tree 868c89f3f74f3771a336bca4c9abcbc75e61105c
parent 61a3c6966158dfd9b1279c10ea8eeb3bc7acdef4
author Michael Ellerman <michael@ellerman.id.au> 1125538139 +1000
committer Jeff Garzik <jgarzik@pobox.com> 1125542276 -0400

[PATCH] iseries_veth: Remove a FIXME WRT deletion of the ack_timer

The iseries_veth driver has a timer which we use to send acks. When the
connection is reset or stopped we need to delete the timer.

Currently we only call del_timer() when resetting a connection, which means
the timer might run again while the connection is being re-setup. As it turns
out that's ok, because the flags the timer consults have been reset.

It's cleaner though to call del_timer_sync() once we've dropped the lock,
although the timer may still run between us dropping the lock and calling
del_timer_sync(), but as above that's ok.

Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>