tree 9bb749909370ec732ed730ca80553908913156af
parent df8ec2490fed5dd23316bbb2c2e90e59e7d37126
author Stefan Richter <stefanr@s5r6.in-berlin.de> 1188043699 +0200
committer Stefan Richter <stefanr@s5r6.in-berlin.de> 1192572005 +0200

firewire: fw-ohci: enforce read order for selfID generation

It seems unlikely, but access to self_id_cpu[0] could at least in theory
be deferred until after the loop over self_id_cpu[1..n] or even after
the subsequent reg_read.  Enforce the desired order by a read barrier.

Also prevent the reg_read from being reordered relative to the for loop.
This isn't necessary if the loop's conditional printk counts as an
implicit barrier, but better make it explicit.

(self_id_cpu[] is a coherent DMA buffer.)

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>