commit f68c53015c5b9aa98ffd87a34009f89bdbbd7160
author Changli Gao <xiaosuo@gmail.com> Mon Oct 04 22:24:12 2010 +0200
committer Patrick McHardy <kaber@trash.net> Mon Oct 04 22:24:12 2010 +0200
tree 93c420dc5f5643125d1bad05398faceeade47416
parent e55df53dd62c73185af46fb6ffa7074b05ceefc4

netfilter: unregister nf hooks, matches and targets in the reverse order

Since we register nf hooks, matches and targets in order, we'd better
unregister them in the reverse order.

Signed-off-by: Changli Gao <xiaosuo@gmail.com>
Signed-off-by: Patrick McHardy <kaber@trash.net>

net/netfilter/core.c

diff --git a/net/netfilter/core.c b/net/netfilter/core.c
index 78b505d..8f014f2 100644
--- a/net/netfilter/core.c
+++ b/net/netfilter/core.c
@@ -105,10 +105,8 @@
 
 void nf_unregister_hooks(struct nf_hook_ops *reg, unsigned int n)
 {
-	unsigned int i;
-
-	for (i = 0; i < n; i++)
-		nf_unregister_hook(&reg[i]);
+	while (n-- > 0)
+		nf_unregister_hook(&reg[n]);
 }
 EXPORT_SYMBOL(nf_unregister_hooks);