tree 8935acfe89c87fe63f72bb114fa17f97f7c26564
parent 1e6c4dfdeb040b2dd5c4d6d803ab95c3971ad80c
author Miklos Szeredi <mszeredi@suse.cz> 1326387586 +0100
committer Linus Torvalds <torvalds@linux-foundation.org> 1326592902 -0800

fsnotify: don't BUG in fsnotify_destroy_mark()

Removing the parent of a watched file results in "kernel BUG at
fs/notify/mark.c:139".

To reproduce

  add "-w /tmp/audit/dir/watched_file" to audit.rules
  rm -rf /tmp/audit/dir

This is caused by fsnotify_destroy_mark() being called without an
extra reference taken by the caller.

Reported by Francesco Cosoleto here:

  https://bugzilla.novell.com/show_bug.cgi?id=689860

Fix by removing the BUG_ON and adding a comment about not accessing mark after
the iput.

Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
CC: stable@vger.kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>