commit 81f79a6672a0bd610f05770d8c96e03e276798da
author Dragos Sbirlea <dragoss@google.com> Tue Jul 23 14:31:47 2013 -0700
committer Dragos Sbirlea <dragoss@google.com> Tue Jul 23 22:48:32 2013 +0000
tree 1b9c9c3d60a528293d822b33bb9d3008913c0218
parent 35275ec4cfe0ebfc247d13c2c96d27c10dc804f9

Refactored string to int conversion.

I was using stringstream for int to std::string, but the StringPrintf
utility is shorter and cleaner.

Change-Id: I454488602459071abb8b846ff7ac8b9594e9d824

compiler/sea_ir/sea.cc

diff --git a/compiler/sea_ir/sea.cc b/compiler/sea_ir/sea.cc
index 347fcff..ae0cb17 100644
--- a/compiler/sea_ir/sea.cc
+++ b/compiler/sea_ir/sea.cc
@@ -13,7 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-
+#include "runtime/base/stringprintf.h"
 #include "file_output_stream.h"
 #include "instruction_tools.h"
 #include "sea.h"
@@ -492,9 +492,7 @@
 
 void Region::ToDot(std::string& result) const {
   result += "\n// Region: \n" + StringId() + " [label=\"region " + StringId() + "(rpo=";
-  std::stringstream ss;
-  ss << rpo_;
-  result.append(ss.str());
+  result += art::StringPrintf("%", rpo_number_);
   if (NULL != GetIDominator()) {
     result += " dom=" + GetIDominator()->StringId();
   }
@@ -712,9 +710,7 @@
       def_it != definition_edges_.end(); def_it++) {
     if (NULL != def_it->second) {
       result += def_it->second->StringId() + " -> " + StringId() +"[color=red,label=\"";
-      std::stringstream ss;
-      ss << def_it->first;
-      result.append(ss.str());
+      result.append(art::StringPrintf("%", def_it->first));
       result += "\"] ; // ssa edge\n";
     }
   }
@@ -763,9 +759,7 @@
 void PhiInstructionNode::ToDot(std::string& result) const {
   result += "// PhiInstruction: \n" + StringId() +
       " [label=\"" + "PHI(";
-  std::stringstream phi_reg_stream;
-  phi_reg_stream << register_no_;
-  result.append(phi_reg_stream.str());
+  result += art::StringPrintf("%d", register_no_);
   result += ")\"";
   result += "];\n";
 
@@ -775,9 +769,7 @@
     for (std::vector<InstructionNode* >::const_iterator def_it = defs_from_pred->begin();
         def_it != defs_from_pred->end(); def_it++) {
         result += (*def_it)->StringId() + " -> " + StringId() +"[color=red,label=\"vR = ";
-        std::stringstream ss;
-        ss << GetRegisterNumber();
-        result.append(ss.str());
+        result += StringPrintf("%d", GetRegisterNumber());
         result += "\"] ; // phi-ssa edge\n";
     }
   }