commit 16e185c9081530859c17270fbaf5798f0ea871f8
author Christopher Ferris <cferris@google.com> Tue Sep 10 16:56:34 2013 -0700
committer Christopher Ferris <cferris@google.com> Fri Sep 20 20:12:09 2013 -0700
tree 610f608fea65670da8650a1d93585321972526db
parent ad999b6062909d4922fb360a6f3b7f412cc06111

__memcpy_chk: Fix signed cmp of unsigned values.

I accidentally did a signed comparison of the size_t values passed in
for three of the _chk functions. Changing them to unsigned compares.

Add three new tests to verify this failure is fixed.

Bug: 10691831

Merge from internal master.

(cherry-picked from 883ef2499c2ff76605f73b1240f719ca6282e554)

Change-Id: Id9a96b549435f5d9b61dc132cf1082e0e30889f5

libc/arch-arm/krait/bionic/__strcat_chk.S

diff --git a/libc/arch-arm/krait/bionic/__strcat_chk.S b/libc/arch-arm/krait/bionic/__strcat_chk.S
index ec99077..956b461 100644
--- a/libc/arch-arm/krait/bionic/__strcat_chk.S
+++ b/libc/arch-arm/krait/bionic/__strcat_chk.S
@@ -180,7 +180,7 @@
 .L_strlen_done:
     add     r2, r3, r4
     cmp     r2, lr
-    bgt     __strcat_chk_failed
+    bhi     __strcat_chk_failed
 
     // Set up the registers for the memcpy code.
     mov     r1, r5