CTS tests for input truncation/padding of NONEwithECDSA.
Bug: 22030217
Change-Id: I5adc7eeb9cede71faee799da70b125806bfb15ac
diff --git a/tests/tests/keystore/src/android/keystore/cts/ECDSASignatureTest.java b/tests/tests/keystore/src/android/keystore/cts/ECDSASignatureTest.java
new file mode 100644
index 0000000..2330209
--- /dev/null
+++ b/tests/tests/keystore/src/android/keystore/cts/ECDSASignatureTest.java
@@ -0,0 +1,119 @@
+/*
+ * Copyright (C) 2015 The Android Open Source Project
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package android.keystore.cts;
+
+import android.security.keystore.KeyGenParameterSpec;
+import android.security.keystore.KeyProperties;
+
+import junit.framework.TestCase;
+
+import java.security.KeyPair;
+import java.security.KeyPairGenerator;
+import java.security.Security;
+import java.security.Signature;
+
+public class ECDSASignatureTest extends TestCase {
+
+ public void testNONEwithECDSATruncatesInputToFieldSize() throws Exception {
+ assertNONEwithECDSATruncatesInputToFieldSize(224);
+ assertNONEwithECDSATruncatesInputToFieldSize(256);
+ assertNONEwithECDSATruncatesInputToFieldSize(384);
+ assertNONEwithECDSATruncatesInputToFieldSize(521);
+ }
+
+ private void assertNONEwithECDSATruncatesInputToFieldSize(int keySizeBits) throws Exception {
+ byte[] message = new byte[(keySizeBits * 3) / 8];
+ for (int i = 0; i < message.length; i++) {
+ message[i] = (byte) (i + 1);
+ }
+ KeyPairGenerator generator = KeyPairGenerator.getInstance("EC", "AndroidKeyStore");
+ generator.initialize(new KeyGenParameterSpec.Builder(
+ "test1",
+ KeyProperties.PURPOSE_SIGN)
+ .setDigests(KeyProperties.DIGEST_NONE)
+ .setKeySize(keySizeBits)
+ .build());
+ KeyPair keyPair = generator.generateKeyPair();
+
+ Signature signature = Signature.getInstance("NONEwithECDSA");
+ signature.initSign(keyPair.getPrivate());
+ assertSame(Security.getProvider(SignatureTest.EXPECTED_PROVIDER_NAME),
+ signature.getProvider());
+ signature.update(message);
+ byte[] sigBytes = signature.sign();
+
+ signature = Signature.getInstance(signature.getAlgorithm(), signature.getProvider());
+ signature.initVerify(keyPair.getPublic());
+
+ // Verify the full-length message
+ signature.update(message);
+ assertTrue(signature.verify(sigBytes));
+
+ // Verify the message truncated to field size
+ signature.update(message, 0, (keySizeBits + 7) / 8);
+ assertTrue(signature.verify(sigBytes));
+
+ // Verify message truncated to one byte shorter than field size -- this should fail
+ signature.update(message, 0, (keySizeBits / 8) - 1);
+ assertFalse(signature.verify(sigBytes));
+ }
+
+ public void testNONEwithECDSASupportsMessagesShorterThanFieldSize() throws Exception {
+ assertNONEwithECDSASupportsMessagesShorterThanFieldSize(224);
+ assertNONEwithECDSASupportsMessagesShorterThanFieldSize(256);
+ assertNONEwithECDSASupportsMessagesShorterThanFieldSize(384);
+ assertNONEwithECDSASupportsMessagesShorterThanFieldSize(521);
+ }
+
+ private void assertNONEwithECDSASupportsMessagesShorterThanFieldSize(
+ int keySizeBits) throws Exception {
+ byte[] message = new byte[(keySizeBits * 3 / 4) / 8];
+ for (int i = 0; i < message.length; i++) {
+ message[i] = (byte) (i + 1);
+ }
+ KeyPairGenerator generator = KeyPairGenerator.getInstance("EC", "AndroidKeyStore");
+ generator.initialize(new KeyGenParameterSpec.Builder(
+ "test1",
+ KeyProperties.PURPOSE_SIGN)
+ .setDigests(KeyProperties.DIGEST_NONE)
+ .setKeySize(keySizeBits)
+ .build());
+ KeyPair keyPair = generator.generateKeyPair();
+
+ Signature signature = Signature.getInstance("NONEwithECDSA");
+ signature.initSign(keyPair.getPrivate());
+ assertSame(Security.getProvider(SignatureTest.EXPECTED_PROVIDER_NAME),
+ signature.getProvider());
+ signature.update(message);
+ byte[] sigBytes = signature.sign();
+
+ signature = Signature.getInstance(signature.getAlgorithm(), signature.getProvider());
+ signature.initVerify(keyPair.getPublic());
+
+ // Verify the message
+ signature.update(message);
+ assertTrue(signature.verify(sigBytes));
+
+ // Assert that the message is left-padded with zero bits
+ byte[] fullLengthMessage = new byte[keySizeBits / 8];
+ System.arraycopy(message, 0,
+ fullLengthMessage, fullLengthMessage.length - message.length,
+ message.length);
+ signature.update(fullLengthMessage);
+ assertTrue(signature.verify(sigBytes));
+ }
+}
diff --git a/tests/tests/keystore/src/android/keystore/cts/SignatureTest.java b/tests/tests/keystore/src/android/keystore/cts/SignatureTest.java
index 34d8b1b..9e8678b 100644
--- a/tests/tests/keystore/src/android/keystore/cts/SignatureTest.java
+++ b/tests/tests/keystore/src/android/keystore/cts/SignatureTest.java
@@ -43,7 +43,7 @@
import android.test.MoreAsserts;
public class SignatureTest extends AndroidTestCase {
- private static final String EXPECTED_PROVIDER_NAME = "AndroidKeyStoreBCWorkaround";
+ static final String EXPECTED_PROVIDER_NAME = "AndroidKeyStoreBCWorkaround";
private static final String[] EXPECTED_SIGNATURE_ALGORITHMS = {
"NONEwithRSA",
@@ -209,6 +209,9 @@
new TreeMap<String, byte[]>(String.CASE_INSENSITIVE_ORDER);
static {
// From RI
+ LONG_MSG_KAT_SIGNATURES.put("NONEwithECDSA", HexEncoding.decode(
+ "304502206e4039608a66ce118821eeca3e2af7f530f51d1ce8089685a13f49010e3cd58b02210083a5"
+ + "fe62a171f1b1d775fad712128a223d6b63336e0248783652474221cb3193"));
LONG_MSG_KAT_SIGNATURES.put("SHA1withECDSA", HexEncoding.decode(
"3044022075f09bb5c87d883c088ca2ad263bbe1754ab614f727465bc43695d3521eaccf80220460e4e"
+ "32421e6f4398cd9b7fbb31a1d1f2961f26b9783620f6413f0e6f7efb84"));
@@ -509,7 +512,7 @@
KeyPair keyPair = getKeyPairForSignatureAlgorithm(algorithm, keyPairs);
try {
- if (algorithm.toLowerCase(Locale.US).startsWith("nonewith")) {
+ if (algorithm.toLowerCase(Locale.US).startsWith("nonewithrsa")) {
// This algorithm cannot accept large messages
Signature signature = Signature.getInstance(algorithm);
signature.initSign(keyPair.getPrivate());