commit 5867bea193779ff3009738513bae9bc84f4a34aa
author buzbee <buzbee@google.com> Sat Apr 09 14:47:32 2011 -0700
committer buzbee <buzbee@google.com> Mon Apr 11 13:39:35 2011 -0700
tree 181b845efba8de8ece9d878b69f86de51c241381
parent 8d6291cce6ff3c9a3010f3725563983847370df7

[JIT] Close code cache race window

See http://b/issue?id=4271784 for details.

Three fixes:
   1.  Verify the code cache version hasn't changed between completion
       of the translation and registering it in JitTable
   2.  When code cache full detected during translating a trace, mark
       the "discard" flag on the work order.
   3.  [The actual cause of the bug] When doing a code cache flush,
       traverse the thread least and cancel any trace selections in
       progress.

Change-Id: Ifea70416d7d91637fb742fc8de11044a89358caa

vm/compiler/codegen/arm/Assemble.c

diff --git a/vm/compiler/codegen/arm/Assemble.c b/vm/compiler/codegen/arm/Assemble.c
index 4f2c10a..83fec33 100644
--- a/vm/compiler/codegen/arm/Assemble.c
+++ b/vm/compiler/codegen/arm/Assemble.c
@@ -1426,7 +1426,7 @@
 
     if (gDvmJit.codeCacheByteUsed + cUnit->totalSize > gDvmJit.codeCacheSize) {
         gDvmJit.codeCacheFull = true;
-        cUnit->baseAddr = NULL;
+        info->discardResult = true;
         return;
     }
 
@@ -1434,7 +1434,7 @@
     cUnit->codeBuffer = (unsigned char *)dvmCompilerNew(chainCellOffset, true);
     if (cUnit->codeBuffer == NULL) {
         LOGE("Code buffer allocation failure\n");
-        cUnit->baseAddr = NULL;
+        info->discardResult = true;
         return;
     }