commit fe6087708cdeafecf223dd1d2d5e6606db70a4e1
author Carl Shapiro <cshapiro@google.com> Wed Jul 28 19:33:46 2010 -0700
committer Carl Shapiro <cshapiro@google.com> Wed Jul 28 19:33:51 2010 -0700
tree 64e21f0df3fcd6ddfd798055c7b588e2a0cacbdc
parent 4d9c8498873e04e7caf9dc05024727a50643602a

Fix a crash during VM shutdown.

The code to shutdown the GC daemon thread was not checking to see if
the GC daemon thread had been initialized.  This caused pthread_join
to crash waiting for an uninitialized thread object.

Change-Id: Iac338a054775aa024d74fbb4a5de35e12d95b862

vm/alloc/HeapSource.c

diff --git a/vm/alloc/HeapSource.c b/vm/alloc/HeapSource.c
index 62c0740..c86994f 100644
--- a/vm/alloc/HeapSource.c
+++ b/vm/alloc/HeapSource.c
@@ -450,7 +450,7 @@
 
 static void gcDaemonShutdown(void)
 {
-    if (gDvm.concurrentMarkSweep) {
+    if (gHs->hasGcThread) {
         dvmLockMutex(&gHs->gcThreadMutex);
         gHs->gcThreadShutdown = true;
         dvmSignalCond(&gHs->gcThreadCond);
@@ -588,7 +588,7 @@
 
 void dvmHeapSourceThreadShutdown(void)
 {
-    if (gDvm.gcHeap != NULL) {
+    if (gDvm.gcHeap != NULL && gDvm.concurrentMarkSweep) {
         gcDaemonShutdown();
     }
 }