use xmalloc, dont hardcode length of string, and get rid of pointless call to memset
diff --git a/miscutils/less.c b/miscutils/less.c
index 6b0cab5..eba916a 100644
--- a/miscutils/less.c
+++ b/miscutils/less.c
@@ -625,12 +625,11 @@
insert_highlights, and then the line is returned. */
int match_status;
- char *line2 = (char *) malloc((sizeof(char) * (strlen(line) + 1)) + 64);
+ char *line2 = (char *) xmalloc((sizeof(char) * (strlen(line) + 1)) + 64);
char sub_line[256];
int prev_eo = 0;
regmatch_t match_structs;
- memset(sub_line, 0, 256);
strcpy(line2, line);
match_found = 0;
@@ -638,7 +637,7 @@
while (match_status == 0) {
- memset(sub_line, 0, 256);
+ memset(sub_line, 0, sizeof(sub_line));
if (match_found == 0)
match_found = 1;