commit dcd27abcc4471ac04d7f196905907eb9a28bf0d8
author Denys Vlasenko <vda.linux@googlemail.com> Mon Oct 05 03:03:07 2009 +0200
committer Denys Vlasenko <vda.linux@googlemail.com> Mon Oct 05 03:03:07 2009 +0200
tree 24ed60e8325dcfccc99b36b5cab663cd693f29bf
parent be168b119750beacc0d0212607c6fa3ee87f238c

unpackers: check errors from close() too

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

archival/bbunzip.c

diff --git a/archival/bbunzip.c b/archival/bbunzip.c
index d25f509..d6625e4 100644
--- a/archival/bbunzip.c
+++ b/archival/bbunzip.c
@@ -98,6 +98,7 @@
 		status = unpacker(&info);
 		if (status < 0)
 			exitcode = 1;
+		xclose(STDOUT_FILENO); /* with error check! */
 
 		if (filename) {
 			char *del = new_name;
@@ -108,12 +109,11 @@
 
 					times.actime = info.mtime;
 					times.modtime = info.mtime;
-					/* Close first.
+					/* Note: we closed it first.
 					 * On some systems calling utime
-					 * then closing resets the mtime. */
-					close(STDOUT_FILENO);
-					/* Ignoring errors */
-					utime(new_name, &times);
+					 * then closing resets the mtime
+					 * back to current time. */
+					utime(new_name, &times); /* ignoring errors */
 				}
 
 				/* Delete _compressed_ file */