| commit | 51f3866995bfb5af75a9a06465ba30909b6e1c4b | [log] [tgz] |
|---|---|---|
| author | reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> | Wed Jun 27 14:24:29 2012 +0000 |
| committer | reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> | Wed Jun 27 14:24:29 2012 +0000 |
| tree | 9535d75471a3e4b2efbdfd109372b155c674e3b6 | |
| parent | 0456e0b7b85060e9b9597ce414c4c2b19aff4f58 [diff] [blame] |
fix leak of Light object (in this private instance, the caller is transferring ownership of the object, so the receive does not need to call ref). Review URL: https://codereview.appspot.com/6348045 git-svn-id: http://skia.googlecode.com/svn/trunk@4360 2bbb7eff-a529-9590-31e7-b0007b416f81
diff --git a/src/effects/SkLightingImageFilter.cpp b/src/effects/SkLightingImageFilter.cpp index 25c92b7..c4a6896 100644 --- a/src/effects/SkLightingImageFilter.cpp +++ b/src/effects/SkLightingImageFilter.cpp
@@ -430,7 +430,8 @@ fSurfaceScale(SkScalarDiv(surfaceScale, SkIntToScalar(255))) { SkASSERT(fLight); - fLight->ref(); + // our caller knows that we take ownership of the light, so we don't + // need to call ref() here. } SkImageFilter* SkLightingImageFilter::CreateDistantLitDiffuse(