commit c6157be6c0ccd56d3eeb2601e6f1ca2fa403a543
author fmalita@google.com <fmalita@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> Thu Sep 27 13:09:58 2012 +0000
committer fmalita@google.com <fmalita@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> Thu Sep 27 13:09:58 2012 +0000
tree a34719940f0acc9e83ed996c3aa60234b544581a
parent 44d498812a6fb0c60a8204e6334564fe518fba33

Pinspect and bench_pictures are crashing when invoked with no arguments.

R=reed@google.com,scroggo@google.com
BUG=

Review URL: https://codereview.appspot.com/6575052

git-svn-id: http://skia.googlecode.com/svn/trunk@5706 2bbb7eff-a529-9590-31e7-b0007b416f81

tools/bench_pictures_main.cpp

diff --git a/tools/bench_pictures_main.cpp b/tools/bench_pictures_main.cpp
index 359240e..7c313cf 100644
--- a/tools/bench_pictures_main.cpp
+++ b/tools/bench_pictures_main.cpp
@@ -402,7 +402,7 @@
         renderer = SkNEW(sk_tools::PipePictureRenderer);
     }
     if (inputs->count() < 1) {
-        SkDELETE(benchmark);
+        SkSafeUnref(renderer);
         usage(argv0);
         exit(-1);
     }

tools/pinspect.cpp

diff --git a/tools/pinspect.cpp b/tools/pinspect.cpp
index cec2013..975eda5 100644
--- a/tools/pinspect.cpp
+++ b/tools/pinspect.cpp
@@ -46,7 +46,8 @@
 
 int main(int argc, char* const argv[]) {
     if (argc < 2) {
-        printf("Usage: pinspect [--dump_ops] filename [filename ...]\n");
+        printf("Usage: pinspect [--dump-ops] filename [filename ...]\n");
+        return 1;
     }
 
     bool doDumpOps = false;