commit dee54be428017a81f13519291a03baac11d61602
author reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> Mon Dec 10 17:39:36 2012 +0000
committer reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> Mon Dec 10 17:39:36 2012 +0000
tree 82ad8dd8de1099624d9dfbe71e53c4ae49e9835e
parent 7f805fff69e38114c2cb214d3482514ab37d430b

optimize for paints that don't require deep copy during clone
Review URL: https://codereview.appspot.com/6903062

git-svn-id: http://skia.googlecode.com/svn/trunk@6739 2bbb7eff-a529-9590-31e7-b0007b416f81

src/core/SkPicturePlayback.cpp

diff --git a/src/core/SkPicturePlayback.cpp b/src/core/SkPicturePlayback.cpp
index a337264..3024c22 100644
--- a/src/core/SkPicturePlayback.cpp
+++ b/src/core/SkPicturePlayback.cpp
@@ -146,6 +146,24 @@
 #endif
 }
 
+static bool needs_deep_copy(const SkPaint& paint) {
+    /*
+     *  These fields are known to be immutable, and so can be shallow-copied
+     *
+     *  getTypeface();
+     *  getAnnotation();
+     */
+
+    return paint.getPathEffect() ||
+           paint.getShader() ||
+           paint.getXfermode() ||
+           paint.getMaskFilter() ||
+           paint.getColorFilter() ||
+           paint.getRasterizer() ||
+           paint.getLooper() ||
+           paint.getImageFilter();
+}
+
 SkPicturePlayback::SkPicturePlayback(const SkPicturePlayback& src, SkPictCopyInfo* deepCopyInfo) {
     this->init();
 
@@ -178,9 +196,14 @@
 
             SkDEBUGCODE(int heapSize = SafeCount(fBitmapHeap.get());)
             for (int i = 0; i < src.fPaints->count(); i++) {
-                deepCopyInfo->paintData[i] = SkFlatData::Create(&deepCopyInfo->controller,
-                                                                &src.fPaints->at(i), 0,
-                                                                &SkFlattenObjectProc<SkPaint>);
+                if (needs_deep_copy(src.fPaints->at(i))) {
+                    deepCopyInfo->paintData[i] = SkFlatData::Create(&deepCopyInfo->controller,
+                                                                    &src.fPaints->at(i), 0,
+                                                                    &SkFlattenObjectProc<SkPaint>);
+                } else {
+                    // this is our sentinel, which we use in the unflatten loop
+                    deepCopyInfo->paintData[i] = NULL;
+                }
             }
             SkASSERT(SafeCount(fBitmapHeap.get()) == heapSize);
 
@@ -191,11 +214,17 @@
 
         fPaints = SkTRefArray<SkPaint>::Create(src.fPaints->count());
         SkASSERT(deepCopyInfo->paintData.count() == src.fPaints->count());
+        SkBitmapHeap* bmHeap = deepCopyInfo->controller.getBitmapHeap();
+        SkTypefacePlayback* tfPlayback = deepCopyInfo->controller.getTypefacePlayback();
         for (int i = 0; i < src.fPaints->count(); i++) {
-            deepCopyInfo->paintData[i]->unflatten(&fPaints->writableAt(i),
-                                                  &SkUnflattenObjectProc<SkPaint>,
-                                                  deepCopyInfo->controller.getBitmapHeap(),
-                                                  deepCopyInfo->controller.getTypefacePlayback());
+            if (deepCopyInfo->paintData[i]) {
+                deepCopyInfo->paintData[i]->unflatten(&fPaints->writableAt(i),
+                                                      &SkUnflattenObjectProc<SkPaint>,
+                                                      bmHeap, tfPlayback);
+            } else {
+                // needs_deep_copy was false, so just need to assign
+                fPaints->writableAt(i) = src.fPaints->at(i);
+            }
         }
 
     } else {