commit 0464fd5e4ce2193e786e5adcab6b828f9366dae3
author Michael J. Spencer <bigcheesegs@gmail.com> Wed Oct 10 21:48:26 2012 +0000
committer Michael J. Spencer <bigcheesegs@gmail.com> Wed Oct 10 21:48:26 2012 +0000
tree 72b476462a53dc48deb42a48fc89285a11e28517
parent cf9030e480f77ab349672f00ad302e216c26c92c

[Options] make Option a value type.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@165663 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Driver/Option.cpp

diff --git a/lib/Driver/Option.cpp b/lib/Driver/Option.cpp
index 117021b..a250d87 100644
--- a/lib/Driver/Option.cpp
+++ b/lib/Driver/Option.cpp
@@ -23,7 +23,8 @@
   // Multi-level aliases are not supported, and alias options cannot
   // have groups. This just simplifies option tracking, it is not an
   // inherent limitation.
-  assert((!getAlias() || (!getAlias()->getAlias() && !getGroup())) &&
+  assert((!getAlias().isValid() || (!getAlias().getAlias().isValid() &&
+         !getGroup().isValid())) &&
          "Multi-level aliases and aliases with groups are unsupported.");
 }
 
@@ -49,16 +50,16 @@
 
   llvm::errs() << " Name:\"" << getName() << '"';
 
-  const Option *Group = getGroup();
-  if (Group) {
+  const Option Group = getGroup();
+  if (Group.isValid()) {
     llvm::errs() << " Group:";
-    Group->dump();
+    Group.dump();
   }
 
-  const Option *Alias = getAlias();
-  if (Alias) {
+  const Option Alias = getAlias();
+  if (Alias.isValid()) {
     llvm::errs() << " Alias:";
-    Alias->dump();
+    Alias.dump();
   }
 
   if (getKind() == MultiArgClass)
@@ -69,17 +70,17 @@
 
 bool Option::matches(OptSpecifier Opt) const {
   // Aliases are never considered in matching, look through them.
-  const Option *Alias = getAlias();
-  if (Alias)
-    return Alias->matches(Opt);
+  const Option Alias = getAlias();
+  if (Alias.isValid())
+    return Alias.matches(Opt);
 
   // Check exact match.
   if (getID() == Opt.getID())
     return true;
 
-  const Option *Group = getGroup();
-  if (Group)
-    return Group->matches(Opt);
+  const Option Group = getGroup();
+  if (Group.isValid())
+    return Group.matches(Opt);
   return false;
 }
 
@@ -155,7 +156,7 @@
     // FIXME: Avoid strlen.
     if (getName().size() != strlen(Args.getArgString(Index))) {
       const char *Value = Args.getArgString(Index) + getName().size();
-      return new Arg(this, Index++, Value);
+      return new Arg(*this, Index++, Value);
     }
 
     // Otherwise it must be separate.