commit 07d161f38e708a91486bf1c031d525faebbb249d
author Ted Kremenek <kremenek@apple.com> Fri Jan 29 01:50:07 2010 +0000
committer Ted Kremenek <kremenek@apple.com> Fri Jan 29 01:50:07 2010 +0000
tree ef918b10d12ac36d3f7b1132d8f97b5369b24f4c
parent 80cd64a8450d8e2c079dc134d9711cd45ba89d63

Alternate format string checking: check for excess data arguments.


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@94787 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Sema/SemaChecking.cpp

diff --git a/lib/Sema/SemaChecking.cpp b/lib/Sema/SemaChecking.cpp
index 81c309b..3cd45a2 100644
--- a/lib/Sema/SemaChecking.cpp
+++ b/lib/Sema/SemaChecking.cpp
@@ -1304,6 +1304,8 @@
       IsObjCLiteral(isObjCLiteral), Beg(beg),
       HasVAListArg(hasVAListArg),
       TheCall(theCall), FormatIdx(formatIdx) {}
+  
+  void DoneProcessing();
     
   void HandleNullChar(const char *nullCharacter);
   
@@ -1434,6 +1436,14 @@
   return true;
 }
 
+void CheckPrintfHandler::DoneProcessing() {
+  // Does the number of data arguments exceed the number of
+  // format conversions in the format string?
+  if (!HasVAListArg && NumConversions < NumDataArgs)
+    S.Diag(getDataArg(NumConversions+1)->getLocStart(),
+           diag::warn_printf_too_many_data_args)
+      << getFormatRange();
+}
 
 void
 Sema::AlternateCheckPrintfString(const StringLiteral *FExpr,
@@ -1467,6 +1477,7 @@
                        HasVAListArg, TheCall, format_idx);
 
   analyze_printf::ParseFormatString(H, Str, Str + StrLen);
+  H.DoneProcessing();
 }
 
 //===--- CHECK: Return Address of Stack Variable --------------------------===//