Added support for additional format string checking for the printf
family of functions. Previous functionality only included checking to
see if the format string was a string literal. Now we check parse the
format string (if it is a literal) and perform the following checks:
(1) Warn if: number conversions (e.g. "%d") != number data arguments.
(2) Warn about missing format strings (e.g., "printf()").
(3) Warn if the format string is not a string literal.
(4) Warn about the use se of '%n' conversion. This conversion is
discouraged for security reasons.
(5) Warn about malformed conversions. For example '%;', '%v'; these
are not valid.
(6) Warn about empty format strings; e.g. printf(""). Although these
can be optimized away by the compiler, they can be indicative of
broken programmer logic. We may need to add additional support to
see when such cases occur within macro expansion to avoid false
positives.
(7) Warn if the string literal is wide; e.g. L"%d".
(8) Warn if we detect a '\0' character WITHIN the format string.
Test cases are included.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@41076 91177308-0d34-0410-b5e6-96231b3b80d8
diff --git a/Sema/Sema.h b/Sema/Sema.h
index d373cc0..22fffc7 100644
--- a/Sema/Sema.h
+++ b/Sema/Sema.h
@@ -423,10 +423,14 @@
// Extra semantic analysis beyond the C type system
private:
- void CheckFunctionCall(Expr *Fn, FunctionDecl *FDecl,
+ void CheckFunctionCall(Expr *Fn,
+ SourceLocation LParenLoc, SourceLocation RParenLoc,
+ FunctionDecl *FDecl,
Expr** Args, unsigned NumArgsInCall);
- void CheckPrintfArguments(Expr *Fn, unsigned id_idx, FunctionDecl *FDecl,
+ void CheckPrintfArguments(Expr *Fn,
+ SourceLocation LParenLoc, SourceLocation RParenLoc,
+ bool HasVAListArg, FunctionDecl *FDecl,
unsigned format_idx, Expr** Args,
unsigned NumArgsInCall);
};