commit 10708c4a89241a923522897dddaa42b8a67501aa
author Daniel Dunbar <daniel@zuster.org> Sat May 23 18:55:58 2009 +0000
committer Daniel Dunbar <daniel@zuster.org> Sat May 23 18:55:58 2009 +0000
tree 8737dacd1d330c1013550ba2aa358a9dce68a377
parent 37530fc3809332be8c862a8ed1a467b431d0f168

Fix use after free, found by Benjamin Kramer.


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@72333 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Driver/HostInfo.cpp

diff --git a/lib/Driver/HostInfo.cpp b/lib/Driver/HostInfo.cpp
index fc6b87f..f60d25e 100644
--- a/lib/Driver/HostInfo.cpp
+++ b/lib/Driver/HostInfo.cpp
@@ -79,12 +79,12 @@
 
   assert(memcmp(&getOSName()[0], "darwin", 6) == 0 &&
          "Unknown Darwin platform.");
-  const char *Release = &getOSName()[6];
   bool HadExtra;
-  if (!Driver::GetReleaseVersion(Release, DarwinVersion[0], DarwinVersion[1], 
+  if (!Driver::GetReleaseVersion(&getOSName()[6], 
+                                 DarwinVersion[0], DarwinVersion[1], 
                                  DarwinVersion[2], HadExtra)) {
     D.Diag(clang::diag::err_drv_invalid_darwin_version)
-      << Release;
+      << getOSName();
   }
   
   // We can only call 4.2.1 for now.