Assume statement expressions have side effects; this gets rid of a lot
of extra warnings in the Python source.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@51594 91177308-0d34-0410-b5e6-96231b3b80d8
diff --git a/lib/AST/Expr.cpp b/lib/AST/Expr.cpp
index e21686c..d26ad10 100644
--- a/lib/AST/Expr.cpp
+++ b/lib/AST/Expr.cpp
@@ -319,14 +319,17 @@
// If the base pointer or element is to a volatile pointer/field, accessing
// if is a side effect.
return getType().isVolatileQualified();
-
+
case CallExprClass:
// TODO: check attributes for pure/const. "void foo() { strlen("bar"); }"
// should warn.
return true;
case ObjCMessageExprClass:
return true;
-
+ case StmtExprClass:
+ // TODO: check the inside of the statement expression
+ return true;
+
case CastExprClass:
// If this is a cast to void, check the operand. Otherwise, the result of
// the cast is unused.