commit 2287cee1857a6aabb3daf1c79d0b703d1dee9640
author Ted Kremenek <kremenek@apple.com> Wed Apr 16 04:30:16 2008 +0000
committer Ted Kremenek <kremenek@apple.com> Wed Apr 16 04:30:16 2008 +0000
tree 1480d4fff90a9e76ae88039b99c03a067b2abc89
parent 88d057533a8a904ef455ef2f0f88447e587e41ff

Remove uses of "Selector&" and "const Selector&", since Selector is just an
immutable smart pointer (we don't need to pass references, just pass Selector).


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@49773 91177308-0d34-0410-b5e6-96231b3b80d8

include/clang/AST/Expr.h

diff --git a/include/clang/AST/Expr.h b/include/clang/AST/Expr.h
index 2cc32a1..469bf3c 100644
--- a/include/clang/AST/Expr.h
+++ b/include/clang/AST/Expr.h
@@ -1393,8 +1393,7 @@
   : Expr(ObjCSelectorExprClass, T), SelName(selInfo), 
   AtLoc(at), RParenLoc(rp) {}
   
-  const Selector &getSelector() const { return SelName; }
-  Selector &getSelector() { return SelName; }
+  Selector getSelector() const { return SelName; }
   
   SourceLocation getAtLoc() const { return AtLoc; }
   SourceLocation getRParenLoc() const { return RParenLoc; }
@@ -1518,7 +1517,6 @@
   Expr *getReceiver() { return SubExprs[RECEIVER]; }
   
   Selector getSelector() const { return SelName; }
-  Selector &getSelector() { return SelName; }
 
   const ObjCMethodDecl *getMethodDecl() const { return MethodProto; }
   ObjCMethodDecl *getMethodDecl() { return MethodProto; }

include/clang/Basic/IdentifierTable.h

diff --git a/include/clang/Basic/IdentifierTable.h b/include/clang/Basic/IdentifierTable.h
index f64fd6f..7c9efc8 100644
--- a/include/clang/Basic/IdentifierTable.h
+++ b/include/clang/Basic/IdentifierTable.h
@@ -231,10 +231,10 @@
     return InfoPtr & ArgFlags;
   }
   /// operator==/!= - Indicate whether the specified selectors are identical.
-  bool operator==(const Selector &RHS) const {
+  bool operator==(Selector RHS) const {
     return InfoPtr == RHS.InfoPtr;
   }
-  bool operator!=(const Selector &RHS) const {
+  bool operator!=(Selector RHS) const {
     return InfoPtr != RHS.InfoPtr;
   }
   void *getAsOpaquePtr() const {

lib/AST/StmtDumper.cpp

diff --git a/lib/AST/StmtDumper.cpp b/lib/AST/StmtDumper.cpp
index 2d4adf8..52eb91e 100644
--- a/lib/AST/StmtDumper.cpp
+++ b/lib/AST/StmtDumper.cpp
@@ -441,7 +441,7 @@
   DumpExpr(Node);
   
   fprintf(F, " ");
-  Selector &selector = Node->getSelector();
+  Selector selector = Node->getSelector();
   fprintf(F, "%s", selector.getName().c_str());
 }
 

lib/AST/StmtPrinter.cpp

diff --git a/lib/AST/StmtPrinter.cpp b/lib/AST/StmtPrinter.cpp
index a76fd1f..2ff7f79 100644
--- a/lib/AST/StmtPrinter.cpp
+++ b/lib/AST/StmtPrinter.cpp
@@ -822,7 +822,7 @@
   Expr *receiver = Mess->getReceiver();
   if (receiver) PrintExpr(receiver);
   else OS << Mess->getClassName()->getName();
-  Selector &selector = Mess->getSelector();
+  Selector selector = Mess->getSelector();
   if (selector.isUnarySelector()) {
     OS << " " << selector.getIdentifierInfoForSlot(0)->getName();
   } else {