commit 2daa5df1b53f7ef745d724771384409f6f5df5c1
author Chris Lattner <sabre@nondot.org> Sun Apr 06 22:04:54 2008 +0000
committer Chris Lattner <sabre@nondot.org> Sun Apr 06 22:04:54 2008 +0000
tree e8511f76731e7179d1aa6f74d092ee8bf73448b6
parent 5edb8bfe8472e7d7bf6a82386394ef27359eb846

Make EnumType/RecordType classof predicates simpler and more efficient in
some cases.


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@49287 91177308-0d34-0410-b5e6-96231b3b80d8

include/clang/AST/Type.h

diff --git a/include/clang/AST/Type.h b/include/clang/AST/Type.h
index b143e4c..4b1f2c6 100644
--- a/include/clang/AST/Type.h
+++ b/include/clang/AST/Type.h
@@ -1020,7 +1020,10 @@
   // the same address space, and return that.
   unsigned getAddressSpace() const { return 0; }
   
-  static bool classof(const Type *T);
+  static bool classof(const TagType *T);
+  static bool classof(const Type *T) {
+    return isa<TagType>(T) && classof(cast<TagType>(T));
+  }
   static bool classof(const RecordType *) { return true; }
 };
 
@@ -1034,7 +1037,10 @@
     return reinterpret_cast<EnumDecl*>(TagType::getDecl());
   }
   
-  static bool classof(const Type *T);
+  static bool classof(const TagType *T);
+  static bool classof(const Type *T) {
+    return isa<TagType>(T) && classof(cast<TagType>(T));
+  }
   static bool classof(const EnumType *) { return true; }
 };
 

lib/AST/Type.cpp

diff --git a/lib/AST/Type.cpp b/lib/AST/Type.cpp
index c06b1d9..c8fb386 100644
--- a/lib/AST/Type.cpp
+++ b/lib/AST/Type.cpp
@@ -739,16 +739,12 @@
   }
 }
 
-bool RecordType::classof(const Type *T) {
-  if (const TagType *TT = dyn_cast<TagType>(T))
-    return isa<RecordDecl>(TT->getDecl());
-  return false;
+bool RecordType::classof(const TagType *TT) {
+  return isa<RecordDecl>(TT->getDecl());
 }
 
-bool EnumType::classof(const Type *T) {
-  if (const TagType *TT = dyn_cast<TagType>(T))
-    return isa<EnumDecl>(TT->getDecl());
-  return false;
+bool EnumType::classof(const TagType *TT) {
+  return isa<EnumDecl>(TT->getDecl());
 }