tighten up some checks, don't allow sending a message to NSString****
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@53836 91177308-0d34-0410-b5e6-96231b3b80d8
diff --git a/lib/Sema/SemaExprObjC.cpp b/lib/Sema/SemaExprObjC.cpp
index 1067d1f..197bf37 100644
--- a/lib/Sema/SemaExprObjC.cpp
+++ b/lib/Sema/SemaExprObjC.cpp
@@ -269,12 +269,13 @@
return true;
}
} else {
- bool receiverIsQualId = isa<ObjCQualifiedIdType>(receiverType);
- // FIXME (snaroff): checking in this code from Patrick. Needs to be
- // revisited. how do we get the ClassDecl from the receiver expression?
- if (!receiverIsQualId)
- while (const PointerType *PTy = receiverType->getAsPointerType())
+ // We allow sending a message to a qualified ID ("id<foo>") to an interface
+ // directly ("[NSNumber foo]") and to a pointer to an interface (an object).
+ if (!isa<ObjCQualifiedIdType>(receiverType) &&
+ !isa<ObjCInterfaceType>(receiverType))
+ if (const PointerType *PTy = receiverType->getAsPointerType())
receiverType = PTy->getPointeeType();
+ // else error, invalid receiver.
ObjCInterfaceDecl* ClassDecl = 0;
if (ObjCQualifiedIdType *QIT =