Bug fix in the transfer function for compound assignments: if the value
of the LHS expressions is Unknown, the value of the entire expression
does not evaluate to the RHS (as is the case with normal assignments).
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@48102 91177308-0d34-0410-b5e6-96231b3b80d8
diff --git a/Analysis/GRExprEngine.cpp b/Analysis/GRExprEngine.cpp
index 95f406b..de6e10c 100644
--- a/Analysis/GRExprEngine.cpp
+++ b/Analysis/GRExprEngine.cpp
@@ -1162,21 +1162,13 @@
}
if (LeftV.isUnknown()) {
-
- // While we do not know the location to store RightV,
- // the entire expression does evaluate to RightV.
-
- if (RightV.isUnknown()) {
- Dst.Add(N2);
- continue;
- }
-
- St = SetRVal(St, B, RightV);
- break;
+ assert (isa<UnknownVal>(GetRVal(St, B)));
+ Dst.Add(N2);
+ continue;
}
// At this pointer we know that the LHS evaluates to an LVal
- // that is neither "Unknown" or "Unintialized."
+ // that is neither "Unknown" or "Undefined."
LVal LeftLV = cast<LVal>(LeftV);
@@ -1196,12 +1188,16 @@
// Propagate unknown values.
if (V.isUnknown()) {
+ // The value bound to LeftV is unknown. Thus we just
+ // propagate the current node (as "B" is already bound to nothing).
+ assert (isa<UnknownVal>(GetRVal(St, B)));
Dst.Add(N2);
continue;
}
if (RightV.isUnknown()) {
- St = SetRVal(SetRVal(St, LeftLV, RightV), B, RightV);
+ assert (isa<UnknownVal>(GetRVal(St, B)));
+ St = SetRVal(St, LeftLV, UnknownVal());
break;
}