Objective-C foreach selector elements must be lvalues.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@55316 91177308-0d34-0410-b5e6-96231b3b80d8
diff --git a/lib/Sema/SemaStmt.cpp b/lib/Sema/SemaStmt.cpp
index 619eb77..629ab34 100644
--- a/lib/Sema/SemaStmt.cpp
+++ b/lib/Sema/SemaStmt.cpp
@@ -562,11 +562,18 @@
return Diag(VD->getLocation(), diag::err_non_variable_decl_in_for);
if (D->getNextDeclarator())
return Diag(D->getLocation(), diag::err_toomany_element_decls);
- } else
- FirstType = static_cast<Expr*>(first)->getType();
+ } else {
+ Expr::isLvalueResult lval = cast<Expr>(First)->isLvalue(Context);
+
+ if (lval != Expr::LV_Valid)
+ return Diag(First->getLocStart(), diag::err_selector_element_not_lvalue,
+ First->getSourceRange());
+
+ FirstType = static_cast<Expr*>(first)->getType();
+ }
if (!Context.isObjCObjectPointerType(FirstType))
Diag(ForLoc, diag::err_selector_element_type,
- FirstType.getAsString(), First->getSourceRange());
+ FirstType.getAsString(), First->getSourceRange());
}
if (Second) {
DefaultFunctionArrayConversion(Second);