commit 8df014e2b173f9c0595f87480d59caaf8979fca3
author Jean-Daniel Dupas <devlists@shadowlab.org> Wed Jul 17 18:17:14 2013 +0000
committer Jean-Daniel Dupas <devlists@shadowlab.org> Wed Jul 17 18:17:14 2013 +0000
tree 3341a7e4d5810db0a0ab4ed3e09103321d082922
parent fd527a4e1a62218285c0ea94dcd53e01b52c48b7

Improve idiomatic-parentheses by checking method family instead of relying on the selector name.



git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@186524 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Sema/SemaExpr.cpp

diff --git a/lib/Sema/SemaExpr.cpp b/lib/Sema/SemaExpr.cpp
index 517afda..0106232 100644
--- a/lib/Sema/SemaExpr.cpp
+++ b/lib/Sema/SemaExpr.cpp
@@ -11968,7 +11968,7 @@
       Selector Sel = ME->getSelector();
 
       // self = [<foo> init...]
-      if (isSelfExpr(Op->getLHS()) && Sel.getNameForSlot(0).startswith("init"))
+      if (isSelfExpr(Op->getLHS()) && ME->getMethodFamily() == OMF_init)
         diagnostic = diag::warn_condition_is_idiomatic_assignment;
 
       // <foo> = [<bar> nextObject]