commit b1d9eb3ed8d41b334f3b790e863140226cb10028
author Ted Kremenek <kremenek@apple.com> Wed Jan 07 22:56:17 2009 +0000
committer Ted Kremenek <kremenek@apple.com> Wed Jan 07 22:56:17 2009 +0000
tree e7014d0821f38837d8ed19bf2082fb07fb571db4
parent 7b61ab7b86a76ef4c7f7550333661ad2aadd88f8

Update some doxygen comments to be more rich.  Remove StoreManager::GetRegionSVal.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@61894 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Analysis/BasicStore.cpp

diff --git a/lib/Analysis/BasicStore.cpp b/lib/Analysis/BasicStore.cpp
index 9e469c0..b223114 100644
--- a/lib/Analysis/BasicStore.cpp
+++ b/lib/Analysis/BasicStore.cpp
@@ -37,7 +37,7 @@
   
   ~BasicStoreManager() {}
 
-  SVal Retrieve(const GRState *state, Loc LV, QualType T);  
+  SVal Retrieve(const GRState *state, Loc loc, QualType T = QualType());  
 
   const GRState* Bind(const GRState* St, Loc L, SVal V) {
     Store store = St->getStore();
@@ -45,8 +45,8 @@
     return StateMgr.MakeStateWithStore(St, store);
   }
 
-  Store BindInternal(Store St, Loc LV, SVal V);  
-  Store Remove(Store St, Loc LV);
+  Store BindInternal(Store St, Loc loc, SVal V);  
+  Store Remove(Store St, Loc loc);
   Store getInitialStore();
 
   // FIXME: Investigate what is using this. This method should be removed.
@@ -263,18 +263,18 @@
     return UnknownVal();
 }
 
-SVal BasicStoreManager::Retrieve(const GRState* state, Loc LV, QualType T) {
+SVal BasicStoreManager::Retrieve(const GRState* state, Loc loc, QualType T) {
   
-  if (isa<UnknownVal>(LV))
+  if (isa<UnknownVal>(loc))
     return UnknownVal();
   
-  assert (!isa<UndefinedVal>(LV));
+  assert (!isa<UndefinedVal>(loc));
   
-  switch (LV.getSubKind()) {
+  switch (loc.getSubKind()) {
 
     case loc::MemRegionKind: {
       const VarRegion* R =
-        dyn_cast<VarRegion>(cast<loc::MemRegionVal>(LV).getRegion());
+        dyn_cast<VarRegion>(cast<loc::MemRegionVal>(loc).getRegion());
       
       if (!R)
         return UnknownVal();
@@ -294,7 +294,7 @@
       // invalidate their bindings).  Just return Undefined.
       return UndefinedVal();            
     case loc::FuncValKind:
-      return LV;
+      return loc;
       
     default:
       assert (false && "Invalid Loc.");
@@ -304,11 +304,11 @@
   return UnknownVal();
 }
   
-Store BasicStoreManager::BindInternal(Store store, Loc LV, SVal V) {    
-  switch (LV.getSubKind()) {      
+Store BasicStoreManager::BindInternal(Store store, Loc loc, SVal V) {    
+  switch (loc.getSubKind()) {      
     case loc::MemRegionKind: {
       const VarRegion* R =
-        dyn_cast<VarRegion>(cast<loc::MemRegionVal>(LV).getRegion());
+        dyn_cast<VarRegion>(cast<loc::MemRegionVal>(loc).getRegion());
       
       if (!R)
         return store;
@@ -324,11 +324,11 @@
   }
 }
 
-Store BasicStoreManager::Remove(Store store, Loc LV) {
-  switch (LV.getSubKind()) {
+Store BasicStoreManager::Remove(Store store, Loc loc) {
+  switch (loc.getSubKind()) {
     case loc::MemRegionKind: {
       const VarRegion* R =
-        dyn_cast<VarRegion>(cast<loc::MemRegionVal>(LV).getRegion());
+        dyn_cast<VarRegion>(cast<loc::MemRegionVal>(loc).getRegion());
       
       if (!R)
         return store;
@@ -379,7 +379,7 @@
           break;
         
         Marked.insert(R);
-        SVal X = GetRegionSVal(state, R);      
+        SVal X = Retrieve(state, loc::MemRegionVal(R));
     
         // FIXME: We need to handle symbols nested in region definitions.
         for (symbol_iterator SI=X.symbol_begin(), SE=X.symbol_end(); SI!=SE; ++SI)