remove the type_info identifier cache. Compared to the cost
of doing the lookup_decl, the hash lookup is cheap. Also,
typeid doesn't happen enough in real world code to worry about
it.
I'd like to eventually get rid of KnownFunctionIDs from Sema
also, but today is not that day.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@59711 91177308-0d34-0410-b5e6-96231b3b80d8
diff --git a/lib/Sema/SemaExprCXX.cpp b/lib/Sema/SemaExprCXX.cpp
index 0186fc3..80bd8ee 100644
--- a/lib/Sema/SemaExprCXX.cpp
+++ b/lib/Sema/SemaExprCXX.cpp
@@ -55,21 +55,16 @@
Sema::ActOnCXXTypeid(SourceLocation OpLoc, SourceLocation LParenLoc,
bool isType, void *TyOrExpr, SourceLocation RParenLoc) {
const NamespaceDecl *StdNs = GetStdNamespace();
- if (!StdNs) {
- Diag(OpLoc, diag::err_need_header_before_typeid);
- return ExprResult(true);
- }
- if (!Ident_TypeInfo) {
- Ident_TypeInfo = &PP.getIdentifierTable().get("type_info");
- }
- Decl *TypeInfoDecl = LookupDecl(Ident_TypeInfo,
+ if (!StdNs)
+ return Diag(OpLoc, diag::err_need_header_before_typeid);
+
+ IdentifierInfo *TypeInfoII = &PP.getIdentifierTable().get("type_info");
+ Decl *TypeInfoDecl = LookupDecl(TypeInfoII,
Decl::IDNS_Tag | Decl::IDNS_Ordinary,
0, StdNs, /*createBuiltins=*/false);
RecordDecl *TypeInfoRecordDecl = dyn_cast_or_null<RecordDecl>(TypeInfoDecl);
- if (!TypeInfoRecordDecl) {
- Diag(OpLoc, diag::err_need_header_before_typeid);
- return ExprResult(true);
- }
+ if (!TypeInfoRecordDecl)
+ return Diag(OpLoc, diag::err_need_header_before_typeid);
QualType TypeInfoType = Context.getTypeDeclType(TypeInfoRecordDecl);