Add ExplicitCastExpr to replace the current CastExpr, and have ImplicitCastExpr and ExplicitCastExpr derive from a common base class (CastExpr):
Expr
-> CastExpr
-> ExplicitCastExpr
-> ImplicitCastExpr
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@54955 91177308-0d34-0410-b5e6-96231b3b80d8
diff --git a/lib/Sema/SemaChecking.cpp b/lib/Sema/SemaChecking.cpp
index a8782c1..e5e80db 100644
--- a/lib/Sema/SemaChecking.cpp
+++ b/lib/Sema/SemaChecking.cpp
@@ -783,16 +783,10 @@
// For casts, we need to handle conversions from arrays to
// pointer values, and pointer-to-pointer conversions.
- case Stmt::CastExprClass:
+ case Stmt::ExplicitCastExprClass:
case Stmt::ImplicitCastExprClass: {
- Expr* SubExpr;
-
- if (ImplicitCastExpr *IE = dyn_cast<ImplicitCastExpr>(E))
- SubExpr = IE->getSubExpr();
- else
- SubExpr = cast<CastExpr>(E)->getSubExpr();
-
+ Expr* SubExpr = cast<CastExpr>(E)->getSubExpr();
QualType T = SubExpr->getType();
if (T->isPointerType() || T->isObjCQualifiedIdType())
diff --git a/lib/Sema/SemaDecl.cpp b/lib/Sema/SemaDecl.cpp
index 906255e..5a1ad50 100644
--- a/lib/Sema/SemaDecl.cpp
+++ b/lib/Sema/SemaDecl.cpp
@@ -946,7 +946,7 @@
diag::err_init_element_not_constant, Init->getSourceRange());
return true;
}
- case Expr::CastExprClass: {
+ case Expr::ExplicitCastExprClass: {
const Expr* SubExpr = cast<CastExpr>(Init)->getSubExpr();
// Check for pointer->pointer cast
@@ -1058,7 +1058,7 @@
// if we don't, we'll figure it out later
return 0;
}
- case Expr::CastExprClass: {
+ case Expr::ExplicitCastExprClass: {
const Expr* SubExpr = cast<CastExpr>(E)->getSubExpr();
// Check for pointer->pointer cast
@@ -1183,14 +1183,8 @@
return true;
}
case Expr::ImplicitCastExprClass:
- case Expr::CastExprClass: {
- const Expr *SubExpr;
- if (const CastExpr *C = dyn_cast<CastExpr>(Init)) {
- SubExpr = C->getSubExpr();
- } else {
- SubExpr = cast<ImplicitCastExpr>(Init)->getSubExpr();
- }
-
+ case Expr::ExplicitCastExprClass: {
+ const Expr *SubExpr = cast<CastExpr>(Init)->getSubExpr();
if (SubExpr->getType()->isArithmeticType())
return CheckArithmeticConstantExpression(SubExpr);
@@ -1267,9 +1261,7 @@
}
} else if (InitTy->isIntegralType()) {
Expr* SubE = 0;
- if (ImplicitCastExpr* ICE = dyn_cast<ImplicitCastExpr>(Init))
- SubE = ICE->getSubExpr();
- else if (CastExpr* CE = dyn_cast<CastExpr>(Init))
+ if (CastExpr* CE = dyn_cast<CastExpr>(Init))
SubE = CE->getSubExpr();
// Special check for pointer cast to int; we allow as an extension
// an address constant cast to an integer if the integer
diff --git a/lib/Sema/SemaExpr.cpp b/lib/Sema/SemaExpr.cpp
index bb18a4a..cac103a 100644
--- a/lib/Sema/SemaExpr.cpp
+++ b/lib/Sema/SemaExpr.cpp
@@ -1154,7 +1154,7 @@
if (CheckCastTypes(SourceRange(LParenLoc, RParenLoc), castType, castExpr))
return true;
- return new CastExpr(castType, castExpr, LParenLoc);
+ return new ExplicitCastExpr(castType, castExpr, LParenLoc);
}
/// Note that lex is not null here, even if this is the gnu "x ?: y" extension.