implement a fixme by making warnings for ++/-- on non-modifiable-lvalues better.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@59484 91177308-0d34-0410-b5e6-96231b3b80d8
diff --git a/lib/Sema/SemaExpr.cpp b/lib/Sema/SemaExpr.cpp
index 1abc5a3..61b6f7e 100644
--- a/lib/Sema/SemaExpr.cpp
+++ b/lib/Sema/SemaExpr.cpp
@@ -2368,7 +2368,7 @@
}
if (NeedType)
- S.Diag(Loc, Diag, E->getType().getAsString(), SR);
+ S.Diag(Loc, Diag, E->getType().getAsString(), E->getSourceRange());
else
S.Diag(Loc, Diag, E->getSourceRange());
return true;
@@ -2463,13 +2463,8 @@
}
// At this point, we know we have a real, complex or pointer type.
// Now make sure the operand is a modifiable lvalue.
- Expr::isModifiableLvalueResult mlval = op->isModifiableLvalue(Context);
- if (mlval != Expr::MLV_Valid) {
- // FIXME: emit a more precise diagnostic...
- Diag(OpLoc, diag::err_typecheck_invalid_lvalue_incr_decr,
- op->getSourceRange());
+ if (CheckForModifiableLvalue(op, OpLoc, *this))
return QualType();
- }
return resType;
}