Fixes IRgen bug in objc++ reference binding of a
getter expression.
Fixes // rdar://8437240
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@114299 91177308-0d34-0410-b5e6-96231b3b80d8
diff --git a/lib/CodeGen/CGExpr.cpp b/lib/CodeGen/CGExpr.cpp
index 924ca3e..9b69297 100644
--- a/lib/CodeGen/CGExpr.cpp
+++ b/lib/CodeGen/CGExpr.cpp
@@ -196,7 +196,15 @@
if (E->isLvalue(CGF.getContext()) == Expr::LV_Valid) {
// Emit the expression as an lvalue.
LValue LV = CGF.EmitLValue(E);
-
+ if (LV.isPropertyRef() || LV.isKVCRef()) {
+ QualType QT = E->getType();
+ RValue RV =
+ LV.isPropertyRef() ? CGF.EmitLoadOfPropertyRefLValue(LV, QT)
+ : CGF.EmitLoadOfKVCRefLValue(LV, QT);
+ assert(RV.isScalar() && "EmitExprForReferenceBinding");
+ return RV.getScalarVal();
+ }
+
if (LV.isSimple())
return LV.getAddress();
diff --git a/test/CodeGenObjCXX/property-dot-reference.mm b/test/CodeGenObjCXX/property-dot-reference.mm
index 82e89f2..0d455c6 100644
--- a/test/CodeGenObjCXX/property-dot-reference.mm
+++ b/test/CodeGenObjCXX/property-dot-reference.mm
@@ -16,3 +16,23 @@
self.node.GetURL();
} // expected-warning {{control reaches end of non-void function}}
@end
+
+// rdar://8437240
+struct X {
+ int x;
+};
+
+void f0(const X &parent);
+@interface A
+- (const X&) target;
+@end
+void f1(A *a) {
+// CHECK: [[PRP:%.*]] = call %struct.X* bitcast (i8* (i8*, i8*, ...)* @objc_msgSend
+// CHECK-NEXT:call void @_Z2f0RK1X(%struct.X* [[PRP]])
+ f0(a.target);
+
+// CHECK: [[MSG:%.*]] = call %struct.X* bitcast (i8* (i8*, i8*, ...)* @objc_msgSend
+// CHECK-NEXT:call void @_Z2f0RK1X(%struct.X* [[MSG]])
+ f0([a target]);
+}
+