commit de93d33099d51ddcbe3ae6f7075acca8bebcb4c8
author Anders Carlsson <andersca@mac.com> Wed Jan 21 06:27:20 2009 +0000
committer Anders Carlsson <andersca@mac.com> Wed Jan 21 06:27:20 2009 +0000
tree bc3162bc0ce8ae43dcd0f175dd128f3c1fd15de6
parent 310dea3da3c932dd65ef5ee13f0a4c7e4bab90e0

Fix an inline asm sema bug that I introduced.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@62666 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Sema/SemaStmt.cpp

diff --git a/lib/Sema/SemaStmt.cpp b/lib/Sema/SemaStmt.cpp
index 4b89acb..9b6da05 100644
--- a/lib/Sema/SemaStmt.cpp
+++ b/lib/Sema/SemaStmt.cpp
@@ -899,8 +899,8 @@
     ParenExpr *InputExpr = cast<ParenExpr>(Exprs[i]);
 
     // Only allow void types for memory constraints.
-    if (info & TargetInfo::CI_AllowsMemory) {
-
+    if ((info & TargetInfo::CI_AllowsMemory) 
+        && !(info & TargetInfo::CI_AllowsRegister)) {
       if (InputExpr->isLvalue(Context) != Expr::LV_Valid)
         return StmtError(Diag(InputExpr->getSubExpr()->getLocStart(),
                               diag::err_asm_invalid_lvalue_in_input)

test/Sema/asm.c

diff --git a/test/Sema/asm.c b/test/Sema/asm.c
index 312b800..4093b1a 100644
--- a/test/Sema/asm.c
+++ b/test/Sema/asm.c
@@ -46,5 +46,11 @@
     asm ("nop" : : "r"(test4(addr))); // expected-error {{invalid type 'void' in asm input for constraint 'r'}}
     asm ("nop" : : "m"(test4(addr))); // expected-error {{invalid lvalue in asm input for constraint 'm'}}
 
-    asm("nop" : : "m"(f())); // expected-error {{invalid lvalue in asm input for constraint 'm'}}
+    asm ("nop" : : "m"(f())); // expected-error {{invalid lvalue in asm input for constraint 'm'}}
+}
+
+// <rdar://problem/6512595>
+void test5()
+{
+  asm("nop" : : "X" (8)); 
 }