commit e5194ff24c224fa8ee83064dff73f62f745a4469
author Anders Carlsson <andersca@mac.com> Sat Mar 28 01:09:05 2009 +0000
committer Anders Carlsson <andersca@mac.com> Sat Mar 28 01:09:05 2009 +0000
tree 5ac4e61124fdc023154bb212181e4c54640facf3
parent 52ba870eba17e634339622dbf103434ca31935eb

Implement access checking for protected base classes.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@67887 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Sema/SemaAccess.cpp

diff --git a/lib/Sema/SemaAccess.cpp b/lib/Sema/SemaAccess.cpp
index cc21243..e65b050 100644
--- a/lib/Sema/SemaAccess.cpp
+++ b/lib/Sema/SemaAccess.cpp
@@ -55,7 +55,7 @@
   
   const CXXBaseSpecifier *InacessibleBase = 0;
 
-  const CXXRecordDecl* CurrentClassDecl = 0;
+  CXXRecordDecl* CurrentClassDecl = 0;
   if (CXXMethodDecl *MD = dyn_cast_or_null<CXXMethodDecl>(getCurFunctionDecl()))
     CurrentClassDecl = MD->getParent();
 
@@ -79,9 +79,21 @@
         if (CurrentClassDecl != Element->Class)
           FoundInaccessibleBase = true;
         break;
-      case AS_protected:  
-        // FIXME: Implement
-        break;
+      case AS_protected:
+        // FIXME: Check if the current function/class is a friend.
+        if (!CurrentClassDecl) {
+          FoundInaccessibleBase = true;
+          break;
+        }
+        
+        if (CurrentClassDecl != Element->Class) {
+          QualType CurrentClassType = Context.getTypeDeclType(CurrentClassDecl);
+          QualType ClassType = Context.getTypeDeclType(Element->Class);
+          
+          if (!IsDerivedFrom(CurrentClassType, ClassType))
+            FoundInaccessibleBase = true;
+          break;
+        }
       }
       
       if (FoundInaccessibleBase) {

lib/Sema/SemaInherit.h

diff --git a/lib/Sema/SemaInherit.h b/lib/Sema/SemaInherit.h
index 6138685..a164d43 100644
--- a/lib/Sema/SemaInherit.h
+++ b/lib/Sema/SemaInherit.h
@@ -40,7 +40,7 @@
     const CXXBaseSpecifier *Base;
 
     /// Class - The record decl of the class that the base is a base of.
-    const CXXRecordDecl *Class;
+    CXXRecordDecl *Class;
     
     /// SubobjectNumber - Identifies which base class subobject (of type
     /// @c Base->getType()) this base path element refers to. This 

test/SemaCXX/access-base-class.cpp

diff --git a/test/SemaCXX/access-base-class.cpp b/test/SemaCXX/access-base-class.cpp
index f984376..3e50b26 100644
--- a/test/SemaCXX/access-base-class.cpp
+++ b/test/SemaCXX/access-base-class.cpp
@@ -80,3 +80,35 @@
     A *a = c;
   }
 }
+
+namespace T7 {
+  
+class C;
+class A { };
+class B : protected A { // expected-note {{'protected' inheritance specifier here}}
+  void f(C *);
+};
+
+class C : protected B { // expected-note {{'protected' inheritance specifier here}}
+  void f(C *c) {
+    A* a = c;
+  }
+};
+
+void B::f(C *c) {
+  A *a = c; // expected-error {{conversion from 'class T7::C' to inaccessible base class 'class T7::A'}} \
+               expected-error {{incompatible type initializing 'class T7::C *', expected 'class T7::A *'}}
+}
+
+class D : private C  {
+  void f(D *d) {
+    A *a = d;
+  }
+};
+
+void f(B* b) {
+  A *a = b; // expected-error {{conversion from 'class T7::B' to inaccessible base class 'class T7::A'}} \
+               expected-error {{incompatible type initializing 'class T7::B *', expected 'class T7::A *'}}
+}
+
+}