commit eb43f4a8f133c2bc510ae136a556e92b68a6ff44
author Eli Friedman <eli.friedman@gmail.com> Tue Sep 13 22:21:56 2011 +0000
committer Eli Friedman <eli.friedman@gmail.com> Tue Sep 13 22:21:56 2011 +0000
tree 2f040bba53a3cb3d214e38a00f6682848c87aaf1
parent a179b531f4728b91291bfbf639ddf71ed7db810a

Re-commit r139643.

Make clang use Acquire loads and Release stores where necessary.



git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@139650 91177308-0d34-0410-b5e6-96231b3b80d8

test/CodeGen/Atomics.c

diff --git a/test/CodeGen/Atomics.c b/test/CodeGen/Atomics.c
index e5a5812..c440b6c 100644
--- a/test/CodeGen/Atomics.c
+++ b/test/CodeGen/Atomics.c
@@ -192,13 +192,12 @@
 
   __sync_synchronize (); // CHECK: fence seq_cst
 
-  // FIXME: These are wrong!
-  __sync_lock_release (&sc); // CHECK: store volatile
-  __sync_lock_release (&uc); // CHECK: store volatile
-  __sync_lock_release (&ss); // CHECK: store volatile
-  __sync_lock_release (&us); // CHECK: store volatile
-  __sync_lock_release (&si); // CHECK: store volatile
-  __sync_lock_release (&ui); // CHECK: store volatile
-  __sync_lock_release (&sll); // CHECK: store volatile
-  __sync_lock_release (&ull); // CHECK: store volatile
+  __sync_lock_release (&sc); // CHECK: store atomic {{.*}} release, align 1
+  __sync_lock_release (&uc); // CHECK: store atomic {{.*}} release, align 1
+  __sync_lock_release (&ss); // CHECK: store atomic {{.*}} release, align 2
+  __sync_lock_release (&us); /// CHECK: store atomic {{.*}} release, align 2
+  __sync_lock_release (&si); // CHECK: store atomic {{.*}} release, align 4
+  __sync_lock_release (&ui); // CHECK: store atomic {{.*}} release, align 4
+  __sync_lock_release (&sll); // CHECK: store atomic {{.*}} release, align 8
+  __sync_lock_release (&ull); // CHECK: store atomic {{.*}} release, align 8
 }

test/CodeGen/atomic.c

diff --git a/test/CodeGen/atomic.c b/test/CodeGen/atomic.c
index a0adac8..c8f4fd0 100644
--- a/test/CodeGen/atomic.c
+++ b/test/CodeGen/atomic.c
@@ -75,8 +75,7 @@
   // CHECK: cmpxchg i32* null, i32 0, i32 0 seq_cst
   
   __sync_lock_release(&val);
-  // FIXME: WRONG!
-  // CHECK: store volatile i32 0, i32* 
+  // CHECK: store atomic {{.*}} release, align 4
   
   __sync_synchronize ();
   // CHECK: fence seq_cst
@@ -88,8 +87,7 @@
 void release_return(int *lock) {
   // Ensure this is actually returning void all the way through.
   return __sync_lock_release(lock);
-  // FIXME: WRONG!
-  // CHECK: store volatile i32 0, i32* 
+  // CHECK: store atomic {{.*}} release, align 4
 }
 
 

test/CodeGenCXX/static-init.cpp

diff --git a/test/CodeGenCXX/static-init.cpp b/test/CodeGenCXX/static-init.cpp
index d488e63..9e2673c 100644
--- a/test/CodeGenCXX/static-init.cpp
+++ b/test/CodeGenCXX/static-init.cpp
@@ -12,13 +12,11 @@
 };
 
 void f() {
+  // CHECK: load atomic i8* bitcast (i64* @_ZGVZ1fvE1a to i8*) acquire, align 1
   // CHECK: call i32 @__cxa_guard_acquire
   // CHECK: call void @_ZN1AC1Ev
   // CHECK: call i32 @__cxa_atexit(void (i8*)* bitcast (void (%struct.A*)* @_ZN1AD1Ev to void (i8*)*), i8* getelementptr inbounds (%struct.A* @_ZZ1fvE1a, i32 0, i32 0), i8* bitcast (i8** @__dso_handle to i8*))
   // CHECK: call void @__cxa_guard_release
-
-  // rdar://problem/9496726
-  // CHECK: call void @llvm.memory.barrier(i1 true, i1 true, i1 false, i1 false, i1 false)
   static A a;
 }