Sanity-check argument to indirect goto.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@67746 91177308-0d34-0410-b5e6-96231b3b80d8
diff --git a/lib/Sema/SemaStmt.cpp b/lib/Sema/SemaStmt.cpp
index 4ef0fda..bbcc71d 100644
--- a/lib/Sema/SemaStmt.cpp
+++ b/lib/Sema/SemaStmt.cpp
@@ -687,10 +687,14 @@
Action::OwningStmtResult
Sema::ActOnIndirectGotoStmt(SourceLocation GotoLoc,SourceLocation StarLoc,
ExprArg DestExp) {
- // FIXME: Verify that the operand is convertible to void*.
// Convert operand to void*
- Expr* E = (Expr*)DestExp.release();
- ImpCastExprToType(E, Context.VoidPtrTy);
+ Expr* E = DestExp.takeAs<Expr>();
+ QualType ETy = E->getType();
+ AssignConvertType ConvTy =
+ CheckSingleAssignmentConstraints(Context.VoidPtrTy, E);
+ if (DiagnoseAssignmentResult(ConvTy, StarLoc, Context.VoidPtrTy, ETy,
+ E, "passing"))
+ return StmtError();
return Owned(new (Context) IndirectGotoStmt(E));
}