Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 1 | //=== MallocChecker.cpp - A malloc/free checker -------------------*- C++ -*--// |
| 2 | // |
| 3 | // The LLVM Compiler Infrastructure |
| 4 | // |
| 5 | // This file is distributed under the University of Illinois Open Source |
| 6 | // License. See LICENSE.TXT for details. |
| 7 | // |
| 8 | //===----------------------------------------------------------------------===// |
| 9 | // |
| 10 | // This file defines malloc/free checker, which checks for potential memory |
| 11 | // leaks, double free, and use-after-free problems. |
| 12 | // |
| 13 | //===----------------------------------------------------------------------===// |
| 14 | |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 15 | #include "ClangSACheckers.h" |
Argyrios Kyrtzidis | ec8605f | 2011-03-01 01:16:21 +0000 | [diff] [blame] | 16 | #include "clang/StaticAnalyzer/Core/Checker.h" |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 17 | #include "clang/StaticAnalyzer/Core/CheckerManager.h" |
| 18 | #include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h" |
Ted Kremenek | 9b66371 | 2011-02-10 01:03:03 +0000 | [diff] [blame] | 19 | #include "clang/StaticAnalyzer/Core/BugReporter/BugType.h" |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 20 | #include "clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h" |
| 21 | #include "clang/StaticAnalyzer/Core/PathSensitive/ProgramStateTrait.h" |
Ted Kremenek | 9b66371 | 2011-02-10 01:03:03 +0000 | [diff] [blame] | 22 | #include "clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h" |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 23 | #include "llvm/ADT/ImmutableMap.h" |
| 24 | using namespace clang; |
Ted Kremenek | 9ef6537 | 2010-12-23 07:20:52 +0000 | [diff] [blame] | 25 | using namespace ento; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 26 | |
| 27 | namespace { |
| 28 | |
Zhongxing Xu | 7fb1464 | 2009-12-11 00:55:44 +0000 | [diff] [blame] | 29 | class RefState { |
Ted Kremenek | dde201b | 2010-08-06 21:12:55 +0000 | [diff] [blame] | 30 | enum Kind { AllocateUnchecked, AllocateFailed, Released, Escaped, |
| 31 | Relinquished } K; |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 32 | const Stmt *S; |
| 33 | |
Zhongxing Xu | 7fb1464 | 2009-12-11 00:55:44 +0000 | [diff] [blame] | 34 | public: |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 35 | RefState(Kind k, const Stmt *s) : K(k), S(s) {} |
| 36 | |
Zhongxing Xu | b94b81a | 2009-12-31 06:13:07 +0000 | [diff] [blame] | 37 | bool isAllocated() const { return K == AllocateUnchecked; } |
Chris Lattner | fae9622 | 2010-09-03 04:34:38 +0000 | [diff] [blame] | 38 | //bool isFailed() const { return K == AllocateFailed; } |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 39 | bool isReleased() const { return K == Released; } |
Chris Lattner | fae9622 | 2010-09-03 04:34:38 +0000 | [diff] [blame] | 40 | //bool isEscaped() const { return K == Escaped; } |
| 41 | //bool isRelinquished() const { return K == Relinquished; } |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 42 | |
| 43 | bool operator==(const RefState &X) const { |
| 44 | return K == X.K && S == X.S; |
| 45 | } |
| 46 | |
Zhongxing Xu | b94b81a | 2009-12-31 06:13:07 +0000 | [diff] [blame] | 47 | static RefState getAllocateUnchecked(const Stmt *s) { |
| 48 | return RefState(AllocateUnchecked, s); |
| 49 | } |
| 50 | static RefState getAllocateFailed() { |
| 51 | return RefState(AllocateFailed, 0); |
| 52 | } |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 53 | static RefState getReleased(const Stmt *s) { return RefState(Released, s); } |
| 54 | static RefState getEscaped(const Stmt *s) { return RefState(Escaped, s); } |
Ted Kremenek | dde201b | 2010-08-06 21:12:55 +0000 | [diff] [blame] | 55 | static RefState getRelinquished(const Stmt *s) { |
| 56 | return RefState(Relinquished, s); |
| 57 | } |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 58 | |
| 59 | void Profile(llvm::FoldingSetNodeID &ID) const { |
| 60 | ID.AddInteger(K); |
| 61 | ID.AddPointer(S); |
| 62 | } |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 63 | }; |
| 64 | |
Kovarththanan Rajaratnam | ba5fb5a | 2009-11-28 06:07:30 +0000 | [diff] [blame] | 65 | class RegionState {}; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 66 | |
Ted Kremenek | e3659a7 | 2012-01-04 23:48:37 +0000 | [diff] [blame] | 67 | class MallocChecker : public Checker<eval::Call, |
| 68 | check::DeadSymbols, |
| 69 | check::EndPath, |
| 70 | check::PreStmt<ReturnStmt>, |
| 71 | check::Location, |
| 72 | check::Bind, |
| 73 | eval::Assume> |
| 74 | { |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 75 | mutable llvm::OwningPtr<BuiltinBug> BT_DoubleFree; |
| 76 | mutable llvm::OwningPtr<BuiltinBug> BT_Leak; |
| 77 | mutable llvm::OwningPtr<BuiltinBug> BT_UseFree; |
| 78 | mutable llvm::OwningPtr<BuiltinBug> BT_UseRelinquished; |
| 79 | mutable llvm::OwningPtr<BuiltinBug> BT_BadFree; |
| 80 | mutable IdentifierInfo *II_malloc, *II_free, *II_realloc, *II_calloc; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 81 | |
| 82 | public: |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 83 | MallocChecker() : II_malloc(0), II_free(0), II_realloc(0), II_calloc(0) {} |
| 84 | |
| 85 | bool evalCall(const CallExpr *CE, CheckerContext &C) const; |
| 86 | void checkDeadSymbols(SymbolReaper &SymReaper, CheckerContext &C) const; |
Anna Zaks | af498a2 | 2011-10-25 19:56:48 +0000 | [diff] [blame] | 87 | void checkEndPath(CheckerContext &C) const; |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 88 | void checkPreStmt(const ReturnStmt *S, CheckerContext &C) const; |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 89 | const ProgramState *evalAssume(const ProgramState *state, SVal Cond, |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 90 | bool Assumption) const; |
Anna Zaks | 390909c | 2011-10-06 00:43:15 +0000 | [diff] [blame] | 91 | void checkLocation(SVal l, bool isLoad, const Stmt *S, |
| 92 | CheckerContext &C) const; |
| 93 | void checkBind(SVal location, SVal val, const Stmt*S, |
| 94 | CheckerContext &C) const; |
Zhongxing Xu | b94b81a | 2009-12-31 06:13:07 +0000 | [diff] [blame] | 95 | |
Zhongxing Xu | 7b76096 | 2009-11-13 07:25:27 +0000 | [diff] [blame] | 96 | private: |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 97 | static void MallocMem(CheckerContext &C, const CallExpr *CE); |
| 98 | static void MallocMemReturnsAttr(CheckerContext &C, const CallExpr *CE, |
| 99 | const OwnershipAttr* Att); |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 100 | static const ProgramState *MallocMemAux(CheckerContext &C, const CallExpr *CE, |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 101 | const Expr *SizeEx, SVal Init, |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 102 | const ProgramState *state) { |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 103 | return MallocMemAux(C, CE, state->getSVal(SizeEx), Init, state); |
| 104 | } |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 105 | static const ProgramState *MallocMemAux(CheckerContext &C, const CallExpr *CE, |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 106 | SVal SizeEx, SVal Init, |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 107 | const ProgramState *state); |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 108 | |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 109 | void FreeMem(CheckerContext &C, const CallExpr *CE) const; |
Jordy Rose | 2a47992 | 2010-08-12 08:54:03 +0000 | [diff] [blame] | 110 | void FreeMemAttr(CheckerContext &C, const CallExpr *CE, |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 111 | const OwnershipAttr* Att) const; |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 112 | const ProgramState *FreeMemAux(CheckerContext &C, const CallExpr *CE, |
Ted Kremenek | e3659a7 | 2012-01-04 23:48:37 +0000 | [diff] [blame] | 113 | const ProgramState *state, unsigned Num, |
| 114 | bool Hold) const; |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 115 | |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 116 | void ReallocMem(CheckerContext &C, const CallExpr *CE) const; |
| 117 | static void CallocMem(CheckerContext &C, const CallExpr *CE); |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 118 | |
Ted Kremenek | 9c378f7 | 2011-08-12 23:37:29 +0000 | [diff] [blame] | 119 | static bool SummarizeValue(raw_ostream &os, SVal V); |
| 120 | static bool SummarizeRegion(raw_ostream &os, const MemRegion *MR); |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 121 | void ReportBadFree(CheckerContext &C, SVal ArgVal, SourceRange range) const; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 122 | }; |
Kovarththanan Rajaratnam | ba5fb5a | 2009-11-28 06:07:30 +0000 | [diff] [blame] | 123 | } // end anonymous namespace |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 124 | |
Zhongxing Xu | b94b81a | 2009-12-31 06:13:07 +0000 | [diff] [blame] | 125 | typedef llvm::ImmutableMap<SymbolRef, RefState> RegionStateTy; |
| 126 | |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 127 | namespace clang { |
Ted Kremenek | 9ef6537 | 2010-12-23 07:20:52 +0000 | [diff] [blame] | 128 | namespace ento { |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 129 | template <> |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 130 | struct ProgramStateTrait<RegionState> |
| 131 | : public ProgramStatePartialTrait<RegionStateTy> { |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 132 | static void *GDMIndex() { static int x; return &x; } |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 133 | }; |
| 134 | } |
Argyrios Kyrtzidis | 5a4f98f | 2010-12-22 18:53:20 +0000 | [diff] [blame] | 135 | } |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 136 | |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 137 | bool MallocChecker::evalCall(const CallExpr *CE, CheckerContext &C) const { |
Anna Zaks | b805c8f | 2011-12-01 05:57:37 +0000 | [diff] [blame] | 138 | const FunctionDecl *FD = C.getCalleeDecl(CE); |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 139 | if (!FD) |
Zhongxing Xu | a49c6b7 | 2009-12-11 03:09:01 +0000 | [diff] [blame] | 140 | return false; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 141 | |
| 142 | ASTContext &Ctx = C.getASTContext(); |
| 143 | if (!II_malloc) |
| 144 | II_malloc = &Ctx.Idents.get("malloc"); |
| 145 | if (!II_free) |
Zhongxing Xu | fc7ac8f | 2009-11-13 07:48:11 +0000 | [diff] [blame] | 146 | II_free = &Ctx.Idents.get("free"); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 147 | if (!II_realloc) |
| 148 | II_realloc = &Ctx.Idents.get("realloc"); |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 149 | if (!II_calloc) |
| 150 | II_calloc = &Ctx.Idents.get("calloc"); |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 151 | |
| 152 | if (FD->getIdentifier() == II_malloc) { |
| 153 | MallocMem(C, CE); |
Zhongxing Xu | a49c6b7 | 2009-12-11 03:09:01 +0000 | [diff] [blame] | 154 | return true; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 155 | } |
| 156 | |
| 157 | if (FD->getIdentifier() == II_free) { |
| 158 | FreeMem(C, CE); |
Zhongxing Xu | a49c6b7 | 2009-12-11 03:09:01 +0000 | [diff] [blame] | 159 | return true; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 160 | } |
Zhongxing Xu | a49c6b7 | 2009-12-11 03:09:01 +0000 | [diff] [blame] | 161 | |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 162 | if (FD->getIdentifier() == II_realloc) { |
| 163 | ReallocMem(C, CE); |
| 164 | return true; |
| 165 | } |
| 166 | |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 167 | if (FD->getIdentifier() == II_calloc) { |
| 168 | CallocMem(C, CE); |
| 169 | return true; |
| 170 | } |
| 171 | |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 172 | // Check all the attributes, if there are any. |
| 173 | // There can be multiple of these attributes. |
| 174 | bool rv = false; |
| 175 | if (FD->hasAttrs()) { |
Sean Hunt | cf807c4 | 2010-08-18 23:23:40 +0000 | [diff] [blame] | 176 | for (specific_attr_iterator<OwnershipAttr> |
| 177 | i = FD->specific_attr_begin<OwnershipAttr>(), |
| 178 | e = FD->specific_attr_end<OwnershipAttr>(); |
| 179 | i != e; ++i) { |
| 180 | switch ((*i)->getOwnKind()) { |
| 181 | case OwnershipAttr::Returns: { |
| 182 | MallocMemReturnsAttr(C, CE, *i); |
Jordy Rose | 2a47992 | 2010-08-12 08:54:03 +0000 | [diff] [blame] | 183 | rv = true; |
| 184 | break; |
Sean Hunt | cf807c4 | 2010-08-18 23:23:40 +0000 | [diff] [blame] | 185 | } |
| 186 | case OwnershipAttr::Takes: |
| 187 | case OwnershipAttr::Holds: { |
| 188 | FreeMemAttr(C, CE, *i); |
Jordy Rose | 2a47992 | 2010-08-12 08:54:03 +0000 | [diff] [blame] | 189 | rv = true; |
| 190 | break; |
Sean Hunt | cf807c4 | 2010-08-18 23:23:40 +0000 | [diff] [blame] | 191 | } |
Jordy Rose | 2a47992 | 2010-08-12 08:54:03 +0000 | [diff] [blame] | 192 | default: |
Jordy Rose | 2a47992 | 2010-08-12 08:54:03 +0000 | [diff] [blame] | 193 | break; |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 194 | } |
| 195 | } |
| 196 | } |
| 197 | return rv; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 198 | } |
| 199 | |
| 200 | void MallocChecker::MallocMem(CheckerContext &C, const CallExpr *CE) { |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 201 | const ProgramState *state = MallocMemAux(C, CE, CE->getArg(0), UndefinedVal(), |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 202 | C.getState()); |
Anna Zaks | 0bd6b11 | 2011-10-26 21:06:34 +0000 | [diff] [blame] | 203 | C.addTransition(state); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 204 | } |
| 205 | |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 206 | void MallocChecker::MallocMemReturnsAttr(CheckerContext &C, const CallExpr *CE, |
| 207 | const OwnershipAttr* Att) { |
Sean Hunt | cf807c4 | 2010-08-18 23:23:40 +0000 | [diff] [blame] | 208 | if (Att->getModule() != "malloc") |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 209 | return; |
| 210 | |
Sean Hunt | cf807c4 | 2010-08-18 23:23:40 +0000 | [diff] [blame] | 211 | OwnershipAttr::args_iterator I = Att->args_begin(), E = Att->args_end(); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 212 | if (I != E) { |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 213 | const ProgramState *state = |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 214 | MallocMemAux(C, CE, CE->getArg(*I), UndefinedVal(), C.getState()); |
Anna Zaks | 0bd6b11 | 2011-10-26 21:06:34 +0000 | [diff] [blame] | 215 | C.addTransition(state); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 216 | return; |
| 217 | } |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 218 | const ProgramState *state = MallocMemAux(C, CE, UnknownVal(), UndefinedVal(), |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 219 | C.getState()); |
Anna Zaks | 0bd6b11 | 2011-10-26 21:06:34 +0000 | [diff] [blame] | 220 | C.addTransition(state); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 221 | } |
| 222 | |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 223 | const ProgramState *MallocChecker::MallocMemAux(CheckerContext &C, |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 224 | const CallExpr *CE, |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 225 | SVal Size, SVal Init, |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 226 | const ProgramState *state) { |
Anna Zaks | 5d0ea6d | 2011-10-04 20:43:05 +0000 | [diff] [blame] | 227 | unsigned Count = C.getCurrentBlockCount(); |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 228 | SValBuilder &svalBuilder = C.getSValBuilder(); |
Zhongxing Xu | a49c6b7 | 2009-12-11 03:09:01 +0000 | [diff] [blame] | 229 | |
Jordy Rose | 32f2656 | 2010-07-04 00:00:41 +0000 | [diff] [blame] | 230 | // Set the return value. |
Ted Kremenek | e3659a7 | 2012-01-04 23:48:37 +0000 | [diff] [blame] | 231 | SVal retVal = svalBuilder.getConjuredSymbolVal(NULL, CE, |
| 232 | CE->getType(), Count); |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 233 | state = state->BindExpr(CE, retVal); |
Zhongxing Xu | a49c6b7 | 2009-12-11 03:09:01 +0000 | [diff] [blame] | 234 | |
Jordy Rose | 32f2656 | 2010-07-04 00:00:41 +0000 | [diff] [blame] | 235 | // Fill the region with the initialization value. |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 236 | state = state->bindDefault(retVal, Init); |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 237 | |
Jordy Rose | 32f2656 | 2010-07-04 00:00:41 +0000 | [diff] [blame] | 238 | // Set the region's extent equal to the Size parameter. |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 239 | const SymbolicRegion *R = cast<SymbolicRegion>(retVal.getAsRegion()); |
| 240 | DefinedOrUnknownSVal Extent = R->getExtent(svalBuilder); |
Jordy Rose | 32f2656 | 2010-07-04 00:00:41 +0000 | [diff] [blame] | 241 | DefinedOrUnknownSVal DefinedSize = cast<DefinedOrUnknownSVal>(Size); |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 242 | DefinedOrUnknownSVal extentMatchesSize = |
Ted Kremenek | 9c14953 | 2010-12-01 21:57:22 +0000 | [diff] [blame] | 243 | svalBuilder.evalEQ(state, Extent, DefinedSize); |
Jordy Rose | 32f2656 | 2010-07-04 00:00:41 +0000 | [diff] [blame] | 244 | |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 245 | state = state->assume(extentMatchesSize, true); |
| 246 | assert(state); |
| 247 | |
| 248 | SymbolRef Sym = retVal.getAsLocSymbol(); |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 249 | assert(Sym); |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 250 | |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 251 | // Set the symbol's state to Allocated. |
Zhongxing Xu | b94b81a | 2009-12-31 06:13:07 +0000 | [diff] [blame] | 252 | return state->set<RegionState>(Sym, RefState::getAllocateUnchecked(CE)); |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 253 | } |
| 254 | |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 255 | void MallocChecker::FreeMem(CheckerContext &C, const CallExpr *CE) const { |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 256 | const ProgramState *state = FreeMemAux(C, CE, C.getState(), 0, false); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 257 | |
| 258 | if (state) |
Anna Zaks | 0bd6b11 | 2011-10-26 21:06:34 +0000 | [diff] [blame] | 259 | C.addTransition(state); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 260 | } |
| 261 | |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 262 | void MallocChecker::FreeMemAttr(CheckerContext &C, const CallExpr *CE, |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 263 | const OwnershipAttr* Att) const { |
Sean Hunt | cf807c4 | 2010-08-18 23:23:40 +0000 | [diff] [blame] | 264 | if (Att->getModule() != "malloc") |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 265 | return; |
| 266 | |
Sean Hunt | cf807c4 | 2010-08-18 23:23:40 +0000 | [diff] [blame] | 267 | for (OwnershipAttr::args_iterator I = Att->args_begin(), E = Att->args_end(); |
| 268 | I != E; ++I) { |
Ted Kremenek | e3659a7 | 2012-01-04 23:48:37 +0000 | [diff] [blame] | 269 | const ProgramState *state = |
| 270 | FreeMemAux(C, CE, C.getState(), *I, |
| 271 | Att->getOwnKind() == OwnershipAttr::Holds); |
Sean Hunt | cf807c4 | 2010-08-18 23:23:40 +0000 | [diff] [blame] | 272 | if (state) |
Anna Zaks | 0bd6b11 | 2011-10-26 21:06:34 +0000 | [diff] [blame] | 273 | C.addTransition(state); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 274 | } |
| 275 | } |
| 276 | |
Ted Kremenek | e3659a7 | 2012-01-04 23:48:37 +0000 | [diff] [blame] | 277 | const ProgramState *MallocChecker::FreeMemAux(CheckerContext &C, |
| 278 | const CallExpr *CE, |
| 279 | const ProgramState *state, |
| 280 | unsigned Num, |
| 281 | bool Hold) const { |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 282 | const Expr *ArgExpr = CE->getArg(Num); |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 283 | SVal ArgVal = state->getSVal(ArgExpr); |
Zhongxing Xu | 181cc3d | 2010-02-14 06:49:48 +0000 | [diff] [blame] | 284 | |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 285 | DefinedOrUnknownSVal location = cast<DefinedOrUnknownSVal>(ArgVal); |
| 286 | |
| 287 | // Check for null dereferences. |
| 288 | if (!isa<Loc>(location)) |
Zhongxing Xu | 181cc3d | 2010-02-14 06:49:48 +0000 | [diff] [blame] | 289 | return state; |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 290 | |
| 291 | // FIXME: Technically using 'Assume' here can result in a path |
| 292 | // bifurcation. In such cases we need to return two states, not just one. |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 293 | const ProgramState *notNullState, *nullState; |
Ted Kremenek | 28f47b9 | 2010-12-01 22:16:56 +0000 | [diff] [blame] | 294 | llvm::tie(notNullState, nullState) = state->assume(location); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 295 | |
| 296 | // The explicit NULL case, no operation is performed. |
| 297 | if (nullState && !notNullState) |
| 298 | return nullState; |
| 299 | |
| 300 | assert(notNullState); |
| 301 | |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 302 | // Unknown values could easily be okay |
| 303 | // Undefined values are handled elsewhere |
| 304 | if (ArgVal.isUnknownOrUndef()) |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 305 | return notNullState; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 306 | |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 307 | const MemRegion *R = ArgVal.getAsRegion(); |
| 308 | |
| 309 | // Nonlocs can't be freed, of course. |
| 310 | // Non-region locations (labels and fixed addresses) also shouldn't be freed. |
| 311 | if (!R) { |
| 312 | ReportBadFree(C, ArgVal, ArgExpr->getSourceRange()); |
| 313 | return NULL; |
| 314 | } |
| 315 | |
| 316 | R = R->StripCasts(); |
| 317 | |
| 318 | // Blocks might show up as heap data, but should not be free()d |
| 319 | if (isa<BlockDataRegion>(R)) { |
| 320 | ReportBadFree(C, ArgVal, ArgExpr->getSourceRange()); |
| 321 | return NULL; |
| 322 | } |
| 323 | |
| 324 | const MemSpaceRegion *MS = R->getMemorySpace(); |
| 325 | |
| 326 | // Parameters, locals, statics, and globals shouldn't be freed. |
| 327 | if (!(isa<UnknownSpaceRegion>(MS) || isa<HeapSpaceRegion>(MS))) { |
| 328 | // FIXME: at the time this code was written, malloc() regions were |
| 329 | // represented by conjured symbols, which are all in UnknownSpaceRegion. |
| 330 | // This means that there isn't actually anything from HeapSpaceRegion |
| 331 | // that should be freed, even though we allow it here. |
| 332 | // Of course, free() can work on memory allocated outside the current |
| 333 | // function, so UnknownSpaceRegion is always a possibility. |
| 334 | // False negatives are better than false positives. |
| 335 | |
| 336 | ReportBadFree(C, ArgVal, ArgExpr->getSourceRange()); |
| 337 | return NULL; |
| 338 | } |
| 339 | |
| 340 | const SymbolicRegion *SR = dyn_cast<SymbolicRegion>(R); |
| 341 | // Various cases could lead to non-symbol values here. |
| 342 | // For now, ignore them. |
| 343 | if (!SR) |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 344 | return notNullState; |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 345 | |
| 346 | SymbolRef Sym = SR->getSymbol(); |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 347 | const RefState *RS = state->get<RegionState>(Sym); |
Zhongxing Xu | 7e3cda9 | 2010-01-18 03:27:34 +0000 | [diff] [blame] | 348 | |
| 349 | // If the symbol has not been tracked, return. This is possible when free() is |
| 350 | // called on a pointer that does not get its pointee directly from malloc(). |
| 351 | // Full support of this requires inter-procedural analysis. |
| 352 | if (!RS) |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 353 | return notNullState; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 354 | |
| 355 | // Check double free. |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 356 | if (RS->isReleased()) { |
Ted Kremenek | d048c6e | 2010-12-20 21:19:09 +0000 | [diff] [blame] | 357 | if (ExplodedNode *N = C.generateSink()) { |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 358 | if (!BT_DoubleFree) |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 359 | BT_DoubleFree.reset( |
| 360 | new BuiltinBug("Double free", |
| 361 | "Try to free a memory block that has been released")); |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 362 | // FIXME: should find where it's freed last time. |
| 363 | BugReport *R = new BugReport(*BT_DoubleFree, |
Benjamin Kramer | d02e232 | 2009-11-14 12:08:24 +0000 | [diff] [blame] | 364 | BT_DoubleFree->getDescription(), N); |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 365 | C.EmitReport(R); |
| 366 | } |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 367 | return NULL; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 368 | } |
| 369 | |
| 370 | // Normal free. |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 371 | if (Hold) |
| 372 | return notNullState->set<RegionState>(Sym, RefState::getRelinquished(CE)); |
| 373 | return notNullState->set<RegionState>(Sym, RefState::getReleased(CE)); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 374 | } |
| 375 | |
Ted Kremenek | 9c378f7 | 2011-08-12 23:37:29 +0000 | [diff] [blame] | 376 | bool MallocChecker::SummarizeValue(raw_ostream &os, SVal V) { |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 377 | if (nonloc::ConcreteInt *IntVal = dyn_cast<nonloc::ConcreteInt>(&V)) |
| 378 | os << "an integer (" << IntVal->getValue() << ")"; |
| 379 | else if (loc::ConcreteInt *ConstAddr = dyn_cast<loc::ConcreteInt>(&V)) |
| 380 | os << "a constant address (" << ConstAddr->getValue() << ")"; |
| 381 | else if (loc::GotoLabel *Label = dyn_cast<loc::GotoLabel>(&V)) |
Chris Lattner | 6810630 | 2011-02-17 05:38:27 +0000 | [diff] [blame] | 382 | os << "the address of the label '" << Label->getLabel()->getName() << "'"; |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 383 | else |
| 384 | return false; |
| 385 | |
| 386 | return true; |
| 387 | } |
| 388 | |
Ted Kremenek | 9c378f7 | 2011-08-12 23:37:29 +0000 | [diff] [blame] | 389 | bool MallocChecker::SummarizeRegion(raw_ostream &os, |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 390 | const MemRegion *MR) { |
| 391 | switch (MR->getKind()) { |
| 392 | case MemRegion::FunctionTextRegionKind: { |
| 393 | const FunctionDecl *FD = cast<FunctionTextRegion>(MR)->getDecl(); |
| 394 | if (FD) |
Benjamin Kramer | b8989f2 | 2011-10-14 18:45:37 +0000 | [diff] [blame] | 395 | os << "the address of the function '" << *FD << '\''; |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 396 | else |
| 397 | os << "the address of a function"; |
| 398 | return true; |
| 399 | } |
| 400 | case MemRegion::BlockTextRegionKind: |
| 401 | os << "block text"; |
| 402 | return true; |
| 403 | case MemRegion::BlockDataRegionKind: |
| 404 | // FIXME: where the block came from? |
| 405 | os << "a block"; |
| 406 | return true; |
| 407 | default: { |
| 408 | const MemSpaceRegion *MS = MR->getMemorySpace(); |
| 409 | |
Anna Zaks | eb31a76 | 2012-01-04 23:54:01 +0000 | [diff] [blame] | 410 | if (isa<StackLocalsSpaceRegion>(MS)) { |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 411 | const VarRegion *VR = dyn_cast<VarRegion>(MR); |
| 412 | const VarDecl *VD; |
| 413 | if (VR) |
| 414 | VD = VR->getDecl(); |
| 415 | else |
| 416 | VD = NULL; |
| 417 | |
| 418 | if (VD) |
| 419 | os << "the address of the local variable '" << VD->getName() << "'"; |
| 420 | else |
| 421 | os << "the address of a local stack variable"; |
| 422 | return true; |
| 423 | } |
Anna Zaks | eb31a76 | 2012-01-04 23:54:01 +0000 | [diff] [blame] | 424 | |
| 425 | if (isa<StackArgumentsSpaceRegion>(MS)) { |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 426 | const VarRegion *VR = dyn_cast<VarRegion>(MR); |
| 427 | const VarDecl *VD; |
| 428 | if (VR) |
| 429 | VD = VR->getDecl(); |
| 430 | else |
| 431 | VD = NULL; |
| 432 | |
| 433 | if (VD) |
| 434 | os << "the address of the parameter '" << VD->getName() << "'"; |
| 435 | else |
| 436 | os << "the address of a parameter"; |
| 437 | return true; |
| 438 | } |
Anna Zaks | eb31a76 | 2012-01-04 23:54:01 +0000 | [diff] [blame] | 439 | |
| 440 | if (isa<GlobalsSpaceRegion>(MS)) { |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 441 | const VarRegion *VR = dyn_cast<VarRegion>(MR); |
| 442 | const VarDecl *VD; |
| 443 | if (VR) |
| 444 | VD = VR->getDecl(); |
| 445 | else |
| 446 | VD = NULL; |
| 447 | |
| 448 | if (VD) { |
| 449 | if (VD->isStaticLocal()) |
| 450 | os << "the address of the static variable '" << VD->getName() << "'"; |
| 451 | else |
| 452 | os << "the address of the global variable '" << VD->getName() << "'"; |
| 453 | } else |
| 454 | os << "the address of a global variable"; |
| 455 | return true; |
| 456 | } |
Anna Zaks | eb31a76 | 2012-01-04 23:54:01 +0000 | [diff] [blame] | 457 | |
| 458 | return false; |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 459 | } |
| 460 | } |
| 461 | } |
| 462 | |
| 463 | void MallocChecker::ReportBadFree(CheckerContext &C, SVal ArgVal, |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 464 | SourceRange range) const { |
Ted Kremenek | d048c6e | 2010-12-20 21:19:09 +0000 | [diff] [blame] | 465 | if (ExplodedNode *N = C.generateSink()) { |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 466 | if (!BT_BadFree) |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 467 | BT_BadFree.reset(new BuiltinBug("Bad free")); |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 468 | |
| 469 | llvm::SmallString<100> buf; |
| 470 | llvm::raw_svector_ostream os(buf); |
| 471 | |
| 472 | const MemRegion *MR = ArgVal.getAsRegion(); |
| 473 | if (MR) { |
| 474 | while (const ElementRegion *ER = dyn_cast<ElementRegion>(MR)) |
| 475 | MR = ER->getSuperRegion(); |
| 476 | |
| 477 | // Special case for alloca() |
| 478 | if (isa<AllocaRegion>(MR)) |
| 479 | os << "Argument to free() was allocated by alloca(), not malloc()"; |
| 480 | else { |
| 481 | os << "Argument to free() is "; |
| 482 | if (SummarizeRegion(os, MR)) |
| 483 | os << ", which is not memory allocated by malloc()"; |
| 484 | else |
| 485 | os << "not memory allocated by malloc()"; |
| 486 | } |
| 487 | } else { |
| 488 | os << "Argument to free() is "; |
| 489 | if (SummarizeValue(os, ArgVal)) |
| 490 | os << ", which is not memory allocated by malloc()"; |
| 491 | else |
| 492 | os << "not memory allocated by malloc()"; |
| 493 | } |
| 494 | |
Anna Zaks | e172e8b | 2011-08-17 23:00:25 +0000 | [diff] [blame] | 495 | BugReport *R = new BugReport(*BT_BadFree, os.str(), N); |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 496 | R->addRange(range); |
| 497 | C.EmitReport(R); |
| 498 | } |
| 499 | } |
| 500 | |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 501 | void MallocChecker::ReallocMem(CheckerContext &C, const CallExpr *CE) const { |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 502 | const ProgramState *state = C.getState(); |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 503 | const Expr *arg0Expr = CE->getArg(0); |
| 504 | DefinedOrUnknownSVal arg0Val |
| 505 | = cast<DefinedOrUnknownSVal>(state->getSVal(arg0Expr)); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 506 | |
Ted Kremenek | 846eabd | 2010-12-01 21:28:31 +0000 | [diff] [blame] | 507 | SValBuilder &svalBuilder = C.getSValBuilder(); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 508 | |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 509 | DefinedOrUnknownSVal PtrEQ = |
| 510 | svalBuilder.evalEQ(state, arg0Val, svalBuilder.makeNull()); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 511 | |
Lenny Maiorani | 4d8d803 | 2011-04-27 14:49:29 +0000 | [diff] [blame] | 512 | // Get the size argument. If there is no size arg then give up. |
| 513 | const Expr *Arg1 = CE->getArg(1); |
| 514 | if (!Arg1) |
| 515 | return; |
| 516 | |
| 517 | // Get the value of the size argument. |
| 518 | DefinedOrUnknownSVal Arg1Val = |
| 519 | cast<DefinedOrUnknownSVal>(state->getSVal(Arg1)); |
| 520 | |
| 521 | // Compare the size argument to 0. |
| 522 | DefinedOrUnknownSVal SizeZero = |
| 523 | svalBuilder.evalEQ(state, Arg1Val, |
| 524 | svalBuilder.makeIntValWithPtrWidth(0, false)); |
| 525 | |
| 526 | // If the ptr is NULL and the size is not 0, the call is equivalent to |
| 527 | // malloc(size). |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 528 | const ProgramState *stateEqual = state->assume(PtrEQ, true); |
Lenny Maiorani | 4d8d803 | 2011-04-27 14:49:29 +0000 | [diff] [blame] | 529 | if (stateEqual && state->assume(SizeZero, false)) { |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 530 | // Hack: set the NULL symbolic region to released to suppress false warning. |
| 531 | // In the future we should add more states for allocated regions, e.g., |
| 532 | // CheckedNull, CheckedNonNull. |
| 533 | |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 534 | SymbolRef Sym = arg0Val.getAsLocSymbol(); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 535 | if (Sym) |
| 536 | stateEqual = stateEqual->set<RegionState>(Sym, RefState::getReleased(CE)); |
| 537 | |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 538 | const ProgramState *stateMalloc = MallocMemAux(C, CE, CE->getArg(1), |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 539 | UndefinedVal(), stateEqual); |
Anna Zaks | 0bd6b11 | 2011-10-26 21:06:34 +0000 | [diff] [blame] | 540 | C.addTransition(stateMalloc); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 541 | } |
| 542 | |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 543 | if (const ProgramState *stateNotEqual = state->assume(PtrEQ, false)) { |
Lenny Maiorani | 4d8d803 | 2011-04-27 14:49:29 +0000 | [diff] [blame] | 544 | // If the size is 0, free the memory. |
Ted Kremenek | e3659a7 | 2012-01-04 23:48:37 +0000 | [diff] [blame] | 545 | if (const ProgramState *stateSizeZero = |
| 546 | stateNotEqual->assume(SizeZero, true)) |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 547 | if (const ProgramState *stateFree = |
Lenny Maiorani | 4d8d803 | 2011-04-27 14:49:29 +0000 | [diff] [blame] | 548 | FreeMemAux(C, CE, stateSizeZero, 0, false)) { |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 549 | |
Zhongxing Xu | d56763f | 2011-09-01 04:53:59 +0000 | [diff] [blame] | 550 | // Bind the return value to NULL because it is now free. |
Anna Zaks | 0bd6b11 | 2011-10-26 21:06:34 +0000 | [diff] [blame] | 551 | C.addTransition(stateFree->BindExpr(CE, svalBuilder.makeNull(), true)); |
Lenny Maiorani | 4d8d803 | 2011-04-27 14:49:29 +0000 | [diff] [blame] | 552 | } |
Ted Kremenek | e3659a7 | 2012-01-04 23:48:37 +0000 | [diff] [blame] | 553 | if (const ProgramState *stateSizeNotZero = |
| 554 | stateNotEqual->assume(SizeZero,false)) |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 555 | if (const ProgramState *stateFree = FreeMemAux(C, CE, stateSizeNotZero, |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 556 | 0, false)) { |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 557 | // FIXME: We should copy the content of the original buffer. |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 558 | const ProgramState *stateRealloc = MallocMemAux(C, CE, CE->getArg(1), |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 559 | UnknownVal(), stateFree); |
Anna Zaks | 0bd6b11 | 2011-10-26 21:06:34 +0000 | [diff] [blame] | 560 | C.addTransition(stateRealloc); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 561 | } |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 562 | } |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 563 | } |
Zhongxing Xu | 7b76096 | 2009-11-13 07:25:27 +0000 | [diff] [blame] | 564 | |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 565 | void MallocChecker::CallocMem(CheckerContext &C, const CallExpr *CE) { |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 566 | const ProgramState *state = C.getState(); |
Ted Kremenek | 846eabd | 2010-12-01 21:28:31 +0000 | [diff] [blame] | 567 | SValBuilder &svalBuilder = C.getSValBuilder(); |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 568 | |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 569 | SVal count = state->getSVal(CE->getArg(0)); |
| 570 | SVal elementSize = state->getSVal(CE->getArg(1)); |
| 571 | SVal TotalSize = svalBuilder.evalBinOp(state, BO_Mul, count, elementSize, |
| 572 | svalBuilder.getContext().getSizeType()); |
| 573 | SVal zeroVal = svalBuilder.makeZeroVal(svalBuilder.getContext().CharTy); |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 574 | |
Anna Zaks | 0bd6b11 | 2011-10-26 21:06:34 +0000 | [diff] [blame] | 575 | C.addTransition(MallocMemAux(C, CE, TotalSize, zeroVal, state)); |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 576 | } |
| 577 | |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 578 | void MallocChecker::checkDeadSymbols(SymbolReaper &SymReaper, |
| 579 | CheckerContext &C) const |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 580 | { |
Zhongxing Xu | 173ff56 | 2010-08-15 08:19:57 +0000 | [diff] [blame] | 581 | if (!SymReaper.hasDeadSymbols()) |
| 582 | return; |
Zhongxing Xu | fc7ac8f | 2009-11-13 07:48:11 +0000 | [diff] [blame] | 583 | |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 584 | const ProgramState *state = C.getState(); |
Zhongxing Xu | 173ff56 | 2010-08-15 08:19:57 +0000 | [diff] [blame] | 585 | RegionStateTy RS = state->get<RegionState>(); |
Jordy Rose | 9076014 | 2010-08-18 04:33:47 +0000 | [diff] [blame] | 586 | RegionStateTy::Factory &F = state->get_context<RegionState>(); |
Zhongxing Xu | 173ff56 | 2010-08-15 08:19:57 +0000 | [diff] [blame] | 587 | |
Ted Kremenek | 217470e | 2011-07-28 23:07:51 +0000 | [diff] [blame] | 588 | bool generateReport = false; |
| 589 | |
Zhongxing Xu | 173ff56 | 2010-08-15 08:19:57 +0000 | [diff] [blame] | 590 | for (RegionStateTy::iterator I = RS.begin(), E = RS.end(); I != E; ++I) { |
| 591 | if (SymReaper.isDead(I->first)) { |
Ted Kremenek | 217470e | 2011-07-28 23:07:51 +0000 | [diff] [blame] | 592 | if (I->second.isAllocated()) |
| 593 | generateReport = true; |
Jordy Rose | 9076014 | 2010-08-18 04:33:47 +0000 | [diff] [blame] | 594 | |
| 595 | // Remove the dead symbol from the map. |
Ted Kremenek | 3baf672 | 2010-11-24 00:54:37 +0000 | [diff] [blame] | 596 | RS = F.remove(RS, I->first); |
Ted Kremenek | 217470e | 2011-07-28 23:07:51 +0000 | [diff] [blame] | 597 | |
Zhongxing Xu | fc7ac8f | 2009-11-13 07:48:11 +0000 | [diff] [blame] | 598 | } |
| 599 | } |
Ted Kremenek | 217470e | 2011-07-28 23:07:51 +0000 | [diff] [blame] | 600 | |
Anna Zaks | 0bd6b11 | 2011-10-26 21:06:34 +0000 | [diff] [blame] | 601 | ExplodedNode *N = C.addTransition(state->set<RegionState>(RS)); |
Ted Kremenek | 217470e | 2011-07-28 23:07:51 +0000 | [diff] [blame] | 602 | |
| 603 | // FIXME: This does not handle when we have multiple leaks at a single |
| 604 | // place. |
| 605 | if (N && generateReport) { |
| 606 | if (!BT_Leak) |
| 607 | BT_Leak.reset(new BuiltinBug("Memory leak", |
| 608 | "Allocated memory never released. Potential memory leak.")); |
| 609 | // FIXME: where it is allocated. |
| 610 | BugReport *R = new BugReport(*BT_Leak, BT_Leak->getDescription(), N); |
| 611 | C.EmitReport(R); |
| 612 | } |
Zhongxing Xu | 7b76096 | 2009-11-13 07:25:27 +0000 | [diff] [blame] | 613 | } |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 614 | |
Anna Zaks | af498a2 | 2011-10-25 19:56:48 +0000 | [diff] [blame] | 615 | void MallocChecker::checkEndPath(CheckerContext &Ctx) const { |
| 616 | const ProgramState *state = Ctx.getState(); |
Jordy Rose | 09cef09 | 2010-08-18 04:26:59 +0000 | [diff] [blame] | 617 | RegionStateTy M = state->get<RegionState>(); |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 618 | |
Jordy Rose | 09cef09 | 2010-08-18 04:26:59 +0000 | [diff] [blame] | 619 | for (RegionStateTy::iterator I = M.begin(), E = M.end(); I != E; ++I) { |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 620 | RefState RS = I->second; |
| 621 | if (RS.isAllocated()) { |
Anna Zaks | 0bd6b11 | 2011-10-26 21:06:34 +0000 | [diff] [blame] | 622 | ExplodedNode *N = Ctx.addTransition(state); |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 623 | if (N) { |
| 624 | if (!BT_Leak) |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 625 | BT_Leak.reset(new BuiltinBug("Memory leak", |
| 626 | "Allocated memory never released. Potential memory leak.")); |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 627 | BugReport *R = new BugReport(*BT_Leak, BT_Leak->getDescription(), N); |
Anna Zaks | af498a2 | 2011-10-25 19:56:48 +0000 | [diff] [blame] | 628 | Ctx.EmitReport(R); |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 629 | } |
| 630 | } |
| 631 | } |
| 632 | } |
Zhongxing Xu | 4985e3e | 2009-11-17 08:58:18 +0000 | [diff] [blame] | 633 | |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 634 | void MallocChecker::checkPreStmt(const ReturnStmt *S, CheckerContext &C) const { |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 635 | const Expr *retExpr = S->getRetValue(); |
| 636 | if (!retExpr) |
Zhongxing Xu | 4985e3e | 2009-11-17 08:58:18 +0000 | [diff] [blame] | 637 | return; |
| 638 | |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 639 | const ProgramState *state = C.getState(); |
Zhongxing Xu | 4985e3e | 2009-11-17 08:58:18 +0000 | [diff] [blame] | 640 | |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 641 | SymbolRef Sym = state->getSVal(retExpr).getAsSymbol(); |
Zhongxing Xu | 4985e3e | 2009-11-17 08:58:18 +0000 | [diff] [blame] | 642 | if (!Sym) |
| 643 | return; |
| 644 | |
| 645 | const RefState *RS = state->get<RegionState>(Sym); |
| 646 | if (!RS) |
| 647 | return; |
| 648 | |
| 649 | // FIXME: check other cases. |
| 650 | if (RS->isAllocated()) |
| 651 | state = state->set<RegionState>(Sym, RefState::getEscaped(S)); |
| 652 | |
Anna Zaks | 0bd6b11 | 2011-10-26 21:06:34 +0000 | [diff] [blame] | 653 | C.addTransition(state); |
Zhongxing Xu | 4985e3e | 2009-11-17 08:58:18 +0000 | [diff] [blame] | 654 | } |
Zhongxing Xu | b94b81a | 2009-12-31 06:13:07 +0000 | [diff] [blame] | 655 | |
Ted Kremenek | e3659a7 | 2012-01-04 23:48:37 +0000 | [diff] [blame] | 656 | const ProgramState *MallocChecker::evalAssume(const ProgramState *state, |
| 657 | SVal Cond, |
| 658 | bool Assumption) const { |
Zhongxing Xu | b94b81a | 2009-12-31 06:13:07 +0000 | [diff] [blame] | 659 | // If a symblic region is assumed to NULL, set its state to AllocateFailed. |
| 660 | // FIXME: should also check symbols assumed to non-null. |
| 661 | |
| 662 | RegionStateTy RS = state->get<RegionState>(); |
| 663 | |
| 664 | for (RegionStateTy::iterator I = RS.begin(), E = RS.end(); I != E; ++I) { |
Zhongxing Xu | 2bfa301 | 2011-04-02 03:20:45 +0000 | [diff] [blame] | 665 | // If the symbol is assumed to NULL, this will return an APSInt*. |
Zhongxing Xu | b94b81a | 2009-12-31 06:13:07 +0000 | [diff] [blame] | 666 | if (state->getSymVal(I.getKey())) |
| 667 | state = state->set<RegionState>(I.getKey(),RefState::getAllocateFailed()); |
| 668 | } |
| 669 | |
| 670 | return state; |
| 671 | } |
Zhongxing Xu | c802378 | 2010-03-10 04:58:55 +0000 | [diff] [blame] | 672 | |
| 673 | // Check if the location is a freed symbolic region. |
Anna Zaks | 390909c | 2011-10-06 00:43:15 +0000 | [diff] [blame] | 674 | void MallocChecker::checkLocation(SVal l, bool isLoad, const Stmt *S, |
| 675 | CheckerContext &C) const { |
Zhongxing Xu | c802378 | 2010-03-10 04:58:55 +0000 | [diff] [blame] | 676 | SymbolRef Sym = l.getLocSymbolInBase(); |
| 677 | if (Sym) { |
| 678 | const RefState *RS = C.getState()->get<RegionState>(Sym); |
Ted Kremenek | cea6865 | 2010-08-06 21:12:49 +0000 | [diff] [blame] | 679 | if (RS && RS->isReleased()) { |
Anna Zaks | 0bd6b11 | 2011-10-26 21:06:34 +0000 | [diff] [blame] | 680 | if (ExplodedNode *N = C.addTransition()) { |
Zhongxing Xu | c802378 | 2010-03-10 04:58:55 +0000 | [diff] [blame] | 681 | if (!BT_UseFree) |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 682 | BT_UseFree.reset(new BuiltinBug("Use dynamically allocated memory " |
| 683 | "after it is freed.")); |
Zhongxing Xu | c802378 | 2010-03-10 04:58:55 +0000 | [diff] [blame] | 684 | |
| 685 | BugReport *R = new BugReport(*BT_UseFree, BT_UseFree->getDescription(), |
| 686 | N); |
| 687 | C.EmitReport(R); |
| 688 | } |
Ted Kremenek | cea6865 | 2010-08-06 21:12:49 +0000 | [diff] [blame] | 689 | } |
Zhongxing Xu | c802378 | 2010-03-10 04:58:55 +0000 | [diff] [blame] | 690 | } |
| 691 | } |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 692 | |
Anna Zaks | 390909c | 2011-10-06 00:43:15 +0000 | [diff] [blame] | 693 | void MallocChecker::checkBind(SVal location, SVal val, |
| 694 | const Stmt *BindS, CheckerContext &C) const { |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 695 | // The PreVisitBind implements the same algorithm as already used by the |
| 696 | // Objective C ownership checker: if the pointer escaped from this scope by |
| 697 | // assignment, let it go. However, assigning to fields of a stack-storage |
| 698 | // structure does not transfer ownership. |
| 699 | |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 700 | const ProgramState *state = C.getState(); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 701 | DefinedOrUnknownSVal l = cast<DefinedOrUnknownSVal>(location); |
| 702 | |
| 703 | // Check for null dereferences. |
| 704 | if (!isa<Loc>(l)) |
| 705 | return; |
| 706 | |
| 707 | // Before checking if the state is null, check if 'val' has a RefState. |
| 708 | // Only then should we check for null and bifurcate the state. |
| 709 | SymbolRef Sym = val.getLocSymbolInBase(); |
| 710 | if (Sym) { |
| 711 | if (const RefState *RS = state->get<RegionState>(Sym)) { |
| 712 | // If ptr is NULL, no operation is performed. |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 713 | const ProgramState *notNullState, *nullState; |
Ted Kremenek | 28f47b9 | 2010-12-01 22:16:56 +0000 | [diff] [blame] | 714 | llvm::tie(notNullState, nullState) = state->assume(l); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 715 | |
| 716 | // Generate a transition for 'nullState' to record the assumption |
| 717 | // that the state was null. |
| 718 | if (nullState) |
Anna Zaks | 0bd6b11 | 2011-10-26 21:06:34 +0000 | [diff] [blame] | 719 | C.addTransition(nullState); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 720 | |
| 721 | if (!notNullState) |
| 722 | return; |
| 723 | |
| 724 | if (RS->isAllocated()) { |
| 725 | // Something we presently own is being assigned somewhere. |
| 726 | const MemRegion *AR = location.getAsRegion(); |
| 727 | if (!AR) |
| 728 | return; |
| 729 | AR = AR->StripCasts()->getBaseRegion(); |
| 730 | do { |
| 731 | // If it is on the stack, we still own it. |
| 732 | if (AR->hasStackNonParametersStorage()) |
| 733 | break; |
| 734 | |
| 735 | // If the state can't represent this binding, we still own it. |
Ted Kremenek | dde201b | 2010-08-06 21:12:55 +0000 | [diff] [blame] | 736 | if (notNullState == (notNullState->bindLoc(cast<Loc>(location), |
| 737 | UnknownVal()))) |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 738 | break; |
| 739 | |
| 740 | // We no longer own this pointer. |
Ted Kremenek | dde201b | 2010-08-06 21:12:55 +0000 | [diff] [blame] | 741 | notNullState = |
| 742 | notNullState->set<RegionState>(Sym, |
Anna Zaks | 390909c | 2011-10-06 00:43:15 +0000 | [diff] [blame] | 743 | RefState::getRelinquished(BindS)); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 744 | } |
| 745 | while (false); |
| 746 | } |
Anna Zaks | 0bd6b11 | 2011-10-26 21:06:34 +0000 | [diff] [blame] | 747 | C.addTransition(notNullState); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 748 | } |
| 749 | } |
| 750 | } |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 751 | |
| 752 | void ento::registerMallocChecker(CheckerManager &mgr) { |
| 753 | mgr.registerChecker<MallocChecker>(); |
| 754 | } |