Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 1 | //=== MallocChecker.cpp - A malloc/free checker -------------------*- C++ -*--// |
| 2 | // |
| 3 | // The LLVM Compiler Infrastructure |
| 4 | // |
| 5 | // This file is distributed under the University of Illinois Open Source |
| 6 | // License. See LICENSE.TXT for details. |
| 7 | // |
| 8 | //===----------------------------------------------------------------------===// |
| 9 | // |
| 10 | // This file defines malloc/free checker, which checks for potential memory |
| 11 | // leaks, double free, and use-after-free problems. |
| 12 | // |
| 13 | //===----------------------------------------------------------------------===// |
| 14 | |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 15 | #include "ClangSACheckers.h" |
Argyrios Kyrtzidis | ec8605f | 2011-03-01 01:16:21 +0000 | [diff] [blame] | 16 | #include "clang/StaticAnalyzer/Core/Checker.h" |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 17 | #include "clang/StaticAnalyzer/Core/CheckerManager.h" |
| 18 | #include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h" |
Ted Kremenek | 9b66371 | 2011-02-10 01:03:03 +0000 | [diff] [blame] | 19 | #include "clang/StaticAnalyzer/Core/BugReporter/BugType.h" |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 20 | #include "clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h" |
| 21 | #include "clang/StaticAnalyzer/Core/PathSensitive/ProgramStateTrait.h" |
Ted Kremenek | 9b66371 | 2011-02-10 01:03:03 +0000 | [diff] [blame] | 22 | #include "clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h" |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 23 | #include "llvm/ADT/ImmutableMap.h" |
| 24 | using namespace clang; |
Ted Kremenek | 9ef6537 | 2010-12-23 07:20:52 +0000 | [diff] [blame] | 25 | using namespace ento; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 26 | |
| 27 | namespace { |
| 28 | |
Zhongxing Xu | 7fb1464 | 2009-12-11 00:55:44 +0000 | [diff] [blame] | 29 | class RefState { |
Ted Kremenek | dde201b | 2010-08-06 21:12:55 +0000 | [diff] [blame] | 30 | enum Kind { AllocateUnchecked, AllocateFailed, Released, Escaped, |
| 31 | Relinquished } K; |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 32 | const Stmt *S; |
| 33 | |
Zhongxing Xu | 7fb1464 | 2009-12-11 00:55:44 +0000 | [diff] [blame] | 34 | public: |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 35 | RefState(Kind k, const Stmt *s) : K(k), S(s) {} |
| 36 | |
Zhongxing Xu | b94b81a | 2009-12-31 06:13:07 +0000 | [diff] [blame] | 37 | bool isAllocated() const { return K == AllocateUnchecked; } |
Chris Lattner | fae9622 | 2010-09-03 04:34:38 +0000 | [diff] [blame] | 38 | //bool isFailed() const { return K == AllocateFailed; } |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 39 | bool isReleased() const { return K == Released; } |
Chris Lattner | fae9622 | 2010-09-03 04:34:38 +0000 | [diff] [blame] | 40 | //bool isEscaped() const { return K == Escaped; } |
| 41 | //bool isRelinquished() const { return K == Relinquished; } |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 42 | |
| 43 | bool operator==(const RefState &X) const { |
| 44 | return K == X.K && S == X.S; |
| 45 | } |
| 46 | |
Zhongxing Xu | b94b81a | 2009-12-31 06:13:07 +0000 | [diff] [blame] | 47 | static RefState getAllocateUnchecked(const Stmt *s) { |
| 48 | return RefState(AllocateUnchecked, s); |
| 49 | } |
| 50 | static RefState getAllocateFailed() { |
| 51 | return RefState(AllocateFailed, 0); |
| 52 | } |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 53 | static RefState getReleased(const Stmt *s) { return RefState(Released, s); } |
| 54 | static RefState getEscaped(const Stmt *s) { return RefState(Escaped, s); } |
Ted Kremenek | dde201b | 2010-08-06 21:12:55 +0000 | [diff] [blame] | 55 | static RefState getRelinquished(const Stmt *s) { |
| 56 | return RefState(Relinquished, s); |
| 57 | } |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 58 | |
| 59 | void Profile(llvm::FoldingSetNodeID &ID) const { |
| 60 | ID.AddInteger(K); |
| 61 | ID.AddPointer(S); |
| 62 | } |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 63 | }; |
| 64 | |
Kovarththanan Rajaratnam | ba5fb5a | 2009-11-28 06:07:30 +0000 | [diff] [blame] | 65 | class RegionState {}; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 66 | |
Argyrios Kyrtzidis | ec8605f | 2011-03-01 01:16:21 +0000 | [diff] [blame] | 67 | class MallocChecker : public Checker<eval::Call, check::DeadSymbols, check::EndPath, check::PreStmt<ReturnStmt>, check::Location, |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 68 | check::Bind, eval::Assume> { |
| 69 | mutable llvm::OwningPtr<BuiltinBug> BT_DoubleFree; |
| 70 | mutable llvm::OwningPtr<BuiltinBug> BT_Leak; |
| 71 | mutable llvm::OwningPtr<BuiltinBug> BT_UseFree; |
| 72 | mutable llvm::OwningPtr<BuiltinBug> BT_UseRelinquished; |
| 73 | mutable llvm::OwningPtr<BuiltinBug> BT_BadFree; |
| 74 | mutable IdentifierInfo *II_malloc, *II_free, *II_realloc, *II_calloc; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 75 | |
| 76 | public: |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 77 | MallocChecker() : II_malloc(0), II_free(0), II_realloc(0), II_calloc(0) {} |
| 78 | |
| 79 | bool evalCall(const CallExpr *CE, CheckerContext &C) const; |
| 80 | void checkDeadSymbols(SymbolReaper &SymReaper, CheckerContext &C) const; |
Anna Zaks | af498a2 | 2011-10-25 19:56:48 +0000 | [diff] [blame] | 81 | void checkEndPath(CheckerContext &C) const; |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 82 | void checkPreStmt(const ReturnStmt *S, CheckerContext &C) const; |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 83 | const ProgramState *evalAssume(const ProgramState *state, SVal Cond, |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 84 | bool Assumption) const; |
Anna Zaks | 390909c | 2011-10-06 00:43:15 +0000 | [diff] [blame] | 85 | void checkLocation(SVal l, bool isLoad, const Stmt *S, |
| 86 | CheckerContext &C) const; |
| 87 | void checkBind(SVal location, SVal val, const Stmt*S, |
| 88 | CheckerContext &C) const; |
Zhongxing Xu | b94b81a | 2009-12-31 06:13:07 +0000 | [diff] [blame] | 89 | |
Zhongxing Xu | 7b76096 | 2009-11-13 07:25:27 +0000 | [diff] [blame] | 90 | private: |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 91 | static void MallocMem(CheckerContext &C, const CallExpr *CE); |
| 92 | static void MallocMemReturnsAttr(CheckerContext &C, const CallExpr *CE, |
| 93 | const OwnershipAttr* Att); |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 94 | static const ProgramState *MallocMemAux(CheckerContext &C, const CallExpr *CE, |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 95 | const Expr *SizeEx, SVal Init, |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 96 | const ProgramState *state) { |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 97 | return MallocMemAux(C, CE, state->getSVal(SizeEx), Init, state); |
| 98 | } |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 99 | static const ProgramState *MallocMemAux(CheckerContext &C, const CallExpr *CE, |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 100 | SVal SizeEx, SVal Init, |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 101 | const ProgramState *state); |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 102 | |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 103 | void FreeMem(CheckerContext &C, const CallExpr *CE) const; |
Jordy Rose | 2a47992 | 2010-08-12 08:54:03 +0000 | [diff] [blame] | 104 | void FreeMemAttr(CheckerContext &C, const CallExpr *CE, |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 105 | const OwnershipAttr* Att) const; |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 106 | const ProgramState *FreeMemAux(CheckerContext &C, const CallExpr *CE, |
| 107 | const ProgramState *state, unsigned Num, bool Hold) const; |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 108 | |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 109 | void ReallocMem(CheckerContext &C, const CallExpr *CE) const; |
| 110 | static void CallocMem(CheckerContext &C, const CallExpr *CE); |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 111 | |
Ted Kremenek | 9c378f7 | 2011-08-12 23:37:29 +0000 | [diff] [blame] | 112 | static bool SummarizeValue(raw_ostream &os, SVal V); |
| 113 | static bool SummarizeRegion(raw_ostream &os, const MemRegion *MR); |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 114 | void ReportBadFree(CheckerContext &C, SVal ArgVal, SourceRange range) const; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 115 | }; |
Kovarththanan Rajaratnam | ba5fb5a | 2009-11-28 06:07:30 +0000 | [diff] [blame] | 116 | } // end anonymous namespace |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 117 | |
Zhongxing Xu | b94b81a | 2009-12-31 06:13:07 +0000 | [diff] [blame] | 118 | typedef llvm::ImmutableMap<SymbolRef, RefState> RegionStateTy; |
| 119 | |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 120 | namespace clang { |
Ted Kremenek | 9ef6537 | 2010-12-23 07:20:52 +0000 | [diff] [blame] | 121 | namespace ento { |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 122 | template <> |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 123 | struct ProgramStateTrait<RegionState> |
| 124 | : public ProgramStatePartialTrait<RegionStateTy> { |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 125 | static void *GDMIndex() { static int x; return &x; } |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 126 | }; |
| 127 | } |
Argyrios Kyrtzidis | 5a4f98f | 2010-12-22 18:53:20 +0000 | [diff] [blame] | 128 | } |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 129 | |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 130 | bool MallocChecker::evalCall(const CallExpr *CE, CheckerContext &C) const { |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 131 | const ProgramState *state = C.getState(); |
Zhongxing Xu | a49c6b7 | 2009-12-11 03:09:01 +0000 | [diff] [blame] | 132 | const Expr *Callee = CE->getCallee(); |
Ted Kremenek | 1397663 | 2010-02-08 16:18:51 +0000 | [diff] [blame] | 133 | SVal L = state->getSVal(Callee); |
Zhongxing Xu | a49c6b7 | 2009-12-11 03:09:01 +0000 | [diff] [blame] | 134 | |
| 135 | const FunctionDecl *FD = L.getAsFunctionDecl(); |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 136 | if (!FD) |
Zhongxing Xu | a49c6b7 | 2009-12-11 03:09:01 +0000 | [diff] [blame] | 137 | return false; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 138 | |
| 139 | ASTContext &Ctx = C.getASTContext(); |
| 140 | if (!II_malloc) |
| 141 | II_malloc = &Ctx.Idents.get("malloc"); |
| 142 | if (!II_free) |
Zhongxing Xu | fc7ac8f | 2009-11-13 07:48:11 +0000 | [diff] [blame] | 143 | II_free = &Ctx.Idents.get("free"); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 144 | if (!II_realloc) |
| 145 | II_realloc = &Ctx.Idents.get("realloc"); |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 146 | if (!II_calloc) |
| 147 | II_calloc = &Ctx.Idents.get("calloc"); |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 148 | |
| 149 | if (FD->getIdentifier() == II_malloc) { |
| 150 | MallocMem(C, CE); |
Zhongxing Xu | a49c6b7 | 2009-12-11 03:09:01 +0000 | [diff] [blame] | 151 | return true; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 152 | } |
| 153 | |
| 154 | if (FD->getIdentifier() == II_free) { |
| 155 | FreeMem(C, CE); |
Zhongxing Xu | a49c6b7 | 2009-12-11 03:09:01 +0000 | [diff] [blame] | 156 | return true; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 157 | } |
Zhongxing Xu | a49c6b7 | 2009-12-11 03:09:01 +0000 | [diff] [blame] | 158 | |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 159 | if (FD->getIdentifier() == II_realloc) { |
| 160 | ReallocMem(C, CE); |
| 161 | return true; |
| 162 | } |
| 163 | |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 164 | if (FD->getIdentifier() == II_calloc) { |
| 165 | CallocMem(C, CE); |
| 166 | return true; |
| 167 | } |
| 168 | |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 169 | // Check all the attributes, if there are any. |
| 170 | // There can be multiple of these attributes. |
| 171 | bool rv = false; |
| 172 | if (FD->hasAttrs()) { |
Sean Hunt | cf807c4 | 2010-08-18 23:23:40 +0000 | [diff] [blame] | 173 | for (specific_attr_iterator<OwnershipAttr> |
| 174 | i = FD->specific_attr_begin<OwnershipAttr>(), |
| 175 | e = FD->specific_attr_end<OwnershipAttr>(); |
| 176 | i != e; ++i) { |
| 177 | switch ((*i)->getOwnKind()) { |
| 178 | case OwnershipAttr::Returns: { |
| 179 | MallocMemReturnsAttr(C, CE, *i); |
Jordy Rose | 2a47992 | 2010-08-12 08:54:03 +0000 | [diff] [blame] | 180 | rv = true; |
| 181 | break; |
Sean Hunt | cf807c4 | 2010-08-18 23:23:40 +0000 | [diff] [blame] | 182 | } |
| 183 | case OwnershipAttr::Takes: |
| 184 | case OwnershipAttr::Holds: { |
| 185 | FreeMemAttr(C, CE, *i); |
Jordy Rose | 2a47992 | 2010-08-12 08:54:03 +0000 | [diff] [blame] | 186 | rv = true; |
| 187 | break; |
Sean Hunt | cf807c4 | 2010-08-18 23:23:40 +0000 | [diff] [blame] | 188 | } |
Jordy Rose | 2a47992 | 2010-08-12 08:54:03 +0000 | [diff] [blame] | 189 | default: |
Jordy Rose | 2a47992 | 2010-08-12 08:54:03 +0000 | [diff] [blame] | 190 | break; |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 191 | } |
| 192 | } |
| 193 | } |
| 194 | return rv; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 195 | } |
| 196 | |
| 197 | void MallocChecker::MallocMem(CheckerContext &C, const CallExpr *CE) { |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 198 | const ProgramState *state = MallocMemAux(C, CE, CE->getArg(0), UndefinedVal(), |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 199 | C.getState()); |
Anna Zaks | 0bd6b11 | 2011-10-26 21:06:34 +0000 | [diff] [blame^] | 200 | C.addTransition(state); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 201 | } |
| 202 | |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 203 | void MallocChecker::MallocMemReturnsAttr(CheckerContext &C, const CallExpr *CE, |
| 204 | const OwnershipAttr* Att) { |
Sean Hunt | cf807c4 | 2010-08-18 23:23:40 +0000 | [diff] [blame] | 205 | if (Att->getModule() != "malloc") |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 206 | return; |
| 207 | |
Sean Hunt | cf807c4 | 2010-08-18 23:23:40 +0000 | [diff] [blame] | 208 | OwnershipAttr::args_iterator I = Att->args_begin(), E = Att->args_end(); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 209 | if (I != E) { |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 210 | const ProgramState *state = |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 211 | MallocMemAux(C, CE, CE->getArg(*I), UndefinedVal(), C.getState()); |
Anna Zaks | 0bd6b11 | 2011-10-26 21:06:34 +0000 | [diff] [blame^] | 212 | C.addTransition(state); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 213 | return; |
| 214 | } |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 215 | const ProgramState *state = MallocMemAux(C, CE, UnknownVal(), UndefinedVal(), |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 216 | C.getState()); |
Anna Zaks | 0bd6b11 | 2011-10-26 21:06:34 +0000 | [diff] [blame^] | 217 | C.addTransition(state); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 218 | } |
| 219 | |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 220 | const ProgramState *MallocChecker::MallocMemAux(CheckerContext &C, |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 221 | const CallExpr *CE, |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 222 | SVal Size, SVal Init, |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 223 | const ProgramState *state) { |
Anna Zaks | 5d0ea6d | 2011-10-04 20:43:05 +0000 | [diff] [blame] | 224 | unsigned Count = C.getCurrentBlockCount(); |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 225 | SValBuilder &svalBuilder = C.getSValBuilder(); |
Zhongxing Xu | a49c6b7 | 2009-12-11 03:09:01 +0000 | [diff] [blame] | 226 | |
Jordy Rose | 32f2656 | 2010-07-04 00:00:41 +0000 | [diff] [blame] | 227 | // Set the return value. |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 228 | SVal retVal = svalBuilder.getConjuredSymbolVal(NULL, CE, CE->getType(), Count); |
| 229 | state = state->BindExpr(CE, retVal); |
Zhongxing Xu | a49c6b7 | 2009-12-11 03:09:01 +0000 | [diff] [blame] | 230 | |
Jordy Rose | 32f2656 | 2010-07-04 00:00:41 +0000 | [diff] [blame] | 231 | // Fill the region with the initialization value. |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 232 | state = state->bindDefault(retVal, Init); |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 233 | |
Jordy Rose | 32f2656 | 2010-07-04 00:00:41 +0000 | [diff] [blame] | 234 | // Set the region's extent equal to the Size parameter. |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 235 | const SymbolicRegion *R = cast<SymbolicRegion>(retVal.getAsRegion()); |
| 236 | DefinedOrUnknownSVal Extent = R->getExtent(svalBuilder); |
Jordy Rose | 32f2656 | 2010-07-04 00:00:41 +0000 | [diff] [blame] | 237 | DefinedOrUnknownSVal DefinedSize = cast<DefinedOrUnknownSVal>(Size); |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 238 | DefinedOrUnknownSVal extentMatchesSize = |
Ted Kremenek | 9c14953 | 2010-12-01 21:57:22 +0000 | [diff] [blame] | 239 | svalBuilder.evalEQ(state, Extent, DefinedSize); |
Jordy Rose | 32f2656 | 2010-07-04 00:00:41 +0000 | [diff] [blame] | 240 | |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 241 | state = state->assume(extentMatchesSize, true); |
| 242 | assert(state); |
| 243 | |
| 244 | SymbolRef Sym = retVal.getAsLocSymbol(); |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 245 | assert(Sym); |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 246 | |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 247 | // Set the symbol's state to Allocated. |
Zhongxing Xu | b94b81a | 2009-12-31 06:13:07 +0000 | [diff] [blame] | 248 | return state->set<RegionState>(Sym, RefState::getAllocateUnchecked(CE)); |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 249 | } |
| 250 | |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 251 | void MallocChecker::FreeMem(CheckerContext &C, const CallExpr *CE) const { |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 252 | const ProgramState *state = FreeMemAux(C, CE, C.getState(), 0, false); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 253 | |
| 254 | if (state) |
Anna Zaks | 0bd6b11 | 2011-10-26 21:06:34 +0000 | [diff] [blame^] | 255 | C.addTransition(state); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 256 | } |
| 257 | |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 258 | void MallocChecker::FreeMemAttr(CheckerContext &C, const CallExpr *CE, |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 259 | const OwnershipAttr* Att) const { |
Sean Hunt | cf807c4 | 2010-08-18 23:23:40 +0000 | [diff] [blame] | 260 | if (Att->getModule() != "malloc") |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 261 | return; |
| 262 | |
Sean Hunt | cf807c4 | 2010-08-18 23:23:40 +0000 | [diff] [blame] | 263 | for (OwnershipAttr::args_iterator I = Att->args_begin(), E = Att->args_end(); |
| 264 | I != E; ++I) { |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 265 | const ProgramState *state = FreeMemAux(C, CE, C.getState(), *I, |
Sean Hunt | cf807c4 | 2010-08-18 23:23:40 +0000 | [diff] [blame] | 266 | Att->getOwnKind() == OwnershipAttr::Holds); |
| 267 | if (state) |
Anna Zaks | 0bd6b11 | 2011-10-26 21:06:34 +0000 | [diff] [blame^] | 268 | C.addTransition(state); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 269 | } |
| 270 | } |
| 271 | |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 272 | const ProgramState *MallocChecker::FreeMemAux(CheckerContext &C, const CallExpr *CE, |
| 273 | const ProgramState *state, unsigned Num, |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 274 | bool Hold) const { |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 275 | const Expr *ArgExpr = CE->getArg(Num); |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 276 | SVal ArgVal = state->getSVal(ArgExpr); |
Zhongxing Xu | 181cc3d | 2010-02-14 06:49:48 +0000 | [diff] [blame] | 277 | |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 278 | DefinedOrUnknownSVal location = cast<DefinedOrUnknownSVal>(ArgVal); |
| 279 | |
| 280 | // Check for null dereferences. |
| 281 | if (!isa<Loc>(location)) |
Zhongxing Xu | 181cc3d | 2010-02-14 06:49:48 +0000 | [diff] [blame] | 282 | return state; |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 283 | |
| 284 | // FIXME: Technically using 'Assume' here can result in a path |
| 285 | // bifurcation. In such cases we need to return two states, not just one. |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 286 | const ProgramState *notNullState, *nullState; |
Ted Kremenek | 28f47b9 | 2010-12-01 22:16:56 +0000 | [diff] [blame] | 287 | llvm::tie(notNullState, nullState) = state->assume(location); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 288 | |
| 289 | // The explicit NULL case, no operation is performed. |
| 290 | if (nullState && !notNullState) |
| 291 | return nullState; |
| 292 | |
| 293 | assert(notNullState); |
| 294 | |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 295 | // Unknown values could easily be okay |
| 296 | // Undefined values are handled elsewhere |
| 297 | if (ArgVal.isUnknownOrUndef()) |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 298 | return notNullState; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 299 | |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 300 | const MemRegion *R = ArgVal.getAsRegion(); |
| 301 | |
| 302 | // Nonlocs can't be freed, of course. |
| 303 | // Non-region locations (labels and fixed addresses) also shouldn't be freed. |
| 304 | if (!R) { |
| 305 | ReportBadFree(C, ArgVal, ArgExpr->getSourceRange()); |
| 306 | return NULL; |
| 307 | } |
| 308 | |
| 309 | R = R->StripCasts(); |
| 310 | |
| 311 | // Blocks might show up as heap data, but should not be free()d |
| 312 | if (isa<BlockDataRegion>(R)) { |
| 313 | ReportBadFree(C, ArgVal, ArgExpr->getSourceRange()); |
| 314 | return NULL; |
| 315 | } |
| 316 | |
| 317 | const MemSpaceRegion *MS = R->getMemorySpace(); |
| 318 | |
| 319 | // Parameters, locals, statics, and globals shouldn't be freed. |
| 320 | if (!(isa<UnknownSpaceRegion>(MS) || isa<HeapSpaceRegion>(MS))) { |
| 321 | // FIXME: at the time this code was written, malloc() regions were |
| 322 | // represented by conjured symbols, which are all in UnknownSpaceRegion. |
| 323 | // This means that there isn't actually anything from HeapSpaceRegion |
| 324 | // that should be freed, even though we allow it here. |
| 325 | // Of course, free() can work on memory allocated outside the current |
| 326 | // function, so UnknownSpaceRegion is always a possibility. |
| 327 | // False negatives are better than false positives. |
| 328 | |
| 329 | ReportBadFree(C, ArgVal, ArgExpr->getSourceRange()); |
| 330 | return NULL; |
| 331 | } |
| 332 | |
| 333 | const SymbolicRegion *SR = dyn_cast<SymbolicRegion>(R); |
| 334 | // Various cases could lead to non-symbol values here. |
| 335 | // For now, ignore them. |
| 336 | if (!SR) |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 337 | return notNullState; |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 338 | |
| 339 | SymbolRef Sym = SR->getSymbol(); |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 340 | const RefState *RS = state->get<RegionState>(Sym); |
Zhongxing Xu | 7e3cda9 | 2010-01-18 03:27:34 +0000 | [diff] [blame] | 341 | |
| 342 | // If the symbol has not been tracked, return. This is possible when free() is |
| 343 | // called on a pointer that does not get its pointee directly from malloc(). |
| 344 | // Full support of this requires inter-procedural analysis. |
| 345 | if (!RS) |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 346 | return notNullState; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 347 | |
| 348 | // Check double free. |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 349 | if (RS->isReleased()) { |
Ted Kremenek | d048c6e | 2010-12-20 21:19:09 +0000 | [diff] [blame] | 350 | if (ExplodedNode *N = C.generateSink()) { |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 351 | if (!BT_DoubleFree) |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 352 | BT_DoubleFree.reset( |
| 353 | new BuiltinBug("Double free", |
| 354 | "Try to free a memory block that has been released")); |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 355 | // FIXME: should find where it's freed last time. |
| 356 | BugReport *R = new BugReport(*BT_DoubleFree, |
Benjamin Kramer | d02e232 | 2009-11-14 12:08:24 +0000 | [diff] [blame] | 357 | BT_DoubleFree->getDescription(), N); |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 358 | C.EmitReport(R); |
| 359 | } |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 360 | return NULL; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 361 | } |
| 362 | |
| 363 | // Normal free. |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 364 | if (Hold) |
| 365 | return notNullState->set<RegionState>(Sym, RefState::getRelinquished(CE)); |
| 366 | return notNullState->set<RegionState>(Sym, RefState::getReleased(CE)); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 367 | } |
| 368 | |
Ted Kremenek | 9c378f7 | 2011-08-12 23:37:29 +0000 | [diff] [blame] | 369 | bool MallocChecker::SummarizeValue(raw_ostream &os, SVal V) { |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 370 | if (nonloc::ConcreteInt *IntVal = dyn_cast<nonloc::ConcreteInt>(&V)) |
| 371 | os << "an integer (" << IntVal->getValue() << ")"; |
| 372 | else if (loc::ConcreteInt *ConstAddr = dyn_cast<loc::ConcreteInt>(&V)) |
| 373 | os << "a constant address (" << ConstAddr->getValue() << ")"; |
| 374 | else if (loc::GotoLabel *Label = dyn_cast<loc::GotoLabel>(&V)) |
Chris Lattner | 6810630 | 2011-02-17 05:38:27 +0000 | [diff] [blame] | 375 | os << "the address of the label '" << Label->getLabel()->getName() << "'"; |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 376 | else |
| 377 | return false; |
| 378 | |
| 379 | return true; |
| 380 | } |
| 381 | |
Ted Kremenek | 9c378f7 | 2011-08-12 23:37:29 +0000 | [diff] [blame] | 382 | bool MallocChecker::SummarizeRegion(raw_ostream &os, |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 383 | const MemRegion *MR) { |
| 384 | switch (MR->getKind()) { |
| 385 | case MemRegion::FunctionTextRegionKind: { |
| 386 | const FunctionDecl *FD = cast<FunctionTextRegion>(MR)->getDecl(); |
| 387 | if (FD) |
Benjamin Kramer | b8989f2 | 2011-10-14 18:45:37 +0000 | [diff] [blame] | 388 | os << "the address of the function '" << *FD << '\''; |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 389 | else |
| 390 | os << "the address of a function"; |
| 391 | return true; |
| 392 | } |
| 393 | case MemRegion::BlockTextRegionKind: |
| 394 | os << "block text"; |
| 395 | return true; |
| 396 | case MemRegion::BlockDataRegionKind: |
| 397 | // FIXME: where the block came from? |
| 398 | os << "a block"; |
| 399 | return true; |
| 400 | default: { |
| 401 | const MemSpaceRegion *MS = MR->getMemorySpace(); |
| 402 | |
| 403 | switch (MS->getKind()) { |
| 404 | case MemRegion::StackLocalsSpaceRegionKind: { |
| 405 | const VarRegion *VR = dyn_cast<VarRegion>(MR); |
| 406 | const VarDecl *VD; |
| 407 | if (VR) |
| 408 | VD = VR->getDecl(); |
| 409 | else |
| 410 | VD = NULL; |
| 411 | |
| 412 | if (VD) |
| 413 | os << "the address of the local variable '" << VD->getName() << "'"; |
| 414 | else |
| 415 | os << "the address of a local stack variable"; |
| 416 | return true; |
| 417 | } |
| 418 | case MemRegion::StackArgumentsSpaceRegionKind: { |
| 419 | const VarRegion *VR = dyn_cast<VarRegion>(MR); |
| 420 | const VarDecl *VD; |
| 421 | if (VR) |
| 422 | VD = VR->getDecl(); |
| 423 | else |
| 424 | VD = NULL; |
| 425 | |
| 426 | if (VD) |
| 427 | os << "the address of the parameter '" << VD->getName() << "'"; |
| 428 | else |
| 429 | os << "the address of a parameter"; |
| 430 | return true; |
| 431 | } |
Ted Kremenek | dcee3ce | 2010-07-01 20:16:50 +0000 | [diff] [blame] | 432 | case MemRegion::NonStaticGlobalSpaceRegionKind: |
| 433 | case MemRegion::StaticGlobalSpaceRegionKind: { |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 434 | const VarRegion *VR = dyn_cast<VarRegion>(MR); |
| 435 | const VarDecl *VD; |
| 436 | if (VR) |
| 437 | VD = VR->getDecl(); |
| 438 | else |
| 439 | VD = NULL; |
| 440 | |
| 441 | if (VD) { |
| 442 | if (VD->isStaticLocal()) |
| 443 | os << "the address of the static variable '" << VD->getName() << "'"; |
| 444 | else |
| 445 | os << "the address of the global variable '" << VD->getName() << "'"; |
| 446 | } else |
| 447 | os << "the address of a global variable"; |
| 448 | return true; |
| 449 | } |
| 450 | default: |
| 451 | return false; |
| 452 | } |
| 453 | } |
| 454 | } |
| 455 | } |
| 456 | |
| 457 | void MallocChecker::ReportBadFree(CheckerContext &C, SVal ArgVal, |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 458 | SourceRange range) const { |
Ted Kremenek | d048c6e | 2010-12-20 21:19:09 +0000 | [diff] [blame] | 459 | if (ExplodedNode *N = C.generateSink()) { |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 460 | if (!BT_BadFree) |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 461 | BT_BadFree.reset(new BuiltinBug("Bad free")); |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 462 | |
| 463 | llvm::SmallString<100> buf; |
| 464 | llvm::raw_svector_ostream os(buf); |
| 465 | |
| 466 | const MemRegion *MR = ArgVal.getAsRegion(); |
| 467 | if (MR) { |
| 468 | while (const ElementRegion *ER = dyn_cast<ElementRegion>(MR)) |
| 469 | MR = ER->getSuperRegion(); |
| 470 | |
| 471 | // Special case for alloca() |
| 472 | if (isa<AllocaRegion>(MR)) |
| 473 | os << "Argument to free() was allocated by alloca(), not malloc()"; |
| 474 | else { |
| 475 | os << "Argument to free() is "; |
| 476 | if (SummarizeRegion(os, MR)) |
| 477 | os << ", which is not memory allocated by malloc()"; |
| 478 | else |
| 479 | os << "not memory allocated by malloc()"; |
| 480 | } |
| 481 | } else { |
| 482 | os << "Argument to free() is "; |
| 483 | if (SummarizeValue(os, ArgVal)) |
| 484 | os << ", which is not memory allocated by malloc()"; |
| 485 | else |
| 486 | os << "not memory allocated by malloc()"; |
| 487 | } |
| 488 | |
Anna Zaks | e172e8b | 2011-08-17 23:00:25 +0000 | [diff] [blame] | 489 | BugReport *R = new BugReport(*BT_BadFree, os.str(), N); |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 490 | R->addRange(range); |
| 491 | C.EmitReport(R); |
| 492 | } |
| 493 | } |
| 494 | |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 495 | void MallocChecker::ReallocMem(CheckerContext &C, const CallExpr *CE) const { |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 496 | const ProgramState *state = C.getState(); |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 497 | const Expr *arg0Expr = CE->getArg(0); |
| 498 | DefinedOrUnknownSVal arg0Val |
| 499 | = cast<DefinedOrUnknownSVal>(state->getSVal(arg0Expr)); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 500 | |
Ted Kremenek | 846eabd | 2010-12-01 21:28:31 +0000 | [diff] [blame] | 501 | SValBuilder &svalBuilder = C.getSValBuilder(); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 502 | |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 503 | DefinedOrUnknownSVal PtrEQ = |
| 504 | svalBuilder.evalEQ(state, arg0Val, svalBuilder.makeNull()); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 505 | |
Lenny Maiorani | 4d8d803 | 2011-04-27 14:49:29 +0000 | [diff] [blame] | 506 | // Get the size argument. If there is no size arg then give up. |
| 507 | const Expr *Arg1 = CE->getArg(1); |
| 508 | if (!Arg1) |
| 509 | return; |
| 510 | |
| 511 | // Get the value of the size argument. |
| 512 | DefinedOrUnknownSVal Arg1Val = |
| 513 | cast<DefinedOrUnknownSVal>(state->getSVal(Arg1)); |
| 514 | |
| 515 | // Compare the size argument to 0. |
| 516 | DefinedOrUnknownSVal SizeZero = |
| 517 | svalBuilder.evalEQ(state, Arg1Val, |
| 518 | svalBuilder.makeIntValWithPtrWidth(0, false)); |
| 519 | |
| 520 | // If the ptr is NULL and the size is not 0, the call is equivalent to |
| 521 | // malloc(size). |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 522 | const ProgramState *stateEqual = state->assume(PtrEQ, true); |
Lenny Maiorani | 4d8d803 | 2011-04-27 14:49:29 +0000 | [diff] [blame] | 523 | if (stateEqual && state->assume(SizeZero, false)) { |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 524 | // Hack: set the NULL symbolic region to released to suppress false warning. |
| 525 | // In the future we should add more states for allocated regions, e.g., |
| 526 | // CheckedNull, CheckedNonNull. |
| 527 | |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 528 | SymbolRef Sym = arg0Val.getAsLocSymbol(); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 529 | if (Sym) |
| 530 | stateEqual = stateEqual->set<RegionState>(Sym, RefState::getReleased(CE)); |
| 531 | |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 532 | const ProgramState *stateMalloc = MallocMemAux(C, CE, CE->getArg(1), |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 533 | UndefinedVal(), stateEqual); |
Anna Zaks | 0bd6b11 | 2011-10-26 21:06:34 +0000 | [diff] [blame^] | 534 | C.addTransition(stateMalloc); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 535 | } |
| 536 | |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 537 | if (const ProgramState *stateNotEqual = state->assume(PtrEQ, false)) { |
Lenny Maiorani | 4d8d803 | 2011-04-27 14:49:29 +0000 | [diff] [blame] | 538 | // If the size is 0, free the memory. |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 539 | if (const ProgramState *stateSizeZero = stateNotEqual->assume(SizeZero, true)) |
| 540 | if (const ProgramState *stateFree = |
Lenny Maiorani | 4d8d803 | 2011-04-27 14:49:29 +0000 | [diff] [blame] | 541 | FreeMemAux(C, CE, stateSizeZero, 0, false)) { |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 542 | |
Zhongxing Xu | d56763f | 2011-09-01 04:53:59 +0000 | [diff] [blame] | 543 | // Bind the return value to NULL because it is now free. |
Anna Zaks | 0bd6b11 | 2011-10-26 21:06:34 +0000 | [diff] [blame^] | 544 | C.addTransition(stateFree->BindExpr(CE, svalBuilder.makeNull(), true)); |
Lenny Maiorani | 4d8d803 | 2011-04-27 14:49:29 +0000 | [diff] [blame] | 545 | } |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 546 | if (const ProgramState *stateSizeNotZero = stateNotEqual->assume(SizeZero,false)) |
| 547 | if (const ProgramState *stateFree = FreeMemAux(C, CE, stateSizeNotZero, |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 548 | 0, false)) { |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 549 | // FIXME: We should copy the content of the original buffer. |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 550 | const ProgramState *stateRealloc = MallocMemAux(C, CE, CE->getArg(1), |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 551 | UnknownVal(), stateFree); |
Anna Zaks | 0bd6b11 | 2011-10-26 21:06:34 +0000 | [diff] [blame^] | 552 | C.addTransition(stateRealloc); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 553 | } |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 554 | } |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 555 | } |
Zhongxing Xu | 7b76096 | 2009-11-13 07:25:27 +0000 | [diff] [blame] | 556 | |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 557 | void MallocChecker::CallocMem(CheckerContext &C, const CallExpr *CE) { |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 558 | const ProgramState *state = C.getState(); |
Ted Kremenek | 846eabd | 2010-12-01 21:28:31 +0000 | [diff] [blame] | 559 | SValBuilder &svalBuilder = C.getSValBuilder(); |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 560 | |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 561 | SVal count = state->getSVal(CE->getArg(0)); |
| 562 | SVal elementSize = state->getSVal(CE->getArg(1)); |
| 563 | SVal TotalSize = svalBuilder.evalBinOp(state, BO_Mul, count, elementSize, |
| 564 | svalBuilder.getContext().getSizeType()); |
| 565 | SVal zeroVal = svalBuilder.makeZeroVal(svalBuilder.getContext().CharTy); |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 566 | |
Anna Zaks | 0bd6b11 | 2011-10-26 21:06:34 +0000 | [diff] [blame^] | 567 | C.addTransition(MallocMemAux(C, CE, TotalSize, zeroVal, state)); |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 568 | } |
| 569 | |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 570 | void MallocChecker::checkDeadSymbols(SymbolReaper &SymReaper, |
| 571 | CheckerContext &C) const |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 572 | { |
Zhongxing Xu | 173ff56 | 2010-08-15 08:19:57 +0000 | [diff] [blame] | 573 | if (!SymReaper.hasDeadSymbols()) |
| 574 | return; |
Zhongxing Xu | fc7ac8f | 2009-11-13 07:48:11 +0000 | [diff] [blame] | 575 | |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 576 | const ProgramState *state = C.getState(); |
Zhongxing Xu | 173ff56 | 2010-08-15 08:19:57 +0000 | [diff] [blame] | 577 | RegionStateTy RS = state->get<RegionState>(); |
Jordy Rose | 9076014 | 2010-08-18 04:33:47 +0000 | [diff] [blame] | 578 | RegionStateTy::Factory &F = state->get_context<RegionState>(); |
Zhongxing Xu | 173ff56 | 2010-08-15 08:19:57 +0000 | [diff] [blame] | 579 | |
Ted Kremenek | 217470e | 2011-07-28 23:07:51 +0000 | [diff] [blame] | 580 | bool generateReport = false; |
| 581 | |
Zhongxing Xu | 173ff56 | 2010-08-15 08:19:57 +0000 | [diff] [blame] | 582 | for (RegionStateTy::iterator I = RS.begin(), E = RS.end(); I != E; ++I) { |
| 583 | if (SymReaper.isDead(I->first)) { |
Ted Kremenek | 217470e | 2011-07-28 23:07:51 +0000 | [diff] [blame] | 584 | if (I->second.isAllocated()) |
| 585 | generateReport = true; |
Jordy Rose | 9076014 | 2010-08-18 04:33:47 +0000 | [diff] [blame] | 586 | |
| 587 | // Remove the dead symbol from the map. |
Ted Kremenek | 3baf672 | 2010-11-24 00:54:37 +0000 | [diff] [blame] | 588 | RS = F.remove(RS, I->first); |
Ted Kremenek | 217470e | 2011-07-28 23:07:51 +0000 | [diff] [blame] | 589 | |
Zhongxing Xu | fc7ac8f | 2009-11-13 07:48:11 +0000 | [diff] [blame] | 590 | } |
| 591 | } |
Ted Kremenek | 217470e | 2011-07-28 23:07:51 +0000 | [diff] [blame] | 592 | |
Anna Zaks | 0bd6b11 | 2011-10-26 21:06:34 +0000 | [diff] [blame^] | 593 | ExplodedNode *N = C.addTransition(state->set<RegionState>(RS)); |
Ted Kremenek | 217470e | 2011-07-28 23:07:51 +0000 | [diff] [blame] | 594 | |
| 595 | // FIXME: This does not handle when we have multiple leaks at a single |
| 596 | // place. |
| 597 | if (N && generateReport) { |
| 598 | if (!BT_Leak) |
| 599 | BT_Leak.reset(new BuiltinBug("Memory leak", |
| 600 | "Allocated memory never released. Potential memory leak.")); |
| 601 | // FIXME: where it is allocated. |
| 602 | BugReport *R = new BugReport(*BT_Leak, BT_Leak->getDescription(), N); |
| 603 | C.EmitReport(R); |
| 604 | } |
Zhongxing Xu | 7b76096 | 2009-11-13 07:25:27 +0000 | [diff] [blame] | 605 | } |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 606 | |
Anna Zaks | af498a2 | 2011-10-25 19:56:48 +0000 | [diff] [blame] | 607 | void MallocChecker::checkEndPath(CheckerContext &Ctx) const { |
| 608 | const ProgramState *state = Ctx.getState(); |
Jordy Rose | 09cef09 | 2010-08-18 04:26:59 +0000 | [diff] [blame] | 609 | RegionStateTy M = state->get<RegionState>(); |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 610 | |
Jordy Rose | 09cef09 | 2010-08-18 04:26:59 +0000 | [diff] [blame] | 611 | for (RegionStateTy::iterator I = M.begin(), E = M.end(); I != E; ++I) { |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 612 | RefState RS = I->second; |
| 613 | if (RS.isAllocated()) { |
Anna Zaks | 0bd6b11 | 2011-10-26 21:06:34 +0000 | [diff] [blame^] | 614 | ExplodedNode *N = Ctx.addTransition(state); |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 615 | if (N) { |
| 616 | if (!BT_Leak) |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 617 | BT_Leak.reset(new BuiltinBug("Memory leak", |
| 618 | "Allocated memory never released. Potential memory leak.")); |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 619 | BugReport *R = new BugReport(*BT_Leak, BT_Leak->getDescription(), N); |
Anna Zaks | af498a2 | 2011-10-25 19:56:48 +0000 | [diff] [blame] | 620 | Ctx.EmitReport(R); |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 621 | } |
| 622 | } |
| 623 | } |
| 624 | } |
Zhongxing Xu | 4985e3e | 2009-11-17 08:58:18 +0000 | [diff] [blame] | 625 | |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 626 | void MallocChecker::checkPreStmt(const ReturnStmt *S, CheckerContext &C) const { |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 627 | const Expr *retExpr = S->getRetValue(); |
| 628 | if (!retExpr) |
Zhongxing Xu | 4985e3e | 2009-11-17 08:58:18 +0000 | [diff] [blame] | 629 | return; |
| 630 | |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 631 | const ProgramState *state = C.getState(); |
Zhongxing Xu | 4985e3e | 2009-11-17 08:58:18 +0000 | [diff] [blame] | 632 | |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 633 | SymbolRef Sym = state->getSVal(retExpr).getAsSymbol(); |
Zhongxing Xu | 4985e3e | 2009-11-17 08:58:18 +0000 | [diff] [blame] | 634 | if (!Sym) |
| 635 | return; |
| 636 | |
| 637 | const RefState *RS = state->get<RegionState>(Sym); |
| 638 | if (!RS) |
| 639 | return; |
| 640 | |
| 641 | // FIXME: check other cases. |
| 642 | if (RS->isAllocated()) |
| 643 | state = state->set<RegionState>(Sym, RefState::getEscaped(S)); |
| 644 | |
Anna Zaks | 0bd6b11 | 2011-10-26 21:06:34 +0000 | [diff] [blame^] | 645 | C.addTransition(state); |
Zhongxing Xu | 4985e3e | 2009-11-17 08:58:18 +0000 | [diff] [blame] | 646 | } |
Zhongxing Xu | b94b81a | 2009-12-31 06:13:07 +0000 | [diff] [blame] | 647 | |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 648 | const ProgramState *MallocChecker::evalAssume(const ProgramState *state, SVal Cond, |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 649 | bool Assumption) const { |
Zhongxing Xu | b94b81a | 2009-12-31 06:13:07 +0000 | [diff] [blame] | 650 | // If a symblic region is assumed to NULL, set its state to AllocateFailed. |
| 651 | // FIXME: should also check symbols assumed to non-null. |
| 652 | |
| 653 | RegionStateTy RS = state->get<RegionState>(); |
| 654 | |
| 655 | for (RegionStateTy::iterator I = RS.begin(), E = RS.end(); I != E; ++I) { |
Zhongxing Xu | 2bfa301 | 2011-04-02 03:20:45 +0000 | [diff] [blame] | 656 | // If the symbol is assumed to NULL, this will return an APSInt*. |
Zhongxing Xu | b94b81a | 2009-12-31 06:13:07 +0000 | [diff] [blame] | 657 | if (state->getSymVal(I.getKey())) |
| 658 | state = state->set<RegionState>(I.getKey(),RefState::getAllocateFailed()); |
| 659 | } |
| 660 | |
| 661 | return state; |
| 662 | } |
Zhongxing Xu | c802378 | 2010-03-10 04:58:55 +0000 | [diff] [blame] | 663 | |
| 664 | // Check if the location is a freed symbolic region. |
Anna Zaks | 390909c | 2011-10-06 00:43:15 +0000 | [diff] [blame] | 665 | void MallocChecker::checkLocation(SVal l, bool isLoad, const Stmt *S, |
| 666 | CheckerContext &C) const { |
Zhongxing Xu | c802378 | 2010-03-10 04:58:55 +0000 | [diff] [blame] | 667 | SymbolRef Sym = l.getLocSymbolInBase(); |
| 668 | if (Sym) { |
| 669 | const RefState *RS = C.getState()->get<RegionState>(Sym); |
Ted Kremenek | cea6865 | 2010-08-06 21:12:49 +0000 | [diff] [blame] | 670 | if (RS && RS->isReleased()) { |
Anna Zaks | 0bd6b11 | 2011-10-26 21:06:34 +0000 | [diff] [blame^] | 671 | if (ExplodedNode *N = C.addTransition()) { |
Zhongxing Xu | c802378 | 2010-03-10 04:58:55 +0000 | [diff] [blame] | 672 | if (!BT_UseFree) |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 673 | BT_UseFree.reset(new BuiltinBug("Use dynamically allocated memory " |
| 674 | "after it is freed.")); |
Zhongxing Xu | c802378 | 2010-03-10 04:58:55 +0000 | [diff] [blame] | 675 | |
| 676 | BugReport *R = new BugReport(*BT_UseFree, BT_UseFree->getDescription(), |
| 677 | N); |
| 678 | C.EmitReport(R); |
| 679 | } |
Ted Kremenek | cea6865 | 2010-08-06 21:12:49 +0000 | [diff] [blame] | 680 | } |
Zhongxing Xu | c802378 | 2010-03-10 04:58:55 +0000 | [diff] [blame] | 681 | } |
| 682 | } |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 683 | |
Anna Zaks | 390909c | 2011-10-06 00:43:15 +0000 | [diff] [blame] | 684 | void MallocChecker::checkBind(SVal location, SVal val, |
| 685 | const Stmt *BindS, CheckerContext &C) const { |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 686 | // The PreVisitBind implements the same algorithm as already used by the |
| 687 | // Objective C ownership checker: if the pointer escaped from this scope by |
| 688 | // assignment, let it go. However, assigning to fields of a stack-storage |
| 689 | // structure does not transfer ownership. |
| 690 | |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 691 | const ProgramState *state = C.getState(); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 692 | DefinedOrUnknownSVal l = cast<DefinedOrUnknownSVal>(location); |
| 693 | |
| 694 | // Check for null dereferences. |
| 695 | if (!isa<Loc>(l)) |
| 696 | return; |
| 697 | |
| 698 | // Before checking if the state is null, check if 'val' has a RefState. |
| 699 | // Only then should we check for null and bifurcate the state. |
| 700 | SymbolRef Sym = val.getLocSymbolInBase(); |
| 701 | if (Sym) { |
| 702 | if (const RefState *RS = state->get<RegionState>(Sym)) { |
| 703 | // If ptr is NULL, no operation is performed. |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 704 | const ProgramState *notNullState, *nullState; |
Ted Kremenek | 28f47b9 | 2010-12-01 22:16:56 +0000 | [diff] [blame] | 705 | llvm::tie(notNullState, nullState) = state->assume(l); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 706 | |
| 707 | // Generate a transition for 'nullState' to record the assumption |
| 708 | // that the state was null. |
| 709 | if (nullState) |
Anna Zaks | 0bd6b11 | 2011-10-26 21:06:34 +0000 | [diff] [blame^] | 710 | C.addTransition(nullState); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 711 | |
| 712 | if (!notNullState) |
| 713 | return; |
| 714 | |
| 715 | if (RS->isAllocated()) { |
| 716 | // Something we presently own is being assigned somewhere. |
| 717 | const MemRegion *AR = location.getAsRegion(); |
| 718 | if (!AR) |
| 719 | return; |
| 720 | AR = AR->StripCasts()->getBaseRegion(); |
| 721 | do { |
| 722 | // If it is on the stack, we still own it. |
| 723 | if (AR->hasStackNonParametersStorage()) |
| 724 | break; |
| 725 | |
| 726 | // If the state can't represent this binding, we still own it. |
Ted Kremenek | dde201b | 2010-08-06 21:12:55 +0000 | [diff] [blame] | 727 | if (notNullState == (notNullState->bindLoc(cast<Loc>(location), |
| 728 | UnknownVal()))) |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 729 | break; |
| 730 | |
| 731 | // We no longer own this pointer. |
Ted Kremenek | dde201b | 2010-08-06 21:12:55 +0000 | [diff] [blame] | 732 | notNullState = |
| 733 | notNullState->set<RegionState>(Sym, |
Anna Zaks | 390909c | 2011-10-06 00:43:15 +0000 | [diff] [blame] | 734 | RefState::getRelinquished(BindS)); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 735 | } |
| 736 | while (false); |
| 737 | } |
Anna Zaks | 0bd6b11 | 2011-10-26 21:06:34 +0000 | [diff] [blame^] | 738 | C.addTransition(notNullState); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 739 | } |
| 740 | } |
| 741 | } |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 742 | |
| 743 | void ento::registerMallocChecker(CheckerManager &mgr) { |
| 744 | mgr.registerChecker<MallocChecker>(); |
| 745 | } |