blob: 5db073c9cb1c13e4034a15c76bdfe87c4551f6d9 [file] [log] [blame]
Ted Kremenek942e24d2010-09-10 03:45:29 +00001//== ObjCAtSyncChecker.cpp - nil mutex checker for @synchronized -*- C++ -*--=//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// This defines ObjCAtSyncChecker, a builtin check that checks for null pointers
11// used as mutexes for @synchronized.
12//
13//===----------------------------------------------------------------------===//
14
Argyrios Kyrtzidis027a6ab2011-02-15 07:42:33 +000015#include "ClangSACheckers.h"
Argyrios Kyrtzidisec8605f2011-03-01 01:16:21 +000016#include "clang/StaticAnalyzer/Core/Checker.h"
Argyrios Kyrtzidis695fb502011-02-17 21:39:17 +000017#include "clang/StaticAnalyzer/Core/CheckerManager.h"
Argyrios Kyrtzidis45d9b4e2011-02-23 07:19:18 +000018#include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
Ted Kremenek9b663712011-02-10 01:03:03 +000019#include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
Ted Kremenek21142582010-12-23 19:38:26 +000020#include "clang/StaticAnalyzer/Checkers/DereferenceChecker.h"
Ted Kremenek9b663712011-02-10 01:03:03 +000021#include "clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h"
Ted Kremenek942e24d2010-09-10 03:45:29 +000022
23using namespace clang;
Ted Kremenek9ef65372010-12-23 07:20:52 +000024using namespace ento;
Ted Kremenek942e24d2010-09-10 03:45:29 +000025
26namespace {
Argyrios Kyrtzidis45d9b4e2011-02-23 07:19:18 +000027class ObjCAtSyncChecker
Argyrios Kyrtzidisec8605f2011-03-01 01:16:21 +000028 : public Checker< check::PreStmt<ObjCAtSynchronizedStmt> > {
Argyrios Kyrtzidis45d9b4e2011-02-23 07:19:18 +000029 mutable llvm::OwningPtr<BuiltinBug> BT_null;
30 mutable llvm::OwningPtr<BuiltinBug> BT_undef;
31
Ted Kremenek942e24d2010-09-10 03:45:29 +000032public:
Argyrios Kyrtzidis45d9b4e2011-02-23 07:19:18 +000033 void checkPreStmt(const ObjCAtSynchronizedStmt *S, CheckerContext &C) const;
Ted Kremenek942e24d2010-09-10 03:45:29 +000034};
35} // end anonymous namespace
36
Argyrios Kyrtzidis45d9b4e2011-02-23 07:19:18 +000037void ObjCAtSyncChecker::checkPreStmt(const ObjCAtSynchronizedStmt *S,
38 CheckerContext &C) const {
Ted Kremenek942e24d2010-09-10 03:45:29 +000039
40 const Expr *Ex = S->getSynchExpr();
Ted Kremenek18c66fd2011-08-15 22:09:50 +000041 const ProgramState *state = C.getState();
Ted Kremenek942e24d2010-09-10 03:45:29 +000042 SVal V = state->getSVal(Ex);
43
44 // Uninitialized value used for the mutex?
45 if (isa<UndefinedVal>(V)) {
Ted Kremenekd048c6e2010-12-20 21:19:09 +000046 if (ExplodedNode *N = C.generateSink()) {
Ted Kremenek942e24d2010-09-10 03:45:29 +000047 if (!BT_undef)
Argyrios Kyrtzidis45d9b4e2011-02-23 07:19:18 +000048 BT_undef.reset(new BuiltinBug("Uninitialized value used as mutex "
49 "for @synchronized"));
Anna Zakse172e8b2011-08-17 23:00:25 +000050 BugReport *report =
51 new BugReport(*BT_undef, BT_undef->getDescription(), N);
Anna Zaks50bbc162011-08-19 22:33:38 +000052 report->addVisitor(bugreporter::getTrackNullOrUndefValueVisitor(N, Ex));
Ted Kremenek942e24d2010-09-10 03:45:29 +000053 C.EmitReport(report);
54 }
55 return;
56 }
57
Ted Kremenek0d4f7672010-10-25 20:20:56 +000058 if (V.isUnknown())
59 return;
60
Ted Kremenek942e24d2010-09-10 03:45:29 +000061 // Check for null mutexes.
Ted Kremenek18c66fd2011-08-15 22:09:50 +000062 const ProgramState *notNullState, *nullState;
Ted Kremenek28f47b92010-12-01 22:16:56 +000063 llvm::tie(notNullState, nullState) = state->assume(cast<DefinedSVal>(V));
Ted Kremenek942e24d2010-09-10 03:45:29 +000064
65 if (nullState) {
66 if (!notNullState) {
67 // Generate an error node. This isn't a sink since
68 // a null mutex just means no synchronization occurs.
Anna Zaks0bd6b112011-10-26 21:06:34 +000069 if (ExplodedNode *N = C.addTransition(nullState)) {
Ted Kremenek942e24d2010-09-10 03:45:29 +000070 if (!BT_null)
Argyrios Kyrtzidis45d9b4e2011-02-23 07:19:18 +000071 BT_null.reset(new BuiltinBug("Nil value used as mutex for @synchronized() "
72 "(no synchronization will occur)"));
Anna Zakse172e8b2011-08-17 23:00:25 +000073 BugReport *report =
74 new BugReport(*BT_null, BT_null->getDescription(), N);
Anna Zaks50bbc162011-08-19 22:33:38 +000075 report->addVisitor(bugreporter::getTrackNullOrUndefValueVisitor(N, Ex));
Ted Kremenek942e24d2010-09-10 03:45:29 +000076
77 C.EmitReport(report);
Ted Kremenek1adee4b2010-10-21 15:38:55 +000078 return;
Ted Kremenek942e24d2010-09-10 03:45:29 +000079 }
80 }
Ted Kremenek1adee4b2010-10-21 15:38:55 +000081 // Don't add a transition for 'nullState'. If the value is
82 // under-constrained to be null or non-null, assume it is non-null
83 // afterwards.
Ted Kremenek942e24d2010-09-10 03:45:29 +000084 }
85
86 if (notNullState)
Anna Zaks0bd6b112011-10-26 21:06:34 +000087 C.addTransition(notNullState);
Ted Kremenek942e24d2010-09-10 03:45:29 +000088}
Ted Kremenek1adee4b2010-10-21 15:38:55 +000089
Argyrios Kyrtzidis45d9b4e2011-02-23 07:19:18 +000090void ento::registerObjCAtSyncChecker(CheckerManager &mgr) {
91 if (mgr.getLangOptions().ObjC2)
92 mgr.registerChecker<ObjCAtSyncChecker>();
93}