blob: 67d290b73c5e6f9eda1abeca0f391cc93c7c512d [file] [log] [blame]
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +00001//=- AnalysisBasedWarnings.cpp - Sema warnings based on libAnalysis -*- C++ -*-=//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// This file defines analysis_warnings::[Policy,Executor].
11// Together they are used by Sema to issue warnings based on inexpensive
12// static analysis algorithms in libAnalysis.
13//
14//===----------------------------------------------------------------------===//
15
Douglas Gregore737f502010-08-12 20:07:10 +000016#include "clang/Sema/AnalysisBasedWarnings.h"
John McCall2d887082010-08-25 22:03:47 +000017#include "clang/Sema/SemaInternal.h"
Ted Kremenek351ba912011-02-23 01:52:04 +000018#include "clang/Sema/ScopeInfo.h"
Ted Kremenekd068aab2010-03-20 21:11:09 +000019#include "clang/Basic/SourceManager.h"
Caitlin Sadowski75f23ae2011-09-09 16:04:02 +000020#include "clang/Basic/SourceLocation.h"
Ted Kremenekfbb178a2011-01-21 19:41:46 +000021#include "clang/Lex/Preprocessor.h"
Richard Smithbdb97ff2012-05-26 06:20:46 +000022#include "clang/Lex/Lexer.h"
John McCall7cd088e2010-08-24 07:21:54 +000023#include "clang/AST/DeclObjC.h"
John McCall384aff82010-08-25 07:42:41 +000024#include "clang/AST/DeclCXX.h"
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +000025#include "clang/AST/ExprObjC.h"
26#include "clang/AST/ExprCXX.h"
27#include "clang/AST/StmtObjC.h"
28#include "clang/AST/StmtCXX.h"
Ted Kremenek6f417152011-04-04 20:56:00 +000029#include "clang/AST/EvaluatedExprVisitor.h"
Caitlin Sadowski3ac1fbc2011-08-23 18:46:34 +000030#include "clang/AST/StmtVisitor.h"
Richard Smithe0d3b4c2012-05-03 18:27:39 +000031#include "clang/AST/RecursiveASTVisitor.h"
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +000032#include "clang/Analysis/AnalysisContext.h"
33#include "clang/Analysis/CFG.h"
34#include "clang/Analysis/Analyses/ReachableCode.h"
Ted Kremenek351ba912011-02-23 01:52:04 +000035#include "clang/Analysis/Analyses/CFGReachabilityAnalysis.h"
Caitlin Sadowski402aa062011-09-09 16:11:56 +000036#include "clang/Analysis/Analyses/ThreadSafety.h"
Ted Kremenek351ba912011-02-23 01:52:04 +000037#include "clang/Analysis/CFGStmtMap.h"
Ted Kremenek6f342132011-03-15 03:17:07 +000038#include "clang/Analysis/Analyses/UninitializedValues.h"
Alexander Kornienko66da0ab2012-09-28 22:24:03 +000039#include "llvm/ADT/ArrayRef.h"
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +000040#include "llvm/ADT/BitVector.h"
Caitlin Sadowski3ac1fbc2011-08-23 18:46:34 +000041#include "llvm/ADT/FoldingSet.h"
42#include "llvm/ADT/ImmutableMap.h"
43#include "llvm/ADT/PostOrderIterator.h"
Dmitri Gribenko19523542012-09-29 11:40:46 +000044#include "llvm/ADT/SmallString.h"
Caitlin Sadowski3ac1fbc2011-08-23 18:46:34 +000045#include "llvm/ADT/SmallVector.h"
Caitlin Sadowski75f23ae2011-09-09 16:04:02 +000046#include "llvm/ADT/StringRef.h"
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +000047#include "llvm/Support/Casting.h"
Caitlin Sadowski3ac1fbc2011-08-23 18:46:34 +000048#include <algorithm>
Richard Smithe0d3b4c2012-05-03 18:27:39 +000049#include <iterator>
Caitlin Sadowski3ac1fbc2011-08-23 18:46:34 +000050#include <vector>
Richard Smithe0d3b4c2012-05-03 18:27:39 +000051#include <deque>
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +000052
53using namespace clang;
54
55//===----------------------------------------------------------------------===//
56// Unreachable code analysis.
57//===----------------------------------------------------------------------===//
58
59namespace {
60 class UnreachableCodeHandler : public reachable_code::Callback {
61 Sema &S;
62 public:
63 UnreachableCodeHandler(Sema &s) : S(s) {}
64
65 void HandleUnreachable(SourceLocation L, SourceRange R1, SourceRange R2) {
66 S.Diag(L, diag::warn_unreachable) << R1 << R2;
67 }
68 };
69}
70
71/// CheckUnreachable - Check for unreachable code.
Ted Kremenek1d26f482011-10-24 01:32:45 +000072static void CheckUnreachable(Sema &S, AnalysisDeclContext &AC) {
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +000073 UnreachableCodeHandler UC(S);
74 reachable_code::FindUnreachableCode(AC, UC);
75}
76
77//===----------------------------------------------------------------------===//
78// Check for missing return value.
79//===----------------------------------------------------------------------===//
80
John McCall16565aa2010-05-16 09:34:11 +000081enum ControlFlowKind {
82 UnknownFallThrough,
83 NeverFallThrough,
84 MaybeFallThrough,
85 AlwaysFallThrough,
86 NeverFallThroughOrReturn
87};
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +000088
89/// CheckFallThrough - Check that we don't fall off the end of a
90/// Statement that should return a value.
91///
Sylvestre Ledruf3477c12012-09-27 10:16:10 +000092/// \returns AlwaysFallThrough iff we always fall off the end of the statement,
93/// MaybeFallThrough iff we might or might not fall off the end,
94/// NeverFallThroughOrReturn iff we never fall off the end of the statement or
95/// return. We assume NeverFallThrough iff we never fall off the end of the
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +000096/// statement but we may return. We assume that functions not marked noreturn
97/// will return.
Ted Kremenek1d26f482011-10-24 01:32:45 +000098static ControlFlowKind CheckFallThrough(AnalysisDeclContext &AC) {
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +000099 CFG *cfg = AC.getCFG();
John McCall16565aa2010-05-16 09:34:11 +0000100 if (cfg == 0) return UnknownFallThrough;
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000101
102 // The CFG leaves in dead things, and we don't want the dead code paths to
103 // confuse us, so we mark all live things first.
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000104 llvm::BitVector live(cfg->getNumBlockIDs());
Ted Kremenek0f3b4ca2011-08-23 23:05:11 +0000105 unsigned count = reachable_code::ScanReachableFromBlock(&cfg->getEntry(),
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000106 live);
107
108 bool AddEHEdges = AC.getAddEHEdges();
109 if (!AddEHEdges && count != cfg->getNumBlockIDs())
110 // When there are things remaining dead, and we didn't add EH edges
111 // from CallExprs to the catch clauses, we have to go back and
112 // mark them as live.
113 for (CFG::iterator I = cfg->begin(), E = cfg->end(); I != E; ++I) {
114 CFGBlock &b = **I;
115 if (!live[b.getBlockID()]) {
116 if (b.pred_begin() == b.pred_end()) {
117 if (b.getTerminator() && isa<CXXTryStmt>(b.getTerminator()))
118 // When not adding EH edges from calls, catch clauses
119 // can otherwise seem dead. Avoid noting them as dead.
Ted Kremenek0f3b4ca2011-08-23 23:05:11 +0000120 count += reachable_code::ScanReachableFromBlock(&b, live);
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000121 continue;
122 }
123 }
124 }
125
126 // Now we know what is live, we check the live precessors of the exit block
127 // and look for fall through paths, being careful to ignore normal returns,
128 // and exceptional paths.
129 bool HasLiveReturn = false;
130 bool HasFakeEdge = false;
131 bool HasPlainEdge = false;
132 bool HasAbnormalEdge = false;
Ted Kremenek90b828a2010-09-09 00:06:07 +0000133
134 // Ignore default cases that aren't likely to be reachable because all
135 // enums in a switch(X) have explicit case statements.
136 CFGBlock::FilterOptions FO;
137 FO.IgnoreDefaultsWithCoveredEnums = 1;
138
139 for (CFGBlock::filtered_pred_iterator
140 I = cfg->getExit().filtered_pred_start_end(FO); I.hasMore(); ++I) {
141 const CFGBlock& B = **I;
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000142 if (!live[B.getBlockID()])
143 continue;
Ted Kremenek5811f592011-01-26 04:49:52 +0000144
Chandler Carruthe05ee6d2011-09-13 09:53:58 +0000145 // Skip blocks which contain an element marked as no-return. They don't
146 // represent actually viable edges into the exit block, so mark them as
147 // abnormal.
148 if (B.hasNoReturnElement()) {
149 HasAbnormalEdge = true;
150 continue;
151 }
152
Ted Kremenek5811f592011-01-26 04:49:52 +0000153 // Destructors can appear after the 'return' in the CFG. This is
154 // normal. We need to look pass the destructors for the return
155 // statement (if it exists).
156 CFGBlock::const_reverse_iterator ri = B.rbegin(), re = B.rend();
Ted Kremenekc9f8f5a2011-03-02 20:32:29 +0000157
Chandler Carruthe05ee6d2011-09-13 09:53:58 +0000158 for ( ; ri != re ; ++ri)
159 if (isa<CFGStmt>(*ri))
Ted Kremenek5811f592011-01-26 04:49:52 +0000160 break;
Chandler Carruthe05ee6d2011-09-13 09:53:58 +0000161
Ted Kremenek5811f592011-01-26 04:49:52 +0000162 // No more CFGElements in the block?
163 if (ri == re) {
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000164 if (B.getTerminator() && isa<CXXTryStmt>(B.getTerminator())) {
165 HasAbnormalEdge = true;
166 continue;
167 }
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000168 // A labeled empty statement, or the entry block...
169 HasPlainEdge = true;
170 continue;
171 }
Ted Kremenekf39e6a32011-01-25 22:50:47 +0000172
Ted Kremenek5811f592011-01-26 04:49:52 +0000173 CFGStmt CS = cast<CFGStmt>(*ri);
Ted Kremenekf1d10d92011-08-23 23:05:04 +0000174 const Stmt *S = CS.getStmt();
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000175 if (isa<ReturnStmt>(S)) {
176 HasLiveReturn = true;
177 continue;
178 }
179 if (isa<ObjCAtThrowStmt>(S)) {
180 HasFakeEdge = true;
181 continue;
182 }
183 if (isa<CXXThrowExpr>(S)) {
184 HasFakeEdge = true;
185 continue;
186 }
Chad Rosier8cd64b42012-06-11 20:47:18 +0000187 if (isa<MSAsmStmt>(S)) {
188 // TODO: Verify this is correct.
189 HasFakeEdge = true;
190 HasLiveReturn = true;
191 continue;
192 }
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000193 if (isa<CXXTryStmt>(S)) {
194 HasAbnormalEdge = true;
195 continue;
196 }
Chandler Carruthe05ee6d2011-09-13 09:53:58 +0000197 if (std::find(B.succ_begin(), B.succ_end(), &cfg->getExit())
198 == B.succ_end()) {
199 HasAbnormalEdge = true;
200 continue;
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000201 }
Chandler Carruthe05ee6d2011-09-13 09:53:58 +0000202
203 HasPlainEdge = true;
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000204 }
205 if (!HasPlainEdge) {
206 if (HasLiveReturn)
207 return NeverFallThrough;
208 return NeverFallThroughOrReturn;
209 }
210 if (HasAbnormalEdge || HasFakeEdge || HasLiveReturn)
211 return MaybeFallThrough;
212 // This says AlwaysFallThrough for calls to functions that are not marked
213 // noreturn, that don't return. If people would like this warning to be more
214 // accurate, such functions should be marked as noreturn.
215 return AlwaysFallThrough;
216}
217
Dan Gohman3c46e8d2010-07-26 21:25:24 +0000218namespace {
219
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000220struct CheckFallThroughDiagnostics {
221 unsigned diag_MaybeFallThrough_HasNoReturn;
222 unsigned diag_MaybeFallThrough_ReturnsNonVoid;
223 unsigned diag_AlwaysFallThrough_HasNoReturn;
224 unsigned diag_AlwaysFallThrough_ReturnsNonVoid;
225 unsigned diag_NeverFallThroughOrReturn;
Douglas Gregor793cd1c2012-02-15 16:20:15 +0000226 enum { Function, Block, Lambda } funMode;
Argyrios Kyrtzidis08274082010-12-15 18:44:22 +0000227 SourceLocation FuncLoc;
Ted Kremenekd064fdc2010-03-23 00:13:23 +0000228
Douglas Gregorca7eaee2010-04-16 23:28:44 +0000229 static CheckFallThroughDiagnostics MakeForFunction(const Decl *Func) {
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000230 CheckFallThroughDiagnostics D;
Argyrios Kyrtzidis08274082010-12-15 18:44:22 +0000231 D.FuncLoc = Func->getLocation();
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000232 D.diag_MaybeFallThrough_HasNoReturn =
233 diag::warn_falloff_noreturn_function;
234 D.diag_MaybeFallThrough_ReturnsNonVoid =
235 diag::warn_maybe_falloff_nonvoid_function;
236 D.diag_AlwaysFallThrough_HasNoReturn =
237 diag::warn_falloff_noreturn_function;
238 D.diag_AlwaysFallThrough_ReturnsNonVoid =
239 diag::warn_falloff_nonvoid_function;
Douglas Gregorca7eaee2010-04-16 23:28:44 +0000240
241 // Don't suggest that virtual functions be marked "noreturn", since they
242 // might be overridden by non-noreturn functions.
243 bool isVirtualMethod = false;
244 if (const CXXMethodDecl *Method = dyn_cast<CXXMethodDecl>(Func))
245 isVirtualMethod = Method->isVirtual();
246
Douglas Gregorfcdd2cb2011-10-10 18:15:57 +0000247 // Don't suggest that template instantiations be marked "noreturn"
248 bool isTemplateInstantiation = false;
Ted Kremenek75df4ee2011-12-01 00:59:17 +0000249 if (const FunctionDecl *Function = dyn_cast<FunctionDecl>(Func))
250 isTemplateInstantiation = Function->isTemplateInstantiation();
Douglas Gregorfcdd2cb2011-10-10 18:15:57 +0000251
252 if (!isVirtualMethod && !isTemplateInstantiation)
Douglas Gregorca7eaee2010-04-16 23:28:44 +0000253 D.diag_NeverFallThroughOrReturn =
254 diag::warn_suggest_noreturn_function;
255 else
256 D.diag_NeverFallThroughOrReturn = 0;
257
Douglas Gregor793cd1c2012-02-15 16:20:15 +0000258 D.funMode = Function;
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000259 return D;
260 }
Ted Kremenekd064fdc2010-03-23 00:13:23 +0000261
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000262 static CheckFallThroughDiagnostics MakeForBlock() {
263 CheckFallThroughDiagnostics D;
264 D.diag_MaybeFallThrough_HasNoReturn =
265 diag::err_noreturn_block_has_return_expr;
266 D.diag_MaybeFallThrough_ReturnsNonVoid =
267 diag::err_maybe_falloff_nonvoid_block;
268 D.diag_AlwaysFallThrough_HasNoReturn =
269 diag::err_noreturn_block_has_return_expr;
270 D.diag_AlwaysFallThrough_ReturnsNonVoid =
271 diag::err_falloff_nonvoid_block;
272 D.diag_NeverFallThroughOrReturn =
273 diag::warn_suggest_noreturn_block;
Douglas Gregor793cd1c2012-02-15 16:20:15 +0000274 D.funMode = Block;
275 return D;
276 }
277
278 static CheckFallThroughDiagnostics MakeForLambda() {
279 CheckFallThroughDiagnostics D;
280 D.diag_MaybeFallThrough_HasNoReturn =
281 diag::err_noreturn_lambda_has_return_expr;
282 D.diag_MaybeFallThrough_ReturnsNonVoid =
283 diag::warn_maybe_falloff_nonvoid_lambda;
284 D.diag_AlwaysFallThrough_HasNoReturn =
285 diag::err_noreturn_lambda_has_return_expr;
286 D.diag_AlwaysFallThrough_ReturnsNonVoid =
287 diag::warn_falloff_nonvoid_lambda;
288 D.diag_NeverFallThroughOrReturn = 0;
289 D.funMode = Lambda;
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000290 return D;
291 }
Ted Kremenekd064fdc2010-03-23 00:13:23 +0000292
David Blaikied6471f72011-09-25 23:23:43 +0000293 bool checkDiagnostics(DiagnosticsEngine &D, bool ReturnsVoid,
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000294 bool HasNoReturn) const {
Douglas Gregor793cd1c2012-02-15 16:20:15 +0000295 if (funMode == Function) {
Argyrios Kyrtzidis08274082010-12-15 18:44:22 +0000296 return (ReturnsVoid ||
297 D.getDiagnosticLevel(diag::warn_maybe_falloff_nonvoid_function,
David Blaikied6471f72011-09-25 23:23:43 +0000298 FuncLoc) == DiagnosticsEngine::Ignored)
Argyrios Kyrtzidis08274082010-12-15 18:44:22 +0000299 && (!HasNoReturn ||
300 D.getDiagnosticLevel(diag::warn_noreturn_function_has_return_expr,
David Blaikied6471f72011-09-25 23:23:43 +0000301 FuncLoc) == DiagnosticsEngine::Ignored)
Argyrios Kyrtzidis08274082010-12-15 18:44:22 +0000302 && (!ReturnsVoid ||
303 D.getDiagnosticLevel(diag::warn_suggest_noreturn_block, FuncLoc)
David Blaikied6471f72011-09-25 23:23:43 +0000304 == DiagnosticsEngine::Ignored);
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000305 }
Ted Kremenekd064fdc2010-03-23 00:13:23 +0000306
Douglas Gregor793cd1c2012-02-15 16:20:15 +0000307 // For blocks / lambdas.
308 return ReturnsVoid && !HasNoReturn
309 && ((funMode == Lambda) ||
Argyrios Kyrtzidis08274082010-12-15 18:44:22 +0000310 D.getDiagnosticLevel(diag::warn_suggest_noreturn_block, FuncLoc)
David Blaikied6471f72011-09-25 23:23:43 +0000311 == DiagnosticsEngine::Ignored);
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000312 }
313};
314
Dan Gohman3c46e8d2010-07-26 21:25:24 +0000315}
316
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000317/// CheckFallThroughForFunctionDef - Check that we don't fall off the end of a
318/// function that should return a value. Check that we don't fall off the end
319/// of a noreturn function. We assume that functions and blocks not marked
320/// noreturn will return.
321static void CheckFallThroughForBody(Sema &S, const Decl *D, const Stmt *Body,
Ted Kremenek3ed6fc02011-02-23 01:51:48 +0000322 const BlockExpr *blkExpr,
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000323 const CheckFallThroughDiagnostics& CD,
Ted Kremenek1d26f482011-10-24 01:32:45 +0000324 AnalysisDeclContext &AC) {
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000325
326 bool ReturnsVoid = false;
327 bool HasNoReturn = false;
328
329 if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(D)) {
330 ReturnsVoid = FD->getResultType()->isVoidType();
331 HasNoReturn = FD->hasAttr<NoReturnAttr>() ||
Rafael Espindola264ba482010-03-30 20:24:48 +0000332 FD->getType()->getAs<FunctionType>()->getNoReturnAttr();
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000333 }
334 else if (const ObjCMethodDecl *MD = dyn_cast<ObjCMethodDecl>(D)) {
335 ReturnsVoid = MD->getResultType()->isVoidType();
336 HasNoReturn = MD->hasAttr<NoReturnAttr>();
337 }
338 else if (isa<BlockDecl>(D)) {
Ted Kremenek3ed6fc02011-02-23 01:51:48 +0000339 QualType BlockTy = blkExpr->getType();
Ted Kremenekd064fdc2010-03-23 00:13:23 +0000340 if (const FunctionType *FT =
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000341 BlockTy->getPointeeType()->getAs<FunctionType>()) {
342 if (FT->getResultType()->isVoidType())
343 ReturnsVoid = true;
344 if (FT->getNoReturnAttr())
345 HasNoReturn = true;
346 }
347 }
348
David Blaikied6471f72011-09-25 23:23:43 +0000349 DiagnosticsEngine &Diags = S.getDiagnostics();
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000350
351 // Short circuit for compilation speed.
352 if (CD.checkDiagnostics(Diags, ReturnsVoid, HasNoReturn))
353 return;
Ted Kremenekd064fdc2010-03-23 00:13:23 +0000354
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000355 // FIXME: Function try block
356 if (const CompoundStmt *Compound = dyn_cast<CompoundStmt>(Body)) {
357 switch (CheckFallThrough(AC)) {
John McCall16565aa2010-05-16 09:34:11 +0000358 case UnknownFallThrough:
359 break;
360
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000361 case MaybeFallThrough:
362 if (HasNoReturn)
363 S.Diag(Compound->getRBracLoc(),
364 CD.diag_MaybeFallThrough_HasNoReturn);
365 else if (!ReturnsVoid)
366 S.Diag(Compound->getRBracLoc(),
367 CD.diag_MaybeFallThrough_ReturnsNonVoid);
368 break;
369 case AlwaysFallThrough:
370 if (HasNoReturn)
371 S.Diag(Compound->getRBracLoc(),
372 CD.diag_AlwaysFallThrough_HasNoReturn);
373 else if (!ReturnsVoid)
374 S.Diag(Compound->getRBracLoc(),
375 CD.diag_AlwaysFallThrough_ReturnsNonVoid);
376 break;
377 case NeverFallThroughOrReturn:
Chandler Carruthb0656ec2011-08-31 09:01:53 +0000378 if (ReturnsVoid && !HasNoReturn && CD.diag_NeverFallThroughOrReturn) {
379 if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(D)) {
380 S.Diag(Compound->getLBracLoc(), CD.diag_NeverFallThroughOrReturn)
Douglas Gregorb3321092011-09-10 00:56:20 +0000381 << 0 << FD;
382 } else if (const ObjCMethodDecl *MD = dyn_cast<ObjCMethodDecl>(D)) {
383 S.Diag(Compound->getLBracLoc(), CD.diag_NeverFallThroughOrReturn)
384 << 1 << MD;
Chandler Carruthb0656ec2011-08-31 09:01:53 +0000385 } else {
386 S.Diag(Compound->getLBracLoc(), CD.diag_NeverFallThroughOrReturn);
387 }
388 }
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000389 break;
390 case NeverFallThrough:
391 break;
392 }
393 }
394}
395
396//===----------------------------------------------------------------------===//
Ted Kremenek610068c2011-01-15 02:58:47 +0000397// -Wuninitialized
398//===----------------------------------------------------------------------===//
399
Ted Kremenek6f417152011-04-04 20:56:00 +0000400namespace {
Chandler Carruth9f649462011-04-05 06:48:00 +0000401/// ContainsReference - A visitor class to search for references to
402/// a particular declaration (the needle) within any evaluated component of an
403/// expression (recursively).
Ted Kremenek6f417152011-04-04 20:56:00 +0000404class ContainsReference : public EvaluatedExprVisitor<ContainsReference> {
Chandler Carruth9f649462011-04-05 06:48:00 +0000405 bool FoundReference;
406 const DeclRefExpr *Needle;
407
Ted Kremenek6f417152011-04-04 20:56:00 +0000408public:
Chandler Carruth9f649462011-04-05 06:48:00 +0000409 ContainsReference(ASTContext &Context, const DeclRefExpr *Needle)
410 : EvaluatedExprVisitor<ContainsReference>(Context),
411 FoundReference(false), Needle(Needle) {}
412
413 void VisitExpr(Expr *E) {
Ted Kremenek6f417152011-04-04 20:56:00 +0000414 // Stop evaluating if we already have a reference.
Chandler Carruth9f649462011-04-05 06:48:00 +0000415 if (FoundReference)
Ted Kremenek6f417152011-04-04 20:56:00 +0000416 return;
Chandler Carruth9f649462011-04-05 06:48:00 +0000417
418 EvaluatedExprVisitor<ContainsReference>::VisitExpr(E);
Ted Kremenek6f417152011-04-04 20:56:00 +0000419 }
Chandler Carruth9f649462011-04-05 06:48:00 +0000420
421 void VisitDeclRefExpr(DeclRefExpr *E) {
422 if (E == Needle)
423 FoundReference = true;
424 else
425 EvaluatedExprVisitor<ContainsReference>::VisitDeclRefExpr(E);
Ted Kremenek6f417152011-04-04 20:56:00 +0000426 }
Chandler Carruth9f649462011-04-05 06:48:00 +0000427
428 bool doesContainReference() const { return FoundReference; }
Ted Kremenek6f417152011-04-04 20:56:00 +0000429};
430}
431
David Blaikie4f4f3492011-09-10 05:35:08 +0000432static bool SuggestInitializationFixit(Sema &S, const VarDecl *VD) {
Fariborz Jahaniana34194f2012-03-08 00:22:50 +0000433 QualType VariableTy = VD->getType().getCanonicalType();
434 if (VariableTy->isBlockPointerType() &&
435 !VD->hasAttr<BlocksAttr>()) {
436 S.Diag(VD->getLocation(), diag::note_block_var_fixit_add_initialization) << VD->getDeclName()
437 << FixItHint::CreateInsertion(VD->getLocation(), "__block ");
438 return true;
439 }
440
David Blaikie4f4f3492011-09-10 05:35:08 +0000441 // Don't issue a fixit if there is already an initializer.
442 if (VD->getInit())
443 return false;
Fariborz Jahaniana34194f2012-03-08 00:22:50 +0000444
David Blaikie4f4f3492011-09-10 05:35:08 +0000445 // Suggest possible initialization (if any).
David Blaikie2c0abf42012-04-30 18:27:22 +0000446 std::string Init = S.getFixItZeroInitializerForType(VariableTy);
447 if (Init.empty())
David Blaikie4f4f3492011-09-10 05:35:08 +0000448 return false;
Richard Trieu7b0a3e32012-05-03 01:09:59 +0000449
450 // Don't suggest a fixit inside macros.
451 if (VD->getLocEnd().isMacroID())
452 return false;
453
Richard Smith7984de32012-01-12 23:53:29 +0000454 SourceLocation Loc = S.PP.getLocForEndOfToken(VD->getLocEnd());
Fariborz Jahaniana34194f2012-03-08 00:22:50 +0000455
Richard Smith7984de32012-01-12 23:53:29 +0000456 S.Diag(Loc, diag::note_var_fixit_add_initialization) << VD->getDeclName()
457 << FixItHint::CreateInsertion(Loc, Init);
458 return true;
David Blaikie4f4f3492011-09-10 05:35:08 +0000459}
460
Richard Smithbdb97ff2012-05-26 06:20:46 +0000461/// Create a fixit to remove an if-like statement, on the assumption that its
462/// condition is CondVal.
463static void CreateIfFixit(Sema &S, const Stmt *If, const Stmt *Then,
464 const Stmt *Else, bool CondVal,
465 FixItHint &Fixit1, FixItHint &Fixit2) {
466 if (CondVal) {
467 // If condition is always true, remove all but the 'then'.
468 Fixit1 = FixItHint::CreateRemoval(
469 CharSourceRange::getCharRange(If->getLocStart(),
470 Then->getLocStart()));
471 if (Else) {
472 SourceLocation ElseKwLoc = Lexer::getLocForEndOfToken(
473 Then->getLocEnd(), 0, S.getSourceManager(), S.getLangOpts());
474 Fixit2 = FixItHint::CreateRemoval(
475 SourceRange(ElseKwLoc, Else->getLocEnd()));
476 }
477 } else {
478 // If condition is always false, remove all but the 'else'.
479 if (Else)
480 Fixit1 = FixItHint::CreateRemoval(
481 CharSourceRange::getCharRange(If->getLocStart(),
482 Else->getLocStart()));
483 else
484 Fixit1 = FixItHint::CreateRemoval(If->getSourceRange());
485 }
486}
487
488/// DiagUninitUse -- Helper function to produce a diagnostic for an
489/// uninitialized use of a variable.
490static void DiagUninitUse(Sema &S, const VarDecl *VD, const UninitUse &Use,
491 bool IsCapturedByBlock) {
492 bool Diagnosed = false;
493
494 // Diagnose each branch which leads to a sometimes-uninitialized use.
Richard Smith2815e1a2012-05-25 02:17:09 +0000495 for (UninitUse::branch_iterator I = Use.branch_begin(), E = Use.branch_end();
496 I != E; ++I) {
Richard Smithbdb97ff2012-05-26 06:20:46 +0000497 assert(Use.getKind() == UninitUse::Sometimes);
498
499 const Expr *User = Use.getUser();
Richard Smith2815e1a2012-05-25 02:17:09 +0000500 const Stmt *Term = I->Terminator;
Richard Smithbdb97ff2012-05-26 06:20:46 +0000501
502 // Information used when building the diagnostic.
Richard Smith2815e1a2012-05-25 02:17:09 +0000503 unsigned DiagKind;
Richard Smith2815e1a2012-05-25 02:17:09 +0000504 const char *Str;
Richard Smithbdb97ff2012-05-26 06:20:46 +0000505 SourceRange Range;
506
507 // FixIts to suppress the diagnosic by removing the dead condition.
508 // For all binary terminators, branch 0 is taken if the condition is true,
509 // and branch 1 is taken if the condition is false.
510 int RemoveDiagKind = -1;
511 const char *FixitStr =
512 S.getLangOpts().CPlusPlus ? (I->Output ? "true" : "false")
513 : (I->Output ? "1" : "0");
514 FixItHint Fixit1, Fixit2;
515
Richard Smith2815e1a2012-05-25 02:17:09 +0000516 switch (Term->getStmtClass()) {
517 default:
Richard Smithbdb97ff2012-05-26 06:20:46 +0000518 // Don't know how to report this. Just fall back to 'may be used
519 // uninitialized'. This happens for range-based for, which the user
520 // can't explicitly fix.
521 // FIXME: This also happens if the first use of a variable is always
522 // uninitialized, eg "for (int n; n < 10; ++n)". We should report that
523 // with the 'is uninitialized' diagnostic.
Richard Smith2815e1a2012-05-25 02:17:09 +0000524 continue;
525
526 // "condition is true / condition is false".
Richard Smithbdb97ff2012-05-26 06:20:46 +0000527 case Stmt::IfStmtClass: {
528 const IfStmt *IS = cast<IfStmt>(Term);
Richard Smith2815e1a2012-05-25 02:17:09 +0000529 DiagKind = 0;
530 Str = "if";
Richard Smithbdb97ff2012-05-26 06:20:46 +0000531 Range = IS->getCond()->getSourceRange();
532 RemoveDiagKind = 0;
533 CreateIfFixit(S, IS, IS->getThen(), IS->getElse(),
534 I->Output, Fixit1, Fixit2);
Richard Smith2815e1a2012-05-25 02:17:09 +0000535 break;
Richard Smithbdb97ff2012-05-26 06:20:46 +0000536 }
537 case Stmt::ConditionalOperatorClass: {
538 const ConditionalOperator *CO = cast<ConditionalOperator>(Term);
Richard Smith2815e1a2012-05-25 02:17:09 +0000539 DiagKind = 0;
540 Str = "?:";
Richard Smithbdb97ff2012-05-26 06:20:46 +0000541 Range = CO->getCond()->getSourceRange();
542 RemoveDiagKind = 0;
543 CreateIfFixit(S, CO, CO->getTrueExpr(), CO->getFalseExpr(),
544 I->Output, Fixit1, Fixit2);
Richard Smith2815e1a2012-05-25 02:17:09 +0000545 break;
Richard Smithbdb97ff2012-05-26 06:20:46 +0000546 }
Richard Smith2815e1a2012-05-25 02:17:09 +0000547 case Stmt::BinaryOperatorClass: {
548 const BinaryOperator *BO = cast<BinaryOperator>(Term);
549 if (!BO->isLogicalOp())
550 continue;
551 DiagKind = 0;
552 Str = BO->getOpcodeStr();
553 Range = BO->getLHS()->getSourceRange();
Richard Smithbdb97ff2012-05-26 06:20:46 +0000554 RemoveDiagKind = 0;
555 if ((BO->getOpcode() == BO_LAnd && I->Output) ||
556 (BO->getOpcode() == BO_LOr && !I->Output))
557 // true && y -> y, false || y -> y.
558 Fixit1 = FixItHint::CreateRemoval(SourceRange(BO->getLocStart(),
559 BO->getOperatorLoc()));
560 else
561 // false && y -> false, true || y -> true.
562 Fixit1 = FixItHint::CreateReplacement(BO->getSourceRange(), FixitStr);
Richard Smith2815e1a2012-05-25 02:17:09 +0000563 break;
564 }
565
566 // "loop is entered / loop is exited".
567 case Stmt::WhileStmtClass:
568 DiagKind = 1;
569 Str = "while";
570 Range = cast<WhileStmt>(Term)->getCond()->getSourceRange();
Richard Smithbdb97ff2012-05-26 06:20:46 +0000571 RemoveDiagKind = 1;
572 Fixit1 = FixItHint::CreateReplacement(Range, FixitStr);
Richard Smith2815e1a2012-05-25 02:17:09 +0000573 break;
574 case Stmt::ForStmtClass:
575 DiagKind = 1;
576 Str = "for";
577 Range = cast<ForStmt>(Term)->getCond()->getSourceRange();
Richard Smithbdb97ff2012-05-26 06:20:46 +0000578 RemoveDiagKind = 1;
579 if (I->Output)
580 Fixit1 = FixItHint::CreateRemoval(Range);
581 else
582 Fixit1 = FixItHint::CreateReplacement(Range, FixitStr);
Richard Smith2815e1a2012-05-25 02:17:09 +0000583 break;
584
585 // "condition is true / loop is exited".
586 case Stmt::DoStmtClass:
587 DiagKind = 2;
588 Str = "do";
589 Range = cast<DoStmt>(Term)->getCond()->getSourceRange();
Richard Smithbdb97ff2012-05-26 06:20:46 +0000590 RemoveDiagKind = 1;
591 Fixit1 = FixItHint::CreateReplacement(Range, FixitStr);
Richard Smith2815e1a2012-05-25 02:17:09 +0000592 break;
593
594 // "switch case is taken".
595 case Stmt::CaseStmtClass:
596 DiagKind = 3;
597 Str = "case";
598 Range = cast<CaseStmt>(Term)->getLHS()->getSourceRange();
599 break;
600 case Stmt::DefaultStmtClass:
601 DiagKind = 3;
602 Str = "default";
603 Range = cast<DefaultStmt>(Term)->getDefaultLoc();
604 break;
605 }
606
Richard Smithbdb97ff2012-05-26 06:20:46 +0000607 S.Diag(Range.getBegin(), diag::warn_sometimes_uninit_var)
608 << VD->getDeclName() << IsCapturedByBlock << DiagKind
609 << Str << I->Output << Range;
610 S.Diag(User->getLocStart(), diag::note_uninit_var_use)
611 << IsCapturedByBlock << User->getSourceRange();
612 if (RemoveDiagKind != -1)
613 S.Diag(Fixit1.RemoveRange.getBegin(), diag::note_uninit_fixit_remove_cond)
614 << RemoveDiagKind << Str << I->Output << Fixit1 << Fixit2;
615
616 Diagnosed = true;
Richard Smith2815e1a2012-05-25 02:17:09 +0000617 }
Richard Smithbdb97ff2012-05-26 06:20:46 +0000618
619 if (!Diagnosed)
620 S.Diag(Use.getUser()->getLocStart(),
621 Use.getKind() == UninitUse::Always ? diag::warn_uninit_var
622 : diag::warn_maybe_uninit_var)
623 << VD->getDeclName() << IsCapturedByBlock
624 << Use.getUser()->getSourceRange();
Richard Smith2815e1a2012-05-25 02:17:09 +0000625}
626
Chandler Carruth262d50e2011-04-05 18:27:05 +0000627/// DiagnoseUninitializedUse -- Helper function for diagnosing uses of an
628/// uninitialized variable. This manages the different forms of diagnostic
629/// emitted for particular types of uses. Returns true if the use was diagnosed
Richard Smith2815e1a2012-05-25 02:17:09 +0000630/// as a warning. If a particular use is one we omit warnings for, returns
Chandler Carruth262d50e2011-04-05 18:27:05 +0000631/// false.
632static bool DiagnoseUninitializedUse(Sema &S, const VarDecl *VD,
Richard Smith2815e1a2012-05-25 02:17:09 +0000633 const UninitUse &Use,
Ted Kremenek9e761722011-10-13 18:50:06 +0000634 bool alwaysReportSelfInit = false) {
Chandler Carruth4c4983b2011-04-05 18:18:05 +0000635
Richard Smith2815e1a2012-05-25 02:17:09 +0000636 if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(Use.getUser())) {
Richard Trieuf6278e52012-05-09 21:08:22 +0000637 // Inspect the initializer of the variable declaration which is
638 // being referenced prior to its initialization. We emit
639 // specialized diagnostics for self-initialization, and we
640 // specifically avoid warning about self references which take the
641 // form of:
642 //
643 // int x = x;
644 //
645 // This is used to indicate to GCC that 'x' is intentionally left
646 // uninitialized. Proven code paths which access 'x' in
647 // an uninitialized state after this will still warn.
648 if (const Expr *Initializer = VD->getInit()) {
649 if (!alwaysReportSelfInit && DRE == Initializer->IgnoreParenImpCasts())
650 return false;
Chandler Carruth4c4983b2011-04-05 18:18:05 +0000651
Richard Trieuf6278e52012-05-09 21:08:22 +0000652 ContainsReference CR(S.Context, DRE);
653 CR.Visit(const_cast<Expr*>(Initializer));
654 if (CR.doesContainReference()) {
Chandler Carruth4c4983b2011-04-05 18:18:05 +0000655 S.Diag(DRE->getLocStart(),
656 diag::warn_uninit_self_reference_in_init)
Richard Trieuf6278e52012-05-09 21:08:22 +0000657 << VD->getDeclName() << VD->getLocation() << DRE->getSourceRange();
658 return true;
Chandler Carruth4c4983b2011-04-05 18:18:05 +0000659 }
Chandler Carruth4c4983b2011-04-05 18:18:05 +0000660 }
Richard Trieuf6278e52012-05-09 21:08:22 +0000661
Richard Smithbdb97ff2012-05-26 06:20:46 +0000662 DiagUninitUse(S, VD, Use, false);
Chandler Carruth4c4983b2011-04-05 18:18:05 +0000663 } else {
Richard Smith2815e1a2012-05-25 02:17:09 +0000664 const BlockExpr *BE = cast<BlockExpr>(Use.getUser());
Richard Smithbdb97ff2012-05-26 06:20:46 +0000665 if (VD->getType()->isBlockPointerType() && !VD->hasAttr<BlocksAttr>())
666 S.Diag(BE->getLocStart(),
667 diag::warn_uninit_byref_blockvar_captured_by_block)
Fariborz Jahaniana34194f2012-03-08 00:22:50 +0000668 << VD->getDeclName();
Richard Smithbdb97ff2012-05-26 06:20:46 +0000669 else
670 DiagUninitUse(S, VD, Use, true);
Chandler Carruth4c4983b2011-04-05 18:18:05 +0000671 }
672
673 // Report where the variable was declared when the use wasn't within
David Blaikie4f4f3492011-09-10 05:35:08 +0000674 // the initializer of that declaration & we didn't already suggest
675 // an initialization fixit.
Richard Trieuf6278e52012-05-09 21:08:22 +0000676 if (!SuggestInitializationFixit(S, VD))
Chandler Carruth4c4983b2011-04-05 18:18:05 +0000677 S.Diag(VD->getLocStart(), diag::note_uninit_var_def)
678 << VD->getDeclName();
679
Chandler Carruth262d50e2011-04-05 18:27:05 +0000680 return true;
Chandler Carruth64fb9592011-04-05 18:18:08 +0000681}
682
Richard Smithe0d3b4c2012-05-03 18:27:39 +0000683namespace {
684 class FallthroughMapper : public RecursiveASTVisitor<FallthroughMapper> {
685 public:
686 FallthroughMapper(Sema &S)
687 : FoundSwitchStatements(false),
688 S(S) {
689 }
690
691 bool foundSwitchStatements() const { return FoundSwitchStatements; }
692
693 void markFallthroughVisited(const AttributedStmt *Stmt) {
694 bool Found = FallthroughStmts.erase(Stmt);
695 assert(Found);
Kaelyn Uhrain3bb29942012-05-03 19:46:38 +0000696 (void)Found;
Richard Smithe0d3b4c2012-05-03 18:27:39 +0000697 }
698
699 typedef llvm::SmallPtrSet<const AttributedStmt*, 8> AttrStmts;
700
701 const AttrStmts &getFallthroughStmts() const {
702 return FallthroughStmts;
703 }
704
705 bool checkFallThroughIntoBlock(const CFGBlock &B, int &AnnotatedCnt) {
706 int UnannotatedCnt = 0;
707 AnnotatedCnt = 0;
708
709 std::deque<const CFGBlock*> BlockQueue;
710
711 std::copy(B.pred_begin(), B.pred_end(), std::back_inserter(BlockQueue));
712
713 while (!BlockQueue.empty()) {
714 const CFGBlock *P = BlockQueue.front();
715 BlockQueue.pop_front();
716
717 const Stmt *Term = P->getTerminator();
718 if (Term && isa<SwitchStmt>(Term))
719 continue; // Switch statement, good.
720
721 const SwitchCase *SW = dyn_cast_or_null<SwitchCase>(P->getLabel());
722 if (SW && SW->getSubStmt() == B.getLabel() && P->begin() == P->end())
723 continue; // Previous case label has no statements, good.
724
725 if (P->pred_begin() == P->pred_end()) { // The block is unreachable.
726 // This only catches trivially unreachable blocks.
727 for (CFGBlock::const_iterator ElIt = P->begin(), ElEnd = P->end();
728 ElIt != ElEnd; ++ElIt) {
729 if (const CFGStmt *CS = ElIt->getAs<CFGStmt>()){
730 if (const AttributedStmt *AS = asFallThroughAttr(CS->getStmt())) {
731 S.Diag(AS->getLocStart(),
732 diag::warn_fallthrough_attr_unreachable);
733 markFallthroughVisited(AS);
734 ++AnnotatedCnt;
735 }
736 // Don't care about other unreachable statements.
737 }
738 }
739 // If there are no unreachable statements, this may be a special
740 // case in CFG:
741 // case X: {
742 // A a; // A has a destructor.
743 // break;
744 // }
745 // // <<<< This place is represented by a 'hanging' CFG block.
746 // case Y:
747 continue;
748 }
749
750 const Stmt *LastStmt = getLastStmt(*P);
751 if (const AttributedStmt *AS = asFallThroughAttr(LastStmt)) {
752 markFallthroughVisited(AS);
753 ++AnnotatedCnt;
754 continue; // Fallthrough annotation, good.
755 }
756
757 if (!LastStmt) { // This block contains no executable statements.
758 // Traverse its predecessors.
759 std::copy(P->pred_begin(), P->pred_end(),
760 std::back_inserter(BlockQueue));
761 continue;
762 }
763
764 ++UnannotatedCnt;
765 }
766 return !!UnannotatedCnt;
767 }
768
769 // RecursiveASTVisitor setup.
770 bool shouldWalkTypesOfTypeLocs() const { return false; }
771
772 bool VisitAttributedStmt(AttributedStmt *S) {
773 if (asFallThroughAttr(S))
774 FallthroughStmts.insert(S);
775 return true;
776 }
777
778 bool VisitSwitchStmt(SwitchStmt *S) {
779 FoundSwitchStatements = true;
780 return true;
781 }
782
783 private:
784
785 static const AttributedStmt *asFallThroughAttr(const Stmt *S) {
786 if (const AttributedStmt *AS = dyn_cast_or_null<AttributedStmt>(S)) {
787 if (hasSpecificAttr<FallThroughAttr>(AS->getAttrs()))
788 return AS;
789 }
790 return 0;
791 }
792
793 static const Stmt *getLastStmt(const CFGBlock &B) {
794 if (const Stmt *Term = B.getTerminator())
795 return Term;
796 for (CFGBlock::const_reverse_iterator ElemIt = B.rbegin(),
797 ElemEnd = B.rend();
798 ElemIt != ElemEnd; ++ElemIt) {
799 if (const CFGStmt *CS = ElemIt->getAs<CFGStmt>())
800 return CS->getStmt();
801 }
802 // Workaround to detect a statement thrown out by CFGBuilder:
803 // case X: {} case Y:
804 // case X: ; case Y:
805 if (const SwitchCase *SW = dyn_cast_or_null<SwitchCase>(B.getLabel()))
806 if (!isa<SwitchCase>(SW->getSubStmt()))
807 return SW->getSubStmt();
808
809 return 0;
810 }
811
812 bool FoundSwitchStatements;
813 AttrStmts FallthroughStmts;
814 Sema &S;
815 };
816}
817
Alexander Kornienko19736342012-06-02 01:01:07 +0000818static void DiagnoseSwitchLabelsFallthrough(Sema &S, AnalysisDeclContext &AC,
Sean Huntc2f51cf2012-06-15 21:22:05 +0000819 bool PerFunction) {
Richard Smithe0d3b4c2012-05-03 18:27:39 +0000820 FallthroughMapper FM(S);
821 FM.TraverseStmt(AC.getBody());
822
823 if (!FM.foundSwitchStatements())
824 return;
825
Sean Huntc2f51cf2012-06-15 21:22:05 +0000826 if (PerFunction && FM.getFallthroughStmts().empty())
Alexander Kornienko19736342012-06-02 01:01:07 +0000827 return;
828
Richard Smithe0d3b4c2012-05-03 18:27:39 +0000829 CFG *Cfg = AC.getCFG();
830
831 if (!Cfg)
832 return;
833
834 int AnnotatedCnt;
835
836 for (CFG::reverse_iterator I = Cfg->rbegin(), E = Cfg->rend(); I != E; ++I) {
837 const CFGBlock &B = **I;
838 const Stmt *Label = B.getLabel();
839
840 if (!Label || !isa<SwitchCase>(Label))
841 continue;
842
843 if (!FM.checkFallThroughIntoBlock(B, AnnotatedCnt))
844 continue;
845
Alexander Kornienko19736342012-06-02 01:01:07 +0000846 S.Diag(Label->getLocStart(),
Sean Huntc2f51cf2012-06-15 21:22:05 +0000847 PerFunction ? diag::warn_unannotated_fallthrough_per_function
848 : diag::warn_unannotated_fallthrough);
Richard Smithe0d3b4c2012-05-03 18:27:39 +0000849
850 if (!AnnotatedCnt) {
851 SourceLocation L = Label->getLocStart();
852 if (L.isMacroID())
853 continue;
854 if (S.getLangOpts().CPlusPlus0x) {
Alexander Kornienkoa189d892012-05-26 00:49:15 +0000855 const Stmt *Term = B.getTerminator();
856 if (!(B.empty() && Term && isa<BreakStmt>(Term))) {
Alexander Kornienko66da0ab2012-09-28 22:24:03 +0000857 Preprocessor &PP = S.getPreprocessor();
858 TokenValue Tokens[] = {
859 tok::l_square, tok::l_square, PP.getIdentifierInfo("clang"),
860 tok::coloncolon, PP.getIdentifierInfo("fallthrough"),
861 tok::r_square, tok::r_square
862 };
Dmitri Gribenko19523542012-09-29 11:40:46 +0000863 StringRef AnnotationSpelling = "[[clang::fallthrough]]";
864 StringRef MacroName = PP.getLastMacroWithSpelling(L, Tokens);
865 if (!MacroName.empty())
866 AnnotationSpelling = MacroName;
867 SmallString<64> TextToInsert(AnnotationSpelling);
868 TextToInsert += "; ";
Alexander Kornienkoa189d892012-05-26 00:49:15 +0000869 S.Diag(L, diag::note_insert_fallthrough_fixit) <<
Alexander Kornienko66da0ab2012-09-28 22:24:03 +0000870 AnnotationSpelling <<
Dmitri Gribenko19523542012-09-29 11:40:46 +0000871 FixItHint::CreateInsertion(L, TextToInsert);
Alexander Kornienkoa189d892012-05-26 00:49:15 +0000872 }
Richard Smithe0d3b4c2012-05-03 18:27:39 +0000873 }
874 S.Diag(L, diag::note_insert_break_fixit) <<
875 FixItHint::CreateInsertion(L, "break; ");
876 }
877 }
878
879 const FallthroughMapper::AttrStmts &Fallthroughs = FM.getFallthroughStmts();
880 for (FallthroughMapper::AttrStmts::const_iterator I = Fallthroughs.begin(),
881 E = Fallthroughs.end();
882 I != E; ++I) {
883 S.Diag((*I)->getLocStart(), diag::warn_fallthrough_attr_invalid_placement);
884 }
885
886}
887
Ted Kremenek610068c2011-01-15 02:58:47 +0000888namespace {
Jordan Rose20441c52012-09-28 22:29:02 +0000889typedef std::pair<const Stmt *,
890 sema::FunctionScopeInfo::WeakObjectUseMap::const_iterator>
891 StmtUsesPair;
Jordan Rose58b6bdc2012-09-28 22:21:30 +0000892
Jordan Rose20441c52012-09-28 22:29:02 +0000893class StmtUseSorter {
Jordan Rose58b6bdc2012-09-28 22:21:30 +0000894 const SourceManager &SM;
895
896public:
Jordan Rose20441c52012-09-28 22:29:02 +0000897 explicit StmtUseSorter(const SourceManager &SM) : SM(SM) { }
Jordan Rose58b6bdc2012-09-28 22:21:30 +0000898
899 bool operator()(const StmtUsesPair &LHS, const StmtUsesPair &RHS) {
900 return SM.isBeforeInTranslationUnit(LHS.first->getLocStart(),
901 RHS.first->getLocStart());
902 }
903};
Jordan Rose20441c52012-09-28 22:29:02 +0000904}
Jordan Rose58b6bdc2012-09-28 22:21:30 +0000905
906
907static void diagnoseRepeatedUseOfWeak(Sema &S,
908 const sema::FunctionScopeInfo *CurFn,
909 const Decl *D) {
910 typedef sema::FunctionScopeInfo::WeakObjectProfileTy WeakObjectProfileTy;
911 typedef sema::FunctionScopeInfo::WeakObjectUseMap WeakObjectUseMap;
912 typedef sema::FunctionScopeInfo::WeakUseVector WeakUseVector;
913
914 const WeakObjectUseMap &WeakMap = CurFn->getWeakObjectUses();
915
916 // Extract all weak objects that are referenced more than once.
917 SmallVector<StmtUsesPair, 8> UsesByStmt;
918 for (WeakObjectUseMap::const_iterator I = WeakMap.begin(), E = WeakMap.end();
919 I != E; ++I) {
920 const WeakUseVector &Uses = I->second;
921 if (Uses.size() <= 1)
922 continue;
923
924 // Find the first read of the weak object.
925 WeakUseVector::const_iterator UI = Uses.begin(), UE = Uses.end();
926 for ( ; UI != UE; ++UI) {
927 if (UI->isUnsafe())
928 break;
929 }
930
931 // If there were only writes to this object, don't warn.
932 if (UI == UE)
933 continue;
934
935 UsesByStmt.push_back(StmtUsesPair(UI->getUseExpr(), I));
936 }
937
938 if (UsesByStmt.empty())
939 return;
940
941 // Sort by first use so that we emit the warnings in a deterministic order.
942 std::sort(UsesByStmt.begin(), UsesByStmt.end(),
Jordan Rose20441c52012-09-28 22:29:02 +0000943 StmtUseSorter(S.getSourceManager()));
Jordan Rose58b6bdc2012-09-28 22:21:30 +0000944
945 // Classify the current code body for better warning text.
946 // This enum should stay in sync with the cases in
947 // warn_arc_repeated_use_of_weak and warn_arc_possible_repeated_use_of_weak.
948 // FIXME: Should we use a common classification enum and the same set of
949 // possibilities all throughout Sema?
950 enum {
951 Function,
952 Method,
953 Block,
954 Lambda
955 } FunctionKind;
956
957 if (isa<sema::BlockScopeInfo>(CurFn))
958 FunctionKind = Block;
959 else if (isa<sema::LambdaScopeInfo>(CurFn))
960 FunctionKind = Lambda;
961 else if (isa<ObjCMethodDecl>(D))
962 FunctionKind = Method;
963 else
964 FunctionKind = Function;
965
966 // Iterate through the sorted problems and emit warnings for each.
967 for (SmallVectorImpl<StmtUsesPair>::const_iterator I = UsesByStmt.begin(),
968 E = UsesByStmt.end();
969 I != E; ++I) {
970 const Stmt *FirstRead = I->first;
971 const WeakObjectProfileTy &Key = I->second->first;
972 const WeakUseVector &Uses = I->second->second;
973
Jordan Rose7a270482012-09-28 22:21:35 +0000974 // For complicated expressions like 'a.b.c' and 'x.b.c', WeakObjectProfileTy
975 // may not contain enough information to determine that these are different
976 // properties. We can only be 100% sure of a repeated use in certain cases,
977 // and we adjust the diagnostic kind accordingly so that the less certain
978 // case can be turned off if it is too noisy.
Jordan Rose58b6bdc2012-09-28 22:21:30 +0000979 unsigned DiagKind;
980 if (Key.isExactProfile())
981 DiagKind = diag::warn_arc_repeated_use_of_weak;
982 else
983 DiagKind = diag::warn_arc_possible_repeated_use_of_weak;
984
Jordan Rose7a270482012-09-28 22:21:35 +0000985 // Classify the weak object being accessed for better warning text.
986 // This enum should stay in sync with the cases in
987 // warn_arc_repeated_use_of_weak and warn_arc_possible_repeated_use_of_weak.
988 enum {
989 Variable,
990 Property,
991 ImplicitProperty,
992 Ivar
993 } ObjectKind;
994
995 const NamedDecl *D = Key.getProperty();
996 if (isa<VarDecl>(D))
997 ObjectKind = Variable;
998 else if (isa<ObjCPropertyDecl>(D))
999 ObjectKind = Property;
1000 else if (isa<ObjCMethodDecl>(D))
1001 ObjectKind = ImplicitProperty;
1002 else if (isa<ObjCIvarDecl>(D))
1003 ObjectKind = Ivar;
1004 else
1005 llvm_unreachable("Unexpected weak object kind!");
1006
Jordan Rose58b6bdc2012-09-28 22:21:30 +00001007 // Show the first time the object was read.
1008 S.Diag(FirstRead->getLocStart(), DiagKind)
Jordan Rose7a270482012-09-28 22:21:35 +00001009 << ObjectKind << D << FunctionKind
Jordan Rose58b6bdc2012-09-28 22:21:30 +00001010 << FirstRead->getSourceRange();
1011
1012 // Print all the other accesses as notes.
1013 for (WeakUseVector::const_iterator UI = Uses.begin(), UE = Uses.end();
1014 UI != UE; ++UI) {
1015 if (UI->getUseExpr() == FirstRead)
1016 continue;
1017 S.Diag(UI->getUseExpr()->getLocStart(),
1018 diag::note_arc_weak_also_accessed_here)
1019 << UI->getUseExpr()->getSourceRange();
1020 }
1021 }
1022}
1023
1024
1025namespace {
Ted Kremenek94b1b4d2011-01-21 19:41:41 +00001026struct SLocSort {
Ted Kremenekf7bafc72011-03-15 04:57:38 +00001027 bool operator()(const UninitUse &a, const UninitUse &b) {
Richard Smith2815e1a2012-05-25 02:17:09 +00001028 // Prefer a more confident report over a less confident one.
1029 if (a.getKind() != b.getKind())
1030 return a.getKind() > b.getKind();
1031 SourceLocation aLoc = a.getUser()->getLocStart();
1032 SourceLocation bLoc = b.getUser()->getLocStart();
Ted Kremenek94b1b4d2011-01-21 19:41:41 +00001033 return aLoc.getRawEncoding() < bLoc.getRawEncoding();
1034 }
1035};
1036
Ted Kremenek610068c2011-01-15 02:58:47 +00001037class UninitValsDiagReporter : public UninitVariablesHandler {
1038 Sema &S;
Chris Lattner5f9e2722011-07-23 10:55:15 +00001039 typedef SmallVector<UninitUse, 2> UsesVec;
Ted Kremenek9e761722011-10-13 18:50:06 +00001040 typedef llvm::DenseMap<const VarDecl *, std::pair<UsesVec*, bool> > UsesMap;
Ted Kremenek94b1b4d2011-01-21 19:41:41 +00001041 UsesMap *uses;
1042
Ted Kremenek610068c2011-01-15 02:58:47 +00001043public:
Ted Kremenek94b1b4d2011-01-21 19:41:41 +00001044 UninitValsDiagReporter(Sema &S) : S(S), uses(0) {}
1045 ~UninitValsDiagReporter() {
1046 flushDiagnostics();
1047 }
Ted Kremenek9e761722011-10-13 18:50:06 +00001048
1049 std::pair<UsesVec*, bool> &getUses(const VarDecl *vd) {
Ted Kremenek94b1b4d2011-01-21 19:41:41 +00001050 if (!uses)
1051 uses = new UsesMap();
Ted Kremenek9e761722011-10-13 18:50:06 +00001052
1053 UsesMap::mapped_type &V = (*uses)[vd];
1054 UsesVec *&vec = V.first;
Ted Kremenek94b1b4d2011-01-21 19:41:41 +00001055 if (!vec)
1056 vec = new UsesVec();
1057
Ted Kremenek9e761722011-10-13 18:50:06 +00001058 return V;
1059 }
1060
Richard Smith2815e1a2012-05-25 02:17:09 +00001061 void handleUseOfUninitVariable(const VarDecl *vd, const UninitUse &use) {
1062 getUses(vd).first->push_back(use);
Ted Kremenek9e761722011-10-13 18:50:06 +00001063 }
1064
1065 void handleSelfInit(const VarDecl *vd) {
1066 getUses(vd).second = true;
Ted Kremenek94b1b4d2011-01-21 19:41:41 +00001067 }
1068
1069 void flushDiagnostics() {
1070 if (!uses)
1071 return;
Ted Kremenek609e3172011-02-02 23:35:53 +00001072
Richard Smith81891882012-05-24 23:45:35 +00001073 // FIXME: This iteration order, and thus the resulting diagnostic order,
1074 // is nondeterministic.
Ted Kremenek94b1b4d2011-01-21 19:41:41 +00001075 for (UsesMap::iterator i = uses->begin(), e = uses->end(); i != e; ++i) {
1076 const VarDecl *vd = i->first;
Ted Kremenek9e761722011-10-13 18:50:06 +00001077 const UsesMap::mapped_type &V = i->second;
Ted Kremenek609e3172011-02-02 23:35:53 +00001078
Ted Kremenek9e761722011-10-13 18:50:06 +00001079 UsesVec *vec = V.first;
1080 bool hasSelfInit = V.second;
1081
1082 // Specially handle the case where we have uses of an uninitialized
1083 // variable, but the root cause is an idiomatic self-init. We want
1084 // to report the diagnostic at the self-init since that is the root cause.
Matt Beaumont-Gay0d381812011-10-19 18:53:03 +00001085 if (!vec->empty() && hasSelfInit && hasAlwaysUninitializedUse(vec))
Richard Smith2815e1a2012-05-25 02:17:09 +00001086 DiagnoseUninitializedUse(S, vd,
1087 UninitUse(vd->getInit()->IgnoreParenCasts(),
1088 /* isAlwaysUninit */ true),
Matt Beaumont-Gay0d381812011-10-19 18:53:03 +00001089 /* alwaysReportSelfInit */ true);
Ted Kremenek9e761722011-10-13 18:50:06 +00001090 else {
1091 // Sort the uses by their SourceLocations. While not strictly
1092 // guaranteed to produce them in line/column order, this will provide
1093 // a stable ordering.
1094 std::sort(vec->begin(), vec->end(), SLocSort());
1095
1096 for (UsesVec::iterator vi = vec->begin(), ve = vec->end(); vi != ve;
1097 ++vi) {
Richard Smith2815e1a2012-05-25 02:17:09 +00001098 // If we have self-init, downgrade all uses to 'may be uninitialized'.
1099 UninitUse Use = hasSelfInit ? UninitUse(vi->getUser(), false) : *vi;
1100
1101 if (DiagnoseUninitializedUse(S, vd, Use))
Ted Kremenek9e761722011-10-13 18:50:06 +00001102 // Skip further diagnostics for this variable. We try to warn only
1103 // on the first point at which a variable is used uninitialized.
1104 break;
1105 }
Chandler Carruth64fb9592011-04-05 18:18:08 +00001106 }
Ted Kremenek9e761722011-10-13 18:50:06 +00001107
1108 // Release the uses vector.
Ted Kremenek94b1b4d2011-01-21 19:41:41 +00001109 delete vec;
1110 }
1111 delete uses;
Ted Kremenek610068c2011-01-15 02:58:47 +00001112 }
Matt Beaumont-Gay0d381812011-10-19 18:53:03 +00001113
1114private:
1115 static bool hasAlwaysUninitializedUse(const UsesVec* vec) {
1116 for (UsesVec::const_iterator i = vec->begin(), e = vec->end(); i != e; ++i) {
Richard Smith2815e1a2012-05-25 02:17:09 +00001117 if (i->getKind() == UninitUse::Always) {
Matt Beaumont-Gay0d381812011-10-19 18:53:03 +00001118 return true;
1119 }
1120 }
1121 return false;
1122}
Ted Kremenek610068c2011-01-15 02:58:47 +00001123};
1124}
1125
Caitlin Sadowski3ac1fbc2011-08-23 18:46:34 +00001126
1127//===----------------------------------------------------------------------===//
1128// -Wthread-safety
1129//===----------------------------------------------------------------------===//
Caitlin Sadowski75f23ae2011-09-09 16:04:02 +00001130namespace clang {
1131namespace thread_safety {
Richard Smith2e515622012-02-03 04:45:26 +00001132typedef llvm::SmallVector<PartialDiagnosticAt, 1> OptionalNotes;
1133typedef std::pair<PartialDiagnosticAt, OptionalNotes> DelayedDiag;
Benjamin Kramerecafd302012-03-26 14:05:40 +00001134typedef std::list<DelayedDiag> DiagList;
Caitlin Sadowski75f23ae2011-09-09 16:04:02 +00001135
Caitlin Sadowski75f23ae2011-09-09 16:04:02 +00001136struct SortDiagBySourceLocation {
Benjamin Kramerecafd302012-03-26 14:05:40 +00001137 SourceManager &SM;
1138 SortDiagBySourceLocation(SourceManager &SM) : SM(SM) {}
Caitlin Sadowski75f23ae2011-09-09 16:04:02 +00001139
1140 bool operator()(const DelayedDiag &left, const DelayedDiag &right) {
1141 // Although this call will be slow, this is only called when outputting
1142 // multiple warnings.
Benjamin Kramerecafd302012-03-26 14:05:40 +00001143 return SM.isBeforeInTranslationUnit(left.first.first, right.first.first);
Caitlin Sadowski75f23ae2011-09-09 16:04:02 +00001144 }
1145};
1146
David Blaikie99ba9e32011-12-20 02:48:34 +00001147namespace {
Caitlin Sadowski75f23ae2011-09-09 16:04:02 +00001148class ThreadSafetyReporter : public clang::thread_safety::ThreadSafetyHandler {
1149 Sema &S;
1150 DiagList Warnings;
Richard Smith2e515622012-02-03 04:45:26 +00001151 SourceLocation FunLocation, FunEndLocation;
Caitlin Sadowski75f23ae2011-09-09 16:04:02 +00001152
1153 // Helper functions
1154 void warnLockMismatch(unsigned DiagID, Name LockName, SourceLocation Loc) {
DeLesley Hutchinsf1ac6372011-10-21 18:10:14 +00001155 // Gracefully handle rare cases when the analysis can't get a more
1156 // precise source location.
1157 if (!Loc.isValid())
1158 Loc = FunLocation;
Richard Smith2e515622012-02-03 04:45:26 +00001159 PartialDiagnosticAt Warning(Loc, S.PDiag(DiagID) << LockName);
1160 Warnings.push_back(DelayedDiag(Warning, OptionalNotes()));
Caitlin Sadowski75f23ae2011-09-09 16:04:02 +00001161 }
1162
1163 public:
Richard Smith2e515622012-02-03 04:45:26 +00001164 ThreadSafetyReporter(Sema &S, SourceLocation FL, SourceLocation FEL)
1165 : S(S), FunLocation(FL), FunEndLocation(FEL) {}
Caitlin Sadowski75f23ae2011-09-09 16:04:02 +00001166
1167 /// \brief Emit all buffered diagnostics in order of sourcelocation.
1168 /// We need to output diagnostics produced while iterating through
1169 /// the lockset in deterministic order, so this function orders diagnostics
1170 /// and outputs them.
1171 void emitDiagnostics() {
Benjamin Kramerecafd302012-03-26 14:05:40 +00001172 Warnings.sort(SortDiagBySourceLocation(S.getSourceManager()));
Caitlin Sadowski75f23ae2011-09-09 16:04:02 +00001173 for (DiagList::iterator I = Warnings.begin(), E = Warnings.end();
Richard Smith2e515622012-02-03 04:45:26 +00001174 I != E; ++I) {
1175 S.Diag(I->first.first, I->first.second);
1176 const OptionalNotes &Notes = I->second;
1177 for (unsigned NoteI = 0, NoteN = Notes.size(); NoteI != NoteN; ++NoteI)
1178 S.Diag(Notes[NoteI].first, Notes[NoteI].second);
1179 }
Caitlin Sadowski75f23ae2011-09-09 16:04:02 +00001180 }
1181
Caitlin Sadowski99107eb2011-09-09 16:21:55 +00001182 void handleInvalidLockExp(SourceLocation Loc) {
Richard Smith2e515622012-02-03 04:45:26 +00001183 PartialDiagnosticAt Warning(Loc,
1184 S.PDiag(diag::warn_cannot_resolve_lock) << Loc);
1185 Warnings.push_back(DelayedDiag(Warning, OptionalNotes()));
Caitlin Sadowski99107eb2011-09-09 16:21:55 +00001186 }
Caitlin Sadowski75f23ae2011-09-09 16:04:02 +00001187 void handleUnmatchedUnlock(Name LockName, SourceLocation Loc) {
1188 warnLockMismatch(diag::warn_unlock_but_no_lock, LockName, Loc);
1189 }
1190
1191 void handleDoubleLock(Name LockName, SourceLocation Loc) {
1192 warnLockMismatch(diag::warn_double_lock, LockName, Loc);
1193 }
1194
Richard Smith2e515622012-02-03 04:45:26 +00001195 void handleMutexHeldEndOfScope(Name LockName, SourceLocation LocLocked,
1196 SourceLocation LocEndOfScope,
Caitlin Sadowski4e4bc752011-09-15 17:25:19 +00001197 LockErrorKind LEK){
1198 unsigned DiagID = 0;
1199 switch (LEK) {
1200 case LEK_LockedSomePredecessors:
Richard Smith2e515622012-02-03 04:45:26 +00001201 DiagID = diag::warn_lock_some_predecessors;
Caitlin Sadowski4e4bc752011-09-15 17:25:19 +00001202 break;
1203 case LEK_LockedSomeLoopIterations:
1204 DiagID = diag::warn_expecting_lock_held_on_loop;
1205 break;
1206 case LEK_LockedAtEndOfFunction:
1207 DiagID = diag::warn_no_unlock;
1208 break;
DeLesley Hutchins879a4332012-07-02 22:16:54 +00001209 case LEK_NotLockedAtEndOfFunction:
1210 DiagID = diag::warn_expecting_locked;
1211 break;
Caitlin Sadowski4e4bc752011-09-15 17:25:19 +00001212 }
Richard Smith2e515622012-02-03 04:45:26 +00001213 if (LocEndOfScope.isInvalid())
1214 LocEndOfScope = FunEndLocation;
1215
1216 PartialDiagnosticAt Warning(LocEndOfScope, S.PDiag(DiagID) << LockName);
1217 PartialDiagnosticAt Note(LocLocked, S.PDiag(diag::note_locked_here));
1218 Warnings.push_back(DelayedDiag(Warning, OptionalNotes(1, Note)));
Caitlin Sadowski75f23ae2011-09-09 16:04:02 +00001219 }
1220
Caitlin Sadowski75f23ae2011-09-09 16:04:02 +00001221
1222 void handleExclusiveAndShared(Name LockName, SourceLocation Loc1,
1223 SourceLocation Loc2) {
Richard Smith2e515622012-02-03 04:45:26 +00001224 PartialDiagnosticAt Warning(
1225 Loc1, S.PDiag(diag::warn_lock_exclusive_and_shared) << LockName);
1226 PartialDiagnosticAt Note(
1227 Loc2, S.PDiag(diag::note_lock_exclusive_and_shared) << LockName);
1228 Warnings.push_back(DelayedDiag(Warning, OptionalNotes(1, Note)));
Caitlin Sadowski75f23ae2011-09-09 16:04:02 +00001229 }
1230
1231 void handleNoMutexHeld(const NamedDecl *D, ProtectedOperationKind POK,
1232 AccessKind AK, SourceLocation Loc) {
Caitlin Sadowskidf8327c2011-09-14 20:09:09 +00001233 assert((POK == POK_VarAccess || POK == POK_VarDereference)
1234 && "Only works for variables");
1235 unsigned DiagID = POK == POK_VarAccess?
1236 diag::warn_variable_requires_any_lock:
1237 diag::warn_var_deref_requires_any_lock;
Richard Smith2e515622012-02-03 04:45:26 +00001238 PartialDiagnosticAt Warning(Loc, S.PDiag(DiagID)
DeLesley Hutchins5b280f22012-09-19 19:18:29 +00001239 << D->getNameAsString() << getLockKindFromAccessKind(AK));
Richard Smith2e515622012-02-03 04:45:26 +00001240 Warnings.push_back(DelayedDiag(Warning, OptionalNotes()));
Caitlin Sadowski75f23ae2011-09-09 16:04:02 +00001241 }
1242
1243 void handleMutexNotHeld(const NamedDecl *D, ProtectedOperationKind POK,
DeLesley Hutchins3f0ec522012-09-10 19:58:23 +00001244 Name LockName, LockKind LK, SourceLocation Loc,
1245 Name *PossibleMatch) {
Caitlin Sadowskie87158d2011-09-13 18:01:58 +00001246 unsigned DiagID = 0;
DeLesley Hutchins3f0ec522012-09-10 19:58:23 +00001247 if (PossibleMatch) {
1248 switch (POK) {
1249 case POK_VarAccess:
1250 DiagID = diag::warn_variable_requires_lock_precise;
1251 break;
1252 case POK_VarDereference:
1253 DiagID = diag::warn_var_deref_requires_lock_precise;
1254 break;
1255 case POK_FunctionCall:
1256 DiagID = diag::warn_fun_requires_lock_precise;
1257 break;
1258 }
1259 PartialDiagnosticAt Warning(Loc, S.PDiag(DiagID)
DeLesley Hutchins5b280f22012-09-19 19:18:29 +00001260 << D->getNameAsString() << LockName << LK);
DeLesley Hutchins3f0ec522012-09-10 19:58:23 +00001261 PartialDiagnosticAt Note(Loc, S.PDiag(diag::note_found_mutex_near_match)
1262 << *PossibleMatch);
1263 Warnings.push_back(DelayedDiag(Warning, OptionalNotes(1, Note)));
1264 } else {
1265 switch (POK) {
1266 case POK_VarAccess:
1267 DiagID = diag::warn_variable_requires_lock;
1268 break;
1269 case POK_VarDereference:
1270 DiagID = diag::warn_var_deref_requires_lock;
1271 break;
1272 case POK_FunctionCall:
1273 DiagID = diag::warn_fun_requires_lock;
1274 break;
1275 }
1276 PartialDiagnosticAt Warning(Loc, S.PDiag(DiagID)
DeLesley Hutchins5b280f22012-09-19 19:18:29 +00001277 << D->getNameAsString() << LockName << LK);
DeLesley Hutchins3f0ec522012-09-10 19:58:23 +00001278 Warnings.push_back(DelayedDiag(Warning, OptionalNotes()));
Caitlin Sadowski75f23ae2011-09-09 16:04:02 +00001279 }
Caitlin Sadowski75f23ae2011-09-09 16:04:02 +00001280 }
1281
1282 void handleFunExcludesLock(Name FunName, Name LockName, SourceLocation Loc) {
Richard Smith2e515622012-02-03 04:45:26 +00001283 PartialDiagnosticAt Warning(Loc,
1284 S.PDiag(diag::warn_fun_excludes_mutex) << FunName << LockName);
1285 Warnings.push_back(DelayedDiag(Warning, OptionalNotes()));
Caitlin Sadowski75f23ae2011-09-09 16:04:02 +00001286 }
1287};
1288}
1289}
David Blaikie99ba9e32011-12-20 02:48:34 +00001290}
Caitlin Sadowski75f23ae2011-09-09 16:04:02 +00001291
Ted Kremenek610068c2011-01-15 02:58:47 +00001292//===----------------------------------------------------------------------===//
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +00001293// AnalysisBasedWarnings - Worker object used by Sema to execute analysis-based
1294// warnings on a function, method, or block.
1295//===----------------------------------------------------------------------===//
1296
Ted Kremenekd064fdc2010-03-23 00:13:23 +00001297clang::sema::AnalysisBasedWarnings::Policy::Policy() {
1298 enableCheckFallThrough = 1;
1299 enableCheckUnreachable = 0;
Caitlin Sadowski3ac1fbc2011-08-23 18:46:34 +00001300 enableThreadSafetyAnalysis = 0;
Ted Kremenekd064fdc2010-03-23 00:13:23 +00001301}
1302
Chandler Carruth5d989942011-07-06 16:21:37 +00001303clang::sema::AnalysisBasedWarnings::AnalysisBasedWarnings(Sema &s)
1304 : S(s),
1305 NumFunctionsAnalyzed(0),
Benjamin Kramer54cf3412011-07-08 20:38:53 +00001306 NumFunctionsWithBadCFGs(0),
Chandler Carruth5d989942011-07-06 16:21:37 +00001307 NumCFGBlocks(0),
Benjamin Kramer54cf3412011-07-08 20:38:53 +00001308 MaxCFGBlocksPerFunction(0),
1309 NumUninitAnalysisFunctions(0),
1310 NumUninitAnalysisVariables(0),
1311 MaxUninitAnalysisVariablesPerFunction(0),
1312 NumUninitAnalysisBlockVisits(0),
1313 MaxUninitAnalysisBlockVisitsPerFunction(0) {
David Blaikied6471f72011-09-25 23:23:43 +00001314 DiagnosticsEngine &D = S.getDiagnostics();
Ted Kremenekd064fdc2010-03-23 00:13:23 +00001315 DefaultPolicy.enableCheckUnreachable = (unsigned)
Argyrios Kyrtzidis08274082010-12-15 18:44:22 +00001316 (D.getDiagnosticLevel(diag::warn_unreachable, SourceLocation()) !=
David Blaikied6471f72011-09-25 23:23:43 +00001317 DiagnosticsEngine::Ignored);
Caitlin Sadowski3ac1fbc2011-08-23 18:46:34 +00001318 DefaultPolicy.enableThreadSafetyAnalysis = (unsigned)
1319 (D.getDiagnosticLevel(diag::warn_double_lock, SourceLocation()) !=
David Blaikied6471f72011-09-25 23:23:43 +00001320 DiagnosticsEngine::Ignored);
Caitlin Sadowski3ac1fbc2011-08-23 18:46:34 +00001321
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +00001322}
1323
Ted Kremenek351ba912011-02-23 01:52:04 +00001324static void flushDiagnostics(Sema &S, sema::FunctionScopeInfo *fscope) {
Chris Lattner5f9e2722011-07-23 10:55:15 +00001325 for (SmallVectorImpl<sema::PossiblyUnreachableDiag>::iterator
Ted Kremenek351ba912011-02-23 01:52:04 +00001326 i = fscope->PossiblyUnreachableDiags.begin(),
1327 e = fscope->PossiblyUnreachableDiags.end();
1328 i != e; ++i) {
1329 const sema::PossiblyUnreachableDiag &D = *i;
1330 S.Diag(D.Loc, D.PD);
1331 }
1332}
1333
Ted Kremenekd064fdc2010-03-23 00:13:23 +00001334void clang::sema::
1335AnalysisBasedWarnings::IssueWarnings(sema::AnalysisBasedWarnings::Policy P,
Ted Kremenek283a3582011-02-23 01:51:53 +00001336 sema::FunctionScopeInfo *fscope,
Ted Kremenek3ed6fc02011-02-23 01:51:48 +00001337 const Decl *D, const BlockExpr *blkExpr) {
Ted Kremenekd068aab2010-03-20 21:11:09 +00001338
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +00001339 // We avoid doing analysis-based warnings when there are errors for
1340 // two reasons:
1341 // (1) The CFGs often can't be constructed (if the body is invalid), so
1342 // don't bother trying.
1343 // (2) The code already has problems; running the analysis just takes more
1344 // time.
David Blaikied6471f72011-09-25 23:23:43 +00001345 DiagnosticsEngine &Diags = S.getDiagnostics();
Ted Kremenek99e81922010-04-30 21:49:25 +00001346
Ted Kremenekd064fdc2010-03-23 00:13:23 +00001347 // Do not do any analysis for declarations in system headers if we are
1348 // going to just ignore them.
Ted Kremenek99e81922010-04-30 21:49:25 +00001349 if (Diags.getSuppressSystemWarnings() &&
Ted Kremenekd064fdc2010-03-23 00:13:23 +00001350 S.SourceMgr.isInSystemHeader(D->getLocation()))
1351 return;
1352
John McCalle0054f62010-08-25 05:56:39 +00001353 // For code in dependent contexts, we'll do this at instantiation time.
David Blaikie23661d32012-01-24 04:51:48 +00001354 if (cast<DeclContext>(D)->isDependentContext())
1355 return;
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +00001356
Ted Kremenek351ba912011-02-23 01:52:04 +00001357 if (Diags.hasErrorOccurred() || Diags.hasFatalErrorOccurred()) {
1358 // Flush out any possibly unreachable diagnostics.
1359 flushDiagnostics(S, fscope);
1360 return;
1361 }
1362
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +00001363 const Stmt *Body = D->getBody();
1364 assert(Body);
1365
Jordy Rosed2001872012-04-28 01:58:08 +00001366 AnalysisDeclContext AC(/* AnalysisDeclContextManager */ 0, D);
Ted Kremenekbc5cb8a2011-07-21 05:22:47 +00001367
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +00001368 // Don't generate EH edges for CallExprs as we'd like to avoid the n^2
1369 // explosion for destrutors that can result and the compile time hit.
Ted Kremenekbc5cb8a2011-07-21 05:22:47 +00001370 AC.getCFGBuildOptions().PruneTriviallyFalseEdges = true;
1371 AC.getCFGBuildOptions().AddEHEdges = false;
1372 AC.getCFGBuildOptions().AddInitializers = true;
1373 AC.getCFGBuildOptions().AddImplicitDtors = true;
Jordan Rosefaadf482012-09-05 23:11:06 +00001374 AC.getCFGBuildOptions().AddTemporaryDtors = true;
1375
Ted Kremenek0c8e5a02011-07-19 14:18:48 +00001376 // Force that certain expressions appear as CFGElements in the CFG. This
1377 // is used to speed up various analyses.
1378 // FIXME: This isn't the right factoring. This is here for initial
1379 // prototyping, but we need a way for analyses to say what expressions they
1380 // expect to always be CFGElements and then fill in the BuildOptions
1381 // appropriately. This is essentially a layering violation.
DeLesley Hutchins1fa3c062011-12-08 20:23:06 +00001382 if (P.enableCheckUnreachable || P.enableThreadSafetyAnalysis) {
1383 // Unreachable code analysis and thread safety require a linearized CFG.
Ted Kremenek0f3b4ca2011-08-23 23:05:11 +00001384 AC.getCFGBuildOptions().setAllAlwaysAdd();
1385 }
1386 else {
1387 AC.getCFGBuildOptions()
1388 .setAlwaysAdd(Stmt::BinaryOperatorClass)
Richard Smith6cfa78f2012-07-17 01:27:33 +00001389 .setAlwaysAdd(Stmt::CompoundAssignOperatorClass)
Ted Kremenek0f3b4ca2011-08-23 23:05:11 +00001390 .setAlwaysAdd(Stmt::BlockExprClass)
1391 .setAlwaysAdd(Stmt::CStyleCastExprClass)
1392 .setAlwaysAdd(Stmt::DeclRefExprClass)
1393 .setAlwaysAdd(Stmt::ImplicitCastExprClass)
Richard Smithe0d3b4c2012-05-03 18:27:39 +00001394 .setAlwaysAdd(Stmt::UnaryOperatorClass)
1395 .setAlwaysAdd(Stmt::AttributedStmtClass);
Ted Kremenek0f3b4ca2011-08-23 23:05:11 +00001396 }
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +00001397
Ted Kremenekbc5cb8a2011-07-21 05:22:47 +00001398 // Construct the analysis context with the specified CFG build options.
1399
Ted Kremenek351ba912011-02-23 01:52:04 +00001400 // Emit delayed diagnostics.
David Blaikie23661d32012-01-24 04:51:48 +00001401 if (!fscope->PossiblyUnreachableDiags.empty()) {
Ted Kremenek351ba912011-02-23 01:52:04 +00001402 bool analyzed = false;
Ted Kremenek0d28d362011-03-10 03:50:34 +00001403
1404 // Register the expressions with the CFGBuilder.
Chris Lattner5f9e2722011-07-23 10:55:15 +00001405 for (SmallVectorImpl<sema::PossiblyUnreachableDiag>::iterator
Ted Kremenek0d28d362011-03-10 03:50:34 +00001406 i = fscope->PossiblyUnreachableDiags.begin(),
1407 e = fscope->PossiblyUnreachableDiags.end();
1408 i != e; ++i) {
1409 if (const Stmt *stmt = i->stmt)
1410 AC.registerForcedBlockExpression(stmt);
1411 }
1412
1413 if (AC.getCFG()) {
1414 analyzed = true;
Chris Lattner5f9e2722011-07-23 10:55:15 +00001415 for (SmallVectorImpl<sema::PossiblyUnreachableDiag>::iterator
Ted Kremenek0d28d362011-03-10 03:50:34 +00001416 i = fscope->PossiblyUnreachableDiags.begin(),
1417 e = fscope->PossiblyUnreachableDiags.end();
1418 i != e; ++i)
1419 {
1420 const sema::PossiblyUnreachableDiag &D = *i;
1421 bool processed = false;
1422 if (const Stmt *stmt = i->stmt) {
1423 const CFGBlock *block = AC.getBlockForRegisteredExpression(stmt);
Eli Friedman71b8fb52012-01-21 01:01:51 +00001424 CFGReverseBlockReachabilityAnalysis *cra =
1425 AC.getCFGReachablityAnalysis();
1426 // FIXME: We should be able to assert that block is non-null, but
1427 // the CFG analysis can skip potentially-evaluated expressions in
1428 // edge cases; see test/Sema/vla-2.c.
1429 if (block && cra) {
Ted Kremenek351ba912011-02-23 01:52:04 +00001430 // Can this block be reached from the entrance?
Ted Kremenek0d28d362011-03-10 03:50:34 +00001431 if (cra->isReachable(&AC.getCFG()->getEntry(), block))
Ted Kremenek351ba912011-02-23 01:52:04 +00001432 S.Diag(D.Loc, D.PD);
Ted Kremenek0d28d362011-03-10 03:50:34 +00001433 processed = true;
Ted Kremenek351ba912011-02-23 01:52:04 +00001434 }
1435 }
Ted Kremenek0d28d362011-03-10 03:50:34 +00001436 if (!processed) {
1437 // Emit the warning anyway if we cannot map to a basic block.
1438 S.Diag(D.Loc, D.PD);
1439 }
Ted Kremenek351ba912011-02-23 01:52:04 +00001440 }
Ted Kremenek0d28d362011-03-10 03:50:34 +00001441 }
Ted Kremenek351ba912011-02-23 01:52:04 +00001442
1443 if (!analyzed)
1444 flushDiagnostics(S, fscope);
1445 }
1446
1447
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +00001448 // Warning: check missing 'return'
David Blaikie23661d32012-01-24 04:51:48 +00001449 if (P.enableCheckFallThrough) {
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +00001450 const CheckFallThroughDiagnostics &CD =
1451 (isa<BlockDecl>(D) ? CheckFallThroughDiagnostics::MakeForBlock()
Douglas Gregor793cd1c2012-02-15 16:20:15 +00001452 : (isa<CXXMethodDecl>(D) &&
1453 cast<CXXMethodDecl>(D)->getOverloadedOperator() == OO_Call &&
1454 cast<CXXMethodDecl>(D)->getParent()->isLambda())
1455 ? CheckFallThroughDiagnostics::MakeForLambda()
1456 : CheckFallThroughDiagnostics::MakeForFunction(D));
Ted Kremenek3ed6fc02011-02-23 01:51:48 +00001457 CheckFallThroughForBody(S, D, Body, blkExpr, CD, AC);
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +00001458 }
1459
1460 // Warning: check for unreachable code
Ted Kremenek5dfee062011-11-30 21:22:09 +00001461 if (P.enableCheckUnreachable) {
1462 // Only check for unreachable code on non-template instantiations.
1463 // Different template instantiations can effectively change the control-flow
1464 // and it is very difficult to prove that a snippet of code in a template
1465 // is unreachable for all instantiations.
Ted Kremenek75df4ee2011-12-01 00:59:17 +00001466 bool isTemplateInstantiation = false;
1467 if (const FunctionDecl *Function = dyn_cast<FunctionDecl>(D))
1468 isTemplateInstantiation = Function->isTemplateInstantiation();
1469 if (!isTemplateInstantiation)
Ted Kremenek5dfee062011-11-30 21:22:09 +00001470 CheckUnreachable(S, AC);
1471 }
Caitlin Sadowski75f23ae2011-09-09 16:04:02 +00001472
Caitlin Sadowski3ac1fbc2011-08-23 18:46:34 +00001473 // Check for thread safety violations
David Blaikie23661d32012-01-24 04:51:48 +00001474 if (P.enableThreadSafetyAnalysis) {
DeLesley Hutchinsf1ac6372011-10-21 18:10:14 +00001475 SourceLocation FL = AC.getDecl()->getLocation();
Richard Smith2e515622012-02-03 04:45:26 +00001476 SourceLocation FEL = AC.getDecl()->getLocEnd();
1477 thread_safety::ThreadSafetyReporter Reporter(S, FL, FEL);
Caitlin Sadowski75f23ae2011-09-09 16:04:02 +00001478 thread_safety::runThreadSafetyAnalysis(AC, Reporter);
1479 Reporter.emitDiagnostics();
1480 }
Caitlin Sadowski3ac1fbc2011-08-23 18:46:34 +00001481
Ted Kremeneka8c17a52011-01-25 19:13:48 +00001482 if (Diags.getDiagnosticLevel(diag::warn_uninit_var, D->getLocStart())
David Blaikied6471f72011-09-25 23:23:43 +00001483 != DiagnosticsEngine::Ignored ||
Richard Smith2815e1a2012-05-25 02:17:09 +00001484 Diags.getDiagnosticLevel(diag::warn_sometimes_uninit_var,D->getLocStart())
1485 != DiagnosticsEngine::Ignored ||
Ted Kremenek76709bf2011-03-15 05:22:28 +00001486 Diags.getDiagnosticLevel(diag::warn_maybe_uninit_var, D->getLocStart())
David Blaikied6471f72011-09-25 23:23:43 +00001487 != DiagnosticsEngine::Ignored) {
Ted Kremenekc5e43c12011-03-17 05:29:57 +00001488 if (CFG *cfg = AC.getCFG()) {
Ted Kremenekc21fed32011-01-18 21:18:58 +00001489 UninitValsDiagReporter reporter(S);
Fariborz Jahanian57080fb2011-07-16 18:31:33 +00001490 UninitVariablesAnalysisStats stats;
Benjamin Kramer12efd572011-07-16 20:13:06 +00001491 std::memset(&stats, 0, sizeof(UninitVariablesAnalysisStats));
Ted Kremeneka8c17a52011-01-25 19:13:48 +00001492 runUninitializedVariablesAnalysis(*cast<DeclContext>(D), *cfg, AC,
Chandler Carruth5d989942011-07-06 16:21:37 +00001493 reporter, stats);
1494
1495 if (S.CollectStats && stats.NumVariablesAnalyzed > 0) {
1496 ++NumUninitAnalysisFunctions;
1497 NumUninitAnalysisVariables += stats.NumVariablesAnalyzed;
1498 NumUninitAnalysisBlockVisits += stats.NumBlockVisits;
1499 MaxUninitAnalysisVariablesPerFunction =
1500 std::max(MaxUninitAnalysisVariablesPerFunction,
1501 stats.NumVariablesAnalyzed);
1502 MaxUninitAnalysisBlockVisitsPerFunction =
1503 std::max(MaxUninitAnalysisBlockVisitsPerFunction,
1504 stats.NumBlockVisits);
1505 }
Ted Kremenek610068c2011-01-15 02:58:47 +00001506 }
1507 }
Chandler Carruth5d989942011-07-06 16:21:37 +00001508
Alexander Kornienko19736342012-06-02 01:01:07 +00001509 bool FallThroughDiagFull =
1510 Diags.getDiagnosticLevel(diag::warn_unannotated_fallthrough,
1511 D->getLocStart()) != DiagnosticsEngine::Ignored;
Sean Huntc2f51cf2012-06-15 21:22:05 +00001512 bool FallThroughDiagPerFunction =
1513 Diags.getDiagnosticLevel(diag::warn_unannotated_fallthrough_per_function,
Alexander Kornienko19736342012-06-02 01:01:07 +00001514 D->getLocStart()) != DiagnosticsEngine::Ignored;
Sean Huntc2f51cf2012-06-15 21:22:05 +00001515 if (FallThroughDiagFull || FallThroughDiagPerFunction) {
Alexander Kornienko19736342012-06-02 01:01:07 +00001516 DiagnoseSwitchLabelsFallthrough(S, AC, !FallThroughDiagFull);
Richard Smithe0d3b4c2012-05-03 18:27:39 +00001517 }
1518
Jordan Rose58b6bdc2012-09-28 22:21:30 +00001519 if (S.getLangOpts().ObjCARCWeak &&
1520 Diags.getDiagnosticLevel(diag::warn_arc_repeated_use_of_weak,
1521 D->getLocStart()) != DiagnosticsEngine::Ignored)
1522 diagnoseRepeatedUseOfWeak(S, fscope, D);
1523
Chandler Carruth5d989942011-07-06 16:21:37 +00001524 // Collect statistics about the CFG if it was built.
1525 if (S.CollectStats && AC.isCFGBuilt()) {
1526 ++NumFunctionsAnalyzed;
1527 if (CFG *cfg = AC.getCFG()) {
1528 // If we successfully built a CFG for this context, record some more
1529 // detail information about it.
Chandler Carruth3ea4c492011-07-06 22:21:45 +00001530 NumCFGBlocks += cfg->getNumBlockIDs();
Chandler Carruth5d989942011-07-06 16:21:37 +00001531 MaxCFGBlocksPerFunction = std::max(MaxCFGBlocksPerFunction,
Chandler Carruth3ea4c492011-07-06 22:21:45 +00001532 cfg->getNumBlockIDs());
Chandler Carruth5d989942011-07-06 16:21:37 +00001533 } else {
1534 ++NumFunctionsWithBadCFGs;
1535 }
1536 }
1537}
1538
1539void clang::sema::AnalysisBasedWarnings::PrintStats() const {
1540 llvm::errs() << "\n*** Analysis Based Warnings Stats:\n";
1541
1542 unsigned NumCFGsBuilt = NumFunctionsAnalyzed - NumFunctionsWithBadCFGs;
1543 unsigned AvgCFGBlocksPerFunction =
1544 !NumCFGsBuilt ? 0 : NumCFGBlocks/NumCFGsBuilt;
1545 llvm::errs() << NumFunctionsAnalyzed << " functions analyzed ("
1546 << NumFunctionsWithBadCFGs << " w/o CFGs).\n"
1547 << " " << NumCFGBlocks << " CFG blocks built.\n"
1548 << " " << AvgCFGBlocksPerFunction
1549 << " average CFG blocks per function.\n"
1550 << " " << MaxCFGBlocksPerFunction
1551 << " max CFG blocks per function.\n";
1552
1553 unsigned AvgUninitVariablesPerFunction = !NumUninitAnalysisFunctions ? 0
1554 : NumUninitAnalysisVariables/NumUninitAnalysisFunctions;
1555 unsigned AvgUninitBlockVisitsPerFunction = !NumUninitAnalysisFunctions ? 0
1556 : NumUninitAnalysisBlockVisits/NumUninitAnalysisFunctions;
1557 llvm::errs() << NumUninitAnalysisFunctions
1558 << " functions analyzed for uninitialiazed variables\n"
1559 << " " << NumUninitAnalysisVariables << " variables analyzed.\n"
1560 << " " << AvgUninitVariablesPerFunction
1561 << " average variables per function.\n"
1562 << " " << MaxUninitAnalysisVariablesPerFunction
1563 << " max variables per function.\n"
1564 << " " << NumUninitAnalysisBlockVisits << " block visits.\n"
1565 << " " << AvgUninitBlockVisitsPerFunction
1566 << " average block visits per function.\n"
1567 << " " << MaxUninitAnalysisBlockVisitsPerFunction
1568 << " max block visits per function.\n";
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +00001569}