blob: 084ca0b77b35c0339a055b8c8de21b8686546092 [file] [log] [blame]
Chris Lattner4d391482007-12-12 07:09:47 +00001//===--- SemaDeclObjC.cpp - Semantic Analysis for ObjC Declarations -------===//
2//
3// The LLVM Compiler Infrastructure
4//
Chris Lattner0bc735f2007-12-29 19:59:25 +00005// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
Chris Lattner4d391482007-12-12 07:09:47 +00007//
8//===----------------------------------------------------------------------===//
9//
10// This file implements semantic analysis for Objective C declarations.
11//
12//===----------------------------------------------------------------------===//
13
John McCall2d887082010-08-25 22:03:47 +000014#include "clang/Sema/SemaInternal.h"
Douglas Gregore737f502010-08-12 20:07:10 +000015#include "clang/Sema/Lookup.h"
Douglas Gregorf0aaf7a2009-04-24 21:10:55 +000016#include "clang/Sema/ExternalSemaSource.h"
John McCall5f1e0942010-08-24 08:50:51 +000017#include "clang/Sema/Scope.h"
John McCall781472f2010-08-25 08:40:02 +000018#include "clang/Sema/ScopeInfo.h"
John McCallf85e1932011-06-15 23:02:42 +000019#include "clang/AST/ASTConsumer.h"
Steve Naroffca331292009-03-03 14:49:36 +000020#include "clang/AST/Expr.h"
John McCallf85e1932011-06-15 23:02:42 +000021#include "clang/AST/ExprObjC.h"
Chris Lattner4d391482007-12-12 07:09:47 +000022#include "clang/AST/ASTContext.h"
23#include "clang/AST/DeclObjC.h"
John McCallf85e1932011-06-15 23:02:42 +000024#include "clang/Basic/SourceManager.h"
John McCall19510852010-08-20 18:27:03 +000025#include "clang/Sema/DeclSpec.h"
John McCall50df6ae2010-08-25 07:03:20 +000026#include "llvm/ADT/DenseSet.h"
27
Chris Lattner4d391482007-12-12 07:09:47 +000028using namespace clang;
29
John McCallf85e1932011-06-15 23:02:42 +000030/// Check whether the given method, which must be in the 'init'
31/// family, is a valid member of that family.
32///
33/// \param receiverTypeIfCall - if null, check this as if declaring it;
34/// if non-null, check this as if making a call to it with the given
35/// receiver type
36///
37/// \return true to indicate that there was an error and appropriate
38/// actions were taken
39bool Sema::checkInitMethod(ObjCMethodDecl *method,
40 QualType receiverTypeIfCall) {
41 if (method->isInvalidDecl()) return true;
42
43 // This castAs is safe: methods that don't return an object
44 // pointer won't be inferred as inits and will reject an explicit
45 // objc_method_family(init).
46
47 // We ignore protocols here. Should we? What about Class?
48
49 const ObjCObjectType *result = method->getResultType()
50 ->castAs<ObjCObjectPointerType>()->getObjectType();
51
52 if (result->isObjCId()) {
53 return false;
54 } else if (result->isObjCClass()) {
55 // fall through: always an error
56 } else {
57 ObjCInterfaceDecl *resultClass = result->getInterface();
58 assert(resultClass && "unexpected object type!");
59
60 // It's okay for the result type to still be a forward declaration
61 // if we're checking an interface declaration.
62 if (resultClass->isForwardDecl()) {
63 if (receiverTypeIfCall.isNull() &&
64 !isa<ObjCImplementationDecl>(method->getDeclContext()))
65 return false;
66
67 // Otherwise, we try to compare class types.
68 } else {
69 // If this method was declared in a protocol, we can't check
70 // anything unless we have a receiver type that's an interface.
71 const ObjCInterfaceDecl *receiverClass = 0;
72 if (isa<ObjCProtocolDecl>(method->getDeclContext())) {
73 if (receiverTypeIfCall.isNull())
74 return false;
75
76 receiverClass = receiverTypeIfCall->castAs<ObjCObjectPointerType>()
77 ->getInterfaceDecl();
78
79 // This can be null for calls to e.g. id<Foo>.
80 if (!receiverClass) return false;
81 } else {
82 receiverClass = method->getClassInterface();
83 assert(receiverClass && "method not associated with a class!");
84 }
85
86 // If either class is a subclass of the other, it's fine.
87 if (receiverClass->isSuperClassOf(resultClass) ||
88 resultClass->isSuperClassOf(receiverClass))
89 return false;
90 }
91 }
92
93 SourceLocation loc = method->getLocation();
94
95 // If we're in a system header, and this is not a call, just make
96 // the method unusable.
97 if (receiverTypeIfCall.isNull() && getSourceManager().isInSystemHeader(loc)) {
98 method->addAttr(new (Context) UnavailableAttr(loc, Context,
99 "init method returns a type unrelated to its receiver type"));
100 return true;
101 }
102
103 // Otherwise, it's an error.
104 Diag(loc, diag::err_arc_init_method_unrelated_result_type);
105 method->setInvalidDecl();
106 return true;
107}
108
Douglas Gregor926df6c2011-06-11 01:09:30 +0000109bool Sema::CheckObjCMethodOverride(ObjCMethodDecl *NewMethod,
110 const ObjCMethodDecl *Overridden,
111 bool IsImplementation) {
112 if (Overridden->hasRelatedResultType() &&
113 !NewMethod->hasRelatedResultType()) {
114 // This can only happen when the method follows a naming convention that
115 // implies a related result type, and the original (overridden) method has
116 // a suitable return type, but the new (overriding) method does not have
117 // a suitable return type.
118 QualType ResultType = NewMethod->getResultType();
119 SourceRange ResultTypeRange;
120 if (const TypeSourceInfo *ResultTypeInfo
John McCallf85e1932011-06-15 23:02:42 +0000121 = NewMethod->getResultTypeSourceInfo())
Douglas Gregor926df6c2011-06-11 01:09:30 +0000122 ResultTypeRange = ResultTypeInfo->getTypeLoc().getSourceRange();
123
124 // Figure out which class this method is part of, if any.
125 ObjCInterfaceDecl *CurrentClass
126 = dyn_cast<ObjCInterfaceDecl>(NewMethod->getDeclContext());
127 if (!CurrentClass) {
128 DeclContext *DC = NewMethod->getDeclContext();
129 if (ObjCCategoryDecl *Cat = dyn_cast<ObjCCategoryDecl>(DC))
130 CurrentClass = Cat->getClassInterface();
131 else if (ObjCImplDecl *Impl = dyn_cast<ObjCImplDecl>(DC))
132 CurrentClass = Impl->getClassInterface();
133 else if (ObjCCategoryImplDecl *CatImpl
134 = dyn_cast<ObjCCategoryImplDecl>(DC))
135 CurrentClass = CatImpl->getClassInterface();
136 }
137
138 if (CurrentClass) {
139 Diag(NewMethod->getLocation(),
140 diag::warn_related_result_type_compatibility_class)
141 << Context.getObjCInterfaceType(CurrentClass)
142 << ResultType
143 << ResultTypeRange;
144 } else {
145 Diag(NewMethod->getLocation(),
146 diag::warn_related_result_type_compatibility_protocol)
147 << ResultType
148 << ResultTypeRange;
149 }
150
151 Diag(Overridden->getLocation(), diag::note_related_result_type_overridden)
152 << Overridden->getMethodFamily();
153 }
154
155 return false;
156}
157
John McCallf85e1932011-06-15 23:02:42 +0000158/// \brief Check a method declaration for compatibility with the Objective-C
159/// ARC conventions.
160static bool CheckARCMethodDecl(Sema &S, ObjCMethodDecl *method) {
161 ObjCMethodFamily family = method->getMethodFamily();
162 switch (family) {
163 case OMF_None:
164 case OMF_dealloc:
165 case OMF_retain:
166 case OMF_release:
167 case OMF_autorelease:
168 case OMF_retainCount:
169 case OMF_self:
John McCall6c2c2502011-07-22 02:45:48 +0000170 case OMF_performSelector:
John McCallf85e1932011-06-15 23:02:42 +0000171 return false;
172
173 case OMF_init:
174 // If the method doesn't obey the init rules, don't bother annotating it.
175 if (S.checkInitMethod(method, QualType()))
176 return true;
177
178 method->addAttr(new (S.Context) NSConsumesSelfAttr(SourceLocation(),
179 S.Context));
180
181 // Don't add a second copy of this attribute, but otherwise don't
182 // let it be suppressed.
183 if (method->hasAttr<NSReturnsRetainedAttr>())
184 return false;
185 break;
186
187 case OMF_alloc:
188 case OMF_copy:
189 case OMF_mutableCopy:
190 case OMF_new:
191 if (method->hasAttr<NSReturnsRetainedAttr>() ||
192 method->hasAttr<NSReturnsNotRetainedAttr>() ||
193 method->hasAttr<NSReturnsAutoreleasedAttr>())
194 return false;
195 break;
196 }
197
198 method->addAttr(new (S.Context) NSReturnsRetainedAttr(SourceLocation(),
199 S.Context));
200 return false;
201}
202
Fariborz Jahanian5ac96d52011-02-15 17:49:58 +0000203static void DiagnoseObjCImplementedDeprecations(Sema &S,
204 NamedDecl *ND,
205 SourceLocation ImplLoc,
206 int select) {
Douglas Gregor0a0d2b12011-03-23 00:50:03 +0000207 if (ND && ND->isDeprecated()) {
Fariborz Jahanian98d810e2011-02-16 00:30:31 +0000208 S.Diag(ImplLoc, diag::warn_deprecated_def) << select;
Fariborz Jahanian5ac96d52011-02-15 17:49:58 +0000209 if (select == 0)
210 S.Diag(ND->getLocation(), diag::note_method_declared_at);
211 else
212 S.Diag(ND->getLocation(), diag::note_previous_decl) << "class";
213 }
214}
215
Steve Naroffebf64432009-02-28 16:59:13 +0000216/// ActOnStartOfObjCMethodDef - This routine sets up parameters; invisible
Chris Lattner4d391482007-12-12 07:09:47 +0000217/// and user declared, in the method definition's AST.
John McCalld226f652010-08-21 09:40:31 +0000218void Sema::ActOnStartOfObjCMethodDef(Scope *FnBodyScope, Decl *D) {
Argyrios Kyrtzidis53d0ea52008-06-28 06:07:14 +0000219 assert(getCurMethodDecl() == 0 && "Method parsing confused");
John McCalld226f652010-08-21 09:40:31 +0000220 ObjCMethodDecl *MDecl = dyn_cast_or_null<ObjCMethodDecl>(D);
Mike Stump1eb44332009-09-09 15:08:12 +0000221
Steve Naroff394f3f42008-07-25 17:57:26 +0000222 // If we don't have a valid method decl, simply return.
223 if (!MDecl)
224 return;
Steve Naroffa56f6162007-12-18 01:30:32 +0000225
226 // Allow the rest of sema to find private method decl implementations.
Douglas Gregorf8d49f62009-01-09 17:18:27 +0000227 if (MDecl->isInstanceMethod())
Fariborz Jahanian3fe10412010-07-22 18:24:20 +0000228 AddInstanceMethodToGlobalPool(MDecl, true);
Steve Naroffa56f6162007-12-18 01:30:32 +0000229 else
Fariborz Jahanian3fe10412010-07-22 18:24:20 +0000230 AddFactoryMethodToGlobalPool(MDecl, true);
231
Chris Lattner4d391482007-12-12 07:09:47 +0000232 // Allow all of Sema to see that we are entering a method definition.
Douglas Gregor44b43212008-12-11 16:49:14 +0000233 PushDeclContext(FnBodyScope, MDecl);
Douglas Gregor9ea9bdb2010-03-01 23:15:13 +0000234 PushFunctionScope();
235
Chris Lattner4d391482007-12-12 07:09:47 +0000236 // Create Decl objects for each parameter, entrring them in the scope for
237 // binding to their use.
Chris Lattner4d391482007-12-12 07:09:47 +0000238
239 // Insert the invisible arguments, self and _cmd!
Fariborz Jahanianfef30b52008-12-09 20:23:04 +0000240 MDecl->createImplicitParams(Context, MDecl->getClassInterface());
Mike Stump1eb44332009-09-09 15:08:12 +0000241
Daniel Dunbar451318c2008-08-26 06:07:48 +0000242 PushOnScopeChains(MDecl->getSelfDecl(), FnBodyScope);
243 PushOnScopeChains(MDecl->getCmdDecl(), FnBodyScope);
Chris Lattner04421082008-04-08 04:40:51 +0000244
Chris Lattner8123a952008-04-10 02:22:51 +0000245 // Introduce all of the other parameters into this scope.
Chris Lattner89951a82009-02-20 18:43:26 +0000246 for (ObjCMethodDecl::param_iterator PI = MDecl->param_begin(),
Fariborz Jahanian23c01042010-09-17 22:07:07 +0000247 E = MDecl->param_end(); PI != E; ++PI) {
248 ParmVarDecl *Param = (*PI);
249 if (!Param->isInvalidDecl() &&
250 RequireCompleteType(Param->getLocation(), Param->getType(),
251 diag::err_typecheck_decl_incomplete_type))
252 Param->setInvalidDecl();
Chris Lattner89951a82009-02-20 18:43:26 +0000253 if ((*PI)->getIdentifier())
254 PushOnScopeChains(*PI, FnBodyScope);
Fariborz Jahanian23c01042010-09-17 22:07:07 +0000255 }
John McCallf85e1932011-06-15 23:02:42 +0000256
257 // In ARC, disallow definition of retain/release/autorelease/retainCount
258 if (getLangOptions().ObjCAutoRefCount) {
259 switch (MDecl->getMethodFamily()) {
260 case OMF_retain:
261 case OMF_retainCount:
262 case OMF_release:
263 case OMF_autorelease:
264 Diag(MDecl->getLocation(), diag::err_arc_illegal_method_def)
265 << MDecl->getSelector();
266 break;
267
268 case OMF_None:
269 case OMF_dealloc:
270 case OMF_alloc:
271 case OMF_init:
272 case OMF_mutableCopy:
273 case OMF_copy:
274 case OMF_new:
275 case OMF_self:
Fariborz Jahanian9670e172011-07-05 22:38:59 +0000276 case OMF_performSelector:
John McCallf85e1932011-06-15 23:02:42 +0000277 break;
278 }
279 }
280
Fariborz Jahanianb1224f62011-02-15 00:59:30 +0000281 // Warn on implementating deprecated methods under
282 // -Wdeprecated-implementations flag.
Fariborz Jahanian5ac96d52011-02-15 17:49:58 +0000283 if (ObjCInterfaceDecl *IC = MDecl->getClassInterface())
284 if (ObjCMethodDecl *IMD =
Fariborz Jahanianb1224f62011-02-15 00:59:30 +0000285 IC->lookupMethod(MDecl->getSelector(), MDecl->isInstanceMethod()))
Fariborz Jahanian5ac96d52011-02-15 17:49:58 +0000286 DiagnoseObjCImplementedDeprecations(*this,
287 dyn_cast<NamedDecl>(IMD),
288 MDecl->getLocation(), 0);
Chris Lattner4d391482007-12-12 07:09:47 +0000289}
290
John McCalld226f652010-08-21 09:40:31 +0000291Decl *Sema::
Chris Lattner7caeabd2008-07-21 22:17:28 +0000292ActOnStartClassInterface(SourceLocation AtInterfaceLoc,
293 IdentifierInfo *ClassName, SourceLocation ClassLoc,
294 IdentifierInfo *SuperName, SourceLocation SuperLoc,
John McCalld226f652010-08-21 09:40:31 +0000295 Decl * const *ProtoRefs, unsigned NumProtoRefs,
Douglas Gregor18df52b2010-01-16 15:02:53 +0000296 const SourceLocation *ProtoLocs,
Chris Lattner7caeabd2008-07-21 22:17:28 +0000297 SourceLocation EndProtoLoc, AttributeList *AttrList) {
Chris Lattner4d391482007-12-12 07:09:47 +0000298 assert(ClassName && "Missing class identifier");
Mike Stump1eb44332009-09-09 15:08:12 +0000299
Chris Lattner4d391482007-12-12 07:09:47 +0000300 // Check for another declaration kind with the same name.
Douglas Gregorc83c6872010-04-15 22:33:43 +0000301 NamedDecl *PrevDecl = LookupSingleName(TUScope, ClassName, ClassLoc,
Douglas Gregorc0b39642010-04-15 23:40:53 +0000302 LookupOrdinaryName, ForRedeclaration);
Douglas Gregor72c3f312008-12-05 18:15:24 +0000303
Ted Kremeneka526c5c2008-01-07 19:49:32 +0000304 if (PrevDecl && !isa<ObjCInterfaceDecl>(PrevDecl)) {
Chris Lattner3c73c412008-11-19 08:23:25 +0000305 Diag(ClassLoc, diag::err_redefinition_different_kind) << ClassName;
Chris Lattner5f4a6822008-11-23 23:12:31 +0000306 Diag(PrevDecl->getLocation(), diag::note_previous_definition);
Chris Lattner4d391482007-12-12 07:09:47 +0000307 }
Mike Stump1eb44332009-09-09 15:08:12 +0000308
Douglas Gregordeacbdc2010-08-11 12:19:30 +0000309 ObjCInterfaceDecl* IDecl = dyn_cast_or_null<ObjCInterfaceDecl>(PrevDecl);
310 if (IDecl) {
Chris Lattner4d391482007-12-12 07:09:47 +0000311 // Class already seen. Is it a forward declaration?
Douglas Gregordeacbdc2010-08-11 12:19:30 +0000312 if (!IDecl->isForwardDecl()) {
313 IDecl->setInvalidDecl();
314 Diag(AtInterfaceLoc, diag::err_duplicate_class_def)<<IDecl->getDeclName();
315 Diag(IDecl->getLocation(), diag::note_previous_definition);
Chris Lattnerb8b96af2008-11-23 22:46:27 +0000316
Douglas Gregordeacbdc2010-08-11 12:19:30 +0000317 // Return the previous class interface.
318 // FIXME: don't leak the objects passed in!
John McCalld226f652010-08-21 09:40:31 +0000319 return IDecl;
Douglas Gregordeacbdc2010-08-11 12:19:30 +0000320 } else {
321 IDecl->setLocation(AtInterfaceLoc);
322 IDecl->setForwardDecl(false);
323 IDecl->setClassLoc(ClassLoc);
Sebastian Redl0b17c612010-08-13 00:28:03 +0000324 // If the forward decl was in a PCH, we need to write it again in a
Sebastian Redl3c7f4132010-08-18 23:57:06 +0000325 // dependent AST file.
Sebastian Redl0b17c612010-08-13 00:28:03 +0000326 IDecl->setChangedSinceDeserialization(true);
Douglas Gregordeacbdc2010-08-11 12:19:30 +0000327
328 // Since this ObjCInterfaceDecl was created by a forward declaration,
329 // we now add it to the DeclContext since it wasn't added before
330 // (see ActOnForwardClassDeclaration).
331 IDecl->setLexicalDeclContext(CurContext);
332 CurContext->addDecl(IDecl);
333
334 if (AttrList)
335 ProcessDeclAttributeList(TUScope, IDecl, AttrList);
Chris Lattner4d391482007-12-12 07:09:47 +0000336 }
Douglas Gregordeacbdc2010-08-11 12:19:30 +0000337 } else {
338 IDecl = ObjCInterfaceDecl::Create(Context, CurContext, AtInterfaceLoc,
339 ClassName, ClassLoc);
340 if (AttrList)
341 ProcessDeclAttributeList(TUScope, IDecl, AttrList);
342
343 PushOnScopeChains(IDecl, TUScope);
Chris Lattner4d391482007-12-12 07:09:47 +0000344 }
Mike Stump1eb44332009-09-09 15:08:12 +0000345
Chris Lattner4d391482007-12-12 07:09:47 +0000346 if (SuperName) {
Chris Lattner4d391482007-12-12 07:09:47 +0000347 // Check if a different kind of symbol declared in this scope.
Douglas Gregorc83c6872010-04-15 22:33:43 +0000348 PrevDecl = LookupSingleName(TUScope, SuperName, SuperLoc,
349 LookupOrdinaryName);
Douglas Gregorf06cdae2010-01-03 18:01:57 +0000350
351 if (!PrevDecl) {
352 // Try to correct for a typo in the superclass name.
Douglas Gregord8bba9c2011-06-28 16:20:02 +0000353 TypoCorrection Corrected = CorrectTypo(
354 DeclarationNameInfo(SuperName, SuperLoc), LookupOrdinaryName, TUScope,
355 NULL, NULL, false, CTC_NoKeywords);
356 if ((PrevDecl = Corrected.getCorrectionDeclAs<ObjCInterfaceDecl>())) {
Douglas Gregorf06cdae2010-01-03 18:01:57 +0000357 Diag(SuperLoc, diag::err_undef_superclass_suggest)
358 << SuperName << ClassName << PrevDecl->getDeclName();
Douglas Gregor67dd1d42010-01-07 00:17:44 +0000359 Diag(PrevDecl->getLocation(), diag::note_previous_decl)
360 << PrevDecl->getDeclName();
Douglas Gregorf06cdae2010-01-03 18:01:57 +0000361 }
362 }
363
Fariborz Jahanianfdee0892009-07-09 22:08:26 +0000364 if (PrevDecl == IDecl) {
365 Diag(SuperLoc, diag::err_recursive_superclass)
366 << SuperName << ClassName << SourceRange(AtInterfaceLoc, ClassLoc);
367 IDecl->setLocEnd(ClassLoc);
Mike Stumpac5fc7c2009-08-04 21:02:39 +0000368 } else {
Mike Stump1eb44332009-09-09 15:08:12 +0000369 ObjCInterfaceDecl *SuperClassDecl =
Fariborz Jahanianfdee0892009-07-09 22:08:26 +0000370 dyn_cast_or_null<ObjCInterfaceDecl>(PrevDecl);
Chris Lattner3c73c412008-11-19 08:23:25 +0000371
Fariborz Jahanianfdee0892009-07-09 22:08:26 +0000372 // Diagnose classes that inherit from deprecated classes.
373 if (SuperClassDecl)
374 (void)DiagnoseUseOfDecl(SuperClassDecl, SuperLoc);
Mike Stump1eb44332009-09-09 15:08:12 +0000375
Fariborz Jahanianfdee0892009-07-09 22:08:26 +0000376 if (PrevDecl && SuperClassDecl == 0) {
377 // The previous declaration was not a class decl. Check if we have a
378 // typedef. If we do, get the underlying class type.
Richard Smith162e1c12011-04-15 14:24:37 +0000379 if (const TypedefNameDecl *TDecl =
380 dyn_cast_or_null<TypedefNameDecl>(PrevDecl)) {
Fariborz Jahanianfdee0892009-07-09 22:08:26 +0000381 QualType T = TDecl->getUnderlyingType();
John McCallc12c5bb2010-05-15 11:32:37 +0000382 if (T->isObjCObjectType()) {
Douglas Gregordeacbdc2010-08-11 12:19:30 +0000383 if (NamedDecl *IDecl = T->getAs<ObjCObjectType>()->getInterface())
384 SuperClassDecl = dyn_cast<ObjCInterfaceDecl>(IDecl);
Fariborz Jahanianfdee0892009-07-09 22:08:26 +0000385 }
386 }
Mike Stump1eb44332009-09-09 15:08:12 +0000387
Fariborz Jahanianfdee0892009-07-09 22:08:26 +0000388 // This handles the following case:
389 //
390 // typedef int SuperClass;
391 // @interface MyClass : SuperClass {} @end
392 //
393 if (!SuperClassDecl) {
394 Diag(SuperLoc, diag::err_redefinition_different_kind) << SuperName;
395 Diag(PrevDecl->getLocation(), diag::note_previous_definition);
Steve Naroff818cb9e2009-02-04 17:14:05 +0000396 }
397 }
Mike Stump1eb44332009-09-09 15:08:12 +0000398
Richard Smith162e1c12011-04-15 14:24:37 +0000399 if (!dyn_cast_or_null<TypedefNameDecl>(PrevDecl)) {
Fariborz Jahanianfdee0892009-07-09 22:08:26 +0000400 if (!SuperClassDecl)
401 Diag(SuperLoc, diag::err_undef_superclass)
402 << SuperName << ClassName << SourceRange(AtInterfaceLoc, ClassLoc);
Fariborz Jahaniana8139732011-06-23 23:16:19 +0000403 else if (SuperClassDecl->isForwardDecl()) {
404 Diag(SuperLoc, diag::err_forward_superclass)
Fariborz Jahanianfdee0892009-07-09 22:08:26 +0000405 << SuperClassDecl->getDeclName() << ClassName
406 << SourceRange(AtInterfaceLoc, ClassLoc);
Fariborz Jahaniana8139732011-06-23 23:16:19 +0000407 Diag(SuperClassDecl->getLocation(), diag::note_forward_class);
408 SuperClassDecl = 0;
409 }
Steve Naroff818cb9e2009-02-04 17:14:05 +0000410 }
Fariborz Jahanianfdee0892009-07-09 22:08:26 +0000411 IDecl->setSuperClass(SuperClassDecl);
412 IDecl->setSuperClassLoc(SuperLoc);
413 IDecl->setLocEnd(SuperLoc);
Steve Naroff818cb9e2009-02-04 17:14:05 +0000414 }
Chris Lattner4d391482007-12-12 07:09:47 +0000415 } else { // we have a root class.
416 IDecl->setLocEnd(ClassLoc);
417 }
Mike Stump1eb44332009-09-09 15:08:12 +0000418
Sebastian Redl0b17c612010-08-13 00:28:03 +0000419 // Check then save referenced protocols.
Chris Lattner06036d32008-07-26 04:13:19 +0000420 if (NumProtoRefs) {
Chris Lattner38af2de2009-02-20 21:35:13 +0000421 IDecl->setProtocolList((ObjCProtocolDecl**)ProtoRefs, NumProtoRefs,
Douglas Gregor18df52b2010-01-16 15:02:53 +0000422 ProtoLocs, Context);
Chris Lattner4d391482007-12-12 07:09:47 +0000423 IDecl->setLocEnd(EndProtoLoc);
424 }
Mike Stump1eb44332009-09-09 15:08:12 +0000425
Anders Carlsson15281452008-11-04 16:57:32 +0000426 CheckObjCDeclScope(IDecl);
John McCalld226f652010-08-21 09:40:31 +0000427 return IDecl;
Chris Lattner4d391482007-12-12 07:09:47 +0000428}
429
430/// ActOnCompatiblityAlias - this action is called after complete parsing of
Daniel Dunbar7ad1b1f2008-09-04 20:01:15 +0000431/// @compatibility_alias declaration. It sets up the alias relationships.
John McCalld226f652010-08-21 09:40:31 +0000432Decl *Sema::ActOnCompatiblityAlias(SourceLocation AtLoc,
433 IdentifierInfo *AliasName,
434 SourceLocation AliasLocation,
435 IdentifierInfo *ClassName,
436 SourceLocation ClassLocation) {
Chris Lattner4d391482007-12-12 07:09:47 +0000437 // Look for previous declaration of alias name
Douglas Gregorc83c6872010-04-15 22:33:43 +0000438 NamedDecl *ADecl = LookupSingleName(TUScope, AliasName, AliasLocation,
Douglas Gregorc0b39642010-04-15 23:40:53 +0000439 LookupOrdinaryName, ForRedeclaration);
Chris Lattner4d391482007-12-12 07:09:47 +0000440 if (ADecl) {
Chris Lattner8b265bd2008-11-23 23:20:13 +0000441 if (isa<ObjCCompatibleAliasDecl>(ADecl))
Chris Lattner4d391482007-12-12 07:09:47 +0000442 Diag(AliasLocation, diag::warn_previous_alias_decl);
Chris Lattner8b265bd2008-11-23 23:20:13 +0000443 else
Chris Lattner3c73c412008-11-19 08:23:25 +0000444 Diag(AliasLocation, diag::err_conflicting_aliasing_type) << AliasName;
Chris Lattner8b265bd2008-11-23 23:20:13 +0000445 Diag(ADecl->getLocation(), diag::note_previous_declaration);
John McCalld226f652010-08-21 09:40:31 +0000446 return 0;
Chris Lattner4d391482007-12-12 07:09:47 +0000447 }
448 // Check for class declaration
Douglas Gregorc83c6872010-04-15 22:33:43 +0000449 NamedDecl *CDeclU = LookupSingleName(TUScope, ClassName, ClassLocation,
Douglas Gregorc0b39642010-04-15 23:40:53 +0000450 LookupOrdinaryName, ForRedeclaration);
Richard Smith162e1c12011-04-15 14:24:37 +0000451 if (const TypedefNameDecl *TDecl =
452 dyn_cast_or_null<TypedefNameDecl>(CDeclU)) {
Fariborz Jahanian305c6582009-01-08 01:10:55 +0000453 QualType T = TDecl->getUnderlyingType();
John McCallc12c5bb2010-05-15 11:32:37 +0000454 if (T->isObjCObjectType()) {
455 if (NamedDecl *IDecl = T->getAs<ObjCObjectType>()->getInterface()) {
Fariborz Jahanian305c6582009-01-08 01:10:55 +0000456 ClassName = IDecl->getIdentifier();
Douglas Gregorc83c6872010-04-15 22:33:43 +0000457 CDeclU = LookupSingleName(TUScope, ClassName, ClassLocation,
Douglas Gregorc0b39642010-04-15 23:40:53 +0000458 LookupOrdinaryName, ForRedeclaration);
Fariborz Jahanian305c6582009-01-08 01:10:55 +0000459 }
460 }
461 }
Chris Lattnerf8d17a52008-03-16 21:17:37 +0000462 ObjCInterfaceDecl *CDecl = dyn_cast_or_null<ObjCInterfaceDecl>(CDeclU);
463 if (CDecl == 0) {
Chris Lattner3c73c412008-11-19 08:23:25 +0000464 Diag(ClassLocation, diag::warn_undef_interface) << ClassName;
Chris Lattnerf8d17a52008-03-16 21:17:37 +0000465 if (CDeclU)
Chris Lattner8b265bd2008-11-23 23:20:13 +0000466 Diag(CDeclU->getLocation(), diag::note_previous_declaration);
John McCalld226f652010-08-21 09:40:31 +0000467 return 0;
Chris Lattner4d391482007-12-12 07:09:47 +0000468 }
Mike Stump1eb44332009-09-09 15:08:12 +0000469
Chris Lattnerf8d17a52008-03-16 21:17:37 +0000470 // Everything checked out, instantiate a new alias declaration AST.
Mike Stump1eb44332009-09-09 15:08:12 +0000471 ObjCCompatibleAliasDecl *AliasDecl =
Douglas Gregord0434102009-01-09 00:49:46 +0000472 ObjCCompatibleAliasDecl::Create(Context, CurContext, AtLoc, AliasName, CDecl);
Mike Stump1eb44332009-09-09 15:08:12 +0000473
Anders Carlsson15281452008-11-04 16:57:32 +0000474 if (!CheckObjCDeclScope(AliasDecl))
Douglas Gregor516ff432009-04-24 02:57:34 +0000475 PushOnScopeChains(AliasDecl, TUScope);
Douglas Gregord0434102009-01-09 00:49:46 +0000476
John McCalld226f652010-08-21 09:40:31 +0000477 return AliasDecl;
Chris Lattner4d391482007-12-12 07:09:47 +0000478}
479
Fariborz Jahanian819e9bf2011-05-13 18:02:08 +0000480bool Sema::CheckForwardProtocolDeclarationForCircularDependency(
Steve Naroff61d68522009-03-05 15:22:01 +0000481 IdentifierInfo *PName,
482 SourceLocation &Ploc, SourceLocation PrevLoc,
Fariborz Jahanian819e9bf2011-05-13 18:02:08 +0000483 const ObjCList<ObjCProtocolDecl> &PList) {
484
485 bool res = false;
Steve Naroff61d68522009-03-05 15:22:01 +0000486 for (ObjCList<ObjCProtocolDecl>::iterator I = PList.begin(),
487 E = PList.end(); I != E; ++I) {
Douglas Gregorc83c6872010-04-15 22:33:43 +0000488 if (ObjCProtocolDecl *PDecl = LookupProtocol((*I)->getIdentifier(),
489 Ploc)) {
Steve Naroff61d68522009-03-05 15:22:01 +0000490 if (PDecl->getIdentifier() == PName) {
491 Diag(Ploc, diag::err_protocol_has_circular_dependency);
492 Diag(PrevLoc, diag::note_previous_definition);
Fariborz Jahanian819e9bf2011-05-13 18:02:08 +0000493 res = true;
Steve Naroff61d68522009-03-05 15:22:01 +0000494 }
Fariborz Jahanian819e9bf2011-05-13 18:02:08 +0000495 if (CheckForwardProtocolDeclarationForCircularDependency(PName, Ploc,
496 PDecl->getLocation(), PDecl->getReferencedProtocols()))
497 res = true;
Steve Naroff61d68522009-03-05 15:22:01 +0000498 }
499 }
Fariborz Jahanian819e9bf2011-05-13 18:02:08 +0000500 return res;
Steve Naroff61d68522009-03-05 15:22:01 +0000501}
502
John McCalld226f652010-08-21 09:40:31 +0000503Decl *
Chris Lattnere13b9592008-07-26 04:03:38 +0000504Sema::ActOnStartProtocolInterface(SourceLocation AtProtoInterfaceLoc,
505 IdentifierInfo *ProtocolName,
506 SourceLocation ProtocolLoc,
John McCalld226f652010-08-21 09:40:31 +0000507 Decl * const *ProtoRefs,
Chris Lattnere13b9592008-07-26 04:03:38 +0000508 unsigned NumProtoRefs,
Douglas Gregor18df52b2010-01-16 15:02:53 +0000509 const SourceLocation *ProtoLocs,
Daniel Dunbar246e70f2008-09-26 04:48:09 +0000510 SourceLocation EndProtoLoc,
511 AttributeList *AttrList) {
Fariborz Jahanian96b69a72011-05-12 22:04:39 +0000512 bool err = false;
Daniel Dunbar246e70f2008-09-26 04:48:09 +0000513 // FIXME: Deal with AttrList.
Chris Lattner4d391482007-12-12 07:09:47 +0000514 assert(ProtocolName && "Missing protocol identifier");
Douglas Gregorc83c6872010-04-15 22:33:43 +0000515 ObjCProtocolDecl *PDecl = LookupProtocol(ProtocolName, ProtocolLoc);
Chris Lattner4d391482007-12-12 07:09:47 +0000516 if (PDecl) {
517 // Protocol already seen. Better be a forward protocol declaration
Chris Lattner439e71f2008-03-16 01:25:17 +0000518 if (!PDecl->isForwardDecl()) {
Fariborz Jahaniane2573e52009-04-06 23:43:32 +0000519 Diag(ProtocolLoc, diag::warn_duplicate_protocol_def) << ProtocolName;
Chris Lattnerb8b96af2008-11-23 22:46:27 +0000520 Diag(PDecl->getLocation(), diag::note_previous_definition);
Chris Lattner439e71f2008-03-16 01:25:17 +0000521 // Just return the protocol we already had.
522 // FIXME: don't leak the objects passed in!
John McCalld226f652010-08-21 09:40:31 +0000523 return PDecl;
Chris Lattner4d391482007-12-12 07:09:47 +0000524 }
Steve Naroff61d68522009-03-05 15:22:01 +0000525 ObjCList<ObjCProtocolDecl> PList;
Mike Stump1eb44332009-09-09 15:08:12 +0000526 PList.set((ObjCProtocolDecl *const*)ProtoRefs, NumProtoRefs, Context);
Fariborz Jahanian819e9bf2011-05-13 18:02:08 +0000527 err = CheckForwardProtocolDeclarationForCircularDependency(
528 ProtocolName, ProtocolLoc, PDecl->getLocation(), PList);
Mike Stump1eb44332009-09-09 15:08:12 +0000529
Steve Narofff11b5082008-08-13 16:39:22 +0000530 // Make sure the cached decl gets a valid start location.
531 PDecl->setLocation(AtProtoInterfaceLoc);
Chris Lattner439e71f2008-03-16 01:25:17 +0000532 PDecl->setForwardDecl(false);
Sebastian Redl0b17c612010-08-13 00:28:03 +0000533 CurContext->addDecl(PDecl);
Sebastian Redl3c7f4132010-08-18 23:57:06 +0000534 // Repeat in dependent AST files.
Sebastian Redl0b17c612010-08-13 00:28:03 +0000535 PDecl->setChangedSinceDeserialization(true);
Chris Lattner439e71f2008-03-16 01:25:17 +0000536 } else {
Mike Stump1eb44332009-09-09 15:08:12 +0000537 PDecl = ObjCProtocolDecl::Create(Context, CurContext,
Douglas Gregord0434102009-01-09 00:49:46 +0000538 AtProtoInterfaceLoc,ProtocolName);
Douglas Gregor6e378de2009-04-23 23:18:26 +0000539 PushOnScopeChains(PDecl, TUScope);
Chris Lattnerc8581052008-03-16 20:19:15 +0000540 PDecl->setForwardDecl(false);
Chris Lattnercca59d72008-03-16 01:23:04 +0000541 }
Fariborz Jahanianbc1c8772008-12-17 01:07:27 +0000542 if (AttrList)
Douglas Gregor9cdda0c2009-06-17 21:51:59 +0000543 ProcessDeclAttributeList(TUScope, PDecl, AttrList);
Fariborz Jahanian96b69a72011-05-12 22:04:39 +0000544 if (!err && NumProtoRefs ) {
Chris Lattnerc8581052008-03-16 20:19:15 +0000545 /// Check then save referenced protocols.
Douglas Gregor18df52b2010-01-16 15:02:53 +0000546 PDecl->setProtocolList((ObjCProtocolDecl**)ProtoRefs, NumProtoRefs,
547 ProtoLocs, Context);
Chris Lattner4d391482007-12-12 07:09:47 +0000548 PDecl->setLocEnd(EndProtoLoc);
549 }
Mike Stump1eb44332009-09-09 15:08:12 +0000550
551 CheckObjCDeclScope(PDecl);
John McCalld226f652010-08-21 09:40:31 +0000552 return PDecl;
Chris Lattner4d391482007-12-12 07:09:47 +0000553}
554
555/// FindProtocolDeclaration - This routine looks up protocols and
Daniel Dunbar7ad1b1f2008-09-04 20:01:15 +0000556/// issues an error if they are not declared. It returns list of
557/// protocol declarations in its 'Protocols' argument.
Chris Lattner4d391482007-12-12 07:09:47 +0000558void
Chris Lattnere13b9592008-07-26 04:03:38 +0000559Sema::FindProtocolDeclaration(bool WarnOnDeclarations,
Chris Lattner7caeabd2008-07-21 22:17:28 +0000560 const IdentifierLocPair *ProtocolId,
Chris Lattner4d391482007-12-12 07:09:47 +0000561 unsigned NumProtocols,
Chris Lattner5f9e2722011-07-23 10:55:15 +0000562 SmallVectorImpl<Decl *> &Protocols) {
Chris Lattner4d391482007-12-12 07:09:47 +0000563 for (unsigned i = 0; i != NumProtocols; ++i) {
Douglas Gregorc83c6872010-04-15 22:33:43 +0000564 ObjCProtocolDecl *PDecl = LookupProtocol(ProtocolId[i].first,
565 ProtocolId[i].second);
Chris Lattnereacc3922008-07-26 03:47:43 +0000566 if (!PDecl) {
Douglas Gregord8bba9c2011-06-28 16:20:02 +0000567 TypoCorrection Corrected = CorrectTypo(
568 DeclarationNameInfo(ProtocolId[i].first, ProtocolId[i].second),
569 LookupObjCProtocolName, TUScope, NULL, NULL, false, CTC_NoKeywords);
570 if ((PDecl = Corrected.getCorrectionDeclAs<ObjCProtocolDecl>())) {
Douglas Gregorf06cdae2010-01-03 18:01:57 +0000571 Diag(ProtocolId[i].second, diag::err_undeclared_protocol_suggest)
Douglas Gregord8bba9c2011-06-28 16:20:02 +0000572 << ProtocolId[i].first << Corrected.getCorrection();
Douglas Gregor67dd1d42010-01-07 00:17:44 +0000573 Diag(PDecl->getLocation(), diag::note_previous_decl)
574 << PDecl->getDeclName();
Douglas Gregorf06cdae2010-01-03 18:01:57 +0000575 }
576 }
577
578 if (!PDecl) {
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000579 Diag(ProtocolId[i].second, diag::err_undeclared_protocol)
Chris Lattner3c73c412008-11-19 08:23:25 +0000580 << ProtocolId[i].first;
Chris Lattnereacc3922008-07-26 03:47:43 +0000581 continue;
582 }
Mike Stump1eb44332009-09-09 15:08:12 +0000583
Douglas Gregor48f3bb92009-02-18 21:56:37 +0000584 (void)DiagnoseUseOfDecl(PDecl, ProtocolId[i].second);
Chris Lattnereacc3922008-07-26 03:47:43 +0000585
586 // If this is a forward declaration and we are supposed to warn in this
587 // case, do it.
588 if (WarnOnDeclarations && PDecl->isForwardDecl())
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000589 Diag(ProtocolId[i].second, diag::warn_undef_protocolref)
Chris Lattner3c73c412008-11-19 08:23:25 +0000590 << ProtocolId[i].first;
John McCalld226f652010-08-21 09:40:31 +0000591 Protocols.push_back(PDecl);
Chris Lattner4d391482007-12-12 07:09:47 +0000592 }
593}
594
Fariborz Jahanian78c39c72009-03-02 19:06:08 +0000595/// DiagnoseClassExtensionDupMethods - Check for duplicate declaration of
Fariborz Jahanianb7f95f52009-03-02 19:05:07 +0000596/// a class method in its extension.
597///
Mike Stump1eb44332009-09-09 15:08:12 +0000598void Sema::DiagnoseClassExtensionDupMethods(ObjCCategoryDecl *CAT,
Fariborz Jahanianb7f95f52009-03-02 19:05:07 +0000599 ObjCInterfaceDecl *ID) {
600 if (!ID)
601 return; // Possibly due to previous error
602
603 llvm::DenseMap<Selector, const ObjCMethodDecl*> MethodMap;
Argyrios Kyrtzidis17945a02009-06-30 02:36:12 +0000604 for (ObjCInterfaceDecl::method_iterator i = ID->meth_begin(),
605 e = ID->meth_end(); i != e; ++i) {
Fariborz Jahanianb7f95f52009-03-02 19:05:07 +0000606 ObjCMethodDecl *MD = *i;
607 MethodMap[MD->getSelector()] = MD;
608 }
609
610 if (MethodMap.empty())
611 return;
Argyrios Kyrtzidis17945a02009-06-30 02:36:12 +0000612 for (ObjCCategoryDecl::method_iterator i = CAT->meth_begin(),
613 e = CAT->meth_end(); i != e; ++i) {
Fariborz Jahanianb7f95f52009-03-02 19:05:07 +0000614 ObjCMethodDecl *Method = *i;
615 const ObjCMethodDecl *&PrevMethod = MethodMap[Method->getSelector()];
616 if (PrevMethod && !MatchTwoMethodDeclarations(Method, PrevMethod)) {
617 Diag(Method->getLocation(), diag::err_duplicate_method_decl)
618 << Method->getDeclName();
619 Diag(PrevMethod->getLocation(), diag::note_previous_declaration);
620 }
621 }
622}
623
Chris Lattner58fe03b2009-04-12 08:43:13 +0000624/// ActOnForwardProtocolDeclaration - Handle @protocol foo;
John McCalld226f652010-08-21 09:40:31 +0000625Decl *
Chris Lattner4d391482007-12-12 07:09:47 +0000626Sema::ActOnForwardProtocolDeclaration(SourceLocation AtProtocolLoc,
Chris Lattner7caeabd2008-07-21 22:17:28 +0000627 const IdentifierLocPair *IdentList,
Fariborz Jahanianbc1c8772008-12-17 01:07:27 +0000628 unsigned NumElts,
629 AttributeList *attrList) {
Chris Lattner5f9e2722011-07-23 10:55:15 +0000630 SmallVector<ObjCProtocolDecl*, 32> Protocols;
631 SmallVector<SourceLocation, 8> ProtoLocs;
Mike Stump1eb44332009-09-09 15:08:12 +0000632
Chris Lattner4d391482007-12-12 07:09:47 +0000633 for (unsigned i = 0; i != NumElts; ++i) {
Chris Lattner7caeabd2008-07-21 22:17:28 +0000634 IdentifierInfo *Ident = IdentList[i].first;
Douglas Gregorc83c6872010-04-15 22:33:43 +0000635 ObjCProtocolDecl *PDecl = LookupProtocol(Ident, IdentList[i].second);
Sebastian Redl0b17c612010-08-13 00:28:03 +0000636 bool isNew = false;
Douglas Gregord0434102009-01-09 00:49:46 +0000637 if (PDecl == 0) { // Not already seen?
Mike Stump1eb44332009-09-09 15:08:12 +0000638 PDecl = ObjCProtocolDecl::Create(Context, CurContext,
Douglas Gregord0434102009-01-09 00:49:46 +0000639 IdentList[i].second, Ident);
Sebastian Redl0b17c612010-08-13 00:28:03 +0000640 PushOnScopeChains(PDecl, TUScope, false);
641 isNew = true;
Douglas Gregord0434102009-01-09 00:49:46 +0000642 }
Sebastian Redl0b17c612010-08-13 00:28:03 +0000643 if (attrList) {
Douglas Gregor9cdda0c2009-06-17 21:51:59 +0000644 ProcessDeclAttributeList(TUScope, PDecl, attrList);
Sebastian Redl0b17c612010-08-13 00:28:03 +0000645 if (!isNew)
646 PDecl->setChangedSinceDeserialization(true);
647 }
Chris Lattner4d391482007-12-12 07:09:47 +0000648 Protocols.push_back(PDecl);
Douglas Gregor18df52b2010-01-16 15:02:53 +0000649 ProtoLocs.push_back(IdentList[i].second);
Chris Lattner4d391482007-12-12 07:09:47 +0000650 }
Mike Stump1eb44332009-09-09 15:08:12 +0000651
652 ObjCForwardProtocolDecl *PDecl =
Douglas Gregord0434102009-01-09 00:49:46 +0000653 ObjCForwardProtocolDecl::Create(Context, CurContext, AtProtocolLoc,
Douglas Gregor18df52b2010-01-16 15:02:53 +0000654 Protocols.data(), Protocols.size(),
655 ProtoLocs.data());
Argyrios Kyrtzidis17945a02009-06-30 02:36:12 +0000656 CurContext->addDecl(PDecl);
Anders Carlsson15281452008-11-04 16:57:32 +0000657 CheckObjCDeclScope(PDecl);
John McCalld226f652010-08-21 09:40:31 +0000658 return PDecl;
Chris Lattner4d391482007-12-12 07:09:47 +0000659}
660
John McCalld226f652010-08-21 09:40:31 +0000661Decl *Sema::
Chris Lattner7caeabd2008-07-21 22:17:28 +0000662ActOnStartCategoryInterface(SourceLocation AtInterfaceLoc,
663 IdentifierInfo *ClassName, SourceLocation ClassLoc,
664 IdentifierInfo *CategoryName,
665 SourceLocation CategoryLoc,
John McCalld226f652010-08-21 09:40:31 +0000666 Decl * const *ProtoRefs,
Chris Lattner7caeabd2008-07-21 22:17:28 +0000667 unsigned NumProtoRefs,
Douglas Gregor18df52b2010-01-16 15:02:53 +0000668 const SourceLocation *ProtoLocs,
Chris Lattner7caeabd2008-07-21 22:17:28 +0000669 SourceLocation EndProtoLoc) {
Fariborz Jahanian80aa1cd2010-06-22 23:20:40 +0000670 ObjCCategoryDecl *CDecl;
Douglas Gregorc83c6872010-04-15 22:33:43 +0000671 ObjCInterfaceDecl *IDecl = getObjCInterfaceDecl(ClassName, ClassLoc, true);
Ted Kremenek09b68972010-02-23 19:39:46 +0000672
673 /// Check that class of this category is already completely declared.
674 if (!IDecl || IDecl->isForwardDecl()) {
675 // Create an invalid ObjCCategoryDecl to serve as context for
676 // the enclosing method declarations. We mark the decl invalid
677 // to make it clear that this isn't a valid AST.
678 CDecl = ObjCCategoryDecl::Create(Context, CurContext, AtInterfaceLoc,
679 ClassLoc, CategoryLoc, CategoryName);
680 CDecl->setInvalidDecl();
681 Diag(ClassLoc, diag::err_undef_interface) << ClassName;
John McCalld226f652010-08-21 09:40:31 +0000682 return CDecl;
Ted Kremenek09b68972010-02-23 19:39:46 +0000683 }
684
Fariborz Jahanian80aa1cd2010-06-22 23:20:40 +0000685 if (!CategoryName && IDecl->getImplementation()) {
686 Diag(ClassLoc, diag::err_class_extension_after_impl) << ClassName;
687 Diag(IDecl->getImplementation()->getLocation(),
688 diag::note_implementation_declared);
Ted Kremenek09b68972010-02-23 19:39:46 +0000689 }
690
Fariborz Jahanian80aa1cd2010-06-22 23:20:40 +0000691 CDecl = ObjCCategoryDecl::Create(Context, CurContext, AtInterfaceLoc,
692 ClassLoc, CategoryLoc, CategoryName);
693 // FIXME: PushOnScopeChains?
694 CurContext->addDecl(CDecl);
Chris Lattner4d391482007-12-12 07:09:47 +0000695
Fariborz Jahanian80aa1cd2010-06-22 23:20:40 +0000696 CDecl->setClassInterface(IDecl);
697 // Insert class extension to the list of class's categories.
698 if (!CategoryName)
699 CDecl->insertNextClassCategory();
Mike Stump1eb44332009-09-09 15:08:12 +0000700
Chris Lattner16b34b42009-02-16 21:30:01 +0000701 // If the interface is deprecated, warn about it.
Douglas Gregor48f3bb92009-02-18 21:56:37 +0000702 (void)DiagnoseUseOfDecl(IDecl, ClassLoc);
Chris Lattner70f19542009-02-16 21:26:43 +0000703
Fariborz Jahanian25760612010-02-15 21:55:26 +0000704 if (CategoryName) {
705 /// Check for duplicate interface declaration for this category
706 ObjCCategoryDecl *CDeclChain;
707 for (CDeclChain = IDecl->getCategoryList(); CDeclChain;
708 CDeclChain = CDeclChain->getNextClassCategory()) {
709 if (CDeclChain->getIdentifier() == CategoryName) {
710 // Class extensions can be declared multiple times.
711 Diag(CategoryLoc, diag::warn_dup_category_def)
712 << ClassName << CategoryName;
713 Diag(CDeclChain->getLocation(), diag::note_previous_definition);
714 break;
715 }
Chris Lattner70f19542009-02-16 21:26:43 +0000716 }
Fariborz Jahanian25760612010-02-15 21:55:26 +0000717 if (!CDeclChain)
718 CDecl->insertNextClassCategory();
Chris Lattner70f19542009-02-16 21:26:43 +0000719 }
Chris Lattner70f19542009-02-16 21:26:43 +0000720
Chris Lattner4d391482007-12-12 07:09:47 +0000721 if (NumProtoRefs) {
Fariborz Jahanianb106fc62009-10-05 21:32:49 +0000722 CDecl->setProtocolList((ObjCProtocolDecl**)ProtoRefs, NumProtoRefs,
Douglas Gregor18df52b2010-01-16 15:02:53 +0000723 ProtoLocs, Context);
Fariborz Jahanian339798e2009-10-05 20:41:32 +0000724 // Protocols in the class extension belong to the class.
Fariborz Jahanian25760612010-02-15 21:55:26 +0000725 if (CDecl->IsClassExtension())
Fariborz Jahanian339798e2009-10-05 20:41:32 +0000726 IDecl->mergeClassExtensionProtocolList((ObjCProtocolDecl**)ProtoRefs,
Ted Kremenek53b94412010-09-01 01:21:15 +0000727 NumProtoRefs, Context);
Chris Lattner4d391482007-12-12 07:09:47 +0000728 }
Mike Stump1eb44332009-09-09 15:08:12 +0000729
Anders Carlsson15281452008-11-04 16:57:32 +0000730 CheckObjCDeclScope(CDecl);
John McCalld226f652010-08-21 09:40:31 +0000731 return CDecl;
Chris Lattner4d391482007-12-12 07:09:47 +0000732}
733
734/// ActOnStartCategoryImplementation - Perform semantic checks on the
Ted Kremeneka526c5c2008-01-07 19:49:32 +0000735/// category implementation declaration and build an ObjCCategoryImplDecl
Chris Lattner4d391482007-12-12 07:09:47 +0000736/// object.
John McCalld226f652010-08-21 09:40:31 +0000737Decl *Sema::ActOnStartCategoryImplementation(
Chris Lattner4d391482007-12-12 07:09:47 +0000738 SourceLocation AtCatImplLoc,
739 IdentifierInfo *ClassName, SourceLocation ClassLoc,
740 IdentifierInfo *CatName, SourceLocation CatLoc) {
Douglas Gregorc83c6872010-04-15 22:33:43 +0000741 ObjCInterfaceDecl *IDecl = getObjCInterfaceDecl(ClassName, ClassLoc, true);
Argyrios Kyrtzidis8a1d7222009-07-21 00:05:53 +0000742 ObjCCategoryDecl *CatIDecl = 0;
743 if (IDecl) {
744 CatIDecl = IDecl->FindCategoryDeclaration(CatName);
745 if (!CatIDecl) {
746 // Category @implementation with no corresponding @interface.
747 // Create and install one.
748 CatIDecl = ObjCCategoryDecl::Create(Context, CurContext, SourceLocation(),
Douglas Gregor3db211b2010-01-16 16:38:58 +0000749 SourceLocation(), SourceLocation(),
Argyrios Kyrtzidis8a1d7222009-07-21 00:05:53 +0000750 CatName);
751 CatIDecl->setClassInterface(IDecl);
752 CatIDecl->insertNextClassCategory();
753 }
754 }
755
Mike Stump1eb44332009-09-09 15:08:12 +0000756 ObjCCategoryImplDecl *CDecl =
Douglas Gregord0434102009-01-09 00:49:46 +0000757 ObjCCategoryImplDecl::Create(Context, CurContext, AtCatImplLoc, CatName,
758 IDecl);
Chris Lattner4d391482007-12-12 07:09:47 +0000759 /// Check that class of this category is already completely declared.
John McCall6c2c2502011-07-22 02:45:48 +0000760 if (!IDecl || IDecl->isForwardDecl()) {
Chris Lattner3c73c412008-11-19 08:23:25 +0000761 Diag(ClassLoc, diag::err_undef_interface) << ClassName;
John McCall6c2c2502011-07-22 02:45:48 +0000762 CDecl->setInvalidDecl();
763 }
Chris Lattner4d391482007-12-12 07:09:47 +0000764
Douglas Gregord0434102009-01-09 00:49:46 +0000765 // FIXME: PushOnScopeChains?
Argyrios Kyrtzidis17945a02009-06-30 02:36:12 +0000766 CurContext->addDecl(CDecl);
Douglas Gregord0434102009-01-09 00:49:46 +0000767
Argyrios Kyrtzidis8a1d7222009-07-21 00:05:53 +0000768 /// Check that CatName, category name, is not used in another implementation.
769 if (CatIDecl) {
770 if (CatIDecl->getImplementation()) {
771 Diag(ClassLoc, diag::err_dup_implementation_category) << ClassName
772 << CatName;
773 Diag(CatIDecl->getImplementation()->getLocation(),
774 diag::note_previous_definition);
Fariborz Jahanianb1224f62011-02-15 00:59:30 +0000775 } else {
Argyrios Kyrtzidis8a1d7222009-07-21 00:05:53 +0000776 CatIDecl->setImplementation(CDecl);
Fariborz Jahanianb1224f62011-02-15 00:59:30 +0000777 // Warn on implementating category of deprecated class under
778 // -Wdeprecated-implementations flag.
Fariborz Jahanian5ac96d52011-02-15 17:49:58 +0000779 DiagnoseObjCImplementedDeprecations(*this,
780 dyn_cast<NamedDecl>(IDecl),
781 CDecl->getLocation(), 2);
Fariborz Jahanianb1224f62011-02-15 00:59:30 +0000782 }
Argyrios Kyrtzidis8a1d7222009-07-21 00:05:53 +0000783 }
Mike Stump1eb44332009-09-09 15:08:12 +0000784
Anders Carlsson15281452008-11-04 16:57:32 +0000785 CheckObjCDeclScope(CDecl);
John McCalld226f652010-08-21 09:40:31 +0000786 return CDecl;
Chris Lattner4d391482007-12-12 07:09:47 +0000787}
788
John McCalld226f652010-08-21 09:40:31 +0000789Decl *Sema::ActOnStartClassImplementation(
Chris Lattner4d391482007-12-12 07:09:47 +0000790 SourceLocation AtClassImplLoc,
791 IdentifierInfo *ClassName, SourceLocation ClassLoc,
Mike Stump1eb44332009-09-09 15:08:12 +0000792 IdentifierInfo *SuperClassname,
Chris Lattner4d391482007-12-12 07:09:47 +0000793 SourceLocation SuperClassLoc) {
Douglas Gregordeacbdc2010-08-11 12:19:30 +0000794 ObjCInterfaceDecl* IDecl = 0;
Chris Lattner4d391482007-12-12 07:09:47 +0000795 // Check for another declaration kind with the same name.
John McCallf36e02d2009-10-09 21:13:30 +0000796 NamedDecl *PrevDecl
Douglas Gregorc0b39642010-04-15 23:40:53 +0000797 = LookupSingleName(TUScope, ClassName, ClassLoc, LookupOrdinaryName,
798 ForRedeclaration);
Ted Kremeneka526c5c2008-01-07 19:49:32 +0000799 if (PrevDecl && !isa<ObjCInterfaceDecl>(PrevDecl)) {
Chris Lattner3c73c412008-11-19 08:23:25 +0000800 Diag(ClassLoc, diag::err_redefinition_different_kind) << ClassName;
Chris Lattner5f4a6822008-11-23 23:12:31 +0000801 Diag(PrevDecl->getLocation(), diag::note_previous_definition);
Douglas Gregordeacbdc2010-08-11 12:19:30 +0000802 } else if ((IDecl = dyn_cast_or_null<ObjCInterfaceDecl>(PrevDecl))) {
803 // If this is a forward declaration of an interface, warn.
804 if (IDecl->isForwardDecl()) {
Chris Lattner3c73c412008-11-19 08:23:25 +0000805 Diag(ClassLoc, diag::warn_undef_interface) << ClassName;
Douglas Gregordeacbdc2010-08-11 12:19:30 +0000806 IDecl = 0;
Fariborz Jahanian77a6be42009-04-23 21:49:04 +0000807 }
Douglas Gregor95ff7422010-01-04 17:27:12 +0000808 } else {
809 // We did not find anything with the name ClassName; try to correct for
810 // typos in the class name.
Douglas Gregord8bba9c2011-06-28 16:20:02 +0000811 TypoCorrection Corrected = CorrectTypo(
812 DeclarationNameInfo(ClassName, ClassLoc), LookupOrdinaryName, TUScope,
813 NULL, NULL, false, CTC_NoKeywords);
814 if ((IDecl = Corrected.getCorrectionDeclAs<ObjCInterfaceDecl>())) {
Douglas Gregora6f26382010-01-06 23:44:25 +0000815 // Suggest the (potentially) correct interface name. However, put the
816 // fix-it hint itself in a separate note, since changing the name in
Douglas Gregordeacbdc2010-08-11 12:19:30 +0000817 // the warning would make the fix-it change semantics.However, don't
Douglas Gregor95ff7422010-01-04 17:27:12 +0000818 // provide a code-modification hint or use the typo name for recovery,
819 // because this is just a warning. The program may actually be correct.
Douglas Gregord8bba9c2011-06-28 16:20:02 +0000820 DeclarationName CorrectedName = Corrected.getCorrection();
Douglas Gregor95ff7422010-01-04 17:27:12 +0000821 Diag(ClassLoc, diag::warn_undef_interface_suggest)
Douglas Gregord8bba9c2011-06-28 16:20:02 +0000822 << ClassName << CorrectedName;
823 Diag(IDecl->getLocation(), diag::note_previous_decl) << CorrectedName
824 << FixItHint::CreateReplacement(ClassLoc, CorrectedName.getAsString());
Douglas Gregor95ff7422010-01-04 17:27:12 +0000825 IDecl = 0;
826 } else {
827 Diag(ClassLoc, diag::warn_undef_interface) << ClassName;
828 }
Chris Lattner4d391482007-12-12 07:09:47 +0000829 }
Mike Stump1eb44332009-09-09 15:08:12 +0000830
Chris Lattner4d391482007-12-12 07:09:47 +0000831 // Check that super class name is valid class name
Ted Kremeneka526c5c2008-01-07 19:49:32 +0000832 ObjCInterfaceDecl* SDecl = 0;
Chris Lattner4d391482007-12-12 07:09:47 +0000833 if (SuperClassname) {
834 // Check if a different kind of symbol declared in this scope.
Douglas Gregorc83c6872010-04-15 22:33:43 +0000835 PrevDecl = LookupSingleName(TUScope, SuperClassname, SuperClassLoc,
836 LookupOrdinaryName);
Ted Kremeneka526c5c2008-01-07 19:49:32 +0000837 if (PrevDecl && !isa<ObjCInterfaceDecl>(PrevDecl)) {
Chris Lattner3c73c412008-11-19 08:23:25 +0000838 Diag(SuperClassLoc, diag::err_redefinition_different_kind)
839 << SuperClassname;
Chris Lattner5f4a6822008-11-23 23:12:31 +0000840 Diag(PrevDecl->getLocation(), diag::note_previous_definition);
Chris Lattner3c73c412008-11-19 08:23:25 +0000841 } else {
Mike Stump1eb44332009-09-09 15:08:12 +0000842 SDecl = dyn_cast_or_null<ObjCInterfaceDecl>(PrevDecl);
Chris Lattner4d391482007-12-12 07:09:47 +0000843 if (!SDecl)
Chris Lattner3c73c412008-11-19 08:23:25 +0000844 Diag(SuperClassLoc, diag::err_undef_superclass)
845 << SuperClassname << ClassName;
Chris Lattner4d391482007-12-12 07:09:47 +0000846 else if (IDecl && IDecl->getSuperClass() != SDecl) {
847 // This implementation and its interface do not have the same
848 // super class.
Chris Lattner3c73c412008-11-19 08:23:25 +0000849 Diag(SuperClassLoc, diag::err_conflicting_super_class)
Chris Lattner08631c52008-11-23 21:45:46 +0000850 << SDecl->getDeclName();
Chris Lattner5f4a6822008-11-23 23:12:31 +0000851 Diag(SDecl->getLocation(), diag::note_previous_definition);
Chris Lattner4d391482007-12-12 07:09:47 +0000852 }
853 }
854 }
Mike Stump1eb44332009-09-09 15:08:12 +0000855
Chris Lattner4d391482007-12-12 07:09:47 +0000856 if (!IDecl) {
857 // Legacy case of @implementation with no corresponding @interface.
858 // Build, chain & install the interface decl into the identifier.
Daniel Dunbarf6414922008-08-20 18:02:42 +0000859
Mike Stump390b4cc2009-05-16 07:39:55 +0000860 // FIXME: Do we support attributes on the @implementation? If so we should
861 // copy them over.
Mike Stump1eb44332009-09-09 15:08:12 +0000862 IDecl = ObjCInterfaceDecl::Create(Context, CurContext, AtClassImplLoc,
Douglas Gregordeacbdc2010-08-11 12:19:30 +0000863 ClassName, ClassLoc, false, true);
Chris Lattner4d391482007-12-12 07:09:47 +0000864 IDecl->setSuperClass(SDecl);
865 IDecl->setLocEnd(ClassLoc);
Douglas Gregor8b9fb302009-04-24 00:16:12 +0000866
867 PushOnScopeChains(IDecl, TUScope);
Douglas Gregordeacbdc2010-08-11 12:19:30 +0000868 } else {
869 // Mark the interface as being completed, even if it was just as
870 // @class ....;
871 // declaration; the user cannot reopen it.
872 IDecl->setForwardDecl(false);
Chris Lattner4d391482007-12-12 07:09:47 +0000873 }
Mike Stump1eb44332009-09-09 15:08:12 +0000874
875 ObjCImplementationDecl* IMPDecl =
876 ObjCImplementationDecl::Create(Context, CurContext, AtClassImplLoc,
Douglas Gregor4afa39d2009-01-20 01:17:11 +0000877 IDecl, SDecl);
Mike Stump1eb44332009-09-09 15:08:12 +0000878
Anders Carlsson15281452008-11-04 16:57:32 +0000879 if (CheckObjCDeclScope(IMPDecl))
John McCalld226f652010-08-21 09:40:31 +0000880 return IMPDecl;
Mike Stump1eb44332009-09-09 15:08:12 +0000881
Chris Lattner4d391482007-12-12 07:09:47 +0000882 // Check that there is no duplicate implementation of this class.
Douglas Gregordeacbdc2010-08-11 12:19:30 +0000883 if (IDecl->getImplementation()) {
884 // FIXME: Don't leak everything!
Chris Lattner3c73c412008-11-19 08:23:25 +0000885 Diag(ClassLoc, diag::err_dup_implementation_class) << ClassName;
Argyrios Kyrtzidis87018772009-07-21 00:06:04 +0000886 Diag(IDecl->getImplementation()->getLocation(),
887 diag::note_previous_definition);
Douglas Gregordeacbdc2010-08-11 12:19:30 +0000888 } else { // add it to the list.
Argyrios Kyrtzidis8a1d7222009-07-21 00:05:53 +0000889 IDecl->setImplementation(IMPDecl);
Douglas Gregor8fc463a2009-04-24 00:11:27 +0000890 PushOnScopeChains(IMPDecl, TUScope);
Fariborz Jahanianb1224f62011-02-15 00:59:30 +0000891 // Warn on implementating deprecated class under
892 // -Wdeprecated-implementations flag.
Fariborz Jahanian5ac96d52011-02-15 17:49:58 +0000893 DiagnoseObjCImplementedDeprecations(*this,
894 dyn_cast<NamedDecl>(IDecl),
895 IMPDecl->getLocation(), 1);
Argyrios Kyrtzidis8a1d7222009-07-21 00:05:53 +0000896 }
John McCalld226f652010-08-21 09:40:31 +0000897 return IMPDecl;
Chris Lattner4d391482007-12-12 07:09:47 +0000898}
899
Ted Kremeneka526c5c2008-01-07 19:49:32 +0000900void Sema::CheckImplementationIvars(ObjCImplementationDecl *ImpDecl,
901 ObjCIvarDecl **ivars, unsigned numIvars,
Chris Lattner4d391482007-12-12 07:09:47 +0000902 SourceLocation RBrace) {
903 assert(ImpDecl && "missing implementation decl");
Douglas Gregor4afa39d2009-01-20 01:17:11 +0000904 ObjCInterfaceDecl* IDecl = ImpDecl->getClassInterface();
Chris Lattner4d391482007-12-12 07:09:47 +0000905 if (!IDecl)
906 return;
907 /// Check case of non-existing @interface decl.
908 /// (legacy objective-c @implementation decl without an @interface decl).
909 /// Add implementations's ivar to the synthesize class's ivar list.
Steve Naroff33feeb02009-04-20 20:09:33 +0000910 if (IDecl->isImplicitInterfaceDecl()) {
Chris Lattner38af2de2009-02-20 21:35:13 +0000911 IDecl->setLocEnd(RBrace);
Fariborz Jahanian3a21cd92010-02-17 17:00:07 +0000912 // Add ivar's to class's DeclContext.
913 for (unsigned i = 0, e = numIvars; i != e; ++i) {
Fariborz Jahanian2f14c4d2010-02-17 18:10:54 +0000914 ivars[i]->setLexicalDeclContext(ImpDecl);
915 IDecl->makeDeclVisibleInContext(ivars[i], false);
Fariborz Jahanian11062e12010-02-19 00:31:17 +0000916 ImpDecl->addDecl(ivars[i]);
Fariborz Jahanian3a21cd92010-02-17 17:00:07 +0000917 }
918
Chris Lattner4d391482007-12-12 07:09:47 +0000919 return;
920 }
921 // If implementation has empty ivar list, just return.
922 if (numIvars == 0)
923 return;
Mike Stump1eb44332009-09-09 15:08:12 +0000924
Chris Lattner4d391482007-12-12 07:09:47 +0000925 assert(ivars && "missing @implementation ivars");
Fariborz Jahanianbd94d442010-02-19 20:58:54 +0000926 if (LangOpts.ObjCNonFragileABI2) {
927 if (ImpDecl->getSuperClass())
928 Diag(ImpDecl->getLocation(), diag::warn_on_superclass_use);
929 for (unsigned i = 0; i < numIvars; i++) {
930 ObjCIvarDecl* ImplIvar = ivars[i];
931 if (const ObjCIvarDecl *ClsIvar =
932 IDecl->getIvarDecl(ImplIvar->getIdentifier())) {
933 Diag(ImplIvar->getLocation(), diag::err_duplicate_ivar_declaration);
934 Diag(ClsIvar->getLocation(), diag::note_previous_definition);
935 continue;
936 }
Fariborz Jahanianbd94d442010-02-19 20:58:54 +0000937 // Instance ivar to Implementation's DeclContext.
938 ImplIvar->setLexicalDeclContext(ImpDecl);
939 IDecl->makeDeclVisibleInContext(ImplIvar, false);
940 ImpDecl->addDecl(ImplIvar);
941 }
942 return;
943 }
Chris Lattner4d391482007-12-12 07:09:47 +0000944 // Check interface's Ivar list against those in the implementation.
945 // names and types must match.
946 //
Chris Lattner4d391482007-12-12 07:09:47 +0000947 unsigned j = 0;
Mike Stump1eb44332009-09-09 15:08:12 +0000948 ObjCInterfaceDecl::ivar_iterator
Chris Lattner4c525092007-12-12 17:58:05 +0000949 IVI = IDecl->ivar_begin(), IVE = IDecl->ivar_end();
950 for (; numIvars > 0 && IVI != IVE; ++IVI) {
Ted Kremeneka526c5c2008-01-07 19:49:32 +0000951 ObjCIvarDecl* ImplIvar = ivars[j++];
952 ObjCIvarDecl* ClsIvar = *IVI;
Chris Lattner4d391482007-12-12 07:09:47 +0000953 assert (ImplIvar && "missing implementation ivar");
954 assert (ClsIvar && "missing class ivar");
Mike Stump1eb44332009-09-09 15:08:12 +0000955
Steve Naroffca331292009-03-03 14:49:36 +0000956 // First, make sure the types match.
Chris Lattner1b63eef2008-07-27 00:05:05 +0000957 if (Context.getCanonicalType(ImplIvar->getType()) !=
958 Context.getCanonicalType(ClsIvar->getType())) {
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000959 Diag(ImplIvar->getLocation(), diag::err_conflicting_ivar_type)
Chris Lattner08631c52008-11-23 21:45:46 +0000960 << ImplIvar->getIdentifier()
961 << ImplIvar->getType() << ClsIvar->getType();
Chris Lattner5f4a6822008-11-23 23:12:31 +0000962 Diag(ClsIvar->getLocation(), diag::note_previous_definition);
Steve Naroffca331292009-03-03 14:49:36 +0000963 } else if (ImplIvar->isBitField() && ClsIvar->isBitField()) {
964 Expr *ImplBitWidth = ImplIvar->getBitWidth();
965 Expr *ClsBitWidth = ClsIvar->getBitWidth();
Eli Friedman9a901bb2009-04-26 19:19:15 +0000966 if (ImplBitWidth->EvaluateAsInt(Context).getZExtValue() !=
967 ClsBitWidth->EvaluateAsInt(Context).getZExtValue()) {
Steve Naroffca331292009-03-03 14:49:36 +0000968 Diag(ImplBitWidth->getLocStart(), diag::err_conflicting_ivar_bitwidth)
969 << ImplIvar->getIdentifier();
970 Diag(ClsBitWidth->getLocStart(), diag::note_previous_definition);
971 }
Mike Stump1eb44332009-09-09 15:08:12 +0000972 }
Steve Naroffca331292009-03-03 14:49:36 +0000973 // Make sure the names are identical.
974 if (ImplIvar->getIdentifier() != ClsIvar->getIdentifier()) {
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000975 Diag(ImplIvar->getLocation(), diag::err_conflicting_ivar_name)
Chris Lattner08631c52008-11-23 21:45:46 +0000976 << ImplIvar->getIdentifier() << ClsIvar->getIdentifier();
Chris Lattner5f4a6822008-11-23 23:12:31 +0000977 Diag(ClsIvar->getLocation(), diag::note_previous_definition);
Chris Lattner4d391482007-12-12 07:09:47 +0000978 }
979 --numIvars;
Chris Lattner4d391482007-12-12 07:09:47 +0000980 }
Mike Stump1eb44332009-09-09 15:08:12 +0000981
Chris Lattner609e4c72007-12-12 18:11:49 +0000982 if (numIvars > 0)
Chris Lattner0e391052007-12-12 18:19:52 +0000983 Diag(ivars[j]->getLocation(), diag::err_inconsistant_ivar_count);
Chris Lattner609e4c72007-12-12 18:11:49 +0000984 else if (IVI != IVE)
Chris Lattner0e391052007-12-12 18:19:52 +0000985 Diag((*IVI)->getLocation(), diag::err_inconsistant_ivar_count);
Chris Lattner4d391482007-12-12 07:09:47 +0000986}
987
Steve Naroff3c2eb662008-02-10 21:38:56 +0000988void Sema::WarnUndefinedMethod(SourceLocation ImpLoc, ObjCMethodDecl *method,
Fariborz Jahanian52146832010-03-31 18:23:33 +0000989 bool &IncompleteImpl, unsigned DiagID) {
Fariborz Jahanian327126e2011-06-24 20:31:37 +0000990 // No point warning no definition of method which is 'unavailable'.
991 if (method->hasAttr<UnavailableAttr>())
992 return;
Steve Naroff3c2eb662008-02-10 21:38:56 +0000993 if (!IncompleteImpl) {
994 Diag(ImpLoc, diag::warn_incomplete_impl);
995 IncompleteImpl = true;
996 }
Fariborz Jahanian61c8d3e2010-10-29 23:20:05 +0000997 if (DiagID == diag::warn_unimplemented_protocol_method)
998 Diag(ImpLoc, DiagID) << method->getDeclName();
999 else
1000 Diag(method->getLocation(), DiagID) << method->getDeclName();
Steve Naroff3c2eb662008-02-10 21:38:56 +00001001}
1002
David Chisnalle8a2d4c2010-10-25 17:23:52 +00001003/// Determines if type B can be substituted for type A. Returns true if we can
1004/// guarantee that anything that the user will do to an object of type A can
1005/// also be done to an object of type B. This is trivially true if the two
1006/// types are the same, or if B is a subclass of A. It becomes more complex
1007/// in cases where protocols are involved.
1008///
1009/// Object types in Objective-C describe the minimum requirements for an
1010/// object, rather than providing a complete description of a type. For
1011/// example, if A is a subclass of B, then B* may refer to an instance of A.
1012/// The principle of substitutability means that we may use an instance of A
1013/// anywhere that we may use an instance of B - it will implement all of the
1014/// ivars of B and all of the methods of B.
1015///
1016/// This substitutability is important when type checking methods, because
1017/// the implementation may have stricter type definitions than the interface.
1018/// The interface specifies minimum requirements, but the implementation may
1019/// have more accurate ones. For example, a method may privately accept
1020/// instances of B, but only publish that it accepts instances of A. Any
1021/// object passed to it will be type checked against B, and so will implicitly
1022/// by a valid A*. Similarly, a method may return a subclass of the class that
1023/// it is declared as returning.
1024///
1025/// This is most important when considering subclassing. A method in a
1026/// subclass must accept any object as an argument that its superclass's
1027/// implementation accepts. It may, however, accept a more general type
1028/// without breaking substitutability (i.e. you can still use the subclass
1029/// anywhere that you can use the superclass, but not vice versa). The
1030/// converse requirement applies to return types: the return type for a
1031/// subclass method must be a valid object of the kind that the superclass
1032/// advertises, but it may be specified more accurately. This avoids the need
1033/// for explicit down-casting by callers.
1034///
1035/// Note: This is a stricter requirement than for assignment.
John McCall10302c02010-10-28 02:34:38 +00001036static bool isObjCTypeSubstitutable(ASTContext &Context,
1037 const ObjCObjectPointerType *A,
1038 const ObjCObjectPointerType *B,
1039 bool rejectId) {
1040 // Reject a protocol-unqualified id.
1041 if (rejectId && B->isObjCIdType()) return false;
David Chisnalle8a2d4c2010-10-25 17:23:52 +00001042
1043 // If B is a qualified id, then A must also be a qualified id and it must
1044 // implement all of the protocols in B. It may not be a qualified class.
1045 // For example, MyClass<A> can be assigned to id<A>, but MyClass<A> is a
1046 // stricter definition so it is not substitutable for id<A>.
1047 if (B->isObjCQualifiedIdType()) {
1048 return A->isObjCQualifiedIdType() &&
John McCall10302c02010-10-28 02:34:38 +00001049 Context.ObjCQualifiedIdTypesAreCompatible(QualType(A, 0),
1050 QualType(B,0),
1051 false);
David Chisnalle8a2d4c2010-10-25 17:23:52 +00001052 }
1053
1054 /*
1055 // id is a special type that bypasses type checking completely. We want a
1056 // warning when it is used in one place but not another.
1057 if (C.isObjCIdType(A) || C.isObjCIdType(B)) return false;
1058
1059
1060 // If B is a qualified id, then A must also be a qualified id (which it isn't
1061 // if we've got this far)
1062 if (B->isObjCQualifiedIdType()) return false;
1063 */
1064
1065 // Now we know that A and B are (potentially-qualified) class types. The
1066 // normal rules for assignment apply.
John McCall10302c02010-10-28 02:34:38 +00001067 return Context.canAssignObjCInterfaces(A, B);
David Chisnalle8a2d4c2010-10-25 17:23:52 +00001068}
1069
John McCall10302c02010-10-28 02:34:38 +00001070static SourceRange getTypeRange(TypeSourceInfo *TSI) {
1071 return (TSI ? TSI->getTypeLoc().getSourceRange() : SourceRange());
1072}
1073
Fariborz Jahanianfefe91e2011-07-28 23:19:50 +00001074static bool CheckMethodOverrideReturn(Sema &S,
John McCall10302c02010-10-28 02:34:38 +00001075 ObjCMethodDecl *MethodImpl,
Fariborz Jahanian21761c82011-02-21 23:49:15 +00001076 ObjCMethodDecl *MethodDecl,
Fariborz Jahanianeee3ef12011-07-24 20:53:26 +00001077 bool IsProtocolMethodDecl,
Fariborz Jahanianfefe91e2011-07-28 23:19:50 +00001078 bool IsDeclaration,
1079 bool Warn) {
Fariborz Jahanian21761c82011-02-21 23:49:15 +00001080 if (IsProtocolMethodDecl &&
1081 (MethodDecl->getObjCDeclQualifier() !=
1082 MethodImpl->getObjCDeclQualifier())) {
Fariborz Jahanianfefe91e2011-07-28 23:19:50 +00001083 if (Warn) {
1084 S.Diag(MethodImpl->getLocation(),
1085 diag::warn_conflicting_ret_type_modifiers)
1086 << MethodImpl->getDeclName() << IsDeclaration
1087 << getTypeRange(MethodImpl->getResultTypeSourceInfo());
1088 S.Diag(MethodDecl->getLocation(), diag::note_previous_declaration)
1089 << getTypeRange(MethodDecl->getResultTypeSourceInfo());
1090 }
1091 else
1092 return false;
Fariborz Jahanian21761c82011-02-21 23:49:15 +00001093 }
1094
John McCall10302c02010-10-28 02:34:38 +00001095 if (S.Context.hasSameUnqualifiedType(MethodImpl->getResultType(),
Fariborz Jahanian21761c82011-02-21 23:49:15 +00001096 MethodDecl->getResultType()))
Fariborz Jahanianfefe91e2011-07-28 23:19:50 +00001097 return true;
1098 if (!Warn)
1099 return false;
John McCall10302c02010-10-28 02:34:38 +00001100
1101 unsigned DiagID = diag::warn_conflicting_ret_types;
1102
1103 // Mismatches between ObjC pointers go into a different warning
1104 // category, and sometimes they're even completely whitelisted.
1105 if (const ObjCObjectPointerType *ImplPtrTy =
1106 MethodImpl->getResultType()->getAs<ObjCObjectPointerType>()) {
1107 if (const ObjCObjectPointerType *IfacePtrTy =
Fariborz Jahanian21761c82011-02-21 23:49:15 +00001108 MethodDecl->getResultType()->getAs<ObjCObjectPointerType>()) {
John McCall10302c02010-10-28 02:34:38 +00001109 // Allow non-matching return types as long as they don't violate
1110 // the principle of substitutability. Specifically, we permit
1111 // return types that are subclasses of the declared return type,
1112 // or that are more-qualified versions of the declared type.
1113 if (isObjCTypeSubstitutable(S.Context, IfacePtrTy, ImplPtrTy, false))
Fariborz Jahanianfefe91e2011-07-28 23:19:50 +00001114 return false;
John McCall10302c02010-10-28 02:34:38 +00001115
1116 DiagID = diag::warn_non_covariant_ret_types;
1117 }
1118 }
1119
1120 S.Diag(MethodImpl->getLocation(), DiagID)
1121 << MethodImpl->getDeclName()
Fariborz Jahanian21761c82011-02-21 23:49:15 +00001122 << MethodDecl->getResultType()
John McCall10302c02010-10-28 02:34:38 +00001123 << MethodImpl->getResultType()
Fariborz Jahanianeee3ef12011-07-24 20:53:26 +00001124 << IsDeclaration
John McCall10302c02010-10-28 02:34:38 +00001125 << getTypeRange(MethodImpl->getResultTypeSourceInfo());
Fariborz Jahanian21761c82011-02-21 23:49:15 +00001126 S.Diag(MethodDecl->getLocation(), diag::note_previous_definition)
1127 << getTypeRange(MethodDecl->getResultTypeSourceInfo());
Fariborz Jahanianfefe91e2011-07-28 23:19:50 +00001128 return false;
John McCall10302c02010-10-28 02:34:38 +00001129}
1130
Fariborz Jahanianfefe91e2011-07-28 23:19:50 +00001131static bool CheckMethodOverrideParam(Sema &S,
John McCall10302c02010-10-28 02:34:38 +00001132 ObjCMethodDecl *MethodImpl,
Fariborz Jahanian21761c82011-02-21 23:49:15 +00001133 ObjCMethodDecl *MethodDecl,
John McCall10302c02010-10-28 02:34:38 +00001134 ParmVarDecl *ImplVar,
Fariborz Jahanian21761c82011-02-21 23:49:15 +00001135 ParmVarDecl *IfaceVar,
Fariborz Jahanianeee3ef12011-07-24 20:53:26 +00001136 bool IsProtocolMethodDecl,
Fariborz Jahanianfefe91e2011-07-28 23:19:50 +00001137 bool IsDeclaration,
1138 bool Warn) {
Fariborz Jahanian21761c82011-02-21 23:49:15 +00001139 if (IsProtocolMethodDecl &&
1140 (ImplVar->getObjCDeclQualifier() !=
1141 IfaceVar->getObjCDeclQualifier())) {
Fariborz Jahanianfefe91e2011-07-28 23:19:50 +00001142 if (Warn) {
1143 S.Diag(ImplVar->getLocation(),
1144 diag::warn_conflicting_param_modifiers)
1145 << getTypeRange(ImplVar->getTypeSourceInfo())
1146 << MethodImpl->getDeclName() << IsDeclaration;
1147 S.Diag(IfaceVar->getLocation(), diag::note_previous_declaration)
1148 << getTypeRange(IfaceVar->getTypeSourceInfo());
1149 }
1150 else
1151 return false;
Fariborz Jahanian21761c82011-02-21 23:49:15 +00001152 }
1153
John McCall10302c02010-10-28 02:34:38 +00001154 QualType ImplTy = ImplVar->getType();
1155 QualType IfaceTy = IfaceVar->getType();
Fariborz Jahanian21761c82011-02-21 23:49:15 +00001156
John McCall10302c02010-10-28 02:34:38 +00001157 if (S.Context.hasSameUnqualifiedType(ImplTy, IfaceTy))
Fariborz Jahanianfefe91e2011-07-28 23:19:50 +00001158 return true;
1159
1160 if (!Warn)
1161 return false;
John McCall10302c02010-10-28 02:34:38 +00001162 unsigned DiagID = diag::warn_conflicting_param_types;
1163
1164 // Mismatches between ObjC pointers go into a different warning
1165 // category, and sometimes they're even completely whitelisted.
1166 if (const ObjCObjectPointerType *ImplPtrTy =
1167 ImplTy->getAs<ObjCObjectPointerType>()) {
1168 if (const ObjCObjectPointerType *IfacePtrTy =
1169 IfaceTy->getAs<ObjCObjectPointerType>()) {
1170 // Allow non-matching argument types as long as they don't
1171 // violate the principle of substitutability. Specifically, the
1172 // implementation must accept any objects that the superclass
1173 // accepts, however it may also accept others.
1174 if (isObjCTypeSubstitutable(S.Context, ImplPtrTy, IfacePtrTy, true))
Fariborz Jahanianfefe91e2011-07-28 23:19:50 +00001175 return false;
John McCall10302c02010-10-28 02:34:38 +00001176
1177 DiagID = diag::warn_non_contravariant_param_types;
1178 }
1179 }
1180
1181 S.Diag(ImplVar->getLocation(), DiagID)
1182 << getTypeRange(ImplVar->getTypeSourceInfo())
Fariborz Jahanianeee3ef12011-07-24 20:53:26 +00001183 << MethodImpl->getDeclName() << IfaceTy << ImplTy
1184 << IsDeclaration;
John McCall10302c02010-10-28 02:34:38 +00001185 S.Diag(IfaceVar->getLocation(), diag::note_previous_definition)
1186 << getTypeRange(IfaceVar->getTypeSourceInfo());
Fariborz Jahanianfefe91e2011-07-28 23:19:50 +00001187 return false;
John McCall10302c02010-10-28 02:34:38 +00001188}
John McCallf85e1932011-06-15 23:02:42 +00001189
1190/// In ARC, check whether the conventional meanings of the two methods
1191/// match. If they don't, it's a hard error.
1192static bool checkMethodFamilyMismatch(Sema &S, ObjCMethodDecl *impl,
1193 ObjCMethodDecl *decl) {
1194 ObjCMethodFamily implFamily = impl->getMethodFamily();
1195 ObjCMethodFamily declFamily = decl->getMethodFamily();
1196 if (implFamily == declFamily) return false;
1197
1198 // Since conventions are sorted by selector, the only possibility is
1199 // that the types differ enough to cause one selector or the other
1200 // to fall out of the family.
1201 assert(implFamily == OMF_None || declFamily == OMF_None);
1202
1203 // No further diagnostics required on invalid declarations.
1204 if (impl->isInvalidDecl() || decl->isInvalidDecl()) return true;
1205
1206 const ObjCMethodDecl *unmatched = impl;
1207 ObjCMethodFamily family = declFamily;
1208 unsigned errorID = diag::err_arc_lost_method_convention;
1209 unsigned noteID = diag::note_arc_lost_method_convention;
1210 if (declFamily == OMF_None) {
1211 unmatched = decl;
1212 family = implFamily;
1213 errorID = diag::err_arc_gained_method_convention;
1214 noteID = diag::note_arc_gained_method_convention;
1215 }
1216
1217 // Indexes into a %select clause in the diagnostic.
1218 enum FamilySelector {
1219 F_alloc, F_copy, F_mutableCopy = F_copy, F_init, F_new
1220 };
1221 FamilySelector familySelector = FamilySelector();
1222
1223 switch (family) {
1224 case OMF_None: llvm_unreachable("logic error, no method convention");
1225 case OMF_retain:
1226 case OMF_release:
1227 case OMF_autorelease:
1228 case OMF_dealloc:
1229 case OMF_retainCount:
1230 case OMF_self:
Fariborz Jahanian9670e172011-07-05 22:38:59 +00001231 case OMF_performSelector:
John McCallf85e1932011-06-15 23:02:42 +00001232 // Mismatches for these methods don't change ownership
1233 // conventions, so we don't care.
1234 return false;
1235
1236 case OMF_init: familySelector = F_init; break;
1237 case OMF_alloc: familySelector = F_alloc; break;
1238 case OMF_copy: familySelector = F_copy; break;
1239 case OMF_mutableCopy: familySelector = F_mutableCopy; break;
1240 case OMF_new: familySelector = F_new; break;
1241 }
1242
1243 enum ReasonSelector { R_NonObjectReturn, R_UnrelatedReturn };
1244 ReasonSelector reasonSelector;
1245
1246 // The only reason these methods don't fall within their families is
1247 // due to unusual result types.
1248 if (unmatched->getResultType()->isObjCObjectPointerType()) {
1249 reasonSelector = R_UnrelatedReturn;
1250 } else {
1251 reasonSelector = R_NonObjectReturn;
1252 }
1253
1254 S.Diag(impl->getLocation(), errorID) << familySelector << reasonSelector;
1255 S.Diag(decl->getLocation(), noteID) << familySelector << reasonSelector;
1256
1257 return true;
1258}
John McCall10302c02010-10-28 02:34:38 +00001259
Fariborz Jahanian8daab972008-12-05 18:18:52 +00001260void Sema::WarnConflictingTypedMethods(ObjCMethodDecl *ImpMethodDecl,
Fariborz Jahanian21761c82011-02-21 23:49:15 +00001261 ObjCMethodDecl *MethodDecl,
Fariborz Jahanianeee3ef12011-07-24 20:53:26 +00001262 bool IsProtocolMethodDecl,
1263 bool IsDeclaration) {
John McCallf85e1932011-06-15 23:02:42 +00001264 if (getLangOptions().ObjCAutoRefCount &&
1265 checkMethodFamilyMismatch(*this, ImpMethodDecl, MethodDecl))
1266 return;
1267
Fariborz Jahanian21761c82011-02-21 23:49:15 +00001268 CheckMethodOverrideReturn(*this, ImpMethodDecl, MethodDecl,
Fariborz Jahanianfefe91e2011-07-28 23:19:50 +00001269 IsProtocolMethodDecl, IsDeclaration, true);
Mike Stump1eb44332009-09-09 15:08:12 +00001270
Chris Lattner3aff9192009-04-11 19:58:42 +00001271 for (ObjCMethodDecl::param_iterator IM = ImpMethodDecl->param_begin(),
Fariborz Jahanian21761c82011-02-21 23:49:15 +00001272 IF = MethodDecl->param_begin(), EM = ImpMethodDecl->param_end();
John McCall10302c02010-10-28 02:34:38 +00001273 IM != EM; ++IM, ++IF)
Fariborz Jahanian21761c82011-02-21 23:49:15 +00001274 CheckMethodOverrideParam(*this, ImpMethodDecl, MethodDecl, *IM, *IF,
Fariborz Jahanianfefe91e2011-07-28 23:19:50 +00001275 IsProtocolMethodDecl, IsDeclaration, true);
Mike Stump1eb44332009-09-09 15:08:12 +00001276
Fariborz Jahanian21761c82011-02-21 23:49:15 +00001277 if (ImpMethodDecl->isVariadic() != MethodDecl->isVariadic()) {
Fariborz Jahanianeee3ef12011-07-24 20:53:26 +00001278 Diag(ImpMethodDecl->getLocation(), diag::warn_conflicting_variadic)
1279 << IsDeclaration;
Fariborz Jahanian21761c82011-02-21 23:49:15 +00001280 Diag(MethodDecl->getLocation(), diag::note_previous_declaration);
Fariborz Jahanian561da7e2010-05-21 23:28:58 +00001281 }
Fariborz Jahanian8daab972008-12-05 18:18:52 +00001282}
1283
Fariborz Jahanian21121902011-08-08 18:03:17 +00001284/// WarnOnMismatchedProtocolMethods - Issues warning on type mismatched
1285/// protocols methods and then returns true(matched), or false(mismatched).
1286bool Sema::WarnOnMismatchedProtocolMethods(ObjCMethodDecl *ImpMethodDecl,
1287 ObjCMethodDecl *MethodDecl) {
1288
1289 bool match = CheckMethodOverrideReturn(*this, ImpMethodDecl, MethodDecl,
1290 true,
1291 true, true);
1292 if (!match)
1293 return false;
1294
1295 for (ObjCMethodDecl::param_iterator IM = ImpMethodDecl->param_begin(),
1296 IF = MethodDecl->param_begin(), EM = ImpMethodDecl->param_end();
1297 IM != EM; ++IM, ++IF) {
1298 match = CheckMethodOverrideParam(*this, ImpMethodDecl, MethodDecl, *IM, *IF,
1299 true, true, true);
1300 if (!match)
1301 return false;
1302 }
1303
1304 if (ImpMethodDecl->isVariadic() != MethodDecl->isVariadic()) {
1305 Diag(ImpMethodDecl->getLocation(), diag::warn_conflicting_variadic)
1306 << true;
1307 Diag(MethodDecl->getLocation(), diag::note_previous_declaration);
1308 return false;
1309 }
1310 return true;
1311}
1312
Fariborz Jahanianfefe91e2011-07-28 23:19:50 +00001313/// WarnExactTypedMethods - This routine issues a warning if method
1314/// implementation declaration matches exactly that of its declaration.
1315void Sema::WarnExactTypedMethods(ObjCMethodDecl *ImpMethodDecl,
1316 ObjCMethodDecl *MethodDecl,
1317 bool IsProtocolMethodDecl) {
1318 // don't issue warning when protocol method is optional because primary
1319 // class is not required to implement it and it is safe for protocol
1320 // to implement it.
1321 if (MethodDecl->getImplementationControl() == ObjCMethodDecl::Optional)
1322 return;
1323 // don't issue warning when primary class's method is
1324 // depecated/unavailable.
1325 if (MethodDecl->hasAttr<UnavailableAttr>() ||
1326 MethodDecl->hasAttr<DeprecatedAttr>())
1327 return;
1328
1329 bool match = CheckMethodOverrideReturn(*this, ImpMethodDecl, MethodDecl,
1330 IsProtocolMethodDecl, false, false);
1331 if (match)
1332 for (ObjCMethodDecl::param_iterator IM = ImpMethodDecl->param_begin(),
1333 IF = MethodDecl->param_begin(), EM = ImpMethodDecl->param_end();
1334 IM != EM; ++IM, ++IF) {
1335 match = CheckMethodOverrideParam(*this, ImpMethodDecl, MethodDecl,
1336 *IM, *IF,
1337 IsProtocolMethodDecl, false, false);
1338 if (!match)
1339 break;
1340 }
1341 if (match)
1342 match = (ImpMethodDecl->isVariadic() == MethodDecl->isVariadic());
David Chisnall7ca13ef2011-08-08 17:32:19 +00001343 if (match)
1344 match = !(MethodDecl->isClassMethod() &&
1345 MethodDecl->getSelector() == GetNullarySelector("load", Context));
Fariborz Jahanianfefe91e2011-07-28 23:19:50 +00001346
1347 if (match) {
1348 Diag(ImpMethodDecl->getLocation(),
1349 diag::warn_category_method_impl_match);
1350 Diag(MethodDecl->getLocation(), diag::note_method_declared_at);
1351 }
1352}
1353
Mike Stump390b4cc2009-05-16 07:39:55 +00001354/// FIXME: Type hierarchies in Objective-C can be deep. We could most likely
1355/// improve the efficiency of selector lookups and type checking by associating
1356/// with each protocol / interface / category the flattened instance tables. If
1357/// we used an immutable set to keep the table then it wouldn't add significant
1358/// memory cost and it would be handy for lookups.
Daniel Dunbarb20ef3e2008-08-27 05:40:03 +00001359
Steve Naroffefe7f362008-02-08 22:06:17 +00001360/// CheckProtocolMethodDefs - This routine checks unimplemented methods
Chris Lattner4d391482007-12-12 07:09:47 +00001361/// Declared in protocol, and those referenced by it.
Steve Naroffefe7f362008-02-08 22:06:17 +00001362void Sema::CheckProtocolMethodDefs(SourceLocation ImpLoc,
1363 ObjCProtocolDecl *PDecl,
Chris Lattner4d391482007-12-12 07:09:47 +00001364 bool& IncompleteImpl,
Steve Naroffefe7f362008-02-08 22:06:17 +00001365 const llvm::DenseSet<Selector> &InsMap,
Daniel Dunbar7ad1b1f2008-09-04 20:01:15 +00001366 const llvm::DenseSet<Selector> &ClsMap,
Fariborz Jahanianf2838592010-03-27 21:10:05 +00001367 ObjCContainerDecl *CDecl) {
1368 ObjCInterfaceDecl *IDecl;
1369 if (ObjCCategoryDecl *C = dyn_cast<ObjCCategoryDecl>(CDecl))
1370 IDecl = C->getClassInterface();
1371 else
1372 IDecl = dyn_cast<ObjCInterfaceDecl>(CDecl);
1373 assert (IDecl && "CheckProtocolMethodDefs - IDecl is null");
1374
Daniel Dunbar7ad1b1f2008-09-04 20:01:15 +00001375 ObjCInterfaceDecl *Super = IDecl->getSuperClass();
Fariborz Jahaniancd187622009-05-22 17:12:32 +00001376 ObjCInterfaceDecl *NSIDecl = 0;
1377 if (getLangOptions().NeXTRuntime) {
Mike Stump1eb44332009-09-09 15:08:12 +00001378 // check to see if class implements forwardInvocation method and objects
1379 // of this class are derived from 'NSProxy' so that to forward requests
Fariborz Jahaniancd187622009-05-22 17:12:32 +00001380 // from one object to another.
Mike Stump1eb44332009-09-09 15:08:12 +00001381 // Under such conditions, which means that every method possible is
1382 // implemented in the class, we should not issue "Method definition not
Fariborz Jahaniancd187622009-05-22 17:12:32 +00001383 // found" warnings.
1384 // FIXME: Use a general GetUnarySelector method for this.
1385 IdentifierInfo* II = &Context.Idents.get("forwardInvocation");
1386 Selector fISelector = Context.Selectors.getSelector(1, &II);
1387 if (InsMap.count(fISelector))
1388 // Is IDecl derived from 'NSProxy'? If so, no instance methods
1389 // need be implemented in the implementation.
1390 NSIDecl = IDecl->lookupInheritedClass(&Context.Idents.get("NSProxy"));
1391 }
Mike Stump1eb44332009-09-09 15:08:12 +00001392
Daniel Dunbar7ad1b1f2008-09-04 20:01:15 +00001393 // If a method lookup fails locally we still need to look and see if
1394 // the method was implemented by a base class or an inherited
1395 // protocol. This lookup is slow, but occurs rarely in correct code
1396 // and otherwise would terminate in a warning.
1397
Chris Lattner4d391482007-12-12 07:09:47 +00001398 // check unimplemented instance methods.
Fariborz Jahaniancd187622009-05-22 17:12:32 +00001399 if (!NSIDecl)
Mike Stump1eb44332009-09-09 15:08:12 +00001400 for (ObjCProtocolDecl::instmeth_iterator I = PDecl->instmeth_begin(),
Argyrios Kyrtzidis17945a02009-06-30 02:36:12 +00001401 E = PDecl->instmeth_end(); I != E; ++I) {
Fariborz Jahaniancd187622009-05-22 17:12:32 +00001402 ObjCMethodDecl *method = *I;
Mike Stump1eb44332009-09-09 15:08:12 +00001403 if (method->getImplementationControl() != ObjCMethodDecl::Optional &&
Fariborz Jahaniancd187622009-05-22 17:12:32 +00001404 !method->isSynthesized() && !InsMap.count(method->getSelector()) &&
Mike Stump1eb44332009-09-09 15:08:12 +00001405 (!Super ||
Argyrios Kyrtzidis17945a02009-06-30 02:36:12 +00001406 !Super->lookupInstanceMethod(method->getSelector()))) {
Fariborz Jahaniancd187622009-05-22 17:12:32 +00001407 // Ugly, but necessary. Method declared in protcol might have
1408 // have been synthesized due to a property declared in the class which
1409 // uses the protocol.
Mike Stump1eb44332009-09-09 15:08:12 +00001410 ObjCMethodDecl *MethodInClass =
Argyrios Kyrtzidis17945a02009-06-30 02:36:12 +00001411 IDecl->lookupInstanceMethod(method->getSelector());
Fariborz Jahanian8822f7c2010-03-27 19:02:17 +00001412 if (!MethodInClass || !MethodInClass->isSynthesized()) {
Fariborz Jahanian52146832010-03-31 18:23:33 +00001413 unsigned DIAG = diag::warn_unimplemented_protocol_method;
Argyrios Kyrtzidis08274082010-12-15 18:44:22 +00001414 if (Diags.getDiagnosticLevel(DIAG, ImpLoc)
1415 != Diagnostic::Ignored) {
Fariborz Jahanian52146832010-03-31 18:23:33 +00001416 WarnUndefinedMethod(ImpLoc, method, IncompleteImpl, DIAG);
Fariborz Jahanian61c8d3e2010-10-29 23:20:05 +00001417 Diag(method->getLocation(), diag::note_method_declared_at);
Fariborz Jahanian52146832010-03-31 18:23:33 +00001418 Diag(CDecl->getLocation(), diag::note_required_for_protocol_at)
1419 << PDecl->getDeclName();
1420 }
Fariborz Jahanian8822f7c2010-03-27 19:02:17 +00001421 }
Fariborz Jahaniancd187622009-05-22 17:12:32 +00001422 }
1423 }
Chris Lattner4d391482007-12-12 07:09:47 +00001424 // check unimplemented class methods
Mike Stump1eb44332009-09-09 15:08:12 +00001425 for (ObjCProtocolDecl::classmeth_iterator
Argyrios Kyrtzidis17945a02009-06-30 02:36:12 +00001426 I = PDecl->classmeth_begin(), E = PDecl->classmeth_end();
Douglas Gregor6ab35242009-04-09 21:40:53 +00001427 I != E; ++I) {
Ted Kremeneka526c5c2008-01-07 19:49:32 +00001428 ObjCMethodDecl *method = *I;
Daniel Dunbar7ad1b1f2008-09-04 20:01:15 +00001429 if (method->getImplementationControl() != ObjCMethodDecl::Optional &&
1430 !ClsMap.count(method->getSelector()) &&
Fariborz Jahanian8822f7c2010-03-27 19:02:17 +00001431 (!Super || !Super->lookupClassMethod(method->getSelector()))) {
Fariborz Jahanian52146832010-03-31 18:23:33 +00001432 unsigned DIAG = diag::warn_unimplemented_protocol_method;
Argyrios Kyrtzidis08274082010-12-15 18:44:22 +00001433 if (Diags.getDiagnosticLevel(DIAG, ImpLoc) != Diagnostic::Ignored) {
Fariborz Jahanian52146832010-03-31 18:23:33 +00001434 WarnUndefinedMethod(ImpLoc, method, IncompleteImpl, DIAG);
Fariborz Jahanian61c8d3e2010-10-29 23:20:05 +00001435 Diag(method->getLocation(), diag::note_method_declared_at);
Fariborz Jahanian52146832010-03-31 18:23:33 +00001436 Diag(IDecl->getLocation(), diag::note_required_for_protocol_at) <<
1437 PDecl->getDeclName();
1438 }
Fariborz Jahanian8822f7c2010-03-27 19:02:17 +00001439 }
Steve Naroff58dbdeb2007-12-14 23:37:57 +00001440 }
Chris Lattner780f3292008-07-21 21:32:27 +00001441 // Check on this protocols's referenced protocols, recursively.
1442 for (ObjCProtocolDecl::protocol_iterator PI = PDecl->protocol_begin(),
1443 E = PDecl->protocol_end(); PI != E; ++PI)
Daniel Dunbar7ad1b1f2008-09-04 20:01:15 +00001444 CheckProtocolMethodDefs(ImpLoc, *PI, IncompleteImpl, InsMap, ClsMap, IDecl);
Chris Lattner4d391482007-12-12 07:09:47 +00001445}
1446
Fariborz Jahanian1e159bc2011-07-16 00:08:33 +00001447/// MatchAllMethodDeclarations - Check methods declared in interface
Fariborz Jahanianb33f3ad2009-05-01 20:07:12 +00001448/// or protocol against those declared in their implementations.
1449///
1450void Sema::MatchAllMethodDeclarations(const llvm::DenseSet<Selector> &InsMap,
1451 const llvm::DenseSet<Selector> &ClsMap,
1452 llvm::DenseSet<Selector> &InsMapSeen,
1453 llvm::DenseSet<Selector> &ClsMapSeen,
1454 ObjCImplDecl* IMPDecl,
1455 ObjCContainerDecl* CDecl,
1456 bool &IncompleteImpl,
Fariborz Jahanianfefe91e2011-07-28 23:19:50 +00001457 bool ImmediateClass,
1458 bool WarnExactMatch) {
Fariborz Jahanianb33f3ad2009-05-01 20:07:12 +00001459 // Check and see if instance methods in class interface have been
1460 // implemented in the implementation class. If so, their types match.
Argyrios Kyrtzidis17945a02009-06-30 02:36:12 +00001461 for (ObjCInterfaceDecl::instmeth_iterator I = CDecl->instmeth_begin(),
1462 E = CDecl->instmeth_end(); I != E; ++I) {
Fariborz Jahanianb33f3ad2009-05-01 20:07:12 +00001463 if (InsMapSeen.count((*I)->getSelector()))
1464 continue;
1465 InsMapSeen.insert((*I)->getSelector());
Mike Stump1eb44332009-09-09 15:08:12 +00001466 if (!(*I)->isSynthesized() &&
Fariborz Jahanianb33f3ad2009-05-01 20:07:12 +00001467 !InsMap.count((*I)->getSelector())) {
1468 if (ImmediateClass)
Fariborz Jahanian52146832010-03-31 18:23:33 +00001469 WarnUndefinedMethod(IMPDecl->getLocation(), *I, IncompleteImpl,
1470 diag::note_undef_method_impl);
Fariborz Jahanianb33f3ad2009-05-01 20:07:12 +00001471 continue;
Mike Stumpac5fc7c2009-08-04 21:02:39 +00001472 } else {
Mike Stump1eb44332009-09-09 15:08:12 +00001473 ObjCMethodDecl *ImpMethodDecl =
Argyrios Kyrtzidis17945a02009-06-30 02:36:12 +00001474 IMPDecl->getInstanceMethod((*I)->getSelector());
Fariborz Jahanian21761c82011-02-21 23:49:15 +00001475 ObjCMethodDecl *MethodDecl =
Argyrios Kyrtzidis17945a02009-06-30 02:36:12 +00001476 CDecl->getInstanceMethod((*I)->getSelector());
Fariborz Jahanian21761c82011-02-21 23:49:15 +00001477 assert(MethodDecl &&
1478 "MethodDecl is null in ImplMethodsVsClassMethods");
Fariborz Jahanianb33f3ad2009-05-01 20:07:12 +00001479 // ImpMethodDecl may be null as in a @dynamic property.
Fariborz Jahanianfefe91e2011-07-28 23:19:50 +00001480 if (ImpMethodDecl) {
1481 if (!WarnExactMatch)
1482 WarnConflictingTypedMethods(ImpMethodDecl, MethodDecl,
1483 isa<ObjCProtocolDecl>(CDecl));
1484 else
1485 WarnExactTypedMethods(ImpMethodDecl, MethodDecl,
1486 isa<ObjCProtocolDecl>(CDecl));
1487 }
Fariborz Jahanianb33f3ad2009-05-01 20:07:12 +00001488 }
1489 }
Mike Stump1eb44332009-09-09 15:08:12 +00001490
Fariborz Jahanianb33f3ad2009-05-01 20:07:12 +00001491 // Check and see if class methods in class interface have been
1492 // implemented in the implementation class. If so, their types match.
Mike Stump1eb44332009-09-09 15:08:12 +00001493 for (ObjCInterfaceDecl::classmeth_iterator
Argyrios Kyrtzidis17945a02009-06-30 02:36:12 +00001494 I = CDecl->classmeth_begin(), E = CDecl->classmeth_end(); I != E; ++I) {
Fariborz Jahanianb33f3ad2009-05-01 20:07:12 +00001495 if (ClsMapSeen.count((*I)->getSelector()))
1496 continue;
1497 ClsMapSeen.insert((*I)->getSelector());
1498 if (!ClsMap.count((*I)->getSelector())) {
1499 if (ImmediateClass)
Fariborz Jahanian52146832010-03-31 18:23:33 +00001500 WarnUndefinedMethod(IMPDecl->getLocation(), *I, IncompleteImpl,
1501 diag::note_undef_method_impl);
Mike Stumpac5fc7c2009-08-04 21:02:39 +00001502 } else {
Argyrios Kyrtzidis17945a02009-06-30 02:36:12 +00001503 ObjCMethodDecl *ImpMethodDecl =
1504 IMPDecl->getClassMethod((*I)->getSelector());
Fariborz Jahanian21761c82011-02-21 23:49:15 +00001505 ObjCMethodDecl *MethodDecl =
Argyrios Kyrtzidis17945a02009-06-30 02:36:12 +00001506 CDecl->getClassMethod((*I)->getSelector());
Fariborz Jahanianfefe91e2011-07-28 23:19:50 +00001507 if (!WarnExactMatch)
1508 WarnConflictingTypedMethods(ImpMethodDecl, MethodDecl,
1509 isa<ObjCProtocolDecl>(CDecl));
1510 else
1511 WarnExactTypedMethods(ImpMethodDecl, MethodDecl,
1512 isa<ObjCProtocolDecl>(CDecl));
Fariborz Jahanianb33f3ad2009-05-01 20:07:12 +00001513 }
1514 }
Fariborz Jahanianf54e3ae2010-10-08 22:59:25 +00001515
Fariborz Jahanianb33f3ad2009-05-01 20:07:12 +00001516 if (ObjCInterfaceDecl *I = dyn_cast<ObjCInterfaceDecl> (CDecl)) {
Fariborz Jahanianf54e3ae2010-10-08 22:59:25 +00001517 // Also methods in class extensions need be looked at next.
1518 for (const ObjCCategoryDecl *ClsExtDecl = I->getFirstClassExtension();
1519 ClsExtDecl; ClsExtDecl = ClsExtDecl->getNextClassExtension())
1520 MatchAllMethodDeclarations(InsMap, ClsMap, InsMapSeen, ClsMapSeen,
1521 IMPDecl,
1522 const_cast<ObjCCategoryDecl *>(ClsExtDecl),
Fariborz Jahanianfefe91e2011-07-28 23:19:50 +00001523 IncompleteImpl, false, WarnExactMatch);
Fariborz Jahanianf54e3ae2010-10-08 22:59:25 +00001524
Fariborz Jahanianb33f3ad2009-05-01 20:07:12 +00001525 // Check for any implementation of a methods declared in protocol.
Ted Kremenek53b94412010-09-01 01:21:15 +00001526 for (ObjCInterfaceDecl::all_protocol_iterator
1527 PI = I->all_referenced_protocol_begin(),
1528 E = I->all_referenced_protocol_end(); PI != E; ++PI)
Mike Stump1eb44332009-09-09 15:08:12 +00001529 MatchAllMethodDeclarations(InsMap, ClsMap, InsMapSeen, ClsMapSeen,
1530 IMPDecl,
Fariborz Jahanianfefe91e2011-07-28 23:19:50 +00001531 (*PI), IncompleteImpl, false, WarnExactMatch);
Fariborz Jahanianeee3ef12011-07-24 20:53:26 +00001532
Fariborz Jahanianfefe91e2011-07-28 23:19:50 +00001533 // FIXME. For now, we are not checking for extact match of methods
1534 // in category implementation and its primary class's super class.
1535 if (!WarnExactMatch && I->getSuperClass())
Fariborz Jahanianb33f3ad2009-05-01 20:07:12 +00001536 MatchAllMethodDeclarations(InsMap, ClsMap, InsMapSeen, ClsMapSeen,
Mike Stump1eb44332009-09-09 15:08:12 +00001537 IMPDecl,
Fariborz Jahanianb33f3ad2009-05-01 20:07:12 +00001538 I->getSuperClass(), IncompleteImpl, false);
1539 }
1540}
1541
Fariborz Jahaniana56a9922011-08-03 23:44:01 +00001542/// MatchMethodsInClassAndProtocols - This routine goes thru list of methods
Fariborz Jahanian74133072011-08-03 18:21:12 +00001543/// declared in the class, and its class extensions. For each method which is
1544/// also declared in one of its qualifying protocols, they must type match or
1545/// it issues a warning.
Fariborz Jahaniana56a9922011-08-03 23:44:01 +00001546static void MatchMethodsInClassAndProtocols(Sema &S,
Fariborz Jahanianeee3ef12011-07-24 20:53:26 +00001547 const ObjCContainerDecl *IDecl,
Fariborz Jahanian74133072011-08-03 18:21:12 +00001548 Sema::ProtocolsMethodsMap &InstMethodsInProtocols,
1549 Sema::ProtocolsMethodsMap &ClsMethodsInProtocols) {
1550 for (ObjCInterfaceDecl::instmeth_iterator IM = IDecl->instmeth_begin(),
1551 E = IDecl->instmeth_end(); IM != E; ++IM) {
1552 Selector Sel = (*IM)->getSelector();
1553 if (ObjCMethodDecl *ProtoMethodDecl = InstMethodsInProtocols[Sel]) {
1554 ObjCMethodDecl *ClsMethodDecl = (*IM);
1555 S.WarnConflictingTypedMethods(ClsMethodDecl,
1556 ProtoMethodDecl, true, true);
Fariborz Jahanianeee3ef12011-07-24 20:53:26 +00001557 }
Fariborz Jahanian74133072011-08-03 18:21:12 +00001558 }
1559 for (ObjCInterfaceDecl::classmeth_iterator IM = IDecl->classmeth_begin(),
1560 E = IDecl->classmeth_end(); IM != E; ++IM) {
1561 Selector Sel = (*IM)->getSelector();
1562 if (ObjCMethodDecl *ProtoMethodDecl = ClsMethodsInProtocols[Sel]) {
1563 ObjCMethodDecl *ClsMethodDecl = (*IM);
1564 S.WarnConflictingTypedMethods(ClsMethodDecl,
1565 ProtoMethodDecl, true, true);
Fariborz Jahanianeee3ef12011-07-24 20:53:26 +00001566 }
Fariborz Jahanian74133072011-08-03 18:21:12 +00001567 }
Fariborz Jahanianeee3ef12011-07-24 20:53:26 +00001568
Fariborz Jahanian74133072011-08-03 18:21:12 +00001569 if (const ObjCInterfaceDecl *I = dyn_cast<ObjCInterfaceDecl>(IDecl)) {
1570 for (const ObjCCategoryDecl *ClsExtDecl = I->getFirstClassExtension();
1571 ClsExtDecl; ClsExtDecl = ClsExtDecl->getNextClassExtension())
Fariborz Jahaniana56a9922011-08-03 23:44:01 +00001572 MatchMethodsInClassAndProtocols(S, ClsExtDecl, InstMethodsInProtocols,
Fariborz Jahanian74133072011-08-03 18:21:12 +00001573 ClsMethodsInProtocols);
1574 }
1575}
1576
Fariborz Jahaniana56a9922011-08-03 23:44:01 +00001577/// CollectMethodsInOneProtocol - This routine collects all methods declared
1578/// in a given protocol.
1579static void CollectMethodsInOneProtocol(const ObjCProtocolDecl *PDecl,
1580 Sema::ProtocolsMethodsMap &InstMethodsInProtocols,
1581 Sema::ProtocolsMethodsMap &ClsMethodsInProtocols) {
1582 for (ObjCProtocolDecl::instmeth_iterator I = PDecl->instmeth_begin(),
1583 E = PDecl->instmeth_end(); I != E; ++I) {
1584 ObjCMethodDecl *method = *I;
1585 ObjCMethodDecl *&ProtocolEntry =
1586 InstMethodsInProtocols[method->getSelector()];
1587 if (!ProtocolEntry)
1588 ProtocolEntry = method;
1589 }
1590 for (ObjCProtocolDecl::classmeth_iterator I = PDecl->classmeth_begin(),
1591 E = PDecl->classmeth_end(); I != E; ++I) {
1592 ObjCMethodDecl *method = *I;
1593 ObjCMethodDecl *&ProtocolEntry =
1594 ClsMethodsInProtocols[method->getSelector()];
1595 if (!ProtocolEntry)
1596 ProtocolEntry = method;
1597 }
1598}
1599
Fariborz Jahanian21121902011-08-08 18:03:17 +00001600/// CollectAllMethodsInProtocols - Helper routine to collect all methods
1601/// declared in given class's immediate and nested protocols.
1602static void CollectAllMethodsInProtocols(const ObjCContainerDecl *ContDecl,
1603 Sema::MethodsInProtocols &InstMethodsInProtocols,
1604 Sema::MethodsInProtocols & ClsMethodsInProtocols) {
1605 if (const ObjCInterfaceDecl *CDecl = dyn_cast<ObjCInterfaceDecl>(ContDecl)) {
1606 for (ObjCInterfaceDecl::all_protocol_iterator
1607 PI = CDecl->all_referenced_protocol_begin(),
1608 E = CDecl->all_referenced_protocol_end(); PI != E; ++PI)
1609 CollectAllMethodsInProtocols(*PI, InstMethodsInProtocols,
1610 ClsMethodsInProtocols);
1611 }
1612
1613 if (const ObjCProtocolDecl *PDecl = dyn_cast<ObjCProtocolDecl>(ContDecl)) {
1614 for (ObjCProtocolDecl::instmeth_iterator I = PDecl->instmeth_begin(),
1615 E = PDecl->instmeth_end(); I != E; ++I) {
1616 ObjCMethodDecl *method = *I;
1617 InstMethodsInProtocols.push_back(Sema::PROTOCOL_METHODS(method->getSelector(),
1618 method));
1619 }
1620 for (ObjCProtocolDecl::classmeth_iterator I = PDecl->classmeth_begin(),
1621 E = PDecl->classmeth_end(); I != E; ++I) {
1622 ObjCMethodDecl *method = *I;
1623 ClsMethodsInProtocols.push_back(Sema::PROTOCOL_METHODS(method->getSelector(),
1624 method));
1625 }
1626
1627 for (ObjCProtocolDecl::protocol_iterator
1628 PI = PDecl->protocol_begin(),
1629 E = PDecl->protocol_end(); PI != E; ++PI)
1630 CollectAllMethodsInProtocols(*PI, InstMethodsInProtocols,
1631 ClsMethodsInProtocols);
1632 }
1633}
1634
Fariborz Jahanian74133072011-08-03 18:21:12 +00001635/// CollectMethodsInProtocols - This routine collects all methods declared
1636/// in class's list and nested qualified protocols. Instance methods and
1637/// class methods have separate containers as they have identical selectors.
1638static void CollectMethodsInProtocols(const ObjCContainerDecl *ContDecl,
1639 Sema::ProtocolsMethodsMap &InstMethodsInProtocols,
1640 Sema::ProtocolsMethodsMap &ClsMethodsInProtocols) {
1641 if (const ObjCInterfaceDecl *CDecl = dyn_cast<ObjCInterfaceDecl>(ContDecl)) {
1642 for (ObjCInterfaceDecl::all_protocol_iterator
1643 PI = CDecl->all_referenced_protocol_begin(),
1644 E = CDecl->all_referenced_protocol_end(); PI != E; ++PI) {
1645 ObjCProtocolDecl *PDecl = (*PI);
Fariborz Jahaniana56a9922011-08-03 23:44:01 +00001646 CollectMethodsInOneProtocol(PDecl, InstMethodsInProtocols,
1647 ClsMethodsInProtocols);
Fariborz Jahanian74133072011-08-03 18:21:12 +00001648
1649 for (ObjCProtocolDecl::protocol_iterator P = PDecl->protocol_begin(),
1650 PE = PDecl->protocol_end(); P != PE; ++P)
Fariborz Jahaniana56a9922011-08-03 23:44:01 +00001651 CollectMethodsInProtocols((*P), InstMethodsInProtocols,
Fariborz Jahanian74133072011-08-03 18:21:12 +00001652 ClsMethodsInProtocols);
1653 }
1654 if (CDecl->getSuperClass())
1655 CollectMethodsInProtocols(CDecl->getSuperClass(), InstMethodsInProtocols,
1656 ClsMethodsInProtocols);
1657 }
1658
Fariborz Jahaniana56a9922011-08-03 23:44:01 +00001659 if (const ObjCProtocolDecl *PDecl = dyn_cast<ObjCProtocolDecl>(ContDecl))
1660 CollectMethodsInOneProtocol(PDecl, InstMethodsInProtocols,
1661 ClsMethodsInProtocols);
Fariborz Jahanian74133072011-08-03 18:21:12 +00001662
Fariborz Jahanianeee3ef12011-07-24 20:53:26 +00001663}
1664
Fariborz Jahanianfefe91e2011-07-28 23:19:50 +00001665/// MatchMethodsInClassAndItsProtocol - Check that any redeclaration of
1666/// method in protocol in its qualified class match in their type and
1667/// issue warnings otherwise.
Fariborz Jahanian74133072011-08-03 18:21:12 +00001668void Sema::MatchMethodsInClassAndItsProtocol(const ObjCInterfaceDecl *CDecl) {
1669 ProtocolsMethodsMap InstMethodsInProtocols, ClsMethodsInProtocols;
1670 CollectMethodsInProtocols(CDecl, InstMethodsInProtocols,
1671 ClsMethodsInProtocols);
1672
1673 if (InstMethodsInProtocols.empty() && ClsMethodsInProtocols.empty())
Fariborz Jahanianeee3ef12011-07-24 20:53:26 +00001674 return;
Fariborz Jahaniana56a9922011-08-03 23:44:01 +00001675 MatchMethodsInClassAndProtocols(*this, CDecl, InstMethodsInProtocols,
Fariborz Jahanian74133072011-08-03 18:21:12 +00001676 ClsMethodsInProtocols);
Fariborz Jahanianeee3ef12011-07-24 20:53:26 +00001677}
1678
Fariborz Jahanian21121902011-08-08 18:03:17 +00001679/// MatchMethodsWithIdenticalSelectors - Helper routine to go through list
1680/// of identical selector lists and issue warning for any type mismatche
1681/// of these methods.
1682static bool MatchMethodsWithIdenticalSelectors(Sema &S,
1683 const Sema::MethodsInProtocols Methods) {
1684 bool res = true;
1685 int size = Methods.size();
1686 int i = 0;
1687 while (i < size) {
1688 int upper = i;
1689 while (upper < size &&
1690 (Methods[i].Sel == Methods[upper].Sel))
1691 upper++;
1692 if (upper > i) {
1693 int lo = i;
1694 int hi = upper - 1;
1695
1696 if (lo < hi) {
1697 Sema::IdenticalSelectorMethods SelectedMethods;
1698 for (int l = lo; l <= hi; l++) {
1699 ObjCMethodDecl *method = Methods[l].Method;
1700 Sema::IDENTICAL_SELECTOR_METHODS
1701 SelectedMethod(method->getLocation(), method);
1702 SelectedMethods.push_back(SelectedMethod);
1703 }
1704 llvm::array_pod_sort(SelectedMethods.begin(), SelectedMethods.end());
1705 lo = 0; hi = SelectedMethods.size()-1;
1706 while (lo < hi) {
1707 ObjCMethodDecl *targetMethod = SelectedMethods[lo].Method;
1708 for (int j = lo+1; j <= hi; j++) {
1709 // match two methods;
1710 ObjCMethodDecl *otherMethod = SelectedMethods[j].Method;
1711 if (!S.WarnOnMismatchedProtocolMethods(targetMethod, otherMethod))
1712 res = false;
1713 }
1714 ++lo;
1715 }
1716 }
1717 }
1718 i += upper;
1719 }
1720 return res;
1721}
1722
1723/// MatchIdenticalSelectorsInProtocols - Main routine to go through list of
1724/// class's protocols (and their protocols) and make sure that methods
1725/// type match across all protocols and issue warnings if they don't.
1726/// FIXME. This may move to static analyzer if performance is proven
1727/// prohibitive.
1728void Sema::MatchIdenticalSelectorsInProtocols(const ObjCInterfaceDecl *CDecl) {
1729 Sema::MethodsInProtocols InsMethods;
1730 Sema::MethodsInProtocols ClsMethods;
1731 CollectAllMethodsInProtocols(CDecl, InsMethods, ClsMethods);
1732
1733 bool match = true;
1734 if (!InsMethods.empty()) {
1735 llvm::array_pod_sort(InsMethods.begin(), InsMethods.end());
1736 if (!MatchMethodsWithIdenticalSelectors(*this, InsMethods))
1737 match = false;
1738 }
1739
1740 if (!ClsMethods.empty()) {
1741 llvm::array_pod_sort(ClsMethods.begin(), ClsMethods.end());
1742 if (!MatchMethodsWithIdenticalSelectors(*this, ClsMethods))
1743 match = false;
1744 }
1745 if (!match)
1746 Diag(CDecl->getLocation() ,diag::note_class_declared);
1747}
1748
1749
Fariborz Jahanianfefe91e2011-07-28 23:19:50 +00001750/// CheckCategoryVsClassMethodMatches - Checks that methods implemented in
1751/// category matches with those implemented in its primary class and
1752/// warns each time an exact match is found.
1753void Sema::CheckCategoryVsClassMethodMatches(
1754 ObjCCategoryImplDecl *CatIMPDecl) {
1755 llvm::DenseSet<Selector> InsMap, ClsMap;
1756
1757 for (ObjCImplementationDecl::instmeth_iterator
1758 I = CatIMPDecl->instmeth_begin(),
1759 E = CatIMPDecl->instmeth_end(); I!=E; ++I)
1760 InsMap.insert((*I)->getSelector());
1761
1762 for (ObjCImplementationDecl::classmeth_iterator
1763 I = CatIMPDecl->classmeth_begin(),
1764 E = CatIMPDecl->classmeth_end(); I != E; ++I)
1765 ClsMap.insert((*I)->getSelector());
1766 if (InsMap.empty() && ClsMap.empty())
1767 return;
1768
1769 // Get category's primary class.
1770 ObjCCategoryDecl *CatDecl = CatIMPDecl->getCategoryDecl();
1771 if (!CatDecl)
1772 return;
1773 ObjCInterfaceDecl *IDecl = CatDecl->getClassInterface();
1774 if (!IDecl)
1775 return;
1776 llvm::DenseSet<Selector> InsMapSeen, ClsMapSeen;
1777 bool IncompleteImpl = false;
1778 MatchAllMethodDeclarations(InsMap, ClsMap, InsMapSeen, ClsMapSeen,
1779 CatIMPDecl, IDecl,
1780 IncompleteImpl, false, true /*WarnExactMatch*/);
1781}
Fariborz Jahanianeee3ef12011-07-24 20:53:26 +00001782
Fariborz Jahanian17cb3262010-05-05 21:52:17 +00001783void Sema::ImplMethodsVsClassMethods(Scope *S, ObjCImplDecl* IMPDecl,
Mike Stump1eb44332009-09-09 15:08:12 +00001784 ObjCContainerDecl* CDecl,
Chris Lattnercddc8882009-03-01 00:56:52 +00001785 bool IncompleteImpl) {
Chris Lattner4d391482007-12-12 07:09:47 +00001786 llvm::DenseSet<Selector> InsMap;
1787 // Check and see if instance methods in class interface have been
1788 // implemented in the implementation class.
Mike Stump1eb44332009-09-09 15:08:12 +00001789 for (ObjCImplementationDecl::instmeth_iterator
Argyrios Kyrtzidis17945a02009-06-30 02:36:12 +00001790 I = IMPDecl->instmeth_begin(), E = IMPDecl->instmeth_end(); I!=E; ++I)
Chris Lattner4c525092007-12-12 17:58:05 +00001791 InsMap.insert((*I)->getSelector());
Mike Stump1eb44332009-09-09 15:08:12 +00001792
Fariborz Jahanian12bac252009-04-14 23:15:21 +00001793 // Check and see if properties declared in the interface have either 1)
1794 // an implementation or 2) there is a @synthesize/@dynamic implementation
1795 // of the property in the @implementation.
Ted Kremenekc32647d2010-12-23 21:35:43 +00001796 if (isa<ObjCInterfaceDecl>(CDecl) &&
1797 !(LangOpts.ObjCDefaultSynthProperties && LangOpts.ObjCNonFragileABI2))
Fariborz Jahanian17cb3262010-05-05 21:52:17 +00001798 DiagnoseUnimplementedProperties(S, IMPDecl, CDecl, InsMap);
Fariborz Jahanian3ac1eda2010-01-20 01:51:55 +00001799
Chris Lattner4d391482007-12-12 07:09:47 +00001800 llvm::DenseSet<Selector> ClsMap;
Mike Stump1eb44332009-09-09 15:08:12 +00001801 for (ObjCImplementationDecl::classmeth_iterator
Argyrios Kyrtzidis17945a02009-06-30 02:36:12 +00001802 I = IMPDecl->classmeth_begin(),
1803 E = IMPDecl->classmeth_end(); I != E; ++I)
Chris Lattner4c525092007-12-12 17:58:05 +00001804 ClsMap.insert((*I)->getSelector());
Mike Stump1eb44332009-09-09 15:08:12 +00001805
Fariborz Jahanianb33f3ad2009-05-01 20:07:12 +00001806 // Check for type conflict of methods declared in a class/protocol and
1807 // its implementation; if any.
1808 llvm::DenseSet<Selector> InsMapSeen, ClsMapSeen;
Mike Stump1eb44332009-09-09 15:08:12 +00001809 MatchAllMethodDeclarations(InsMap, ClsMap, InsMapSeen, ClsMapSeen,
1810 IMPDecl, CDecl,
Fariborz Jahanianb33f3ad2009-05-01 20:07:12 +00001811 IncompleteImpl, true);
Fariborz Jahanian74133072011-08-03 18:21:12 +00001812 // Check for any type mismtch of methods declared in class
1813 // and methods declared in protocol. Do this only when the class
1814 // is being implementaed.
1815 if (isa<ObjCImplementationDecl>(IMPDecl))
Fariborz Jahanian21121902011-08-08 18:03:17 +00001816 if (const ObjCInterfaceDecl *I = dyn_cast<ObjCInterfaceDecl>(CDecl)) {
1817 MatchIdenticalSelectorsInProtocols(I);
Fariborz Jahanian74133072011-08-03 18:21:12 +00001818 MatchMethodsInClassAndItsProtocol(I);
Fariborz Jahanian21121902011-08-08 18:03:17 +00001819 }
Fariborz Jahanian74133072011-08-03 18:21:12 +00001820
Fariborz Jahanianfefe91e2011-07-28 23:19:50 +00001821 // check all methods implemented in category against those declared
1822 // in its primary class.
1823 if (ObjCCategoryImplDecl *CatDecl =
1824 dyn_cast<ObjCCategoryImplDecl>(IMPDecl))
1825 CheckCategoryVsClassMethodMatches(CatDecl);
Mike Stump1eb44332009-09-09 15:08:12 +00001826
Chris Lattner4d391482007-12-12 07:09:47 +00001827 // Check the protocol list for unimplemented methods in the @implementation
1828 // class.
Fariborz Jahanianb33f3ad2009-05-01 20:07:12 +00001829 // Check and see if class methods in class interface have been
1830 // implemented in the implementation class.
Mike Stump1eb44332009-09-09 15:08:12 +00001831
Chris Lattnercddc8882009-03-01 00:56:52 +00001832 if (ObjCInterfaceDecl *I = dyn_cast<ObjCInterfaceDecl> (CDecl)) {
Ted Kremenek53b94412010-09-01 01:21:15 +00001833 for (ObjCInterfaceDecl::all_protocol_iterator
1834 PI = I->all_referenced_protocol_begin(),
1835 E = I->all_referenced_protocol_end(); PI != E; ++PI)
Mike Stump1eb44332009-09-09 15:08:12 +00001836 CheckProtocolMethodDefs(IMPDecl->getLocation(), *PI, IncompleteImpl,
Chris Lattnercddc8882009-03-01 00:56:52 +00001837 InsMap, ClsMap, I);
1838 // Check class extensions (unnamed categories)
Fariborz Jahanian80aa1cd2010-06-22 23:20:40 +00001839 for (const ObjCCategoryDecl *Categories = I->getFirstClassExtension();
1840 Categories; Categories = Categories->getNextClassExtension())
1841 ImplMethodsVsClassMethods(S, IMPDecl,
1842 const_cast<ObjCCategoryDecl*>(Categories),
1843 IncompleteImpl);
Chris Lattnercddc8882009-03-01 00:56:52 +00001844 } else if (ObjCCategoryDecl *C = dyn_cast<ObjCCategoryDecl>(CDecl)) {
Fariborz Jahanianb106fc62009-10-05 21:32:49 +00001845 // For extended class, unimplemented methods in its protocols will
1846 // be reported in the primary class.
Fariborz Jahanian25760612010-02-15 21:55:26 +00001847 if (!C->IsClassExtension()) {
Fariborz Jahanianb106fc62009-10-05 21:32:49 +00001848 for (ObjCCategoryDecl::protocol_iterator PI = C->protocol_begin(),
1849 E = C->protocol_end(); PI != E; ++PI)
1850 CheckProtocolMethodDefs(IMPDecl->getLocation(), *PI, IncompleteImpl,
Fariborz Jahanianf2838592010-03-27 21:10:05 +00001851 InsMap, ClsMap, CDecl);
Fariborz Jahanian3ad230e2010-01-20 19:36:21 +00001852 // Report unimplemented properties in the category as well.
1853 // When reporting on missing setter/getters, do not report when
1854 // setter/getter is implemented in category's primary class
1855 // implementation.
1856 if (ObjCInterfaceDecl *ID = C->getClassInterface())
1857 if (ObjCImplDecl *IMP = ID->getImplementation()) {
1858 for (ObjCImplementationDecl::instmeth_iterator
1859 I = IMP->instmeth_begin(), E = IMP->instmeth_end(); I!=E; ++I)
1860 InsMap.insert((*I)->getSelector());
1861 }
Fariborz Jahanian17cb3262010-05-05 21:52:17 +00001862 DiagnoseUnimplementedProperties(S, IMPDecl, CDecl, InsMap);
Fariborz Jahanian3ad230e2010-01-20 19:36:21 +00001863 }
Chris Lattnercddc8882009-03-01 00:56:52 +00001864 } else
1865 assert(false && "invalid ObjCContainerDecl type.");
Chris Lattner4d391482007-12-12 07:09:47 +00001866}
1867
Mike Stump1eb44332009-09-09 15:08:12 +00001868/// ActOnForwardClassDeclaration -
John McCalld226f652010-08-21 09:40:31 +00001869Decl *
Chris Lattner4d391482007-12-12 07:09:47 +00001870Sema::ActOnForwardClassDeclaration(SourceLocation AtClassLoc,
Chris Lattnerbdbde4d2009-02-16 19:25:52 +00001871 IdentifierInfo **IdentList,
Ted Kremenekc09cba62009-11-17 23:12:20 +00001872 SourceLocation *IdentLocs,
Chris Lattnerbdbde4d2009-02-16 19:25:52 +00001873 unsigned NumElts) {
Chris Lattner5f9e2722011-07-23 10:55:15 +00001874 SmallVector<ObjCInterfaceDecl*, 32> Interfaces;
Mike Stump1eb44332009-09-09 15:08:12 +00001875
Chris Lattner4d391482007-12-12 07:09:47 +00001876 for (unsigned i = 0; i != NumElts; ++i) {
1877 // Check for another declaration kind with the same name.
John McCallf36e02d2009-10-09 21:13:30 +00001878 NamedDecl *PrevDecl
Douglas Gregorc83c6872010-04-15 22:33:43 +00001879 = LookupSingleName(TUScope, IdentList[i], IdentLocs[i],
Douglas Gregorc0b39642010-04-15 23:40:53 +00001880 LookupOrdinaryName, ForRedeclaration);
Douglas Gregorf57172b2008-12-08 18:40:42 +00001881 if (PrevDecl && PrevDecl->isTemplateParameter()) {
Douglas Gregor72c3f312008-12-05 18:15:24 +00001882 // Maybe we will complain about the shadowed template parameter.
1883 DiagnoseTemplateParameterShadow(AtClassLoc, PrevDecl);
1884 // Just pretend that we didn't see the previous declaration.
1885 PrevDecl = 0;
1886 }
1887
Ted Kremeneka526c5c2008-01-07 19:49:32 +00001888 if (PrevDecl && !isa<ObjCInterfaceDecl>(PrevDecl)) {
Steve Naroffc7333882008-06-05 22:57:10 +00001889 // GCC apparently allows the following idiom:
1890 //
1891 // typedef NSObject < XCElementTogglerP > XCElementToggler;
1892 // @class XCElementToggler;
1893 //
Mike Stump1eb44332009-09-09 15:08:12 +00001894 // FIXME: Make an extension?
Richard Smith162e1c12011-04-15 14:24:37 +00001895 TypedefNameDecl *TDD = dyn_cast<TypedefNameDecl>(PrevDecl);
John McCallc12c5bb2010-05-15 11:32:37 +00001896 if (!TDD || !TDD->getUnderlyingType()->isObjCObjectType()) {
Chris Lattner3c73c412008-11-19 08:23:25 +00001897 Diag(AtClassLoc, diag::err_redefinition_different_kind) << IdentList[i];
Chris Lattner5f4a6822008-11-23 23:12:31 +00001898 Diag(PrevDecl->getLocation(), diag::note_previous_definition);
John McCallc12c5bb2010-05-15 11:32:37 +00001899 } else {
Mike Stumpac5fc7c2009-08-04 21:02:39 +00001900 // a forward class declaration matching a typedef name of a class refers
1901 // to the underlying class.
John McCallc12c5bb2010-05-15 11:32:37 +00001902 if (const ObjCObjectType *OI =
1903 TDD->getUnderlyingType()->getAs<ObjCObjectType>())
1904 PrevDecl = OI->getInterface();
Fariborz Jahaniancae27c52009-05-07 21:49:26 +00001905 }
Chris Lattner4d391482007-12-12 07:09:47 +00001906 }
Douglas Gregordeacbdc2010-08-11 12:19:30 +00001907 ObjCInterfaceDecl *IDecl = dyn_cast_or_null<ObjCInterfaceDecl>(PrevDecl);
1908 if (!IDecl) { // Not already seen? Make a forward decl.
1909 IDecl = ObjCInterfaceDecl::Create(Context, CurContext, AtClassLoc,
1910 IdentList[i], IdentLocs[i], true);
1911
1912 // Push the ObjCInterfaceDecl on the scope chain but do *not* add it to
1913 // the current DeclContext. This prevents clients that walk DeclContext
1914 // from seeing the imaginary ObjCInterfaceDecl until it is actually
1915 // declared later (if at all). We also take care to explicitly make
1916 // sure this declaration is visible for name lookup.
1917 PushOnScopeChains(IDecl, TUScope, false);
1918 CurContext->makeDeclVisibleInContext(IDecl, true);
1919 }
Chris Lattner4d391482007-12-12 07:09:47 +00001920
1921 Interfaces.push_back(IDecl);
1922 }
Mike Stump1eb44332009-09-09 15:08:12 +00001923
Ted Kremenek321c22f2009-11-18 00:28:11 +00001924 assert(Interfaces.size() == NumElts);
Douglas Gregord0434102009-01-09 00:49:46 +00001925 ObjCClassDecl *CDecl = ObjCClassDecl::Create(Context, CurContext, AtClassLoc,
Ted Kremenek321c22f2009-11-18 00:28:11 +00001926 Interfaces.data(), IdentLocs,
Anders Carlsson15281452008-11-04 16:57:32 +00001927 Interfaces.size());
Argyrios Kyrtzidis17945a02009-06-30 02:36:12 +00001928 CurContext->addDecl(CDecl);
Anders Carlsson15281452008-11-04 16:57:32 +00001929 CheckObjCDeclScope(CDecl);
John McCalld226f652010-08-21 09:40:31 +00001930 return CDecl;
Chris Lattner4d391482007-12-12 07:09:47 +00001931}
1932
John McCall0f4c4c42011-06-16 01:15:19 +00001933static bool tryMatchRecordTypes(ASTContext &Context,
1934 Sema::MethodMatchStrategy strategy,
1935 const Type *left, const Type *right);
1936
John McCallf85e1932011-06-15 23:02:42 +00001937static bool matchTypes(ASTContext &Context, Sema::MethodMatchStrategy strategy,
1938 QualType leftQT, QualType rightQT) {
1939 const Type *left =
1940 Context.getCanonicalType(leftQT).getUnqualifiedType().getTypePtr();
1941 const Type *right =
1942 Context.getCanonicalType(rightQT).getUnqualifiedType().getTypePtr();
1943
1944 if (left == right) return true;
1945
1946 // If we're doing a strict match, the types have to match exactly.
1947 if (strategy == Sema::MMS_strict) return false;
1948
1949 if (left->isIncompleteType() || right->isIncompleteType()) return false;
1950
1951 // Otherwise, use this absurdly complicated algorithm to try to
1952 // validate the basic, low-level compatibility of the two types.
1953
1954 // As a minimum, require the sizes and alignments to match.
1955 if (Context.getTypeInfo(left) != Context.getTypeInfo(right))
1956 return false;
1957
1958 // Consider all the kinds of non-dependent canonical types:
1959 // - functions and arrays aren't possible as return and parameter types
1960
1961 // - vector types of equal size can be arbitrarily mixed
1962 if (isa<VectorType>(left)) return isa<VectorType>(right);
1963 if (isa<VectorType>(right)) return false;
1964
1965 // - references should only match references of identical type
John McCall0f4c4c42011-06-16 01:15:19 +00001966 // - structs, unions, and Objective-C objects must match more-or-less
1967 // exactly
John McCallf85e1932011-06-15 23:02:42 +00001968 // - everything else should be a scalar
1969 if (!left->isScalarType() || !right->isScalarType())
John McCall0f4c4c42011-06-16 01:15:19 +00001970 return tryMatchRecordTypes(Context, strategy, left, right);
John McCallf85e1932011-06-15 23:02:42 +00001971
1972 // Make scalars agree in kind, except count bools as chars.
1973 Type::ScalarTypeKind leftSK = left->getScalarTypeKind();
1974 Type::ScalarTypeKind rightSK = right->getScalarTypeKind();
1975 if (leftSK == Type::STK_Bool) leftSK = Type::STK_Integral;
1976 if (rightSK == Type::STK_Bool) rightSK = Type::STK_Integral;
1977
1978 // Note that data member pointers and function member pointers don't
1979 // intermix because of the size differences.
1980
1981 return (leftSK == rightSK);
1982}
Chris Lattner4d391482007-12-12 07:09:47 +00001983
John McCall0f4c4c42011-06-16 01:15:19 +00001984static bool tryMatchRecordTypes(ASTContext &Context,
1985 Sema::MethodMatchStrategy strategy,
1986 const Type *lt, const Type *rt) {
1987 assert(lt && rt && lt != rt);
1988
1989 if (!isa<RecordType>(lt) || !isa<RecordType>(rt)) return false;
1990 RecordDecl *left = cast<RecordType>(lt)->getDecl();
1991 RecordDecl *right = cast<RecordType>(rt)->getDecl();
1992
1993 // Require union-hood to match.
1994 if (left->isUnion() != right->isUnion()) return false;
1995
1996 // Require an exact match if either is non-POD.
1997 if ((isa<CXXRecordDecl>(left) && !cast<CXXRecordDecl>(left)->isPOD()) ||
1998 (isa<CXXRecordDecl>(right) && !cast<CXXRecordDecl>(right)->isPOD()))
1999 return false;
2000
2001 // Require size and alignment to match.
2002 if (Context.getTypeInfo(lt) != Context.getTypeInfo(rt)) return false;
2003
2004 // Require fields to match.
2005 RecordDecl::field_iterator li = left->field_begin(), le = left->field_end();
2006 RecordDecl::field_iterator ri = right->field_begin(), re = right->field_end();
2007 for (; li != le && ri != re; ++li, ++ri) {
2008 if (!matchTypes(Context, strategy, li->getType(), ri->getType()))
2009 return false;
2010 }
2011 return (li == le && ri == re);
2012}
2013
Chris Lattner4d391482007-12-12 07:09:47 +00002014/// MatchTwoMethodDeclarations - Checks that two methods have matching type and
2015/// returns true, or false, accordingly.
2016/// TODO: Handle protocol list; such as id<p1,p2> in type comparisons
John McCallf85e1932011-06-15 23:02:42 +00002017bool Sema::MatchTwoMethodDeclarations(const ObjCMethodDecl *left,
2018 const ObjCMethodDecl *right,
2019 MethodMatchStrategy strategy) {
2020 if (!matchTypes(Context, strategy,
2021 left->getResultType(), right->getResultType()))
2022 return false;
Mike Stump1eb44332009-09-09 15:08:12 +00002023
John McCallf85e1932011-06-15 23:02:42 +00002024 if (getLangOptions().ObjCAutoRefCount &&
2025 (left->hasAttr<NSReturnsRetainedAttr>()
2026 != right->hasAttr<NSReturnsRetainedAttr>() ||
2027 left->hasAttr<NSConsumesSelfAttr>()
2028 != right->hasAttr<NSConsumesSelfAttr>()))
2029 return false;
Mike Stump1eb44332009-09-09 15:08:12 +00002030
John McCallf85e1932011-06-15 23:02:42 +00002031 ObjCMethodDecl::param_iterator
2032 li = left->param_begin(), le = left->param_end(), ri = right->param_begin();
Mike Stump1eb44332009-09-09 15:08:12 +00002033
John McCallf85e1932011-06-15 23:02:42 +00002034 for (; li != le; ++li, ++ri) {
2035 assert(ri != right->param_end() && "Param mismatch");
2036 ParmVarDecl *lparm = *li, *rparm = *ri;
2037
2038 if (!matchTypes(Context, strategy, lparm->getType(), rparm->getType()))
2039 return false;
2040
2041 if (getLangOptions().ObjCAutoRefCount &&
2042 lparm->hasAttr<NSConsumedAttr>() != rparm->hasAttr<NSConsumedAttr>())
2043 return false;
Chris Lattner4d391482007-12-12 07:09:47 +00002044 }
2045 return true;
2046}
2047
Sebastian Redldb9d2142010-08-02 23:18:59 +00002048/// \brief Read the contents of the method pool for a given selector from
2049/// external storage.
Douglas Gregorf0aaf7a2009-04-24 21:10:55 +00002050///
Sebastian Redldb9d2142010-08-02 23:18:59 +00002051/// This routine should only be called once, when the method pool has no entry
2052/// for this selector.
2053Sema::GlobalMethodPool::iterator Sema::ReadMethodPool(Selector Sel) {
Douglas Gregorf0aaf7a2009-04-24 21:10:55 +00002054 assert(ExternalSource && "We need an external AST source");
Sebastian Redldb9d2142010-08-02 23:18:59 +00002055 assert(MethodPool.find(Sel) == MethodPool.end() &&
2056 "Selector data already loaded into the method pool");
Douglas Gregorf0aaf7a2009-04-24 21:10:55 +00002057
2058 // Read the method list from the external source.
Sebastian Redldb9d2142010-08-02 23:18:59 +00002059 GlobalMethods Methods = ExternalSource->ReadMethodPool(Sel);
Mike Stump1eb44332009-09-09 15:08:12 +00002060
Sebastian Redldb9d2142010-08-02 23:18:59 +00002061 return MethodPool.insert(std::make_pair(Sel, Methods)).first;
Douglas Gregorf0aaf7a2009-04-24 21:10:55 +00002062}
2063
Sebastian Redldb9d2142010-08-02 23:18:59 +00002064void Sema::AddMethodToGlobalPool(ObjCMethodDecl *Method, bool impl,
2065 bool instance) {
2066 GlobalMethodPool::iterator Pos = MethodPool.find(Method->getSelector());
2067 if (Pos == MethodPool.end()) {
2068 if (ExternalSource)
2069 Pos = ReadMethodPool(Method->getSelector());
Douglas Gregorf0aaf7a2009-04-24 21:10:55 +00002070 else
Sebastian Redldb9d2142010-08-02 23:18:59 +00002071 Pos = MethodPool.insert(std::make_pair(Method->getSelector(),
2072 GlobalMethods())).first;
Douglas Gregorf0aaf7a2009-04-24 21:10:55 +00002073 }
Fariborz Jahanian3fe10412010-07-22 18:24:20 +00002074 Method->setDefined(impl);
Sebastian Redldb9d2142010-08-02 23:18:59 +00002075 ObjCMethodList &Entry = instance ? Pos->second.first : Pos->second.second;
Chris Lattnerb25df352009-03-04 05:16:45 +00002076 if (Entry.Method == 0) {
Chris Lattner4d391482007-12-12 07:09:47 +00002077 // Haven't seen a method with this selector name yet - add it.
Chris Lattnerb25df352009-03-04 05:16:45 +00002078 Entry.Method = Method;
2079 Entry.Next = 0;
2080 return;
Chris Lattner4d391482007-12-12 07:09:47 +00002081 }
Mike Stump1eb44332009-09-09 15:08:12 +00002082
Chris Lattnerb25df352009-03-04 05:16:45 +00002083 // We've seen a method with this name, see if we have already seen this type
2084 // signature.
John McCallf85e1932011-06-15 23:02:42 +00002085 for (ObjCMethodList *List = &Entry; List; List = List->Next) {
2086 bool match = MatchTwoMethodDeclarations(Method, List->Method);
2087
2088 if (match) {
Fariborz Jahanian8e5fc9b2010-12-21 00:44:01 +00002089 ObjCMethodDecl *PrevObjCMethod = List->Method;
2090 PrevObjCMethod->setDefined(impl);
2091 // If a method is deprecated, push it in the global pool.
2092 // This is used for better diagnostics.
Douglas Gregor0a0d2b12011-03-23 00:50:03 +00002093 if (Method->isDeprecated()) {
2094 if (!PrevObjCMethod->isDeprecated())
Fariborz Jahanian8e5fc9b2010-12-21 00:44:01 +00002095 List->Method = Method;
2096 }
2097 // If new method is unavailable, push it into global pool
2098 // unless previous one is deprecated.
Douglas Gregor0a0d2b12011-03-23 00:50:03 +00002099 if (Method->isUnavailable()) {
2100 if (PrevObjCMethod->getAvailability() < AR_Deprecated)
Fariborz Jahanian8e5fc9b2010-12-21 00:44:01 +00002101 List->Method = Method;
2102 }
Chris Lattnerb25df352009-03-04 05:16:45 +00002103 return;
Fariborz Jahanian3fe10412010-07-22 18:24:20 +00002104 }
John McCallf85e1932011-06-15 23:02:42 +00002105 }
Mike Stump1eb44332009-09-09 15:08:12 +00002106
Chris Lattnerb25df352009-03-04 05:16:45 +00002107 // We have a new signature for an existing method - add it.
2108 // This is extremely rare. Only 1% of Cocoa selectors are "overloaded".
Ted Kremenek298ed872010-02-11 00:53:01 +00002109 ObjCMethodList *Mem = BumpAlloc.Allocate<ObjCMethodList>();
2110 Entry.Next = new (Mem) ObjCMethodList(Method, Entry.Next);
Chris Lattner4d391482007-12-12 07:09:47 +00002111}
2112
John McCallf85e1932011-06-15 23:02:42 +00002113/// Determines if this is an "acceptable" loose mismatch in the global
2114/// method pool. This exists mostly as a hack to get around certain
2115/// global mismatches which we can't afford to make warnings / errors.
2116/// Really, what we want is a way to take a method out of the global
2117/// method pool.
2118static bool isAcceptableMethodMismatch(ObjCMethodDecl *chosen,
2119 ObjCMethodDecl *other) {
2120 if (!chosen->isInstanceMethod())
2121 return false;
2122
2123 Selector sel = chosen->getSelector();
2124 if (!sel.isUnarySelector() || sel.getNameForSlot(0) != "length")
2125 return false;
2126
2127 // Don't complain about mismatches for -length if the method we
2128 // chose has an integral result type.
2129 return (chosen->getResultType()->isIntegerType());
2130}
2131
Sebastian Redldb9d2142010-08-02 23:18:59 +00002132ObjCMethodDecl *Sema::LookupMethodInGlobalPool(Selector Sel, SourceRange R,
Fariborz Jahanian6b308f62010-08-09 23:27:58 +00002133 bool receiverIdOrClass,
Sebastian Redldb9d2142010-08-02 23:18:59 +00002134 bool warn, bool instance) {
2135 GlobalMethodPool::iterator Pos = MethodPool.find(Sel);
2136 if (Pos == MethodPool.end()) {
2137 if (ExternalSource)
2138 Pos = ReadMethodPool(Sel);
Douglas Gregorf0aaf7a2009-04-24 21:10:55 +00002139 else
2140 return 0;
2141 }
2142
Sebastian Redldb9d2142010-08-02 23:18:59 +00002143 ObjCMethodList &MethList = instance ? Pos->second.first : Pos->second.second;
Mike Stump1eb44332009-09-09 15:08:12 +00002144
Sebastian Redldb9d2142010-08-02 23:18:59 +00002145 if (warn && MethList.Method && MethList.Next) {
John McCallf85e1932011-06-15 23:02:42 +00002146 bool issueDiagnostic = false, issueError = false;
2147
2148 // We support a warning which complains about *any* difference in
2149 // method signature.
2150 bool strictSelectorMatch =
2151 (receiverIdOrClass && warn &&
2152 (Diags.getDiagnosticLevel(diag::warn_strict_multiple_method_decl,
2153 R.getBegin()) !=
2154 Diagnostic::Ignored));
Fariborz Jahanian6b308f62010-08-09 23:27:58 +00002155 if (strictSelectorMatch)
2156 for (ObjCMethodList *Next = MethList.Next; Next; Next = Next->Next) {
John McCallf85e1932011-06-15 23:02:42 +00002157 if (!MatchTwoMethodDeclarations(MethList.Method, Next->Method,
2158 MMS_strict)) {
2159 issueDiagnostic = true;
2160 break;
2161 }
Fariborz Jahanian6b308f62010-08-09 23:27:58 +00002162 }
2163
John McCallf85e1932011-06-15 23:02:42 +00002164 // If we didn't see any strict differences, we won't see any loose
2165 // differences. In ARC, however, we also need to check for loose
2166 // mismatches, because most of them are errors.
2167 if (!strictSelectorMatch ||
2168 (issueDiagnostic && getLangOptions().ObjCAutoRefCount))
Fariborz Jahanian6b308f62010-08-09 23:27:58 +00002169 for (ObjCMethodList *Next = MethList.Next; Next; Next = Next->Next) {
John McCallf85e1932011-06-15 23:02:42 +00002170 // This checks if the methods differ in type mismatch.
2171 if (!MatchTwoMethodDeclarations(MethList.Method, Next->Method,
2172 MMS_loose) &&
2173 !isAcceptableMethodMismatch(MethList.Method, Next->Method)) {
2174 issueDiagnostic = true;
2175 if (getLangOptions().ObjCAutoRefCount)
2176 issueError = true;
2177 break;
2178 }
Fariborz Jahanian6b308f62010-08-09 23:27:58 +00002179 }
2180
John McCallf85e1932011-06-15 23:02:42 +00002181 if (issueDiagnostic) {
2182 if (issueError)
2183 Diag(R.getBegin(), diag::err_arc_multiple_method_decl) << Sel << R;
2184 else if (strictSelectorMatch)
Fariborz Jahanian6b308f62010-08-09 23:27:58 +00002185 Diag(R.getBegin(), diag::warn_strict_multiple_method_decl) << Sel << R;
2186 else
2187 Diag(R.getBegin(), diag::warn_multiple_method_decl) << Sel << R;
John McCallf85e1932011-06-15 23:02:42 +00002188
2189 Diag(MethList.Method->getLocStart(),
2190 issueError ? diag::note_possibility : diag::note_using)
Sebastian Redldb9d2142010-08-02 23:18:59 +00002191 << MethList.Method->getSourceRange();
2192 for (ObjCMethodList *Next = MethList.Next; Next; Next = Next->Next)
2193 Diag(Next->Method->getLocStart(), diag::note_also_found)
2194 << Next->Method->getSourceRange();
2195 }
Douglas Gregorf0aaf7a2009-04-24 21:10:55 +00002196 }
2197 return MethList.Method;
2198}
2199
Fariborz Jahanian3fe10412010-07-22 18:24:20 +00002200ObjCMethodDecl *Sema::LookupImplementedMethodInGlobalPool(Selector Sel) {
Sebastian Redldb9d2142010-08-02 23:18:59 +00002201 GlobalMethodPool::iterator Pos = MethodPool.find(Sel);
2202 if (Pos == MethodPool.end())
2203 return 0;
2204
2205 GlobalMethods &Methods = Pos->second;
2206
2207 if (Methods.first.Method && Methods.first.Method->isDefined())
2208 return Methods.first.Method;
2209 if (Methods.second.Method && Methods.second.Method->isDefined())
2210 return Methods.second.Method;
Fariborz Jahanian3fe10412010-07-22 18:24:20 +00002211 return 0;
2212}
2213
Fariborz Jahaniane198f5d2009-08-04 17:01:09 +00002214/// CompareMethodParamsInBaseAndSuper - This routine compares methods with
2215/// identical selector names in current and its super classes and issues
2216/// a warning if any of their argument types are incompatible.
Fariborz Jahaniandbdec8b2009-08-04 01:07:16 +00002217void Sema::CompareMethodParamsInBaseAndSuper(Decl *ClassDecl,
2218 ObjCMethodDecl *Method,
2219 bool IsInstance) {
Fariborz Jahaniane198f5d2009-08-04 17:01:09 +00002220 ObjCInterfaceDecl *ID = dyn_cast<ObjCInterfaceDecl>(ClassDecl);
2221 if (ID == 0) return;
Mike Stump1eb44332009-09-09 15:08:12 +00002222
Fariborz Jahaniane198f5d2009-08-04 17:01:09 +00002223 while (ObjCInterfaceDecl *SD = ID->getSuperClass()) {
Mike Stump1eb44332009-09-09 15:08:12 +00002224 ObjCMethodDecl *SuperMethodDecl =
Fariborz Jahaniane198f5d2009-08-04 17:01:09 +00002225 SD->lookupMethod(Method->getSelector(), IsInstance);
2226 if (SuperMethodDecl == 0) {
Fariborz Jahaniandbdec8b2009-08-04 01:07:16 +00002227 ID = SD;
Fariborz Jahaniane198f5d2009-08-04 17:01:09 +00002228 continue;
Fariborz Jahaniandbdec8b2009-08-04 01:07:16 +00002229 }
Fariborz Jahaniane198f5d2009-08-04 17:01:09 +00002230 ObjCMethodDecl::param_iterator ParamI = Method->param_begin(),
2231 E = Method->param_end();
2232 ObjCMethodDecl::param_iterator PrevI = SuperMethodDecl->param_begin();
2233 for (; ParamI != E; ++ParamI, ++PrevI) {
2234 // Number of parameters are the same and is guaranteed by selector match.
2235 assert(PrevI != SuperMethodDecl->param_end() && "Param mismatch");
2236 QualType T1 = Context.getCanonicalType((*ParamI)->getType());
2237 QualType T2 = Context.getCanonicalType((*PrevI)->getType());
Chris Lattnerfc8f0e12011-04-15 05:22:18 +00002238 // If type of argument of method in this class does not match its
Fariborz Jahaniane198f5d2009-08-04 17:01:09 +00002239 // respective argument type in the super class method, issue warning;
2240 if (!Context.typesAreCompatible(T1, T2)) {
Mike Stump1eb44332009-09-09 15:08:12 +00002241 Diag((*ParamI)->getLocation(), diag::ext_typecheck_base_super)
Fariborz Jahaniane198f5d2009-08-04 17:01:09 +00002242 << T1 << T2;
2243 Diag(SuperMethodDecl->getLocation(), diag::note_previous_declaration);
2244 return;
2245 }
2246 }
2247 ID = SD;
2248 }
Fariborz Jahaniandbdec8b2009-08-04 01:07:16 +00002249}
2250
Fariborz Jahanianf914b972010-02-23 23:41:11 +00002251/// DiagnoseDuplicateIvars -
2252/// Check for duplicate ivars in the entire class at the start of
2253/// @implementation. This becomes necesssary because class extension can
2254/// add ivars to a class in random order which will not be known until
2255/// class's @implementation is seen.
2256void Sema::DiagnoseDuplicateIvars(ObjCInterfaceDecl *ID,
2257 ObjCInterfaceDecl *SID) {
2258 for (ObjCInterfaceDecl::ivar_iterator IVI = ID->ivar_begin(),
2259 IVE = ID->ivar_end(); IVI != IVE; ++IVI) {
2260 ObjCIvarDecl* Ivar = (*IVI);
2261 if (Ivar->isInvalidDecl())
2262 continue;
2263 if (IdentifierInfo *II = Ivar->getIdentifier()) {
2264 ObjCIvarDecl* prevIvar = SID->lookupInstanceVariable(II);
2265 if (prevIvar) {
2266 Diag(Ivar->getLocation(), diag::err_duplicate_member) << II;
2267 Diag(prevIvar->getLocation(), diag::note_previous_declaration);
2268 Ivar->setInvalidDecl();
2269 }
2270 }
2271 }
2272}
2273
Steve Naroffa56f6162007-12-18 01:30:32 +00002274// Note: For class/category implemenations, allMethods/allProperties is
2275// always null.
Fariborz Jahanian17cb3262010-05-05 21:52:17 +00002276void Sema::ActOnAtEnd(Scope *S, SourceRange AtEnd,
John McCalld226f652010-08-21 09:40:31 +00002277 Decl *ClassDecl,
2278 Decl **allMethods, unsigned allNum,
2279 Decl **allProperties, unsigned pNum,
Chris Lattner682bf922009-03-29 16:50:03 +00002280 DeclGroupPtrTy *allTUVars, unsigned tuvNum) {
Steve Naroffa56f6162007-12-18 01:30:32 +00002281 // FIXME: If we don't have a ClassDecl, we have an error. We should consider
2282 // always passing in a decl. If the decl has an error, isInvalidDecl()
Chris Lattner4d391482007-12-12 07:09:47 +00002283 // should be true.
2284 if (!ClassDecl)
2285 return;
Fariborz Jahanian63e963c2009-11-16 18:57:01 +00002286
Mike Stump1eb44332009-09-09 15:08:12 +00002287 bool isInterfaceDeclKind =
Chris Lattnerf8d17a52008-03-16 21:17:37 +00002288 isa<ObjCInterfaceDecl>(ClassDecl) || isa<ObjCCategoryDecl>(ClassDecl)
2289 || isa<ObjCProtocolDecl>(ClassDecl);
Ted Kremeneka526c5c2008-01-07 19:49:32 +00002290 bool checkIdenticalMethods = isa<ObjCImplementationDecl>(ClassDecl);
Steve Naroff09c47192009-01-09 15:36:25 +00002291
Ted Kremenek782f2f52010-01-07 01:20:12 +00002292 if (!isInterfaceDeclKind && AtEnd.isInvalid()) {
2293 // FIXME: This is wrong. We shouldn't be pretending that there is
2294 // an '@end' in the declaration.
2295 SourceLocation L = ClassDecl->getLocation();
2296 AtEnd.setBegin(L);
2297 AtEnd.setEnd(L);
Fariborz Jahanian64089ce2011-04-22 22:02:28 +00002298 Diag(L, diag::err_missing_atend);
Fariborz Jahanian63e963c2009-11-16 18:57:01 +00002299 }
2300
Steve Naroff0701bbb2009-01-08 17:28:14 +00002301 // FIXME: Remove these and use the ObjCContainerDecl/DeclContext.
2302 llvm::DenseMap<Selector, const ObjCMethodDecl*> InsMap;
2303 llvm::DenseMap<Selector, const ObjCMethodDecl*> ClsMap;
2304
Chris Lattner4d391482007-12-12 07:09:47 +00002305 for (unsigned i = 0; i < allNum; i++ ) {
Ted Kremeneka526c5c2008-01-07 19:49:32 +00002306 ObjCMethodDecl *Method =
John McCalld226f652010-08-21 09:40:31 +00002307 cast_or_null<ObjCMethodDecl>(allMethods[i]);
Chris Lattner4d391482007-12-12 07:09:47 +00002308
2309 if (!Method) continue; // Already issued a diagnostic.
Douglas Gregorf8d49f62009-01-09 17:18:27 +00002310 if (Method->isInstanceMethod()) {
Chris Lattner4d391482007-12-12 07:09:47 +00002311 /// Check for instance method of the same name with incompatible types
Ted Kremeneka526c5c2008-01-07 19:49:32 +00002312 const ObjCMethodDecl *&PrevMethod = InsMap[Method->getSelector()];
Mike Stump1eb44332009-09-09 15:08:12 +00002313 bool match = PrevMethod ? MatchTwoMethodDeclarations(Method, PrevMethod)
Chris Lattner4d391482007-12-12 07:09:47 +00002314 : false;
Mike Stump1eb44332009-09-09 15:08:12 +00002315 if ((isInterfaceDeclKind && PrevMethod && !match)
Eli Friedman82b4e762008-12-16 20:15:50 +00002316 || (checkIdenticalMethods && match)) {
Chris Lattner5f4a6822008-11-23 23:12:31 +00002317 Diag(Method->getLocation(), diag::err_duplicate_method_decl)
Chris Lattner077bf5e2008-11-24 03:33:13 +00002318 << Method->getDeclName();
Chris Lattner5f4a6822008-11-23 23:12:31 +00002319 Diag(PrevMethod->getLocation(), diag::note_previous_declaration);
Douglas Gregorbdb2d502010-12-21 17:34:17 +00002320 Method->setInvalidDecl();
Chris Lattner4d391482007-12-12 07:09:47 +00002321 } else {
Chris Lattner4d391482007-12-12 07:09:47 +00002322 InsMap[Method->getSelector()] = Method;
2323 /// The following allows us to typecheck messages to "id".
2324 AddInstanceMethodToGlobalPool(Method);
Mike Stump1eb44332009-09-09 15:08:12 +00002325 // verify that the instance method conforms to the same definition of
Fariborz Jahaniane198f5d2009-08-04 17:01:09 +00002326 // parent methods if it shadows one.
Fariborz Jahaniandbdec8b2009-08-04 01:07:16 +00002327 CompareMethodParamsInBaseAndSuper(ClassDecl, Method, true);
Chris Lattner4d391482007-12-12 07:09:47 +00002328 }
Mike Stumpac5fc7c2009-08-04 21:02:39 +00002329 } else {
Chris Lattner4d391482007-12-12 07:09:47 +00002330 /// Check for class method of the same name with incompatible types
Ted Kremeneka526c5c2008-01-07 19:49:32 +00002331 const ObjCMethodDecl *&PrevMethod = ClsMap[Method->getSelector()];
Mike Stump1eb44332009-09-09 15:08:12 +00002332 bool match = PrevMethod ? MatchTwoMethodDeclarations(Method, PrevMethod)
Chris Lattner4d391482007-12-12 07:09:47 +00002333 : false;
Mike Stump1eb44332009-09-09 15:08:12 +00002334 if ((isInterfaceDeclKind && PrevMethod && !match)
Eli Friedman82b4e762008-12-16 20:15:50 +00002335 || (checkIdenticalMethods && match)) {
Chris Lattner5f4a6822008-11-23 23:12:31 +00002336 Diag(Method->getLocation(), diag::err_duplicate_method_decl)
Chris Lattner077bf5e2008-11-24 03:33:13 +00002337 << Method->getDeclName();
Chris Lattner5f4a6822008-11-23 23:12:31 +00002338 Diag(PrevMethod->getLocation(), diag::note_previous_declaration);
Douglas Gregorbdb2d502010-12-21 17:34:17 +00002339 Method->setInvalidDecl();
Chris Lattner4d391482007-12-12 07:09:47 +00002340 } else {
Chris Lattner4d391482007-12-12 07:09:47 +00002341 ClsMap[Method->getSelector()] = Method;
Steve Naroffa56f6162007-12-18 01:30:32 +00002342 /// The following allows us to typecheck messages to "Class".
2343 AddFactoryMethodToGlobalPool(Method);
Mike Stump1eb44332009-09-09 15:08:12 +00002344 // verify that the class method conforms to the same definition of
Fariborz Jahaniane198f5d2009-08-04 17:01:09 +00002345 // parent methods if it shadows one.
Fariborz Jahaniandbdec8b2009-08-04 01:07:16 +00002346 CompareMethodParamsInBaseAndSuper(ClassDecl, Method, false);
Chris Lattner4d391482007-12-12 07:09:47 +00002347 }
2348 }
2349 }
Ted Kremeneka526c5c2008-01-07 19:49:32 +00002350 if (ObjCInterfaceDecl *I = dyn_cast<ObjCInterfaceDecl>(ClassDecl)) {
Mike Stump1eb44332009-09-09 15:08:12 +00002351 // Compares properties declared in this class to those of its
Fariborz Jahanian02edb982008-05-01 00:03:38 +00002352 // super class.
Fariborz Jahanianaebf0cb2008-05-02 19:17:30 +00002353 ComparePropertiesInBaseAndSuper(I);
John McCalld226f652010-08-21 09:40:31 +00002354 CompareProperties(I, I);
Steve Naroff09c47192009-01-09 15:36:25 +00002355 } else if (ObjCCategoryDecl *C = dyn_cast<ObjCCategoryDecl>(ClassDecl)) {
Fariborz Jahanian77e14bd2008-12-06 19:59:02 +00002356 // Categories are used to extend the class by declaring new methods.
Mike Stump1eb44332009-09-09 15:08:12 +00002357 // By the same token, they are also used to add new properties. No
Fariborz Jahanian77e14bd2008-12-06 19:59:02 +00002358 // need to compare the added property to those in the class.
Daniel Dunbarb20ef3e2008-08-27 05:40:03 +00002359
Fariborz Jahanian107089f2010-01-18 18:41:16 +00002360 // Compare protocol properties with those in category
John McCalld226f652010-08-21 09:40:31 +00002361 CompareProperties(C, C);
Fariborz Jahanian88f5e9b2010-12-10 23:36:33 +00002362 if (C->IsClassExtension()) {
2363 ObjCInterfaceDecl *CCPrimary = C->getClassInterface();
2364 DiagnoseClassExtensionDupMethods(C, CCPrimary);
Fariborz Jahanian88f5e9b2010-12-10 23:36:33 +00002365 }
Chris Lattner4d391482007-12-12 07:09:47 +00002366 }
Steve Naroff09c47192009-01-09 15:36:25 +00002367 if (ObjCContainerDecl *CDecl = dyn_cast<ObjCContainerDecl>(ClassDecl)) {
Fariborz Jahanian25760612010-02-15 21:55:26 +00002368 if (CDecl->getIdentifier())
2369 // ProcessPropertyDecl is responsible for diagnosing conflicts with any
2370 // user-defined setter/getter. It also synthesizes setter/getter methods
2371 // and adds them to the DeclContext and global method pools.
2372 for (ObjCContainerDecl::prop_iterator I = CDecl->prop_begin(),
2373 E = CDecl->prop_end();
2374 I != E; ++I)
2375 ProcessPropertyDecl(*I, CDecl);
Ted Kremenek782f2f52010-01-07 01:20:12 +00002376 CDecl->setAtEndRange(AtEnd);
Steve Naroff09c47192009-01-09 15:36:25 +00002377 }
2378 if (ObjCImplementationDecl *IC=dyn_cast<ObjCImplementationDecl>(ClassDecl)) {
Ted Kremenek782f2f52010-01-07 01:20:12 +00002379 IC->setAtEndRange(AtEnd);
Fariborz Jahanian7ca8b062009-11-11 22:40:11 +00002380 if (ObjCInterfaceDecl* IDecl = IC->getClassInterface()) {
Fariborz Jahanianc78f6842010-12-11 18:39:37 +00002381 // Any property declared in a class extension might have user
2382 // declared setter or getter in current class extension or one
2383 // of the other class extensions. Mark them as synthesized as
2384 // property will be synthesized when property with same name is
2385 // seen in the @implementation.
2386 for (const ObjCCategoryDecl *ClsExtDecl =
2387 IDecl->getFirstClassExtension();
2388 ClsExtDecl; ClsExtDecl = ClsExtDecl->getNextClassExtension()) {
2389 for (ObjCContainerDecl::prop_iterator I = ClsExtDecl->prop_begin(),
2390 E = ClsExtDecl->prop_end(); I != E; ++I) {
2391 ObjCPropertyDecl *Property = (*I);
2392 // Skip over properties declared @dynamic
2393 if (const ObjCPropertyImplDecl *PIDecl
2394 = IC->FindPropertyImplDecl(Property->getIdentifier()))
2395 if (PIDecl->getPropertyImplementation()
2396 == ObjCPropertyImplDecl::Dynamic)
2397 continue;
2398
2399 for (const ObjCCategoryDecl *CExtDecl =
2400 IDecl->getFirstClassExtension();
2401 CExtDecl; CExtDecl = CExtDecl->getNextClassExtension()) {
2402 if (ObjCMethodDecl *GetterMethod =
2403 CExtDecl->getInstanceMethod(Property->getGetterName()))
2404 GetterMethod->setSynthesized(true);
2405 if (!Property->isReadOnly())
2406 if (ObjCMethodDecl *SetterMethod =
2407 CExtDecl->getInstanceMethod(Property->getSetterName()))
2408 SetterMethod->setSynthesized(true);
2409 }
2410 }
2411 }
2412
Ted Kremenekc32647d2010-12-23 21:35:43 +00002413 if (LangOpts.ObjCDefaultSynthProperties &&
2414 LangOpts.ObjCNonFragileABI2)
Fariborz Jahanian509d4772010-05-14 18:35:57 +00002415 DefaultSynthesizeProperties(S, IC, IDecl);
Fariborz Jahanian17cb3262010-05-05 21:52:17 +00002416 ImplMethodsVsClassMethods(S, IC, IDecl);
Fariborz Jahanian7ca8b062009-11-11 22:40:11 +00002417 AtomicPropertySetterGetterRules(IC, IDecl);
John McCallf85e1932011-06-15 23:02:42 +00002418 DiagnoseOwningPropertyGetterSynthesis(IC);
Fariborz Jahanian2c18bb72010-08-20 21:21:08 +00002419
Fariborz Jahanianf914b972010-02-23 23:41:11 +00002420 if (LangOpts.ObjCNonFragileABI2)
2421 while (IDecl->getSuperClass()) {
2422 DiagnoseDuplicateIvars(IDecl, IDecl->getSuperClass());
2423 IDecl = IDecl->getSuperClass();
2424 }
Fariborz Jahanian7ca8b062009-11-11 22:40:11 +00002425 }
Fariborz Jahaniane4498c62010-04-28 16:11:27 +00002426 SetIvarInitializers(IC);
Mike Stump1eb44332009-09-09 15:08:12 +00002427 } else if (ObjCCategoryImplDecl* CatImplClass =
Steve Naroff09c47192009-01-09 15:36:25 +00002428 dyn_cast<ObjCCategoryImplDecl>(ClassDecl)) {
Ted Kremenek782f2f52010-01-07 01:20:12 +00002429 CatImplClass->setAtEndRange(AtEnd);
Mike Stump1eb44332009-09-09 15:08:12 +00002430
Chris Lattner4d391482007-12-12 07:09:47 +00002431 // Find category interface decl and then check that all methods declared
Daniel Dunbarb20ef3e2008-08-27 05:40:03 +00002432 // in this interface are implemented in the category @implementation.
Chris Lattner97a58872009-02-16 18:32:47 +00002433 if (ObjCInterfaceDecl* IDecl = CatImplClass->getClassInterface()) {
Ted Kremeneka526c5c2008-01-07 19:49:32 +00002434 for (ObjCCategoryDecl *Categories = IDecl->getCategoryList();
Chris Lattner4d391482007-12-12 07:09:47 +00002435 Categories; Categories = Categories->getNextClassCategory()) {
2436 if (Categories->getIdentifier() == CatImplClass->getIdentifier()) {
Fariborz Jahanian17cb3262010-05-05 21:52:17 +00002437 ImplMethodsVsClassMethods(S, CatImplClass, Categories);
Chris Lattner4d391482007-12-12 07:09:47 +00002438 break;
2439 }
2440 }
2441 }
2442 }
Chris Lattner682bf922009-03-29 16:50:03 +00002443 if (isInterfaceDeclKind) {
2444 // Reject invalid vardecls.
2445 for (unsigned i = 0; i != tuvNum; i++) {
2446 DeclGroupRef DG = allTUVars[i].getAsVal<DeclGroupRef>();
2447 for (DeclGroupRef::iterator I = DG.begin(), E = DG.end(); I != E; ++I)
2448 if (VarDecl *VDecl = dyn_cast<VarDecl>(*I)) {
Daniel Dunbar5466c7b2009-04-14 02:25:56 +00002449 if (!VDecl->hasExternalStorage())
Steve Naroff87454162009-04-13 17:58:46 +00002450 Diag(VDecl->getLocation(), diag::err_objc_var_decl_inclass);
Fariborz Jahanianb31cb7f2009-03-21 18:06:45 +00002451 }
Chris Lattner682bf922009-03-29 16:50:03 +00002452 }
Fariborz Jahanian38e24c72009-03-18 22:33:24 +00002453 }
Chris Lattner4d391482007-12-12 07:09:47 +00002454}
2455
2456
2457/// CvtQTToAstBitMask - utility routine to produce an AST bitmask for
2458/// objective-c's type qualifier from the parser version of the same info.
Mike Stump1eb44332009-09-09 15:08:12 +00002459static Decl::ObjCDeclQualifier
Ted Kremeneka526c5c2008-01-07 19:49:32 +00002460CvtQTToAstBitMask(ObjCDeclSpec::ObjCDeclQualifier PQTVal) {
John McCall09e2c522011-05-01 03:04:29 +00002461 return (Decl::ObjCDeclQualifier) (unsigned) PQTVal;
Chris Lattner4d391482007-12-12 07:09:47 +00002462}
2463
Ted Kremenek422bae72010-04-18 04:59:38 +00002464static inline
Sean Huntcf807c42010-08-18 23:23:40 +00002465bool containsInvalidMethodImplAttribute(const AttrVec &A) {
Ted Kremenek422bae72010-04-18 04:59:38 +00002466 // The 'ibaction' attribute is allowed on method definitions because of
2467 // how the IBAction macro is used on both method declarations and definitions.
2468 // If the method definitions contains any other attributes, return true.
Sean Huntcf807c42010-08-18 23:23:40 +00002469 for (AttrVec::const_iterator i = A.begin(), e = A.end(); i != e; ++i)
2470 if ((*i)->getKind() != attr::IBAction)
2471 return true;
2472 return false;
Ted Kremenek422bae72010-04-18 04:59:38 +00002473}
2474
Douglas Gregor926df6c2011-06-11 01:09:30 +00002475/// \brief Check whether the declared result type of the given Objective-C
2476/// method declaration is compatible with the method's class.
2477///
2478static bool
2479CheckRelatedResultTypeCompatibility(Sema &S, ObjCMethodDecl *Method,
2480 ObjCInterfaceDecl *CurrentClass) {
2481 QualType ResultType = Method->getResultType();
2482 SourceRange ResultTypeRange;
2483 if (const TypeSourceInfo *ResultTypeInfo = Method->getResultTypeSourceInfo())
2484 ResultTypeRange = ResultTypeInfo->getTypeLoc().getSourceRange();
2485
2486 // If an Objective-C method inherits its related result type, then its
2487 // declared result type must be compatible with its own class type. The
2488 // declared result type is compatible if:
2489 if (const ObjCObjectPointerType *ResultObjectType
2490 = ResultType->getAs<ObjCObjectPointerType>()) {
2491 // - it is id or qualified id, or
2492 if (ResultObjectType->isObjCIdType() ||
2493 ResultObjectType->isObjCQualifiedIdType())
2494 return false;
2495
2496 if (CurrentClass) {
2497 if (ObjCInterfaceDecl *ResultClass
2498 = ResultObjectType->getInterfaceDecl()) {
2499 // - it is the same as the method's class type, or
2500 if (CurrentClass == ResultClass)
2501 return false;
2502
2503 // - it is a superclass of the method's class type
2504 if (ResultClass->isSuperClassOf(CurrentClass))
2505 return false;
2506 }
2507 }
2508 }
2509
2510 return true;
2511}
2512
John McCall6c2c2502011-07-22 02:45:48 +00002513namespace {
2514/// A helper class for searching for methods which a particular method
2515/// overrides.
2516class OverrideSearch {
2517 Sema &S;
2518 ObjCMethodDecl *Method;
2519 llvm::SmallPtrSet<ObjCContainerDecl*, 8> Searched;
2520 llvm::SmallPtrSet<ObjCMethodDecl*, 8> Overridden;
2521 bool Recursive;
2522
2523public:
2524 OverrideSearch(Sema &S, ObjCMethodDecl *method) : S(S), Method(method) {
2525 Selector selector = method->getSelector();
2526
2527 // Bypass this search if we've never seen an instance/class method
2528 // with this selector before.
2529 Sema::GlobalMethodPool::iterator it = S.MethodPool.find(selector);
2530 if (it == S.MethodPool.end()) {
2531 if (!S.ExternalSource) return;
2532 it = S.ReadMethodPool(selector);
2533 }
2534 ObjCMethodList &list =
2535 method->isInstanceMethod() ? it->second.first : it->second.second;
2536 if (!list.Method) return;
2537
2538 ObjCContainerDecl *container
2539 = cast<ObjCContainerDecl>(method->getDeclContext());
2540
2541 // Prevent the search from reaching this container again. This is
2542 // important with categories, which override methods from the
2543 // interface and each other.
2544 Searched.insert(container);
2545 searchFromContainer(container);
Douglas Gregor926df6c2011-06-11 01:09:30 +00002546 }
John McCall6c2c2502011-07-22 02:45:48 +00002547
2548 typedef llvm::SmallPtrSet<ObjCMethodDecl*,8>::iterator iterator;
2549 iterator begin() const { return Overridden.begin(); }
2550 iterator end() const { return Overridden.end(); }
2551
2552private:
2553 void searchFromContainer(ObjCContainerDecl *container) {
2554 if (container->isInvalidDecl()) return;
2555
2556 switch (container->getDeclKind()) {
2557#define OBJCCONTAINER(type, base) \
2558 case Decl::type: \
2559 searchFrom(cast<type##Decl>(container)); \
2560 break;
2561#define ABSTRACT_DECL(expansion)
2562#define DECL(type, base) \
2563 case Decl::type:
2564#include "clang/AST/DeclNodes.inc"
2565 llvm_unreachable("not an ObjC container!");
2566 }
2567 }
2568
2569 void searchFrom(ObjCProtocolDecl *protocol) {
2570 // A method in a protocol declaration overrides declarations from
2571 // referenced ("parent") protocols.
2572 search(protocol->getReferencedProtocols());
2573 }
2574
2575 void searchFrom(ObjCCategoryDecl *category) {
2576 // A method in a category declaration overrides declarations from
2577 // the main class and from protocols the category references.
2578 search(category->getClassInterface());
2579 search(category->getReferencedProtocols());
2580 }
2581
2582 void searchFrom(ObjCCategoryImplDecl *impl) {
2583 // A method in a category definition that has a category
2584 // declaration overrides declarations from the category
2585 // declaration.
2586 if (ObjCCategoryDecl *category = impl->getCategoryDecl()) {
2587 search(category);
2588
2589 // Otherwise it overrides declarations from the class.
2590 } else {
2591 search(impl->getClassInterface());
2592 }
2593 }
2594
2595 void searchFrom(ObjCInterfaceDecl *iface) {
2596 // A method in a class declaration overrides declarations from
2597
2598 // - categories,
2599 for (ObjCCategoryDecl *category = iface->getCategoryList();
2600 category; category = category->getNextClassCategory())
2601 search(category);
2602
2603 // - the super class, and
2604 if (ObjCInterfaceDecl *super = iface->getSuperClass())
2605 search(super);
2606
2607 // - any referenced protocols.
2608 search(iface->getReferencedProtocols());
2609 }
2610
2611 void searchFrom(ObjCImplementationDecl *impl) {
2612 // A method in a class implementation overrides declarations from
2613 // the class interface.
2614 search(impl->getClassInterface());
2615 }
2616
2617
2618 void search(const ObjCProtocolList &protocols) {
2619 for (ObjCProtocolList::iterator i = protocols.begin(), e = protocols.end();
2620 i != e; ++i)
2621 search(*i);
2622 }
2623
2624 void search(ObjCContainerDecl *container) {
2625 // Abort if we've already searched this container.
2626 if (!Searched.insert(container)) return;
2627
2628 // Check for a method in this container which matches this selector.
2629 ObjCMethodDecl *meth = container->getMethod(Method->getSelector(),
2630 Method->isInstanceMethod());
2631
2632 // If we find one, record it and bail out.
2633 if (meth) {
2634 Overridden.insert(meth);
2635 return;
2636 }
2637
2638 // Otherwise, search for methods that a hypothetical method here
2639 // would have overridden.
2640
2641 // Note that we're now in a recursive case.
2642 Recursive = true;
2643
2644 searchFromContainer(container);
2645 }
2646};
Douglas Gregor926df6c2011-06-11 01:09:30 +00002647}
2648
John McCalld226f652010-08-21 09:40:31 +00002649Decl *Sema::ActOnMethodDeclaration(
Fariborz Jahanian7f532532011-02-09 22:20:01 +00002650 Scope *S,
Chris Lattner4d391482007-12-12 07:09:47 +00002651 SourceLocation MethodLoc, SourceLocation EndLoc,
John McCalld226f652010-08-21 09:40:31 +00002652 tok::TokenKind MethodType, Decl *ClassDecl,
John McCallb3d87482010-08-24 05:47:05 +00002653 ObjCDeclSpec &ReturnQT, ParsedType ReturnType,
Douglas Gregor926df6c2011-06-11 01:09:30 +00002654 SourceLocation SelectorStartLoc,
Chris Lattner4d391482007-12-12 07:09:47 +00002655 Selector Sel,
2656 // optional arguments. The number of types/arguments is obtained
2657 // from the Sel.getNumArgs().
Chris Lattnere294d3f2009-04-11 18:57:04 +00002658 ObjCArgInfo *ArgInfo,
Fariborz Jahanian4f4fd922010-04-08 00:30:06 +00002659 DeclaratorChunk::ParamInfo *CParamInfo, unsigned CNumArgs, // c-style args
Chris Lattner4d391482007-12-12 07:09:47 +00002660 AttributeList *AttrList, tok::ObjCKeywordKind MethodDeclKind,
Fariborz Jahanian90ba78c2011-03-12 18:54:30 +00002661 bool isVariadic, bool MethodDefinition) {
Steve Naroffda323ad2008-02-29 21:48:07 +00002662 // Make sure we can establish a context for the method.
2663 if (!ClassDecl) {
2664 Diag(MethodLoc, diag::error_missing_method_context);
John McCalld226f652010-08-21 09:40:31 +00002665 return 0;
Steve Naroffda323ad2008-02-29 21:48:07 +00002666 }
Chris Lattner4d391482007-12-12 07:09:47 +00002667 QualType resultDeclType;
Mike Stump1eb44332009-09-09 15:08:12 +00002668
Douglas Gregor4bc1cb62010-03-08 14:59:44 +00002669 TypeSourceInfo *ResultTInfo = 0;
Steve Naroffccef3712009-02-20 22:59:16 +00002670 if (ReturnType) {
Douglas Gregor4bc1cb62010-03-08 14:59:44 +00002671 resultDeclType = GetTypeFromParser(ReturnType, &ResultTInfo);
Mike Stump1eb44332009-09-09 15:08:12 +00002672
Steve Naroffccef3712009-02-20 22:59:16 +00002673 // Methods cannot return interface types. All ObjC objects are
2674 // passed by reference.
John McCallc12c5bb2010-05-15 11:32:37 +00002675 if (resultDeclType->isObjCObjectType()) {
Chris Lattner2dd979f2009-04-11 19:08:56 +00002676 Diag(MethodLoc, diag::err_object_cannot_be_passed_returned_by_value)
2677 << 0 << resultDeclType;
John McCalld226f652010-08-21 09:40:31 +00002678 return 0;
Douglas Gregor926df6c2011-06-11 01:09:30 +00002679 }
Fariborz Jahanianaab24a62011-07-21 17:00:47 +00002680 } else { // get the type for "id".
Ted Kremeneka526c5c2008-01-07 19:49:32 +00002681 resultDeclType = Context.getObjCIdType();
Fariborz Jahanianfeb4fa12011-07-21 17:38:14 +00002682 Diag(MethodLoc, diag::warn_missing_method_return_type)
2683 << FixItHint::CreateInsertion(SelectorStartLoc, "(id)");
Fariborz Jahanianaab24a62011-07-21 17:00:47 +00002684 }
Mike Stump1eb44332009-09-09 15:08:12 +00002685
2686 ObjCMethodDecl* ObjCMethod =
Chris Lattner6c4ae5d2008-03-16 00:49:28 +00002687 ObjCMethodDecl::Create(Context, MethodLoc, EndLoc, Sel, resultDeclType,
Douglas Gregor4bc1cb62010-03-08 14:59:44 +00002688 ResultTInfo,
Mike Stump1eb44332009-09-09 15:08:12 +00002689 cast<DeclContext>(ClassDecl),
Chris Lattner6c4ae5d2008-03-16 00:49:28 +00002690 MethodType == tok::minus, isVariadic,
Fariborz Jahanian3fe10412010-07-22 18:24:20 +00002691 false, false,
Douglas Gregor926df6c2011-06-11 01:09:30 +00002692 MethodDeclKind == tok::objc_optional
2693 ? ObjCMethodDecl::Optional
2694 : ObjCMethodDecl::Required,
2695 false);
Mike Stump1eb44332009-09-09 15:08:12 +00002696
Chris Lattner5f9e2722011-07-23 10:55:15 +00002697 SmallVector<ParmVarDecl*, 16> Params;
Mike Stump1eb44332009-09-09 15:08:12 +00002698
Chris Lattner7db638d2009-04-11 19:42:43 +00002699 for (unsigned i = 0, e = Sel.getNumArgs(); i != e; ++i) {
John McCall58e46772009-10-23 21:48:59 +00002700 QualType ArgType;
John McCalla93c9342009-12-07 02:54:59 +00002701 TypeSourceInfo *DI;
Mike Stump1eb44332009-09-09 15:08:12 +00002702
Chris Lattnere294d3f2009-04-11 18:57:04 +00002703 if (ArgInfo[i].Type == 0) {
John McCall58e46772009-10-23 21:48:59 +00002704 ArgType = Context.getObjCIdType();
2705 DI = 0;
Chris Lattnere294d3f2009-04-11 18:57:04 +00002706 } else {
John McCall58e46772009-10-23 21:48:59 +00002707 ArgType = GetTypeFromParser(ArgInfo[i].Type, &DI);
Steve Naroff6082c622008-12-09 19:36:17 +00002708 // Perform the default array/function conversions (C99 6.7.5.3p[7,8]).
Douglas Gregor79e6bd32011-07-12 04:42:08 +00002709 ArgType = Context.getAdjustedParameterType(ArgType);
Chris Lattnere294d3f2009-04-11 18:57:04 +00002710 }
Mike Stump1eb44332009-09-09 15:08:12 +00002711
Fariborz Jahanian7f532532011-02-09 22:20:01 +00002712 LookupResult R(*this, ArgInfo[i].Name, ArgInfo[i].NameLoc,
2713 LookupOrdinaryName, ForRedeclaration);
2714 LookupName(R, S);
2715 if (R.isSingleResult()) {
2716 NamedDecl *PrevDecl = R.getFoundDecl();
2717 if (S->isDeclScope(PrevDecl)) {
Fariborz Jahanian90ba78c2011-03-12 18:54:30 +00002718 Diag(ArgInfo[i].NameLoc,
2719 (MethodDefinition ? diag::warn_method_param_redefinition
2720 : diag::warn_method_param_declaration))
Fariborz Jahanian7f532532011-02-09 22:20:01 +00002721 << ArgInfo[i].Name;
2722 Diag(PrevDecl->getLocation(),
2723 diag::note_previous_declaration);
2724 }
2725 }
2726
Abramo Bagnaraff676cb2011-03-08 08:55:46 +00002727 SourceLocation StartLoc = DI
2728 ? DI->getTypeLoc().getBeginLoc()
2729 : ArgInfo[i].NameLoc;
2730
John McCall81ef3e62011-04-23 02:46:06 +00002731 ParmVarDecl* Param = CheckParameter(ObjCMethod, StartLoc,
2732 ArgInfo[i].NameLoc, ArgInfo[i].Name,
2733 ArgType, DI, SC_None, SC_None);
Mike Stump1eb44332009-09-09 15:08:12 +00002734
John McCall70798862011-05-02 00:30:12 +00002735 Param->setObjCMethodScopeInfo(i);
2736
Chris Lattner0ed844b2008-04-04 06:12:32 +00002737 Param->setObjCDeclQualifier(
Chris Lattnere294d3f2009-04-11 18:57:04 +00002738 CvtQTToAstBitMask(ArgInfo[i].DeclSpec.getObjCDeclQualifier()));
Mike Stump1eb44332009-09-09 15:08:12 +00002739
Chris Lattnerf97e8fa2009-04-11 19:34:56 +00002740 // Apply the attributes to the parameter.
Douglas Gregor9cdda0c2009-06-17 21:51:59 +00002741 ProcessDeclAttributeList(TUScope, Param, ArgInfo[i].ArgAttrs);
Mike Stump1eb44332009-09-09 15:08:12 +00002742
Fariborz Jahanian7f532532011-02-09 22:20:01 +00002743 S->AddDecl(Param);
2744 IdResolver.AddDecl(Param);
2745
Chris Lattner0ed844b2008-04-04 06:12:32 +00002746 Params.push_back(Param);
2747 }
Fariborz Jahanian7f532532011-02-09 22:20:01 +00002748
Fariborz Jahanian4f4fd922010-04-08 00:30:06 +00002749 for (unsigned i = 0, e = CNumArgs; i != e; ++i) {
John McCalld226f652010-08-21 09:40:31 +00002750 ParmVarDecl *Param = cast<ParmVarDecl>(CParamInfo[i].Param);
Fariborz Jahanian4f4fd922010-04-08 00:30:06 +00002751 QualType ArgType = Param->getType();
2752 if (ArgType.isNull())
2753 ArgType = Context.getObjCIdType();
2754 else
2755 // Perform the default array/function conversions (C99 6.7.5.3p[7,8]).
Douglas Gregor79e6bd32011-07-12 04:42:08 +00002756 ArgType = Context.getAdjustedParameterType(ArgType);
John McCallc12c5bb2010-05-15 11:32:37 +00002757 if (ArgType->isObjCObjectType()) {
Fariborz Jahanian4f4fd922010-04-08 00:30:06 +00002758 Diag(Param->getLocation(),
2759 diag::err_object_cannot_be_passed_returned_by_value)
2760 << 1 << ArgType;
2761 Param->setInvalidDecl();
2762 }
2763 Param->setDeclContext(ObjCMethod);
Fariborz Jahanian7f532532011-02-09 22:20:01 +00002764
Fariborz Jahanian4f4fd922010-04-08 00:30:06 +00002765 Params.push_back(Param);
2766 }
2767
Fariborz Jahanian4ecb25f2010-04-09 15:40:42 +00002768 ObjCMethod->setMethodParams(Context, Params.data(), Params.size(),
2769 Sel.getNumArgs());
Ted Kremeneka526c5c2008-01-07 19:49:32 +00002770 ObjCMethod->setObjCDeclQualifier(
2771 CvtQTToAstBitMask(ReturnQT.getObjCDeclQualifier()));
Daniel Dunbar35682492008-09-26 04:12:28 +00002772
2773 if (AttrList)
Douglas Gregor9cdda0c2009-06-17 21:51:59 +00002774 ProcessDeclAttributeList(TUScope, ObjCMethod, AttrList);
Mike Stump1eb44332009-09-09 15:08:12 +00002775
Douglas Gregorbdb2d502010-12-21 17:34:17 +00002776 // Add the method now.
John McCall6c2c2502011-07-22 02:45:48 +00002777 const ObjCMethodDecl *PrevMethod = 0;
2778 if (ObjCImplDecl *ImpDecl = dyn_cast<ObjCImplDecl>(ClassDecl)) {
Chris Lattner4d391482007-12-12 07:09:47 +00002779 if (MethodType == tok::minus) {
Argyrios Kyrtzidis17945a02009-06-30 02:36:12 +00002780 PrevMethod = ImpDecl->getInstanceMethod(Sel);
2781 ImpDecl->addInstanceMethod(ObjCMethod);
Chris Lattner4d391482007-12-12 07:09:47 +00002782 } else {
Argyrios Kyrtzidis17945a02009-06-30 02:36:12 +00002783 PrevMethod = ImpDecl->getClassMethod(Sel);
2784 ImpDecl->addClassMethod(ObjCMethod);
Chris Lattner4d391482007-12-12 07:09:47 +00002785 }
Douglas Gregor926df6c2011-06-11 01:09:30 +00002786
Sean Huntcf807c42010-08-18 23:23:40 +00002787 if (ObjCMethod->hasAttrs() &&
2788 containsInvalidMethodImplAttribute(ObjCMethod->getAttrs()))
Fariborz Jahanian5d36ac22009-05-12 21:36:23 +00002789 Diag(EndLoc, diag::warn_attribute_method_def);
Douglas Gregorbdb2d502010-12-21 17:34:17 +00002790 } else {
2791 cast<DeclContext>(ClassDecl)->addDecl(ObjCMethod);
Chris Lattner4d391482007-12-12 07:09:47 +00002792 }
John McCall6c2c2502011-07-22 02:45:48 +00002793
Chris Lattner4d391482007-12-12 07:09:47 +00002794 if (PrevMethod) {
2795 // You can never have two method definitions with the same name.
Chris Lattner5f4a6822008-11-23 23:12:31 +00002796 Diag(ObjCMethod->getLocation(), diag::err_duplicate_method_decl)
Chris Lattner077bf5e2008-11-24 03:33:13 +00002797 << ObjCMethod->getDeclName();
Chris Lattner5f4a6822008-11-23 23:12:31 +00002798 Diag(PrevMethod->getLocation(), diag::note_previous_declaration);
Mike Stump1eb44332009-09-09 15:08:12 +00002799 }
John McCall54abf7d2009-11-04 02:18:39 +00002800
Douglas Gregor926df6c2011-06-11 01:09:30 +00002801 // If this Objective-C method does not have a related result type, but we
2802 // are allowed to infer related result types, try to do so based on the
2803 // method family.
2804 ObjCInterfaceDecl *CurrentClass = dyn_cast<ObjCInterfaceDecl>(ClassDecl);
2805 if (!CurrentClass) {
2806 if (ObjCCategoryDecl *Cat = dyn_cast<ObjCCategoryDecl>(ClassDecl))
2807 CurrentClass = Cat->getClassInterface();
2808 else if (ObjCImplDecl *Impl = dyn_cast<ObjCImplDecl>(ClassDecl))
2809 CurrentClass = Impl->getClassInterface();
2810 else if (ObjCCategoryImplDecl *CatImpl
2811 = dyn_cast<ObjCCategoryImplDecl>(ClassDecl))
2812 CurrentClass = CatImpl->getClassInterface();
2813 }
John McCall6c2c2502011-07-22 02:45:48 +00002814
2815 bool isRelatedResultTypeCompatible =
2816 (getLangOptions().ObjCInferRelatedResultType &&
2817 !CheckRelatedResultTypeCompatibility(*this, ObjCMethod, CurrentClass));
2818
2819 // Search for overridden methods and merge information down from them.
2820 OverrideSearch overrides(*this, ObjCMethod);
2821 for (OverrideSearch::iterator
2822 i = overrides.begin(), e = overrides.end(); i != e; ++i) {
2823 ObjCMethodDecl *overridden = *i;
2824
2825 // Propagate down the 'related result type' bit from overridden methods.
2826 if (isRelatedResultTypeCompatible && overridden->hasRelatedResultType())
Douglas Gregor926df6c2011-06-11 01:09:30 +00002827 ObjCMethod->SetRelatedResultType();
John McCall6c2c2502011-07-22 02:45:48 +00002828
2829 // Then merge the declarations.
2830 mergeObjCMethodDecls(ObjCMethod, overridden);
Douglas Gregor926df6c2011-06-11 01:09:30 +00002831 }
2832
John McCallf85e1932011-06-15 23:02:42 +00002833 bool ARCError = false;
2834 if (getLangOptions().ObjCAutoRefCount)
2835 ARCError = CheckARCMethodDecl(*this, ObjCMethod);
2836
John McCall6c2c2502011-07-22 02:45:48 +00002837 if (!ARCError && isRelatedResultTypeCompatible &&
2838 !ObjCMethod->hasRelatedResultType()) {
Douglas Gregor926df6c2011-06-11 01:09:30 +00002839 bool InferRelatedResultType = false;
2840 switch (ObjCMethod->getMethodFamily()) {
2841 case OMF_None:
2842 case OMF_copy:
2843 case OMF_dealloc:
2844 case OMF_mutableCopy:
2845 case OMF_release:
2846 case OMF_retainCount:
Fariborz Jahanian9670e172011-07-05 22:38:59 +00002847 case OMF_performSelector:
Douglas Gregor926df6c2011-06-11 01:09:30 +00002848 break;
2849
2850 case OMF_alloc:
2851 case OMF_new:
2852 InferRelatedResultType = ObjCMethod->isClassMethod();
2853 break;
2854
2855 case OMF_init:
2856 case OMF_autorelease:
2857 case OMF_retain:
2858 case OMF_self:
2859 InferRelatedResultType = ObjCMethod->isInstanceMethod();
2860 break;
2861 }
2862
John McCall6c2c2502011-07-22 02:45:48 +00002863 if (InferRelatedResultType)
Douglas Gregor926df6c2011-06-11 01:09:30 +00002864 ObjCMethod->SetRelatedResultType();
Douglas Gregor926df6c2011-06-11 01:09:30 +00002865 }
2866
John McCalld226f652010-08-21 09:40:31 +00002867 return ObjCMethod;
Chris Lattner4d391482007-12-12 07:09:47 +00002868}
2869
Chris Lattnercc98eac2008-12-17 07:13:27 +00002870bool Sema::CheckObjCDeclScope(Decl *D) {
Sebastian Redl7a126a42010-08-31 00:36:30 +00002871 if (isa<TranslationUnitDecl>(CurContext->getRedeclContext()))
Anders Carlsson15281452008-11-04 16:57:32 +00002872 return false;
Mike Stump1eb44332009-09-09 15:08:12 +00002873
Anders Carlsson15281452008-11-04 16:57:32 +00002874 Diag(D->getLocation(), diag::err_objc_decls_may_only_appear_in_global_scope);
2875 D->setInvalidDecl();
Mike Stump1eb44332009-09-09 15:08:12 +00002876
Anders Carlsson15281452008-11-04 16:57:32 +00002877 return true;
2878}
Chris Lattnercc98eac2008-12-17 07:13:27 +00002879
Chris Lattnercc98eac2008-12-17 07:13:27 +00002880/// Called whenever @defs(ClassName) is encountered in the source. Inserts the
2881/// instance variables of ClassName into Decls.
John McCalld226f652010-08-21 09:40:31 +00002882void Sema::ActOnDefs(Scope *S, Decl *TagD, SourceLocation DeclStart,
Chris Lattnercc98eac2008-12-17 07:13:27 +00002883 IdentifierInfo *ClassName,
Chris Lattner5f9e2722011-07-23 10:55:15 +00002884 SmallVectorImpl<Decl*> &Decls) {
Chris Lattnercc98eac2008-12-17 07:13:27 +00002885 // Check that ClassName is a valid class
Douglas Gregorc83c6872010-04-15 22:33:43 +00002886 ObjCInterfaceDecl *Class = getObjCInterfaceDecl(ClassName, DeclStart);
Chris Lattnercc98eac2008-12-17 07:13:27 +00002887 if (!Class) {
2888 Diag(DeclStart, diag::err_undef_interface) << ClassName;
2889 return;
2890 }
Fariborz Jahanian0468fb92009-04-21 20:28:41 +00002891 if (LangOpts.ObjCNonFragileABI) {
2892 Diag(DeclStart, diag::err_atdef_nonfragile_interface);
2893 return;
2894 }
Mike Stump1eb44332009-09-09 15:08:12 +00002895
Chris Lattnercc98eac2008-12-17 07:13:27 +00002896 // Collect the instance variables
Jordy Rosedb8264e2011-07-22 02:08:32 +00002897 SmallVector<const ObjCIvarDecl*, 32> Ivars;
Fariborz Jahanian2c18bb72010-08-20 21:21:08 +00002898 Context.DeepCollectObjCIvars(Class, true, Ivars);
Fariborz Jahanian41833352009-06-04 17:08:55 +00002899 // For each ivar, create a fresh ObjCAtDefsFieldDecl.
Fariborz Jahanian2c18bb72010-08-20 21:21:08 +00002900 for (unsigned i = 0; i < Ivars.size(); i++) {
Jordy Rosedb8264e2011-07-22 02:08:32 +00002901 const FieldDecl* ID = cast<FieldDecl>(Ivars[i]);
John McCalld226f652010-08-21 09:40:31 +00002902 RecordDecl *Record = dyn_cast<RecordDecl>(TagD);
Abramo Bagnaraff676cb2011-03-08 08:55:46 +00002903 Decl *FD = ObjCAtDefsFieldDecl::Create(Context, Record,
2904 /*FIXME: StartL=*/ID->getLocation(),
2905 ID->getLocation(),
Fariborz Jahanian41833352009-06-04 17:08:55 +00002906 ID->getIdentifier(), ID->getType(),
2907 ID->getBitWidth());
John McCalld226f652010-08-21 09:40:31 +00002908 Decls.push_back(FD);
Fariborz Jahanian41833352009-06-04 17:08:55 +00002909 }
Mike Stump1eb44332009-09-09 15:08:12 +00002910
Chris Lattnercc98eac2008-12-17 07:13:27 +00002911 // Introduce all of these fields into the appropriate scope.
Chris Lattner5f9e2722011-07-23 10:55:15 +00002912 for (SmallVectorImpl<Decl*>::iterator D = Decls.begin();
Chris Lattnercc98eac2008-12-17 07:13:27 +00002913 D != Decls.end(); ++D) {
John McCalld226f652010-08-21 09:40:31 +00002914 FieldDecl *FD = cast<FieldDecl>(*D);
Chris Lattnercc98eac2008-12-17 07:13:27 +00002915 if (getLangOptions().CPlusPlus)
2916 PushOnScopeChains(cast<FieldDecl>(FD), S);
John McCalld226f652010-08-21 09:40:31 +00002917 else if (RecordDecl *Record = dyn_cast<RecordDecl>(TagD))
Argyrios Kyrtzidis17945a02009-06-30 02:36:12 +00002918 Record->addDecl(FD);
Chris Lattnercc98eac2008-12-17 07:13:27 +00002919 }
2920}
2921
Douglas Gregor160b5632010-04-26 17:32:49 +00002922/// \brief Build a type-check a new Objective-C exception variable declaration.
Abramo Bagnaraff676cb2011-03-08 08:55:46 +00002923VarDecl *Sema::BuildObjCExceptionDecl(TypeSourceInfo *TInfo, QualType T,
2924 SourceLocation StartLoc,
2925 SourceLocation IdLoc,
2926 IdentifierInfo *Id,
Douglas Gregor160b5632010-04-26 17:32:49 +00002927 bool Invalid) {
2928 // ISO/IEC TR 18037 S6.7.3: "The type of an object with automatic storage
2929 // duration shall not be qualified by an address-space qualifier."
2930 // Since all parameters have automatic store duration, they can not have
2931 // an address space.
2932 if (T.getAddressSpace() != 0) {
Abramo Bagnaraff676cb2011-03-08 08:55:46 +00002933 Diag(IdLoc, diag::err_arg_with_address_space);
Douglas Gregor160b5632010-04-26 17:32:49 +00002934 Invalid = true;
2935 }
2936
2937 // An @catch parameter must be an unqualified object pointer type;
2938 // FIXME: Recover from "NSObject foo" by inserting the * in "NSObject *foo"?
2939 if (Invalid) {
2940 // Don't do any further checking.
Douglas Gregorbe270a02010-04-26 17:57:08 +00002941 } else if (T->isDependentType()) {
2942 // Okay: we don't know what this type will instantiate to.
Douglas Gregor160b5632010-04-26 17:32:49 +00002943 } else if (!T->isObjCObjectPointerType()) {
2944 Invalid = true;
Abramo Bagnaraff676cb2011-03-08 08:55:46 +00002945 Diag(IdLoc ,diag::err_catch_param_not_objc_type);
Douglas Gregor160b5632010-04-26 17:32:49 +00002946 } else if (T->isObjCQualifiedIdType()) {
2947 Invalid = true;
Abramo Bagnaraff676cb2011-03-08 08:55:46 +00002948 Diag(IdLoc, diag::err_illegal_qualifiers_on_catch_parm);
Douglas Gregor160b5632010-04-26 17:32:49 +00002949 }
2950
Abramo Bagnaraff676cb2011-03-08 08:55:46 +00002951 VarDecl *New = VarDecl::Create(Context, CurContext, StartLoc, IdLoc, Id,
2952 T, TInfo, SC_None, SC_None);
Douglas Gregor324b54d2010-05-03 18:51:14 +00002953 New->setExceptionVariable(true);
2954
Douglas Gregor160b5632010-04-26 17:32:49 +00002955 if (Invalid)
2956 New->setInvalidDecl();
2957 return New;
2958}
2959
John McCalld226f652010-08-21 09:40:31 +00002960Decl *Sema::ActOnObjCExceptionDecl(Scope *S, Declarator &D) {
Douglas Gregor160b5632010-04-26 17:32:49 +00002961 const DeclSpec &DS = D.getDeclSpec();
2962
2963 // We allow the "register" storage class on exception variables because
2964 // GCC did, but we drop it completely. Any other storage class is an error.
2965 if (DS.getStorageClassSpec() == DeclSpec::SCS_register) {
2966 Diag(DS.getStorageClassSpecLoc(), diag::warn_register_objc_catch_parm)
2967 << FixItHint::CreateRemoval(SourceRange(DS.getStorageClassSpecLoc()));
2968 } else if (DS.getStorageClassSpec() != DeclSpec::SCS_unspecified) {
2969 Diag(DS.getStorageClassSpecLoc(), diag::err_storage_spec_on_catch_parm)
2970 << DS.getStorageClassSpec();
2971 }
2972 if (D.getDeclSpec().isThreadSpecified())
2973 Diag(D.getDeclSpec().getThreadSpecLoc(), diag::err_invalid_thread);
2974 D.getMutableDeclSpec().ClearStorageClassSpecs();
2975
2976 DiagnoseFunctionSpecifiers(D);
2977
2978 // Check that there are no default arguments inside the type of this
2979 // exception object (C++ only).
2980 if (getLangOptions().CPlusPlus)
2981 CheckExtraCXXDefaultArguments(D);
2982
Argyrios Kyrtzidis32153982011-06-28 03:01:15 +00002983 TypeSourceInfo *TInfo = GetTypeForDeclarator(D, S);
John McCallbf1a0282010-06-04 23:28:52 +00002984 QualType ExceptionType = TInfo->getType();
Douglas Gregor160b5632010-04-26 17:32:49 +00002985
Abramo Bagnaraff676cb2011-03-08 08:55:46 +00002986 VarDecl *New = BuildObjCExceptionDecl(TInfo, ExceptionType,
2987 D.getSourceRange().getBegin(),
2988 D.getIdentifierLoc(),
2989 D.getIdentifier(),
Douglas Gregor160b5632010-04-26 17:32:49 +00002990 D.isInvalidType());
2991
2992 // Parameter declarators cannot be qualified (C++ [dcl.meaning]p1).
2993 if (D.getCXXScopeSpec().isSet()) {
2994 Diag(D.getIdentifierLoc(), diag::err_qualified_objc_catch_parm)
2995 << D.getCXXScopeSpec().getRange();
2996 New->setInvalidDecl();
2997 }
2998
2999 // Add the parameter declaration into this scope.
John McCalld226f652010-08-21 09:40:31 +00003000 S->AddDecl(New);
Douglas Gregor160b5632010-04-26 17:32:49 +00003001 if (D.getIdentifier())
3002 IdResolver.AddDecl(New);
3003
3004 ProcessDeclAttributes(S, New, D);
3005
3006 if (New->hasAttr<BlocksAttr>())
3007 Diag(New->getLocation(), diag::err_block_on_nonlocal);
John McCalld226f652010-08-21 09:40:31 +00003008 return New;
Douglas Gregor4e6c0d12010-04-23 23:01:43 +00003009}
Fariborz Jahanian786cd152010-04-27 17:18:58 +00003010
3011/// CollectIvarsToConstructOrDestruct - Collect those ivars which require
Fariborz Jahaniane4498c62010-04-28 16:11:27 +00003012/// initialization.
Fariborz Jahanian2c18bb72010-08-20 21:21:08 +00003013void Sema::CollectIvarsToConstructOrDestruct(ObjCInterfaceDecl *OI,
Chris Lattner5f9e2722011-07-23 10:55:15 +00003014 SmallVectorImpl<ObjCIvarDecl*> &Ivars) {
Fariborz Jahanian2c18bb72010-08-20 21:21:08 +00003015 for (ObjCIvarDecl *Iv = OI->all_declared_ivar_begin(); Iv;
3016 Iv= Iv->getNextIvar()) {
Fariborz Jahanian786cd152010-04-27 17:18:58 +00003017 QualType QT = Context.getBaseElementType(Iv->getType());
Douglas Gregor68dd3ee2010-05-20 02:24:22 +00003018 if (QT->isRecordType())
Fariborz Jahanian2c18bb72010-08-20 21:21:08 +00003019 Ivars.push_back(Iv);
Fariborz Jahanian786cd152010-04-27 17:18:58 +00003020 }
3021}
Fariborz Jahaniane4498c62010-04-28 16:11:27 +00003022
Fariborz Jahanian3fe10412010-07-22 18:24:20 +00003023void Sema::DiagnoseUseOfUnimplementedSelectors() {
Douglas Gregor5b9dc7c2011-07-28 14:54:22 +00003024 // Load referenced selectors from the external source.
3025 if (ExternalSource) {
3026 SmallVector<std::pair<Selector, SourceLocation>, 4> Sels;
3027 ExternalSource->ReadReferencedSelectors(Sels);
3028 for (unsigned I = 0, N = Sels.size(); I != N; ++I)
3029 ReferencedSelectors[Sels[I].first] = Sels[I].second;
3030 }
3031
Fariborz Jahanian8b789132011-02-04 23:19:27 +00003032 // Warning will be issued only when selector table is
3033 // generated (which means there is at lease one implementation
3034 // in the TU). This is to match gcc's behavior.
3035 if (ReferencedSelectors.empty() ||
3036 !Context.AnyObjCImplementation())
Fariborz Jahanian3fe10412010-07-22 18:24:20 +00003037 return;
3038 for (llvm::DenseMap<Selector, SourceLocation>::iterator S =
3039 ReferencedSelectors.begin(),
3040 E = ReferencedSelectors.end(); S != E; ++S) {
3041 Selector Sel = (*S).first;
3042 if (!LookupImplementedMethodInGlobalPool(Sel))
3043 Diag((*S).second, diag::warn_unimplemented_selector) << Sel;
3044 }
3045 return;
3046}