blob: 5e8770888c5857e474ab4600e70eed8b6f491e76 [file] [log] [blame]
Chris Lattner59907c42007-08-10 20:18:51 +00001//===--- SemaChecking.cpp - Extra Semantic Checking -----------------------===//
2//
3// The LLVM Compiler Infrastructure
4//
Chris Lattner0bc735f2007-12-29 19:59:25 +00005// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
Chris Lattner59907c42007-08-10 20:18:51 +00007//
8//===----------------------------------------------------------------------===//
9//
Mike Stump1eb44332009-09-09 15:08:12 +000010// This file implements extra semantic analysis beyond what is enforced
Chris Lattner59907c42007-08-10 20:18:51 +000011// by the C type system.
12//
13//===----------------------------------------------------------------------===//
14
John McCall5f8d6042011-08-27 01:09:30 +000015#include "clang/Sema/Initialization.h"
Douglas Gregore737f502010-08-12 20:07:10 +000016#include "clang/Sema/Sema.h"
John McCall2d887082010-08-25 22:03:47 +000017#include "clang/Sema/SemaInternal.h"
Eli Friedman276b0612011-10-11 02:20:01 +000018#include "clang/Sema/Initialization.h"
John McCall781472f2010-08-25 08:40:02 +000019#include "clang/Sema/ScopeInfo.h"
Ted Kremenek826a3452010-07-16 02:11:22 +000020#include "clang/Analysis/Analyses/FormatString.h"
Chris Lattner59907c42007-08-10 20:18:51 +000021#include "clang/AST/ASTContext.h"
Ken Dyck199c3d62010-01-11 17:06:35 +000022#include "clang/AST/CharUnits.h"
John McCall384aff82010-08-25 07:42:41 +000023#include "clang/AST/DeclCXX.h"
Daniel Dunbarc4a1dea2008-08-11 05:35:13 +000024#include "clang/AST/DeclObjC.h"
Ted Kremenek23245122007-08-20 16:18:38 +000025#include "clang/AST/ExprCXX.h"
Ted Kremenek7ff22b22008-06-16 18:00:42 +000026#include "clang/AST/ExprObjC.h"
John McCallf85e1932011-06-15 23:02:42 +000027#include "clang/AST/EvaluatedExprVisitor.h"
Mike Stumpf8c49212010-01-21 03:59:47 +000028#include "clang/AST/DeclObjC.h"
29#include "clang/AST/StmtCXX.h"
30#include "clang/AST/StmtObjC.h"
Chris Lattner59907c42007-08-10 20:18:51 +000031#include "clang/Lex/Preprocessor.h"
Mike Stumpf8c49212010-01-21 03:59:47 +000032#include "llvm/ADT/BitVector.h"
33#include "llvm/ADT/STLExtras.h"
Tom Care3bfc5f42010-06-09 04:11:11 +000034#include "llvm/Support/raw_ostream.h"
Eric Christopher691ebc32010-04-17 02:26:23 +000035#include "clang/Basic/TargetBuiltins.h"
Nate Begeman26a31422010-06-08 02:47:44 +000036#include "clang/Basic/TargetInfo.h"
Fariborz Jahanian7da71022010-09-07 19:38:13 +000037#include "clang/Basic/ConvertUTF.h"
Zhongxing Xua1f3dba2009-05-20 01:55:10 +000038#include <limits>
Chris Lattner59907c42007-08-10 20:18:51 +000039using namespace clang;
John McCall781472f2010-08-25 08:40:02 +000040using namespace sema;
Chris Lattner59907c42007-08-10 20:18:51 +000041
Chris Lattner60800082009-02-18 17:49:48 +000042SourceLocation Sema::getLocationOfStringLiteralByte(const StringLiteral *SL,
43 unsigned ByteNo) const {
Chris Lattner08f92e32010-11-17 07:37:15 +000044 return SL->getLocationOfByte(ByteNo, PP.getSourceManager(),
45 PP.getLangOptions(), PP.getTargetInfo());
Chris Lattner60800082009-02-18 17:49:48 +000046}
47
John McCall8e10f3b2011-02-26 05:39:39 +000048/// Checks that a call expression's argument count is the desired number.
49/// This is useful when doing custom type-checking. Returns true on error.
50static bool checkArgCount(Sema &S, CallExpr *call, unsigned desiredArgCount) {
51 unsigned argCount = call->getNumArgs();
52 if (argCount == desiredArgCount) return false;
53
54 if (argCount < desiredArgCount)
55 return S.Diag(call->getLocEnd(), diag::err_typecheck_call_too_few_args)
56 << 0 /*function call*/ << desiredArgCount << argCount
57 << call->getSourceRange();
58
59 // Highlight all the excess arguments.
60 SourceRange range(call->getArg(desiredArgCount)->getLocStart(),
61 call->getArg(argCount - 1)->getLocEnd());
62
63 return S.Diag(range.getBegin(), diag::err_typecheck_call_too_many_args)
64 << 0 /*function call*/ << desiredArgCount << argCount
65 << call->getArg(1)->getSourceRange();
66}
67
Julien Lerouge77f68bb2011-09-09 22:41:49 +000068/// CheckBuiltinAnnotationString - Checks that string argument to the builtin
69/// annotation is a non wide string literal.
70static bool CheckBuiltinAnnotationString(Sema &S, Expr *Arg) {
71 Arg = Arg->IgnoreParenCasts();
72 StringLiteral *Literal = dyn_cast<StringLiteral>(Arg);
73 if (!Literal || !Literal->isAscii()) {
74 S.Diag(Arg->getLocStart(), diag::err_builtin_annotation_not_string_constant)
75 << Arg->getSourceRange();
76 return true;
77 }
78 return false;
79}
80
John McCall60d7b3a2010-08-24 06:29:42 +000081ExprResult
Anders Carlssond406bf02009-08-16 01:56:34 +000082Sema::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
John McCall60d7b3a2010-08-24 06:29:42 +000083 ExprResult TheCallResult(Owned(TheCall));
Douglas Gregor2def4832008-11-17 20:34:05 +000084
Chris Lattner946928f2010-10-01 23:23:24 +000085 // Find out if any arguments are required to be integer constant expressions.
86 unsigned ICEArguments = 0;
87 ASTContext::GetBuiltinTypeError Error;
88 Context.GetBuiltinType(BuiltinID, Error, &ICEArguments);
89 if (Error != ASTContext::GE_None)
90 ICEArguments = 0; // Don't diagnose previously diagnosed errors.
91
92 // If any arguments are required to be ICE's, check and diagnose.
93 for (unsigned ArgNo = 0; ICEArguments != 0; ++ArgNo) {
94 // Skip arguments not required to be ICE's.
95 if ((ICEArguments & (1 << ArgNo)) == 0) continue;
96
97 llvm::APSInt Result;
98 if (SemaBuiltinConstantArg(TheCall, ArgNo, Result))
99 return true;
100 ICEArguments &= ~(1 << ArgNo);
101 }
102
Anders Carlssond406bf02009-08-16 01:56:34 +0000103 switch (BuiltinID) {
Chris Lattner30ce3442007-12-19 23:59:04 +0000104 case Builtin::BI__builtin___CFStringMakeConstantString:
Chris Lattner925e60d2007-12-28 05:29:59 +0000105 assert(TheCall->getNumArgs() == 1 &&
Chris Lattner1b9a0792007-12-20 00:26:33 +0000106 "Wrong # arguments to builtin CFStringMakeConstantString");
Chris Lattner69039812009-02-18 06:01:06 +0000107 if (CheckObjCString(TheCall->getArg(0)))
Sebastian Redl0eb23302009-01-19 00:08:26 +0000108 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000109 break;
Ted Kremenek49ff7a12008-07-09 17:58:53 +0000110 case Builtin::BI__builtin_stdarg_start:
Chris Lattner30ce3442007-12-19 23:59:04 +0000111 case Builtin::BI__builtin_va_start:
Sebastian Redl0eb23302009-01-19 00:08:26 +0000112 if (SemaBuiltinVAStart(TheCall))
113 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000114 break;
Chris Lattner1b9a0792007-12-20 00:26:33 +0000115 case Builtin::BI__builtin_isgreater:
116 case Builtin::BI__builtin_isgreaterequal:
117 case Builtin::BI__builtin_isless:
118 case Builtin::BI__builtin_islessequal:
119 case Builtin::BI__builtin_islessgreater:
120 case Builtin::BI__builtin_isunordered:
Sebastian Redl0eb23302009-01-19 00:08:26 +0000121 if (SemaBuiltinUnorderedCompare(TheCall))
122 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000123 break;
Benjamin Kramere771a7a2010-02-15 22:42:31 +0000124 case Builtin::BI__builtin_fpclassify:
125 if (SemaBuiltinFPClassification(TheCall, 6))
126 return ExprError();
127 break;
Eli Friedman9ac6f622009-08-31 20:06:00 +0000128 case Builtin::BI__builtin_isfinite:
129 case Builtin::BI__builtin_isinf:
130 case Builtin::BI__builtin_isinf_sign:
131 case Builtin::BI__builtin_isnan:
132 case Builtin::BI__builtin_isnormal:
Benjamin Kramer3b1e26b2010-02-16 10:07:31 +0000133 if (SemaBuiltinFPClassification(TheCall, 1))
Eli Friedman9ac6f622009-08-31 20:06:00 +0000134 return ExprError();
135 break;
Eli Friedmand38617c2008-05-14 19:38:39 +0000136 case Builtin::BI__builtin_shufflevector:
Sebastian Redl0eb23302009-01-19 00:08:26 +0000137 return SemaBuiltinShuffleVector(TheCall);
138 // TheCall will be freed by the smart pointer here, but that's fine, since
139 // SemaBuiltinShuffleVector guts it, but then doesn't release it.
Daniel Dunbar4493f792008-07-21 22:59:13 +0000140 case Builtin::BI__builtin_prefetch:
Sebastian Redl0eb23302009-01-19 00:08:26 +0000141 if (SemaBuiltinPrefetch(TheCall))
142 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000143 break;
Daniel Dunbard5f8a4f2008-09-03 21:13:56 +0000144 case Builtin::BI__builtin_object_size:
Sebastian Redl0eb23302009-01-19 00:08:26 +0000145 if (SemaBuiltinObjectSize(TheCall))
146 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000147 break;
Eli Friedmand875fed2009-05-03 04:46:36 +0000148 case Builtin::BI__builtin_longjmp:
149 if (SemaBuiltinLongjmp(TheCall))
150 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000151 break;
John McCall8e10f3b2011-02-26 05:39:39 +0000152
153 case Builtin::BI__builtin_classify_type:
154 if (checkArgCount(*this, TheCall, 1)) return true;
155 TheCall->setType(Context.IntTy);
156 break;
Chris Lattner75c29a02010-10-12 17:47:42 +0000157 case Builtin::BI__builtin_constant_p:
John McCall8e10f3b2011-02-26 05:39:39 +0000158 if (checkArgCount(*this, TheCall, 1)) return true;
159 TheCall->setType(Context.IntTy);
Chris Lattner75c29a02010-10-12 17:47:42 +0000160 break;
Chris Lattner5caa3702009-05-08 06:58:22 +0000161 case Builtin::BI__sync_fetch_and_add:
Douglas Gregora9766412011-11-28 16:30:08 +0000162 case Builtin::BI__sync_fetch_and_add_1:
163 case Builtin::BI__sync_fetch_and_add_2:
164 case Builtin::BI__sync_fetch_and_add_4:
165 case Builtin::BI__sync_fetch_and_add_8:
166 case Builtin::BI__sync_fetch_and_add_16:
Chris Lattner5caa3702009-05-08 06:58:22 +0000167 case Builtin::BI__sync_fetch_and_sub:
Douglas Gregora9766412011-11-28 16:30:08 +0000168 case Builtin::BI__sync_fetch_and_sub_1:
169 case Builtin::BI__sync_fetch_and_sub_2:
170 case Builtin::BI__sync_fetch_and_sub_4:
171 case Builtin::BI__sync_fetch_and_sub_8:
172 case Builtin::BI__sync_fetch_and_sub_16:
Chris Lattner5caa3702009-05-08 06:58:22 +0000173 case Builtin::BI__sync_fetch_and_or:
Douglas Gregora9766412011-11-28 16:30:08 +0000174 case Builtin::BI__sync_fetch_and_or_1:
175 case Builtin::BI__sync_fetch_and_or_2:
176 case Builtin::BI__sync_fetch_and_or_4:
177 case Builtin::BI__sync_fetch_and_or_8:
178 case Builtin::BI__sync_fetch_and_or_16:
Chris Lattner5caa3702009-05-08 06:58:22 +0000179 case Builtin::BI__sync_fetch_and_and:
Douglas Gregora9766412011-11-28 16:30:08 +0000180 case Builtin::BI__sync_fetch_and_and_1:
181 case Builtin::BI__sync_fetch_and_and_2:
182 case Builtin::BI__sync_fetch_and_and_4:
183 case Builtin::BI__sync_fetch_and_and_8:
184 case Builtin::BI__sync_fetch_and_and_16:
Chris Lattner5caa3702009-05-08 06:58:22 +0000185 case Builtin::BI__sync_fetch_and_xor:
Douglas Gregora9766412011-11-28 16:30:08 +0000186 case Builtin::BI__sync_fetch_and_xor_1:
187 case Builtin::BI__sync_fetch_and_xor_2:
188 case Builtin::BI__sync_fetch_and_xor_4:
189 case Builtin::BI__sync_fetch_and_xor_8:
190 case Builtin::BI__sync_fetch_and_xor_16:
Chris Lattner5caa3702009-05-08 06:58:22 +0000191 case Builtin::BI__sync_add_and_fetch:
Douglas Gregora9766412011-11-28 16:30:08 +0000192 case Builtin::BI__sync_add_and_fetch_1:
193 case Builtin::BI__sync_add_and_fetch_2:
194 case Builtin::BI__sync_add_and_fetch_4:
195 case Builtin::BI__sync_add_and_fetch_8:
196 case Builtin::BI__sync_add_and_fetch_16:
Chris Lattner5caa3702009-05-08 06:58:22 +0000197 case Builtin::BI__sync_sub_and_fetch:
Douglas Gregora9766412011-11-28 16:30:08 +0000198 case Builtin::BI__sync_sub_and_fetch_1:
199 case Builtin::BI__sync_sub_and_fetch_2:
200 case Builtin::BI__sync_sub_and_fetch_4:
201 case Builtin::BI__sync_sub_and_fetch_8:
202 case Builtin::BI__sync_sub_and_fetch_16:
Chris Lattner5caa3702009-05-08 06:58:22 +0000203 case Builtin::BI__sync_and_and_fetch:
Douglas Gregora9766412011-11-28 16:30:08 +0000204 case Builtin::BI__sync_and_and_fetch_1:
205 case Builtin::BI__sync_and_and_fetch_2:
206 case Builtin::BI__sync_and_and_fetch_4:
207 case Builtin::BI__sync_and_and_fetch_8:
208 case Builtin::BI__sync_and_and_fetch_16:
Chris Lattner5caa3702009-05-08 06:58:22 +0000209 case Builtin::BI__sync_or_and_fetch:
Douglas Gregora9766412011-11-28 16:30:08 +0000210 case Builtin::BI__sync_or_and_fetch_1:
211 case Builtin::BI__sync_or_and_fetch_2:
212 case Builtin::BI__sync_or_and_fetch_4:
213 case Builtin::BI__sync_or_and_fetch_8:
214 case Builtin::BI__sync_or_and_fetch_16:
Chris Lattner5caa3702009-05-08 06:58:22 +0000215 case Builtin::BI__sync_xor_and_fetch:
Douglas Gregora9766412011-11-28 16:30:08 +0000216 case Builtin::BI__sync_xor_and_fetch_1:
217 case Builtin::BI__sync_xor_and_fetch_2:
218 case Builtin::BI__sync_xor_and_fetch_4:
219 case Builtin::BI__sync_xor_and_fetch_8:
220 case Builtin::BI__sync_xor_and_fetch_16:
Chris Lattner5caa3702009-05-08 06:58:22 +0000221 case Builtin::BI__sync_val_compare_and_swap:
Douglas Gregora9766412011-11-28 16:30:08 +0000222 case Builtin::BI__sync_val_compare_and_swap_1:
223 case Builtin::BI__sync_val_compare_and_swap_2:
224 case Builtin::BI__sync_val_compare_and_swap_4:
225 case Builtin::BI__sync_val_compare_and_swap_8:
226 case Builtin::BI__sync_val_compare_and_swap_16:
Chris Lattner5caa3702009-05-08 06:58:22 +0000227 case Builtin::BI__sync_bool_compare_and_swap:
Douglas Gregora9766412011-11-28 16:30:08 +0000228 case Builtin::BI__sync_bool_compare_and_swap_1:
229 case Builtin::BI__sync_bool_compare_and_swap_2:
230 case Builtin::BI__sync_bool_compare_and_swap_4:
231 case Builtin::BI__sync_bool_compare_and_swap_8:
232 case Builtin::BI__sync_bool_compare_and_swap_16:
Chris Lattner5caa3702009-05-08 06:58:22 +0000233 case Builtin::BI__sync_lock_test_and_set:
Douglas Gregora9766412011-11-28 16:30:08 +0000234 case Builtin::BI__sync_lock_test_and_set_1:
235 case Builtin::BI__sync_lock_test_and_set_2:
236 case Builtin::BI__sync_lock_test_and_set_4:
237 case Builtin::BI__sync_lock_test_and_set_8:
238 case Builtin::BI__sync_lock_test_and_set_16:
Chris Lattner5caa3702009-05-08 06:58:22 +0000239 case Builtin::BI__sync_lock_release:
Douglas Gregora9766412011-11-28 16:30:08 +0000240 case Builtin::BI__sync_lock_release_1:
241 case Builtin::BI__sync_lock_release_2:
242 case Builtin::BI__sync_lock_release_4:
243 case Builtin::BI__sync_lock_release_8:
244 case Builtin::BI__sync_lock_release_16:
Chris Lattner23aa9c82011-04-09 03:57:26 +0000245 case Builtin::BI__sync_swap:
Douglas Gregora9766412011-11-28 16:30:08 +0000246 case Builtin::BI__sync_swap_1:
247 case Builtin::BI__sync_swap_2:
248 case Builtin::BI__sync_swap_4:
249 case Builtin::BI__sync_swap_8:
250 case Builtin::BI__sync_swap_16:
Chandler Carruthd2014572010-07-09 18:59:35 +0000251 return SemaBuiltinAtomicOverloaded(move(TheCallResult));
Eli Friedman276b0612011-10-11 02:20:01 +0000252 case Builtin::BI__atomic_load:
253 return SemaAtomicOpsOverloaded(move(TheCallResult), AtomicExpr::Load);
254 case Builtin::BI__atomic_store:
255 return SemaAtomicOpsOverloaded(move(TheCallResult), AtomicExpr::Store);
David Chisnall7a7ee302012-01-16 17:27:18 +0000256 case Builtin::BI__atomic_init:
257 return SemaAtomicOpsOverloaded(move(TheCallResult), AtomicExpr::Init);
Eli Friedman276b0612011-10-11 02:20:01 +0000258 case Builtin::BI__atomic_exchange:
259 return SemaAtomicOpsOverloaded(move(TheCallResult), AtomicExpr::Xchg);
260 case Builtin::BI__atomic_compare_exchange_strong:
261 return SemaAtomicOpsOverloaded(move(TheCallResult),
262 AtomicExpr::CmpXchgStrong);
263 case Builtin::BI__atomic_compare_exchange_weak:
264 return SemaAtomicOpsOverloaded(move(TheCallResult),
265 AtomicExpr::CmpXchgWeak);
266 case Builtin::BI__atomic_fetch_add:
267 return SemaAtomicOpsOverloaded(move(TheCallResult), AtomicExpr::Add);
268 case Builtin::BI__atomic_fetch_sub:
269 return SemaAtomicOpsOverloaded(move(TheCallResult), AtomicExpr::Sub);
270 case Builtin::BI__atomic_fetch_and:
271 return SemaAtomicOpsOverloaded(move(TheCallResult), AtomicExpr::And);
272 case Builtin::BI__atomic_fetch_or:
273 return SemaAtomicOpsOverloaded(move(TheCallResult), AtomicExpr::Or);
274 case Builtin::BI__atomic_fetch_xor:
275 return SemaAtomicOpsOverloaded(move(TheCallResult), AtomicExpr::Xor);
Julien Lerouge77f68bb2011-09-09 22:41:49 +0000276 case Builtin::BI__builtin_annotation:
277 if (CheckBuiltinAnnotationString(*this, TheCall->getArg(1)))
278 return ExprError();
279 break;
Nate Begeman26a31422010-06-08 02:47:44 +0000280 }
281
282 // Since the target specific builtins for each arch overlap, only check those
283 // of the arch we are compiling for.
284 if (BuiltinID >= Builtin::FirstTSBuiltin) {
Douglas Gregorbcfd1f52011-09-02 00:18:52 +0000285 switch (Context.getTargetInfo().getTriple().getArch()) {
Nate Begeman26a31422010-06-08 02:47:44 +0000286 case llvm::Triple::arm:
287 case llvm::Triple::thumb:
288 if (CheckARMBuiltinFunctionCall(BuiltinID, TheCall))
289 return ExprError();
290 break;
Nate Begeman26a31422010-06-08 02:47:44 +0000291 default:
292 break;
293 }
294 }
295
296 return move(TheCallResult);
297}
298
Nate Begeman61eecf52010-06-14 05:21:25 +0000299// Get the valid immediate range for the specified NEON type code.
300static unsigned RFT(unsigned t, bool shift = false) {
Bob Wilsonda95f732011-11-08 01:16:11 +0000301 NeonTypeFlags Type(t);
302 int IsQuad = Type.isQuad();
303 switch (Type.getEltType()) {
304 case NeonTypeFlags::Int8:
305 case NeonTypeFlags::Poly8:
306 return shift ? 7 : (8 << IsQuad) - 1;
307 case NeonTypeFlags::Int16:
308 case NeonTypeFlags::Poly16:
309 return shift ? 15 : (4 << IsQuad) - 1;
310 case NeonTypeFlags::Int32:
311 return shift ? 31 : (2 << IsQuad) - 1;
312 case NeonTypeFlags::Int64:
313 return shift ? 63 : (1 << IsQuad) - 1;
314 case NeonTypeFlags::Float16:
315 assert(!shift && "cannot shift float types!");
316 return (4 << IsQuad) - 1;
317 case NeonTypeFlags::Float32:
318 assert(!shift && "cannot shift float types!");
319 return (2 << IsQuad) - 1;
Nate Begeman61eecf52010-06-14 05:21:25 +0000320 }
David Blaikie7530c032012-01-17 06:56:22 +0000321 llvm_unreachable("Invalid NeonTypeFlag!");
Nate Begeman61eecf52010-06-14 05:21:25 +0000322}
323
Bob Wilson6f9f03e2011-11-08 05:04:11 +0000324/// getNeonEltType - Return the QualType corresponding to the elements of
325/// the vector type specified by the NeonTypeFlags. This is used to check
326/// the pointer arguments for Neon load/store intrinsics.
327static QualType getNeonEltType(NeonTypeFlags Flags, ASTContext &Context) {
328 switch (Flags.getEltType()) {
329 case NeonTypeFlags::Int8:
330 return Flags.isUnsigned() ? Context.UnsignedCharTy : Context.SignedCharTy;
331 case NeonTypeFlags::Int16:
332 return Flags.isUnsigned() ? Context.UnsignedShortTy : Context.ShortTy;
333 case NeonTypeFlags::Int32:
334 return Flags.isUnsigned() ? Context.UnsignedIntTy : Context.IntTy;
335 case NeonTypeFlags::Int64:
336 return Flags.isUnsigned() ? Context.UnsignedLongLongTy : Context.LongLongTy;
337 case NeonTypeFlags::Poly8:
338 return Context.SignedCharTy;
339 case NeonTypeFlags::Poly16:
340 return Context.ShortTy;
341 case NeonTypeFlags::Float16:
342 return Context.UnsignedShortTy;
343 case NeonTypeFlags::Float32:
344 return Context.FloatTy;
345 }
David Blaikie7530c032012-01-17 06:56:22 +0000346 llvm_unreachable("Invalid NeonTypeFlag!");
Bob Wilson6f9f03e2011-11-08 05:04:11 +0000347}
348
Nate Begeman26a31422010-06-08 02:47:44 +0000349bool Sema::CheckARMBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
Nate Begeman1c2a88c2010-06-09 01:10:23 +0000350 llvm::APSInt Result;
351
Nate Begeman0d15c532010-06-13 04:47:52 +0000352 unsigned mask = 0;
Nate Begeman61eecf52010-06-14 05:21:25 +0000353 unsigned TV = 0;
Bob Wilson46482552011-11-16 21:32:23 +0000354 int PtrArgNum = -1;
Bob Wilson6f9f03e2011-11-08 05:04:11 +0000355 bool HasConstPtr = false;
Nate Begeman1c2a88c2010-06-09 01:10:23 +0000356 switch (BuiltinID) {
Nate Begemana23326b2010-06-17 04:17:01 +0000357#define GET_NEON_OVERLOAD_CHECK
358#include "clang/Basic/arm_neon.inc"
359#undef GET_NEON_OVERLOAD_CHECK
Nate Begeman1c2a88c2010-06-09 01:10:23 +0000360 }
361
Nate Begeman0d15c532010-06-13 04:47:52 +0000362 // For NEON intrinsics which are overloaded on vector element type, validate
363 // the immediate which specifies which variant to emit.
Bob Wilson6f9f03e2011-11-08 05:04:11 +0000364 unsigned ImmArg = TheCall->getNumArgs()-1;
Nate Begeman0d15c532010-06-13 04:47:52 +0000365 if (mask) {
Bob Wilson6f9f03e2011-11-08 05:04:11 +0000366 if (SemaBuiltinConstantArg(TheCall, ImmArg, Result))
Nate Begeman0d15c532010-06-13 04:47:52 +0000367 return true;
368
Bob Wilsonda95f732011-11-08 01:16:11 +0000369 TV = Result.getLimitedValue(64);
370 if ((TV > 63) || (mask & (1 << TV)) == 0)
Nate Begeman0d15c532010-06-13 04:47:52 +0000371 return Diag(TheCall->getLocStart(), diag::err_invalid_neon_type_code)
Bob Wilson6f9f03e2011-11-08 05:04:11 +0000372 << TheCall->getArg(ImmArg)->getSourceRange();
373 }
374
Bob Wilson46482552011-11-16 21:32:23 +0000375 if (PtrArgNum >= 0) {
Bob Wilson6f9f03e2011-11-08 05:04:11 +0000376 // Check that pointer arguments have the specified type.
Bob Wilson46482552011-11-16 21:32:23 +0000377 Expr *Arg = TheCall->getArg(PtrArgNum);
378 if (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Arg))
379 Arg = ICE->getSubExpr();
380 ExprResult RHS = DefaultFunctionArrayLvalueConversion(Arg);
381 QualType RHSTy = RHS.get()->getType();
382 QualType EltTy = getNeonEltType(NeonTypeFlags(TV), Context);
383 if (HasConstPtr)
384 EltTy = EltTy.withConst();
385 QualType LHSTy = Context.getPointerType(EltTy);
386 AssignConvertType ConvTy;
387 ConvTy = CheckSingleAssignmentConstraints(LHSTy, RHS);
388 if (RHS.isInvalid())
389 return true;
390 if (DiagnoseAssignmentResult(ConvTy, Arg->getLocStart(), LHSTy, RHSTy,
391 RHS.get(), AA_Assigning))
392 return true;
Nate Begeman0d15c532010-06-13 04:47:52 +0000393 }
Nate Begeman1c2a88c2010-06-09 01:10:23 +0000394
Nate Begeman0d15c532010-06-13 04:47:52 +0000395 // For NEON intrinsics which take an immediate value as part of the
396 // instruction, range check them here.
Nate Begeman61eecf52010-06-14 05:21:25 +0000397 unsigned i = 0, l = 0, u = 0;
Nate Begeman0d15c532010-06-13 04:47:52 +0000398 switch (BuiltinID) {
399 default: return false;
Nate Begemanbb37f502010-07-29 22:48:34 +0000400 case ARM::BI__builtin_arm_ssat: i = 1; l = 1; u = 31; break;
401 case ARM::BI__builtin_arm_usat: i = 1; u = 31; break;
Nate Begeman99c40bb2010-08-03 21:32:34 +0000402 case ARM::BI__builtin_arm_vcvtr_f:
403 case ARM::BI__builtin_arm_vcvtr_d: i = 1; u = 1; break;
Nate Begemana23326b2010-06-17 04:17:01 +0000404#define GET_NEON_IMMEDIATE_CHECK
405#include "clang/Basic/arm_neon.inc"
406#undef GET_NEON_IMMEDIATE_CHECK
Nate Begeman0d15c532010-06-13 04:47:52 +0000407 };
408
Nate Begeman61eecf52010-06-14 05:21:25 +0000409 // Check that the immediate argument is actually a constant.
Nate Begeman0d15c532010-06-13 04:47:52 +0000410 if (SemaBuiltinConstantArg(TheCall, i, Result))
411 return true;
412
Nate Begeman61eecf52010-06-14 05:21:25 +0000413 // Range check against the upper/lower values for this isntruction.
Nate Begeman0d15c532010-06-13 04:47:52 +0000414 unsigned Val = Result.getZExtValue();
Nate Begeman61eecf52010-06-14 05:21:25 +0000415 if (Val < l || Val > (u + l))
Nate Begeman0d15c532010-06-13 04:47:52 +0000416 return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
Benjamin Kramer476d8b82010-08-11 14:47:12 +0000417 << l << u+l << TheCall->getArg(i)->getSourceRange();
Nate Begeman0d15c532010-06-13 04:47:52 +0000418
Nate Begeman99c40bb2010-08-03 21:32:34 +0000419 // FIXME: VFP Intrinsics should error if VFP not present.
Nate Begeman26a31422010-06-08 02:47:44 +0000420 return false;
Anders Carlssond406bf02009-08-16 01:56:34 +0000421}
Daniel Dunbarde454282008-10-02 18:44:07 +0000422
Anders Carlssond406bf02009-08-16 01:56:34 +0000423/// CheckFunctionCall - Check a direct function call for various correctness
424/// and safety properties not strictly enforced by the C type system.
425bool Sema::CheckFunctionCall(FunctionDecl *FDecl, CallExpr *TheCall) {
426 // Get the IdentifierInfo* for the called function.
427 IdentifierInfo *FnInfo = FDecl->getIdentifier();
428
429 // None of the checks below are needed for functions that don't have
430 // simple names (e.g., C++ conversion functions).
431 if (!FnInfo)
432 return false;
Mike Stump1eb44332009-09-09 15:08:12 +0000433
Daniel Dunbarde454282008-10-02 18:44:07 +0000434 // FIXME: This mechanism should be abstracted to be less fragile and
435 // more efficient. For example, just map function ids to custom
436 // handlers.
437
Ted Kremenekc82faca2010-09-09 04:33:05 +0000438 // Printf and scanf checking.
439 for (specific_attr_iterator<FormatAttr>
440 i = FDecl->specific_attr_begin<FormatAttr>(),
441 e = FDecl->specific_attr_end<FormatAttr>(); i != e ; ++i) {
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +0000442 CheckFormatArguments(*i, TheCall);
Chris Lattner59907c42007-08-10 20:18:51 +0000443 }
Mike Stump1eb44332009-09-09 15:08:12 +0000444
Ted Kremenekc82faca2010-09-09 04:33:05 +0000445 for (specific_attr_iterator<NonNullAttr>
446 i = FDecl->specific_attr_begin<NonNullAttr>(),
447 e = FDecl->specific_attr_end<NonNullAttr>(); i != e; ++i) {
Nick Lewycky909a70d2011-03-25 01:44:32 +0000448 CheckNonNullArguments(*i, TheCall->getArgs(),
449 TheCall->getCallee()->getLocStart());
Ted Kremenekc82faca2010-09-09 04:33:05 +0000450 }
Sebastian Redl0eb23302009-01-19 00:08:26 +0000451
Anna Zaks0a151a12012-01-17 00:37:07 +0000452 unsigned CMId = FDecl->getMemoryFunctionKind();
453 if (CMId == 0)
Anna Zaksd9b859a2012-01-13 21:52:01 +0000454 return false;
Ted Kremenekbd5da9d2011-08-18 20:55:45 +0000455
Anna Zaksd9b859a2012-01-13 21:52:01 +0000456 // Handle memory setting and copying functions.
Anna Zaks0a151a12012-01-17 00:37:07 +0000457 if (CMId == Builtin::BIstrlcpy || CMId == Builtin::BIstrlcat)
Ted Kremenekbd5da9d2011-08-18 20:55:45 +0000458 CheckStrlcpycatArguments(TheCall, FnInfo);
Anna Zaksd9b859a2012-01-13 21:52:01 +0000459 else
Anna Zaks0a151a12012-01-17 00:37:07 +0000460 CheckMemaccessArguments(TheCall, CMId, FnInfo);
Chandler Carruth7ccc95b2011-04-27 07:05:31 +0000461
Anders Carlssond406bf02009-08-16 01:56:34 +0000462 return false;
Anders Carlsson71993dd2007-08-17 05:31:46 +0000463}
464
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +0000465bool Sema::CheckObjCMethodCall(ObjCMethodDecl *Method, SourceLocation lbrac,
466 Expr **Args, unsigned NumArgs) {
467 for (specific_attr_iterator<FormatAttr>
468 i = Method->specific_attr_begin<FormatAttr>(),
469 e = Method->specific_attr_end<FormatAttr>(); i != e ; ++i) {
470
471 CheckFormatArguments(*i, Args, NumArgs, false, lbrac,
472 Method->getSourceRange());
473 }
474
475 // diagnose nonnull arguments.
476 for (specific_attr_iterator<NonNullAttr>
477 i = Method->specific_attr_begin<NonNullAttr>(),
478 e = Method->specific_attr_end<NonNullAttr>(); i != e; ++i) {
479 CheckNonNullArguments(*i, Args, lbrac);
480 }
481
482 return false;
483}
484
Anders Carlssond406bf02009-08-16 01:56:34 +0000485bool Sema::CheckBlockCall(NamedDecl *NDecl, CallExpr *TheCall) {
Fariborz Jahanian725165f2009-05-18 21:05:18 +0000486 const VarDecl *V = dyn_cast<VarDecl>(NDecl);
487 if (!V)
Anders Carlssond406bf02009-08-16 01:56:34 +0000488 return false;
Mike Stump1eb44332009-09-09 15:08:12 +0000489
Fariborz Jahanian725165f2009-05-18 21:05:18 +0000490 QualType Ty = V->getType();
491 if (!Ty->isBlockPointerType())
Anders Carlssond406bf02009-08-16 01:56:34 +0000492 return false;
Mike Stump1eb44332009-09-09 15:08:12 +0000493
Jean-Daniel Dupas43d12512012-01-25 00:55:11 +0000494 // format string checking.
495 for (specific_attr_iterator<FormatAttr>
496 i = NDecl->specific_attr_begin<FormatAttr>(),
497 e = NDecl->specific_attr_end<FormatAttr>(); i != e ; ++i) {
498 CheckFormatArguments(*i, TheCall);
499 }
Anders Carlssond406bf02009-08-16 01:56:34 +0000500
501 return false;
Fariborz Jahanian725165f2009-05-18 21:05:18 +0000502}
503
Eli Friedman276b0612011-10-11 02:20:01 +0000504ExprResult
505Sema::SemaAtomicOpsOverloaded(ExprResult TheCallResult, AtomicExpr::AtomicOp Op) {
506 CallExpr *TheCall = cast<CallExpr>(TheCallResult.get());
507 DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts());
Eli Friedman276b0612011-10-11 02:20:01 +0000508
509 // All these operations take one of the following four forms:
510 // T __atomic_load(_Atomic(T)*, int) (loads)
511 // T* __atomic_add(_Atomic(T*)*, ptrdiff_t, int) (pointer add/sub)
512 // int __atomic_compare_exchange_strong(_Atomic(T)*, T*, T, int, int)
513 // (cmpxchg)
514 // T __atomic_exchange(_Atomic(T)*, T, int) (everything else)
515 // where T is an appropriate type, and the int paremeterss are for orderings.
516 unsigned NumVals = 1;
517 unsigned NumOrders = 1;
518 if (Op == AtomicExpr::Load) {
519 NumVals = 0;
520 } else if (Op == AtomicExpr::CmpXchgWeak || Op == AtomicExpr::CmpXchgStrong) {
521 NumVals = 2;
522 NumOrders = 2;
523 }
David Chisnall7a7ee302012-01-16 17:27:18 +0000524 if (Op == AtomicExpr::Init)
525 NumOrders = 0;
Eli Friedman276b0612011-10-11 02:20:01 +0000526
527 if (TheCall->getNumArgs() < NumVals+NumOrders+1) {
528 Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args)
529 << 0 << NumVals+NumOrders+1 << TheCall->getNumArgs()
530 << TheCall->getCallee()->getSourceRange();
531 return ExprError();
532 } else if (TheCall->getNumArgs() > NumVals+NumOrders+1) {
533 Diag(TheCall->getArg(NumVals+NumOrders+1)->getLocStart(),
534 diag::err_typecheck_call_too_many_args)
535 << 0 << NumVals+NumOrders+1 << TheCall->getNumArgs()
536 << TheCall->getCallee()->getSourceRange();
537 return ExprError();
538 }
539
540 // Inspect the first argument of the atomic operation. This should always be
541 // a pointer to an _Atomic type.
Eli Friedmandfa64ba2011-10-14 22:48:56 +0000542 Expr *Ptr = TheCall->getArg(0);
Eli Friedman276b0612011-10-11 02:20:01 +0000543 Ptr = DefaultFunctionArrayLvalueConversion(Ptr).get();
544 const PointerType *pointerType = Ptr->getType()->getAs<PointerType>();
545 if (!pointerType) {
546 Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic)
547 << Ptr->getType() << Ptr->getSourceRange();
548 return ExprError();
549 }
550
551 QualType AtomTy = pointerType->getPointeeType();
552 if (!AtomTy->isAtomicType()) {
553 Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic)
554 << Ptr->getType() << Ptr->getSourceRange();
555 return ExprError();
556 }
557 QualType ValType = AtomTy->getAs<AtomicType>()->getValueType();
558
559 if ((Op == AtomicExpr::Add || Op == AtomicExpr::Sub) &&
560 !ValType->isIntegerType() && !ValType->isPointerType()) {
561 Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic_int_or_ptr)
562 << Ptr->getType() << Ptr->getSourceRange();
563 return ExprError();
564 }
565
566 if (!ValType->isIntegerType() &&
567 (Op == AtomicExpr::And || Op == AtomicExpr::Or || Op == AtomicExpr::Xor)){
568 Diag(DRE->getLocStart(), diag::err_atomic_op_logical_needs_atomic_int)
569 << Ptr->getType() << Ptr->getSourceRange();
570 return ExprError();
571 }
572
573 switch (ValType.getObjCLifetime()) {
574 case Qualifiers::OCL_None:
575 case Qualifiers::OCL_ExplicitNone:
576 // okay
577 break;
578
579 case Qualifiers::OCL_Weak:
580 case Qualifiers::OCL_Strong:
581 case Qualifiers::OCL_Autoreleasing:
582 Diag(DRE->getLocStart(), diag::err_arc_atomic_ownership)
583 << ValType << Ptr->getSourceRange();
584 return ExprError();
585 }
586
587 QualType ResultType = ValType;
David Chisnall7a7ee302012-01-16 17:27:18 +0000588 if (Op == AtomicExpr::Store || Op == AtomicExpr::Init)
Eli Friedman276b0612011-10-11 02:20:01 +0000589 ResultType = Context.VoidTy;
590 else if (Op == AtomicExpr::CmpXchgWeak || Op == AtomicExpr::CmpXchgStrong)
591 ResultType = Context.BoolTy;
592
593 // The first argument --- the pointer --- has a fixed type; we
594 // deduce the types of the rest of the arguments accordingly. Walk
595 // the remaining arguments, converting them to the deduced value type.
596 for (unsigned i = 1; i != NumVals+NumOrders+1; ++i) {
597 ExprResult Arg = TheCall->getArg(i);
598 QualType Ty;
599 if (i < NumVals+1) {
600 // The second argument to a cmpxchg is a pointer to the data which will
601 // be exchanged. The second argument to a pointer add/subtract is the
602 // amount to add/subtract, which must be a ptrdiff_t. The third
603 // argument to a cmpxchg and the second argument in all other cases
604 // is the type of the value.
605 if (i == 1 && (Op == AtomicExpr::CmpXchgWeak ||
606 Op == AtomicExpr::CmpXchgStrong))
607 Ty = Context.getPointerType(ValType.getUnqualifiedType());
608 else if (!ValType->isIntegerType() &&
609 (Op == AtomicExpr::Add || Op == AtomicExpr::Sub))
610 Ty = Context.getPointerDiffType();
611 else
612 Ty = ValType;
613 } else {
614 // The order(s) are always converted to int.
615 Ty = Context.IntTy;
616 }
617 InitializedEntity Entity =
618 InitializedEntity::InitializeParameter(Context, Ty, false);
619 Arg = PerformCopyInitialization(Entity, SourceLocation(), Arg);
620 if (Arg.isInvalid())
621 return true;
622 TheCall->setArg(i, Arg.get());
623 }
624
Eli Friedmandfa64ba2011-10-14 22:48:56 +0000625 SmallVector<Expr*, 5> SubExprs;
626 SubExprs.push_back(Ptr);
Eli Friedman276b0612011-10-11 02:20:01 +0000627 if (Op == AtomicExpr::Load) {
Eli Friedmandfa64ba2011-10-14 22:48:56 +0000628 SubExprs.push_back(TheCall->getArg(1)); // Order
David Chisnall7a7ee302012-01-16 17:27:18 +0000629 } else if (Op == AtomicExpr::Init) {
630 SubExprs.push_back(TheCall->getArg(1)); // Val1
Eli Friedman276b0612011-10-11 02:20:01 +0000631 } else if (Op != AtomicExpr::CmpXchgWeak && Op != AtomicExpr::CmpXchgStrong) {
Eli Friedmandfa64ba2011-10-14 22:48:56 +0000632 SubExprs.push_back(TheCall->getArg(2)); // Order
633 SubExprs.push_back(TheCall->getArg(1)); // Val1
Eli Friedman276b0612011-10-11 02:20:01 +0000634 } else {
Eli Friedmandfa64ba2011-10-14 22:48:56 +0000635 SubExprs.push_back(TheCall->getArg(3)); // Order
636 SubExprs.push_back(TheCall->getArg(1)); // Val1
637 SubExprs.push_back(TheCall->getArg(2)); // Val2
638 SubExprs.push_back(TheCall->getArg(4)); // OrderFail
Eli Friedman276b0612011-10-11 02:20:01 +0000639 }
Eli Friedmandfa64ba2011-10-14 22:48:56 +0000640
641 return Owned(new (Context) AtomicExpr(TheCall->getCallee()->getLocStart(),
642 SubExprs.data(), SubExprs.size(),
643 ResultType, Op,
644 TheCall->getRParenLoc()));
Eli Friedman276b0612011-10-11 02:20:01 +0000645}
646
647
John McCall5f8d6042011-08-27 01:09:30 +0000648/// checkBuiltinArgument - Given a call to a builtin function, perform
649/// normal type-checking on the given argument, updating the call in
650/// place. This is useful when a builtin function requires custom
651/// type-checking for some of its arguments but not necessarily all of
652/// them.
653///
654/// Returns true on error.
655static bool checkBuiltinArgument(Sema &S, CallExpr *E, unsigned ArgIndex) {
656 FunctionDecl *Fn = E->getDirectCallee();
657 assert(Fn && "builtin call without direct callee!");
658
659 ParmVarDecl *Param = Fn->getParamDecl(ArgIndex);
660 InitializedEntity Entity =
661 InitializedEntity::InitializeParameter(S.Context, Param);
662
663 ExprResult Arg = E->getArg(0);
664 Arg = S.PerformCopyInitialization(Entity, SourceLocation(), Arg);
665 if (Arg.isInvalid())
666 return true;
667
668 E->setArg(ArgIndex, Arg.take());
669 return false;
670}
671
Chris Lattner5caa3702009-05-08 06:58:22 +0000672/// SemaBuiltinAtomicOverloaded - We have a call to a function like
673/// __sync_fetch_and_add, which is an overloaded function based on the pointer
674/// type of its first argument. The main ActOnCallExpr routines have already
675/// promoted the types of arguments because all of these calls are prototyped as
676/// void(...).
677///
678/// This function goes through and does final semantic checking for these
679/// builtins,
John McCall60d7b3a2010-08-24 06:29:42 +0000680ExprResult
681Sema::SemaBuiltinAtomicOverloaded(ExprResult TheCallResult) {
Chandler Carruthd2014572010-07-09 18:59:35 +0000682 CallExpr *TheCall = (CallExpr *)TheCallResult.get();
Chris Lattner5caa3702009-05-08 06:58:22 +0000683 DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts());
684 FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl());
685
686 // Ensure that we have at least one argument to do type inference from.
Chandler Carruthd2014572010-07-09 18:59:35 +0000687 if (TheCall->getNumArgs() < 1) {
688 Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least)
689 << 0 << 1 << TheCall->getNumArgs()
690 << TheCall->getCallee()->getSourceRange();
691 return ExprError();
692 }
Mike Stump1eb44332009-09-09 15:08:12 +0000693
Chris Lattner5caa3702009-05-08 06:58:22 +0000694 // Inspect the first argument of the atomic builtin. This should always be
695 // a pointer type, whose element is an integral scalar or pointer type.
696 // Because it is a pointer type, we don't have to worry about any implicit
697 // casts here.
Chandler Carruthd2014572010-07-09 18:59:35 +0000698 // FIXME: We don't allow floating point scalars as input.
Chris Lattner5caa3702009-05-08 06:58:22 +0000699 Expr *FirstArg = TheCall->getArg(0);
Eli Friedman8c382062012-01-23 02:35:22 +0000700 ExprResult FirstArgResult = DefaultFunctionArrayLvalueConversion(FirstArg);
701 if (FirstArgResult.isInvalid())
702 return ExprError();
703 FirstArg = FirstArgResult.take();
704 TheCall->setArg(0, FirstArg);
705
John McCallf85e1932011-06-15 23:02:42 +0000706 const PointerType *pointerType = FirstArg->getType()->getAs<PointerType>();
707 if (!pointerType) {
Chandler Carruthd2014572010-07-09 18:59:35 +0000708 Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer)
709 << FirstArg->getType() << FirstArg->getSourceRange();
710 return ExprError();
711 }
Mike Stump1eb44332009-09-09 15:08:12 +0000712
John McCallf85e1932011-06-15 23:02:42 +0000713 QualType ValType = pointerType->getPointeeType();
Chris Lattnerdd5fa7a2010-09-17 21:12:38 +0000714 if (!ValType->isIntegerType() && !ValType->isAnyPointerType() &&
Chandler Carruthd2014572010-07-09 18:59:35 +0000715 !ValType->isBlockPointerType()) {
716 Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer_intptr)
717 << FirstArg->getType() << FirstArg->getSourceRange();
718 return ExprError();
719 }
Chris Lattner5caa3702009-05-08 06:58:22 +0000720
John McCallf85e1932011-06-15 23:02:42 +0000721 switch (ValType.getObjCLifetime()) {
722 case Qualifiers::OCL_None:
723 case Qualifiers::OCL_ExplicitNone:
724 // okay
725 break;
726
727 case Qualifiers::OCL_Weak:
728 case Qualifiers::OCL_Strong:
729 case Qualifiers::OCL_Autoreleasing:
Argyrios Kyrtzidisb8b03132011-06-24 00:08:59 +0000730 Diag(DRE->getLocStart(), diag::err_arc_atomic_ownership)
John McCallf85e1932011-06-15 23:02:42 +0000731 << ValType << FirstArg->getSourceRange();
732 return ExprError();
733 }
734
John McCallb45ae252011-10-05 07:41:44 +0000735 // Strip any qualifiers off ValType.
736 ValType = ValType.getUnqualifiedType();
737
Chandler Carruth8d13d222010-07-18 20:54:12 +0000738 // The majority of builtins return a value, but a few have special return
739 // types, so allow them to override appropriately below.
740 QualType ResultType = ValType;
741
Chris Lattner5caa3702009-05-08 06:58:22 +0000742 // We need to figure out which concrete builtin this maps onto. For example,
743 // __sync_fetch_and_add with a 2 byte object turns into
744 // __sync_fetch_and_add_2.
745#define BUILTIN_ROW(x) \
746 { Builtin::BI##x##_1, Builtin::BI##x##_2, Builtin::BI##x##_4, \
747 Builtin::BI##x##_8, Builtin::BI##x##_16 }
Mike Stump1eb44332009-09-09 15:08:12 +0000748
Chris Lattner5caa3702009-05-08 06:58:22 +0000749 static const unsigned BuiltinIndices[][5] = {
750 BUILTIN_ROW(__sync_fetch_and_add),
751 BUILTIN_ROW(__sync_fetch_and_sub),
752 BUILTIN_ROW(__sync_fetch_and_or),
753 BUILTIN_ROW(__sync_fetch_and_and),
754 BUILTIN_ROW(__sync_fetch_and_xor),
Mike Stump1eb44332009-09-09 15:08:12 +0000755
Chris Lattner5caa3702009-05-08 06:58:22 +0000756 BUILTIN_ROW(__sync_add_and_fetch),
757 BUILTIN_ROW(__sync_sub_and_fetch),
758 BUILTIN_ROW(__sync_and_and_fetch),
759 BUILTIN_ROW(__sync_or_and_fetch),
760 BUILTIN_ROW(__sync_xor_and_fetch),
Mike Stump1eb44332009-09-09 15:08:12 +0000761
Chris Lattner5caa3702009-05-08 06:58:22 +0000762 BUILTIN_ROW(__sync_val_compare_and_swap),
763 BUILTIN_ROW(__sync_bool_compare_and_swap),
764 BUILTIN_ROW(__sync_lock_test_and_set),
Chris Lattner23aa9c82011-04-09 03:57:26 +0000765 BUILTIN_ROW(__sync_lock_release),
766 BUILTIN_ROW(__sync_swap)
Chris Lattner5caa3702009-05-08 06:58:22 +0000767 };
Mike Stump1eb44332009-09-09 15:08:12 +0000768#undef BUILTIN_ROW
769
Chris Lattner5caa3702009-05-08 06:58:22 +0000770 // Determine the index of the size.
771 unsigned SizeIndex;
Ken Dyck199c3d62010-01-11 17:06:35 +0000772 switch (Context.getTypeSizeInChars(ValType).getQuantity()) {
Chris Lattner5caa3702009-05-08 06:58:22 +0000773 case 1: SizeIndex = 0; break;
774 case 2: SizeIndex = 1; break;
775 case 4: SizeIndex = 2; break;
776 case 8: SizeIndex = 3; break;
777 case 16: SizeIndex = 4; break;
778 default:
Chandler Carruthd2014572010-07-09 18:59:35 +0000779 Diag(DRE->getLocStart(), diag::err_atomic_builtin_pointer_size)
780 << FirstArg->getType() << FirstArg->getSourceRange();
781 return ExprError();
Chris Lattner5caa3702009-05-08 06:58:22 +0000782 }
Mike Stump1eb44332009-09-09 15:08:12 +0000783
Chris Lattner5caa3702009-05-08 06:58:22 +0000784 // Each of these builtins has one pointer argument, followed by some number of
785 // values (0, 1 or 2) followed by a potentially empty varags list of stuff
786 // that we ignore. Find out which row of BuiltinIndices to read from as well
787 // as the number of fixed args.
Douglas Gregor7814e6d2009-09-12 00:22:50 +0000788 unsigned BuiltinID = FDecl->getBuiltinID();
Chris Lattner5caa3702009-05-08 06:58:22 +0000789 unsigned BuiltinIndex, NumFixed = 1;
790 switch (BuiltinID) {
David Blaikieb219cfc2011-09-23 05:06:16 +0000791 default: llvm_unreachable("Unknown overloaded atomic builtin!");
Douglas Gregora9766412011-11-28 16:30:08 +0000792 case Builtin::BI__sync_fetch_and_add:
793 case Builtin::BI__sync_fetch_and_add_1:
794 case Builtin::BI__sync_fetch_and_add_2:
795 case Builtin::BI__sync_fetch_and_add_4:
796 case Builtin::BI__sync_fetch_and_add_8:
797 case Builtin::BI__sync_fetch_and_add_16:
798 BuiltinIndex = 0;
799 break;
800
801 case Builtin::BI__sync_fetch_and_sub:
802 case Builtin::BI__sync_fetch_and_sub_1:
803 case Builtin::BI__sync_fetch_and_sub_2:
804 case Builtin::BI__sync_fetch_and_sub_4:
805 case Builtin::BI__sync_fetch_and_sub_8:
806 case Builtin::BI__sync_fetch_and_sub_16:
807 BuiltinIndex = 1;
808 break;
809
810 case Builtin::BI__sync_fetch_and_or:
811 case Builtin::BI__sync_fetch_and_or_1:
812 case Builtin::BI__sync_fetch_and_or_2:
813 case Builtin::BI__sync_fetch_and_or_4:
814 case Builtin::BI__sync_fetch_and_or_8:
815 case Builtin::BI__sync_fetch_and_or_16:
816 BuiltinIndex = 2;
817 break;
818
819 case Builtin::BI__sync_fetch_and_and:
820 case Builtin::BI__sync_fetch_and_and_1:
821 case Builtin::BI__sync_fetch_and_and_2:
822 case Builtin::BI__sync_fetch_and_and_4:
823 case Builtin::BI__sync_fetch_and_and_8:
824 case Builtin::BI__sync_fetch_and_and_16:
825 BuiltinIndex = 3;
826 break;
Mike Stump1eb44332009-09-09 15:08:12 +0000827
Douglas Gregora9766412011-11-28 16:30:08 +0000828 case Builtin::BI__sync_fetch_and_xor:
829 case Builtin::BI__sync_fetch_and_xor_1:
830 case Builtin::BI__sync_fetch_and_xor_2:
831 case Builtin::BI__sync_fetch_and_xor_4:
832 case Builtin::BI__sync_fetch_and_xor_8:
833 case Builtin::BI__sync_fetch_and_xor_16:
834 BuiltinIndex = 4;
835 break;
836
837 case Builtin::BI__sync_add_and_fetch:
838 case Builtin::BI__sync_add_and_fetch_1:
839 case Builtin::BI__sync_add_and_fetch_2:
840 case Builtin::BI__sync_add_and_fetch_4:
841 case Builtin::BI__sync_add_and_fetch_8:
842 case Builtin::BI__sync_add_and_fetch_16:
843 BuiltinIndex = 5;
844 break;
845
846 case Builtin::BI__sync_sub_and_fetch:
847 case Builtin::BI__sync_sub_and_fetch_1:
848 case Builtin::BI__sync_sub_and_fetch_2:
849 case Builtin::BI__sync_sub_and_fetch_4:
850 case Builtin::BI__sync_sub_and_fetch_8:
851 case Builtin::BI__sync_sub_and_fetch_16:
852 BuiltinIndex = 6;
853 break;
854
855 case Builtin::BI__sync_and_and_fetch:
856 case Builtin::BI__sync_and_and_fetch_1:
857 case Builtin::BI__sync_and_and_fetch_2:
858 case Builtin::BI__sync_and_and_fetch_4:
859 case Builtin::BI__sync_and_and_fetch_8:
860 case Builtin::BI__sync_and_and_fetch_16:
861 BuiltinIndex = 7;
862 break;
863
864 case Builtin::BI__sync_or_and_fetch:
865 case Builtin::BI__sync_or_and_fetch_1:
866 case Builtin::BI__sync_or_and_fetch_2:
867 case Builtin::BI__sync_or_and_fetch_4:
868 case Builtin::BI__sync_or_and_fetch_8:
869 case Builtin::BI__sync_or_and_fetch_16:
870 BuiltinIndex = 8;
871 break;
872
873 case Builtin::BI__sync_xor_and_fetch:
874 case Builtin::BI__sync_xor_and_fetch_1:
875 case Builtin::BI__sync_xor_and_fetch_2:
876 case Builtin::BI__sync_xor_and_fetch_4:
877 case Builtin::BI__sync_xor_and_fetch_8:
878 case Builtin::BI__sync_xor_and_fetch_16:
879 BuiltinIndex = 9;
880 break;
Mike Stump1eb44332009-09-09 15:08:12 +0000881
Chris Lattner5caa3702009-05-08 06:58:22 +0000882 case Builtin::BI__sync_val_compare_and_swap:
Douglas Gregora9766412011-11-28 16:30:08 +0000883 case Builtin::BI__sync_val_compare_and_swap_1:
884 case Builtin::BI__sync_val_compare_and_swap_2:
885 case Builtin::BI__sync_val_compare_and_swap_4:
886 case Builtin::BI__sync_val_compare_and_swap_8:
887 case Builtin::BI__sync_val_compare_and_swap_16:
Daniel Dunbar7eff7c42010-03-25 17:13:09 +0000888 BuiltinIndex = 10;
Chris Lattner5caa3702009-05-08 06:58:22 +0000889 NumFixed = 2;
890 break;
Douglas Gregora9766412011-11-28 16:30:08 +0000891
Chris Lattner5caa3702009-05-08 06:58:22 +0000892 case Builtin::BI__sync_bool_compare_and_swap:
Douglas Gregora9766412011-11-28 16:30:08 +0000893 case Builtin::BI__sync_bool_compare_and_swap_1:
894 case Builtin::BI__sync_bool_compare_and_swap_2:
895 case Builtin::BI__sync_bool_compare_and_swap_4:
896 case Builtin::BI__sync_bool_compare_and_swap_8:
897 case Builtin::BI__sync_bool_compare_and_swap_16:
Daniel Dunbar7eff7c42010-03-25 17:13:09 +0000898 BuiltinIndex = 11;
Chris Lattner5caa3702009-05-08 06:58:22 +0000899 NumFixed = 2;
Chandler Carruth8d13d222010-07-18 20:54:12 +0000900 ResultType = Context.BoolTy;
Chris Lattner5caa3702009-05-08 06:58:22 +0000901 break;
Douglas Gregora9766412011-11-28 16:30:08 +0000902
903 case Builtin::BI__sync_lock_test_and_set:
904 case Builtin::BI__sync_lock_test_and_set_1:
905 case Builtin::BI__sync_lock_test_and_set_2:
906 case Builtin::BI__sync_lock_test_and_set_4:
907 case Builtin::BI__sync_lock_test_and_set_8:
908 case Builtin::BI__sync_lock_test_and_set_16:
909 BuiltinIndex = 12;
910 break;
911
Chris Lattner5caa3702009-05-08 06:58:22 +0000912 case Builtin::BI__sync_lock_release:
Douglas Gregora9766412011-11-28 16:30:08 +0000913 case Builtin::BI__sync_lock_release_1:
914 case Builtin::BI__sync_lock_release_2:
915 case Builtin::BI__sync_lock_release_4:
916 case Builtin::BI__sync_lock_release_8:
917 case Builtin::BI__sync_lock_release_16:
Daniel Dunbar7eff7c42010-03-25 17:13:09 +0000918 BuiltinIndex = 13;
Chris Lattner5caa3702009-05-08 06:58:22 +0000919 NumFixed = 0;
Chandler Carruth8d13d222010-07-18 20:54:12 +0000920 ResultType = Context.VoidTy;
Chris Lattner5caa3702009-05-08 06:58:22 +0000921 break;
Douglas Gregora9766412011-11-28 16:30:08 +0000922
923 case Builtin::BI__sync_swap:
924 case Builtin::BI__sync_swap_1:
925 case Builtin::BI__sync_swap_2:
926 case Builtin::BI__sync_swap_4:
927 case Builtin::BI__sync_swap_8:
928 case Builtin::BI__sync_swap_16:
929 BuiltinIndex = 14;
930 break;
Chris Lattner5caa3702009-05-08 06:58:22 +0000931 }
Mike Stump1eb44332009-09-09 15:08:12 +0000932
Chris Lattner5caa3702009-05-08 06:58:22 +0000933 // Now that we know how many fixed arguments we expect, first check that we
934 // have at least that many.
Chandler Carruthd2014572010-07-09 18:59:35 +0000935 if (TheCall->getNumArgs() < 1+NumFixed) {
936 Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least)
937 << 0 << 1+NumFixed << TheCall->getNumArgs()
938 << TheCall->getCallee()->getSourceRange();
939 return ExprError();
940 }
Mike Stump1eb44332009-09-09 15:08:12 +0000941
Chris Lattnere7ac0a92009-05-08 15:36:58 +0000942 // Get the decl for the concrete builtin from this, we can tell what the
943 // concrete integer type we should convert to is.
944 unsigned NewBuiltinID = BuiltinIndices[BuiltinIndex][SizeIndex];
945 const char *NewBuiltinName = Context.BuiltinInfo.GetName(NewBuiltinID);
946 IdentifierInfo *NewBuiltinII = PP.getIdentifierInfo(NewBuiltinName);
Mike Stump1eb44332009-09-09 15:08:12 +0000947 FunctionDecl *NewBuiltinDecl =
Chris Lattnere7ac0a92009-05-08 15:36:58 +0000948 cast<FunctionDecl>(LazilyCreateBuiltin(NewBuiltinII, NewBuiltinID,
949 TUScope, false, DRE->getLocStart()));
Chandler Carruthd2014572010-07-09 18:59:35 +0000950
John McCallf871d0c2010-08-07 06:22:56 +0000951 // The first argument --- the pointer --- has a fixed type; we
952 // deduce the types of the rest of the arguments accordingly. Walk
953 // the remaining arguments, converting them to the deduced value type.
Chris Lattner5caa3702009-05-08 06:58:22 +0000954 for (unsigned i = 0; i != NumFixed; ++i) {
John Wiegley429bb272011-04-08 18:41:53 +0000955 ExprResult Arg = TheCall->getArg(i+1);
Mike Stump1eb44332009-09-09 15:08:12 +0000956
Chris Lattner5caa3702009-05-08 06:58:22 +0000957 // GCC does an implicit conversion to the pointer or integer ValType. This
958 // can fail in some cases (1i -> int**), check for this error case now.
John McCallb45ae252011-10-05 07:41:44 +0000959 // Initialize the argument.
960 InitializedEntity Entity = InitializedEntity::InitializeParameter(Context,
961 ValType, /*consume*/ false);
962 Arg = PerformCopyInitialization(Entity, SourceLocation(), Arg);
John Wiegley429bb272011-04-08 18:41:53 +0000963 if (Arg.isInvalid())
Chandler Carruthd2014572010-07-09 18:59:35 +0000964 return ExprError();
Mike Stump1eb44332009-09-09 15:08:12 +0000965
Chris Lattner5caa3702009-05-08 06:58:22 +0000966 // Okay, we have something that *can* be converted to the right type. Check
967 // to see if there is a potentially weird extension going on here. This can
968 // happen when you do an atomic operation on something like an char* and
969 // pass in 42. The 42 gets converted to char. This is even more strange
970 // for things like 45.123 -> char, etc.
Mike Stump1eb44332009-09-09 15:08:12 +0000971 // FIXME: Do this check.
John McCallb45ae252011-10-05 07:41:44 +0000972 TheCall->setArg(i+1, Arg.take());
Chris Lattner5caa3702009-05-08 06:58:22 +0000973 }
Mike Stump1eb44332009-09-09 15:08:12 +0000974
Douglas Gregorbbcb7ea2011-09-09 16:51:10 +0000975 ASTContext& Context = this->getASTContext();
976
977 // Create a new DeclRefExpr to refer to the new decl.
978 DeclRefExpr* NewDRE = DeclRefExpr::Create(
979 Context,
980 DRE->getQualifierLoc(),
Abramo Bagnarae4b92762012-01-27 09:46:47 +0000981 SourceLocation(),
Douglas Gregorbbcb7ea2011-09-09 16:51:10 +0000982 NewBuiltinDecl,
983 DRE->getLocation(),
984 NewBuiltinDecl->getType(),
985 DRE->getValueKind());
Mike Stump1eb44332009-09-09 15:08:12 +0000986
Chris Lattner5caa3702009-05-08 06:58:22 +0000987 // Set the callee in the CallExpr.
988 // FIXME: This leaks the original parens and implicit casts.
Douglas Gregorbbcb7ea2011-09-09 16:51:10 +0000989 ExprResult PromotedCall = UsualUnaryConversions(NewDRE);
John Wiegley429bb272011-04-08 18:41:53 +0000990 if (PromotedCall.isInvalid())
991 return ExprError();
992 TheCall->setCallee(PromotedCall.take());
Mike Stump1eb44332009-09-09 15:08:12 +0000993
Chandler Carruthdb4325b2010-07-18 07:23:17 +0000994 // Change the result type of the call to match the original value type. This
995 // is arbitrary, but the codegen for these builtins ins design to handle it
996 // gracefully.
Chandler Carruth8d13d222010-07-18 20:54:12 +0000997 TheCall->setType(ResultType);
Chandler Carruthd2014572010-07-09 18:59:35 +0000998
999 return move(TheCallResult);
Chris Lattner5caa3702009-05-08 06:58:22 +00001000}
1001
Chris Lattner69039812009-02-18 06:01:06 +00001002/// CheckObjCString - Checks that the argument to the builtin
Anders Carlsson71993dd2007-08-17 05:31:46 +00001003/// CFString constructor is correct
Steve Narofffd942622009-04-13 20:26:29 +00001004/// Note: It might also make sense to do the UTF-16 conversion here (would
1005/// simplify the backend).
Chris Lattner69039812009-02-18 06:01:06 +00001006bool Sema::CheckObjCString(Expr *Arg) {
Chris Lattner56f34942008-02-13 01:02:39 +00001007 Arg = Arg->IgnoreParenCasts();
Anders Carlsson71993dd2007-08-17 05:31:46 +00001008 StringLiteral *Literal = dyn_cast<StringLiteral>(Arg);
1009
Douglas Gregor5cee1192011-07-27 05:40:30 +00001010 if (!Literal || !Literal->isAscii()) {
Chris Lattnerfa25bbb2008-11-19 05:08:23 +00001011 Diag(Arg->getLocStart(), diag::err_cfstring_literal_not_string_constant)
1012 << Arg->getSourceRange();
Anders Carlsson9cdc4d32007-08-17 15:44:17 +00001013 return true;
Anders Carlsson71993dd2007-08-17 05:31:46 +00001014 }
Mike Stump1eb44332009-09-09 15:08:12 +00001015
Fariborz Jahanian7da71022010-09-07 19:38:13 +00001016 if (Literal->containsNonAsciiOrNull()) {
Chris Lattner5f9e2722011-07-23 10:55:15 +00001017 StringRef String = Literal->getString();
Fariborz Jahanian7da71022010-09-07 19:38:13 +00001018 unsigned NumBytes = String.size();
Chris Lattner5f9e2722011-07-23 10:55:15 +00001019 SmallVector<UTF16, 128> ToBuf(NumBytes);
Fariborz Jahanian7da71022010-09-07 19:38:13 +00001020 const UTF8 *FromPtr = (UTF8 *)String.data();
1021 UTF16 *ToPtr = &ToBuf[0];
1022
1023 ConversionResult Result = ConvertUTF8toUTF16(&FromPtr, FromPtr + NumBytes,
1024 &ToPtr, ToPtr + NumBytes,
1025 strictConversion);
1026 // Check for conversion failure.
1027 if (Result != conversionOK)
1028 Diag(Arg->getLocStart(),
1029 diag::warn_cfstring_truncated) << Arg->getSourceRange();
1030 }
Anders Carlsson9cdc4d32007-08-17 15:44:17 +00001031 return false;
Chris Lattner59907c42007-08-10 20:18:51 +00001032}
1033
Chris Lattnerc27c6652007-12-20 00:05:45 +00001034/// SemaBuiltinVAStart - Check the arguments to __builtin_va_start for validity.
1035/// Emit an error and return true on failure, return false on success.
Chris Lattner925e60d2007-12-28 05:29:59 +00001036bool Sema::SemaBuiltinVAStart(CallExpr *TheCall) {
1037 Expr *Fn = TheCall->getCallee();
1038 if (TheCall->getNumArgs() > 2) {
Chris Lattner2c21a072008-11-21 18:44:24 +00001039 Diag(TheCall->getArg(2)->getLocStart(),
Chris Lattnerfa25bbb2008-11-19 05:08:23 +00001040 diag::err_typecheck_call_too_many_args)
Eric Christopherccfa9632010-04-16 04:56:46 +00001041 << 0 /*function call*/ << 2 << TheCall->getNumArgs()
1042 << Fn->getSourceRange()
Mike Stump1eb44332009-09-09 15:08:12 +00001043 << SourceRange(TheCall->getArg(2)->getLocStart(),
Chris Lattnerfa25bbb2008-11-19 05:08:23 +00001044 (*(TheCall->arg_end()-1))->getLocEnd());
Chris Lattner30ce3442007-12-19 23:59:04 +00001045 return true;
1046 }
Eli Friedman56f20ae2008-12-15 22:05:35 +00001047
1048 if (TheCall->getNumArgs() < 2) {
Eric Christopherd77b9a22010-04-16 04:48:22 +00001049 return Diag(TheCall->getLocEnd(),
1050 diag::err_typecheck_call_too_few_args_at_least)
1051 << 0 /*function call*/ << 2 << TheCall->getNumArgs();
Eli Friedman56f20ae2008-12-15 22:05:35 +00001052 }
1053
John McCall5f8d6042011-08-27 01:09:30 +00001054 // Type-check the first argument normally.
1055 if (checkBuiltinArgument(*this, TheCall, 0))
1056 return true;
1057
Chris Lattnerc27c6652007-12-20 00:05:45 +00001058 // Determine whether the current function is variadic or not.
Douglas Gregor9ea9bdb2010-03-01 23:15:13 +00001059 BlockScopeInfo *CurBlock = getCurBlock();
Chris Lattnerc27c6652007-12-20 00:05:45 +00001060 bool isVariadic;
Steve Naroffcd9c5142009-04-15 19:33:47 +00001061 if (CurBlock)
John McCallc71a4912010-06-04 19:02:56 +00001062 isVariadic = CurBlock->TheDecl->isVariadic();
Ted Kremenek9498d382010-04-29 16:49:01 +00001063 else if (FunctionDecl *FD = getCurFunctionDecl())
1064 isVariadic = FD->isVariadic();
1065 else
Argyrios Kyrtzidis53d0ea52008-06-28 06:07:14 +00001066 isVariadic = getCurMethodDecl()->isVariadic();
Mike Stump1eb44332009-09-09 15:08:12 +00001067
Chris Lattnerc27c6652007-12-20 00:05:45 +00001068 if (!isVariadic) {
Chris Lattner30ce3442007-12-19 23:59:04 +00001069 Diag(Fn->getLocStart(), diag::err_va_start_used_in_non_variadic_function);
1070 return true;
1071 }
Mike Stump1eb44332009-09-09 15:08:12 +00001072
Chris Lattner30ce3442007-12-19 23:59:04 +00001073 // Verify that the second argument to the builtin is the last argument of the
1074 // current function or method.
1075 bool SecondArgIsLastNamedArgument = false;
Anders Carlssone2c14102008-02-13 01:22:59 +00001076 const Expr *Arg = TheCall->getArg(1)->IgnoreParenCasts();
Mike Stump1eb44332009-09-09 15:08:12 +00001077
Anders Carlsson88cf2262008-02-11 04:20:54 +00001078 if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Arg)) {
1079 if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(DR->getDecl())) {
Chris Lattner30ce3442007-12-19 23:59:04 +00001080 // FIXME: This isn't correct for methods (results in bogus warning).
1081 // Get the last formal in the current function.
Anders Carlsson88cf2262008-02-11 04:20:54 +00001082 const ParmVarDecl *LastArg;
Steve Naroffcd9c5142009-04-15 19:33:47 +00001083 if (CurBlock)
1084 LastArg = *(CurBlock->TheDecl->param_end()-1);
1085 else if (FunctionDecl *FD = getCurFunctionDecl())
Chris Lattner371f2582008-12-04 23:50:19 +00001086 LastArg = *(FD->param_end()-1);
Chris Lattner30ce3442007-12-19 23:59:04 +00001087 else
Argyrios Kyrtzidis53d0ea52008-06-28 06:07:14 +00001088 LastArg = *(getCurMethodDecl()->param_end()-1);
Chris Lattner30ce3442007-12-19 23:59:04 +00001089 SecondArgIsLastNamedArgument = PV == LastArg;
1090 }
1091 }
Mike Stump1eb44332009-09-09 15:08:12 +00001092
Chris Lattner30ce3442007-12-19 23:59:04 +00001093 if (!SecondArgIsLastNamedArgument)
Mike Stump1eb44332009-09-09 15:08:12 +00001094 Diag(TheCall->getArg(1)->getLocStart(),
Chris Lattner30ce3442007-12-19 23:59:04 +00001095 diag::warn_second_parameter_of_va_start_not_last_named_argument);
1096 return false;
Eli Friedman6cfda232008-05-20 08:23:37 +00001097}
Chris Lattner30ce3442007-12-19 23:59:04 +00001098
Chris Lattner1b9a0792007-12-20 00:26:33 +00001099/// SemaBuiltinUnorderedCompare - Handle functions like __builtin_isgreater and
1100/// friends. This is declared to take (...), so we have to check everything.
Chris Lattner925e60d2007-12-28 05:29:59 +00001101bool Sema::SemaBuiltinUnorderedCompare(CallExpr *TheCall) {
1102 if (TheCall->getNumArgs() < 2)
Chris Lattner2c21a072008-11-21 18:44:24 +00001103 return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args)
Eric Christopherd77b9a22010-04-16 04:48:22 +00001104 << 0 << 2 << TheCall->getNumArgs()/*function call*/;
Chris Lattner925e60d2007-12-28 05:29:59 +00001105 if (TheCall->getNumArgs() > 2)
Mike Stump1eb44332009-09-09 15:08:12 +00001106 return Diag(TheCall->getArg(2)->getLocStart(),
Chris Lattnerfa25bbb2008-11-19 05:08:23 +00001107 diag::err_typecheck_call_too_many_args)
Eric Christopherccfa9632010-04-16 04:56:46 +00001108 << 0 /*function call*/ << 2 << TheCall->getNumArgs()
Chris Lattnerfa25bbb2008-11-19 05:08:23 +00001109 << SourceRange(TheCall->getArg(2)->getLocStart(),
1110 (*(TheCall->arg_end()-1))->getLocEnd());
Mike Stump1eb44332009-09-09 15:08:12 +00001111
John Wiegley429bb272011-04-08 18:41:53 +00001112 ExprResult OrigArg0 = TheCall->getArg(0);
1113 ExprResult OrigArg1 = TheCall->getArg(1);
Douglas Gregorcde01732009-05-19 22:10:17 +00001114
Chris Lattner1b9a0792007-12-20 00:26:33 +00001115 // Do standard promotions between the two arguments, returning their common
1116 // type.
Chris Lattner925e60d2007-12-28 05:29:59 +00001117 QualType Res = UsualArithmeticConversions(OrigArg0, OrigArg1, false);
John Wiegley429bb272011-04-08 18:41:53 +00001118 if (OrigArg0.isInvalid() || OrigArg1.isInvalid())
1119 return true;
Daniel Dunbar403bc2b2009-02-19 19:28:43 +00001120
1121 // Make sure any conversions are pushed back into the call; this is
1122 // type safe since unordered compare builtins are declared as "_Bool
1123 // foo(...)".
John Wiegley429bb272011-04-08 18:41:53 +00001124 TheCall->setArg(0, OrigArg0.get());
1125 TheCall->setArg(1, OrigArg1.get());
Mike Stump1eb44332009-09-09 15:08:12 +00001126
John Wiegley429bb272011-04-08 18:41:53 +00001127 if (OrigArg0.get()->isTypeDependent() || OrigArg1.get()->isTypeDependent())
Douglas Gregorcde01732009-05-19 22:10:17 +00001128 return false;
1129
Chris Lattner1b9a0792007-12-20 00:26:33 +00001130 // If the common type isn't a real floating type, then the arguments were
1131 // invalid for this operation.
1132 if (!Res->isRealFloatingType())
John Wiegley429bb272011-04-08 18:41:53 +00001133 return Diag(OrigArg0.get()->getLocStart(),
Chris Lattnerfa25bbb2008-11-19 05:08:23 +00001134 diag::err_typecheck_call_invalid_ordered_compare)
John Wiegley429bb272011-04-08 18:41:53 +00001135 << OrigArg0.get()->getType() << OrigArg1.get()->getType()
1136 << SourceRange(OrigArg0.get()->getLocStart(), OrigArg1.get()->getLocEnd());
Mike Stump1eb44332009-09-09 15:08:12 +00001137
Chris Lattner1b9a0792007-12-20 00:26:33 +00001138 return false;
1139}
1140
Benjamin Kramere771a7a2010-02-15 22:42:31 +00001141/// SemaBuiltinSemaBuiltinFPClassification - Handle functions like
1142/// __builtin_isnan and friends. This is declared to take (...), so we have
Benjamin Kramer3b1e26b2010-02-16 10:07:31 +00001143/// to check everything. We expect the last argument to be a floating point
1144/// value.
1145bool Sema::SemaBuiltinFPClassification(CallExpr *TheCall, unsigned NumArgs) {
1146 if (TheCall->getNumArgs() < NumArgs)
Eli Friedman9ac6f622009-08-31 20:06:00 +00001147 return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args)
Eric Christopherd77b9a22010-04-16 04:48:22 +00001148 << 0 << NumArgs << TheCall->getNumArgs()/*function call*/;
Benjamin Kramer3b1e26b2010-02-16 10:07:31 +00001149 if (TheCall->getNumArgs() > NumArgs)
1150 return Diag(TheCall->getArg(NumArgs)->getLocStart(),
Eli Friedman9ac6f622009-08-31 20:06:00 +00001151 diag::err_typecheck_call_too_many_args)
Eric Christopherccfa9632010-04-16 04:56:46 +00001152 << 0 /*function call*/ << NumArgs << TheCall->getNumArgs()
Benjamin Kramer3b1e26b2010-02-16 10:07:31 +00001153 << SourceRange(TheCall->getArg(NumArgs)->getLocStart(),
Eli Friedman9ac6f622009-08-31 20:06:00 +00001154 (*(TheCall->arg_end()-1))->getLocEnd());
1155
Benjamin Kramer3b1e26b2010-02-16 10:07:31 +00001156 Expr *OrigArg = TheCall->getArg(NumArgs-1);
Mike Stump1eb44332009-09-09 15:08:12 +00001157
Eli Friedman9ac6f622009-08-31 20:06:00 +00001158 if (OrigArg->isTypeDependent())
1159 return false;
1160
Chris Lattner81368fb2010-05-06 05:50:07 +00001161 // This operation requires a non-_Complex floating-point number.
Eli Friedman9ac6f622009-08-31 20:06:00 +00001162 if (!OrigArg->getType()->isRealFloatingType())
Mike Stump1eb44332009-09-09 15:08:12 +00001163 return Diag(OrigArg->getLocStart(),
Eli Friedman9ac6f622009-08-31 20:06:00 +00001164 diag::err_typecheck_call_invalid_unary_fp)
1165 << OrigArg->getType() << OrigArg->getSourceRange();
Mike Stump1eb44332009-09-09 15:08:12 +00001166
Chris Lattner81368fb2010-05-06 05:50:07 +00001167 // If this is an implicit conversion from float -> double, remove it.
1168 if (ImplicitCastExpr *Cast = dyn_cast<ImplicitCastExpr>(OrigArg)) {
1169 Expr *CastArg = Cast->getSubExpr();
1170 if (CastArg->getType()->isSpecificBuiltinType(BuiltinType::Float)) {
1171 assert(Cast->getType()->isSpecificBuiltinType(BuiltinType::Double) &&
1172 "promotion from float to double is the only expected cast here");
1173 Cast->setSubExpr(0);
Chris Lattner81368fb2010-05-06 05:50:07 +00001174 TheCall->setArg(NumArgs-1, CastArg);
1175 OrigArg = CastArg;
1176 }
1177 }
1178
Eli Friedman9ac6f622009-08-31 20:06:00 +00001179 return false;
1180}
1181
Eli Friedmand38617c2008-05-14 19:38:39 +00001182/// SemaBuiltinShuffleVector - Handle __builtin_shufflevector.
1183// This is declared to take (...), so we have to check everything.
John McCall60d7b3a2010-08-24 06:29:42 +00001184ExprResult Sema::SemaBuiltinShuffleVector(CallExpr *TheCall) {
Nate Begeman37b6a572010-06-08 00:16:34 +00001185 if (TheCall->getNumArgs() < 2)
Sebastian Redl0eb23302009-01-19 00:08:26 +00001186 return ExprError(Diag(TheCall->getLocEnd(),
Eric Christopherd77b9a22010-04-16 04:48:22 +00001187 diag::err_typecheck_call_too_few_args_at_least)
Nate Begeman37b6a572010-06-08 00:16:34 +00001188 << 0 /*function call*/ << 2 << TheCall->getNumArgs()
Eric Christopherd77b9a22010-04-16 04:48:22 +00001189 << TheCall->getSourceRange());
Eli Friedmand38617c2008-05-14 19:38:39 +00001190
Nate Begeman37b6a572010-06-08 00:16:34 +00001191 // Determine which of the following types of shufflevector we're checking:
1192 // 1) unary, vector mask: (lhs, mask)
1193 // 2) binary, vector mask: (lhs, rhs, mask)
1194 // 3) binary, scalar mask: (lhs, rhs, index, ..., index)
1195 QualType resType = TheCall->getArg(0)->getType();
1196 unsigned numElements = 0;
1197
Douglas Gregorcde01732009-05-19 22:10:17 +00001198 if (!TheCall->getArg(0)->isTypeDependent() &&
1199 !TheCall->getArg(1)->isTypeDependent()) {
Nate Begeman37b6a572010-06-08 00:16:34 +00001200 QualType LHSType = TheCall->getArg(0)->getType();
1201 QualType RHSType = TheCall->getArg(1)->getType();
1202
1203 if (!LHSType->isVectorType() || !RHSType->isVectorType()) {
Douglas Gregorcde01732009-05-19 22:10:17 +00001204 Diag(TheCall->getLocStart(), diag::err_shufflevector_non_vector)
Mike Stump1eb44332009-09-09 15:08:12 +00001205 << SourceRange(TheCall->getArg(0)->getLocStart(),
Douglas Gregorcde01732009-05-19 22:10:17 +00001206 TheCall->getArg(1)->getLocEnd());
1207 return ExprError();
1208 }
Nate Begeman37b6a572010-06-08 00:16:34 +00001209
1210 numElements = LHSType->getAs<VectorType>()->getNumElements();
1211 unsigned numResElements = TheCall->getNumArgs() - 2;
Mike Stump1eb44332009-09-09 15:08:12 +00001212
Nate Begeman37b6a572010-06-08 00:16:34 +00001213 // Check to see if we have a call with 2 vector arguments, the unary shuffle
1214 // with mask. If so, verify that RHS is an integer vector type with the
1215 // same number of elts as lhs.
1216 if (TheCall->getNumArgs() == 2) {
Douglas Gregorf6094622010-07-23 15:58:24 +00001217 if (!RHSType->hasIntegerRepresentation() ||
Nate Begeman37b6a572010-06-08 00:16:34 +00001218 RHSType->getAs<VectorType>()->getNumElements() != numElements)
1219 Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector)
1220 << SourceRange(TheCall->getArg(1)->getLocStart(),
1221 TheCall->getArg(1)->getLocEnd());
1222 numResElements = numElements;
1223 }
1224 else if (!Context.hasSameUnqualifiedType(LHSType, RHSType)) {
Douglas Gregorcde01732009-05-19 22:10:17 +00001225 Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector)
Mike Stump1eb44332009-09-09 15:08:12 +00001226 << SourceRange(TheCall->getArg(0)->getLocStart(),
Douglas Gregorcde01732009-05-19 22:10:17 +00001227 TheCall->getArg(1)->getLocEnd());
1228 return ExprError();
Nate Begeman37b6a572010-06-08 00:16:34 +00001229 } else if (numElements != numResElements) {
1230 QualType eltType = LHSType->getAs<VectorType>()->getElementType();
Chris Lattner788b0fd2010-06-23 06:00:24 +00001231 resType = Context.getVectorType(eltType, numResElements,
Bob Wilsone86d78c2010-11-10 21:56:12 +00001232 VectorType::GenericVector);
Douglas Gregorcde01732009-05-19 22:10:17 +00001233 }
Eli Friedmand38617c2008-05-14 19:38:39 +00001234 }
1235
1236 for (unsigned i = 2; i < TheCall->getNumArgs(); i++) {
Douglas Gregorcde01732009-05-19 22:10:17 +00001237 if (TheCall->getArg(i)->isTypeDependent() ||
1238 TheCall->getArg(i)->isValueDependent())
1239 continue;
1240
Nate Begeman37b6a572010-06-08 00:16:34 +00001241 llvm::APSInt Result(32);
1242 if (!TheCall->getArg(i)->isIntegerConstantExpr(Result, Context))
1243 return ExprError(Diag(TheCall->getLocStart(),
1244 diag::err_shufflevector_nonconstant_argument)
1245 << TheCall->getArg(i)->getSourceRange());
Sebastian Redl0eb23302009-01-19 00:08:26 +00001246
Chris Lattnerd1a0b6d2008-08-10 02:05:13 +00001247 if (Result.getActiveBits() > 64 || Result.getZExtValue() >= numElements*2)
Sebastian Redl0eb23302009-01-19 00:08:26 +00001248 return ExprError(Diag(TheCall->getLocStart(),
Chris Lattnerfa25bbb2008-11-19 05:08:23 +00001249 diag::err_shufflevector_argument_too_large)
Sebastian Redl0eb23302009-01-19 00:08:26 +00001250 << TheCall->getArg(i)->getSourceRange());
Eli Friedmand38617c2008-05-14 19:38:39 +00001251 }
1252
Chris Lattner5f9e2722011-07-23 10:55:15 +00001253 SmallVector<Expr*, 32> exprs;
Eli Friedmand38617c2008-05-14 19:38:39 +00001254
Chris Lattnerd1a0b6d2008-08-10 02:05:13 +00001255 for (unsigned i = 0, e = TheCall->getNumArgs(); i != e; i++) {
Eli Friedmand38617c2008-05-14 19:38:39 +00001256 exprs.push_back(TheCall->getArg(i));
1257 TheCall->setArg(i, 0);
1258 }
1259
Nate Begemana88dc302009-08-12 02:10:25 +00001260 return Owned(new (Context) ShuffleVectorExpr(Context, exprs.begin(),
Nate Begeman37b6a572010-06-08 00:16:34 +00001261 exprs.size(), resType,
Ted Kremenek8189cde2009-02-07 01:47:29 +00001262 TheCall->getCallee()->getLocStart(),
1263 TheCall->getRParenLoc()));
Eli Friedmand38617c2008-05-14 19:38:39 +00001264}
Chris Lattner30ce3442007-12-19 23:59:04 +00001265
Daniel Dunbar4493f792008-07-21 22:59:13 +00001266/// SemaBuiltinPrefetch - Handle __builtin_prefetch.
1267// This is declared to take (const void*, ...) and can take two
1268// optional constant int args.
1269bool Sema::SemaBuiltinPrefetch(CallExpr *TheCall) {
Chris Lattnerfa25bbb2008-11-19 05:08:23 +00001270 unsigned NumArgs = TheCall->getNumArgs();
Daniel Dunbar4493f792008-07-21 22:59:13 +00001271
Chris Lattnerfa25bbb2008-11-19 05:08:23 +00001272 if (NumArgs > 3)
Eric Christopherccfa9632010-04-16 04:56:46 +00001273 return Diag(TheCall->getLocEnd(),
1274 diag::err_typecheck_call_too_many_args_at_most)
1275 << 0 /*function call*/ << 3 << NumArgs
1276 << TheCall->getSourceRange();
Daniel Dunbar4493f792008-07-21 22:59:13 +00001277
1278 // Argument 0 is checked for us and the remaining arguments must be
1279 // constant integers.
Chris Lattnerfa25bbb2008-11-19 05:08:23 +00001280 for (unsigned i = 1; i != NumArgs; ++i) {
Daniel Dunbar4493f792008-07-21 22:59:13 +00001281 Expr *Arg = TheCall->getArg(i);
Eric Christopher691ebc32010-04-17 02:26:23 +00001282
Eli Friedman9aef7262009-12-04 00:30:06 +00001283 llvm::APSInt Result;
Eric Christopher691ebc32010-04-17 02:26:23 +00001284 if (SemaBuiltinConstantArg(TheCall, i, Result))
1285 return true;
Mike Stump1eb44332009-09-09 15:08:12 +00001286
Daniel Dunbar4493f792008-07-21 22:59:13 +00001287 // FIXME: gcc issues a warning and rewrites these to 0. These
1288 // seems especially odd for the third argument since the default
1289 // is 3.
Chris Lattnerfa25bbb2008-11-19 05:08:23 +00001290 if (i == 1) {
Eli Friedman9aef7262009-12-04 00:30:06 +00001291 if (Result.getLimitedValue() > 1)
Chris Lattnerfa25bbb2008-11-19 05:08:23 +00001292 return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
Chris Lattner21fb98e2009-09-23 06:06:36 +00001293 << "0" << "1" << Arg->getSourceRange();
Daniel Dunbar4493f792008-07-21 22:59:13 +00001294 } else {
Eli Friedman9aef7262009-12-04 00:30:06 +00001295 if (Result.getLimitedValue() > 3)
Chris Lattnerfa25bbb2008-11-19 05:08:23 +00001296 return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
Chris Lattner21fb98e2009-09-23 06:06:36 +00001297 << "0" << "3" << Arg->getSourceRange();
Daniel Dunbar4493f792008-07-21 22:59:13 +00001298 }
1299 }
1300
Chris Lattnerfa25bbb2008-11-19 05:08:23 +00001301 return false;
Daniel Dunbar4493f792008-07-21 22:59:13 +00001302}
1303
Eric Christopher691ebc32010-04-17 02:26:23 +00001304/// SemaBuiltinConstantArg - Handle a check if argument ArgNum of CallExpr
1305/// TheCall is a constant expression.
1306bool Sema::SemaBuiltinConstantArg(CallExpr *TheCall, int ArgNum,
1307 llvm::APSInt &Result) {
1308 Expr *Arg = TheCall->getArg(ArgNum);
1309 DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts());
1310 FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl());
1311
1312 if (Arg->isTypeDependent() || Arg->isValueDependent()) return false;
1313
1314 if (!Arg->isIntegerConstantExpr(Result, Context))
1315 return Diag(TheCall->getLocStart(), diag::err_constant_integer_arg_type)
Eric Christopher5e896552010-04-19 18:23:02 +00001316 << FDecl->getDeclName() << Arg->getSourceRange();
Eric Christopher691ebc32010-04-17 02:26:23 +00001317
Chris Lattner21fb98e2009-09-23 06:06:36 +00001318 return false;
1319}
1320
Daniel Dunbard5f8a4f2008-09-03 21:13:56 +00001321/// SemaBuiltinObjectSize - Handle __builtin_object_size(void *ptr,
1322/// int type). This simply type checks that type is one of the defined
1323/// constants (0-3).
Chris Lattnerfc8f0e12011-04-15 05:22:18 +00001324// For compatibility check 0-3, llvm only handles 0 and 2.
Daniel Dunbard5f8a4f2008-09-03 21:13:56 +00001325bool Sema::SemaBuiltinObjectSize(CallExpr *TheCall) {
Eric Christopher691ebc32010-04-17 02:26:23 +00001326 llvm::APSInt Result;
1327
1328 // Check constant-ness first.
1329 if (SemaBuiltinConstantArg(TheCall, 1, Result))
1330 return true;
1331
Daniel Dunbard5f8a4f2008-09-03 21:13:56 +00001332 Expr *Arg = TheCall->getArg(1);
Daniel Dunbard5f8a4f2008-09-03 21:13:56 +00001333 if (Result.getSExtValue() < 0 || Result.getSExtValue() > 3) {
Chris Lattnerfa25bbb2008-11-19 05:08:23 +00001334 return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
1335 << "0" << "3" << SourceRange(Arg->getLocStart(), Arg->getLocEnd());
Daniel Dunbard5f8a4f2008-09-03 21:13:56 +00001336 }
1337
1338 return false;
1339}
1340
Eli Friedman586d6a82009-05-03 06:04:26 +00001341/// SemaBuiltinLongjmp - Handle __builtin_longjmp(void *env[5], int val).
Eli Friedmand875fed2009-05-03 04:46:36 +00001342/// This checks that val is a constant 1.
1343bool Sema::SemaBuiltinLongjmp(CallExpr *TheCall) {
1344 Expr *Arg = TheCall->getArg(1);
Eric Christopher691ebc32010-04-17 02:26:23 +00001345 llvm::APSInt Result;
Douglas Gregorcde01732009-05-19 22:10:17 +00001346
Eric Christopher691ebc32010-04-17 02:26:23 +00001347 // TODO: This is less than ideal. Overload this to take a value.
1348 if (SemaBuiltinConstantArg(TheCall, 1, Result))
1349 return true;
1350
1351 if (Result != 1)
Eli Friedmand875fed2009-05-03 04:46:36 +00001352 return Diag(TheCall->getLocStart(), diag::err_builtin_longjmp_invalid_val)
1353 << SourceRange(Arg->getLocStart(), Arg->getLocEnd());
1354
1355 return false;
1356}
1357
Ted Kremenekb43e8ad2011-02-24 23:03:04 +00001358// Handle i > 1 ? "x" : "y", recursively.
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00001359bool Sema::SemaCheckStringLiteral(const Expr *E, Expr **Args,
1360 unsigned NumArgs, bool HasVAListArg,
Ted Kremenek826a3452010-07-16 02:11:22 +00001361 unsigned format_idx, unsigned firstDataArg,
Jean-Daniel Dupas34269df2012-01-30 08:46:47 +00001362 FormatStringType Type, bool inFunctionCall) {
Ted Kremenek4fe64412010-09-09 03:51:39 +00001363 tryAgain:
Douglas Gregorcde01732009-05-19 22:10:17 +00001364 if (E->isTypeDependent() || E->isValueDependent())
1365 return false;
Ted Kremenekd30ef872009-01-12 23:09:09 +00001366
Jean-Daniel Dupas34269df2012-01-30 08:46:47 +00001367 E = E->IgnoreParenCasts();
Peter Collingbournef111d932011-04-15 00:35:48 +00001368
Ted Kremenekd30ef872009-01-12 23:09:09 +00001369 switch (E->getStmtClass()) {
John McCall56ca35d2011-02-17 10:25:35 +00001370 case Stmt::BinaryConditionalOperatorClass:
Ted Kremenekd30ef872009-01-12 23:09:09 +00001371 case Stmt::ConditionalOperatorClass: {
John McCall56ca35d2011-02-17 10:25:35 +00001372 const AbstractConditionalOperator *C = cast<AbstractConditionalOperator>(E);
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00001373 return SemaCheckStringLiteral(C->getTrueExpr(), Args, NumArgs, HasVAListArg,
Jean-Daniel Dupas34269df2012-01-30 08:46:47 +00001374 format_idx, firstDataArg, Type,
Richard Trieu55733de2011-10-28 00:41:25 +00001375 inFunctionCall)
Jean-Daniel Dupas34269df2012-01-30 08:46:47 +00001376 && SemaCheckStringLiteral(C->getFalseExpr(), Args, NumArgs, HasVAListArg,
1377 format_idx, firstDataArg, Type,
1378 inFunctionCall);
Ted Kremenekd30ef872009-01-12 23:09:09 +00001379 }
1380
Ted Kremenek95355bb2010-09-09 03:51:42 +00001381 case Stmt::IntegerLiteralClass:
1382 // Technically -Wformat-nonliteral does not warn about this case.
1383 // The behavior of printf and friends in this case is implementation
1384 // dependent. Ideally if the format string cannot be null then
1385 // it should have a 'nonnull' attribute in the function prototype.
1386 return true;
1387
Ted Kremenekd30ef872009-01-12 23:09:09 +00001388 case Stmt::ImplicitCastExprClass: {
Ted Kremenek4fe64412010-09-09 03:51:39 +00001389 E = cast<ImplicitCastExpr>(E)->getSubExpr();
1390 goto tryAgain;
Ted Kremenekd30ef872009-01-12 23:09:09 +00001391 }
1392
John McCall56ca35d2011-02-17 10:25:35 +00001393 case Stmt::OpaqueValueExprClass:
1394 if (const Expr *src = cast<OpaqueValueExpr>(E)->getSourceExpr()) {
1395 E = src;
1396 goto tryAgain;
1397 }
1398 return false;
1399
Ted Kremenekb43e8ad2011-02-24 23:03:04 +00001400 case Stmt::PredefinedExprClass:
1401 // While __func__, etc., are technically not string literals, they
1402 // cannot contain format specifiers and thus are not a security
1403 // liability.
1404 return true;
1405
Ted Kremenek082d9362009-03-20 21:35:28 +00001406 case Stmt::DeclRefExprClass: {
1407 const DeclRefExpr *DR = cast<DeclRefExpr>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00001408
Ted Kremenek082d9362009-03-20 21:35:28 +00001409 // As an exception, do not flag errors for variables binding to
1410 // const string literals.
1411 if (const VarDecl *VD = dyn_cast<VarDecl>(DR->getDecl())) {
1412 bool isConstant = false;
1413 QualType T = DR->getType();
Ted Kremenekd30ef872009-01-12 23:09:09 +00001414
Ted Kremenek082d9362009-03-20 21:35:28 +00001415 if (const ArrayType *AT = Context.getAsArrayType(T)) {
1416 isConstant = AT->getElementType().isConstant(Context);
Mike Stumpac5fc7c2009-08-04 21:02:39 +00001417 } else if (const PointerType *PT = T->getAs<PointerType>()) {
Mike Stump1eb44332009-09-09 15:08:12 +00001418 isConstant = T.isConstant(Context) &&
Ted Kremenek082d9362009-03-20 21:35:28 +00001419 PT->getPointeeType().isConstant(Context);
Jean-Daniel Dupase98e5b52012-01-25 10:35:33 +00001420 } else if (T->isObjCObjectPointerType()) {
1421 // In ObjC, there is usually no "const ObjectPointer" type,
1422 // so don't check if the pointee type is constant.
1423 isConstant = T.isConstant(Context);
Ted Kremenek082d9362009-03-20 21:35:28 +00001424 }
Mike Stump1eb44332009-09-09 15:08:12 +00001425
Ted Kremenek082d9362009-03-20 21:35:28 +00001426 if (isConstant) {
Sebastian Redl31310a22010-02-01 20:16:42 +00001427 if (const Expr *Init = VD->getAnyInitializer())
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00001428 return SemaCheckStringLiteral(Init, Args, NumArgs,
Ted Kremenek826a3452010-07-16 02:11:22 +00001429 HasVAListArg, format_idx, firstDataArg,
Jean-Daniel Dupas34269df2012-01-30 08:46:47 +00001430 Type, /*inFunctionCall*/false);
Ted Kremenek082d9362009-03-20 21:35:28 +00001431 }
Mike Stump1eb44332009-09-09 15:08:12 +00001432
Anders Carlssond966a552009-06-28 19:55:58 +00001433 // For vprintf* functions (i.e., HasVAListArg==true), we add a
1434 // special check to see if the format string is a function parameter
1435 // of the function calling the printf function. If the function
1436 // has an attribute indicating it is a printf-like function, then we
1437 // should suppress warnings concerning non-literals being used in a call
1438 // to a vprintf function. For example:
1439 //
1440 // void
1441 // logmessage(char const *fmt __attribute__ (format (printf, 1, 2)), ...){
1442 // va_list ap;
1443 // va_start(ap, fmt);
1444 // vprintf(fmt, ap); // Do NOT emit a warning about "fmt".
1445 // ...
1446 //
1447 //
1448 // FIXME: We don't have full attribute support yet, so just check to see
1449 // if the argument is a DeclRefExpr that references a parameter. We'll
1450 // add proper support for checking the attribute later.
1451 if (HasVAListArg)
1452 if (isa<ParmVarDecl>(VD))
1453 return true;
Ted Kremenek082d9362009-03-20 21:35:28 +00001454 }
Mike Stump1eb44332009-09-09 15:08:12 +00001455
Ted Kremenek082d9362009-03-20 21:35:28 +00001456 return false;
1457 }
Ted Kremenekd30ef872009-01-12 23:09:09 +00001458
Anders Carlsson8f031b32009-06-27 04:05:33 +00001459 case Stmt::CallExprClass: {
1460 const CallExpr *CE = cast<CallExpr>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00001461 if (const ImplicitCastExpr *ICE
Anders Carlsson8f031b32009-06-27 04:05:33 +00001462 = dyn_cast<ImplicitCastExpr>(CE->getCallee())) {
1463 if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(ICE->getSubExpr())) {
1464 if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(DRE->getDecl())) {
Argyrios Kyrtzidis40b598e2009-06-30 02:34:44 +00001465 if (const FormatArgAttr *FA = FD->getAttr<FormatArgAttr>()) {
Anders Carlsson8f031b32009-06-27 04:05:33 +00001466 unsigned ArgIndex = FA->getFormatIdx();
1467 const Expr *Arg = CE->getArg(ArgIndex - 1);
Mike Stump1eb44332009-09-09 15:08:12 +00001468
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00001469 return SemaCheckStringLiteral(Arg, Args, NumArgs, HasVAListArg,
Jean-Daniel Dupas34269df2012-01-30 08:46:47 +00001470 format_idx, firstDataArg, Type,
Richard Trieu55733de2011-10-28 00:41:25 +00001471 inFunctionCall);
Anders Carlsson8f031b32009-06-27 04:05:33 +00001472 }
1473 }
1474 }
1475 }
Mike Stump1eb44332009-09-09 15:08:12 +00001476
Anders Carlsson8f031b32009-06-27 04:05:33 +00001477 return false;
1478 }
Ted Kremenek082d9362009-03-20 21:35:28 +00001479 case Stmt::ObjCStringLiteralClass:
1480 case Stmt::StringLiteralClass: {
1481 const StringLiteral *StrE = NULL;
Mike Stump1eb44332009-09-09 15:08:12 +00001482
Ted Kremenek082d9362009-03-20 21:35:28 +00001483 if (const ObjCStringLiteral *ObjCFExpr = dyn_cast<ObjCStringLiteral>(E))
Ted Kremenekd30ef872009-01-12 23:09:09 +00001484 StrE = ObjCFExpr->getString();
1485 else
Ted Kremenek082d9362009-03-20 21:35:28 +00001486 StrE = cast<StringLiteral>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00001487
Ted Kremenekd30ef872009-01-12 23:09:09 +00001488 if (StrE) {
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00001489 CheckFormatString(StrE, E, Args, NumArgs, HasVAListArg, format_idx,
Jean-Daniel Dupas34269df2012-01-30 08:46:47 +00001490 firstDataArg, Type, inFunctionCall);
Ted Kremenekd30ef872009-01-12 23:09:09 +00001491 return true;
1492 }
Mike Stump1eb44332009-09-09 15:08:12 +00001493
Ted Kremenekd30ef872009-01-12 23:09:09 +00001494 return false;
1495 }
Mike Stump1eb44332009-09-09 15:08:12 +00001496
Ted Kremenek082d9362009-03-20 21:35:28 +00001497 default:
1498 return false;
Ted Kremenekd30ef872009-01-12 23:09:09 +00001499 }
1500}
1501
Fariborz Jahaniane898f8a2009-05-21 18:48:51 +00001502void
Mike Stump1eb44332009-09-09 15:08:12 +00001503Sema::CheckNonNullArguments(const NonNullAttr *NonNull,
Nick Lewycky909a70d2011-03-25 01:44:32 +00001504 const Expr * const *ExprArgs,
1505 SourceLocation CallSiteLoc) {
Sean Huntcf807c42010-08-18 23:23:40 +00001506 for (NonNullAttr::args_iterator i = NonNull->args_begin(),
1507 e = NonNull->args_end();
Fariborz Jahaniane898f8a2009-05-21 18:48:51 +00001508 i != e; ++i) {
Nick Lewycky909a70d2011-03-25 01:44:32 +00001509 const Expr *ArgExpr = ExprArgs[*i];
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001510 if (ArgExpr->isNullPointerConstant(Context,
Douglas Gregorce940492009-09-25 04:25:58 +00001511 Expr::NPC_ValueDependentIsNotNull))
Nick Lewycky909a70d2011-03-25 01:44:32 +00001512 Diag(CallSiteLoc, diag::warn_null_arg) << ArgExpr->getSourceRange();
Fariborz Jahaniane898f8a2009-05-21 18:48:51 +00001513 }
1514}
Ted Kremenekd30ef872009-01-12 23:09:09 +00001515
Jean-Daniel Dupas34269df2012-01-30 08:46:47 +00001516Sema::FormatStringType Sema::GetFormatStringType(const FormatAttr *Format) {
1517 return llvm::StringSwitch<FormatStringType>(Format->getType())
1518 .Case("scanf", FST_Scanf)
1519 .Cases("printf", "printf0", FST_Printf)
1520 .Cases("NSString", "CFString", FST_NSString)
1521 .Case("strftime", FST_Strftime)
1522 .Case("strfmon", FST_Strfmon)
1523 .Cases("kprintf", "cmn_err", "vcmn_err", "zcmn_err", FST_Kprintf)
1524 .Default(FST_Unknown);
1525}
1526
Ted Kremenek826a3452010-07-16 02:11:22 +00001527/// CheckPrintfScanfArguments - Check calls to printf and scanf (and similar
1528/// functions) for correct use of format strings.
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00001529void Sema::CheckFormatArguments(const FormatAttr *Format, CallExpr *TheCall) {
1530 bool IsCXXMember = false;
Sebastian Redl4a2614e2009-11-17 18:02:24 +00001531 // The way the format attribute works in GCC, the implicit this argument
1532 // of member functions is counted. However, it doesn't appear in our own
1533 // lists, so decrement format_idx in that case.
1534 if (isa<CXXMemberCallExpr>(TheCall)) {
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00001535 const CXXMethodDecl *method_decl =
1536 dyn_cast<CXXMethodDecl>(TheCall->getCalleeDecl());
1537 IsCXXMember = method_decl && method_decl->isInstance();
1538 }
1539 CheckFormatArguments(Format, TheCall->getArgs(), TheCall->getNumArgs(),
1540 IsCXXMember, TheCall->getRParenLoc(),
1541 TheCall->getCallee()->getSourceRange());
1542}
1543
1544void Sema::CheckFormatArguments(const FormatAttr *Format, Expr **Args,
1545 unsigned NumArgs, bool IsCXXMember,
1546 SourceLocation Loc, SourceRange Range) {
Jean-Daniel Dupas34269df2012-01-30 08:46:47 +00001547 bool HasVAListArg = Format->getFirstArg() == 0;
1548 unsigned format_idx = Format->getFormatIdx() - 1;
1549 unsigned firstDataArg = HasVAListArg ? 0 : Format->getFirstArg() - 1;
1550 if (IsCXXMember) {
1551 if (format_idx == 0)
1552 return;
1553 --format_idx;
1554 if(firstDataArg != 0)
1555 --firstDataArg;
Sebastian Redl4a2614e2009-11-17 18:02:24 +00001556 }
Jean-Daniel Dupas34269df2012-01-30 08:46:47 +00001557 CheckFormatArguments(Args, NumArgs, HasVAListArg, format_idx,
1558 firstDataArg, GetFormatStringType(Format), Loc, Range);
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00001559}
Sebastian Redl4a2614e2009-11-17 18:02:24 +00001560
Jean-Daniel Dupas34269df2012-01-30 08:46:47 +00001561void Sema::CheckFormatArguments(Expr **Args, unsigned NumArgs,
1562 bool HasVAListArg, unsigned format_idx,
1563 unsigned firstDataArg, FormatStringType Type,
1564 SourceLocation Loc, SourceRange Range) {
Ted Kremenek826a3452010-07-16 02:11:22 +00001565 // CHECK: printf/scanf-like function is called with no format string.
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00001566 if (format_idx >= NumArgs) {
1567 Diag(Loc, diag::warn_missing_format_string) << Range;
Ted Kremenek71895b92007-08-14 17:39:48 +00001568 return;
1569 }
Mike Stump1eb44332009-09-09 15:08:12 +00001570
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00001571 const Expr *OrigFormatExpr = Args[format_idx]->IgnoreParenCasts();
Mike Stump1eb44332009-09-09 15:08:12 +00001572
Chris Lattner59907c42007-08-10 20:18:51 +00001573 // CHECK: format string is not a string literal.
Mike Stump1eb44332009-09-09 15:08:12 +00001574 //
Ted Kremenek71895b92007-08-14 17:39:48 +00001575 // Dynamically generated format strings are difficult to
1576 // automatically vet at compile time. Requiring that format strings
1577 // are string literals: (1) permits the checking of format strings by
1578 // the compiler and thereby (2) can practically remove the source of
1579 // many format string exploits.
Ted Kremenek7ff22b22008-06-16 18:00:42 +00001580
Mike Stump1eb44332009-09-09 15:08:12 +00001581 // Format string can be either ObjC string (e.g. @"%d") or
Ted Kremenek7ff22b22008-06-16 18:00:42 +00001582 // C string (e.g. "%d")
Mike Stump1eb44332009-09-09 15:08:12 +00001583 // ObjC string uses the same format specifiers as C string, so we can use
Ted Kremenek7ff22b22008-06-16 18:00:42 +00001584 // the same format string checking logic for both ObjC and C strings.
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00001585 if (SemaCheckStringLiteral(OrigFormatExpr, Args, NumArgs, HasVAListArg,
Jean-Daniel Dupas34269df2012-01-30 08:46:47 +00001586 format_idx, firstDataArg, Type))
Chris Lattner1cd3e1f2009-04-29 04:49:34 +00001587 return; // Literal format string found, check done!
Ted Kremenek7ff22b22008-06-16 18:00:42 +00001588
Jean-Daniel Dupasce3aa392012-01-30 19:46:17 +00001589 // Do not emit diag when the string param is a macro expansion and the
1590 // format is either NSString or CFString. This is a hack to prevent
1591 // diag when using the NSLocalizedString and CFCopyLocalizedString macros
1592 // which are usually used in place of NS and CF string literals.
1593 if (Type == FST_NSString && Args[format_idx]->getLocStart().isMacroID())
1594 return;
1595
Chris Lattner655f1412009-04-29 04:59:47 +00001596 // If there are no arguments specified, warn with -Wformat-security, otherwise
1597 // warn only with -Wformat-nonliteral.
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00001598 if (NumArgs == format_idx+1)
1599 Diag(Args[format_idx]->getLocStart(),
Ted Kremenek826a3452010-07-16 02:11:22 +00001600 diag::warn_format_nonliteral_noargs)
Chris Lattner655f1412009-04-29 04:59:47 +00001601 << OrigFormatExpr->getSourceRange();
1602 else
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00001603 Diag(Args[format_idx]->getLocStart(),
Ted Kremenek826a3452010-07-16 02:11:22 +00001604 diag::warn_format_nonliteral)
Chris Lattner655f1412009-04-29 04:59:47 +00001605 << OrigFormatExpr->getSourceRange();
Ted Kremenekd30ef872009-01-12 23:09:09 +00001606}
Ted Kremenek71895b92007-08-14 17:39:48 +00001607
Ted Kremeneke0e53132010-01-28 23:39:18 +00001608namespace {
Ted Kremenek826a3452010-07-16 02:11:22 +00001609class CheckFormatHandler : public analyze_format_string::FormatStringHandler {
1610protected:
Ted Kremeneke0e53132010-01-28 23:39:18 +00001611 Sema &S;
1612 const StringLiteral *FExpr;
1613 const Expr *OrigFormatExpr;
Ted Kremenek6ee76532010-03-25 03:59:12 +00001614 const unsigned FirstDataArg;
Ted Kremeneke0e53132010-01-28 23:39:18 +00001615 const unsigned NumDataArgs;
1616 const bool IsObjCLiteral;
1617 const char *Beg; // Start of format string.
Ted Kremenek0d277352010-01-29 01:06:55 +00001618 const bool HasVAListArg;
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00001619 const Expr * const *Args;
1620 const unsigned NumArgs;
Ted Kremenek0d277352010-01-29 01:06:55 +00001621 unsigned FormatIdx;
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001622 llvm::BitVector CoveredArgs;
Ted Kremenekefaff192010-02-27 01:41:03 +00001623 bool usesPositionalArgs;
1624 bool atFirstArg;
Richard Trieu55733de2011-10-28 00:41:25 +00001625 bool inFunctionCall;
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001626public:
Ted Kremenek826a3452010-07-16 02:11:22 +00001627 CheckFormatHandler(Sema &s, const StringLiteral *fexpr,
Ted Kremenek6ee76532010-03-25 03:59:12 +00001628 const Expr *origFormatExpr, unsigned firstDataArg,
Ted Kremeneke0e53132010-01-28 23:39:18 +00001629 unsigned numDataArgs, bool isObjCLiteral,
Ted Kremenek0d277352010-01-29 01:06:55 +00001630 const char *beg, bool hasVAListArg,
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00001631 Expr **args, unsigned numArgs,
1632 unsigned formatIdx, bool inFunctionCall)
Ted Kremeneke0e53132010-01-28 23:39:18 +00001633 : S(s), FExpr(fexpr), OrigFormatExpr(origFormatExpr),
Ted Kremenek6ee76532010-03-25 03:59:12 +00001634 FirstDataArg(firstDataArg),
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001635 NumDataArgs(numDataArgs),
Ted Kremenek0d277352010-01-29 01:06:55 +00001636 IsObjCLiteral(isObjCLiteral), Beg(beg),
1637 HasVAListArg(hasVAListArg),
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00001638 Args(args), NumArgs(numArgs), FormatIdx(formatIdx),
Richard Trieu55733de2011-10-28 00:41:25 +00001639 usesPositionalArgs(false), atFirstArg(true),
1640 inFunctionCall(inFunctionCall) {
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001641 CoveredArgs.resize(numDataArgs);
1642 CoveredArgs.reset();
1643 }
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001644
Ted Kremenek07d161f2010-01-29 01:50:07 +00001645 void DoneProcessing();
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001646
Ted Kremenek826a3452010-07-16 02:11:22 +00001647 void HandleIncompleteSpecifier(const char *startSpecifier,
1648 unsigned specifierLen);
1649
Ted Kremenekefaff192010-02-27 01:41:03 +00001650 virtual void HandleInvalidPosition(const char *startSpecifier,
1651 unsigned specifierLen,
Ted Kremenek826a3452010-07-16 02:11:22 +00001652 analyze_format_string::PositionContext p);
Ted Kremenekefaff192010-02-27 01:41:03 +00001653
1654 virtual void HandleZeroPosition(const char *startPos, unsigned posLen);
1655
Ted Kremeneke0e53132010-01-28 23:39:18 +00001656 void HandleNullChar(const char *nullCharacter);
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001657
Richard Trieu55733de2011-10-28 00:41:25 +00001658 template <typename Range>
1659 static void EmitFormatDiagnostic(Sema &S, bool inFunctionCall,
1660 const Expr *ArgumentExpr,
1661 PartialDiagnostic PDiag,
1662 SourceLocation StringLoc,
1663 bool IsStringLocation, Range StringRange,
1664 FixItHint Fixit = FixItHint());
1665
Ted Kremenek826a3452010-07-16 02:11:22 +00001666protected:
Ted Kremenekc09b6a52010-07-19 21:25:57 +00001667 bool HandleInvalidConversionSpecifier(unsigned argIndex, SourceLocation Loc,
1668 const char *startSpec,
1669 unsigned specifierLen,
1670 const char *csStart, unsigned csLen);
Richard Trieu55733de2011-10-28 00:41:25 +00001671
1672 void HandlePositionalNonpositionalArgs(SourceLocation Loc,
1673 const char *startSpec,
1674 unsigned specifierLen);
Ted Kremenekc09b6a52010-07-19 21:25:57 +00001675
Ted Kremenekf88c8e02010-01-29 20:55:36 +00001676 SourceRange getFormatStringRange();
Ted Kremenek826a3452010-07-16 02:11:22 +00001677 CharSourceRange getSpecifierRange(const char *startSpecifier,
1678 unsigned specifierLen);
Ted Kremeneke0e53132010-01-28 23:39:18 +00001679 SourceLocation getLocationOfByte(const char *x);
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001680
Ted Kremenek0d277352010-01-29 01:06:55 +00001681 const Expr *getDataArg(unsigned i) const;
Ted Kremenek666a1972010-07-26 19:45:42 +00001682
1683 bool CheckNumArgs(const analyze_format_string::FormatSpecifier &FS,
1684 const analyze_format_string::ConversionSpecifier &CS,
1685 const char *startSpecifier, unsigned specifierLen,
1686 unsigned argIndex);
Richard Trieu55733de2011-10-28 00:41:25 +00001687
1688 template <typename Range>
1689 void EmitFormatDiagnostic(PartialDiagnostic PDiag, SourceLocation StringLoc,
1690 bool IsStringLocation, Range StringRange,
1691 FixItHint Fixit = FixItHint());
1692
1693 void CheckPositionalAndNonpositionalArgs(
1694 const analyze_format_string::FormatSpecifier *FS);
Ted Kremeneke0e53132010-01-28 23:39:18 +00001695};
1696}
1697
Ted Kremenek826a3452010-07-16 02:11:22 +00001698SourceRange CheckFormatHandler::getFormatStringRange() {
Ted Kremeneke0e53132010-01-28 23:39:18 +00001699 return OrigFormatExpr->getSourceRange();
1700}
1701
Ted Kremenek826a3452010-07-16 02:11:22 +00001702CharSourceRange CheckFormatHandler::
1703getSpecifierRange(const char *startSpecifier, unsigned specifierLen) {
Tom Care45f9b7e2010-06-21 21:21:01 +00001704 SourceLocation Start = getLocationOfByte(startSpecifier);
1705 SourceLocation End = getLocationOfByte(startSpecifier + specifierLen - 1);
1706
1707 // Advance the end SourceLocation by one due to half-open ranges.
Argyrios Kyrtzidisa64ccef2011-09-19 20:40:19 +00001708 End = End.getLocWithOffset(1);
Tom Care45f9b7e2010-06-21 21:21:01 +00001709
1710 return CharSourceRange::getCharRange(Start, End);
Ted Kremenekf88c8e02010-01-29 20:55:36 +00001711}
1712
Ted Kremenek826a3452010-07-16 02:11:22 +00001713SourceLocation CheckFormatHandler::getLocationOfByte(const char *x) {
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001714 return S.getLocationOfStringLiteralByte(FExpr, x - Beg);
Ted Kremeneke0e53132010-01-28 23:39:18 +00001715}
1716
Ted Kremenek826a3452010-07-16 02:11:22 +00001717void CheckFormatHandler::HandleIncompleteSpecifier(const char *startSpecifier,
1718 unsigned specifierLen){
Richard Trieu55733de2011-10-28 00:41:25 +00001719 EmitFormatDiagnostic(S.PDiag(diag::warn_printf_incomplete_specifier),
1720 getLocationOfByte(startSpecifier),
1721 /*IsStringLocation*/true,
1722 getSpecifierRange(startSpecifier, specifierLen));
Ted Kremenek808015a2010-01-29 03:16:21 +00001723}
1724
Ted Kremenekefaff192010-02-27 01:41:03 +00001725void
Ted Kremenek826a3452010-07-16 02:11:22 +00001726CheckFormatHandler::HandleInvalidPosition(const char *startPos, unsigned posLen,
1727 analyze_format_string::PositionContext p) {
Richard Trieu55733de2011-10-28 00:41:25 +00001728 EmitFormatDiagnostic(S.PDiag(diag::warn_format_invalid_positional_specifier)
1729 << (unsigned) p,
1730 getLocationOfByte(startPos), /*IsStringLocation*/true,
1731 getSpecifierRange(startPos, posLen));
Ted Kremenekefaff192010-02-27 01:41:03 +00001732}
1733
Ted Kremenek826a3452010-07-16 02:11:22 +00001734void CheckFormatHandler::HandleZeroPosition(const char *startPos,
Ted Kremenekefaff192010-02-27 01:41:03 +00001735 unsigned posLen) {
Richard Trieu55733de2011-10-28 00:41:25 +00001736 EmitFormatDiagnostic(S.PDiag(diag::warn_format_zero_positional_specifier),
1737 getLocationOfByte(startPos),
1738 /*IsStringLocation*/true,
1739 getSpecifierRange(startPos, posLen));
Ted Kremenekefaff192010-02-27 01:41:03 +00001740}
1741
Ted Kremenek826a3452010-07-16 02:11:22 +00001742void CheckFormatHandler::HandleNullChar(const char *nullCharacter) {
Ted Kremenek0c069442011-03-15 21:18:48 +00001743 if (!IsObjCLiteral) {
1744 // The presence of a null character is likely an error.
Richard Trieu55733de2011-10-28 00:41:25 +00001745 EmitFormatDiagnostic(
1746 S.PDiag(diag::warn_printf_format_string_contains_null_char),
1747 getLocationOfByte(nullCharacter), /*IsStringLocation*/true,
1748 getFormatStringRange());
Ted Kremenek0c069442011-03-15 21:18:48 +00001749 }
Ted Kremenek826a3452010-07-16 02:11:22 +00001750}
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001751
Ted Kremenek826a3452010-07-16 02:11:22 +00001752const Expr *CheckFormatHandler::getDataArg(unsigned i) const {
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00001753 return Args[FirstDataArg + i];
Ted Kremenek826a3452010-07-16 02:11:22 +00001754}
1755
1756void CheckFormatHandler::DoneProcessing() {
1757 // Does the number of data arguments exceed the number of
1758 // format conversions in the format string?
1759 if (!HasVAListArg) {
1760 // Find any arguments that weren't covered.
1761 CoveredArgs.flip();
1762 signed notCoveredArg = CoveredArgs.find_first();
1763 if (notCoveredArg >= 0) {
1764 assert((unsigned)notCoveredArg < NumDataArgs);
Richard Trieu55733de2011-10-28 00:41:25 +00001765 EmitFormatDiagnostic(S.PDiag(diag::warn_printf_data_arg_not_used),
1766 getDataArg((unsigned) notCoveredArg)->getLocStart(),
1767 /*IsStringLocation*/false, getFormatStringRange());
Ted Kremenek826a3452010-07-16 02:11:22 +00001768 }
1769 }
1770}
1771
Ted Kremenekc09b6a52010-07-19 21:25:57 +00001772bool
1773CheckFormatHandler::HandleInvalidConversionSpecifier(unsigned argIndex,
1774 SourceLocation Loc,
1775 const char *startSpec,
1776 unsigned specifierLen,
1777 const char *csStart,
1778 unsigned csLen) {
1779
1780 bool keepGoing = true;
1781 if (argIndex < NumDataArgs) {
1782 // Consider the argument coverered, even though the specifier doesn't
1783 // make sense.
1784 CoveredArgs.set(argIndex);
1785 }
1786 else {
1787 // If argIndex exceeds the number of data arguments we
1788 // don't issue a warning because that is just a cascade of warnings (and
1789 // they may have intended '%%' anyway). We don't want to continue processing
1790 // the format string after this point, however, as we will like just get
1791 // gibberish when trying to match arguments.
1792 keepGoing = false;
1793 }
1794
Richard Trieu55733de2011-10-28 00:41:25 +00001795 EmitFormatDiagnostic(S.PDiag(diag::warn_format_invalid_conversion)
1796 << StringRef(csStart, csLen),
1797 Loc, /*IsStringLocation*/true,
1798 getSpecifierRange(startSpec, specifierLen));
Ted Kremenekc09b6a52010-07-19 21:25:57 +00001799
1800 return keepGoing;
1801}
1802
Richard Trieu55733de2011-10-28 00:41:25 +00001803void
1804CheckFormatHandler::HandlePositionalNonpositionalArgs(SourceLocation Loc,
1805 const char *startSpec,
1806 unsigned specifierLen) {
1807 EmitFormatDiagnostic(
1808 S.PDiag(diag::warn_format_mix_positional_nonpositional_args),
1809 Loc, /*isStringLoc*/true, getSpecifierRange(startSpec, specifierLen));
1810}
1811
Ted Kremenek666a1972010-07-26 19:45:42 +00001812bool
1813CheckFormatHandler::CheckNumArgs(
1814 const analyze_format_string::FormatSpecifier &FS,
1815 const analyze_format_string::ConversionSpecifier &CS,
1816 const char *startSpecifier, unsigned specifierLen, unsigned argIndex) {
1817
1818 if (argIndex >= NumDataArgs) {
Richard Trieu55733de2011-10-28 00:41:25 +00001819 PartialDiagnostic PDiag = FS.usesPositionalArg()
1820 ? (S.PDiag(diag::warn_printf_positional_arg_exceeds_data_args)
1821 << (argIndex+1) << NumDataArgs)
1822 : S.PDiag(diag::warn_printf_insufficient_data_args);
1823 EmitFormatDiagnostic(
1824 PDiag, getLocationOfByte(CS.getStart()), /*IsStringLocation*/true,
1825 getSpecifierRange(startSpecifier, specifierLen));
Ted Kremenek666a1972010-07-26 19:45:42 +00001826 return false;
1827 }
1828 return true;
1829}
1830
Richard Trieu55733de2011-10-28 00:41:25 +00001831template<typename Range>
1832void CheckFormatHandler::EmitFormatDiagnostic(PartialDiagnostic PDiag,
1833 SourceLocation Loc,
1834 bool IsStringLocation,
1835 Range StringRange,
1836 FixItHint FixIt) {
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00001837 EmitFormatDiagnostic(S, inFunctionCall, Args[FormatIdx], PDiag,
Richard Trieu55733de2011-10-28 00:41:25 +00001838 Loc, IsStringLocation, StringRange, FixIt);
1839}
1840
1841/// \brief If the format string is not within the funcion call, emit a note
1842/// so that the function call and string are in diagnostic messages.
1843///
1844/// \param inFunctionCall if true, the format string is within the function
1845/// call and only one diagnostic message will be produced. Otherwise, an
1846/// extra note will be emitted pointing to location of the format string.
1847///
1848/// \param ArgumentExpr the expression that is passed as the format string
1849/// argument in the function call. Used for getting locations when two
1850/// diagnostics are emitted.
1851///
1852/// \param PDiag the callee should already have provided any strings for the
1853/// diagnostic message. This function only adds locations and fixits
1854/// to diagnostics.
1855///
1856/// \param Loc primary location for diagnostic. If two diagnostics are
1857/// required, one will be at Loc and a new SourceLocation will be created for
1858/// the other one.
1859///
1860/// \param IsStringLocation if true, Loc points to the format string should be
1861/// used for the note. Otherwise, Loc points to the argument list and will
1862/// be used with PDiag.
1863///
1864/// \param StringRange some or all of the string to highlight. This is
1865/// templated so it can accept either a CharSourceRange or a SourceRange.
1866///
1867/// \param Fixit optional fix it hint for the format string.
1868template<typename Range>
1869void CheckFormatHandler::EmitFormatDiagnostic(Sema &S, bool InFunctionCall,
1870 const Expr *ArgumentExpr,
1871 PartialDiagnostic PDiag,
1872 SourceLocation Loc,
1873 bool IsStringLocation,
1874 Range StringRange,
1875 FixItHint FixIt) {
1876 if (InFunctionCall)
1877 S.Diag(Loc, PDiag) << StringRange << FixIt;
1878 else {
1879 S.Diag(IsStringLocation ? ArgumentExpr->getExprLoc() : Loc, PDiag)
1880 << ArgumentExpr->getSourceRange();
1881 S.Diag(IsStringLocation ? Loc : StringRange.getBegin(),
1882 diag::note_format_string_defined)
1883 << StringRange << FixIt;
1884 }
1885}
1886
Ted Kremenek826a3452010-07-16 02:11:22 +00001887//===--- CHECK: Printf format string checking ------------------------------===//
1888
1889namespace {
1890class CheckPrintfHandler : public CheckFormatHandler {
1891public:
1892 CheckPrintfHandler(Sema &s, const StringLiteral *fexpr,
1893 const Expr *origFormatExpr, unsigned firstDataArg,
1894 unsigned numDataArgs, bool isObjCLiteral,
1895 const char *beg, bool hasVAListArg,
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00001896 Expr **Args, unsigned NumArgs,
1897 unsigned formatIdx, bool inFunctionCall)
Ted Kremenek826a3452010-07-16 02:11:22 +00001898 : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg,
1899 numDataArgs, isObjCLiteral, beg, hasVAListArg,
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00001900 Args, NumArgs, formatIdx, inFunctionCall) {}
Ted Kremenek826a3452010-07-16 02:11:22 +00001901
1902
1903 bool HandleInvalidPrintfConversionSpecifier(
1904 const analyze_printf::PrintfSpecifier &FS,
1905 const char *startSpecifier,
1906 unsigned specifierLen);
1907
1908 bool HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier &FS,
1909 const char *startSpecifier,
1910 unsigned specifierLen);
1911
1912 bool HandleAmount(const analyze_format_string::OptionalAmount &Amt, unsigned k,
1913 const char *startSpecifier, unsigned specifierLen);
1914 void HandleInvalidAmount(const analyze_printf::PrintfSpecifier &FS,
1915 const analyze_printf::OptionalAmount &Amt,
1916 unsigned type,
1917 const char *startSpecifier, unsigned specifierLen);
1918 void HandleFlag(const analyze_printf::PrintfSpecifier &FS,
1919 const analyze_printf::OptionalFlag &flag,
1920 const char *startSpecifier, unsigned specifierLen);
1921 void HandleIgnoredFlag(const analyze_printf::PrintfSpecifier &FS,
1922 const analyze_printf::OptionalFlag &ignoredFlag,
1923 const analyze_printf::OptionalFlag &flag,
1924 const char *startSpecifier, unsigned specifierLen);
1925};
1926}
1927
1928bool CheckPrintfHandler::HandleInvalidPrintfConversionSpecifier(
1929 const analyze_printf::PrintfSpecifier &FS,
1930 const char *startSpecifier,
1931 unsigned specifierLen) {
Ted Kremenek6ecb9502010-07-20 20:04:27 +00001932 const analyze_printf::PrintfConversionSpecifier &CS =
Ted Kremenekc09b6a52010-07-19 21:25:57 +00001933 FS.getConversionSpecifier();
Ted Kremenek826a3452010-07-16 02:11:22 +00001934
Ted Kremenekc09b6a52010-07-19 21:25:57 +00001935 return HandleInvalidConversionSpecifier(FS.getArgIndex(),
1936 getLocationOfByte(CS.getStart()),
1937 startSpecifier, specifierLen,
1938 CS.getStart(), CS.getLength());
Ted Kremenek26ac2e02010-01-29 02:40:24 +00001939}
1940
Ted Kremenek826a3452010-07-16 02:11:22 +00001941bool CheckPrintfHandler::HandleAmount(
1942 const analyze_format_string::OptionalAmount &Amt,
1943 unsigned k, const char *startSpecifier,
1944 unsigned specifierLen) {
Ted Kremenek0d277352010-01-29 01:06:55 +00001945
1946 if (Amt.hasDataArgument()) {
Ted Kremenek0d277352010-01-29 01:06:55 +00001947 if (!HasVAListArg) {
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001948 unsigned argIndex = Amt.getArgIndex();
1949 if (argIndex >= NumDataArgs) {
Richard Trieu55733de2011-10-28 00:41:25 +00001950 EmitFormatDiagnostic(S.PDiag(diag::warn_printf_asterisk_missing_arg)
1951 << k,
1952 getLocationOfByte(Amt.getStart()),
1953 /*IsStringLocation*/true,
1954 getSpecifierRange(startSpecifier, specifierLen));
Ted Kremenek0d277352010-01-29 01:06:55 +00001955 // Don't do any more checking. We will just emit
1956 // spurious errors.
1957 return false;
1958 }
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001959
Ted Kremenek0d277352010-01-29 01:06:55 +00001960 // Type check the data argument. It should be an 'int'.
Ted Kremenek31f8e322010-01-29 23:32:22 +00001961 // Although not in conformance with C99, we also allow the argument to be
1962 // an 'unsigned int' as that is a reasonably safe case. GCC also
1963 // doesn't emit a warning for that case.
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001964 CoveredArgs.set(argIndex);
1965 const Expr *Arg = getDataArg(argIndex);
Ted Kremenek0d277352010-01-29 01:06:55 +00001966 QualType T = Arg->getType();
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001967
1968 const analyze_printf::ArgTypeResult &ATR = Amt.getArgType(S.Context);
1969 assert(ATR.isValid());
1970
1971 if (!ATR.matchesType(S.Context, T)) {
Richard Trieu55733de2011-10-28 00:41:25 +00001972 EmitFormatDiagnostic(S.PDiag(diag::warn_printf_asterisk_wrong_type)
Hans Wennborga792aff2011-12-07 10:33:11 +00001973 << k << ATR.getRepresentativeTypeName(S.Context)
Richard Trieu55733de2011-10-28 00:41:25 +00001974 << T << Arg->getSourceRange(),
1975 getLocationOfByte(Amt.getStart()),
1976 /*IsStringLocation*/true,
1977 getSpecifierRange(startSpecifier, specifierLen));
Ted Kremenek0d277352010-01-29 01:06:55 +00001978 // Don't do any more checking. We will just emit
1979 // spurious errors.
1980 return false;
1981 }
1982 }
1983 }
1984 return true;
1985}
Ted Kremenek0d277352010-01-29 01:06:55 +00001986
Tom Caree4ee9662010-06-17 19:00:27 +00001987void CheckPrintfHandler::HandleInvalidAmount(
Ted Kremenek826a3452010-07-16 02:11:22 +00001988 const analyze_printf::PrintfSpecifier &FS,
Tom Caree4ee9662010-06-17 19:00:27 +00001989 const analyze_printf::OptionalAmount &Amt,
1990 unsigned type,
1991 const char *startSpecifier,
1992 unsigned specifierLen) {
Ted Kremenek6ecb9502010-07-20 20:04:27 +00001993 const analyze_printf::PrintfConversionSpecifier &CS =
1994 FS.getConversionSpecifier();
Tom Caree4ee9662010-06-17 19:00:27 +00001995
Richard Trieu55733de2011-10-28 00:41:25 +00001996 FixItHint fixit =
1997 Amt.getHowSpecified() == analyze_printf::OptionalAmount::Constant
1998 ? FixItHint::CreateRemoval(getSpecifierRange(Amt.getStart(),
1999 Amt.getConstantLength()))
2000 : FixItHint();
2001
2002 EmitFormatDiagnostic(S.PDiag(diag::warn_printf_nonsensical_optional_amount)
2003 << type << CS.toString(),
2004 getLocationOfByte(Amt.getStart()),
2005 /*IsStringLocation*/true,
2006 getSpecifierRange(startSpecifier, specifierLen),
2007 fixit);
Tom Caree4ee9662010-06-17 19:00:27 +00002008}
2009
Ted Kremenek826a3452010-07-16 02:11:22 +00002010void CheckPrintfHandler::HandleFlag(const analyze_printf::PrintfSpecifier &FS,
Tom Caree4ee9662010-06-17 19:00:27 +00002011 const analyze_printf::OptionalFlag &flag,
2012 const char *startSpecifier,
2013 unsigned specifierLen) {
2014 // Warn about pointless flag with a fixit removal.
Ted Kremenek6ecb9502010-07-20 20:04:27 +00002015 const analyze_printf::PrintfConversionSpecifier &CS =
2016 FS.getConversionSpecifier();
Richard Trieu55733de2011-10-28 00:41:25 +00002017 EmitFormatDiagnostic(S.PDiag(diag::warn_printf_nonsensical_flag)
2018 << flag.toString() << CS.toString(),
2019 getLocationOfByte(flag.getPosition()),
2020 /*IsStringLocation*/true,
2021 getSpecifierRange(startSpecifier, specifierLen),
2022 FixItHint::CreateRemoval(
2023 getSpecifierRange(flag.getPosition(), 1)));
Tom Caree4ee9662010-06-17 19:00:27 +00002024}
2025
2026void CheckPrintfHandler::HandleIgnoredFlag(
Ted Kremenek826a3452010-07-16 02:11:22 +00002027 const analyze_printf::PrintfSpecifier &FS,
Tom Caree4ee9662010-06-17 19:00:27 +00002028 const analyze_printf::OptionalFlag &ignoredFlag,
2029 const analyze_printf::OptionalFlag &flag,
2030 const char *startSpecifier,
2031 unsigned specifierLen) {
2032 // Warn about ignored flag with a fixit removal.
Richard Trieu55733de2011-10-28 00:41:25 +00002033 EmitFormatDiagnostic(S.PDiag(diag::warn_printf_ignored_flag)
2034 << ignoredFlag.toString() << flag.toString(),
2035 getLocationOfByte(ignoredFlag.getPosition()),
2036 /*IsStringLocation*/true,
2037 getSpecifierRange(startSpecifier, specifierLen),
2038 FixItHint::CreateRemoval(
2039 getSpecifierRange(ignoredFlag.getPosition(), 1)));
Tom Caree4ee9662010-06-17 19:00:27 +00002040}
2041
Ted Kremeneke0e53132010-01-28 23:39:18 +00002042bool
Ted Kremenek826a3452010-07-16 02:11:22 +00002043CheckPrintfHandler::HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier
Ted Kremenek5c41ee82010-02-11 09:27:41 +00002044 &FS,
Ted Kremeneke0e53132010-01-28 23:39:18 +00002045 const char *startSpecifier,
2046 unsigned specifierLen) {
2047
Ted Kremenek6ecb9502010-07-20 20:04:27 +00002048 using namespace analyze_format_string;
Ted Kremenekefaff192010-02-27 01:41:03 +00002049 using namespace analyze_printf;
Ted Kremenek6ecb9502010-07-20 20:04:27 +00002050 const PrintfConversionSpecifier &CS = FS.getConversionSpecifier();
Ted Kremeneke0e53132010-01-28 23:39:18 +00002051
Ted Kremenekbaa40062010-07-19 22:01:06 +00002052 if (FS.consumesDataArgument()) {
2053 if (atFirstArg) {
2054 atFirstArg = false;
2055 usesPositionalArgs = FS.usesPositionalArg();
2056 }
2057 else if (usesPositionalArgs != FS.usesPositionalArg()) {
Richard Trieu55733de2011-10-28 00:41:25 +00002058 HandlePositionalNonpositionalArgs(getLocationOfByte(CS.getStart()),
2059 startSpecifier, specifierLen);
Ted Kremenekbaa40062010-07-19 22:01:06 +00002060 return false;
2061 }
Ted Kremenek0d277352010-01-29 01:06:55 +00002062 }
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00002063
Ted Kremenekefaff192010-02-27 01:41:03 +00002064 // First check if the field width, precision, and conversion specifier
2065 // have matching data arguments.
2066 if (!HandleAmount(FS.getFieldWidth(), /* field width */ 0,
2067 startSpecifier, specifierLen)) {
2068 return false;
2069 }
2070
2071 if (!HandleAmount(FS.getPrecision(), /* precision */ 1,
2072 startSpecifier, specifierLen)) {
Ted Kremenek0d277352010-01-29 01:06:55 +00002073 return false;
2074 }
2075
Ted Kremenekf88c8e02010-01-29 20:55:36 +00002076 if (!CS.consumesDataArgument()) {
2077 // FIXME: Technically specifying a precision or field width here
2078 // makes no sense. Worth issuing a warning at some point.
Ted Kremenek0e5675d2010-02-10 02:16:30 +00002079 return true;
Ted Kremenekf88c8e02010-01-29 20:55:36 +00002080 }
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00002081
Ted Kremenek7f70dc82010-02-26 19:18:41 +00002082 // Consume the argument.
2083 unsigned argIndex = FS.getArgIndex();
Ted Kremeneke3fc5472010-02-27 08:34:51 +00002084 if (argIndex < NumDataArgs) {
2085 // The check to see if the argIndex is valid will come later.
2086 // We set the bit here because we may exit early from this
2087 // function if we encounter some other error.
2088 CoveredArgs.set(argIndex);
2089 }
Ted Kremenek7f70dc82010-02-26 19:18:41 +00002090
2091 // Check for using an Objective-C specific conversion specifier
2092 // in a non-ObjC literal.
2093 if (!IsObjCLiteral && CS.isObjCArg()) {
Ted Kremenek826a3452010-07-16 02:11:22 +00002094 return HandleInvalidPrintfConversionSpecifier(FS, startSpecifier,
2095 specifierLen);
Ted Kremenek7f70dc82010-02-26 19:18:41 +00002096 }
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00002097
Tom Caree4ee9662010-06-17 19:00:27 +00002098 // Check for invalid use of field width
2099 if (!FS.hasValidFieldWidth()) {
Tom Care45f9b7e2010-06-21 21:21:01 +00002100 HandleInvalidAmount(FS, FS.getFieldWidth(), /* field width */ 0,
Tom Caree4ee9662010-06-17 19:00:27 +00002101 startSpecifier, specifierLen);
2102 }
2103
2104 // Check for invalid use of precision
2105 if (!FS.hasValidPrecision()) {
2106 HandleInvalidAmount(FS, FS.getPrecision(), /* precision */ 1,
2107 startSpecifier, specifierLen);
2108 }
2109
2110 // Check each flag does not conflict with any other component.
Ted Kremenek65197b42011-01-08 05:28:46 +00002111 if (!FS.hasValidThousandsGroupingPrefix())
2112 HandleFlag(FS, FS.hasThousandsGrouping(), startSpecifier, specifierLen);
Tom Caree4ee9662010-06-17 19:00:27 +00002113 if (!FS.hasValidLeadingZeros())
2114 HandleFlag(FS, FS.hasLeadingZeros(), startSpecifier, specifierLen);
2115 if (!FS.hasValidPlusPrefix())
2116 HandleFlag(FS, FS.hasPlusPrefix(), startSpecifier, specifierLen);
Tom Care45f9b7e2010-06-21 21:21:01 +00002117 if (!FS.hasValidSpacePrefix())
2118 HandleFlag(FS, FS.hasSpacePrefix(), startSpecifier, specifierLen);
Tom Caree4ee9662010-06-17 19:00:27 +00002119 if (!FS.hasValidAlternativeForm())
2120 HandleFlag(FS, FS.hasAlternativeForm(), startSpecifier, specifierLen);
2121 if (!FS.hasValidLeftJustified())
2122 HandleFlag(FS, FS.isLeftJustified(), startSpecifier, specifierLen);
2123
2124 // Check that flags are not ignored by another flag
Tom Care45f9b7e2010-06-21 21:21:01 +00002125 if (FS.hasSpacePrefix() && FS.hasPlusPrefix()) // ' ' ignored by '+'
2126 HandleIgnoredFlag(FS, FS.hasSpacePrefix(), FS.hasPlusPrefix(),
2127 startSpecifier, specifierLen);
Tom Caree4ee9662010-06-17 19:00:27 +00002128 if (FS.hasLeadingZeros() && FS.isLeftJustified()) // '0' ignored by '-'
2129 HandleIgnoredFlag(FS, FS.hasLeadingZeros(), FS.isLeftJustified(),
2130 startSpecifier, specifierLen);
2131
2132 // Check the length modifier is valid with the given conversion specifier.
2133 const LengthModifier &LM = FS.getLengthModifier();
2134 if (!FS.hasValidLengthModifier())
Richard Trieu55733de2011-10-28 00:41:25 +00002135 EmitFormatDiagnostic(S.PDiag(diag::warn_format_nonsensical_length)
2136 << LM.toString() << CS.toString(),
2137 getLocationOfByte(LM.getStart()),
2138 /*IsStringLocation*/true,
2139 getSpecifierRange(startSpecifier, specifierLen),
2140 FixItHint::CreateRemoval(
2141 getSpecifierRange(LM.getStart(),
2142 LM.getLength())));
Tom Caree4ee9662010-06-17 19:00:27 +00002143
2144 // Are we using '%n'?
Ted Kremenek35d353b2010-07-20 20:04:10 +00002145 if (CS.getKind() == ConversionSpecifier::nArg) {
Tom Caree4ee9662010-06-17 19:00:27 +00002146 // Issue a warning about this being a possible security issue.
Richard Trieu55733de2011-10-28 00:41:25 +00002147 EmitFormatDiagnostic(S.PDiag(diag::warn_printf_write_back),
2148 getLocationOfByte(CS.getStart()),
2149 /*IsStringLocation*/true,
2150 getSpecifierRange(startSpecifier, specifierLen));
Ted Kremeneke82d8042010-01-29 01:35:25 +00002151 // Continue checking the other format specifiers.
2152 return true;
2153 }
Ted Kremenek5c41ee82010-02-11 09:27:41 +00002154
Ted Kremenekda51f0d2010-01-29 01:43:31 +00002155 // The remaining checks depend on the data arguments.
2156 if (HasVAListArg)
2157 return true;
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00002158
Ted Kremenek666a1972010-07-26 19:45:42 +00002159 if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex))
Ted Kremenekda51f0d2010-01-29 01:43:31 +00002160 return false;
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00002161
Michael J. Spencer96827eb2010-07-27 04:46:02 +00002162 // Now type check the data expression that matches the
2163 // format specifier.
2164 const Expr *Ex = getDataArg(argIndex);
Nico Weber339b9072012-01-31 01:43:25 +00002165 const analyze_printf::ArgTypeResult &ATR = FS.getArgType(S.Context,
2166 IsObjCLiteral);
Michael J. Spencer96827eb2010-07-27 04:46:02 +00002167 if (ATR.isValid() && !ATR.matchesType(S.Context, Ex->getType())) {
2168 // Check if we didn't match because of an implicit cast from a 'char'
2169 // or 'short' to an 'int'. This is done because printf is a varargs
2170 // function.
2171 if (const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Ex))
Ted Kremenek4d8ae4d2010-10-21 04:00:58 +00002172 if (ICE->getType() == S.Context.IntTy) {
2173 // All further checking is done on the subexpression.
2174 Ex = ICE->getSubExpr();
2175 if (ATR.matchesType(S.Context, Ex->getType()))
Michael J. Spencer96827eb2010-07-27 04:46:02 +00002176 return true;
Ted Kremenek4d8ae4d2010-10-21 04:00:58 +00002177 }
Michael J. Spencer96827eb2010-07-27 04:46:02 +00002178
2179 // We may be able to offer a FixItHint if it is a supported type.
2180 PrintfSpecifier fixedFS = FS;
Hans Wennborga7da2152011-10-18 08:10:06 +00002181 bool success = fixedFS.fixType(Ex->getType(), S.getLangOptions());
Michael J. Spencer96827eb2010-07-27 04:46:02 +00002182
2183 if (success) {
2184 // Get the fix string from the fixed format specifier
2185 llvm::SmallString<128> buf;
2186 llvm::raw_svector_ostream os(buf);
2187 fixedFS.toString(os);
2188
Richard Trieu55733de2011-10-28 00:41:25 +00002189 EmitFormatDiagnostic(
2190 S.PDiag(diag::warn_printf_conversion_argument_type_mismatch)
Hans Wennborga792aff2011-12-07 10:33:11 +00002191 << ATR.getRepresentativeTypeName(S.Context) << Ex->getType()
Richard Trieu55733de2011-10-28 00:41:25 +00002192 << Ex->getSourceRange(),
2193 getLocationOfByte(CS.getStart()),
2194 /*IsStringLocation*/true,
2195 getSpecifierRange(startSpecifier, specifierLen),
2196 FixItHint::CreateReplacement(
2197 getSpecifierRange(startSpecifier, specifierLen),
2198 os.str()));
Michael J. Spencer96827eb2010-07-27 04:46:02 +00002199 }
2200 else {
Jean-Daniel Dupas220947b2012-01-31 18:12:08 +00002201 EmitFormatDiagnostic(
2202 S.PDiag(diag::warn_printf_conversion_argument_type_mismatch)
2203 << ATR.getRepresentativeTypeName(S.Context) << Ex->getType()
2204 << getSpecifierRange(startSpecifier, specifierLen)
2205 << Ex->getSourceRange(),
2206 getLocationOfByte(CS.getStart()),
2207 true,
2208 getSpecifierRange(startSpecifier, specifierLen));
Michael J. Spencer96827eb2010-07-27 04:46:02 +00002209 }
2210 }
2211
Ted Kremeneke0e53132010-01-28 23:39:18 +00002212 return true;
2213}
2214
Ted Kremenek826a3452010-07-16 02:11:22 +00002215//===--- CHECK: Scanf format string checking ------------------------------===//
2216
2217namespace {
2218class CheckScanfHandler : public CheckFormatHandler {
2219public:
2220 CheckScanfHandler(Sema &s, const StringLiteral *fexpr,
2221 const Expr *origFormatExpr, unsigned firstDataArg,
2222 unsigned numDataArgs, bool isObjCLiteral,
2223 const char *beg, bool hasVAListArg,
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00002224 Expr **Args, unsigned NumArgs,
2225 unsigned formatIdx, bool inFunctionCall)
Ted Kremenek826a3452010-07-16 02:11:22 +00002226 : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg,
2227 numDataArgs, isObjCLiteral, beg, hasVAListArg,
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00002228 Args, NumArgs, formatIdx, inFunctionCall) {}
Ted Kremenek826a3452010-07-16 02:11:22 +00002229
2230 bool HandleScanfSpecifier(const analyze_scanf::ScanfSpecifier &FS,
2231 const char *startSpecifier,
2232 unsigned specifierLen);
Ted Kremenekc09b6a52010-07-19 21:25:57 +00002233
2234 bool HandleInvalidScanfConversionSpecifier(
2235 const analyze_scanf::ScanfSpecifier &FS,
2236 const char *startSpecifier,
2237 unsigned specifierLen);
Ted Kremenekb7c21012010-07-16 18:28:03 +00002238
2239 void HandleIncompleteScanList(const char *start, const char *end);
Ted Kremenek826a3452010-07-16 02:11:22 +00002240};
Ted Kremenek07d161f2010-01-29 01:50:07 +00002241}
Ted Kremeneke0e53132010-01-28 23:39:18 +00002242
Ted Kremenekb7c21012010-07-16 18:28:03 +00002243void CheckScanfHandler::HandleIncompleteScanList(const char *start,
2244 const char *end) {
Richard Trieu55733de2011-10-28 00:41:25 +00002245 EmitFormatDiagnostic(S.PDiag(diag::warn_scanf_scanlist_incomplete),
2246 getLocationOfByte(end), /*IsStringLocation*/true,
2247 getSpecifierRange(start, end - start));
Ted Kremenekb7c21012010-07-16 18:28:03 +00002248}
2249
Ted Kremenekc09b6a52010-07-19 21:25:57 +00002250bool CheckScanfHandler::HandleInvalidScanfConversionSpecifier(
2251 const analyze_scanf::ScanfSpecifier &FS,
2252 const char *startSpecifier,
2253 unsigned specifierLen) {
2254
Ted Kremenek6ecb9502010-07-20 20:04:27 +00002255 const analyze_scanf::ScanfConversionSpecifier &CS =
Ted Kremenekc09b6a52010-07-19 21:25:57 +00002256 FS.getConversionSpecifier();
2257
2258 return HandleInvalidConversionSpecifier(FS.getArgIndex(),
2259 getLocationOfByte(CS.getStart()),
2260 startSpecifier, specifierLen,
2261 CS.getStart(), CS.getLength());
2262}
2263
Ted Kremenek826a3452010-07-16 02:11:22 +00002264bool CheckScanfHandler::HandleScanfSpecifier(
2265 const analyze_scanf::ScanfSpecifier &FS,
2266 const char *startSpecifier,
2267 unsigned specifierLen) {
2268
2269 using namespace analyze_scanf;
2270 using namespace analyze_format_string;
2271
Ted Kremenek6ecb9502010-07-20 20:04:27 +00002272 const ScanfConversionSpecifier &CS = FS.getConversionSpecifier();
Ted Kremenek826a3452010-07-16 02:11:22 +00002273
Ted Kremenekbaa40062010-07-19 22:01:06 +00002274 // Handle case where '%' and '*' don't consume an argument. These shouldn't
2275 // be used to decide if we are using positional arguments consistently.
2276 if (FS.consumesDataArgument()) {
2277 if (atFirstArg) {
2278 atFirstArg = false;
2279 usesPositionalArgs = FS.usesPositionalArg();
2280 }
2281 else if (usesPositionalArgs != FS.usesPositionalArg()) {
Richard Trieu55733de2011-10-28 00:41:25 +00002282 HandlePositionalNonpositionalArgs(getLocationOfByte(CS.getStart()),
2283 startSpecifier, specifierLen);
Ted Kremenekbaa40062010-07-19 22:01:06 +00002284 return false;
2285 }
Ted Kremenek826a3452010-07-16 02:11:22 +00002286 }
2287
2288 // Check if the field with is non-zero.
2289 const OptionalAmount &Amt = FS.getFieldWidth();
2290 if (Amt.getHowSpecified() == OptionalAmount::Constant) {
2291 if (Amt.getConstantAmount() == 0) {
2292 const CharSourceRange &R = getSpecifierRange(Amt.getStart(),
2293 Amt.getConstantLength());
Richard Trieu55733de2011-10-28 00:41:25 +00002294 EmitFormatDiagnostic(S.PDiag(diag::warn_scanf_nonzero_width),
2295 getLocationOfByte(Amt.getStart()),
2296 /*IsStringLocation*/true, R,
2297 FixItHint::CreateRemoval(R));
Ted Kremenek826a3452010-07-16 02:11:22 +00002298 }
2299 }
2300
2301 if (!FS.consumesDataArgument()) {
2302 // FIXME: Technically specifying a precision or field width here
2303 // makes no sense. Worth issuing a warning at some point.
2304 return true;
2305 }
2306
2307 // Consume the argument.
2308 unsigned argIndex = FS.getArgIndex();
2309 if (argIndex < NumDataArgs) {
2310 // The check to see if the argIndex is valid will come later.
2311 // We set the bit here because we may exit early from this
2312 // function if we encounter some other error.
2313 CoveredArgs.set(argIndex);
2314 }
2315
Ted Kremenek1e51c202010-07-20 20:04:47 +00002316 // Check the length modifier is valid with the given conversion specifier.
2317 const LengthModifier &LM = FS.getLengthModifier();
2318 if (!FS.hasValidLengthModifier()) {
Jean-Daniel Dupas220947b2012-01-31 18:12:08 +00002319 const CharSourceRange &R = getSpecifierRange(LM.getStart(), LM.getLength());
2320 EmitFormatDiagnostic(S.PDiag(diag::warn_format_nonsensical_length)
2321 << LM.toString() << CS.toString()
2322 << getSpecifierRange(startSpecifier, specifierLen),
2323 getLocationOfByte(LM.getStart()),
2324 /*IsStringLocation*/true, R,
2325 FixItHint::CreateRemoval(R));
Ted Kremenek1e51c202010-07-20 20:04:47 +00002326 }
2327
Ted Kremenek826a3452010-07-16 02:11:22 +00002328 // The remaining checks depend on the data arguments.
2329 if (HasVAListArg)
2330 return true;
2331
Ted Kremenek666a1972010-07-26 19:45:42 +00002332 if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex))
Ted Kremenek826a3452010-07-16 02:11:22 +00002333 return false;
Ted Kremenek826a3452010-07-16 02:11:22 +00002334
Hans Wennborg6fcd9322011-12-10 13:20:11 +00002335 // Check that the argument type matches the format specifier.
2336 const Expr *Ex = getDataArg(argIndex);
2337 const analyze_scanf::ScanfArgTypeResult &ATR = FS.getArgType(S.Context);
2338 if (ATR.isValid() && !ATR.matchesType(S.Context, Ex->getType())) {
2339 ScanfSpecifier fixedFS = FS;
2340 bool success = fixedFS.fixType(Ex->getType(), S.getLangOptions());
2341
2342 if (success) {
2343 // Get the fix string from the fixed format specifier.
2344 llvm::SmallString<128> buf;
2345 llvm::raw_svector_ostream os(buf);
2346 fixedFS.toString(os);
2347
2348 EmitFormatDiagnostic(
2349 S.PDiag(diag::warn_printf_conversion_argument_type_mismatch)
2350 << ATR.getRepresentativeTypeName(S.Context) << Ex->getType()
2351 << Ex->getSourceRange(),
2352 getLocationOfByte(CS.getStart()),
2353 /*IsStringLocation*/true,
2354 getSpecifierRange(startSpecifier, specifierLen),
2355 FixItHint::CreateReplacement(
2356 getSpecifierRange(startSpecifier, specifierLen),
2357 os.str()));
2358 } else {
Jean-Daniel Dupas220947b2012-01-31 18:12:08 +00002359 EmitFormatDiagnostic(
2360 S.PDiag(diag::warn_printf_conversion_argument_type_mismatch)
Hans Wennborg6fcd9322011-12-10 13:20:11 +00002361 << ATR.getRepresentativeTypeName(S.Context) << Ex->getType()
Jean-Daniel Dupas220947b2012-01-31 18:12:08 +00002362 << Ex->getSourceRange(),
2363 getLocationOfByte(CS.getStart()),
2364 /*IsStringLocation*/true,
2365 getSpecifierRange(startSpecifier, specifierLen));
Hans Wennborg6fcd9322011-12-10 13:20:11 +00002366 }
2367 }
2368
Ted Kremenek826a3452010-07-16 02:11:22 +00002369 return true;
2370}
2371
2372void Sema::CheckFormatString(const StringLiteral *FExpr,
Ted Kremenek0e5675d2010-02-10 02:16:30 +00002373 const Expr *OrigFormatExpr,
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00002374 Expr **Args, unsigned NumArgs,
2375 bool HasVAListArg, unsigned format_idx,
Jean-Daniel Dupas34269df2012-01-30 08:46:47 +00002376 unsigned firstDataArg, FormatStringType Type,
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00002377 bool inFunctionCall) {
Ted Kremenek826a3452010-07-16 02:11:22 +00002378
Ted Kremeneke0e53132010-01-28 23:39:18 +00002379 // CHECK: is the format string a wide literal?
Douglas Gregor5cee1192011-07-27 05:40:30 +00002380 if (!FExpr->isAscii()) {
Richard Trieu55733de2011-10-28 00:41:25 +00002381 CheckFormatHandler::EmitFormatDiagnostic(
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00002382 *this, inFunctionCall, Args[format_idx],
Richard Trieu55733de2011-10-28 00:41:25 +00002383 PDiag(diag::warn_format_string_is_wide_literal), FExpr->getLocStart(),
2384 /*IsStringLocation*/true, OrigFormatExpr->getSourceRange());
Ted Kremeneke0e53132010-01-28 23:39:18 +00002385 return;
2386 }
Ted Kremenek826a3452010-07-16 02:11:22 +00002387
Ted Kremeneke0e53132010-01-28 23:39:18 +00002388 // Str - The format string. NOTE: this is NOT null-terminated!
Chris Lattner5f9e2722011-07-23 10:55:15 +00002389 StringRef StrRef = FExpr->getString();
Benjamin Kramer2f4eaef2010-08-17 12:54:38 +00002390 const char *Str = StrRef.data();
2391 unsigned StrLen = StrRef.size();
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00002392 const unsigned numDataArgs = NumArgs - firstDataArg;
Ted Kremenek826a3452010-07-16 02:11:22 +00002393
Ted Kremeneke0e53132010-01-28 23:39:18 +00002394 // CHECK: empty format string?
Ted Kremenek4cd57912011-09-29 05:52:16 +00002395 if (StrLen == 0 && numDataArgs > 0) {
Richard Trieu55733de2011-10-28 00:41:25 +00002396 CheckFormatHandler::EmitFormatDiagnostic(
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00002397 *this, inFunctionCall, Args[format_idx],
Richard Trieu55733de2011-10-28 00:41:25 +00002398 PDiag(diag::warn_empty_format_string), FExpr->getLocStart(),
2399 /*IsStringLocation*/true, OrigFormatExpr->getSourceRange());
Ted Kremeneke0e53132010-01-28 23:39:18 +00002400 return;
2401 }
Ted Kremenek826a3452010-07-16 02:11:22 +00002402
Jean-Daniel Dupas34269df2012-01-30 08:46:47 +00002403 if (Type == FST_Printf || Type == FST_NSString) {
Ted Kremenek826a3452010-07-16 02:11:22 +00002404 CheckPrintfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg,
Ted Kremenek4cd57912011-09-29 05:52:16 +00002405 numDataArgs, isa<ObjCStringLiteral>(OrigFormatExpr),
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00002406 Str, HasVAListArg, Args, NumArgs, format_idx,
Richard Trieu55733de2011-10-28 00:41:25 +00002407 inFunctionCall);
Ted Kremenek826a3452010-07-16 02:11:22 +00002408
Hans Wennborgd02deeb2011-12-15 10:25:47 +00002409 if (!analyze_format_string::ParsePrintfString(H, Str, Str + StrLen,
2410 getLangOptions()))
Ted Kremenek826a3452010-07-16 02:11:22 +00002411 H.DoneProcessing();
Jean-Daniel Dupas34269df2012-01-30 08:46:47 +00002412 } else if (Type == FST_Scanf) {
Ted Kremenek826a3452010-07-16 02:11:22 +00002413 CheckScanfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg,
Ted Kremenek4cd57912011-09-29 05:52:16 +00002414 numDataArgs, isa<ObjCStringLiteral>(OrigFormatExpr),
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00002415 Str, HasVAListArg, Args, NumArgs, format_idx,
Richard Trieu55733de2011-10-28 00:41:25 +00002416 inFunctionCall);
Ted Kremenek826a3452010-07-16 02:11:22 +00002417
Hans Wennborgd02deeb2011-12-15 10:25:47 +00002418 if (!analyze_format_string::ParseScanfString(H, Str, Str + StrLen,
2419 getLangOptions()))
Ted Kremenek826a3452010-07-16 02:11:22 +00002420 H.DoneProcessing();
Jean-Daniel Dupas34269df2012-01-30 08:46:47 +00002421 } // TODO: handle other formats
Ted Kremenekce7024e2010-01-28 01:18:22 +00002422}
2423
Chandler Carruth7ccc95b2011-04-27 07:05:31 +00002424//===--- CHECK: Standard memory functions ---------------------------------===//
2425
Douglas Gregor2a053a32011-05-03 20:05:22 +00002426/// \brief Determine whether the given type is a dynamic class type (e.g.,
2427/// whether it has a vtable).
2428static bool isDynamicClassType(QualType T) {
2429 if (CXXRecordDecl *Record = T->getAsCXXRecordDecl())
2430 if (CXXRecordDecl *Definition = Record->getDefinition())
2431 if (Definition->isDynamicClass())
2432 return true;
2433
2434 return false;
2435}
2436
Chandler Carrutha72a12f2011-06-21 23:04:20 +00002437/// \brief If E is a sizeof expression, returns its argument expression,
Chandler Carruth000d4282011-06-16 09:09:40 +00002438/// otherwise returns NULL.
2439static const Expr *getSizeOfExprArg(const Expr* E) {
Nico Webere4a1c642011-06-14 16:14:58 +00002440 if (const UnaryExprOrTypeTraitExpr *SizeOf =
Chandler Carruth000d4282011-06-16 09:09:40 +00002441 dyn_cast<UnaryExprOrTypeTraitExpr>(E))
2442 if (SizeOf->getKind() == clang::UETT_SizeOf && !SizeOf->isArgumentType())
2443 return SizeOf->getArgumentExpr()->IgnoreParenImpCasts();
Nico Webere4a1c642011-06-14 16:14:58 +00002444
Chandler Carruth000d4282011-06-16 09:09:40 +00002445 return 0;
2446}
2447
Chandler Carrutha72a12f2011-06-21 23:04:20 +00002448/// \brief If E is a sizeof expression, returns its argument type.
Chandler Carruth000d4282011-06-16 09:09:40 +00002449static QualType getSizeOfArgType(const Expr* E) {
2450 if (const UnaryExprOrTypeTraitExpr *SizeOf =
2451 dyn_cast<UnaryExprOrTypeTraitExpr>(E))
2452 if (SizeOf->getKind() == clang::UETT_SizeOf)
2453 return SizeOf->getTypeOfArgument();
2454
2455 return QualType();
Nico Webere4a1c642011-06-14 16:14:58 +00002456}
2457
Chandler Carruth7ccc95b2011-04-27 07:05:31 +00002458/// \brief Check for dangerous or invalid arguments to memset().
2459///
Chandler Carruth929f0132011-06-03 06:23:57 +00002460/// This issues warnings on known problematic, dangerous or unspecified
Matt Beaumont-Gaycc2f30c2011-08-05 00:22:34 +00002461/// arguments to the standard 'memset', 'memcpy', 'memmove', and 'memcmp'
2462/// function calls.
Chandler Carruth7ccc95b2011-04-27 07:05:31 +00002463///
2464/// \param Call The call expression to diagnose.
Matt Beaumont-Gaycc2f30c2011-08-05 00:22:34 +00002465void Sema::CheckMemaccessArguments(const CallExpr *Call,
Anna Zaks0a151a12012-01-17 00:37:07 +00002466 unsigned BId,
Matt Beaumont-Gaycc2f30c2011-08-05 00:22:34 +00002467 IdentifierInfo *FnName) {
Anna Zaks0a151a12012-01-17 00:37:07 +00002468 assert(BId != 0);
2469
Ted Kremenek1d59f7f2011-04-28 01:38:02 +00002470 // It is possible to have a non-standard definition of memset. Validate
Douglas Gregor707a23e2011-06-16 17:56:04 +00002471 // we have enough arguments, and if not, abort further checking.
Anna Zaks0a151a12012-01-17 00:37:07 +00002472 unsigned ExpectedNumArgs = (BId == Builtin::BIstrndup ? 2 : 3);
Nico Webercda57822011-10-13 22:30:23 +00002473 if (Call->getNumArgs() < ExpectedNumArgs)
Ted Kremenek1d59f7f2011-04-28 01:38:02 +00002474 return;
2475
Anna Zaks0a151a12012-01-17 00:37:07 +00002476 unsigned LastArg = (BId == Builtin::BImemset ||
2477 BId == Builtin::BIstrndup ? 1 : 2);
2478 unsigned LenArg = (BId == Builtin::BIstrndup ? 1 : 2);
Nico Webercda57822011-10-13 22:30:23 +00002479 const Expr *LenExpr = Call->getArg(LenArg)->IgnoreParenImpCasts();
Chandler Carruth000d4282011-06-16 09:09:40 +00002480
2481 // We have special checking when the length is a sizeof expression.
2482 QualType SizeOfArgTy = getSizeOfArgType(LenExpr);
2483 const Expr *SizeOfArg = getSizeOfExprArg(LenExpr);
2484 llvm::FoldingSetNodeID SizeOfArgID;
2485
Douglas Gregor06bc9eb2011-05-03 20:37:33 +00002486 for (unsigned ArgIdx = 0; ArgIdx != LastArg; ++ArgIdx) {
2487 const Expr *Dest = Call->getArg(ArgIdx)->IgnoreParenImpCasts();
Nico Webere4a1c642011-06-14 16:14:58 +00002488 SourceRange ArgRange = Call->getArg(ArgIdx)->getSourceRange();
Chandler Carruth7ccc95b2011-04-27 07:05:31 +00002489
Douglas Gregor06bc9eb2011-05-03 20:37:33 +00002490 QualType DestTy = Dest->getType();
2491 if (const PointerType *DestPtrTy = DestTy->getAs<PointerType>()) {
2492 QualType PointeeTy = DestPtrTy->getPointeeType();
John McCallf85e1932011-06-15 23:02:42 +00002493
Chandler Carruth000d4282011-06-16 09:09:40 +00002494 // Never warn about void type pointers. This can be used to suppress
2495 // false positives.
2496 if (PointeeTy->isVoidType())
Douglas Gregor06bc9eb2011-05-03 20:37:33 +00002497 continue;
Chandler Carruth7ccc95b2011-04-27 07:05:31 +00002498
Chandler Carruth000d4282011-06-16 09:09:40 +00002499 // Catch "memset(p, 0, sizeof(p))" -- needs to be sizeof(*p). Do this by
2500 // actually comparing the expressions for equality. Because computing the
2501 // expression IDs can be expensive, we only do this if the diagnostic is
2502 // enabled.
2503 if (SizeOfArg &&
2504 Diags.getDiagnosticLevel(diag::warn_sizeof_pointer_expr_memaccess,
2505 SizeOfArg->getExprLoc())) {
2506 // We only compute IDs for expressions if the warning is enabled, and
2507 // cache the sizeof arg's ID.
2508 if (SizeOfArgID == llvm::FoldingSetNodeID())
2509 SizeOfArg->Profile(SizeOfArgID, Context, true);
2510 llvm::FoldingSetNodeID DestID;
2511 Dest->Profile(DestID, Context, true);
2512 if (DestID == SizeOfArgID) {
Nico Webercda57822011-10-13 22:30:23 +00002513 // TODO: For strncpy() and friends, this could suggest sizeof(dst)
2514 // over sizeof(src) as well.
Chandler Carruth000d4282011-06-16 09:09:40 +00002515 unsigned ActionIdx = 0; // Default is to suggest dereferencing.
2516 if (const UnaryOperator *UnaryOp = dyn_cast<UnaryOperator>(Dest))
2517 if (UnaryOp->getOpcode() == UO_AddrOf)
2518 ActionIdx = 1; // If its an address-of operator, just remove it.
2519 if (Context.getTypeSize(PointeeTy) == Context.getCharWidth())
2520 ActionIdx = 2; // If the pointee's size is sizeof(char),
2521 // suggest an explicit length.
Anna Zaksd9b859a2012-01-13 21:52:01 +00002522 unsigned DestSrcSelect =
Anna Zaks0a151a12012-01-17 00:37:07 +00002523 (BId == Builtin::BIstrndup ? 1 : ArgIdx);
Chandler Carruth000d4282011-06-16 09:09:40 +00002524 DiagRuntimeBehavior(SizeOfArg->getExprLoc(), Dest,
2525 PDiag(diag::warn_sizeof_pointer_expr_memaccess)
Nico Webercda57822011-10-13 22:30:23 +00002526 << FnName << DestSrcSelect << ActionIdx
Chandler Carruth000d4282011-06-16 09:09:40 +00002527 << Dest->getSourceRange()
2528 << SizeOfArg->getSourceRange());
2529 break;
2530 }
2531 }
2532
2533 // Also check for cases where the sizeof argument is the exact same
2534 // type as the memory argument, and where it points to a user-defined
2535 // record type.
2536 if (SizeOfArgTy != QualType()) {
2537 if (PointeeTy->isRecordType() &&
2538 Context.typesAreCompatible(SizeOfArgTy, DestTy)) {
2539 DiagRuntimeBehavior(LenExpr->getExprLoc(), Dest,
2540 PDiag(diag::warn_sizeof_pointer_type_memaccess)
2541 << FnName << SizeOfArgTy << ArgIdx
2542 << PointeeTy << Dest->getSourceRange()
2543 << LenExpr->getSourceRange());
2544 break;
2545 }
Nico Webere4a1c642011-06-14 16:14:58 +00002546 }
2547
Douglas Gregor06bc9eb2011-05-03 20:37:33 +00002548 // Always complain about dynamic classes.
Anna Zaks0a151a12012-01-17 00:37:07 +00002549 if (isDynamicClassType(PointeeTy)) {
2550
2551 unsigned OperationType = 0;
2552 // "overwritten" if we're warning about the destination for any call
2553 // but memcmp; otherwise a verb appropriate to the call.
2554 if (ArgIdx != 0 || BId == Builtin::BImemcmp) {
2555 if (BId == Builtin::BImemcpy)
2556 OperationType = 1;
2557 else if(BId == Builtin::BImemmove)
2558 OperationType = 2;
2559 else if (BId == Builtin::BImemcmp)
2560 OperationType = 3;
2561 }
2562
Matt Beaumont-Gay5c5218e2011-08-19 20:40:18 +00002563 DiagRuntimeBehavior(
2564 Dest->getExprLoc(), Dest,
2565 PDiag(diag::warn_dyn_class_memaccess)
Anna Zaks0a151a12012-01-17 00:37:07 +00002566 << (BId == Builtin::BImemcmp ? ArgIdx + 2 : ArgIdx)
Anna Zaksd9b859a2012-01-13 21:52:01 +00002567 << FnName << PointeeTy
Anna Zaks0a151a12012-01-17 00:37:07 +00002568 << OperationType
Matt Beaumont-Gay5c5218e2011-08-19 20:40:18 +00002569 << Call->getCallee()->getSourceRange());
Anna Zaks0a151a12012-01-17 00:37:07 +00002570 } else if (PointeeTy.hasNonTrivialObjCLifetime() &&
2571 BId != Builtin::BImemset)
Matt Beaumont-Gay5c5218e2011-08-19 20:40:18 +00002572 DiagRuntimeBehavior(
2573 Dest->getExprLoc(), Dest,
2574 PDiag(diag::warn_arc_object_memaccess)
2575 << ArgIdx << FnName << PointeeTy
2576 << Call->getCallee()->getSourceRange());
John McCallf85e1932011-06-15 23:02:42 +00002577 else
Douglas Gregor06bc9eb2011-05-03 20:37:33 +00002578 continue;
John McCallf85e1932011-06-15 23:02:42 +00002579
2580 DiagRuntimeBehavior(
2581 Dest->getExprLoc(), Dest,
Chandler Carruth929f0132011-06-03 06:23:57 +00002582 PDiag(diag::note_bad_memaccess_silence)
Douglas Gregor06bc9eb2011-05-03 20:37:33 +00002583 << FixItHint::CreateInsertion(ArgRange.getBegin(), "(void*)"));
2584 break;
2585 }
Chandler Carruth7ccc95b2011-04-27 07:05:31 +00002586 }
2587}
2588
Ted Kremenekbd5da9d2011-08-18 20:55:45 +00002589// A little helper routine: ignore addition and subtraction of integer literals.
2590// This intentionally does not ignore all integer constant expressions because
2591// we don't want to remove sizeof().
2592static const Expr *ignoreLiteralAdditions(const Expr *Ex, ASTContext &Ctx) {
2593 Ex = Ex->IgnoreParenCasts();
2594
2595 for (;;) {
2596 const BinaryOperator * BO = dyn_cast<BinaryOperator>(Ex);
2597 if (!BO || !BO->isAdditiveOp())
2598 break;
2599
2600 const Expr *RHS = BO->getRHS()->IgnoreParenCasts();
2601 const Expr *LHS = BO->getLHS()->IgnoreParenCasts();
2602
2603 if (isa<IntegerLiteral>(RHS))
2604 Ex = LHS;
2605 else if (isa<IntegerLiteral>(LHS))
2606 Ex = RHS;
2607 else
2608 break;
2609 }
2610
2611 return Ex;
2612}
2613
2614// Warn if the user has made the 'size' argument to strlcpy or strlcat
2615// be the size of the source, instead of the destination.
2616void Sema::CheckStrlcpycatArguments(const CallExpr *Call,
2617 IdentifierInfo *FnName) {
2618
2619 // Don't crash if the user has the wrong number of arguments
2620 if (Call->getNumArgs() != 3)
2621 return;
2622
2623 const Expr *SrcArg = ignoreLiteralAdditions(Call->getArg(1), Context);
2624 const Expr *SizeArg = ignoreLiteralAdditions(Call->getArg(2), Context);
2625 const Expr *CompareWithSrc = NULL;
2626
2627 // Look for 'strlcpy(dst, x, sizeof(x))'
2628 if (const Expr *Ex = getSizeOfExprArg(SizeArg))
2629 CompareWithSrc = Ex;
2630 else {
2631 // Look for 'strlcpy(dst, x, strlen(x))'
2632 if (const CallExpr *SizeCall = dyn_cast<CallExpr>(SizeArg)) {
Richard Smith180f4792011-11-10 06:34:14 +00002633 if (SizeCall->isBuiltinCall() == Builtin::BIstrlen
Ted Kremenekbd5da9d2011-08-18 20:55:45 +00002634 && SizeCall->getNumArgs() == 1)
2635 CompareWithSrc = ignoreLiteralAdditions(SizeCall->getArg(0), Context);
2636 }
2637 }
2638
2639 if (!CompareWithSrc)
2640 return;
2641
2642 // Determine if the argument to sizeof/strlen is equal to the source
2643 // argument. In principle there's all kinds of things you could do
2644 // here, for instance creating an == expression and evaluating it with
2645 // EvaluateAsBooleanCondition, but this uses a more direct technique:
2646 const DeclRefExpr *SrcArgDRE = dyn_cast<DeclRefExpr>(SrcArg);
2647 if (!SrcArgDRE)
2648 return;
2649
2650 const DeclRefExpr *CompareWithSrcDRE = dyn_cast<DeclRefExpr>(CompareWithSrc);
2651 if (!CompareWithSrcDRE ||
2652 SrcArgDRE->getDecl() != CompareWithSrcDRE->getDecl())
2653 return;
2654
2655 const Expr *OriginalSizeArg = Call->getArg(2);
2656 Diag(CompareWithSrcDRE->getLocStart(), diag::warn_strlcpycat_wrong_size)
2657 << OriginalSizeArg->getSourceRange() << FnName;
2658
2659 // Output a FIXIT hint if the destination is an array (rather than a
2660 // pointer to an array). This could be enhanced to handle some
2661 // pointers if we know the actual size, like if DstArg is 'array+2'
2662 // we could say 'sizeof(array)-2'.
2663 const Expr *DstArg = Call->getArg(0)->IgnoreParenImpCasts();
Ted Kremenek8f746222011-08-18 22:48:41 +00002664 QualType DstArgTy = DstArg->getType();
Ted Kremenekbd5da9d2011-08-18 20:55:45 +00002665
Ted Kremenek8f746222011-08-18 22:48:41 +00002666 // Only handle constant-sized or VLAs, but not flexible members.
2667 if (const ConstantArrayType *CAT = Context.getAsConstantArrayType(DstArgTy)) {
2668 // Only issue the FIXIT for arrays of size > 1.
2669 if (CAT->getSize().getSExtValue() <= 1)
2670 return;
2671 } else if (!DstArgTy->isVariableArrayType()) {
2672 return;
Ted Kremenekbd5da9d2011-08-18 20:55:45 +00002673 }
Ted Kremenek8f746222011-08-18 22:48:41 +00002674
2675 llvm::SmallString<128> sizeString;
2676 llvm::raw_svector_ostream OS(sizeString);
2677 OS << "sizeof(";
Douglas Gregor8987b232011-09-27 23:30:47 +00002678 DstArg->printPretty(OS, Context, 0, getPrintingPolicy());
Ted Kremenek8f746222011-08-18 22:48:41 +00002679 OS << ")";
2680
2681 Diag(OriginalSizeArg->getLocStart(), diag::note_strlcpycat_wrong_size)
2682 << FixItHint::CreateReplacement(OriginalSizeArg->getSourceRange(),
2683 OS.str());
Ted Kremenekbd5da9d2011-08-18 20:55:45 +00002684}
2685
Ted Kremenek06de2762007-08-17 16:46:58 +00002686//===--- CHECK: Return Address of Stack Variable --------------------------===//
2687
Chris Lattner5f9e2722011-07-23 10:55:15 +00002688static Expr *EvalVal(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars);
2689static Expr *EvalAddr(Expr* E, SmallVectorImpl<DeclRefExpr *> &refVars);
Ted Kremenek06de2762007-08-17 16:46:58 +00002690
2691/// CheckReturnStackAddr - Check if a return statement returns the address
2692/// of a stack variable.
2693void
2694Sema::CheckReturnStackAddr(Expr *RetValExp, QualType lhsType,
2695 SourceLocation ReturnLoc) {
Mike Stump1eb44332009-09-09 15:08:12 +00002696
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00002697 Expr *stackE = 0;
Chris Lattner5f9e2722011-07-23 10:55:15 +00002698 SmallVector<DeclRefExpr *, 8> refVars;
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00002699
2700 // Perform checking for returned stack addresses, local blocks,
2701 // label addresses or references to temporaries.
John McCallf85e1932011-06-15 23:02:42 +00002702 if (lhsType->isPointerType() ||
2703 (!getLangOptions().ObjCAutoRefCount && lhsType->isBlockPointerType())) {
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00002704 stackE = EvalAddr(RetValExp, refVars);
Mike Stumpac5fc7c2009-08-04 21:02:39 +00002705 } else if (lhsType->isReferenceType()) {
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00002706 stackE = EvalVal(RetValExp, refVars);
2707 }
2708
2709 if (stackE == 0)
2710 return; // Nothing suspicious was found.
2711
2712 SourceLocation diagLoc;
2713 SourceRange diagRange;
2714 if (refVars.empty()) {
2715 diagLoc = stackE->getLocStart();
2716 diagRange = stackE->getSourceRange();
2717 } else {
2718 // We followed through a reference variable. 'stackE' contains the
2719 // problematic expression but we will warn at the return statement pointing
2720 // at the reference variable. We will later display the "trail" of
2721 // reference variables using notes.
2722 diagLoc = refVars[0]->getLocStart();
2723 diagRange = refVars[0]->getSourceRange();
2724 }
2725
2726 if (DeclRefExpr *DR = dyn_cast<DeclRefExpr>(stackE)) { //address of local var.
2727 Diag(diagLoc, lhsType->isReferenceType() ? diag::warn_ret_stack_ref
2728 : diag::warn_ret_stack_addr)
2729 << DR->getDecl()->getDeclName() << diagRange;
2730 } else if (isa<BlockExpr>(stackE)) { // local block.
2731 Diag(diagLoc, diag::err_ret_local_block) << diagRange;
2732 } else if (isa<AddrLabelExpr>(stackE)) { // address of label.
2733 Diag(diagLoc, diag::warn_ret_addr_label) << diagRange;
2734 } else { // local temporary.
2735 Diag(diagLoc, lhsType->isReferenceType() ? diag::warn_ret_local_temp_ref
2736 : diag::warn_ret_local_temp_addr)
2737 << diagRange;
2738 }
2739
2740 // Display the "trail" of reference variables that we followed until we
2741 // found the problematic expression using notes.
2742 for (unsigned i = 0, e = refVars.size(); i != e; ++i) {
2743 VarDecl *VD = cast<VarDecl>(refVars[i]->getDecl());
2744 // If this var binds to another reference var, show the range of the next
2745 // var, otherwise the var binds to the problematic expression, in which case
2746 // show the range of the expression.
2747 SourceRange range = (i < e-1) ? refVars[i+1]->getSourceRange()
2748 : stackE->getSourceRange();
2749 Diag(VD->getLocation(), diag::note_ref_var_local_bind)
2750 << VD->getDeclName() << range;
Ted Kremenek06de2762007-08-17 16:46:58 +00002751 }
2752}
2753
2754/// EvalAddr - EvalAddr and EvalVal are mutually recursive functions that
2755/// check if the expression in a return statement evaluates to an address
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00002756/// to a location on the stack, a local block, an address of a label, or a
2757/// reference to local temporary. The recursion is used to traverse the
Ted Kremenek06de2762007-08-17 16:46:58 +00002758/// AST of the return expression, with recursion backtracking when we
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00002759/// encounter a subexpression that (1) clearly does not lead to one of the
2760/// above problematic expressions (2) is something we cannot determine leads to
2761/// a problematic expression based on such local checking.
2762///
2763/// Both EvalAddr and EvalVal follow through reference variables to evaluate
2764/// the expression that they point to. Such variables are added to the
2765/// 'refVars' vector so that we know what the reference variable "trail" was.
Ted Kremenek06de2762007-08-17 16:46:58 +00002766///
Ted Kremeneke8c600f2007-08-28 17:02:55 +00002767/// EvalAddr processes expressions that are pointers that are used as
2768/// references (and not L-values). EvalVal handles all other values.
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00002769/// At the base case of the recursion is a check for the above problematic
2770/// expressions.
Ted Kremenek06de2762007-08-17 16:46:58 +00002771///
2772/// This implementation handles:
2773///
2774/// * pointer-to-pointer casts
2775/// * implicit conversions from array references to pointers
2776/// * taking the address of fields
2777/// * arbitrary interplay between "&" and "*" operators
2778/// * pointer arithmetic from an address of a stack variable
2779/// * taking the address of an array element where the array is on the stack
Chris Lattner5f9e2722011-07-23 10:55:15 +00002780static Expr *EvalAddr(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars) {
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00002781 if (E->isTypeDependent())
2782 return NULL;
2783
Ted Kremenek06de2762007-08-17 16:46:58 +00002784 // We should only be called for evaluating pointer expressions.
David Chisnall0f436562009-08-17 16:35:33 +00002785 assert((E->getType()->isAnyPointerType() ||
Steve Naroffdd972f22008-09-05 22:11:13 +00002786 E->getType()->isBlockPointerType() ||
Ted Kremeneka526c5c2008-01-07 19:49:32 +00002787 E->getType()->isObjCQualifiedIdType()) &&
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00002788 "EvalAddr only works on pointers");
Mike Stump1eb44332009-09-09 15:08:12 +00002789
Peter Collingbournef111d932011-04-15 00:35:48 +00002790 E = E->IgnoreParens();
2791
Ted Kremenek06de2762007-08-17 16:46:58 +00002792 // Our "symbolic interpreter" is just a dispatch off the currently
2793 // viewed AST node. We then recursively traverse the AST by calling
2794 // EvalAddr and EvalVal appropriately.
2795 switch (E->getStmtClass()) {
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00002796 case Stmt::DeclRefExprClass: {
2797 DeclRefExpr *DR = cast<DeclRefExpr>(E);
2798
2799 if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl()))
2800 // If this is a reference variable, follow through to the expression that
2801 // it points to.
2802 if (V->hasLocalStorage() &&
2803 V->getType()->isReferenceType() && V->hasInit()) {
2804 // Add the reference variable to the "trail".
2805 refVars.push_back(DR);
2806 return EvalAddr(V->getInit(), refVars);
2807 }
2808
2809 return NULL;
2810 }
Ted Kremenek06de2762007-08-17 16:46:58 +00002811
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00002812 case Stmt::UnaryOperatorClass: {
2813 // The only unary operator that make sense to handle here
2814 // is AddrOf. All others don't make sense as pointers.
2815 UnaryOperator *U = cast<UnaryOperator>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00002816
John McCall2de56d12010-08-25 11:45:40 +00002817 if (U->getOpcode() == UO_AddrOf)
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00002818 return EvalVal(U->getSubExpr(), refVars);
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00002819 else
Ted Kremenek06de2762007-08-17 16:46:58 +00002820 return NULL;
2821 }
Mike Stump1eb44332009-09-09 15:08:12 +00002822
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00002823 case Stmt::BinaryOperatorClass: {
2824 // Handle pointer arithmetic. All other binary operators are not valid
2825 // in this context.
2826 BinaryOperator *B = cast<BinaryOperator>(E);
John McCall2de56d12010-08-25 11:45:40 +00002827 BinaryOperatorKind op = B->getOpcode();
Mike Stump1eb44332009-09-09 15:08:12 +00002828
John McCall2de56d12010-08-25 11:45:40 +00002829 if (op != BO_Add && op != BO_Sub)
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00002830 return NULL;
Mike Stump1eb44332009-09-09 15:08:12 +00002831
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00002832 Expr *Base = B->getLHS();
2833
2834 // Determine which argument is the real pointer base. It could be
2835 // the RHS argument instead of the LHS.
2836 if (!Base->getType()->isPointerType()) Base = B->getRHS();
Mike Stump1eb44332009-09-09 15:08:12 +00002837
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00002838 assert (Base->getType()->isPointerType());
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00002839 return EvalAddr(Base, refVars);
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00002840 }
Steve Naroff61f40a22008-09-10 19:17:48 +00002841
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00002842 // For conditional operators we need to see if either the LHS or RHS are
2843 // valid DeclRefExpr*s. If one of them is valid, we return it.
2844 case Stmt::ConditionalOperatorClass: {
2845 ConditionalOperator *C = cast<ConditionalOperator>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00002846
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00002847 // Handle the GNU extension for missing LHS.
Douglas Gregor9ee5ee82010-10-21 16:21:08 +00002848 if (Expr *lhsExpr = C->getLHS()) {
2849 // In C++, we can have a throw-expression, which has 'void' type.
2850 if (!lhsExpr->getType()->isVoidType())
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00002851 if (Expr* LHS = EvalAddr(lhsExpr, refVars))
Douglas Gregor9ee5ee82010-10-21 16:21:08 +00002852 return LHS;
2853 }
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00002854
Douglas Gregor9ee5ee82010-10-21 16:21:08 +00002855 // In C++, we can have a throw-expression, which has 'void' type.
2856 if (C->getRHS()->getType()->isVoidType())
2857 return NULL;
2858
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00002859 return EvalAddr(C->getRHS(), refVars);
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00002860 }
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00002861
2862 case Stmt::BlockExprClass:
John McCall469a1eb2011-02-02 13:00:07 +00002863 if (cast<BlockExpr>(E)->getBlockDecl()->hasCaptures())
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00002864 return E; // local block.
2865 return NULL;
2866
2867 case Stmt::AddrLabelExprClass:
2868 return E; // address of label.
Mike Stump1eb44332009-09-09 15:08:12 +00002869
John McCall80ee6e82011-11-10 05:35:25 +00002870 case Stmt::ExprWithCleanupsClass:
2871 return EvalAddr(cast<ExprWithCleanups>(E)->getSubExpr(), refVars);
2872
Ted Kremenek54b52742008-08-07 00:49:01 +00002873 // For casts, we need to handle conversions from arrays to
2874 // pointer values, and pointer-to-pointer conversions.
Douglas Gregor49badde2008-10-27 19:41:14 +00002875 case Stmt::ImplicitCastExprClass:
Douglas Gregor6eec8e82008-10-28 15:36:24 +00002876 case Stmt::CStyleCastExprClass:
John McCallf85e1932011-06-15 23:02:42 +00002877 case Stmt::CXXFunctionalCastExprClass:
2878 case Stmt::ObjCBridgedCastExprClass: {
Argyrios Kyrtzidis0835a3c2008-08-18 23:01:59 +00002879 Expr* SubExpr = cast<CastExpr>(E)->getSubExpr();
Ted Kremenek54b52742008-08-07 00:49:01 +00002880 QualType T = SubExpr->getType();
Mike Stump1eb44332009-09-09 15:08:12 +00002881
Steve Naroffdd972f22008-09-05 22:11:13 +00002882 if (SubExpr->getType()->isPointerType() ||
2883 SubExpr->getType()->isBlockPointerType() ||
2884 SubExpr->getType()->isObjCQualifiedIdType())
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00002885 return EvalAddr(SubExpr, refVars);
Ted Kremenek54b52742008-08-07 00:49:01 +00002886 else if (T->isArrayType())
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00002887 return EvalVal(SubExpr, refVars);
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00002888 else
Ted Kremenek54b52742008-08-07 00:49:01 +00002889 return 0;
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00002890 }
Mike Stump1eb44332009-09-09 15:08:12 +00002891
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00002892 // C++ casts. For dynamic casts, static casts, and const casts, we
2893 // are always converting from a pointer-to-pointer, so we just blow
Douglas Gregor49badde2008-10-27 19:41:14 +00002894 // through the cast. In the case the dynamic cast doesn't fail (and
2895 // return NULL), we take the conservative route and report cases
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00002896 // where we return the address of a stack variable. For Reinterpre
Douglas Gregor49badde2008-10-27 19:41:14 +00002897 // FIXME: The comment about is wrong; we're not always converting
2898 // from pointer to pointer. I'm guessing that this code should also
Mike Stump1eb44332009-09-09 15:08:12 +00002899 // handle references to objects.
2900 case Stmt::CXXStaticCastExprClass:
2901 case Stmt::CXXDynamicCastExprClass:
Douglas Gregor49badde2008-10-27 19:41:14 +00002902 case Stmt::CXXConstCastExprClass:
2903 case Stmt::CXXReinterpretCastExprClass: {
2904 Expr *S = cast<CXXNamedCastExpr>(E)->getSubExpr();
Steve Naroffdd972f22008-09-05 22:11:13 +00002905 if (S->getType()->isPointerType() || S->getType()->isBlockPointerType())
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00002906 return EvalAddr(S, refVars);
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00002907 else
2908 return NULL;
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00002909 }
Mike Stump1eb44332009-09-09 15:08:12 +00002910
Douglas Gregor03e80032011-06-21 17:03:29 +00002911 case Stmt::MaterializeTemporaryExprClass:
2912 if (Expr *Result = EvalAddr(
2913 cast<MaterializeTemporaryExpr>(E)->GetTemporaryExpr(),
2914 refVars))
2915 return Result;
2916
2917 return E;
2918
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00002919 // Everything else: we simply don't reason about them.
2920 default:
2921 return NULL;
2922 }
Ted Kremenek06de2762007-08-17 16:46:58 +00002923}
Mike Stump1eb44332009-09-09 15:08:12 +00002924
Ted Kremenek06de2762007-08-17 16:46:58 +00002925
2926/// EvalVal - This function is complements EvalAddr in the mutual recursion.
2927/// See the comments for EvalAddr for more details.
Chris Lattner5f9e2722011-07-23 10:55:15 +00002928static Expr *EvalVal(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars) {
Ted Kremenek68957a92010-08-04 20:01:07 +00002929do {
Ted Kremeneke8c600f2007-08-28 17:02:55 +00002930 // We should only be called for evaluating non-pointer expressions, or
2931 // expressions with a pointer type that are not used as references but instead
2932 // are l-values (e.g., DeclRefExpr with a pointer type).
Mike Stump1eb44332009-09-09 15:08:12 +00002933
Ted Kremenek06de2762007-08-17 16:46:58 +00002934 // Our "symbolic interpreter" is just a dispatch off the currently
2935 // viewed AST node. We then recursively traverse the AST by calling
2936 // EvalAddr and EvalVal appropriately.
Peter Collingbournef111d932011-04-15 00:35:48 +00002937
2938 E = E->IgnoreParens();
Ted Kremenek06de2762007-08-17 16:46:58 +00002939 switch (E->getStmtClass()) {
Ted Kremenek68957a92010-08-04 20:01:07 +00002940 case Stmt::ImplicitCastExprClass: {
2941 ImplicitCastExpr *IE = cast<ImplicitCastExpr>(E);
John McCall5baba9d2010-08-25 10:28:54 +00002942 if (IE->getValueKind() == VK_LValue) {
Ted Kremenek68957a92010-08-04 20:01:07 +00002943 E = IE->getSubExpr();
2944 continue;
2945 }
2946 return NULL;
2947 }
2948
John McCall80ee6e82011-11-10 05:35:25 +00002949 case Stmt::ExprWithCleanupsClass:
2950 return EvalVal(cast<ExprWithCleanups>(E)->getSubExpr(), refVars);
2951
Douglas Gregora2813ce2009-10-23 18:54:35 +00002952 case Stmt::DeclRefExprClass: {
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00002953 // When we hit a DeclRefExpr we are looking at code that refers to a
2954 // variable's name. If it's not a reference variable we check if it has
2955 // local storage within the function, and if so, return the expression.
Ted Kremenek06de2762007-08-17 16:46:58 +00002956 DeclRefExpr *DR = cast<DeclRefExpr>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00002957
Ted Kremenek06de2762007-08-17 16:46:58 +00002958 if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl()))
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00002959 if (V->hasLocalStorage()) {
2960 if (!V->getType()->isReferenceType())
2961 return DR;
2962
2963 // Reference variable, follow through to the expression that
2964 // it points to.
2965 if (V->hasInit()) {
2966 // Add the reference variable to the "trail".
2967 refVars.push_back(DR);
2968 return EvalVal(V->getInit(), refVars);
2969 }
2970 }
Mike Stump1eb44332009-09-09 15:08:12 +00002971
Ted Kremenek06de2762007-08-17 16:46:58 +00002972 return NULL;
2973 }
Mike Stump1eb44332009-09-09 15:08:12 +00002974
Ted Kremenek06de2762007-08-17 16:46:58 +00002975 case Stmt::UnaryOperatorClass: {
2976 // The only unary operator that make sense to handle here
2977 // is Deref. All others don't resolve to a "name." This includes
2978 // handling all sorts of rvalues passed to a unary operator.
2979 UnaryOperator *U = cast<UnaryOperator>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00002980
John McCall2de56d12010-08-25 11:45:40 +00002981 if (U->getOpcode() == UO_Deref)
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00002982 return EvalAddr(U->getSubExpr(), refVars);
Ted Kremenek06de2762007-08-17 16:46:58 +00002983
2984 return NULL;
2985 }
Mike Stump1eb44332009-09-09 15:08:12 +00002986
Ted Kremenek06de2762007-08-17 16:46:58 +00002987 case Stmt::ArraySubscriptExprClass: {
2988 // Array subscripts are potential references to data on the stack. We
2989 // retrieve the DeclRefExpr* for the array variable if it indeed
2990 // has local storage.
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00002991 return EvalAddr(cast<ArraySubscriptExpr>(E)->getBase(), refVars);
Ted Kremenek06de2762007-08-17 16:46:58 +00002992 }
Mike Stump1eb44332009-09-09 15:08:12 +00002993
Ted Kremenek06de2762007-08-17 16:46:58 +00002994 case Stmt::ConditionalOperatorClass: {
2995 // For conditional operators we need to see if either the LHS or RHS are
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00002996 // non-NULL Expr's. If one is non-NULL, we return it.
Ted Kremenek06de2762007-08-17 16:46:58 +00002997 ConditionalOperator *C = cast<ConditionalOperator>(E);
2998
Anders Carlsson39073232007-11-30 19:04:31 +00002999 // Handle the GNU extension for missing LHS.
3000 if (Expr *lhsExpr = C->getLHS())
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00003001 if (Expr *LHS = EvalVal(lhsExpr, refVars))
Anders Carlsson39073232007-11-30 19:04:31 +00003002 return LHS;
3003
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00003004 return EvalVal(C->getRHS(), refVars);
Ted Kremenek06de2762007-08-17 16:46:58 +00003005 }
Mike Stump1eb44332009-09-09 15:08:12 +00003006
Ted Kremenek06de2762007-08-17 16:46:58 +00003007 // Accesses to members are potential references to data on the stack.
Douglas Gregor83f6faf2009-08-31 23:41:50 +00003008 case Stmt::MemberExprClass: {
Ted Kremenek06de2762007-08-17 16:46:58 +00003009 MemberExpr *M = cast<MemberExpr>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00003010
Ted Kremenek06de2762007-08-17 16:46:58 +00003011 // Check for indirect access. We only want direct field accesses.
Ted Kremeneka423e812010-09-02 01:12:13 +00003012 if (M->isArrow())
Ted Kremenek06de2762007-08-17 16:46:58 +00003013 return NULL;
Ted Kremeneka423e812010-09-02 01:12:13 +00003014
3015 // Check whether the member type is itself a reference, in which case
3016 // we're not going to refer to the member, but to what the member refers to.
3017 if (M->getMemberDecl()->getType()->isReferenceType())
3018 return NULL;
3019
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00003020 return EvalVal(M->getBase(), refVars);
Ted Kremenek06de2762007-08-17 16:46:58 +00003021 }
Mike Stump1eb44332009-09-09 15:08:12 +00003022
Douglas Gregor03e80032011-06-21 17:03:29 +00003023 case Stmt::MaterializeTemporaryExprClass:
3024 if (Expr *Result = EvalVal(
3025 cast<MaterializeTemporaryExpr>(E)->GetTemporaryExpr(),
3026 refVars))
3027 return Result;
3028
3029 return E;
3030
Ted Kremenek06de2762007-08-17 16:46:58 +00003031 default:
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00003032 // Check that we don't return or take the address of a reference to a
3033 // temporary. This is only useful in C++.
3034 if (!E->isTypeDependent() && E->isRValue())
3035 return E;
3036
3037 // Everything else: we simply don't reason about them.
Ted Kremenek06de2762007-08-17 16:46:58 +00003038 return NULL;
3039 }
Ted Kremenek68957a92010-08-04 20:01:07 +00003040} while (true);
Ted Kremenek06de2762007-08-17 16:46:58 +00003041}
Ted Kremenek588e5eb2007-11-25 00:58:00 +00003042
3043//===--- CHECK: Floating-Point comparisons (-Wfloat-equal) ---------------===//
3044
3045/// Check for comparisons of floating point operands using != and ==.
3046/// Issue a warning if these are no self-comparisons, as they are not likely
3047/// to do what the programmer intended.
Richard Trieudd225092011-09-15 21:56:47 +00003048void Sema::CheckFloatComparison(SourceLocation Loc, Expr* LHS, Expr *RHS) {
Ted Kremenek588e5eb2007-11-25 00:58:00 +00003049 bool EmitWarning = true;
Mike Stump1eb44332009-09-09 15:08:12 +00003050
Richard Trieudd225092011-09-15 21:56:47 +00003051 Expr* LeftExprSansParen = LHS->IgnoreParenImpCasts();
3052 Expr* RightExprSansParen = RHS->IgnoreParenImpCasts();
Ted Kremenek588e5eb2007-11-25 00:58:00 +00003053
3054 // Special case: check for x == x (which is OK).
3055 // Do not emit warnings for such cases.
3056 if (DeclRefExpr* DRL = dyn_cast<DeclRefExpr>(LeftExprSansParen))
3057 if (DeclRefExpr* DRR = dyn_cast<DeclRefExpr>(RightExprSansParen))
3058 if (DRL->getDecl() == DRR->getDecl())
3059 EmitWarning = false;
Mike Stump1eb44332009-09-09 15:08:12 +00003060
3061
Ted Kremenek1b500bb2007-11-29 00:59:04 +00003062 // Special case: check for comparisons against literals that can be exactly
3063 // represented by APFloat. In such cases, do not emit a warning. This
3064 // is a heuristic: often comparison against such literals are used to
3065 // detect if a value in a variable has not changed. This clearly can
3066 // lead to false negatives.
3067 if (EmitWarning) {
3068 if (FloatingLiteral* FLL = dyn_cast<FloatingLiteral>(LeftExprSansParen)) {
3069 if (FLL->isExact())
3070 EmitWarning = false;
Mike Stumpac5fc7c2009-08-04 21:02:39 +00003071 } else
Ted Kremenek1b500bb2007-11-29 00:59:04 +00003072 if (FloatingLiteral* FLR = dyn_cast<FloatingLiteral>(RightExprSansParen)){
3073 if (FLR->isExact())
3074 EmitWarning = false;
3075 }
3076 }
Mike Stump1eb44332009-09-09 15:08:12 +00003077
Ted Kremenek588e5eb2007-11-25 00:58:00 +00003078 // Check for comparisons with builtin types.
Sebastian Redl0eb23302009-01-19 00:08:26 +00003079 if (EmitWarning)
Ted Kremenek588e5eb2007-11-25 00:58:00 +00003080 if (CallExpr* CL = dyn_cast<CallExpr>(LeftExprSansParen))
Richard Smith180f4792011-11-10 06:34:14 +00003081 if (CL->isBuiltinCall())
Ted Kremenek588e5eb2007-11-25 00:58:00 +00003082 EmitWarning = false;
Mike Stump1eb44332009-09-09 15:08:12 +00003083
Sebastian Redl0eb23302009-01-19 00:08:26 +00003084 if (EmitWarning)
Ted Kremenek588e5eb2007-11-25 00:58:00 +00003085 if (CallExpr* CR = dyn_cast<CallExpr>(RightExprSansParen))
Richard Smith180f4792011-11-10 06:34:14 +00003086 if (CR->isBuiltinCall())
Ted Kremenek588e5eb2007-11-25 00:58:00 +00003087 EmitWarning = false;
Mike Stump1eb44332009-09-09 15:08:12 +00003088
Ted Kremenek588e5eb2007-11-25 00:58:00 +00003089 // Emit the diagnostic.
3090 if (EmitWarning)
Richard Trieudd225092011-09-15 21:56:47 +00003091 Diag(Loc, diag::warn_floatingpoint_eq)
3092 << LHS->getSourceRange() << RHS->getSourceRange();
Ted Kremenek588e5eb2007-11-25 00:58:00 +00003093}
John McCallba26e582010-01-04 23:21:16 +00003094
John McCallf2370c92010-01-06 05:24:50 +00003095//===--- CHECK: Integer mixed-sign comparisons (-Wsign-compare) --------===//
3096//===--- CHECK: Lossy implicit conversions (-Wconversion) --------------===//
John McCallba26e582010-01-04 23:21:16 +00003097
John McCallf2370c92010-01-06 05:24:50 +00003098namespace {
John McCallba26e582010-01-04 23:21:16 +00003099
John McCallf2370c92010-01-06 05:24:50 +00003100/// Structure recording the 'active' range of an integer-valued
3101/// expression.
3102struct IntRange {
3103 /// The number of bits active in the int.
3104 unsigned Width;
John McCallba26e582010-01-04 23:21:16 +00003105
John McCallf2370c92010-01-06 05:24:50 +00003106 /// True if the int is known not to have negative values.
3107 bool NonNegative;
John McCallba26e582010-01-04 23:21:16 +00003108
John McCallf2370c92010-01-06 05:24:50 +00003109 IntRange(unsigned Width, bool NonNegative)
3110 : Width(Width), NonNegative(NonNegative)
3111 {}
John McCallba26e582010-01-04 23:21:16 +00003112
John McCall1844a6e2010-11-10 23:38:19 +00003113 /// Returns the range of the bool type.
John McCallf2370c92010-01-06 05:24:50 +00003114 static IntRange forBoolType() {
3115 return IntRange(1, true);
John McCall51313c32010-01-04 23:31:57 +00003116 }
3117
John McCall1844a6e2010-11-10 23:38:19 +00003118 /// Returns the range of an opaque value of the given integral type.
3119 static IntRange forValueOfType(ASTContext &C, QualType T) {
3120 return forValueOfCanonicalType(C,
3121 T->getCanonicalTypeInternal().getTypePtr());
John McCall51313c32010-01-04 23:31:57 +00003122 }
3123
John McCall1844a6e2010-11-10 23:38:19 +00003124 /// Returns the range of an opaque value of a canonical integral type.
3125 static IntRange forValueOfCanonicalType(ASTContext &C, const Type *T) {
John McCallf2370c92010-01-06 05:24:50 +00003126 assert(T->isCanonicalUnqualified());
3127
3128 if (const VectorType *VT = dyn_cast<VectorType>(T))
3129 T = VT->getElementType().getTypePtr();
3130 if (const ComplexType *CT = dyn_cast<ComplexType>(T))
3131 T = CT->getElementType().getTypePtr();
John McCall323ed742010-05-06 08:58:33 +00003132
John McCall091f23f2010-11-09 22:22:12 +00003133 // For enum types, use the known bit width of the enumerators.
John McCall323ed742010-05-06 08:58:33 +00003134 if (const EnumType *ET = dyn_cast<EnumType>(T)) {
3135 EnumDecl *Enum = ET->getDecl();
John McCall5e1cdac2011-10-07 06:10:15 +00003136 if (!Enum->isCompleteDefinition())
John McCall091f23f2010-11-09 22:22:12 +00003137 return IntRange(C.getIntWidth(QualType(T, 0)), false);
3138
John McCall323ed742010-05-06 08:58:33 +00003139 unsigned NumPositive = Enum->getNumPositiveBits();
3140 unsigned NumNegative = Enum->getNumNegativeBits();
3141
3142 return IntRange(std::max(NumPositive, NumNegative), NumNegative == 0);
3143 }
John McCallf2370c92010-01-06 05:24:50 +00003144
3145 const BuiltinType *BT = cast<BuiltinType>(T);
3146 assert(BT->isInteger());
3147
3148 return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger());
3149 }
3150
John McCall1844a6e2010-11-10 23:38:19 +00003151 /// Returns the "target" range of a canonical integral type, i.e.
3152 /// the range of values expressible in the type.
3153 ///
3154 /// This matches forValueOfCanonicalType except that enums have the
3155 /// full range of their type, not the range of their enumerators.
3156 static IntRange forTargetOfCanonicalType(ASTContext &C, const Type *T) {
3157 assert(T->isCanonicalUnqualified());
3158
3159 if (const VectorType *VT = dyn_cast<VectorType>(T))
3160 T = VT->getElementType().getTypePtr();
3161 if (const ComplexType *CT = dyn_cast<ComplexType>(T))
3162 T = CT->getElementType().getTypePtr();
3163 if (const EnumType *ET = dyn_cast<EnumType>(T))
Douglas Gregor69ff26b2011-09-08 23:29:05 +00003164 T = C.getCanonicalType(ET->getDecl()->getIntegerType()).getTypePtr();
John McCall1844a6e2010-11-10 23:38:19 +00003165
3166 const BuiltinType *BT = cast<BuiltinType>(T);
3167 assert(BT->isInteger());
3168
3169 return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger());
3170 }
3171
3172 /// Returns the supremum of two ranges: i.e. their conservative merge.
John McCallc0cd21d2010-02-23 19:22:29 +00003173 static IntRange join(IntRange L, IntRange R) {
John McCallf2370c92010-01-06 05:24:50 +00003174 return IntRange(std::max(L.Width, R.Width),
John McCall60fad452010-01-06 22:07:33 +00003175 L.NonNegative && R.NonNegative);
3176 }
3177
John McCall1844a6e2010-11-10 23:38:19 +00003178 /// Returns the infinum of two ranges: i.e. their aggressive merge.
John McCallc0cd21d2010-02-23 19:22:29 +00003179 static IntRange meet(IntRange L, IntRange R) {
John McCall60fad452010-01-06 22:07:33 +00003180 return IntRange(std::min(L.Width, R.Width),
3181 L.NonNegative || R.NonNegative);
John McCallf2370c92010-01-06 05:24:50 +00003182 }
3183};
3184
Ted Kremenek0692a192012-01-31 05:37:37 +00003185static IntRange GetValueRange(ASTContext &C, llvm::APSInt &value,
3186 unsigned MaxWidth) {
John McCallf2370c92010-01-06 05:24:50 +00003187 if (value.isSigned() && value.isNegative())
3188 return IntRange(value.getMinSignedBits(), false);
3189
3190 if (value.getBitWidth() > MaxWidth)
Jay Foad9f71a8f2010-12-07 08:25:34 +00003191 value = value.trunc(MaxWidth);
John McCallf2370c92010-01-06 05:24:50 +00003192
3193 // isNonNegative() just checks the sign bit without considering
3194 // signedness.
3195 return IntRange(value.getActiveBits(), true);
3196}
3197
Ted Kremenek0692a192012-01-31 05:37:37 +00003198static IntRange GetValueRange(ASTContext &C, APValue &result, QualType Ty,
3199 unsigned MaxWidth) {
John McCallf2370c92010-01-06 05:24:50 +00003200 if (result.isInt())
3201 return GetValueRange(C, result.getInt(), MaxWidth);
3202
3203 if (result.isVector()) {
John McCall0acc3112010-01-06 22:57:21 +00003204 IntRange R = GetValueRange(C, result.getVectorElt(0), Ty, MaxWidth);
3205 for (unsigned i = 1, e = result.getVectorLength(); i != e; ++i) {
3206 IntRange El = GetValueRange(C, result.getVectorElt(i), Ty, MaxWidth);
3207 R = IntRange::join(R, El);
3208 }
John McCallf2370c92010-01-06 05:24:50 +00003209 return R;
3210 }
3211
3212 if (result.isComplexInt()) {
3213 IntRange R = GetValueRange(C, result.getComplexIntReal(), MaxWidth);
3214 IntRange I = GetValueRange(C, result.getComplexIntImag(), MaxWidth);
3215 return IntRange::join(R, I);
John McCall51313c32010-01-04 23:31:57 +00003216 }
3217
3218 // This can happen with lossless casts to intptr_t of "based" lvalues.
3219 // Assume it might use arbitrary bits.
John McCall0acc3112010-01-06 22:57:21 +00003220 // FIXME: The only reason we need to pass the type in here is to get
3221 // the sign right on this one case. It would be nice if APValue
3222 // preserved this.
Eli Friedman65639282012-01-04 23:13:47 +00003223 assert(result.isLValue() || result.isAddrLabelDiff());
Douglas Gregor5e9ebb32011-05-21 16:28:01 +00003224 return IntRange(MaxWidth, Ty->isUnsignedIntegerOrEnumerationType());
John McCall51313c32010-01-04 23:31:57 +00003225}
John McCallf2370c92010-01-06 05:24:50 +00003226
3227/// Pseudo-evaluate the given integer expression, estimating the
3228/// range of values it might take.
3229///
3230/// \param MaxWidth - the width to which the value will be truncated
Ted Kremenek0692a192012-01-31 05:37:37 +00003231static IntRange GetExprRange(ASTContext &C, Expr *E, unsigned MaxWidth) {
John McCallf2370c92010-01-06 05:24:50 +00003232 E = E->IgnoreParens();
3233
3234 // Try a full evaluation first.
3235 Expr::EvalResult result;
Richard Smith51f47082011-10-29 00:50:52 +00003236 if (E->EvaluateAsRValue(result, C))
John McCall0acc3112010-01-06 22:57:21 +00003237 return GetValueRange(C, result.Val, E->getType(), MaxWidth);
John McCallf2370c92010-01-06 05:24:50 +00003238
3239 // I think we only want to look through implicit casts here; if the
3240 // user has an explicit widening cast, we should treat the value as
3241 // being of the new, wider type.
3242 if (ImplicitCastExpr *CE = dyn_cast<ImplicitCastExpr>(E)) {
Eli Friedmanb17ee5b2011-12-15 02:41:52 +00003243 if (CE->getCastKind() == CK_NoOp || CE->getCastKind() == CK_LValueToRValue)
John McCallf2370c92010-01-06 05:24:50 +00003244 return GetExprRange(C, CE->getSubExpr(), MaxWidth);
3245
John McCall1844a6e2010-11-10 23:38:19 +00003246 IntRange OutputTypeRange = IntRange::forValueOfType(C, CE->getType());
John McCallf2370c92010-01-06 05:24:50 +00003247
John McCall2de56d12010-08-25 11:45:40 +00003248 bool isIntegerCast = (CE->getCastKind() == CK_IntegralCast);
John McCall60fad452010-01-06 22:07:33 +00003249
John McCallf2370c92010-01-06 05:24:50 +00003250 // Assume that non-integer casts can span the full range of the type.
John McCall60fad452010-01-06 22:07:33 +00003251 if (!isIntegerCast)
John McCallf2370c92010-01-06 05:24:50 +00003252 return OutputTypeRange;
3253
3254 IntRange SubRange
3255 = GetExprRange(C, CE->getSubExpr(),
3256 std::min(MaxWidth, OutputTypeRange.Width));
3257
3258 // Bail out if the subexpr's range is as wide as the cast type.
3259 if (SubRange.Width >= OutputTypeRange.Width)
3260 return OutputTypeRange;
3261
3262 // Otherwise, we take the smaller width, and we're non-negative if
3263 // either the output type or the subexpr is.
3264 return IntRange(SubRange.Width,
3265 SubRange.NonNegative || OutputTypeRange.NonNegative);
3266 }
3267
3268 if (ConditionalOperator *CO = dyn_cast<ConditionalOperator>(E)) {
3269 // If we can fold the condition, just take that operand.
3270 bool CondResult;
3271 if (CO->getCond()->EvaluateAsBooleanCondition(CondResult, C))
3272 return GetExprRange(C, CondResult ? CO->getTrueExpr()
3273 : CO->getFalseExpr(),
3274 MaxWidth);
3275
3276 // Otherwise, conservatively merge.
3277 IntRange L = GetExprRange(C, CO->getTrueExpr(), MaxWidth);
3278 IntRange R = GetExprRange(C, CO->getFalseExpr(), MaxWidth);
3279 return IntRange::join(L, R);
3280 }
3281
3282 if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) {
3283 switch (BO->getOpcode()) {
3284
3285 // Boolean-valued operations are single-bit and positive.
John McCall2de56d12010-08-25 11:45:40 +00003286 case BO_LAnd:
3287 case BO_LOr:
3288 case BO_LT:
3289 case BO_GT:
3290 case BO_LE:
3291 case BO_GE:
3292 case BO_EQ:
3293 case BO_NE:
John McCallf2370c92010-01-06 05:24:50 +00003294 return IntRange::forBoolType();
3295
John McCall862ff872011-07-13 06:35:24 +00003296 // The type of the assignments is the type of the LHS, so the RHS
3297 // is not necessarily the same type.
John McCall2de56d12010-08-25 11:45:40 +00003298 case BO_MulAssign:
3299 case BO_DivAssign:
3300 case BO_RemAssign:
3301 case BO_AddAssign:
3302 case BO_SubAssign:
John McCall862ff872011-07-13 06:35:24 +00003303 case BO_XorAssign:
3304 case BO_OrAssign:
3305 // TODO: bitfields?
John McCall1844a6e2010-11-10 23:38:19 +00003306 return IntRange::forValueOfType(C, E->getType());
John McCallc0cd21d2010-02-23 19:22:29 +00003307
John McCall862ff872011-07-13 06:35:24 +00003308 // Simple assignments just pass through the RHS, which will have
3309 // been coerced to the LHS type.
3310 case BO_Assign:
3311 // TODO: bitfields?
3312 return GetExprRange(C, BO->getRHS(), MaxWidth);
3313
John McCallf2370c92010-01-06 05:24:50 +00003314 // Operations with opaque sources are black-listed.
John McCall2de56d12010-08-25 11:45:40 +00003315 case BO_PtrMemD:
3316 case BO_PtrMemI:
John McCall1844a6e2010-11-10 23:38:19 +00003317 return IntRange::forValueOfType(C, E->getType());
John McCallf2370c92010-01-06 05:24:50 +00003318
John McCall60fad452010-01-06 22:07:33 +00003319 // Bitwise-and uses the *infinum* of the two source ranges.
John McCall2de56d12010-08-25 11:45:40 +00003320 case BO_And:
3321 case BO_AndAssign:
John McCall60fad452010-01-06 22:07:33 +00003322 return IntRange::meet(GetExprRange(C, BO->getLHS(), MaxWidth),
3323 GetExprRange(C, BO->getRHS(), MaxWidth));
3324
John McCallf2370c92010-01-06 05:24:50 +00003325 // Left shift gets black-listed based on a judgement call.
John McCall2de56d12010-08-25 11:45:40 +00003326 case BO_Shl:
John McCall3aae6092010-04-07 01:14:35 +00003327 // ...except that we want to treat '1 << (blah)' as logically
3328 // positive. It's an important idiom.
3329 if (IntegerLiteral *I
3330 = dyn_cast<IntegerLiteral>(BO->getLHS()->IgnoreParenCasts())) {
3331 if (I->getValue() == 1) {
John McCall1844a6e2010-11-10 23:38:19 +00003332 IntRange R = IntRange::forValueOfType(C, E->getType());
John McCall3aae6092010-04-07 01:14:35 +00003333 return IntRange(R.Width, /*NonNegative*/ true);
3334 }
3335 }
3336 // fallthrough
3337
John McCall2de56d12010-08-25 11:45:40 +00003338 case BO_ShlAssign:
John McCall1844a6e2010-11-10 23:38:19 +00003339 return IntRange::forValueOfType(C, E->getType());
John McCallf2370c92010-01-06 05:24:50 +00003340
John McCall60fad452010-01-06 22:07:33 +00003341 // Right shift by a constant can narrow its left argument.
John McCall2de56d12010-08-25 11:45:40 +00003342 case BO_Shr:
3343 case BO_ShrAssign: {
John McCall60fad452010-01-06 22:07:33 +00003344 IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth);
3345
3346 // If the shift amount is a positive constant, drop the width by
3347 // that much.
3348 llvm::APSInt shift;
3349 if (BO->getRHS()->isIntegerConstantExpr(shift, C) &&
3350 shift.isNonNegative()) {
3351 unsigned zext = shift.getZExtValue();
3352 if (zext >= L.Width)
3353 L.Width = (L.NonNegative ? 0 : 1);
3354 else
3355 L.Width -= zext;
3356 }
3357
3358 return L;
3359 }
3360
3361 // Comma acts as its right operand.
John McCall2de56d12010-08-25 11:45:40 +00003362 case BO_Comma:
John McCallf2370c92010-01-06 05:24:50 +00003363 return GetExprRange(C, BO->getRHS(), MaxWidth);
3364
John McCall60fad452010-01-06 22:07:33 +00003365 // Black-list pointer subtractions.
John McCall2de56d12010-08-25 11:45:40 +00003366 case BO_Sub:
John McCallf2370c92010-01-06 05:24:50 +00003367 if (BO->getLHS()->getType()->isPointerType())
John McCall1844a6e2010-11-10 23:38:19 +00003368 return IntRange::forValueOfType(C, E->getType());
John McCall00fe7612011-07-14 22:39:48 +00003369 break;
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00003370
John McCall00fe7612011-07-14 22:39:48 +00003371 // The width of a division result is mostly determined by the size
3372 // of the LHS.
3373 case BO_Div: {
3374 // Don't 'pre-truncate' the operands.
3375 unsigned opWidth = C.getIntWidth(E->getType());
3376 IntRange L = GetExprRange(C, BO->getLHS(), opWidth);
3377
3378 // If the divisor is constant, use that.
3379 llvm::APSInt divisor;
3380 if (BO->getRHS()->isIntegerConstantExpr(divisor, C)) {
3381 unsigned log2 = divisor.logBase2(); // floor(log_2(divisor))
3382 if (log2 >= L.Width)
3383 L.Width = (L.NonNegative ? 0 : 1);
3384 else
3385 L.Width = std::min(L.Width - log2, MaxWidth);
3386 return L;
3387 }
3388
3389 // Otherwise, just use the LHS's width.
3390 IntRange R = GetExprRange(C, BO->getRHS(), opWidth);
3391 return IntRange(L.Width, L.NonNegative && R.NonNegative);
3392 }
3393
3394 // The result of a remainder can't be larger than the result of
3395 // either side.
3396 case BO_Rem: {
3397 // Don't 'pre-truncate' the operands.
3398 unsigned opWidth = C.getIntWidth(E->getType());
3399 IntRange L = GetExprRange(C, BO->getLHS(), opWidth);
3400 IntRange R = GetExprRange(C, BO->getRHS(), opWidth);
3401
3402 IntRange meet = IntRange::meet(L, R);
3403 meet.Width = std::min(meet.Width, MaxWidth);
3404 return meet;
3405 }
3406
3407 // The default behavior is okay for these.
3408 case BO_Mul:
3409 case BO_Add:
3410 case BO_Xor:
3411 case BO_Or:
John McCallf2370c92010-01-06 05:24:50 +00003412 break;
3413 }
3414
John McCall00fe7612011-07-14 22:39:48 +00003415 // The default case is to treat the operation as if it were closed
3416 // on the narrowest type that encompasses both operands.
John McCallf2370c92010-01-06 05:24:50 +00003417 IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth);
3418 IntRange R = GetExprRange(C, BO->getRHS(), MaxWidth);
3419 return IntRange::join(L, R);
3420 }
3421
3422 if (UnaryOperator *UO = dyn_cast<UnaryOperator>(E)) {
3423 switch (UO->getOpcode()) {
3424 // Boolean-valued operations are white-listed.
John McCall2de56d12010-08-25 11:45:40 +00003425 case UO_LNot:
John McCallf2370c92010-01-06 05:24:50 +00003426 return IntRange::forBoolType();
3427
3428 // Operations with opaque sources are black-listed.
John McCall2de56d12010-08-25 11:45:40 +00003429 case UO_Deref:
3430 case UO_AddrOf: // should be impossible
John McCall1844a6e2010-11-10 23:38:19 +00003431 return IntRange::forValueOfType(C, E->getType());
John McCallf2370c92010-01-06 05:24:50 +00003432
3433 default:
3434 return GetExprRange(C, UO->getSubExpr(), MaxWidth);
3435 }
3436 }
Douglas Gregor8ecdb652010-04-28 22:16:22 +00003437
3438 if (dyn_cast<OffsetOfExpr>(E)) {
John McCall1844a6e2010-11-10 23:38:19 +00003439 IntRange::forValueOfType(C, E->getType());
Douglas Gregor8ecdb652010-04-28 22:16:22 +00003440 }
John McCallf2370c92010-01-06 05:24:50 +00003441
Richard Smitha6b8b2c2011-10-10 18:28:20 +00003442 if (FieldDecl *BitField = E->getBitField())
3443 return IntRange(BitField->getBitWidthValue(C),
Douglas Gregor5e9ebb32011-05-21 16:28:01 +00003444 BitField->getType()->isUnsignedIntegerOrEnumerationType());
John McCallf2370c92010-01-06 05:24:50 +00003445
John McCall1844a6e2010-11-10 23:38:19 +00003446 return IntRange::forValueOfType(C, E->getType());
John McCallf2370c92010-01-06 05:24:50 +00003447}
John McCall51313c32010-01-04 23:31:57 +00003448
Ted Kremenek0692a192012-01-31 05:37:37 +00003449static IntRange GetExprRange(ASTContext &C, Expr *E) {
John McCall323ed742010-05-06 08:58:33 +00003450 return GetExprRange(C, E, C.getIntWidth(E->getType()));
3451}
3452
John McCall51313c32010-01-04 23:31:57 +00003453/// Checks whether the given value, which currently has the given
3454/// source semantics, has the same value when coerced through the
3455/// target semantics.
Ted Kremenek0692a192012-01-31 05:37:37 +00003456static bool IsSameFloatAfterCast(const llvm::APFloat &value,
3457 const llvm::fltSemantics &Src,
3458 const llvm::fltSemantics &Tgt) {
John McCall51313c32010-01-04 23:31:57 +00003459 llvm::APFloat truncated = value;
3460
3461 bool ignored;
3462 truncated.convert(Src, llvm::APFloat::rmNearestTiesToEven, &ignored);
3463 truncated.convert(Tgt, llvm::APFloat::rmNearestTiesToEven, &ignored);
3464
3465 return truncated.bitwiseIsEqual(value);
3466}
3467
3468/// Checks whether the given value, which currently has the given
3469/// source semantics, has the same value when coerced through the
3470/// target semantics.
3471///
3472/// The value might be a vector of floats (or a complex number).
Ted Kremenek0692a192012-01-31 05:37:37 +00003473static bool IsSameFloatAfterCast(const APValue &value,
3474 const llvm::fltSemantics &Src,
3475 const llvm::fltSemantics &Tgt) {
John McCall51313c32010-01-04 23:31:57 +00003476 if (value.isFloat())
3477 return IsSameFloatAfterCast(value.getFloat(), Src, Tgt);
3478
3479 if (value.isVector()) {
3480 for (unsigned i = 0, e = value.getVectorLength(); i != e; ++i)
3481 if (!IsSameFloatAfterCast(value.getVectorElt(i), Src, Tgt))
3482 return false;
3483 return true;
3484 }
3485
3486 assert(value.isComplexFloat());
3487 return (IsSameFloatAfterCast(value.getComplexFloatReal(), Src, Tgt) &&
3488 IsSameFloatAfterCast(value.getComplexFloatImag(), Src, Tgt));
3489}
3490
Ted Kremenek0692a192012-01-31 05:37:37 +00003491static void AnalyzeImplicitConversions(Sema &S, Expr *E, SourceLocation CC);
John McCall323ed742010-05-06 08:58:33 +00003492
Ted Kremeneke3b159c2010-09-23 21:43:44 +00003493static bool IsZero(Sema &S, Expr *E) {
3494 // Suppress cases where we are comparing against an enum constant.
3495 if (const DeclRefExpr *DR =
3496 dyn_cast<DeclRefExpr>(E->IgnoreParenImpCasts()))
3497 if (isa<EnumConstantDecl>(DR->getDecl()))
3498 return false;
3499
3500 // Suppress cases where the '0' value is expanded from a macro.
3501 if (E->getLocStart().isMacroID())
3502 return false;
3503
John McCall323ed742010-05-06 08:58:33 +00003504 llvm::APSInt Value;
3505 return E->isIntegerConstantExpr(Value, S.Context) && Value == 0;
3506}
3507
John McCall372e1032010-10-06 00:25:24 +00003508static bool HasEnumType(Expr *E) {
3509 // Strip off implicit integral promotions.
3510 while (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(E)) {
Argyrios Kyrtzidis63b57ae2010-10-07 21:52:18 +00003511 if (ICE->getCastKind() != CK_IntegralCast &&
3512 ICE->getCastKind() != CK_NoOp)
John McCall372e1032010-10-06 00:25:24 +00003513 break;
Argyrios Kyrtzidis63b57ae2010-10-07 21:52:18 +00003514 E = ICE->getSubExpr();
John McCall372e1032010-10-06 00:25:24 +00003515 }
3516
3517 return E->getType()->isEnumeralType();
3518}
3519
Ted Kremenek0692a192012-01-31 05:37:37 +00003520static void CheckTrivialUnsignedComparison(Sema &S, BinaryOperator *E) {
John McCall2de56d12010-08-25 11:45:40 +00003521 BinaryOperatorKind op = E->getOpcode();
Douglas Gregor14af91a2010-12-21 07:22:56 +00003522 if (E->isValueDependent())
3523 return;
3524
John McCall2de56d12010-08-25 11:45:40 +00003525 if (op == BO_LT && IsZero(S, E->getRHS())) {
John McCall323ed742010-05-06 08:58:33 +00003526 S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison)
John McCall372e1032010-10-06 00:25:24 +00003527 << "< 0" << "false" << HasEnumType(E->getLHS())
John McCall323ed742010-05-06 08:58:33 +00003528 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
John McCall2de56d12010-08-25 11:45:40 +00003529 } else if (op == BO_GE && IsZero(S, E->getRHS())) {
John McCall323ed742010-05-06 08:58:33 +00003530 S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison)
John McCall372e1032010-10-06 00:25:24 +00003531 << ">= 0" << "true" << HasEnumType(E->getLHS())
John McCall323ed742010-05-06 08:58:33 +00003532 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
John McCall2de56d12010-08-25 11:45:40 +00003533 } else if (op == BO_GT && IsZero(S, E->getLHS())) {
John McCall323ed742010-05-06 08:58:33 +00003534 S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison)
John McCall372e1032010-10-06 00:25:24 +00003535 << "0 >" << "false" << HasEnumType(E->getRHS())
John McCall323ed742010-05-06 08:58:33 +00003536 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
John McCall2de56d12010-08-25 11:45:40 +00003537 } else if (op == BO_LE && IsZero(S, E->getLHS())) {
John McCall323ed742010-05-06 08:58:33 +00003538 S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison)
John McCall372e1032010-10-06 00:25:24 +00003539 << "0 <=" << "true" << HasEnumType(E->getRHS())
John McCall323ed742010-05-06 08:58:33 +00003540 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
3541 }
3542}
3543
3544/// Analyze the operands of the given comparison. Implements the
3545/// fallback case from AnalyzeComparison.
Ted Kremenek0692a192012-01-31 05:37:37 +00003546static void AnalyzeImpConvsInComparison(Sema &S, BinaryOperator *E) {
John McCallb4eb64d2010-10-08 02:01:28 +00003547 AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc());
3548 AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc());
John McCall323ed742010-05-06 08:58:33 +00003549}
John McCall51313c32010-01-04 23:31:57 +00003550
John McCallba26e582010-01-04 23:21:16 +00003551/// \brief Implements -Wsign-compare.
3552///
Richard Trieudd225092011-09-15 21:56:47 +00003553/// \param E the binary operator to check for warnings
Ted Kremenek0692a192012-01-31 05:37:37 +00003554static void AnalyzeComparison(Sema &S, BinaryOperator *E) {
John McCall323ed742010-05-06 08:58:33 +00003555 // The type the comparison is being performed in.
3556 QualType T = E->getLHS()->getType();
3557 assert(S.Context.hasSameUnqualifiedType(T, E->getRHS()->getType())
3558 && "comparison with mismatched types");
John McCallba26e582010-01-04 23:21:16 +00003559
John McCall323ed742010-05-06 08:58:33 +00003560 // We don't do anything special if this isn't an unsigned integral
3561 // comparison: we're only interested in integral comparisons, and
3562 // signed comparisons only happen in cases we don't care to warn about.
Douglas Gregor3e026e32011-02-19 22:34:59 +00003563 //
3564 // We also don't care about value-dependent expressions or expressions
3565 // whose result is a constant.
3566 if (!T->hasUnsignedIntegerRepresentation()
3567 || E->isValueDependent() || E->isIntegerConstantExpr(S.Context))
John McCall323ed742010-05-06 08:58:33 +00003568 return AnalyzeImpConvsInComparison(S, E);
John McCallf2370c92010-01-06 05:24:50 +00003569
Richard Trieudd225092011-09-15 21:56:47 +00003570 Expr *LHS = E->getLHS()->IgnoreParenImpCasts();
3571 Expr *RHS = E->getRHS()->IgnoreParenImpCasts();
John McCallba26e582010-01-04 23:21:16 +00003572
John McCall323ed742010-05-06 08:58:33 +00003573 // Check to see if one of the (unmodified) operands is of different
3574 // signedness.
3575 Expr *signedOperand, *unsignedOperand;
Richard Trieudd225092011-09-15 21:56:47 +00003576 if (LHS->getType()->hasSignedIntegerRepresentation()) {
3577 assert(!RHS->getType()->hasSignedIntegerRepresentation() &&
John McCall323ed742010-05-06 08:58:33 +00003578 "unsigned comparison between two signed integer expressions?");
Richard Trieudd225092011-09-15 21:56:47 +00003579 signedOperand = LHS;
3580 unsignedOperand = RHS;
3581 } else if (RHS->getType()->hasSignedIntegerRepresentation()) {
3582 signedOperand = RHS;
3583 unsignedOperand = LHS;
John McCallba26e582010-01-04 23:21:16 +00003584 } else {
John McCall323ed742010-05-06 08:58:33 +00003585 CheckTrivialUnsignedComparison(S, E);
3586 return AnalyzeImpConvsInComparison(S, E);
John McCallba26e582010-01-04 23:21:16 +00003587 }
3588
John McCall323ed742010-05-06 08:58:33 +00003589 // Otherwise, calculate the effective range of the signed operand.
3590 IntRange signedRange = GetExprRange(S.Context, signedOperand);
John McCallf2370c92010-01-06 05:24:50 +00003591
John McCall323ed742010-05-06 08:58:33 +00003592 // Go ahead and analyze implicit conversions in the operands. Note
3593 // that we skip the implicit conversions on both sides.
Richard Trieudd225092011-09-15 21:56:47 +00003594 AnalyzeImplicitConversions(S, LHS, E->getOperatorLoc());
3595 AnalyzeImplicitConversions(S, RHS, E->getOperatorLoc());
John McCallba26e582010-01-04 23:21:16 +00003596
John McCall323ed742010-05-06 08:58:33 +00003597 // If the signed range is non-negative, -Wsign-compare won't fire,
3598 // but we should still check for comparisons which are always true
3599 // or false.
3600 if (signedRange.NonNegative)
3601 return CheckTrivialUnsignedComparison(S, E);
John McCallba26e582010-01-04 23:21:16 +00003602
3603 // For (in)equality comparisons, if the unsigned operand is a
3604 // constant which cannot collide with a overflowed signed operand,
3605 // then reinterpreting the signed operand as unsigned will not
3606 // change the result of the comparison.
John McCall323ed742010-05-06 08:58:33 +00003607 if (E->isEqualityOp()) {
3608 unsigned comparisonWidth = S.Context.getIntWidth(T);
3609 IntRange unsignedRange = GetExprRange(S.Context, unsignedOperand);
John McCallba26e582010-01-04 23:21:16 +00003610
John McCall323ed742010-05-06 08:58:33 +00003611 // We should never be unable to prove that the unsigned operand is
3612 // non-negative.
3613 assert(unsignedRange.NonNegative && "unsigned range includes negative?");
3614
3615 if (unsignedRange.Width < comparisonWidth)
3616 return;
3617 }
3618
3619 S.Diag(E->getOperatorLoc(), diag::warn_mixed_sign_comparison)
Richard Trieudd225092011-09-15 21:56:47 +00003620 << LHS->getType() << RHS->getType()
3621 << LHS->getSourceRange() << RHS->getSourceRange();
John McCallba26e582010-01-04 23:21:16 +00003622}
3623
John McCall15d7d122010-11-11 03:21:53 +00003624/// Analyzes an attempt to assign the given value to a bitfield.
3625///
3626/// Returns true if there was something fishy about the attempt.
Ted Kremenek0692a192012-01-31 05:37:37 +00003627static bool AnalyzeBitFieldAssignment(Sema &S, FieldDecl *Bitfield, Expr *Init,
3628 SourceLocation InitLoc) {
John McCall15d7d122010-11-11 03:21:53 +00003629 assert(Bitfield->isBitField());
3630 if (Bitfield->isInvalidDecl())
3631 return false;
3632
John McCall91b60142010-11-11 05:33:51 +00003633 // White-list bool bitfields.
3634 if (Bitfield->getType()->isBooleanType())
3635 return false;
3636
Douglas Gregor46ff3032011-02-04 13:09:01 +00003637 // Ignore value- or type-dependent expressions.
3638 if (Bitfield->getBitWidth()->isValueDependent() ||
3639 Bitfield->getBitWidth()->isTypeDependent() ||
3640 Init->isValueDependent() ||
3641 Init->isTypeDependent())
3642 return false;
3643
John McCall15d7d122010-11-11 03:21:53 +00003644 Expr *OriginalInit = Init->IgnoreParenImpCasts();
3645
Richard Smith80d4b552011-12-28 19:48:30 +00003646 llvm::APSInt Value;
3647 if (!OriginalInit->EvaluateAsInt(Value, S.Context, Expr::SE_AllowSideEffects))
John McCall15d7d122010-11-11 03:21:53 +00003648 return false;
3649
John McCall15d7d122010-11-11 03:21:53 +00003650 unsigned OriginalWidth = Value.getBitWidth();
Richard Smitha6b8b2c2011-10-10 18:28:20 +00003651 unsigned FieldWidth = Bitfield->getBitWidthValue(S.Context);
John McCall15d7d122010-11-11 03:21:53 +00003652
3653 if (OriginalWidth <= FieldWidth)
3654 return false;
3655
Eli Friedman3a643af2012-01-26 23:11:39 +00003656 // Compute the value which the bitfield will contain.
Jay Foad9f71a8f2010-12-07 08:25:34 +00003657 llvm::APSInt TruncatedValue = Value.trunc(FieldWidth);
Eli Friedman3a643af2012-01-26 23:11:39 +00003658 TruncatedValue.setIsSigned(Bitfield->getType()->isSignedIntegerType());
John McCall15d7d122010-11-11 03:21:53 +00003659
Eli Friedman3a643af2012-01-26 23:11:39 +00003660 // Check whether the stored value is equal to the original value.
3661 TruncatedValue = TruncatedValue.extend(OriginalWidth);
John McCall15d7d122010-11-11 03:21:53 +00003662 if (Value == TruncatedValue)
3663 return false;
3664
Eli Friedman3a643af2012-01-26 23:11:39 +00003665 // Special-case bitfields of width 1: booleans are naturally 0/1, and
3666 // therefore don't strictly fit into a bitfield of width 1.
3667 if (FieldWidth == 1 && Value.getBoolValue() == TruncatedValue.getBoolValue())
3668 return false;
3669
John McCall15d7d122010-11-11 03:21:53 +00003670 std::string PrettyValue = Value.toString(10);
3671 std::string PrettyTrunc = TruncatedValue.toString(10);
3672
3673 S.Diag(InitLoc, diag::warn_impcast_bitfield_precision_constant)
3674 << PrettyValue << PrettyTrunc << OriginalInit->getType()
3675 << Init->getSourceRange();
3676
3677 return true;
3678}
3679
John McCallbeb22aa2010-11-09 23:24:47 +00003680/// Analyze the given simple or compound assignment for warning-worthy
3681/// operations.
Ted Kremenek0692a192012-01-31 05:37:37 +00003682static void AnalyzeAssignment(Sema &S, BinaryOperator *E) {
John McCallbeb22aa2010-11-09 23:24:47 +00003683 // Just recurse on the LHS.
3684 AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc());
3685
3686 // We want to recurse on the RHS as normal unless we're assigning to
3687 // a bitfield.
3688 if (FieldDecl *Bitfield = E->getLHS()->getBitField()) {
John McCall15d7d122010-11-11 03:21:53 +00003689 if (AnalyzeBitFieldAssignment(S, Bitfield, E->getRHS(),
3690 E->getOperatorLoc())) {
3691 // Recurse, ignoring any implicit conversions on the RHS.
3692 return AnalyzeImplicitConversions(S, E->getRHS()->IgnoreParenImpCasts(),
3693 E->getOperatorLoc());
John McCallbeb22aa2010-11-09 23:24:47 +00003694 }
3695 }
3696
3697 AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc());
3698}
3699
John McCall51313c32010-01-04 23:31:57 +00003700/// Diagnose an implicit cast; purely a helper for CheckImplicitConversion.
Ted Kremenek0692a192012-01-31 05:37:37 +00003701static void DiagnoseImpCast(Sema &S, Expr *E, QualType SourceType, QualType T,
Ted Kremenekfdba1822012-01-31 05:37:48 +00003702 SourceLocation CContext, unsigned diag,
3703 bool pruneControlFlow = false) {
3704 if (pruneControlFlow) {
3705 S.DiagRuntimeBehavior(E->getExprLoc(), E,
3706 S.PDiag(diag)
3707 << SourceType << T << E->getSourceRange()
3708 << SourceRange(CContext));
3709 return;
3710 }
Douglas Gregor5a5b38f2011-03-12 00:14:31 +00003711 S.Diag(E->getExprLoc(), diag)
3712 << SourceType << T << E->getSourceRange() << SourceRange(CContext);
3713}
3714
Chandler Carruthe1b02e02011-04-05 06:47:57 +00003715/// Diagnose an implicit cast; purely a helper for CheckImplicitConversion.
Ted Kremenek0692a192012-01-31 05:37:37 +00003716static void DiagnoseImpCast(Sema &S, Expr *E, QualType T,
Ted Kremenekfdba1822012-01-31 05:37:48 +00003717 SourceLocation CContext, unsigned diag,
3718 bool pruneControlFlow = false) {
3719 DiagnoseImpCast(S, E, E->getType(), T, CContext, diag, pruneControlFlow);
Chandler Carruthe1b02e02011-04-05 06:47:57 +00003720}
3721
Matt Beaumont-Gay9ce63772011-10-14 15:36:25 +00003722/// Diagnose an implicit cast from a literal expression. Does not warn when the
3723/// cast wouldn't lose information.
Chandler Carruthf65076e2011-04-10 08:36:24 +00003724void DiagnoseFloatingLiteralImpCast(Sema &S, FloatingLiteral *FL, QualType T,
3725 SourceLocation CContext) {
Matt Beaumont-Gay9ce63772011-10-14 15:36:25 +00003726 // Try to convert the literal exactly to an integer. If we can, don't warn.
Chandler Carruthf65076e2011-04-10 08:36:24 +00003727 bool isExact = false;
Matt Beaumont-Gay9ce63772011-10-14 15:36:25 +00003728 const llvm::APFloat &Value = FL->getValue();
Jeffrey Yasskin3e1ef782011-07-15 17:03:07 +00003729 llvm::APSInt IntegerValue(S.Context.getIntWidth(T),
3730 T->hasUnsignedIntegerRepresentation());
3731 if (Value.convertToInteger(IntegerValue,
Chandler Carruthf65076e2011-04-10 08:36:24 +00003732 llvm::APFloat::rmTowardZero, &isExact)
Matt Beaumont-Gay9ce63772011-10-14 15:36:25 +00003733 == llvm::APFloat::opOK && isExact)
Chandler Carruthf65076e2011-04-10 08:36:24 +00003734 return;
3735
Matt Beaumont-Gay9ce63772011-10-14 15:36:25 +00003736 S.Diag(FL->getExprLoc(), diag::warn_impcast_literal_float_to_integer)
3737 << FL->getType() << T << FL->getSourceRange() << SourceRange(CContext);
Chandler Carruthf65076e2011-04-10 08:36:24 +00003738}
3739
John McCall091f23f2010-11-09 22:22:12 +00003740std::string PrettyPrintInRange(const llvm::APSInt &Value, IntRange Range) {
3741 if (!Range.Width) return "0";
3742
3743 llvm::APSInt ValueInRange = Value;
3744 ValueInRange.setIsSigned(!Range.NonNegative);
Jay Foad9f71a8f2010-12-07 08:25:34 +00003745 ValueInRange = ValueInRange.trunc(Range.Width);
John McCall091f23f2010-11-09 22:22:12 +00003746 return ValueInRange.toString(10);
3747}
3748
John McCall323ed742010-05-06 08:58:33 +00003749void CheckImplicitConversion(Sema &S, Expr *E, QualType T,
John McCallb4eb64d2010-10-08 02:01:28 +00003750 SourceLocation CC, bool *ICContext = 0) {
John McCall323ed742010-05-06 08:58:33 +00003751 if (E->isTypeDependent() || E->isValueDependent()) return;
John McCall51313c32010-01-04 23:31:57 +00003752
John McCall323ed742010-05-06 08:58:33 +00003753 const Type *Source = S.Context.getCanonicalType(E->getType()).getTypePtr();
3754 const Type *Target = S.Context.getCanonicalType(T).getTypePtr();
3755 if (Source == Target) return;
3756 if (Target->isDependentType()) return;
John McCall51313c32010-01-04 23:31:57 +00003757
Chandler Carruth108f7562011-07-26 05:40:03 +00003758 // If the conversion context location is invalid don't complain. We also
3759 // don't want to emit a warning if the issue occurs from the expansion of
3760 // a system macro. The problem is that 'getSpellingLoc()' is slow, so we
3761 // delay this check as long as possible. Once we detect we are in that
3762 // scenario, we just return.
Ted Kremenekef9ff882011-03-10 20:03:42 +00003763 if (CC.isInvalid())
John McCallb4eb64d2010-10-08 02:01:28 +00003764 return;
3765
Richard Trieuf1f8b1a2011-09-23 20:10:00 +00003766 // Diagnose implicit casts to bool.
3767 if (Target->isSpecificBuiltinType(BuiltinType::Bool)) {
3768 if (isa<StringLiteral>(E))
3769 // Warn on string literal to bool. Checks for string literals in logical
3770 // expressions, for instances, assert(0 && "error here"), is prevented
3771 // by a check in AnalyzeImplicitConversions().
3772 return DiagnoseImpCast(S, E, T, CC,
3773 diag::warn_impcast_string_literal_to_bool);
Lang Hamese14ca9f2011-12-05 20:49:50 +00003774 if (Source->isFunctionType()) {
3775 // Warn on function to bool. Checks free functions and static member
3776 // functions. Weakly imported functions are excluded from the check,
3777 // since it's common to test their value to check whether the linker
3778 // found a definition for them.
3779 ValueDecl *D = 0;
3780 if (DeclRefExpr* R = dyn_cast<DeclRefExpr>(E)) {
3781 D = R->getDecl();
3782 } else if (MemberExpr *M = dyn_cast<MemberExpr>(E)) {
3783 D = M->getMemberDecl();
3784 }
3785
3786 if (D && !D->isWeak()) {
Richard Trieu26b45d82011-12-06 04:48:01 +00003787 if (FunctionDecl* F = dyn_cast<FunctionDecl>(D)) {
3788 S.Diag(E->getExprLoc(), diag::warn_impcast_function_to_bool)
3789 << F << E->getSourceRange() << SourceRange(CC);
David Blaikie2def7732011-12-09 21:42:37 +00003790 S.Diag(E->getExprLoc(), diag::note_function_to_bool_silence)
3791 << FixItHint::CreateInsertion(E->getExprLoc(), "&");
3792 QualType ReturnType;
3793 UnresolvedSet<4> NonTemplateOverloads;
3794 S.isExprCallable(*E, ReturnType, NonTemplateOverloads);
3795 if (!ReturnType.isNull()
3796 && ReturnType->isSpecificBuiltinType(BuiltinType::Bool))
3797 S.Diag(E->getExprLoc(), diag::note_function_to_bool_call)
3798 << FixItHint::CreateInsertion(
3799 S.getPreprocessor().getLocForEndOfToken(E->getLocEnd()), "()");
Richard Trieu26b45d82011-12-06 04:48:01 +00003800 return;
3801 }
Lang Hamese14ca9f2011-12-05 20:49:50 +00003802 }
3803 }
David Blaikiee37cdc42011-09-29 04:06:47 +00003804 return; // Other casts to bool are not checked.
Richard Trieuf1f8b1a2011-09-23 20:10:00 +00003805 }
John McCall51313c32010-01-04 23:31:57 +00003806
3807 // Strip vector types.
3808 if (isa<VectorType>(Source)) {
Ted Kremenekef9ff882011-03-10 20:03:42 +00003809 if (!isa<VectorType>(Target)) {
Matt Beaumont-Gayd87a0cd2012-01-06 22:43:58 +00003810 if (S.SourceMgr.isInSystemMacro(CC))
Ted Kremenekef9ff882011-03-10 20:03:42 +00003811 return;
John McCallb4eb64d2010-10-08 02:01:28 +00003812 return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_vector_scalar);
Ted Kremenekef9ff882011-03-10 20:03:42 +00003813 }
Chris Lattnerb792b302011-06-14 04:51:15 +00003814
3815 // If the vector cast is cast between two vectors of the same size, it is
3816 // a bitcast, not a conversion.
3817 if (S.Context.getTypeSize(Source) == S.Context.getTypeSize(Target))
3818 return;
John McCall51313c32010-01-04 23:31:57 +00003819
3820 Source = cast<VectorType>(Source)->getElementType().getTypePtr();
3821 Target = cast<VectorType>(Target)->getElementType().getTypePtr();
3822 }
3823
3824 // Strip complex types.
3825 if (isa<ComplexType>(Source)) {
Ted Kremenekef9ff882011-03-10 20:03:42 +00003826 if (!isa<ComplexType>(Target)) {
Matt Beaumont-Gayd87a0cd2012-01-06 22:43:58 +00003827 if (S.SourceMgr.isInSystemMacro(CC))
Ted Kremenekef9ff882011-03-10 20:03:42 +00003828 return;
3829
John McCallb4eb64d2010-10-08 02:01:28 +00003830 return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_complex_scalar);
Ted Kremenekef9ff882011-03-10 20:03:42 +00003831 }
John McCall51313c32010-01-04 23:31:57 +00003832
3833 Source = cast<ComplexType>(Source)->getElementType().getTypePtr();
3834 Target = cast<ComplexType>(Target)->getElementType().getTypePtr();
3835 }
3836
3837 const BuiltinType *SourceBT = dyn_cast<BuiltinType>(Source);
3838 const BuiltinType *TargetBT = dyn_cast<BuiltinType>(Target);
3839
3840 // If the source is floating point...
3841 if (SourceBT && SourceBT->isFloatingPoint()) {
3842 // ...and the target is floating point...
3843 if (TargetBT && TargetBT->isFloatingPoint()) {
3844 // ...then warn if we're dropping FP rank.
3845
3846 // Builtin FP kinds are ordered by increasing FP rank.
3847 if (SourceBT->getKind() > TargetBT->getKind()) {
3848 // Don't warn about float constants that are precisely
3849 // representable in the target type.
3850 Expr::EvalResult result;
Richard Smith51f47082011-10-29 00:50:52 +00003851 if (E->EvaluateAsRValue(result, S.Context)) {
John McCall51313c32010-01-04 23:31:57 +00003852 // Value might be a float, a float vector, or a float complex.
3853 if (IsSameFloatAfterCast(result.Val,
John McCall323ed742010-05-06 08:58:33 +00003854 S.Context.getFloatTypeSemantics(QualType(TargetBT, 0)),
3855 S.Context.getFloatTypeSemantics(QualType(SourceBT, 0))))
John McCall51313c32010-01-04 23:31:57 +00003856 return;
3857 }
3858
Matt Beaumont-Gayd87a0cd2012-01-06 22:43:58 +00003859 if (S.SourceMgr.isInSystemMacro(CC))
Ted Kremenekef9ff882011-03-10 20:03:42 +00003860 return;
3861
John McCallb4eb64d2010-10-08 02:01:28 +00003862 DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_precision);
John McCall51313c32010-01-04 23:31:57 +00003863 }
3864 return;
3865 }
3866
Ted Kremenekef9ff882011-03-10 20:03:42 +00003867 // If the target is integral, always warn.
Chandler Carrutha5b93322011-02-17 11:05:49 +00003868 if ((TargetBT && TargetBT->isInteger())) {
Matt Beaumont-Gayd87a0cd2012-01-06 22:43:58 +00003869 if (S.SourceMgr.isInSystemMacro(CC))
Ted Kremenekef9ff882011-03-10 20:03:42 +00003870 return;
3871
Chandler Carrutha5b93322011-02-17 11:05:49 +00003872 Expr *InnerE = E->IgnoreParenImpCasts();
Matt Beaumont-Gay634c8af2011-09-08 22:30:47 +00003873 // We also want to warn on, e.g., "int i = -1.234"
3874 if (UnaryOperator *UOp = dyn_cast<UnaryOperator>(InnerE))
3875 if (UOp->getOpcode() == UO_Minus || UOp->getOpcode() == UO_Plus)
3876 InnerE = UOp->getSubExpr()->IgnoreParenImpCasts();
3877
Chandler Carruthf65076e2011-04-10 08:36:24 +00003878 if (FloatingLiteral *FL = dyn_cast<FloatingLiteral>(InnerE)) {
3879 DiagnoseFloatingLiteralImpCast(S, FL, T, CC);
Chandler Carrutha5b93322011-02-17 11:05:49 +00003880 } else {
3881 DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_integer);
3882 }
3883 }
John McCall51313c32010-01-04 23:31:57 +00003884
3885 return;
3886 }
3887
John McCallf2370c92010-01-06 05:24:50 +00003888 if (!Source->isIntegerType() || !Target->isIntegerType())
John McCall51313c32010-01-04 23:31:57 +00003889 return;
3890
Richard Trieu1838ca52011-05-29 19:59:02 +00003891 if ((E->isNullPointerConstant(S.Context, Expr::NPC_ValueDependentIsNotNull)
3892 == Expr::NPCK_GNUNull) && Target->isIntegerType()) {
3893 S.Diag(E->getExprLoc(), diag::warn_impcast_null_pointer_to_integer)
3894 << E->getSourceRange() << clang::SourceRange(CC);
3895 return;
3896 }
3897
John McCall323ed742010-05-06 08:58:33 +00003898 IntRange SourceRange = GetExprRange(S.Context, E);
John McCall1844a6e2010-11-10 23:38:19 +00003899 IntRange TargetRange = IntRange::forTargetOfCanonicalType(S.Context, Target);
John McCallf2370c92010-01-06 05:24:50 +00003900
3901 if (SourceRange.Width > TargetRange.Width) {
John McCall091f23f2010-11-09 22:22:12 +00003902 // If the source is a constant, use a default-on diagnostic.
3903 // TODO: this should happen for bitfield stores, too.
3904 llvm::APSInt Value(32);
3905 if (E->isIntegerConstantExpr(Value, S.Context)) {
Matt Beaumont-Gayd87a0cd2012-01-06 22:43:58 +00003906 if (S.SourceMgr.isInSystemMacro(CC))
Ted Kremenekef9ff882011-03-10 20:03:42 +00003907 return;
3908
John McCall091f23f2010-11-09 22:22:12 +00003909 std::string PrettySourceValue = Value.toString(10);
3910 std::string PrettyTargetValue = PrettyPrintInRange(Value, TargetRange);
3911
Ted Kremenek5e745da2011-10-22 02:37:33 +00003912 S.DiagRuntimeBehavior(E->getExprLoc(), E,
3913 S.PDiag(diag::warn_impcast_integer_precision_constant)
3914 << PrettySourceValue << PrettyTargetValue
3915 << E->getType() << T << E->getSourceRange()
3916 << clang::SourceRange(CC));
John McCall091f23f2010-11-09 22:22:12 +00003917 return;
3918 }
3919
Chris Lattnerb792b302011-06-14 04:51:15 +00003920 // People want to build with -Wshorten-64-to-32 and not -Wconversion.
Matt Beaumont-Gayd87a0cd2012-01-06 22:43:58 +00003921 if (S.SourceMgr.isInSystemMacro(CC))
Ted Kremenekef9ff882011-03-10 20:03:42 +00003922 return;
3923
John McCallf2370c92010-01-06 05:24:50 +00003924 if (SourceRange.Width == 64 && TargetRange.Width == 32)
Ted Kremenekfdba1822012-01-31 05:37:48 +00003925 return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_64_32,
3926 /* pruneControlFlow */ true);
John McCallb4eb64d2010-10-08 02:01:28 +00003927 return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_precision);
John McCall323ed742010-05-06 08:58:33 +00003928 }
3929
3930 if ((TargetRange.NonNegative && !SourceRange.NonNegative) ||
3931 (!TargetRange.NonNegative && SourceRange.NonNegative &&
3932 SourceRange.Width == TargetRange.Width)) {
Ted Kremenekef9ff882011-03-10 20:03:42 +00003933
Matt Beaumont-Gayd87a0cd2012-01-06 22:43:58 +00003934 if (S.SourceMgr.isInSystemMacro(CC))
Ted Kremenekef9ff882011-03-10 20:03:42 +00003935 return;
3936
John McCall323ed742010-05-06 08:58:33 +00003937 unsigned DiagID = diag::warn_impcast_integer_sign;
3938
3939 // Traditionally, gcc has warned about this under -Wsign-compare.
3940 // We also want to warn about it in -Wconversion.
3941 // So if -Wconversion is off, use a completely identical diagnostic
3942 // in the sign-compare group.
3943 // The conditional-checking code will
3944 if (ICContext) {
3945 DiagID = diag::warn_impcast_integer_sign_conditional;
3946 *ICContext = true;
3947 }
3948
John McCallb4eb64d2010-10-08 02:01:28 +00003949 return DiagnoseImpCast(S, E, T, CC, DiagID);
John McCall51313c32010-01-04 23:31:57 +00003950 }
3951
Douglas Gregor284cc8d2011-02-22 02:45:07 +00003952 // Diagnose conversions between different enumeration types.
Douglas Gregor5a5b38f2011-03-12 00:14:31 +00003953 // In C, we pretend that the type of an EnumConstantDecl is its enumeration
3954 // type, to give us better diagnostics.
3955 QualType SourceType = E->getType();
3956 if (!S.getLangOptions().CPlusPlus) {
3957 if (DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(E))
3958 if (EnumConstantDecl *ECD = dyn_cast<EnumConstantDecl>(DRE->getDecl())) {
3959 EnumDecl *Enum = cast<EnumDecl>(ECD->getDeclContext());
3960 SourceType = S.Context.getTypeDeclType(Enum);
3961 Source = S.Context.getCanonicalType(SourceType).getTypePtr();
3962 }
3963 }
3964
Douglas Gregor284cc8d2011-02-22 02:45:07 +00003965 if (const EnumType *SourceEnum = Source->getAs<EnumType>())
3966 if (const EnumType *TargetEnum = Target->getAs<EnumType>())
3967 if ((SourceEnum->getDecl()->getIdentifier() ||
Richard Smith162e1c12011-04-15 14:24:37 +00003968 SourceEnum->getDecl()->getTypedefNameForAnonDecl()) &&
Douglas Gregor284cc8d2011-02-22 02:45:07 +00003969 (TargetEnum->getDecl()->getIdentifier() ||
Richard Smith162e1c12011-04-15 14:24:37 +00003970 TargetEnum->getDecl()->getTypedefNameForAnonDecl()) &&
Ted Kremenekef9ff882011-03-10 20:03:42 +00003971 SourceEnum != TargetEnum) {
Matt Beaumont-Gayd87a0cd2012-01-06 22:43:58 +00003972 if (S.SourceMgr.isInSystemMacro(CC))
Ted Kremenekef9ff882011-03-10 20:03:42 +00003973 return;
3974
Douglas Gregor5a5b38f2011-03-12 00:14:31 +00003975 return DiagnoseImpCast(S, E, SourceType, T, CC,
Douglas Gregor284cc8d2011-02-22 02:45:07 +00003976 diag::warn_impcast_different_enum_types);
Ted Kremenekef9ff882011-03-10 20:03:42 +00003977 }
Douglas Gregor284cc8d2011-02-22 02:45:07 +00003978
John McCall51313c32010-01-04 23:31:57 +00003979 return;
3980}
3981
John McCall323ed742010-05-06 08:58:33 +00003982void CheckConditionalOperator(Sema &S, ConditionalOperator *E, QualType T);
3983
3984void CheckConditionalOperand(Sema &S, Expr *E, QualType T,
John McCallb4eb64d2010-10-08 02:01:28 +00003985 SourceLocation CC, bool &ICContext) {
John McCall323ed742010-05-06 08:58:33 +00003986 E = E->IgnoreParenImpCasts();
3987
3988 if (isa<ConditionalOperator>(E))
3989 return CheckConditionalOperator(S, cast<ConditionalOperator>(E), T);
3990
John McCallb4eb64d2010-10-08 02:01:28 +00003991 AnalyzeImplicitConversions(S, E, CC);
John McCall323ed742010-05-06 08:58:33 +00003992 if (E->getType() != T)
John McCallb4eb64d2010-10-08 02:01:28 +00003993 return CheckImplicitConversion(S, E, T, CC, &ICContext);
John McCall323ed742010-05-06 08:58:33 +00003994 return;
3995}
3996
3997void CheckConditionalOperator(Sema &S, ConditionalOperator *E, QualType T) {
John McCallb4eb64d2010-10-08 02:01:28 +00003998 SourceLocation CC = E->getQuestionLoc();
3999
4000 AnalyzeImplicitConversions(S, E->getCond(), CC);
John McCall323ed742010-05-06 08:58:33 +00004001
4002 bool Suspicious = false;
John McCallb4eb64d2010-10-08 02:01:28 +00004003 CheckConditionalOperand(S, E->getTrueExpr(), T, CC, Suspicious);
4004 CheckConditionalOperand(S, E->getFalseExpr(), T, CC, Suspicious);
John McCall323ed742010-05-06 08:58:33 +00004005
4006 // If -Wconversion would have warned about either of the candidates
4007 // for a signedness conversion to the context type...
4008 if (!Suspicious) return;
4009
4010 // ...but it's currently ignored...
Argyrios Kyrtzidis08274082010-12-15 18:44:22 +00004011 if (S.Diags.getDiagnosticLevel(diag::warn_impcast_integer_sign_conditional,
4012 CC))
John McCall323ed742010-05-06 08:58:33 +00004013 return;
4014
John McCall323ed742010-05-06 08:58:33 +00004015 // ...then check whether it would have warned about either of the
4016 // candidates for a signedness conversion to the condition type.
Richard Trieu52541612011-07-21 02:46:28 +00004017 if (E->getType() == T) return;
4018
4019 Suspicious = false;
4020 CheckImplicitConversion(S, E->getTrueExpr()->IgnoreParenImpCasts(),
4021 E->getType(), CC, &Suspicious);
4022 if (!Suspicious)
4023 CheckImplicitConversion(S, E->getFalseExpr()->IgnoreParenImpCasts(),
John McCallb4eb64d2010-10-08 02:01:28 +00004024 E->getType(), CC, &Suspicious);
John McCall323ed742010-05-06 08:58:33 +00004025}
4026
4027/// AnalyzeImplicitConversions - Find and report any interesting
4028/// implicit conversions in the given expression. There are a couple
4029/// of competing diagnostics here, -Wconversion and -Wsign-compare.
John McCallb4eb64d2010-10-08 02:01:28 +00004030void AnalyzeImplicitConversions(Sema &S, Expr *OrigE, SourceLocation CC) {
John McCall323ed742010-05-06 08:58:33 +00004031 QualType T = OrigE->getType();
4032 Expr *E = OrigE->IgnoreParenImpCasts();
4033
Douglas Gregorf8b6e152011-10-10 17:38:18 +00004034 if (E->isTypeDependent() || E->isValueDependent())
4035 return;
4036
John McCall323ed742010-05-06 08:58:33 +00004037 // For conditional operators, we analyze the arguments as if they
4038 // were being fed directly into the output.
4039 if (isa<ConditionalOperator>(E)) {
4040 ConditionalOperator *CO = cast<ConditionalOperator>(E);
4041 CheckConditionalOperator(S, CO, T);
4042 return;
4043 }
4044
4045 // Go ahead and check any implicit conversions we might have skipped.
4046 // The non-canonical typecheck is just an optimization;
4047 // CheckImplicitConversion will filter out dead implicit conversions.
4048 if (E->getType() != T)
John McCallb4eb64d2010-10-08 02:01:28 +00004049 CheckImplicitConversion(S, E, T, CC);
John McCall323ed742010-05-06 08:58:33 +00004050
4051 // Now continue drilling into this expression.
4052
4053 // Skip past explicit casts.
4054 if (isa<ExplicitCastExpr>(E)) {
4055 E = cast<ExplicitCastExpr>(E)->getSubExpr()->IgnoreParenImpCasts();
John McCallb4eb64d2010-10-08 02:01:28 +00004056 return AnalyzeImplicitConversions(S, E, CC);
John McCall323ed742010-05-06 08:58:33 +00004057 }
4058
John McCallbeb22aa2010-11-09 23:24:47 +00004059 if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) {
4060 // Do a somewhat different check with comparison operators.
4061 if (BO->isComparisonOp())
4062 return AnalyzeComparison(S, BO);
4063
Eli Friedman0fa06382012-01-26 23:34:06 +00004064 // And with simple assignments.
4065 if (BO->getOpcode() == BO_Assign)
John McCallbeb22aa2010-11-09 23:24:47 +00004066 return AnalyzeAssignment(S, BO);
4067 }
John McCall323ed742010-05-06 08:58:33 +00004068
4069 // These break the otherwise-useful invariant below. Fortunately,
4070 // we don't really need to recurse into them, because any internal
4071 // expressions should have been analyzed already when they were
4072 // built into statements.
4073 if (isa<StmtExpr>(E)) return;
4074
4075 // Don't descend into unevaluated contexts.
Peter Collingbournef4e3cfb2011-03-11 19:24:49 +00004076 if (isa<UnaryExprOrTypeTraitExpr>(E)) return;
John McCall323ed742010-05-06 08:58:33 +00004077
4078 // Now just recurse over the expression's children.
John McCallb4eb64d2010-10-08 02:01:28 +00004079 CC = E->getExprLoc();
Richard Trieuf1f8b1a2011-09-23 20:10:00 +00004080 BinaryOperator *BO = dyn_cast<BinaryOperator>(E);
4081 bool IsLogicalOperator = BO && BO->isLogicalOp();
4082 for (Stmt::child_range I = E->children(); I; ++I) {
4083 Expr *ChildExpr = cast<Expr>(*I);
4084 if (IsLogicalOperator &&
4085 isa<StringLiteral>(ChildExpr->IgnoreParenImpCasts()))
4086 // Ignore checking string literals that are in logical operators.
4087 continue;
4088 AnalyzeImplicitConversions(S, ChildExpr, CC);
4089 }
John McCall323ed742010-05-06 08:58:33 +00004090}
4091
4092} // end anonymous namespace
4093
4094/// Diagnoses "dangerous" implicit conversions within the given
4095/// expression (which is a full expression). Implements -Wconversion
4096/// and -Wsign-compare.
John McCallb4eb64d2010-10-08 02:01:28 +00004097///
4098/// \param CC the "context" location of the implicit conversion, i.e.
4099/// the most location of the syntactic entity requiring the implicit
4100/// conversion
4101void Sema::CheckImplicitConversions(Expr *E, SourceLocation CC) {
John McCall323ed742010-05-06 08:58:33 +00004102 // Don't diagnose in unevaluated contexts.
4103 if (ExprEvalContexts.back().Context == Sema::Unevaluated)
4104 return;
4105
4106 // Don't diagnose for value- or type-dependent expressions.
4107 if (E->isTypeDependent() || E->isValueDependent())
4108 return;
4109
Kaelyn Uhraind6c88652011-08-05 23:18:04 +00004110 // Check for array bounds violations in cases where the check isn't triggered
4111 // elsewhere for other Expr types (like BinaryOperators), e.g. when an
4112 // ArraySubscriptExpr is on the RHS of a variable initialization.
4113 CheckArrayAccess(E);
4114
John McCallb4eb64d2010-10-08 02:01:28 +00004115 // This is not the right CC for (e.g.) a variable initialization.
4116 AnalyzeImplicitConversions(*this, E, CC);
John McCall323ed742010-05-06 08:58:33 +00004117}
4118
John McCall15d7d122010-11-11 03:21:53 +00004119void Sema::CheckBitFieldInitialization(SourceLocation InitLoc,
4120 FieldDecl *BitField,
4121 Expr *Init) {
4122 (void) AnalyzeBitFieldAssignment(*this, BitField, Init, InitLoc);
4123}
4124
Mike Stumpf8c49212010-01-21 03:59:47 +00004125/// CheckParmsForFunctionDef - Check that the parameters of the given
4126/// function are appropriate for the definition of a function. This
4127/// takes care of any checks that cannot be performed on the
4128/// declaration itself, e.g., that the types of each of the function
4129/// parameters are complete.
Douglas Gregor82aa7132010-11-01 18:37:59 +00004130bool Sema::CheckParmsForFunctionDef(ParmVarDecl **P, ParmVarDecl **PEnd,
4131 bool CheckParameterNames) {
Mike Stumpf8c49212010-01-21 03:59:47 +00004132 bool HasInvalidParm = false;
Douglas Gregor82aa7132010-11-01 18:37:59 +00004133 for (; P != PEnd; ++P) {
4134 ParmVarDecl *Param = *P;
4135
Mike Stumpf8c49212010-01-21 03:59:47 +00004136 // C99 6.7.5.3p4: the parameters in a parameter type list in a
4137 // function declarator that is part of a function definition of
4138 // that function shall not have incomplete type.
4139 //
4140 // This is also C++ [dcl.fct]p6.
4141 if (!Param->isInvalidDecl() &&
4142 RequireCompleteType(Param->getLocation(), Param->getType(),
4143 diag::err_typecheck_decl_incomplete_type)) {
4144 Param->setInvalidDecl();
4145 HasInvalidParm = true;
4146 }
4147
4148 // C99 6.9.1p5: If the declarator includes a parameter type list, the
4149 // declaration of each parameter shall include an identifier.
Douglas Gregor82aa7132010-11-01 18:37:59 +00004150 if (CheckParameterNames &&
4151 Param->getIdentifier() == 0 &&
Mike Stumpf8c49212010-01-21 03:59:47 +00004152 !Param->isImplicit() &&
4153 !getLangOptions().CPlusPlus)
4154 Diag(Param->getLocation(), diag::err_parameter_name_omitted);
Sam Weinigd17e3402010-02-01 05:02:49 +00004155
4156 // C99 6.7.5.3p12:
4157 // If the function declarator is not part of a definition of that
4158 // function, parameters may have incomplete type and may use the [*]
4159 // notation in their sequences of declarator specifiers to specify
4160 // variable length array types.
4161 QualType PType = Param->getOriginalType();
4162 if (const ArrayType *AT = Context.getAsArrayType(PType)) {
4163 if (AT->getSizeModifier() == ArrayType::Star) {
4164 // FIXME: This diagnosic should point the the '[*]' if source-location
4165 // information is added for it.
4166 Diag(Param->getLocation(), diag::err_array_star_in_function_definition);
4167 }
4168 }
Mike Stumpf8c49212010-01-21 03:59:47 +00004169 }
4170
4171 return HasInvalidParm;
4172}
John McCallb7f4ffe2010-08-12 21:44:57 +00004173
4174/// CheckCastAlign - Implements -Wcast-align, which warns when a
4175/// pointer cast increases the alignment requirements.
4176void Sema::CheckCastAlign(Expr *Op, QualType T, SourceRange TRange) {
4177 // This is actually a lot of work to potentially be doing on every
4178 // cast; don't do it if we're ignoring -Wcast_align (as is the default).
Argyrios Kyrtzidis08274082010-12-15 18:44:22 +00004179 if (getDiagnostics().getDiagnosticLevel(diag::warn_cast_align,
4180 TRange.getBegin())
David Blaikied6471f72011-09-25 23:23:43 +00004181 == DiagnosticsEngine::Ignored)
John McCallb7f4ffe2010-08-12 21:44:57 +00004182 return;
4183
4184 // Ignore dependent types.
4185 if (T->isDependentType() || Op->getType()->isDependentType())
4186 return;
4187
4188 // Require that the destination be a pointer type.
4189 const PointerType *DestPtr = T->getAs<PointerType>();
4190 if (!DestPtr) return;
4191
4192 // If the destination has alignment 1, we're done.
4193 QualType DestPointee = DestPtr->getPointeeType();
4194 if (DestPointee->isIncompleteType()) return;
4195 CharUnits DestAlign = Context.getTypeAlignInChars(DestPointee);
4196 if (DestAlign.isOne()) return;
4197
4198 // Require that the source be a pointer type.
4199 const PointerType *SrcPtr = Op->getType()->getAs<PointerType>();
4200 if (!SrcPtr) return;
4201 QualType SrcPointee = SrcPtr->getPointeeType();
4202
4203 // Whitelist casts from cv void*. We already implicitly
4204 // whitelisted casts to cv void*, since they have alignment 1.
4205 // Also whitelist casts involving incomplete types, which implicitly
4206 // includes 'void'.
4207 if (SrcPointee->isIncompleteType()) return;
4208
4209 CharUnits SrcAlign = Context.getTypeAlignInChars(SrcPointee);
4210 if (SrcAlign >= DestAlign) return;
4211
4212 Diag(TRange.getBegin(), diag::warn_cast_align)
4213 << Op->getType() << T
4214 << static_cast<unsigned>(SrcAlign.getQuantity())
4215 << static_cast<unsigned>(DestAlign.getQuantity())
4216 << TRange << Op->getSourceRange();
4217}
4218
Kaelyn Uhraind6c88652011-08-05 23:18:04 +00004219static const Type* getElementType(const Expr *BaseExpr) {
4220 const Type* EltType = BaseExpr->getType().getTypePtr();
4221 if (EltType->isAnyPointerType())
4222 return EltType->getPointeeType().getTypePtr();
4223 else if (EltType->isArrayType())
4224 return EltType->getBaseElementTypeUnsafe();
4225 return EltType;
4226}
4227
Chandler Carruthc2684342011-08-05 09:10:50 +00004228/// \brief Check whether this array fits the idiom of a size-one tail padded
4229/// array member of a struct.
4230///
4231/// We avoid emitting out-of-bounds access warnings for such arrays as they are
4232/// commonly used to emulate flexible arrays in C89 code.
4233static bool IsTailPaddedMemberArray(Sema &S, llvm::APInt Size,
4234 const NamedDecl *ND) {
4235 if (Size != 1 || !ND) return false;
4236
4237 const FieldDecl *FD = dyn_cast<FieldDecl>(ND);
4238 if (!FD) return false;
4239
4240 // Don't consider sizes resulting from macro expansions or template argument
4241 // substitution to form C89 tail-padded arrays.
4242 ConstantArrayTypeLoc TL =
4243 cast<ConstantArrayTypeLoc>(FD->getTypeSourceInfo()->getTypeLoc());
4244 const Expr *SizeExpr = dyn_cast<IntegerLiteral>(TL.getSizeExpr());
4245 if (!SizeExpr || SizeExpr->getExprLoc().isMacroID())
4246 return false;
4247
4248 const RecordDecl *RD = dyn_cast<RecordDecl>(FD->getDeclContext());
Matt Beaumont-Gay381711c2011-11-29 22:43:53 +00004249 if (!RD) return false;
4250 if (RD->isUnion()) return false;
4251 if (const CXXRecordDecl *CRD = dyn_cast<CXXRecordDecl>(RD)) {
4252 if (!CRD->isStandardLayout()) return false;
4253 }
Chandler Carruthc2684342011-08-05 09:10:50 +00004254
Benjamin Kramer22d4fed2011-08-06 03:04:42 +00004255 // See if this is the last field decl in the record.
4256 const Decl *D = FD;
4257 while ((D = D->getNextDeclInContext()))
4258 if (isa<FieldDecl>(D))
4259 return false;
4260 return true;
Chandler Carruthc2684342011-08-05 09:10:50 +00004261}
4262
Kaelyn Uhraind6c88652011-08-05 23:18:04 +00004263void Sema::CheckArrayAccess(const Expr *BaseExpr, const Expr *IndexExpr,
Matt Beaumont-Gay80fb7dd2011-12-14 16:02:15 +00004264 const ArraySubscriptExpr *ASE,
Richard Smith25b009a2011-12-16 19:31:14 +00004265 bool AllowOnePastEnd, bool IndexNegated) {
Matt Beaumont-Gay80fb7dd2011-12-14 16:02:15 +00004266 IndexExpr = IndexExpr->IgnoreParenCasts();
4267 if (IndexExpr->isValueDependent())
4268 return;
4269
Matt Beaumont-Gay8ef8f432011-12-12 22:35:02 +00004270 const Type *EffectiveType = getElementType(BaseExpr);
Kaelyn Uhraind6c88652011-08-05 23:18:04 +00004271 BaseExpr = BaseExpr->IgnoreParenCasts();
Chandler Carruth34064582011-02-17 20:55:08 +00004272 const ConstantArrayType *ArrayTy =
Kaelyn Uhraind6c88652011-08-05 23:18:04 +00004273 Context.getAsConstantArrayType(BaseExpr->getType());
Chandler Carruth34064582011-02-17 20:55:08 +00004274 if (!ArrayTy)
Ted Kremeneka0125d82011-02-16 01:57:07 +00004275 return;
Chandler Carruth35001ca2011-02-17 21:10:52 +00004276
Chandler Carruth34064582011-02-17 20:55:08 +00004277 llvm::APSInt index;
Matt Beaumont-Gay80fb7dd2011-12-14 16:02:15 +00004278 if (!IndexExpr->EvaluateAsInt(index, Context))
Ted Kremeneka0125d82011-02-16 01:57:07 +00004279 return;
Richard Smith25b009a2011-12-16 19:31:14 +00004280 if (IndexNegated)
4281 index = -index;
Ted Kremenek8fd0a5d2011-02-16 04:01:44 +00004282
Chandler Carruthba447122011-08-05 08:07:29 +00004283 const NamedDecl *ND = NULL;
Chandler Carruthba447122011-08-05 08:07:29 +00004284 if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(BaseExpr))
4285 ND = dyn_cast<NamedDecl>(DRE->getDecl());
Chandler Carruthc2684342011-08-05 09:10:50 +00004286 if (const MemberExpr *ME = dyn_cast<MemberExpr>(BaseExpr))
Chandler Carruthba447122011-08-05 08:07:29 +00004287 ND = dyn_cast<NamedDecl>(ME->getMemberDecl());
Chandler Carruthba447122011-08-05 08:07:29 +00004288
Ted Kremenek9e060ca2011-02-23 23:06:04 +00004289 if (index.isUnsigned() || !index.isNegative()) {
Ted Kremenek25b3b842011-02-18 02:27:00 +00004290 llvm::APInt size = ArrayTy->getSize();
Chandler Carruth35001ca2011-02-17 21:10:52 +00004291 if (!size.isStrictlyPositive())
4292 return;
Kaelyn Uhraind6c88652011-08-05 23:18:04 +00004293
4294 const Type* BaseType = getElementType(BaseExpr);
Nico Weberde5998f2011-09-17 22:59:41 +00004295 if (BaseType != EffectiveType) {
Kaelyn Uhraind6c88652011-08-05 23:18:04 +00004296 // Make sure we're comparing apples to apples when comparing index to size
4297 uint64_t ptrarith_typesize = Context.getTypeSize(EffectiveType);
4298 uint64_t array_typesize = Context.getTypeSize(BaseType);
Kaelyn Uhraind10f4bc2011-08-10 19:47:25 +00004299 // Handle ptrarith_typesize being zero, such as when casting to void*
Kaelyn Uhrain18f16972011-08-10 18:49:28 +00004300 if (!ptrarith_typesize) ptrarith_typesize = 1;
Kaelyn Uhraind6c88652011-08-05 23:18:04 +00004301 if (ptrarith_typesize != array_typesize) {
4302 // There's a cast to a different size type involved
4303 uint64_t ratio = array_typesize / ptrarith_typesize;
4304 // TODO: Be smarter about handling cases where array_typesize is not a
4305 // multiple of ptrarith_typesize
4306 if (ptrarith_typesize * ratio == array_typesize)
4307 size *= llvm::APInt(size.getBitWidth(), ratio);
4308 }
4309 }
4310
Chandler Carruth34064582011-02-17 20:55:08 +00004311 if (size.getBitWidth() > index.getBitWidth())
4312 index = index.sext(size.getBitWidth());
Ted Kremenek25b3b842011-02-18 02:27:00 +00004313 else if (size.getBitWidth() < index.getBitWidth())
4314 size = size.sext(index.getBitWidth());
4315
Kaelyn Uhraind6c88652011-08-05 23:18:04 +00004316 // For array subscripting the index must be less than size, but for pointer
4317 // arithmetic also allow the index (offset) to be equal to size since
4318 // computing the next address after the end of the array is legal and
4319 // commonly done e.g. in C++ iterators and range-based for loops.
4320 if (AllowOnePastEnd ? index.sle(size) : index.slt(size))
Chandler Carruthba447122011-08-05 08:07:29 +00004321 return;
4322
4323 // Also don't warn for arrays of size 1 which are members of some
4324 // structure. These are often used to approximate flexible arrays in C89
4325 // code.
Kaelyn Uhraind6c88652011-08-05 23:18:04 +00004326 if (IsTailPaddedMemberArray(*this, size, ND))
Ted Kremenek8fd0a5d2011-02-16 04:01:44 +00004327 return;
Chandler Carruth34064582011-02-17 20:55:08 +00004328
Matt Beaumont-Gay80fb7dd2011-12-14 16:02:15 +00004329 // Suppress the warning if the subscript expression (as identified by the
4330 // ']' location) and the index expression are both from macro expansions
4331 // within a system header.
4332 if (ASE) {
4333 SourceLocation RBracketLoc = SourceMgr.getSpellingLoc(
4334 ASE->getRBracketLoc());
4335 if (SourceMgr.isInSystemHeader(RBracketLoc)) {
4336 SourceLocation IndexLoc = SourceMgr.getSpellingLoc(
4337 IndexExpr->getLocStart());
4338 if (SourceMgr.isFromSameFile(RBracketLoc, IndexLoc))
4339 return;
4340 }
4341 }
4342
Kaelyn Uhraind6c88652011-08-05 23:18:04 +00004343 unsigned DiagID = diag::warn_ptr_arith_exceeds_bounds;
Matt Beaumont-Gay80fb7dd2011-12-14 16:02:15 +00004344 if (ASE)
Kaelyn Uhraind6c88652011-08-05 23:18:04 +00004345 DiagID = diag::warn_array_index_exceeds_bounds;
4346
4347 DiagRuntimeBehavior(BaseExpr->getLocStart(), BaseExpr,
4348 PDiag(DiagID) << index.toString(10, true)
4349 << size.toString(10, true)
4350 << (unsigned)size.getLimitedValue(~0U)
4351 << IndexExpr->getSourceRange());
Chandler Carruth34064582011-02-17 20:55:08 +00004352 } else {
Kaelyn Uhraind6c88652011-08-05 23:18:04 +00004353 unsigned DiagID = diag::warn_array_index_precedes_bounds;
Matt Beaumont-Gay80fb7dd2011-12-14 16:02:15 +00004354 if (!ASE) {
Kaelyn Uhraind6c88652011-08-05 23:18:04 +00004355 DiagID = diag::warn_ptr_arith_precedes_bounds;
4356 if (index.isNegative()) index = -index;
4357 }
4358
4359 DiagRuntimeBehavior(BaseExpr->getLocStart(), BaseExpr,
4360 PDiag(DiagID) << index.toString(10, true)
4361 << IndexExpr->getSourceRange());
Ted Kremeneka0125d82011-02-16 01:57:07 +00004362 }
Chandler Carruth35001ca2011-02-17 21:10:52 +00004363
Matt Beaumont-Gaycfbc5b52011-11-29 19:27:11 +00004364 if (!ND) {
4365 // Try harder to find a NamedDecl to point at in the note.
4366 while (const ArraySubscriptExpr *ASE =
4367 dyn_cast<ArraySubscriptExpr>(BaseExpr))
4368 BaseExpr = ASE->getBase()->IgnoreParenCasts();
4369 if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(BaseExpr))
4370 ND = dyn_cast<NamedDecl>(DRE->getDecl());
4371 if (const MemberExpr *ME = dyn_cast<MemberExpr>(BaseExpr))
4372 ND = dyn_cast<NamedDecl>(ME->getMemberDecl());
4373 }
4374
Chandler Carruth35001ca2011-02-17 21:10:52 +00004375 if (ND)
Kaelyn Uhraind6c88652011-08-05 23:18:04 +00004376 DiagRuntimeBehavior(ND->getLocStart(), BaseExpr,
4377 PDiag(diag::note_array_index_out_of_bounds)
4378 << ND->getDeclName());
Ted Kremeneka0125d82011-02-16 01:57:07 +00004379}
4380
Ted Kremenek3aea4da2011-03-01 18:41:00 +00004381void Sema::CheckArrayAccess(const Expr *expr) {
Kaelyn Uhraind6c88652011-08-05 23:18:04 +00004382 int AllowOnePastEnd = 0;
4383 while (expr) {
4384 expr = expr->IgnoreParenImpCasts();
Ted Kremenek3aea4da2011-03-01 18:41:00 +00004385 switch (expr->getStmtClass()) {
Kaelyn Uhraind6c88652011-08-05 23:18:04 +00004386 case Stmt::ArraySubscriptExprClass: {
4387 const ArraySubscriptExpr *ASE = cast<ArraySubscriptExpr>(expr);
Matt Beaumont-Gay80fb7dd2011-12-14 16:02:15 +00004388 CheckArrayAccess(ASE->getBase(), ASE->getIdx(), ASE,
Kaelyn Uhraind6c88652011-08-05 23:18:04 +00004389 AllowOnePastEnd > 0);
Ted Kremenek3aea4da2011-03-01 18:41:00 +00004390 return;
Kaelyn Uhraind6c88652011-08-05 23:18:04 +00004391 }
4392 case Stmt::UnaryOperatorClass: {
4393 // Only unwrap the * and & unary operators
4394 const UnaryOperator *UO = cast<UnaryOperator>(expr);
4395 expr = UO->getSubExpr();
4396 switch (UO->getOpcode()) {
4397 case UO_AddrOf:
4398 AllowOnePastEnd++;
4399 break;
4400 case UO_Deref:
4401 AllowOnePastEnd--;
4402 break;
4403 default:
4404 return;
4405 }
4406 break;
4407 }
Ted Kremenek3aea4da2011-03-01 18:41:00 +00004408 case Stmt::ConditionalOperatorClass: {
4409 const ConditionalOperator *cond = cast<ConditionalOperator>(expr);
4410 if (const Expr *lhs = cond->getLHS())
4411 CheckArrayAccess(lhs);
4412 if (const Expr *rhs = cond->getRHS())
4413 CheckArrayAccess(rhs);
4414 return;
4415 }
4416 default:
4417 return;
4418 }
Peter Collingbournef111d932011-04-15 00:35:48 +00004419 }
Ted Kremenek3aea4da2011-03-01 18:41:00 +00004420}
John McCallf85e1932011-06-15 23:02:42 +00004421
4422//===--- CHECK: Objective-C retain cycles ----------------------------------//
4423
4424namespace {
4425 struct RetainCycleOwner {
4426 RetainCycleOwner() : Variable(0), Indirect(false) {}
4427 VarDecl *Variable;
4428 SourceRange Range;
4429 SourceLocation Loc;
4430 bool Indirect;
4431
4432 void setLocsFrom(Expr *e) {
4433 Loc = e->getExprLoc();
4434 Range = e->getSourceRange();
4435 }
4436 };
4437}
4438
4439/// Consider whether capturing the given variable can possibly lead to
4440/// a retain cycle.
4441static bool considerVariable(VarDecl *var, Expr *ref, RetainCycleOwner &owner) {
4442 // In ARC, it's captured strongly iff the variable has __strong
4443 // lifetime. In MRR, it's captured strongly if the variable is
4444 // __block and has an appropriate type.
4445 if (var->getType().getObjCLifetime() != Qualifiers::OCL_Strong)
4446 return false;
4447
4448 owner.Variable = var;
4449 owner.setLocsFrom(ref);
4450 return true;
4451}
4452
Fariborz Jahanian6e6f93a2012-01-10 19:28:26 +00004453static bool findRetainCycleOwner(Sema &S, Expr *e, RetainCycleOwner &owner) {
John McCallf85e1932011-06-15 23:02:42 +00004454 while (true) {
4455 e = e->IgnoreParens();
4456 if (CastExpr *cast = dyn_cast<CastExpr>(e)) {
4457 switch (cast->getCastKind()) {
4458 case CK_BitCast:
4459 case CK_LValueBitCast:
4460 case CK_LValueToRValue:
John McCall33e56f32011-09-10 06:18:15 +00004461 case CK_ARCReclaimReturnedObject:
John McCallf85e1932011-06-15 23:02:42 +00004462 e = cast->getSubExpr();
4463 continue;
4464
John McCallf85e1932011-06-15 23:02:42 +00004465 default:
4466 return false;
4467 }
4468 }
4469
4470 if (ObjCIvarRefExpr *ref = dyn_cast<ObjCIvarRefExpr>(e)) {
4471 ObjCIvarDecl *ivar = ref->getDecl();
4472 if (ivar->getType().getObjCLifetime() != Qualifiers::OCL_Strong)
4473 return false;
4474
4475 // Try to find a retain cycle in the base.
Fariborz Jahanian6e6f93a2012-01-10 19:28:26 +00004476 if (!findRetainCycleOwner(S, ref->getBase(), owner))
John McCallf85e1932011-06-15 23:02:42 +00004477 return false;
4478
4479 if (ref->isFreeIvar()) owner.setLocsFrom(ref);
4480 owner.Indirect = true;
4481 return true;
4482 }
4483
4484 if (DeclRefExpr *ref = dyn_cast<DeclRefExpr>(e)) {
4485 VarDecl *var = dyn_cast<VarDecl>(ref->getDecl());
4486 if (!var) return false;
4487 return considerVariable(var, ref, owner);
4488 }
4489
4490 if (BlockDeclRefExpr *ref = dyn_cast<BlockDeclRefExpr>(e)) {
4491 owner.Variable = ref->getDecl();
4492 owner.setLocsFrom(ref);
4493 return true;
4494 }
4495
4496 if (MemberExpr *member = dyn_cast<MemberExpr>(e)) {
4497 if (member->isArrow()) return false;
4498
4499 // Don't count this as an indirect ownership.
4500 e = member->getBase();
4501 continue;
4502 }
4503
John McCall4b9c2d22011-11-06 09:01:30 +00004504 if (PseudoObjectExpr *pseudo = dyn_cast<PseudoObjectExpr>(e)) {
4505 // Only pay attention to pseudo-objects on property references.
4506 ObjCPropertyRefExpr *pre
4507 = dyn_cast<ObjCPropertyRefExpr>(pseudo->getSyntacticForm()
4508 ->IgnoreParens());
4509 if (!pre) return false;
4510 if (pre->isImplicitProperty()) return false;
4511 ObjCPropertyDecl *property = pre->getExplicitProperty();
4512 if (!property->isRetaining() &&
4513 !(property->getPropertyIvarDecl() &&
4514 property->getPropertyIvarDecl()->getType()
4515 .getObjCLifetime() == Qualifiers::OCL_Strong))
4516 return false;
4517
4518 owner.Indirect = true;
Fariborz Jahanian6e6f93a2012-01-10 19:28:26 +00004519 if (pre->isSuperReceiver()) {
4520 owner.Variable = S.getCurMethodDecl()->getSelfDecl();
4521 if (!owner.Variable)
4522 return false;
4523 owner.Loc = pre->getLocation();
4524 owner.Range = pre->getSourceRange();
4525 return true;
4526 }
John McCall4b9c2d22011-11-06 09:01:30 +00004527 e = const_cast<Expr*>(cast<OpaqueValueExpr>(pre->getBase())
4528 ->getSourceExpr());
4529 continue;
4530 }
4531
John McCallf85e1932011-06-15 23:02:42 +00004532 // Array ivars?
4533
4534 return false;
4535 }
4536}
4537
4538namespace {
4539 struct FindCaptureVisitor : EvaluatedExprVisitor<FindCaptureVisitor> {
4540 FindCaptureVisitor(ASTContext &Context, VarDecl *variable)
4541 : EvaluatedExprVisitor<FindCaptureVisitor>(Context),
4542 Variable(variable), Capturer(0) {}
4543
4544 VarDecl *Variable;
4545 Expr *Capturer;
4546
4547 void VisitDeclRefExpr(DeclRefExpr *ref) {
4548 if (ref->getDecl() == Variable && !Capturer)
4549 Capturer = ref;
4550 }
4551
4552 void VisitBlockDeclRefExpr(BlockDeclRefExpr *ref) {
4553 if (ref->getDecl() == Variable && !Capturer)
4554 Capturer = ref;
4555 }
4556
4557 void VisitObjCIvarRefExpr(ObjCIvarRefExpr *ref) {
4558 if (Capturer) return;
4559 Visit(ref->getBase());
4560 if (Capturer && ref->isFreeIvar())
4561 Capturer = ref;
4562 }
4563
4564 void VisitBlockExpr(BlockExpr *block) {
4565 // Look inside nested blocks
4566 if (block->getBlockDecl()->capturesVariable(Variable))
4567 Visit(block->getBlockDecl()->getBody());
4568 }
4569 };
4570}
4571
4572/// Check whether the given argument is a block which captures a
4573/// variable.
4574static Expr *findCapturingExpr(Sema &S, Expr *e, RetainCycleOwner &owner) {
4575 assert(owner.Variable && owner.Loc.isValid());
4576
4577 e = e->IgnoreParenCasts();
4578 BlockExpr *block = dyn_cast<BlockExpr>(e);
4579 if (!block || !block->getBlockDecl()->capturesVariable(owner.Variable))
4580 return 0;
4581
4582 FindCaptureVisitor visitor(S.Context, owner.Variable);
4583 visitor.Visit(block->getBlockDecl()->getBody());
4584 return visitor.Capturer;
4585}
4586
4587static void diagnoseRetainCycle(Sema &S, Expr *capturer,
4588 RetainCycleOwner &owner) {
4589 assert(capturer);
4590 assert(owner.Variable && owner.Loc.isValid());
4591
4592 S.Diag(capturer->getExprLoc(), diag::warn_arc_retain_cycle)
4593 << owner.Variable << capturer->getSourceRange();
4594 S.Diag(owner.Loc, diag::note_arc_retain_cycle_owner)
4595 << owner.Indirect << owner.Range;
4596}
4597
4598/// Check for a keyword selector that starts with the word 'add' or
4599/// 'set'.
4600static bool isSetterLikeSelector(Selector sel) {
4601 if (sel.isUnarySelector()) return false;
4602
Chris Lattner5f9e2722011-07-23 10:55:15 +00004603 StringRef str = sel.getNameForSlot(0);
John McCallf85e1932011-06-15 23:02:42 +00004604 while (!str.empty() && str.front() == '_') str = str.substr(1);
Ted Kremenek968a0ee2011-12-01 00:59:21 +00004605 if (str.startswith("set"))
John McCallf85e1932011-06-15 23:02:42 +00004606 str = str.substr(3);
Ted Kremenek968a0ee2011-12-01 00:59:21 +00004607 else if (str.startswith("add")) {
4608 // Specially whitelist 'addOperationWithBlock:'.
4609 if (sel.getNumArgs() == 1 && str.startswith("addOperationWithBlock"))
4610 return false;
4611 str = str.substr(3);
4612 }
John McCallf85e1932011-06-15 23:02:42 +00004613 else
4614 return false;
4615
4616 if (str.empty()) return true;
4617 return !islower(str.front());
4618}
4619
4620/// Check a message send to see if it's likely to cause a retain cycle.
4621void Sema::checkRetainCycles(ObjCMessageExpr *msg) {
4622 // Only check instance methods whose selector looks like a setter.
4623 if (!msg->isInstanceMessage() || !isSetterLikeSelector(msg->getSelector()))
4624 return;
4625
4626 // Try to find a variable that the receiver is strongly owned by.
4627 RetainCycleOwner owner;
4628 if (msg->getReceiverKind() == ObjCMessageExpr::Instance) {
Fariborz Jahanian6e6f93a2012-01-10 19:28:26 +00004629 if (!findRetainCycleOwner(*this, msg->getInstanceReceiver(), owner))
John McCallf85e1932011-06-15 23:02:42 +00004630 return;
4631 } else {
4632 assert(msg->getReceiverKind() == ObjCMessageExpr::SuperInstance);
4633 owner.Variable = getCurMethodDecl()->getSelfDecl();
4634 owner.Loc = msg->getSuperLoc();
4635 owner.Range = msg->getSuperLoc();
4636 }
4637
4638 // Check whether the receiver is captured by any of the arguments.
4639 for (unsigned i = 0, e = msg->getNumArgs(); i != e; ++i)
4640 if (Expr *capturer = findCapturingExpr(*this, msg->getArg(i), owner))
4641 return diagnoseRetainCycle(*this, capturer, owner);
4642}
4643
4644/// Check a property assign to see if it's likely to cause a retain cycle.
4645void Sema::checkRetainCycles(Expr *receiver, Expr *argument) {
4646 RetainCycleOwner owner;
Fariborz Jahanian6e6f93a2012-01-10 19:28:26 +00004647 if (!findRetainCycleOwner(*this, receiver, owner))
John McCallf85e1932011-06-15 23:02:42 +00004648 return;
4649
4650 if (Expr *capturer = findCapturingExpr(*this, argument, owner))
4651 diagnoseRetainCycle(*this, capturer, owner);
4652}
4653
Fariborz Jahanian921c1432011-06-24 18:25:34 +00004654bool Sema::checkUnsafeAssigns(SourceLocation Loc,
John McCallf85e1932011-06-15 23:02:42 +00004655 QualType LHS, Expr *RHS) {
4656 Qualifiers::ObjCLifetime LT = LHS.getObjCLifetime();
4657 if (LT != Qualifiers::OCL_Weak && LT != Qualifiers::OCL_ExplicitNone)
Fariborz Jahanian921c1432011-06-24 18:25:34 +00004658 return false;
4659 // strip off any implicit cast added to get to the one arc-specific
4660 while (ImplicitCastExpr *cast = dyn_cast<ImplicitCastExpr>(RHS)) {
John McCall33e56f32011-09-10 06:18:15 +00004661 if (cast->getCastKind() == CK_ARCConsumeObject) {
John McCallf85e1932011-06-15 23:02:42 +00004662 Diag(Loc, diag::warn_arc_retained_assign)
4663 << (LT == Qualifiers::OCL_ExplicitNone)
4664 << RHS->getSourceRange();
Fariborz Jahanian921c1432011-06-24 18:25:34 +00004665 return true;
4666 }
4667 RHS = cast->getSubExpr();
4668 }
4669 return false;
John McCallf85e1932011-06-15 23:02:42 +00004670}
4671
Fariborz Jahanian921c1432011-06-24 18:25:34 +00004672void Sema::checkUnsafeExprAssigns(SourceLocation Loc,
4673 Expr *LHS, Expr *RHS) {
Fariborz Jahanian87eaf722012-01-17 22:58:16 +00004674 QualType LHSType;
4675 // PropertyRef on LHS type need be directly obtained from
4676 // its declaration as it has a PsuedoType.
4677 ObjCPropertyRefExpr *PRE
4678 = dyn_cast<ObjCPropertyRefExpr>(LHS->IgnoreParens());
4679 if (PRE && !PRE->isImplicitProperty()) {
4680 const ObjCPropertyDecl *PD = PRE->getExplicitProperty();
4681 if (PD)
4682 LHSType = PD->getType();
4683 }
4684
4685 if (LHSType.isNull())
4686 LHSType = LHS->getType();
Fariborz Jahanian921c1432011-06-24 18:25:34 +00004687 if (checkUnsafeAssigns(Loc, LHSType, RHS))
4688 return;
4689 Qualifiers::ObjCLifetime LT = LHSType.getObjCLifetime();
4690 // FIXME. Check for other life times.
4691 if (LT != Qualifiers::OCL_None)
4692 return;
4693
Fariborz Jahanian87eaf722012-01-17 22:58:16 +00004694 if (PRE) {
Fariborz Jahanian921c1432011-06-24 18:25:34 +00004695 if (PRE->isImplicitProperty())
4696 return;
4697 const ObjCPropertyDecl *PD = PRE->getExplicitProperty();
4698 if (!PD)
4699 return;
4700
4701 unsigned Attributes = PD->getPropertyAttributes();
Fariborz Jahanian87eaf722012-01-17 22:58:16 +00004702 if (Attributes & ObjCPropertyDecl::OBJC_PR_assign) {
4703 // when 'assign' attribute was not explicitly specified
4704 // by user, ignore it and rely on property type itself
4705 // for lifetime info.
4706 unsigned AsWrittenAttr = PD->getPropertyAttributesAsWritten();
4707 if (!(AsWrittenAttr & ObjCPropertyDecl::OBJC_PR_assign) &&
4708 LHSType->isObjCRetainableType())
4709 return;
4710
Fariborz Jahanian921c1432011-06-24 18:25:34 +00004711 while (ImplicitCastExpr *cast = dyn_cast<ImplicitCastExpr>(RHS)) {
John McCall33e56f32011-09-10 06:18:15 +00004712 if (cast->getCastKind() == CK_ARCConsumeObject) {
Fariborz Jahanian921c1432011-06-24 18:25:34 +00004713 Diag(Loc, diag::warn_arc_retained_property_assign)
4714 << RHS->getSourceRange();
4715 return;
4716 }
4717 RHS = cast->getSubExpr();
4718 }
Fariborz Jahanian87eaf722012-01-17 22:58:16 +00004719 }
Fariborz Jahanian921c1432011-06-24 18:25:34 +00004720 }
4721}