blob: 026d73aa50a7d9879e85c1329ced496393e41674 [file] [log] [blame]
Chris Lattner59907c42007-08-10 20:18:51 +00001//===--- SemaChecking.cpp - Extra Semantic Checking -----------------------===//
2//
3// The LLVM Compiler Infrastructure
4//
Chris Lattner0bc735f2007-12-29 19:59:25 +00005// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
Chris Lattner59907c42007-08-10 20:18:51 +00007//
8//===----------------------------------------------------------------------===//
9//
Mike Stump1eb44332009-09-09 15:08:12 +000010// This file implements extra semantic analysis beyond what is enforced
Chris Lattner59907c42007-08-10 20:18:51 +000011// by the C type system.
12//
13//===----------------------------------------------------------------------===//
14
15#include "Sema.h"
Ted Kremenek826a3452010-07-16 02:11:22 +000016#include "clang/Analysis/Analyses/FormatString.h"
Chris Lattner59907c42007-08-10 20:18:51 +000017#include "clang/AST/ASTContext.h"
Ken Dyck199c3d62010-01-11 17:06:35 +000018#include "clang/AST/CharUnits.h"
Daniel Dunbarc4a1dea2008-08-11 05:35:13 +000019#include "clang/AST/DeclObjC.h"
Ted Kremenek23245122007-08-20 16:18:38 +000020#include "clang/AST/ExprCXX.h"
Ted Kremenek7ff22b22008-06-16 18:00:42 +000021#include "clang/AST/ExprObjC.h"
Mike Stumpf8c49212010-01-21 03:59:47 +000022#include "clang/AST/DeclObjC.h"
23#include "clang/AST/StmtCXX.h"
24#include "clang/AST/StmtObjC.h"
Chris Lattner719e6152009-02-18 19:21:10 +000025#include "clang/Lex/LiteralSupport.h"
Chris Lattner59907c42007-08-10 20:18:51 +000026#include "clang/Lex/Preprocessor.h"
Mike Stumpf8c49212010-01-21 03:59:47 +000027#include "llvm/ADT/BitVector.h"
28#include "llvm/ADT/STLExtras.h"
Tom Care3bfc5f42010-06-09 04:11:11 +000029#include "llvm/Support/raw_ostream.h"
Eric Christopher691ebc32010-04-17 02:26:23 +000030#include "clang/Basic/TargetBuiltins.h"
Nate Begeman26a31422010-06-08 02:47:44 +000031#include "clang/Basic/TargetInfo.h"
Zhongxing Xua1f3dba2009-05-20 01:55:10 +000032#include <limits>
Chris Lattner59907c42007-08-10 20:18:51 +000033using namespace clang;
34
Chris Lattner60800082009-02-18 17:49:48 +000035/// getLocationOfStringLiteralByte - Return a source location that points to the
36/// specified byte of the specified string literal.
37///
38/// Strings are amazingly complex. They can be formed from multiple tokens and
39/// can have escape sequences in them in addition to the usual trigraph and
40/// escaped newline business. This routine handles this complexity.
41///
42SourceLocation Sema::getLocationOfStringLiteralByte(const StringLiteral *SL,
43 unsigned ByteNo) const {
44 assert(!SL->isWide() && "This doesn't work for wide strings yet");
Mike Stump1eb44332009-09-09 15:08:12 +000045
Chris Lattner60800082009-02-18 17:49:48 +000046 // Loop over all of the tokens in this string until we find the one that
47 // contains the byte we're looking for.
48 unsigned TokNo = 0;
49 while (1) {
50 assert(TokNo < SL->getNumConcatenated() && "Invalid byte number!");
51 SourceLocation StrTokLoc = SL->getStrTokenLoc(TokNo);
Mike Stump1eb44332009-09-09 15:08:12 +000052
Chris Lattner60800082009-02-18 17:49:48 +000053 // Get the spelling of the string so that we can get the data that makes up
54 // the string literal, not the identifier for the macro it is potentially
55 // expanded through.
56 SourceLocation StrTokSpellingLoc = SourceMgr.getSpellingLoc(StrTokLoc);
57
58 // Re-lex the token to get its length and original spelling.
59 std::pair<FileID, unsigned> LocInfo =
60 SourceMgr.getDecomposedLoc(StrTokSpellingLoc);
Douglas Gregorf715ca12010-03-16 00:06:06 +000061 bool Invalid = false;
Benjamin Kramerf6ac97b2010-03-16 14:14:31 +000062 llvm::StringRef Buffer = SourceMgr.getBufferData(LocInfo.first, &Invalid);
Douglas Gregorf715ca12010-03-16 00:06:06 +000063 if (Invalid)
Douglas Gregoraea67db2010-03-15 22:54:52 +000064 return StrTokSpellingLoc;
65
Benjamin Kramerf6ac97b2010-03-16 14:14:31 +000066 const char *StrData = Buffer.data()+LocInfo.second;
Mike Stump1eb44332009-09-09 15:08:12 +000067
Chris Lattner60800082009-02-18 17:49:48 +000068 // Create a langops struct and enable trigraphs. This is sufficient for
69 // relexing tokens.
70 LangOptions LangOpts;
71 LangOpts.Trigraphs = true;
Mike Stump1eb44332009-09-09 15:08:12 +000072
Chris Lattner60800082009-02-18 17:49:48 +000073 // Create a lexer starting at the beginning of this token.
Benjamin Kramerf6ac97b2010-03-16 14:14:31 +000074 Lexer TheLexer(StrTokSpellingLoc, LangOpts, Buffer.begin(), StrData,
75 Buffer.end());
Chris Lattner60800082009-02-18 17:49:48 +000076 Token TheTok;
77 TheLexer.LexFromRawLexer(TheTok);
Mike Stump1eb44332009-09-09 15:08:12 +000078
Chris Lattner443e53c2009-02-18 19:26:42 +000079 // Use the StringLiteralParser to compute the length of the string in bytes.
Douglas Gregorb90f4b32010-05-26 05:35:51 +000080 StringLiteralParser SLP(&TheTok, 1, PP, /*Complain=*/false);
Chris Lattner443e53c2009-02-18 19:26:42 +000081 unsigned TokNumBytes = SLP.GetStringLength();
Mike Stump1eb44332009-09-09 15:08:12 +000082
Chris Lattner2197c962009-02-18 18:52:52 +000083 // If the byte is in this token, return the location of the byte.
Chris Lattner60800082009-02-18 17:49:48 +000084 if (ByteNo < TokNumBytes ||
85 (ByteNo == TokNumBytes && TokNo == SL->getNumConcatenated())) {
Mike Stump1eb44332009-09-09 15:08:12 +000086 unsigned Offset =
Douglas Gregorb90f4b32010-05-26 05:35:51 +000087 StringLiteralParser::getOffsetOfStringByte(TheTok, ByteNo, PP,
88 /*Complain=*/false);
Mike Stump1eb44332009-09-09 15:08:12 +000089
Chris Lattner719e6152009-02-18 19:21:10 +000090 // Now that we know the offset of the token in the spelling, use the
91 // preprocessor to get the offset in the original source.
92 return PP.AdvanceToTokenCharacter(StrTokLoc, Offset);
Chris Lattner60800082009-02-18 17:49:48 +000093 }
Mike Stump1eb44332009-09-09 15:08:12 +000094
Chris Lattner60800082009-02-18 17:49:48 +000095 // Move to the next string token.
96 ++TokNo;
97 ByteNo -= TokNumBytes;
98 }
99}
100
Ryan Flynn4403a5e2009-08-06 03:00:50 +0000101/// CheckablePrintfAttr - does a function call have a "printf" attribute
102/// and arguments that merit checking?
103bool Sema::CheckablePrintfAttr(const FormatAttr *Format, CallExpr *TheCall) {
104 if (Format->getType() == "printf") return true;
105 if (Format->getType() == "printf0") {
106 // printf0 allows null "format" string; if so don't check format/args
107 unsigned format_idx = Format->getFormatIdx() - 1;
Sebastian Redl4a2614e2009-11-17 18:02:24 +0000108 // Does the index refer to the implicit object argument?
109 if (isa<CXXMemberCallExpr>(TheCall)) {
110 if (format_idx == 0)
111 return false;
112 --format_idx;
113 }
Ryan Flynn4403a5e2009-08-06 03:00:50 +0000114 if (format_idx < TheCall->getNumArgs()) {
115 Expr *Format = TheCall->getArg(format_idx)->IgnoreParenCasts();
Ted Kremenekefaff192010-02-27 01:41:03 +0000116 if (!Format->isNullPointerConstant(Context,
117 Expr::NPC_ValueDependentIsNull))
Ryan Flynn4403a5e2009-08-06 03:00:50 +0000118 return true;
119 }
120 }
121 return false;
122}
Chris Lattner60800082009-02-18 17:49:48 +0000123
Sebastian Redl0eb23302009-01-19 00:08:26 +0000124Action::OwningExprResult
Anders Carlssond406bf02009-08-16 01:56:34 +0000125Sema::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
Sebastian Redl0eb23302009-01-19 00:08:26 +0000126 OwningExprResult TheCallResult(Owned(TheCall));
Douglas Gregor2def4832008-11-17 20:34:05 +0000127
Anders Carlssond406bf02009-08-16 01:56:34 +0000128 switch (BuiltinID) {
Chris Lattner30ce3442007-12-19 23:59:04 +0000129 case Builtin::BI__builtin___CFStringMakeConstantString:
Chris Lattner925e60d2007-12-28 05:29:59 +0000130 assert(TheCall->getNumArgs() == 1 &&
Chris Lattner1b9a0792007-12-20 00:26:33 +0000131 "Wrong # arguments to builtin CFStringMakeConstantString");
Chris Lattner69039812009-02-18 06:01:06 +0000132 if (CheckObjCString(TheCall->getArg(0)))
Sebastian Redl0eb23302009-01-19 00:08:26 +0000133 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000134 break;
Ted Kremenek49ff7a12008-07-09 17:58:53 +0000135 case Builtin::BI__builtin_stdarg_start:
Chris Lattner30ce3442007-12-19 23:59:04 +0000136 case Builtin::BI__builtin_va_start:
Sebastian Redl0eb23302009-01-19 00:08:26 +0000137 if (SemaBuiltinVAStart(TheCall))
138 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000139 break;
Chris Lattner1b9a0792007-12-20 00:26:33 +0000140 case Builtin::BI__builtin_isgreater:
141 case Builtin::BI__builtin_isgreaterequal:
142 case Builtin::BI__builtin_isless:
143 case Builtin::BI__builtin_islessequal:
144 case Builtin::BI__builtin_islessgreater:
145 case Builtin::BI__builtin_isunordered:
Sebastian Redl0eb23302009-01-19 00:08:26 +0000146 if (SemaBuiltinUnorderedCompare(TheCall))
147 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000148 break;
Benjamin Kramere771a7a2010-02-15 22:42:31 +0000149 case Builtin::BI__builtin_fpclassify:
150 if (SemaBuiltinFPClassification(TheCall, 6))
151 return ExprError();
152 break;
Eli Friedman9ac6f622009-08-31 20:06:00 +0000153 case Builtin::BI__builtin_isfinite:
154 case Builtin::BI__builtin_isinf:
155 case Builtin::BI__builtin_isinf_sign:
156 case Builtin::BI__builtin_isnan:
157 case Builtin::BI__builtin_isnormal:
Benjamin Kramer3b1e26b2010-02-16 10:07:31 +0000158 if (SemaBuiltinFPClassification(TheCall, 1))
Eli Friedman9ac6f622009-08-31 20:06:00 +0000159 return ExprError();
160 break;
Eli Friedman6cfda232008-05-20 08:23:37 +0000161 case Builtin::BI__builtin_return_address:
Eric Christopher691ebc32010-04-17 02:26:23 +0000162 case Builtin::BI__builtin_frame_address: {
163 llvm::APSInt Result;
164 if (SemaBuiltinConstantArg(TheCall, 0, Result))
Sebastian Redl0eb23302009-01-19 00:08:26 +0000165 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000166 break;
Eric Christopher691ebc32010-04-17 02:26:23 +0000167 }
168 case Builtin::BI__builtin_eh_return_data_regno: {
169 llvm::APSInt Result;
170 if (SemaBuiltinConstantArg(TheCall, 0, Result))
Chris Lattner21fb98e2009-09-23 06:06:36 +0000171 return ExprError();
172 break;
Eric Christopher691ebc32010-04-17 02:26:23 +0000173 }
Eli Friedmand38617c2008-05-14 19:38:39 +0000174 case Builtin::BI__builtin_shufflevector:
Sebastian Redl0eb23302009-01-19 00:08:26 +0000175 return SemaBuiltinShuffleVector(TheCall);
176 // TheCall will be freed by the smart pointer here, but that's fine, since
177 // SemaBuiltinShuffleVector guts it, but then doesn't release it.
Daniel Dunbar4493f792008-07-21 22:59:13 +0000178 case Builtin::BI__builtin_prefetch:
Sebastian Redl0eb23302009-01-19 00:08:26 +0000179 if (SemaBuiltinPrefetch(TheCall))
180 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000181 break;
Daniel Dunbard5f8a4f2008-09-03 21:13:56 +0000182 case Builtin::BI__builtin_object_size:
Sebastian Redl0eb23302009-01-19 00:08:26 +0000183 if (SemaBuiltinObjectSize(TheCall))
184 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000185 break;
Eli Friedmand875fed2009-05-03 04:46:36 +0000186 case Builtin::BI__builtin_longjmp:
187 if (SemaBuiltinLongjmp(TheCall))
188 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000189 break;
Chris Lattner5caa3702009-05-08 06:58:22 +0000190 case Builtin::BI__sync_fetch_and_add:
191 case Builtin::BI__sync_fetch_and_sub:
192 case Builtin::BI__sync_fetch_and_or:
193 case Builtin::BI__sync_fetch_and_and:
194 case Builtin::BI__sync_fetch_and_xor:
195 case Builtin::BI__sync_add_and_fetch:
196 case Builtin::BI__sync_sub_and_fetch:
197 case Builtin::BI__sync_and_and_fetch:
198 case Builtin::BI__sync_or_and_fetch:
199 case Builtin::BI__sync_xor_and_fetch:
200 case Builtin::BI__sync_val_compare_and_swap:
201 case Builtin::BI__sync_bool_compare_and_swap:
202 case Builtin::BI__sync_lock_test_and_set:
203 case Builtin::BI__sync_lock_release:
Chandler Carruthd2014572010-07-09 18:59:35 +0000204 return SemaBuiltinAtomicOverloaded(move(TheCallResult));
Nate Begeman26a31422010-06-08 02:47:44 +0000205 }
206
207 // Since the target specific builtins for each arch overlap, only check those
208 // of the arch we are compiling for.
209 if (BuiltinID >= Builtin::FirstTSBuiltin) {
210 switch (Context.Target.getTriple().getArch()) {
211 case llvm::Triple::arm:
212 case llvm::Triple::thumb:
213 if (CheckARMBuiltinFunctionCall(BuiltinID, TheCall))
214 return ExprError();
215 break;
216 case llvm::Triple::x86:
217 case llvm::Triple::x86_64:
218 if (CheckX86BuiltinFunctionCall(BuiltinID, TheCall))
219 return ExprError();
220 break;
221 default:
222 break;
223 }
224 }
225
226 return move(TheCallResult);
227}
228
229bool Sema::CheckX86BuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
230 switch (BuiltinID) {
Eric Christopher691ebc32010-04-17 02:26:23 +0000231 case X86::BI__builtin_ia32_palignr128:
232 case X86::BI__builtin_ia32_palignr: {
233 llvm::APSInt Result;
234 if (SemaBuiltinConstantArg(TheCall, 2, Result))
Nate Begeman26a31422010-06-08 02:47:44 +0000235 return true;
Eric Christopher691ebc32010-04-17 02:26:23 +0000236 break;
237 }
Anders Carlsson71993dd2007-08-17 05:31:46 +0000238 }
Nate Begeman26a31422010-06-08 02:47:44 +0000239 return false;
240}
Mike Stump1eb44332009-09-09 15:08:12 +0000241
Nate Begeman61eecf52010-06-14 05:21:25 +0000242// Get the valid immediate range for the specified NEON type code.
243static unsigned RFT(unsigned t, bool shift = false) {
244 bool quad = t & 0x10;
245
246 switch (t & 0x7) {
247 case 0: // i8
Nate Begemand69ec162010-06-17 02:26:59 +0000248 return shift ? 7 : (8 << (int)quad) - 1;
Nate Begeman61eecf52010-06-14 05:21:25 +0000249 case 1: // i16
Nate Begemand69ec162010-06-17 02:26:59 +0000250 return shift ? 15 : (4 << (int)quad) - 1;
Nate Begeman61eecf52010-06-14 05:21:25 +0000251 case 2: // i32
Nate Begemand69ec162010-06-17 02:26:59 +0000252 return shift ? 31 : (2 << (int)quad) - 1;
Nate Begeman61eecf52010-06-14 05:21:25 +0000253 case 3: // i64
Nate Begemand69ec162010-06-17 02:26:59 +0000254 return shift ? 63 : (1 << (int)quad) - 1;
Nate Begeman61eecf52010-06-14 05:21:25 +0000255 case 4: // f32
256 assert(!shift && "cannot shift float types!");
Nate Begemand69ec162010-06-17 02:26:59 +0000257 return (2 << (int)quad) - 1;
Nate Begeman61eecf52010-06-14 05:21:25 +0000258 case 5: // poly8
259 assert(!shift && "cannot shift polynomial types!");
Nate Begemand69ec162010-06-17 02:26:59 +0000260 return (8 << (int)quad) - 1;
Nate Begeman61eecf52010-06-14 05:21:25 +0000261 case 6: // poly16
262 assert(!shift && "cannot shift polynomial types!");
Nate Begemand69ec162010-06-17 02:26:59 +0000263 return (4 << (int)quad) - 1;
Nate Begeman61eecf52010-06-14 05:21:25 +0000264 case 7: // float16
265 assert(!shift && "cannot shift float types!");
Nate Begemand69ec162010-06-17 02:26:59 +0000266 return (4 << (int)quad) - 1;
Nate Begeman61eecf52010-06-14 05:21:25 +0000267 }
268 return 0;
269}
270
Nate Begeman26a31422010-06-08 02:47:44 +0000271bool Sema::CheckARMBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
Nate Begeman1c2a88c2010-06-09 01:10:23 +0000272 llvm::APSInt Result;
273
Nate Begeman0d15c532010-06-13 04:47:52 +0000274 unsigned mask = 0;
Nate Begeman61eecf52010-06-14 05:21:25 +0000275 unsigned TV = 0;
Nate Begeman1c2a88c2010-06-09 01:10:23 +0000276 switch (BuiltinID) {
Nate Begemana23326b2010-06-17 04:17:01 +0000277#define GET_NEON_OVERLOAD_CHECK
278#include "clang/Basic/arm_neon.inc"
279#undef GET_NEON_OVERLOAD_CHECK
Nate Begeman1c2a88c2010-06-09 01:10:23 +0000280 }
281
Nate Begeman0d15c532010-06-13 04:47:52 +0000282 // For NEON intrinsics which are overloaded on vector element type, validate
283 // the immediate which specifies which variant to emit.
284 if (mask) {
285 unsigned ArgNo = TheCall->getNumArgs()-1;
286 if (SemaBuiltinConstantArg(TheCall, ArgNo, Result))
287 return true;
288
Nate Begeman61eecf52010-06-14 05:21:25 +0000289 TV = Result.getLimitedValue(32);
290 if ((TV > 31) || (mask & (1 << TV)) == 0)
Nate Begeman0d15c532010-06-13 04:47:52 +0000291 return Diag(TheCall->getLocStart(), diag::err_invalid_neon_type_code)
292 << TheCall->getArg(ArgNo)->getSourceRange();
293 }
Nate Begeman1c2a88c2010-06-09 01:10:23 +0000294
Nate Begeman0d15c532010-06-13 04:47:52 +0000295 // For NEON intrinsics which take an immediate value as part of the
296 // instruction, range check them here.
Nate Begeman61eecf52010-06-14 05:21:25 +0000297 unsigned i = 0, l = 0, u = 0;
Nate Begeman0d15c532010-06-13 04:47:52 +0000298 switch (BuiltinID) {
299 default: return false;
Nate Begemanbb37f502010-07-29 22:48:34 +0000300 case ARM::BI__builtin_arm_ssat: i = 1; l = 1; u = 31; break;
301 case ARM::BI__builtin_arm_usat: i = 1; u = 31; break;
Nate Begeman99c40bb2010-08-03 21:32:34 +0000302 case ARM::BI__builtin_arm_vcvtr_f:
303 case ARM::BI__builtin_arm_vcvtr_d: i = 1; u = 1; break;
Nate Begemana23326b2010-06-17 04:17:01 +0000304#define GET_NEON_IMMEDIATE_CHECK
305#include "clang/Basic/arm_neon.inc"
306#undef GET_NEON_IMMEDIATE_CHECK
Nate Begeman0d15c532010-06-13 04:47:52 +0000307 };
308
Nate Begeman61eecf52010-06-14 05:21:25 +0000309 // Check that the immediate argument is actually a constant.
Nate Begeman0d15c532010-06-13 04:47:52 +0000310 if (SemaBuiltinConstantArg(TheCall, i, Result))
311 return true;
312
Nate Begeman61eecf52010-06-14 05:21:25 +0000313 // Range check against the upper/lower values for this isntruction.
Nate Begeman0d15c532010-06-13 04:47:52 +0000314 unsigned Val = Result.getZExtValue();
Nate Begeman61eecf52010-06-14 05:21:25 +0000315 if (Val < l || Val > (u + l))
Nate Begeman0d15c532010-06-13 04:47:52 +0000316 return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
Benjamin Kramer476d8b82010-08-11 14:47:12 +0000317 << l << u+l << TheCall->getArg(i)->getSourceRange();
Nate Begeman0d15c532010-06-13 04:47:52 +0000318
Nate Begeman99c40bb2010-08-03 21:32:34 +0000319 // FIXME: VFP Intrinsics should error if VFP not present.
Nate Begeman26a31422010-06-08 02:47:44 +0000320 return false;
Anders Carlssond406bf02009-08-16 01:56:34 +0000321}
Daniel Dunbarde454282008-10-02 18:44:07 +0000322
Anders Carlssond406bf02009-08-16 01:56:34 +0000323/// CheckFunctionCall - Check a direct function call for various correctness
324/// and safety properties not strictly enforced by the C type system.
325bool Sema::CheckFunctionCall(FunctionDecl *FDecl, CallExpr *TheCall) {
326 // Get the IdentifierInfo* for the called function.
327 IdentifierInfo *FnInfo = FDecl->getIdentifier();
328
329 // None of the checks below are needed for functions that don't have
330 // simple names (e.g., C++ conversion functions).
331 if (!FnInfo)
332 return false;
Mike Stump1eb44332009-09-09 15:08:12 +0000333
Daniel Dunbarde454282008-10-02 18:44:07 +0000334 // FIXME: This mechanism should be abstracted to be less fragile and
335 // more efficient. For example, just map function ids to custom
336 // handlers.
337
Chris Lattner59907c42007-08-10 20:18:51 +0000338 // Printf checking.
Argyrios Kyrtzidis40b598e2009-06-30 02:34:44 +0000339 if (const FormatAttr *Format = FDecl->getAttr<FormatAttr>()) {
Ted Kremenek826a3452010-07-16 02:11:22 +0000340 const bool b = Format->getType() == "scanf";
341 if (b || CheckablePrintfAttr(Format, TheCall)) {
Ted Kremenek3d692df2009-02-27 17:58:43 +0000342 bool HasVAListArg = Format->getFirstArg() == 0;
Ted Kremenek826a3452010-07-16 02:11:22 +0000343 CheckPrintfScanfArguments(TheCall, HasVAListArg,
344 Format->getFormatIdx() - 1,
345 HasVAListArg ? 0 : Format->getFirstArg() - 1,
346 !b);
Douglas Gregor3c385e52009-02-14 18:57:46 +0000347 }
Chris Lattner59907c42007-08-10 20:18:51 +0000348 }
Mike Stump1eb44332009-09-09 15:08:12 +0000349
350 for (const NonNullAttr *NonNull = FDecl->getAttr<NonNullAttr>(); NonNull;
Anders Carlssond406bf02009-08-16 01:56:34 +0000351 NonNull = NonNull->getNext<NonNullAttr>())
352 CheckNonNullArguments(NonNull, TheCall);
Sebastian Redl0eb23302009-01-19 00:08:26 +0000353
Anders Carlssond406bf02009-08-16 01:56:34 +0000354 return false;
Anders Carlsson71993dd2007-08-17 05:31:46 +0000355}
356
Anders Carlssond406bf02009-08-16 01:56:34 +0000357bool Sema::CheckBlockCall(NamedDecl *NDecl, CallExpr *TheCall) {
Fariborz Jahanian725165f2009-05-18 21:05:18 +0000358 // Printf checking.
Argyrios Kyrtzidis40b598e2009-06-30 02:34:44 +0000359 const FormatAttr *Format = NDecl->getAttr<FormatAttr>();
Fariborz Jahanian725165f2009-05-18 21:05:18 +0000360 if (!Format)
Anders Carlssond406bf02009-08-16 01:56:34 +0000361 return false;
Mike Stump1eb44332009-09-09 15:08:12 +0000362
Fariborz Jahanian725165f2009-05-18 21:05:18 +0000363 const VarDecl *V = dyn_cast<VarDecl>(NDecl);
364 if (!V)
Anders Carlssond406bf02009-08-16 01:56:34 +0000365 return false;
Mike Stump1eb44332009-09-09 15:08:12 +0000366
Fariborz Jahanian725165f2009-05-18 21:05:18 +0000367 QualType Ty = V->getType();
368 if (!Ty->isBlockPointerType())
Anders Carlssond406bf02009-08-16 01:56:34 +0000369 return false;
Mike Stump1eb44332009-09-09 15:08:12 +0000370
Ted Kremenek826a3452010-07-16 02:11:22 +0000371 const bool b = Format->getType() == "scanf";
372 if (!b && !CheckablePrintfAttr(Format, TheCall))
Anders Carlssond406bf02009-08-16 01:56:34 +0000373 return false;
Mike Stump1eb44332009-09-09 15:08:12 +0000374
Anders Carlssond406bf02009-08-16 01:56:34 +0000375 bool HasVAListArg = Format->getFirstArg() == 0;
Ted Kremenek826a3452010-07-16 02:11:22 +0000376 CheckPrintfScanfArguments(TheCall, HasVAListArg, Format->getFormatIdx() - 1,
377 HasVAListArg ? 0 : Format->getFirstArg() - 1, !b);
Anders Carlssond406bf02009-08-16 01:56:34 +0000378
379 return false;
Fariborz Jahanian725165f2009-05-18 21:05:18 +0000380}
381
Chris Lattner5caa3702009-05-08 06:58:22 +0000382/// SemaBuiltinAtomicOverloaded - We have a call to a function like
383/// __sync_fetch_and_add, which is an overloaded function based on the pointer
384/// type of its first argument. The main ActOnCallExpr routines have already
385/// promoted the types of arguments because all of these calls are prototyped as
386/// void(...).
387///
388/// This function goes through and does final semantic checking for these
389/// builtins,
Chandler Carruthd2014572010-07-09 18:59:35 +0000390Sema::OwningExprResult
391Sema::SemaBuiltinAtomicOverloaded(OwningExprResult TheCallResult) {
392 CallExpr *TheCall = (CallExpr *)TheCallResult.get();
Chris Lattner5caa3702009-05-08 06:58:22 +0000393 DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts());
394 FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl());
395
396 // Ensure that we have at least one argument to do type inference from.
Chandler Carruthd2014572010-07-09 18:59:35 +0000397 if (TheCall->getNumArgs() < 1) {
398 Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least)
399 << 0 << 1 << TheCall->getNumArgs()
400 << TheCall->getCallee()->getSourceRange();
401 return ExprError();
402 }
Mike Stump1eb44332009-09-09 15:08:12 +0000403
Chris Lattner5caa3702009-05-08 06:58:22 +0000404 // Inspect the first argument of the atomic builtin. This should always be
405 // a pointer type, whose element is an integral scalar or pointer type.
406 // Because it is a pointer type, we don't have to worry about any implicit
407 // casts here.
Chandler Carruthd2014572010-07-09 18:59:35 +0000408 // FIXME: We don't allow floating point scalars as input.
Chris Lattner5caa3702009-05-08 06:58:22 +0000409 Expr *FirstArg = TheCall->getArg(0);
Chandler Carruthd2014572010-07-09 18:59:35 +0000410 if (!FirstArg->getType()->isPointerType()) {
411 Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer)
412 << FirstArg->getType() << FirstArg->getSourceRange();
413 return ExprError();
414 }
Mike Stump1eb44332009-09-09 15:08:12 +0000415
Chandler Carruthd2014572010-07-09 18:59:35 +0000416 QualType ValType =
417 FirstArg->getType()->getAs<PointerType>()->getPointeeType();
Mike Stump1eb44332009-09-09 15:08:12 +0000418 if (!ValType->isIntegerType() && !ValType->isPointerType() &&
Chandler Carruthd2014572010-07-09 18:59:35 +0000419 !ValType->isBlockPointerType()) {
420 Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer_intptr)
421 << FirstArg->getType() << FirstArg->getSourceRange();
422 return ExprError();
423 }
Chris Lattner5caa3702009-05-08 06:58:22 +0000424
Chandler Carruth8d13d222010-07-18 20:54:12 +0000425 // The majority of builtins return a value, but a few have special return
426 // types, so allow them to override appropriately below.
427 QualType ResultType = ValType;
428
Chris Lattner5caa3702009-05-08 06:58:22 +0000429 // We need to figure out which concrete builtin this maps onto. For example,
430 // __sync_fetch_and_add with a 2 byte object turns into
431 // __sync_fetch_and_add_2.
432#define BUILTIN_ROW(x) \
433 { Builtin::BI##x##_1, Builtin::BI##x##_2, Builtin::BI##x##_4, \
434 Builtin::BI##x##_8, Builtin::BI##x##_16 }
Mike Stump1eb44332009-09-09 15:08:12 +0000435
Chris Lattner5caa3702009-05-08 06:58:22 +0000436 static const unsigned BuiltinIndices[][5] = {
437 BUILTIN_ROW(__sync_fetch_and_add),
438 BUILTIN_ROW(__sync_fetch_and_sub),
439 BUILTIN_ROW(__sync_fetch_and_or),
440 BUILTIN_ROW(__sync_fetch_and_and),
441 BUILTIN_ROW(__sync_fetch_and_xor),
Mike Stump1eb44332009-09-09 15:08:12 +0000442
Chris Lattner5caa3702009-05-08 06:58:22 +0000443 BUILTIN_ROW(__sync_add_and_fetch),
444 BUILTIN_ROW(__sync_sub_and_fetch),
445 BUILTIN_ROW(__sync_and_and_fetch),
446 BUILTIN_ROW(__sync_or_and_fetch),
447 BUILTIN_ROW(__sync_xor_and_fetch),
Mike Stump1eb44332009-09-09 15:08:12 +0000448
Chris Lattner5caa3702009-05-08 06:58:22 +0000449 BUILTIN_ROW(__sync_val_compare_and_swap),
450 BUILTIN_ROW(__sync_bool_compare_and_swap),
451 BUILTIN_ROW(__sync_lock_test_and_set),
452 BUILTIN_ROW(__sync_lock_release)
453 };
Mike Stump1eb44332009-09-09 15:08:12 +0000454#undef BUILTIN_ROW
455
Chris Lattner5caa3702009-05-08 06:58:22 +0000456 // Determine the index of the size.
457 unsigned SizeIndex;
Ken Dyck199c3d62010-01-11 17:06:35 +0000458 switch (Context.getTypeSizeInChars(ValType).getQuantity()) {
Chris Lattner5caa3702009-05-08 06:58:22 +0000459 case 1: SizeIndex = 0; break;
460 case 2: SizeIndex = 1; break;
461 case 4: SizeIndex = 2; break;
462 case 8: SizeIndex = 3; break;
463 case 16: SizeIndex = 4; break;
464 default:
Chandler Carruthd2014572010-07-09 18:59:35 +0000465 Diag(DRE->getLocStart(), diag::err_atomic_builtin_pointer_size)
466 << FirstArg->getType() << FirstArg->getSourceRange();
467 return ExprError();
Chris Lattner5caa3702009-05-08 06:58:22 +0000468 }
Mike Stump1eb44332009-09-09 15:08:12 +0000469
Chris Lattner5caa3702009-05-08 06:58:22 +0000470 // Each of these builtins has one pointer argument, followed by some number of
471 // values (0, 1 or 2) followed by a potentially empty varags list of stuff
472 // that we ignore. Find out which row of BuiltinIndices to read from as well
473 // as the number of fixed args.
Douglas Gregor7814e6d2009-09-12 00:22:50 +0000474 unsigned BuiltinID = FDecl->getBuiltinID();
Chris Lattner5caa3702009-05-08 06:58:22 +0000475 unsigned BuiltinIndex, NumFixed = 1;
476 switch (BuiltinID) {
477 default: assert(0 && "Unknown overloaded atomic builtin!");
478 case Builtin::BI__sync_fetch_and_add: BuiltinIndex = 0; break;
479 case Builtin::BI__sync_fetch_and_sub: BuiltinIndex = 1; break;
480 case Builtin::BI__sync_fetch_and_or: BuiltinIndex = 2; break;
481 case Builtin::BI__sync_fetch_and_and: BuiltinIndex = 3; break;
482 case Builtin::BI__sync_fetch_and_xor: BuiltinIndex = 4; break;
Mike Stump1eb44332009-09-09 15:08:12 +0000483
Daniel Dunbar7eff7c42010-03-25 17:13:09 +0000484 case Builtin::BI__sync_add_and_fetch: BuiltinIndex = 5; break;
485 case Builtin::BI__sync_sub_and_fetch: BuiltinIndex = 6; break;
486 case Builtin::BI__sync_and_and_fetch: BuiltinIndex = 7; break;
487 case Builtin::BI__sync_or_and_fetch: BuiltinIndex = 8; break;
488 case Builtin::BI__sync_xor_and_fetch: BuiltinIndex = 9; break;
Mike Stump1eb44332009-09-09 15:08:12 +0000489
Chris Lattner5caa3702009-05-08 06:58:22 +0000490 case Builtin::BI__sync_val_compare_and_swap:
Daniel Dunbar7eff7c42010-03-25 17:13:09 +0000491 BuiltinIndex = 10;
Chris Lattner5caa3702009-05-08 06:58:22 +0000492 NumFixed = 2;
493 break;
494 case Builtin::BI__sync_bool_compare_and_swap:
Daniel Dunbar7eff7c42010-03-25 17:13:09 +0000495 BuiltinIndex = 11;
Chris Lattner5caa3702009-05-08 06:58:22 +0000496 NumFixed = 2;
Chandler Carruth8d13d222010-07-18 20:54:12 +0000497 ResultType = Context.BoolTy;
Chris Lattner5caa3702009-05-08 06:58:22 +0000498 break;
Daniel Dunbar7eff7c42010-03-25 17:13:09 +0000499 case Builtin::BI__sync_lock_test_and_set: BuiltinIndex = 12; break;
Chris Lattner5caa3702009-05-08 06:58:22 +0000500 case Builtin::BI__sync_lock_release:
Daniel Dunbar7eff7c42010-03-25 17:13:09 +0000501 BuiltinIndex = 13;
Chris Lattner5caa3702009-05-08 06:58:22 +0000502 NumFixed = 0;
Chandler Carruth8d13d222010-07-18 20:54:12 +0000503 ResultType = Context.VoidTy;
Chris Lattner5caa3702009-05-08 06:58:22 +0000504 break;
505 }
Mike Stump1eb44332009-09-09 15:08:12 +0000506
Chris Lattner5caa3702009-05-08 06:58:22 +0000507 // Now that we know how many fixed arguments we expect, first check that we
508 // have at least that many.
Chandler Carruthd2014572010-07-09 18:59:35 +0000509 if (TheCall->getNumArgs() < 1+NumFixed) {
510 Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least)
511 << 0 << 1+NumFixed << TheCall->getNumArgs()
512 << TheCall->getCallee()->getSourceRange();
513 return ExprError();
514 }
Mike Stump1eb44332009-09-09 15:08:12 +0000515
Chris Lattnere7ac0a92009-05-08 15:36:58 +0000516 // Get the decl for the concrete builtin from this, we can tell what the
517 // concrete integer type we should convert to is.
518 unsigned NewBuiltinID = BuiltinIndices[BuiltinIndex][SizeIndex];
519 const char *NewBuiltinName = Context.BuiltinInfo.GetName(NewBuiltinID);
520 IdentifierInfo *NewBuiltinII = PP.getIdentifierInfo(NewBuiltinName);
Mike Stump1eb44332009-09-09 15:08:12 +0000521 FunctionDecl *NewBuiltinDecl =
Chris Lattnere7ac0a92009-05-08 15:36:58 +0000522 cast<FunctionDecl>(LazilyCreateBuiltin(NewBuiltinII, NewBuiltinID,
523 TUScope, false, DRE->getLocStart()));
Chandler Carruthd2014572010-07-09 18:59:35 +0000524
John McCallf871d0c2010-08-07 06:22:56 +0000525 // The first argument --- the pointer --- has a fixed type; we
526 // deduce the types of the rest of the arguments accordingly. Walk
527 // the remaining arguments, converting them to the deduced value type.
Chris Lattner5caa3702009-05-08 06:58:22 +0000528 for (unsigned i = 0; i != NumFixed; ++i) {
529 Expr *Arg = TheCall->getArg(i+1);
Mike Stump1eb44332009-09-09 15:08:12 +0000530
Chris Lattner5caa3702009-05-08 06:58:22 +0000531 // If the argument is an implicit cast, then there was a promotion due to
532 // "...", just remove it now.
533 if (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Arg)) {
534 Arg = ICE->getSubExpr();
535 ICE->setSubExpr(0);
Chris Lattner5caa3702009-05-08 06:58:22 +0000536 TheCall->setArg(i+1, Arg);
537 }
Mike Stump1eb44332009-09-09 15:08:12 +0000538
Chris Lattner5caa3702009-05-08 06:58:22 +0000539 // GCC does an implicit conversion to the pointer or integer ValType. This
540 // can fail in some cases (1i -> int**), check for this error case now.
Anders Carlssoncdb61972009-08-07 22:21:05 +0000541 CastExpr::CastKind Kind = CastExpr::CK_Unknown;
John McCallf871d0c2010-08-07 06:22:56 +0000542 CXXCastPath BasePath;
Anders Carlsson5cf86ba2010-04-24 19:06:50 +0000543 if (CheckCastTypes(Arg->getSourceRange(), ValType, Arg, Kind, BasePath))
Chandler Carruthd2014572010-07-09 18:59:35 +0000544 return ExprError();
Mike Stump1eb44332009-09-09 15:08:12 +0000545
Chris Lattner5caa3702009-05-08 06:58:22 +0000546 // Okay, we have something that *can* be converted to the right type. Check
547 // to see if there is a potentially weird extension going on here. This can
548 // happen when you do an atomic operation on something like an char* and
549 // pass in 42. The 42 gets converted to char. This is even more strange
550 // for things like 45.123 -> char, etc.
Mike Stump1eb44332009-09-09 15:08:12 +0000551 // FIXME: Do this check.
John McCallf871d0c2010-08-07 06:22:56 +0000552 ImpCastExprToType(Arg, ValType, Kind, ImplicitCastExpr::RValue, &BasePath);
Chris Lattner5caa3702009-05-08 06:58:22 +0000553 TheCall->setArg(i+1, Arg);
554 }
Mike Stump1eb44332009-09-09 15:08:12 +0000555
Chris Lattner5caa3702009-05-08 06:58:22 +0000556 // Switch the DeclRefExpr to refer to the new decl.
557 DRE->setDecl(NewBuiltinDecl);
558 DRE->setType(NewBuiltinDecl->getType());
Mike Stump1eb44332009-09-09 15:08:12 +0000559
Chris Lattner5caa3702009-05-08 06:58:22 +0000560 // Set the callee in the CallExpr.
561 // FIXME: This leaks the original parens and implicit casts.
562 Expr *PromotedCall = DRE;
563 UsualUnaryConversions(PromotedCall);
564 TheCall->setCallee(PromotedCall);
Mike Stump1eb44332009-09-09 15:08:12 +0000565
Chandler Carruthdb4325b2010-07-18 07:23:17 +0000566 // Change the result type of the call to match the original value type. This
567 // is arbitrary, but the codegen for these builtins ins design to handle it
568 // gracefully.
Chandler Carruth8d13d222010-07-18 20:54:12 +0000569 TheCall->setType(ResultType);
Chandler Carruthd2014572010-07-09 18:59:35 +0000570
571 return move(TheCallResult);
Chris Lattner5caa3702009-05-08 06:58:22 +0000572}
573
574
Chris Lattner69039812009-02-18 06:01:06 +0000575/// CheckObjCString - Checks that the argument to the builtin
Anders Carlsson71993dd2007-08-17 05:31:46 +0000576/// CFString constructor is correct
Steve Narofffd942622009-04-13 20:26:29 +0000577/// FIXME: GCC currently emits the following warning:
Mike Stump1eb44332009-09-09 15:08:12 +0000578/// "warning: input conversion stopped due to an input byte that does not
Steve Narofffd942622009-04-13 20:26:29 +0000579/// belong to the input codeset UTF-8"
580/// Note: It might also make sense to do the UTF-16 conversion here (would
581/// simplify the backend).
Chris Lattner69039812009-02-18 06:01:06 +0000582bool Sema::CheckObjCString(Expr *Arg) {
Chris Lattner56f34942008-02-13 01:02:39 +0000583 Arg = Arg->IgnoreParenCasts();
Anders Carlsson71993dd2007-08-17 05:31:46 +0000584 StringLiteral *Literal = dyn_cast<StringLiteral>(Arg);
585
586 if (!Literal || Literal->isWide()) {
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000587 Diag(Arg->getLocStart(), diag::err_cfstring_literal_not_string_constant)
588 << Arg->getSourceRange();
Anders Carlsson9cdc4d32007-08-17 15:44:17 +0000589 return true;
Anders Carlsson71993dd2007-08-17 05:31:46 +0000590 }
Mike Stump1eb44332009-09-09 15:08:12 +0000591
Daniel Dunbarf015b032009-09-22 10:03:52 +0000592 const char *Data = Literal->getStrData();
593 unsigned Length = Literal->getByteLength();
Mike Stump1eb44332009-09-09 15:08:12 +0000594
Daniel Dunbarf015b032009-09-22 10:03:52 +0000595 for (unsigned i = 0; i < Length; ++i) {
596 if (!Data[i]) {
597 Diag(getLocationOfStringLiteralByte(Literal, i),
598 diag::warn_cfstring_literal_contains_nul_character)
599 << Arg->getSourceRange();
600 break;
601 }
602 }
Mike Stump1eb44332009-09-09 15:08:12 +0000603
Anders Carlsson9cdc4d32007-08-17 15:44:17 +0000604 return false;
Chris Lattner59907c42007-08-10 20:18:51 +0000605}
606
Chris Lattnerc27c6652007-12-20 00:05:45 +0000607/// SemaBuiltinVAStart - Check the arguments to __builtin_va_start for validity.
608/// Emit an error and return true on failure, return false on success.
Chris Lattner925e60d2007-12-28 05:29:59 +0000609bool Sema::SemaBuiltinVAStart(CallExpr *TheCall) {
610 Expr *Fn = TheCall->getCallee();
611 if (TheCall->getNumArgs() > 2) {
Chris Lattner2c21a072008-11-21 18:44:24 +0000612 Diag(TheCall->getArg(2)->getLocStart(),
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000613 diag::err_typecheck_call_too_many_args)
Eric Christopherccfa9632010-04-16 04:56:46 +0000614 << 0 /*function call*/ << 2 << TheCall->getNumArgs()
615 << Fn->getSourceRange()
Mike Stump1eb44332009-09-09 15:08:12 +0000616 << SourceRange(TheCall->getArg(2)->getLocStart(),
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000617 (*(TheCall->arg_end()-1))->getLocEnd());
Chris Lattner30ce3442007-12-19 23:59:04 +0000618 return true;
619 }
Eli Friedman56f20ae2008-12-15 22:05:35 +0000620
621 if (TheCall->getNumArgs() < 2) {
Eric Christopherd77b9a22010-04-16 04:48:22 +0000622 return Diag(TheCall->getLocEnd(),
623 diag::err_typecheck_call_too_few_args_at_least)
624 << 0 /*function call*/ << 2 << TheCall->getNumArgs();
Eli Friedman56f20ae2008-12-15 22:05:35 +0000625 }
626
Chris Lattnerc27c6652007-12-20 00:05:45 +0000627 // Determine whether the current function is variadic or not.
Douglas Gregor9ea9bdb2010-03-01 23:15:13 +0000628 BlockScopeInfo *CurBlock = getCurBlock();
Chris Lattnerc27c6652007-12-20 00:05:45 +0000629 bool isVariadic;
Steve Naroffcd9c5142009-04-15 19:33:47 +0000630 if (CurBlock)
John McCallc71a4912010-06-04 19:02:56 +0000631 isVariadic = CurBlock->TheDecl->isVariadic();
Ted Kremenek9498d382010-04-29 16:49:01 +0000632 else if (FunctionDecl *FD = getCurFunctionDecl())
633 isVariadic = FD->isVariadic();
634 else
Argyrios Kyrtzidis53d0ea52008-06-28 06:07:14 +0000635 isVariadic = getCurMethodDecl()->isVariadic();
Mike Stump1eb44332009-09-09 15:08:12 +0000636
Chris Lattnerc27c6652007-12-20 00:05:45 +0000637 if (!isVariadic) {
Chris Lattner30ce3442007-12-19 23:59:04 +0000638 Diag(Fn->getLocStart(), diag::err_va_start_used_in_non_variadic_function);
639 return true;
640 }
Mike Stump1eb44332009-09-09 15:08:12 +0000641
Chris Lattner30ce3442007-12-19 23:59:04 +0000642 // Verify that the second argument to the builtin is the last argument of the
643 // current function or method.
644 bool SecondArgIsLastNamedArgument = false;
Anders Carlssone2c14102008-02-13 01:22:59 +0000645 const Expr *Arg = TheCall->getArg(1)->IgnoreParenCasts();
Mike Stump1eb44332009-09-09 15:08:12 +0000646
Anders Carlsson88cf2262008-02-11 04:20:54 +0000647 if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Arg)) {
648 if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(DR->getDecl())) {
Chris Lattner30ce3442007-12-19 23:59:04 +0000649 // FIXME: This isn't correct for methods (results in bogus warning).
650 // Get the last formal in the current function.
Anders Carlsson88cf2262008-02-11 04:20:54 +0000651 const ParmVarDecl *LastArg;
Steve Naroffcd9c5142009-04-15 19:33:47 +0000652 if (CurBlock)
653 LastArg = *(CurBlock->TheDecl->param_end()-1);
654 else if (FunctionDecl *FD = getCurFunctionDecl())
Chris Lattner371f2582008-12-04 23:50:19 +0000655 LastArg = *(FD->param_end()-1);
Chris Lattner30ce3442007-12-19 23:59:04 +0000656 else
Argyrios Kyrtzidis53d0ea52008-06-28 06:07:14 +0000657 LastArg = *(getCurMethodDecl()->param_end()-1);
Chris Lattner30ce3442007-12-19 23:59:04 +0000658 SecondArgIsLastNamedArgument = PV == LastArg;
659 }
660 }
Mike Stump1eb44332009-09-09 15:08:12 +0000661
Chris Lattner30ce3442007-12-19 23:59:04 +0000662 if (!SecondArgIsLastNamedArgument)
Mike Stump1eb44332009-09-09 15:08:12 +0000663 Diag(TheCall->getArg(1)->getLocStart(),
Chris Lattner30ce3442007-12-19 23:59:04 +0000664 diag::warn_second_parameter_of_va_start_not_last_named_argument);
665 return false;
Eli Friedman6cfda232008-05-20 08:23:37 +0000666}
Chris Lattner30ce3442007-12-19 23:59:04 +0000667
Chris Lattner1b9a0792007-12-20 00:26:33 +0000668/// SemaBuiltinUnorderedCompare - Handle functions like __builtin_isgreater and
669/// friends. This is declared to take (...), so we have to check everything.
Chris Lattner925e60d2007-12-28 05:29:59 +0000670bool Sema::SemaBuiltinUnorderedCompare(CallExpr *TheCall) {
671 if (TheCall->getNumArgs() < 2)
Chris Lattner2c21a072008-11-21 18:44:24 +0000672 return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args)
Eric Christopherd77b9a22010-04-16 04:48:22 +0000673 << 0 << 2 << TheCall->getNumArgs()/*function call*/;
Chris Lattner925e60d2007-12-28 05:29:59 +0000674 if (TheCall->getNumArgs() > 2)
Mike Stump1eb44332009-09-09 15:08:12 +0000675 return Diag(TheCall->getArg(2)->getLocStart(),
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000676 diag::err_typecheck_call_too_many_args)
Eric Christopherccfa9632010-04-16 04:56:46 +0000677 << 0 /*function call*/ << 2 << TheCall->getNumArgs()
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000678 << SourceRange(TheCall->getArg(2)->getLocStart(),
679 (*(TheCall->arg_end()-1))->getLocEnd());
Mike Stump1eb44332009-09-09 15:08:12 +0000680
Chris Lattner925e60d2007-12-28 05:29:59 +0000681 Expr *OrigArg0 = TheCall->getArg(0);
682 Expr *OrigArg1 = TheCall->getArg(1);
Douglas Gregorcde01732009-05-19 22:10:17 +0000683
Chris Lattner1b9a0792007-12-20 00:26:33 +0000684 // Do standard promotions between the two arguments, returning their common
685 // type.
Chris Lattner925e60d2007-12-28 05:29:59 +0000686 QualType Res = UsualArithmeticConversions(OrigArg0, OrigArg1, false);
Daniel Dunbar403bc2b2009-02-19 19:28:43 +0000687
688 // Make sure any conversions are pushed back into the call; this is
689 // type safe since unordered compare builtins are declared as "_Bool
690 // foo(...)".
691 TheCall->setArg(0, OrigArg0);
692 TheCall->setArg(1, OrigArg1);
Mike Stump1eb44332009-09-09 15:08:12 +0000693
Douglas Gregorcde01732009-05-19 22:10:17 +0000694 if (OrigArg0->isTypeDependent() || OrigArg1->isTypeDependent())
695 return false;
696
Chris Lattner1b9a0792007-12-20 00:26:33 +0000697 // If the common type isn't a real floating type, then the arguments were
698 // invalid for this operation.
699 if (!Res->isRealFloatingType())
Mike Stump1eb44332009-09-09 15:08:12 +0000700 return Diag(OrigArg0->getLocStart(),
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000701 diag::err_typecheck_call_invalid_ordered_compare)
Chris Lattnerd1625842008-11-24 06:25:27 +0000702 << OrigArg0->getType() << OrigArg1->getType()
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000703 << SourceRange(OrigArg0->getLocStart(), OrigArg1->getLocEnd());
Mike Stump1eb44332009-09-09 15:08:12 +0000704
Chris Lattner1b9a0792007-12-20 00:26:33 +0000705 return false;
706}
707
Benjamin Kramere771a7a2010-02-15 22:42:31 +0000708/// SemaBuiltinSemaBuiltinFPClassification - Handle functions like
709/// __builtin_isnan and friends. This is declared to take (...), so we have
Benjamin Kramer3b1e26b2010-02-16 10:07:31 +0000710/// to check everything. We expect the last argument to be a floating point
711/// value.
712bool Sema::SemaBuiltinFPClassification(CallExpr *TheCall, unsigned NumArgs) {
713 if (TheCall->getNumArgs() < NumArgs)
Eli Friedman9ac6f622009-08-31 20:06:00 +0000714 return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args)
Eric Christopherd77b9a22010-04-16 04:48:22 +0000715 << 0 << NumArgs << TheCall->getNumArgs()/*function call*/;
Benjamin Kramer3b1e26b2010-02-16 10:07:31 +0000716 if (TheCall->getNumArgs() > NumArgs)
717 return Diag(TheCall->getArg(NumArgs)->getLocStart(),
Eli Friedman9ac6f622009-08-31 20:06:00 +0000718 diag::err_typecheck_call_too_many_args)
Eric Christopherccfa9632010-04-16 04:56:46 +0000719 << 0 /*function call*/ << NumArgs << TheCall->getNumArgs()
Benjamin Kramer3b1e26b2010-02-16 10:07:31 +0000720 << SourceRange(TheCall->getArg(NumArgs)->getLocStart(),
Eli Friedman9ac6f622009-08-31 20:06:00 +0000721 (*(TheCall->arg_end()-1))->getLocEnd());
722
Benjamin Kramer3b1e26b2010-02-16 10:07:31 +0000723 Expr *OrigArg = TheCall->getArg(NumArgs-1);
Mike Stump1eb44332009-09-09 15:08:12 +0000724
Eli Friedman9ac6f622009-08-31 20:06:00 +0000725 if (OrigArg->isTypeDependent())
726 return false;
727
Chris Lattner81368fb2010-05-06 05:50:07 +0000728 // This operation requires a non-_Complex floating-point number.
Eli Friedman9ac6f622009-08-31 20:06:00 +0000729 if (!OrigArg->getType()->isRealFloatingType())
Mike Stump1eb44332009-09-09 15:08:12 +0000730 return Diag(OrigArg->getLocStart(),
Eli Friedman9ac6f622009-08-31 20:06:00 +0000731 diag::err_typecheck_call_invalid_unary_fp)
732 << OrigArg->getType() << OrigArg->getSourceRange();
Mike Stump1eb44332009-09-09 15:08:12 +0000733
Chris Lattner81368fb2010-05-06 05:50:07 +0000734 // If this is an implicit conversion from float -> double, remove it.
735 if (ImplicitCastExpr *Cast = dyn_cast<ImplicitCastExpr>(OrigArg)) {
736 Expr *CastArg = Cast->getSubExpr();
737 if (CastArg->getType()->isSpecificBuiltinType(BuiltinType::Float)) {
738 assert(Cast->getType()->isSpecificBuiltinType(BuiltinType::Double) &&
739 "promotion from float to double is the only expected cast here");
740 Cast->setSubExpr(0);
Chris Lattner81368fb2010-05-06 05:50:07 +0000741 TheCall->setArg(NumArgs-1, CastArg);
742 OrigArg = CastArg;
743 }
744 }
745
Eli Friedman9ac6f622009-08-31 20:06:00 +0000746 return false;
747}
748
Eli Friedmand38617c2008-05-14 19:38:39 +0000749/// SemaBuiltinShuffleVector - Handle __builtin_shufflevector.
750// This is declared to take (...), so we have to check everything.
Sebastian Redl0eb23302009-01-19 00:08:26 +0000751Action::OwningExprResult Sema::SemaBuiltinShuffleVector(CallExpr *TheCall) {
Nate Begeman37b6a572010-06-08 00:16:34 +0000752 if (TheCall->getNumArgs() < 2)
Sebastian Redl0eb23302009-01-19 00:08:26 +0000753 return ExprError(Diag(TheCall->getLocEnd(),
Eric Christopherd77b9a22010-04-16 04:48:22 +0000754 diag::err_typecheck_call_too_few_args_at_least)
Nate Begeman37b6a572010-06-08 00:16:34 +0000755 << 0 /*function call*/ << 2 << TheCall->getNumArgs()
Eric Christopherd77b9a22010-04-16 04:48:22 +0000756 << TheCall->getSourceRange());
Eli Friedmand38617c2008-05-14 19:38:39 +0000757
Nate Begeman37b6a572010-06-08 00:16:34 +0000758 // Determine which of the following types of shufflevector we're checking:
759 // 1) unary, vector mask: (lhs, mask)
760 // 2) binary, vector mask: (lhs, rhs, mask)
761 // 3) binary, scalar mask: (lhs, rhs, index, ..., index)
762 QualType resType = TheCall->getArg(0)->getType();
763 unsigned numElements = 0;
764
Douglas Gregorcde01732009-05-19 22:10:17 +0000765 if (!TheCall->getArg(0)->isTypeDependent() &&
766 !TheCall->getArg(1)->isTypeDependent()) {
Nate Begeman37b6a572010-06-08 00:16:34 +0000767 QualType LHSType = TheCall->getArg(0)->getType();
768 QualType RHSType = TheCall->getArg(1)->getType();
769
770 if (!LHSType->isVectorType() || !RHSType->isVectorType()) {
Douglas Gregorcde01732009-05-19 22:10:17 +0000771 Diag(TheCall->getLocStart(), diag::err_shufflevector_non_vector)
Mike Stump1eb44332009-09-09 15:08:12 +0000772 << SourceRange(TheCall->getArg(0)->getLocStart(),
Douglas Gregorcde01732009-05-19 22:10:17 +0000773 TheCall->getArg(1)->getLocEnd());
774 return ExprError();
775 }
Nate Begeman37b6a572010-06-08 00:16:34 +0000776
777 numElements = LHSType->getAs<VectorType>()->getNumElements();
778 unsigned numResElements = TheCall->getNumArgs() - 2;
Mike Stump1eb44332009-09-09 15:08:12 +0000779
Nate Begeman37b6a572010-06-08 00:16:34 +0000780 // Check to see if we have a call with 2 vector arguments, the unary shuffle
781 // with mask. If so, verify that RHS is an integer vector type with the
782 // same number of elts as lhs.
783 if (TheCall->getNumArgs() == 2) {
Douglas Gregorf6094622010-07-23 15:58:24 +0000784 if (!RHSType->hasIntegerRepresentation() ||
Nate Begeman37b6a572010-06-08 00:16:34 +0000785 RHSType->getAs<VectorType>()->getNumElements() != numElements)
786 Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector)
787 << SourceRange(TheCall->getArg(1)->getLocStart(),
788 TheCall->getArg(1)->getLocEnd());
789 numResElements = numElements;
790 }
791 else if (!Context.hasSameUnqualifiedType(LHSType, RHSType)) {
Douglas Gregorcde01732009-05-19 22:10:17 +0000792 Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector)
Mike Stump1eb44332009-09-09 15:08:12 +0000793 << SourceRange(TheCall->getArg(0)->getLocStart(),
Douglas Gregorcde01732009-05-19 22:10:17 +0000794 TheCall->getArg(1)->getLocEnd());
795 return ExprError();
Nate Begeman37b6a572010-06-08 00:16:34 +0000796 } else if (numElements != numResElements) {
797 QualType eltType = LHSType->getAs<VectorType>()->getElementType();
Chris Lattner788b0fd2010-06-23 06:00:24 +0000798 resType = Context.getVectorType(eltType, numResElements,
799 VectorType::NotAltiVec);
Douglas Gregorcde01732009-05-19 22:10:17 +0000800 }
Eli Friedmand38617c2008-05-14 19:38:39 +0000801 }
802
803 for (unsigned i = 2; i < TheCall->getNumArgs(); i++) {
Douglas Gregorcde01732009-05-19 22:10:17 +0000804 if (TheCall->getArg(i)->isTypeDependent() ||
805 TheCall->getArg(i)->isValueDependent())
806 continue;
807
Nate Begeman37b6a572010-06-08 00:16:34 +0000808 llvm::APSInt Result(32);
809 if (!TheCall->getArg(i)->isIntegerConstantExpr(Result, Context))
810 return ExprError(Diag(TheCall->getLocStart(),
811 diag::err_shufflevector_nonconstant_argument)
812 << TheCall->getArg(i)->getSourceRange());
Sebastian Redl0eb23302009-01-19 00:08:26 +0000813
Chris Lattnerd1a0b6d2008-08-10 02:05:13 +0000814 if (Result.getActiveBits() > 64 || Result.getZExtValue() >= numElements*2)
Sebastian Redl0eb23302009-01-19 00:08:26 +0000815 return ExprError(Diag(TheCall->getLocStart(),
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000816 diag::err_shufflevector_argument_too_large)
Sebastian Redl0eb23302009-01-19 00:08:26 +0000817 << TheCall->getArg(i)->getSourceRange());
Eli Friedmand38617c2008-05-14 19:38:39 +0000818 }
819
820 llvm::SmallVector<Expr*, 32> exprs;
821
Chris Lattnerd1a0b6d2008-08-10 02:05:13 +0000822 for (unsigned i = 0, e = TheCall->getNumArgs(); i != e; i++) {
Eli Friedmand38617c2008-05-14 19:38:39 +0000823 exprs.push_back(TheCall->getArg(i));
824 TheCall->setArg(i, 0);
825 }
826
Nate Begemana88dc302009-08-12 02:10:25 +0000827 return Owned(new (Context) ShuffleVectorExpr(Context, exprs.begin(),
Nate Begeman37b6a572010-06-08 00:16:34 +0000828 exprs.size(), resType,
Ted Kremenek8189cde2009-02-07 01:47:29 +0000829 TheCall->getCallee()->getLocStart(),
830 TheCall->getRParenLoc()));
Eli Friedmand38617c2008-05-14 19:38:39 +0000831}
Chris Lattner30ce3442007-12-19 23:59:04 +0000832
Daniel Dunbar4493f792008-07-21 22:59:13 +0000833/// SemaBuiltinPrefetch - Handle __builtin_prefetch.
834// This is declared to take (const void*, ...) and can take two
835// optional constant int args.
836bool Sema::SemaBuiltinPrefetch(CallExpr *TheCall) {
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000837 unsigned NumArgs = TheCall->getNumArgs();
Daniel Dunbar4493f792008-07-21 22:59:13 +0000838
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000839 if (NumArgs > 3)
Eric Christopherccfa9632010-04-16 04:56:46 +0000840 return Diag(TheCall->getLocEnd(),
841 diag::err_typecheck_call_too_many_args_at_most)
842 << 0 /*function call*/ << 3 << NumArgs
843 << TheCall->getSourceRange();
Daniel Dunbar4493f792008-07-21 22:59:13 +0000844
845 // Argument 0 is checked for us and the remaining arguments must be
846 // constant integers.
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000847 for (unsigned i = 1; i != NumArgs; ++i) {
Daniel Dunbar4493f792008-07-21 22:59:13 +0000848 Expr *Arg = TheCall->getArg(i);
Eric Christopher691ebc32010-04-17 02:26:23 +0000849
Eli Friedman9aef7262009-12-04 00:30:06 +0000850 llvm::APSInt Result;
Eric Christopher691ebc32010-04-17 02:26:23 +0000851 if (SemaBuiltinConstantArg(TheCall, i, Result))
852 return true;
Mike Stump1eb44332009-09-09 15:08:12 +0000853
Daniel Dunbar4493f792008-07-21 22:59:13 +0000854 // FIXME: gcc issues a warning and rewrites these to 0. These
855 // seems especially odd for the third argument since the default
856 // is 3.
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000857 if (i == 1) {
Eli Friedman9aef7262009-12-04 00:30:06 +0000858 if (Result.getLimitedValue() > 1)
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000859 return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
Chris Lattner21fb98e2009-09-23 06:06:36 +0000860 << "0" << "1" << Arg->getSourceRange();
Daniel Dunbar4493f792008-07-21 22:59:13 +0000861 } else {
Eli Friedman9aef7262009-12-04 00:30:06 +0000862 if (Result.getLimitedValue() > 3)
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000863 return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
Chris Lattner21fb98e2009-09-23 06:06:36 +0000864 << "0" << "3" << Arg->getSourceRange();
Daniel Dunbar4493f792008-07-21 22:59:13 +0000865 }
866 }
867
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000868 return false;
Daniel Dunbar4493f792008-07-21 22:59:13 +0000869}
870
Eric Christopher691ebc32010-04-17 02:26:23 +0000871/// SemaBuiltinConstantArg - Handle a check if argument ArgNum of CallExpr
872/// TheCall is a constant expression.
873bool Sema::SemaBuiltinConstantArg(CallExpr *TheCall, int ArgNum,
874 llvm::APSInt &Result) {
875 Expr *Arg = TheCall->getArg(ArgNum);
876 DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts());
877 FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl());
878
879 if (Arg->isTypeDependent() || Arg->isValueDependent()) return false;
880
881 if (!Arg->isIntegerConstantExpr(Result, Context))
882 return Diag(TheCall->getLocStart(), diag::err_constant_integer_arg_type)
Eric Christopher5e896552010-04-19 18:23:02 +0000883 << FDecl->getDeclName() << Arg->getSourceRange();
Eric Christopher691ebc32010-04-17 02:26:23 +0000884
Chris Lattner21fb98e2009-09-23 06:06:36 +0000885 return false;
886}
887
Daniel Dunbard5f8a4f2008-09-03 21:13:56 +0000888/// SemaBuiltinObjectSize - Handle __builtin_object_size(void *ptr,
889/// int type). This simply type checks that type is one of the defined
890/// constants (0-3).
Eric Christopherfee667f2009-12-23 03:49:37 +0000891// For compatability check 0-3, llvm only handles 0 and 2.
Daniel Dunbard5f8a4f2008-09-03 21:13:56 +0000892bool Sema::SemaBuiltinObjectSize(CallExpr *TheCall) {
Eric Christopher691ebc32010-04-17 02:26:23 +0000893 llvm::APSInt Result;
894
895 // Check constant-ness first.
896 if (SemaBuiltinConstantArg(TheCall, 1, Result))
897 return true;
898
Daniel Dunbard5f8a4f2008-09-03 21:13:56 +0000899 Expr *Arg = TheCall->getArg(1);
Daniel Dunbard5f8a4f2008-09-03 21:13:56 +0000900 if (Result.getSExtValue() < 0 || Result.getSExtValue() > 3) {
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000901 return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
902 << "0" << "3" << SourceRange(Arg->getLocStart(), Arg->getLocEnd());
Daniel Dunbard5f8a4f2008-09-03 21:13:56 +0000903 }
904
905 return false;
906}
907
Eli Friedman586d6a82009-05-03 06:04:26 +0000908/// SemaBuiltinLongjmp - Handle __builtin_longjmp(void *env[5], int val).
Eli Friedmand875fed2009-05-03 04:46:36 +0000909/// This checks that val is a constant 1.
910bool Sema::SemaBuiltinLongjmp(CallExpr *TheCall) {
911 Expr *Arg = TheCall->getArg(1);
Eric Christopher691ebc32010-04-17 02:26:23 +0000912 llvm::APSInt Result;
Douglas Gregorcde01732009-05-19 22:10:17 +0000913
Eric Christopher691ebc32010-04-17 02:26:23 +0000914 // TODO: This is less than ideal. Overload this to take a value.
915 if (SemaBuiltinConstantArg(TheCall, 1, Result))
916 return true;
917
918 if (Result != 1)
Eli Friedmand875fed2009-05-03 04:46:36 +0000919 return Diag(TheCall->getLocStart(), diag::err_builtin_longjmp_invalid_val)
920 << SourceRange(Arg->getLocStart(), Arg->getLocEnd());
921
922 return false;
923}
924
Ted Kremenekd30ef872009-01-12 23:09:09 +0000925// Handle i > 1 ? "x" : "y", recursivelly
Ted Kremenek082d9362009-03-20 21:35:28 +0000926bool Sema::SemaCheckStringLiteral(const Expr *E, const CallExpr *TheCall,
927 bool HasVAListArg,
Ted Kremenek826a3452010-07-16 02:11:22 +0000928 unsigned format_idx, unsigned firstDataArg,
929 bool isPrintf) {
930
Douglas Gregorcde01732009-05-19 22:10:17 +0000931 if (E->isTypeDependent() || E->isValueDependent())
932 return false;
Ted Kremenekd30ef872009-01-12 23:09:09 +0000933
934 switch (E->getStmtClass()) {
935 case Stmt::ConditionalOperatorClass: {
Ted Kremenek082d9362009-03-20 21:35:28 +0000936 const ConditionalOperator *C = cast<ConditionalOperator>(E);
Ted Kremenek826a3452010-07-16 02:11:22 +0000937 return SemaCheckStringLiteral(C->getTrueExpr(), TheCall, HasVAListArg,
938 format_idx, firstDataArg, isPrintf)
939 && SemaCheckStringLiteral(C->getRHS(), TheCall, HasVAListArg,
940 format_idx, firstDataArg, isPrintf);
Ted Kremenekd30ef872009-01-12 23:09:09 +0000941 }
942
943 case Stmt::ImplicitCastExprClass: {
Ted Kremenek082d9362009-03-20 21:35:28 +0000944 const ImplicitCastExpr *Expr = cast<ImplicitCastExpr>(E);
Ted Kremenekd30ef872009-01-12 23:09:09 +0000945 return SemaCheckStringLiteral(Expr->getSubExpr(), TheCall, HasVAListArg,
Ted Kremenek826a3452010-07-16 02:11:22 +0000946 format_idx, firstDataArg, isPrintf);
Ted Kremenekd30ef872009-01-12 23:09:09 +0000947 }
948
949 case Stmt::ParenExprClass: {
Ted Kremenek082d9362009-03-20 21:35:28 +0000950 const ParenExpr *Expr = cast<ParenExpr>(E);
Ted Kremenekd30ef872009-01-12 23:09:09 +0000951 return SemaCheckStringLiteral(Expr->getSubExpr(), TheCall, HasVAListArg,
Ted Kremenek826a3452010-07-16 02:11:22 +0000952 format_idx, firstDataArg, isPrintf);
Ted Kremenekd30ef872009-01-12 23:09:09 +0000953 }
Mike Stump1eb44332009-09-09 15:08:12 +0000954
Ted Kremenek082d9362009-03-20 21:35:28 +0000955 case Stmt::DeclRefExprClass: {
956 const DeclRefExpr *DR = cast<DeclRefExpr>(E);
Mike Stump1eb44332009-09-09 15:08:12 +0000957
Ted Kremenek082d9362009-03-20 21:35:28 +0000958 // As an exception, do not flag errors for variables binding to
959 // const string literals.
960 if (const VarDecl *VD = dyn_cast<VarDecl>(DR->getDecl())) {
961 bool isConstant = false;
962 QualType T = DR->getType();
Ted Kremenekd30ef872009-01-12 23:09:09 +0000963
Ted Kremenek082d9362009-03-20 21:35:28 +0000964 if (const ArrayType *AT = Context.getAsArrayType(T)) {
965 isConstant = AT->getElementType().isConstant(Context);
Mike Stumpac5fc7c2009-08-04 21:02:39 +0000966 } else if (const PointerType *PT = T->getAs<PointerType>()) {
Mike Stump1eb44332009-09-09 15:08:12 +0000967 isConstant = T.isConstant(Context) &&
Ted Kremenek082d9362009-03-20 21:35:28 +0000968 PT->getPointeeType().isConstant(Context);
969 }
Mike Stump1eb44332009-09-09 15:08:12 +0000970
Ted Kremenek082d9362009-03-20 21:35:28 +0000971 if (isConstant) {
Sebastian Redl31310a22010-02-01 20:16:42 +0000972 if (const Expr *Init = VD->getAnyInitializer())
Ted Kremenek082d9362009-03-20 21:35:28 +0000973 return SemaCheckStringLiteral(Init, TheCall,
Ted Kremenek826a3452010-07-16 02:11:22 +0000974 HasVAListArg, format_idx, firstDataArg,
975 isPrintf);
Ted Kremenek082d9362009-03-20 21:35:28 +0000976 }
Mike Stump1eb44332009-09-09 15:08:12 +0000977
Anders Carlssond966a552009-06-28 19:55:58 +0000978 // For vprintf* functions (i.e., HasVAListArg==true), we add a
979 // special check to see if the format string is a function parameter
980 // of the function calling the printf function. If the function
981 // has an attribute indicating it is a printf-like function, then we
982 // should suppress warnings concerning non-literals being used in a call
983 // to a vprintf function. For example:
984 //
985 // void
986 // logmessage(char const *fmt __attribute__ (format (printf, 1, 2)), ...){
987 // va_list ap;
988 // va_start(ap, fmt);
989 // vprintf(fmt, ap); // Do NOT emit a warning about "fmt".
990 // ...
991 //
992 //
993 // FIXME: We don't have full attribute support yet, so just check to see
994 // if the argument is a DeclRefExpr that references a parameter. We'll
995 // add proper support for checking the attribute later.
996 if (HasVAListArg)
997 if (isa<ParmVarDecl>(VD))
998 return true;
Ted Kremenek082d9362009-03-20 21:35:28 +0000999 }
Mike Stump1eb44332009-09-09 15:08:12 +00001000
Ted Kremenek082d9362009-03-20 21:35:28 +00001001 return false;
1002 }
Ted Kremenekd30ef872009-01-12 23:09:09 +00001003
Anders Carlsson8f031b32009-06-27 04:05:33 +00001004 case Stmt::CallExprClass: {
1005 const CallExpr *CE = cast<CallExpr>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00001006 if (const ImplicitCastExpr *ICE
Anders Carlsson8f031b32009-06-27 04:05:33 +00001007 = dyn_cast<ImplicitCastExpr>(CE->getCallee())) {
1008 if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(ICE->getSubExpr())) {
1009 if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(DRE->getDecl())) {
Argyrios Kyrtzidis40b598e2009-06-30 02:34:44 +00001010 if (const FormatArgAttr *FA = FD->getAttr<FormatArgAttr>()) {
Anders Carlsson8f031b32009-06-27 04:05:33 +00001011 unsigned ArgIndex = FA->getFormatIdx();
1012 const Expr *Arg = CE->getArg(ArgIndex - 1);
Mike Stump1eb44332009-09-09 15:08:12 +00001013
1014 return SemaCheckStringLiteral(Arg, TheCall, HasVAListArg,
Ted Kremenek826a3452010-07-16 02:11:22 +00001015 format_idx, firstDataArg, isPrintf);
Anders Carlsson8f031b32009-06-27 04:05:33 +00001016 }
1017 }
1018 }
1019 }
Mike Stump1eb44332009-09-09 15:08:12 +00001020
Anders Carlsson8f031b32009-06-27 04:05:33 +00001021 return false;
1022 }
Ted Kremenek082d9362009-03-20 21:35:28 +00001023 case Stmt::ObjCStringLiteralClass:
1024 case Stmt::StringLiteralClass: {
1025 const StringLiteral *StrE = NULL;
Mike Stump1eb44332009-09-09 15:08:12 +00001026
Ted Kremenek082d9362009-03-20 21:35:28 +00001027 if (const ObjCStringLiteral *ObjCFExpr = dyn_cast<ObjCStringLiteral>(E))
Ted Kremenekd30ef872009-01-12 23:09:09 +00001028 StrE = ObjCFExpr->getString();
1029 else
Ted Kremenek082d9362009-03-20 21:35:28 +00001030 StrE = cast<StringLiteral>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00001031
Ted Kremenekd30ef872009-01-12 23:09:09 +00001032 if (StrE) {
Ted Kremenek826a3452010-07-16 02:11:22 +00001033 CheckFormatString(StrE, E, TheCall, HasVAListArg, format_idx,
1034 firstDataArg, isPrintf);
Ted Kremenekd30ef872009-01-12 23:09:09 +00001035 return true;
1036 }
Mike Stump1eb44332009-09-09 15:08:12 +00001037
Ted Kremenekd30ef872009-01-12 23:09:09 +00001038 return false;
1039 }
Mike Stump1eb44332009-09-09 15:08:12 +00001040
Ted Kremenek082d9362009-03-20 21:35:28 +00001041 default:
1042 return false;
Ted Kremenekd30ef872009-01-12 23:09:09 +00001043 }
1044}
1045
Fariborz Jahaniane898f8a2009-05-21 18:48:51 +00001046void
Mike Stump1eb44332009-09-09 15:08:12 +00001047Sema::CheckNonNullArguments(const NonNullAttr *NonNull,
1048 const CallExpr *TheCall) {
Fariborz Jahaniane898f8a2009-05-21 18:48:51 +00001049 for (NonNullAttr::iterator i = NonNull->begin(), e = NonNull->end();
1050 i != e; ++i) {
Chris Lattner12b97ff2009-05-25 18:23:36 +00001051 const Expr *ArgExpr = TheCall->getArg(*i);
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001052 if (ArgExpr->isNullPointerConstant(Context,
Douglas Gregorce940492009-09-25 04:25:58 +00001053 Expr::NPC_ValueDependentIsNotNull))
Chris Lattner12b97ff2009-05-25 18:23:36 +00001054 Diag(TheCall->getCallee()->getLocStart(), diag::warn_null_arg)
1055 << ArgExpr->getSourceRange();
Fariborz Jahaniane898f8a2009-05-21 18:48:51 +00001056 }
1057}
Ted Kremenekd30ef872009-01-12 23:09:09 +00001058
Ted Kremenek826a3452010-07-16 02:11:22 +00001059/// CheckPrintfScanfArguments - Check calls to printf and scanf (and similar
1060/// functions) for correct use of format strings.
Chris Lattner59907c42007-08-10 20:18:51 +00001061void
Ted Kremenek826a3452010-07-16 02:11:22 +00001062Sema::CheckPrintfScanfArguments(const CallExpr *TheCall, bool HasVAListArg,
1063 unsigned format_idx, unsigned firstDataArg,
1064 bool isPrintf) {
1065
Ted Kremenek082d9362009-03-20 21:35:28 +00001066 const Expr *Fn = TheCall->getCallee();
Chris Lattner925e60d2007-12-28 05:29:59 +00001067
Sebastian Redl4a2614e2009-11-17 18:02:24 +00001068 // The way the format attribute works in GCC, the implicit this argument
1069 // of member functions is counted. However, it doesn't appear in our own
1070 // lists, so decrement format_idx in that case.
1071 if (isa<CXXMemberCallExpr>(TheCall)) {
1072 // Catch a format attribute mistakenly referring to the object argument.
1073 if (format_idx == 0)
1074 return;
1075 --format_idx;
1076 if(firstDataArg != 0)
1077 --firstDataArg;
1078 }
1079
Ted Kremenek826a3452010-07-16 02:11:22 +00001080 // CHECK: printf/scanf-like function is called with no format string.
Chris Lattner925e60d2007-12-28 05:29:59 +00001081 if (format_idx >= TheCall->getNumArgs()) {
Ted Kremenek826a3452010-07-16 02:11:22 +00001082 Diag(TheCall->getRParenLoc(), diag::warn_missing_format_string)
Chris Lattnerdcd5ef12008-11-19 05:27:50 +00001083 << Fn->getSourceRange();
Ted Kremenek71895b92007-08-14 17:39:48 +00001084 return;
1085 }
Mike Stump1eb44332009-09-09 15:08:12 +00001086
Ted Kremenek082d9362009-03-20 21:35:28 +00001087 const Expr *OrigFormatExpr = TheCall->getArg(format_idx)->IgnoreParenCasts();
Mike Stump1eb44332009-09-09 15:08:12 +00001088
Chris Lattner59907c42007-08-10 20:18:51 +00001089 // CHECK: format string is not a string literal.
Mike Stump1eb44332009-09-09 15:08:12 +00001090 //
Ted Kremenek71895b92007-08-14 17:39:48 +00001091 // Dynamically generated format strings are difficult to
1092 // automatically vet at compile time. Requiring that format strings
1093 // are string literals: (1) permits the checking of format strings by
1094 // the compiler and thereby (2) can practically remove the source of
1095 // many format string exploits.
Ted Kremenek7ff22b22008-06-16 18:00:42 +00001096
Mike Stump1eb44332009-09-09 15:08:12 +00001097 // Format string can be either ObjC string (e.g. @"%d") or
Ted Kremenek7ff22b22008-06-16 18:00:42 +00001098 // C string (e.g. "%d")
Mike Stump1eb44332009-09-09 15:08:12 +00001099 // ObjC string uses the same format specifiers as C string, so we can use
Ted Kremenek7ff22b22008-06-16 18:00:42 +00001100 // the same format string checking logic for both ObjC and C strings.
Chris Lattner1cd3e1f2009-04-29 04:49:34 +00001101 if (SemaCheckStringLiteral(OrigFormatExpr, TheCall, HasVAListArg, format_idx,
Ted Kremenek826a3452010-07-16 02:11:22 +00001102 firstDataArg, isPrintf))
Chris Lattner1cd3e1f2009-04-29 04:49:34 +00001103 return; // Literal format string found, check done!
Ted Kremenek7ff22b22008-06-16 18:00:42 +00001104
Chris Lattner655f1412009-04-29 04:59:47 +00001105 // If there are no arguments specified, warn with -Wformat-security, otherwise
1106 // warn only with -Wformat-nonliteral.
1107 if (TheCall->getNumArgs() == format_idx+1)
Mike Stump1eb44332009-09-09 15:08:12 +00001108 Diag(TheCall->getArg(format_idx)->getLocStart(),
Ted Kremenek826a3452010-07-16 02:11:22 +00001109 diag::warn_format_nonliteral_noargs)
Chris Lattner655f1412009-04-29 04:59:47 +00001110 << OrigFormatExpr->getSourceRange();
1111 else
Mike Stump1eb44332009-09-09 15:08:12 +00001112 Diag(TheCall->getArg(format_idx)->getLocStart(),
Ted Kremenek826a3452010-07-16 02:11:22 +00001113 diag::warn_format_nonliteral)
Chris Lattner655f1412009-04-29 04:59:47 +00001114 << OrigFormatExpr->getSourceRange();
Ted Kremenekd30ef872009-01-12 23:09:09 +00001115}
Ted Kremenek71895b92007-08-14 17:39:48 +00001116
Ted Kremeneke0e53132010-01-28 23:39:18 +00001117namespace {
Ted Kremenek826a3452010-07-16 02:11:22 +00001118class CheckFormatHandler : public analyze_format_string::FormatStringHandler {
1119protected:
Ted Kremeneke0e53132010-01-28 23:39:18 +00001120 Sema &S;
1121 const StringLiteral *FExpr;
1122 const Expr *OrigFormatExpr;
Ted Kremenek6ee76532010-03-25 03:59:12 +00001123 const unsigned FirstDataArg;
Ted Kremeneke0e53132010-01-28 23:39:18 +00001124 const unsigned NumDataArgs;
1125 const bool IsObjCLiteral;
1126 const char *Beg; // Start of format string.
Ted Kremenek0d277352010-01-29 01:06:55 +00001127 const bool HasVAListArg;
1128 const CallExpr *TheCall;
1129 unsigned FormatIdx;
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001130 llvm::BitVector CoveredArgs;
Ted Kremenekefaff192010-02-27 01:41:03 +00001131 bool usesPositionalArgs;
1132 bool atFirstArg;
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001133public:
Ted Kremenek826a3452010-07-16 02:11:22 +00001134 CheckFormatHandler(Sema &s, const StringLiteral *fexpr,
Ted Kremenek6ee76532010-03-25 03:59:12 +00001135 const Expr *origFormatExpr, unsigned firstDataArg,
Ted Kremeneke0e53132010-01-28 23:39:18 +00001136 unsigned numDataArgs, bool isObjCLiteral,
Ted Kremenek0d277352010-01-29 01:06:55 +00001137 const char *beg, bool hasVAListArg,
1138 const CallExpr *theCall, unsigned formatIdx)
Ted Kremeneke0e53132010-01-28 23:39:18 +00001139 : S(s), FExpr(fexpr), OrigFormatExpr(origFormatExpr),
Ted Kremenek6ee76532010-03-25 03:59:12 +00001140 FirstDataArg(firstDataArg),
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001141 NumDataArgs(numDataArgs),
Ted Kremenek0d277352010-01-29 01:06:55 +00001142 IsObjCLiteral(isObjCLiteral), Beg(beg),
1143 HasVAListArg(hasVAListArg),
Ted Kremenekefaff192010-02-27 01:41:03 +00001144 TheCall(theCall), FormatIdx(formatIdx),
1145 usesPositionalArgs(false), atFirstArg(true) {
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001146 CoveredArgs.resize(numDataArgs);
1147 CoveredArgs.reset();
1148 }
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001149
Ted Kremenek07d161f2010-01-29 01:50:07 +00001150 void DoneProcessing();
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001151
Ted Kremenek826a3452010-07-16 02:11:22 +00001152 void HandleIncompleteSpecifier(const char *startSpecifier,
1153 unsigned specifierLen);
1154
Ted Kremenekefaff192010-02-27 01:41:03 +00001155 virtual void HandleInvalidPosition(const char *startSpecifier,
1156 unsigned specifierLen,
Ted Kremenek826a3452010-07-16 02:11:22 +00001157 analyze_format_string::PositionContext p);
Ted Kremenekefaff192010-02-27 01:41:03 +00001158
1159 virtual void HandleZeroPosition(const char *startPos, unsigned posLen);
1160
Ted Kremeneke0e53132010-01-28 23:39:18 +00001161 void HandleNullChar(const char *nullCharacter);
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001162
Ted Kremenek826a3452010-07-16 02:11:22 +00001163protected:
Ted Kremenekc09b6a52010-07-19 21:25:57 +00001164 bool HandleInvalidConversionSpecifier(unsigned argIndex, SourceLocation Loc,
1165 const char *startSpec,
1166 unsigned specifierLen,
1167 const char *csStart, unsigned csLen);
1168
Ted Kremenekf88c8e02010-01-29 20:55:36 +00001169 SourceRange getFormatStringRange();
Ted Kremenek826a3452010-07-16 02:11:22 +00001170 CharSourceRange getSpecifierRange(const char *startSpecifier,
1171 unsigned specifierLen);
Ted Kremeneke0e53132010-01-28 23:39:18 +00001172 SourceLocation getLocationOfByte(const char *x);
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001173
Ted Kremenek0d277352010-01-29 01:06:55 +00001174 const Expr *getDataArg(unsigned i) const;
Ted Kremenek666a1972010-07-26 19:45:42 +00001175
1176 bool CheckNumArgs(const analyze_format_string::FormatSpecifier &FS,
1177 const analyze_format_string::ConversionSpecifier &CS,
1178 const char *startSpecifier, unsigned specifierLen,
1179 unsigned argIndex);
Ted Kremeneke0e53132010-01-28 23:39:18 +00001180};
1181}
1182
Ted Kremenek826a3452010-07-16 02:11:22 +00001183SourceRange CheckFormatHandler::getFormatStringRange() {
Ted Kremeneke0e53132010-01-28 23:39:18 +00001184 return OrigFormatExpr->getSourceRange();
1185}
1186
Ted Kremenek826a3452010-07-16 02:11:22 +00001187CharSourceRange CheckFormatHandler::
1188getSpecifierRange(const char *startSpecifier, unsigned specifierLen) {
Tom Care45f9b7e2010-06-21 21:21:01 +00001189 SourceLocation Start = getLocationOfByte(startSpecifier);
1190 SourceLocation End = getLocationOfByte(startSpecifier + specifierLen - 1);
1191
1192 // Advance the end SourceLocation by one due to half-open ranges.
1193 End = End.getFileLocWithOffset(1);
1194
1195 return CharSourceRange::getCharRange(Start, End);
Ted Kremenekf88c8e02010-01-29 20:55:36 +00001196}
1197
Ted Kremenek826a3452010-07-16 02:11:22 +00001198SourceLocation CheckFormatHandler::getLocationOfByte(const char *x) {
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001199 return S.getLocationOfStringLiteralByte(FExpr, x - Beg);
Ted Kremeneke0e53132010-01-28 23:39:18 +00001200}
1201
Ted Kremenek826a3452010-07-16 02:11:22 +00001202void CheckFormatHandler::HandleIncompleteSpecifier(const char *startSpecifier,
1203 unsigned specifierLen){
Ted Kremenek808015a2010-01-29 03:16:21 +00001204 SourceLocation Loc = getLocationOfByte(startSpecifier);
1205 S.Diag(Loc, diag::warn_printf_incomplete_specifier)
Ted Kremenek826a3452010-07-16 02:11:22 +00001206 << getSpecifierRange(startSpecifier, specifierLen);
Ted Kremenek808015a2010-01-29 03:16:21 +00001207}
1208
Ted Kremenekefaff192010-02-27 01:41:03 +00001209void
Ted Kremenek826a3452010-07-16 02:11:22 +00001210CheckFormatHandler::HandleInvalidPosition(const char *startPos, unsigned posLen,
1211 analyze_format_string::PositionContext p) {
Ted Kremenekefaff192010-02-27 01:41:03 +00001212 SourceLocation Loc = getLocationOfByte(startPos);
Ted Kremenek826a3452010-07-16 02:11:22 +00001213 S.Diag(Loc, diag::warn_format_invalid_positional_specifier)
1214 << (unsigned) p << getSpecifierRange(startPos, posLen);
Ted Kremenekefaff192010-02-27 01:41:03 +00001215}
1216
Ted Kremenek826a3452010-07-16 02:11:22 +00001217void CheckFormatHandler::HandleZeroPosition(const char *startPos,
Ted Kremenekefaff192010-02-27 01:41:03 +00001218 unsigned posLen) {
1219 SourceLocation Loc = getLocationOfByte(startPos);
Ted Kremenek826a3452010-07-16 02:11:22 +00001220 S.Diag(Loc, diag::warn_format_zero_positional_specifier)
1221 << getSpecifierRange(startPos, posLen);
Ted Kremenekefaff192010-02-27 01:41:03 +00001222}
1223
Ted Kremenek826a3452010-07-16 02:11:22 +00001224void CheckFormatHandler::HandleNullChar(const char *nullCharacter) {
1225 // The presence of a null character is likely an error.
1226 S.Diag(getLocationOfByte(nullCharacter),
1227 diag::warn_printf_format_string_contains_null_char)
1228 << getFormatStringRange();
1229}
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001230
Ted Kremenek826a3452010-07-16 02:11:22 +00001231const Expr *CheckFormatHandler::getDataArg(unsigned i) const {
1232 return TheCall->getArg(FirstDataArg + i);
1233}
1234
1235void CheckFormatHandler::DoneProcessing() {
1236 // Does the number of data arguments exceed the number of
1237 // format conversions in the format string?
1238 if (!HasVAListArg) {
1239 // Find any arguments that weren't covered.
1240 CoveredArgs.flip();
1241 signed notCoveredArg = CoveredArgs.find_first();
1242 if (notCoveredArg >= 0) {
1243 assert((unsigned)notCoveredArg < NumDataArgs);
1244 S.Diag(getDataArg((unsigned) notCoveredArg)->getLocStart(),
1245 diag::warn_printf_data_arg_not_used)
1246 << getFormatStringRange();
1247 }
1248 }
1249}
1250
Ted Kremenekc09b6a52010-07-19 21:25:57 +00001251bool
1252CheckFormatHandler::HandleInvalidConversionSpecifier(unsigned argIndex,
1253 SourceLocation Loc,
1254 const char *startSpec,
1255 unsigned specifierLen,
1256 const char *csStart,
1257 unsigned csLen) {
1258
1259 bool keepGoing = true;
1260 if (argIndex < NumDataArgs) {
1261 // Consider the argument coverered, even though the specifier doesn't
1262 // make sense.
1263 CoveredArgs.set(argIndex);
1264 }
1265 else {
1266 // If argIndex exceeds the number of data arguments we
1267 // don't issue a warning because that is just a cascade of warnings (and
1268 // they may have intended '%%' anyway). We don't want to continue processing
1269 // the format string after this point, however, as we will like just get
1270 // gibberish when trying to match arguments.
1271 keepGoing = false;
1272 }
1273
1274 S.Diag(Loc, diag::warn_format_invalid_conversion)
1275 << llvm::StringRef(csStart, csLen)
1276 << getSpecifierRange(startSpec, specifierLen);
1277
1278 return keepGoing;
1279}
1280
Ted Kremenek666a1972010-07-26 19:45:42 +00001281bool
1282CheckFormatHandler::CheckNumArgs(
1283 const analyze_format_string::FormatSpecifier &FS,
1284 const analyze_format_string::ConversionSpecifier &CS,
1285 const char *startSpecifier, unsigned specifierLen, unsigned argIndex) {
1286
1287 if (argIndex >= NumDataArgs) {
1288 if (FS.usesPositionalArg()) {
1289 S.Diag(getLocationOfByte(CS.getStart()),
1290 diag::warn_printf_positional_arg_exceeds_data_args)
1291 << (argIndex+1) << NumDataArgs
1292 << getSpecifierRange(startSpecifier, specifierLen);
1293 }
1294 else {
1295 S.Diag(getLocationOfByte(CS.getStart()),
1296 diag::warn_printf_insufficient_data_args)
1297 << getSpecifierRange(startSpecifier, specifierLen);
1298 }
1299
1300 return false;
1301 }
1302 return true;
1303}
1304
Ted Kremenek826a3452010-07-16 02:11:22 +00001305//===--- CHECK: Printf format string checking ------------------------------===//
1306
1307namespace {
1308class CheckPrintfHandler : public CheckFormatHandler {
1309public:
1310 CheckPrintfHandler(Sema &s, const StringLiteral *fexpr,
1311 const Expr *origFormatExpr, unsigned firstDataArg,
1312 unsigned numDataArgs, bool isObjCLiteral,
1313 const char *beg, bool hasVAListArg,
1314 const CallExpr *theCall, unsigned formatIdx)
1315 : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg,
1316 numDataArgs, isObjCLiteral, beg, hasVAListArg,
1317 theCall, formatIdx) {}
1318
1319
1320 bool HandleInvalidPrintfConversionSpecifier(
1321 const analyze_printf::PrintfSpecifier &FS,
1322 const char *startSpecifier,
1323 unsigned specifierLen);
1324
1325 bool HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier &FS,
1326 const char *startSpecifier,
1327 unsigned specifierLen);
1328
1329 bool HandleAmount(const analyze_format_string::OptionalAmount &Amt, unsigned k,
1330 const char *startSpecifier, unsigned specifierLen);
1331 void HandleInvalidAmount(const analyze_printf::PrintfSpecifier &FS,
1332 const analyze_printf::OptionalAmount &Amt,
1333 unsigned type,
1334 const char *startSpecifier, unsigned specifierLen);
1335 void HandleFlag(const analyze_printf::PrintfSpecifier &FS,
1336 const analyze_printf::OptionalFlag &flag,
1337 const char *startSpecifier, unsigned specifierLen);
1338 void HandleIgnoredFlag(const analyze_printf::PrintfSpecifier &FS,
1339 const analyze_printf::OptionalFlag &ignoredFlag,
1340 const analyze_printf::OptionalFlag &flag,
1341 const char *startSpecifier, unsigned specifierLen);
1342};
1343}
1344
1345bool CheckPrintfHandler::HandleInvalidPrintfConversionSpecifier(
1346 const analyze_printf::PrintfSpecifier &FS,
1347 const char *startSpecifier,
1348 unsigned specifierLen) {
Ted Kremenek6ecb9502010-07-20 20:04:27 +00001349 const analyze_printf::PrintfConversionSpecifier &CS =
Ted Kremenekc09b6a52010-07-19 21:25:57 +00001350 FS.getConversionSpecifier();
Ted Kremenek826a3452010-07-16 02:11:22 +00001351
Ted Kremenekc09b6a52010-07-19 21:25:57 +00001352 return HandleInvalidConversionSpecifier(FS.getArgIndex(),
1353 getLocationOfByte(CS.getStart()),
1354 startSpecifier, specifierLen,
1355 CS.getStart(), CS.getLength());
Ted Kremenek26ac2e02010-01-29 02:40:24 +00001356}
1357
Ted Kremenek826a3452010-07-16 02:11:22 +00001358bool CheckPrintfHandler::HandleAmount(
1359 const analyze_format_string::OptionalAmount &Amt,
1360 unsigned k, const char *startSpecifier,
1361 unsigned specifierLen) {
Ted Kremenek0d277352010-01-29 01:06:55 +00001362
1363 if (Amt.hasDataArgument()) {
Ted Kremenek0d277352010-01-29 01:06:55 +00001364 if (!HasVAListArg) {
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001365 unsigned argIndex = Amt.getArgIndex();
1366 if (argIndex >= NumDataArgs) {
Ted Kremenekefaff192010-02-27 01:41:03 +00001367 S.Diag(getLocationOfByte(Amt.getStart()),
1368 diag::warn_printf_asterisk_missing_arg)
Ted Kremenek826a3452010-07-16 02:11:22 +00001369 << k << getSpecifierRange(startSpecifier, specifierLen);
Ted Kremenek0d277352010-01-29 01:06:55 +00001370 // Don't do any more checking. We will just emit
1371 // spurious errors.
1372 return false;
1373 }
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001374
Ted Kremenek0d277352010-01-29 01:06:55 +00001375 // Type check the data argument. It should be an 'int'.
Ted Kremenek31f8e322010-01-29 23:32:22 +00001376 // Although not in conformance with C99, we also allow the argument to be
1377 // an 'unsigned int' as that is a reasonably safe case. GCC also
1378 // doesn't emit a warning for that case.
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001379 CoveredArgs.set(argIndex);
1380 const Expr *Arg = getDataArg(argIndex);
Ted Kremenek0d277352010-01-29 01:06:55 +00001381 QualType T = Arg->getType();
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001382
1383 const analyze_printf::ArgTypeResult &ATR = Amt.getArgType(S.Context);
1384 assert(ATR.isValid());
1385
1386 if (!ATR.matchesType(S.Context, T)) {
Ted Kremenekefaff192010-02-27 01:41:03 +00001387 S.Diag(getLocationOfByte(Amt.getStart()),
1388 diag::warn_printf_asterisk_wrong_type)
1389 << k
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001390 << ATR.getRepresentativeType(S.Context) << T
Ted Kremenek826a3452010-07-16 02:11:22 +00001391 << getSpecifierRange(startSpecifier, specifierLen)
Ted Kremenekd635c5f2010-01-30 00:49:51 +00001392 << Arg->getSourceRange();
Ted Kremenek0d277352010-01-29 01:06:55 +00001393 // Don't do any more checking. We will just emit
1394 // spurious errors.
1395 return false;
1396 }
1397 }
1398 }
1399 return true;
1400}
Ted Kremenek0d277352010-01-29 01:06:55 +00001401
Tom Caree4ee9662010-06-17 19:00:27 +00001402void CheckPrintfHandler::HandleInvalidAmount(
Ted Kremenek826a3452010-07-16 02:11:22 +00001403 const analyze_printf::PrintfSpecifier &FS,
Tom Caree4ee9662010-06-17 19:00:27 +00001404 const analyze_printf::OptionalAmount &Amt,
1405 unsigned type,
1406 const char *startSpecifier,
1407 unsigned specifierLen) {
Ted Kremenek6ecb9502010-07-20 20:04:27 +00001408 const analyze_printf::PrintfConversionSpecifier &CS =
1409 FS.getConversionSpecifier();
Tom Caree4ee9662010-06-17 19:00:27 +00001410 switch (Amt.getHowSpecified()) {
1411 case analyze_printf::OptionalAmount::Constant:
1412 S.Diag(getLocationOfByte(Amt.getStart()),
1413 diag::warn_printf_nonsensical_optional_amount)
1414 << type
1415 << CS.toString()
Ted Kremenek826a3452010-07-16 02:11:22 +00001416 << getSpecifierRange(startSpecifier, specifierLen)
1417 << FixItHint::CreateRemoval(getSpecifierRange(Amt.getStart(),
Tom Caree4ee9662010-06-17 19:00:27 +00001418 Amt.getConstantLength()));
1419 break;
1420
1421 default:
1422 S.Diag(getLocationOfByte(Amt.getStart()),
1423 diag::warn_printf_nonsensical_optional_amount)
1424 << type
1425 << CS.toString()
Ted Kremenek826a3452010-07-16 02:11:22 +00001426 << getSpecifierRange(startSpecifier, specifierLen);
Tom Caree4ee9662010-06-17 19:00:27 +00001427 break;
1428 }
1429}
1430
Ted Kremenek826a3452010-07-16 02:11:22 +00001431void CheckPrintfHandler::HandleFlag(const analyze_printf::PrintfSpecifier &FS,
Tom Caree4ee9662010-06-17 19:00:27 +00001432 const analyze_printf::OptionalFlag &flag,
1433 const char *startSpecifier,
1434 unsigned specifierLen) {
1435 // Warn about pointless flag with a fixit removal.
Ted Kremenek6ecb9502010-07-20 20:04:27 +00001436 const analyze_printf::PrintfConversionSpecifier &CS =
1437 FS.getConversionSpecifier();
Tom Caree4ee9662010-06-17 19:00:27 +00001438 S.Diag(getLocationOfByte(flag.getPosition()),
1439 diag::warn_printf_nonsensical_flag)
1440 << flag.toString() << CS.toString()
Ted Kremenek826a3452010-07-16 02:11:22 +00001441 << getSpecifierRange(startSpecifier, specifierLen)
1442 << FixItHint::CreateRemoval(getSpecifierRange(flag.getPosition(), 1));
Tom Caree4ee9662010-06-17 19:00:27 +00001443}
1444
1445void CheckPrintfHandler::HandleIgnoredFlag(
Ted Kremenek826a3452010-07-16 02:11:22 +00001446 const analyze_printf::PrintfSpecifier &FS,
Tom Caree4ee9662010-06-17 19:00:27 +00001447 const analyze_printf::OptionalFlag &ignoredFlag,
1448 const analyze_printf::OptionalFlag &flag,
1449 const char *startSpecifier,
1450 unsigned specifierLen) {
1451 // Warn about ignored flag with a fixit removal.
1452 S.Diag(getLocationOfByte(ignoredFlag.getPosition()),
1453 diag::warn_printf_ignored_flag)
1454 << ignoredFlag.toString() << flag.toString()
Ted Kremenek826a3452010-07-16 02:11:22 +00001455 << getSpecifierRange(startSpecifier, specifierLen)
1456 << FixItHint::CreateRemoval(getSpecifierRange(
Tom Caree4ee9662010-06-17 19:00:27 +00001457 ignoredFlag.getPosition(), 1));
1458}
1459
Ted Kremeneke0e53132010-01-28 23:39:18 +00001460bool
Ted Kremenek826a3452010-07-16 02:11:22 +00001461CheckPrintfHandler::HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier
Ted Kremenek5c41ee82010-02-11 09:27:41 +00001462 &FS,
Ted Kremeneke0e53132010-01-28 23:39:18 +00001463 const char *startSpecifier,
1464 unsigned specifierLen) {
1465
Ted Kremenek6ecb9502010-07-20 20:04:27 +00001466 using namespace analyze_format_string;
Ted Kremenekefaff192010-02-27 01:41:03 +00001467 using namespace analyze_printf;
Ted Kremenek6ecb9502010-07-20 20:04:27 +00001468 const PrintfConversionSpecifier &CS = FS.getConversionSpecifier();
Ted Kremeneke0e53132010-01-28 23:39:18 +00001469
Ted Kremenekbaa40062010-07-19 22:01:06 +00001470 if (FS.consumesDataArgument()) {
1471 if (atFirstArg) {
1472 atFirstArg = false;
1473 usesPositionalArgs = FS.usesPositionalArg();
1474 }
1475 else if (usesPositionalArgs != FS.usesPositionalArg()) {
1476 // Cannot mix-and-match positional and non-positional arguments.
1477 S.Diag(getLocationOfByte(CS.getStart()),
1478 diag::warn_format_mix_positional_nonpositional_args)
1479 << getSpecifierRange(startSpecifier, specifierLen);
1480 return false;
1481 }
Ted Kremenek0d277352010-01-29 01:06:55 +00001482 }
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001483
Ted Kremenekefaff192010-02-27 01:41:03 +00001484 // First check if the field width, precision, and conversion specifier
1485 // have matching data arguments.
1486 if (!HandleAmount(FS.getFieldWidth(), /* field width */ 0,
1487 startSpecifier, specifierLen)) {
1488 return false;
1489 }
1490
1491 if (!HandleAmount(FS.getPrecision(), /* precision */ 1,
1492 startSpecifier, specifierLen)) {
Ted Kremenek0d277352010-01-29 01:06:55 +00001493 return false;
1494 }
1495
Ted Kremenekf88c8e02010-01-29 20:55:36 +00001496 if (!CS.consumesDataArgument()) {
1497 // FIXME: Technically specifying a precision or field width here
1498 // makes no sense. Worth issuing a warning at some point.
Ted Kremenek0e5675d2010-02-10 02:16:30 +00001499 return true;
Ted Kremenekf88c8e02010-01-29 20:55:36 +00001500 }
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001501
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001502 // Consume the argument.
1503 unsigned argIndex = FS.getArgIndex();
Ted Kremeneke3fc5472010-02-27 08:34:51 +00001504 if (argIndex < NumDataArgs) {
1505 // The check to see if the argIndex is valid will come later.
1506 // We set the bit here because we may exit early from this
1507 // function if we encounter some other error.
1508 CoveredArgs.set(argIndex);
1509 }
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001510
1511 // Check for using an Objective-C specific conversion specifier
1512 // in a non-ObjC literal.
1513 if (!IsObjCLiteral && CS.isObjCArg()) {
Ted Kremenek826a3452010-07-16 02:11:22 +00001514 return HandleInvalidPrintfConversionSpecifier(FS, startSpecifier,
1515 specifierLen);
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001516 }
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001517
Tom Caree4ee9662010-06-17 19:00:27 +00001518 // Check for invalid use of field width
1519 if (!FS.hasValidFieldWidth()) {
Tom Care45f9b7e2010-06-21 21:21:01 +00001520 HandleInvalidAmount(FS, FS.getFieldWidth(), /* field width */ 0,
Tom Caree4ee9662010-06-17 19:00:27 +00001521 startSpecifier, specifierLen);
1522 }
1523
1524 // Check for invalid use of precision
1525 if (!FS.hasValidPrecision()) {
1526 HandleInvalidAmount(FS, FS.getPrecision(), /* precision */ 1,
1527 startSpecifier, specifierLen);
1528 }
1529
1530 // Check each flag does not conflict with any other component.
1531 if (!FS.hasValidLeadingZeros())
1532 HandleFlag(FS, FS.hasLeadingZeros(), startSpecifier, specifierLen);
1533 if (!FS.hasValidPlusPrefix())
1534 HandleFlag(FS, FS.hasPlusPrefix(), startSpecifier, specifierLen);
Tom Care45f9b7e2010-06-21 21:21:01 +00001535 if (!FS.hasValidSpacePrefix())
1536 HandleFlag(FS, FS.hasSpacePrefix(), startSpecifier, specifierLen);
Tom Caree4ee9662010-06-17 19:00:27 +00001537 if (!FS.hasValidAlternativeForm())
1538 HandleFlag(FS, FS.hasAlternativeForm(), startSpecifier, specifierLen);
1539 if (!FS.hasValidLeftJustified())
1540 HandleFlag(FS, FS.isLeftJustified(), startSpecifier, specifierLen);
1541
1542 // Check that flags are not ignored by another flag
Tom Care45f9b7e2010-06-21 21:21:01 +00001543 if (FS.hasSpacePrefix() && FS.hasPlusPrefix()) // ' ' ignored by '+'
1544 HandleIgnoredFlag(FS, FS.hasSpacePrefix(), FS.hasPlusPrefix(),
1545 startSpecifier, specifierLen);
Tom Caree4ee9662010-06-17 19:00:27 +00001546 if (FS.hasLeadingZeros() && FS.isLeftJustified()) // '0' ignored by '-'
1547 HandleIgnoredFlag(FS, FS.hasLeadingZeros(), FS.isLeftJustified(),
1548 startSpecifier, specifierLen);
1549
1550 // Check the length modifier is valid with the given conversion specifier.
1551 const LengthModifier &LM = FS.getLengthModifier();
1552 if (!FS.hasValidLengthModifier())
1553 S.Diag(getLocationOfByte(LM.getStart()),
Ted Kremenek649aecf2010-07-20 20:03:43 +00001554 diag::warn_format_nonsensical_length)
Tom Caree4ee9662010-06-17 19:00:27 +00001555 << LM.toString() << CS.toString()
Ted Kremenek826a3452010-07-16 02:11:22 +00001556 << getSpecifierRange(startSpecifier, specifierLen)
1557 << FixItHint::CreateRemoval(getSpecifierRange(LM.getStart(),
Tom Caree4ee9662010-06-17 19:00:27 +00001558 LM.getLength()));
1559
1560 // Are we using '%n'?
Ted Kremenek35d353b2010-07-20 20:04:10 +00001561 if (CS.getKind() == ConversionSpecifier::nArg) {
Tom Caree4ee9662010-06-17 19:00:27 +00001562 // Issue a warning about this being a possible security issue.
Ted Kremeneke82d8042010-01-29 01:35:25 +00001563 S.Diag(getLocationOfByte(CS.getStart()), diag::warn_printf_write_back)
Ted Kremenek826a3452010-07-16 02:11:22 +00001564 << getSpecifierRange(startSpecifier, specifierLen);
Ted Kremeneke82d8042010-01-29 01:35:25 +00001565 // Continue checking the other format specifiers.
1566 return true;
1567 }
Ted Kremenek5c41ee82010-02-11 09:27:41 +00001568
Ted Kremenekda51f0d2010-01-29 01:43:31 +00001569 // The remaining checks depend on the data arguments.
1570 if (HasVAListArg)
1571 return true;
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001572
Ted Kremenek666a1972010-07-26 19:45:42 +00001573 if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex))
Ted Kremenekda51f0d2010-01-29 01:43:31 +00001574 return false;
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001575
Michael J. Spencer96827eb2010-07-27 04:46:02 +00001576 // Now type check the data expression that matches the
1577 // format specifier.
1578 const Expr *Ex = getDataArg(argIndex);
1579 const analyze_printf::ArgTypeResult &ATR = FS.getArgType(S.Context);
1580 if (ATR.isValid() && !ATR.matchesType(S.Context, Ex->getType())) {
1581 // Check if we didn't match because of an implicit cast from a 'char'
1582 // or 'short' to an 'int'. This is done because printf is a varargs
1583 // function.
1584 if (const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Ex))
1585 if (ICE->getType() == S.Context.IntTy)
1586 if (ATR.matchesType(S.Context, ICE->getSubExpr()->getType()))
1587 return true;
1588
1589 // We may be able to offer a FixItHint if it is a supported type.
1590 PrintfSpecifier fixedFS = FS;
1591 bool success = fixedFS.fixType(Ex->getType());
1592
1593 if (success) {
1594 // Get the fix string from the fixed format specifier
1595 llvm::SmallString<128> buf;
1596 llvm::raw_svector_ostream os(buf);
1597 fixedFS.toString(os);
1598
1599 S.Diag(getLocationOfByte(CS.getStart()),
1600 diag::warn_printf_conversion_argument_type_mismatch)
1601 << ATR.getRepresentativeType(S.Context) << Ex->getType()
1602 << getSpecifierRange(startSpecifier, specifierLen)
1603 << Ex->getSourceRange()
1604 << FixItHint::CreateReplacement(
1605 getSpecifierRange(startSpecifier, specifierLen),
1606 os.str());
1607 }
1608 else {
1609 S.Diag(getLocationOfByte(CS.getStart()),
1610 diag::warn_printf_conversion_argument_type_mismatch)
1611 << ATR.getRepresentativeType(S.Context) << Ex->getType()
1612 << getSpecifierRange(startSpecifier, specifierLen)
1613 << Ex->getSourceRange();
1614 }
1615 }
1616
Ted Kremeneke0e53132010-01-28 23:39:18 +00001617 return true;
1618}
1619
Ted Kremenek826a3452010-07-16 02:11:22 +00001620//===--- CHECK: Scanf format string checking ------------------------------===//
1621
1622namespace {
1623class CheckScanfHandler : public CheckFormatHandler {
1624public:
1625 CheckScanfHandler(Sema &s, const StringLiteral *fexpr,
1626 const Expr *origFormatExpr, unsigned firstDataArg,
1627 unsigned numDataArgs, bool isObjCLiteral,
1628 const char *beg, bool hasVAListArg,
1629 const CallExpr *theCall, unsigned formatIdx)
1630 : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg,
1631 numDataArgs, isObjCLiteral, beg, hasVAListArg,
1632 theCall, formatIdx) {}
1633
1634 bool HandleScanfSpecifier(const analyze_scanf::ScanfSpecifier &FS,
1635 const char *startSpecifier,
1636 unsigned specifierLen);
Ted Kremenekc09b6a52010-07-19 21:25:57 +00001637
1638 bool HandleInvalidScanfConversionSpecifier(
1639 const analyze_scanf::ScanfSpecifier &FS,
1640 const char *startSpecifier,
1641 unsigned specifierLen);
Ted Kremenekb7c21012010-07-16 18:28:03 +00001642
1643 void HandleIncompleteScanList(const char *start, const char *end);
Ted Kremenek826a3452010-07-16 02:11:22 +00001644};
Ted Kremenek07d161f2010-01-29 01:50:07 +00001645}
Ted Kremeneke0e53132010-01-28 23:39:18 +00001646
Ted Kremenekb7c21012010-07-16 18:28:03 +00001647void CheckScanfHandler::HandleIncompleteScanList(const char *start,
1648 const char *end) {
1649 S.Diag(getLocationOfByte(end), diag::warn_scanf_scanlist_incomplete)
1650 << getSpecifierRange(start, end - start);
1651}
1652
Ted Kremenekc09b6a52010-07-19 21:25:57 +00001653bool CheckScanfHandler::HandleInvalidScanfConversionSpecifier(
1654 const analyze_scanf::ScanfSpecifier &FS,
1655 const char *startSpecifier,
1656 unsigned specifierLen) {
1657
Ted Kremenek6ecb9502010-07-20 20:04:27 +00001658 const analyze_scanf::ScanfConversionSpecifier &CS =
Ted Kremenekc09b6a52010-07-19 21:25:57 +00001659 FS.getConversionSpecifier();
1660
1661 return HandleInvalidConversionSpecifier(FS.getArgIndex(),
1662 getLocationOfByte(CS.getStart()),
1663 startSpecifier, specifierLen,
1664 CS.getStart(), CS.getLength());
1665}
1666
Ted Kremenek826a3452010-07-16 02:11:22 +00001667bool CheckScanfHandler::HandleScanfSpecifier(
1668 const analyze_scanf::ScanfSpecifier &FS,
1669 const char *startSpecifier,
1670 unsigned specifierLen) {
1671
1672 using namespace analyze_scanf;
1673 using namespace analyze_format_string;
1674
Ted Kremenek6ecb9502010-07-20 20:04:27 +00001675 const ScanfConversionSpecifier &CS = FS.getConversionSpecifier();
Ted Kremenek826a3452010-07-16 02:11:22 +00001676
Ted Kremenekbaa40062010-07-19 22:01:06 +00001677 // Handle case where '%' and '*' don't consume an argument. These shouldn't
1678 // be used to decide if we are using positional arguments consistently.
1679 if (FS.consumesDataArgument()) {
1680 if (atFirstArg) {
1681 atFirstArg = false;
1682 usesPositionalArgs = FS.usesPositionalArg();
1683 }
1684 else if (usesPositionalArgs != FS.usesPositionalArg()) {
1685 // Cannot mix-and-match positional and non-positional arguments.
1686 S.Diag(getLocationOfByte(CS.getStart()),
1687 diag::warn_format_mix_positional_nonpositional_args)
1688 << getSpecifierRange(startSpecifier, specifierLen);
1689 return false;
1690 }
Ted Kremenek826a3452010-07-16 02:11:22 +00001691 }
1692
1693 // Check if the field with is non-zero.
1694 const OptionalAmount &Amt = FS.getFieldWidth();
1695 if (Amt.getHowSpecified() == OptionalAmount::Constant) {
1696 if (Amt.getConstantAmount() == 0) {
1697 const CharSourceRange &R = getSpecifierRange(Amt.getStart(),
1698 Amt.getConstantLength());
1699 S.Diag(getLocationOfByte(Amt.getStart()),
1700 diag::warn_scanf_nonzero_width)
1701 << R << FixItHint::CreateRemoval(R);
1702 }
1703 }
1704
1705 if (!FS.consumesDataArgument()) {
1706 // FIXME: Technically specifying a precision or field width here
1707 // makes no sense. Worth issuing a warning at some point.
1708 return true;
1709 }
1710
1711 // Consume the argument.
1712 unsigned argIndex = FS.getArgIndex();
1713 if (argIndex < NumDataArgs) {
1714 // The check to see if the argIndex is valid will come later.
1715 // We set the bit here because we may exit early from this
1716 // function if we encounter some other error.
1717 CoveredArgs.set(argIndex);
1718 }
1719
Ted Kremenek1e51c202010-07-20 20:04:47 +00001720 // Check the length modifier is valid with the given conversion specifier.
1721 const LengthModifier &LM = FS.getLengthModifier();
1722 if (!FS.hasValidLengthModifier()) {
1723 S.Diag(getLocationOfByte(LM.getStart()),
1724 diag::warn_format_nonsensical_length)
1725 << LM.toString() << CS.toString()
1726 << getSpecifierRange(startSpecifier, specifierLen)
1727 << FixItHint::CreateRemoval(getSpecifierRange(LM.getStart(),
1728 LM.getLength()));
1729 }
1730
Ted Kremenek826a3452010-07-16 02:11:22 +00001731 // The remaining checks depend on the data arguments.
1732 if (HasVAListArg)
1733 return true;
1734
Ted Kremenek666a1972010-07-26 19:45:42 +00001735 if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex))
Ted Kremenek826a3452010-07-16 02:11:22 +00001736 return false;
Ted Kremenek826a3452010-07-16 02:11:22 +00001737
1738 // FIXME: Check that the argument type matches the format specifier.
1739
1740 return true;
1741}
1742
1743void Sema::CheckFormatString(const StringLiteral *FExpr,
Ted Kremenek0e5675d2010-02-10 02:16:30 +00001744 const Expr *OrigFormatExpr,
1745 const CallExpr *TheCall, bool HasVAListArg,
Ted Kremenek826a3452010-07-16 02:11:22 +00001746 unsigned format_idx, unsigned firstDataArg,
1747 bool isPrintf) {
1748
Ted Kremeneke0e53132010-01-28 23:39:18 +00001749 // CHECK: is the format string a wide literal?
1750 if (FExpr->isWide()) {
1751 Diag(FExpr->getLocStart(),
Ted Kremenek826a3452010-07-16 02:11:22 +00001752 diag::warn_format_string_is_wide_literal)
Ted Kremeneke0e53132010-01-28 23:39:18 +00001753 << OrigFormatExpr->getSourceRange();
1754 return;
1755 }
Ted Kremenek826a3452010-07-16 02:11:22 +00001756
Ted Kremeneke0e53132010-01-28 23:39:18 +00001757 // Str - The format string. NOTE: this is NOT null-terminated!
1758 const char *Str = FExpr->getStrData();
Ted Kremenek826a3452010-07-16 02:11:22 +00001759
Ted Kremeneke0e53132010-01-28 23:39:18 +00001760 // CHECK: empty format string?
1761 unsigned StrLen = FExpr->getByteLength();
Ted Kremenek826a3452010-07-16 02:11:22 +00001762
Ted Kremeneke0e53132010-01-28 23:39:18 +00001763 if (StrLen == 0) {
Ted Kremenek826a3452010-07-16 02:11:22 +00001764 Diag(FExpr->getLocStart(), diag::warn_empty_format_string)
Ted Kremeneke0e53132010-01-28 23:39:18 +00001765 << OrigFormatExpr->getSourceRange();
1766 return;
1767 }
Ted Kremenek826a3452010-07-16 02:11:22 +00001768
1769 if (isPrintf) {
1770 CheckPrintfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg,
1771 TheCall->getNumArgs() - firstDataArg,
1772 isa<ObjCStringLiteral>(OrigFormatExpr), Str,
1773 HasVAListArg, TheCall, format_idx);
1774
1775 if (!analyze_format_string::ParsePrintfString(H, Str, Str + StrLen))
1776 H.DoneProcessing();
1777 }
1778 else {
1779 CheckScanfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg,
1780 TheCall->getNumArgs() - firstDataArg,
1781 isa<ObjCStringLiteral>(OrigFormatExpr), Str,
1782 HasVAListArg, TheCall, format_idx);
1783
1784 if (!analyze_format_string::ParseScanfString(H, Str, Str + StrLen))
1785 H.DoneProcessing();
1786 }
Ted Kremenekce7024e2010-01-28 01:18:22 +00001787}
1788
Ted Kremenek06de2762007-08-17 16:46:58 +00001789//===--- CHECK: Return Address of Stack Variable --------------------------===//
1790
1791static DeclRefExpr* EvalVal(Expr *E);
1792static DeclRefExpr* EvalAddr(Expr* E);
1793
1794/// CheckReturnStackAddr - Check if a return statement returns the address
1795/// of a stack variable.
1796void
1797Sema::CheckReturnStackAddr(Expr *RetValExp, QualType lhsType,
1798 SourceLocation ReturnLoc) {
Mike Stump1eb44332009-09-09 15:08:12 +00001799
Ted Kremenek06de2762007-08-17 16:46:58 +00001800 // Perform checking for returned stack addresses.
Steve Naroffdd972f22008-09-05 22:11:13 +00001801 if (lhsType->isPointerType() || lhsType->isBlockPointerType()) {
Ted Kremenek06de2762007-08-17 16:46:58 +00001802 if (DeclRefExpr *DR = EvalAddr(RetValExp))
Chris Lattner3c73c412008-11-19 08:23:25 +00001803 Diag(DR->getLocStart(), diag::warn_ret_stack_addr)
Chris Lattner08631c52008-11-23 21:45:46 +00001804 << DR->getDecl()->getDeclName() << RetValExp->getSourceRange();
Mike Stump1eb44332009-09-09 15:08:12 +00001805
Steve Naroffc50a4a52008-09-16 22:25:10 +00001806 // Skip over implicit cast expressions when checking for block expressions.
Chris Lattner4ca606e2009-09-08 00:36:37 +00001807 RetValExp = RetValExp->IgnoreParenCasts();
Steve Naroffc50a4a52008-09-16 22:25:10 +00001808
Chris Lattner9e6b37a2009-10-30 04:01:58 +00001809 if (BlockExpr *C = dyn_cast<BlockExpr>(RetValExp))
Mike Stump397195b2009-04-17 00:09:41 +00001810 if (C->hasBlockDeclRefExprs())
1811 Diag(C->getLocStart(), diag::err_ret_local_block)
1812 << C->getSourceRange();
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001813
Chris Lattner9e6b37a2009-10-30 04:01:58 +00001814 if (AddrLabelExpr *ALE = dyn_cast<AddrLabelExpr>(RetValExp))
1815 Diag(ALE->getLocStart(), diag::warn_ret_addr_label)
1816 << ALE->getSourceRange();
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001817
Mike Stumpac5fc7c2009-08-04 21:02:39 +00001818 } else if (lhsType->isReferenceType()) {
1819 // Perform checking for stack values returned by reference.
Douglas Gregor49badde2008-10-27 19:41:14 +00001820 // Check for a reference to the stack
1821 if (DeclRefExpr *DR = EvalVal(RetValExp))
Chris Lattnerdcd5ef12008-11-19 05:27:50 +00001822 Diag(DR->getLocStart(), diag::warn_ret_stack_ref)
Chris Lattner08631c52008-11-23 21:45:46 +00001823 << DR->getDecl()->getDeclName() << RetValExp->getSourceRange();
Ted Kremenek06de2762007-08-17 16:46:58 +00001824 }
1825}
1826
1827/// EvalAddr - EvalAddr and EvalVal are mutually recursive functions that
1828/// check if the expression in a return statement evaluates to an address
1829/// to a location on the stack. The recursion is used to traverse the
1830/// AST of the return expression, with recursion backtracking when we
1831/// encounter a subexpression that (1) clearly does not lead to the address
1832/// of a stack variable or (2) is something we cannot determine leads to
1833/// the address of a stack variable based on such local checking.
1834///
Ted Kremeneke8c600f2007-08-28 17:02:55 +00001835/// EvalAddr processes expressions that are pointers that are used as
1836/// references (and not L-values). EvalVal handles all other values.
Mike Stump1eb44332009-09-09 15:08:12 +00001837/// At the base case of the recursion is a check for a DeclRefExpr* in
Ted Kremenek06de2762007-08-17 16:46:58 +00001838/// the refers to a stack variable.
1839///
1840/// This implementation handles:
1841///
1842/// * pointer-to-pointer casts
1843/// * implicit conversions from array references to pointers
1844/// * taking the address of fields
1845/// * arbitrary interplay between "&" and "*" operators
1846/// * pointer arithmetic from an address of a stack variable
1847/// * taking the address of an array element where the array is on the stack
1848static DeclRefExpr* EvalAddr(Expr *E) {
Ted Kremenek06de2762007-08-17 16:46:58 +00001849 // We should only be called for evaluating pointer expressions.
David Chisnall0f436562009-08-17 16:35:33 +00001850 assert((E->getType()->isAnyPointerType() ||
Steve Naroffdd972f22008-09-05 22:11:13 +00001851 E->getType()->isBlockPointerType() ||
Ted Kremeneka526c5c2008-01-07 19:49:32 +00001852 E->getType()->isObjCQualifiedIdType()) &&
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001853 "EvalAddr only works on pointers");
Mike Stump1eb44332009-09-09 15:08:12 +00001854
Ted Kremenek06de2762007-08-17 16:46:58 +00001855 // Our "symbolic interpreter" is just a dispatch off the currently
1856 // viewed AST node. We then recursively traverse the AST by calling
1857 // EvalAddr and EvalVal appropriately.
1858 switch (E->getStmtClass()) {
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001859 case Stmt::ParenExprClass:
1860 // Ignore parentheses.
1861 return EvalAddr(cast<ParenExpr>(E)->getSubExpr());
Ted Kremenek06de2762007-08-17 16:46:58 +00001862
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001863 case Stmt::UnaryOperatorClass: {
1864 // The only unary operator that make sense to handle here
1865 // is AddrOf. All others don't make sense as pointers.
1866 UnaryOperator *U = cast<UnaryOperator>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00001867
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001868 if (U->getOpcode() == UnaryOperator::AddrOf)
1869 return EvalVal(U->getSubExpr());
1870 else
Ted Kremenek06de2762007-08-17 16:46:58 +00001871 return NULL;
1872 }
Mike Stump1eb44332009-09-09 15:08:12 +00001873
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001874 case Stmt::BinaryOperatorClass: {
1875 // Handle pointer arithmetic. All other binary operators are not valid
1876 // in this context.
1877 BinaryOperator *B = cast<BinaryOperator>(E);
1878 BinaryOperator::Opcode op = B->getOpcode();
Mike Stump1eb44332009-09-09 15:08:12 +00001879
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001880 if (op != BinaryOperator::Add && op != BinaryOperator::Sub)
1881 return NULL;
Mike Stump1eb44332009-09-09 15:08:12 +00001882
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001883 Expr *Base = B->getLHS();
1884
1885 // Determine which argument is the real pointer base. It could be
1886 // the RHS argument instead of the LHS.
1887 if (!Base->getType()->isPointerType()) Base = B->getRHS();
Mike Stump1eb44332009-09-09 15:08:12 +00001888
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001889 assert (Base->getType()->isPointerType());
1890 return EvalAddr(Base);
1891 }
Steve Naroff61f40a22008-09-10 19:17:48 +00001892
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001893 // For conditional operators we need to see if either the LHS or RHS are
1894 // valid DeclRefExpr*s. If one of them is valid, we return it.
1895 case Stmt::ConditionalOperatorClass: {
1896 ConditionalOperator *C = cast<ConditionalOperator>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00001897
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001898 // Handle the GNU extension for missing LHS.
1899 if (Expr *lhsExpr = C->getLHS())
1900 if (DeclRefExpr* LHS = EvalAddr(lhsExpr))
1901 return LHS;
1902
1903 return EvalAddr(C->getRHS());
1904 }
Mike Stump1eb44332009-09-09 15:08:12 +00001905
Ted Kremenek54b52742008-08-07 00:49:01 +00001906 // For casts, we need to handle conversions from arrays to
1907 // pointer values, and pointer-to-pointer conversions.
Douglas Gregor49badde2008-10-27 19:41:14 +00001908 case Stmt::ImplicitCastExprClass:
Douglas Gregor6eec8e82008-10-28 15:36:24 +00001909 case Stmt::CStyleCastExprClass:
Douglas Gregor49badde2008-10-27 19:41:14 +00001910 case Stmt::CXXFunctionalCastExprClass: {
Argyrios Kyrtzidis0835a3c2008-08-18 23:01:59 +00001911 Expr* SubExpr = cast<CastExpr>(E)->getSubExpr();
Ted Kremenek54b52742008-08-07 00:49:01 +00001912 QualType T = SubExpr->getType();
Mike Stump1eb44332009-09-09 15:08:12 +00001913
Steve Naroffdd972f22008-09-05 22:11:13 +00001914 if (SubExpr->getType()->isPointerType() ||
1915 SubExpr->getType()->isBlockPointerType() ||
1916 SubExpr->getType()->isObjCQualifiedIdType())
Ted Kremenek54b52742008-08-07 00:49:01 +00001917 return EvalAddr(SubExpr);
1918 else if (T->isArrayType())
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001919 return EvalVal(SubExpr);
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001920 else
Ted Kremenek54b52742008-08-07 00:49:01 +00001921 return 0;
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001922 }
Mike Stump1eb44332009-09-09 15:08:12 +00001923
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001924 // C++ casts. For dynamic casts, static casts, and const casts, we
1925 // are always converting from a pointer-to-pointer, so we just blow
Douglas Gregor49badde2008-10-27 19:41:14 +00001926 // through the cast. In the case the dynamic cast doesn't fail (and
1927 // return NULL), we take the conservative route and report cases
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001928 // where we return the address of a stack variable. For Reinterpre
Douglas Gregor49badde2008-10-27 19:41:14 +00001929 // FIXME: The comment about is wrong; we're not always converting
1930 // from pointer to pointer. I'm guessing that this code should also
Mike Stump1eb44332009-09-09 15:08:12 +00001931 // handle references to objects.
1932 case Stmt::CXXStaticCastExprClass:
1933 case Stmt::CXXDynamicCastExprClass:
Douglas Gregor49badde2008-10-27 19:41:14 +00001934 case Stmt::CXXConstCastExprClass:
1935 case Stmt::CXXReinterpretCastExprClass: {
1936 Expr *S = cast<CXXNamedCastExpr>(E)->getSubExpr();
Steve Naroffdd972f22008-09-05 22:11:13 +00001937 if (S->getType()->isPointerType() || S->getType()->isBlockPointerType())
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001938 return EvalAddr(S);
1939 else
1940 return NULL;
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001941 }
Mike Stump1eb44332009-09-09 15:08:12 +00001942
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001943 // Everything else: we simply don't reason about them.
1944 default:
1945 return NULL;
1946 }
Ted Kremenek06de2762007-08-17 16:46:58 +00001947}
Mike Stump1eb44332009-09-09 15:08:12 +00001948
Ted Kremenek06de2762007-08-17 16:46:58 +00001949
1950/// EvalVal - This function is complements EvalAddr in the mutual recursion.
1951/// See the comments for EvalAddr for more details.
1952static DeclRefExpr* EvalVal(Expr *E) {
Ted Kremenek68957a92010-08-04 20:01:07 +00001953do {
Ted Kremeneke8c600f2007-08-28 17:02:55 +00001954 // We should only be called for evaluating non-pointer expressions, or
1955 // expressions with a pointer type that are not used as references but instead
1956 // are l-values (e.g., DeclRefExpr with a pointer type).
Mike Stump1eb44332009-09-09 15:08:12 +00001957
Ted Kremenek06de2762007-08-17 16:46:58 +00001958 // Our "symbolic interpreter" is just a dispatch off the currently
1959 // viewed AST node. We then recursively traverse the AST by calling
1960 // EvalAddr and EvalVal appropriately.
1961 switch (E->getStmtClass()) {
Ted Kremenek68957a92010-08-04 20:01:07 +00001962 case Stmt::ImplicitCastExprClass: {
1963 ImplicitCastExpr *IE = cast<ImplicitCastExpr>(E);
1964 if (IE->getCategory() == ImplicitCastExpr::LValue) {
1965 E = IE->getSubExpr();
1966 continue;
1967 }
1968 return NULL;
1969 }
1970
Douglas Gregora2813ce2009-10-23 18:54:35 +00001971 case Stmt::DeclRefExprClass: {
Ted Kremenek06de2762007-08-17 16:46:58 +00001972 // DeclRefExpr: the base case. When we hit a DeclRefExpr we are looking
1973 // at code that refers to a variable's name. We check if it has local
1974 // storage within the function, and if so, return the expression.
1975 DeclRefExpr *DR = cast<DeclRefExpr>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00001976
Ted Kremenek06de2762007-08-17 16:46:58 +00001977 if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl()))
Mike Stump1eb44332009-09-09 15:08:12 +00001978 if (V->hasLocalStorage() && !V->getType()->isReferenceType()) return DR;
1979
Ted Kremenek06de2762007-08-17 16:46:58 +00001980 return NULL;
1981 }
Mike Stump1eb44332009-09-09 15:08:12 +00001982
Ted Kremenek68957a92010-08-04 20:01:07 +00001983 case Stmt::ParenExprClass: {
Ted Kremenek06de2762007-08-17 16:46:58 +00001984 // Ignore parentheses.
Ted Kremenek68957a92010-08-04 20:01:07 +00001985 E = cast<ParenExpr>(E)->getSubExpr();
1986 continue;
1987 }
Mike Stump1eb44332009-09-09 15:08:12 +00001988
Ted Kremenek06de2762007-08-17 16:46:58 +00001989 case Stmt::UnaryOperatorClass: {
1990 // The only unary operator that make sense to handle here
1991 // is Deref. All others don't resolve to a "name." This includes
1992 // handling all sorts of rvalues passed to a unary operator.
1993 UnaryOperator *U = cast<UnaryOperator>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00001994
Ted Kremenek06de2762007-08-17 16:46:58 +00001995 if (U->getOpcode() == UnaryOperator::Deref)
1996 return EvalAddr(U->getSubExpr());
1997
1998 return NULL;
1999 }
Mike Stump1eb44332009-09-09 15:08:12 +00002000
Ted Kremenek06de2762007-08-17 16:46:58 +00002001 case Stmt::ArraySubscriptExprClass: {
2002 // Array subscripts are potential references to data on the stack. We
2003 // retrieve the DeclRefExpr* for the array variable if it indeed
2004 // has local storage.
Ted Kremenek23245122007-08-20 16:18:38 +00002005 return EvalAddr(cast<ArraySubscriptExpr>(E)->getBase());
Ted Kremenek06de2762007-08-17 16:46:58 +00002006 }
Mike Stump1eb44332009-09-09 15:08:12 +00002007
Ted Kremenek06de2762007-08-17 16:46:58 +00002008 case Stmt::ConditionalOperatorClass: {
2009 // For conditional operators we need to see if either the LHS or RHS are
2010 // non-NULL DeclRefExpr's. If one is non-NULL, we return it.
2011 ConditionalOperator *C = cast<ConditionalOperator>(E);
2012
Anders Carlsson39073232007-11-30 19:04:31 +00002013 // Handle the GNU extension for missing LHS.
2014 if (Expr *lhsExpr = C->getLHS())
2015 if (DeclRefExpr *LHS = EvalVal(lhsExpr))
2016 return LHS;
2017
2018 return EvalVal(C->getRHS());
Ted Kremenek06de2762007-08-17 16:46:58 +00002019 }
Mike Stump1eb44332009-09-09 15:08:12 +00002020
Ted Kremenek06de2762007-08-17 16:46:58 +00002021 // Accesses to members are potential references to data on the stack.
Douglas Gregor83f6faf2009-08-31 23:41:50 +00002022 case Stmt::MemberExprClass: {
Ted Kremenek06de2762007-08-17 16:46:58 +00002023 MemberExpr *M = cast<MemberExpr>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00002024
Ted Kremenek06de2762007-08-17 16:46:58 +00002025 // Check for indirect access. We only want direct field accesses.
2026 if (!M->isArrow())
2027 return EvalVal(M->getBase());
2028 else
2029 return NULL;
2030 }
Mike Stump1eb44332009-09-09 15:08:12 +00002031
Ted Kremenek06de2762007-08-17 16:46:58 +00002032 // Everything else: we simply don't reason about them.
2033 default:
2034 return NULL;
2035 }
Ted Kremenek68957a92010-08-04 20:01:07 +00002036} while (true);
Ted Kremenek06de2762007-08-17 16:46:58 +00002037}
Ted Kremenek588e5eb2007-11-25 00:58:00 +00002038
2039//===--- CHECK: Floating-Point comparisons (-Wfloat-equal) ---------------===//
2040
2041/// Check for comparisons of floating point operands using != and ==.
2042/// Issue a warning if these are no self-comparisons, as they are not likely
2043/// to do what the programmer intended.
2044void Sema::CheckFloatComparison(SourceLocation loc, Expr* lex, Expr *rex) {
2045 bool EmitWarning = true;
Mike Stump1eb44332009-09-09 15:08:12 +00002046
Ted Kremenek4e99a5f2008-01-17 16:57:34 +00002047 Expr* LeftExprSansParen = lex->IgnoreParens();
Ted Kremenek32e97b62008-01-17 17:55:13 +00002048 Expr* RightExprSansParen = rex->IgnoreParens();
Ted Kremenek588e5eb2007-11-25 00:58:00 +00002049
2050 // Special case: check for x == x (which is OK).
2051 // Do not emit warnings for such cases.
2052 if (DeclRefExpr* DRL = dyn_cast<DeclRefExpr>(LeftExprSansParen))
2053 if (DeclRefExpr* DRR = dyn_cast<DeclRefExpr>(RightExprSansParen))
2054 if (DRL->getDecl() == DRR->getDecl())
2055 EmitWarning = false;
Mike Stump1eb44332009-09-09 15:08:12 +00002056
2057
Ted Kremenek1b500bb2007-11-29 00:59:04 +00002058 // Special case: check for comparisons against literals that can be exactly
2059 // represented by APFloat. In such cases, do not emit a warning. This
2060 // is a heuristic: often comparison against such literals are used to
2061 // detect if a value in a variable has not changed. This clearly can
2062 // lead to false negatives.
2063 if (EmitWarning) {
2064 if (FloatingLiteral* FLL = dyn_cast<FloatingLiteral>(LeftExprSansParen)) {
2065 if (FLL->isExact())
2066 EmitWarning = false;
Mike Stumpac5fc7c2009-08-04 21:02:39 +00002067 } else
Ted Kremenek1b500bb2007-11-29 00:59:04 +00002068 if (FloatingLiteral* FLR = dyn_cast<FloatingLiteral>(RightExprSansParen)){
2069 if (FLR->isExact())
2070 EmitWarning = false;
2071 }
2072 }
Mike Stump1eb44332009-09-09 15:08:12 +00002073
Ted Kremenek588e5eb2007-11-25 00:58:00 +00002074 // Check for comparisons with builtin types.
Sebastian Redl0eb23302009-01-19 00:08:26 +00002075 if (EmitWarning)
Ted Kremenek588e5eb2007-11-25 00:58:00 +00002076 if (CallExpr* CL = dyn_cast<CallExpr>(LeftExprSansParen))
Douglas Gregor3c385e52009-02-14 18:57:46 +00002077 if (CL->isBuiltinCall(Context))
Ted Kremenek588e5eb2007-11-25 00:58:00 +00002078 EmitWarning = false;
Mike Stump1eb44332009-09-09 15:08:12 +00002079
Sebastian Redl0eb23302009-01-19 00:08:26 +00002080 if (EmitWarning)
Ted Kremenek588e5eb2007-11-25 00:58:00 +00002081 if (CallExpr* CR = dyn_cast<CallExpr>(RightExprSansParen))
Douglas Gregor3c385e52009-02-14 18:57:46 +00002082 if (CR->isBuiltinCall(Context))
Ted Kremenek588e5eb2007-11-25 00:58:00 +00002083 EmitWarning = false;
Mike Stump1eb44332009-09-09 15:08:12 +00002084
Ted Kremenek588e5eb2007-11-25 00:58:00 +00002085 // Emit the diagnostic.
2086 if (EmitWarning)
Chris Lattnerfa25bbb2008-11-19 05:08:23 +00002087 Diag(loc, diag::warn_floatingpoint_eq)
2088 << lex->getSourceRange() << rex->getSourceRange();
Ted Kremenek588e5eb2007-11-25 00:58:00 +00002089}
John McCallba26e582010-01-04 23:21:16 +00002090
John McCallf2370c92010-01-06 05:24:50 +00002091//===--- CHECK: Integer mixed-sign comparisons (-Wsign-compare) --------===//
2092//===--- CHECK: Lossy implicit conversions (-Wconversion) --------------===//
John McCallba26e582010-01-04 23:21:16 +00002093
John McCallf2370c92010-01-06 05:24:50 +00002094namespace {
John McCallba26e582010-01-04 23:21:16 +00002095
John McCallf2370c92010-01-06 05:24:50 +00002096/// Structure recording the 'active' range of an integer-valued
2097/// expression.
2098struct IntRange {
2099 /// The number of bits active in the int.
2100 unsigned Width;
John McCallba26e582010-01-04 23:21:16 +00002101
John McCallf2370c92010-01-06 05:24:50 +00002102 /// True if the int is known not to have negative values.
2103 bool NonNegative;
John McCallba26e582010-01-04 23:21:16 +00002104
John McCallf2370c92010-01-06 05:24:50 +00002105 IntRange() {}
2106 IntRange(unsigned Width, bool NonNegative)
2107 : Width(Width), NonNegative(NonNegative)
2108 {}
John McCallba26e582010-01-04 23:21:16 +00002109
John McCallf2370c92010-01-06 05:24:50 +00002110 // Returns the range of the bool type.
2111 static IntRange forBoolType() {
2112 return IntRange(1, true);
John McCall51313c32010-01-04 23:31:57 +00002113 }
2114
John McCallf2370c92010-01-06 05:24:50 +00002115 // Returns the range of an integral type.
2116 static IntRange forType(ASTContext &C, QualType T) {
2117 return forCanonicalType(C, T->getCanonicalTypeInternal().getTypePtr());
John McCall51313c32010-01-04 23:31:57 +00002118 }
2119
John McCallf2370c92010-01-06 05:24:50 +00002120 // Returns the range of an integeral type based on its canonical
2121 // representation.
2122 static IntRange forCanonicalType(ASTContext &C, const Type *T) {
2123 assert(T->isCanonicalUnqualified());
2124
2125 if (const VectorType *VT = dyn_cast<VectorType>(T))
2126 T = VT->getElementType().getTypePtr();
2127 if (const ComplexType *CT = dyn_cast<ComplexType>(T))
2128 T = CT->getElementType().getTypePtr();
John McCall323ed742010-05-06 08:58:33 +00002129
2130 if (const EnumType *ET = dyn_cast<EnumType>(T)) {
2131 EnumDecl *Enum = ET->getDecl();
2132 unsigned NumPositive = Enum->getNumPositiveBits();
2133 unsigned NumNegative = Enum->getNumNegativeBits();
2134
2135 return IntRange(std::max(NumPositive, NumNegative), NumNegative == 0);
2136 }
John McCallf2370c92010-01-06 05:24:50 +00002137
2138 const BuiltinType *BT = cast<BuiltinType>(T);
2139 assert(BT->isInteger());
2140
2141 return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger());
2142 }
2143
2144 // Returns the supremum of two ranges: i.e. their conservative merge.
John McCallc0cd21d2010-02-23 19:22:29 +00002145 static IntRange join(IntRange L, IntRange R) {
John McCallf2370c92010-01-06 05:24:50 +00002146 return IntRange(std::max(L.Width, R.Width),
John McCall60fad452010-01-06 22:07:33 +00002147 L.NonNegative && R.NonNegative);
2148 }
2149
2150 // Returns the infinum of two ranges: i.e. their aggressive merge.
John McCallc0cd21d2010-02-23 19:22:29 +00002151 static IntRange meet(IntRange L, IntRange R) {
John McCall60fad452010-01-06 22:07:33 +00002152 return IntRange(std::min(L.Width, R.Width),
2153 L.NonNegative || R.NonNegative);
John McCallf2370c92010-01-06 05:24:50 +00002154 }
2155};
2156
2157IntRange GetValueRange(ASTContext &C, llvm::APSInt &value, unsigned MaxWidth) {
2158 if (value.isSigned() && value.isNegative())
2159 return IntRange(value.getMinSignedBits(), false);
2160
2161 if (value.getBitWidth() > MaxWidth)
2162 value.trunc(MaxWidth);
2163
2164 // isNonNegative() just checks the sign bit without considering
2165 // signedness.
2166 return IntRange(value.getActiveBits(), true);
2167}
2168
John McCall0acc3112010-01-06 22:57:21 +00002169IntRange GetValueRange(ASTContext &C, APValue &result, QualType Ty,
John McCallf2370c92010-01-06 05:24:50 +00002170 unsigned MaxWidth) {
2171 if (result.isInt())
2172 return GetValueRange(C, result.getInt(), MaxWidth);
2173
2174 if (result.isVector()) {
John McCall0acc3112010-01-06 22:57:21 +00002175 IntRange R = GetValueRange(C, result.getVectorElt(0), Ty, MaxWidth);
2176 for (unsigned i = 1, e = result.getVectorLength(); i != e; ++i) {
2177 IntRange El = GetValueRange(C, result.getVectorElt(i), Ty, MaxWidth);
2178 R = IntRange::join(R, El);
2179 }
John McCallf2370c92010-01-06 05:24:50 +00002180 return R;
2181 }
2182
2183 if (result.isComplexInt()) {
2184 IntRange R = GetValueRange(C, result.getComplexIntReal(), MaxWidth);
2185 IntRange I = GetValueRange(C, result.getComplexIntImag(), MaxWidth);
2186 return IntRange::join(R, I);
John McCall51313c32010-01-04 23:31:57 +00002187 }
2188
2189 // This can happen with lossless casts to intptr_t of "based" lvalues.
2190 // Assume it might use arbitrary bits.
John McCall0acc3112010-01-06 22:57:21 +00002191 // FIXME: The only reason we need to pass the type in here is to get
2192 // the sign right on this one case. It would be nice if APValue
2193 // preserved this.
John McCallf2370c92010-01-06 05:24:50 +00002194 assert(result.isLValue());
John McCall0acc3112010-01-06 22:57:21 +00002195 return IntRange(MaxWidth, Ty->isUnsignedIntegerType());
John McCall51313c32010-01-04 23:31:57 +00002196}
John McCallf2370c92010-01-06 05:24:50 +00002197
2198/// Pseudo-evaluate the given integer expression, estimating the
2199/// range of values it might take.
2200///
2201/// \param MaxWidth - the width to which the value will be truncated
2202IntRange GetExprRange(ASTContext &C, Expr *E, unsigned MaxWidth) {
2203 E = E->IgnoreParens();
2204
2205 // Try a full evaluation first.
2206 Expr::EvalResult result;
2207 if (E->Evaluate(result, C))
John McCall0acc3112010-01-06 22:57:21 +00002208 return GetValueRange(C, result.Val, E->getType(), MaxWidth);
John McCallf2370c92010-01-06 05:24:50 +00002209
2210 // I think we only want to look through implicit casts here; if the
2211 // user has an explicit widening cast, we should treat the value as
2212 // being of the new, wider type.
2213 if (ImplicitCastExpr *CE = dyn_cast<ImplicitCastExpr>(E)) {
2214 if (CE->getCastKind() == CastExpr::CK_NoOp)
2215 return GetExprRange(C, CE->getSubExpr(), MaxWidth);
2216
2217 IntRange OutputTypeRange = IntRange::forType(C, CE->getType());
2218
John McCall60fad452010-01-06 22:07:33 +00002219 bool isIntegerCast = (CE->getCastKind() == CastExpr::CK_IntegralCast);
2220 if (!isIntegerCast && CE->getCastKind() == CastExpr::CK_Unknown)
2221 isIntegerCast = CE->getSubExpr()->getType()->isIntegerType();
2222
John McCallf2370c92010-01-06 05:24:50 +00002223 // Assume that non-integer casts can span the full range of the type.
John McCall60fad452010-01-06 22:07:33 +00002224 if (!isIntegerCast)
John McCallf2370c92010-01-06 05:24:50 +00002225 return OutputTypeRange;
2226
2227 IntRange SubRange
2228 = GetExprRange(C, CE->getSubExpr(),
2229 std::min(MaxWidth, OutputTypeRange.Width));
2230
2231 // Bail out if the subexpr's range is as wide as the cast type.
2232 if (SubRange.Width >= OutputTypeRange.Width)
2233 return OutputTypeRange;
2234
2235 // Otherwise, we take the smaller width, and we're non-negative if
2236 // either the output type or the subexpr is.
2237 return IntRange(SubRange.Width,
2238 SubRange.NonNegative || OutputTypeRange.NonNegative);
2239 }
2240
2241 if (ConditionalOperator *CO = dyn_cast<ConditionalOperator>(E)) {
2242 // If we can fold the condition, just take that operand.
2243 bool CondResult;
2244 if (CO->getCond()->EvaluateAsBooleanCondition(CondResult, C))
2245 return GetExprRange(C, CondResult ? CO->getTrueExpr()
2246 : CO->getFalseExpr(),
2247 MaxWidth);
2248
2249 // Otherwise, conservatively merge.
2250 IntRange L = GetExprRange(C, CO->getTrueExpr(), MaxWidth);
2251 IntRange R = GetExprRange(C, CO->getFalseExpr(), MaxWidth);
2252 return IntRange::join(L, R);
2253 }
2254
2255 if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) {
2256 switch (BO->getOpcode()) {
2257
2258 // Boolean-valued operations are single-bit and positive.
2259 case BinaryOperator::LAnd:
2260 case BinaryOperator::LOr:
2261 case BinaryOperator::LT:
2262 case BinaryOperator::GT:
2263 case BinaryOperator::LE:
2264 case BinaryOperator::GE:
2265 case BinaryOperator::EQ:
2266 case BinaryOperator::NE:
2267 return IntRange::forBoolType();
2268
John McCallc0cd21d2010-02-23 19:22:29 +00002269 // The type of these compound assignments is the type of the LHS,
2270 // so the RHS is not necessarily an integer.
2271 case BinaryOperator::MulAssign:
2272 case BinaryOperator::DivAssign:
2273 case BinaryOperator::RemAssign:
2274 case BinaryOperator::AddAssign:
2275 case BinaryOperator::SubAssign:
2276 return IntRange::forType(C, E->getType());
2277
John McCallf2370c92010-01-06 05:24:50 +00002278 // Operations with opaque sources are black-listed.
2279 case BinaryOperator::PtrMemD:
2280 case BinaryOperator::PtrMemI:
2281 return IntRange::forType(C, E->getType());
2282
John McCall60fad452010-01-06 22:07:33 +00002283 // Bitwise-and uses the *infinum* of the two source ranges.
2284 case BinaryOperator::And:
John McCallc0cd21d2010-02-23 19:22:29 +00002285 case BinaryOperator::AndAssign:
John McCall60fad452010-01-06 22:07:33 +00002286 return IntRange::meet(GetExprRange(C, BO->getLHS(), MaxWidth),
2287 GetExprRange(C, BO->getRHS(), MaxWidth));
2288
John McCallf2370c92010-01-06 05:24:50 +00002289 // Left shift gets black-listed based on a judgement call.
2290 case BinaryOperator::Shl:
John McCall3aae6092010-04-07 01:14:35 +00002291 // ...except that we want to treat '1 << (blah)' as logically
2292 // positive. It's an important idiom.
2293 if (IntegerLiteral *I
2294 = dyn_cast<IntegerLiteral>(BO->getLHS()->IgnoreParenCasts())) {
2295 if (I->getValue() == 1) {
2296 IntRange R = IntRange::forType(C, E->getType());
2297 return IntRange(R.Width, /*NonNegative*/ true);
2298 }
2299 }
2300 // fallthrough
2301
John McCallc0cd21d2010-02-23 19:22:29 +00002302 case BinaryOperator::ShlAssign:
John McCallf2370c92010-01-06 05:24:50 +00002303 return IntRange::forType(C, E->getType());
2304
John McCall60fad452010-01-06 22:07:33 +00002305 // Right shift by a constant can narrow its left argument.
John McCallc0cd21d2010-02-23 19:22:29 +00002306 case BinaryOperator::Shr:
2307 case BinaryOperator::ShrAssign: {
John McCall60fad452010-01-06 22:07:33 +00002308 IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth);
2309
2310 // If the shift amount is a positive constant, drop the width by
2311 // that much.
2312 llvm::APSInt shift;
2313 if (BO->getRHS()->isIntegerConstantExpr(shift, C) &&
2314 shift.isNonNegative()) {
2315 unsigned zext = shift.getZExtValue();
2316 if (zext >= L.Width)
2317 L.Width = (L.NonNegative ? 0 : 1);
2318 else
2319 L.Width -= zext;
2320 }
2321
2322 return L;
2323 }
2324
2325 // Comma acts as its right operand.
John McCallf2370c92010-01-06 05:24:50 +00002326 case BinaryOperator::Comma:
2327 return GetExprRange(C, BO->getRHS(), MaxWidth);
2328
John McCall60fad452010-01-06 22:07:33 +00002329 // Black-list pointer subtractions.
John McCallf2370c92010-01-06 05:24:50 +00002330 case BinaryOperator::Sub:
2331 if (BO->getLHS()->getType()->isPointerType())
2332 return IntRange::forType(C, E->getType());
2333 // fallthrough
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00002334
John McCallf2370c92010-01-06 05:24:50 +00002335 default:
2336 break;
2337 }
2338
2339 // Treat every other operator as if it were closed on the
2340 // narrowest type that encompasses both operands.
2341 IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth);
2342 IntRange R = GetExprRange(C, BO->getRHS(), MaxWidth);
2343 return IntRange::join(L, R);
2344 }
2345
2346 if (UnaryOperator *UO = dyn_cast<UnaryOperator>(E)) {
2347 switch (UO->getOpcode()) {
2348 // Boolean-valued operations are white-listed.
2349 case UnaryOperator::LNot:
2350 return IntRange::forBoolType();
2351
2352 // Operations with opaque sources are black-listed.
2353 case UnaryOperator::Deref:
2354 case UnaryOperator::AddrOf: // should be impossible
2355 case UnaryOperator::OffsetOf:
2356 return IntRange::forType(C, E->getType());
2357
2358 default:
2359 return GetExprRange(C, UO->getSubExpr(), MaxWidth);
2360 }
2361 }
Douglas Gregor8ecdb652010-04-28 22:16:22 +00002362
2363 if (dyn_cast<OffsetOfExpr>(E)) {
2364 IntRange::forType(C, E->getType());
2365 }
John McCallf2370c92010-01-06 05:24:50 +00002366
2367 FieldDecl *BitField = E->getBitField();
2368 if (BitField) {
2369 llvm::APSInt BitWidthAP = BitField->getBitWidth()->EvaluateAsInt(C);
2370 unsigned BitWidth = BitWidthAP.getZExtValue();
2371
2372 return IntRange(BitWidth, BitField->getType()->isUnsignedIntegerType());
2373 }
2374
2375 return IntRange::forType(C, E->getType());
2376}
John McCall51313c32010-01-04 23:31:57 +00002377
John McCall323ed742010-05-06 08:58:33 +00002378IntRange GetExprRange(ASTContext &C, Expr *E) {
2379 return GetExprRange(C, E, C.getIntWidth(E->getType()));
2380}
2381
John McCall51313c32010-01-04 23:31:57 +00002382/// Checks whether the given value, which currently has the given
2383/// source semantics, has the same value when coerced through the
2384/// target semantics.
John McCallf2370c92010-01-06 05:24:50 +00002385bool IsSameFloatAfterCast(const llvm::APFloat &value,
2386 const llvm::fltSemantics &Src,
2387 const llvm::fltSemantics &Tgt) {
John McCall51313c32010-01-04 23:31:57 +00002388 llvm::APFloat truncated = value;
2389
2390 bool ignored;
2391 truncated.convert(Src, llvm::APFloat::rmNearestTiesToEven, &ignored);
2392 truncated.convert(Tgt, llvm::APFloat::rmNearestTiesToEven, &ignored);
2393
2394 return truncated.bitwiseIsEqual(value);
2395}
2396
2397/// Checks whether the given value, which currently has the given
2398/// source semantics, has the same value when coerced through the
2399/// target semantics.
2400///
2401/// The value might be a vector of floats (or a complex number).
John McCallf2370c92010-01-06 05:24:50 +00002402bool IsSameFloatAfterCast(const APValue &value,
2403 const llvm::fltSemantics &Src,
2404 const llvm::fltSemantics &Tgt) {
John McCall51313c32010-01-04 23:31:57 +00002405 if (value.isFloat())
2406 return IsSameFloatAfterCast(value.getFloat(), Src, Tgt);
2407
2408 if (value.isVector()) {
2409 for (unsigned i = 0, e = value.getVectorLength(); i != e; ++i)
2410 if (!IsSameFloatAfterCast(value.getVectorElt(i), Src, Tgt))
2411 return false;
2412 return true;
2413 }
2414
2415 assert(value.isComplexFloat());
2416 return (IsSameFloatAfterCast(value.getComplexFloatReal(), Src, Tgt) &&
2417 IsSameFloatAfterCast(value.getComplexFloatImag(), Src, Tgt));
2418}
2419
John McCall323ed742010-05-06 08:58:33 +00002420void AnalyzeImplicitConversions(Sema &S, Expr *E);
2421
2422bool IsZero(Sema &S, Expr *E) {
2423 llvm::APSInt Value;
2424 return E->isIntegerConstantExpr(Value, S.Context) && Value == 0;
2425}
2426
2427void CheckTrivialUnsignedComparison(Sema &S, BinaryOperator *E) {
2428 BinaryOperator::Opcode op = E->getOpcode();
2429 if (op == BinaryOperator::LT && IsZero(S, E->getRHS())) {
2430 S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison)
2431 << "< 0" << "false"
2432 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
2433 } else if (op == BinaryOperator::GE && IsZero(S, E->getRHS())) {
2434 S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison)
2435 << ">= 0" << "true"
2436 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
2437 } else if (op == BinaryOperator::GT && IsZero(S, E->getLHS())) {
2438 S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison)
2439 << "0 >" << "false"
2440 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
2441 } else if (op == BinaryOperator::LE && IsZero(S, E->getLHS())) {
2442 S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison)
2443 << "0 <=" << "true"
2444 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
2445 }
2446}
2447
2448/// Analyze the operands of the given comparison. Implements the
2449/// fallback case from AnalyzeComparison.
2450void AnalyzeImpConvsInComparison(Sema &S, BinaryOperator *E) {
2451 AnalyzeImplicitConversions(S, E->getLHS());
2452 AnalyzeImplicitConversions(S, E->getRHS());
2453}
John McCall51313c32010-01-04 23:31:57 +00002454
John McCallba26e582010-01-04 23:21:16 +00002455/// \brief Implements -Wsign-compare.
2456///
2457/// \param lex the left-hand expression
2458/// \param rex the right-hand expression
2459/// \param OpLoc the location of the joining operator
John McCalld1b47bf2010-03-11 19:43:18 +00002460/// \param BinOpc binary opcode or 0
John McCall323ed742010-05-06 08:58:33 +00002461void AnalyzeComparison(Sema &S, BinaryOperator *E) {
2462 // The type the comparison is being performed in.
2463 QualType T = E->getLHS()->getType();
2464 assert(S.Context.hasSameUnqualifiedType(T, E->getRHS()->getType())
2465 && "comparison with mismatched types");
John McCallba26e582010-01-04 23:21:16 +00002466
John McCall323ed742010-05-06 08:58:33 +00002467 // We don't do anything special if this isn't an unsigned integral
2468 // comparison: we're only interested in integral comparisons, and
2469 // signed comparisons only happen in cases we don't care to warn about.
Douglas Gregorf6094622010-07-23 15:58:24 +00002470 if (!T->hasUnsignedIntegerRepresentation())
John McCall323ed742010-05-06 08:58:33 +00002471 return AnalyzeImpConvsInComparison(S, E);
John McCallf2370c92010-01-06 05:24:50 +00002472
John McCall323ed742010-05-06 08:58:33 +00002473 Expr *lex = E->getLHS()->IgnoreParenImpCasts();
2474 Expr *rex = E->getRHS()->IgnoreParenImpCasts();
John McCallba26e582010-01-04 23:21:16 +00002475
John McCall323ed742010-05-06 08:58:33 +00002476 // Check to see if one of the (unmodified) operands is of different
2477 // signedness.
2478 Expr *signedOperand, *unsignedOperand;
Douglas Gregorf6094622010-07-23 15:58:24 +00002479 if (lex->getType()->hasSignedIntegerRepresentation()) {
2480 assert(!rex->getType()->hasSignedIntegerRepresentation() &&
John McCall323ed742010-05-06 08:58:33 +00002481 "unsigned comparison between two signed integer expressions?");
2482 signedOperand = lex;
2483 unsignedOperand = rex;
Douglas Gregorf6094622010-07-23 15:58:24 +00002484 } else if (rex->getType()->hasSignedIntegerRepresentation()) {
John McCall323ed742010-05-06 08:58:33 +00002485 signedOperand = rex;
2486 unsignedOperand = lex;
John McCallba26e582010-01-04 23:21:16 +00002487 } else {
John McCall323ed742010-05-06 08:58:33 +00002488 CheckTrivialUnsignedComparison(S, E);
2489 return AnalyzeImpConvsInComparison(S, E);
John McCallba26e582010-01-04 23:21:16 +00002490 }
2491
John McCall323ed742010-05-06 08:58:33 +00002492 // Otherwise, calculate the effective range of the signed operand.
2493 IntRange signedRange = GetExprRange(S.Context, signedOperand);
John McCallf2370c92010-01-06 05:24:50 +00002494
John McCall323ed742010-05-06 08:58:33 +00002495 // Go ahead and analyze implicit conversions in the operands. Note
2496 // that we skip the implicit conversions on both sides.
2497 AnalyzeImplicitConversions(S, lex);
2498 AnalyzeImplicitConversions(S, rex);
John McCallba26e582010-01-04 23:21:16 +00002499
John McCall323ed742010-05-06 08:58:33 +00002500 // If the signed range is non-negative, -Wsign-compare won't fire,
2501 // but we should still check for comparisons which are always true
2502 // or false.
2503 if (signedRange.NonNegative)
2504 return CheckTrivialUnsignedComparison(S, E);
John McCallba26e582010-01-04 23:21:16 +00002505
2506 // For (in)equality comparisons, if the unsigned operand is a
2507 // constant which cannot collide with a overflowed signed operand,
2508 // then reinterpreting the signed operand as unsigned will not
2509 // change the result of the comparison.
John McCall323ed742010-05-06 08:58:33 +00002510 if (E->isEqualityOp()) {
2511 unsigned comparisonWidth = S.Context.getIntWidth(T);
2512 IntRange unsignedRange = GetExprRange(S.Context, unsignedOperand);
John McCallba26e582010-01-04 23:21:16 +00002513
John McCall323ed742010-05-06 08:58:33 +00002514 // We should never be unable to prove that the unsigned operand is
2515 // non-negative.
2516 assert(unsignedRange.NonNegative && "unsigned range includes negative?");
2517
2518 if (unsignedRange.Width < comparisonWidth)
2519 return;
2520 }
2521
2522 S.Diag(E->getOperatorLoc(), diag::warn_mixed_sign_comparison)
2523 << lex->getType() << rex->getType()
2524 << lex->getSourceRange() << rex->getSourceRange();
John McCallba26e582010-01-04 23:21:16 +00002525}
2526
John McCall51313c32010-01-04 23:31:57 +00002527/// Diagnose an implicit cast; purely a helper for CheckImplicitConversion.
John McCall323ed742010-05-06 08:58:33 +00002528void DiagnoseImpCast(Sema &S, Expr *E, QualType T, unsigned diag) {
John McCall51313c32010-01-04 23:31:57 +00002529 S.Diag(E->getExprLoc(), diag) << E->getType() << T << E->getSourceRange();
2530}
2531
John McCall323ed742010-05-06 08:58:33 +00002532void CheckImplicitConversion(Sema &S, Expr *E, QualType T,
2533 bool *ICContext = 0) {
2534 if (E->isTypeDependent() || E->isValueDependent()) return;
John McCall51313c32010-01-04 23:31:57 +00002535
John McCall323ed742010-05-06 08:58:33 +00002536 const Type *Source = S.Context.getCanonicalType(E->getType()).getTypePtr();
2537 const Type *Target = S.Context.getCanonicalType(T).getTypePtr();
2538 if (Source == Target) return;
2539 if (Target->isDependentType()) return;
John McCall51313c32010-01-04 23:31:57 +00002540
2541 // Never diagnose implicit casts to bool.
2542 if (Target->isSpecificBuiltinType(BuiltinType::Bool))
2543 return;
2544
2545 // Strip vector types.
2546 if (isa<VectorType>(Source)) {
2547 if (!isa<VectorType>(Target))
John McCall323ed742010-05-06 08:58:33 +00002548 return DiagnoseImpCast(S, E, T, diag::warn_impcast_vector_scalar);
John McCall51313c32010-01-04 23:31:57 +00002549
2550 Source = cast<VectorType>(Source)->getElementType().getTypePtr();
2551 Target = cast<VectorType>(Target)->getElementType().getTypePtr();
2552 }
2553
2554 // Strip complex types.
2555 if (isa<ComplexType>(Source)) {
2556 if (!isa<ComplexType>(Target))
John McCall323ed742010-05-06 08:58:33 +00002557 return DiagnoseImpCast(S, E, T, diag::warn_impcast_complex_scalar);
John McCall51313c32010-01-04 23:31:57 +00002558
2559 Source = cast<ComplexType>(Source)->getElementType().getTypePtr();
2560 Target = cast<ComplexType>(Target)->getElementType().getTypePtr();
2561 }
2562
2563 const BuiltinType *SourceBT = dyn_cast<BuiltinType>(Source);
2564 const BuiltinType *TargetBT = dyn_cast<BuiltinType>(Target);
2565
2566 // If the source is floating point...
2567 if (SourceBT && SourceBT->isFloatingPoint()) {
2568 // ...and the target is floating point...
2569 if (TargetBT && TargetBT->isFloatingPoint()) {
2570 // ...then warn if we're dropping FP rank.
2571
2572 // Builtin FP kinds are ordered by increasing FP rank.
2573 if (SourceBT->getKind() > TargetBT->getKind()) {
2574 // Don't warn about float constants that are precisely
2575 // representable in the target type.
2576 Expr::EvalResult result;
John McCall323ed742010-05-06 08:58:33 +00002577 if (E->Evaluate(result, S.Context)) {
John McCall51313c32010-01-04 23:31:57 +00002578 // Value might be a float, a float vector, or a float complex.
2579 if (IsSameFloatAfterCast(result.Val,
John McCall323ed742010-05-06 08:58:33 +00002580 S.Context.getFloatTypeSemantics(QualType(TargetBT, 0)),
2581 S.Context.getFloatTypeSemantics(QualType(SourceBT, 0))))
John McCall51313c32010-01-04 23:31:57 +00002582 return;
2583 }
2584
John McCall323ed742010-05-06 08:58:33 +00002585 DiagnoseImpCast(S, E, T, diag::warn_impcast_float_precision);
John McCall51313c32010-01-04 23:31:57 +00002586 }
2587 return;
2588 }
2589
2590 // If the target is integral, always warn.
2591 if ((TargetBT && TargetBT->isInteger()))
2592 // TODO: don't warn for integer values?
John McCall323ed742010-05-06 08:58:33 +00002593 DiagnoseImpCast(S, E, T, diag::warn_impcast_float_integer);
John McCall51313c32010-01-04 23:31:57 +00002594
2595 return;
2596 }
2597
John McCallf2370c92010-01-06 05:24:50 +00002598 if (!Source->isIntegerType() || !Target->isIntegerType())
John McCall51313c32010-01-04 23:31:57 +00002599 return;
2600
John McCall323ed742010-05-06 08:58:33 +00002601 IntRange SourceRange = GetExprRange(S.Context, E);
2602 IntRange TargetRange = IntRange::forCanonicalType(S.Context, Target);
John McCallf2370c92010-01-06 05:24:50 +00002603
2604 if (SourceRange.Width > TargetRange.Width) {
John McCall51313c32010-01-04 23:31:57 +00002605 // People want to build with -Wshorten-64-to-32 and not -Wconversion
2606 // and by god we'll let them.
John McCallf2370c92010-01-06 05:24:50 +00002607 if (SourceRange.Width == 64 && TargetRange.Width == 32)
John McCall323ed742010-05-06 08:58:33 +00002608 return DiagnoseImpCast(S, E, T, diag::warn_impcast_integer_64_32);
2609 return DiagnoseImpCast(S, E, T, diag::warn_impcast_integer_precision);
2610 }
2611
2612 if ((TargetRange.NonNegative && !SourceRange.NonNegative) ||
2613 (!TargetRange.NonNegative && SourceRange.NonNegative &&
2614 SourceRange.Width == TargetRange.Width)) {
2615 unsigned DiagID = diag::warn_impcast_integer_sign;
2616
2617 // Traditionally, gcc has warned about this under -Wsign-compare.
2618 // We also want to warn about it in -Wconversion.
2619 // So if -Wconversion is off, use a completely identical diagnostic
2620 // in the sign-compare group.
2621 // The conditional-checking code will
2622 if (ICContext) {
2623 DiagID = diag::warn_impcast_integer_sign_conditional;
2624 *ICContext = true;
2625 }
2626
2627 return DiagnoseImpCast(S, E, T, DiagID);
John McCall51313c32010-01-04 23:31:57 +00002628 }
2629
2630 return;
2631}
2632
John McCall323ed742010-05-06 08:58:33 +00002633void CheckConditionalOperator(Sema &S, ConditionalOperator *E, QualType T);
2634
2635void CheckConditionalOperand(Sema &S, Expr *E, QualType T,
2636 bool &ICContext) {
2637 E = E->IgnoreParenImpCasts();
2638
2639 if (isa<ConditionalOperator>(E))
2640 return CheckConditionalOperator(S, cast<ConditionalOperator>(E), T);
2641
2642 AnalyzeImplicitConversions(S, E);
2643 if (E->getType() != T)
2644 return CheckImplicitConversion(S, E, T, &ICContext);
2645 return;
2646}
2647
2648void CheckConditionalOperator(Sema &S, ConditionalOperator *E, QualType T) {
2649 AnalyzeImplicitConversions(S, E->getCond());
2650
2651 bool Suspicious = false;
2652 CheckConditionalOperand(S, E->getTrueExpr(), T, Suspicious);
2653 CheckConditionalOperand(S, E->getFalseExpr(), T, Suspicious);
2654
2655 // If -Wconversion would have warned about either of the candidates
2656 // for a signedness conversion to the context type...
2657 if (!Suspicious) return;
2658
2659 // ...but it's currently ignored...
2660 if (S.Diags.getDiagnosticLevel(diag::warn_impcast_integer_sign_conditional))
2661 return;
2662
2663 // ...and -Wsign-compare isn't...
2664 if (!S.Diags.getDiagnosticLevel(diag::warn_mixed_sign_conditional))
2665 return;
2666
2667 // ...then check whether it would have warned about either of the
2668 // candidates for a signedness conversion to the condition type.
2669 if (E->getType() != T) {
2670 Suspicious = false;
2671 CheckImplicitConversion(S, E->getTrueExpr()->IgnoreParenImpCasts(),
2672 E->getType(), &Suspicious);
2673 if (!Suspicious)
2674 CheckImplicitConversion(S, E->getFalseExpr()->IgnoreParenImpCasts(),
2675 E->getType(), &Suspicious);
2676 if (!Suspicious)
2677 return;
2678 }
2679
2680 // If so, emit a diagnostic under -Wsign-compare.
2681 Expr *lex = E->getTrueExpr()->IgnoreParenImpCasts();
2682 Expr *rex = E->getFalseExpr()->IgnoreParenImpCasts();
2683 S.Diag(E->getQuestionLoc(), diag::warn_mixed_sign_conditional)
2684 << lex->getType() << rex->getType()
2685 << lex->getSourceRange() << rex->getSourceRange();
2686}
2687
2688/// AnalyzeImplicitConversions - Find and report any interesting
2689/// implicit conversions in the given expression. There are a couple
2690/// of competing diagnostics here, -Wconversion and -Wsign-compare.
2691void AnalyzeImplicitConversions(Sema &S, Expr *OrigE) {
2692 QualType T = OrigE->getType();
2693 Expr *E = OrigE->IgnoreParenImpCasts();
2694
2695 // For conditional operators, we analyze the arguments as if they
2696 // were being fed directly into the output.
2697 if (isa<ConditionalOperator>(E)) {
2698 ConditionalOperator *CO = cast<ConditionalOperator>(E);
2699 CheckConditionalOperator(S, CO, T);
2700 return;
2701 }
2702
2703 // Go ahead and check any implicit conversions we might have skipped.
2704 // The non-canonical typecheck is just an optimization;
2705 // CheckImplicitConversion will filter out dead implicit conversions.
2706 if (E->getType() != T)
2707 CheckImplicitConversion(S, E, T);
2708
2709 // Now continue drilling into this expression.
2710
2711 // Skip past explicit casts.
2712 if (isa<ExplicitCastExpr>(E)) {
2713 E = cast<ExplicitCastExpr>(E)->getSubExpr()->IgnoreParenImpCasts();
2714 return AnalyzeImplicitConversions(S, E);
2715 }
2716
2717 // Do a somewhat different check with comparison operators.
2718 if (isa<BinaryOperator>(E) && cast<BinaryOperator>(E)->isComparisonOp())
2719 return AnalyzeComparison(S, cast<BinaryOperator>(E));
2720
2721 // These break the otherwise-useful invariant below. Fortunately,
2722 // we don't really need to recurse into them, because any internal
2723 // expressions should have been analyzed already when they were
2724 // built into statements.
2725 if (isa<StmtExpr>(E)) return;
2726
2727 // Don't descend into unevaluated contexts.
2728 if (isa<SizeOfAlignOfExpr>(E)) return;
2729
2730 // Now just recurse over the expression's children.
2731 for (Stmt::child_iterator I = E->child_begin(), IE = E->child_end();
2732 I != IE; ++I)
2733 AnalyzeImplicitConversions(S, cast<Expr>(*I));
2734}
2735
2736} // end anonymous namespace
2737
2738/// Diagnoses "dangerous" implicit conversions within the given
2739/// expression (which is a full expression). Implements -Wconversion
2740/// and -Wsign-compare.
2741void Sema::CheckImplicitConversions(Expr *E) {
2742 // Don't diagnose in unevaluated contexts.
2743 if (ExprEvalContexts.back().Context == Sema::Unevaluated)
2744 return;
2745
2746 // Don't diagnose for value- or type-dependent expressions.
2747 if (E->isTypeDependent() || E->isValueDependent())
2748 return;
2749
2750 AnalyzeImplicitConversions(*this, E);
2751}
2752
Mike Stumpf8c49212010-01-21 03:59:47 +00002753/// CheckParmsForFunctionDef - Check that the parameters of the given
2754/// function are appropriate for the definition of a function. This
2755/// takes care of any checks that cannot be performed on the
2756/// declaration itself, e.g., that the types of each of the function
2757/// parameters are complete.
2758bool Sema::CheckParmsForFunctionDef(FunctionDecl *FD) {
2759 bool HasInvalidParm = false;
2760 for (unsigned p = 0, NumParams = FD->getNumParams(); p < NumParams; ++p) {
2761 ParmVarDecl *Param = FD->getParamDecl(p);
2762
2763 // C99 6.7.5.3p4: the parameters in a parameter type list in a
2764 // function declarator that is part of a function definition of
2765 // that function shall not have incomplete type.
2766 //
2767 // This is also C++ [dcl.fct]p6.
2768 if (!Param->isInvalidDecl() &&
2769 RequireCompleteType(Param->getLocation(), Param->getType(),
2770 diag::err_typecheck_decl_incomplete_type)) {
2771 Param->setInvalidDecl();
2772 HasInvalidParm = true;
2773 }
2774
2775 // C99 6.9.1p5: If the declarator includes a parameter type list, the
2776 // declaration of each parameter shall include an identifier.
2777 if (Param->getIdentifier() == 0 &&
2778 !Param->isImplicit() &&
2779 !getLangOptions().CPlusPlus)
2780 Diag(Param->getLocation(), diag::err_parameter_name_omitted);
Sam Weinigd17e3402010-02-01 05:02:49 +00002781
2782 // C99 6.7.5.3p12:
2783 // If the function declarator is not part of a definition of that
2784 // function, parameters may have incomplete type and may use the [*]
2785 // notation in their sequences of declarator specifiers to specify
2786 // variable length array types.
2787 QualType PType = Param->getOriginalType();
2788 if (const ArrayType *AT = Context.getAsArrayType(PType)) {
2789 if (AT->getSizeModifier() == ArrayType::Star) {
2790 // FIXME: This diagnosic should point the the '[*]' if source-location
2791 // information is added for it.
2792 Diag(Param->getLocation(), diag::err_array_star_in_function_definition);
2793 }
2794 }
Mike Stumpf8c49212010-01-21 03:59:47 +00002795 }
2796
2797 return HasInvalidParm;
2798}