blob: f0f56efa9e7e66c943ef61a49561e4f97dcbb4db [file] [log] [blame]
Zhongxing Xu589c0f22009-11-12 08:38:56 +00001//=== MallocChecker.cpp - A malloc/free checker -------------------*- C++ -*--//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// This file defines malloc/free checker, which checks for potential memory
11// leaks, double free, and use-after-free problems.
12//
13//===----------------------------------------------------------------------===//
14
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +000015#include "ClangSACheckers.h"
Argyrios Kyrtzidisec8605f2011-03-01 01:16:21 +000016#include "clang/StaticAnalyzer/Core/Checker.h"
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +000017#include "clang/StaticAnalyzer/Core/CheckerManager.h"
18#include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
Ted Kremenek9b663712011-02-10 01:03:03 +000019#include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
Ted Kremenek18c66fd2011-08-15 22:09:50 +000020#include "clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h"
21#include "clang/StaticAnalyzer/Core/PathSensitive/ProgramStateTrait.h"
Ted Kremenek9b663712011-02-10 01:03:03 +000022#include "clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h"
Zhongxing Xu589c0f22009-11-12 08:38:56 +000023#include "llvm/ADT/ImmutableMap.h"
24using namespace clang;
Ted Kremenek9ef65372010-12-23 07:20:52 +000025using namespace ento;
Zhongxing Xu589c0f22009-11-12 08:38:56 +000026
27namespace {
28
Zhongxing Xu7fb14642009-12-11 00:55:44 +000029class RefState {
Ted Kremenekdde201b2010-08-06 21:12:55 +000030 enum Kind { AllocateUnchecked, AllocateFailed, Released, Escaped,
31 Relinquished } K;
Zhongxing Xu243fde92009-11-17 07:54:15 +000032 const Stmt *S;
33
Zhongxing Xu7fb14642009-12-11 00:55:44 +000034public:
Zhongxing Xu243fde92009-11-17 07:54:15 +000035 RefState(Kind k, const Stmt *s) : K(k), S(s) {}
36
Zhongxing Xub94b81a2009-12-31 06:13:07 +000037 bool isAllocated() const { return K == AllocateUnchecked; }
Chris Lattnerfae96222010-09-03 04:34:38 +000038 //bool isFailed() const { return K == AllocateFailed; }
Zhongxing Xu243fde92009-11-17 07:54:15 +000039 bool isReleased() const { return K == Released; }
Chris Lattnerfae96222010-09-03 04:34:38 +000040 //bool isEscaped() const { return K == Escaped; }
41 //bool isRelinquished() const { return K == Relinquished; }
Zhongxing Xu243fde92009-11-17 07:54:15 +000042
43 bool operator==(const RefState &X) const {
44 return K == X.K && S == X.S;
45 }
46
Zhongxing Xub94b81a2009-12-31 06:13:07 +000047 static RefState getAllocateUnchecked(const Stmt *s) {
48 return RefState(AllocateUnchecked, s);
49 }
50 static RefState getAllocateFailed() {
51 return RefState(AllocateFailed, 0);
52 }
Zhongxing Xu243fde92009-11-17 07:54:15 +000053 static RefState getReleased(const Stmt *s) { return RefState(Released, s); }
54 static RefState getEscaped(const Stmt *s) { return RefState(Escaped, s); }
Ted Kremenekdde201b2010-08-06 21:12:55 +000055 static RefState getRelinquished(const Stmt *s) {
56 return RefState(Relinquished, s);
57 }
Zhongxing Xu243fde92009-11-17 07:54:15 +000058
59 void Profile(llvm::FoldingSetNodeID &ID) const {
60 ID.AddInteger(K);
61 ID.AddPointer(S);
62 }
Zhongxing Xu589c0f22009-11-12 08:38:56 +000063};
64
Kovarththanan Rajaratnamba5fb5a2009-11-28 06:07:30 +000065class RegionState {};
Zhongxing Xu589c0f22009-11-12 08:38:56 +000066
Argyrios Kyrtzidisec8605f2011-03-01 01:16:21 +000067class MallocChecker : public Checker<eval::Call, check::DeadSymbols, check::EndPath, check::PreStmt<ReturnStmt>, check::Location,
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +000068 check::Bind, eval::Assume> {
69 mutable llvm::OwningPtr<BuiltinBug> BT_DoubleFree;
70 mutable llvm::OwningPtr<BuiltinBug> BT_Leak;
71 mutable llvm::OwningPtr<BuiltinBug> BT_UseFree;
72 mutable llvm::OwningPtr<BuiltinBug> BT_UseRelinquished;
73 mutable llvm::OwningPtr<BuiltinBug> BT_BadFree;
74 mutable IdentifierInfo *II_malloc, *II_free, *II_realloc, *II_calloc;
Zhongxing Xu589c0f22009-11-12 08:38:56 +000075
76public:
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +000077 MallocChecker() : II_malloc(0), II_free(0), II_realloc(0), II_calloc(0) {}
78
79 bool evalCall(const CallExpr *CE, CheckerContext &C) const;
80 void checkDeadSymbols(SymbolReaper &SymReaper, CheckerContext &C) const;
81 void checkEndPath(EndOfFunctionNodeBuilder &B, ExprEngine &Eng) const;
82 void checkPreStmt(const ReturnStmt *S, CheckerContext &C) const;
Ted Kremenek18c66fd2011-08-15 22:09:50 +000083 const ProgramState *evalAssume(const ProgramState *state, SVal Cond,
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +000084 bool Assumption) const;
85 void checkLocation(SVal l, bool isLoad, CheckerContext &C) const;
86 void checkBind(SVal location, SVal val, CheckerContext &C) const;
Zhongxing Xub94b81a2009-12-31 06:13:07 +000087
Zhongxing Xu7b760962009-11-13 07:25:27 +000088private:
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +000089 static void MallocMem(CheckerContext &C, const CallExpr *CE);
90 static void MallocMemReturnsAttr(CheckerContext &C, const CallExpr *CE,
91 const OwnershipAttr* Att);
Ted Kremenek18c66fd2011-08-15 22:09:50 +000092 static const ProgramState *MallocMemAux(CheckerContext &C, const CallExpr *CE,
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +000093 const Expr *SizeEx, SVal Init,
Ted Kremenek18c66fd2011-08-15 22:09:50 +000094 const ProgramState *state) {
Zhongxing Xua5ce9662010-06-01 03:01:33 +000095 return MallocMemAux(C, CE, state->getSVal(SizeEx), Init, state);
96 }
Ted Kremenek18c66fd2011-08-15 22:09:50 +000097 static const ProgramState *MallocMemAux(CheckerContext &C, const CallExpr *CE,
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +000098 SVal SizeEx, SVal Init,
Ted Kremenek18c66fd2011-08-15 22:09:50 +000099 const ProgramState *state);
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000100
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000101 void FreeMem(CheckerContext &C, const CallExpr *CE) const;
Jordy Rose2a479922010-08-12 08:54:03 +0000102 void FreeMemAttr(CheckerContext &C, const CallExpr *CE,
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000103 const OwnershipAttr* Att) const;
Ted Kremenek18c66fd2011-08-15 22:09:50 +0000104 const ProgramState *FreeMemAux(CheckerContext &C, const CallExpr *CE,
105 const ProgramState *state, unsigned Num, bool Hold) const;
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000106
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000107 void ReallocMem(CheckerContext &C, const CallExpr *CE) const;
108 static void CallocMem(CheckerContext &C, const CallExpr *CE);
Jordy Rose43859f62010-06-07 19:32:37 +0000109
Ted Kremenek9c378f72011-08-12 23:37:29 +0000110 static bool SummarizeValue(raw_ostream &os, SVal V);
111 static bool SummarizeRegion(raw_ostream &os, const MemRegion *MR);
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000112 void ReportBadFree(CheckerContext &C, SVal ArgVal, SourceRange range) const;
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000113};
Kovarththanan Rajaratnamba5fb5a2009-11-28 06:07:30 +0000114} // end anonymous namespace
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000115
Zhongxing Xub94b81a2009-12-31 06:13:07 +0000116typedef llvm::ImmutableMap<SymbolRef, RefState> RegionStateTy;
117
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000118namespace clang {
Ted Kremenek9ef65372010-12-23 07:20:52 +0000119namespace ento {
Zhongxing Xu243fde92009-11-17 07:54:15 +0000120 template <>
Ted Kremenek18c66fd2011-08-15 22:09:50 +0000121 struct ProgramStateTrait<RegionState>
122 : public ProgramStatePartialTrait<RegionStateTy> {
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000123 static void *GDMIndex() { static int x; return &x; }
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000124 };
125}
Argyrios Kyrtzidis5a4f98f2010-12-22 18:53:20 +0000126}
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000127
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000128bool MallocChecker::evalCall(const CallExpr *CE, CheckerContext &C) const {
Ted Kremenek18c66fd2011-08-15 22:09:50 +0000129 const ProgramState *state = C.getState();
Zhongxing Xua49c6b72009-12-11 03:09:01 +0000130 const Expr *Callee = CE->getCallee();
Ted Kremenek13976632010-02-08 16:18:51 +0000131 SVal L = state->getSVal(Callee);
Zhongxing Xua49c6b72009-12-11 03:09:01 +0000132
133 const FunctionDecl *FD = L.getAsFunctionDecl();
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000134 if (!FD)
Zhongxing Xua49c6b72009-12-11 03:09:01 +0000135 return false;
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000136
137 ASTContext &Ctx = C.getASTContext();
138 if (!II_malloc)
139 II_malloc = &Ctx.Idents.get("malloc");
140 if (!II_free)
Zhongxing Xufc7ac8f2009-11-13 07:48:11 +0000141 II_free = &Ctx.Idents.get("free");
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000142 if (!II_realloc)
143 II_realloc = &Ctx.Idents.get("realloc");
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000144 if (!II_calloc)
145 II_calloc = &Ctx.Idents.get("calloc");
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000146
147 if (FD->getIdentifier() == II_malloc) {
148 MallocMem(C, CE);
Zhongxing Xua49c6b72009-12-11 03:09:01 +0000149 return true;
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000150 }
151
152 if (FD->getIdentifier() == II_free) {
153 FreeMem(C, CE);
Zhongxing Xua49c6b72009-12-11 03:09:01 +0000154 return true;
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000155 }
Zhongxing Xua49c6b72009-12-11 03:09:01 +0000156
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000157 if (FD->getIdentifier() == II_realloc) {
158 ReallocMem(C, CE);
159 return true;
160 }
161
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000162 if (FD->getIdentifier() == II_calloc) {
163 CallocMem(C, CE);
164 return true;
165 }
166
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000167 // Check all the attributes, if there are any.
168 // There can be multiple of these attributes.
169 bool rv = false;
170 if (FD->hasAttrs()) {
Sean Huntcf807c42010-08-18 23:23:40 +0000171 for (specific_attr_iterator<OwnershipAttr>
172 i = FD->specific_attr_begin<OwnershipAttr>(),
173 e = FD->specific_attr_end<OwnershipAttr>();
174 i != e; ++i) {
175 switch ((*i)->getOwnKind()) {
176 case OwnershipAttr::Returns: {
177 MallocMemReturnsAttr(C, CE, *i);
Jordy Rose2a479922010-08-12 08:54:03 +0000178 rv = true;
179 break;
Sean Huntcf807c42010-08-18 23:23:40 +0000180 }
181 case OwnershipAttr::Takes:
182 case OwnershipAttr::Holds: {
183 FreeMemAttr(C, CE, *i);
Jordy Rose2a479922010-08-12 08:54:03 +0000184 rv = true;
185 break;
Sean Huntcf807c42010-08-18 23:23:40 +0000186 }
Jordy Rose2a479922010-08-12 08:54:03 +0000187 default:
Jordy Rose2a479922010-08-12 08:54:03 +0000188 break;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000189 }
190 }
191 }
192 return rv;
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000193}
194
195void MallocChecker::MallocMem(CheckerContext &C, const CallExpr *CE) {
Ted Kremenek18c66fd2011-08-15 22:09:50 +0000196 const ProgramState *state = MallocMemAux(C, CE, CE->getArg(0), UndefinedVal(),
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000197 C.getState());
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000198 C.addTransition(state);
199}
200
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000201void MallocChecker::MallocMemReturnsAttr(CheckerContext &C, const CallExpr *CE,
202 const OwnershipAttr* Att) {
Sean Huntcf807c42010-08-18 23:23:40 +0000203 if (Att->getModule() != "malloc")
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000204 return;
205
Sean Huntcf807c42010-08-18 23:23:40 +0000206 OwnershipAttr::args_iterator I = Att->args_begin(), E = Att->args_end();
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000207 if (I != E) {
Ted Kremenek18c66fd2011-08-15 22:09:50 +0000208 const ProgramState *state =
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000209 MallocMemAux(C, CE, CE->getArg(*I), UndefinedVal(), C.getState());
210 C.addTransition(state);
211 return;
212 }
Ted Kremenek18c66fd2011-08-15 22:09:50 +0000213 const ProgramState *state = MallocMemAux(C, CE, UnknownVal(), UndefinedVal(),
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000214 C.getState());
215 C.addTransition(state);
216}
217
Ted Kremenek18c66fd2011-08-15 22:09:50 +0000218const ProgramState *MallocChecker::MallocMemAux(CheckerContext &C,
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000219 const CallExpr *CE,
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000220 SVal Size, SVal Init,
Ted Kremenek18c66fd2011-08-15 22:09:50 +0000221 const ProgramState *state) {
Zhongxing Xua49c6b72009-12-11 03:09:01 +0000222 unsigned Count = C.getNodeBuilder().getCurrentBlockCount();
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000223 SValBuilder &svalBuilder = C.getSValBuilder();
Zhongxing Xua49c6b72009-12-11 03:09:01 +0000224
Jordy Rose32f26562010-07-04 00:00:41 +0000225 // Set the return value.
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000226 SVal retVal = svalBuilder.getConjuredSymbolVal(NULL, CE, CE->getType(), Count);
227 state = state->BindExpr(CE, retVal);
Zhongxing Xua49c6b72009-12-11 03:09:01 +0000228
Jordy Rose32f26562010-07-04 00:00:41 +0000229 // Fill the region with the initialization value.
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000230 state = state->bindDefault(retVal, Init);
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000231
Jordy Rose32f26562010-07-04 00:00:41 +0000232 // Set the region's extent equal to the Size parameter.
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000233 const SymbolicRegion *R = cast<SymbolicRegion>(retVal.getAsRegion());
234 DefinedOrUnknownSVal Extent = R->getExtent(svalBuilder);
Jordy Rose32f26562010-07-04 00:00:41 +0000235 DefinedOrUnknownSVal DefinedSize = cast<DefinedOrUnknownSVal>(Size);
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000236 DefinedOrUnknownSVal extentMatchesSize =
Ted Kremenek9c149532010-12-01 21:57:22 +0000237 svalBuilder.evalEQ(state, Extent, DefinedSize);
Jordy Rose32f26562010-07-04 00:00:41 +0000238
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000239 state = state->assume(extentMatchesSize, true);
240 assert(state);
241
242 SymbolRef Sym = retVal.getAsLocSymbol();
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000243 assert(Sym);
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000244
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000245 // Set the symbol's state to Allocated.
Zhongxing Xub94b81a2009-12-31 06:13:07 +0000246 return state->set<RegionState>(Sym, RefState::getAllocateUnchecked(CE));
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000247}
248
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000249void MallocChecker::FreeMem(CheckerContext &C, const CallExpr *CE) const {
Ted Kremenek18c66fd2011-08-15 22:09:50 +0000250 const ProgramState *state = FreeMemAux(C, CE, C.getState(), 0, false);
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000251
252 if (state)
253 C.addTransition(state);
254}
255
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000256void MallocChecker::FreeMemAttr(CheckerContext &C, const CallExpr *CE,
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000257 const OwnershipAttr* Att) const {
Sean Huntcf807c42010-08-18 23:23:40 +0000258 if (Att->getModule() != "malloc")
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000259 return;
260
Sean Huntcf807c42010-08-18 23:23:40 +0000261 for (OwnershipAttr::args_iterator I = Att->args_begin(), E = Att->args_end();
262 I != E; ++I) {
Ted Kremenek18c66fd2011-08-15 22:09:50 +0000263 const ProgramState *state = FreeMemAux(C, CE, C.getState(), *I,
Sean Huntcf807c42010-08-18 23:23:40 +0000264 Att->getOwnKind() == OwnershipAttr::Holds);
265 if (state)
266 C.addTransition(state);
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000267 }
268}
269
Ted Kremenek18c66fd2011-08-15 22:09:50 +0000270const ProgramState *MallocChecker::FreeMemAux(CheckerContext &C, const CallExpr *CE,
271 const ProgramState *state, unsigned Num,
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000272 bool Hold) const {
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000273 const Expr *ArgExpr = CE->getArg(Num);
Jordy Rose43859f62010-06-07 19:32:37 +0000274 SVal ArgVal = state->getSVal(ArgExpr);
Zhongxing Xu181cc3d2010-02-14 06:49:48 +0000275
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000276 DefinedOrUnknownSVal location = cast<DefinedOrUnknownSVal>(ArgVal);
277
278 // Check for null dereferences.
279 if (!isa<Loc>(location))
Zhongxing Xu181cc3d2010-02-14 06:49:48 +0000280 return state;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000281
282 // FIXME: Technically using 'Assume' here can result in a path
283 // bifurcation. In such cases we need to return two states, not just one.
Ted Kremenek18c66fd2011-08-15 22:09:50 +0000284 const ProgramState *notNullState, *nullState;
Ted Kremenek28f47b92010-12-01 22:16:56 +0000285 llvm::tie(notNullState, nullState) = state->assume(location);
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000286
287 // The explicit NULL case, no operation is performed.
288 if (nullState && !notNullState)
289 return nullState;
290
291 assert(notNullState);
292
Jordy Rose43859f62010-06-07 19:32:37 +0000293 // Unknown values could easily be okay
294 // Undefined values are handled elsewhere
295 if (ArgVal.isUnknownOrUndef())
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000296 return notNullState;
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000297
Jordy Rose43859f62010-06-07 19:32:37 +0000298 const MemRegion *R = ArgVal.getAsRegion();
299
300 // Nonlocs can't be freed, of course.
301 // Non-region locations (labels and fixed addresses) also shouldn't be freed.
302 if (!R) {
303 ReportBadFree(C, ArgVal, ArgExpr->getSourceRange());
304 return NULL;
305 }
306
307 R = R->StripCasts();
308
309 // Blocks might show up as heap data, but should not be free()d
310 if (isa<BlockDataRegion>(R)) {
311 ReportBadFree(C, ArgVal, ArgExpr->getSourceRange());
312 return NULL;
313 }
314
315 const MemSpaceRegion *MS = R->getMemorySpace();
316
317 // Parameters, locals, statics, and globals shouldn't be freed.
318 if (!(isa<UnknownSpaceRegion>(MS) || isa<HeapSpaceRegion>(MS))) {
319 // FIXME: at the time this code was written, malloc() regions were
320 // represented by conjured symbols, which are all in UnknownSpaceRegion.
321 // This means that there isn't actually anything from HeapSpaceRegion
322 // that should be freed, even though we allow it here.
323 // Of course, free() can work on memory allocated outside the current
324 // function, so UnknownSpaceRegion is always a possibility.
325 // False negatives are better than false positives.
326
327 ReportBadFree(C, ArgVal, ArgExpr->getSourceRange());
328 return NULL;
329 }
330
331 const SymbolicRegion *SR = dyn_cast<SymbolicRegion>(R);
332 // Various cases could lead to non-symbol values here.
333 // For now, ignore them.
334 if (!SR)
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000335 return notNullState;
Jordy Rose43859f62010-06-07 19:32:37 +0000336
337 SymbolRef Sym = SR->getSymbol();
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000338 const RefState *RS = state->get<RegionState>(Sym);
Zhongxing Xu7e3cda92010-01-18 03:27:34 +0000339
340 // If the symbol has not been tracked, return. This is possible when free() is
341 // called on a pointer that does not get its pointee directly from malloc().
342 // Full support of this requires inter-procedural analysis.
343 if (!RS)
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000344 return notNullState;
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000345
346 // Check double free.
Zhongxing Xu243fde92009-11-17 07:54:15 +0000347 if (RS->isReleased()) {
Ted Kremenekd048c6e2010-12-20 21:19:09 +0000348 if (ExplodedNode *N = C.generateSink()) {
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000349 if (!BT_DoubleFree)
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000350 BT_DoubleFree.reset(
351 new BuiltinBug("Double free",
352 "Try to free a memory block that has been released"));
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000353 // FIXME: should find where it's freed last time.
354 BugReport *R = new BugReport(*BT_DoubleFree,
Benjamin Kramerd02e2322009-11-14 12:08:24 +0000355 BT_DoubleFree->getDescription(), N);
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000356 C.EmitReport(R);
357 }
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000358 return NULL;
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000359 }
360
361 // Normal free.
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000362 if (Hold)
363 return notNullState->set<RegionState>(Sym, RefState::getRelinquished(CE));
364 return notNullState->set<RegionState>(Sym, RefState::getReleased(CE));
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000365}
366
Ted Kremenek9c378f72011-08-12 23:37:29 +0000367bool MallocChecker::SummarizeValue(raw_ostream &os, SVal V) {
Jordy Rose43859f62010-06-07 19:32:37 +0000368 if (nonloc::ConcreteInt *IntVal = dyn_cast<nonloc::ConcreteInt>(&V))
369 os << "an integer (" << IntVal->getValue() << ")";
370 else if (loc::ConcreteInt *ConstAddr = dyn_cast<loc::ConcreteInt>(&V))
371 os << "a constant address (" << ConstAddr->getValue() << ")";
372 else if (loc::GotoLabel *Label = dyn_cast<loc::GotoLabel>(&V))
Chris Lattner68106302011-02-17 05:38:27 +0000373 os << "the address of the label '" << Label->getLabel()->getName() << "'";
Jordy Rose43859f62010-06-07 19:32:37 +0000374 else
375 return false;
376
377 return true;
378}
379
Ted Kremenek9c378f72011-08-12 23:37:29 +0000380bool MallocChecker::SummarizeRegion(raw_ostream &os,
Jordy Rose43859f62010-06-07 19:32:37 +0000381 const MemRegion *MR) {
382 switch (MR->getKind()) {
383 case MemRegion::FunctionTextRegionKind: {
384 const FunctionDecl *FD = cast<FunctionTextRegion>(MR)->getDecl();
385 if (FD)
386 os << "the address of the function '" << FD << "'";
387 else
388 os << "the address of a function";
389 return true;
390 }
391 case MemRegion::BlockTextRegionKind:
392 os << "block text";
393 return true;
394 case MemRegion::BlockDataRegionKind:
395 // FIXME: where the block came from?
396 os << "a block";
397 return true;
398 default: {
399 const MemSpaceRegion *MS = MR->getMemorySpace();
400
401 switch (MS->getKind()) {
402 case MemRegion::StackLocalsSpaceRegionKind: {
403 const VarRegion *VR = dyn_cast<VarRegion>(MR);
404 const VarDecl *VD;
405 if (VR)
406 VD = VR->getDecl();
407 else
408 VD = NULL;
409
410 if (VD)
411 os << "the address of the local variable '" << VD->getName() << "'";
412 else
413 os << "the address of a local stack variable";
414 return true;
415 }
416 case MemRegion::StackArgumentsSpaceRegionKind: {
417 const VarRegion *VR = dyn_cast<VarRegion>(MR);
418 const VarDecl *VD;
419 if (VR)
420 VD = VR->getDecl();
421 else
422 VD = NULL;
423
424 if (VD)
425 os << "the address of the parameter '" << VD->getName() << "'";
426 else
427 os << "the address of a parameter";
428 return true;
429 }
Ted Kremenekdcee3ce2010-07-01 20:16:50 +0000430 case MemRegion::NonStaticGlobalSpaceRegionKind:
431 case MemRegion::StaticGlobalSpaceRegionKind: {
Jordy Rose43859f62010-06-07 19:32:37 +0000432 const VarRegion *VR = dyn_cast<VarRegion>(MR);
433 const VarDecl *VD;
434 if (VR)
435 VD = VR->getDecl();
436 else
437 VD = NULL;
438
439 if (VD) {
440 if (VD->isStaticLocal())
441 os << "the address of the static variable '" << VD->getName() << "'";
442 else
443 os << "the address of the global variable '" << VD->getName() << "'";
444 } else
445 os << "the address of a global variable";
446 return true;
447 }
448 default:
449 return false;
450 }
451 }
452 }
453}
454
455void MallocChecker::ReportBadFree(CheckerContext &C, SVal ArgVal,
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000456 SourceRange range) const {
Ted Kremenekd048c6e2010-12-20 21:19:09 +0000457 if (ExplodedNode *N = C.generateSink()) {
Jordy Rose43859f62010-06-07 19:32:37 +0000458 if (!BT_BadFree)
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000459 BT_BadFree.reset(new BuiltinBug("Bad free"));
Jordy Rose43859f62010-06-07 19:32:37 +0000460
461 llvm::SmallString<100> buf;
462 llvm::raw_svector_ostream os(buf);
463
464 const MemRegion *MR = ArgVal.getAsRegion();
465 if (MR) {
466 while (const ElementRegion *ER = dyn_cast<ElementRegion>(MR))
467 MR = ER->getSuperRegion();
468
469 // Special case for alloca()
470 if (isa<AllocaRegion>(MR))
471 os << "Argument to free() was allocated by alloca(), not malloc()";
472 else {
473 os << "Argument to free() is ";
474 if (SummarizeRegion(os, MR))
475 os << ", which is not memory allocated by malloc()";
476 else
477 os << "not memory allocated by malloc()";
478 }
479 } else {
480 os << "Argument to free() is ";
481 if (SummarizeValue(os, ArgVal))
482 os << ", which is not memory allocated by malloc()";
483 else
484 os << "not memory allocated by malloc()";
485 }
486
Anna Zakse172e8b2011-08-17 23:00:25 +0000487 BugReport *R = new BugReport(*BT_BadFree, os.str(), N);
Jordy Rose43859f62010-06-07 19:32:37 +0000488 R->addRange(range);
489 C.EmitReport(R);
490 }
491}
492
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000493void MallocChecker::ReallocMem(CheckerContext &C, const CallExpr *CE) const {
Ted Kremenek18c66fd2011-08-15 22:09:50 +0000494 const ProgramState *state = C.getState();
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000495 const Expr *arg0Expr = CE->getArg(0);
496 DefinedOrUnknownSVal arg0Val
497 = cast<DefinedOrUnknownSVal>(state->getSVal(arg0Expr));
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000498
Ted Kremenek846eabd2010-12-01 21:28:31 +0000499 SValBuilder &svalBuilder = C.getSValBuilder();
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000500
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000501 DefinedOrUnknownSVal PtrEQ =
502 svalBuilder.evalEQ(state, arg0Val, svalBuilder.makeNull());
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000503
Lenny Maiorani4d8d8032011-04-27 14:49:29 +0000504 // Get the size argument. If there is no size arg then give up.
505 const Expr *Arg1 = CE->getArg(1);
506 if (!Arg1)
507 return;
508
509 // Get the value of the size argument.
510 DefinedOrUnknownSVal Arg1Val =
511 cast<DefinedOrUnknownSVal>(state->getSVal(Arg1));
512
513 // Compare the size argument to 0.
514 DefinedOrUnknownSVal SizeZero =
515 svalBuilder.evalEQ(state, Arg1Val,
516 svalBuilder.makeIntValWithPtrWidth(0, false));
517
518 // If the ptr is NULL and the size is not 0, the call is equivalent to
519 // malloc(size).
Ted Kremenek18c66fd2011-08-15 22:09:50 +0000520 const ProgramState *stateEqual = state->assume(PtrEQ, true);
Lenny Maiorani4d8d8032011-04-27 14:49:29 +0000521 if (stateEqual && state->assume(SizeZero, false)) {
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000522 // Hack: set the NULL symbolic region to released to suppress false warning.
523 // In the future we should add more states for allocated regions, e.g.,
524 // CheckedNull, CheckedNonNull.
525
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000526 SymbolRef Sym = arg0Val.getAsLocSymbol();
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000527 if (Sym)
528 stateEqual = stateEqual->set<RegionState>(Sym, RefState::getReleased(CE));
529
Ted Kremenek18c66fd2011-08-15 22:09:50 +0000530 const ProgramState *stateMalloc = MallocMemAux(C, CE, CE->getArg(1),
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000531 UndefinedVal(), stateEqual);
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000532 C.addTransition(stateMalloc);
533 }
534
Ted Kremenek18c66fd2011-08-15 22:09:50 +0000535 if (const ProgramState *stateNotEqual = state->assume(PtrEQ, false)) {
Lenny Maiorani4d8d8032011-04-27 14:49:29 +0000536 // If the size is 0, free the memory.
Ted Kremenek18c66fd2011-08-15 22:09:50 +0000537 if (const ProgramState *stateSizeZero = stateNotEqual->assume(SizeZero, true))
538 if (const ProgramState *stateFree =
Lenny Maiorani4d8d8032011-04-27 14:49:29 +0000539 FreeMemAux(C, CE, stateSizeZero, 0, false)) {
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000540
Zhongxing Xud56763f2011-09-01 04:53:59 +0000541 // Bind the return value to NULL because it is now free.
542 C.addTransition(stateFree->BindExpr(CE, svalBuilder.makeNull(), true));
Lenny Maiorani4d8d8032011-04-27 14:49:29 +0000543 }
Ted Kremenek18c66fd2011-08-15 22:09:50 +0000544 if (const ProgramState *stateSizeNotZero = stateNotEqual->assume(SizeZero,false))
545 if (const ProgramState *stateFree = FreeMemAux(C, CE, stateSizeNotZero,
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000546 0, false)) {
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000547 // FIXME: We should copy the content of the original buffer.
Ted Kremenek18c66fd2011-08-15 22:09:50 +0000548 const ProgramState *stateRealloc = MallocMemAux(C, CE, CE->getArg(1),
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000549 UnknownVal(), stateFree);
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000550 C.addTransition(stateRealloc);
551 }
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000552 }
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000553}
Zhongxing Xu7b760962009-11-13 07:25:27 +0000554
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000555void MallocChecker::CallocMem(CheckerContext &C, const CallExpr *CE) {
Ted Kremenek18c66fd2011-08-15 22:09:50 +0000556 const ProgramState *state = C.getState();
Ted Kremenek846eabd2010-12-01 21:28:31 +0000557 SValBuilder &svalBuilder = C.getSValBuilder();
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000558
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000559 SVal count = state->getSVal(CE->getArg(0));
560 SVal elementSize = state->getSVal(CE->getArg(1));
561 SVal TotalSize = svalBuilder.evalBinOp(state, BO_Mul, count, elementSize,
562 svalBuilder.getContext().getSizeType());
563 SVal zeroVal = svalBuilder.makeZeroVal(svalBuilder.getContext().CharTy);
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000564
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000565 C.addTransition(MallocMemAux(C, CE, TotalSize, zeroVal, state));
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000566}
567
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000568void MallocChecker::checkDeadSymbols(SymbolReaper &SymReaper,
569 CheckerContext &C) const
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000570{
Zhongxing Xu173ff562010-08-15 08:19:57 +0000571 if (!SymReaper.hasDeadSymbols())
572 return;
Zhongxing Xufc7ac8f2009-11-13 07:48:11 +0000573
Ted Kremenek18c66fd2011-08-15 22:09:50 +0000574 const ProgramState *state = C.getState();
Zhongxing Xu173ff562010-08-15 08:19:57 +0000575 RegionStateTy RS = state->get<RegionState>();
Jordy Rose90760142010-08-18 04:33:47 +0000576 RegionStateTy::Factory &F = state->get_context<RegionState>();
Zhongxing Xu173ff562010-08-15 08:19:57 +0000577
Ted Kremenek217470e2011-07-28 23:07:51 +0000578 bool generateReport = false;
579
Zhongxing Xu173ff562010-08-15 08:19:57 +0000580 for (RegionStateTy::iterator I = RS.begin(), E = RS.end(); I != E; ++I) {
581 if (SymReaper.isDead(I->first)) {
Ted Kremenek217470e2011-07-28 23:07:51 +0000582 if (I->second.isAllocated())
583 generateReport = true;
Jordy Rose90760142010-08-18 04:33:47 +0000584
585 // Remove the dead symbol from the map.
Ted Kremenek3baf6722010-11-24 00:54:37 +0000586 RS = F.remove(RS, I->first);
Ted Kremenek217470e2011-07-28 23:07:51 +0000587
Zhongxing Xufc7ac8f2009-11-13 07:48:11 +0000588 }
589 }
Ted Kremenek217470e2011-07-28 23:07:51 +0000590
591 ExplodedNode *N = C.generateNode(state->set<RegionState>(RS));
592
593 // FIXME: This does not handle when we have multiple leaks at a single
594 // place.
595 if (N && generateReport) {
596 if (!BT_Leak)
597 BT_Leak.reset(new BuiltinBug("Memory leak",
598 "Allocated memory never released. Potential memory leak."));
599 // FIXME: where it is allocated.
600 BugReport *R = new BugReport(*BT_Leak, BT_Leak->getDescription(), N);
601 C.EmitReport(R);
602 }
Zhongxing Xu7b760962009-11-13 07:25:27 +0000603}
Zhongxing Xu243fde92009-11-17 07:54:15 +0000604
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000605void MallocChecker::checkEndPath(EndOfFunctionNodeBuilder &B,
606 ExprEngine &Eng) const {
Ted Kremenek18c66fd2011-08-15 22:09:50 +0000607 const ProgramState *state = B.getState();
Jordy Rose09cef092010-08-18 04:26:59 +0000608 RegionStateTy M = state->get<RegionState>();
Zhongxing Xu243fde92009-11-17 07:54:15 +0000609
Jordy Rose09cef092010-08-18 04:26:59 +0000610 for (RegionStateTy::iterator I = M.begin(), E = M.end(); I != E; ++I) {
Zhongxing Xu243fde92009-11-17 07:54:15 +0000611 RefState RS = I->second;
612 if (RS.isAllocated()) {
Argyrios Kyrtzidisf178ac82011-02-23 21:04:49 +0000613 ExplodedNode *N = B.generateNode(state);
Zhongxing Xu243fde92009-11-17 07:54:15 +0000614 if (N) {
615 if (!BT_Leak)
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000616 BT_Leak.reset(new BuiltinBug("Memory leak",
617 "Allocated memory never released. Potential memory leak."));
Zhongxing Xu243fde92009-11-17 07:54:15 +0000618 BugReport *R = new BugReport(*BT_Leak, BT_Leak->getDescription(), N);
619 Eng.getBugReporter().EmitReport(R);
620 }
621 }
622 }
623}
Zhongxing Xu4985e3e2009-11-17 08:58:18 +0000624
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000625void MallocChecker::checkPreStmt(const ReturnStmt *S, CheckerContext &C) const {
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000626 const Expr *retExpr = S->getRetValue();
627 if (!retExpr)
Zhongxing Xu4985e3e2009-11-17 08:58:18 +0000628 return;
629
Ted Kremenek18c66fd2011-08-15 22:09:50 +0000630 const ProgramState *state = C.getState();
Zhongxing Xu4985e3e2009-11-17 08:58:18 +0000631
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000632 SymbolRef Sym = state->getSVal(retExpr).getAsSymbol();
Zhongxing Xu4985e3e2009-11-17 08:58:18 +0000633 if (!Sym)
634 return;
635
636 const RefState *RS = state->get<RegionState>(Sym);
637 if (!RS)
638 return;
639
640 // FIXME: check other cases.
641 if (RS->isAllocated())
642 state = state->set<RegionState>(Sym, RefState::getEscaped(S));
643
Ted Kremenek19d67b52009-11-23 22:22:01 +0000644 C.addTransition(state);
Zhongxing Xu4985e3e2009-11-17 08:58:18 +0000645}
Zhongxing Xub94b81a2009-12-31 06:13:07 +0000646
Ted Kremenek18c66fd2011-08-15 22:09:50 +0000647const ProgramState *MallocChecker::evalAssume(const ProgramState *state, SVal Cond,
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000648 bool Assumption) const {
Zhongxing Xub94b81a2009-12-31 06:13:07 +0000649 // If a symblic region is assumed to NULL, set its state to AllocateFailed.
650 // FIXME: should also check symbols assumed to non-null.
651
652 RegionStateTy RS = state->get<RegionState>();
653
654 for (RegionStateTy::iterator I = RS.begin(), E = RS.end(); I != E; ++I) {
Zhongxing Xu2bfa3012011-04-02 03:20:45 +0000655 // If the symbol is assumed to NULL, this will return an APSInt*.
Zhongxing Xub94b81a2009-12-31 06:13:07 +0000656 if (state->getSymVal(I.getKey()))
657 state = state->set<RegionState>(I.getKey(),RefState::getAllocateFailed());
658 }
659
660 return state;
661}
Zhongxing Xuc8023782010-03-10 04:58:55 +0000662
663// Check if the location is a freed symbolic region.
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000664void MallocChecker::checkLocation(SVal l, bool isLoad,CheckerContext &C) const {
Zhongxing Xuc8023782010-03-10 04:58:55 +0000665 SymbolRef Sym = l.getLocSymbolInBase();
666 if (Sym) {
667 const RefState *RS = C.getState()->get<RegionState>(Sym);
Ted Kremenekcea68652010-08-06 21:12:49 +0000668 if (RS && RS->isReleased()) {
Ted Kremenekd048c6e2010-12-20 21:19:09 +0000669 if (ExplodedNode *N = C.generateNode()) {
Zhongxing Xuc8023782010-03-10 04:58:55 +0000670 if (!BT_UseFree)
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000671 BT_UseFree.reset(new BuiltinBug("Use dynamically allocated memory "
672 "after it is freed."));
Zhongxing Xuc8023782010-03-10 04:58:55 +0000673
674 BugReport *R = new BugReport(*BT_UseFree, BT_UseFree->getDescription(),
675 N);
676 C.EmitReport(R);
677 }
Ted Kremenekcea68652010-08-06 21:12:49 +0000678 }
Zhongxing Xuc8023782010-03-10 04:58:55 +0000679 }
680}
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000681
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000682void MallocChecker::checkBind(SVal location, SVal val,CheckerContext &C) const {
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000683 // The PreVisitBind implements the same algorithm as already used by the
684 // Objective C ownership checker: if the pointer escaped from this scope by
685 // assignment, let it go. However, assigning to fields of a stack-storage
686 // structure does not transfer ownership.
687
Ted Kremenek18c66fd2011-08-15 22:09:50 +0000688 const ProgramState *state = C.getState();
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000689 DefinedOrUnknownSVal l = cast<DefinedOrUnknownSVal>(location);
690
691 // Check for null dereferences.
692 if (!isa<Loc>(l))
693 return;
694
695 // Before checking if the state is null, check if 'val' has a RefState.
696 // Only then should we check for null and bifurcate the state.
697 SymbolRef Sym = val.getLocSymbolInBase();
698 if (Sym) {
699 if (const RefState *RS = state->get<RegionState>(Sym)) {
700 // If ptr is NULL, no operation is performed.
Ted Kremenek18c66fd2011-08-15 22:09:50 +0000701 const ProgramState *notNullState, *nullState;
Ted Kremenek28f47b92010-12-01 22:16:56 +0000702 llvm::tie(notNullState, nullState) = state->assume(l);
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000703
704 // Generate a transition for 'nullState' to record the assumption
705 // that the state was null.
706 if (nullState)
707 C.addTransition(nullState);
708
709 if (!notNullState)
710 return;
711
712 if (RS->isAllocated()) {
713 // Something we presently own is being assigned somewhere.
714 const MemRegion *AR = location.getAsRegion();
715 if (!AR)
716 return;
717 AR = AR->StripCasts()->getBaseRegion();
718 do {
719 // If it is on the stack, we still own it.
720 if (AR->hasStackNonParametersStorage())
721 break;
722
723 // If the state can't represent this binding, we still own it.
Ted Kremenekdde201b2010-08-06 21:12:55 +0000724 if (notNullState == (notNullState->bindLoc(cast<Loc>(location),
725 UnknownVal())))
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000726 break;
727
728 // We no longer own this pointer.
Ted Kremenekdde201b2010-08-06 21:12:55 +0000729 notNullState =
730 notNullState->set<RegionState>(Sym,
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000731 RefState::getRelinquished(C.getStmt()));
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000732 }
733 while (false);
734 }
735 C.addTransition(notNullState);
736 }
737 }
738}
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000739
740void ento::registerMallocChecker(CheckerManager &mgr) {
741 mgr.registerChecker<MallocChecker>();
742}