blob: cbf5cf98b0be1cbfa02027095f09ff2e0e930069 [file] [log] [blame]
Daniel Jasperbac016b2012-12-03 18:12:45 +00001//===- unittest/Format/FormatTest.cpp - Formatting unit tests -------------===//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9
Manuel Klimekca547db2013-01-16 14:55:28 +000010#define DEBUG_TYPE "format-test"
11
Chandler Carruth1050e8b2012-12-04 09:45:34 +000012#include "clang/Format/Format.h"
Manuel Klimekca547db2013-01-16 14:55:28 +000013#include "../Tooling/RewriterTestContext.h"
Chandler Carruthb1ba0ef2013-01-19 08:09:44 +000014#include "clang/Lex/Lexer.h"
15#include "llvm/Support/Debug.h"
16#include "gtest/gtest.h"
Manuel Klimekca547db2013-01-16 14:55:28 +000017
Daniel Jasperbac016b2012-12-03 18:12:45 +000018namespace clang {
19namespace format {
20
21class FormatTest : public ::testing::Test {
22protected:
23 std::string format(llvm::StringRef Code, unsigned Offset, unsigned Length,
24 const FormatStyle &Style) {
Manuel Klimekca547db2013-01-16 14:55:28 +000025 DEBUG(llvm::errs() << "---\n");
Daniel Jasperbac016b2012-12-03 18:12:45 +000026 RewriterTestContext Context;
27 FileID ID = Context.createInMemoryFile("input.cc", Code);
28 SourceLocation Start =
29 Context.Sources.getLocForStartOfFile(ID).getLocWithOffset(Offset);
30 std::vector<CharSourceRange> Ranges(
31 1,
32 CharSourceRange::getCharRange(Start, Start.getLocWithOffset(Length)));
Daniel Jasper46ef8522013-01-10 13:08:12 +000033 Lexer Lex(ID, Context.Sources.getBuffer(ID), Context.Sources,
34 getFormattingLangOpts());
Daniel Jasper66d19bd2013-02-18 11:59:17 +000035 tooling::Replacements Replace = reformat(
36 Style, Lex, Context.Sources, Ranges, new IgnoringDiagConsumer());
Daniel Jasperafcbd852013-01-30 09:46:12 +000037 ReplacementCount = Replace.size();
Daniel Jasperbac016b2012-12-03 18:12:45 +000038 EXPECT_TRUE(applyAllReplacements(Replace, Context.Rewrite));
Manuel Klimekca547db2013-01-16 14:55:28 +000039 DEBUG(llvm::errs() << "\n" << Context.getRewrittenText(ID) << "\n\n");
Daniel Jasperbac016b2012-12-03 18:12:45 +000040 return Context.getRewrittenText(ID);
41 }
42
Daniel Jasper66d19bd2013-02-18 11:59:17 +000043 std::string
44 format(llvm::StringRef Code, const FormatStyle &Style = getLLVMStyle()) {
Daniel Jasperbac016b2012-12-03 18:12:45 +000045 return format(Code, 0, Code.size(), Style);
46 }
47
Daniel Jaspere35ec2b2012-12-18 19:56:56 +000048 std::string messUp(llvm::StringRef Code) {
49 std::string MessedUp(Code.str());
50 bool InComment = false;
Manuel Klimek526ed112013-01-09 15:25:02 +000051 bool InPreprocessorDirective = false;
Daniel Jaspere35ec2b2012-12-18 19:56:56 +000052 bool JustReplacedNewline = false;
53 for (unsigned i = 0, e = MessedUp.size() - 1; i != e; ++i) {
54 if (MessedUp[i] == '/' && MessedUp[i + 1] == '/') {
55 if (JustReplacedNewline)
56 MessedUp[i - 1] = '\n';
57 InComment = true;
Daniel Jaspere0b15ea2013-01-14 15:40:57 +000058 } else if (MessedUp[i] == '#' && (JustReplacedNewline || i == 0)) {
Daniel Jasper66d19bd2013-02-18 11:59:17 +000059 if (i != 0)
60 MessedUp[i - 1] = '\n';
Manuel Klimek526ed112013-01-09 15:25:02 +000061 InPreprocessorDirective = true;
Manuel Klimekd4397b92013-01-04 23:34:14 +000062 } else if (MessedUp[i] == '\\' && MessedUp[i + 1] == '\n') {
63 MessedUp[i] = ' ';
Manuel Klimek526ed112013-01-09 15:25:02 +000064 MessedUp[i + 1] = ' ';
Daniel Jaspere35ec2b2012-12-18 19:56:56 +000065 } else if (MessedUp[i] == '\n') {
66 if (InComment) {
67 InComment = false;
Manuel Klimek526ed112013-01-09 15:25:02 +000068 } else if (InPreprocessorDirective) {
69 InPreprocessorDirective = false;
Daniel Jaspere35ec2b2012-12-18 19:56:56 +000070 } else {
71 JustReplacedNewline = true;
72 MessedUp[i] = ' ';
73 }
Manuel Klimekd4397b92013-01-04 23:34:14 +000074 } else if (MessedUp[i] != ' ') {
75 JustReplacedNewline = false;
Daniel Jaspere35ec2b2012-12-18 19:56:56 +000076 }
Daniel Jasperbac016b2012-12-03 18:12:45 +000077 }
Daniel Jaspere35ec2b2012-12-18 19:56:56 +000078 return MessedUp;
79 }
80
Manuel Klimek060143e2013-01-02 18:33:23 +000081 FormatStyle getLLVMStyleWithColumns(unsigned ColumnLimit) {
82 FormatStyle Style = getLLVMStyle();
83 Style.ColumnLimit = ColumnLimit;
84 return Style;
85 }
86
Daniel Jasper6f5bb2c2013-01-14 16:24:39 +000087 FormatStyle getGoogleStyleWithColumns(unsigned ColumnLimit) {
88 FormatStyle Style = getGoogleStyle();
89 Style.ColumnLimit = ColumnLimit;
90 return Style;
91 }
92
Manuel Klimek060143e2013-01-02 18:33:23 +000093 void verifyFormat(llvm::StringRef Code,
94 const FormatStyle &Style = getLLVMStyle()) {
95 EXPECT_EQ(Code.str(), format(messUp(Code), Style));
Daniel Jasperbac016b2012-12-03 18:12:45 +000096 }
97
98 void verifyGoogleFormat(llvm::StringRef Code) {
Manuel Klimek060143e2013-01-02 18:33:23 +000099 verifyFormat(Code, getGoogleStyle());
Daniel Jasperbac016b2012-12-03 18:12:45 +0000100 }
Daniel Jasper4bfc65a2013-01-23 12:10:53 +0000101
102 void verifyIndependentOfContext(llvm::StringRef text) {
103 verifyFormat(text);
104 verifyFormat(llvm::Twine("void f() { " + text + " }").str());
105 }
Daniel Jasperafcbd852013-01-30 09:46:12 +0000106
107 int ReplacementCount;
Daniel Jasperbac016b2012-12-03 18:12:45 +0000108};
109
Manuel Klimek526ed112013-01-09 15:25:02 +0000110TEST_F(FormatTest, MessUp) {
111 EXPECT_EQ("1 2 3", messUp("1 2 3"));
112 EXPECT_EQ("1 2 3\n", messUp("1\n2\n3\n"));
113 EXPECT_EQ("a\n//b\nc", messUp("a\n//b\nc"));
114 EXPECT_EQ("a\n#b\nc", messUp("a\n#b\nc"));
115 EXPECT_EQ("a\n#b c d\ne", messUp("a\n#b\\\nc\\\nd\ne"));
116}
117
Alexander Kornienko15757312012-12-06 18:03:27 +0000118//===----------------------------------------------------------------------===//
119// Basic function tests.
120//===----------------------------------------------------------------------===//
121
Daniel Jasperbac016b2012-12-03 18:12:45 +0000122TEST_F(FormatTest, DoesNotChangeCorrectlyFormatedCode) {
123 EXPECT_EQ(";", format(";"));
124}
125
126TEST_F(FormatTest, FormatsGlobalStatementsAt0) {
127 EXPECT_EQ("int i;", format(" int i;"));
128 EXPECT_EQ("\nint i;", format(" \n\t \r int i;"));
129 EXPECT_EQ("int i;\nint j;", format(" int i; int j;"));
130 EXPECT_EQ("int i;\nint j;", format(" int i;\n int j;"));
131}
132
133TEST_F(FormatTest, FormatsUnwrappedLinesAtFirstFormat) {
134 EXPECT_EQ("int i;", format("int\ni;"));
135}
136
137TEST_F(FormatTest, FormatsNestedBlockStatements) {
Manuel Klimek36fab8d2013-01-10 13:24:24 +0000138 EXPECT_EQ("{\n {\n {}\n }\n}", format("{{{}}}"));
Daniel Jasperbac016b2012-12-03 18:12:45 +0000139}
140
Alexander Kornienko15757312012-12-06 18:03:27 +0000141TEST_F(FormatTest, FormatsNestedCall) {
142 verifyFormat("Method(f1, f2(f3));");
143 verifyFormat("Method(f1(f2, f3()));");
Daniel Jasper4e9008a2013-01-13 08:19:51 +0000144 verifyFormat("Method(f1(f2, (f3())));");
Alexander Kornienko15757312012-12-06 18:03:27 +0000145}
146
Daniel Jasperdaf1a152013-02-07 21:08:36 +0000147TEST_F(FormatTest, NestedNameSpecifiers) {
Daniel Jasper6b825c22013-01-16 07:19:28 +0000148 verifyFormat("vector< ::Type> v;");
Daniel Jasperdaf1a152013-02-07 21:08:36 +0000149 verifyFormat("::ns::SomeFunction(::ns::SomeOtherFunction())");
Daniel Jasper6b825c22013-01-16 07:19:28 +0000150}
151
Daniel Jasperafcbd852013-01-30 09:46:12 +0000152TEST_F(FormatTest, OnlyGeneratesNecessaryReplacements) {
153 EXPECT_EQ("if (a) {\n"
154 " f();\n"
Daniel Jasper66d19bd2013-02-18 11:59:17 +0000155 "}",
156 format("if(a){f();}"));
Daniel Jasperafcbd852013-01-30 09:46:12 +0000157 EXPECT_EQ(4, ReplacementCount);
158 EXPECT_EQ("if (a) {\n"
159 " f();\n"
Daniel Jasper66d19bd2013-02-18 11:59:17 +0000160 "}",
161 format("if (a) {\n"
162 " f();\n"
163 "}"));
Daniel Jasperafcbd852013-01-30 09:46:12 +0000164 EXPECT_EQ(0, ReplacementCount);
165}
166
Daniel Jasperc78c6b32013-02-14 09:58:41 +0000167TEST_F(FormatTest, RemovesTrailingWhitespaceOfFormattedLine) {
168 EXPECT_EQ("int a;\nint b;", format("int a; \nint b;", 0, 0, getLLVMStyle()));
Daniel Jasper516fb312013-03-01 18:11:39 +0000169 EXPECT_EQ("int a;", format("int a; "));
170 EXPECT_EQ("int a;\n", format("int a; \n \n \n "));
171 EXPECT_EQ("int a;\nint b; ",
172 format("int a; \nint b; ", 0, 0, getLLVMStyle()));
Daniel Jasperc78c6b32013-02-14 09:58:41 +0000173}
174
Daniel Jasper1eee6c42013-03-04 13:43:19 +0000175TEST_F(FormatTest, FormatsCorrectRegionForLeadingWhitespace) {
176 EXPECT_EQ("int b;\nint a;",
177 format("int b;\n int a;", 7, 0, getLLVMStyle()));
178 EXPECT_EQ("int b;\n int a;",
179 format("int b;\n int a;", 6, 0, getLLVMStyle()));
180
181 EXPECT_EQ("#define A \\\n"
182 " int a; \\\n"
183 " int b;",
184 format("#define A \\\n"
185 " int a; \\\n"
186 " int b;",
187 26, 0, getLLVMStyleWithColumns(12)));
188 EXPECT_EQ("#define A \\\n"
189 " int a; \\\n"
190 " int b;",
191 format("#define A \\\n"
192 " int a; \\\n"
193 " int b;",
194 25, 0, getLLVMStyleWithColumns(12)));
195}
196
Daniel Jasperf3023542013-03-07 20:50:00 +0000197TEST_F(FormatTest, RemovesWhitespaceWhenTriggeredOnEmptyLine) {
198 EXPECT_EQ("int a;\n\n int b;",
199 format("int a;\n \n\n int b;", 7, 0, getLLVMStyle()));
200 EXPECT_EQ("int a;\n\n int b;",
201 format("int a;\n \n\n int b;", 9, 0, getLLVMStyle()));
202}
203
Daniel Jasper29333162013-02-18 13:08:03 +0000204TEST_F(FormatTest, ReformatsMovedLines) {
205 EXPECT_EQ(
206 "template <typename T> T *getFETokenInfo() const {\n"
207 " return static_cast<T *>(FETokenInfo);\n"
208 "}\n"
209 " int a; // <- Should not be formatted",
210 format(
211 "template<typename T>\n"
212 "T *getFETokenInfo() const { return static_cast<T*>(FETokenInfo); }\n"
213 " int a; // <- Should not be formatted",
214 9, 5, getLLVMStyle()));
215}
216
Alexander Kornienko15757312012-12-06 18:03:27 +0000217//===----------------------------------------------------------------------===//
218// Tests for control statements.
219//===----------------------------------------------------------------------===//
220
221TEST_F(FormatTest, FormatIfWithoutCompountStatement) {
Daniel Jasper6f5bb2c2013-01-14 16:24:39 +0000222 verifyFormat("if (true)\n f();\ng();");
223 verifyFormat("if (a)\n if (b)\n if (c)\n g();\nh();");
Alexander Kornienko15757312012-12-06 18:03:27 +0000224 verifyFormat("if (a)\n if (b) {\n f();\n }\ng();");
Daniel Jasperdf3736a2013-01-16 15:44:34 +0000225
226 FormatStyle AllowsMergedIf = getGoogleStyle();
227 AllowsMergedIf.AllowShortIfStatementsOnASingleLine = true;
228 verifyFormat("if (a)\n"
229 " // comment\n"
Daniel Jasper66d19bd2013-02-18 11:59:17 +0000230 " f();",
231 AllowsMergedIf);
Daniel Jasperdf3736a2013-01-16 15:44:34 +0000232
233 verifyFormat("if (a) // Can't merge this\n"
Daniel Jasper66d19bd2013-02-18 11:59:17 +0000234 " f();\n",
235 AllowsMergedIf);
Daniel Jasperdf3736a2013-01-16 15:44:34 +0000236 verifyFormat("if (a) /* still don't merge */\n"
Daniel Jasper66d19bd2013-02-18 11:59:17 +0000237 " f();",
238 AllowsMergedIf);
Daniel Jasperdf3736a2013-01-16 15:44:34 +0000239 verifyFormat("if (a) { // Never merge this\n"
240 " f();\n"
Daniel Jasper66d19bd2013-02-18 11:59:17 +0000241 "}",
242 AllowsMergedIf);
Daniel Jasperdf3736a2013-01-16 15:44:34 +0000243 verifyFormat("if (a) { /* Never merge this */\n"
244 " f();\n"
Daniel Jasper66d19bd2013-02-18 11:59:17 +0000245 "}",
246 AllowsMergedIf);
Daniel Jasperdf3736a2013-01-16 15:44:34 +0000247
248 AllowsMergedIf.ColumnLimit = 14;
249 verifyFormat("if (a) return;", AllowsMergedIf);
Daniel Jasperfd0ca972013-01-14 16:02:06 +0000250 verifyFormat("if (aaaaaaaaa)\n"
Daniel Jasper66d19bd2013-02-18 11:59:17 +0000251 " return;",
252 AllowsMergedIf);
Daniel Jasperdf3736a2013-01-16 15:44:34 +0000253
254 AllowsMergedIf.ColumnLimit = 13;
255 verifyFormat("if (a)\n return;", AllowsMergedIf);
Alexander Kornienko15757312012-12-06 18:03:27 +0000256}
257
258TEST_F(FormatTest, ParseIfElse) {
259 verifyFormat("if (true)\n"
260 " if (true)\n"
261 " if (true)\n"
262 " f();\n"
263 " else\n"
264 " g();\n"
265 " else\n"
266 " h();\n"
267 "else\n"
268 " i();");
269 verifyFormat("if (true)\n"
270 " if (true)\n"
271 " if (true) {\n"
Daniel Jasper6f5bb2c2013-01-14 16:24:39 +0000272 " if (true)\n"
273 " f();\n"
Alexander Kornienko15757312012-12-06 18:03:27 +0000274 " } else {\n"
275 " g();\n"
276 " }\n"
277 " else\n"
278 " h();\n"
279 "else {\n"
280 " i();\n"
281 "}");
282}
283
284TEST_F(FormatTest, ElseIf) {
Manuel Klimek2f1ac412013-01-21 16:42:44 +0000285 verifyFormat("if (a) {\n} else if (b) {\n}");
Alexander Kornienko15757312012-12-06 18:03:27 +0000286 verifyFormat("if (a)\n"
287 " f();\n"
288 "else if (b)\n"
289 " g();\n"
290 "else\n"
291 " h();");
292}
293
Daniel Jasperbac016b2012-12-03 18:12:45 +0000294TEST_F(FormatTest, FormatsForLoop) {
295 verifyFormat(
296 "for (int VeryVeryLongLoopVariable = 0; VeryVeryLongLoopVariable < 10;\n"
Alexander Kornienko2e97cfc2012-12-05 15:06:06 +0000297 " ++VeryVeryLongLoopVariable)\n"
298 " ;");
299 verifyFormat("for (;;)\n"
300 " f();");
Manuel Klimek2f1ac412013-01-21 16:42:44 +0000301 verifyFormat("for (;;) {\n}");
Alexander Kornienko2e97cfc2012-12-05 15:06:06 +0000302 verifyFormat("for (;;) {\n"
303 " f();\n"
304 "}");
Daniel Jaspera324a0e2012-12-21 14:37:20 +0000305
306 verifyFormat(
307 "for (std::vector<UnwrappedLine>::iterator I = UnwrappedLines.begin(),\n"
308 " E = UnwrappedLines.end();\n"
Manuel Klimek2f1ac412013-01-21 16:42:44 +0000309 " I != E; ++I) {\n}");
Daniel Jaspera324a0e2012-12-21 14:37:20 +0000310
311 verifyFormat(
312 "for (MachineFun::iterator IIII = PrevIt, EEEE = F.end(); IIII != EEEE;\n"
Manuel Klimek2f1ac412013-01-21 16:42:44 +0000313 " ++IIIII) {\n}");
Daniel Jasper8ed9f2b2013-04-03 13:36:17 +0000314 verifyFormat("for (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaa =\n"
315 " aaaaaaaaaaaaaaaa.aaaaaaaaaaaaaaa;\n"
Daniel Jasper66d19bd2013-02-18 11:59:17 +0000316 " aaaaaaaaaaa != aaaaaaaaaaaaaaaaaaa; ++aaaaaaaaaaa) {\n}");
Daniel Jasper7d812812013-02-21 15:00:29 +0000317 verifyFormat("for (llvm::ArrayRef<NamedDecl *>::iterator\n"
318 " I = FD->getDeclsInPrototypeScope().begin(),\n"
319 " E = FD->getDeclsInPrototypeScope().end();\n"
320 " I != E; ++I) {\n}");
Daniel Jasper75223182013-01-28 17:30:17 +0000321
322 // FIXME: Not sure whether we want extra identation in line 3 here:
323 verifyFormat(
324 "for (aaaaaaaaaaaaaaaaa aaaaaaaaaaa = aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;\n"
325 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa !=\n"
Daniel Jasperf9955d32013-03-20 12:37:50 +0000326 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n"
327 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);\n"
Daniel Jasper75223182013-01-28 17:30:17 +0000328 " ++aaaaaaaaaaa) {\n}");
Daniel Jasperfaab0d32013-02-27 09:47:53 +0000329 verifyFormat("for (int aaaaaaaaaaa = 1; aaaaaaaaaaa <= bbbbbbbbbbbbbbb;\n"
330 " aaaaaaaaaaa++, bbbbbbbbbbbbbbbbb++) {\n"
331 "}");
Daniel Jasper8ed9f2b2013-04-03 13:36:17 +0000332 verifyFormat("for (some_namespace::SomeIterator iter( // force break\n"
333 " aaaaaaaaaa);\n"
334 " iter; ++iter) {\n"
335 "}");
Daniel Jasper8159d2f2013-02-04 07:30:30 +0000336
Daniel Jasperfaab0d32013-02-27 09:47:53 +0000337 FormatStyle NoBinPacking = getLLVMStyle();
338 NoBinPacking.BinPackParameters = false;
339 verifyFormat("for (int aaaaaaaaaaa = 1;\n"
340 " aaaaaaaaaaa <= aaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaa,\n"
341 " aaaaaaaaaaaaaaaa,\n"
342 " aaaaaaaaaaaaaaaa,\n"
343 " aaaaaaaaaaaaaaaa);\n"
344 " aaaaaaaaaaa++, bbbbbbbbbbbbbbbbb++) {\n"
345 "}",
346 NoBinPacking);
347 verifyFormat(
Daniel Jasper237d4c12013-02-23 21:01:55 +0000348 "for (std::vector<UnwrappedLine>::iterator I = UnwrappedLines.begin(),\n"
349 " E = UnwrappedLines.end();\n"
350 " I != E;\n"
Daniel Jasperfaab0d32013-02-27 09:47:53 +0000351 " ++I) {\n}",
352 NoBinPacking);
Daniel Jasperbac016b2012-12-03 18:12:45 +0000353}
354
Daniel Jasper3b9a8fc2013-01-28 13:21:16 +0000355TEST_F(FormatTest, RangeBasedForLoops) {
356 verifyFormat("for (auto aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa :\n"
357 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n}");
358 verifyFormat("for (auto aaaaaaaaaaaaaaaaaaaaa :\n"
359 " aaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaa, aaaaaaaaaaaaa)) {\n}");
Daniel Jasper84a1a632013-02-26 13:18:08 +0000360 verifyFormat("for (const aaaaaaaaaaaaaaaaaaaaa &aaaaaaaaa :\n"
361 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n}");
Daniel Jasper3b9a8fc2013-01-28 13:21:16 +0000362}
363
Daniel Jasperbac016b2012-12-03 18:12:45 +0000364TEST_F(FormatTest, FormatsWhileLoop) {
Manuel Klimek2f1ac412013-01-21 16:42:44 +0000365 verifyFormat("while (true) {\n}");
Alexander Kornienko2e97cfc2012-12-05 15:06:06 +0000366 verifyFormat("while (true)\n"
367 " f();");
Manuel Klimek2f1ac412013-01-21 16:42:44 +0000368 verifyFormat("while () {\n}");
Alexander Kornienko2e97cfc2012-12-05 15:06:06 +0000369 verifyFormat("while () {\n"
370 " f();\n"
371 "}");
Daniel Jasperbac016b2012-12-03 18:12:45 +0000372}
373
Alexander Kornienko15757312012-12-06 18:03:27 +0000374TEST_F(FormatTest, FormatsDoWhile) {
375 verifyFormat("do {\n"
376 " do_something();\n"
377 "} while (something());");
378 verifyFormat("do\n"
379 " do_something();\n"
380 "while (something());");
Daniel Jasperbac016b2012-12-03 18:12:45 +0000381}
382
Alexander Kornienko15757312012-12-06 18:03:27 +0000383TEST_F(FormatTest, FormatsSwitchStatement) {
Daniel Jasperbac016b2012-12-03 18:12:45 +0000384 verifyFormat("switch (x) {\n"
385 "case 1:\n"
386 " f();\n"
387 " break;\n"
388 "case kFoo:\n"
389 "case ns::kBar:\n"
390 "case kBaz:\n"
391 " break;\n"
392 "default:\n"
393 " g();\n"
394 " break;\n"
395 "}");
396 verifyFormat("switch (x) {\n"
397 "case 1: {\n"
398 " f();\n"
399 " break;\n"
400 "}\n"
401 "}");
Nico Weber94fb7292013-01-18 05:50:57 +0000402 verifyFormat("switch (x) {\n"
403 "case 1: {\n"
404 " f();\n"
405 " {\n"
406 " g();\n"
407 " h();\n"
408 " }\n"
409 " break;\n"
410 "}\n"
411 "}");
412 verifyFormat("switch (x) {\n"
413 "case 1: {\n"
414 " f();\n"
415 " if (foo) {\n"
416 " g();\n"
417 " h();\n"
418 " }\n"
419 " break;\n"
420 "}\n"
421 "}");
422 verifyFormat("switch (x) {\n"
423 "case 1: {\n"
424 " f();\n"
425 " g();\n"
426 "} break;\n"
427 "}");
Daniel Jasperbac016b2012-12-03 18:12:45 +0000428 verifyFormat("switch (test)\n"
429 " ;");
Daniel Jasper4ba9bfd2013-03-12 12:26:55 +0000430 verifyFormat("switch (x) {\n"
431 "default: {\n"
432 " // Do nothing.\n"
Manuel Klimek67d080d2013-04-12 14:13:36 +0000433 "}\n"
Daniel Jasper4ba9bfd2013-03-12 12:26:55 +0000434 "}");
Daniel Jasper6050a1e2013-03-13 15:53:12 +0000435 verifyFormat("switch (x) {\n"
Daniel Jasper5999f762013-04-09 17:46:55 +0000436 "// comment\n"
Daniel Jasper6050a1e2013-03-13 15:53:12 +0000437 "// if 1, do f()\n"
438 "case 1:\n"
439 " f();\n"
440 "}");
Daniel Jasperc30eb512013-03-19 18:33:58 +0000441 verifyFormat("switch (x) {\n"
442 "case 1:\n"
443 " // Do amazing stuff\n"
444 " {\n"
445 " f();\n"
446 " g();\n"
447 " }\n"
448 " break;\n"
449 "}");
Daniel Jasperbcca7e42013-03-20 10:23:53 +0000450 verifyFormat("#define A \\\n"
451 " switch (x) { \\\n"
452 " case a: \\\n"
453 " foo = b; \\\n"
454 " }", getLLVMStyleWithColumns(20));
Daniel Jasper66d19bd2013-02-18 11:59:17 +0000455
Alexander Kornienko15757312012-12-06 18:03:27 +0000456 verifyGoogleFormat("switch (x) {\n"
457 " case 1:\n"
458 " f();\n"
459 " break;\n"
460 " case kFoo:\n"
461 " case ns::kBar:\n"
462 " case kBaz:\n"
463 " break;\n"
464 " default:\n"
465 " g();\n"
466 " break;\n"
467 "}");
468 verifyGoogleFormat("switch (x) {\n"
469 " case 1: {\n"
470 " f();\n"
471 " break;\n"
472 " }\n"
473 "}");
474 verifyGoogleFormat("switch (test)\n"
475 " ;");
Daniel Jasperbac016b2012-12-03 18:12:45 +0000476}
477
Alexander Kornienko15757312012-12-06 18:03:27 +0000478TEST_F(FormatTest, FormatsLabels) {
Daniel Jasperbac016b2012-12-03 18:12:45 +0000479 verifyFormat("void f() {\n"
480 " some_code();\n"
481 "test_label:\n"
482 " some_other_code();\n"
483 " {\n"
484 " some_more_code();\n"
485 " another_label:\n"
486 " some_more_code();\n"
487 " }\n"
488 "}");
489 verifyFormat("some_code();\n"
490 "test_label:\n"
491 "some_other_code();");
492}
493
Alexander Kornienko15757312012-12-06 18:03:27 +0000494//===----------------------------------------------------------------------===//
495// Tests for comments.
496//===----------------------------------------------------------------------===//
497
498TEST_F(FormatTest, UnderstandsSingleLineComments) {
Daniel Jasperb64eca02013-03-22 10:01:29 +0000499 verifyFormat("//* */");
Daniel Jaspere35ec2b2012-12-18 19:56:56 +0000500 verifyFormat("// line 1\n"
501 "// line 2\n"
Manuel Klimek36fab8d2013-01-10 13:24:24 +0000502 "void f() {}\n");
Alexander Kornienko15757312012-12-06 18:03:27 +0000503
Daniel Jaspere35ec2b2012-12-18 19:56:56 +0000504 verifyFormat("void f() {\n"
505 " // Doesn't do anything\n"
506 "}");
Daniel Jasperdcc2a622013-01-18 08:44:07 +0000507 verifyFormat("void f(int i, // some comment (probably for i)\n"
508 " int j, // some comment (probably for j)\n"
Daniel Jasper487f64b2013-01-13 16:10:20 +0000509 " int k); // some comment (probably for k)");
510 verifyFormat("void f(int i,\n"
511 " // some comment (probably for j)\n"
512 " int j,\n"
513 " // some comment (probably for k)\n"
514 " int k);");
Alexander Kornienko15757312012-12-06 18:03:27 +0000515
Daniel Jasperdcc2a622013-01-18 08:44:07 +0000516 verifyFormat("int i // This is a fancy variable\n"
517 " = 5; // with nicely aligned comment.");
518
519 verifyFormat("// Leading comment.\n"
520 "int a; // Trailing comment.");
521 verifyFormat("int a; // Trailing comment\n"
522 " // on 2\n"
523 " // or 3 lines.\n"
524 "int b;");
525 verifyFormat("int a; // Trailing comment\n"
526 "\n"
527 "// Leading comment.\n"
528 "int b;");
529 verifyFormat("int a; // Comment.\n"
530 " // More details.\n"
531 "int bbbb; // Another comment.");
532 verifyFormat(
533 "int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa; // comment\n"
534 "int bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb; // comment\n"
535 "int cccccccccccccccccccccccccccccc; // comment\n"
536 "int ddd; // looooooooooooooooooooooooong comment\n"
537 "int aaaaaaaaaaaaaaaaaaaaaaa; // comment\n"
538 "int bbbbbbbbbbbbbbbbbbbbb; // comment\n"
539 "int ccccccccccccccccccc; // comment");
540
Daniel Jasper7d1185d2013-01-18 09:19:33 +0000541 verifyFormat("#include \"a\" // comment\n"
542 "#include \"a/b/c\" // comment");
543 verifyFormat("#include <a> // comment\n"
544 "#include <a/b/c> // comment");
Alexander Kornienko15757312012-12-06 18:03:27 +0000545
Daniel Jaspere35ec2b2012-12-18 19:56:56 +0000546 verifyFormat("enum E {\n"
547 " // comment\n"
Daniel Jasper7ad4eff2013-01-07 11:09:06 +0000548 " VAL_A, // comment\n"
Daniel Jaspere35ec2b2012-12-18 19:56:56 +0000549 " VAL_B\n"
550 "};");
Daniel Jasper05b1ac82012-12-17 11:29:41 +0000551
552 verifyFormat(
553 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa =\n"
Daniel Jasper7ad4eff2013-01-07 11:09:06 +0000554 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb; // Trailing comment");
Daniel Jasper043835a2013-01-09 09:33:39 +0000555 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa =\n"
556 " // Comment inside a statement.\n"
557 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb;");
Daniel Jasper36ba0ff2013-02-06 15:23:09 +0000558 verifyFormat(
559 "bool aaaaaaaaaaaaa = // comment\n"
560 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaaaaaaa ||\n"
561 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaaaaaaaa;");
Manuel Klimek6cf58142013-01-07 08:54:53 +0000562
Daniel Jasper42f458d2013-02-13 19:25:54 +0000563 verifyFormat("int aaaa; // aaaaa\n"
Daniel Jasper66d19bd2013-02-18 11:59:17 +0000564 "int aa; // aaaaaaa",
565 getLLVMStyleWithColumns(20));
Daniel Jasper42f458d2013-02-13 19:25:54 +0000566
Daniel Jasper821627e2013-01-21 22:49:20 +0000567 EXPECT_EQ("void f() { // This does something ..\n"
568 "}\n"
569 "int a; // This is unrelated",
570 format("void f() { // This does something ..\n"
571 " }\n"
572 "int a; // This is unrelated"));
573 EXPECT_EQ("void f() { // This does something ..\n"
574 "} // awesome..\n"
575 "\n"
576 "int a; // This is unrelated",
577 format("void f() { // This does something ..\n"
578 " } // awesome..\n"
579 " \n"
580 "int a; // This is unrelated"));
581
Daniel Jasper7ad4eff2013-01-07 11:09:06 +0000582 EXPECT_EQ("int i; // single line trailing comment",
Manuel Klimek6cf58142013-01-07 08:54:53 +0000583 format("int i;\\\n// single line trailing comment"));
Daniel Jasper7ad4eff2013-01-07 11:09:06 +0000584
585 verifyGoogleFormat("int a; // Trailing comment.");
Daniel Jasperd4f2c2e2013-01-29 19:41:55 +0000586
587 verifyFormat("someFunction(anotherFunction( // Force break.\n"
588 " parameter));");
Daniel Jasper5b7e7b02013-02-05 09:34:14 +0000589
590 verifyGoogleFormat("#endif // HEADER_GUARD");
Daniel Jasper474e4622013-02-06 22:04:05 +0000591
592 verifyFormat("const char *test[] = {\n"
593 " // A\n"
594 " \"aaaa\",\n"
595 " // B\n"
596 " \"aaaaa\",\n"
597 "};");
Daniel Jasper729a7432013-02-11 12:36:37 +0000598 verifyGoogleFormat(
599 "aaaaaaaaaaaaaaaaaaaaaaaaaa(\n"
600 " aaaaaaaaaaaaaaaaaaaaaa); // 81 cols with this comment");
Alexander Kornienko4128e192013-04-03 12:38:53 +0000601 EXPECT_EQ("D(a, {\n"
602 " // test\n"
603 " int a;\n"
604 "});",
605 format("D(a, {\n"
606 "// test\n"
607 "int a;\n"
608 "});"));
Daniel Jasper05b1ac82012-12-17 11:29:41 +0000609}
610
Daniel Jasperc363dbb2013-03-22 16:25:51 +0000611TEST_F(FormatTest, CanFormatCommentsLocally) {
612 EXPECT_EQ("int a; // comment\n"
613 "int b; // comment",
614 format("int a; // comment\n"
615 "int b; // comment",
616 0, 0, getLLVMStyle()));
617 EXPECT_EQ("int a; // comment\n"
618 " // line 2\n"
619 "int b;",
620 format("int a; // comment\n"
621 " // line 2\n"
622 "int b;",
623 28, 0, getLLVMStyle()));
624}
625
Daniel Jasper812c0452013-03-01 16:45:59 +0000626TEST_F(FormatTest, RemovesTrailingWhitespaceOfComments) {
627 EXPECT_EQ("// comment", format("// comment "));
628 EXPECT_EQ("int aaaaaaa, bbbbbbb; // comment",
629 format("int aaaaaaa, bbbbbbb; // comment ",
630 getLLVMStyleWithColumns(33)));
631}
632
Daniel Jasper05b1ac82012-12-17 11:29:41 +0000633TEST_F(FormatTest, UnderstandsMultiLineComments) {
Alexander Kornienko15757312012-12-06 18:03:27 +0000634 verifyFormat("f(/*test=*/ true);");
Daniel Jasper2c6cc482013-01-17 12:53:34 +0000635 EXPECT_EQ(
636 "f(aaaaaaaaaaaaaaaaaaaaaaaaa, /* Trailing comment for aa... */\n"
637 " bbbbbbbbbbbbbbbbbbbbbbbbb);",
638 format("f(aaaaaaaaaaaaaaaaaaaaaaaaa , /* Trailing comment for aa... */\n"
639 " bbbbbbbbbbbbbbbbbbbbbbbbb);"));
640 EXPECT_EQ(
641 "f(aaaaaaaaaaaaaaaaaaaaaaaaa,\n"
642 " /* Leading comment for bb... */ bbbbbbbbbbbbbbbbbbbbbbbbb);",
643 format("f(aaaaaaaaaaaaaaaaaaaaaaaaa , \n"
644 "/* Leading comment for bb... */ bbbbbbbbbbbbbbbbbbbbbbbbb);"));
Daniel Jasperd4f2c2e2013-01-29 19:41:55 +0000645
Daniel Jasperfaab0d32013-02-27 09:47:53 +0000646 FormatStyle NoBinPacking = getLLVMStyle();
647 NoBinPacking.BinPackParameters = false;
648 verifyFormat("aaaaaaaa(/* parameter 1 */ aaaaaa,\n"
649 " /* parameter 2 */ aaaaaa,\n"
650 " /* parameter 3 */ aaaaaa,\n"
651 " /* parameter 4 */ aaaaaa);",
652 NoBinPacking);
Daniel Jasper2c6cc482013-01-17 12:53:34 +0000653}
654
Alexander Kornienkof7536152013-03-14 16:10:54 +0000655TEST_F(FormatTest, AlignsMultiLineComments) {
656 EXPECT_EQ("/*\n"
657 " * Really multi-line\n"
658 " * comment.\n"
659 " */\n"
660 "void f() {}",
661 format(" /*\n"
662 " * Really multi-line\n"
663 " * comment.\n"
664 " */\n"
665 " void f() {}"));
Alexander Kornienkof7536152013-03-14 16:10:54 +0000666 EXPECT_EQ("class C {\n"
667 " /*\n"
668 " * Another multi-line\n"
669 " * comment.\n"
670 " */\n"
671 " void f() {}\n"
672 "};",
673 format("class C {\n"
674 "/*\n"
675 " * Another multi-line\n"
676 " * comment.\n"
677 " */\n"
678 "void f() {}\n"
679 "};"));
Alexander Kornienko1fdd8b32013-03-15 13:42:02 +0000680 EXPECT_EQ("/*\n"
681 " 1. This is a comment with non-trivial formatting.\n"
682 " 1.1. We have to indent/outdent all lines equally\n"
683 " 1.1.1. to keep the formatting.\n"
684 " */",
685 format(" /*\n"
686 " 1. This is a comment with non-trivial formatting.\n"
687 " 1.1. We have to indent/outdent all lines equally\n"
688 " 1.1.1. to keep the formatting.\n"
689 " */"));
690 EXPECT_EQ("/*\n"
691 " Don't try to outdent if there's not enough inentation.\n"
692 " */",
693 format(" /*\n"
694 " Don't try to outdent if there's not enough inentation.\n"
695 " */"));
Alexander Kornienkof7536152013-03-14 16:10:54 +0000696}
697
Alexander Kornienko5262dd92013-03-27 11:52:18 +0000698TEST_F(FormatTest, SplitsLongCxxComments) {
699 EXPECT_EQ("// A comment that\n"
700 "// doesn't fit on\n"
701 "// one line",
702 format("// A comment that doesn't fit on one line",
703 getLLVMStyleWithColumns(20)));
704 EXPECT_EQ("if (true) // A comment that\n"
705 " // doesn't fit on\n"
706 " // one line",
707 format("if (true) // A comment that doesn't fit on one line ",
708 getLLVMStyleWithColumns(30)));
709 EXPECT_EQ("// Don't_touch_leading_whitespace",
710 format("// Don't_touch_leading_whitespace",
711 getLLVMStyleWithColumns(20)));
712 EXPECT_EQ(
713 "//Don't add leading\n"
714 "//whitespace",
715 format("//Don't add leading whitespace", getLLVMStyleWithColumns(20)));
Alexander Kornienko9fdc00a2013-03-28 18:40:55 +0000716 EXPECT_EQ("// A comment before\n"
717 "// a macro\n"
718 "// definition\n"
719 "#define a b",
720 format("// A comment before a macro definition\n"
721 "#define a b",
722 getLLVMStyleWithColumns(20)));
Alexander Kornienko5262dd92013-03-27 11:52:18 +0000723}
724
Alexander Kornienkof52d5272013-04-02 13:04:06 +0000725TEST_F(FormatTest, ParsesCommentsAdjacentToPPDirectives) {
726 EXPECT_EQ("namespace {}\n// Test\n#define A",
727 format("namespace {}\n // Test\n#define A"));
728 EXPECT_EQ("namespace {}\n/* Test */\n#define A",
729 format("namespace {}\n /* Test */\n#define A"));
730 EXPECT_EQ("namespace {}\n/* Test */ #define A",
731 format("namespace {}\n /* Test */ #define A"));
732}
733
Alexander Kornienko052685c2013-03-19 17:41:36 +0000734TEST_F(FormatTest, SplitsLongLinesInComments) {
735 EXPECT_EQ("/* This is a long\n"
Alexander Kornienko7c22cf32013-03-21 12:28:10 +0000736 " * comment that\n"
737 " * doesn't\n"
738 " * fit on one line.\n"
739 " */",
Alexander Kornienko052685c2013-03-19 17:41:36 +0000740 format("/* "
741 "This is a long "
Alexander Kornienko7c22cf32013-03-21 12:28:10 +0000742 "comment that "
743 "doesn't "
Alexander Kornienko052685c2013-03-19 17:41:36 +0000744 "fit on one line. */",
745 getLLVMStyleWithColumns(20)));
746 EXPECT_EQ("/*\n"
747 "This is a long\n"
748 "comment that doesn't\n"
749 "fit on one line.\n"
750 "*/",
751 format("/*\n"
752 "This is a long "
753 "comment that doesn't "
754 "fit on one line. \n"
755 "*/", getLLVMStyleWithColumns(20)));
756 EXPECT_EQ("/*\n"
757 " * This is a long\n"
758 " * comment that\n"
759 " * doesn't fit on\n"
760 " * one line.\n"
761 " */",
Alexander Kornienko7c22cf32013-03-21 12:28:10 +0000762 format("/* \n"
Alexander Kornienko052685c2013-03-19 17:41:36 +0000763 " * This is a long "
764 " comment that "
765 " doesn't fit on "
766 " one line. \n"
767 " */", getLLVMStyleWithColumns(20)));
768 EXPECT_EQ("/*\n"
769 " * This_is_a_comment_with_words_that_dont_fit_on_one_line\n"
770 " * so_it_should_be_broken\n"
771 " * wherever_a_space_occurs\n"
772 " */",
773 format("/*\n"
774 " * This_is_a_comment_with_words_that_dont_fit_on_one_line "
775 " so_it_should_be_broken "
776 " wherever_a_space_occurs \n"
777 " */",
778 getLLVMStyleWithColumns(20)));
779 EXPECT_EQ("/*\n"
Alexander Kornienko5262dd92013-03-27 11:52:18 +0000780 " * This_comment_can_not_be_broken_into_lines\n"
Alexander Kornienko052685c2013-03-19 17:41:36 +0000781 " */",
782 format("/*\n"
Alexander Kornienko5262dd92013-03-27 11:52:18 +0000783 " * This_comment_can_not_be_broken_into_lines\n"
Alexander Kornienko052685c2013-03-19 17:41:36 +0000784 " */",
785 getLLVMStyleWithColumns(20)));
786 EXPECT_EQ("{\n"
787 " /*\n"
788 " This is another\n"
789 " long comment that\n"
790 " doesn't fit on one\n"
791 " line 1234567890\n"
792 " */\n"
793 "}",
794 format("{\n"
795 "/*\n"
796 "This is another "
797 " long comment that "
798 " doesn't fit on one"
799 " line 1234567890\n"
800 "*/\n"
801 "}", getLLVMStyleWithColumns(20)));
802 EXPECT_EQ("{\n"
803 " /*\n"
804 " * This i s\n"
805 " * another comment\n"
806 " * t hat doesn' t\n"
807 " * fit on one l i\n"
808 " * n e\n"
809 " */\n"
810 "}",
811 format("{\n"
812 "/*\n"
813 " * This i s"
814 " another comment"
815 " t hat doesn' t"
816 " fit on one l i"
817 " n e\n"
818 " */\n"
819 "}", getLLVMStyleWithColumns(20)));
820 EXPECT_EQ("/*\n"
821 " * This is a long\n"
822 " * comment that\n"
823 " * doesn't fit on\n"
824 " * one line\n"
825 " */",
826 format(" /*\n"
827 " * This is a long comment that doesn't fit on one line\n"
828 " */", getLLVMStyleWithColumns(20)));
Alexander Kornienko7c22cf32013-03-21 12:28:10 +0000829 EXPECT_EQ("{\n"
830 " if (something) /* This is a\n"
831 "long comment */\n"
832 " ;\n"
833 "}",
834 format("{\n"
835 " if (something) /* This is a long comment */\n"
836 " ;\n"
837 "}",
838 getLLVMStyleWithColumns(30)));
Alexander Kornienko052685c2013-03-19 17:41:36 +0000839}
840
841TEST_F(FormatTest, SplitsLongLinesInCommentsInPreprocessor) {
842 EXPECT_EQ("#define X \\\n"
Alexander Kornienko7c22cf32013-03-21 12:28:10 +0000843 " /* \\\n"
844 " Test \\\n"
Alexander Kornienko052685c2013-03-19 17:41:36 +0000845 " Macro comment \\\n"
846 " with a long \\\n"
847 " line \\\n"
Alexander Kornienko70ce7882013-04-15 14:28:00 +0000848 " */ \\\n"
Alexander Kornienko052685c2013-03-19 17:41:36 +0000849 " A + B",
850 format("#define X \\\n"
851 " /*\n"
Alexander Kornienko7c22cf32013-03-21 12:28:10 +0000852 " Test\n"
Alexander Kornienko052685c2013-03-19 17:41:36 +0000853 " Macro comment with a long line\n"
854 " */ \\\n"
855 " A + B",
856 getLLVMStyleWithColumns(20)));
857 EXPECT_EQ("#define X \\\n"
858 " /* Macro comment \\\n"
Alexander Kornienko7c22cf32013-03-21 12:28:10 +0000859 " with a long \\\n"
Alexander Kornienko70ce7882013-04-15 14:28:00 +0000860 " line */ \\\n"
Alexander Kornienko7c22cf32013-03-21 12:28:10 +0000861 " A + B",
862 format("#define X \\\n"
863 " /* Macro comment with a long\n"
864 " line */ \\\n"
865 " A + B",
866 getLLVMStyleWithColumns(20)));
867 EXPECT_EQ("#define X \\\n"
868 " /* Macro comment \\\n"
869 " * with a long \\\n"
Alexander Kornienko70ce7882013-04-15 14:28:00 +0000870 " * line */ \\\n"
Alexander Kornienko052685c2013-03-19 17:41:36 +0000871 " A + B",
872 format("#define X \\\n"
873 " /* Macro comment with a long line */ \\\n"
874 " A + B",
875 getLLVMStyleWithColumns(20)));
876}
877
Daniel Jasper2c6cc482013-01-17 12:53:34 +0000878TEST_F(FormatTest, CommentsInStaticInitializers) {
879 EXPECT_EQ(
880 "static SomeType type = { aaaaaaaaaaaaaaaaaaaa, /* comment */\n"
881 " aaaaaaaaaaaaaaaaaaaa /* comment */,\n"
882 " /* comment */ aaaaaaaaaaaaaaaaaaaa,\n"
883 " aaaaaaaaaaaaaaaaaaaa, // comment\n"
884 " aaaaaaaaaaaaaaaaaaaa };",
885 format("static SomeType type = { aaaaaaaaaaaaaaaaaaaa , /* comment */\n"
886 " aaaaaaaaaaaaaaaaaaaa /* comment */ ,\n"
887 " /* comment */ aaaaaaaaaaaaaaaaaaaa ,\n"
888 " aaaaaaaaaaaaaaaaaaaa , // comment\n"
889 " aaaaaaaaaaaaaaaaaaaa };"));
890 verifyFormat("static SomeType type = { aaaaaaaaaaa, // comment for aa...\n"
891 " bbbbbbbbbbb, ccccccccccc };");
892 verifyFormat("static SomeType type = { aaaaaaaaaaa,\n"
893 " // comment for bb....\n"
894 " bbbbbbbbbbb, ccccccccccc };");
895 verifyGoogleFormat(
896 "static SomeType type = { aaaaaaaaaaa, // comment for aa...\n"
Daniel Jasperf343cab2013-01-31 14:59:26 +0000897 " bbbbbbbbbbb, ccccccccccc };");
Daniel Jasper2c6cc482013-01-17 12:53:34 +0000898 verifyGoogleFormat("static SomeType type = { aaaaaaaaaaa,\n"
899 " // comment for bb....\n"
Daniel Jasperf343cab2013-01-31 14:59:26 +0000900 " bbbbbbbbbbb, ccccccccccc };");
Daniel Jasper2c6cc482013-01-17 12:53:34 +0000901
Daniel Jasperf343cab2013-01-31 14:59:26 +0000902 verifyFormat("S s = { { a, b, c }, // Group #1\n"
903 " { d, e, f }, // Group #2\n"
904 " { g, h, i } }; // Group #3");
905 verifyFormat("S s = { { // Group #1\n"
906 " a, b, c },\n"
907 " { // Group #2\n"
908 " d, e, f },\n"
909 " { // Group #3\n"
910 " g, h, i } };");
Daniel Jasperc4615b72013-02-20 12:56:39 +0000911
912 EXPECT_EQ("S s = {\n"
913 " // Some comment\n"
Daniel Jasper1ef81d52013-02-26 13:10:34 +0000914 " a,\n"
Daniel Jasperc4615b72013-02-20 12:56:39 +0000915 "\n"
916 " // Comment after empty line\n"
917 " b\n"
Daniel Jasper1ef81d52013-02-26 13:10:34 +0000918 "}",
919 format("S s = {\n"
920 " // Some comment\n"
921 " a,\n"
922 " \n"
923 " // Comment after empty line\n"
924 " b\n"
925 "}"));
926 EXPECT_EQ("S s = { a, b };", format("S s = {\n"
Daniel Jasper84a1a632013-02-26 13:18:08 +0000927 " a,\n"
928 "\n"
929 " b\n"
930 "};"));
Daniel Jasper25e81b22013-02-28 15:04:12 +0000931 verifyFormat("const uint8_t aaaaaaaaaaaaaaaaaaaaaa[0] = {\n"
932 " 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, // comment\n"
933 " 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, // comment\n"
934 " 0x00, 0x00, 0x00, 0x00 // comment\n"
935 "};");
Alexander Kornienko15757312012-12-06 18:03:27 +0000936}
937
Alexander Kornienko15757312012-12-06 18:03:27 +0000938//===----------------------------------------------------------------------===//
939// Tests for classes, namespaces, etc.
940//===----------------------------------------------------------------------===//
941
942TEST_F(FormatTest, DoesNotBreakSemiAfterClassDecl) {
Manuel Klimek2f1ac412013-01-21 16:42:44 +0000943 verifyFormat("class A {\n};");
Alexander Kornienko15757312012-12-06 18:03:27 +0000944}
945
946TEST_F(FormatTest, UnderstandsAccessSpecifiers) {
947 verifyFormat("class A {\n"
948 "public:\n"
Daniel Jasperac3223e2013-04-10 09:49:49 +0000949 "public: // comment\n"
Alexander Kornienko15757312012-12-06 18:03:27 +0000950 "protected:\n"
951 "private:\n"
Manuel Klimek36fab8d2013-01-10 13:24:24 +0000952 " void f() {}\n"
Alexander Kornienko15757312012-12-06 18:03:27 +0000953 "};");
954 verifyGoogleFormat("class A {\n"
955 " public:\n"
956 " protected:\n"
957 " private:\n"
Manuel Klimek36fab8d2013-01-10 13:24:24 +0000958 " void f() {}\n"
Alexander Kornienko15757312012-12-06 18:03:27 +0000959 "};");
960}
961
Alexander Kornienko94b748f2013-03-27 17:08:02 +0000962TEST_F(FormatTest, SeparatesLogicalBlocks) {
963 EXPECT_EQ("class A {\n"
964 "public:\n"
965 " void f();\n"
966 "\n"
967 "private:\n"
968 " void g() {}\n"
969 " // test\n"
970 "protected:\n"
971 " int h;\n"
972 "};",
973 format("class A {\n"
974 "public:\n"
975 "void f();\n"
976 "private:\n"
977 "void g() {}\n"
978 "// test\n"
979 "protected:\n"
980 "int h;\n"
981 "};"));
982}
983
Daniel Jasper6b119d62013-04-05 17:22:09 +0000984TEST_F(FormatTest, FormatsClasses) {
Manuel Klimek2f1ac412013-01-21 16:42:44 +0000985 verifyFormat("class A : public B {\n};");
986 verifyFormat("class A : public ::B {\n};");
Daniel Jasper6cabab42013-02-14 08:42:54 +0000987
988 verifyFormat(
989 "class AAAAAAAAAAAAAAAAAAAA : public BBBBBBBBBBBBBBBBBBBBBBBBBBBBBB,\n"
990 " public CCCCCCCCCCCCCCCCCCCCCCCCCCCCCC {\n"
991 "};\n");
992 verifyFormat("class AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA :\n"
993 " public BBBBBBBBBBBBBBBBBBBBBBBBBBBBBB,\n"
994 " public CCCCCCCCCCCCCCCCCCCCCCCCCCCCCC {\n"
995 "};\n");
996 verifyFormat(
997 "class A : public B, public C, public D, public E, public F, public G {\n"
998 "};");
999 verifyFormat("class AAAAAAAAAAAA : public B,\n"
1000 " public C,\n"
1001 " public D,\n"
1002 " public E,\n"
1003 " public F,\n"
1004 " public G {\n"
1005 "};");
Daniel Jasper6b119d62013-04-05 17:22:09 +00001006
1007 verifyFormat("class\n"
1008 " ReallyReallyLongClassName {\n};",
1009 getLLVMStyleWithColumns(32));
Daniel Jasperbac016b2012-12-03 18:12:45 +00001010}
1011
Manuel Klimekde768542013-01-07 18:10:23 +00001012TEST_F(FormatTest, FormatsVariableDeclarationsAfterStructOrClass) {
Manuel Klimek2f1ac412013-01-21 16:42:44 +00001013 verifyFormat("class A {\n} a, b;");
1014 verifyFormat("struct A {\n} a, b;");
1015 verifyFormat("union A {\n} a;");
Manuel Klimekde768542013-01-07 18:10:23 +00001016}
1017
Alexander Kornienko15757312012-12-06 18:03:27 +00001018TEST_F(FormatTest, FormatsEnum) {
Alexander Kornienkoa166e732012-12-04 14:46:19 +00001019 verifyFormat("enum {\n"
1020 " Zero,\n"
1021 " One = 1,\n"
1022 " Two = One + 1,\n"
1023 " Three = (One + Two),\n"
1024 " Four = (Zero && (One ^ Two)) | (One << Two),\n"
1025 " Five = (One, Two, Three, Four, 5)\n"
1026 "};");
1027 verifyFormat("enum Enum {\n"
1028 "};");
1029 verifyFormat("enum {\n"
1030 "};");
Manuel Klimek308232c2013-01-21 19:17:52 +00001031 verifyFormat("enum X E {\n} d;");
1032 verifyFormat("enum __attribute__((...)) E {\n} d;");
1033 verifyFormat("enum __declspec__((...)) E {\n} d;");
1034 verifyFormat("enum X f() {\n a();\n return 42;\n}");
Alexander Kornienkoa166e732012-12-04 14:46:19 +00001035}
1036
Nico Weberefaddc02013-01-14 05:49:49 +00001037TEST_F(FormatTest, FormatsBitfields) {
1038 verifyFormat("struct Bitfields {\n"
1039 " unsigned sClass : 8;\n"
1040 " unsigned ValueKind : 2;\n"
1041 "};");
1042}
1043
Alexander Kornienko15757312012-12-06 18:03:27 +00001044TEST_F(FormatTest, FormatsNamespaces) {
1045 verifyFormat("namespace some_namespace {\n"
Manuel Klimek2f1ac412013-01-21 16:42:44 +00001046 "class A {\n};\n"
Manuel Klimek517e8942013-01-11 17:54:10 +00001047 "void f() { f(); }\n"
Alexander Kornienko15757312012-12-06 18:03:27 +00001048 "}");
1049 verifyFormat("namespace {\n"
Manuel Klimek2f1ac412013-01-21 16:42:44 +00001050 "class A {\n};\n"
Manuel Klimek517e8942013-01-11 17:54:10 +00001051 "void f() { f(); }\n"
Alexander Kornienko15757312012-12-06 18:03:27 +00001052 "}");
Dmitri Gribenko1f94f2b2012-12-30 21:27:25 +00001053 verifyFormat("inline namespace X {\n"
Manuel Klimek2f1ac412013-01-21 16:42:44 +00001054 "class A {\n};\n"
Manuel Klimek517e8942013-01-11 17:54:10 +00001055 "void f() { f(); }\n"
Dmitri Gribenko1f94f2b2012-12-30 21:27:25 +00001056 "}");
Alexander Kornienko15757312012-12-06 18:03:27 +00001057 verifyFormat("using namespace some_namespace;\n"
Manuel Klimek2f1ac412013-01-21 16:42:44 +00001058 "class A {\n};\n"
Manuel Klimek517e8942013-01-11 17:54:10 +00001059 "void f() { f(); }");
Manuel Klimek7fc2db02013-02-06 16:08:09 +00001060
1061 // This code is more common than we thought; if we
1062 // layout this correctly the semicolon will go into
1063 // its own line, which is undesireable.
1064 verifyFormat("namespace {\n};");
1065 verifyFormat("namespace {\n"
1066 "class A {\n"
1067 "};\n"
1068 "};");
Alexander Kornienko15757312012-12-06 18:03:27 +00001069}
1070
Daniel Jasper66d19bd2013-02-18 11:59:17 +00001071TEST_F(FormatTest, FormatsExternC) { verifyFormat("extern \"C\" {\nint a;"); }
Manuel Klimekd19dc2d2013-01-21 14:32:05 +00001072
Daniel Jasper923ebef2013-03-14 13:45:21 +00001073TEST_F(FormatTest, FormatsInlineASM) {
1074 verifyFormat("asm(\"xyz\" : \"=a\"(a), \"=d\"(b) : \"a\"(data));");
1075 verifyFormat(
1076 "asm(\"movq\\t%%rbx, %%rsi\\n\\t\"\n"
1077 " \"cpuid\\n\\t\"\n"
1078 " \"xchgq\\t%%rbx, %%rsi\\n\\t\"\n"
1079 " : \"=a\" (*rEAX), \"=S\" (*rEBX), \"=c\" (*rECX), \"=d\" (*rEDX)\n"
1080 " : \"a\"(value));");
1081}
1082
Nico Webera9ccdd12013-01-07 16:36:17 +00001083TEST_F(FormatTest, FormatTryCatch) {
Manuel Klimek517e8942013-01-11 17:54:10 +00001084 // FIXME: Handle try-catch explicitly in the UnwrappedLineParser, then we'll
1085 // also not create single-line-blocks.
Nico Webera9ccdd12013-01-07 16:36:17 +00001086 verifyFormat("try {\n"
1087 " throw a * b;\n"
1088 "}\n"
1089 "catch (int a) {\n"
1090 " // Do nothing.\n"
1091 "}\n"
1092 "catch (...) {\n"
1093 " exit(42);\n"
1094 "}");
1095
1096 // Function-level try statements.
Manuel Klimek517e8942013-01-11 17:54:10 +00001097 verifyFormat("int f() try { return 4; }\n"
Nico Webera9ccdd12013-01-07 16:36:17 +00001098 "catch (...) {\n"
1099 " return 5;\n"
1100 "}");
1101 verifyFormat("class A {\n"
1102 " int a;\n"
Manuel Klimek36fab8d2013-01-10 13:24:24 +00001103 " A() try : a(0) {}\n"
Nico Webera9ccdd12013-01-07 16:36:17 +00001104 " catch (...) {\n"
1105 " throw;\n"
1106 " }\n"
1107 "};\n");
1108}
1109
1110TEST_F(FormatTest, FormatObjCTryCatch) {
Manuel Klimekd5688cf2013-01-11 19:17:44 +00001111 verifyFormat("@try {\n"
1112 " f();\n"
1113 "}\n"
1114 "@catch (NSException e) {\n"
1115 " @throw;\n"
1116 "}\n"
1117 "@finally {\n"
1118 " exit(42);\n"
1119 "}");
Nico Webera9ccdd12013-01-07 16:36:17 +00001120}
1121
Daniel Jasper05b1ac82012-12-17 11:29:41 +00001122TEST_F(FormatTest, StaticInitializers) {
1123 verifyFormat("static SomeClass SC = { 1, 'a' };");
1124
1125 // FIXME: Format like enums if the static initializer does not fit on a line.
1126 verifyFormat(
Daniel Jasper9cda8002013-01-07 13:08:40 +00001127 "static SomeClass WithALoooooooooooooooooooongName = {\n"
Manuel Klimekc8c8a472013-01-10 15:58:26 +00001128 " 100000000, \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\"\n"
1129 "};");
1130
1131 verifyFormat(
1132 "static SomeClass = { a, b, c, d, e, f, g, h, i, j,\n"
1133 " looooooooooooooooooooooooooooooooooongname,\n"
1134 " looooooooooooooooooooooooooooooong };");
Daniel Jasperf343cab2013-01-31 14:59:26 +00001135 // Allow bin-packing in static initializers as this would often lead to
1136 // terrible results, e.g.:
1137 verifyGoogleFormat(
1138 "static SomeClass = { a, b, c, d, e, f, g, h, i, j,\n"
1139 " looooooooooooooooooooooooooooooooooongname,\n"
1140 " looooooooooooooooooooooooooooooong };");
Daniel Jasper05b1ac82012-12-17 11:29:41 +00001141}
1142
Manuel Klimek2c7739e2013-01-14 16:41:43 +00001143TEST_F(FormatTest, NestedStaticInitializers) {
1144 verifyFormat("static A x = { { {} } };\n");
Daniel Jasper66d19bd2013-02-18 11:59:17 +00001145 verifyFormat("static A x = { { { init1, init2, init3, init4 },\n"
1146 " { init1, init2, init3, init4 } } };");
Daniel Jasper0df6acd2013-01-16 14:59:02 +00001147
Daniel Jasper66d19bd2013-02-18 11:59:17 +00001148 verifyFormat("somes Status::global_reps[3] = {\n"
1149 " { kGlobalRef, OK_CODE, NULL, NULL, NULL },\n"
1150 " { kGlobalRef, CANCELLED_CODE, NULL, NULL, NULL },\n"
1151 " { kGlobalRef, UNKNOWN_CODE, NULL, NULL, NULL }\n"
1152 "};");
1153 verifyGoogleFormat("somes Status::global_reps[3] = {\n"
1154 " { kGlobalRef, OK_CODE, NULL, NULL, NULL },\n"
1155 " { kGlobalRef, CANCELLED_CODE, NULL, NULL, NULL },\n"
1156 " { kGlobalRef, UNKNOWN_CODE, NULL, NULL, NULL }\n"
1157 "};");
Manuel Klimek2c7739e2013-01-14 16:41:43 +00001158 verifyFormat(
1159 "CGRect cg_rect = { { rect.fLeft, rect.fTop },\n"
1160 " { rect.fRight - rect.fLeft, rect.fBottom - rect.fTop"
1161 " } };");
1162
Daniel Jasperf343cab2013-01-31 14:59:26 +00001163 verifyFormat(
1164 "SomeArrayOfSomeType a = { { { 1, 2, 3 }, { 1, 2, 3 },\n"
1165 " { 111111111111111111111111111111,\n"
1166 " 222222222222222222222222222222,\n"
1167 " 333333333333333333333333333333 },\n"
1168 " { 1, 2, 3 }, { 1, 2, 3 } } };");
Daniel Jasper6bd02322013-02-03 18:07:15 +00001169 verifyFormat(
1170 "SomeArrayOfSomeType a = { { { 1, 2, 3 } }, { { 1, 2, 3 } },\n"
1171 " { { 111111111111111111111111111111,\n"
1172 " 222222222222222222222222222222,\n"
1173 " 333333333333333333333333333333 } },\n"
1174 " { { 1, 2, 3 } }, { { 1, 2, 3 } } };");
Daniel Jasperf343cab2013-01-31 14:59:26 +00001175
Nico Weber6a21a552013-01-18 02:43:57 +00001176 // FIXME: We might at some point want to handle this similar to parameter
Manuel Klimek2c7739e2013-01-14 16:41:43 +00001177 // lists, where we have an option to put each on a single line.
Daniel Jasper66d19bd2013-02-18 11:59:17 +00001178 verifyFormat(
1179 "struct {\n"
1180 " unsigned bit;\n"
1181 " const char *const name;\n"
1182 "} kBitsToOs[] = { { kOsMac, \"Mac\" }, { kOsWin, \"Windows\" },\n"
1183 " { kOsLinux, \"Linux\" }, { kOsCrOS, \"Chrome OS\" } };");
Manuel Klimek2c7739e2013-01-14 16:41:43 +00001184}
1185
Manuel Klimeka080a182013-01-02 16:30:12 +00001186TEST_F(FormatTest, FormatsSmallMacroDefinitionsInSingleLine) {
1187 verifyFormat("#define ALooooooooooooooooooooooooooooooooooooooongMacro("
1188 " \\\n"
1189 " aLoooooooooooooooooooooooongFuuuuuuuuuuuuuunctiooooooooo)");
1190}
1191
Daniel Jasper71607512013-01-07 10:48:50 +00001192TEST_F(FormatTest, DoesNotBreakPureVirtualFunctionDefinition) {
Daniel Jasper8ed9f2b2013-04-03 13:36:17 +00001193 verifyFormat(
Daniel Jasper1407bee2013-04-11 14:29:13 +00001194 "virtual void write(ELFWriter *writerrr,\n"
1195 " OwningPtr<FileOutputBuffer> &buffer) = 0;");
Daniel Jasper71607512013-01-07 10:48:50 +00001196}
1197
Manuel Klimekbd04f2a2013-01-31 15:58:48 +00001198TEST_F(FormatTest, LayoutUnknownPPDirective) {
1199 EXPECT_EQ("#123 \"A string literal\"",
1200 format(" # 123 \"A string literal\""));
1201 EXPECT_EQ("#;", format("#;"));
Manuel Klimekdd5b1012013-01-07 10:03:37 +00001202 verifyFormat("#\n;\n;\n;");
Manuel Klimeka080a182013-01-02 16:30:12 +00001203}
1204
1205TEST_F(FormatTest, UnescapedEndOfLineEndsPPDirective) {
1206 EXPECT_EQ("#line 42 \"test\"\n",
1207 format("# \\\n line \\\n 42 \\\n \"test\"\n"));
Daniel Jasper66d19bd2013-02-18 11:59:17 +00001208 EXPECT_EQ("#define A B\n", format("# \\\n define \\\n A \\\n B\n",
1209 getLLVMStyleWithColumns(12)));
Manuel Klimeka080a182013-01-02 16:30:12 +00001210}
1211
1212TEST_F(FormatTest, EndOfFileEndsPPDirective) {
1213 EXPECT_EQ("#line 42 \"test\"",
1214 format("# \\\n line \\\n 42 \\\n \"test\""));
Daniel Jasper66d19bd2013-02-18 11:59:17 +00001215 EXPECT_EQ("#define A B", format("# \\\n define \\\n A \\\n B"));
Manuel Klimeka080a182013-01-02 16:30:12 +00001216}
1217
Manuel Klimek060143e2013-01-02 18:33:23 +00001218TEST_F(FormatTest, IndentsPPDirectiveInReducedSpace) {
Daniel Jaspera4d46212013-02-28 11:05:57 +00001219 verifyFormat("#define A(BB)", getLLVMStyleWithColumns(13));
1220 verifyFormat("#define A( \\\n BB)", getLLVMStyleWithColumns(12));
Manuel Klimek060143e2013-01-02 18:33:23 +00001221 verifyFormat("#define A( \\\n A, B)", getLLVMStyleWithColumns(12));
Daniel Jaspera4d46212013-02-28 11:05:57 +00001222 // FIXME: We never break before the macro name.
1223 verifyFormat("#define AA(\\\n B)", getLLVMStyleWithColumns(12));
Daniel Jaspere0b15ea2013-01-14 15:40:57 +00001224
1225 verifyFormat("#define A A\n#define A A");
1226 verifyFormat("#define A(X) A\n#define A A");
1227
Daniel Jaspera4d46212013-02-28 11:05:57 +00001228 verifyFormat("#define Something Other", getLLVMStyleWithColumns(23));
1229 verifyFormat("#define Something \\\n Other", getLLVMStyleWithColumns(22));
Manuel Klimek060143e2013-01-02 18:33:23 +00001230}
1231
1232TEST_F(FormatTest, HandlePreprocessorDirectiveContext) {
Alexander Kornienko9fdc00a2013-03-28 18:40:55 +00001233 EXPECT_EQ("// somecomment\n"
Manuel Klimekd4397b92013-01-04 23:34:14 +00001234 "#include \"a.h\"\n"
Daniel Jaspera4d46212013-02-28 11:05:57 +00001235 "#define A( \\\n"
1236 " A, B)\n"
Manuel Klimekd4397b92013-01-04 23:34:14 +00001237 "#include \"b.h\"\n"
Alexander Kornienko5262dd92013-03-27 11:52:18 +00001238 "// somecomment\n",
Alexander Kornienko9fdc00a2013-03-28 18:40:55 +00001239 format(" // somecomment\n"
Manuel Klimekd4397b92013-01-04 23:34:14 +00001240 " #include \"a.h\"\n"
1241 "#define A(A,\\\n"
1242 " B)\n"
1243 " #include \"b.h\"\n"
Alexander Kornienko5262dd92013-03-27 11:52:18 +00001244 " // somecomment\n",
Daniel Jasper66d19bd2013-02-18 11:59:17 +00001245 getLLVMStyleWithColumns(13)));
Manuel Klimek060143e2013-01-02 18:33:23 +00001246}
1247
Daniel Jasper66d19bd2013-02-18 11:59:17 +00001248TEST_F(FormatTest, LayoutSingleHash) { EXPECT_EQ("#\na;", format("#\na;")); }
Manuel Klimekd4397b92013-01-04 23:34:14 +00001249
1250TEST_F(FormatTest, LayoutCodeInMacroDefinitions) {
1251 EXPECT_EQ("#define A \\\n"
1252 " c; \\\n"
1253 " e;\n"
Daniel Jasper66d19bd2013-02-18 11:59:17 +00001254 "f;",
1255 format("#define A c; e;\n"
1256 "f;",
1257 getLLVMStyleWithColumns(14)));
Manuel Klimekd4397b92013-01-04 23:34:14 +00001258}
1259
Daniel Jasper66d19bd2013-02-18 11:59:17 +00001260TEST_F(FormatTest, LayoutRemainingTokens) { EXPECT_EQ("{}", format("{}")); }
Manuel Klimekd4397b92013-01-04 23:34:14 +00001261
1262TEST_F(FormatTest, LayoutSingleUnwrappedLineInMacro) {
Daniel Jasper26f7e782013-01-08 14:56:18 +00001263 EXPECT_EQ("# define A\\\n b;",
1264 format("# define A b;", 11, 2, getLLVMStyleWithColumns(11)));
Manuel Klimekd4397b92013-01-04 23:34:14 +00001265}
1266
1267TEST_F(FormatTest, MacroDefinitionInsideStatement) {
Manuel Klimek526ed112013-01-09 15:25:02 +00001268 EXPECT_EQ("int x,\n"
1269 "#define A\n"
Daniel Jasper66d19bd2013-02-18 11:59:17 +00001270 " y;",
1271 format("int x,\n#define A\ny;"));
Manuel Klimekd4397b92013-01-04 23:34:14 +00001272}
1273
Manuel Klimek6f8424b2013-01-05 21:34:55 +00001274TEST_F(FormatTest, HashInMacroDefinition) {
1275 verifyFormat("#define A \\\n b #c;", getLLVMStyleWithColumns(11));
1276 verifyFormat("#define A \\\n"
1277 " { \\\n"
1278 " f(#c);\\\n"
Daniel Jasper66d19bd2013-02-18 11:59:17 +00001279 " }",
1280 getLLVMStyleWithColumns(11));
Daniel Jasper765561f2013-01-08 16:17:54 +00001281
1282 verifyFormat("#define A(X) \\\n"
Daniel Jasper66d19bd2013-02-18 11:59:17 +00001283 " void function##X()",
1284 getLLVMStyleWithColumns(22));
Daniel Jasper765561f2013-01-08 16:17:54 +00001285
1286 verifyFormat("#define A(a, b, c) \\\n"
Daniel Jasper66d19bd2013-02-18 11:59:17 +00001287 " void a##b##c()",
1288 getLLVMStyleWithColumns(22));
Daniel Jasper765561f2013-01-08 16:17:54 +00001289
Daniel Jaspere0b15ea2013-01-14 15:40:57 +00001290 verifyFormat("#define A void # ## #", getLLVMStyleWithColumns(22));
Manuel Klimek6f8424b2013-01-05 21:34:55 +00001291}
1292
Manuel Klimek7ccbc212013-01-23 14:37:36 +00001293TEST_F(FormatTest, RespectWhitespaceInMacroDefinitions) {
1294 verifyFormat("#define A (1)");
1295}
1296
Manuel Klimeka28fc062013-02-11 12:33:24 +00001297TEST_F(FormatTest, EmptyLinesInMacroDefinitions) {
1298 EXPECT_EQ("#define A b;", format("#define A \\\n"
1299 " \\\n"
Daniel Jasper66d19bd2013-02-18 11:59:17 +00001300 " b;",
1301 getLLVMStyleWithColumns(25)));
Manuel Klimeka28fc062013-02-11 12:33:24 +00001302 EXPECT_EQ("#define A \\\n"
1303 " \\\n"
1304 " a; \\\n"
Daniel Jasper66d19bd2013-02-18 11:59:17 +00001305 " b;",
1306 format("#define A \\\n"
1307 " \\\n"
1308 " a; \\\n"
1309 " b;",
1310 getLLVMStyleWithColumns(11)));
Manuel Klimeka28fc062013-02-11 12:33:24 +00001311 EXPECT_EQ("#define A \\\n"
1312 " a; \\\n"
1313 " \\\n"
Daniel Jasper66d19bd2013-02-18 11:59:17 +00001314 " b;",
1315 format("#define A \\\n"
1316 " a; \\\n"
1317 " \\\n"
1318 " b;",
1319 getLLVMStyleWithColumns(11)));
Manuel Klimeka28fc062013-02-11 12:33:24 +00001320}
1321
Daniel Jasper34511fb2013-02-19 17:14:38 +00001322TEST_F(FormatTest, MacroDefinitionsWithIncompleteCode) {
Daniel Jaspercf6d76a2013-03-18 12:50:26 +00001323 verifyFormat("#define A :");
1324
Daniel Jasper34511fb2013-02-19 17:14:38 +00001325 // FIXME: Improve formatting of case labels in macros.
1326 verifyFormat("#define SOMECASES \\\n"
Daniel Jasperbcca7e42013-03-20 10:23:53 +00001327 " case 1: \\\n"
Daniel Jasper34511fb2013-02-19 17:14:38 +00001328 " case 2\n",
1329 getLLVMStyleWithColumns(20));
1330
1331 verifyFormat("#define A template <typename T>");
Daniel Jasper03628b82013-02-19 20:05:41 +00001332 verifyFormat("#define STR(x) #x\n"
1333 "f(STR(this_is_a_string_literal{));");
Daniel Jasper34511fb2013-02-19 17:14:38 +00001334}
1335
Alexander Kornienko3d713a72013-04-08 22:16:06 +00001336TEST_F(FormatTest, MacroCallsWithoutTrailingSemicolon) {
1337 EXPECT_EQ("INITIALIZE_PASS_BEGIN(ScopDetection, \"polly-detect\")\n"
1338 "INITIALIZE_AG_DEPENDENCY(AliasAnalysis)\n"
1339 "INITIALIZE_PASS_DEPENDENCY(DominatorTree)\n"
1340 "class X {\n"
1341 "};\n"
1342 "INITIALIZE_PASS_END(ScopDetection, \"polly-detect\")\n"
1343 "int *createScopDetectionPass() { return 0; }",
1344 format(" INITIALIZE_PASS_BEGIN(ScopDetection, \"polly-detect\")\n"
1345 " INITIALIZE_AG_DEPENDENCY(AliasAnalysis)\n"
1346 " INITIALIZE_PASS_DEPENDENCY(DominatorTree)\n"
1347 " class X {};\n"
1348 " INITIALIZE_PASS_END(ScopDetection, \"polly-detect\")\n"
1349 " int *createScopDetectionPass() { return 0; }"));
Alexander Kornienko99b0e142013-04-09 16:15:19 +00001350 // FIXME: We could probably treat IPC_BEGIN_MESSAGE_MAP/IPC_END_MESSAGE_MAP as
1351 // braces, so that inner block is indented one level more.
1352 EXPECT_EQ("int q() {\n"
1353 " IPC_BEGIN_MESSAGE_MAP(WebKitTestController, message)\n"
1354 " IPC_MESSAGE_HANDLER(xxx, qqq)\n"
1355 " IPC_END_MESSAGE_MAP()\n"
1356 "}",
1357 format("int q() {\n"
1358 " IPC_BEGIN_MESSAGE_MAP(WebKitTestController, message)\n"
1359 " IPC_MESSAGE_HANDLER(xxx, qqq)\n"
1360 " IPC_END_MESSAGE_MAP()\n"
1361 "}"));
1362 EXPECT_EQ("int q() {\n"
1363 " f(x);\n"
1364 " f(x) {}\n"
1365 " f(x)->g();\n"
1366 " f(x)->*g();\n"
1367 " f(x).g();\n"
1368 " f(x) = x;\n"
1369 " f(x) += x;\n"
1370 " f(x) -= x;\n"
1371 " f(x) *= x;\n"
1372 " f(x) /= x;\n"
1373 " f(x) %= x;\n"
1374 " f(x) &= x;\n"
1375 " f(x) |= x;\n"
1376 " f(x) ^= x;\n"
1377 " f(x) >>= x;\n"
1378 " f(x) <<= x;\n"
1379 " f(x)[y].z();\n"
1380 " LOG(INFO) << x;\n"
1381 " ifstream(x) >> x;\n"
1382 "}\n",
1383 format("int q() {\n"
1384 " f(x)\n;\n"
1385 " f(x)\n {}\n"
1386 " f(x)\n->g();\n"
1387 " f(x)\n->*g();\n"
1388 " f(x)\n.g();\n"
1389 " f(x)\n = x;\n"
1390 " f(x)\n += x;\n"
1391 " f(x)\n -= x;\n"
1392 " f(x)\n *= x;\n"
1393 " f(x)\n /= x;\n"
1394 " f(x)\n %= x;\n"
1395 " f(x)\n &= x;\n"
1396 " f(x)\n |= x;\n"
1397 " f(x)\n ^= x;\n"
1398 " f(x)\n >>= x;\n"
1399 " f(x)\n <<= x;\n"
1400 " f(x)\n[y].z();\n"
1401 " LOG(INFO)\n << x;\n"
1402 " ifstream(x)\n >> x;\n"
1403 "}\n"));
1404 EXPECT_EQ("int q() {\n"
1405 " f(x)\n"
1406 " if (1) {\n"
1407 " }\n"
1408 " f(x)\n"
1409 " while (1) {\n"
1410 " }\n"
1411 " f(x)\n"
1412 " g(x);\n"
1413 " f(x)\n"
1414 " try {\n"
1415 " q();\n"
1416 " }\n"
1417 " catch (...) {\n"
1418 " }\n"
1419 "}\n",
1420 format("int q() {\n"
1421 "f(x)\n"
1422 "if (1) {}\n"
1423 "f(x)\n"
1424 "while (1) {}\n"
1425 "f(x)\n"
1426 "g(x);\n"
1427 "f(x)\n"
1428 "try { q(); } catch (...) {}\n"
1429 "}\n"));
1430 EXPECT_EQ("class A {\n"
1431 " A() : t(0) {}\n"
1432 " A(X x)\n" // FIXME: function-level try blocks are broken.
1433 " try : t(0) {\n"
1434 " }\n"
1435 " catch (...) {\n"
1436 " }\n"
1437 "};",
1438 format("class A {\n"
1439 " A()\n : t(0) {}\n"
1440 " A(X x)\n"
1441 " try : t(0) {} catch (...) {}\n"
1442 "};"));
Alexander Kornienko3d713a72013-04-08 22:16:06 +00001443}
1444
Manuel Klimekc37b4d62013-01-05 22:14:16 +00001445TEST_F(FormatTest, IndentPreprocessorDirectivesAtZero) {
1446 EXPECT_EQ("{\n {\n#define A\n }\n}", format("{{\n#define A\n}}"));
1447}
1448
Manuel Klimekf6fd00b2013-01-05 22:56:06 +00001449TEST_F(FormatTest, FormatHashIfNotAtStartOfLine) {
Manuel Klimek517e8942013-01-11 17:54:10 +00001450 verifyFormat("{\n { a #c; }\n}");
Manuel Klimekf6fd00b2013-01-05 22:56:06 +00001451}
1452
Manuel Klimeka5342db2013-01-06 20:07:31 +00001453TEST_F(FormatTest, FormatUnbalancedStructuralElements) {
1454 EXPECT_EQ("#define A \\\n { \\\n {\nint i;",
1455 format("#define A { {\nint i;", getLLVMStyleWithColumns(11)));
1456 EXPECT_EQ("#define A \\\n } \\\n }\nint i;",
1457 format("#define A } }\nint i;", getLLVMStyleWithColumns(11)));
1458}
Manuel Klimekd4397b92013-01-04 23:34:14 +00001459
Manuel Klimek95419382013-01-07 07:56:50 +00001460TEST_F(FormatTest, EscapedNewlineAtStartOfTokenInMacroDefinition) {
Daniel Jaspercd162382013-01-07 13:26:07 +00001461 EXPECT_EQ(
1462 "#define A \\\n int i; \\\n int j;",
1463 format("#define A \\\nint i;\\\n int j;", getLLVMStyleWithColumns(11)));
Manuel Klimek95419382013-01-07 07:56:50 +00001464}
1465
Manuel Klimekd544c572013-01-07 09:24:17 +00001466TEST_F(FormatTest, CalculateSpaceOnConsecutiveLinesInMacro) {
1467 verifyFormat("#define A \\\n"
1468 " int v( \\\n"
1469 " a); \\\n"
Daniel Jasper66d19bd2013-02-18 11:59:17 +00001470 " int i;",
1471 getLLVMStyleWithColumns(11));
Manuel Klimekd544c572013-01-07 09:24:17 +00001472}
1473
Manuel Klimeka080a182013-01-02 16:30:12 +00001474TEST_F(FormatTest, MixingPreprocessorDirectivesAndNormalCode) {
Manuel Klimekd4397b92013-01-04 23:34:14 +00001475 EXPECT_EQ(
1476 "#define ALooooooooooooooooooooooooooooooooooooooongMacro("
1477 " \\\n"
1478 " aLoooooooooooooooooooooooongFuuuuuuuuuuuuuunctiooooooooo)\n"
1479 "\n"
1480 "AlooooooooooooooooooooooooooooooooooooooongCaaaaaaaaaal(\n"
1481 " aLooooooooooooooooooooooonPaaaaaaaaaaaaaaaaaaaaarmmmm);\n",
1482 format(" #define ALooooooooooooooooooooooooooooooooooooooongMacro("
1483 "\\\n"
1484 "aLoooooooooooooooooooooooongFuuuuuuuuuuuuuunctiooooooooo)\n"
1485 " \n"
1486 " AlooooooooooooooooooooooooooooooooooooooongCaaaaaaaaaal(\n"
1487 " aLooooooooooooooooooooooonPaaaaaaaaaaaaaaaaaaaaarmmmm);\n"));
Manuel Klimeka080a182013-01-02 16:30:12 +00001488}
1489
Manuel Klimek526ed112013-01-09 15:25:02 +00001490TEST_F(FormatTest, LayoutStatementsAroundPreprocessorDirectives) {
1491 EXPECT_EQ("int\n"
1492 "#define A\n"
Daniel Jasper8ed9f2b2013-04-03 13:36:17 +00001493 "a;",
Manuel Klimek526ed112013-01-09 15:25:02 +00001494 format("int\n#define A\na;"));
Daniel Jasper66d19bd2013-02-18 11:59:17 +00001495 verifyFormat("functionCallTo(\n"
1496 " someOtherFunction(\n"
1497 " withSomeParameters, whichInSequence,\n"
1498 " areLongerThanALine(andAnotherCall,\n"
1499 "#define A B\n"
1500 " withMoreParamters,\n"
1501 " whichStronglyInfluenceTheLayout),\n"
Daniel Jasper7d812812013-02-21 15:00:29 +00001502 " andMoreParameters),\n"
1503 " trailing);",
Daniel Jasper66d19bd2013-02-18 11:59:17 +00001504 getLLVMStyleWithColumns(69));
Manuel Klimek526ed112013-01-09 15:25:02 +00001505}
1506
Manuel Klimekbb42bf12013-01-10 11:52:21 +00001507TEST_F(FormatTest, LayoutBlockInsideParens) {
1508 EXPECT_EQ("functionCall({\n"
1509 " int i;\n"
Daniel Jasper66d19bd2013-02-18 11:59:17 +00001510 "});",
1511 format(" functionCall ( {int i;} );"));
Manuel Klimekbb42bf12013-01-10 11:52:21 +00001512}
1513
1514TEST_F(FormatTest, LayoutBlockInsideStatement) {
Manuel Klimek517e8942013-01-11 17:54:10 +00001515 EXPECT_EQ("SOME_MACRO { int i; }\n"
Daniel Jasper66d19bd2013-02-18 11:59:17 +00001516 "int i;",
1517 format(" SOME_MACRO {int i;} int i;"));
Manuel Klimekbb42bf12013-01-10 11:52:21 +00001518}
1519
1520TEST_F(FormatTest, LayoutNestedBlocks) {
1521 verifyFormat("void AddOsStrings(unsigned bitmask) {\n"
1522 " struct s {\n"
1523 " int i;\n"
1524 " };\n"
1525 " s kBitsToOs[] = { { 10 } };\n"
1526 " for (int i = 0; i < 10; ++i)\n"
1527 " return;\n"
1528 "}");
1529}
1530
Manuel Klimek36fab8d2013-01-10 13:24:24 +00001531TEST_F(FormatTest, PutEmptyBlocksIntoOneLine) {
1532 EXPECT_EQ("{}", format("{}"));
Manuel Klimek2f1ac412013-01-21 16:42:44 +00001533
1534 // Negative test for enum.
1535 verifyFormat("enum E {\n};");
1536
1537 // Note that when there's a missing ';', we still join...
1538 verifyFormat("enum E {}");
Manuel Klimek36fab8d2013-01-10 13:24:24 +00001539}
1540
Alexander Kornienko15757312012-12-06 18:03:27 +00001541//===----------------------------------------------------------------------===//
1542// Line break tests.
1543//===----------------------------------------------------------------------===//
1544
1545TEST_F(FormatTest, FormatsFunctionDefinition) {
1546 verifyFormat("void f(int a, int b, int c, int d, int e, int f, int g,"
1547 " int h, int j, int f,\n"
Daniel Jasperf11a7052013-02-21 21:33:55 +00001548 " int c, int ddddddddddddd) {}");
Alexander Kornienko15757312012-12-06 18:03:27 +00001549}
1550
1551TEST_F(FormatTest, FormatsAwesomeMethodCall) {
1552 verifyFormat(
Daniel Jasper986e17f2013-01-28 07:35:34 +00001553 "SomeLongMethodName(SomeReallyLongMethod(CallOtherReallyLongMethod(\n"
1554 " parameter, parameter, parameter)),\n"
Daniel Jaspera4974cf2012-12-24 16:43:00 +00001555 " SecondLongCall(parameter));");
Alexander Kornienko15757312012-12-06 18:03:27 +00001556}
1557
Daniel Jasperae8699b2013-01-28 09:35:24 +00001558TEST_F(FormatTest, PreventConfusingIndents) {
Daniel Jasper986e17f2013-01-28 07:35:34 +00001559 verifyFormat(
1560 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n"
1561 " aaaaaaaaaaaaaaaaaaaaaaaa(\n"
1562 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa),\n"
1563 " aaaaaaaaaaaaaaaaaaaaaaaa);");
1564 verifyFormat(
1565 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa[\n"
1566 " aaaaaaaaaaaaaaaaaaaaaaaa[\n"
1567 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa],\n"
1568 " aaaaaaaaaaaaaaaaaaaaaaaa];");
1569 verifyFormat(
1570 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa<\n"
1571 " aaaaaaaaaaaaaaaaaaaaaaaa<\n"
1572 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa>,\n"
1573 " aaaaaaaaaaaaaaaaaaaaaaaa>;");
Daniel Jasperae8699b2013-01-28 09:35:24 +00001574 verifyFormat("int a = bbbb && ccc && fffff(\n"
1575 "#define A Just forcing a new line\n"
1576 " ddd);");
Daniel Jasper986e17f2013-01-28 07:35:34 +00001577}
1578
Daniel Jasperbf71ba22013-04-08 20:33:42 +00001579TEST_F(FormatTest, ExpressionIndentation) {
1580 verifyFormat("bool value = aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n"
1581 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n"
1582 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ==\n"
1583 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa *\n"
1584 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb +\n"
1585 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb &&\n"
1586 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa *\n"
1587 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa >\n"
1588 " ccccccccccccccccccccccccccccccccccccccccc;");
1589 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa *\n"
1590 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n"
1591 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ==\n"
1592 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb) {\n}");
1593 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n"
1594 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa *\n"
1595 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ==\n"
1596 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb) {\n}");
1597 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ==\n"
1598 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa *\n"
1599 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n"
1600 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb) {\n}");
1601}
1602
Daniel Jasper1321eb52012-12-18 21:05:13 +00001603TEST_F(FormatTest, ConstructorInitializers) {
Manuel Klimek36fab8d2013-01-10 13:24:24 +00001604 verifyFormat("Constructor() : Initializer(FitsOnTheLine) {}");
Daniel Jasper7e9bf8c2013-01-11 11:37:55 +00001605 verifyFormat("Constructor() : Inttializer(FitsOnTheLine) {}",
1606 getLLVMStyleWithColumns(45));
Daniel Jasperf11a7052013-02-21 21:33:55 +00001607 verifyFormat("Constructor()\n"
1608 " : Inttializer(FitsOnTheLine) {}",
Daniel Jasper7e9bf8c2013-01-11 11:37:55 +00001609 getLLVMStyleWithColumns(44));
Manuel Klimek2f1ac412013-01-21 16:42:44 +00001610 verifyFormat("Constructor()\n"
Daniel Jasperf11a7052013-02-21 21:33:55 +00001611 " : Inttializer(FitsOnTheLine) {}",
Manuel Klimek2f1ac412013-01-21 16:42:44 +00001612 getLLVMStyleWithColumns(43));
Daniel Jasper1321eb52012-12-18 21:05:13 +00001613
1614 verifyFormat(
1615 "SomeClass::Constructor()\n"
Daniel Jasperf11a7052013-02-21 21:33:55 +00001616 " : aaaaaaaaaaaaa(aaaaaaaaaaaaaa), aaaaaaaaaaaaaaa(aaaaaaaaaaaa) {}");
Daniel Jasper1321eb52012-12-18 21:05:13 +00001617
1618 verifyFormat(
1619 "SomeClass::Constructor()\n"
Daniel Jasper7e9bf8c2013-01-11 11:37:55 +00001620 " : aaaaaaaaaaaaa(aaaaaaaaaaaaaa), aaaaaaaaaaaaa(aaaaaaaaaaaaaa),\n"
Daniel Jasperf11a7052013-02-21 21:33:55 +00001621 " aaaaaaaaaaaaa(aaaaaaaaaaaaaa) {}");
Daniel Jasper7e9bf8c2013-01-11 11:37:55 +00001622 verifyFormat(
1623 "SomeClass::Constructor()\n"
Daniel Jasper1321eb52012-12-18 21:05:13 +00001624 " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa),\n"
Daniel Jasperf11a7052013-02-21 21:33:55 +00001625 " aaaaaaaaaaaaaaa(aaaaaaaaaaaa) {}");
Daniel Jasper1321eb52012-12-18 21:05:13 +00001626
1627 verifyFormat("Constructor()\n"
1628 " : aaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaa),\n"
1629 " aaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaa,\n"
1630 " aaaaaaaaaaaaaaaaaaaaaaaaaaa),\n"
Daniel Jasperf11a7052013-02-21 21:33:55 +00001631 " aaaaaaaaaaaaaaaaaaaaaaa() {}");
Daniel Jasper1321eb52012-12-18 21:05:13 +00001632
Daniel Jasper02b771e2013-01-28 13:31:35 +00001633 verifyFormat("Constructor()\n"
1634 " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n"
Daniel Jasperf11a7052013-02-21 21:33:55 +00001635 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {}");
Daniel Jasper02b771e2013-01-28 13:31:35 +00001636
Daniel Jasper9c3e71a2013-02-25 15:59:54 +00001637 verifyFormat("Constructor(int Parameter = 0)\n"
1638 " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaa),\n"
1639 " aaaaaaaaaaaa(aaaaaaaaaaaaaaaaa) {}");
1640
Daniel Jasper1321eb52012-12-18 21:05:13 +00001641 // Here a line could be saved by splitting the second initializer onto two
1642 // lines, but that is not desireable.
Daniel Jasperfaab0d32013-02-27 09:47:53 +00001643 verifyFormat("Constructor()\n"
1644 " : aaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaa),\n"
1645 " aaaaaaaaaaa(aaaaaaaaaaa),\n"
1646 " aaaaaaaaaaaaaaaaaaaaat(aaaaaaaaaaaaaaaaaaaaaaaaaaaa) {}");
Daniel Jasper1321eb52012-12-18 21:05:13 +00001647
Daniel Jasperb130a542013-02-15 16:49:44 +00001648 FormatStyle OnePerLine = getLLVMStyle();
1649 OnePerLine.ConstructorInitializerAllOnOneLineOrOnePerLine = true;
1650 verifyFormat("SomeClass::Constructor()\n"
1651 " : aaaaaaaaaaaaa(aaaaaaaaaaaaaa),\n"
1652 " aaaaaaaaaaaaa(aaaaaaaaaaaaaa),\n"
Daniel Jasperf11a7052013-02-21 21:33:55 +00001653 " aaaaaaaaaaaaa(aaaaaaaaaaaaaa) {}",
Daniel Jasper66d19bd2013-02-18 11:59:17 +00001654 OnePerLine);
Daniel Jasperb130a542013-02-15 16:49:44 +00001655 verifyFormat("SomeClass::Constructor()\n"
1656 " : aaaaaaaaaaaaa(aaaaaaaaaaaaaa), // Some comment\n"
1657 " aaaaaaaaaaaaa(aaaaaaaaaaaaaa),\n"
Daniel Jasperf11a7052013-02-21 21:33:55 +00001658 " aaaaaaaaaaaaa(aaaaaaaaaaaaaa) {}",
Daniel Jasper66d19bd2013-02-18 11:59:17 +00001659 OnePerLine);
Daniel Jasperb130a542013-02-15 16:49:44 +00001660 verifyFormat("MyClass::MyClass(int var)\n"
1661 " : some_var_(var), // 4 space indent\n"
1662 " some_other_var_(var + 1) { // lined up\n"
Daniel Jasper66d19bd2013-02-18 11:59:17 +00001663 "}",
1664 OnePerLine);
Daniel Jasper3a39ac72013-02-28 09:39:12 +00001665 verifyFormat("Constructor()\n"
1666 " : aaaaa(aaaaaa),\n"
1667 " aaaaa(aaaaaa),\n"
1668 " aaaaa(aaaaaa),\n"
1669 " aaaaa(aaaaaa),\n"
1670 " aaaaa(aaaaaa) {}",
1671 OnePerLine);
Daniel Jasperb3123142013-01-12 07:36:22 +00001672
1673 // This test takes VERY long when memoization is broken.
Daniel Jasperfaab0d32013-02-27 09:47:53 +00001674 OnePerLine.BinPackParameters = false;
Daniel Jasper0df6acd2013-01-16 14:59:02 +00001675 std::string input = "Constructor()\n"
Daniel Jasper3499dda2013-01-25 15:43:32 +00001676 " : aaaa(a,\n";
Daniel Jasper0df6acd2013-01-16 14:59:02 +00001677 for (unsigned i = 0, e = 80; i != e; ++i) {
1678 input += " a,\n";
1679 }
Daniel Jasperf11a7052013-02-21 21:33:55 +00001680 input += " a) {}";
Daniel Jasperfaab0d32013-02-27 09:47:53 +00001681 verifyFormat(input, OnePerLine);
Daniel Jasper1321eb52012-12-18 21:05:13 +00001682}
1683
Alexander Kornienko15757312012-12-06 18:03:27 +00001684TEST_F(FormatTest, BreaksAsHighAsPossible) {
1685 verifyFormat(
Alexander Kornienko3fd9ccd2013-03-12 16:28:18 +00001686 "void f() {\n"
1687 " if ((aaaaaaaaaaaaaaaaaaaaaaaaaaaaa && aaaaaaaaaaaaaaaaaaaaaaaaaa) ||\n"
1688 " (bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb && bbbbbbbbbbbbbbbbbbbbbbbbbb))\n"
1689 " f();\n"
1690 "}");
Daniel Jasper518ee342013-02-26 13:59:14 +00001691 verifyFormat("if (Intervals[i].getRange().getFirst() <\n"
Daniel Jasperbf71ba22013-04-08 20:33:42 +00001692 " Intervals[i - 1].getRange().getLast()) {\n}");
Alexander Kornienko15757312012-12-06 18:03:27 +00001693}
1694
Daniel Jasper1407bee2013-04-11 14:29:13 +00001695TEST_F(FormatTest, BreaksFunctionDeclarations) {
1696 // Principially, we break function declarations in a certain order:
1697 // 1) break amongst arguments.
1698 verifyFormat("Aaaaaaaaaaaaaa bbbbbbbbbbbbbb(Cccccccccccccc cccccccccccccc,\n"
1699 " Cccccccccccccc cccccccccccccc);");
1700
1701 // 2) break after return type.
1702 verifyFormat("Aaaaaaaaaaaaaaaaaaaaaaaa\n"
1703 "bbbbbbbbbbbbbb(Cccccccccccccc cccccccccccccccccccccccccc);");
1704
1705 // 3) break after (.
1706 verifyFormat(
1707 "Aaaaaaaaaaaaaaaaaaaaaaaa bbbbbbbbbbbbbbbbbb(\n"
1708 " Cccccccccccccccccccccccccccccc cccccccccccccccccccccccccccccccc);");
1709
1710 // 4) break before after nested name specifiers.
1711 verifyFormat(
1712 "Aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n"
1713 "SomeClasssssssssssssssssssssssssssssssssssssss::\n"
1714 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb(Cccccccccccccc cccccccccc);");
1715
1716 // However, there are exceptions, if a sufficient amount of lines can be
1717 // saved.
1718 // FIXME: The precise cut-offs wrt. the number of saved lines might need some
1719 // more adjusting.
1720 verifyFormat("Aaaaaaaaaaaaaaaaaa bbbbbbbbbbbbbb(Cccccccccccccc cccccccccc,\n"
1721 " Cccccccccccccc cccccccccc,\n"
1722 " Cccccccccccccc cccccccccc,\n"
1723 " Cccccccccccccc cccccccccc,\n"
1724 " Cccccccccccccc cccccccccc);");
1725 verifyFormat(
1726 "Aaaaaaaaaaaaaaaaaa\n"
1727 "bbbbbbbbbbbbbb(Cccccccccccccc cccccccccc, Cccccccccccccc cccccccccc,\n"
1728 " Cccccccccccccc cccccccccc, Cccccccccccccc cccccccccc,\n"
1729 " Cccccccccccccc cccccccccc, Cccccccccccccc cccccccccc);");
1730 verifyFormat(
1731 "Aaaaaaaaaa bbbbbbbbbbbbbbbbbbbbbbbbbbbbbb(Cccccccccccccc cccccccccc,\n"
1732 " Cccccccccccccc cccccccccc,\n"
1733 " Cccccccccccccc cccccccccc,\n"
1734 " Cccccccccccccc cccccccccc,\n"
1735 " Cccccccccccccc cccccccccc,\n"
1736 " Cccccccccccccc cccccccccc,\n"
1737 " Cccccccccccccc cccccccccc);");
1738 verifyFormat("Aaaaaaaaaa bbbbbbbbbbbbbbbbbbbbbbbbbbbbbb(\n"
1739 " Cccccccccccccc cccccccccc, Cccccccccccccc cccccccccc,\n"
1740 " Cccccccccccccc cccccccccc, Cccccccccccccc cccccccccc,\n"
1741 " Cccccccccccccc cccccccccc, Cccccccccccccc cccccccccc,\n"
1742 " Cccccccccccccc cccccccccc, Cccccccccccccc cccccccccc);");
1743}
1744
Daniel Jasperbac016b2012-12-03 18:12:45 +00001745TEST_F(FormatTest, BreaksDesireably) {
1746 verifyFormat("if (aaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaa) ||\n"
1747 " aaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaa) ||\n"
Manuel Klimek2f1ac412013-01-21 16:42:44 +00001748 " aaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaa)) {\n}");
Daniel Jaspere438bac2013-01-23 20:41:06 +00001749 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n"
1750 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)) {\n"
1751 "}");
Daniel Jasperbac016b2012-12-03 18:12:45 +00001752
1753 verifyFormat(
1754 "aaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n"
Daniel Jasperf11a7052013-02-21 21:33:55 +00001755 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {}");
Daniel Jasperbac016b2012-12-03 18:12:45 +00001756
1757 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n"
1758 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n"
1759 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa));");
Daniel Jaspera88bb452012-12-04 10:50:12 +00001760
1761 verifyFormat(
1762 "aaaaaaaa(aaaaaaaaaaaaa, aaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n"
1763 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)),\n"
1764 " aaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n"
1765 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)));");
Daniel Jasper33182dd2012-12-05 14:57:28 +00001766
1767 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ||\n"
1768 " (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);");
1769
Daniel Jasper723f0302013-01-02 14:40:02 +00001770 verifyFormat(
Alexander Kornienko3fd9ccd2013-03-12 16:28:18 +00001771 "void f() {\n"
1772 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa &&\n"
1773 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);\n"
1774 "}");
Daniel Jasper3499dda2013-01-25 15:43:32 +00001775 verifyFormat(
1776 "aaaaaa(new Aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n"
1777 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaa));");
1778 verifyFormat(
1779 "aaaaaa(aaa, new Aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n"
1780 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaa));");
Daniel Jasper64f09282013-03-20 13:53:11 +00001781 verifyFormat(
1782 "aaaaaaaaaaaaaaaaa(\n"
1783 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n"
1784 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);");
Daniel Jasper723f0302013-01-02 14:40:02 +00001785
Daniel Jasper33182dd2012-12-05 14:57:28 +00001786 // This test case breaks on an incorrect memoization, i.e. an optimization not
1787 // taking into account the StopAt value.
1788 verifyFormat(
1789 "return aaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaa ||\n"
Daniel Jaspercf225b62012-12-24 13:43:52 +00001790 " aaaaaaaaaaa(aaaaaaaaa) || aaaaaaaaaaaaaaaaaaaaaaa ||\n"
1791 " aaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaa ||\n"
1792 " (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);");
Daniel Jaspera4974cf2012-12-24 16:43:00 +00001793
Daniel Jaspercd162382013-01-07 13:26:07 +00001794 verifyFormat("{\n {\n {\n"
1795 " Annotation.SpaceRequiredBefore =\n"
1796 " Line.Tokens[i - 1].Tok.isNot(tok::l_paren) &&\n"
1797 " Line.Tokens[i - 1].Tok.isNot(tok::l_square);\n"
1798 " }\n }\n}");
Daniel Jasperbac016b2012-12-03 18:12:45 +00001799}
1800
Daniel Jasper0df6acd2013-01-16 14:59:02 +00001801TEST_F(FormatTest, FormatsOneParameterPerLineIfNecessary) {
Daniel Jasper8ed9f2b2013-04-03 13:36:17 +00001802 FormatStyle NoBinPacking = getGoogleStyle();
Daniel Jasperfaab0d32013-02-27 09:47:53 +00001803 NoBinPacking.BinPackParameters = false;
1804 verifyFormat("f(aaaaaaaaaaaaaaaaaaaa,\n"
1805 " aaaaaaaaaaaaaaaaaaaa,\n"
1806 " aaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaa);",
1807 NoBinPacking);
1808 verifyFormat("aaaaaaa(aaaaaaaaaaaaa,\n"
1809 " aaaaaaaaaaaaa,\n"
1810 " aaaaaaaaaaaaa(aaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaa));",
1811 NoBinPacking);
1812 verifyFormat(
Daniel Jasper0df6acd2013-01-16 14:59:02 +00001813 "aaaaaaaa(aaaaaaaaaaaaa,\n"
1814 " aaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n"
1815 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)),\n"
1816 " aaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n"
Daniel Jasperfaab0d32013-02-27 09:47:53 +00001817 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)));",
1818 NoBinPacking);
1819 verifyFormat("aaaaaaaaaaaaaaa(aaaaaaaaa, aaaaaaaaa, aaaaaaaaaaaaaaaaaaaaa)\n"
1820 " .aaaaaaaaaaaaaaaaaa();",
1821 NoBinPacking);
1822 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n"
1823 " aaaaaaaaaa, aaaaaaaaaa, aaaaaaaaaa, aaaaaaaaaaa);",
1824 NoBinPacking);
Daniel Jasper66d19bd2013-02-18 11:59:17 +00001825
Daniel Jasperfaab0d32013-02-27 09:47:53 +00001826 verifyFormat(
Daniel Jasper8f4bd7a2013-01-23 10:08:28 +00001827 "aaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaa,\n"
1828 " aaaaaaaaaaaa,\n"
Daniel Jasperfaab0d32013-02-27 09:47:53 +00001829 " aaaaaaaaaaaa);",
1830 NoBinPacking);
1831 verifyFormat(
Daniel Jasper0df6acd2013-01-16 14:59:02 +00001832 "somefunction(someotherFunction(ddddddddddddddddddddddddddddddddddd,\n"
1833 " ddddddddddddddddddddddddddddd),\n"
Daniel Jasperfaab0d32013-02-27 09:47:53 +00001834 " test);",
1835 NoBinPacking);
Daniel Jasper0df6acd2013-01-16 14:59:02 +00001836
Daniel Jasperfaab0d32013-02-27 09:47:53 +00001837 verifyFormat("std::vector<aaaaaaaaaaaaaaaaaaaaaaa,\n"
1838 " aaaaaaaaaaaaaaaaaaaaaaa,\n"
1839 " aaaaaaaaaaaaaaaaaaaaaaa> aaaaaaaaaaaaaaaaaa;",
1840 NoBinPacking);
1841 verifyFormat("a(\"a\"\n"
1842 " \"a\",\n"
1843 " a);");
Daniel Jasper8f4bd7a2013-01-23 10:08:28 +00001844
Daniel Jasperfaab0d32013-02-27 09:47:53 +00001845 NoBinPacking.AllowAllParametersOfDeclarationOnNextLine = false;
Daniel Jasperf1579602013-01-29 16:03:49 +00001846 verifyFormat("void aaaaaaaaaa(aaaaaaaaa,\n"
Daniel Jasper8f4bd7a2013-01-23 10:08:28 +00001847 " aaaaaaaaa,\n"
Daniel Jasperf1579602013-01-29 16:03:49 +00001848 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);",
Daniel Jasperfaab0d32013-02-27 09:47:53 +00001849 NoBinPacking);
Daniel Jasperfc759082013-02-14 14:26:07 +00001850 verifyFormat(
1851 "void f() {\n"
1852 " aaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaa, aaaaaaaaa, aaaaaaaaaaaaaaaaaaaaa)\n"
1853 " .aaaaaaa();\n"
Daniel Jasper66d19bd2013-02-18 11:59:17 +00001854 "}",
Daniel Jasperfaab0d32013-02-27 09:47:53 +00001855 NoBinPacking);
Daniel Jasper0df6acd2013-01-16 14:59:02 +00001856}
1857
Daniel Jasperc79afda2013-01-18 10:56:38 +00001858TEST_F(FormatTest, FormatsBuilderPattern) {
1859 verifyFormat(
1860 "return llvm::StringSwitch<Reference::Kind>(name)\n"
Daniel Jasper65622aa2013-04-08 10:45:44 +00001861 " .StartsWith(\".eh_frame_hdr\", ORDER_EH_FRAMEHDR)\n"
1862 " .StartsWith(\".eh_frame\", ORDER_EH_FRAME).StartsWith(\".init\", ORDER_INIT)\n"
1863 " .StartsWith(\".fini\", ORDER_FINI).StartsWith(\".hash\", ORDER_HASH)\n"
1864 " .Default(ORDER_TEXT);\n");
Daniel Jasperbf71ba22013-04-08 20:33:42 +00001865
Daniel Jasper4a544e52013-02-15 20:33:06 +00001866 verifyFormat("return aaaaaaaaaaaaaaaaa->aaaaa().aaaaaaaaaaaaa().aaaaaa() <\n"
Daniel Jasperbf71ba22013-04-08 20:33:42 +00001867 " aaaaaaaaaaaaaaa->aaaaa().aaaaaaaaaaaaa().aaaaaa();");
Daniel Jasper515f65d2013-02-18 13:24:21 +00001868 verifyFormat(
1869 "aaaaaaa->aaaaaaa\n"
1870 " ->aaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n"
1871 " ->aaaaaaaa(aaaaaaaaaaaaaaa);");
Daniel Jasper82282dc2013-02-18 13:52:06 +00001872 verifyFormat(
1873 "aaaaaaaaaaaaaaaaaaa()->aaaaaa(bbbbb)->aaaaaaaaaaaaaaaaaaa( // break\n"
Daniel Jasper24849712013-03-01 16:48:32 +00001874 " aaaaaaaaaaaaaa);");
Daniel Jasper82282dc2013-02-18 13:52:06 +00001875 verifyFormat(
1876 "aaaaaaaaaaaaaaaaaaaaaaa *aaaaaaaaa = aaaaaa->aaaaaaaaaaaa()\n"
1877 " ->aaaaaaaaaaaaaaaa(\n"
1878 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n"
1879 " ->aaaaaaaaaaaaaaaaa();");
Daniel Jasperc79afda2013-01-18 10:56:38 +00001880}
1881
Daniel Jasper7d19bc22013-01-11 14:23:32 +00001882TEST_F(FormatTest, DoesNotBreakTrailingAnnotation) {
1883 verifyFormat("void aaaaaaaaaaaa(int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n"
Daniel Jasper8ef19a22013-03-14 09:50:46 +00001884 " LOCKS_EXCLUDED(aaaaaaaaaaaaa);");
Daniel Jasper60ca75d2013-01-17 13:31:52 +00001885 verifyFormat("void aaaaaaaaaaaa(int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) const\n"
Daniel Jasper8ef19a22013-03-14 09:50:46 +00001886 " LOCKS_EXCLUDED(aaaaaaaaaaaaa);");
Daniel Jasper60ca75d2013-01-17 13:31:52 +00001887 verifyFormat("void aaaaaaaaaaaa(int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) const\n"
Daniel Jasper8ef19a22013-03-14 09:50:46 +00001888 " LOCKS_EXCLUDED(aaaaaaaaaaaaa) {}");
Daniel Jasper8ed41002013-02-28 14:44:25 +00001889 verifyFormat(
1890 "void aaaaaaaaaaaaaaaaaa()\n"
1891 " __attribute__((aaaaaaaaaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaaaaa,\n"
1892 " aaaaaaaaaaaaaaaaaaaaaaaaa));");
Daniel Jasper8ef19a22013-03-14 09:50:46 +00001893 verifyFormat("bool aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n"
1894 " __attribute__((unused));");
Daniel Jasper1407bee2013-04-11 14:29:13 +00001895
Daniel Jasper8ef19a22013-03-14 09:50:46 +00001896 // FIXME: This is bad indentation, but generally hard to distinguish from a
1897 // function declaration.
1898 verifyFormat(
1899 "bool aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n"
1900 "GUARDED_BY(aaaaaaaaaaaa);");
Daniel Jasper7d19bc22013-01-11 14:23:32 +00001901}
1902
Daniel Jaspere2c7acf2012-12-24 00:13:23 +00001903TEST_F(FormatTest, BreaksAccordingToOperatorPrecedence) {
1904 verifyFormat(
1905 "if (aaaaaaaaaaaaaaaaaaaaaaaaa ||\n"
Manuel Klimek2f1ac412013-01-21 16:42:44 +00001906 " bbbbbbbbbbbbbbbbbbbbbbbbb && ccccccccccccccccccccccccc) {\n}");
Daniel Jaspercd162382013-01-07 13:26:07 +00001907 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaa && bbbbbbbbbbbbbbbbbbbbbbbbb ||\n"
Manuel Klimek2f1ac412013-01-21 16:42:44 +00001908 " ccccccccccccccccccccccccc) {\n}");
Daniel Jaspercd162382013-01-07 13:26:07 +00001909 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaa || bbbbbbbbbbbbbbbbbbbbbbbbb ||\n"
Manuel Klimek2f1ac412013-01-21 16:42:44 +00001910 " ccccccccccccccccccccccccc) {\n}");
Daniel Jaspere2c7acf2012-12-24 00:13:23 +00001911 verifyFormat(
1912 "if ((aaaaaaaaaaaaaaaaaaaaaaaaa || bbbbbbbbbbbbbbbbbbbbbbbbb) &&\n"
Manuel Klimek2f1ac412013-01-21 16:42:44 +00001913 " ccccccccccccccccccccccccc) {\n}");
Daniel Jasper29f123b2013-02-08 15:28:42 +00001914 verifyFormat("return aaaa & AAAAAAAAAAAAAAAAAAAAAAAAAAAAA ||\n"
1915 " bbbb & BBBBBBBBBBBBBBBBBBBBBBBBBBBBB ||\n"
1916 " cccc & CCCCCCCCCCCCCCCCCCCCCCCCCC ||\n"
1917 " dddd & DDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDD;");
1918 verifyFormat("if ((aaaaaaaaaa != aaaaaaaaaaaaaaa ||\n"
1919 " aaaaaaaaaaaaaaaaaaaaaaaa() >= aaaaaaaaaaaaaaaaaaaa) &&\n"
1920 " aaaaaaaaaaaaaaa != aa) {\n}");
Daniel Jaspere2c7acf2012-12-24 00:13:23 +00001921}
1922
Daniel Jasper7006e7e2013-01-23 12:27:43 +00001923TEST_F(FormatTest, BreaksAfterAssignments) {
Daniel Jasper9cda8002013-01-07 13:08:40 +00001924 verifyFormat(
Daniel Jasper7006e7e2013-01-23 12:27:43 +00001925 "unsigned Cost =\n"
1926 " TTI.getMemoryOpCost(I->getOpcode(), VectorTy, SI->getAlignment(),\n"
1927 " SI->getPointerAddressSpaceee());\n");
Daniel Jasper9cda8002013-01-07 13:08:40 +00001928 verifyFormat(
Daniel Jasper13cb7c22013-01-23 15:55:19 +00001929 "CharSourceRange LineRange = CharSourceRange::getTokenRange(\n"
1930 " Line.Tokens.front().Tok.getLo(), Line.Tokens.back().Tok.getLoc());");
Daniel Jasperf39c8852013-01-23 16:58:21 +00001931
1932 verifyFormat(
1933 "aaaaaaaaaaaaaaaaaaaaaaaaaa aaaa = aaaaaaaaaaaaaa(0).aaaa()\n"
1934 " .aaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaa::aaaaaaaaaaaaaaaaaaaaa);");
Daniel Jasper9cda8002013-01-07 13:08:40 +00001935}
1936
Daniel Jaspercf225b62012-12-24 13:43:52 +00001937TEST_F(FormatTest, AlignsAfterAssignments) {
1938 verifyFormat(
1939 "int Result = aaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaa +\n"
Daniel Jasper9cda8002013-01-07 13:08:40 +00001940 " aaaaaaaaaaaaaaaaaaaaaaaaa;");
Daniel Jaspercf225b62012-12-24 13:43:52 +00001941 verifyFormat(
1942 "Result += aaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaa +\n"
Daniel Jasper9cda8002013-01-07 13:08:40 +00001943 " aaaaaaaaaaaaaaaaaaaaaaaaa;");
Daniel Jaspercf225b62012-12-24 13:43:52 +00001944 verifyFormat(
1945 "Result >>= aaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaa +\n"
Daniel Jasper9cda8002013-01-07 13:08:40 +00001946 " aaaaaaaaaaaaaaaaaaaaaaaaa;");
Daniel Jaspercf225b62012-12-24 13:43:52 +00001947 verifyFormat(
1948 "int Result = (aaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaa +\n"
Daniel Jasper9cda8002013-01-07 13:08:40 +00001949 " aaaaaaaaaaaaaaaaaaaaaaaaa);");
Daniel Jasper66d19bd2013-02-18 11:59:17 +00001950 verifyFormat("double LooooooooooooooooooooooooongResult =\n"
1951 " aaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaa +\n"
1952 " aaaaaaaaaaaaaaaaaaaaaaaa;");
Daniel Jaspercf225b62012-12-24 13:43:52 +00001953}
1954
1955TEST_F(FormatTest, AlignsAfterReturn) {
1956 verifyFormat(
1957 "return aaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaa +\n"
1958 " aaaaaaaaaaaaaaaaaaaaaaaaa;");
1959 verifyFormat(
1960 "return (aaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaa +\n"
1961 " aaaaaaaaaaaaaaaaaaaaaaaaa);");
Daniel Jasper37911302013-04-02 14:33:13 +00001962 verifyFormat(
1963 "return aaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa >=\n"
Daniel Jasperbf71ba22013-04-08 20:33:42 +00001964 " aaaaaaaaaaaaaaaaaaaaaa();");
Daniel Jasper37911302013-04-02 14:33:13 +00001965 verifyFormat(
1966 "return (aaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa >=\n"
Daniel Jasperbf71ba22013-04-08 20:33:42 +00001967 " aaaaaaaaaaaaaaaaaaaaaa());");
1968 verifyFormat("return aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n"
1969 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);");
1970 verifyFormat("return aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n"
1971 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) &&\n"
1972 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;");
Daniel Jaspercf225b62012-12-24 13:43:52 +00001973}
1974
Daniel Jasper9c837d02013-01-09 07:06:56 +00001975TEST_F(FormatTest, BreaksConditionalExpressions) {
1976 verifyFormat(
1977 "aaaa(aaaaaaaaaaaaaaaaaaaa,\n"
Daniel Jasperbfe6fd42013-01-28 12:45:14 +00001978 " aaaaaaaaaaaaaaaaaaaaaaaaaa ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n"
1979 " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);");
Daniel Jasper1f2b0782013-01-16 16:23:19 +00001980 verifyFormat(
Daniel Jasperbfe6fd42013-01-28 12:45:14 +00001981 "aaaa(aaaaaaaaaaaaaaaaaaaa, aaaaaaa ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n"
1982 " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);");
1983 verifyFormat(
1984 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaa ? aaaa(aaaaaa)\n"
1985 " : aaaaaaaaaaaaa);");
1986 verifyFormat(
1987 "aaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaa,\n"
Daniel Jasper64f09282013-03-20 13:53:11 +00001988 " aaaaaaaaaaaaaaaa ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n"
Daniel Jasperbfe6fd42013-01-28 12:45:14 +00001989 " : aaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n"
1990 " aaaaaaaaaaaaa);");
1991 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n"
1992 " ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n"
1993 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n"
1994 " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n"
1995 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);");
1996 verifyFormat("aaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n"
1997 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n"
1998 " ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n"
1999 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n"
2000 " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n"
2001 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa),\n"
2002 " aaaaaaaaaaaaaaaaaaaaaaaaaaa);");
Daniel Jasper7878a7b2013-02-15 11:07:25 +00002003
2004 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n"
2005 " ? aaaaaaaaaaaaaaaaaaaaaaaaaaa\n"
2006 " : aaaaaaaaaaaaaaaaaaaaaaaaaaa;");
Daniel Jasper37911302013-04-02 14:33:13 +00002007 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaa =\n"
2008 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n"
2009 " ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n"
2010 " : aaaaaaaaaaaaaaaa;");
Daniel Jasper237d4c12013-02-23 21:01:55 +00002011 verifyFormat(
2012 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa == aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n"
2013 " ? aaaaaaaaaaaaaaa\n"
2014 " : aaaaaaaaaaaaaaa;");
2015 verifyFormat("f(aaaaaaaaaaaaaaaa == // force break\n"
Daniel Jasperbf71ba22013-04-08 20:33:42 +00002016 " aaaaaaaaa\n"
Daniel Jasper65622aa2013-04-08 10:45:44 +00002017 " ? b\n"
2018 " : c);");
Daniel Jasper087387a2013-02-08 16:49:27 +00002019 verifyFormat(
Daniel Jasper7878a7b2013-02-15 11:07:25 +00002020 "unsigned Indent =\n"
2021 " format(TheLine.First, IndentForLevel[TheLine.Level] >= 0\n"
2022 " ? IndentForLevel[TheLine.Level]\n"
Daniel Jasper7d812812013-02-21 15:00:29 +00002023 " : TheLine * 2,\n"
2024 " TheLine.InPPDirective, PreviousEndOfLineColumn);",
Daniel Jasper66d19bd2013-02-18 11:59:17 +00002025 getLLVMStyleWithColumns(70));
Daniel Jasper7878a7b2013-02-15 11:07:25 +00002026
Daniel Jasperfaab0d32013-02-27 09:47:53 +00002027 FormatStyle NoBinPacking = getLLVMStyle();
2028 NoBinPacking.BinPackParameters = false;
2029 verifyFormat(
Daniel Jasper237d4c12013-02-23 21:01:55 +00002030 "void f() {\n"
2031 " g(aaa,\n"
2032 " aaaaaaaaaa == aaaaaaaaaa ? aaaa : aaaaa,\n"
2033 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa == aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n"
2034 " ? aaaaaaaaaaaaaaa\n"
2035 " : aaaaaaaaaaaaaaa);\n"
Daniel Jasperfaab0d32013-02-27 09:47:53 +00002036 "}",
2037 NoBinPacking);
Daniel Jasper9c837d02013-01-09 07:06:56 +00002038}
2039
Daniel Jasper2e603772013-01-29 11:21:01 +00002040TEST_F(FormatTest, DeclarationsOfMultipleVariables) {
2041 verifyFormat("bool aaaaaaaaaaaaaaaaa = aaaaaa->aaaaaaaaaaaaaaaaa(),\n"
2042 " aaaaaaaaaaa = aaaaaa->aaaaaaaaaaa();");
2043 verifyFormat("bool a = true, b = false;");
2044
Daniel Jasper2e603772013-01-29 11:21:01 +00002045 verifyFormat("bool aaaaaaaaaaaaaaaaaaaaaaaaa =\n"
Daniel Jasper8ed9f2b2013-04-03 13:36:17 +00002046 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaa),\n"
Daniel Jasper2e603772013-01-29 11:21:01 +00002047 " bbbbbbbbbbbbbbbbbbbbbbbbb =\n"
Daniel Jasper37911302013-04-02 14:33:13 +00002048 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb(bbbbbbbbbbbbbbbb);");
Daniel Jasper2e603772013-01-29 11:21:01 +00002049 verifyFormat(
Daniel Jasper7d812812013-02-21 15:00:29 +00002050 "bool aaaaaaaaaaaaaaaaaaaaa =\n"
Daniel Jasper8ed9f2b2013-04-03 13:36:17 +00002051 " bbbbbbbbbbbbbbbbbbbbbbbbbbbb && cccccccccccccccccccccccccccc,\n"
Daniel Jasper7d812812013-02-21 15:00:29 +00002052 " d = e && f;");
Daniel Jasperadc0f092013-04-05 09:38:50 +00002053 verifyFormat("aaaaaaaaa a = aaaaaaaaaaaaaaaaaaaa, b = bbbbbbbbbbbbbbbbbbbb,\n"
2054 " c = cccccccccccccccccccc, d = dddddddddddddddddddd;");
2055 verifyFormat("aaaaaaaaa *a = aaaaaaaaaaaaaaaaaaa, *b = bbbbbbbbbbbbbbbbbbb,\n"
2056 " *c = ccccccccccccccccccc, *d = ddddddddddddddddddd;");
2057 verifyFormat("aaaaaaaaa ***a = aaaaaaaaaaaaaaaaaaa, ***b = bbbbbbbbbbbbbbb,\n"
2058 " ***c = ccccccccccccccccccc, ***d = ddddddddddddddd;");
2059 // FIXME: If multiple variables are defined, the "*" needs to move to the new
2060 // line. Also fix indent for breaking after the type, this looks bad.
2061 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa *\n"
2062 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaa = aaaaaaaaaaaaaaaaaaa,\n"
2063 " *b = bbbbbbbbbbbbbbbbbbb;");
Daniel Jasper2e603772013-01-29 11:21:01 +00002064
Daniel Jasperadc0f092013-04-05 09:38:50 +00002065 // Not ideal, but pointer-with-type does not allow much here.
2066 verifyGoogleFormat(
2067 "aaaaaaaaa* a = aaaaaaaaaaaaaaaaaaa, *b = bbbbbbbbbbbbbbbbbbb,\n"
2068 " *b = bbbbbbbbbbbbbbbbbbb, *d = ddddddddddddddddddd;");
Daniel Jasper2e603772013-01-29 11:21:01 +00002069}
2070
Nico Weber7d37b8b2013-01-12 01:28:06 +00002071TEST_F(FormatTest, ConditionalExpressionsInBrackets) {
2072 verifyFormat("arr[foo ? bar : baz];");
2073 verifyFormat("f()[foo ? bar : baz];");
2074 verifyFormat("(a + b)[foo ? bar : baz];");
2075 verifyFormat("arr[foo ? (4 > 5 ? 4 : 5) : 5 < 5 ? 5 : 7];");
2076}
2077
Daniel Jasperbac016b2012-12-03 18:12:45 +00002078TEST_F(FormatTest, AlignsStringLiterals) {
2079 verifyFormat("loooooooooooooooooooooooooongFunction(\"short literal \"\n"
2080 " \"short literal\");");
2081 verifyFormat(
2082 "looooooooooooooooooooooooongFunction(\n"
2083 " \"short literal\"\n"
2084 " \"looooooooooooooooooooooooooooooooooooooooooooooooong literal\");");
Daniel Jasper66d19bd2013-02-18 11:59:17 +00002085 verifyFormat("someFunction(\"Always break between multi-line\"\n"
2086 " \" string literals\",\n"
2087 " and, other, parameters);");
Manuel Klimekb56b6d12013-02-20 15:25:48 +00002088 EXPECT_EQ("fun + \"1243\" /* comment */\n"
2089 " \"5678\";",
2090 format("fun + \"1243\" /* comment */\n"
2091 " \"5678\";",
2092 getLLVMStyleWithColumns(28)));
2093 EXPECT_EQ(
2094 "aaaaaa = \"aaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaaaaaaaaaaaa \"\n"
2095 " \"aaaaaaaaaaaaaaaaaaaaa\"\n"
2096 " \"aaaaaaaaaaaaaaaa\";",
2097 format("aaaaaa ="
2098 "\"aaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaaaaaaaaaaaa "
2099 "aaaaaaaaaaaaaaaaaaaaa\" "
2100 "\"aaaaaaaaaaaaaaaa\";"));
Manuel Klimeke9a62262013-02-20 15:32:58 +00002101 verifyFormat("a = a + \"a\"\n"
2102 " \"a\"\n"
2103 " \"a\";");
Daniel Jasper3a204412013-02-23 07:46:38 +00002104
2105 verifyFormat(
2106 "#define LL_FORMAT \"ll\"\n"
2107 "printf(\"aaaaa: %d, bbbbbb: %\" LL_FORMAT \"d, cccccccc: %\" LL_FORMAT\n"
2108 " \"d, ddddddddd: %\" LL_FORMAT \"d\");");
Daniel Jasperbac016b2012-12-03 18:12:45 +00002109}
2110
Alexander Kornienko15757312012-12-06 18:03:27 +00002111TEST_F(FormatTest, AlignsPipes) {
2112 verifyFormat(
2113 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n"
2114 " << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n"
2115 " << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;");
2116 verifyFormat(
2117 "aaaaaaaaaaaaaaaaaaaa << aaaaaaaaaaaaaaaaaaaa << aaaaaaaaaaaaaaaaaaaa\n"
2118 " << aaaaaaaaaaaaaaaaaaaa;");
2119 verifyFormat(
2120 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa << aaaaaaaaaaaaaaaaaaaaaaaaaaaa\n"
2121 " << aaaaaaaaaaaaaaaaaaaaaaaaaaaa;");
2122 verifyFormat(
2123 "llvm::outs() << \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\"\n"
2124 " \"bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb\"\n"
2125 " << \"ccccccccccccccccccccccccccccccccccccccccccccccccc\";");
2126 verifyFormat(
2127 "aaaaaaaa << (aaaaaaaaaaaaaaaaaaa << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n"
2128 " << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n"
2129 " << aaaaaaaaaaaaaaaaaaaaaaaaaaaaa;");
Daniel Jasperfa543ac2013-02-04 07:34:48 +00002130
2131 verifyFormat("return out << \"somepacket = {\\n\"\n"
2132 " << \" aaaaaa = \" << pkt.aaaaaa << \"\\n\"\n"
2133 " << \" bbbb = \" << pkt.bbbb << \"\\n\"\n"
2134 " << \" cccccc = \" << pkt.cccccc << \"\\n\"\n"
2135 " << \" ddd = [\" << pkt.ddd << \"]\\n\"\n"
2136 " << \"}\";");
Daniel Jasper4e8a7b42013-02-06 21:04:05 +00002137
2138 verifyFormat(
2139 "llvm::outs() << \"aaaaaaaaaaaaaaaaa = \" << aaaaaaaaaaaaaaaaa\n"
2140 " << \"bbbbbbbbbbbbbbbbb = \" << bbbbbbbbbbbbbbbbb\n"
2141 " << \"ccccccccccccccccc = \" << ccccccccccccccccc\n"
2142 " << \"ddddddddddddddddd = \" << ddddddddddddddddd\n"
2143 " << \"eeeeeeeeeeeeeeeee = \" << eeeeeeeeeeeeeeeee;");
Daniel Jasperbfa1edd2013-03-14 14:00:17 +00002144 verifyFormat("llvm::outs() << aaaaaaaaaaaaaaaaaaaaaaaa << \"=\"\n"
2145 " << bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb;");
Daniel Jasper37911302013-04-02 14:33:13 +00002146
2147 verifyFormat(
2148 "llvm::errs() << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n"
2149 " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa();");
Alexander Kornienko15757312012-12-06 18:03:27 +00002150}
2151
Daniel Jasperbac016b2012-12-03 18:12:45 +00002152TEST_F(FormatTest, UnderstandsEquals) {
2153 verifyFormat(
2154 "aaaaaaaaaaaaaaaaa =\n"
2155 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;");
2156 verifyFormat(
2157 "if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa =\n"
Manuel Klimek2f1ac412013-01-21 16:42:44 +00002158 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n}");
Daniel Jasperbac016b2012-12-03 18:12:45 +00002159 verifyFormat(
2160 "if (a) {\n"
Manuel Klimek36fab8d2013-01-10 13:24:24 +00002161 " f();\n"
Daniel Jasperbac016b2012-12-03 18:12:45 +00002162 "} else if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa =\n"
Manuel Klimek2f1ac412013-01-21 16:42:44 +00002163 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n"
2164 "}");
Daniel Jasperbac016b2012-12-03 18:12:45 +00002165
Daniel Jasper66d19bd2013-02-18 11:59:17 +00002166 verifyFormat("if (int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa =\n"
2167 " 100000000 + 10000000) {\n}");
Daniel Jasperbac016b2012-12-03 18:12:45 +00002168}
2169
Daniel Jasper9a0b4942012-12-17 14:34:14 +00002170TEST_F(FormatTest, WrapsAtFunctionCallsIfNecessary) {
Daniel Jasper1321eb52012-12-18 21:05:13 +00002171 verifyFormat("LoooooooooooooooooooooooooooooooooooooongObject\n"
2172 " .looooooooooooooooooooooooooooooooooooooongFunction();");
Daniel Jasper9a0b4942012-12-17 14:34:14 +00002173
Daniel Jasper1321eb52012-12-18 21:05:13 +00002174 verifyFormat("LoooooooooooooooooooooooooooooooooooooongObject\n"
2175 " ->looooooooooooooooooooooooooooooooooooooongFunction();");
Daniel Jasper9a0b4942012-12-17 14:34:14 +00002176
2177 verifyFormat(
2178 "LooooooooooooooooooooooooooooooooongObject->shortFunction(Parameter1,\n"
2179 " Parameter2);");
2180
2181 verifyFormat(
2182 "ShortObject->shortFunction(\n"
2183 " LooooooooooooooooooooooooooooooooooooooooooooooongParameter1,\n"
2184 " LooooooooooooooooooooooooooooooooooooooooooooooongParameter2);");
2185
2186 verifyFormat("loooooooooooooongFunction(\n"
2187 " LoooooooooooooongObject->looooooooooooooooongFunction());");
2188
2189 verifyFormat(
2190 "function(LoooooooooooooooooooooooooooooooooooongObject\n"
2191 " ->loooooooooooooooooooooooooooooooooooooooongFunction());");
2192
Daniel Jasperfc759082013-02-14 14:26:07 +00002193 verifyFormat("EXPECT_CALL(SomeObject, SomeFunction(Parameter))\n"
2194 " .WillRepeatedly(Return(SomeValue));");
2195 verifyFormat("SomeMap[std::pair(aaaaaaaaaaaa, bbbbbbbbbbbbbbb)]\n"
2196 " .insert(ccccccccccccccccccccccc);");
Daniel Jasper3af59ce2013-03-15 14:57:30 +00002197 verifyFormat(
2198 "aaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n"
2199 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n"
2200 " .aaaaaaaaaaaaaaa(\n"
2201 " aa(aaaaaaaaaaaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaaaaaaaaa,\n"
2202 " aaaaaaaaaaaaaaaaaaaaaaaaaaa));");
Daniel Jasper37911302013-04-02 14:33:13 +00002203 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n"
2204 " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n"
2205 " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n"
2206 " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa()) {\n"
2207 "}");
Daniel Jasperfc759082013-02-14 14:26:07 +00002208
Daniel Jasper46a46a22013-01-07 07:13:20 +00002209 // Here, it is not necessary to wrap at "." or "->".
Daniel Jasper1321eb52012-12-18 21:05:13 +00002210 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaa) ||\n"
Manuel Klimek2f1ac412013-01-21 16:42:44 +00002211 " aaaa.aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n}");
Daniel Jasper46a46a22013-01-07 07:13:20 +00002212 verifyFormat(
2213 "aaaaaaaaaaa->aaaaaaaaa(\n"
2214 " aaaaaaaaaaaaaaaaaaaaaaaaa,\n"
2215 " aaaaaaaaaaaaaaaaaa->aaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaa));\n");
Daniel Jasper9fc56f22013-02-14 15:01:34 +00002216
2217 verifyFormat(
2218 "aaaaaaaaaaaaaaaaaaaaaaaaa(\n"
2219 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa().aaaaaaaaaaaaaaaaa());");
Daniel Jasper8d0d19a2013-03-13 15:37:48 +00002220 verifyFormat("a->aaaaaa()->aaaaaaaaaaa(aaaaaaaa()->aaaaaa()->aaaaa() *\n"
2221 " aaaaaaaaa()->aaaaaa()->aaaaa());");
2222 verifyFormat("a->aaaaaa()->aaaaaaaaaaa(aaaaaaaa()->aaaaaa()->aaaaa() ||\n"
2223 " aaaaaaaaa()->aaaaaa()->aaaaa());");
Daniel Jasperfaab0d32013-02-27 09:47:53 +00002224
Daniel Jasper3af59ce2013-03-15 14:57:30 +00002225 // FIXME: Should we break before .a()?
2226 verifyFormat("aaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n"
2227 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa).a();");
2228
Daniel Jasperfaab0d32013-02-27 09:47:53 +00002229 FormatStyle NoBinPacking = getLLVMStyle();
2230 NoBinPacking.BinPackParameters = false;
2231 verifyFormat("aaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaa)\n"
2232 " .aaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaa)\n"
2233 " .aaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaa,\n"
2234 " aaaaaaaaaaaaaaaaaaa,\n"
2235 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);",
2236 NoBinPacking);
Daniel Jasper9a0b4942012-12-17 14:34:14 +00002237}
2238
Daniel Jasper9a64fb52013-01-02 15:08:56 +00002239TEST_F(FormatTest, WrapsTemplateDeclarations) {
2240 verifyFormat("template <typename T>\n"
2241 "virtual void loooooooooooongFunction(int Param1, int Param2);");
2242 verifyFormat(
Daniel Jasperc79afda2013-01-18 10:56:38 +00002243 "template <typename T>\n"
Daniel Jasper29f123b2013-02-08 15:28:42 +00002244 "using comment_to_xml_conversion = comment_to_xml_conversion<T, int>;");
Daniel Jasper66d19bd2013-02-18 11:59:17 +00002245 verifyFormat("template <typename T>\n"
2246 "void f(int Paaaaaaaaaaaaaaaaaaaaaaaaaaaaaaram1,\n"
2247 " int Paaaaaaaaaaaaaaaaaaaaaaaaaaaaaaram2);");
Daniel Jasper9a64fb52013-01-02 15:08:56 +00002248 verifyFormat(
2249 "template <typename T>\n"
2250 "void looooooooooooooooooooongFunction(int Paaaaaaaaaaaaaaaaaaaaram1,\n"
2251 " int Paaaaaaaaaaaaaaaaaaaaram2);");
Daniel Jasper5eda31e2013-01-02 18:30:06 +00002252 verifyFormat(
2253 "template <typename T>\n"
2254 "aaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaa,\n"
2255 " aaaaaaaaaaaaaaaaaaaaaaaaaa<T>::aaaaaaaaaa,\n"
2256 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);");
Daniel Jasperd64f7382013-01-09 09:50:48 +00002257 verifyFormat("template <typename T>\n"
2258 "void aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n"
Daniel Jasper8ed9f2b2013-04-03 13:36:17 +00002259 " int aaaaaaaaaaaaaaaaaaaaaa);");
Daniel Jasper3fc0bb72013-01-09 10:40:23 +00002260 verifyFormat(
2261 "template <typename T1, typename T2 = char, typename T3 = char,\n"
2262 " typename T4 = char>\n"
2263 "void f();");
Daniel Jasper3499dda2013-01-25 15:43:32 +00002264 verifyFormat(
2265 "aaaaaaaaaaaaaaaaaaaaaaaa<aaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaa>(\n"
2266 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);");
Daniel Jasper01786732013-02-04 07:21:18 +00002267
Daniel Jasper66d19bd2013-02-18 11:59:17 +00002268 verifyFormat("a<aaaaaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaa>(\n"
2269 " a(aaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaa));");
Daniel Jasper9a64fb52013-01-02 15:08:56 +00002270}
2271
Daniel Jasper63f00362013-01-25 10:57:27 +00002272TEST_F(FormatTest, WrapsAtNestedNameSpecifiers) {
2273 verifyFormat(
2274 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::\n"
2275 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa();");
2276 verifyFormat(
2277 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::\n"
2278 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n"
2279 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa());");
2280
2281 // FIXME: Should we have an extra indent after the second break?
2282 verifyFormat(
2283 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::\n"
2284 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::\n"
2285 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa();");
2286
2287 // FIXME: Look into whether we should indent 4 from the start or 4 from
2288 // "bbbbb..." here instead of what we are doing now.
2289 verifyFormat(
2290 "aaaaaaaaaaaaaaa(bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb::\n"
Daniel Jasper5f2173e2013-01-28 07:43:15 +00002291 " cccccccccccccccccccccccccccccccccccccccccccccc());");
Daniel Jasper63f00362013-01-25 10:57:27 +00002292
2293 // Breaking at nested name specifiers is generally not desirable.
2294 verifyFormat(
2295 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n"
2296 " aaaaaaaaaaaaaaaaaaaaaaa);");
Daniel Jasperbfe6fd42013-01-28 12:45:14 +00002297
2298 verifyFormat(
2299 "aaaaaaaaaaaaaaaaaa(aaaaaaaa, aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::\n"
2300 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n"
2301 " aaaaaaaaaaaaaaaaaaaaa);",
2302 getLLVMStyleWithColumns(74));
Daniel Jasper37911302013-04-02 14:33:13 +00002303
2304 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::\n"
2305 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n"
2306 " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa();");
Daniel Jasper63f00362013-01-25 10:57:27 +00002307}
2308
Daniel Jasperbac016b2012-12-03 18:12:45 +00002309TEST_F(FormatTest, UnderstandsTemplateParameters) {
2310 verifyFormat("A<int> a;");
2311 verifyFormat("A<A<A<int> > > a;");
2312 verifyFormat("A<A<A<int, 2>, 3>, 4> a;");
2313 verifyFormat("bool x = a < 1 || 2 > a;");
2314 verifyFormat("bool x = 5 < f<int>();");
2315 verifyFormat("bool x = f<int>() > 5;");
2316 verifyFormat("bool x = 5 < a<int>::x;");
2317 verifyFormat("bool x = a < 4 ? a > 2 : false;");
2318 verifyFormat("bool x = f() ? a < 2 : a > 2;");
2319
2320 verifyGoogleFormat("A<A<int>> a;");
2321 verifyGoogleFormat("A<A<A<int>>> a;");
2322 verifyGoogleFormat("A<A<A<A<int>>>> a;");
Daniel Jasper8ff690a2013-02-06 14:22:40 +00002323 verifyGoogleFormat("A<A<int> > a;");
2324 verifyGoogleFormat("A<A<A<int> > > a;");
2325 verifyGoogleFormat("A<A<A<A<int> > > > a;");
2326 EXPECT_EQ("A<A<A<A>>> a;", format("A<A<A<A> >> a;", getGoogleStyle()));
2327 EXPECT_EQ("A<A<A<A>>> a;", format("A<A<A<A>> > a;", getGoogleStyle()));
Daniel Jasperbac016b2012-12-03 18:12:45 +00002328
2329 verifyFormat("test >> a >> b;");
2330 verifyFormat("test << a >> b;");
2331
2332 verifyFormat("f<int>();");
Manuel Klimek36fab8d2013-01-10 13:24:24 +00002333 verifyFormat("template <typename T> void f() {}");
Daniel Jasperbac016b2012-12-03 18:12:45 +00002334}
2335
Daniel Jasper807809c2013-02-28 09:21:10 +00002336TEST_F(FormatTest, UnderstandsBinaryOperators) {
2337 verifyFormat("COMPARE(a, ==, b);");
Alexander Kornienko54a38bd2013-03-20 16:41:56 +00002338}
2339
2340TEST_F(FormatTest, UnderstandsPointersToMembers) {
2341 verifyFormat("int A::*x;");
2342 // FIXME: Recognize pointers to member functions.
2343 //verifyFormat("int (S::*func)(void *);");
2344 verifyFormat("int(S::*func)(void *);");
2345 verifyFormat("(a->*f)();");
2346 verifyFormat("a->*x;");
2347 verifyFormat("(a.*f)();");
2348 verifyFormat("((*a).*f)();");
2349 verifyFormat("a.*x;");
Daniel Jasper807809c2013-02-28 09:21:10 +00002350}
2351
Daniel Jasper98e6b4a2012-12-21 09:41:31 +00002352TEST_F(FormatTest, UnderstandsUnaryOperators) {
Daniel Jasperbac016b2012-12-03 18:12:45 +00002353 verifyFormat("int a = -2;");
Daniel Jasper8822d3a2012-12-04 13:02:32 +00002354 verifyFormat("f(-1, -2, -3);");
2355 verifyFormat("a[-1] = 5;");
2356 verifyFormat("int a = 5 + -2;");
Manuel Klimek2f1ac412013-01-21 16:42:44 +00002357 verifyFormat("if (i == -1) {\n}");
2358 verifyFormat("if (i != -1) {\n}");
2359 verifyFormat("if (i > -1) {\n}");
2360 verifyFormat("if (i < -1) {\n}");
Daniel Jasperd56a7372012-12-06 13:16:39 +00002361 verifyFormat("++(a->f());");
2362 verifyFormat("--(a->f());");
Daniel Jasper4abbb532013-01-14 12:18:19 +00002363 verifyFormat("(a->f())++;");
2364 verifyFormat("a[42]++;");
Manuel Klimek2f1ac412013-01-21 16:42:44 +00002365 verifyFormat("if (!(a->f())) {\n}");
Daniel Jasper98e6b4a2012-12-21 09:41:31 +00002366
2367 verifyFormat("a-- > b;");
2368 verifyFormat("b ? -a : c;");
2369 verifyFormat("n * sizeof char16;");
Daniel Jasperba3d3072013-01-02 17:21:36 +00002370 verifyFormat("n * alignof char16;");
Daniel Jasper98e6b4a2012-12-21 09:41:31 +00002371 verifyFormat("sizeof(char);");
Daniel Jasperba3d3072013-01-02 17:21:36 +00002372 verifyFormat("alignof(char);");
Daniel Jasper1f0754b2013-01-02 15:26:16 +00002373
2374 verifyFormat("return -1;");
2375 verifyFormat("switch (a) {\n"
2376 "case -1:\n"
2377 " break;\n"
2378 "}");
Daniel Jasperb5985422013-03-22 10:44:43 +00002379 verifyFormat("#define X -1");
2380 verifyFormat("#define X -kConstant");
Nico Webercc191d12013-01-12 05:41:23 +00002381
2382 verifyFormat("const NSPoint kBrowserFrameViewPatternOffset = { -5, +3 };");
2383 verifyFormat("const NSPoint kBrowserFrameViewPatternOffset = { +5, -3 };");
Daniel Jasperb369c2c2013-01-15 14:27:39 +00002384
2385 verifyFormat("int a = /* confusing comment */ -1;");
2386 // FIXME: The space after 'i' is wrong, but hopefully, this is a rare case.
2387 verifyFormat("int a = i /* confusing comment */++;");
Daniel Jasperbac016b2012-12-03 18:12:45 +00002388}
2389
2390TEST_F(FormatTest, UndestandsOverloadedOperators) {
Daniel Jasperf6aef6a2012-12-24 10:56:04 +00002391 verifyFormat("bool operator<();");
2392 verifyFormat("bool operator>();");
2393 verifyFormat("bool operator=();");
2394 verifyFormat("bool operator==();");
2395 verifyFormat("bool operator!=();");
2396 verifyFormat("int operator+();");
2397 verifyFormat("int operator++();");
2398 verifyFormat("bool operator();");
2399 verifyFormat("bool operator()();");
2400 verifyFormat("bool operator[]();");
2401 verifyFormat("operator bool();");
Daniel Jasper2b4c9242013-02-11 08:01:18 +00002402 verifyFormat("operator int();");
2403 verifyFormat("operator void *();");
Daniel Jasperf6aef6a2012-12-24 10:56:04 +00002404 verifyFormat("operator SomeType<int>();");
Daniel Jasper2b4c9242013-02-11 08:01:18 +00002405 verifyFormat("operator SomeType<int, int>();");
2406 verifyFormat("operator SomeType<SomeType<int> >();");
Daniel Jasperf6aef6a2012-12-24 10:56:04 +00002407 verifyFormat("void *operator new(std::size_t size);");
2408 verifyFormat("void *operator new[](std::size_t size);");
2409 verifyFormat("void operator delete(void *ptr);");
2410 verifyFormat("void operator delete[](void *ptr);");
Daniel Jasper2b4c9242013-02-11 08:01:18 +00002411
Daniel Jasperdc2efa12013-02-15 19:24:08 +00002412 verifyFormat(
2413 "ostream &operator<<(ostream &OutputStream,\n"
2414 " SomeReallyLongType WithSomeReallyLongValue);");
Daniel Jasper27b91cc2013-04-05 17:21:59 +00002415 verifyFormat("bool operator<(const aaaaaaaaaaaaaaaaaaaaa &left,\n"
2416 " const aaaaaaaaaaaaaaaaaaaaa &right) {\n"
2417 " return left.group < right.group;\n"
2418 "}");
Daniel Jasper2eb23b72013-04-11 08:48:20 +00002419 verifyFormat("SomeType &operator=(const SomeType &S);");
Daniel Jasperdc2efa12013-02-15 19:24:08 +00002420
Daniel Jasper2b4c9242013-02-11 08:01:18 +00002421 verifyGoogleFormat("operator void*();");
2422 verifyGoogleFormat("operator SomeType<SomeType<int>>();");
Daniel Jasperbac016b2012-12-03 18:12:45 +00002423}
2424
Daniel Jasper088dab52013-01-11 16:09:04 +00002425TEST_F(FormatTest, UnderstandsNewAndDelete) {
Daniel Jasper37eff832013-02-23 08:07:18 +00002426 verifyFormat("void f() {\n"
2427 " A *a = new A;\n"
2428 " A *a = new (placement) A;\n"
2429 " delete a;\n"
2430 " delete (A *)a;\n"
2431 "}");
Daniel Jasper088dab52013-01-11 16:09:04 +00002432}
2433
Daniel Jasper5d334402013-01-02 08:57:10 +00002434TEST_F(FormatTest, UnderstandsUsesOfStarAndAmp) {
Manuel Klimek36fab8d2013-01-10 13:24:24 +00002435 verifyFormat("int *f(int *a) {}");
Manuel Klimek36fab8d2013-01-10 13:24:24 +00002436 verifyFormat("int main(int argc, char **argv) {}");
Daniel Jasperd0f349b2013-02-18 12:44:35 +00002437 verifyFormat("Test::Test(int b) : a(b * b) {}");
Daniel Jasper4bfc65a2013-01-23 12:10:53 +00002438 verifyIndependentOfContext("f(a, *a);");
Daniel Jasper8a5d7cd2013-03-01 17:13:29 +00002439 verifyFormat("void g() { f(*a); }");
Daniel Jasper4bfc65a2013-01-23 12:10:53 +00002440 verifyIndependentOfContext("int a = b * 10;");
2441 verifyIndependentOfContext("int a = 10 * b;");
2442 verifyIndependentOfContext("int a = b * c;");
2443 verifyIndependentOfContext("int a += b * c;");
2444 verifyIndependentOfContext("int a -= b * c;");
2445 verifyIndependentOfContext("int a *= b * c;");
2446 verifyIndependentOfContext("int a /= b * c;");
2447 verifyIndependentOfContext("int a = *b;");
2448 verifyIndependentOfContext("int a = *b * c;");
2449 verifyIndependentOfContext("int a = b * *c;");
2450 verifyIndependentOfContext("return 10 * b;");
2451 verifyIndependentOfContext("return *b * *c;");
2452 verifyIndependentOfContext("return a & ~b;");
2453 verifyIndependentOfContext("f(b ? *c : *d);");
2454 verifyIndependentOfContext("int a = b ? *c : *d;");
2455 verifyIndependentOfContext("*b = a;");
2456 verifyIndependentOfContext("a * ~b;");
2457 verifyIndependentOfContext("a * !b;");
2458 verifyIndependentOfContext("a * +b;");
2459 verifyIndependentOfContext("a * -b;");
2460 verifyIndependentOfContext("a * ++b;");
2461 verifyIndependentOfContext("a * --b;");
2462 verifyIndependentOfContext("a[4] * b;");
Daniel Jasper9c65b062013-02-27 11:43:50 +00002463 verifyIndependentOfContext("a[a * a] = 1;");
Daniel Jasper4bfc65a2013-01-23 12:10:53 +00002464 verifyIndependentOfContext("f() * b;");
2465 verifyIndependentOfContext("a * [self dostuff];");
Daniel Jasper81d2d382013-04-01 17:13:26 +00002466 verifyIndependentOfContext("int x = a * (a + b);");
Daniel Jasper4bfc65a2013-01-23 12:10:53 +00002467 verifyIndependentOfContext("(a *)(a + b);");
2468 verifyIndependentOfContext("int *pa = (int *)&a;");
Nico Weber95e8e462013-02-12 16:17:07 +00002469 verifyIndependentOfContext("return sizeof(int **);");
2470 verifyIndependentOfContext("return sizeof(int ******);");
2471 verifyIndependentOfContext("return (int **&)a;");
Daniel Jasper8a5d7cd2013-03-01 17:13:29 +00002472 verifyFormat("void f(Type (*parameter)[10]) {}");
Nico Weber95e8e462013-02-12 16:17:07 +00002473 verifyGoogleFormat("return sizeof(int**);");
2474 verifyIndependentOfContext("Type **A = static_cast<Type **>(P);");
2475 verifyGoogleFormat("Type** A = static_cast<Type**>(P);");
2476 // FIXME: The newline is wrong.
2477 verifyFormat("auto a = [](int **&, int ***) {}\n;");
Daniel Jasperc74e2792012-12-07 09:52:15 +00002478
Daniel Jasper4bfc65a2013-01-23 12:10:53 +00002479 verifyIndependentOfContext("InvalidRegions[*R] = 0;");
Daniel Jasper9bb0d282013-01-04 20:46:38 +00002480
Daniel Jasper4bfc65a2013-01-23 12:10:53 +00002481 verifyIndependentOfContext("A<int *> a;");
2482 verifyIndependentOfContext("A<int **> a;");
2483 verifyIndependentOfContext("A<int *, int *> a;");
Daniel Jasper4e778092013-02-06 10:05:46 +00002484 verifyIndependentOfContext(
2485 "const char *const p = reinterpret_cast<const char *const>(q);");
Daniel Jasper4bfc65a2013-01-23 12:10:53 +00002486 verifyIndependentOfContext("A<int **, int **> a;");
Daniel Jasper6b5ba8b2013-02-06 10:57:42 +00002487 verifyIndependentOfContext("void f(int *a = d * e, int *b = c * d);");
Daniel Jasperd3cf17b2013-03-14 10:50:25 +00002488 verifyFormat("for (char **a = b; *a; ++a) {\n}");
Daniel Jasper8b39c662012-12-10 18:59:13 +00002489
Daniel Jasper2db356d2013-01-08 20:03:18 +00002490 verifyFormat(
2491 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n"
2492 " aaaaaaaaaaaaaaaaaaaaaaaaaaaa, *aaaaaaaaaaaaaaaaaaaaaaaaaaaaa);");
2493
Manuel Klimek36fab8d2013-01-10 13:24:24 +00002494 verifyGoogleFormat("int main(int argc, char** argv) {}");
Daniel Jasper8b39c662012-12-10 18:59:13 +00002495 verifyGoogleFormat("A<int*> a;");
2496 verifyGoogleFormat("A<int**> a;");
2497 verifyGoogleFormat("A<int*, int*> a;");
2498 verifyGoogleFormat("A<int**, int**> a;");
Daniel Jasper5d334402013-01-02 08:57:10 +00002499 verifyGoogleFormat("f(b ? *c : *d);");
2500 verifyGoogleFormat("int a = b ? *c : *d;");
Daniel Jasper48bd7b72013-01-16 16:04:06 +00002501 verifyGoogleFormat("Type* t = **x;");
2502 verifyGoogleFormat("Type* t = *++*x;");
2503 verifyGoogleFormat("*++*x;");
2504 verifyGoogleFormat("Type* t = const_cast<T*>(&*x);");
2505 verifyGoogleFormat("Type* t = x++ * y;");
Daniel Jasper4e778092013-02-06 10:05:46 +00002506 verifyGoogleFormat(
2507 "const char* const p = reinterpret_cast<const char* const>(q);");
Manuel Klimek1b6f4bd2013-01-14 10:58:01 +00002508
Daniel Jasper4bfc65a2013-01-23 12:10:53 +00002509 verifyIndependentOfContext("a = *(x + y);");
2510 verifyIndependentOfContext("a = &(x + y);");
2511 verifyIndependentOfContext("*(x + y).call();");
2512 verifyIndependentOfContext("&(x + y)->call();");
Daniel Jasper8a5d7cd2013-03-01 17:13:29 +00002513 verifyFormat("void f() { &(*I).first; }");
Daniel Jasperb369c2c2013-01-15 14:27:39 +00002514
Daniel Jasper4bfc65a2013-01-23 12:10:53 +00002515 verifyIndependentOfContext("f(b * /* confusing comment */ ++c);");
Daniel Jasperb369c2c2013-01-15 14:27:39 +00002516 verifyFormat(
2517 "int *MyValues = {\n"
2518 " *A, // Operator detection might be confused by the '{'\n"
2519 " *BB // Operator detection might be confused by previous comment\n"
2520 "};");
Nico Weber5096a442013-01-17 17:17:19 +00002521
Daniel Jasper4bfc65a2013-01-23 12:10:53 +00002522 verifyIndependentOfContext("if (int *a = &b)");
2523 verifyIndependentOfContext("if (int &a = *b)");
2524 verifyIndependentOfContext("if (a & b[i])");
2525 verifyIndependentOfContext("if (a::b::c::d & b[i])");
2526 verifyIndependentOfContext("if (*b[i])");
2527 verifyIndependentOfContext("if (int *a = (&b))");
2528 verifyIndependentOfContext("while (int *a = &b)");
Daniel Jasper20d35832013-01-23 12:58:14 +00002529 verifyFormat("void f() {\n"
2530 " for (const int &v : Values) {\n"
2531 " }\n"
2532 "}");
Daniel Jasperd0f349b2013-02-18 12:44:35 +00002533 verifyFormat("for (int i = a * a; i < 10; ++i) {\n}");
2534 verifyFormat("for (int i = 0; i < a * a; ++i) {\n}");
Daniel Jasperffee1712013-01-22 11:46:26 +00002535
Daniel Jasper6f21a982013-03-13 07:49:51 +00002536 verifyIndependentOfContext("A = new SomeType *[Length];");
Daniel Jasper4bfc65a2013-01-23 12:10:53 +00002537 verifyIndependentOfContext("A = new SomeType *[Length]();");
Daniel Jasperffee1712013-01-22 11:46:26 +00002538 verifyGoogleFormat("A = new SomeType* [Length]();");
Daniel Jasper6f21a982013-03-13 07:49:51 +00002539 verifyGoogleFormat("A = new SomeType* [Length];");
Daniel Jasper8a5d7cd2013-03-01 17:13:29 +00002540}
Daniel Jasper8ff690a2013-02-06 14:22:40 +00002541
Daniel Jasper8a5d7cd2013-03-01 17:13:29 +00002542TEST_F(FormatTest, AdaptivelyFormatsPointersAndReferences) {
Daniel Jasper8ff690a2013-02-06 14:22:40 +00002543 EXPECT_EQ("int *a;\n"
2544 "int *a;\n"
Daniel Jasper66d19bd2013-02-18 11:59:17 +00002545 "int *a;",
2546 format("int *a;\n"
2547 "int* a;\n"
2548 "int *a;",
2549 getGoogleStyle()));
Daniel Jasper8ff690a2013-02-06 14:22:40 +00002550 EXPECT_EQ("int* a;\n"
2551 "int* a;\n"
Daniel Jasper66d19bd2013-02-18 11:59:17 +00002552 "int* a;",
2553 format("int* a;\n"
2554 "int* a;\n"
2555 "int *a;",
2556 getGoogleStyle()));
Daniel Jasper8ff690a2013-02-06 14:22:40 +00002557 EXPECT_EQ("int *a;\n"
2558 "int *a;\n"
Daniel Jasper66d19bd2013-02-18 11:59:17 +00002559 "int *a;",
2560 format("int *a;\n"
2561 "int * a;\n"
2562 "int * a;",
2563 getGoogleStyle()));
Daniel Jasperbac016b2012-12-03 18:12:45 +00002564}
2565
Alexander Kornienko3fd9ccd2013-03-12 16:28:18 +00002566TEST_F(FormatTest, UnderstandsRvalueReferences) {
2567 verifyFormat("int f(int &&a) {}");
2568 verifyFormat("int f(int a, char &&b) {}");
2569 verifyFormat("void f() { int &&a = b; }");
2570 verifyGoogleFormat("int f(int a, char&& b) {}");
2571 verifyGoogleFormat("void f() { int&& a = b; }");
2572
2573 // FIXME: These require somewhat deeper changes in template arguments
2574 // formatting.
2575 // verifyIndependentOfContext("A<int &&> a;");
2576 // verifyIndependentOfContext("A<int &&, int &&> a;");
2577 // verifyGoogleFormat("A<int&&> a;");
2578 // verifyGoogleFormat("A<int&&, int&&> a;");
2579}
2580
Manuel Klimeka32a7fd2013-01-23 14:08:21 +00002581TEST_F(FormatTest, FormatsBinaryOperatorsPrecedingEquals) {
2582 verifyFormat("void f() {\n"
2583 " x[aaaaaaaaa -\n"
Daniel Jasperbf71ba22013-04-08 20:33:42 +00002584 " b] = 23;\n"
Daniel Jasper66d19bd2013-02-18 11:59:17 +00002585 "}",
2586 getLLVMStyleWithColumns(15));
Manuel Klimeka32a7fd2013-01-23 14:08:21 +00002587}
2588
Daniel Jasper4981bd02013-01-13 08:01:36 +00002589TEST_F(FormatTest, FormatsCasts) {
2590 verifyFormat("Type *A = static_cast<Type *>(P);");
2591 verifyFormat("Type *A = (Type *)P;");
2592 verifyFormat("Type *A = (vector<Type *, int *>)P;");
2593 verifyFormat("int a = (int)(2.0f);");
2594
2595 // FIXME: These also need to be identified.
2596 verifyFormat("int a = (int) 2.0f;");
2597 verifyFormat("int a = (int) * b;");
2598
2599 // These are not casts.
2600 verifyFormat("void f(int *) {}");
Nico Weber6fa7e742013-02-13 04:32:57 +00002601 verifyFormat("f(foo)->b;");
2602 verifyFormat("f(foo).b;");
2603 verifyFormat("f(foo)(b);");
2604 verifyFormat("f(foo)[b];");
2605 verifyFormat("[](foo) { return 4; }(bar)];");
2606 verifyFormat("(*funptr)(foo)[4];");
2607 verifyFormat("funptrs[4](foo)[4];");
Daniel Jasper4981bd02013-01-13 08:01:36 +00002608 verifyFormat("void f(int *);");
2609 verifyFormat("void f(int *) = 0;");
2610 verifyFormat("void f(SmallVector<int>) {}");
2611 verifyFormat("void f(SmallVector<int>);");
2612 verifyFormat("void f(SmallVector<int>) = 0;");
Nico Weber77280572013-02-09 18:02:07 +00002613 verifyFormat("void f(int i = (kValue) * kMask) {}");
2614 verifyFormat("void f(int i = (kA * kB) & kMask) {}");
Nico Weber6fa7e742013-02-13 04:32:57 +00002615 verifyFormat("int a = sizeof(int) * b;");
2616 verifyFormat("int a = alignof(int) * b;");
Daniel Jasperfaab0d32013-02-27 09:47:53 +00002617
Daniel Jasper37eff832013-02-23 08:07:18 +00002618 // These are not casts, but at some point were confused with casts.
2619 verifyFormat("virtual void foo(int *) override;");
2620 verifyFormat("virtual void foo(char &) const;");
2621 verifyFormat("virtual void foo(int *a, char *) const;");
Daniel Jasper6a365aa2013-03-13 17:13:53 +00002622 verifyFormat("int a = sizeof(int *) + b;");
2623 verifyFormat("int a = alignof(int *) + b;");
Daniel Jasper4981bd02013-01-13 08:01:36 +00002624}
2625
Daniel Jasper46ef8522013-01-10 13:08:12 +00002626TEST_F(FormatTest, FormatsFunctionTypes) {
Daniel Jasper46ef8522013-01-10 13:08:12 +00002627 verifyFormat("A<bool()> a;");
2628 verifyFormat("A<SomeType()> a;");
2629 verifyFormat("A<void(*)(int, std::string)> a;");
Daniel Jasper9322aae2013-03-20 09:53:18 +00002630 verifyFormat("A<void *(int)>;");
Daniel Jasper81d2d382013-04-01 17:13:26 +00002631 verifyFormat("void *(*a)(int *, SomeType *);");
Daniel Jasper46ef8522013-01-10 13:08:12 +00002632
Daniel Jasper8a5d7cd2013-03-01 17:13:29 +00002633 // FIXME: Inconsistent.
2634 verifyFormat("int (*func)(void *);");
2635 verifyFormat("void f() { int(*func)(void *); }");
Daniel Jasper9322aae2013-03-20 09:53:18 +00002636
Daniel Jasper81d2d382013-04-01 17:13:26 +00002637 verifyGoogleFormat("A<void*(int*, SomeType*)>;");
2638 verifyGoogleFormat("void* (*a)(int);");
Daniel Jasper46ef8522013-01-10 13:08:12 +00002639}
2640
Daniel Jasper3c08a812013-02-24 18:54:32 +00002641TEST_F(FormatTest, BreaksLongDeclarations) {
Daniel Jasper83f25ba2013-01-28 15:16:31 +00002642 verifyFormat("int *someFunction(int LoooooooooooooooooooongParam1,\n"
Daniel Jasperf11a7052013-02-21 21:33:55 +00002643 " int LoooooooooooooooooooongParam2) {}");
Daniel Jasper4dc41de2013-01-02 08:44:14 +00002644 verifyFormat(
Daniel Jasper1407bee2013-04-11 14:29:13 +00002645 "TypeSpecDecl *TypeSpecDecl::Create(ASTContext &C, DeclContext *DC,\n"
2646 " SourceLocation L, IdentifierIn *II,\n"
2647 " Type *T) {}");
Daniel Jasper3c08a812013-02-24 18:54:32 +00002648 verifyFormat("ReallyLongReturnType<TemplateParam1, TemplateParam2>\n"
2649 "ReallyReallyLongFunctionName(\n"
2650 " const std::string &SomeParameter,\n"
2651 " const SomeType<string, SomeOtherTemplateParameter> &\n"
2652 " ReallyReallyLongParameterName,\n"
2653 " const SomeType<string, SomeOtherTemplateParameter> &\n"
2654 " AnotherLongParameterName) {}");
2655 verifyFormat(
2656 "aaaaaaaaaaaaaaaa::aaaaaaaaaaaaaaaa<aaaaaaaaaaaaa, aaaaaaaaaaaa>\n"
2657 "aaaaaaaaaaaaaaaaaaaaaaa;");
2658
Daniel Jasperd75ff642013-01-28 15:40:20 +00002659 verifyGoogleFormat(
Daniel Jasperfaab0d32013-02-27 09:47:53 +00002660 "TypeSpecDecl* TypeSpecDecl::Create(ASTContext& C, DeclContext* DC,\n"
2661 " SourceLocation L) {}");
Daniel Jaspera03ab102013-02-13 20:33:44 +00002662 verifyGoogleFormat(
2663 "some_namespace::LongReturnType\n"
2664 "long_namespace::SomeVeryLongClass::SomeVeryLongFunction(\n"
Daniel Jasperf11a7052013-02-21 21:33:55 +00002665 " int first_long_parameter, int second_parameter) {}");
Daniel Jaspera03ab102013-02-13 20:33:44 +00002666
2667 verifyGoogleFormat("template <typename T>\n"
2668 "aaaaaaaa::aaaaa::aaaaaa<T, aaaaaaaaaaaaaaaaaaaaaaaaa>\n"
Daniel Jasperf11a7052013-02-21 21:33:55 +00002669 "aaaaaaaaaaaaaaaaaaaaaaaa<T>::aaaaaaa() {}");
Daniel Jasperb6f02f32013-02-28 10:06:05 +00002670 verifyGoogleFormat("A<A<A>> aaaaaaaaaa(int aaaaaaaaaaaaaaaaaaaaaaaaaaa,\n"
2671 " int aaaaaaaaaaaaaaaaaaaaaaa);");
Daniel Jasper4dc41de2013-01-02 08:44:14 +00002672}
2673
Daniel Jasper3b5943f2012-12-06 09:56:08 +00002674TEST_F(FormatTest, LineStartsWithSpecialCharacter) {
2675 verifyFormat("(a)->b();");
2676 verifyFormat("--a;");
2677}
2678
Daniel Jasper8822d3a2012-12-04 13:02:32 +00002679TEST_F(FormatTest, HandlesIncludeDirectives) {
Daniel Jasper2b9c10b2013-01-14 15:52:06 +00002680 verifyFormat("#include <string>\n"
2681 "#include <a/b/c.h>\n"
2682 "#include \"a/b/string\"\n"
2683 "#include \"string.h\"\n"
2684 "#include \"string.h\"\n"
Manuel Klimek407a31a2013-01-15 15:50:27 +00002685 "#include <a-a>\n"
Daniel Jasper3a204412013-02-23 07:46:38 +00002686 "#include < path with space >\n"
2687 "#include \"some very long include paaaaaaaaaaaaaaaaaaaaaaath\"",
2688 getLLVMStyleWithColumns(35));
Nico Weberb23ae0c2012-12-21 18:21:56 +00002689
Daniel Jasper8134e1e2013-01-13 08:12:18 +00002690 verifyFormat("#import <string>");
2691 verifyFormat("#import <a/b/c.h>");
2692 verifyFormat("#import \"a/b/string\"");
2693 verifyFormat("#import \"string.h\"");
2694 verifyFormat("#import \"string.h\"");
Daniel Jasper8822d3a2012-12-04 13:02:32 +00002695}
2696
Alexander Kornienko15757312012-12-06 18:03:27 +00002697//===----------------------------------------------------------------------===//
2698// Error recovery tests.
2699//===----------------------------------------------------------------------===//
2700
Daniel Jasperc5cfa492013-02-14 09:19:04 +00002701TEST_F(FormatTest, IncompleteParameterLists) {
Daniel Jasperfaab0d32013-02-27 09:47:53 +00002702 FormatStyle NoBinPacking = getLLVMStyle();
2703 NoBinPacking.BinPackParameters = false;
2704 verifyFormat("void aaaaaaaaaaaaaaaaaa(int level,\n"
2705 " double *min_x,\n"
2706 " double *max_x,\n"
2707 " double *min_y,\n"
2708 " double *max_y,\n"
2709 " double *min_z,\n"
2710 " double *max_z, ) {}",
2711 NoBinPacking);
Daniel Jasperc5cfa492013-02-14 09:19:04 +00002712}
2713
Daniel Jasper700e7102013-01-10 09:26:47 +00002714TEST_F(FormatTest, IncorrectCodeTrailingStuff) {
Alexander Kornienko51c23fa2013-01-16 11:45:16 +00002715 verifyFormat("void f() { return; }\n42");
2716 verifyFormat("void f() {\n"
2717 " if (0)\n"
2718 " return;\n"
2719 "}\n"
2720 "42");
Alexander Kornienkod8818752013-01-16 11:43:46 +00002721 verifyFormat("void f() { return }\n42");
2722 verifyFormat("void f() {\n"
2723 " if (0)\n"
2724 " return\n"
2725 "}\n"
2726 "42");
2727}
2728
2729TEST_F(FormatTest, IncorrectCodeMissingSemicolon) {
2730 EXPECT_EQ("void f() { return }", format("void f ( ) { return }"));
2731 EXPECT_EQ("void f() {\n"
2732 " if (a)\n"
2733 " return\n"
Daniel Jasper66d19bd2013-02-18 11:59:17 +00002734 "}",
2735 format("void f ( ) { if ( a ) return }"));
Alexander Kornienkod8818752013-01-16 11:43:46 +00002736 EXPECT_EQ("namespace N { void f() }", format("namespace N { void f() }"));
2737 EXPECT_EQ("namespace N {\n"
2738 "void f() {}\n"
2739 "void g()\n"
Daniel Jasper66d19bd2013-02-18 11:59:17 +00002740 "}",
2741 format("namespace N { void f( ) { } void g( ) }"));
Daniel Jasper700e7102013-01-10 09:26:47 +00002742}
2743
Daniel Jasperceb99ab2013-01-09 10:16:05 +00002744TEST_F(FormatTest, IndentationWithinColumnLimitNotPossible) {
2745 verifyFormat("int aaaaaaaa =\n"
Alexander Kornienko5262dd92013-03-27 11:52:18 +00002746 " // Overlylongcomment\n"
Daniel Jasper66d19bd2013-02-18 11:59:17 +00002747 " b;",
2748 getLLVMStyleWithColumns(20));
Daniel Jasperceb99ab2013-01-09 10:16:05 +00002749 verifyFormat("function(\n"
2750 " ShortArgument,\n"
Daniel Jasper66d19bd2013-02-18 11:59:17 +00002751 " LoooooooooooongArgument);\n",
2752 getLLVMStyleWithColumns(20));
Daniel Jasperceb99ab2013-01-09 10:16:05 +00002753}
2754
Alexander Kornienko56e49c52012-12-10 16:34:48 +00002755TEST_F(FormatTest, IncorrectAccessSpecifier) {
2756 verifyFormat("public:");
2757 verifyFormat("class A {\n"
2758 "public\n"
Manuel Klimek36fab8d2013-01-10 13:24:24 +00002759 " void f() {}\n"
Alexander Kornienko56e49c52012-12-10 16:34:48 +00002760 "};");
2761 verifyFormat("public\n"
2762 "int qwerty;");
2763 verifyFormat("public\n"
Manuel Klimek36fab8d2013-01-10 13:24:24 +00002764 "B {}");
Alexander Kornienko56e49c52012-12-10 16:34:48 +00002765 verifyFormat("public\n"
Manuel Klimek36fab8d2013-01-10 13:24:24 +00002766 "{}");
Alexander Kornienko56e49c52012-12-10 16:34:48 +00002767 verifyFormat("public\n"
Manuel Klimek517e8942013-01-11 17:54:10 +00002768 "B { int x; }");
Alexander Kornienko56e49c52012-12-10 16:34:48 +00002769}
Daniel Jasperbac016b2012-12-03 18:12:45 +00002770
Daniel Jasper92f9faf2013-03-20 15:58:10 +00002771TEST_F(FormatTest, IncorrectCodeUnbalancedBraces) {
2772 verifyFormat("{");
2773 verifyFormat("#})");
2774}
Alexander Kornienko393b0082012-12-04 15:40:36 +00002775
2776TEST_F(FormatTest, IncorrectCodeDoNoWhile) {
Manuel Klimek2f1ac412013-01-21 16:42:44 +00002777 verifyFormat("do {\n}");
2778 verifyFormat("do {\n}\n"
Alexander Kornienko393b0082012-12-04 15:40:36 +00002779 "f();");
Manuel Klimek2f1ac412013-01-21 16:42:44 +00002780 verifyFormat("do {\n}\n"
Alexander Kornienko393b0082012-12-04 15:40:36 +00002781 "wheeee(fun);");
2782 verifyFormat("do {\n"
2783 " f();\n"
Manuel Klimekde768542013-01-07 18:10:23 +00002784 "}");
Alexander Kornienko393b0082012-12-04 15:40:36 +00002785}
2786
Manuel Klimek6eca03f2013-01-11 19:23:05 +00002787TEST_F(FormatTest, IncorrectCodeMissingParens) {
Manuel Klimekd4658432013-01-11 18:28:36 +00002788 verifyFormat("if {\n foo;\n foo();\n}");
Manuel Klimek6eca03f2013-01-11 19:23:05 +00002789 verifyFormat("switch {\n foo;\n foo();\n}");
2790 verifyFormat("for {\n foo;\n foo();\n}");
2791 verifyFormat("while {\n foo;\n foo();\n}");
2792 verifyFormat("do {\n foo;\n foo();\n} while;");
Manuel Klimekd4658432013-01-11 18:28:36 +00002793}
2794
Daniel Jasper1f42f112013-01-04 18:52:56 +00002795TEST_F(FormatTest, DoesNotTouchUnwrappedLinesWithErrors) {
2796 verifyFormat("namespace {\n"
Manuel Klimekd4397b92013-01-04 23:34:14 +00002797 "class Foo { Foo ( }; } // comment");
Daniel Jasper1f42f112013-01-04 18:52:56 +00002798}
2799
Alexander Kornienkocff563c2012-12-04 17:27:50 +00002800TEST_F(FormatTest, IncorrectCodeErrorDetection) {
Manuel Klimek36fab8d2013-01-10 13:24:24 +00002801 EXPECT_EQ("{\n{}\n", format("{\n{\n}\n"));
2802 EXPECT_EQ("{\n {}\n", format("{\n {\n}\n"));
2803 EXPECT_EQ("{\n {}\n", format("{\n {\n }\n"));
2804 EXPECT_EQ("{\n {}\n }\n}\n", format("{\n {\n }\n }\n}\n"));
Alexander Kornienkocff563c2012-12-04 17:27:50 +00002805
Alexander Kornienkocff563c2012-12-04 17:27:50 +00002806 EXPECT_EQ("{\n"
2807 " {\n"
2808 " breakme(\n"
2809 " qwe);\n"
Daniel Jasper66d19bd2013-02-18 11:59:17 +00002810 "}\n",
2811 format("{\n"
2812 " {\n"
2813 " breakme(qwe);\n"
2814 "}\n",
2815 getLLVMStyleWithColumns(10)));
Alexander Kornienkocff563c2012-12-04 17:27:50 +00002816}
2817
Manuel Klimek2851c162013-01-10 14:36:46 +00002818TEST_F(FormatTest, LayoutCallsInsideBraceInitializers) {
Daniel Jasper66d19bd2013-02-18 11:59:17 +00002819 verifyFormat("int x = {\n"
2820 " avariable,\n"
2821 " b(alongervariable)\n"
2822 "};",
2823 getLLVMStyleWithColumns(25));
Manuel Klimek2851c162013-01-10 14:36:46 +00002824}
2825
Manuel Klimekc44ee892013-01-21 10:07:49 +00002826TEST_F(FormatTest, LayoutBraceInitializersInReturnStatement) {
2827 verifyFormat("return (a)(b) { 1, 2, 3 };");
2828}
2829
Manuel Klimek2851c162013-01-10 14:36:46 +00002830TEST_F(FormatTest, LayoutTokensFollowingBlockInParentheses) {
Daniel Jasper7d812812013-02-21 15:00:29 +00002831 // FIXME: This is bad, find a better and more generic solution.
Manuel Klimek2851c162013-01-10 14:36:46 +00002832 verifyFormat(
2833 "Aaa({\n"
2834 " int i;\n"
Daniel Jasper7d812812013-02-21 15:00:29 +00002835 "},\n"
2836 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb,\n"
2837 " ccccccccccccccccc));");
Manuel Klimek2851c162013-01-10 14:36:46 +00002838}
2839
Manuel Klimek517e8942013-01-11 17:54:10 +00002840TEST_F(FormatTest, PullTrivialFunctionDefinitionsIntoSingleLine) {
2841 verifyFormat("void f() { return 42; }");
2842 verifyFormat("void f() {\n"
2843 " // Comment\n"
2844 "}");
2845 verifyFormat("{\n"
2846 "#error {\n"
2847 " int a;\n"
2848 "}");
2849 verifyFormat("{\n"
2850 " int a;\n"
2851 "#error {\n"
2852 "}");
Manuel Klimek2f1ac412013-01-21 16:42:44 +00002853
2854 verifyFormat("void f() { return 42; }", getLLVMStyleWithColumns(23));
2855 verifyFormat("void f() {\n return 42;\n}", getLLVMStyleWithColumns(22));
2856
2857 verifyFormat("void f() {}", getLLVMStyleWithColumns(11));
2858 verifyFormat("void f() {\n}", getLLVMStyleWithColumns(10));
Manuel Klimek517e8942013-01-11 17:54:10 +00002859}
2860
Manuel Klimek47ea7f62013-01-15 13:38:33 +00002861TEST_F(FormatTest, UnderstandContextOfRecordTypeKeywords) {
2862 // Elaborate type variable declarations.
Manuel Klimek606e07e2013-01-11 18:13:04 +00002863 verifyFormat("struct foo a = { bar };\nint n;");
Manuel Klimek47ea7f62013-01-15 13:38:33 +00002864 verifyFormat("class foo a = { bar };\nint n;");
2865 verifyFormat("union foo a = { bar };\nint n;");
2866
2867 // Elaborate types inside function definitions.
2868 verifyFormat("struct foo f() {}\nint n;");
2869 verifyFormat("class foo f() {}\nint n;");
2870 verifyFormat("union foo f() {}\nint n;");
2871
2872 // Templates.
2873 verifyFormat("template <class X> void f() {}\nint n;");
2874 verifyFormat("template <struct X> void f() {}\nint n;");
2875 verifyFormat("template <union X> void f() {}\nint n;");
2876
2877 // Actual definitions...
Manuel Klimek2f1ac412013-01-21 16:42:44 +00002878 verifyFormat("struct {\n} n;");
2879 verifyFormat(
2880 "template <template <class T, class Y>, class Z> class X {\n} n;");
Manuel Klimek47ea7f62013-01-15 13:38:33 +00002881 verifyFormat("union Z {\n int n;\n} x;");
Manuel Klimek2f1ac412013-01-21 16:42:44 +00002882 verifyFormat("class MACRO Z {\n} n;");
2883 verifyFormat("class MACRO(X) Z {\n} n;");
2884 verifyFormat("class __attribute__(X) Z {\n} n;");
2885 verifyFormat("class __declspec(X) Z {\n} n;");
Manuel Klimekb8b1ce12013-02-06 15:57:54 +00002886 verifyFormat("class A##B##C {\n} n;");
Manuel Klimek47ea7f62013-01-15 13:38:33 +00002887
Manuel Klimek7f5b0252013-01-21 10:17:14 +00002888 // Redefinition from nested context:
Manuel Klimek2f1ac412013-01-21 16:42:44 +00002889 verifyFormat("class A::B::C {\n} n;");
Manuel Klimek7f5b0252013-01-21 10:17:14 +00002890
Manuel Klimek3a3408c2013-01-21 13:58:54 +00002891 // Template definitions.
2892 // FIXME: This is still incorrectly handled at the formatter side.
Manuel Klimek2f1ac412013-01-21 16:42:44 +00002893 verifyFormat("template <> struct X < 15, i < 3 && 42 < 50 && 33<28> {\n};");
Manuel Klimek3a3408c2013-01-21 13:58:54 +00002894
2895 // FIXME:
2896 // This now gets parsed incorrectly as class definition.
Manuel Klimek2f1ac412013-01-21 16:42:44 +00002897 // verifyFormat("class A<int> f() {\n}\nint n;");
Manuel Klimek3a3408c2013-01-21 13:58:54 +00002898
Manuel Klimek47ea7f62013-01-15 13:38:33 +00002899 // Elaborate types where incorrectly parsing the structural element would
2900 // break the indent.
2901 verifyFormat("if (true)\n"
2902 " class X x;\n"
2903 "else\n"
2904 " f();\n");
Daniel Jasper6fe554e2013-03-20 15:12:38 +00002905
2906 // This is simply incomplete. Formatting is not important, but must not crash.
2907 verifyFormat("class A:");
Manuel Klimek606e07e2013-01-11 18:13:04 +00002908}
2909
Manuel Klimek407a31a2013-01-15 15:50:27 +00002910TEST_F(FormatTest, DoNotInterfereWithErrorAndWarning) {
2911 verifyFormat("#error Leave all white!!!!! space* alone!\n");
2912 verifyFormat("#warning Leave all white!!!!! space* alone!\n");
2913 EXPECT_EQ("#error 1", format(" # error 1"));
2914 EXPECT_EQ("#warning 1", format(" # warning 1"));
2915}
2916
Manuel Klimek525fe162013-01-18 14:04:34 +00002917TEST_F(FormatTest, MergeHandlingInTheFaceOfPreprocessorDirectives) {
2918 FormatStyle AllowsMergedIf = getGoogleStyle();
2919 AllowsMergedIf.AllowShortIfStatementsOnASingleLine = true;
2920 verifyFormat("void f() { f(); }\n#error E", AllowsMergedIf);
2921 verifyFormat("if (true) return 42;\n#error E", AllowsMergedIf);
Manuel Klimek4c128122013-01-18 14:46:43 +00002922 verifyFormat("if (true)\n#error E\n return 42;", AllowsMergedIf);
2923 EXPECT_EQ("if (true) return 42;",
2924 format("if (true)\nreturn 42;", AllowsMergedIf));
2925 FormatStyle ShortMergedIf = AllowsMergedIf;
2926 ShortMergedIf.ColumnLimit = 25;
2927 verifyFormat("#define A \\\n"
Daniel Jasper66d19bd2013-02-18 11:59:17 +00002928 " if (true) return 42;",
2929 ShortMergedIf);
Manuel Klimek4c128122013-01-18 14:46:43 +00002930 verifyFormat("#define A \\\n"
2931 " f(); \\\n"
2932 " if (true)\n"
Daniel Jasper66d19bd2013-02-18 11:59:17 +00002933 "#define B",
2934 ShortMergedIf);
Manuel Klimek4c128122013-01-18 14:46:43 +00002935 verifyFormat("#define A \\\n"
2936 " f(); \\\n"
2937 " if (true)\n"
Daniel Jasper66d19bd2013-02-18 11:59:17 +00002938 "g();",
2939 ShortMergedIf);
Manuel Klimek0fbe0082013-01-21 14:16:56 +00002940 verifyFormat("{\n"
2941 "#ifdef A\n"
2942 " // Comment\n"
2943 " if (true) continue;\n"
2944 "#endif\n"
2945 " // Comment\n"
Daniel Jasper66d19bd2013-02-18 11:59:17 +00002946 " if (true) continue;",
2947 ShortMergedIf);
Manuel Klimek525fe162013-01-18 14:04:34 +00002948}
2949
Manuel Klimek86721d22013-01-22 16:31:55 +00002950TEST_F(FormatTest, BlockCommentsInControlLoops) {
2951 verifyFormat("if (0) /* a comment in a strange place */ {\n"
2952 " f();\n"
2953 "}");
2954 verifyFormat("if (0) /* a comment in a strange place */ {\n"
2955 " f();\n"
2956 "} /* another comment */ else /* comment #3 */ {\n"
2957 " g();\n"
2958 "}");
2959 verifyFormat("while (0) /* a comment in a strange place */ {\n"
2960 " f();\n"
2961 "}");
2962 verifyFormat("for (;;) /* a comment in a strange place */ {\n"
2963 " f();\n"
2964 "}");
2965 verifyFormat("do /* a comment in a strange place */ {\n"
2966 " f();\n"
2967 "} /* another comment */ while (0);");
2968}
2969
2970TEST_F(FormatTest, BlockComments) {
2971 EXPECT_EQ("/* */ /* */ /* */\n/* */ /* */ /* */",
2972 format("/* *//* */ /* */\n/* *//* */ /* */"));
Daniel Jasper66d19bd2013-02-18 11:59:17 +00002973 EXPECT_EQ("/* */ a /* */ b;", format(" /* */ a/* */ b;"));
Alexander Kornienko7c22cf32013-03-21 12:28:10 +00002974 EXPECT_EQ("#define A /*123*/\\\n"
Manuel Klimek86721d22013-01-22 16:31:55 +00002975 " b\n"
2976 "/* */\n"
2977 "someCall(\n"
2978 " parameter);",
Alexander Kornienko7c22cf32013-03-21 12:28:10 +00002979 format("#define A /*123*/ b\n"
Manuel Klimek86721d22013-01-22 16:31:55 +00002980 "/* */\n"
Daniel Jasper66d19bd2013-02-18 11:59:17 +00002981 "someCall(parameter);",
2982 getLLVMStyleWithColumns(15)));
Manuel Klimek86721d22013-01-22 16:31:55 +00002983
2984 EXPECT_EQ("#define A\n"
2985 "/* */ someCall(\n"
2986 " parameter);",
2987 format("#define A\n"
Daniel Jasper66d19bd2013-02-18 11:59:17 +00002988 "/* */someCall(parameter);",
2989 getLLVMStyleWithColumns(15)));
Daniel Jasper2752ff32013-02-04 07:32:14 +00002990
Daniel Jasperfaab0d32013-02-27 09:47:53 +00002991 FormatStyle NoBinPacking = getLLVMStyle();
2992 NoBinPacking.BinPackParameters = false;
Daniel Jasper2752ff32013-02-04 07:32:14 +00002993 EXPECT_EQ("someFunction(1, /* comment 1 */\n"
2994 " 2, /* comment 2 */\n"
2995 " 3, /* comment 3 */\n"
Daniel Jaspercda16502013-02-04 08:34:57 +00002996 " aaaa,\n"
2997 " bbbb);",
Daniel Jasper2752ff32013-02-04 07:32:14 +00002998 format("someFunction (1, /* comment 1 */\n"
2999 " 2, /* comment 2 */ \n"
3000 " 3, /* comment 3 */\n"
Daniel Jasper66d19bd2013-02-18 11:59:17 +00003001 "aaaa, bbbb );",
Daniel Jasperfaab0d32013-02-27 09:47:53 +00003002 NoBinPacking));
Daniel Jasper36ba0ff2013-02-06 15:23:09 +00003003 verifyFormat(
3004 "bool aaaaaaaaaaaaa = /* comment: */ aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ||\n"
3005 " aaaaaaaaaaaaaaaaaaaaaaaaaaaa;");
3006 EXPECT_EQ(
3007 "bool aaaaaaaaaaaaa = /* trailing comment */\n"
3008 " aaaaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaaaa ||\n"
3009 " aaaaaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaaaaa;",
3010 format(
3011 "bool aaaaaaaaaaaaa = /* trailing comment */\n"
3012 " aaaaaaaaaaaaaaaaaaaaaaaaaaa||aaaaaaaaaaaaaaaaaaaaaaaaa ||\n"
3013 " aaaaaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaaaaa;"));
Daniel Jasper15417ef2013-02-06 20:07:35 +00003014 EXPECT_EQ(
3015 "int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa; /* comment */\n"
3016 "int bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb; /* comment */\n"
3017 "int cccccccccccccccccccccccccccccc; /* comment */\n",
3018 format("int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa; /* comment */\n"
3019 "int bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb; /* comment */\n"
3020 "int cccccccccccccccccccccccccccccc; /* comment */\n"));
Manuel Klimek86721d22013-01-22 16:31:55 +00003021}
3022
Manuel Klimekb3507cd2013-02-06 16:40:56 +00003023TEST_F(FormatTest, BlockCommentsInMacros) {
3024 EXPECT_EQ("#define A \\\n"
3025 " { \\\n"
3026 " /* one line */ \\\n"
3027 " someCall();",
3028 format("#define A { \\\n"
3029 " /* one line */ \\\n"
Daniel Jasper66d19bd2013-02-18 11:59:17 +00003030 " someCall();",
3031 getLLVMStyleWithColumns(20)));
Manuel Klimekb3507cd2013-02-06 16:40:56 +00003032 EXPECT_EQ("#define A \\\n"
3033 " { \\\n"
3034 " /* previous */ \\\n"
3035 " /* one line */ \\\n"
3036 " someCall();",
3037 format("#define A { \\\n"
3038 " /* previous */ \\\n"
3039 " /* one line */ \\\n"
Daniel Jasper66d19bd2013-02-18 11:59:17 +00003040 " someCall();",
3041 getLLVMStyleWithColumns(20)));
Manuel Klimekb3507cd2013-02-06 16:40:56 +00003042}
3043
3044TEST_F(FormatTest, IndentLineCommentsInStartOfBlockAtEndOfFile) {
3045 // FIXME: This is not what we want...
3046 verifyFormat("{\n"
3047 "// a"
3048 "// b");
3049}
3050
Manuel Klimek092a2c72013-01-23 10:09:28 +00003051TEST_F(FormatTest, FormatStarDependingOnContext) {
Manuel Klimek70b03f42013-01-23 09:32:48 +00003052 verifyFormat("void f(int *a);");
3053 verifyFormat("void f() { f(fint * b); }");
Manuel Klimek836b58f2013-01-23 11:03:04 +00003054 verifyFormat("class A {\n void f(int *a);\n};");
3055 verifyFormat("class A {\n int *a;\n};");
3056 verifyFormat("namespace a {\n"
3057 "namespace b {\n"
3058 "class A {\n"
3059 " void f() {}\n"
3060 " int *a;\n"
3061 "};\n"
3062 "}\n"
3063 "}");
Manuel Klimek70b03f42013-01-23 09:32:48 +00003064}
3065
Manuel Klimek092a2c72013-01-23 10:09:28 +00003066TEST_F(FormatTest, SpecialTokensAtEndOfLine) {
3067 verifyFormat("while");
3068 verifyFormat("operator");
3069}
3070
Nico Webercf4a79c2013-01-08 17:56:31 +00003071//===----------------------------------------------------------------------===//
3072// Objective-C tests.
3073//===----------------------------------------------------------------------===//
3074
Fariborz Jahanian154120c2012-12-20 19:54:13 +00003075TEST_F(FormatTest, FormatForObjectiveCMethodDecls) {
3076 verifyFormat("- (void)sendAction:(SEL)aSelector to:(BOOL)anObject;");
3077 EXPECT_EQ("- (NSUInteger)indexOfObject:(id)anObject;",
3078 format("-(NSUInteger)indexOfObject:(id)anObject;"));
Daniel Jaspercd162382013-01-07 13:26:07 +00003079 EXPECT_EQ("- (NSInteger)Mthod1;", format("-(NSInteger)Mthod1;"));
Fariborz Jahanian154120c2012-12-20 19:54:13 +00003080 EXPECT_EQ("+ (id)Mthod2;", format("+(id)Mthod2;"));
3081 EXPECT_EQ("- (NSInteger)Method3:(id)anObject;",
3082 format("-(NSInteger)Method3:(id)anObject;"));
3083 EXPECT_EQ("- (NSInteger)Method4:(id)anObject;",
3084 format("-(NSInteger)Method4:(id)anObject;"));
3085 EXPECT_EQ("- (NSInteger)Method5:(id)anObject:(id)AnotherObject;",
3086 format("-(NSInteger)Method5:(id)anObject:(id)AnotherObject;"));
3087 EXPECT_EQ("- (id)Method6:(id)A:(id)B:(id)C:(id)D;",
3088 format("- (id)Method6:(id)A:(id)B:(id)C:(id)D;"));
Daniel Jaspercd162382013-01-07 13:26:07 +00003089 EXPECT_EQ(
3090 "- (void)sendAction:(SEL)aSelector to:(id)anObject forAllCells:(BOOL)flag;",
Daniel Jasper66d19bd2013-02-18 11:59:17 +00003091 format(
3092 "- (void)sendAction:(SEL)aSelector to:(id)anObject forAllCells:(BOOL)flag;"));
Fariborz Jahanian9b3f02c2012-12-21 22:51:18 +00003093
3094 // Very long objectiveC method declaration.
Daniel Jasper63d7ced2013-02-05 10:07:47 +00003095 verifyFormat("- (NSUInteger)indexOfObject:(id)anObject\n"
3096 " inRange:(NSRange)range\n"
3097 " outRange:(NSRange)out_range\n"
3098 " outRange1:(NSRange)out_range1\n"
3099 " outRange2:(NSRange)out_range2\n"
3100 " outRange3:(NSRange)out_range3\n"
3101 " outRange4:(NSRange)out_range4\n"
3102 " outRange5:(NSRange)out_range5\n"
3103 " outRange6:(NSRange)out_range6\n"
3104 " outRange7:(NSRange)out_range7\n"
3105 " outRange8:(NSRange)out_range8\n"
3106 " outRange9:(NSRange)out_range9;");
Nico Webere0fd4292013-01-10 20:18:33 +00003107
3108 verifyFormat("- (int)sum:(vector<int>)numbers;");
Nico Weberaab60052013-01-17 06:14:50 +00003109 verifyGoogleFormat("- (void)setDelegate:(id<Protocol>)delegate;");
Nico Webere0fd4292013-01-10 20:18:33 +00003110 // FIXME: In LLVM style, there should be a space in front of a '<' for ObjC
3111 // protocol lists (but not for template classes):
3112 //verifyFormat("- (void)setDelegate:(id <Protocol>)delegate;");
Nico Webercd52bda2013-01-10 23:11:41 +00003113
3114 verifyFormat("- (int(*)())foo:(int(*)())f;");
Nico Weberaab60052013-01-17 06:14:50 +00003115 verifyGoogleFormat("- (int(*)())foo:(int(*)())foo;");
Nico Webercd52bda2013-01-10 23:11:41 +00003116
3117 // If there's no return type (very rare in practice!), LLVM and Google style
3118 // agree.
Daniel Jasper627707b2013-03-22 16:55:40 +00003119 verifyFormat("- foo;");
Nico Webercd52bda2013-01-10 23:11:41 +00003120 verifyFormat("- foo:(int)f;");
3121 verifyGoogleFormat("- foo:(int)foo;");
Fariborz Jahanian154120c2012-12-20 19:54:13 +00003122}
3123
Daniel Jasper886568d2013-01-09 08:36:49 +00003124TEST_F(FormatTest, FormatObjCBlocks) {
Daniel Jasper46ef8522013-01-10 13:08:12 +00003125 verifyFormat("int (^Block)(int, int);");
3126 verifyFormat("int (^Block1)(int, int) = ^(int i, int j)");
Daniel Jasper886568d2013-01-09 08:36:49 +00003127}
3128
Nico Weber27d13672013-01-09 20:25:35 +00003129TEST_F(FormatTest, FormatObjCInterface) {
Nico Weber5f500df2013-01-10 20:12:55 +00003130 verifyFormat("@interface Foo : NSObject <NSSomeDelegate> {\n"
Nico Weber27d13672013-01-09 20:25:35 +00003131 "@public\n"
3132 " int field1;\n"
3133 "@protected\n"
3134 " int field2;\n"
3135 "@private\n"
3136 " int field3;\n"
3137 "@package\n"
3138 " int field4;\n"
3139 "}\n"
3140 "+ (id)init;\n"
3141 "@end");
3142
Nico Weber27d13672013-01-09 20:25:35 +00003143 verifyGoogleFormat("@interface Foo : NSObject<NSSomeDelegate> {\n"
3144 " @public\n"
3145 " int field1;\n"
3146 " @protected\n"
3147 " int field2;\n"
3148 " @private\n"
3149 " int field3;\n"
3150 " @package\n"
3151 " int field4;\n"
3152 "}\n"
Nico Weberaab60052013-01-17 06:14:50 +00003153 "+ (id)init;\n"
Nico Weber27d13672013-01-09 20:25:35 +00003154 "@end");
3155
Nico Weberf5ecfa52013-01-22 16:53:59 +00003156 verifyFormat("@interface /* wait for it */ Foo\n"
Nico Weber27d13672013-01-09 20:25:35 +00003157 "+ (id)init;\n"
3158 "// Look, a comment!\n"
3159 "- (int)answerWith:(int)i;\n"
3160 "@end");
3161
3162 verifyFormat("@interface Foo\n"
Nico Weber049c4472013-01-09 21:42:32 +00003163 "@end\n"
3164 "@interface Bar\n"
Nico Weber27d13672013-01-09 20:25:35 +00003165 "@end");
3166
3167 verifyFormat("@interface Foo : Bar\n"
3168 "+ (id)init;\n"
3169 "@end");
3170
Nico Weberf5ecfa52013-01-22 16:53:59 +00003171 verifyFormat("@interface Foo : /**/ Bar /**/ <Baz, /**/ Quux>\n"
Nico Weber27d13672013-01-09 20:25:35 +00003172 "+ (id)init;\n"
3173 "@end");
3174
Nico Weber5f500df2013-01-10 20:12:55 +00003175 verifyGoogleFormat("@interface Foo : Bar<Baz, Quux>\n"
Nico Weberaab60052013-01-17 06:14:50 +00003176 "+ (id)init;\n"
Nico Weber5f500df2013-01-10 20:12:55 +00003177 "@end");
3178
Nico Webered91bba2013-01-10 19:19:14 +00003179 verifyFormat("@interface Foo (HackStuff)\n"
Nico Weber27d13672013-01-09 20:25:35 +00003180 "+ (id)init;\n"
3181 "@end");
3182
Nico Webered91bba2013-01-10 19:19:14 +00003183 verifyFormat("@interface Foo ()\n"
Nico Weber27d13672013-01-09 20:25:35 +00003184 "+ (id)init;\n"
3185 "@end");
3186
Nico Weber5f500df2013-01-10 20:12:55 +00003187 verifyFormat("@interface Foo (HackStuff) <MyProtocol>\n"
Nico Weber27d13672013-01-09 20:25:35 +00003188 "+ (id)init;\n"
3189 "@end");
3190
Nico Weber5f500df2013-01-10 20:12:55 +00003191 verifyGoogleFormat("@interface Foo (HackStuff)<MyProtocol>\n"
Nico Weberaab60052013-01-17 06:14:50 +00003192 "+ (id)init;\n"
Nico Weber5f500df2013-01-10 20:12:55 +00003193 "@end");
3194
Manuel Klimekd5688cf2013-01-11 19:17:44 +00003195 verifyFormat("@interface Foo {\n"
3196 " int _i;\n"
3197 "}\n"
Nico Weber27d13672013-01-09 20:25:35 +00003198 "+ (id)init;\n"
3199 "@end");
3200
Manuel Klimekd5688cf2013-01-11 19:17:44 +00003201 verifyFormat("@interface Foo : Bar {\n"
3202 " int _i;\n"
3203 "}\n"
Nico Weber27d13672013-01-09 20:25:35 +00003204 "+ (id)init;\n"
3205 "@end");
3206
Manuel Klimekd5688cf2013-01-11 19:17:44 +00003207 verifyFormat("@interface Foo : Bar <Baz, Quux> {\n"
3208 " int _i;\n"
3209 "}\n"
Nico Weber27d13672013-01-09 20:25:35 +00003210 "+ (id)init;\n"
3211 "@end");
3212
Manuel Klimekd5688cf2013-01-11 19:17:44 +00003213 verifyFormat("@interface Foo (HackStuff) {\n"
3214 " int _i;\n"
3215 "}\n"
Nico Weber27d13672013-01-09 20:25:35 +00003216 "+ (id)init;\n"
3217 "@end");
3218
Manuel Klimekd5688cf2013-01-11 19:17:44 +00003219 verifyFormat("@interface Foo () {\n"
3220 " int _i;\n"
3221 "}\n"
Nico Weber27d13672013-01-09 20:25:35 +00003222 "+ (id)init;\n"
3223 "@end");
3224
Manuel Klimekd5688cf2013-01-11 19:17:44 +00003225 verifyFormat("@interface Foo (HackStuff) <MyProtocol> {\n"
3226 " int _i;\n"
3227 "}\n"
Nico Weber27d13672013-01-09 20:25:35 +00003228 "+ (id)init;\n"
3229 "@end");
3230}
3231
Nico Weber50767d82013-01-09 23:25:37 +00003232TEST_F(FormatTest, FormatObjCImplementation) {
3233 verifyFormat("@implementation Foo : NSObject {\n"
3234 "@public\n"
3235 " int field1;\n"
3236 "@protected\n"
3237 " int field2;\n"
3238 "@private\n"
3239 " int field3;\n"
3240 "@package\n"
3241 " int field4;\n"
3242 "}\n"
Manuel Klimek2f1ac412013-01-21 16:42:44 +00003243 "+ (id)init {\n}\n"
Nico Weber50767d82013-01-09 23:25:37 +00003244 "@end");
3245
3246 verifyGoogleFormat("@implementation Foo : NSObject {\n"
3247 " @public\n"
3248 " int field1;\n"
3249 " @protected\n"
3250 " int field2;\n"
3251 " @private\n"
3252 " int field3;\n"
3253 " @package\n"
3254 " int field4;\n"
3255 "}\n"
Manuel Klimek2f1ac412013-01-21 16:42:44 +00003256 "+ (id)init {\n}\n"
Nico Weber50767d82013-01-09 23:25:37 +00003257 "@end");
3258
3259 verifyFormat("@implementation Foo\n"
3260 "+ (id)init {\n"
Daniel Jasper6f5bb2c2013-01-14 16:24:39 +00003261 " if (true)\n"
3262 " return nil;\n"
Nico Weber50767d82013-01-09 23:25:37 +00003263 "}\n"
3264 "// Look, a comment!\n"
Manuel Klimekd5688cf2013-01-11 19:17:44 +00003265 "- (int)answerWith:(int)i {\n"
3266 " return i;\n"
3267 "}\n"
Nico Weber67015ed2013-01-11 21:14:08 +00003268 "+ (int)answerWith:(int)i {\n"
3269 " return i;\n"
3270 "}\n"
Nico Weber50767d82013-01-09 23:25:37 +00003271 "@end");
3272
3273 verifyFormat("@implementation Foo\n"
3274 "@end\n"
3275 "@implementation Bar\n"
3276 "@end");
3277
3278 verifyFormat("@implementation Foo : Bar\n"
Manuel Klimek2f1ac412013-01-21 16:42:44 +00003279 "+ (id)init {\n}\n"
3280 "- (void)foo {\n}\n"
Nico Weber50767d82013-01-09 23:25:37 +00003281 "@end");
3282
Manuel Klimekd5688cf2013-01-11 19:17:44 +00003283 verifyFormat("@implementation Foo {\n"
3284 " int _i;\n"
3285 "}\n"
Manuel Klimek2f1ac412013-01-21 16:42:44 +00003286 "+ (id)init {\n}\n"
Nico Weber50767d82013-01-09 23:25:37 +00003287 "@end");
3288
Manuel Klimekd5688cf2013-01-11 19:17:44 +00003289 verifyFormat("@implementation Foo : Bar {\n"
3290 " int _i;\n"
3291 "}\n"
Manuel Klimek2f1ac412013-01-21 16:42:44 +00003292 "+ (id)init {\n}\n"
Nico Weber50767d82013-01-09 23:25:37 +00003293 "@end");
3294
Nico Webered91bba2013-01-10 19:19:14 +00003295 verifyFormat("@implementation Foo (HackStuff)\n"
Manuel Klimek2f1ac412013-01-21 16:42:44 +00003296 "+ (id)init {\n}\n"
Nico Weber50767d82013-01-09 23:25:37 +00003297 "@end");
3298}
3299
Nico Weber1abe6ea2013-01-09 21:15:03 +00003300TEST_F(FormatTest, FormatObjCProtocol) {
3301 verifyFormat("@protocol Foo\n"
3302 "@property(weak) id delegate;\n"
3303 "- (NSUInteger)numberOfThings;\n"
3304 "@end");
3305
Nico Weber5f500df2013-01-10 20:12:55 +00003306 verifyFormat("@protocol MyProtocol <NSObject>\n"
Nico Weber1abe6ea2013-01-09 21:15:03 +00003307 "- (NSUInteger)numberOfThings;\n"
3308 "@end");
3309
Nico Weber5f500df2013-01-10 20:12:55 +00003310 verifyGoogleFormat("@protocol MyProtocol<NSObject>\n"
Nico Weberaab60052013-01-17 06:14:50 +00003311 "- (NSUInteger)numberOfThings;\n"
Nico Weber5f500df2013-01-10 20:12:55 +00003312 "@end");
3313
Nico Weber1abe6ea2013-01-09 21:15:03 +00003314 verifyFormat("@protocol Foo;\n"
3315 "@protocol Bar;\n");
Nico Weber049c4472013-01-09 21:42:32 +00003316
3317 verifyFormat("@protocol Foo\n"
3318 "@end\n"
3319 "@protocol Bar\n"
3320 "@end");
Nico Weberb530fa32013-01-10 00:25:19 +00003321
3322 verifyFormat("@protocol myProtocol\n"
3323 "- (void)mandatoryWithInt:(int)i;\n"
3324 "@optional\n"
3325 "- (void)optional;\n"
3326 "@required\n"
3327 "- (void)required;\n"
Nico Weber880e5382013-01-10 00:42:07 +00003328 "@optional\n"
3329 "@property(assign) int madProp;\n"
Nico Weberb530fa32013-01-10 00:25:19 +00003330 "@end\n");
Nico Weber1abe6ea2013-01-09 21:15:03 +00003331}
3332
Daniel Jasper63d7ced2013-02-05 10:07:47 +00003333TEST_F(FormatTest, FormatObjCMethodDeclarations) {
3334 verifyFormat("- (void)doSomethingWith:(GTMFoo *)theFoo\n"
3335 " rect:(NSRect)theRect\n"
3336 " interval:(float)theInterval {\n"
3337 "}");
3338 verifyFormat("- (void)shortf:(GTMFoo *)theFoo\n"
3339 " longKeyword:(NSRect)theRect\n"
3340 " evenLongerKeyword:(float)theInterval\n"
3341 " error:(NSError **)theError {\n"
3342 "}");
3343}
3344
Nico Weberbcfdd262013-01-12 06:18:40 +00003345TEST_F(FormatTest, FormatObjCMethodExpr) {
3346 verifyFormat("[foo bar:baz];");
3347 verifyFormat("return [foo bar:baz];");
3348 verifyFormat("f([foo bar:baz]);");
3349 verifyFormat("f(2, [foo bar:baz]);");
3350 verifyFormat("f(2, a ? b : c);");
3351 verifyFormat("[[self initWithInt:4] bar:[baz quux:arrrr]];");
3352
Nico Weberee0feec2013-02-05 16:21:00 +00003353 // Unary operators.
3354 verifyFormat("int a = +[foo bar:baz];");
3355 verifyFormat("int a = -[foo bar:baz];");
3356 verifyFormat("int a = ![foo bar:baz];");
3357 verifyFormat("int a = ~[foo bar:baz];");
3358 verifyFormat("int a = ++[foo bar:baz];");
3359 verifyFormat("int a = --[foo bar:baz];");
3360 verifyFormat("int a = sizeof [foo bar:baz];");
3361 verifyFormat("int a = alignof [foo bar:baz];");
Nico Webere8a97982013-02-06 06:20:11 +00003362 verifyFormat("int a = &[foo bar:baz];");
3363 verifyFormat("int a = *[foo bar:baz];");
Nico Weberee0feec2013-02-05 16:21:00 +00003364 // FIXME: Make casts work, without breaking f()[4].
Nico Weber4c2cc602013-02-13 03:48:27 +00003365 //verifyFormat("int a = (int)[foo bar:baz];");
Nico Webere0dc7c72013-02-13 04:40:03 +00003366 //verifyFormat("return (int)[foo bar:baz];");
3367 //verifyFormat("(void)[foo bar:baz];");
Nico Weber4c2cc602013-02-13 03:48:27 +00003368 verifyFormat("return (MyType *)[self.tableView cellForRowAtIndexPath:cell];");
Nico Weberee0feec2013-02-05 16:21:00 +00003369
3370 // Binary operators.
Nico Weberbcfdd262013-01-12 06:18:40 +00003371 verifyFormat("[foo bar:baz], [foo bar:baz];");
3372 verifyFormat("[foo bar:baz] = [foo bar:baz];");
3373 verifyFormat("[foo bar:baz] *= [foo bar:baz];");
3374 verifyFormat("[foo bar:baz] /= [foo bar:baz];");
3375 verifyFormat("[foo bar:baz] %= [foo bar:baz];");
3376 verifyFormat("[foo bar:baz] += [foo bar:baz];");
3377 verifyFormat("[foo bar:baz] -= [foo bar:baz];");
3378 verifyFormat("[foo bar:baz] <<= [foo bar:baz];");
3379 verifyFormat("[foo bar:baz] >>= [foo bar:baz];");
3380 verifyFormat("[foo bar:baz] &= [foo bar:baz];");
3381 verifyFormat("[foo bar:baz] ^= [foo bar:baz];");
3382 verifyFormat("[foo bar:baz] |= [foo bar:baz];");
3383 verifyFormat("[foo bar:baz] ? [foo bar:baz] : [foo bar:baz];");
3384 verifyFormat("[foo bar:baz] || [foo bar:baz];");
3385 verifyFormat("[foo bar:baz] && [foo bar:baz];");
3386 verifyFormat("[foo bar:baz] | [foo bar:baz];");
3387 verifyFormat("[foo bar:baz] ^ [foo bar:baz];");
3388 verifyFormat("[foo bar:baz] & [foo bar:baz];");
3389 verifyFormat("[foo bar:baz] == [foo bar:baz];");
3390 verifyFormat("[foo bar:baz] != [foo bar:baz];");
3391 verifyFormat("[foo bar:baz] >= [foo bar:baz];");
3392 verifyFormat("[foo bar:baz] <= [foo bar:baz];");
3393 verifyFormat("[foo bar:baz] > [foo bar:baz];");
3394 verifyFormat("[foo bar:baz] < [foo bar:baz];");
3395 verifyFormat("[foo bar:baz] >> [foo bar:baz];");
3396 verifyFormat("[foo bar:baz] << [foo bar:baz];");
3397 verifyFormat("[foo bar:baz] - [foo bar:baz];");
3398 verifyFormat("[foo bar:baz] + [foo bar:baz];");
3399 verifyFormat("[foo bar:baz] * [foo bar:baz];");
3400 verifyFormat("[foo bar:baz] / [foo bar:baz];");
3401 verifyFormat("[foo bar:baz] % [foo bar:baz];");
3402 // Whew!
3403
Nico Weberc2e6d2a2013-02-11 15:32:15 +00003404 verifyFormat("return in[42];");
3405 verifyFormat("for (id foo in [self getStuffFor:bla]) {\n"
3406 "}");
3407
Nico Weberbcfdd262013-01-12 06:18:40 +00003408 verifyFormat("[self stuffWithInt:(4 + 2) float:4.5];");
3409 verifyFormat("[self stuffWithInt:a ? b : c float:4.5];");
3410 verifyFormat("[self stuffWithInt:a ? [self foo:bar] : c];");
3411 verifyFormat("[self stuffWithInt:a ? (e ? f : g) : c];");
3412 verifyFormat("[cond ? obj1 : obj2 methodWithParam:param]");
Nico Weber6292dd42013-01-12 23:41:33 +00003413 verifyFormat("[button setAction:@selector(zoomOut:)];");
Nico Webercd458332013-01-12 23:48:49 +00003414 verifyFormat("[color getRed:&r green:&g blue:&b alpha:&a];");
Daniel Jasper63d7ced2013-02-05 10:07:47 +00003415
Nico Weberbcfdd262013-01-12 06:18:40 +00003416 verifyFormat("arr[[self indexForFoo:a]];");
3417 verifyFormat("throw [self errorFor:a];");
3418 verifyFormat("@throw [self errorFor:a];");
3419
Nico Webere8ccc812013-01-12 22:48:47 +00003420 // This tests that the formatter doesn't break after "backing" but before ":",
3421 // which would be at 80 columns.
Nico Weberbcfdd262013-01-12 06:18:40 +00003422 verifyFormat(
3423 "void f() {\n"
Daniel Jasper63d7ced2013-02-05 10:07:47 +00003424 " if ((self = [super initWithContentRect:contentRect\n"
3425 " styleMask:styleMask\n"
3426 " backing:NSBackingStoreBuffered\n"
3427 " defer:YES]))");
3428
Daniel Jasper4e778092013-02-06 10:05:46 +00003429 verifyFormat(
3430 "[foo checkThatBreakingAfterColonWorksOk:\n"
3431 " [bar ifItDoes:reduceOverallLineLengthLikeInThisCase]];");
Daniel Jasper63d7ced2013-02-05 10:07:47 +00003432
3433 verifyFormat("[myObj short:arg1 // Force line break\n"
3434 " longKeyword:arg2\n"
3435 " evenLongerKeyword:arg3\n"
3436 " error:arg4];");
3437 verifyFormat(
3438 "void f() {\n"
3439 " popup_window_.reset([[RenderWidgetPopupWindow alloc]\n"
3440 " initWithContentRect:NSMakeRect(origin_global.x, origin_global.y,\n"
3441 " pos.width(), pos.height())\n"
3442 " styleMask:NSBorderlessWindowMask\n"
3443 " backing:NSBackingStoreBuffered\n"
3444 " defer:NO]);\n"
3445 "}");
Daniel Jasper4e778092013-02-06 10:05:46 +00003446 verifyFormat("[contentsContainer replaceSubview:[subviews objectAtIndex:0]\n"
3447 " with:contentsNativeView];");
3448
3449 verifyFormat(
3450 "[pboard addTypes:[NSArray arrayWithObject:kBookmarkButtonDragType]\n"
3451 " owner:nillllll];");
3452
Daniel Jasper4e778092013-02-06 10:05:46 +00003453 verifyFormat(
Daniel Jasperce3d1a62013-02-08 08:22:00 +00003454 "[pboard setData:[NSData dataWithBytes:&button length:sizeof(button)]\n"
Daniel Jasper4e778092013-02-06 10:05:46 +00003455 " forType:kBookmarkButtonDragType];");
3456
3457 verifyFormat("[defaultCenter addObserver:self\n"
3458 " selector:@selector(willEnterFullscreen)\n"
3459 " name:kWillEnterFullscreenNotification\n"
3460 " object:nil];");
Daniel Jasper9e9e6e02013-02-06 16:00:26 +00003461 verifyFormat("[image_rep drawInRect:drawRect\n"
3462 " fromRect:NSZeroRect\n"
3463 " operation:NSCompositeCopy\n"
3464 " fraction:1.0\n"
3465 " respectFlipped:NO\n"
3466 " hints:nil];");
Nico Weber4ed7f3e2013-02-06 16:54:35 +00003467
3468 verifyFormat(
3469 "scoped_nsobject<NSTextField> message(\n"
3470 " // The frame will be fixed up when |-setMessageText:| is called.\n"
3471 " [[NSTextField alloc] initWithFrame:NSMakeRect(0, 0, 0, 0)]);");
Nico Weberbcfdd262013-01-12 06:18:40 +00003472}
3473
Nico Weber581f5572013-01-07 15:56:25 +00003474TEST_F(FormatTest, ObjCAt) {
Nico Weber4a293a22013-01-07 16:07:07 +00003475 verifyFormat("@autoreleasepool");
Nico Weberd0af4b42013-01-07 16:14:28 +00003476 verifyFormat("@catch");
3477 verifyFormat("@class");
Nico Weber4a293a22013-01-07 16:07:07 +00003478 verifyFormat("@compatibility_alias");
3479 verifyFormat("@defs");
Nico Weberefcfe732013-01-07 15:17:23 +00003480 verifyFormat("@dynamic");
Nico Weber4a293a22013-01-07 16:07:07 +00003481 verifyFormat("@encode");
3482 verifyFormat("@end");
3483 verifyFormat("@finally");
3484 verifyFormat("@implementation");
3485 verifyFormat("@import");
3486 verifyFormat("@interface");
3487 verifyFormat("@optional");
3488 verifyFormat("@package");
Nico Weberd0af4b42013-01-07 16:14:28 +00003489 verifyFormat("@private");
Nico Weber4a293a22013-01-07 16:07:07 +00003490 verifyFormat("@property");
Nico Weberd0af4b42013-01-07 16:14:28 +00003491 verifyFormat("@protected");
Nico Weber4a293a22013-01-07 16:07:07 +00003492 verifyFormat("@protocol");
Nico Weberd0af4b42013-01-07 16:14:28 +00003493 verifyFormat("@public");
Nico Weber4a293a22013-01-07 16:07:07 +00003494 verifyFormat("@required");
3495 verifyFormat("@selector");
3496 verifyFormat("@synchronized");
3497 verifyFormat("@synthesize");
Nico Weberd0af4b42013-01-07 16:14:28 +00003498 verifyFormat("@throw");
3499 verifyFormat("@try");
Nico Weber4a293a22013-01-07 16:07:07 +00003500
Nico Weber581f5572013-01-07 15:56:25 +00003501 EXPECT_EQ("@interface", format("@ interface"));
3502
3503 // The precise formatting of this doesn't matter, nobody writes code like
3504 // this.
3505 verifyFormat("@ /*foo*/ interface");
Nico Weberefcfe732013-01-07 15:17:23 +00003506}
3507
Nico Weberc31689a2013-01-08 19:15:23 +00003508TEST_F(FormatTest, ObjCSnippets) {
Manuel Klimekd5688cf2013-01-11 19:17:44 +00003509 verifyFormat("@autoreleasepool {\n"
3510 " foo();\n"
3511 "}");
Nico Webercf4a79c2013-01-08 17:56:31 +00003512 verifyFormat("@class Foo, Bar;");
Nico Weberc31689a2013-01-08 19:15:23 +00003513 verifyFormat("@compatibility_alias AliasName ExistingClass;");
Nico Webercf4a79c2013-01-08 17:56:31 +00003514 verifyFormat("@dynamic textColor;");
Nico Weber5dfe9b42013-01-18 05:11:47 +00003515 verifyFormat("char *buf1 = @encode(int *);");
3516 verifyFormat("char *buf1 = @encode(typeof(4 * 5));");
Nico Weber95e8e462013-02-12 16:17:07 +00003517 verifyFormat("char *buf1 = @encode(int **);");
Nico Weber3a2673e2013-01-08 20:16:23 +00003518 verifyFormat("Protocol *proto = @protocol(p1);");
Nico Weber6a21a552013-01-18 02:43:57 +00003519 verifyFormat("SEL s = @selector(foo:);");
Manuel Klimekd5688cf2013-01-11 19:17:44 +00003520 verifyFormat("@synchronized(self) {\n"
3521 " f();\n"
3522 "}");
Nico Webercf4a79c2013-01-08 17:56:31 +00003523
Nico Weber70848232013-01-10 21:30:42 +00003524 verifyFormat("@synthesize dropArrowPosition = dropArrowPosition_;");
3525 verifyGoogleFormat("@synthesize dropArrowPosition = dropArrowPosition_;");
3526
Nico Webercf4a79c2013-01-08 17:56:31 +00003527 verifyFormat("@property(assign, nonatomic) CGFloat hoverAlpha;");
Nico Weber70848232013-01-10 21:30:42 +00003528 verifyFormat("@property(assign, getter=isEditable) BOOL editable;");
3529 verifyGoogleFormat("@property(assign, getter=isEditable) BOOL editable;");
Nico Webercf4a79c2013-01-08 17:56:31 +00003530}
3531
Nico Weber712f5b32013-02-07 00:19:29 +00003532TEST_F(FormatTest, ObjCLiterals) {
3533 verifyFormat("@\"String\"");
3534 verifyFormat("@1");
3535 verifyFormat("@+4.8");
3536 verifyFormat("@-4");
3537 verifyFormat("@1LL");
3538 verifyFormat("@.5");
3539 verifyFormat("@'c'");
3540 verifyFormat("@true");
3541
3542 verifyFormat("NSNumber *smallestInt = @(-INT_MAX - 1);");
3543 verifyFormat("NSNumber *piOverTwo = @(M_PI / 2);");
3544 verifyFormat("NSNumber *favoriteColor = @(Green);");
3545 verifyFormat("NSString *path = @(getenv(\"PATH\"));");
3546
Nico Weber712f5b32013-02-07 00:19:29 +00003547 verifyFormat("@[");
Nico Weber051860e2013-02-10 02:08:05 +00003548 verifyFormat("@[]");
3549 verifyFormat(
3550 "NSArray *array = @[ @\" Hey \", NSApp, [NSNumber numberWithInt:42] ];");
3551 verifyFormat("return @[ @3, @[], @[ @4, @5 ] ];");
3552
Nico Weber712f5b32013-02-07 00:19:29 +00003553 verifyFormat("@{");
Nico Weberd74fcdb2013-02-10 20:35:35 +00003554 verifyFormat("@{}");
3555 verifyFormat("@{ @\"one\" : @1 }");
3556 verifyFormat("return @{ @\"one\" : @1 };");
3557 verifyFormat("@{ @\"one\" : @1, }");
Manuel Klimek67d080d2013-04-12 14:13:36 +00003558
3559 // FIXME: Breaking in cases where we think there's a structural error
3560 // showed that we're incorrectly parsing this code. We need to fix the
3561 // parsing here.
3562 verifyFormat("@{ @\"one\" : @\n"
3563 "{ @2 : @1 }\n"
3564 "}");
3565 verifyFormat("@{ @\"one\" : @\n"
3566 "{ @2 : @1 }\n"
3567 ",\n"
3568 "}");
3569
Nico Weberd74fcdb2013-02-10 20:35:35 +00003570 verifyFormat("@{ 1 > 2 ? @\"one\" : @\"two\" : 1 > 2 ? @1 : @2 }");
3571 verifyFormat("[self setDict:@{}");
3572 verifyFormat("[self setDict:@{ @1 : @2 }");
3573 verifyFormat("NSLog(@\"%@\", @{ @1 : @2, @2 : @3 }[@1]);");
3574 verifyFormat(
3575 "NSDictionary *masses = @{ @\"H\" : @1.0078, @\"He\" : @4.0026 };");
Nico Webere6262002013-02-10 20:39:05 +00003576 verifyFormat(
3577 "NSDictionary *settings = @{ AVEncoderKey : @(AVAudioQualityMax) };");
Daniel Jasper66d19bd2013-02-18 11:59:17 +00003578
Nico Weberd74fcdb2013-02-10 20:35:35 +00003579 // FIXME: Nested and multi-line array and dictionary literals need more work.
Nico Weber0ac717b2013-02-10 20:48:24 +00003580 verifyFormat(
3581 "NSDictionary *d = @{ @\"nam\" : NSUserNam(), @\"dte\" : [NSDate date],\n"
3582 " @\"processInfo\" : [NSProcessInfo processInfo] };");
Nico Weber712f5b32013-02-07 00:19:29 +00003583}
3584
Manuel Klimek547d5db2013-02-08 17:38:27 +00003585TEST_F(FormatTest, ReformatRegionAdjustsIndent) {
3586 EXPECT_EQ("{\n"
3587 "{\n"
3588 "a;\n"
3589 "b;\n"
3590 "}\n"
Daniel Jasper66d19bd2013-02-18 11:59:17 +00003591 "}",
3592 format("{\n"
3593 "{\n"
3594 "a;\n"
3595 " b;\n"
3596 "}\n"
3597 "}",
3598 13, 2, getLLVMStyle()));
Manuel Klimek547d5db2013-02-08 17:38:27 +00003599 EXPECT_EQ("{\n"
3600 "{\n"
3601 " a;\n"
3602 "b;\n"
3603 "}\n"
Daniel Jasper66d19bd2013-02-18 11:59:17 +00003604 "}",
3605 format("{\n"
3606 "{\n"
3607 " a;\n"
3608 "b;\n"
3609 "}\n"
3610 "}",
3611 9, 2, getLLVMStyle()));
Manuel Klimek547d5db2013-02-08 17:38:27 +00003612 EXPECT_EQ("{\n"
3613 "{\n"
3614 "public:\n"
3615 " b;\n"
3616 "}\n"
Daniel Jasper66d19bd2013-02-18 11:59:17 +00003617 "}",
3618 format("{\n"
3619 "{\n"
3620 "public:\n"
3621 " b;\n"
3622 "}\n"
3623 "}",
3624 17, 2, getLLVMStyle()));
Manuel Klimek547d5db2013-02-08 17:38:27 +00003625 EXPECT_EQ("{\n"
3626 "{\n"
3627 "a;\n"
3628 "}\n"
3629 "{\n"
3630 " b;\n"
3631 "}\n"
Daniel Jasper66d19bd2013-02-18 11:59:17 +00003632 "}",
3633 format("{\n"
3634 "{\n"
3635 "a;\n"
3636 "}\n"
3637 "{\n"
3638 " b;\n"
3639 "}\n"
3640 "}",
3641 22, 2, getLLVMStyle()));
Manuel Klimek52635ff2013-02-08 19:53:32 +00003642 EXPECT_EQ(" {\n"
3643 " a;\n"
Daniel Jasper66d19bd2013-02-18 11:59:17 +00003644 " }",
3645 format(" {\n"
3646 "a;\n"
3647 " }",
3648 4, 2, getLLVMStyle()));
Daniel Jasper9ece2bb2013-02-12 16:51:23 +00003649 EXPECT_EQ("void f() {}\n"
Daniel Jasper66d19bd2013-02-18 11:59:17 +00003650 "void g() {}",
3651 format("void f() {}\n"
3652 "void g() {}",
3653 13, 0, getLLVMStyle()));
Daniel Jasper83a90e52013-03-20 14:31:47 +00003654 EXPECT_EQ("int a; // comment\n"
3655 " // line 2\n"
3656 "int b;",
3657 format("int a; // comment\n"
3658 " // line 2\n"
3659 " int b;",
3660 35, 0, getLLVMStyle()));
Manuel Klimek52635ff2013-02-08 19:53:32 +00003661}
Manuel Klimek547d5db2013-02-08 17:38:27 +00003662
Manuel Klimek8092a942013-02-20 10:15:13 +00003663TEST_F(FormatTest, BreakStringLiterals) {
3664 EXPECT_EQ("\"some text \"\n"
3665 "\"other\";",
3666 format("\"some text other\";", getLLVMStyleWithColumns(12)));
3667 EXPECT_EQ(
3668 "#define A \\\n"
3669 " \"some \" \\\n"
3670 " \"text \" \\\n"
3671 " \"other\";",
3672 format("#define A \"some text other\";", getLLVMStyleWithColumns(12)));
3673 EXPECT_EQ(
3674 "#define A \\\n"
3675 " \"so \" \\\n"
3676 " \"text \" \\\n"
3677 " \"other\";",
3678 format("#define A \"so text other\";", getLLVMStyleWithColumns(12)));
3679
3680 EXPECT_EQ("\"some text\"",
3681 format("\"some text\"", getLLVMStyleWithColumns(1)));
3682 EXPECT_EQ("\"some text\"",
3683 format("\"some text\"", getLLVMStyleWithColumns(11)));
3684 EXPECT_EQ("\"some \"\n"
3685 "\"text\"",
3686 format("\"some text\"", getLLVMStyleWithColumns(10)));
3687 EXPECT_EQ("\"some \"\n"
3688 "\"text\"",
3689 format("\"some text\"", getLLVMStyleWithColumns(7)));
Manuel Klimekaf31fd72013-03-01 13:14:08 +00003690 EXPECT_EQ("\"some\"\n"
Alexander Kornienko70ce7882013-04-15 14:28:00 +00003691 "\" tex\"\n"
3692 "\"t\"",
Manuel Klimek8092a942013-02-20 10:15:13 +00003693 format("\"some text\"", getLLVMStyleWithColumns(6)));
Manuel Klimek00905912013-03-04 20:03:38 +00003694 EXPECT_EQ("\"some\"\n"
3695 "\" tex\"\n"
3696 "\" and\"",
3697 format("\"some tex and\"", getLLVMStyleWithColumns(6)));
3698 EXPECT_EQ("\"some\"\n"
3699 "\"/tex\"\n"
3700 "\"/and\"",
3701 format("\"some/tex/and\"", getLLVMStyleWithColumns(6)));
Manuel Klimek8092a942013-02-20 10:15:13 +00003702
3703 EXPECT_EQ("variable =\n"
3704 " \"long string \"\n"
3705 " \"literal\";",
3706 format("variable = \"long string literal\";",
3707 getLLVMStyleWithColumns(20)));
3708
3709 EXPECT_EQ("variable = f(\n"
3710 " \"long string \"\n"
Daniel Jasperfaab0d32013-02-27 09:47:53 +00003711 " \"literal\",\n"
3712 " short,\n"
Manuel Klimek8092a942013-02-20 10:15:13 +00003713 " loooooooooooooooooooong);",
3714 format("variable = f(\"long string literal\", short, "
3715 "loooooooooooooooooooong);",
3716 getLLVMStyleWithColumns(20)));
3717 EXPECT_EQ(
3718 "f(\"one two\".split(\n"
3719 " variable));",
3720 format("f(\"one two\".split(variable));", getLLVMStyleWithColumns(20)));
3721 EXPECT_EQ("f(\"one two three four five six \"\n"
3722 " \"seven\".split(\n"
3723 " really_looooong_variable));",
3724 format("f(\"one two three four five six seven\"."
3725 "split(really_looooong_variable));",
3726 getLLVMStyleWithColumns(33)));
3727
3728 EXPECT_EQ("f(\"some \"\n"
3729 " \"text\",\n"
3730 " other);",
3731 format("f(\"some text\", other);", getLLVMStyleWithColumns(10)));
Daniel Jasper0fb382b2013-02-26 12:52:34 +00003732
3733 // Only break as a last resort.
3734 verifyFormat(
3735 "aaaaaaaaaaaaaaaaaaaa(\n"
3736 " aaaaaaaaaaaaaaaaaaaa,\n"
3737 " aaaaaa(\"aaa aaaaa aaa aaa aaaaa aaa aaaaa aaa aaa aaaaaa\"));");
Manuel Klimekaf31fd72013-03-01 13:14:08 +00003738
3739 EXPECT_EQ(
3740 "\"splitmea\"\n"
Manuel Klimekbc30c712013-03-01 13:29:19 +00003741 "\"trandomp\"\n"
3742 "\"oint\"",
Manuel Klimekaf31fd72013-03-01 13:14:08 +00003743 format("\"splitmeatrandompoint\"", getLLVMStyleWithColumns(10)));
Manuel Klimekbc30c712013-03-01 13:29:19 +00003744
3745 EXPECT_EQ(
3746 "\"split/\"\n"
3747 "\"pathat/\"\n"
3748 "\"slashes\"",
3749 format("\"split/pathat/slashes\"", getLLVMStyleWithColumns(10)));
Manuel Klimek8092a942013-02-20 10:15:13 +00003750}
3751
Manuel Klimekaa62d0c2013-03-08 18:59:48 +00003752TEST_F(FormatTest, DoNotBreakStringLiteralsInEscapeSequence) {
3753 EXPECT_EQ("\"\\a\"",
3754 format("\"\\a\"", getLLVMStyleWithColumns(3)));
3755 EXPECT_EQ("\"\\\"",
3756 format("\"\\\"", getLLVMStyleWithColumns(2)));
3757 EXPECT_EQ("\"test\"\n"
3758 "\"\\n\"",
3759 format("\"test\\n\"", getLLVMStyleWithColumns(7)));
3760 EXPECT_EQ("\"tes\\\\\"\n"
3761 "\"n\"",
3762 format("\"tes\\\\n\"", getLLVMStyleWithColumns(7)));
3763 EXPECT_EQ("\"\\\\\\\\\"\n"
3764 "\"\\n\"",
3765 format("\"\\\\\\\\\\n\"", getLLVMStyleWithColumns(7)));
3766 EXPECT_EQ("\"\\uff01\"",
3767 format("\"\\uff01\"", getLLVMStyleWithColumns(7)));
3768 EXPECT_EQ("\"\\uff01\"\n"
3769 "\"test\"",
3770 format("\"\\uff01test\"", getLLVMStyleWithColumns(8)));
3771 EXPECT_EQ("\"\\Uff01ff02\"",
3772 format("\"\\Uff01ff02\"", getLLVMStyleWithColumns(11)));
3773 EXPECT_EQ("\"\\x000000000001\"\n"
3774 "\"next\"",
3775 format("\"\\x000000000001next\"", getLLVMStyleWithColumns(16)));
3776 EXPECT_EQ("\"\\x000000000001next\"",
3777 format("\"\\x000000000001next\"", getLLVMStyleWithColumns(15)));
3778 EXPECT_EQ("\"\\x000000000001\"",
3779 format("\"\\x000000000001\"", getLLVMStyleWithColumns(7)));
3780 EXPECT_EQ("\"test\"\n"
3781 "\"\\000000\"\n"
3782 "\"000001\"",
3783 format("\"test\\000000000001\"", getLLVMStyleWithColumns(9)));
3784 EXPECT_EQ("\"test\\000\"\n"
Alexander Kornienko70ce7882013-04-15 14:28:00 +00003785 "\"00000000\"\n"
3786 "\"1\"",
Manuel Klimekaa62d0c2013-03-08 18:59:48 +00003787 format("\"test\\000000000001\"", getLLVMStyleWithColumns(10)));
3788 EXPECT_EQ("R\"(\\x\\x00)\"\n",
3789 format("R\"(\\x\\x00)\"\n", getLLVMStyleWithColumns(7)));
3790}
3791
Manuel Klimek423dd932013-04-10 09:52:05 +00003792TEST_F(FormatTest, DoNotCreateUnreasonableUnwrappedLines) {
3793 verifyFormat("void f() {\n"
3794 " return g() {}\n"
3795 " void h() {}");
3796 verifyFormat("if (foo)\n"
3797 " return { forgot_closing_brace();\n"
3798 "test();");
3799 verifyFormat("int a[] = { void forgot_closing_brace()\n"
3800 "{\n"
3801 " f();\n"
3802 " g();\n"
3803 "}");
3804}
3805
Daniel Jaspercd162382013-01-07 13:26:07 +00003806} // end namespace tooling
3807} // end namespace clang