blob: 7b0941e34b6cf8e237ff30a343235e34a3c3db64 [file] [log] [blame]
Chris Lattner59907c42007-08-10 20:18:51 +00001//===--- SemaChecking.cpp - Extra Semantic Checking -----------------------===//
2//
3// The LLVM Compiler Infrastructure
4//
Chris Lattner0bc735f2007-12-29 19:59:25 +00005// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
Chris Lattner59907c42007-08-10 20:18:51 +00007//
8//===----------------------------------------------------------------------===//
9//
Mike Stump1eb44332009-09-09 15:08:12 +000010// This file implements extra semantic analysis beyond what is enforced
Chris Lattner59907c42007-08-10 20:18:51 +000011// by the C type system.
12//
13//===----------------------------------------------------------------------===//
14
Douglas Gregore737f502010-08-12 20:07:10 +000015#include "clang/Sema/Sema.h"
John McCall2d887082010-08-25 22:03:47 +000016#include "clang/Sema/SemaInternal.h"
John McCall781472f2010-08-25 08:40:02 +000017#include "clang/Sema/ScopeInfo.h"
Ted Kremenek826a3452010-07-16 02:11:22 +000018#include "clang/Analysis/Analyses/FormatString.h"
Chris Lattner59907c42007-08-10 20:18:51 +000019#include "clang/AST/ASTContext.h"
Ken Dyck199c3d62010-01-11 17:06:35 +000020#include "clang/AST/CharUnits.h"
John McCall384aff82010-08-25 07:42:41 +000021#include "clang/AST/DeclCXX.h"
Daniel Dunbarc4a1dea2008-08-11 05:35:13 +000022#include "clang/AST/DeclObjC.h"
Ted Kremenek23245122007-08-20 16:18:38 +000023#include "clang/AST/ExprCXX.h"
Ted Kremenek7ff22b22008-06-16 18:00:42 +000024#include "clang/AST/ExprObjC.h"
Mike Stumpf8c49212010-01-21 03:59:47 +000025#include "clang/AST/DeclObjC.h"
26#include "clang/AST/StmtCXX.h"
27#include "clang/AST/StmtObjC.h"
Chris Lattner719e6152009-02-18 19:21:10 +000028#include "clang/Lex/LiteralSupport.h"
Chris Lattner59907c42007-08-10 20:18:51 +000029#include "clang/Lex/Preprocessor.h"
Mike Stumpf8c49212010-01-21 03:59:47 +000030#include "llvm/ADT/BitVector.h"
31#include "llvm/ADT/STLExtras.h"
Tom Care3bfc5f42010-06-09 04:11:11 +000032#include "llvm/Support/raw_ostream.h"
Eric Christopher691ebc32010-04-17 02:26:23 +000033#include "clang/Basic/TargetBuiltins.h"
Nate Begeman26a31422010-06-08 02:47:44 +000034#include "clang/Basic/TargetInfo.h"
Fariborz Jahanian7da71022010-09-07 19:38:13 +000035#include "clang/Basic/ConvertUTF.h"
36
Zhongxing Xua1f3dba2009-05-20 01:55:10 +000037#include <limits>
Chris Lattner59907c42007-08-10 20:18:51 +000038using namespace clang;
John McCall781472f2010-08-25 08:40:02 +000039using namespace sema;
Chris Lattner59907c42007-08-10 20:18:51 +000040
Chris Lattner60800082009-02-18 17:49:48 +000041/// getLocationOfStringLiteralByte - Return a source location that points to the
42/// specified byte of the specified string literal.
43///
44/// Strings are amazingly complex. They can be formed from multiple tokens and
45/// can have escape sequences in them in addition to the usual trigraph and
46/// escaped newline business. This routine handles this complexity.
47///
48SourceLocation Sema::getLocationOfStringLiteralByte(const StringLiteral *SL,
49 unsigned ByteNo) const {
50 assert(!SL->isWide() && "This doesn't work for wide strings yet");
Mike Stump1eb44332009-09-09 15:08:12 +000051
Chris Lattner60800082009-02-18 17:49:48 +000052 // Loop over all of the tokens in this string until we find the one that
53 // contains the byte we're looking for.
54 unsigned TokNo = 0;
55 while (1) {
56 assert(TokNo < SL->getNumConcatenated() && "Invalid byte number!");
57 SourceLocation StrTokLoc = SL->getStrTokenLoc(TokNo);
Mike Stump1eb44332009-09-09 15:08:12 +000058
Chris Lattner60800082009-02-18 17:49:48 +000059 // Get the spelling of the string so that we can get the data that makes up
60 // the string literal, not the identifier for the macro it is potentially
61 // expanded through.
62 SourceLocation StrTokSpellingLoc = SourceMgr.getSpellingLoc(StrTokLoc);
63
64 // Re-lex the token to get its length and original spelling.
65 std::pair<FileID, unsigned> LocInfo =
66 SourceMgr.getDecomposedLoc(StrTokSpellingLoc);
Douglas Gregorf715ca12010-03-16 00:06:06 +000067 bool Invalid = false;
Benjamin Kramerf6ac97b2010-03-16 14:14:31 +000068 llvm::StringRef Buffer = SourceMgr.getBufferData(LocInfo.first, &Invalid);
Douglas Gregorf715ca12010-03-16 00:06:06 +000069 if (Invalid)
Douglas Gregoraea67db2010-03-15 22:54:52 +000070 return StrTokSpellingLoc;
71
Benjamin Kramerf6ac97b2010-03-16 14:14:31 +000072 const char *StrData = Buffer.data()+LocInfo.second;
Mike Stump1eb44332009-09-09 15:08:12 +000073
Chris Lattner60800082009-02-18 17:49:48 +000074 // Create a langops struct and enable trigraphs. This is sufficient for
75 // relexing tokens.
76 LangOptions LangOpts;
77 LangOpts.Trigraphs = true;
Mike Stump1eb44332009-09-09 15:08:12 +000078
Chris Lattner60800082009-02-18 17:49:48 +000079 // Create a lexer starting at the beginning of this token.
Benjamin Kramerf6ac97b2010-03-16 14:14:31 +000080 Lexer TheLexer(StrTokSpellingLoc, LangOpts, Buffer.begin(), StrData,
81 Buffer.end());
Chris Lattner60800082009-02-18 17:49:48 +000082 Token TheTok;
83 TheLexer.LexFromRawLexer(TheTok);
Mike Stump1eb44332009-09-09 15:08:12 +000084
Chris Lattner443e53c2009-02-18 19:26:42 +000085 // Use the StringLiteralParser to compute the length of the string in bytes.
Douglas Gregorb90f4b32010-05-26 05:35:51 +000086 StringLiteralParser SLP(&TheTok, 1, PP, /*Complain=*/false);
Chris Lattner443e53c2009-02-18 19:26:42 +000087 unsigned TokNumBytes = SLP.GetStringLength();
Mike Stump1eb44332009-09-09 15:08:12 +000088
Chris Lattner2197c962009-02-18 18:52:52 +000089 // If the byte is in this token, return the location of the byte.
Chris Lattner60800082009-02-18 17:49:48 +000090 if (ByteNo < TokNumBytes ||
91 (ByteNo == TokNumBytes && TokNo == SL->getNumConcatenated())) {
Mike Stump1eb44332009-09-09 15:08:12 +000092 unsigned Offset =
Douglas Gregorb90f4b32010-05-26 05:35:51 +000093 StringLiteralParser::getOffsetOfStringByte(TheTok, ByteNo, PP,
94 /*Complain=*/false);
Mike Stump1eb44332009-09-09 15:08:12 +000095
Chris Lattner719e6152009-02-18 19:21:10 +000096 // Now that we know the offset of the token in the spelling, use the
97 // preprocessor to get the offset in the original source.
98 return PP.AdvanceToTokenCharacter(StrTokLoc, Offset);
Chris Lattner60800082009-02-18 17:49:48 +000099 }
Mike Stump1eb44332009-09-09 15:08:12 +0000100
Chris Lattner60800082009-02-18 17:49:48 +0000101 // Move to the next string token.
102 ++TokNo;
103 ByteNo -= TokNumBytes;
104 }
105}
106
Ryan Flynn4403a5e2009-08-06 03:00:50 +0000107/// CheckablePrintfAttr - does a function call have a "printf" attribute
108/// and arguments that merit checking?
109bool Sema::CheckablePrintfAttr(const FormatAttr *Format, CallExpr *TheCall) {
110 if (Format->getType() == "printf") return true;
111 if (Format->getType() == "printf0") {
112 // printf0 allows null "format" string; if so don't check format/args
113 unsigned format_idx = Format->getFormatIdx() - 1;
Sebastian Redl4a2614e2009-11-17 18:02:24 +0000114 // Does the index refer to the implicit object argument?
115 if (isa<CXXMemberCallExpr>(TheCall)) {
116 if (format_idx == 0)
117 return false;
118 --format_idx;
119 }
Ryan Flynn4403a5e2009-08-06 03:00:50 +0000120 if (format_idx < TheCall->getNumArgs()) {
121 Expr *Format = TheCall->getArg(format_idx)->IgnoreParenCasts();
Ted Kremenekefaff192010-02-27 01:41:03 +0000122 if (!Format->isNullPointerConstant(Context,
123 Expr::NPC_ValueDependentIsNull))
Ryan Flynn4403a5e2009-08-06 03:00:50 +0000124 return true;
125 }
126 }
127 return false;
128}
Chris Lattner60800082009-02-18 17:49:48 +0000129
John McCall60d7b3a2010-08-24 06:29:42 +0000130ExprResult
Anders Carlssond406bf02009-08-16 01:56:34 +0000131Sema::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
John McCall60d7b3a2010-08-24 06:29:42 +0000132 ExprResult TheCallResult(Owned(TheCall));
Douglas Gregor2def4832008-11-17 20:34:05 +0000133
Anders Carlssond406bf02009-08-16 01:56:34 +0000134 switch (BuiltinID) {
Chris Lattner30ce3442007-12-19 23:59:04 +0000135 case Builtin::BI__builtin___CFStringMakeConstantString:
Chris Lattner925e60d2007-12-28 05:29:59 +0000136 assert(TheCall->getNumArgs() == 1 &&
Chris Lattner1b9a0792007-12-20 00:26:33 +0000137 "Wrong # arguments to builtin CFStringMakeConstantString");
Chris Lattner69039812009-02-18 06:01:06 +0000138 if (CheckObjCString(TheCall->getArg(0)))
Sebastian Redl0eb23302009-01-19 00:08:26 +0000139 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000140 break;
Ted Kremenek49ff7a12008-07-09 17:58:53 +0000141 case Builtin::BI__builtin_stdarg_start:
Chris Lattner30ce3442007-12-19 23:59:04 +0000142 case Builtin::BI__builtin_va_start:
Sebastian Redl0eb23302009-01-19 00:08:26 +0000143 if (SemaBuiltinVAStart(TheCall))
144 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000145 break;
Chris Lattner1b9a0792007-12-20 00:26:33 +0000146 case Builtin::BI__builtin_isgreater:
147 case Builtin::BI__builtin_isgreaterequal:
148 case Builtin::BI__builtin_isless:
149 case Builtin::BI__builtin_islessequal:
150 case Builtin::BI__builtin_islessgreater:
151 case Builtin::BI__builtin_isunordered:
Sebastian Redl0eb23302009-01-19 00:08:26 +0000152 if (SemaBuiltinUnorderedCompare(TheCall))
153 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000154 break;
Benjamin Kramere771a7a2010-02-15 22:42:31 +0000155 case Builtin::BI__builtin_fpclassify:
156 if (SemaBuiltinFPClassification(TheCall, 6))
157 return ExprError();
158 break;
Eli Friedman9ac6f622009-08-31 20:06:00 +0000159 case Builtin::BI__builtin_isfinite:
160 case Builtin::BI__builtin_isinf:
161 case Builtin::BI__builtin_isinf_sign:
162 case Builtin::BI__builtin_isnan:
163 case Builtin::BI__builtin_isnormal:
Benjamin Kramer3b1e26b2010-02-16 10:07:31 +0000164 if (SemaBuiltinFPClassification(TheCall, 1))
Eli Friedman9ac6f622009-08-31 20:06:00 +0000165 return ExprError();
166 break;
Eli Friedman6cfda232008-05-20 08:23:37 +0000167 case Builtin::BI__builtin_return_address:
Eric Christopher691ebc32010-04-17 02:26:23 +0000168 case Builtin::BI__builtin_frame_address: {
169 llvm::APSInt Result;
170 if (SemaBuiltinConstantArg(TheCall, 0, Result))
Sebastian Redl0eb23302009-01-19 00:08:26 +0000171 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000172 break;
Eric Christopher691ebc32010-04-17 02:26:23 +0000173 }
174 case Builtin::BI__builtin_eh_return_data_regno: {
175 llvm::APSInt Result;
176 if (SemaBuiltinConstantArg(TheCall, 0, Result))
Chris Lattner21fb98e2009-09-23 06:06:36 +0000177 return ExprError();
178 break;
Eric Christopher691ebc32010-04-17 02:26:23 +0000179 }
Eli Friedmand38617c2008-05-14 19:38:39 +0000180 case Builtin::BI__builtin_shufflevector:
Sebastian Redl0eb23302009-01-19 00:08:26 +0000181 return SemaBuiltinShuffleVector(TheCall);
182 // TheCall will be freed by the smart pointer here, but that's fine, since
183 // SemaBuiltinShuffleVector guts it, but then doesn't release it.
Daniel Dunbar4493f792008-07-21 22:59:13 +0000184 case Builtin::BI__builtin_prefetch:
Sebastian Redl0eb23302009-01-19 00:08:26 +0000185 if (SemaBuiltinPrefetch(TheCall))
186 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000187 break;
Daniel Dunbard5f8a4f2008-09-03 21:13:56 +0000188 case Builtin::BI__builtin_object_size:
Sebastian Redl0eb23302009-01-19 00:08:26 +0000189 if (SemaBuiltinObjectSize(TheCall))
190 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000191 break;
Eli Friedmand875fed2009-05-03 04:46:36 +0000192 case Builtin::BI__builtin_longjmp:
193 if (SemaBuiltinLongjmp(TheCall))
194 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000195 break;
Chris Lattner5caa3702009-05-08 06:58:22 +0000196 case Builtin::BI__sync_fetch_and_add:
197 case Builtin::BI__sync_fetch_and_sub:
198 case Builtin::BI__sync_fetch_and_or:
199 case Builtin::BI__sync_fetch_and_and:
200 case Builtin::BI__sync_fetch_and_xor:
201 case Builtin::BI__sync_add_and_fetch:
202 case Builtin::BI__sync_sub_and_fetch:
203 case Builtin::BI__sync_and_and_fetch:
204 case Builtin::BI__sync_or_and_fetch:
205 case Builtin::BI__sync_xor_and_fetch:
206 case Builtin::BI__sync_val_compare_and_swap:
207 case Builtin::BI__sync_bool_compare_and_swap:
208 case Builtin::BI__sync_lock_test_and_set:
209 case Builtin::BI__sync_lock_release:
Chandler Carruthd2014572010-07-09 18:59:35 +0000210 return SemaBuiltinAtomicOverloaded(move(TheCallResult));
Nate Begeman26a31422010-06-08 02:47:44 +0000211 }
212
213 // Since the target specific builtins for each arch overlap, only check those
214 // of the arch we are compiling for.
215 if (BuiltinID >= Builtin::FirstTSBuiltin) {
216 switch (Context.Target.getTriple().getArch()) {
217 case llvm::Triple::arm:
218 case llvm::Triple::thumb:
219 if (CheckARMBuiltinFunctionCall(BuiltinID, TheCall))
220 return ExprError();
221 break;
222 case llvm::Triple::x86:
223 case llvm::Triple::x86_64:
224 if (CheckX86BuiltinFunctionCall(BuiltinID, TheCall))
225 return ExprError();
226 break;
227 default:
228 break;
229 }
230 }
231
232 return move(TheCallResult);
233}
234
235bool Sema::CheckX86BuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
236 switch (BuiltinID) {
Eric Christopher691ebc32010-04-17 02:26:23 +0000237 case X86::BI__builtin_ia32_palignr128:
238 case X86::BI__builtin_ia32_palignr: {
239 llvm::APSInt Result;
240 if (SemaBuiltinConstantArg(TheCall, 2, Result))
Nate Begeman26a31422010-06-08 02:47:44 +0000241 return true;
Eric Christopher691ebc32010-04-17 02:26:23 +0000242 break;
243 }
Anders Carlsson71993dd2007-08-17 05:31:46 +0000244 }
Nate Begeman26a31422010-06-08 02:47:44 +0000245 return false;
246}
Mike Stump1eb44332009-09-09 15:08:12 +0000247
Nate Begeman61eecf52010-06-14 05:21:25 +0000248// Get the valid immediate range for the specified NEON type code.
249static unsigned RFT(unsigned t, bool shift = false) {
250 bool quad = t & 0x10;
251
252 switch (t & 0x7) {
253 case 0: // i8
Nate Begemand69ec162010-06-17 02:26:59 +0000254 return shift ? 7 : (8 << (int)quad) - 1;
Nate Begeman61eecf52010-06-14 05:21:25 +0000255 case 1: // i16
Nate Begemand69ec162010-06-17 02:26:59 +0000256 return shift ? 15 : (4 << (int)quad) - 1;
Nate Begeman61eecf52010-06-14 05:21:25 +0000257 case 2: // i32
Nate Begemand69ec162010-06-17 02:26:59 +0000258 return shift ? 31 : (2 << (int)quad) - 1;
Nate Begeman61eecf52010-06-14 05:21:25 +0000259 case 3: // i64
Nate Begemand69ec162010-06-17 02:26:59 +0000260 return shift ? 63 : (1 << (int)quad) - 1;
Nate Begeman61eecf52010-06-14 05:21:25 +0000261 case 4: // f32
262 assert(!shift && "cannot shift float types!");
Nate Begemand69ec162010-06-17 02:26:59 +0000263 return (2 << (int)quad) - 1;
Nate Begeman61eecf52010-06-14 05:21:25 +0000264 case 5: // poly8
265 assert(!shift && "cannot shift polynomial types!");
Nate Begemand69ec162010-06-17 02:26:59 +0000266 return (8 << (int)quad) - 1;
Nate Begeman61eecf52010-06-14 05:21:25 +0000267 case 6: // poly16
268 assert(!shift && "cannot shift polynomial types!");
Nate Begemand69ec162010-06-17 02:26:59 +0000269 return (4 << (int)quad) - 1;
Nate Begeman61eecf52010-06-14 05:21:25 +0000270 case 7: // float16
271 assert(!shift && "cannot shift float types!");
Nate Begemand69ec162010-06-17 02:26:59 +0000272 return (4 << (int)quad) - 1;
Nate Begeman61eecf52010-06-14 05:21:25 +0000273 }
274 return 0;
275}
276
Nate Begeman26a31422010-06-08 02:47:44 +0000277bool Sema::CheckARMBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
Nate Begeman1c2a88c2010-06-09 01:10:23 +0000278 llvm::APSInt Result;
279
Nate Begeman0d15c532010-06-13 04:47:52 +0000280 unsigned mask = 0;
Nate Begeman61eecf52010-06-14 05:21:25 +0000281 unsigned TV = 0;
Nate Begeman1c2a88c2010-06-09 01:10:23 +0000282 switch (BuiltinID) {
Nate Begemana23326b2010-06-17 04:17:01 +0000283#define GET_NEON_OVERLOAD_CHECK
284#include "clang/Basic/arm_neon.inc"
285#undef GET_NEON_OVERLOAD_CHECK
Nate Begeman1c2a88c2010-06-09 01:10:23 +0000286 }
287
Nate Begeman0d15c532010-06-13 04:47:52 +0000288 // For NEON intrinsics which are overloaded on vector element type, validate
289 // the immediate which specifies which variant to emit.
290 if (mask) {
291 unsigned ArgNo = TheCall->getNumArgs()-1;
292 if (SemaBuiltinConstantArg(TheCall, ArgNo, Result))
293 return true;
294
Nate Begeman61eecf52010-06-14 05:21:25 +0000295 TV = Result.getLimitedValue(32);
296 if ((TV > 31) || (mask & (1 << TV)) == 0)
Nate Begeman0d15c532010-06-13 04:47:52 +0000297 return Diag(TheCall->getLocStart(), diag::err_invalid_neon_type_code)
298 << TheCall->getArg(ArgNo)->getSourceRange();
299 }
Nate Begeman1c2a88c2010-06-09 01:10:23 +0000300
Nate Begeman0d15c532010-06-13 04:47:52 +0000301 // For NEON intrinsics which take an immediate value as part of the
302 // instruction, range check them here.
Nate Begeman61eecf52010-06-14 05:21:25 +0000303 unsigned i = 0, l = 0, u = 0;
Nate Begeman0d15c532010-06-13 04:47:52 +0000304 switch (BuiltinID) {
305 default: return false;
Nate Begemanbb37f502010-07-29 22:48:34 +0000306 case ARM::BI__builtin_arm_ssat: i = 1; l = 1; u = 31; break;
307 case ARM::BI__builtin_arm_usat: i = 1; u = 31; break;
Nate Begeman99c40bb2010-08-03 21:32:34 +0000308 case ARM::BI__builtin_arm_vcvtr_f:
309 case ARM::BI__builtin_arm_vcvtr_d: i = 1; u = 1; break;
Nate Begemana23326b2010-06-17 04:17:01 +0000310#define GET_NEON_IMMEDIATE_CHECK
311#include "clang/Basic/arm_neon.inc"
312#undef GET_NEON_IMMEDIATE_CHECK
Nate Begeman0d15c532010-06-13 04:47:52 +0000313 };
314
Nate Begeman61eecf52010-06-14 05:21:25 +0000315 // Check that the immediate argument is actually a constant.
Nate Begeman0d15c532010-06-13 04:47:52 +0000316 if (SemaBuiltinConstantArg(TheCall, i, Result))
317 return true;
318
Nate Begeman61eecf52010-06-14 05:21:25 +0000319 // Range check against the upper/lower values for this isntruction.
Nate Begeman0d15c532010-06-13 04:47:52 +0000320 unsigned Val = Result.getZExtValue();
Nate Begeman61eecf52010-06-14 05:21:25 +0000321 if (Val < l || Val > (u + l))
Nate Begeman0d15c532010-06-13 04:47:52 +0000322 return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
Benjamin Kramer476d8b82010-08-11 14:47:12 +0000323 << l << u+l << TheCall->getArg(i)->getSourceRange();
Nate Begeman0d15c532010-06-13 04:47:52 +0000324
Nate Begeman99c40bb2010-08-03 21:32:34 +0000325 // FIXME: VFP Intrinsics should error if VFP not present.
Nate Begeman26a31422010-06-08 02:47:44 +0000326 return false;
Anders Carlssond406bf02009-08-16 01:56:34 +0000327}
Daniel Dunbarde454282008-10-02 18:44:07 +0000328
Anders Carlssond406bf02009-08-16 01:56:34 +0000329/// CheckFunctionCall - Check a direct function call for various correctness
330/// and safety properties not strictly enforced by the C type system.
331bool Sema::CheckFunctionCall(FunctionDecl *FDecl, CallExpr *TheCall) {
332 // Get the IdentifierInfo* for the called function.
333 IdentifierInfo *FnInfo = FDecl->getIdentifier();
334
335 // None of the checks below are needed for functions that don't have
336 // simple names (e.g., C++ conversion functions).
337 if (!FnInfo)
338 return false;
Mike Stump1eb44332009-09-09 15:08:12 +0000339
Daniel Dunbarde454282008-10-02 18:44:07 +0000340 // FIXME: This mechanism should be abstracted to be less fragile and
341 // more efficient. For example, just map function ids to custom
342 // handlers.
343
Chris Lattner59907c42007-08-10 20:18:51 +0000344 // Printf checking.
Argyrios Kyrtzidis40b598e2009-06-30 02:34:44 +0000345 if (const FormatAttr *Format = FDecl->getAttr<FormatAttr>()) {
Ted Kremenek826a3452010-07-16 02:11:22 +0000346 const bool b = Format->getType() == "scanf";
347 if (b || CheckablePrintfAttr(Format, TheCall)) {
Ted Kremenek3d692df2009-02-27 17:58:43 +0000348 bool HasVAListArg = Format->getFirstArg() == 0;
Ted Kremenek826a3452010-07-16 02:11:22 +0000349 CheckPrintfScanfArguments(TheCall, HasVAListArg,
350 Format->getFormatIdx() - 1,
351 HasVAListArg ? 0 : Format->getFirstArg() - 1,
352 !b);
Douglas Gregor3c385e52009-02-14 18:57:46 +0000353 }
Chris Lattner59907c42007-08-10 20:18:51 +0000354 }
Mike Stump1eb44332009-09-09 15:08:12 +0000355
Sean Huntcf807c42010-08-18 23:23:40 +0000356 specific_attr_iterator<NonNullAttr>
357 i = FDecl->specific_attr_begin<NonNullAttr>(),
358 e = FDecl->specific_attr_end<NonNullAttr>();
359
360 for (; i != e; ++i)
361 CheckNonNullArguments(*i, TheCall);
Sebastian Redl0eb23302009-01-19 00:08:26 +0000362
Anders Carlssond406bf02009-08-16 01:56:34 +0000363 return false;
Anders Carlsson71993dd2007-08-17 05:31:46 +0000364}
365
Anders Carlssond406bf02009-08-16 01:56:34 +0000366bool Sema::CheckBlockCall(NamedDecl *NDecl, CallExpr *TheCall) {
Fariborz Jahanian725165f2009-05-18 21:05:18 +0000367 // Printf checking.
Argyrios Kyrtzidis40b598e2009-06-30 02:34:44 +0000368 const FormatAttr *Format = NDecl->getAttr<FormatAttr>();
Fariborz Jahanian725165f2009-05-18 21:05:18 +0000369 if (!Format)
Anders Carlssond406bf02009-08-16 01:56:34 +0000370 return false;
Mike Stump1eb44332009-09-09 15:08:12 +0000371
Fariborz Jahanian725165f2009-05-18 21:05:18 +0000372 const VarDecl *V = dyn_cast<VarDecl>(NDecl);
373 if (!V)
Anders Carlssond406bf02009-08-16 01:56:34 +0000374 return false;
Mike Stump1eb44332009-09-09 15:08:12 +0000375
Fariborz Jahanian725165f2009-05-18 21:05:18 +0000376 QualType Ty = V->getType();
377 if (!Ty->isBlockPointerType())
Anders Carlssond406bf02009-08-16 01:56:34 +0000378 return false;
Mike Stump1eb44332009-09-09 15:08:12 +0000379
Ted Kremenek826a3452010-07-16 02:11:22 +0000380 const bool b = Format->getType() == "scanf";
381 if (!b && !CheckablePrintfAttr(Format, TheCall))
Anders Carlssond406bf02009-08-16 01:56:34 +0000382 return false;
Mike Stump1eb44332009-09-09 15:08:12 +0000383
Anders Carlssond406bf02009-08-16 01:56:34 +0000384 bool HasVAListArg = Format->getFirstArg() == 0;
Ted Kremenek826a3452010-07-16 02:11:22 +0000385 CheckPrintfScanfArguments(TheCall, HasVAListArg, Format->getFormatIdx() - 1,
386 HasVAListArg ? 0 : Format->getFirstArg() - 1, !b);
Anders Carlssond406bf02009-08-16 01:56:34 +0000387
388 return false;
Fariborz Jahanian725165f2009-05-18 21:05:18 +0000389}
390
Chris Lattner5caa3702009-05-08 06:58:22 +0000391/// SemaBuiltinAtomicOverloaded - We have a call to a function like
392/// __sync_fetch_and_add, which is an overloaded function based on the pointer
393/// type of its first argument. The main ActOnCallExpr routines have already
394/// promoted the types of arguments because all of these calls are prototyped as
395/// void(...).
396///
397/// This function goes through and does final semantic checking for these
398/// builtins,
John McCall60d7b3a2010-08-24 06:29:42 +0000399ExprResult
400Sema::SemaBuiltinAtomicOverloaded(ExprResult TheCallResult) {
Chandler Carruthd2014572010-07-09 18:59:35 +0000401 CallExpr *TheCall = (CallExpr *)TheCallResult.get();
Chris Lattner5caa3702009-05-08 06:58:22 +0000402 DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts());
403 FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl());
404
405 // Ensure that we have at least one argument to do type inference from.
Chandler Carruthd2014572010-07-09 18:59:35 +0000406 if (TheCall->getNumArgs() < 1) {
407 Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least)
408 << 0 << 1 << TheCall->getNumArgs()
409 << TheCall->getCallee()->getSourceRange();
410 return ExprError();
411 }
Mike Stump1eb44332009-09-09 15:08:12 +0000412
Chris Lattner5caa3702009-05-08 06:58:22 +0000413 // Inspect the first argument of the atomic builtin. This should always be
414 // a pointer type, whose element is an integral scalar or pointer type.
415 // Because it is a pointer type, we don't have to worry about any implicit
416 // casts here.
Chandler Carruthd2014572010-07-09 18:59:35 +0000417 // FIXME: We don't allow floating point scalars as input.
Chris Lattner5caa3702009-05-08 06:58:22 +0000418 Expr *FirstArg = TheCall->getArg(0);
Chandler Carruthd2014572010-07-09 18:59:35 +0000419 if (!FirstArg->getType()->isPointerType()) {
420 Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer)
421 << FirstArg->getType() << FirstArg->getSourceRange();
422 return ExprError();
423 }
Mike Stump1eb44332009-09-09 15:08:12 +0000424
Chandler Carruthd2014572010-07-09 18:59:35 +0000425 QualType ValType =
426 FirstArg->getType()->getAs<PointerType>()->getPointeeType();
Mike Stump1eb44332009-09-09 15:08:12 +0000427 if (!ValType->isIntegerType() && !ValType->isPointerType() &&
Chandler Carruthd2014572010-07-09 18:59:35 +0000428 !ValType->isBlockPointerType()) {
429 Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer_intptr)
430 << FirstArg->getType() << FirstArg->getSourceRange();
431 return ExprError();
432 }
Chris Lattner5caa3702009-05-08 06:58:22 +0000433
Chandler Carruth8d13d222010-07-18 20:54:12 +0000434 // The majority of builtins return a value, but a few have special return
435 // types, so allow them to override appropriately below.
436 QualType ResultType = ValType;
437
Chris Lattner5caa3702009-05-08 06:58:22 +0000438 // We need to figure out which concrete builtin this maps onto. For example,
439 // __sync_fetch_and_add with a 2 byte object turns into
440 // __sync_fetch_and_add_2.
441#define BUILTIN_ROW(x) \
442 { Builtin::BI##x##_1, Builtin::BI##x##_2, Builtin::BI##x##_4, \
443 Builtin::BI##x##_8, Builtin::BI##x##_16 }
Mike Stump1eb44332009-09-09 15:08:12 +0000444
Chris Lattner5caa3702009-05-08 06:58:22 +0000445 static const unsigned BuiltinIndices[][5] = {
446 BUILTIN_ROW(__sync_fetch_and_add),
447 BUILTIN_ROW(__sync_fetch_and_sub),
448 BUILTIN_ROW(__sync_fetch_and_or),
449 BUILTIN_ROW(__sync_fetch_and_and),
450 BUILTIN_ROW(__sync_fetch_and_xor),
Mike Stump1eb44332009-09-09 15:08:12 +0000451
Chris Lattner5caa3702009-05-08 06:58:22 +0000452 BUILTIN_ROW(__sync_add_and_fetch),
453 BUILTIN_ROW(__sync_sub_and_fetch),
454 BUILTIN_ROW(__sync_and_and_fetch),
455 BUILTIN_ROW(__sync_or_and_fetch),
456 BUILTIN_ROW(__sync_xor_and_fetch),
Mike Stump1eb44332009-09-09 15:08:12 +0000457
Chris Lattner5caa3702009-05-08 06:58:22 +0000458 BUILTIN_ROW(__sync_val_compare_and_swap),
459 BUILTIN_ROW(__sync_bool_compare_and_swap),
460 BUILTIN_ROW(__sync_lock_test_and_set),
461 BUILTIN_ROW(__sync_lock_release)
462 };
Mike Stump1eb44332009-09-09 15:08:12 +0000463#undef BUILTIN_ROW
464
Chris Lattner5caa3702009-05-08 06:58:22 +0000465 // Determine the index of the size.
466 unsigned SizeIndex;
Ken Dyck199c3d62010-01-11 17:06:35 +0000467 switch (Context.getTypeSizeInChars(ValType).getQuantity()) {
Chris Lattner5caa3702009-05-08 06:58:22 +0000468 case 1: SizeIndex = 0; break;
469 case 2: SizeIndex = 1; break;
470 case 4: SizeIndex = 2; break;
471 case 8: SizeIndex = 3; break;
472 case 16: SizeIndex = 4; break;
473 default:
Chandler Carruthd2014572010-07-09 18:59:35 +0000474 Diag(DRE->getLocStart(), diag::err_atomic_builtin_pointer_size)
475 << FirstArg->getType() << FirstArg->getSourceRange();
476 return ExprError();
Chris Lattner5caa3702009-05-08 06:58:22 +0000477 }
Mike Stump1eb44332009-09-09 15:08:12 +0000478
Chris Lattner5caa3702009-05-08 06:58:22 +0000479 // Each of these builtins has one pointer argument, followed by some number of
480 // values (0, 1 or 2) followed by a potentially empty varags list of stuff
481 // that we ignore. Find out which row of BuiltinIndices to read from as well
482 // as the number of fixed args.
Douglas Gregor7814e6d2009-09-12 00:22:50 +0000483 unsigned BuiltinID = FDecl->getBuiltinID();
Chris Lattner5caa3702009-05-08 06:58:22 +0000484 unsigned BuiltinIndex, NumFixed = 1;
485 switch (BuiltinID) {
486 default: assert(0 && "Unknown overloaded atomic builtin!");
487 case Builtin::BI__sync_fetch_and_add: BuiltinIndex = 0; break;
488 case Builtin::BI__sync_fetch_and_sub: BuiltinIndex = 1; break;
489 case Builtin::BI__sync_fetch_and_or: BuiltinIndex = 2; break;
490 case Builtin::BI__sync_fetch_and_and: BuiltinIndex = 3; break;
491 case Builtin::BI__sync_fetch_and_xor: BuiltinIndex = 4; break;
Mike Stump1eb44332009-09-09 15:08:12 +0000492
Daniel Dunbar7eff7c42010-03-25 17:13:09 +0000493 case Builtin::BI__sync_add_and_fetch: BuiltinIndex = 5; break;
494 case Builtin::BI__sync_sub_and_fetch: BuiltinIndex = 6; break;
495 case Builtin::BI__sync_and_and_fetch: BuiltinIndex = 7; break;
496 case Builtin::BI__sync_or_and_fetch: BuiltinIndex = 8; break;
497 case Builtin::BI__sync_xor_and_fetch: BuiltinIndex = 9; break;
Mike Stump1eb44332009-09-09 15:08:12 +0000498
Chris Lattner5caa3702009-05-08 06:58:22 +0000499 case Builtin::BI__sync_val_compare_and_swap:
Daniel Dunbar7eff7c42010-03-25 17:13:09 +0000500 BuiltinIndex = 10;
Chris Lattner5caa3702009-05-08 06:58:22 +0000501 NumFixed = 2;
502 break;
503 case Builtin::BI__sync_bool_compare_and_swap:
Daniel Dunbar7eff7c42010-03-25 17:13:09 +0000504 BuiltinIndex = 11;
Chris Lattner5caa3702009-05-08 06:58:22 +0000505 NumFixed = 2;
Chandler Carruth8d13d222010-07-18 20:54:12 +0000506 ResultType = Context.BoolTy;
Chris Lattner5caa3702009-05-08 06:58:22 +0000507 break;
Daniel Dunbar7eff7c42010-03-25 17:13:09 +0000508 case Builtin::BI__sync_lock_test_and_set: BuiltinIndex = 12; break;
Chris Lattner5caa3702009-05-08 06:58:22 +0000509 case Builtin::BI__sync_lock_release:
Daniel Dunbar7eff7c42010-03-25 17:13:09 +0000510 BuiltinIndex = 13;
Chris Lattner5caa3702009-05-08 06:58:22 +0000511 NumFixed = 0;
Chandler Carruth8d13d222010-07-18 20:54:12 +0000512 ResultType = Context.VoidTy;
Chris Lattner5caa3702009-05-08 06:58:22 +0000513 break;
514 }
Mike Stump1eb44332009-09-09 15:08:12 +0000515
Chris Lattner5caa3702009-05-08 06:58:22 +0000516 // Now that we know how many fixed arguments we expect, first check that we
517 // have at least that many.
Chandler Carruthd2014572010-07-09 18:59:35 +0000518 if (TheCall->getNumArgs() < 1+NumFixed) {
519 Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least)
520 << 0 << 1+NumFixed << TheCall->getNumArgs()
521 << TheCall->getCallee()->getSourceRange();
522 return ExprError();
523 }
Mike Stump1eb44332009-09-09 15:08:12 +0000524
Chris Lattnere7ac0a92009-05-08 15:36:58 +0000525 // Get the decl for the concrete builtin from this, we can tell what the
526 // concrete integer type we should convert to is.
527 unsigned NewBuiltinID = BuiltinIndices[BuiltinIndex][SizeIndex];
528 const char *NewBuiltinName = Context.BuiltinInfo.GetName(NewBuiltinID);
529 IdentifierInfo *NewBuiltinII = PP.getIdentifierInfo(NewBuiltinName);
Mike Stump1eb44332009-09-09 15:08:12 +0000530 FunctionDecl *NewBuiltinDecl =
Chris Lattnere7ac0a92009-05-08 15:36:58 +0000531 cast<FunctionDecl>(LazilyCreateBuiltin(NewBuiltinII, NewBuiltinID,
532 TUScope, false, DRE->getLocStart()));
Chandler Carruthd2014572010-07-09 18:59:35 +0000533
John McCallf871d0c2010-08-07 06:22:56 +0000534 // The first argument --- the pointer --- has a fixed type; we
535 // deduce the types of the rest of the arguments accordingly. Walk
536 // the remaining arguments, converting them to the deduced value type.
Chris Lattner5caa3702009-05-08 06:58:22 +0000537 for (unsigned i = 0; i != NumFixed; ++i) {
538 Expr *Arg = TheCall->getArg(i+1);
Mike Stump1eb44332009-09-09 15:08:12 +0000539
Chris Lattner5caa3702009-05-08 06:58:22 +0000540 // If the argument is an implicit cast, then there was a promotion due to
541 // "...", just remove it now.
542 if (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Arg)) {
543 Arg = ICE->getSubExpr();
544 ICE->setSubExpr(0);
Chris Lattner5caa3702009-05-08 06:58:22 +0000545 TheCall->setArg(i+1, Arg);
546 }
Mike Stump1eb44332009-09-09 15:08:12 +0000547
Chris Lattner5caa3702009-05-08 06:58:22 +0000548 // GCC does an implicit conversion to the pointer or integer ValType. This
549 // can fail in some cases (1i -> int**), check for this error case now.
John McCall2de56d12010-08-25 11:45:40 +0000550 CastKind Kind = CK_Unknown;
John McCallf871d0c2010-08-07 06:22:56 +0000551 CXXCastPath BasePath;
Anders Carlsson5cf86ba2010-04-24 19:06:50 +0000552 if (CheckCastTypes(Arg->getSourceRange(), ValType, Arg, Kind, BasePath))
Chandler Carruthd2014572010-07-09 18:59:35 +0000553 return ExprError();
Mike Stump1eb44332009-09-09 15:08:12 +0000554
Chris Lattner5caa3702009-05-08 06:58:22 +0000555 // Okay, we have something that *can* be converted to the right type. Check
556 // to see if there is a potentially weird extension going on here. This can
557 // happen when you do an atomic operation on something like an char* and
558 // pass in 42. The 42 gets converted to char. This is even more strange
559 // for things like 45.123 -> char, etc.
Mike Stump1eb44332009-09-09 15:08:12 +0000560 // FIXME: Do this check.
John McCall5baba9d2010-08-25 10:28:54 +0000561 ImpCastExprToType(Arg, ValType, Kind, VK_RValue, &BasePath);
Chris Lattner5caa3702009-05-08 06:58:22 +0000562 TheCall->setArg(i+1, Arg);
563 }
Mike Stump1eb44332009-09-09 15:08:12 +0000564
Chris Lattner5caa3702009-05-08 06:58:22 +0000565 // Switch the DeclRefExpr to refer to the new decl.
566 DRE->setDecl(NewBuiltinDecl);
567 DRE->setType(NewBuiltinDecl->getType());
Mike Stump1eb44332009-09-09 15:08:12 +0000568
Chris Lattner5caa3702009-05-08 06:58:22 +0000569 // Set the callee in the CallExpr.
570 // FIXME: This leaks the original parens and implicit casts.
571 Expr *PromotedCall = DRE;
572 UsualUnaryConversions(PromotedCall);
573 TheCall->setCallee(PromotedCall);
Mike Stump1eb44332009-09-09 15:08:12 +0000574
Chandler Carruthdb4325b2010-07-18 07:23:17 +0000575 // Change the result type of the call to match the original value type. This
576 // is arbitrary, but the codegen for these builtins ins design to handle it
577 // gracefully.
Chandler Carruth8d13d222010-07-18 20:54:12 +0000578 TheCall->setType(ResultType);
Chandler Carruthd2014572010-07-09 18:59:35 +0000579
580 return move(TheCallResult);
Chris Lattner5caa3702009-05-08 06:58:22 +0000581}
582
583
Chris Lattner69039812009-02-18 06:01:06 +0000584/// CheckObjCString - Checks that the argument to the builtin
Anders Carlsson71993dd2007-08-17 05:31:46 +0000585/// CFString constructor is correct
Steve Narofffd942622009-04-13 20:26:29 +0000586/// Note: It might also make sense to do the UTF-16 conversion here (would
587/// simplify the backend).
Chris Lattner69039812009-02-18 06:01:06 +0000588bool Sema::CheckObjCString(Expr *Arg) {
Chris Lattner56f34942008-02-13 01:02:39 +0000589 Arg = Arg->IgnoreParenCasts();
Anders Carlsson71993dd2007-08-17 05:31:46 +0000590 StringLiteral *Literal = dyn_cast<StringLiteral>(Arg);
591
592 if (!Literal || Literal->isWide()) {
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000593 Diag(Arg->getLocStart(), diag::err_cfstring_literal_not_string_constant)
594 << Arg->getSourceRange();
Anders Carlsson9cdc4d32007-08-17 15:44:17 +0000595 return true;
Anders Carlsson71993dd2007-08-17 05:31:46 +0000596 }
Mike Stump1eb44332009-09-09 15:08:12 +0000597
Benjamin Kramer2f4eaef2010-08-17 12:54:38 +0000598 size_t NulPos = Literal->getString().find('\0');
599 if (NulPos != llvm::StringRef::npos) {
600 Diag(getLocationOfStringLiteralByte(Literal, NulPos),
601 diag::warn_cfstring_literal_contains_nul_character)
602 << Arg->getSourceRange();
Daniel Dunbarf015b032009-09-22 10:03:52 +0000603 }
Fariborz Jahanian7da71022010-09-07 19:38:13 +0000604 if (Literal->containsNonAsciiOrNull()) {
605 llvm::StringRef String = Literal->getString();
606 unsigned NumBytes = String.size();
607 llvm::SmallVector<UTF16, 128> ToBuf(NumBytes);
608 const UTF8 *FromPtr = (UTF8 *)String.data();
609 UTF16 *ToPtr = &ToBuf[0];
610
611 ConversionResult Result = ConvertUTF8toUTF16(&FromPtr, FromPtr + NumBytes,
612 &ToPtr, ToPtr + NumBytes,
613 strictConversion);
614 // Check for conversion failure.
615 if (Result != conversionOK)
616 Diag(Arg->getLocStart(),
617 diag::warn_cfstring_truncated) << Arg->getSourceRange();
618 }
Anders Carlsson9cdc4d32007-08-17 15:44:17 +0000619 return false;
Chris Lattner59907c42007-08-10 20:18:51 +0000620}
621
Chris Lattnerc27c6652007-12-20 00:05:45 +0000622/// SemaBuiltinVAStart - Check the arguments to __builtin_va_start for validity.
623/// Emit an error and return true on failure, return false on success.
Chris Lattner925e60d2007-12-28 05:29:59 +0000624bool Sema::SemaBuiltinVAStart(CallExpr *TheCall) {
625 Expr *Fn = TheCall->getCallee();
626 if (TheCall->getNumArgs() > 2) {
Chris Lattner2c21a072008-11-21 18:44:24 +0000627 Diag(TheCall->getArg(2)->getLocStart(),
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000628 diag::err_typecheck_call_too_many_args)
Eric Christopherccfa9632010-04-16 04:56:46 +0000629 << 0 /*function call*/ << 2 << TheCall->getNumArgs()
630 << Fn->getSourceRange()
Mike Stump1eb44332009-09-09 15:08:12 +0000631 << SourceRange(TheCall->getArg(2)->getLocStart(),
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000632 (*(TheCall->arg_end()-1))->getLocEnd());
Chris Lattner30ce3442007-12-19 23:59:04 +0000633 return true;
634 }
Eli Friedman56f20ae2008-12-15 22:05:35 +0000635
636 if (TheCall->getNumArgs() < 2) {
Eric Christopherd77b9a22010-04-16 04:48:22 +0000637 return Diag(TheCall->getLocEnd(),
638 diag::err_typecheck_call_too_few_args_at_least)
639 << 0 /*function call*/ << 2 << TheCall->getNumArgs();
Eli Friedman56f20ae2008-12-15 22:05:35 +0000640 }
641
Chris Lattnerc27c6652007-12-20 00:05:45 +0000642 // Determine whether the current function is variadic or not.
Douglas Gregor9ea9bdb2010-03-01 23:15:13 +0000643 BlockScopeInfo *CurBlock = getCurBlock();
Chris Lattnerc27c6652007-12-20 00:05:45 +0000644 bool isVariadic;
Steve Naroffcd9c5142009-04-15 19:33:47 +0000645 if (CurBlock)
John McCallc71a4912010-06-04 19:02:56 +0000646 isVariadic = CurBlock->TheDecl->isVariadic();
Ted Kremenek9498d382010-04-29 16:49:01 +0000647 else if (FunctionDecl *FD = getCurFunctionDecl())
648 isVariadic = FD->isVariadic();
649 else
Argyrios Kyrtzidis53d0ea52008-06-28 06:07:14 +0000650 isVariadic = getCurMethodDecl()->isVariadic();
Mike Stump1eb44332009-09-09 15:08:12 +0000651
Chris Lattnerc27c6652007-12-20 00:05:45 +0000652 if (!isVariadic) {
Chris Lattner30ce3442007-12-19 23:59:04 +0000653 Diag(Fn->getLocStart(), diag::err_va_start_used_in_non_variadic_function);
654 return true;
655 }
Mike Stump1eb44332009-09-09 15:08:12 +0000656
Chris Lattner30ce3442007-12-19 23:59:04 +0000657 // Verify that the second argument to the builtin is the last argument of the
658 // current function or method.
659 bool SecondArgIsLastNamedArgument = false;
Anders Carlssone2c14102008-02-13 01:22:59 +0000660 const Expr *Arg = TheCall->getArg(1)->IgnoreParenCasts();
Mike Stump1eb44332009-09-09 15:08:12 +0000661
Anders Carlsson88cf2262008-02-11 04:20:54 +0000662 if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Arg)) {
663 if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(DR->getDecl())) {
Chris Lattner30ce3442007-12-19 23:59:04 +0000664 // FIXME: This isn't correct for methods (results in bogus warning).
665 // Get the last formal in the current function.
Anders Carlsson88cf2262008-02-11 04:20:54 +0000666 const ParmVarDecl *LastArg;
Steve Naroffcd9c5142009-04-15 19:33:47 +0000667 if (CurBlock)
668 LastArg = *(CurBlock->TheDecl->param_end()-1);
669 else if (FunctionDecl *FD = getCurFunctionDecl())
Chris Lattner371f2582008-12-04 23:50:19 +0000670 LastArg = *(FD->param_end()-1);
Chris Lattner30ce3442007-12-19 23:59:04 +0000671 else
Argyrios Kyrtzidis53d0ea52008-06-28 06:07:14 +0000672 LastArg = *(getCurMethodDecl()->param_end()-1);
Chris Lattner30ce3442007-12-19 23:59:04 +0000673 SecondArgIsLastNamedArgument = PV == LastArg;
674 }
675 }
Mike Stump1eb44332009-09-09 15:08:12 +0000676
Chris Lattner30ce3442007-12-19 23:59:04 +0000677 if (!SecondArgIsLastNamedArgument)
Mike Stump1eb44332009-09-09 15:08:12 +0000678 Diag(TheCall->getArg(1)->getLocStart(),
Chris Lattner30ce3442007-12-19 23:59:04 +0000679 diag::warn_second_parameter_of_va_start_not_last_named_argument);
680 return false;
Eli Friedman6cfda232008-05-20 08:23:37 +0000681}
Chris Lattner30ce3442007-12-19 23:59:04 +0000682
Chris Lattner1b9a0792007-12-20 00:26:33 +0000683/// SemaBuiltinUnorderedCompare - Handle functions like __builtin_isgreater and
684/// friends. This is declared to take (...), so we have to check everything.
Chris Lattner925e60d2007-12-28 05:29:59 +0000685bool Sema::SemaBuiltinUnorderedCompare(CallExpr *TheCall) {
686 if (TheCall->getNumArgs() < 2)
Chris Lattner2c21a072008-11-21 18:44:24 +0000687 return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args)
Eric Christopherd77b9a22010-04-16 04:48:22 +0000688 << 0 << 2 << TheCall->getNumArgs()/*function call*/;
Chris Lattner925e60d2007-12-28 05:29:59 +0000689 if (TheCall->getNumArgs() > 2)
Mike Stump1eb44332009-09-09 15:08:12 +0000690 return Diag(TheCall->getArg(2)->getLocStart(),
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000691 diag::err_typecheck_call_too_many_args)
Eric Christopherccfa9632010-04-16 04:56:46 +0000692 << 0 /*function call*/ << 2 << TheCall->getNumArgs()
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000693 << SourceRange(TheCall->getArg(2)->getLocStart(),
694 (*(TheCall->arg_end()-1))->getLocEnd());
Mike Stump1eb44332009-09-09 15:08:12 +0000695
Chris Lattner925e60d2007-12-28 05:29:59 +0000696 Expr *OrigArg0 = TheCall->getArg(0);
697 Expr *OrigArg1 = TheCall->getArg(1);
Douglas Gregorcde01732009-05-19 22:10:17 +0000698
Chris Lattner1b9a0792007-12-20 00:26:33 +0000699 // Do standard promotions between the two arguments, returning their common
700 // type.
Chris Lattner925e60d2007-12-28 05:29:59 +0000701 QualType Res = UsualArithmeticConversions(OrigArg0, OrigArg1, false);
Daniel Dunbar403bc2b2009-02-19 19:28:43 +0000702
703 // Make sure any conversions are pushed back into the call; this is
704 // type safe since unordered compare builtins are declared as "_Bool
705 // foo(...)".
706 TheCall->setArg(0, OrigArg0);
707 TheCall->setArg(1, OrigArg1);
Mike Stump1eb44332009-09-09 15:08:12 +0000708
Douglas Gregorcde01732009-05-19 22:10:17 +0000709 if (OrigArg0->isTypeDependent() || OrigArg1->isTypeDependent())
710 return false;
711
Chris Lattner1b9a0792007-12-20 00:26:33 +0000712 // If the common type isn't a real floating type, then the arguments were
713 // invalid for this operation.
714 if (!Res->isRealFloatingType())
Mike Stump1eb44332009-09-09 15:08:12 +0000715 return Diag(OrigArg0->getLocStart(),
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000716 diag::err_typecheck_call_invalid_ordered_compare)
Chris Lattnerd1625842008-11-24 06:25:27 +0000717 << OrigArg0->getType() << OrigArg1->getType()
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000718 << SourceRange(OrigArg0->getLocStart(), OrigArg1->getLocEnd());
Mike Stump1eb44332009-09-09 15:08:12 +0000719
Chris Lattner1b9a0792007-12-20 00:26:33 +0000720 return false;
721}
722
Benjamin Kramere771a7a2010-02-15 22:42:31 +0000723/// SemaBuiltinSemaBuiltinFPClassification - Handle functions like
724/// __builtin_isnan and friends. This is declared to take (...), so we have
Benjamin Kramer3b1e26b2010-02-16 10:07:31 +0000725/// to check everything. We expect the last argument to be a floating point
726/// value.
727bool Sema::SemaBuiltinFPClassification(CallExpr *TheCall, unsigned NumArgs) {
728 if (TheCall->getNumArgs() < NumArgs)
Eli Friedman9ac6f622009-08-31 20:06:00 +0000729 return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args)
Eric Christopherd77b9a22010-04-16 04:48:22 +0000730 << 0 << NumArgs << TheCall->getNumArgs()/*function call*/;
Benjamin Kramer3b1e26b2010-02-16 10:07:31 +0000731 if (TheCall->getNumArgs() > NumArgs)
732 return Diag(TheCall->getArg(NumArgs)->getLocStart(),
Eli Friedman9ac6f622009-08-31 20:06:00 +0000733 diag::err_typecheck_call_too_many_args)
Eric Christopherccfa9632010-04-16 04:56:46 +0000734 << 0 /*function call*/ << NumArgs << TheCall->getNumArgs()
Benjamin Kramer3b1e26b2010-02-16 10:07:31 +0000735 << SourceRange(TheCall->getArg(NumArgs)->getLocStart(),
Eli Friedman9ac6f622009-08-31 20:06:00 +0000736 (*(TheCall->arg_end()-1))->getLocEnd());
737
Benjamin Kramer3b1e26b2010-02-16 10:07:31 +0000738 Expr *OrigArg = TheCall->getArg(NumArgs-1);
Mike Stump1eb44332009-09-09 15:08:12 +0000739
Eli Friedman9ac6f622009-08-31 20:06:00 +0000740 if (OrigArg->isTypeDependent())
741 return false;
742
Chris Lattner81368fb2010-05-06 05:50:07 +0000743 // This operation requires a non-_Complex floating-point number.
Eli Friedman9ac6f622009-08-31 20:06:00 +0000744 if (!OrigArg->getType()->isRealFloatingType())
Mike Stump1eb44332009-09-09 15:08:12 +0000745 return Diag(OrigArg->getLocStart(),
Eli Friedman9ac6f622009-08-31 20:06:00 +0000746 diag::err_typecheck_call_invalid_unary_fp)
747 << OrigArg->getType() << OrigArg->getSourceRange();
Mike Stump1eb44332009-09-09 15:08:12 +0000748
Chris Lattner81368fb2010-05-06 05:50:07 +0000749 // If this is an implicit conversion from float -> double, remove it.
750 if (ImplicitCastExpr *Cast = dyn_cast<ImplicitCastExpr>(OrigArg)) {
751 Expr *CastArg = Cast->getSubExpr();
752 if (CastArg->getType()->isSpecificBuiltinType(BuiltinType::Float)) {
753 assert(Cast->getType()->isSpecificBuiltinType(BuiltinType::Double) &&
754 "promotion from float to double is the only expected cast here");
755 Cast->setSubExpr(0);
Chris Lattner81368fb2010-05-06 05:50:07 +0000756 TheCall->setArg(NumArgs-1, CastArg);
757 OrigArg = CastArg;
758 }
759 }
760
Eli Friedman9ac6f622009-08-31 20:06:00 +0000761 return false;
762}
763
Eli Friedmand38617c2008-05-14 19:38:39 +0000764/// SemaBuiltinShuffleVector - Handle __builtin_shufflevector.
765// This is declared to take (...), so we have to check everything.
John McCall60d7b3a2010-08-24 06:29:42 +0000766ExprResult Sema::SemaBuiltinShuffleVector(CallExpr *TheCall) {
Nate Begeman37b6a572010-06-08 00:16:34 +0000767 if (TheCall->getNumArgs() < 2)
Sebastian Redl0eb23302009-01-19 00:08:26 +0000768 return ExprError(Diag(TheCall->getLocEnd(),
Eric Christopherd77b9a22010-04-16 04:48:22 +0000769 diag::err_typecheck_call_too_few_args_at_least)
Nate Begeman37b6a572010-06-08 00:16:34 +0000770 << 0 /*function call*/ << 2 << TheCall->getNumArgs()
Eric Christopherd77b9a22010-04-16 04:48:22 +0000771 << TheCall->getSourceRange());
Eli Friedmand38617c2008-05-14 19:38:39 +0000772
Nate Begeman37b6a572010-06-08 00:16:34 +0000773 // Determine which of the following types of shufflevector we're checking:
774 // 1) unary, vector mask: (lhs, mask)
775 // 2) binary, vector mask: (lhs, rhs, mask)
776 // 3) binary, scalar mask: (lhs, rhs, index, ..., index)
777 QualType resType = TheCall->getArg(0)->getType();
778 unsigned numElements = 0;
779
Douglas Gregorcde01732009-05-19 22:10:17 +0000780 if (!TheCall->getArg(0)->isTypeDependent() &&
781 !TheCall->getArg(1)->isTypeDependent()) {
Nate Begeman37b6a572010-06-08 00:16:34 +0000782 QualType LHSType = TheCall->getArg(0)->getType();
783 QualType RHSType = TheCall->getArg(1)->getType();
784
785 if (!LHSType->isVectorType() || !RHSType->isVectorType()) {
Douglas Gregorcde01732009-05-19 22:10:17 +0000786 Diag(TheCall->getLocStart(), diag::err_shufflevector_non_vector)
Mike Stump1eb44332009-09-09 15:08:12 +0000787 << SourceRange(TheCall->getArg(0)->getLocStart(),
Douglas Gregorcde01732009-05-19 22:10:17 +0000788 TheCall->getArg(1)->getLocEnd());
789 return ExprError();
790 }
Nate Begeman37b6a572010-06-08 00:16:34 +0000791
792 numElements = LHSType->getAs<VectorType>()->getNumElements();
793 unsigned numResElements = TheCall->getNumArgs() - 2;
Mike Stump1eb44332009-09-09 15:08:12 +0000794
Nate Begeman37b6a572010-06-08 00:16:34 +0000795 // Check to see if we have a call with 2 vector arguments, the unary shuffle
796 // with mask. If so, verify that RHS is an integer vector type with the
797 // same number of elts as lhs.
798 if (TheCall->getNumArgs() == 2) {
Douglas Gregorf6094622010-07-23 15:58:24 +0000799 if (!RHSType->hasIntegerRepresentation() ||
Nate Begeman37b6a572010-06-08 00:16:34 +0000800 RHSType->getAs<VectorType>()->getNumElements() != numElements)
801 Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector)
802 << SourceRange(TheCall->getArg(1)->getLocStart(),
803 TheCall->getArg(1)->getLocEnd());
804 numResElements = numElements;
805 }
806 else if (!Context.hasSameUnqualifiedType(LHSType, RHSType)) {
Douglas Gregorcde01732009-05-19 22:10:17 +0000807 Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector)
Mike Stump1eb44332009-09-09 15:08:12 +0000808 << SourceRange(TheCall->getArg(0)->getLocStart(),
Douglas Gregorcde01732009-05-19 22:10:17 +0000809 TheCall->getArg(1)->getLocEnd());
810 return ExprError();
Nate Begeman37b6a572010-06-08 00:16:34 +0000811 } else if (numElements != numResElements) {
812 QualType eltType = LHSType->getAs<VectorType>()->getElementType();
Chris Lattner788b0fd2010-06-23 06:00:24 +0000813 resType = Context.getVectorType(eltType, numResElements,
814 VectorType::NotAltiVec);
Douglas Gregorcde01732009-05-19 22:10:17 +0000815 }
Eli Friedmand38617c2008-05-14 19:38:39 +0000816 }
817
818 for (unsigned i = 2; i < TheCall->getNumArgs(); i++) {
Douglas Gregorcde01732009-05-19 22:10:17 +0000819 if (TheCall->getArg(i)->isTypeDependent() ||
820 TheCall->getArg(i)->isValueDependent())
821 continue;
822
Nate Begeman37b6a572010-06-08 00:16:34 +0000823 llvm::APSInt Result(32);
824 if (!TheCall->getArg(i)->isIntegerConstantExpr(Result, Context))
825 return ExprError(Diag(TheCall->getLocStart(),
826 diag::err_shufflevector_nonconstant_argument)
827 << TheCall->getArg(i)->getSourceRange());
Sebastian Redl0eb23302009-01-19 00:08:26 +0000828
Chris Lattnerd1a0b6d2008-08-10 02:05:13 +0000829 if (Result.getActiveBits() > 64 || Result.getZExtValue() >= numElements*2)
Sebastian Redl0eb23302009-01-19 00:08:26 +0000830 return ExprError(Diag(TheCall->getLocStart(),
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000831 diag::err_shufflevector_argument_too_large)
Sebastian Redl0eb23302009-01-19 00:08:26 +0000832 << TheCall->getArg(i)->getSourceRange());
Eli Friedmand38617c2008-05-14 19:38:39 +0000833 }
834
835 llvm::SmallVector<Expr*, 32> exprs;
836
Chris Lattnerd1a0b6d2008-08-10 02:05:13 +0000837 for (unsigned i = 0, e = TheCall->getNumArgs(); i != e; i++) {
Eli Friedmand38617c2008-05-14 19:38:39 +0000838 exprs.push_back(TheCall->getArg(i));
839 TheCall->setArg(i, 0);
840 }
841
Nate Begemana88dc302009-08-12 02:10:25 +0000842 return Owned(new (Context) ShuffleVectorExpr(Context, exprs.begin(),
Nate Begeman37b6a572010-06-08 00:16:34 +0000843 exprs.size(), resType,
Ted Kremenek8189cde2009-02-07 01:47:29 +0000844 TheCall->getCallee()->getLocStart(),
845 TheCall->getRParenLoc()));
Eli Friedmand38617c2008-05-14 19:38:39 +0000846}
Chris Lattner30ce3442007-12-19 23:59:04 +0000847
Daniel Dunbar4493f792008-07-21 22:59:13 +0000848/// SemaBuiltinPrefetch - Handle __builtin_prefetch.
849// This is declared to take (const void*, ...) and can take two
850// optional constant int args.
851bool Sema::SemaBuiltinPrefetch(CallExpr *TheCall) {
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000852 unsigned NumArgs = TheCall->getNumArgs();
Daniel Dunbar4493f792008-07-21 22:59:13 +0000853
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000854 if (NumArgs > 3)
Eric Christopherccfa9632010-04-16 04:56:46 +0000855 return Diag(TheCall->getLocEnd(),
856 diag::err_typecheck_call_too_many_args_at_most)
857 << 0 /*function call*/ << 3 << NumArgs
858 << TheCall->getSourceRange();
Daniel Dunbar4493f792008-07-21 22:59:13 +0000859
860 // Argument 0 is checked for us and the remaining arguments must be
861 // constant integers.
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000862 for (unsigned i = 1; i != NumArgs; ++i) {
Daniel Dunbar4493f792008-07-21 22:59:13 +0000863 Expr *Arg = TheCall->getArg(i);
Eric Christopher691ebc32010-04-17 02:26:23 +0000864
Eli Friedman9aef7262009-12-04 00:30:06 +0000865 llvm::APSInt Result;
Eric Christopher691ebc32010-04-17 02:26:23 +0000866 if (SemaBuiltinConstantArg(TheCall, i, Result))
867 return true;
Mike Stump1eb44332009-09-09 15:08:12 +0000868
Daniel Dunbar4493f792008-07-21 22:59:13 +0000869 // FIXME: gcc issues a warning and rewrites these to 0. These
870 // seems especially odd for the third argument since the default
871 // is 3.
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000872 if (i == 1) {
Eli Friedman9aef7262009-12-04 00:30:06 +0000873 if (Result.getLimitedValue() > 1)
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000874 return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
Chris Lattner21fb98e2009-09-23 06:06:36 +0000875 << "0" << "1" << Arg->getSourceRange();
Daniel Dunbar4493f792008-07-21 22:59:13 +0000876 } else {
Eli Friedman9aef7262009-12-04 00:30:06 +0000877 if (Result.getLimitedValue() > 3)
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000878 return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
Chris Lattner21fb98e2009-09-23 06:06:36 +0000879 << "0" << "3" << Arg->getSourceRange();
Daniel Dunbar4493f792008-07-21 22:59:13 +0000880 }
881 }
882
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000883 return false;
Daniel Dunbar4493f792008-07-21 22:59:13 +0000884}
885
Eric Christopher691ebc32010-04-17 02:26:23 +0000886/// SemaBuiltinConstantArg - Handle a check if argument ArgNum of CallExpr
887/// TheCall is a constant expression.
888bool Sema::SemaBuiltinConstantArg(CallExpr *TheCall, int ArgNum,
889 llvm::APSInt &Result) {
890 Expr *Arg = TheCall->getArg(ArgNum);
891 DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts());
892 FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl());
893
894 if (Arg->isTypeDependent() || Arg->isValueDependent()) return false;
895
896 if (!Arg->isIntegerConstantExpr(Result, Context))
897 return Diag(TheCall->getLocStart(), diag::err_constant_integer_arg_type)
Eric Christopher5e896552010-04-19 18:23:02 +0000898 << FDecl->getDeclName() << Arg->getSourceRange();
Eric Christopher691ebc32010-04-17 02:26:23 +0000899
Chris Lattner21fb98e2009-09-23 06:06:36 +0000900 return false;
901}
902
Daniel Dunbard5f8a4f2008-09-03 21:13:56 +0000903/// SemaBuiltinObjectSize - Handle __builtin_object_size(void *ptr,
904/// int type). This simply type checks that type is one of the defined
905/// constants (0-3).
Eric Christopherfee667f2009-12-23 03:49:37 +0000906// For compatability check 0-3, llvm only handles 0 and 2.
Daniel Dunbard5f8a4f2008-09-03 21:13:56 +0000907bool Sema::SemaBuiltinObjectSize(CallExpr *TheCall) {
Eric Christopher691ebc32010-04-17 02:26:23 +0000908 llvm::APSInt Result;
909
910 // Check constant-ness first.
911 if (SemaBuiltinConstantArg(TheCall, 1, Result))
912 return true;
913
Daniel Dunbard5f8a4f2008-09-03 21:13:56 +0000914 Expr *Arg = TheCall->getArg(1);
Daniel Dunbard5f8a4f2008-09-03 21:13:56 +0000915 if (Result.getSExtValue() < 0 || Result.getSExtValue() > 3) {
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000916 return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
917 << "0" << "3" << SourceRange(Arg->getLocStart(), Arg->getLocEnd());
Daniel Dunbard5f8a4f2008-09-03 21:13:56 +0000918 }
919
920 return false;
921}
922
Eli Friedman586d6a82009-05-03 06:04:26 +0000923/// SemaBuiltinLongjmp - Handle __builtin_longjmp(void *env[5], int val).
Eli Friedmand875fed2009-05-03 04:46:36 +0000924/// This checks that val is a constant 1.
925bool Sema::SemaBuiltinLongjmp(CallExpr *TheCall) {
926 Expr *Arg = TheCall->getArg(1);
Eric Christopher691ebc32010-04-17 02:26:23 +0000927 llvm::APSInt Result;
Douglas Gregorcde01732009-05-19 22:10:17 +0000928
Eric Christopher691ebc32010-04-17 02:26:23 +0000929 // TODO: This is less than ideal. Overload this to take a value.
930 if (SemaBuiltinConstantArg(TheCall, 1, Result))
931 return true;
932
933 if (Result != 1)
Eli Friedmand875fed2009-05-03 04:46:36 +0000934 return Diag(TheCall->getLocStart(), diag::err_builtin_longjmp_invalid_val)
935 << SourceRange(Arg->getLocStart(), Arg->getLocEnd());
936
937 return false;
938}
939
Ted Kremenekd30ef872009-01-12 23:09:09 +0000940// Handle i > 1 ? "x" : "y", recursivelly
Ted Kremenek082d9362009-03-20 21:35:28 +0000941bool Sema::SemaCheckStringLiteral(const Expr *E, const CallExpr *TheCall,
942 bool HasVAListArg,
Ted Kremenek826a3452010-07-16 02:11:22 +0000943 unsigned format_idx, unsigned firstDataArg,
944 bool isPrintf) {
945
Douglas Gregorcde01732009-05-19 22:10:17 +0000946 if (E->isTypeDependent() || E->isValueDependent())
947 return false;
Ted Kremenekd30ef872009-01-12 23:09:09 +0000948
949 switch (E->getStmtClass()) {
950 case Stmt::ConditionalOperatorClass: {
Ted Kremenek082d9362009-03-20 21:35:28 +0000951 const ConditionalOperator *C = cast<ConditionalOperator>(E);
Ted Kremenek826a3452010-07-16 02:11:22 +0000952 return SemaCheckStringLiteral(C->getTrueExpr(), TheCall, HasVAListArg,
953 format_idx, firstDataArg, isPrintf)
954 && SemaCheckStringLiteral(C->getRHS(), TheCall, HasVAListArg,
955 format_idx, firstDataArg, isPrintf);
Ted Kremenekd30ef872009-01-12 23:09:09 +0000956 }
957
958 case Stmt::ImplicitCastExprClass: {
Ted Kremenek082d9362009-03-20 21:35:28 +0000959 const ImplicitCastExpr *Expr = cast<ImplicitCastExpr>(E);
Ted Kremenekd30ef872009-01-12 23:09:09 +0000960 return SemaCheckStringLiteral(Expr->getSubExpr(), TheCall, HasVAListArg,
Ted Kremenek826a3452010-07-16 02:11:22 +0000961 format_idx, firstDataArg, isPrintf);
Ted Kremenekd30ef872009-01-12 23:09:09 +0000962 }
963
964 case Stmt::ParenExprClass: {
Ted Kremenek082d9362009-03-20 21:35:28 +0000965 const ParenExpr *Expr = cast<ParenExpr>(E);
Ted Kremenekd30ef872009-01-12 23:09:09 +0000966 return SemaCheckStringLiteral(Expr->getSubExpr(), TheCall, HasVAListArg,
Ted Kremenek826a3452010-07-16 02:11:22 +0000967 format_idx, firstDataArg, isPrintf);
Ted Kremenekd30ef872009-01-12 23:09:09 +0000968 }
Mike Stump1eb44332009-09-09 15:08:12 +0000969
Ted Kremenek082d9362009-03-20 21:35:28 +0000970 case Stmt::DeclRefExprClass: {
971 const DeclRefExpr *DR = cast<DeclRefExpr>(E);
Mike Stump1eb44332009-09-09 15:08:12 +0000972
Ted Kremenek082d9362009-03-20 21:35:28 +0000973 // As an exception, do not flag errors for variables binding to
974 // const string literals.
975 if (const VarDecl *VD = dyn_cast<VarDecl>(DR->getDecl())) {
976 bool isConstant = false;
977 QualType T = DR->getType();
Ted Kremenekd30ef872009-01-12 23:09:09 +0000978
Ted Kremenek082d9362009-03-20 21:35:28 +0000979 if (const ArrayType *AT = Context.getAsArrayType(T)) {
980 isConstant = AT->getElementType().isConstant(Context);
Mike Stumpac5fc7c2009-08-04 21:02:39 +0000981 } else if (const PointerType *PT = T->getAs<PointerType>()) {
Mike Stump1eb44332009-09-09 15:08:12 +0000982 isConstant = T.isConstant(Context) &&
Ted Kremenek082d9362009-03-20 21:35:28 +0000983 PT->getPointeeType().isConstant(Context);
984 }
Mike Stump1eb44332009-09-09 15:08:12 +0000985
Ted Kremenek082d9362009-03-20 21:35:28 +0000986 if (isConstant) {
Sebastian Redl31310a22010-02-01 20:16:42 +0000987 if (const Expr *Init = VD->getAnyInitializer())
Ted Kremenek082d9362009-03-20 21:35:28 +0000988 return SemaCheckStringLiteral(Init, TheCall,
Ted Kremenek826a3452010-07-16 02:11:22 +0000989 HasVAListArg, format_idx, firstDataArg,
990 isPrintf);
Ted Kremenek082d9362009-03-20 21:35:28 +0000991 }
Mike Stump1eb44332009-09-09 15:08:12 +0000992
Anders Carlssond966a552009-06-28 19:55:58 +0000993 // For vprintf* functions (i.e., HasVAListArg==true), we add a
994 // special check to see if the format string is a function parameter
995 // of the function calling the printf function. If the function
996 // has an attribute indicating it is a printf-like function, then we
997 // should suppress warnings concerning non-literals being used in a call
998 // to a vprintf function. For example:
999 //
1000 // void
1001 // logmessage(char const *fmt __attribute__ (format (printf, 1, 2)), ...){
1002 // va_list ap;
1003 // va_start(ap, fmt);
1004 // vprintf(fmt, ap); // Do NOT emit a warning about "fmt".
1005 // ...
1006 //
1007 //
1008 // FIXME: We don't have full attribute support yet, so just check to see
1009 // if the argument is a DeclRefExpr that references a parameter. We'll
1010 // add proper support for checking the attribute later.
1011 if (HasVAListArg)
1012 if (isa<ParmVarDecl>(VD))
1013 return true;
Ted Kremenek082d9362009-03-20 21:35:28 +00001014 }
Mike Stump1eb44332009-09-09 15:08:12 +00001015
Ted Kremenek082d9362009-03-20 21:35:28 +00001016 return false;
1017 }
Ted Kremenekd30ef872009-01-12 23:09:09 +00001018
Anders Carlsson8f031b32009-06-27 04:05:33 +00001019 case Stmt::CallExprClass: {
1020 const CallExpr *CE = cast<CallExpr>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00001021 if (const ImplicitCastExpr *ICE
Anders Carlsson8f031b32009-06-27 04:05:33 +00001022 = dyn_cast<ImplicitCastExpr>(CE->getCallee())) {
1023 if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(ICE->getSubExpr())) {
1024 if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(DRE->getDecl())) {
Argyrios Kyrtzidis40b598e2009-06-30 02:34:44 +00001025 if (const FormatArgAttr *FA = FD->getAttr<FormatArgAttr>()) {
Anders Carlsson8f031b32009-06-27 04:05:33 +00001026 unsigned ArgIndex = FA->getFormatIdx();
1027 const Expr *Arg = CE->getArg(ArgIndex - 1);
Mike Stump1eb44332009-09-09 15:08:12 +00001028
1029 return SemaCheckStringLiteral(Arg, TheCall, HasVAListArg,
Ted Kremenek826a3452010-07-16 02:11:22 +00001030 format_idx, firstDataArg, isPrintf);
Anders Carlsson8f031b32009-06-27 04:05:33 +00001031 }
1032 }
1033 }
1034 }
Mike Stump1eb44332009-09-09 15:08:12 +00001035
Anders Carlsson8f031b32009-06-27 04:05:33 +00001036 return false;
1037 }
Ted Kremenek082d9362009-03-20 21:35:28 +00001038 case Stmt::ObjCStringLiteralClass:
1039 case Stmt::StringLiteralClass: {
1040 const StringLiteral *StrE = NULL;
Mike Stump1eb44332009-09-09 15:08:12 +00001041
Ted Kremenek082d9362009-03-20 21:35:28 +00001042 if (const ObjCStringLiteral *ObjCFExpr = dyn_cast<ObjCStringLiteral>(E))
Ted Kremenekd30ef872009-01-12 23:09:09 +00001043 StrE = ObjCFExpr->getString();
1044 else
Ted Kremenek082d9362009-03-20 21:35:28 +00001045 StrE = cast<StringLiteral>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00001046
Ted Kremenekd30ef872009-01-12 23:09:09 +00001047 if (StrE) {
Ted Kremenek826a3452010-07-16 02:11:22 +00001048 CheckFormatString(StrE, E, TheCall, HasVAListArg, format_idx,
1049 firstDataArg, isPrintf);
Ted Kremenekd30ef872009-01-12 23:09:09 +00001050 return true;
1051 }
Mike Stump1eb44332009-09-09 15:08:12 +00001052
Ted Kremenekd30ef872009-01-12 23:09:09 +00001053 return false;
1054 }
Mike Stump1eb44332009-09-09 15:08:12 +00001055
Ted Kremenek082d9362009-03-20 21:35:28 +00001056 default:
1057 return false;
Ted Kremenekd30ef872009-01-12 23:09:09 +00001058 }
1059}
1060
Fariborz Jahaniane898f8a2009-05-21 18:48:51 +00001061void
Mike Stump1eb44332009-09-09 15:08:12 +00001062Sema::CheckNonNullArguments(const NonNullAttr *NonNull,
1063 const CallExpr *TheCall) {
Sean Huntcf807c42010-08-18 23:23:40 +00001064 for (NonNullAttr::args_iterator i = NonNull->args_begin(),
1065 e = NonNull->args_end();
Fariborz Jahaniane898f8a2009-05-21 18:48:51 +00001066 i != e; ++i) {
Chris Lattner12b97ff2009-05-25 18:23:36 +00001067 const Expr *ArgExpr = TheCall->getArg(*i);
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001068 if (ArgExpr->isNullPointerConstant(Context,
Douglas Gregorce940492009-09-25 04:25:58 +00001069 Expr::NPC_ValueDependentIsNotNull))
Chris Lattner12b97ff2009-05-25 18:23:36 +00001070 Diag(TheCall->getCallee()->getLocStart(), diag::warn_null_arg)
1071 << ArgExpr->getSourceRange();
Fariborz Jahaniane898f8a2009-05-21 18:48:51 +00001072 }
1073}
Ted Kremenekd30ef872009-01-12 23:09:09 +00001074
Ted Kremenek826a3452010-07-16 02:11:22 +00001075/// CheckPrintfScanfArguments - Check calls to printf and scanf (and similar
1076/// functions) for correct use of format strings.
Chris Lattner59907c42007-08-10 20:18:51 +00001077void
Ted Kremenek826a3452010-07-16 02:11:22 +00001078Sema::CheckPrintfScanfArguments(const CallExpr *TheCall, bool HasVAListArg,
1079 unsigned format_idx, unsigned firstDataArg,
1080 bool isPrintf) {
1081
Ted Kremenek082d9362009-03-20 21:35:28 +00001082 const Expr *Fn = TheCall->getCallee();
Chris Lattner925e60d2007-12-28 05:29:59 +00001083
Sebastian Redl4a2614e2009-11-17 18:02:24 +00001084 // The way the format attribute works in GCC, the implicit this argument
1085 // of member functions is counted. However, it doesn't appear in our own
1086 // lists, so decrement format_idx in that case.
1087 if (isa<CXXMemberCallExpr>(TheCall)) {
1088 // Catch a format attribute mistakenly referring to the object argument.
1089 if (format_idx == 0)
1090 return;
1091 --format_idx;
1092 if(firstDataArg != 0)
1093 --firstDataArg;
1094 }
1095
Ted Kremenek826a3452010-07-16 02:11:22 +00001096 // CHECK: printf/scanf-like function is called with no format string.
Chris Lattner925e60d2007-12-28 05:29:59 +00001097 if (format_idx >= TheCall->getNumArgs()) {
Ted Kremenek826a3452010-07-16 02:11:22 +00001098 Diag(TheCall->getRParenLoc(), diag::warn_missing_format_string)
Chris Lattnerdcd5ef12008-11-19 05:27:50 +00001099 << Fn->getSourceRange();
Ted Kremenek71895b92007-08-14 17:39:48 +00001100 return;
1101 }
Mike Stump1eb44332009-09-09 15:08:12 +00001102
Ted Kremenek082d9362009-03-20 21:35:28 +00001103 const Expr *OrigFormatExpr = TheCall->getArg(format_idx)->IgnoreParenCasts();
Mike Stump1eb44332009-09-09 15:08:12 +00001104
Chris Lattner59907c42007-08-10 20:18:51 +00001105 // CHECK: format string is not a string literal.
Mike Stump1eb44332009-09-09 15:08:12 +00001106 //
Ted Kremenek71895b92007-08-14 17:39:48 +00001107 // Dynamically generated format strings are difficult to
1108 // automatically vet at compile time. Requiring that format strings
1109 // are string literals: (1) permits the checking of format strings by
1110 // the compiler and thereby (2) can practically remove the source of
1111 // many format string exploits.
Ted Kremenek7ff22b22008-06-16 18:00:42 +00001112
Mike Stump1eb44332009-09-09 15:08:12 +00001113 // Format string can be either ObjC string (e.g. @"%d") or
Ted Kremenek7ff22b22008-06-16 18:00:42 +00001114 // C string (e.g. "%d")
Mike Stump1eb44332009-09-09 15:08:12 +00001115 // ObjC string uses the same format specifiers as C string, so we can use
Ted Kremenek7ff22b22008-06-16 18:00:42 +00001116 // the same format string checking logic for both ObjC and C strings.
Chris Lattner1cd3e1f2009-04-29 04:49:34 +00001117 if (SemaCheckStringLiteral(OrigFormatExpr, TheCall, HasVAListArg, format_idx,
Ted Kremenek826a3452010-07-16 02:11:22 +00001118 firstDataArg, isPrintf))
Chris Lattner1cd3e1f2009-04-29 04:49:34 +00001119 return; // Literal format string found, check done!
Ted Kremenek7ff22b22008-06-16 18:00:42 +00001120
Chris Lattner655f1412009-04-29 04:59:47 +00001121 // If there are no arguments specified, warn with -Wformat-security, otherwise
1122 // warn only with -Wformat-nonliteral.
1123 if (TheCall->getNumArgs() == format_idx+1)
Mike Stump1eb44332009-09-09 15:08:12 +00001124 Diag(TheCall->getArg(format_idx)->getLocStart(),
Ted Kremenek826a3452010-07-16 02:11:22 +00001125 diag::warn_format_nonliteral_noargs)
Chris Lattner655f1412009-04-29 04:59:47 +00001126 << OrigFormatExpr->getSourceRange();
1127 else
Mike Stump1eb44332009-09-09 15:08:12 +00001128 Diag(TheCall->getArg(format_idx)->getLocStart(),
Ted Kremenek826a3452010-07-16 02:11:22 +00001129 diag::warn_format_nonliteral)
Chris Lattner655f1412009-04-29 04:59:47 +00001130 << OrigFormatExpr->getSourceRange();
Ted Kremenekd30ef872009-01-12 23:09:09 +00001131}
Ted Kremenek71895b92007-08-14 17:39:48 +00001132
Ted Kremeneke0e53132010-01-28 23:39:18 +00001133namespace {
Ted Kremenek826a3452010-07-16 02:11:22 +00001134class CheckFormatHandler : public analyze_format_string::FormatStringHandler {
1135protected:
Ted Kremeneke0e53132010-01-28 23:39:18 +00001136 Sema &S;
1137 const StringLiteral *FExpr;
1138 const Expr *OrigFormatExpr;
Ted Kremenek6ee76532010-03-25 03:59:12 +00001139 const unsigned FirstDataArg;
Ted Kremeneke0e53132010-01-28 23:39:18 +00001140 const unsigned NumDataArgs;
1141 const bool IsObjCLiteral;
1142 const char *Beg; // Start of format string.
Ted Kremenek0d277352010-01-29 01:06:55 +00001143 const bool HasVAListArg;
1144 const CallExpr *TheCall;
1145 unsigned FormatIdx;
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001146 llvm::BitVector CoveredArgs;
Ted Kremenekefaff192010-02-27 01:41:03 +00001147 bool usesPositionalArgs;
1148 bool atFirstArg;
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001149public:
Ted Kremenek826a3452010-07-16 02:11:22 +00001150 CheckFormatHandler(Sema &s, const StringLiteral *fexpr,
Ted Kremenek6ee76532010-03-25 03:59:12 +00001151 const Expr *origFormatExpr, unsigned firstDataArg,
Ted Kremeneke0e53132010-01-28 23:39:18 +00001152 unsigned numDataArgs, bool isObjCLiteral,
Ted Kremenek0d277352010-01-29 01:06:55 +00001153 const char *beg, bool hasVAListArg,
1154 const CallExpr *theCall, unsigned formatIdx)
Ted Kremeneke0e53132010-01-28 23:39:18 +00001155 : S(s), FExpr(fexpr), OrigFormatExpr(origFormatExpr),
Ted Kremenek6ee76532010-03-25 03:59:12 +00001156 FirstDataArg(firstDataArg),
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001157 NumDataArgs(numDataArgs),
Ted Kremenek0d277352010-01-29 01:06:55 +00001158 IsObjCLiteral(isObjCLiteral), Beg(beg),
1159 HasVAListArg(hasVAListArg),
Ted Kremenekefaff192010-02-27 01:41:03 +00001160 TheCall(theCall), FormatIdx(formatIdx),
1161 usesPositionalArgs(false), atFirstArg(true) {
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001162 CoveredArgs.resize(numDataArgs);
1163 CoveredArgs.reset();
1164 }
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001165
Ted Kremenek07d161f2010-01-29 01:50:07 +00001166 void DoneProcessing();
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001167
Ted Kremenek826a3452010-07-16 02:11:22 +00001168 void HandleIncompleteSpecifier(const char *startSpecifier,
1169 unsigned specifierLen);
1170
Ted Kremenekefaff192010-02-27 01:41:03 +00001171 virtual void HandleInvalidPosition(const char *startSpecifier,
1172 unsigned specifierLen,
Ted Kremenek826a3452010-07-16 02:11:22 +00001173 analyze_format_string::PositionContext p);
Ted Kremenekefaff192010-02-27 01:41:03 +00001174
1175 virtual void HandleZeroPosition(const char *startPos, unsigned posLen);
1176
Ted Kremeneke0e53132010-01-28 23:39:18 +00001177 void HandleNullChar(const char *nullCharacter);
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001178
Ted Kremenek826a3452010-07-16 02:11:22 +00001179protected:
Ted Kremenekc09b6a52010-07-19 21:25:57 +00001180 bool HandleInvalidConversionSpecifier(unsigned argIndex, SourceLocation Loc,
1181 const char *startSpec,
1182 unsigned specifierLen,
1183 const char *csStart, unsigned csLen);
1184
Ted Kremenekf88c8e02010-01-29 20:55:36 +00001185 SourceRange getFormatStringRange();
Ted Kremenek826a3452010-07-16 02:11:22 +00001186 CharSourceRange getSpecifierRange(const char *startSpecifier,
1187 unsigned specifierLen);
Ted Kremeneke0e53132010-01-28 23:39:18 +00001188 SourceLocation getLocationOfByte(const char *x);
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001189
Ted Kremenek0d277352010-01-29 01:06:55 +00001190 const Expr *getDataArg(unsigned i) const;
Ted Kremenek666a1972010-07-26 19:45:42 +00001191
1192 bool CheckNumArgs(const analyze_format_string::FormatSpecifier &FS,
1193 const analyze_format_string::ConversionSpecifier &CS,
1194 const char *startSpecifier, unsigned specifierLen,
1195 unsigned argIndex);
Ted Kremeneke0e53132010-01-28 23:39:18 +00001196};
1197}
1198
Ted Kremenek826a3452010-07-16 02:11:22 +00001199SourceRange CheckFormatHandler::getFormatStringRange() {
Ted Kremeneke0e53132010-01-28 23:39:18 +00001200 return OrigFormatExpr->getSourceRange();
1201}
1202
Ted Kremenek826a3452010-07-16 02:11:22 +00001203CharSourceRange CheckFormatHandler::
1204getSpecifierRange(const char *startSpecifier, unsigned specifierLen) {
Tom Care45f9b7e2010-06-21 21:21:01 +00001205 SourceLocation Start = getLocationOfByte(startSpecifier);
1206 SourceLocation End = getLocationOfByte(startSpecifier + specifierLen - 1);
1207
1208 // Advance the end SourceLocation by one due to half-open ranges.
1209 End = End.getFileLocWithOffset(1);
1210
1211 return CharSourceRange::getCharRange(Start, End);
Ted Kremenekf88c8e02010-01-29 20:55:36 +00001212}
1213
Ted Kremenek826a3452010-07-16 02:11:22 +00001214SourceLocation CheckFormatHandler::getLocationOfByte(const char *x) {
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001215 return S.getLocationOfStringLiteralByte(FExpr, x - Beg);
Ted Kremeneke0e53132010-01-28 23:39:18 +00001216}
1217
Ted Kremenek826a3452010-07-16 02:11:22 +00001218void CheckFormatHandler::HandleIncompleteSpecifier(const char *startSpecifier,
1219 unsigned specifierLen){
Ted Kremenek808015a2010-01-29 03:16:21 +00001220 SourceLocation Loc = getLocationOfByte(startSpecifier);
1221 S.Diag(Loc, diag::warn_printf_incomplete_specifier)
Ted Kremenek826a3452010-07-16 02:11:22 +00001222 << getSpecifierRange(startSpecifier, specifierLen);
Ted Kremenek808015a2010-01-29 03:16:21 +00001223}
1224
Ted Kremenekefaff192010-02-27 01:41:03 +00001225void
Ted Kremenek826a3452010-07-16 02:11:22 +00001226CheckFormatHandler::HandleInvalidPosition(const char *startPos, unsigned posLen,
1227 analyze_format_string::PositionContext p) {
Ted Kremenekefaff192010-02-27 01:41:03 +00001228 SourceLocation Loc = getLocationOfByte(startPos);
Ted Kremenek826a3452010-07-16 02:11:22 +00001229 S.Diag(Loc, diag::warn_format_invalid_positional_specifier)
1230 << (unsigned) p << getSpecifierRange(startPos, posLen);
Ted Kremenekefaff192010-02-27 01:41:03 +00001231}
1232
Ted Kremenek826a3452010-07-16 02:11:22 +00001233void CheckFormatHandler::HandleZeroPosition(const char *startPos,
Ted Kremenekefaff192010-02-27 01:41:03 +00001234 unsigned posLen) {
1235 SourceLocation Loc = getLocationOfByte(startPos);
Ted Kremenek826a3452010-07-16 02:11:22 +00001236 S.Diag(Loc, diag::warn_format_zero_positional_specifier)
1237 << getSpecifierRange(startPos, posLen);
Ted Kremenekefaff192010-02-27 01:41:03 +00001238}
1239
Ted Kremenek826a3452010-07-16 02:11:22 +00001240void CheckFormatHandler::HandleNullChar(const char *nullCharacter) {
1241 // The presence of a null character is likely an error.
1242 S.Diag(getLocationOfByte(nullCharacter),
1243 diag::warn_printf_format_string_contains_null_char)
1244 << getFormatStringRange();
1245}
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001246
Ted Kremenek826a3452010-07-16 02:11:22 +00001247const Expr *CheckFormatHandler::getDataArg(unsigned i) const {
1248 return TheCall->getArg(FirstDataArg + i);
1249}
1250
1251void CheckFormatHandler::DoneProcessing() {
1252 // Does the number of data arguments exceed the number of
1253 // format conversions in the format string?
1254 if (!HasVAListArg) {
1255 // Find any arguments that weren't covered.
1256 CoveredArgs.flip();
1257 signed notCoveredArg = CoveredArgs.find_first();
1258 if (notCoveredArg >= 0) {
1259 assert((unsigned)notCoveredArg < NumDataArgs);
1260 S.Diag(getDataArg((unsigned) notCoveredArg)->getLocStart(),
1261 diag::warn_printf_data_arg_not_used)
1262 << getFormatStringRange();
1263 }
1264 }
1265}
1266
Ted Kremenekc09b6a52010-07-19 21:25:57 +00001267bool
1268CheckFormatHandler::HandleInvalidConversionSpecifier(unsigned argIndex,
1269 SourceLocation Loc,
1270 const char *startSpec,
1271 unsigned specifierLen,
1272 const char *csStart,
1273 unsigned csLen) {
1274
1275 bool keepGoing = true;
1276 if (argIndex < NumDataArgs) {
1277 // Consider the argument coverered, even though the specifier doesn't
1278 // make sense.
1279 CoveredArgs.set(argIndex);
1280 }
1281 else {
1282 // If argIndex exceeds the number of data arguments we
1283 // don't issue a warning because that is just a cascade of warnings (and
1284 // they may have intended '%%' anyway). We don't want to continue processing
1285 // the format string after this point, however, as we will like just get
1286 // gibberish when trying to match arguments.
1287 keepGoing = false;
1288 }
1289
1290 S.Diag(Loc, diag::warn_format_invalid_conversion)
1291 << llvm::StringRef(csStart, csLen)
1292 << getSpecifierRange(startSpec, specifierLen);
1293
1294 return keepGoing;
1295}
1296
Ted Kremenek666a1972010-07-26 19:45:42 +00001297bool
1298CheckFormatHandler::CheckNumArgs(
1299 const analyze_format_string::FormatSpecifier &FS,
1300 const analyze_format_string::ConversionSpecifier &CS,
1301 const char *startSpecifier, unsigned specifierLen, unsigned argIndex) {
1302
1303 if (argIndex >= NumDataArgs) {
1304 if (FS.usesPositionalArg()) {
1305 S.Diag(getLocationOfByte(CS.getStart()),
1306 diag::warn_printf_positional_arg_exceeds_data_args)
1307 << (argIndex+1) << NumDataArgs
1308 << getSpecifierRange(startSpecifier, specifierLen);
1309 }
1310 else {
1311 S.Diag(getLocationOfByte(CS.getStart()),
1312 diag::warn_printf_insufficient_data_args)
1313 << getSpecifierRange(startSpecifier, specifierLen);
1314 }
1315
1316 return false;
1317 }
1318 return true;
1319}
1320
Ted Kremenek826a3452010-07-16 02:11:22 +00001321//===--- CHECK: Printf format string checking ------------------------------===//
1322
1323namespace {
1324class CheckPrintfHandler : public CheckFormatHandler {
1325public:
1326 CheckPrintfHandler(Sema &s, const StringLiteral *fexpr,
1327 const Expr *origFormatExpr, unsigned firstDataArg,
1328 unsigned numDataArgs, bool isObjCLiteral,
1329 const char *beg, bool hasVAListArg,
1330 const CallExpr *theCall, unsigned formatIdx)
1331 : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg,
1332 numDataArgs, isObjCLiteral, beg, hasVAListArg,
1333 theCall, formatIdx) {}
1334
1335
1336 bool HandleInvalidPrintfConversionSpecifier(
1337 const analyze_printf::PrintfSpecifier &FS,
1338 const char *startSpecifier,
1339 unsigned specifierLen);
1340
1341 bool HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier &FS,
1342 const char *startSpecifier,
1343 unsigned specifierLen);
1344
1345 bool HandleAmount(const analyze_format_string::OptionalAmount &Amt, unsigned k,
1346 const char *startSpecifier, unsigned specifierLen);
1347 void HandleInvalidAmount(const analyze_printf::PrintfSpecifier &FS,
1348 const analyze_printf::OptionalAmount &Amt,
1349 unsigned type,
1350 const char *startSpecifier, unsigned specifierLen);
1351 void HandleFlag(const analyze_printf::PrintfSpecifier &FS,
1352 const analyze_printf::OptionalFlag &flag,
1353 const char *startSpecifier, unsigned specifierLen);
1354 void HandleIgnoredFlag(const analyze_printf::PrintfSpecifier &FS,
1355 const analyze_printf::OptionalFlag &ignoredFlag,
1356 const analyze_printf::OptionalFlag &flag,
1357 const char *startSpecifier, unsigned specifierLen);
1358};
1359}
1360
1361bool CheckPrintfHandler::HandleInvalidPrintfConversionSpecifier(
1362 const analyze_printf::PrintfSpecifier &FS,
1363 const char *startSpecifier,
1364 unsigned specifierLen) {
Ted Kremenek6ecb9502010-07-20 20:04:27 +00001365 const analyze_printf::PrintfConversionSpecifier &CS =
Ted Kremenekc09b6a52010-07-19 21:25:57 +00001366 FS.getConversionSpecifier();
Ted Kremenek826a3452010-07-16 02:11:22 +00001367
Ted Kremenekc09b6a52010-07-19 21:25:57 +00001368 return HandleInvalidConversionSpecifier(FS.getArgIndex(),
1369 getLocationOfByte(CS.getStart()),
1370 startSpecifier, specifierLen,
1371 CS.getStart(), CS.getLength());
Ted Kremenek26ac2e02010-01-29 02:40:24 +00001372}
1373
Ted Kremenek826a3452010-07-16 02:11:22 +00001374bool CheckPrintfHandler::HandleAmount(
1375 const analyze_format_string::OptionalAmount &Amt,
1376 unsigned k, const char *startSpecifier,
1377 unsigned specifierLen) {
Ted Kremenek0d277352010-01-29 01:06:55 +00001378
1379 if (Amt.hasDataArgument()) {
Ted Kremenek0d277352010-01-29 01:06:55 +00001380 if (!HasVAListArg) {
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001381 unsigned argIndex = Amt.getArgIndex();
1382 if (argIndex >= NumDataArgs) {
Ted Kremenekefaff192010-02-27 01:41:03 +00001383 S.Diag(getLocationOfByte(Amt.getStart()),
1384 diag::warn_printf_asterisk_missing_arg)
Ted Kremenek826a3452010-07-16 02:11:22 +00001385 << k << getSpecifierRange(startSpecifier, specifierLen);
Ted Kremenek0d277352010-01-29 01:06:55 +00001386 // Don't do any more checking. We will just emit
1387 // spurious errors.
1388 return false;
1389 }
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001390
Ted Kremenek0d277352010-01-29 01:06:55 +00001391 // Type check the data argument. It should be an 'int'.
Ted Kremenek31f8e322010-01-29 23:32:22 +00001392 // Although not in conformance with C99, we also allow the argument to be
1393 // an 'unsigned int' as that is a reasonably safe case. GCC also
1394 // doesn't emit a warning for that case.
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001395 CoveredArgs.set(argIndex);
1396 const Expr *Arg = getDataArg(argIndex);
Ted Kremenek0d277352010-01-29 01:06:55 +00001397 QualType T = Arg->getType();
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001398
1399 const analyze_printf::ArgTypeResult &ATR = Amt.getArgType(S.Context);
1400 assert(ATR.isValid());
1401
1402 if (!ATR.matchesType(S.Context, T)) {
Ted Kremenekefaff192010-02-27 01:41:03 +00001403 S.Diag(getLocationOfByte(Amt.getStart()),
1404 diag::warn_printf_asterisk_wrong_type)
1405 << k
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001406 << ATR.getRepresentativeType(S.Context) << T
Ted Kremenek826a3452010-07-16 02:11:22 +00001407 << getSpecifierRange(startSpecifier, specifierLen)
Ted Kremenekd635c5f2010-01-30 00:49:51 +00001408 << Arg->getSourceRange();
Ted Kremenek0d277352010-01-29 01:06:55 +00001409 // Don't do any more checking. We will just emit
1410 // spurious errors.
1411 return false;
1412 }
1413 }
1414 }
1415 return true;
1416}
Ted Kremenek0d277352010-01-29 01:06:55 +00001417
Tom Caree4ee9662010-06-17 19:00:27 +00001418void CheckPrintfHandler::HandleInvalidAmount(
Ted Kremenek826a3452010-07-16 02:11:22 +00001419 const analyze_printf::PrintfSpecifier &FS,
Tom Caree4ee9662010-06-17 19:00:27 +00001420 const analyze_printf::OptionalAmount &Amt,
1421 unsigned type,
1422 const char *startSpecifier,
1423 unsigned specifierLen) {
Ted Kremenek6ecb9502010-07-20 20:04:27 +00001424 const analyze_printf::PrintfConversionSpecifier &CS =
1425 FS.getConversionSpecifier();
Tom Caree4ee9662010-06-17 19:00:27 +00001426 switch (Amt.getHowSpecified()) {
1427 case analyze_printf::OptionalAmount::Constant:
1428 S.Diag(getLocationOfByte(Amt.getStart()),
1429 diag::warn_printf_nonsensical_optional_amount)
1430 << type
1431 << CS.toString()
Ted Kremenek826a3452010-07-16 02:11:22 +00001432 << getSpecifierRange(startSpecifier, specifierLen)
1433 << FixItHint::CreateRemoval(getSpecifierRange(Amt.getStart(),
Tom Caree4ee9662010-06-17 19:00:27 +00001434 Amt.getConstantLength()));
1435 break;
1436
1437 default:
1438 S.Diag(getLocationOfByte(Amt.getStart()),
1439 diag::warn_printf_nonsensical_optional_amount)
1440 << type
1441 << CS.toString()
Ted Kremenek826a3452010-07-16 02:11:22 +00001442 << getSpecifierRange(startSpecifier, specifierLen);
Tom Caree4ee9662010-06-17 19:00:27 +00001443 break;
1444 }
1445}
1446
Ted Kremenek826a3452010-07-16 02:11:22 +00001447void CheckPrintfHandler::HandleFlag(const analyze_printf::PrintfSpecifier &FS,
Tom Caree4ee9662010-06-17 19:00:27 +00001448 const analyze_printf::OptionalFlag &flag,
1449 const char *startSpecifier,
1450 unsigned specifierLen) {
1451 // Warn about pointless flag with a fixit removal.
Ted Kremenek6ecb9502010-07-20 20:04:27 +00001452 const analyze_printf::PrintfConversionSpecifier &CS =
1453 FS.getConversionSpecifier();
Tom Caree4ee9662010-06-17 19:00:27 +00001454 S.Diag(getLocationOfByte(flag.getPosition()),
1455 diag::warn_printf_nonsensical_flag)
1456 << flag.toString() << CS.toString()
Ted Kremenek826a3452010-07-16 02:11:22 +00001457 << getSpecifierRange(startSpecifier, specifierLen)
1458 << FixItHint::CreateRemoval(getSpecifierRange(flag.getPosition(), 1));
Tom Caree4ee9662010-06-17 19:00:27 +00001459}
1460
1461void CheckPrintfHandler::HandleIgnoredFlag(
Ted Kremenek826a3452010-07-16 02:11:22 +00001462 const analyze_printf::PrintfSpecifier &FS,
Tom Caree4ee9662010-06-17 19:00:27 +00001463 const analyze_printf::OptionalFlag &ignoredFlag,
1464 const analyze_printf::OptionalFlag &flag,
1465 const char *startSpecifier,
1466 unsigned specifierLen) {
1467 // Warn about ignored flag with a fixit removal.
1468 S.Diag(getLocationOfByte(ignoredFlag.getPosition()),
1469 diag::warn_printf_ignored_flag)
1470 << ignoredFlag.toString() << flag.toString()
Ted Kremenek826a3452010-07-16 02:11:22 +00001471 << getSpecifierRange(startSpecifier, specifierLen)
1472 << FixItHint::CreateRemoval(getSpecifierRange(
Tom Caree4ee9662010-06-17 19:00:27 +00001473 ignoredFlag.getPosition(), 1));
1474}
1475
Ted Kremeneke0e53132010-01-28 23:39:18 +00001476bool
Ted Kremenek826a3452010-07-16 02:11:22 +00001477CheckPrintfHandler::HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier
Ted Kremenek5c41ee82010-02-11 09:27:41 +00001478 &FS,
Ted Kremeneke0e53132010-01-28 23:39:18 +00001479 const char *startSpecifier,
1480 unsigned specifierLen) {
1481
Ted Kremenek6ecb9502010-07-20 20:04:27 +00001482 using namespace analyze_format_string;
Ted Kremenekefaff192010-02-27 01:41:03 +00001483 using namespace analyze_printf;
Ted Kremenek6ecb9502010-07-20 20:04:27 +00001484 const PrintfConversionSpecifier &CS = FS.getConversionSpecifier();
Ted Kremeneke0e53132010-01-28 23:39:18 +00001485
Ted Kremenekbaa40062010-07-19 22:01:06 +00001486 if (FS.consumesDataArgument()) {
1487 if (atFirstArg) {
1488 atFirstArg = false;
1489 usesPositionalArgs = FS.usesPositionalArg();
1490 }
1491 else if (usesPositionalArgs != FS.usesPositionalArg()) {
1492 // Cannot mix-and-match positional and non-positional arguments.
1493 S.Diag(getLocationOfByte(CS.getStart()),
1494 diag::warn_format_mix_positional_nonpositional_args)
1495 << getSpecifierRange(startSpecifier, specifierLen);
1496 return false;
1497 }
Ted Kremenek0d277352010-01-29 01:06:55 +00001498 }
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001499
Ted Kremenekefaff192010-02-27 01:41:03 +00001500 // First check if the field width, precision, and conversion specifier
1501 // have matching data arguments.
1502 if (!HandleAmount(FS.getFieldWidth(), /* field width */ 0,
1503 startSpecifier, specifierLen)) {
1504 return false;
1505 }
1506
1507 if (!HandleAmount(FS.getPrecision(), /* precision */ 1,
1508 startSpecifier, specifierLen)) {
Ted Kremenek0d277352010-01-29 01:06:55 +00001509 return false;
1510 }
1511
Ted Kremenekf88c8e02010-01-29 20:55:36 +00001512 if (!CS.consumesDataArgument()) {
1513 // FIXME: Technically specifying a precision or field width here
1514 // makes no sense. Worth issuing a warning at some point.
Ted Kremenek0e5675d2010-02-10 02:16:30 +00001515 return true;
Ted Kremenekf88c8e02010-01-29 20:55:36 +00001516 }
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001517
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001518 // Consume the argument.
1519 unsigned argIndex = FS.getArgIndex();
Ted Kremeneke3fc5472010-02-27 08:34:51 +00001520 if (argIndex < NumDataArgs) {
1521 // The check to see if the argIndex is valid will come later.
1522 // We set the bit here because we may exit early from this
1523 // function if we encounter some other error.
1524 CoveredArgs.set(argIndex);
1525 }
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001526
1527 // Check for using an Objective-C specific conversion specifier
1528 // in a non-ObjC literal.
1529 if (!IsObjCLiteral && CS.isObjCArg()) {
Ted Kremenek826a3452010-07-16 02:11:22 +00001530 return HandleInvalidPrintfConversionSpecifier(FS, startSpecifier,
1531 specifierLen);
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001532 }
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001533
Tom Caree4ee9662010-06-17 19:00:27 +00001534 // Check for invalid use of field width
1535 if (!FS.hasValidFieldWidth()) {
Tom Care45f9b7e2010-06-21 21:21:01 +00001536 HandleInvalidAmount(FS, FS.getFieldWidth(), /* field width */ 0,
Tom Caree4ee9662010-06-17 19:00:27 +00001537 startSpecifier, specifierLen);
1538 }
1539
1540 // Check for invalid use of precision
1541 if (!FS.hasValidPrecision()) {
1542 HandleInvalidAmount(FS, FS.getPrecision(), /* precision */ 1,
1543 startSpecifier, specifierLen);
1544 }
1545
1546 // Check each flag does not conflict with any other component.
1547 if (!FS.hasValidLeadingZeros())
1548 HandleFlag(FS, FS.hasLeadingZeros(), startSpecifier, specifierLen);
1549 if (!FS.hasValidPlusPrefix())
1550 HandleFlag(FS, FS.hasPlusPrefix(), startSpecifier, specifierLen);
Tom Care45f9b7e2010-06-21 21:21:01 +00001551 if (!FS.hasValidSpacePrefix())
1552 HandleFlag(FS, FS.hasSpacePrefix(), startSpecifier, specifierLen);
Tom Caree4ee9662010-06-17 19:00:27 +00001553 if (!FS.hasValidAlternativeForm())
1554 HandleFlag(FS, FS.hasAlternativeForm(), startSpecifier, specifierLen);
1555 if (!FS.hasValidLeftJustified())
1556 HandleFlag(FS, FS.isLeftJustified(), startSpecifier, specifierLen);
1557
1558 // Check that flags are not ignored by another flag
Tom Care45f9b7e2010-06-21 21:21:01 +00001559 if (FS.hasSpacePrefix() && FS.hasPlusPrefix()) // ' ' ignored by '+'
1560 HandleIgnoredFlag(FS, FS.hasSpacePrefix(), FS.hasPlusPrefix(),
1561 startSpecifier, specifierLen);
Tom Caree4ee9662010-06-17 19:00:27 +00001562 if (FS.hasLeadingZeros() && FS.isLeftJustified()) // '0' ignored by '-'
1563 HandleIgnoredFlag(FS, FS.hasLeadingZeros(), FS.isLeftJustified(),
1564 startSpecifier, specifierLen);
1565
1566 // Check the length modifier is valid with the given conversion specifier.
1567 const LengthModifier &LM = FS.getLengthModifier();
1568 if (!FS.hasValidLengthModifier())
1569 S.Diag(getLocationOfByte(LM.getStart()),
Ted Kremenek649aecf2010-07-20 20:03:43 +00001570 diag::warn_format_nonsensical_length)
Tom Caree4ee9662010-06-17 19:00:27 +00001571 << LM.toString() << CS.toString()
Ted Kremenek826a3452010-07-16 02:11:22 +00001572 << getSpecifierRange(startSpecifier, specifierLen)
1573 << FixItHint::CreateRemoval(getSpecifierRange(LM.getStart(),
Tom Caree4ee9662010-06-17 19:00:27 +00001574 LM.getLength()));
1575
1576 // Are we using '%n'?
Ted Kremenek35d353b2010-07-20 20:04:10 +00001577 if (CS.getKind() == ConversionSpecifier::nArg) {
Tom Caree4ee9662010-06-17 19:00:27 +00001578 // Issue a warning about this being a possible security issue.
Ted Kremeneke82d8042010-01-29 01:35:25 +00001579 S.Diag(getLocationOfByte(CS.getStart()), diag::warn_printf_write_back)
Ted Kremenek826a3452010-07-16 02:11:22 +00001580 << getSpecifierRange(startSpecifier, specifierLen);
Ted Kremeneke82d8042010-01-29 01:35:25 +00001581 // Continue checking the other format specifiers.
1582 return true;
1583 }
Ted Kremenek5c41ee82010-02-11 09:27:41 +00001584
Ted Kremenekda51f0d2010-01-29 01:43:31 +00001585 // The remaining checks depend on the data arguments.
1586 if (HasVAListArg)
1587 return true;
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001588
Ted Kremenek666a1972010-07-26 19:45:42 +00001589 if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex))
Ted Kremenekda51f0d2010-01-29 01:43:31 +00001590 return false;
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001591
Michael J. Spencer96827eb2010-07-27 04:46:02 +00001592 // Now type check the data expression that matches the
1593 // format specifier.
1594 const Expr *Ex = getDataArg(argIndex);
1595 const analyze_printf::ArgTypeResult &ATR = FS.getArgType(S.Context);
1596 if (ATR.isValid() && !ATR.matchesType(S.Context, Ex->getType())) {
1597 // Check if we didn't match because of an implicit cast from a 'char'
1598 // or 'short' to an 'int'. This is done because printf is a varargs
1599 // function.
1600 if (const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Ex))
1601 if (ICE->getType() == S.Context.IntTy)
1602 if (ATR.matchesType(S.Context, ICE->getSubExpr()->getType()))
1603 return true;
1604
1605 // We may be able to offer a FixItHint if it is a supported type.
1606 PrintfSpecifier fixedFS = FS;
1607 bool success = fixedFS.fixType(Ex->getType());
1608
1609 if (success) {
1610 // Get the fix string from the fixed format specifier
1611 llvm::SmallString<128> buf;
1612 llvm::raw_svector_ostream os(buf);
1613 fixedFS.toString(os);
1614
Ted Kremenek9325eaf2010-08-24 22:24:51 +00001615 // FIXME: getRepresentativeType() perhaps should return a string
1616 // instead of a QualType to better handle when the representative
1617 // type is 'wint_t' (which is defined in the system headers).
Michael J. Spencer96827eb2010-07-27 04:46:02 +00001618 S.Diag(getLocationOfByte(CS.getStart()),
1619 diag::warn_printf_conversion_argument_type_mismatch)
1620 << ATR.getRepresentativeType(S.Context) << Ex->getType()
1621 << getSpecifierRange(startSpecifier, specifierLen)
1622 << Ex->getSourceRange()
1623 << FixItHint::CreateReplacement(
1624 getSpecifierRange(startSpecifier, specifierLen),
1625 os.str());
1626 }
1627 else {
1628 S.Diag(getLocationOfByte(CS.getStart()),
1629 diag::warn_printf_conversion_argument_type_mismatch)
1630 << ATR.getRepresentativeType(S.Context) << Ex->getType()
1631 << getSpecifierRange(startSpecifier, specifierLen)
1632 << Ex->getSourceRange();
1633 }
1634 }
1635
Ted Kremeneke0e53132010-01-28 23:39:18 +00001636 return true;
1637}
1638
Ted Kremenek826a3452010-07-16 02:11:22 +00001639//===--- CHECK: Scanf format string checking ------------------------------===//
1640
1641namespace {
1642class CheckScanfHandler : public CheckFormatHandler {
1643public:
1644 CheckScanfHandler(Sema &s, const StringLiteral *fexpr,
1645 const Expr *origFormatExpr, unsigned firstDataArg,
1646 unsigned numDataArgs, bool isObjCLiteral,
1647 const char *beg, bool hasVAListArg,
1648 const CallExpr *theCall, unsigned formatIdx)
1649 : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg,
1650 numDataArgs, isObjCLiteral, beg, hasVAListArg,
1651 theCall, formatIdx) {}
1652
1653 bool HandleScanfSpecifier(const analyze_scanf::ScanfSpecifier &FS,
1654 const char *startSpecifier,
1655 unsigned specifierLen);
Ted Kremenekc09b6a52010-07-19 21:25:57 +00001656
1657 bool HandleInvalidScanfConversionSpecifier(
1658 const analyze_scanf::ScanfSpecifier &FS,
1659 const char *startSpecifier,
1660 unsigned specifierLen);
Ted Kremenekb7c21012010-07-16 18:28:03 +00001661
1662 void HandleIncompleteScanList(const char *start, const char *end);
Ted Kremenek826a3452010-07-16 02:11:22 +00001663};
Ted Kremenek07d161f2010-01-29 01:50:07 +00001664}
Ted Kremeneke0e53132010-01-28 23:39:18 +00001665
Ted Kremenekb7c21012010-07-16 18:28:03 +00001666void CheckScanfHandler::HandleIncompleteScanList(const char *start,
1667 const char *end) {
1668 S.Diag(getLocationOfByte(end), diag::warn_scanf_scanlist_incomplete)
1669 << getSpecifierRange(start, end - start);
1670}
1671
Ted Kremenekc09b6a52010-07-19 21:25:57 +00001672bool CheckScanfHandler::HandleInvalidScanfConversionSpecifier(
1673 const analyze_scanf::ScanfSpecifier &FS,
1674 const char *startSpecifier,
1675 unsigned specifierLen) {
1676
Ted Kremenek6ecb9502010-07-20 20:04:27 +00001677 const analyze_scanf::ScanfConversionSpecifier &CS =
Ted Kremenekc09b6a52010-07-19 21:25:57 +00001678 FS.getConversionSpecifier();
1679
1680 return HandleInvalidConversionSpecifier(FS.getArgIndex(),
1681 getLocationOfByte(CS.getStart()),
1682 startSpecifier, specifierLen,
1683 CS.getStart(), CS.getLength());
1684}
1685
Ted Kremenek826a3452010-07-16 02:11:22 +00001686bool CheckScanfHandler::HandleScanfSpecifier(
1687 const analyze_scanf::ScanfSpecifier &FS,
1688 const char *startSpecifier,
1689 unsigned specifierLen) {
1690
1691 using namespace analyze_scanf;
1692 using namespace analyze_format_string;
1693
Ted Kremenek6ecb9502010-07-20 20:04:27 +00001694 const ScanfConversionSpecifier &CS = FS.getConversionSpecifier();
Ted Kremenek826a3452010-07-16 02:11:22 +00001695
Ted Kremenekbaa40062010-07-19 22:01:06 +00001696 // Handle case where '%' and '*' don't consume an argument. These shouldn't
1697 // be used to decide if we are using positional arguments consistently.
1698 if (FS.consumesDataArgument()) {
1699 if (atFirstArg) {
1700 atFirstArg = false;
1701 usesPositionalArgs = FS.usesPositionalArg();
1702 }
1703 else if (usesPositionalArgs != FS.usesPositionalArg()) {
1704 // Cannot mix-and-match positional and non-positional arguments.
1705 S.Diag(getLocationOfByte(CS.getStart()),
1706 diag::warn_format_mix_positional_nonpositional_args)
1707 << getSpecifierRange(startSpecifier, specifierLen);
1708 return false;
1709 }
Ted Kremenek826a3452010-07-16 02:11:22 +00001710 }
1711
1712 // Check if the field with is non-zero.
1713 const OptionalAmount &Amt = FS.getFieldWidth();
1714 if (Amt.getHowSpecified() == OptionalAmount::Constant) {
1715 if (Amt.getConstantAmount() == 0) {
1716 const CharSourceRange &R = getSpecifierRange(Amt.getStart(),
1717 Amt.getConstantLength());
1718 S.Diag(getLocationOfByte(Amt.getStart()),
1719 diag::warn_scanf_nonzero_width)
1720 << R << FixItHint::CreateRemoval(R);
1721 }
1722 }
1723
1724 if (!FS.consumesDataArgument()) {
1725 // FIXME: Technically specifying a precision or field width here
1726 // makes no sense. Worth issuing a warning at some point.
1727 return true;
1728 }
1729
1730 // Consume the argument.
1731 unsigned argIndex = FS.getArgIndex();
1732 if (argIndex < NumDataArgs) {
1733 // The check to see if the argIndex is valid will come later.
1734 // We set the bit here because we may exit early from this
1735 // function if we encounter some other error.
1736 CoveredArgs.set(argIndex);
1737 }
1738
Ted Kremenek1e51c202010-07-20 20:04:47 +00001739 // Check the length modifier is valid with the given conversion specifier.
1740 const LengthModifier &LM = FS.getLengthModifier();
1741 if (!FS.hasValidLengthModifier()) {
1742 S.Diag(getLocationOfByte(LM.getStart()),
1743 diag::warn_format_nonsensical_length)
1744 << LM.toString() << CS.toString()
1745 << getSpecifierRange(startSpecifier, specifierLen)
1746 << FixItHint::CreateRemoval(getSpecifierRange(LM.getStart(),
1747 LM.getLength()));
1748 }
1749
Ted Kremenek826a3452010-07-16 02:11:22 +00001750 // The remaining checks depend on the data arguments.
1751 if (HasVAListArg)
1752 return true;
1753
Ted Kremenek666a1972010-07-26 19:45:42 +00001754 if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex))
Ted Kremenek826a3452010-07-16 02:11:22 +00001755 return false;
Ted Kremenek826a3452010-07-16 02:11:22 +00001756
1757 // FIXME: Check that the argument type matches the format specifier.
1758
1759 return true;
1760}
1761
1762void Sema::CheckFormatString(const StringLiteral *FExpr,
Ted Kremenek0e5675d2010-02-10 02:16:30 +00001763 const Expr *OrigFormatExpr,
1764 const CallExpr *TheCall, bool HasVAListArg,
Ted Kremenek826a3452010-07-16 02:11:22 +00001765 unsigned format_idx, unsigned firstDataArg,
1766 bool isPrintf) {
1767
Ted Kremeneke0e53132010-01-28 23:39:18 +00001768 // CHECK: is the format string a wide literal?
1769 if (FExpr->isWide()) {
1770 Diag(FExpr->getLocStart(),
Ted Kremenek826a3452010-07-16 02:11:22 +00001771 diag::warn_format_string_is_wide_literal)
Ted Kremeneke0e53132010-01-28 23:39:18 +00001772 << OrigFormatExpr->getSourceRange();
1773 return;
1774 }
Ted Kremenek826a3452010-07-16 02:11:22 +00001775
Ted Kremeneke0e53132010-01-28 23:39:18 +00001776 // Str - The format string. NOTE: this is NOT null-terminated!
Benjamin Kramer2f4eaef2010-08-17 12:54:38 +00001777 llvm::StringRef StrRef = FExpr->getString();
1778 const char *Str = StrRef.data();
1779 unsigned StrLen = StrRef.size();
Ted Kremenek826a3452010-07-16 02:11:22 +00001780
Ted Kremeneke0e53132010-01-28 23:39:18 +00001781 // CHECK: empty format string?
Ted Kremeneke0e53132010-01-28 23:39:18 +00001782 if (StrLen == 0) {
Ted Kremenek826a3452010-07-16 02:11:22 +00001783 Diag(FExpr->getLocStart(), diag::warn_empty_format_string)
Ted Kremeneke0e53132010-01-28 23:39:18 +00001784 << OrigFormatExpr->getSourceRange();
1785 return;
1786 }
Ted Kremenek826a3452010-07-16 02:11:22 +00001787
1788 if (isPrintf) {
1789 CheckPrintfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg,
1790 TheCall->getNumArgs() - firstDataArg,
1791 isa<ObjCStringLiteral>(OrigFormatExpr), Str,
1792 HasVAListArg, TheCall, format_idx);
1793
1794 if (!analyze_format_string::ParsePrintfString(H, Str, Str + StrLen))
1795 H.DoneProcessing();
1796 }
1797 else {
1798 CheckScanfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg,
1799 TheCall->getNumArgs() - firstDataArg,
1800 isa<ObjCStringLiteral>(OrigFormatExpr), Str,
1801 HasVAListArg, TheCall, format_idx);
1802
1803 if (!analyze_format_string::ParseScanfString(H, Str, Str + StrLen))
1804 H.DoneProcessing();
1805 }
Ted Kremenekce7024e2010-01-28 01:18:22 +00001806}
1807
Ted Kremenek06de2762007-08-17 16:46:58 +00001808//===--- CHECK: Return Address of Stack Variable --------------------------===//
1809
1810static DeclRefExpr* EvalVal(Expr *E);
1811static DeclRefExpr* EvalAddr(Expr* E);
1812
1813/// CheckReturnStackAddr - Check if a return statement returns the address
1814/// of a stack variable.
1815void
1816Sema::CheckReturnStackAddr(Expr *RetValExp, QualType lhsType,
1817 SourceLocation ReturnLoc) {
Mike Stump1eb44332009-09-09 15:08:12 +00001818
Ted Kremenek06de2762007-08-17 16:46:58 +00001819 // Perform checking for returned stack addresses.
Steve Naroffdd972f22008-09-05 22:11:13 +00001820 if (lhsType->isPointerType() || lhsType->isBlockPointerType()) {
Ted Kremenek06de2762007-08-17 16:46:58 +00001821 if (DeclRefExpr *DR = EvalAddr(RetValExp))
Chris Lattner3c73c412008-11-19 08:23:25 +00001822 Diag(DR->getLocStart(), diag::warn_ret_stack_addr)
Chris Lattner08631c52008-11-23 21:45:46 +00001823 << DR->getDecl()->getDeclName() << RetValExp->getSourceRange();
Mike Stump1eb44332009-09-09 15:08:12 +00001824
Steve Naroffc50a4a52008-09-16 22:25:10 +00001825 // Skip over implicit cast expressions when checking for block expressions.
Chris Lattner4ca606e2009-09-08 00:36:37 +00001826 RetValExp = RetValExp->IgnoreParenCasts();
Steve Naroffc50a4a52008-09-16 22:25:10 +00001827
Chris Lattner9e6b37a2009-10-30 04:01:58 +00001828 if (BlockExpr *C = dyn_cast<BlockExpr>(RetValExp))
Mike Stump397195b2009-04-17 00:09:41 +00001829 if (C->hasBlockDeclRefExprs())
1830 Diag(C->getLocStart(), diag::err_ret_local_block)
1831 << C->getSourceRange();
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001832
Chris Lattner9e6b37a2009-10-30 04:01:58 +00001833 if (AddrLabelExpr *ALE = dyn_cast<AddrLabelExpr>(RetValExp))
1834 Diag(ALE->getLocStart(), diag::warn_ret_addr_label)
1835 << ALE->getSourceRange();
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001836
Mike Stumpac5fc7c2009-08-04 21:02:39 +00001837 } else if (lhsType->isReferenceType()) {
1838 // Perform checking for stack values returned by reference.
Douglas Gregor49badde2008-10-27 19:41:14 +00001839 // Check for a reference to the stack
1840 if (DeclRefExpr *DR = EvalVal(RetValExp))
Chris Lattnerdcd5ef12008-11-19 05:27:50 +00001841 Diag(DR->getLocStart(), diag::warn_ret_stack_ref)
Chris Lattner08631c52008-11-23 21:45:46 +00001842 << DR->getDecl()->getDeclName() << RetValExp->getSourceRange();
Ted Kremenek06de2762007-08-17 16:46:58 +00001843 }
1844}
1845
1846/// EvalAddr - EvalAddr and EvalVal are mutually recursive functions that
1847/// check if the expression in a return statement evaluates to an address
1848/// to a location on the stack. The recursion is used to traverse the
1849/// AST of the return expression, with recursion backtracking when we
1850/// encounter a subexpression that (1) clearly does not lead to the address
1851/// of a stack variable or (2) is something we cannot determine leads to
1852/// the address of a stack variable based on such local checking.
1853///
Ted Kremeneke8c600f2007-08-28 17:02:55 +00001854/// EvalAddr processes expressions that are pointers that are used as
1855/// references (and not L-values). EvalVal handles all other values.
Mike Stump1eb44332009-09-09 15:08:12 +00001856/// At the base case of the recursion is a check for a DeclRefExpr* in
Ted Kremenek06de2762007-08-17 16:46:58 +00001857/// the refers to a stack variable.
1858///
1859/// This implementation handles:
1860///
1861/// * pointer-to-pointer casts
1862/// * implicit conversions from array references to pointers
1863/// * taking the address of fields
1864/// * arbitrary interplay between "&" and "*" operators
1865/// * pointer arithmetic from an address of a stack variable
1866/// * taking the address of an array element where the array is on the stack
1867static DeclRefExpr* EvalAddr(Expr *E) {
Ted Kremenek06de2762007-08-17 16:46:58 +00001868 // We should only be called for evaluating pointer expressions.
David Chisnall0f436562009-08-17 16:35:33 +00001869 assert((E->getType()->isAnyPointerType() ||
Steve Naroffdd972f22008-09-05 22:11:13 +00001870 E->getType()->isBlockPointerType() ||
Ted Kremeneka526c5c2008-01-07 19:49:32 +00001871 E->getType()->isObjCQualifiedIdType()) &&
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001872 "EvalAddr only works on pointers");
Mike Stump1eb44332009-09-09 15:08:12 +00001873
Ted Kremenek06de2762007-08-17 16:46:58 +00001874 // Our "symbolic interpreter" is just a dispatch off the currently
1875 // viewed AST node. We then recursively traverse the AST by calling
1876 // EvalAddr and EvalVal appropriately.
1877 switch (E->getStmtClass()) {
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001878 case Stmt::ParenExprClass:
1879 // Ignore parentheses.
1880 return EvalAddr(cast<ParenExpr>(E)->getSubExpr());
Ted Kremenek06de2762007-08-17 16:46:58 +00001881
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001882 case Stmt::UnaryOperatorClass: {
1883 // The only unary operator that make sense to handle here
1884 // is AddrOf. All others don't make sense as pointers.
1885 UnaryOperator *U = cast<UnaryOperator>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00001886
John McCall2de56d12010-08-25 11:45:40 +00001887 if (U->getOpcode() == UO_AddrOf)
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001888 return EvalVal(U->getSubExpr());
1889 else
Ted Kremenek06de2762007-08-17 16:46:58 +00001890 return NULL;
1891 }
Mike Stump1eb44332009-09-09 15:08:12 +00001892
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001893 case Stmt::BinaryOperatorClass: {
1894 // Handle pointer arithmetic. All other binary operators are not valid
1895 // in this context.
1896 BinaryOperator *B = cast<BinaryOperator>(E);
John McCall2de56d12010-08-25 11:45:40 +00001897 BinaryOperatorKind op = B->getOpcode();
Mike Stump1eb44332009-09-09 15:08:12 +00001898
John McCall2de56d12010-08-25 11:45:40 +00001899 if (op != BO_Add && op != BO_Sub)
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001900 return NULL;
Mike Stump1eb44332009-09-09 15:08:12 +00001901
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001902 Expr *Base = B->getLHS();
1903
1904 // Determine which argument is the real pointer base. It could be
1905 // the RHS argument instead of the LHS.
1906 if (!Base->getType()->isPointerType()) Base = B->getRHS();
Mike Stump1eb44332009-09-09 15:08:12 +00001907
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001908 assert (Base->getType()->isPointerType());
1909 return EvalAddr(Base);
1910 }
Steve Naroff61f40a22008-09-10 19:17:48 +00001911
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001912 // For conditional operators we need to see if either the LHS or RHS are
1913 // valid DeclRefExpr*s. If one of them is valid, we return it.
1914 case Stmt::ConditionalOperatorClass: {
1915 ConditionalOperator *C = cast<ConditionalOperator>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00001916
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001917 // Handle the GNU extension for missing LHS.
1918 if (Expr *lhsExpr = C->getLHS())
1919 if (DeclRefExpr* LHS = EvalAddr(lhsExpr))
1920 return LHS;
1921
1922 return EvalAddr(C->getRHS());
1923 }
Mike Stump1eb44332009-09-09 15:08:12 +00001924
Ted Kremenek54b52742008-08-07 00:49:01 +00001925 // For casts, we need to handle conversions from arrays to
1926 // pointer values, and pointer-to-pointer conversions.
Douglas Gregor49badde2008-10-27 19:41:14 +00001927 case Stmt::ImplicitCastExprClass:
Douglas Gregor6eec8e82008-10-28 15:36:24 +00001928 case Stmt::CStyleCastExprClass:
Douglas Gregor49badde2008-10-27 19:41:14 +00001929 case Stmt::CXXFunctionalCastExprClass: {
Argyrios Kyrtzidis0835a3c2008-08-18 23:01:59 +00001930 Expr* SubExpr = cast<CastExpr>(E)->getSubExpr();
Ted Kremenek54b52742008-08-07 00:49:01 +00001931 QualType T = SubExpr->getType();
Mike Stump1eb44332009-09-09 15:08:12 +00001932
Steve Naroffdd972f22008-09-05 22:11:13 +00001933 if (SubExpr->getType()->isPointerType() ||
1934 SubExpr->getType()->isBlockPointerType() ||
1935 SubExpr->getType()->isObjCQualifiedIdType())
Ted Kremenek54b52742008-08-07 00:49:01 +00001936 return EvalAddr(SubExpr);
1937 else if (T->isArrayType())
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001938 return EvalVal(SubExpr);
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001939 else
Ted Kremenek54b52742008-08-07 00:49:01 +00001940 return 0;
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001941 }
Mike Stump1eb44332009-09-09 15:08:12 +00001942
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001943 // C++ casts. For dynamic casts, static casts, and const casts, we
1944 // are always converting from a pointer-to-pointer, so we just blow
Douglas Gregor49badde2008-10-27 19:41:14 +00001945 // through the cast. In the case the dynamic cast doesn't fail (and
1946 // return NULL), we take the conservative route and report cases
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001947 // where we return the address of a stack variable. For Reinterpre
Douglas Gregor49badde2008-10-27 19:41:14 +00001948 // FIXME: The comment about is wrong; we're not always converting
1949 // from pointer to pointer. I'm guessing that this code should also
Mike Stump1eb44332009-09-09 15:08:12 +00001950 // handle references to objects.
1951 case Stmt::CXXStaticCastExprClass:
1952 case Stmt::CXXDynamicCastExprClass:
Douglas Gregor49badde2008-10-27 19:41:14 +00001953 case Stmt::CXXConstCastExprClass:
1954 case Stmt::CXXReinterpretCastExprClass: {
1955 Expr *S = cast<CXXNamedCastExpr>(E)->getSubExpr();
Steve Naroffdd972f22008-09-05 22:11:13 +00001956 if (S->getType()->isPointerType() || S->getType()->isBlockPointerType())
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001957 return EvalAddr(S);
1958 else
1959 return NULL;
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001960 }
Mike Stump1eb44332009-09-09 15:08:12 +00001961
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001962 // Everything else: we simply don't reason about them.
1963 default:
1964 return NULL;
1965 }
Ted Kremenek06de2762007-08-17 16:46:58 +00001966}
Mike Stump1eb44332009-09-09 15:08:12 +00001967
Ted Kremenek06de2762007-08-17 16:46:58 +00001968
1969/// EvalVal - This function is complements EvalAddr in the mutual recursion.
1970/// See the comments for EvalAddr for more details.
1971static DeclRefExpr* EvalVal(Expr *E) {
Ted Kremenek68957a92010-08-04 20:01:07 +00001972do {
Ted Kremeneke8c600f2007-08-28 17:02:55 +00001973 // We should only be called for evaluating non-pointer expressions, or
1974 // expressions with a pointer type that are not used as references but instead
1975 // are l-values (e.g., DeclRefExpr with a pointer type).
Mike Stump1eb44332009-09-09 15:08:12 +00001976
Ted Kremenek06de2762007-08-17 16:46:58 +00001977 // Our "symbolic interpreter" is just a dispatch off the currently
1978 // viewed AST node. We then recursively traverse the AST by calling
1979 // EvalAddr and EvalVal appropriately.
1980 switch (E->getStmtClass()) {
Ted Kremenek68957a92010-08-04 20:01:07 +00001981 case Stmt::ImplicitCastExprClass: {
1982 ImplicitCastExpr *IE = cast<ImplicitCastExpr>(E);
John McCall5baba9d2010-08-25 10:28:54 +00001983 if (IE->getValueKind() == VK_LValue) {
Ted Kremenek68957a92010-08-04 20:01:07 +00001984 E = IE->getSubExpr();
1985 continue;
1986 }
1987 return NULL;
1988 }
1989
Douglas Gregora2813ce2009-10-23 18:54:35 +00001990 case Stmt::DeclRefExprClass: {
Ted Kremenek06de2762007-08-17 16:46:58 +00001991 // DeclRefExpr: the base case. When we hit a DeclRefExpr we are looking
1992 // at code that refers to a variable's name. We check if it has local
1993 // storage within the function, and if so, return the expression.
1994 DeclRefExpr *DR = cast<DeclRefExpr>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00001995
Ted Kremenek06de2762007-08-17 16:46:58 +00001996 if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl()))
Mike Stump1eb44332009-09-09 15:08:12 +00001997 if (V->hasLocalStorage() && !V->getType()->isReferenceType()) return DR;
1998
Ted Kremenek06de2762007-08-17 16:46:58 +00001999 return NULL;
2000 }
Mike Stump1eb44332009-09-09 15:08:12 +00002001
Ted Kremenek68957a92010-08-04 20:01:07 +00002002 case Stmt::ParenExprClass: {
Ted Kremenek06de2762007-08-17 16:46:58 +00002003 // Ignore parentheses.
Ted Kremenek68957a92010-08-04 20:01:07 +00002004 E = cast<ParenExpr>(E)->getSubExpr();
2005 continue;
2006 }
Mike Stump1eb44332009-09-09 15:08:12 +00002007
Ted Kremenek06de2762007-08-17 16:46:58 +00002008 case Stmt::UnaryOperatorClass: {
2009 // The only unary operator that make sense to handle here
2010 // is Deref. All others don't resolve to a "name." This includes
2011 // handling all sorts of rvalues passed to a unary operator.
2012 UnaryOperator *U = cast<UnaryOperator>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00002013
John McCall2de56d12010-08-25 11:45:40 +00002014 if (U->getOpcode() == UO_Deref)
Ted Kremenek06de2762007-08-17 16:46:58 +00002015 return EvalAddr(U->getSubExpr());
2016
2017 return NULL;
2018 }
Mike Stump1eb44332009-09-09 15:08:12 +00002019
Ted Kremenek06de2762007-08-17 16:46:58 +00002020 case Stmt::ArraySubscriptExprClass: {
2021 // Array subscripts are potential references to data on the stack. We
2022 // retrieve the DeclRefExpr* for the array variable if it indeed
2023 // has local storage.
Ted Kremenek23245122007-08-20 16:18:38 +00002024 return EvalAddr(cast<ArraySubscriptExpr>(E)->getBase());
Ted Kremenek06de2762007-08-17 16:46:58 +00002025 }
Mike Stump1eb44332009-09-09 15:08:12 +00002026
Ted Kremenek06de2762007-08-17 16:46:58 +00002027 case Stmt::ConditionalOperatorClass: {
2028 // For conditional operators we need to see if either the LHS or RHS are
2029 // non-NULL DeclRefExpr's. If one is non-NULL, we return it.
2030 ConditionalOperator *C = cast<ConditionalOperator>(E);
2031
Anders Carlsson39073232007-11-30 19:04:31 +00002032 // Handle the GNU extension for missing LHS.
2033 if (Expr *lhsExpr = C->getLHS())
2034 if (DeclRefExpr *LHS = EvalVal(lhsExpr))
2035 return LHS;
2036
2037 return EvalVal(C->getRHS());
Ted Kremenek06de2762007-08-17 16:46:58 +00002038 }
Mike Stump1eb44332009-09-09 15:08:12 +00002039
Ted Kremenek06de2762007-08-17 16:46:58 +00002040 // Accesses to members are potential references to data on the stack.
Douglas Gregor83f6faf2009-08-31 23:41:50 +00002041 case Stmt::MemberExprClass: {
Ted Kremenek06de2762007-08-17 16:46:58 +00002042 MemberExpr *M = cast<MemberExpr>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00002043
Ted Kremenek06de2762007-08-17 16:46:58 +00002044 // Check for indirect access. We only want direct field accesses.
Ted Kremeneka423e812010-09-02 01:12:13 +00002045 if (M->isArrow())
Ted Kremenek06de2762007-08-17 16:46:58 +00002046 return NULL;
Ted Kremeneka423e812010-09-02 01:12:13 +00002047
2048 // Check whether the member type is itself a reference, in which case
2049 // we're not going to refer to the member, but to what the member refers to.
2050 if (M->getMemberDecl()->getType()->isReferenceType())
2051 return NULL;
2052
2053 return EvalVal(M->getBase());
Ted Kremenek06de2762007-08-17 16:46:58 +00002054 }
Mike Stump1eb44332009-09-09 15:08:12 +00002055
Ted Kremenek06de2762007-08-17 16:46:58 +00002056 // Everything else: we simply don't reason about them.
2057 default:
2058 return NULL;
2059 }
Ted Kremenek68957a92010-08-04 20:01:07 +00002060} while (true);
Ted Kremenek06de2762007-08-17 16:46:58 +00002061}
Ted Kremenek588e5eb2007-11-25 00:58:00 +00002062
2063//===--- CHECK: Floating-Point comparisons (-Wfloat-equal) ---------------===//
2064
2065/// Check for comparisons of floating point operands using != and ==.
2066/// Issue a warning if these are no self-comparisons, as they are not likely
2067/// to do what the programmer intended.
2068void Sema::CheckFloatComparison(SourceLocation loc, Expr* lex, Expr *rex) {
2069 bool EmitWarning = true;
Mike Stump1eb44332009-09-09 15:08:12 +00002070
Ted Kremenek4e99a5f2008-01-17 16:57:34 +00002071 Expr* LeftExprSansParen = lex->IgnoreParens();
Ted Kremenek32e97b62008-01-17 17:55:13 +00002072 Expr* RightExprSansParen = rex->IgnoreParens();
Ted Kremenek588e5eb2007-11-25 00:58:00 +00002073
2074 // Special case: check for x == x (which is OK).
2075 // Do not emit warnings for such cases.
2076 if (DeclRefExpr* DRL = dyn_cast<DeclRefExpr>(LeftExprSansParen))
2077 if (DeclRefExpr* DRR = dyn_cast<DeclRefExpr>(RightExprSansParen))
2078 if (DRL->getDecl() == DRR->getDecl())
2079 EmitWarning = false;
Mike Stump1eb44332009-09-09 15:08:12 +00002080
2081
Ted Kremenek1b500bb2007-11-29 00:59:04 +00002082 // Special case: check for comparisons against literals that can be exactly
2083 // represented by APFloat. In such cases, do not emit a warning. This
2084 // is a heuristic: often comparison against such literals are used to
2085 // detect if a value in a variable has not changed. This clearly can
2086 // lead to false negatives.
2087 if (EmitWarning) {
2088 if (FloatingLiteral* FLL = dyn_cast<FloatingLiteral>(LeftExprSansParen)) {
2089 if (FLL->isExact())
2090 EmitWarning = false;
Mike Stumpac5fc7c2009-08-04 21:02:39 +00002091 } else
Ted Kremenek1b500bb2007-11-29 00:59:04 +00002092 if (FloatingLiteral* FLR = dyn_cast<FloatingLiteral>(RightExprSansParen)){
2093 if (FLR->isExact())
2094 EmitWarning = false;
2095 }
2096 }
Mike Stump1eb44332009-09-09 15:08:12 +00002097
Ted Kremenek588e5eb2007-11-25 00:58:00 +00002098 // Check for comparisons with builtin types.
Sebastian Redl0eb23302009-01-19 00:08:26 +00002099 if (EmitWarning)
Ted Kremenek588e5eb2007-11-25 00:58:00 +00002100 if (CallExpr* CL = dyn_cast<CallExpr>(LeftExprSansParen))
Douglas Gregor3c385e52009-02-14 18:57:46 +00002101 if (CL->isBuiltinCall(Context))
Ted Kremenek588e5eb2007-11-25 00:58:00 +00002102 EmitWarning = false;
Mike Stump1eb44332009-09-09 15:08:12 +00002103
Sebastian Redl0eb23302009-01-19 00:08:26 +00002104 if (EmitWarning)
Ted Kremenek588e5eb2007-11-25 00:58:00 +00002105 if (CallExpr* CR = dyn_cast<CallExpr>(RightExprSansParen))
Douglas Gregor3c385e52009-02-14 18:57:46 +00002106 if (CR->isBuiltinCall(Context))
Ted Kremenek588e5eb2007-11-25 00:58:00 +00002107 EmitWarning = false;
Mike Stump1eb44332009-09-09 15:08:12 +00002108
Ted Kremenek588e5eb2007-11-25 00:58:00 +00002109 // Emit the diagnostic.
2110 if (EmitWarning)
Chris Lattnerfa25bbb2008-11-19 05:08:23 +00002111 Diag(loc, diag::warn_floatingpoint_eq)
2112 << lex->getSourceRange() << rex->getSourceRange();
Ted Kremenek588e5eb2007-11-25 00:58:00 +00002113}
John McCallba26e582010-01-04 23:21:16 +00002114
John McCallf2370c92010-01-06 05:24:50 +00002115//===--- CHECK: Integer mixed-sign comparisons (-Wsign-compare) --------===//
2116//===--- CHECK: Lossy implicit conversions (-Wconversion) --------------===//
John McCallba26e582010-01-04 23:21:16 +00002117
John McCallf2370c92010-01-06 05:24:50 +00002118namespace {
John McCallba26e582010-01-04 23:21:16 +00002119
John McCallf2370c92010-01-06 05:24:50 +00002120/// Structure recording the 'active' range of an integer-valued
2121/// expression.
2122struct IntRange {
2123 /// The number of bits active in the int.
2124 unsigned Width;
John McCallba26e582010-01-04 23:21:16 +00002125
John McCallf2370c92010-01-06 05:24:50 +00002126 /// True if the int is known not to have negative values.
2127 bool NonNegative;
John McCallba26e582010-01-04 23:21:16 +00002128
John McCallf2370c92010-01-06 05:24:50 +00002129 IntRange(unsigned Width, bool NonNegative)
2130 : Width(Width), NonNegative(NonNegative)
2131 {}
John McCallba26e582010-01-04 23:21:16 +00002132
John McCallf2370c92010-01-06 05:24:50 +00002133 // Returns the range of the bool type.
2134 static IntRange forBoolType() {
2135 return IntRange(1, true);
John McCall51313c32010-01-04 23:31:57 +00002136 }
2137
John McCallf2370c92010-01-06 05:24:50 +00002138 // Returns the range of an integral type.
2139 static IntRange forType(ASTContext &C, QualType T) {
2140 return forCanonicalType(C, T->getCanonicalTypeInternal().getTypePtr());
John McCall51313c32010-01-04 23:31:57 +00002141 }
2142
John McCallf2370c92010-01-06 05:24:50 +00002143 // Returns the range of an integeral type based on its canonical
2144 // representation.
2145 static IntRange forCanonicalType(ASTContext &C, const Type *T) {
2146 assert(T->isCanonicalUnqualified());
2147
2148 if (const VectorType *VT = dyn_cast<VectorType>(T))
2149 T = VT->getElementType().getTypePtr();
2150 if (const ComplexType *CT = dyn_cast<ComplexType>(T))
2151 T = CT->getElementType().getTypePtr();
John McCall323ed742010-05-06 08:58:33 +00002152
2153 if (const EnumType *ET = dyn_cast<EnumType>(T)) {
2154 EnumDecl *Enum = ET->getDecl();
2155 unsigned NumPositive = Enum->getNumPositiveBits();
2156 unsigned NumNegative = Enum->getNumNegativeBits();
2157
2158 return IntRange(std::max(NumPositive, NumNegative), NumNegative == 0);
2159 }
John McCallf2370c92010-01-06 05:24:50 +00002160
2161 const BuiltinType *BT = cast<BuiltinType>(T);
2162 assert(BT->isInteger());
2163
2164 return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger());
2165 }
2166
2167 // Returns the supremum of two ranges: i.e. their conservative merge.
John McCallc0cd21d2010-02-23 19:22:29 +00002168 static IntRange join(IntRange L, IntRange R) {
John McCallf2370c92010-01-06 05:24:50 +00002169 return IntRange(std::max(L.Width, R.Width),
John McCall60fad452010-01-06 22:07:33 +00002170 L.NonNegative && R.NonNegative);
2171 }
2172
2173 // Returns the infinum of two ranges: i.e. their aggressive merge.
John McCallc0cd21d2010-02-23 19:22:29 +00002174 static IntRange meet(IntRange L, IntRange R) {
John McCall60fad452010-01-06 22:07:33 +00002175 return IntRange(std::min(L.Width, R.Width),
2176 L.NonNegative || R.NonNegative);
John McCallf2370c92010-01-06 05:24:50 +00002177 }
2178};
2179
2180IntRange GetValueRange(ASTContext &C, llvm::APSInt &value, unsigned MaxWidth) {
2181 if (value.isSigned() && value.isNegative())
2182 return IntRange(value.getMinSignedBits(), false);
2183
2184 if (value.getBitWidth() > MaxWidth)
2185 value.trunc(MaxWidth);
2186
2187 // isNonNegative() just checks the sign bit without considering
2188 // signedness.
2189 return IntRange(value.getActiveBits(), true);
2190}
2191
John McCall0acc3112010-01-06 22:57:21 +00002192IntRange GetValueRange(ASTContext &C, APValue &result, QualType Ty,
John McCallf2370c92010-01-06 05:24:50 +00002193 unsigned MaxWidth) {
2194 if (result.isInt())
2195 return GetValueRange(C, result.getInt(), MaxWidth);
2196
2197 if (result.isVector()) {
John McCall0acc3112010-01-06 22:57:21 +00002198 IntRange R = GetValueRange(C, result.getVectorElt(0), Ty, MaxWidth);
2199 for (unsigned i = 1, e = result.getVectorLength(); i != e; ++i) {
2200 IntRange El = GetValueRange(C, result.getVectorElt(i), Ty, MaxWidth);
2201 R = IntRange::join(R, El);
2202 }
John McCallf2370c92010-01-06 05:24:50 +00002203 return R;
2204 }
2205
2206 if (result.isComplexInt()) {
2207 IntRange R = GetValueRange(C, result.getComplexIntReal(), MaxWidth);
2208 IntRange I = GetValueRange(C, result.getComplexIntImag(), MaxWidth);
2209 return IntRange::join(R, I);
John McCall51313c32010-01-04 23:31:57 +00002210 }
2211
2212 // This can happen with lossless casts to intptr_t of "based" lvalues.
2213 // Assume it might use arbitrary bits.
John McCall0acc3112010-01-06 22:57:21 +00002214 // FIXME: The only reason we need to pass the type in here is to get
2215 // the sign right on this one case. It would be nice if APValue
2216 // preserved this.
John McCallf2370c92010-01-06 05:24:50 +00002217 assert(result.isLValue());
John McCall0acc3112010-01-06 22:57:21 +00002218 return IntRange(MaxWidth, Ty->isUnsignedIntegerType());
John McCall51313c32010-01-04 23:31:57 +00002219}
John McCallf2370c92010-01-06 05:24:50 +00002220
2221/// Pseudo-evaluate the given integer expression, estimating the
2222/// range of values it might take.
2223///
2224/// \param MaxWidth - the width to which the value will be truncated
2225IntRange GetExprRange(ASTContext &C, Expr *E, unsigned MaxWidth) {
2226 E = E->IgnoreParens();
2227
2228 // Try a full evaluation first.
2229 Expr::EvalResult result;
2230 if (E->Evaluate(result, C))
John McCall0acc3112010-01-06 22:57:21 +00002231 return GetValueRange(C, result.Val, E->getType(), MaxWidth);
John McCallf2370c92010-01-06 05:24:50 +00002232
2233 // I think we only want to look through implicit casts here; if the
2234 // user has an explicit widening cast, we should treat the value as
2235 // being of the new, wider type.
2236 if (ImplicitCastExpr *CE = dyn_cast<ImplicitCastExpr>(E)) {
John McCall2de56d12010-08-25 11:45:40 +00002237 if (CE->getCastKind() == CK_NoOp)
John McCallf2370c92010-01-06 05:24:50 +00002238 return GetExprRange(C, CE->getSubExpr(), MaxWidth);
2239
2240 IntRange OutputTypeRange = IntRange::forType(C, CE->getType());
2241
John McCall2de56d12010-08-25 11:45:40 +00002242 bool isIntegerCast = (CE->getCastKind() == CK_IntegralCast);
2243 if (!isIntegerCast && CE->getCastKind() == CK_Unknown)
John McCall60fad452010-01-06 22:07:33 +00002244 isIntegerCast = CE->getSubExpr()->getType()->isIntegerType();
2245
John McCallf2370c92010-01-06 05:24:50 +00002246 // Assume that non-integer casts can span the full range of the type.
John McCall60fad452010-01-06 22:07:33 +00002247 if (!isIntegerCast)
John McCallf2370c92010-01-06 05:24:50 +00002248 return OutputTypeRange;
2249
2250 IntRange SubRange
2251 = GetExprRange(C, CE->getSubExpr(),
2252 std::min(MaxWidth, OutputTypeRange.Width));
2253
2254 // Bail out if the subexpr's range is as wide as the cast type.
2255 if (SubRange.Width >= OutputTypeRange.Width)
2256 return OutputTypeRange;
2257
2258 // Otherwise, we take the smaller width, and we're non-negative if
2259 // either the output type or the subexpr is.
2260 return IntRange(SubRange.Width,
2261 SubRange.NonNegative || OutputTypeRange.NonNegative);
2262 }
2263
2264 if (ConditionalOperator *CO = dyn_cast<ConditionalOperator>(E)) {
2265 // If we can fold the condition, just take that operand.
2266 bool CondResult;
2267 if (CO->getCond()->EvaluateAsBooleanCondition(CondResult, C))
2268 return GetExprRange(C, CondResult ? CO->getTrueExpr()
2269 : CO->getFalseExpr(),
2270 MaxWidth);
2271
2272 // Otherwise, conservatively merge.
2273 IntRange L = GetExprRange(C, CO->getTrueExpr(), MaxWidth);
2274 IntRange R = GetExprRange(C, CO->getFalseExpr(), MaxWidth);
2275 return IntRange::join(L, R);
2276 }
2277
2278 if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) {
2279 switch (BO->getOpcode()) {
2280
2281 // Boolean-valued operations are single-bit and positive.
John McCall2de56d12010-08-25 11:45:40 +00002282 case BO_LAnd:
2283 case BO_LOr:
2284 case BO_LT:
2285 case BO_GT:
2286 case BO_LE:
2287 case BO_GE:
2288 case BO_EQ:
2289 case BO_NE:
John McCallf2370c92010-01-06 05:24:50 +00002290 return IntRange::forBoolType();
2291
John McCallc0cd21d2010-02-23 19:22:29 +00002292 // The type of these compound assignments is the type of the LHS,
2293 // so the RHS is not necessarily an integer.
John McCall2de56d12010-08-25 11:45:40 +00002294 case BO_MulAssign:
2295 case BO_DivAssign:
2296 case BO_RemAssign:
2297 case BO_AddAssign:
2298 case BO_SubAssign:
John McCallc0cd21d2010-02-23 19:22:29 +00002299 return IntRange::forType(C, E->getType());
2300
John McCallf2370c92010-01-06 05:24:50 +00002301 // Operations with opaque sources are black-listed.
John McCall2de56d12010-08-25 11:45:40 +00002302 case BO_PtrMemD:
2303 case BO_PtrMemI:
John McCallf2370c92010-01-06 05:24:50 +00002304 return IntRange::forType(C, E->getType());
2305
John McCall60fad452010-01-06 22:07:33 +00002306 // Bitwise-and uses the *infinum* of the two source ranges.
John McCall2de56d12010-08-25 11:45:40 +00002307 case BO_And:
2308 case BO_AndAssign:
John McCall60fad452010-01-06 22:07:33 +00002309 return IntRange::meet(GetExprRange(C, BO->getLHS(), MaxWidth),
2310 GetExprRange(C, BO->getRHS(), MaxWidth));
2311
John McCallf2370c92010-01-06 05:24:50 +00002312 // Left shift gets black-listed based on a judgement call.
John McCall2de56d12010-08-25 11:45:40 +00002313 case BO_Shl:
John McCall3aae6092010-04-07 01:14:35 +00002314 // ...except that we want to treat '1 << (blah)' as logically
2315 // positive. It's an important idiom.
2316 if (IntegerLiteral *I
2317 = dyn_cast<IntegerLiteral>(BO->getLHS()->IgnoreParenCasts())) {
2318 if (I->getValue() == 1) {
2319 IntRange R = IntRange::forType(C, E->getType());
2320 return IntRange(R.Width, /*NonNegative*/ true);
2321 }
2322 }
2323 // fallthrough
2324
John McCall2de56d12010-08-25 11:45:40 +00002325 case BO_ShlAssign:
John McCallf2370c92010-01-06 05:24:50 +00002326 return IntRange::forType(C, E->getType());
2327
John McCall60fad452010-01-06 22:07:33 +00002328 // Right shift by a constant can narrow its left argument.
John McCall2de56d12010-08-25 11:45:40 +00002329 case BO_Shr:
2330 case BO_ShrAssign: {
John McCall60fad452010-01-06 22:07:33 +00002331 IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth);
2332
2333 // If the shift amount is a positive constant, drop the width by
2334 // that much.
2335 llvm::APSInt shift;
2336 if (BO->getRHS()->isIntegerConstantExpr(shift, C) &&
2337 shift.isNonNegative()) {
2338 unsigned zext = shift.getZExtValue();
2339 if (zext >= L.Width)
2340 L.Width = (L.NonNegative ? 0 : 1);
2341 else
2342 L.Width -= zext;
2343 }
2344
2345 return L;
2346 }
2347
2348 // Comma acts as its right operand.
John McCall2de56d12010-08-25 11:45:40 +00002349 case BO_Comma:
John McCallf2370c92010-01-06 05:24:50 +00002350 return GetExprRange(C, BO->getRHS(), MaxWidth);
2351
John McCall60fad452010-01-06 22:07:33 +00002352 // Black-list pointer subtractions.
John McCall2de56d12010-08-25 11:45:40 +00002353 case BO_Sub:
John McCallf2370c92010-01-06 05:24:50 +00002354 if (BO->getLHS()->getType()->isPointerType())
2355 return IntRange::forType(C, E->getType());
2356 // fallthrough
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00002357
John McCallf2370c92010-01-06 05:24:50 +00002358 default:
2359 break;
2360 }
2361
2362 // Treat every other operator as if it were closed on the
2363 // narrowest type that encompasses both operands.
2364 IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth);
2365 IntRange R = GetExprRange(C, BO->getRHS(), MaxWidth);
2366 return IntRange::join(L, R);
2367 }
2368
2369 if (UnaryOperator *UO = dyn_cast<UnaryOperator>(E)) {
2370 switch (UO->getOpcode()) {
2371 // Boolean-valued operations are white-listed.
John McCall2de56d12010-08-25 11:45:40 +00002372 case UO_LNot:
John McCallf2370c92010-01-06 05:24:50 +00002373 return IntRange::forBoolType();
2374
2375 // Operations with opaque sources are black-listed.
John McCall2de56d12010-08-25 11:45:40 +00002376 case UO_Deref:
2377 case UO_AddrOf: // should be impossible
John McCallf2370c92010-01-06 05:24:50 +00002378 return IntRange::forType(C, E->getType());
2379
2380 default:
2381 return GetExprRange(C, UO->getSubExpr(), MaxWidth);
2382 }
2383 }
Douglas Gregor8ecdb652010-04-28 22:16:22 +00002384
2385 if (dyn_cast<OffsetOfExpr>(E)) {
2386 IntRange::forType(C, E->getType());
2387 }
John McCallf2370c92010-01-06 05:24:50 +00002388
2389 FieldDecl *BitField = E->getBitField();
2390 if (BitField) {
2391 llvm::APSInt BitWidthAP = BitField->getBitWidth()->EvaluateAsInt(C);
2392 unsigned BitWidth = BitWidthAP.getZExtValue();
2393
2394 return IntRange(BitWidth, BitField->getType()->isUnsignedIntegerType());
2395 }
2396
2397 return IntRange::forType(C, E->getType());
2398}
John McCall51313c32010-01-04 23:31:57 +00002399
John McCall323ed742010-05-06 08:58:33 +00002400IntRange GetExprRange(ASTContext &C, Expr *E) {
2401 return GetExprRange(C, E, C.getIntWidth(E->getType()));
2402}
2403
John McCall51313c32010-01-04 23:31:57 +00002404/// Checks whether the given value, which currently has the given
2405/// source semantics, has the same value when coerced through the
2406/// target semantics.
John McCallf2370c92010-01-06 05:24:50 +00002407bool IsSameFloatAfterCast(const llvm::APFloat &value,
2408 const llvm::fltSemantics &Src,
2409 const llvm::fltSemantics &Tgt) {
John McCall51313c32010-01-04 23:31:57 +00002410 llvm::APFloat truncated = value;
2411
2412 bool ignored;
2413 truncated.convert(Src, llvm::APFloat::rmNearestTiesToEven, &ignored);
2414 truncated.convert(Tgt, llvm::APFloat::rmNearestTiesToEven, &ignored);
2415
2416 return truncated.bitwiseIsEqual(value);
2417}
2418
2419/// Checks whether the given value, which currently has the given
2420/// source semantics, has the same value when coerced through the
2421/// target semantics.
2422///
2423/// The value might be a vector of floats (or a complex number).
John McCallf2370c92010-01-06 05:24:50 +00002424bool IsSameFloatAfterCast(const APValue &value,
2425 const llvm::fltSemantics &Src,
2426 const llvm::fltSemantics &Tgt) {
John McCall51313c32010-01-04 23:31:57 +00002427 if (value.isFloat())
2428 return IsSameFloatAfterCast(value.getFloat(), Src, Tgt);
2429
2430 if (value.isVector()) {
2431 for (unsigned i = 0, e = value.getVectorLength(); i != e; ++i)
2432 if (!IsSameFloatAfterCast(value.getVectorElt(i), Src, Tgt))
2433 return false;
2434 return true;
2435 }
2436
2437 assert(value.isComplexFloat());
2438 return (IsSameFloatAfterCast(value.getComplexFloatReal(), Src, Tgt) &&
2439 IsSameFloatAfterCast(value.getComplexFloatImag(), Src, Tgt));
2440}
2441
John McCall323ed742010-05-06 08:58:33 +00002442void AnalyzeImplicitConversions(Sema &S, Expr *E);
2443
2444bool IsZero(Sema &S, Expr *E) {
2445 llvm::APSInt Value;
2446 return E->isIntegerConstantExpr(Value, S.Context) && Value == 0;
2447}
2448
2449void CheckTrivialUnsignedComparison(Sema &S, BinaryOperator *E) {
John McCall2de56d12010-08-25 11:45:40 +00002450 BinaryOperatorKind op = E->getOpcode();
2451 if (op == BO_LT && IsZero(S, E->getRHS())) {
John McCall323ed742010-05-06 08:58:33 +00002452 S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison)
2453 << "< 0" << "false"
2454 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
John McCall2de56d12010-08-25 11:45:40 +00002455 } else if (op == BO_GE && IsZero(S, E->getRHS())) {
John McCall323ed742010-05-06 08:58:33 +00002456 S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison)
2457 << ">= 0" << "true"
2458 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
John McCall2de56d12010-08-25 11:45:40 +00002459 } else if (op == BO_GT && IsZero(S, E->getLHS())) {
John McCall323ed742010-05-06 08:58:33 +00002460 S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison)
2461 << "0 >" << "false"
2462 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
John McCall2de56d12010-08-25 11:45:40 +00002463 } else if (op == BO_LE && IsZero(S, E->getLHS())) {
John McCall323ed742010-05-06 08:58:33 +00002464 S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison)
2465 << "0 <=" << "true"
2466 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
2467 }
2468}
2469
2470/// Analyze the operands of the given comparison. Implements the
2471/// fallback case from AnalyzeComparison.
2472void AnalyzeImpConvsInComparison(Sema &S, BinaryOperator *E) {
2473 AnalyzeImplicitConversions(S, E->getLHS());
2474 AnalyzeImplicitConversions(S, E->getRHS());
2475}
John McCall51313c32010-01-04 23:31:57 +00002476
John McCallba26e582010-01-04 23:21:16 +00002477/// \brief Implements -Wsign-compare.
2478///
2479/// \param lex the left-hand expression
2480/// \param rex the right-hand expression
2481/// \param OpLoc the location of the joining operator
John McCalld1b47bf2010-03-11 19:43:18 +00002482/// \param BinOpc binary opcode or 0
John McCall323ed742010-05-06 08:58:33 +00002483void AnalyzeComparison(Sema &S, BinaryOperator *E) {
2484 // The type the comparison is being performed in.
2485 QualType T = E->getLHS()->getType();
2486 assert(S.Context.hasSameUnqualifiedType(T, E->getRHS()->getType())
2487 && "comparison with mismatched types");
John McCallba26e582010-01-04 23:21:16 +00002488
John McCall323ed742010-05-06 08:58:33 +00002489 // We don't do anything special if this isn't an unsigned integral
2490 // comparison: we're only interested in integral comparisons, and
2491 // signed comparisons only happen in cases we don't care to warn about.
Douglas Gregorf6094622010-07-23 15:58:24 +00002492 if (!T->hasUnsignedIntegerRepresentation())
John McCall323ed742010-05-06 08:58:33 +00002493 return AnalyzeImpConvsInComparison(S, E);
John McCallf2370c92010-01-06 05:24:50 +00002494
John McCall323ed742010-05-06 08:58:33 +00002495 Expr *lex = E->getLHS()->IgnoreParenImpCasts();
2496 Expr *rex = E->getRHS()->IgnoreParenImpCasts();
John McCallba26e582010-01-04 23:21:16 +00002497
John McCall323ed742010-05-06 08:58:33 +00002498 // Check to see if one of the (unmodified) operands is of different
2499 // signedness.
2500 Expr *signedOperand, *unsignedOperand;
Douglas Gregorf6094622010-07-23 15:58:24 +00002501 if (lex->getType()->hasSignedIntegerRepresentation()) {
2502 assert(!rex->getType()->hasSignedIntegerRepresentation() &&
John McCall323ed742010-05-06 08:58:33 +00002503 "unsigned comparison between two signed integer expressions?");
2504 signedOperand = lex;
2505 unsignedOperand = rex;
Douglas Gregorf6094622010-07-23 15:58:24 +00002506 } else if (rex->getType()->hasSignedIntegerRepresentation()) {
John McCall323ed742010-05-06 08:58:33 +00002507 signedOperand = rex;
2508 unsignedOperand = lex;
John McCallba26e582010-01-04 23:21:16 +00002509 } else {
John McCall323ed742010-05-06 08:58:33 +00002510 CheckTrivialUnsignedComparison(S, E);
2511 return AnalyzeImpConvsInComparison(S, E);
John McCallba26e582010-01-04 23:21:16 +00002512 }
2513
John McCall323ed742010-05-06 08:58:33 +00002514 // Otherwise, calculate the effective range of the signed operand.
2515 IntRange signedRange = GetExprRange(S.Context, signedOperand);
John McCallf2370c92010-01-06 05:24:50 +00002516
John McCall323ed742010-05-06 08:58:33 +00002517 // Go ahead and analyze implicit conversions in the operands. Note
2518 // that we skip the implicit conversions on both sides.
2519 AnalyzeImplicitConversions(S, lex);
2520 AnalyzeImplicitConversions(S, rex);
John McCallba26e582010-01-04 23:21:16 +00002521
John McCall323ed742010-05-06 08:58:33 +00002522 // If the signed range is non-negative, -Wsign-compare won't fire,
2523 // but we should still check for comparisons which are always true
2524 // or false.
2525 if (signedRange.NonNegative)
2526 return CheckTrivialUnsignedComparison(S, E);
John McCallba26e582010-01-04 23:21:16 +00002527
2528 // For (in)equality comparisons, if the unsigned operand is a
2529 // constant which cannot collide with a overflowed signed operand,
2530 // then reinterpreting the signed operand as unsigned will not
2531 // change the result of the comparison.
John McCall323ed742010-05-06 08:58:33 +00002532 if (E->isEqualityOp()) {
2533 unsigned comparisonWidth = S.Context.getIntWidth(T);
2534 IntRange unsignedRange = GetExprRange(S.Context, unsignedOperand);
John McCallba26e582010-01-04 23:21:16 +00002535
John McCall323ed742010-05-06 08:58:33 +00002536 // We should never be unable to prove that the unsigned operand is
2537 // non-negative.
2538 assert(unsignedRange.NonNegative && "unsigned range includes negative?");
2539
2540 if (unsignedRange.Width < comparisonWidth)
2541 return;
2542 }
2543
2544 S.Diag(E->getOperatorLoc(), diag::warn_mixed_sign_comparison)
2545 << lex->getType() << rex->getType()
2546 << lex->getSourceRange() << rex->getSourceRange();
John McCallba26e582010-01-04 23:21:16 +00002547}
2548
John McCall51313c32010-01-04 23:31:57 +00002549/// Diagnose an implicit cast; purely a helper for CheckImplicitConversion.
John McCall323ed742010-05-06 08:58:33 +00002550void DiagnoseImpCast(Sema &S, Expr *E, QualType T, unsigned diag) {
John McCall51313c32010-01-04 23:31:57 +00002551 S.Diag(E->getExprLoc(), diag) << E->getType() << T << E->getSourceRange();
2552}
2553
John McCall323ed742010-05-06 08:58:33 +00002554void CheckImplicitConversion(Sema &S, Expr *E, QualType T,
2555 bool *ICContext = 0) {
2556 if (E->isTypeDependent() || E->isValueDependent()) return;
John McCall51313c32010-01-04 23:31:57 +00002557
John McCall323ed742010-05-06 08:58:33 +00002558 const Type *Source = S.Context.getCanonicalType(E->getType()).getTypePtr();
2559 const Type *Target = S.Context.getCanonicalType(T).getTypePtr();
2560 if (Source == Target) return;
2561 if (Target->isDependentType()) return;
John McCall51313c32010-01-04 23:31:57 +00002562
2563 // Never diagnose implicit casts to bool.
2564 if (Target->isSpecificBuiltinType(BuiltinType::Bool))
2565 return;
2566
2567 // Strip vector types.
2568 if (isa<VectorType>(Source)) {
2569 if (!isa<VectorType>(Target))
John McCall323ed742010-05-06 08:58:33 +00002570 return DiagnoseImpCast(S, E, T, diag::warn_impcast_vector_scalar);
John McCall51313c32010-01-04 23:31:57 +00002571
2572 Source = cast<VectorType>(Source)->getElementType().getTypePtr();
2573 Target = cast<VectorType>(Target)->getElementType().getTypePtr();
2574 }
2575
2576 // Strip complex types.
2577 if (isa<ComplexType>(Source)) {
2578 if (!isa<ComplexType>(Target))
John McCall323ed742010-05-06 08:58:33 +00002579 return DiagnoseImpCast(S, E, T, diag::warn_impcast_complex_scalar);
John McCall51313c32010-01-04 23:31:57 +00002580
2581 Source = cast<ComplexType>(Source)->getElementType().getTypePtr();
2582 Target = cast<ComplexType>(Target)->getElementType().getTypePtr();
2583 }
2584
2585 const BuiltinType *SourceBT = dyn_cast<BuiltinType>(Source);
2586 const BuiltinType *TargetBT = dyn_cast<BuiltinType>(Target);
2587
2588 // If the source is floating point...
2589 if (SourceBT && SourceBT->isFloatingPoint()) {
2590 // ...and the target is floating point...
2591 if (TargetBT && TargetBT->isFloatingPoint()) {
2592 // ...then warn if we're dropping FP rank.
2593
2594 // Builtin FP kinds are ordered by increasing FP rank.
2595 if (SourceBT->getKind() > TargetBT->getKind()) {
2596 // Don't warn about float constants that are precisely
2597 // representable in the target type.
2598 Expr::EvalResult result;
John McCall323ed742010-05-06 08:58:33 +00002599 if (E->Evaluate(result, S.Context)) {
John McCall51313c32010-01-04 23:31:57 +00002600 // Value might be a float, a float vector, or a float complex.
2601 if (IsSameFloatAfterCast(result.Val,
John McCall323ed742010-05-06 08:58:33 +00002602 S.Context.getFloatTypeSemantics(QualType(TargetBT, 0)),
2603 S.Context.getFloatTypeSemantics(QualType(SourceBT, 0))))
John McCall51313c32010-01-04 23:31:57 +00002604 return;
2605 }
2606
John McCall323ed742010-05-06 08:58:33 +00002607 DiagnoseImpCast(S, E, T, diag::warn_impcast_float_precision);
John McCall51313c32010-01-04 23:31:57 +00002608 }
2609 return;
2610 }
2611
2612 // If the target is integral, always warn.
2613 if ((TargetBT && TargetBT->isInteger()))
2614 // TODO: don't warn for integer values?
John McCall323ed742010-05-06 08:58:33 +00002615 DiagnoseImpCast(S, E, T, diag::warn_impcast_float_integer);
John McCall51313c32010-01-04 23:31:57 +00002616
2617 return;
2618 }
2619
John McCallf2370c92010-01-06 05:24:50 +00002620 if (!Source->isIntegerType() || !Target->isIntegerType())
John McCall51313c32010-01-04 23:31:57 +00002621 return;
2622
John McCall323ed742010-05-06 08:58:33 +00002623 IntRange SourceRange = GetExprRange(S.Context, E);
2624 IntRange TargetRange = IntRange::forCanonicalType(S.Context, Target);
John McCallf2370c92010-01-06 05:24:50 +00002625
2626 if (SourceRange.Width > TargetRange.Width) {
John McCall51313c32010-01-04 23:31:57 +00002627 // People want to build with -Wshorten-64-to-32 and not -Wconversion
2628 // and by god we'll let them.
John McCallf2370c92010-01-06 05:24:50 +00002629 if (SourceRange.Width == 64 && TargetRange.Width == 32)
John McCall323ed742010-05-06 08:58:33 +00002630 return DiagnoseImpCast(S, E, T, diag::warn_impcast_integer_64_32);
2631 return DiagnoseImpCast(S, E, T, diag::warn_impcast_integer_precision);
2632 }
2633
2634 if ((TargetRange.NonNegative && !SourceRange.NonNegative) ||
2635 (!TargetRange.NonNegative && SourceRange.NonNegative &&
2636 SourceRange.Width == TargetRange.Width)) {
2637 unsigned DiagID = diag::warn_impcast_integer_sign;
2638
2639 // Traditionally, gcc has warned about this under -Wsign-compare.
2640 // We also want to warn about it in -Wconversion.
2641 // So if -Wconversion is off, use a completely identical diagnostic
2642 // in the sign-compare group.
2643 // The conditional-checking code will
2644 if (ICContext) {
2645 DiagID = diag::warn_impcast_integer_sign_conditional;
2646 *ICContext = true;
2647 }
2648
2649 return DiagnoseImpCast(S, E, T, DiagID);
John McCall51313c32010-01-04 23:31:57 +00002650 }
2651
2652 return;
2653}
2654
John McCall323ed742010-05-06 08:58:33 +00002655void CheckConditionalOperator(Sema &S, ConditionalOperator *E, QualType T);
2656
2657void CheckConditionalOperand(Sema &S, Expr *E, QualType T,
2658 bool &ICContext) {
2659 E = E->IgnoreParenImpCasts();
2660
2661 if (isa<ConditionalOperator>(E))
2662 return CheckConditionalOperator(S, cast<ConditionalOperator>(E), T);
2663
2664 AnalyzeImplicitConversions(S, E);
2665 if (E->getType() != T)
2666 return CheckImplicitConversion(S, E, T, &ICContext);
2667 return;
2668}
2669
2670void CheckConditionalOperator(Sema &S, ConditionalOperator *E, QualType T) {
2671 AnalyzeImplicitConversions(S, E->getCond());
2672
2673 bool Suspicious = false;
2674 CheckConditionalOperand(S, E->getTrueExpr(), T, Suspicious);
2675 CheckConditionalOperand(S, E->getFalseExpr(), T, Suspicious);
2676
2677 // If -Wconversion would have warned about either of the candidates
2678 // for a signedness conversion to the context type...
2679 if (!Suspicious) return;
2680
2681 // ...but it's currently ignored...
2682 if (S.Diags.getDiagnosticLevel(diag::warn_impcast_integer_sign_conditional))
2683 return;
2684
2685 // ...and -Wsign-compare isn't...
2686 if (!S.Diags.getDiagnosticLevel(diag::warn_mixed_sign_conditional))
2687 return;
2688
2689 // ...then check whether it would have warned about either of the
2690 // candidates for a signedness conversion to the condition type.
2691 if (E->getType() != T) {
2692 Suspicious = false;
2693 CheckImplicitConversion(S, E->getTrueExpr()->IgnoreParenImpCasts(),
2694 E->getType(), &Suspicious);
2695 if (!Suspicious)
2696 CheckImplicitConversion(S, E->getFalseExpr()->IgnoreParenImpCasts(),
2697 E->getType(), &Suspicious);
2698 if (!Suspicious)
2699 return;
2700 }
2701
2702 // If so, emit a diagnostic under -Wsign-compare.
2703 Expr *lex = E->getTrueExpr()->IgnoreParenImpCasts();
2704 Expr *rex = E->getFalseExpr()->IgnoreParenImpCasts();
2705 S.Diag(E->getQuestionLoc(), diag::warn_mixed_sign_conditional)
2706 << lex->getType() << rex->getType()
2707 << lex->getSourceRange() << rex->getSourceRange();
2708}
2709
2710/// AnalyzeImplicitConversions - Find and report any interesting
2711/// implicit conversions in the given expression. There are a couple
2712/// of competing diagnostics here, -Wconversion and -Wsign-compare.
2713void AnalyzeImplicitConversions(Sema &S, Expr *OrigE) {
2714 QualType T = OrigE->getType();
2715 Expr *E = OrigE->IgnoreParenImpCasts();
2716
2717 // For conditional operators, we analyze the arguments as if they
2718 // were being fed directly into the output.
2719 if (isa<ConditionalOperator>(E)) {
2720 ConditionalOperator *CO = cast<ConditionalOperator>(E);
2721 CheckConditionalOperator(S, CO, T);
2722 return;
2723 }
2724
2725 // Go ahead and check any implicit conversions we might have skipped.
2726 // The non-canonical typecheck is just an optimization;
2727 // CheckImplicitConversion will filter out dead implicit conversions.
2728 if (E->getType() != T)
2729 CheckImplicitConversion(S, E, T);
2730
2731 // Now continue drilling into this expression.
2732
2733 // Skip past explicit casts.
2734 if (isa<ExplicitCastExpr>(E)) {
2735 E = cast<ExplicitCastExpr>(E)->getSubExpr()->IgnoreParenImpCasts();
2736 return AnalyzeImplicitConversions(S, E);
2737 }
2738
2739 // Do a somewhat different check with comparison operators.
2740 if (isa<BinaryOperator>(E) && cast<BinaryOperator>(E)->isComparisonOp())
2741 return AnalyzeComparison(S, cast<BinaryOperator>(E));
2742
2743 // These break the otherwise-useful invariant below. Fortunately,
2744 // we don't really need to recurse into them, because any internal
2745 // expressions should have been analyzed already when they were
2746 // built into statements.
2747 if (isa<StmtExpr>(E)) return;
2748
2749 // Don't descend into unevaluated contexts.
2750 if (isa<SizeOfAlignOfExpr>(E)) return;
2751
2752 // Now just recurse over the expression's children.
2753 for (Stmt::child_iterator I = E->child_begin(), IE = E->child_end();
2754 I != IE; ++I)
2755 AnalyzeImplicitConversions(S, cast<Expr>(*I));
2756}
2757
2758} // end anonymous namespace
2759
2760/// Diagnoses "dangerous" implicit conversions within the given
2761/// expression (which is a full expression). Implements -Wconversion
2762/// and -Wsign-compare.
2763void Sema::CheckImplicitConversions(Expr *E) {
2764 // Don't diagnose in unevaluated contexts.
2765 if (ExprEvalContexts.back().Context == Sema::Unevaluated)
2766 return;
2767
2768 // Don't diagnose for value- or type-dependent expressions.
2769 if (E->isTypeDependent() || E->isValueDependent())
2770 return;
2771
2772 AnalyzeImplicitConversions(*this, E);
2773}
2774
Mike Stumpf8c49212010-01-21 03:59:47 +00002775/// CheckParmsForFunctionDef - Check that the parameters of the given
2776/// function are appropriate for the definition of a function. This
2777/// takes care of any checks that cannot be performed on the
2778/// declaration itself, e.g., that the types of each of the function
2779/// parameters are complete.
2780bool Sema::CheckParmsForFunctionDef(FunctionDecl *FD) {
2781 bool HasInvalidParm = false;
2782 for (unsigned p = 0, NumParams = FD->getNumParams(); p < NumParams; ++p) {
2783 ParmVarDecl *Param = FD->getParamDecl(p);
2784
2785 // C99 6.7.5.3p4: the parameters in a parameter type list in a
2786 // function declarator that is part of a function definition of
2787 // that function shall not have incomplete type.
2788 //
2789 // This is also C++ [dcl.fct]p6.
2790 if (!Param->isInvalidDecl() &&
2791 RequireCompleteType(Param->getLocation(), Param->getType(),
2792 diag::err_typecheck_decl_incomplete_type)) {
2793 Param->setInvalidDecl();
2794 HasInvalidParm = true;
2795 }
2796
2797 // C99 6.9.1p5: If the declarator includes a parameter type list, the
2798 // declaration of each parameter shall include an identifier.
2799 if (Param->getIdentifier() == 0 &&
2800 !Param->isImplicit() &&
2801 !getLangOptions().CPlusPlus)
2802 Diag(Param->getLocation(), diag::err_parameter_name_omitted);
Sam Weinigd17e3402010-02-01 05:02:49 +00002803
2804 // C99 6.7.5.3p12:
2805 // If the function declarator is not part of a definition of that
2806 // function, parameters may have incomplete type and may use the [*]
2807 // notation in their sequences of declarator specifiers to specify
2808 // variable length array types.
2809 QualType PType = Param->getOriginalType();
2810 if (const ArrayType *AT = Context.getAsArrayType(PType)) {
2811 if (AT->getSizeModifier() == ArrayType::Star) {
2812 // FIXME: This diagnosic should point the the '[*]' if source-location
2813 // information is added for it.
2814 Diag(Param->getLocation(), diag::err_array_star_in_function_definition);
2815 }
2816 }
Mike Stumpf8c49212010-01-21 03:59:47 +00002817 }
2818
2819 return HasInvalidParm;
2820}
John McCallb7f4ffe2010-08-12 21:44:57 +00002821
2822/// CheckCastAlign - Implements -Wcast-align, which warns when a
2823/// pointer cast increases the alignment requirements.
2824void Sema::CheckCastAlign(Expr *Op, QualType T, SourceRange TRange) {
2825 // This is actually a lot of work to potentially be doing on every
2826 // cast; don't do it if we're ignoring -Wcast_align (as is the default).
2827 if (getDiagnostics().getDiagnosticLevel(diag::warn_cast_align)
2828 == Diagnostic::Ignored)
2829 return;
2830
2831 // Ignore dependent types.
2832 if (T->isDependentType() || Op->getType()->isDependentType())
2833 return;
2834
2835 // Require that the destination be a pointer type.
2836 const PointerType *DestPtr = T->getAs<PointerType>();
2837 if (!DestPtr) return;
2838
2839 // If the destination has alignment 1, we're done.
2840 QualType DestPointee = DestPtr->getPointeeType();
2841 if (DestPointee->isIncompleteType()) return;
2842 CharUnits DestAlign = Context.getTypeAlignInChars(DestPointee);
2843 if (DestAlign.isOne()) return;
2844
2845 // Require that the source be a pointer type.
2846 const PointerType *SrcPtr = Op->getType()->getAs<PointerType>();
2847 if (!SrcPtr) return;
2848 QualType SrcPointee = SrcPtr->getPointeeType();
2849
2850 // Whitelist casts from cv void*. We already implicitly
2851 // whitelisted casts to cv void*, since they have alignment 1.
2852 // Also whitelist casts involving incomplete types, which implicitly
2853 // includes 'void'.
2854 if (SrcPointee->isIncompleteType()) return;
2855
2856 CharUnits SrcAlign = Context.getTypeAlignInChars(SrcPointee);
2857 if (SrcAlign >= DestAlign) return;
2858
2859 Diag(TRange.getBegin(), diag::warn_cast_align)
2860 << Op->getType() << T
2861 << static_cast<unsigned>(SrcAlign.getQuantity())
2862 << static_cast<unsigned>(DestAlign.getQuantity())
2863 << TRange << Op->getSourceRange();
2864}
2865