Daniel Dunbar | a572887 | 2009-12-15 20:14:24 +0000 | [diff] [blame] | 1 | // RUN: %clang_cc1 -Wparentheses -fsyntax-only -verify %s |
| 2 | // RUN: %clang_cc1 -Wparentheses -fixit %s -o - | %clang_cc1 -Wparentheses -Werror - |
Sebastian Redl | 9e1d29b | 2009-10-26 15:24:15 +0000 | [diff] [blame] | 3 | |
| 4 | // Test the various warnings under -Wparentheses |
| 5 | void if_assign(void) { |
| 6 | int i; |
Douglas Gregor | 827feec | 2010-01-08 00:20:23 +0000 | [diff] [blame] | 7 | if (i = 4) {} // expected-warning {{assignment as a condition}} \ |
Douglas Gregor | 55b3884 | 2010-04-14 16:09:52 +0000 | [diff] [blame] | 8 | // expected-note{{use '==' to turn this assignment into an equality comparison}} \ |
| 9 | // expected-note{{place parentheses around the assignment to silence this warning}} |
Sebastian Redl | 9e1d29b | 2009-10-26 15:24:15 +0000 | [diff] [blame] | 10 | if ((i = 4)) {} |
| 11 | } |
| 12 | |
| 13 | void bitwise_rel(unsigned i) { |
Douglas Gregor | 827feec | 2010-01-08 00:20:23 +0000 | [diff] [blame] | 14 | (void)(i & 0x2 == 0); // expected-warning {{& has lower precedence than ==}} \ |
Douglas Gregor | 55b3884 | 2010-04-14 16:09:52 +0000 | [diff] [blame] | 15 | // expected-note{{place parentheses around the & expression to evaluate it first}} \ |
| 16 | // expected-note{{place parentheses around the == expression to silence this warning}} |
Douglas Gregor | 827feec | 2010-01-08 00:20:23 +0000 | [diff] [blame] | 17 | (void)(0 == i & 0x2); // expected-warning {{& has lower precedence than ==}} \ |
Douglas Gregor | 55b3884 | 2010-04-14 16:09:52 +0000 | [diff] [blame] | 18 | // expected-note{{place parentheses around the & expression to evaluate it first}} \ |
| 19 | // expected-note{{place parentheses around the == expression to silence this warning}} |
Douglas Gregor | 827feec | 2010-01-08 00:20:23 +0000 | [diff] [blame] | 20 | (void)(i & 0xff < 30); // expected-warning {{& has lower precedence than <}} \ |
Douglas Gregor | 55b3884 | 2010-04-14 16:09:52 +0000 | [diff] [blame] | 21 | // expected-note{{place parentheses around the & expression to evaluate it first}} \ |
| 22 | // expected-note{{place parentheses around the < expression to silence this warning}} |
Sebastian Redl | 9e1d29b | 2009-10-26 15:24:15 +0000 | [diff] [blame] | 23 | (void)((i & 0x2) == 0); |
| 24 | (void)(i & (0x2 == 0)); |
| 25 | // Eager logical op |
| 26 | (void)(i == 1 | i == 2 | i == 3); |
| 27 | (void)(i != 1 & i != 2 & i != 3); |
Argyrios Kyrtzidis | bee77f7 | 2010-11-16 21:00:12 +0000 | [diff] [blame] | 28 | |
| 29 | (void)(i || i && i); // expected-warning {{'&&' within '||'}} \ |
| 30 | // expected-note {{place parentheses around the '&&' expression to silence this warning}} |
Argyrios Kyrtzidis | 567bb71 | 2010-11-17 18:26:36 +0000 | [diff] [blame] | 31 | (void)(i || i && "w00t"); // no warning. |
| 32 | (void)("w00t" && i || i); // no warning. |
| 33 | (void)(i || i && "w00t" || i); // expected-warning {{'&&' within '||'}} \ |
| 34 | // expected-note {{place parentheses around the '&&' expression to silence this warning}} |
| 35 | (void)(i || "w00t" && i || i); // expected-warning {{'&&' within '||'}} \ |
| 36 | // expected-note {{place parentheses around the '&&' expression to silence this warning}} |
Argyrios Kyrtzidis | 47d512c | 2010-11-17 19:18:19 +0000 | [diff] [blame] | 37 | (void)(i && i || 0); // no warning. |
| 38 | (void)(0 || i && i); // no warning. |
Sebastian Redl | 9e1d29b | 2009-10-26 15:24:15 +0000 | [diff] [blame] | 39 | } |