Ted Kremenek | f5d2ef4 | 2011-02-25 22:00:43 +0000 | [diff] [blame] | 1 | //=== StackAddrEscapeChecker.cpp ----------------------------------*- C++ -*--// |
Zhongxing Xu | 1622a54 | 2010-06-08 10:00:00 +0000 | [diff] [blame] | 2 | // |
| 3 | // The LLVM Compiler Infrastructure |
| 4 | // |
| 5 | // This file is distributed under the University of Illinois Open Source |
| 6 | // License. See LICENSE.TXT for details. |
| 7 | // |
| 8 | //===----------------------------------------------------------------------===// |
| 9 | // |
| 10 | // This file defines stack address leak checker, which checks if an invalid |
| 11 | // stack address is stored into a global or heap location. See CERT DCL30-C. |
| 12 | // |
| 13 | //===----------------------------------------------------------------------===// |
| 14 | |
Argyrios Kyrtzidis | 027a6ab | 2011-02-15 07:42:33 +0000 | [diff] [blame] | 15 | #include "ClangSACheckers.h" |
Argyrios Kyrtzidis | ec8605f | 2011-03-01 01:16:21 +0000 | [diff] [blame] | 16 | #include "clang/StaticAnalyzer/Core/Checker.h" |
Argyrios Kyrtzidis | 695fb50 | 2011-02-17 21:39:17 +0000 | [diff] [blame] | 17 | #include "clang/StaticAnalyzer/Core/CheckerManager.h" |
Argyrios Kyrtzidis | af5800a | 2011-02-23 21:04:54 +0000 | [diff] [blame] | 18 | #include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h" |
Ted Kremenek | 9b66371 | 2011-02-10 01:03:03 +0000 | [diff] [blame] | 19 | #include "clang/StaticAnalyzer/Core/BugReporter/BugType.h" |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 20 | #include "clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h" |
Zhongxing Xu | 9b14683 | 2010-06-09 06:08:24 +0000 | [diff] [blame] | 21 | #include "clang/Basic/SourceManager.h" |
| 22 | #include "llvm/ADT/SmallString.h" |
Zhongxing Xu | 1622a54 | 2010-06-08 10:00:00 +0000 | [diff] [blame] | 23 | using namespace clang; |
Ted Kremenek | 9ef6537 | 2010-12-23 07:20:52 +0000 | [diff] [blame] | 24 | using namespace ento; |
Zhongxing Xu | 1622a54 | 2010-06-08 10:00:00 +0000 | [diff] [blame] | 25 | |
| 26 | namespace { |
Argyrios Kyrtzidis | ec8605f | 2011-03-01 01:16:21 +0000 | [diff] [blame] | 27 | class StackAddrEscapeChecker : public Checker< check::PreStmt<ReturnStmt>, |
Argyrios Kyrtzidis | af5800a | 2011-02-23 21:04:54 +0000 | [diff] [blame] | 28 | check::EndPath > { |
| 29 | mutable llvm::OwningPtr<BuiltinBug> BT_stackleak; |
| 30 | mutable llvm::OwningPtr<BuiltinBug> BT_returnstack; |
Zhongxing Xu | 1622a54 | 2010-06-08 10:00:00 +0000 | [diff] [blame] | 31 | |
| 32 | public: |
Argyrios Kyrtzidis | af5800a | 2011-02-23 21:04:54 +0000 | [diff] [blame] | 33 | void checkPreStmt(const ReturnStmt *RS, CheckerContext &C) const; |
| 34 | void checkEndPath(EndOfFunctionNodeBuilder &B, ExprEngine &Eng) const; |
Zhongxing Xu | 9b14683 | 2010-06-09 06:08:24 +0000 | [diff] [blame] | 35 | private: |
Argyrios Kyrtzidis | af5800a | 2011-02-23 21:04:54 +0000 | [diff] [blame] | 36 | void EmitStackError(CheckerContext &C, const MemRegion *R, |
| 37 | const Expr *RetE) const; |
Chris Lattner | 5f9e272 | 2011-07-23 10:55:15 +0000 | [diff] [blame] | 38 | static SourceRange GenName(raw_ostream &os, const MemRegion *R, |
Argyrios Kyrtzidis | af5800a | 2011-02-23 21:04:54 +0000 | [diff] [blame] | 39 | SourceManager &SM); |
Zhongxing Xu | 1622a54 | 2010-06-08 10:00:00 +0000 | [diff] [blame] | 40 | }; |
| 41 | } |
| 42 | |
Chris Lattner | 5f9e272 | 2011-07-23 10:55:15 +0000 | [diff] [blame] | 43 | SourceRange StackAddrEscapeChecker::GenName(raw_ostream &os, |
Ted Kremenek | a816615 | 2010-06-17 04:21:37 +0000 | [diff] [blame] | 44 | const MemRegion *R, |
| 45 | SourceManager &SM) { |
| 46 | // Get the base region, stripping away fields and elements. |
| 47 | R = R->getBaseRegion(); |
| 48 | SourceRange range; |
| 49 | os << "Address of "; |
| 50 | |
| 51 | // Check if the region is a compound literal. |
| 52 | if (const CompoundLiteralRegion* CR = dyn_cast<CompoundLiteralRegion>(R)) { |
Ted Kremenek | 9c378f7 | 2011-08-12 23:37:29 +0000 | [diff] [blame] | 53 | const CompoundLiteralExpr *CL = CR->getLiteralExpr(); |
Ted Kremenek | a816615 | 2010-06-17 04:21:37 +0000 | [diff] [blame] | 54 | os << "stack memory associated with a compound literal " |
| 55 | "declared on line " |
Chandler Carruth | 6421162 | 2011-07-25 21:09:52 +0000 | [diff] [blame] | 56 | << SM.getExpansionLineNumber(CL->getLocStart()) |
Ted Kremenek | a816615 | 2010-06-17 04:21:37 +0000 | [diff] [blame] | 57 | << " returned to caller"; |
| 58 | range = CL->getSourceRange(); |
| 59 | } |
| 60 | else if (const AllocaRegion* AR = dyn_cast<AllocaRegion>(R)) { |
Ted Kremenek | 9c378f7 | 2011-08-12 23:37:29 +0000 | [diff] [blame] | 61 | const Expr *ARE = AR->getExpr(); |
Ted Kremenek | a816615 | 2010-06-17 04:21:37 +0000 | [diff] [blame] | 62 | SourceLocation L = ARE->getLocStart(); |
| 63 | range = ARE->getSourceRange(); |
| 64 | os << "stack memory allocated by call to alloca() on line " |
Chandler Carruth | 6421162 | 2011-07-25 21:09:52 +0000 | [diff] [blame] | 65 | << SM.getExpansionLineNumber(L); |
Ted Kremenek | a816615 | 2010-06-17 04:21:37 +0000 | [diff] [blame] | 66 | } |
| 67 | else if (const BlockDataRegion *BR = dyn_cast<BlockDataRegion>(R)) { |
| 68 | const BlockDecl *BD = BR->getCodeRegion()->getDecl(); |
| 69 | SourceLocation L = BD->getLocStart(); |
| 70 | range = BD->getSourceRange(); |
| 71 | os << "stack-allocated block declared on line " |
Chandler Carruth | 6421162 | 2011-07-25 21:09:52 +0000 | [diff] [blame] | 72 | << SM.getExpansionLineNumber(L); |
Ted Kremenek | a816615 | 2010-06-17 04:21:37 +0000 | [diff] [blame] | 73 | } |
| 74 | else if (const VarRegion *VR = dyn_cast<VarRegion>(R)) { |
| 75 | os << "stack memory associated with local variable '" |
| 76 | << VR->getString() << '\''; |
| 77 | range = VR->getDecl()->getSourceRange(); |
| 78 | } |
| 79 | else { |
| 80 | assert(false && "Invalid region in ReturnStackAddressChecker."); |
| 81 | } |
| 82 | |
| 83 | return range; |
| 84 | } |
| 85 | |
Ted Kremenek | f5d2ef4 | 2011-02-25 22:00:43 +0000 | [diff] [blame] | 86 | void StackAddrEscapeChecker::EmitStackError(CheckerContext &C, const MemRegion *R, |
Argyrios Kyrtzidis | af5800a | 2011-02-23 21:04:54 +0000 | [diff] [blame] | 87 | const Expr *RetE) const { |
Ted Kremenek | d048c6e | 2010-12-20 21:19:09 +0000 | [diff] [blame] | 88 | ExplodedNode *N = C.generateSink(); |
Zhongxing Xu | 9b14683 | 2010-06-09 06:08:24 +0000 | [diff] [blame] | 89 | |
| 90 | if (!N) |
| 91 | return; |
| 92 | |
| 93 | if (!BT_returnstack) |
Argyrios Kyrtzidis | af5800a | 2011-02-23 21:04:54 +0000 | [diff] [blame] | 94 | BT_returnstack.reset( |
| 95 | new BuiltinBug("Return of address to stack-allocated memory")); |
Zhongxing Xu | 9b14683 | 2010-06-09 06:08:24 +0000 | [diff] [blame] | 96 | |
| 97 | // Generate a report for this bug. |
| 98 | llvm::SmallString<512> buf; |
| 99 | llvm::raw_svector_ostream os(buf); |
Ted Kremenek | a816615 | 2010-06-17 04:21:37 +0000 | [diff] [blame] | 100 | SourceRange range = GenName(os, R, C.getSourceManager()); |
| 101 | os << " returned to caller"; |
Anna Zaks | e172e8b | 2011-08-17 23:00:25 +0000 | [diff] [blame] | 102 | BugReport *report = new BugReport(*BT_returnstack, os.str(), N); |
Zhongxing Xu | 9b14683 | 2010-06-09 06:08:24 +0000 | [diff] [blame] | 103 | report->addRange(RetE->getSourceRange()); |
| 104 | if (range.isValid()) |
| 105 | report->addRange(range); |
| 106 | |
| 107 | C.EmitReport(report); |
Eli Friedman | a7e6845 | 2010-08-22 01:00:03 +0000 | [diff] [blame] | 108 | } |
Zhongxing Xu | 9b14683 | 2010-06-09 06:08:24 +0000 | [diff] [blame] | 109 | |
Ted Kremenek | f5d2ef4 | 2011-02-25 22:00:43 +0000 | [diff] [blame] | 110 | void StackAddrEscapeChecker::checkPreStmt(const ReturnStmt *RS, |
Argyrios Kyrtzidis | af5800a | 2011-02-23 21:04:54 +0000 | [diff] [blame] | 111 | CheckerContext &C) const { |
Zhongxing Xu | 9b14683 | 2010-06-09 06:08:24 +0000 | [diff] [blame] | 112 | |
| 113 | const Expr *RetE = RS->getRetValue(); |
| 114 | if (!RetE) |
| 115 | return; |
| 116 | |
| 117 | SVal V = C.getState()->getSVal(RetE); |
| 118 | const MemRegion *R = V.getAsRegion(); |
| 119 | |
| 120 | if (!R || !R->hasStackStorage()) |
| 121 | return; |
| 122 | |
| 123 | if (R->hasStackStorage()) { |
John McCall | f85e193 | 2011-06-15 23:02:42 +0000 | [diff] [blame] | 124 | // Automatic reference counting automatically copies blocks. |
| 125 | if (C.getASTContext().getLangOptions().ObjCAutoRefCount && |
| 126 | isa<BlockDataRegion>(R)) |
| 127 | return; |
| 128 | |
Zhongxing Xu | 9b14683 | 2010-06-09 06:08:24 +0000 | [diff] [blame] | 129 | EmitStackError(C, R, RetE); |
| 130 | return; |
| 131 | } |
| 132 | } |
Zhongxing Xu | 1622a54 | 2010-06-08 10:00:00 +0000 | [diff] [blame] | 133 | |
Ted Kremenek | f5d2ef4 | 2011-02-25 22:00:43 +0000 | [diff] [blame] | 134 | void StackAddrEscapeChecker::checkEndPath(EndOfFunctionNodeBuilder &B, |
Argyrios Kyrtzidis | af5800a | 2011-02-23 21:04:54 +0000 | [diff] [blame] | 135 | ExprEngine &Eng) const { |
Ted Kremenek | ba37d3b | 2011-01-13 04:36:40 +0000 | [diff] [blame] | 136 | |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 137 | const ProgramState *state = B.getState(); |
Zhongxing Xu | 1622a54 | 2010-06-08 10:00:00 +0000 | [diff] [blame] | 138 | |
Ted Kremenek | 551bd1f | 2010-06-17 00:24:44 +0000 | [diff] [blame] | 139 | // Iterate over all bindings to global variables and see if it contains |
| 140 | // a memory region in the stack space. |
| 141 | class CallBack : public StoreManager::BindingsHandler { |
| 142 | private: |
John McCall | f85e193 | 2011-06-15 23:02:42 +0000 | [diff] [blame] | 143 | ExprEngine &Eng; |
Ted Kremenek | 551bd1f | 2010-06-17 00:24:44 +0000 | [diff] [blame] | 144 | const StackFrameContext *CurSFC; |
| 145 | public: |
Chris Lattner | 5f9e272 | 2011-07-23 10:55:15 +0000 | [diff] [blame] | 146 | SmallVector<std::pair<const MemRegion*, const MemRegion*>, 10> V; |
Zhongxing Xu | 1622a54 | 2010-06-08 10:00:00 +0000 | [diff] [blame] | 147 | |
John McCall | f85e193 | 2011-06-15 23:02:42 +0000 | [diff] [blame] | 148 | CallBack(ExprEngine &Eng, const LocationContext *LCtx) |
| 149 | : Eng(Eng), CurSFC(LCtx->getCurrentStackFrame()) {} |
Ted Kremenek | 551bd1f | 2010-06-17 00:24:44 +0000 | [diff] [blame] | 150 | |
| 151 | bool HandleBinding(StoreManager &SMgr, Store store, |
| 152 | const MemRegion *region, SVal val) { |
| 153 | |
| 154 | if (!isa<GlobalsSpaceRegion>(region->getMemorySpace())) |
| 155 | return true; |
| 156 | |
| 157 | const MemRegion *vR = val.getAsRegion(); |
| 158 | if (!vR) |
| 159 | return true; |
John McCall | f85e193 | 2011-06-15 23:02:42 +0000 | [diff] [blame] | 160 | |
| 161 | // Under automated retain release, it is okay to assign a block |
| 162 | // directly to a global variable. |
| 163 | if (Eng.getContext().getLangOptions().ObjCAutoRefCount && |
| 164 | isa<BlockDataRegion>(vR)) |
| 165 | return true; |
| 166 | |
Ted Kremenek | 551bd1f | 2010-06-17 00:24:44 +0000 | [diff] [blame] | 167 | if (const StackSpaceRegion *SSR = |
| 168 | dyn_cast<StackSpaceRegion>(vR->getMemorySpace())) { |
| 169 | // If the global variable holds a location in the current stack frame, |
| 170 | // record the binding to emit a warning. |
Ted Kremenek | a816615 | 2010-06-17 04:21:37 +0000 | [diff] [blame] | 171 | if (SSR->getStackFrame() == CurSFC) |
| 172 | V.push_back(std::make_pair(region, vR)); |
Zhongxing Xu | 1622a54 | 2010-06-08 10:00:00 +0000 | [diff] [blame] | 173 | } |
Ted Kremenek | 551bd1f | 2010-06-17 00:24:44 +0000 | [diff] [blame] | 174 | |
| 175 | return true; |
Zhongxing Xu | 1622a54 | 2010-06-08 10:00:00 +0000 | [diff] [blame] | 176 | } |
Ted Kremenek | 551bd1f | 2010-06-17 00:24:44 +0000 | [diff] [blame] | 177 | }; |
| 178 | |
John McCall | f85e193 | 2011-06-15 23:02:42 +0000 | [diff] [blame] | 179 | CallBack cb(Eng, B.getPredecessor()->getLocationContext()); |
Ted Kremenek | 551bd1f | 2010-06-17 00:24:44 +0000 | [diff] [blame] | 180 | state->getStateManager().getStoreManager().iterBindings(state->getStore(),cb); |
Ted Kremenek | a816615 | 2010-06-17 04:21:37 +0000 | [diff] [blame] | 181 | |
| 182 | if (cb.V.empty()) |
Ted Kremenek | 551bd1f | 2010-06-17 00:24:44 +0000 | [diff] [blame] | 183 | return; |
| 184 | |
| 185 | // Generate an error node. |
Argyrios Kyrtzidis | f178ac8 | 2011-02-23 21:04:49 +0000 | [diff] [blame] | 186 | ExplodedNode *N = B.generateNode(state); |
Ted Kremenek | 551bd1f | 2010-06-17 00:24:44 +0000 | [diff] [blame] | 187 | if (!N) |
| 188 | return; |
Ted Kremenek | 551bd1f | 2010-06-17 00:24:44 +0000 | [diff] [blame] | 189 | |
Ted Kremenek | a816615 | 2010-06-17 04:21:37 +0000 | [diff] [blame] | 190 | if (!BT_stackleak) |
Argyrios Kyrtzidis | af5800a | 2011-02-23 21:04:54 +0000 | [diff] [blame] | 191 | BT_stackleak.reset( |
Ted Kremenek | a816615 | 2010-06-17 04:21:37 +0000 | [diff] [blame] | 192 | new BuiltinBug("Stack address stored into global variable", |
| 193 | "Stack address was saved into a global variable. " |
| 194 | "This is dangerous because the address will become " |
Argyrios Kyrtzidis | af5800a | 2011-02-23 21:04:54 +0000 | [diff] [blame] | 195 | "invalid after returning from the function")); |
Ted Kremenek | a816615 | 2010-06-17 04:21:37 +0000 | [diff] [blame] | 196 | |
| 197 | for (unsigned i = 0, e = cb.V.size(); i != e; ++i) { |
| 198 | // Generate a report for this bug. |
| 199 | llvm::SmallString<512> buf; |
| 200 | llvm::raw_svector_ostream os(buf); |
| 201 | SourceRange range = GenName(os, cb.V[i].second, |
| 202 | Eng.getContext().getSourceManager()); |
| 203 | os << " is still referred to by the global variable '"; |
| 204 | const VarRegion *VR = cast<VarRegion>(cb.V[i].first->getBaseRegion()); |
Jordy Rose | 7df1234 | 2011-08-21 05:25:15 +0000 | [diff] [blame^] | 205 | os << VR->getDecl() |
Ted Kremenek | a816615 | 2010-06-17 04:21:37 +0000 | [diff] [blame] | 206 | << "' upon returning to the caller. This will be a dangling reference"; |
Anna Zaks | e172e8b | 2011-08-17 23:00:25 +0000 | [diff] [blame] | 207 | BugReport *report = new BugReport(*BT_stackleak, os.str(), N); |
Ted Kremenek | a816615 | 2010-06-17 04:21:37 +0000 | [diff] [blame] | 208 | if (range.isValid()) |
| 209 | report->addRange(range); |
| 210 | |
| 211 | Eng.getBugReporter().EmitReport(report); |
| 212 | } |
Zhongxing Xu | 1622a54 | 2010-06-08 10:00:00 +0000 | [diff] [blame] | 213 | } |
Argyrios Kyrtzidis | af5800a | 2011-02-23 21:04:54 +0000 | [diff] [blame] | 214 | |
Ted Kremenek | f5d2ef4 | 2011-02-25 22:00:43 +0000 | [diff] [blame] | 215 | void ento::registerStackAddrEscapeChecker(CheckerManager &mgr) { |
| 216 | mgr.registerChecker<StackAddrEscapeChecker>(); |
Argyrios Kyrtzidis | af5800a | 2011-02-23 21:04:54 +0000 | [diff] [blame] | 217 | } |