blob: b004aa9c647b2fec5bd69dbd3c1128d83c7e3cac [file] [log] [blame]
Ted Kremenekf5d2ef42011-02-25 22:00:43 +00001//=== StackAddrEscapeChecker.cpp ----------------------------------*- C++ -*--//
Zhongxing Xu1622a542010-06-08 10:00:00 +00002//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// This file defines stack address leak checker, which checks if an invalid
11// stack address is stored into a global or heap location. See CERT DCL30-C.
12//
13//===----------------------------------------------------------------------===//
14
Argyrios Kyrtzidis027a6ab2011-02-15 07:42:33 +000015#include "ClangSACheckers.h"
Argyrios Kyrtzidisec8605f2011-03-01 01:16:21 +000016#include "clang/StaticAnalyzer/Core/Checker.h"
Argyrios Kyrtzidis695fb502011-02-17 21:39:17 +000017#include "clang/StaticAnalyzer/Core/CheckerManager.h"
Argyrios Kyrtzidisaf5800a2011-02-23 21:04:54 +000018#include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
Ted Kremenek9b663712011-02-10 01:03:03 +000019#include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
Ted Kremenek18c66fd2011-08-15 22:09:50 +000020#include "clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h"
Zhongxing Xu9b146832010-06-09 06:08:24 +000021#include "clang/Basic/SourceManager.h"
22#include "llvm/ADT/SmallString.h"
Zhongxing Xu1622a542010-06-08 10:00:00 +000023using namespace clang;
Ted Kremenek9ef65372010-12-23 07:20:52 +000024using namespace ento;
Zhongxing Xu1622a542010-06-08 10:00:00 +000025
26namespace {
Argyrios Kyrtzidisec8605f2011-03-01 01:16:21 +000027class StackAddrEscapeChecker : public Checker< check::PreStmt<ReturnStmt>,
Argyrios Kyrtzidisaf5800a2011-02-23 21:04:54 +000028 check::EndPath > {
29 mutable llvm::OwningPtr<BuiltinBug> BT_stackleak;
30 mutable llvm::OwningPtr<BuiltinBug> BT_returnstack;
Zhongxing Xu1622a542010-06-08 10:00:00 +000031
32public:
Argyrios Kyrtzidisaf5800a2011-02-23 21:04:54 +000033 void checkPreStmt(const ReturnStmt *RS, CheckerContext &C) const;
34 void checkEndPath(EndOfFunctionNodeBuilder &B, ExprEngine &Eng) const;
Zhongxing Xu9b146832010-06-09 06:08:24 +000035private:
Argyrios Kyrtzidisaf5800a2011-02-23 21:04:54 +000036 void EmitStackError(CheckerContext &C, const MemRegion *R,
37 const Expr *RetE) const;
Chris Lattner5f9e2722011-07-23 10:55:15 +000038 static SourceRange GenName(raw_ostream &os, const MemRegion *R,
Argyrios Kyrtzidisaf5800a2011-02-23 21:04:54 +000039 SourceManager &SM);
Zhongxing Xu1622a542010-06-08 10:00:00 +000040};
41}
42
Chris Lattner5f9e2722011-07-23 10:55:15 +000043SourceRange StackAddrEscapeChecker::GenName(raw_ostream &os,
Ted Kremeneka8166152010-06-17 04:21:37 +000044 const MemRegion *R,
45 SourceManager &SM) {
46 // Get the base region, stripping away fields and elements.
47 R = R->getBaseRegion();
48 SourceRange range;
49 os << "Address of ";
50
51 // Check if the region is a compound literal.
52 if (const CompoundLiteralRegion* CR = dyn_cast<CompoundLiteralRegion>(R)) {
Ted Kremenek9c378f72011-08-12 23:37:29 +000053 const CompoundLiteralExpr *CL = CR->getLiteralExpr();
Ted Kremeneka8166152010-06-17 04:21:37 +000054 os << "stack memory associated with a compound literal "
55 "declared on line "
Chandler Carruth64211622011-07-25 21:09:52 +000056 << SM.getExpansionLineNumber(CL->getLocStart())
Ted Kremeneka8166152010-06-17 04:21:37 +000057 << " returned to caller";
58 range = CL->getSourceRange();
59 }
60 else if (const AllocaRegion* AR = dyn_cast<AllocaRegion>(R)) {
Ted Kremenek9c378f72011-08-12 23:37:29 +000061 const Expr *ARE = AR->getExpr();
Ted Kremeneka8166152010-06-17 04:21:37 +000062 SourceLocation L = ARE->getLocStart();
63 range = ARE->getSourceRange();
64 os << "stack memory allocated by call to alloca() on line "
Chandler Carruth64211622011-07-25 21:09:52 +000065 << SM.getExpansionLineNumber(L);
Ted Kremeneka8166152010-06-17 04:21:37 +000066 }
67 else if (const BlockDataRegion *BR = dyn_cast<BlockDataRegion>(R)) {
68 const BlockDecl *BD = BR->getCodeRegion()->getDecl();
69 SourceLocation L = BD->getLocStart();
70 range = BD->getSourceRange();
71 os << "stack-allocated block declared on line "
Chandler Carruth64211622011-07-25 21:09:52 +000072 << SM.getExpansionLineNumber(L);
Ted Kremeneka8166152010-06-17 04:21:37 +000073 }
74 else if (const VarRegion *VR = dyn_cast<VarRegion>(R)) {
75 os << "stack memory associated with local variable '"
76 << VR->getString() << '\'';
77 range = VR->getDecl()->getSourceRange();
78 }
79 else {
80 assert(false && "Invalid region in ReturnStackAddressChecker.");
81 }
82
83 return range;
84}
85
Ted Kremenekf5d2ef42011-02-25 22:00:43 +000086void StackAddrEscapeChecker::EmitStackError(CheckerContext &C, const MemRegion *R,
Argyrios Kyrtzidisaf5800a2011-02-23 21:04:54 +000087 const Expr *RetE) const {
Ted Kremenekd048c6e2010-12-20 21:19:09 +000088 ExplodedNode *N = C.generateSink();
Zhongxing Xu9b146832010-06-09 06:08:24 +000089
90 if (!N)
91 return;
92
93 if (!BT_returnstack)
Argyrios Kyrtzidisaf5800a2011-02-23 21:04:54 +000094 BT_returnstack.reset(
95 new BuiltinBug("Return of address to stack-allocated memory"));
Zhongxing Xu9b146832010-06-09 06:08:24 +000096
97 // Generate a report for this bug.
98 llvm::SmallString<512> buf;
99 llvm::raw_svector_ostream os(buf);
Ted Kremeneka8166152010-06-17 04:21:37 +0000100 SourceRange range = GenName(os, R, C.getSourceManager());
101 os << " returned to caller";
Anna Zakse172e8b2011-08-17 23:00:25 +0000102 BugReport *report = new BugReport(*BT_returnstack, os.str(), N);
Zhongxing Xu9b146832010-06-09 06:08:24 +0000103 report->addRange(RetE->getSourceRange());
104 if (range.isValid())
105 report->addRange(range);
106
107 C.EmitReport(report);
Eli Friedmana7e68452010-08-22 01:00:03 +0000108}
Zhongxing Xu9b146832010-06-09 06:08:24 +0000109
Ted Kremenekf5d2ef42011-02-25 22:00:43 +0000110void StackAddrEscapeChecker::checkPreStmt(const ReturnStmt *RS,
Argyrios Kyrtzidisaf5800a2011-02-23 21:04:54 +0000111 CheckerContext &C) const {
Zhongxing Xu9b146832010-06-09 06:08:24 +0000112
113 const Expr *RetE = RS->getRetValue();
114 if (!RetE)
115 return;
116
117 SVal V = C.getState()->getSVal(RetE);
118 const MemRegion *R = V.getAsRegion();
119
120 if (!R || !R->hasStackStorage())
121 return;
122
123 if (R->hasStackStorage()) {
John McCallf85e1932011-06-15 23:02:42 +0000124 // Automatic reference counting automatically copies blocks.
125 if (C.getASTContext().getLangOptions().ObjCAutoRefCount &&
126 isa<BlockDataRegion>(R))
127 return;
128
Zhongxing Xu9b146832010-06-09 06:08:24 +0000129 EmitStackError(C, R, RetE);
130 return;
131 }
132}
Zhongxing Xu1622a542010-06-08 10:00:00 +0000133
Ted Kremenekf5d2ef42011-02-25 22:00:43 +0000134void StackAddrEscapeChecker::checkEndPath(EndOfFunctionNodeBuilder &B,
Argyrios Kyrtzidisaf5800a2011-02-23 21:04:54 +0000135 ExprEngine &Eng) const {
Ted Kremenekba37d3b2011-01-13 04:36:40 +0000136
Ted Kremenek18c66fd2011-08-15 22:09:50 +0000137 const ProgramState *state = B.getState();
Zhongxing Xu1622a542010-06-08 10:00:00 +0000138
Ted Kremenek551bd1f2010-06-17 00:24:44 +0000139 // Iterate over all bindings to global variables and see if it contains
140 // a memory region in the stack space.
141 class CallBack : public StoreManager::BindingsHandler {
142 private:
John McCallf85e1932011-06-15 23:02:42 +0000143 ExprEngine &Eng;
Ted Kremenek551bd1f2010-06-17 00:24:44 +0000144 const StackFrameContext *CurSFC;
145 public:
Chris Lattner5f9e2722011-07-23 10:55:15 +0000146 SmallVector<std::pair<const MemRegion*, const MemRegion*>, 10> V;
Zhongxing Xu1622a542010-06-08 10:00:00 +0000147
John McCallf85e1932011-06-15 23:02:42 +0000148 CallBack(ExprEngine &Eng, const LocationContext *LCtx)
149 : Eng(Eng), CurSFC(LCtx->getCurrentStackFrame()) {}
Ted Kremenek551bd1f2010-06-17 00:24:44 +0000150
151 bool HandleBinding(StoreManager &SMgr, Store store,
152 const MemRegion *region, SVal val) {
153
154 if (!isa<GlobalsSpaceRegion>(region->getMemorySpace()))
155 return true;
156
157 const MemRegion *vR = val.getAsRegion();
158 if (!vR)
159 return true;
John McCallf85e1932011-06-15 23:02:42 +0000160
161 // Under automated retain release, it is okay to assign a block
162 // directly to a global variable.
163 if (Eng.getContext().getLangOptions().ObjCAutoRefCount &&
164 isa<BlockDataRegion>(vR))
165 return true;
166
Ted Kremenek551bd1f2010-06-17 00:24:44 +0000167 if (const StackSpaceRegion *SSR =
168 dyn_cast<StackSpaceRegion>(vR->getMemorySpace())) {
169 // If the global variable holds a location in the current stack frame,
170 // record the binding to emit a warning.
Ted Kremeneka8166152010-06-17 04:21:37 +0000171 if (SSR->getStackFrame() == CurSFC)
172 V.push_back(std::make_pair(region, vR));
Zhongxing Xu1622a542010-06-08 10:00:00 +0000173 }
Ted Kremenek551bd1f2010-06-17 00:24:44 +0000174
175 return true;
Zhongxing Xu1622a542010-06-08 10:00:00 +0000176 }
Ted Kremenek551bd1f2010-06-17 00:24:44 +0000177 };
178
John McCallf85e1932011-06-15 23:02:42 +0000179 CallBack cb(Eng, B.getPredecessor()->getLocationContext());
Ted Kremenek551bd1f2010-06-17 00:24:44 +0000180 state->getStateManager().getStoreManager().iterBindings(state->getStore(),cb);
Ted Kremeneka8166152010-06-17 04:21:37 +0000181
182 if (cb.V.empty())
Ted Kremenek551bd1f2010-06-17 00:24:44 +0000183 return;
184
185 // Generate an error node.
Argyrios Kyrtzidisf178ac82011-02-23 21:04:49 +0000186 ExplodedNode *N = B.generateNode(state);
Ted Kremenek551bd1f2010-06-17 00:24:44 +0000187 if (!N)
188 return;
Ted Kremenek551bd1f2010-06-17 00:24:44 +0000189
Ted Kremeneka8166152010-06-17 04:21:37 +0000190 if (!BT_stackleak)
Argyrios Kyrtzidisaf5800a2011-02-23 21:04:54 +0000191 BT_stackleak.reset(
Ted Kremeneka8166152010-06-17 04:21:37 +0000192 new BuiltinBug("Stack address stored into global variable",
193 "Stack address was saved into a global variable. "
194 "This is dangerous because the address will become "
Argyrios Kyrtzidisaf5800a2011-02-23 21:04:54 +0000195 "invalid after returning from the function"));
Ted Kremeneka8166152010-06-17 04:21:37 +0000196
197 for (unsigned i = 0, e = cb.V.size(); i != e; ++i) {
198 // Generate a report for this bug.
199 llvm::SmallString<512> buf;
200 llvm::raw_svector_ostream os(buf);
201 SourceRange range = GenName(os, cb.V[i].second,
202 Eng.getContext().getSourceManager());
203 os << " is still referred to by the global variable '";
204 const VarRegion *VR = cast<VarRegion>(cb.V[i].first->getBaseRegion());
Jordy Rose7df12342011-08-21 05:25:15 +0000205 os << VR->getDecl()
Ted Kremeneka8166152010-06-17 04:21:37 +0000206 << "' upon returning to the caller. This will be a dangling reference";
Anna Zakse172e8b2011-08-17 23:00:25 +0000207 BugReport *report = new BugReport(*BT_stackleak, os.str(), N);
Ted Kremeneka8166152010-06-17 04:21:37 +0000208 if (range.isValid())
209 report->addRange(range);
210
211 Eng.getBugReporter().EmitReport(report);
212 }
Zhongxing Xu1622a542010-06-08 10:00:00 +0000213}
Argyrios Kyrtzidisaf5800a2011-02-23 21:04:54 +0000214
Ted Kremenekf5d2ef42011-02-25 22:00:43 +0000215void ento::registerStackAddrEscapeChecker(CheckerManager &mgr) {
216 mgr.registerChecker<StackAddrEscapeChecker>();
Argyrios Kyrtzidisaf5800a2011-02-23 21:04:54 +0000217}