blob: 6c6804fe9eb81f8dda1597531942aa51ffa746e7 [file] [log] [blame]
Ted Kremenek6f342132011-03-15 03:17:07 +00001//==- UninitializedValues.cpp - Find Uninitialized Values -------*- C++ --*-==//
Ted Kremenek610068c2011-01-15 02:58:47 +00002//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// This file implements uninitialized values analysis for source-level CFGs.
11//
12//===----------------------------------------------------------------------===//
13
Richard Smith558e8872012-07-13 23:33:44 +000014#include "clang/AST/ASTContext.h"
Benjamin Kramer2fa67ef2012-12-01 15:09:41 +000015#include "clang/AST/Attr.h"
Ted Kremenek610068c2011-01-15 02:58:47 +000016#include "clang/AST/Decl.h"
Jordan Rosed049b402013-05-15 23:22:55 +000017#include "clang/AST/StmtVisitor.h"
Ted Kremenekc1602582012-11-17 02:00:00 +000018#include "clang/Analysis/Analyses/PostOrderCFGView.h"
Ted Kremenek6f342132011-03-15 03:17:07 +000019#include "clang/Analysis/Analyses/UninitializedValues.h"
Benjamin Kramer2fa67ef2012-12-01 15:09:41 +000020#include "clang/Analysis/AnalysisContext.h"
21#include "clang/Analysis/CFG.h"
Ted Kremenek25c1d572012-09-13 00:21:35 +000022#include "clang/Analysis/DomainSpecific/ObjCNoReturn.h"
Benjamin Kramer2fa67ef2012-12-01 15:09:41 +000023#include "llvm/ADT/DenseMap.h"
24#include "llvm/ADT/Optional.h"
25#include "llvm/ADT/PackedVector.h"
26#include "llvm/ADT/SmallBitVector.h"
27#include "llvm/ADT/SmallVector.h"
Argyrios Kyrtzidisb2c60b02012-03-01 19:45:56 +000028#include "llvm/Support/SaveAndRestore.h"
Benjamin Kramer2fa67ef2012-12-01 15:09:41 +000029#include <utility>
Ted Kremenek610068c2011-01-15 02:58:47 +000030
31using namespace clang;
32
Richard Smith558e8872012-07-13 23:33:44 +000033#define DEBUG_LOGGING 0
34
Ted Kremenek40900ee2011-01-27 02:29:34 +000035static bool isTrackedVar(const VarDecl *vd, const DeclContext *dc) {
Ted Kremenek1cbc3152011-03-17 03:06:11 +000036 if (vd->isLocalVarDecl() && !vd->hasGlobalStorage() &&
Ted Kremeneka21612f2011-04-07 20:02:56 +000037 !vd->isExceptionVariable() &&
Ted Kremenek1cbc3152011-03-17 03:06:11 +000038 vd->getDeclContext() == dc) {
39 QualType ty = vd->getType();
40 return ty->isScalarType() || ty->isVectorType();
41 }
42 return false;
Ted Kremenekc104e532011-01-18 04:53:25 +000043}
44
Ted Kremenek610068c2011-01-15 02:58:47 +000045//------------------------------------------------------------------------====//
Ted Kremenek136f8f22011-03-15 04:57:27 +000046// DeclToIndex: a mapping from Decls we track to value indices.
Ted Kremenek610068c2011-01-15 02:58:47 +000047//====------------------------------------------------------------------------//
48
49namespace {
Ted Kremenek136f8f22011-03-15 04:57:27 +000050class DeclToIndex {
Ted Kremenek610068c2011-01-15 02:58:47 +000051 llvm::DenseMap<const VarDecl *, unsigned> map;
52public:
Ted Kremenek136f8f22011-03-15 04:57:27 +000053 DeclToIndex() {}
Ted Kremenek610068c2011-01-15 02:58:47 +000054
55 /// Compute the actual mapping from declarations to bits.
56 void computeMap(const DeclContext &dc);
57
58 /// Return the number of declarations in the map.
59 unsigned size() const { return map.size(); }
60
61 /// Returns the bit vector index for a given declaration.
David Blaikiedc84cd52013-02-20 22:23:23 +000062 Optional<unsigned> getValueIndex(const VarDecl *d) const;
Ted Kremenek610068c2011-01-15 02:58:47 +000063};
64}
65
Ted Kremenek136f8f22011-03-15 04:57:27 +000066void DeclToIndex::computeMap(const DeclContext &dc) {
Ted Kremenek610068c2011-01-15 02:58:47 +000067 unsigned count = 0;
68 DeclContext::specific_decl_iterator<VarDecl> I(dc.decls_begin()),
69 E(dc.decls_end());
70 for ( ; I != E; ++I) {
David Blaikie581deb32012-06-06 20:45:41 +000071 const VarDecl *vd = *I;
Ted Kremenek40900ee2011-01-27 02:29:34 +000072 if (isTrackedVar(vd, &dc))
Ted Kremenek610068c2011-01-15 02:58:47 +000073 map[vd] = count++;
74 }
75}
76
David Blaikiedc84cd52013-02-20 22:23:23 +000077Optional<unsigned> DeclToIndex::getValueIndex(const VarDecl *d) const {
Ted Kremenekb831c672011-03-29 01:40:00 +000078 llvm::DenseMap<const VarDecl *, unsigned>::const_iterator I = map.find(d);
Ted Kremenek610068c2011-01-15 02:58:47 +000079 if (I == map.end())
David Blaikie66874fb2013-02-21 01:47:18 +000080 return None;
Ted Kremenek610068c2011-01-15 02:58:47 +000081 return I->second;
82}
83
84//------------------------------------------------------------------------====//
85// CFGBlockValues: dataflow values for CFG blocks.
86//====------------------------------------------------------------------------//
87
Ted Kremenekf7bafc72011-03-15 04:57:38 +000088// These values are defined in such a way that a merge can be done using
89// a bitwise OR.
90enum Value { Unknown = 0x0, /* 00 */
91 Initialized = 0x1, /* 01 */
92 Uninitialized = 0x2, /* 10 */
93 MayUninitialized = 0x3 /* 11 */ };
94
95static bool isUninitialized(const Value v) {
96 return v >= Uninitialized;
97}
98static bool isAlwaysUninit(const Value v) {
99 return v == Uninitialized;
100}
Ted Kremenekafb10c42011-03-15 04:57:29 +0000101
Benjamin Kramerda57f3e2011-03-26 12:38:21 +0000102namespace {
Ted Kremenek496398d2011-03-15 04:57:32 +0000103
Benjamin Kramerda3d76b2012-09-28 16:44:29 +0000104typedef llvm::PackedVector<Value, 2, llvm::SmallBitVector> ValueVector;
Ted Kremenek13bd4232011-01-20 17:37:17 +0000105
Ted Kremenek610068c2011-01-15 02:58:47 +0000106class CFGBlockValues {
107 const CFG &cfg;
Benjamin Kramerda3d76b2012-09-28 16:44:29 +0000108 SmallVector<ValueVector, 8> vals;
Ted Kremenek136f8f22011-03-15 04:57:27 +0000109 ValueVector scratch;
Ted Kremenek4ddb3872011-03-15 05:30:12 +0000110 DeclToIndex declToIndex;
Ted Kremenek610068c2011-01-15 02:58:47 +0000111public:
112 CFGBlockValues(const CFG &cfg);
Ted Kremenekeee18c32012-07-19 04:59:05 +0000113
Ted Kremenekd40066b2011-04-04 23:29:12 +0000114 unsigned getNumEntries() const { return declToIndex.size(); }
115
Ted Kremenek610068c2011-01-15 02:58:47 +0000116 void computeSetOfDeclarations(const DeclContext &dc);
Ted Kremenekeee18c32012-07-19 04:59:05 +0000117 ValueVector &getValueVector(const CFGBlock *block) {
Benjamin Kramerda3d76b2012-09-28 16:44:29 +0000118 return vals[block->getBlockID()];
Ted Kremenekeee18c32012-07-19 04:59:05 +0000119 }
Ted Kremenek13bd4232011-01-20 17:37:17 +0000120
Richard Smitha9e8b9e2012-07-02 23:23:04 +0000121 void setAllScratchValues(Value V);
Ted Kremenek136f8f22011-03-15 04:57:27 +0000122 void mergeIntoScratch(ValueVector const &source, bool isFirst);
123 bool updateValueVectorWithScratch(const CFGBlock *block);
Ted Kremenek610068c2011-01-15 02:58:47 +0000124
125 bool hasNoDeclarations() const {
Ted Kremenek4ddb3872011-03-15 05:30:12 +0000126 return declToIndex.size() == 0;
Ted Kremenek610068c2011-01-15 02:58:47 +0000127 }
Ted Kremeneke0e29332011-08-20 01:15:28 +0000128
Ted Kremenek610068c2011-01-15 02:58:47 +0000129 void resetScratch();
Ted Kremenek13bd4232011-01-20 17:37:17 +0000130
Ted Kremenek136f8f22011-03-15 04:57:27 +0000131 ValueVector::reference operator[](const VarDecl *vd);
Richard Smith2815e1a2012-05-25 02:17:09 +0000132
133 Value getValue(const CFGBlock *block, const CFGBlock *dstBlock,
134 const VarDecl *vd) {
David Blaikiedc84cd52013-02-20 22:23:23 +0000135 const Optional<unsigned> &idx = declToIndex.getValueIndex(vd);
Richard Smith2815e1a2012-05-25 02:17:09 +0000136 assert(idx.hasValue());
Ted Kremenekeee18c32012-07-19 04:59:05 +0000137 return getValueVector(block)[idx.getValue()];
Richard Smith2815e1a2012-05-25 02:17:09 +0000138 }
Ted Kremenek610068c2011-01-15 02:58:47 +0000139};
Benjamin Kramerda57f3e2011-03-26 12:38:21 +0000140} // end anonymous namespace
Ted Kremenek610068c2011-01-15 02:58:47 +0000141
Ted Kremenekeee18c32012-07-19 04:59:05 +0000142CFGBlockValues::CFGBlockValues(const CFG &c) : cfg(c), vals(0) {}
Ted Kremenek610068c2011-01-15 02:58:47 +0000143
Ted Kremenek610068c2011-01-15 02:58:47 +0000144void CFGBlockValues::computeSetOfDeclarations(const DeclContext &dc) {
Ted Kremenek4ddb3872011-03-15 05:30:12 +0000145 declToIndex.computeMap(dc);
Ted Kremenekeee18c32012-07-19 04:59:05 +0000146 unsigned decls = declToIndex.size();
147 scratch.resize(decls);
148 unsigned n = cfg.getNumBlockIDs();
149 if (!n)
150 return;
151 vals.resize(n);
152 for (unsigned i = 0; i < n; ++i)
Benjamin Kramerda3d76b2012-09-28 16:44:29 +0000153 vals[i].resize(decls);
Ted Kremenek13bd4232011-01-20 17:37:17 +0000154}
155
Richard Smith558e8872012-07-13 23:33:44 +0000156#if DEBUG_LOGGING
Ted Kremenek136f8f22011-03-15 04:57:27 +0000157static void printVector(const CFGBlock *block, ValueVector &bv,
Ted Kremenek9fcbcee2011-02-01 17:43:18 +0000158 unsigned num) {
Ted Kremenek9fcbcee2011-02-01 17:43:18 +0000159 llvm::errs() << block->getBlockID() << " :";
160 for (unsigned i = 0; i < bv.size(); ++i) {
161 llvm::errs() << ' ' << bv[i];
162 }
163 llvm::errs() << " : " << num << '\n';
164}
165#endif
Ted Kremenek610068c2011-01-15 02:58:47 +0000166
Richard Smitha9e8b9e2012-07-02 23:23:04 +0000167void CFGBlockValues::setAllScratchValues(Value V) {
168 for (unsigned I = 0, E = scratch.size(); I != E; ++I)
169 scratch[I] = V;
170}
171
Ted Kremenekc5f740e2011-10-07 00:42:48 +0000172void CFGBlockValues::mergeIntoScratch(ValueVector const &source,
173 bool isFirst) {
174 if (isFirst)
175 scratch = source;
176 else
177 scratch |= source;
178}
179
Ted Kremenek136f8f22011-03-15 04:57:27 +0000180bool CFGBlockValues::updateValueVectorWithScratch(const CFGBlock *block) {
Ted Kremenekeee18c32012-07-19 04:59:05 +0000181 ValueVector &dst = getValueVector(block);
Ted Kremenek610068c2011-01-15 02:58:47 +0000182 bool changed = (dst != scratch);
183 if (changed)
184 dst = scratch;
Richard Smith558e8872012-07-13 23:33:44 +0000185#if DEBUG_LOGGING
Ted Kremenek9fcbcee2011-02-01 17:43:18 +0000186 printVector(block, scratch, 0);
187#endif
Ted Kremenek13bd4232011-01-20 17:37:17 +0000188 return changed;
189}
190
Ted Kremenek610068c2011-01-15 02:58:47 +0000191void CFGBlockValues::resetScratch() {
192 scratch.reset();
193}
194
Ted Kremenek136f8f22011-03-15 04:57:27 +0000195ValueVector::reference CFGBlockValues::operator[](const VarDecl *vd) {
David Blaikiedc84cd52013-02-20 22:23:23 +0000196 const Optional<unsigned> &idx = declToIndex.getValueIndex(vd);
Ted Kremenek610068c2011-01-15 02:58:47 +0000197 assert(idx.hasValue());
198 return scratch[idx.getValue()];
199}
200
201//------------------------------------------------------------------------====//
202// Worklist: worklist for dataflow analysis.
203//====------------------------------------------------------------------------//
204
205namespace {
206class DataflowWorklist {
Ted Kremenekc1602582012-11-17 02:00:00 +0000207 PostOrderCFGView::iterator PO_I, PO_E;
Chris Lattner5f9e2722011-07-23 10:55:15 +0000208 SmallVector<const CFGBlock *, 20> worklist;
Ted Kremenek496398d2011-03-15 04:57:32 +0000209 llvm::BitVector enqueuedBlocks;
Ted Kremenek610068c2011-01-15 02:58:47 +0000210public:
Ted Kremenekc1602582012-11-17 02:00:00 +0000211 DataflowWorklist(const CFG &cfg, PostOrderCFGView &view)
212 : PO_I(view.begin()), PO_E(view.end()),
213 enqueuedBlocks(cfg.getNumBlockIDs(), true) {
214 // Treat the first block as already analyzed.
215 if (PO_I != PO_E) {
216 assert(*PO_I == &cfg.getEntry());
217 enqueuedBlocks[(*PO_I)->getBlockID()] = false;
218 ++PO_I;
219 }
220 }
Ted Kremenek610068c2011-01-15 02:58:47 +0000221
Ted Kremenek610068c2011-01-15 02:58:47 +0000222 void enqueueSuccessors(const CFGBlock *block);
223 const CFGBlock *dequeue();
Ted Kremenek610068c2011-01-15 02:58:47 +0000224};
225}
226
Ted Kremenek610068c2011-01-15 02:58:47 +0000227void DataflowWorklist::enqueueSuccessors(const clang::CFGBlock *block) {
228 for (CFGBlock::const_succ_iterator I = block->succ_begin(),
229 E = block->succ_end(); I != E; ++I) {
Chandler Carruth80520502011-07-08 11:19:06 +0000230 const CFGBlock *Successor = *I;
231 if (!Successor || enqueuedBlocks[Successor->getBlockID()])
232 continue;
233 worklist.push_back(Successor);
234 enqueuedBlocks[Successor->getBlockID()] = true;
Ted Kremenek610068c2011-01-15 02:58:47 +0000235 }
236}
237
238const CFGBlock *DataflowWorklist::dequeue() {
Ted Kremenekc1602582012-11-17 02:00:00 +0000239 const CFGBlock *B = 0;
240
241 // First dequeue from the worklist. This can represent
242 // updates along backedges that we want propagated as quickly as possible.
Robert Wilhelm344472e2013-08-23 16:11:15 +0000243 if (!worklist.empty())
244 B = worklist.pop_back_val();
245
Ted Kremenekc1602582012-11-17 02:00:00 +0000246 // Next dequeue from the initial reverse post order. This is the
247 // theoretical ideal in the presence of no back edges.
248 else if (PO_I != PO_E) {
249 B = *PO_I;
250 ++PO_I;
251 }
252 else {
Ted Kremenek610068c2011-01-15 02:58:47 +0000253 return 0;
Ted Kremenekc1602582012-11-17 02:00:00 +0000254 }
255
256 assert(enqueuedBlocks[B->getBlockID()] == true);
257 enqueuedBlocks[B->getBlockID()] = false;
258 return B;
Ted Kremenek610068c2011-01-15 02:58:47 +0000259}
260
261//------------------------------------------------------------------------====//
Richard Smith9532e0d2012-07-17 00:06:14 +0000262// Classification of DeclRefExprs as use or initialization.
Ted Kremenek610068c2011-01-15 02:58:47 +0000263//====------------------------------------------------------------------------//
264
Ted Kremenek610068c2011-01-15 02:58:47 +0000265namespace {
266class FindVarResult {
267 const VarDecl *vd;
268 const DeclRefExpr *dr;
269public:
Richard Smith9532e0d2012-07-17 00:06:14 +0000270 FindVarResult(const VarDecl *vd, const DeclRefExpr *dr) : vd(vd), dr(dr) {}
271
Ted Kremenek610068c2011-01-15 02:58:47 +0000272 const DeclRefExpr *getDeclRefExpr() const { return dr; }
273 const VarDecl *getDecl() const { return vd; }
274};
Richard Smith9532e0d2012-07-17 00:06:14 +0000275
276static const Expr *stripCasts(ASTContext &C, const Expr *Ex) {
277 while (Ex) {
278 Ex = Ex->IgnoreParenNoopCasts(C);
279 if (const CastExpr *CE = dyn_cast<CastExpr>(Ex)) {
280 if (CE->getCastKind() == CK_LValueBitCast) {
281 Ex = CE->getSubExpr();
282 continue;
283 }
284 }
285 break;
286 }
287 return Ex;
288}
289
290/// If E is an expression comprising a reference to a single variable, find that
291/// variable.
292static FindVarResult findVar(const Expr *E, const DeclContext *DC) {
293 if (const DeclRefExpr *DRE =
294 dyn_cast<DeclRefExpr>(stripCasts(DC->getParentASTContext(), E)))
295 if (const VarDecl *VD = dyn_cast<VarDecl>(DRE->getDecl()))
296 if (isTrackedVar(VD, DC))
297 return FindVarResult(VD, DRE);
298 return FindVarResult(0, 0);
299}
300
301/// \brief Classify each DeclRefExpr as an initialization or a use. Any
302/// DeclRefExpr which isn't explicitly classified will be assumed to have
303/// escaped the analysis and will be treated as an initialization.
304class ClassifyRefs : public StmtVisitor<ClassifyRefs> {
305public:
306 enum Class {
307 Init,
308 Use,
309 SelfInit,
310 Ignore
311 };
312
313private:
314 const DeclContext *DC;
315 llvm::DenseMap<const DeclRefExpr*, Class> Classification;
316
317 bool isTrackedVar(const VarDecl *VD) const {
318 return ::isTrackedVar(VD, DC);
319 }
320
321 void classify(const Expr *E, Class C);
322
323public:
324 ClassifyRefs(AnalysisDeclContext &AC) : DC(cast<DeclContext>(AC.getDecl())) {}
325
326 void VisitDeclStmt(DeclStmt *DS);
327 void VisitUnaryOperator(UnaryOperator *UO);
328 void VisitBinaryOperator(BinaryOperator *BO);
329 void VisitCallExpr(CallExpr *CE);
330 void VisitCastExpr(CastExpr *CE);
331
332 void operator()(Stmt *S) { Visit(S); }
333
334 Class get(const DeclRefExpr *DRE) const {
335 llvm::DenseMap<const DeclRefExpr*, Class>::const_iterator I
336 = Classification.find(DRE);
337 if (I != Classification.end())
338 return I->second;
339
340 const VarDecl *VD = dyn_cast<VarDecl>(DRE->getDecl());
341 if (!VD || !isTrackedVar(VD))
342 return Ignore;
343
344 return Init;
345 }
346};
347}
348
349static const DeclRefExpr *getSelfInitExpr(VarDecl *VD) {
350 if (Expr *Init = VD->getInit()) {
351 const DeclRefExpr *DRE
352 = dyn_cast<DeclRefExpr>(stripCasts(VD->getASTContext(), Init));
353 if (DRE && DRE->getDecl() == VD)
354 return DRE;
355 }
356 return 0;
357}
358
359void ClassifyRefs::classify(const Expr *E, Class C) {
Ted Kremenek77fd3c02013-01-19 00:25:06 +0000360 // The result of a ?: could also be an lvalue.
361 E = E->IgnoreParens();
362 if (const ConditionalOperator *CO = dyn_cast<ConditionalOperator>(E)) {
363 const Expr *TrueExpr = CO->getTrueExpr();
364 if (!isa<OpaqueValueExpr>(TrueExpr))
365 classify(TrueExpr, C);
366 classify(CO->getFalseExpr(), C);
367 return;
368 }
369
Richard Smith9532e0d2012-07-17 00:06:14 +0000370 FindVarResult Var = findVar(E, DC);
371 if (const DeclRefExpr *DRE = Var.getDeclRefExpr())
372 Classification[DRE] = std::max(Classification[DRE], C);
373}
374
375void ClassifyRefs::VisitDeclStmt(DeclStmt *DS) {
376 for (DeclStmt::decl_iterator DI = DS->decl_begin(), DE = DS->decl_end();
377 DI != DE; ++DI) {
378 VarDecl *VD = dyn_cast<VarDecl>(*DI);
379 if (VD && isTrackedVar(VD))
380 if (const DeclRefExpr *DRE = getSelfInitExpr(VD))
381 Classification[DRE] = SelfInit;
382 }
383}
384
385void ClassifyRefs::VisitBinaryOperator(BinaryOperator *BO) {
386 // Ignore the evaluation of a DeclRefExpr on the LHS of an assignment. If this
387 // is not a compound-assignment, we will treat it as initializing the variable
388 // when TransferFunctions visits it. A compound-assignment does not affect
389 // whether a variable is uninitialized, and there's no point counting it as a
390 // use.
Richard Smith6cfa78f2012-07-17 01:27:33 +0000391 if (BO->isCompoundAssignmentOp())
392 classify(BO->getLHS(), Use);
393 else if (BO->getOpcode() == BO_Assign)
Richard Smith9532e0d2012-07-17 00:06:14 +0000394 classify(BO->getLHS(), Ignore);
395}
396
397void ClassifyRefs::VisitUnaryOperator(UnaryOperator *UO) {
398 // Increment and decrement are uses despite there being no lvalue-to-rvalue
399 // conversion.
400 if (UO->isIncrementDecrementOp())
401 classify(UO->getSubExpr(), Use);
402}
403
404void ClassifyRefs::VisitCallExpr(CallExpr *CE) {
405 // If a value is passed by const reference to a function, we should not assume
406 // that it is initialized by the call, and we conservatively do not assume
407 // that it is used.
408 for (CallExpr::arg_iterator I = CE->arg_begin(), E = CE->arg_end();
409 I != E; ++I)
410 if ((*I)->getType().isConstQualified() && (*I)->isGLValue())
411 classify(*I, Ignore);
412}
413
414void ClassifyRefs::VisitCastExpr(CastExpr *CE) {
415 if (CE->getCastKind() == CK_LValueToRValue)
416 classify(CE->getSubExpr(), Use);
417 else if (CStyleCastExpr *CSE = dyn_cast<CStyleCastExpr>(CE)) {
418 if (CSE->getType()->isVoidType()) {
419 // Squelch any detected load of an uninitialized value if
420 // we cast it to void.
421 // e.g. (void) x;
422 classify(CSE->getSubExpr(), Ignore);
423 }
424 }
425}
426
427//------------------------------------------------------------------------====//
428// Transfer function for uninitialized values analysis.
429//====------------------------------------------------------------------------//
430
431namespace {
Ted Kremenek0c8e5a02011-07-19 14:18:48 +0000432class TransferFunctions : public StmtVisitor<TransferFunctions> {
Ted Kremenek610068c2011-01-15 02:58:47 +0000433 CFGBlockValues &vals;
434 const CFG &cfg;
Richard Smith2815e1a2012-05-25 02:17:09 +0000435 const CFGBlock *block;
Ted Kremenek1d26f482011-10-24 01:32:45 +0000436 AnalysisDeclContext &ac;
Richard Smith9532e0d2012-07-17 00:06:14 +0000437 const ClassifyRefs &classification;
Ted Kremenek25c1d572012-09-13 00:21:35 +0000438 ObjCNoReturn objCNoRet;
Ted Kremenekeba76a42012-11-17 07:18:30 +0000439 UninitVariablesHandler &handler;
Richard Smith9532e0d2012-07-17 00:06:14 +0000440
Ted Kremenek610068c2011-01-15 02:58:47 +0000441public:
442 TransferFunctions(CFGBlockValues &vals, const CFG &cfg,
Richard Smith2815e1a2012-05-25 02:17:09 +0000443 const CFGBlock *block, AnalysisDeclContext &ac,
Richard Smith9532e0d2012-07-17 00:06:14 +0000444 const ClassifyRefs &classification,
Ted Kremenekeba76a42012-11-17 07:18:30 +0000445 UninitVariablesHandler &handler)
Richard Smith9532e0d2012-07-17 00:06:14 +0000446 : vals(vals), cfg(cfg), block(block), ac(ac),
Ted Kremenek25c1d572012-09-13 00:21:35 +0000447 classification(classification), objCNoRet(ac.getASTContext()),
448 handler(handler) {}
Richard Smith9532e0d2012-07-17 00:06:14 +0000449
Richard Smith81891882012-05-24 23:45:35 +0000450 void reportUse(const Expr *ex, const VarDecl *vd);
Ted Kremeneka8c17a52011-01-25 19:13:48 +0000451
Ted Kremenek25c1d572012-09-13 00:21:35 +0000452 void VisitBinaryOperator(BinaryOperator *bo);
Ted Kremeneka8c17a52011-01-25 19:13:48 +0000453 void VisitBlockExpr(BlockExpr *be);
Richard Smitha9e8b9e2012-07-02 23:23:04 +0000454 void VisitCallExpr(CallExpr *ce);
Ted Kremenekc21fed32011-01-18 21:18:58 +0000455 void VisitDeclRefExpr(DeclRefExpr *dr);
Ted Kremenek25c1d572012-09-13 00:21:35 +0000456 void VisitDeclStmt(DeclStmt *ds);
457 void VisitObjCForCollectionStmt(ObjCForCollectionStmt *FS);
458 void VisitObjCMessageExpr(ObjCMessageExpr *ME);
Richard Smith2815e1a2012-05-25 02:17:09 +0000459
Ted Kremenek40900ee2011-01-27 02:29:34 +0000460 bool isTrackedVar(const VarDecl *vd) {
461 return ::isTrackedVar(vd, cast<DeclContext>(ac.getDecl()));
462 }
Richard Smith2815e1a2012-05-25 02:17:09 +0000463
Richard Smith9532e0d2012-07-17 00:06:14 +0000464 FindVarResult findVar(const Expr *ex) {
465 return ::findVar(ex, cast<DeclContext>(ac.getDecl()));
466 }
467
Richard Smith2815e1a2012-05-25 02:17:09 +0000468 UninitUse getUninitUse(const Expr *ex, const VarDecl *vd, Value v) {
469 UninitUse Use(ex, isAlwaysUninit(v));
470
471 assert(isUninitialized(v));
472 if (Use.getKind() == UninitUse::Always)
473 return Use;
474
475 // If an edge which leads unconditionally to this use did not initialize
476 // the variable, we can say something stronger than 'may be uninitialized':
477 // we can say 'either it's used uninitialized or you have dead code'.
478 //
479 // We track the number of successors of a node which have been visited, and
480 // visit a node once we have visited all of its successors. Only edges where
481 // the variable might still be uninitialized are followed. Since a variable
482 // can't transfer from being initialized to being uninitialized, this will
483 // trace out the subgraph which inevitably leads to the use and does not
484 // initialize the variable. We do not want to skip past loops, since their
485 // non-termination might be correlated with the initialization condition.
486 //
487 // For example:
488 //
489 // void f(bool a, bool b) {
490 // block1: int n;
491 // if (a) {
492 // block2: if (b)
493 // block3: n = 1;
494 // block4: } else if (b) {
495 // block5: while (!a) {
496 // block6: do_work(&a);
497 // n = 2;
498 // }
499 // }
500 // block7: if (a)
501 // block8: g();
502 // block9: return n;
503 // }
504 //
505 // Starting from the maybe-uninitialized use in block 9:
506 // * Block 7 is not visited because we have only visited one of its two
507 // successors.
508 // * Block 8 is visited because we've visited its only successor.
509 // From block 8:
510 // * Block 7 is visited because we've now visited both of its successors.
511 // From block 7:
512 // * Blocks 1, 2, 4, 5, and 6 are not visited because we didn't visit all
513 // of their successors (we didn't visit 4, 3, 5, 6, and 5, respectively).
514 // * Block 3 is not visited because it initializes 'n'.
515 // Now the algorithm terminates, having visited blocks 7 and 8, and having
516 // found the frontier is blocks 2, 4, and 5.
517 //
518 // 'n' is definitely uninitialized for two edges into block 7 (from blocks 2
519 // and 4), so we report that any time either of those edges is taken (in
520 // each case when 'b == false'), 'n' is used uninitialized.
Dmitri Gribenkocfa88f82013-01-12 19:30:44 +0000521 SmallVector<const CFGBlock*, 32> Queue;
522 SmallVector<unsigned, 32> SuccsVisited(cfg.getNumBlockIDs(), 0);
Richard Smith2815e1a2012-05-25 02:17:09 +0000523 Queue.push_back(block);
524 // Specify that we've already visited all successors of the starting block.
525 // This has the dual purpose of ensuring we never add it to the queue, and
526 // of marking it as not being a candidate element of the frontier.
527 SuccsVisited[block->getBlockID()] = block->succ_size();
528 while (!Queue.empty()) {
Robert Wilhelm344472e2013-08-23 16:11:15 +0000529 const CFGBlock *B = Queue.pop_back_val();
Richard Smith2815e1a2012-05-25 02:17:09 +0000530 for (CFGBlock::const_pred_iterator I = B->pred_begin(), E = B->pred_end();
531 I != E; ++I) {
532 const CFGBlock *Pred = *I;
533 if (vals.getValue(Pred, B, vd) == Initialized)
534 // This block initializes the variable.
535 continue;
536
Richard Smith558e8872012-07-13 23:33:44 +0000537 unsigned &SV = SuccsVisited[Pred->getBlockID()];
538 if (!SV) {
539 // When visiting the first successor of a block, mark all NULL
540 // successors as having been visited.
541 for (CFGBlock::const_succ_iterator SI = Pred->succ_begin(),
542 SE = Pred->succ_end();
543 SI != SE; ++SI)
544 if (!*SI)
545 ++SV;
546 }
547
548 if (++SV == Pred->succ_size())
Richard Smith2815e1a2012-05-25 02:17:09 +0000549 // All paths from this block lead to the use and don't initialize the
550 // variable.
551 Queue.push_back(Pred);
552 }
553 }
554
555 // Scan the frontier, looking for blocks where the variable was
556 // uninitialized.
557 for (CFG::const_iterator BI = cfg.begin(), BE = cfg.end(); BI != BE; ++BI) {
558 const CFGBlock *Block = *BI;
559 unsigned BlockID = Block->getBlockID();
560 const Stmt *Term = Block->getTerminator();
561 if (SuccsVisited[BlockID] && SuccsVisited[BlockID] < Block->succ_size() &&
562 Term) {
563 // This block inevitably leads to the use. If we have an edge from here
564 // to a post-dominator block, and the variable is uninitialized on that
565 // edge, we have found a bug.
566 for (CFGBlock::const_succ_iterator I = Block->succ_begin(),
567 E = Block->succ_end(); I != E; ++I) {
568 const CFGBlock *Succ = *I;
569 if (Succ && SuccsVisited[Succ->getBlockID()] >= Succ->succ_size() &&
570 vals.getValue(Block, Succ, vd) == Uninitialized) {
571 // Switch cases are a special case: report the label to the caller
572 // as the 'terminator', not the switch statement itself. Suppress
573 // situations where no label matched: we can't be sure that's
574 // possible.
575 if (isa<SwitchStmt>(Term)) {
576 const Stmt *Label = Succ->getLabel();
577 if (!Label || !isa<SwitchCase>(Label))
578 // Might not be possible.
579 continue;
580 UninitUse::Branch Branch;
581 Branch.Terminator = Label;
582 Branch.Output = 0; // Ignored.
583 Use.addUninitBranch(Branch);
584 } else {
585 UninitUse::Branch Branch;
586 Branch.Terminator = Term;
587 Branch.Output = I - Block->succ_begin();
588 Use.addUninitBranch(Branch);
589 }
590 }
591 }
592 }
593 }
594
595 return Use;
596 }
Ted Kremenek610068c2011-01-15 02:58:47 +0000597};
598}
599
Richard Smith81891882012-05-24 23:45:35 +0000600void TransferFunctions::reportUse(const Expr *ex, const VarDecl *vd) {
Richard Smith81891882012-05-24 23:45:35 +0000601 Value v = vals[vd];
602 if (isUninitialized(v))
Ted Kremenekeba76a42012-11-17 07:18:30 +0000603 handler.handleUseOfUninitVariable(vd, getUninitUse(ex, vd, v));
Ted Kremenek610068c2011-01-15 02:58:47 +0000604}
605
Richard Smith9532e0d2012-07-17 00:06:14 +0000606void TransferFunctions::VisitObjCForCollectionStmt(ObjCForCollectionStmt *FS) {
Ted Kremenek1ea800c2011-01-27 02:01:31 +0000607 // This represents an initialization of the 'element' value.
Richard Smith9532e0d2012-07-17 00:06:14 +0000608 if (DeclStmt *DS = dyn_cast<DeclStmt>(FS->getElement())) {
609 const VarDecl *VD = cast<VarDecl>(DS->getSingleDecl());
610 if (isTrackedVar(VD))
611 vals[VD] = Initialized;
Ted Kremenek1ea800c2011-01-27 02:01:31 +0000612 }
Ted Kremenek1ea800c2011-01-27 02:01:31 +0000613}
614
Ted Kremeneka8c17a52011-01-25 19:13:48 +0000615void TransferFunctions::VisitBlockExpr(BlockExpr *be) {
Ted Kremenekbc8b44c2011-03-31 22:32:41 +0000616 const BlockDecl *bd = be->getBlockDecl();
617 for (BlockDecl::capture_const_iterator i = bd->capture_begin(),
618 e = bd->capture_end() ; i != e; ++i) {
619 const VarDecl *vd = i->getVariable();
Ted Kremenekbc8b44c2011-03-31 22:32:41 +0000620 if (!isTrackedVar(vd))
621 continue;
622 if (i->isByRef()) {
623 vals[vd] = Initialized;
624 continue;
625 }
Richard Smith81891882012-05-24 23:45:35 +0000626 reportUse(be, vd);
Ted Kremeneka8c17a52011-01-25 19:13:48 +0000627 }
628}
629
Richard Smitha9e8b9e2012-07-02 23:23:04 +0000630void TransferFunctions::VisitCallExpr(CallExpr *ce) {
Ted Kremenek44ca53f2012-09-12 05:53:43 +0000631 if (Decl *Callee = ce->getCalleeDecl()) {
632 if (Callee->hasAttr<ReturnsTwiceAttr>()) {
633 // After a call to a function like setjmp or vfork, any variable which is
634 // initialized anywhere within this function may now be initialized. For
635 // now, just assume such a call initializes all variables. FIXME: Only
636 // mark variables as initialized if they have an initializer which is
637 // reachable from here.
638 vals.setAllScratchValues(Initialized);
639 }
640 else if (Callee->hasAttr<AnalyzerNoReturnAttr>()) {
641 // Functions labeled like "analyzer_noreturn" are often used to denote
642 // "panic" functions that in special debug situations can still return,
643 // but for the most part should not be treated as returning. This is a
644 // useful annotation borrowed from the static analyzer that is useful for
645 // suppressing branch-specific false positives when we call one of these
646 // functions but keep pretending the path continues (when in reality the
647 // user doesn't care).
648 vals.setAllScratchValues(Unknown);
649 }
650 }
Richard Smitha9e8b9e2012-07-02 23:23:04 +0000651}
652
Ted Kremenek0c8e5a02011-07-19 14:18:48 +0000653void TransferFunctions::VisitDeclRefExpr(DeclRefExpr *dr) {
Richard Smith9532e0d2012-07-17 00:06:14 +0000654 switch (classification.get(dr)) {
655 case ClassifyRefs::Ignore:
656 break;
657 case ClassifyRefs::Use:
658 reportUse(dr, cast<VarDecl>(dr->getDecl()));
659 break;
660 case ClassifyRefs::Init:
661 vals[cast<VarDecl>(dr->getDecl())] = Initialized;
662 break;
663 case ClassifyRefs::SelfInit:
Ted Kremenekeba76a42012-11-17 07:18:30 +0000664 handler.handleSelfInit(cast<VarDecl>(dr->getDecl()));
Richard Smith9532e0d2012-07-17 00:06:14 +0000665 break;
666 }
Ted Kremenek0c8e5a02011-07-19 14:18:48 +0000667}
668
Richard Smith9532e0d2012-07-17 00:06:14 +0000669void TransferFunctions::VisitBinaryOperator(BinaryOperator *BO) {
670 if (BO->getOpcode() == BO_Assign) {
671 FindVarResult Var = findVar(BO->getLHS());
672 if (const VarDecl *VD = Var.getDecl())
673 vals[VD] = Initialized;
674 }
675}
676
677void TransferFunctions::VisitDeclStmt(DeclStmt *DS) {
678 for (DeclStmt::decl_iterator DI = DS->decl_begin(), DE = DS->decl_end();
Ted Kremenek610068c2011-01-15 02:58:47 +0000679 DI != DE; ++DI) {
Richard Smith9532e0d2012-07-17 00:06:14 +0000680 VarDecl *VD = dyn_cast<VarDecl>(*DI);
681 if (VD && isTrackedVar(VD)) {
682 if (getSelfInitExpr(VD)) {
683 // If the initializer consists solely of a reference to itself, we
684 // explicitly mark the variable as uninitialized. This allows code
685 // like the following:
686 //
687 // int x = x;
688 //
689 // to deliberately leave a variable uninitialized. Different analysis
690 // clients can detect this pattern and adjust their reporting
691 // appropriately, but we need to continue to analyze subsequent uses
692 // of the variable.
693 vals[VD] = Uninitialized;
694 } else if (VD->getInit()) {
695 // Treat the new variable as initialized.
696 vals[VD] = Initialized;
697 } else {
698 // No initializer: the variable is now uninitialized. This matters
699 // for cases like:
700 // while (...) {
701 // int n;
702 // use(n);
703 // n = 0;
704 // }
705 // FIXME: Mark the variable as uninitialized whenever its scope is
706 // left, since its scope could be re-entered by a jump over the
707 // declaration.
708 vals[VD] = Uninitialized;
Ted Kremenekc21fed32011-01-18 21:18:58 +0000709 }
Ted Kremenek610068c2011-01-15 02:58:47 +0000710 }
711 }
712}
713
Ted Kremenek25c1d572012-09-13 00:21:35 +0000714void TransferFunctions::VisitObjCMessageExpr(ObjCMessageExpr *ME) {
715 // If the Objective-C message expression is an implicit no-return that
716 // is not modeled in the CFG, set the tracked dataflow values to Unknown.
717 if (objCNoRet.isImplicitNoReturn(ME)) {
718 vals.setAllScratchValues(Unknown);
719 }
720}
721
Ted Kremenek610068c2011-01-15 02:58:47 +0000722//------------------------------------------------------------------------====//
723// High-level "driver" logic for uninitialized values analysis.
724//====------------------------------------------------------------------------//
725
Ted Kremenek13bd4232011-01-20 17:37:17 +0000726static bool runOnBlock(const CFGBlock *block, const CFG &cfg,
Ted Kremenek1d26f482011-10-24 01:32:45 +0000727 AnalysisDeclContext &ac, CFGBlockValues &vals,
Richard Smith9532e0d2012-07-17 00:06:14 +0000728 const ClassifyRefs &classification,
Ted Kremenekf8adeef2011-04-04 20:30:58 +0000729 llvm::BitVector &wasAnalyzed,
Ted Kremenekeba76a42012-11-17 07:18:30 +0000730 UninitVariablesHandler &handler) {
Ted Kremenekf8adeef2011-04-04 20:30:58 +0000731 wasAnalyzed[block->getBlockID()] = true;
Ted Kremenek610068c2011-01-15 02:58:47 +0000732 vals.resetScratch();
Ted Kremenekeee18c32012-07-19 04:59:05 +0000733 // Merge in values of predecessor blocks.
Ted Kremenek610068c2011-01-15 02:58:47 +0000734 bool isFirst = true;
735 for (CFGBlock::const_pred_iterator I = block->pred_begin(),
736 E = block->pred_end(); I != E; ++I) {
Ted Kremenek6f275422011-09-02 19:39:26 +0000737 const CFGBlock *pred = *I;
738 if (wasAnalyzed[pred->getBlockID()]) {
Ted Kremenekeee18c32012-07-19 04:59:05 +0000739 vals.mergeIntoScratch(vals.getValueVector(pred), isFirst);
Ted Kremenek6f275422011-09-02 19:39:26 +0000740 isFirst = false;
741 }
Ted Kremenek610068c2011-01-15 02:58:47 +0000742 }
743 // Apply the transfer function.
Richard Smith9532e0d2012-07-17 00:06:14 +0000744 TransferFunctions tf(vals, cfg, block, ac, classification, handler);
Ted Kremenek610068c2011-01-15 02:58:47 +0000745 for (CFGBlock::const_iterator I = block->begin(), E = block->end();
746 I != E; ++I) {
David Blaikieb0780542013-02-23 00:29:34 +0000747 if (Optional<CFGStmt> cs = I->getAs<CFGStmt>())
748 tf.Visit(const_cast<Stmt*>(cs->getStmt()));
Ted Kremenek610068c2011-01-15 02:58:47 +0000749 }
Ted Kremenek136f8f22011-03-15 04:57:27 +0000750 return vals.updateValueVectorWithScratch(block);
Ted Kremenek610068c2011-01-15 02:58:47 +0000751}
752
Ted Kremenekeba76a42012-11-17 07:18:30 +0000753/// PruneBlocksHandler is a special UninitVariablesHandler that is used
754/// to detect when a CFGBlock has any *potential* use of an uninitialized
755/// variable. It is mainly used to prune out work during the final
756/// reporting pass.
757namespace {
758struct PruneBlocksHandler : public UninitVariablesHandler {
759 PruneBlocksHandler(unsigned numBlocks)
760 : hadUse(numBlocks, false), hadAnyUse(false),
761 currentBlock(0) {}
762
763 virtual ~PruneBlocksHandler() {}
764
765 /// Records if a CFGBlock had a potential use of an uninitialized variable.
766 llvm::BitVector hadUse;
767
768 /// Records if any CFGBlock had a potential use of an uninitialized variable.
769 bool hadAnyUse;
770
771 /// The current block to scribble use information.
772 unsigned currentBlock;
773
774 virtual void handleUseOfUninitVariable(const VarDecl *vd,
775 const UninitUse &use) {
776 hadUse[currentBlock] = true;
777 hadAnyUse = true;
778 }
779
780 /// Called when the uninitialized variable analysis detects the
781 /// idiom 'int x = x'. All other uses of 'x' within the initializer
782 /// are handled by handleUseOfUninitVariable.
783 virtual void handleSelfInit(const VarDecl *vd) {
784 hadUse[currentBlock] = true;
785 hadAnyUse = true;
786 }
787};
788}
789
Chandler Carruth5d989942011-07-06 16:21:37 +0000790void clang::runUninitializedVariablesAnalysis(
791 const DeclContext &dc,
792 const CFG &cfg,
Ted Kremenek1d26f482011-10-24 01:32:45 +0000793 AnalysisDeclContext &ac,
Chandler Carruth5d989942011-07-06 16:21:37 +0000794 UninitVariablesHandler &handler,
795 UninitVariablesAnalysisStats &stats) {
Ted Kremenek610068c2011-01-15 02:58:47 +0000796 CFGBlockValues vals(cfg);
797 vals.computeSetOfDeclarations(dc);
798 if (vals.hasNoDeclarations())
799 return;
Ted Kremenekd40066b2011-04-04 23:29:12 +0000800
Chandler Carruth5d989942011-07-06 16:21:37 +0000801 stats.NumVariablesAnalyzed = vals.getNumEntries();
802
Richard Smith9532e0d2012-07-17 00:06:14 +0000803 // Precompute which expressions are uses and which are initializations.
804 ClassifyRefs classification(ac);
805 cfg.VisitBlockStmts(classification);
806
Ted Kremenekd40066b2011-04-04 23:29:12 +0000807 // Mark all variables uninitialized at the entry.
808 const CFGBlock &entry = cfg.getEntry();
Ted Kremenekeee18c32012-07-19 04:59:05 +0000809 ValueVector &vec = vals.getValueVector(&entry);
810 const unsigned n = vals.getNumEntries();
811 for (unsigned j = 0; j < n ; ++j) {
812 vec[j] = Uninitialized;
Ted Kremenekd40066b2011-04-04 23:29:12 +0000813 }
814
815 // Proceed with the workist.
Ted Kremenekc1602582012-11-17 02:00:00 +0000816 DataflowWorklist worklist(cfg, *ac.getAnalysis<PostOrderCFGView>());
Ted Kremenek496398d2011-03-15 04:57:32 +0000817 llvm::BitVector previouslyVisited(cfg.getNumBlockIDs());
Ted Kremenek610068c2011-01-15 02:58:47 +0000818 worklist.enqueueSuccessors(&cfg.getEntry());
Ted Kremenekf8adeef2011-04-04 20:30:58 +0000819 llvm::BitVector wasAnalyzed(cfg.getNumBlockIDs(), false);
Ted Kremenek6f275422011-09-02 19:39:26 +0000820 wasAnalyzed[cfg.getEntry().getBlockID()] = true;
Ted Kremenekeba76a42012-11-17 07:18:30 +0000821 PruneBlocksHandler PBH(cfg.getNumBlockIDs());
Ted Kremenek610068c2011-01-15 02:58:47 +0000822
823 while (const CFGBlock *block = worklist.dequeue()) {
Ted Kremenekeba76a42012-11-17 07:18:30 +0000824 PBH.currentBlock = block->getBlockID();
825
Ted Kremenek610068c2011-01-15 02:58:47 +0000826 // Did the block change?
Richard Smith9532e0d2012-07-17 00:06:14 +0000827 bool changed = runOnBlock(block, cfg, ac, vals,
Ted Kremenekeba76a42012-11-17 07:18:30 +0000828 classification, wasAnalyzed, PBH);
Chandler Carruth5d989942011-07-06 16:21:37 +0000829 ++stats.NumBlockVisits;
Ted Kremenek610068c2011-01-15 02:58:47 +0000830 if (changed || !previouslyVisited[block->getBlockID()])
831 worklist.enqueueSuccessors(block);
832 previouslyVisited[block->getBlockID()] = true;
833 }
Ted Kremenekeba76a42012-11-17 07:18:30 +0000834
835 if (!PBH.hadAnyUse)
836 return;
837
Enea Zaffanella67d472c2013-01-11 11:37:08 +0000838 // Run through the blocks one more time, and report uninitialized variables.
Ted Kremenek610068c2011-01-15 02:58:47 +0000839 for (CFG::const_iterator BI = cfg.begin(), BE = cfg.end(); BI != BE; ++BI) {
Ted Kremenek6f275422011-09-02 19:39:26 +0000840 const CFGBlock *block = *BI;
Ted Kremenekeba76a42012-11-17 07:18:30 +0000841 if (PBH.hadUse[block->getBlockID()]) {
842 runOnBlock(block, cfg, ac, vals, classification, wasAnalyzed, handler);
Chandler Carruth5d989942011-07-06 16:21:37 +0000843 ++stats.NumBlockVisits;
844 }
Ted Kremenek610068c2011-01-15 02:58:47 +0000845 }
846}
847
848UninitVariablesHandler::~UninitVariablesHandler() {}