blob: 2a603d36e1f2ebdd81549ed779d6d5ddc3ce8a21 [file] [log] [blame]
Zhongxing Xu589c0f22009-11-12 08:38:56 +00001//=== MallocChecker.cpp - A malloc/free checker -------------------*- C++ -*--//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// This file defines malloc/free checker, which checks for potential memory
11// leaks, double free, and use-after-free problems.
12//
13//===----------------------------------------------------------------------===//
14
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +000015#include "ClangSACheckers.h"
Anna Zaksf0dfc9c2012-02-17 22:35:31 +000016#include "InterCheckerAPI.h"
Chandler Carruth55fc8732012-12-04 09:13:33 +000017#include "clang/AST/Attr.h"
18#include "clang/Basic/SourceManager.h"
19#include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
Argyrios Kyrtzidisec8605f2011-03-01 01:16:21 +000020#include "clang/StaticAnalyzer/Core/Checker.h"
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +000021#include "clang/StaticAnalyzer/Core/CheckerManager.h"
Jordan Rosef540c542012-07-26 21:39:41 +000022#include "clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h"
Chandler Carruth55fc8732012-12-04 09:13:33 +000023#include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
Ted Kremenek18c66fd2011-08-15 22:09:50 +000024#include "clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h"
25#include "clang/StaticAnalyzer/Core/PathSensitive/ProgramStateTrait.h"
Ted Kremenek9b663712011-02-10 01:03:03 +000026#include "clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h"
Zhongxing Xu589c0f22009-11-12 08:38:56 +000027#include "llvm/ADT/ImmutableMap.h"
Benjamin Kramer00bd44d2012-02-04 12:31:12 +000028#include "llvm/ADT/STLExtras.h"
Benjamin Kramer2fa67ef2012-12-01 15:09:41 +000029#include "llvm/ADT/SmallString.h"
Jordan Rose615a0922012-09-22 01:24:42 +000030#include "llvm/ADT/StringExtras.h"
Anna Zaks60a1fa42012-02-22 03:14:20 +000031#include <climits>
32
Zhongxing Xu589c0f22009-11-12 08:38:56 +000033using namespace clang;
Ted Kremenek9ef65372010-12-23 07:20:52 +000034using namespace ento;
Zhongxing Xu589c0f22009-11-12 08:38:56 +000035
36namespace {
37
Anton Yartsev849c7bf2013-03-28 17:05:19 +000038// Used to check correspondence between allocators and deallocators.
39enum AllocationFamily {
40 AF_None,
41 AF_Malloc,
42 AF_CXXNew,
43 AF_CXXNewArray
44};
45
Zhongxing Xu7fb14642009-12-11 00:55:44 +000046class RefState {
Anna Zaks050cdd72012-06-20 20:57:46 +000047 enum Kind { // Reference to allocated memory.
48 Allocated,
49 // Reference to released/freed memory.
50 Released,
Anna Zaks050cdd72012-06-20 20:57:46 +000051 // The responsibility for freeing resources has transfered from
52 // this reference. A relinquished symbol should not be freed.
Anna Zaks04130232013-04-09 00:30:28 +000053 Relinquished,
54 // We are no longer guaranteed to have observed all manipulations
55 // of this pointer/memory. For example, it could have been
56 // passed as a parameter to an opaque function.
57 Escaped
58 };
Anton Yartsev849c7bf2013-03-28 17:05:19 +000059
Zhongxing Xu243fde92009-11-17 07:54:15 +000060 const Stmt *S;
Anton Yartsev849c7bf2013-03-28 17:05:19 +000061 unsigned K : 2; // Kind enum, but stored as a bitfield.
62 unsigned Family : 30; // Rest of 32-bit word, currently just an allocation
63 // family.
Zhongxing Xu243fde92009-11-17 07:54:15 +000064
Anton Yartsev849c7bf2013-03-28 17:05:19 +000065 RefState(Kind k, const Stmt *s, unsigned family)
Anna Zaks04130232013-04-09 00:30:28 +000066 : S(s), K(k), Family(family) {
67 assert(family != AF_None);
68 }
Zhongxing Xu7fb14642009-12-11 00:55:44 +000069public:
Anna Zaks050cdd72012-06-20 20:57:46 +000070 bool isAllocated() const { return K == Allocated; }
Zhongxing Xu243fde92009-11-17 07:54:15 +000071 bool isReleased() const { return K == Released; }
Anna Zaks050cdd72012-06-20 20:57:46 +000072 bool isRelinquished() const { return K == Relinquished; }
Anna Zaks04130232013-04-09 00:30:28 +000073 bool isEscaped() const { return K == Escaped; }
74 AllocationFamily getAllocationFamily() const {
Anton Yartsev849c7bf2013-03-28 17:05:19 +000075 return (AllocationFamily)Family;
76 }
Anna Zaksc8bb3be2012-02-13 18:05:39 +000077 const Stmt *getStmt() const { return S; }
Zhongxing Xu243fde92009-11-17 07:54:15 +000078
79 bool operator==(const RefState &X) const {
Anton Yartsev849c7bf2013-03-28 17:05:19 +000080 return K == X.K && S == X.S && Family == X.Family;
Zhongxing Xu243fde92009-11-17 07:54:15 +000081 }
82
Anton Yartsev849c7bf2013-03-28 17:05:19 +000083 static RefState getAllocated(unsigned family, const Stmt *s) {
84 return RefState(Allocated, s, family);
Zhongxing Xub94b81a2009-12-31 06:13:07 +000085 }
Anton Yartsev849c7bf2013-03-28 17:05:19 +000086 static RefState getReleased(unsigned family, const Stmt *s) {
87 return RefState(Released, s, family);
88 }
89 static RefState getRelinquished(unsigned family, const Stmt *s) {
90 return RefState(Relinquished, s, family);
Ted Kremenekdde201b2010-08-06 21:12:55 +000091 }
Anna Zaks04130232013-04-09 00:30:28 +000092 static RefState getEscaped(const RefState *RS) {
93 return RefState(Escaped, RS->getStmt(), RS->getAllocationFamily());
94 }
Zhongxing Xu243fde92009-11-17 07:54:15 +000095
96 void Profile(llvm::FoldingSetNodeID &ID) const {
97 ID.AddInteger(K);
98 ID.AddPointer(S);
Anton Yartsev849c7bf2013-03-28 17:05:19 +000099 ID.AddInteger(Family);
Zhongxing Xu243fde92009-11-17 07:54:15 +0000100 }
Ted Kremenekc37fad62013-01-03 01:30:12 +0000101
Dmitri Gribenkocfa88f82013-01-12 19:30:44 +0000102 void dump(raw_ostream &OS) const {
Ted Kremenekc37fad62013-01-03 01:30:12 +0000103 static const char *Table[] = {
104 "Allocated",
105 "Released",
106 "Relinquished"
107 };
108 OS << Table[(unsigned) K];
109 }
110
111 LLVM_ATTRIBUTE_USED void dump() const {
112 dump(llvm::errs());
113 }
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000114};
115
Anna Zaks9dc298b2012-09-12 22:57:34 +0000116enum ReallocPairKind {
117 RPToBeFreedAfterFailure,
118 // The symbol has been freed when reallocation failed.
119 RPIsFreeOnFailure,
120 // The symbol does not need to be freed after reallocation fails.
121 RPDoNotTrackAfterFailure
122};
123
Anna Zaks55dd9562012-08-24 02:28:20 +0000124/// \class ReallocPair
125/// \brief Stores information about the symbol being reallocated by a call to
126/// 'realloc' to allow modeling failed reallocation later in the path.
Anna Zaks40add292012-02-15 00:11:25 +0000127struct ReallocPair {
Anna Zaks55dd9562012-08-24 02:28:20 +0000128 // \brief The symbol which realloc reallocated.
Anna Zaks40add292012-02-15 00:11:25 +0000129 SymbolRef ReallocatedSym;
Anna Zaks9dc298b2012-09-12 22:57:34 +0000130 ReallocPairKind Kind;
Anna Zaks55dd9562012-08-24 02:28:20 +0000131
Anna Zaks9dc298b2012-09-12 22:57:34 +0000132 ReallocPair(SymbolRef S, ReallocPairKind K) :
133 ReallocatedSym(S), Kind(K) {}
Anna Zaks40add292012-02-15 00:11:25 +0000134 void Profile(llvm::FoldingSetNodeID &ID) const {
Anna Zaks9dc298b2012-09-12 22:57:34 +0000135 ID.AddInteger(Kind);
Anna Zaks40add292012-02-15 00:11:25 +0000136 ID.AddPointer(ReallocatedSym);
137 }
138 bool operator==(const ReallocPair &X) const {
139 return ReallocatedSym == X.ReallocatedSym &&
Anna Zaks9dc298b2012-09-12 22:57:34 +0000140 Kind == X.Kind;
Anna Zaks40add292012-02-15 00:11:25 +0000141 }
142};
143
Anna Zaks97bfb552013-01-08 00:25:29 +0000144typedef std::pair<const ExplodedNode*, const MemRegion*> LeakInfo;
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000145
Anna Zaksb319e022012-02-08 20:13:28 +0000146class MallocChecker : public Checker<check::DeadSymbols,
Anna Zaksbf53dfa2012-12-20 00:38:25 +0000147 check::PointerEscape,
Anna Zaks41988f32013-03-28 23:15:29 +0000148 check::ConstPointerEscape,
Ted Kremeneke3659a72012-01-04 23:48:37 +0000149 check::PreStmt<ReturnStmt>,
Anton Yartsev55e57a52013-04-10 22:21:41 +0000150 check::PreCall,
Anna Zaksb319e022012-02-08 20:13:28 +0000151 check::PostStmt<CallExpr>,
Anton Yartsev2de19ed2013-03-25 01:35:45 +0000152 check::PostStmt<CXXNewExpr>,
153 check::PreStmt<CXXDeleteExpr>,
Anna Zaksf5aa3f52012-03-22 00:57:20 +0000154 check::PostStmt<BlockExpr>,
Anna Zaks4141e4d2012-11-13 03:18:01 +0000155 check::PostObjCMessage,
Ted Kremeneke3659a72012-01-04 23:48:37 +0000156 check::Location,
Anna Zaksbf53dfa2012-12-20 00:38:25 +0000157 eval::Assume>
Ted Kremeneke3659a72012-01-04 23:48:37 +0000158{
Anna Zaksfebdc322012-02-16 22:26:12 +0000159 mutable OwningPtr<BugType> BT_DoubleFree;
160 mutable OwningPtr<BugType> BT_Leak;
161 mutable OwningPtr<BugType> BT_UseFree;
162 mutable OwningPtr<BugType> BT_BadFree;
Anton Yartsev648cb712013-04-04 23:46:29 +0000163 mutable OwningPtr<BugType> BT_MismatchedDealloc;
Anna Zaks118aa752013-02-07 23:05:47 +0000164 mutable OwningPtr<BugType> BT_OffsetFree;
Anna Zaksb16ce452012-02-15 00:11:22 +0000165 mutable IdentifierInfo *II_malloc, *II_free, *II_realloc, *II_calloc,
Anna Zaks60a1fa42012-02-22 03:14:20 +0000166 *II_valloc, *II_reallocf, *II_strndup, *II_strdup;
167
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000168public:
Anna Zaksb16ce452012-02-15 00:11:22 +0000169 MallocChecker() : II_malloc(0), II_free(0), II_realloc(0), II_calloc(0),
Anna Zaks60a1fa42012-02-22 03:14:20 +0000170 II_valloc(0), II_reallocf(0), II_strndup(0), II_strdup(0) {}
Anna Zaks231361a2012-02-08 23:16:52 +0000171
172 /// In pessimistic mode, the checker assumes that it does not know which
173 /// functions might free the memory.
174 struct ChecksFilter {
175 DefaultBool CMallocPessimistic;
176 DefaultBool CMallocOptimistic;
Anton Yartsev2de19ed2013-03-25 01:35:45 +0000177 DefaultBool CNewDeleteChecker;
Jordan Rosee85deb32013-04-05 17:55:00 +0000178 DefaultBool CNewDeleteLeaksChecker;
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000179 DefaultBool CMismatchedDeallocatorChecker;
Anna Zaks231361a2012-02-08 23:16:52 +0000180 };
181
182 ChecksFilter Filter;
183
Anton Yartsev55e57a52013-04-10 22:21:41 +0000184 void checkPreCall(const CallEvent &Call, CheckerContext &C) const;
Anna Zaksb319e022012-02-08 20:13:28 +0000185 void checkPostStmt(const CallExpr *CE, CheckerContext &C) const;
Anton Yartsev2de19ed2013-03-25 01:35:45 +0000186 void checkPostStmt(const CXXNewExpr *NE, CheckerContext &C) const;
187 void checkPreStmt(const CXXDeleteExpr *DE, CheckerContext &C) const;
Anna Zaks4141e4d2012-11-13 03:18:01 +0000188 void checkPostObjCMessage(const ObjCMethodCall &Call, CheckerContext &C) const;
Anna Zaksf5aa3f52012-03-22 00:57:20 +0000189 void checkPostStmt(const BlockExpr *BE, CheckerContext &C) const;
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000190 void checkDeadSymbols(SymbolReaper &SymReaper, CheckerContext &C) const;
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000191 void checkPreStmt(const ReturnStmt *S, CheckerContext &C) const;
Ted Kremenek8bef8232012-01-26 21:29:00 +0000192 ProgramStateRef evalAssume(ProgramStateRef state, SVal Cond,
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000193 bool Assumption) const;
Anna Zaks390909c2011-10-06 00:43:15 +0000194 void checkLocation(SVal l, bool isLoad, const Stmt *S,
195 CheckerContext &C) const;
Anna Zaksbf53dfa2012-12-20 00:38:25 +0000196
197 ProgramStateRef checkPointerEscape(ProgramStateRef State,
198 const InvalidatedSymbols &Escaped,
Anna Zaks233e26a2013-02-07 23:05:43 +0000199 const CallEvent *Call,
200 PointerEscapeKind Kind) const;
Anna Zaks41988f32013-03-28 23:15:29 +0000201 ProgramStateRef checkConstPointerEscape(ProgramStateRef State,
202 const InvalidatedSymbols &Escaped,
203 const CallEvent *Call,
204 PointerEscapeKind Kind) const;
Zhongxing Xub94b81a2009-12-31 06:13:07 +0000205
Anna Zaks93c5a242012-05-02 00:05:20 +0000206 void printState(raw_ostream &Out, ProgramStateRef State,
207 const char *NL, const char *Sep) const;
208
Zhongxing Xu7b760962009-11-13 07:25:27 +0000209private:
Anna Zaks66c40402012-02-14 21:55:24 +0000210 void initIdentifierInfo(ASTContext &C) const;
211
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000212 /// \brief Determine family of a deallocation expression.
Anton Yartsev648cb712013-04-04 23:46:29 +0000213 AllocationFamily getAllocationFamily(CheckerContext &C, const Stmt *S) const;
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000214
215 /// \brief Print names of allocators and deallocators.
216 ///
217 /// \returns true on success.
218 bool printAllocDeallocName(raw_ostream &os, CheckerContext &C,
219 const Expr *E) const;
220
221 /// \brief Print expected name of an allocator based on the deallocator's
222 /// family derived from the DeallocExpr.
223 void printExpectedAllocName(raw_ostream &os, CheckerContext &C,
224 const Expr *DeallocExpr) const;
225 /// \brief Print expected name of a deallocator based on the allocator's
226 /// family.
227 void printExpectedDeallocName(raw_ostream &os, AllocationFamily Family) const;
228
Jordan Rose9fe09f32013-03-09 00:59:10 +0000229 ///@{
Anna Zaks66c40402012-02-14 21:55:24 +0000230 /// Check if this is one of the functions which can allocate/reallocate memory
231 /// pointed to by one of its arguments.
232 bool isMemFunction(const FunctionDecl *FD, ASTContext &C) const;
Anna Zaks14345182012-05-18 01:16:10 +0000233 bool isFreeFunction(const FunctionDecl *FD, ASTContext &C) const;
234 bool isAllocationFunction(const FunctionDecl *FD, ASTContext &C) const;
Anton Yartsev2de19ed2013-03-25 01:35:45 +0000235 bool isStandardNewDelete(const FunctionDecl *FD, ASTContext &C) const;
Jordan Rose9fe09f32013-03-09 00:59:10 +0000236 ///@}
Anna Zaks87cb5be2012-02-22 19:24:52 +0000237 static ProgramStateRef MallocMemReturnsAttr(CheckerContext &C,
238 const CallExpr *CE,
239 const OwnershipAttr* Att);
Ted Kremenek8bef8232012-01-26 21:29:00 +0000240 static ProgramStateRef MallocMemAux(CheckerContext &C, const CallExpr *CE,
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000241 const Expr *SizeEx, SVal Init,
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000242 ProgramStateRef State,
243 AllocationFamily Family = AF_Malloc) {
Ted Kremenek5eca4822012-01-06 22:09:28 +0000244 return MallocMemAux(C, CE,
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000245 State->getSVal(SizeEx, C.getLocationContext()),
246 Init, State, Family);
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000247 }
Anna Zaks87cb5be2012-02-22 19:24:52 +0000248
Ted Kremenek8bef8232012-01-26 21:29:00 +0000249 static ProgramStateRef MallocMemAux(CheckerContext &C, const CallExpr *CE,
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000250 SVal SizeEx, SVal Init,
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000251 ProgramStateRef State,
252 AllocationFamily Family = AF_Malloc);
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000253
Anna Zaks87cb5be2012-02-22 19:24:52 +0000254 /// Update the RefState to reflect the new memory allocation.
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000255 static ProgramStateRef
256 MallocUpdateRefState(CheckerContext &C, const Expr *E, ProgramStateRef State,
257 AllocationFamily Family = AF_Malloc);
Anna Zaks87cb5be2012-02-22 19:24:52 +0000258
259 ProgramStateRef FreeMemAttr(CheckerContext &C, const CallExpr *CE,
260 const OwnershipAttr* Att) const;
Ted Kremenek8bef8232012-01-26 21:29:00 +0000261 ProgramStateRef FreeMemAux(CheckerContext &C, const CallExpr *CE,
Anna Zaks5b7aa342012-06-22 02:04:31 +0000262 ProgramStateRef state, unsigned Num,
Anna Zaks55dd9562012-08-24 02:28:20 +0000263 bool Hold,
Anna Zaks4141e4d2012-11-13 03:18:01 +0000264 bool &ReleasedAllocated,
265 bool ReturnsNullOnFailure = false) const;
Anna Zaks5b7aa342012-06-22 02:04:31 +0000266 ProgramStateRef FreeMemAux(CheckerContext &C, const Expr *Arg,
267 const Expr *ParentExpr,
Anna Zaks4141e4d2012-11-13 03:18:01 +0000268 ProgramStateRef State,
Anna Zaks55dd9562012-08-24 02:28:20 +0000269 bool Hold,
Anna Zaks4141e4d2012-11-13 03:18:01 +0000270 bool &ReleasedAllocated,
271 bool ReturnsNullOnFailure = false) const;
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000272
Anna Zaks87cb5be2012-02-22 19:24:52 +0000273 ProgramStateRef ReallocMem(CheckerContext &C, const CallExpr *CE,
274 bool FreesMemOnFailure) const;
275 static ProgramStateRef CallocMem(CheckerContext &C, const CallExpr *CE);
Jordy Rose43859f62010-06-07 19:32:37 +0000276
Anna Zaks14345182012-05-18 01:16:10 +0000277 ///\brief Check if the memory associated with this symbol was released.
278 bool isReleased(SymbolRef Sym, CheckerContext &C) const;
279
Anton Yartsev2de19ed2013-03-25 01:35:45 +0000280 bool checkUseAfterFree(SymbolRef Sym, CheckerContext &C, const Stmt *S) const;
Anna Zaks91c2a112012-02-08 23:16:56 +0000281
Jordan Rose9fe09f32013-03-09 00:59:10 +0000282 /// Check if the function is known not to free memory, or if it is
283 /// "interesting" and should be modeled explicitly.
284 ///
285 /// We assume that pointers do not escape through calls to system functions
286 /// not handled by this checker.
287 bool doesNotFreeMemOrInteresting(const CallEvent *Call,
288 ProgramStateRef State) const;
Anna Zaks66c40402012-02-14 21:55:24 +0000289
Anna Zaks41988f32013-03-28 23:15:29 +0000290 // Implementation of the checkPointerEscape callabcks.
291 ProgramStateRef checkPointerEscapeAux(ProgramStateRef State,
292 const InvalidatedSymbols &Escaped,
293 const CallEvent *Call,
294 PointerEscapeKind Kind,
295 bool(*CheckRefState)(const RefState*)) const;
296
Anton Yartsev648cb712013-04-04 23:46:29 +0000297 // Used to suppress warnings if they are not related to the tracked family
Anton Yartseva3989b82013-04-05 19:08:04 +0000298 // (derived from Sym or AllocDeallocStmt).
Anton Yartsev648cb712013-04-04 23:46:29 +0000299 bool isTrackedFamily(AllocationFamily Family) const;
300 bool isTrackedFamily(CheckerContext &C, const Stmt *AllocDeallocStmt) const;
301 bool isTrackedFamily(CheckerContext &C, SymbolRef Sym) const;
302
Ted Kremenek9c378f72011-08-12 23:37:29 +0000303 static bool SummarizeValue(raw_ostream &os, SVal V);
304 static bool SummarizeRegion(raw_ostream &os, const MemRegion *MR);
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000305 void ReportBadFree(CheckerContext &C, SVal ArgVal, SourceRange Range,
306 const Expr *DeallocExpr) const;
Anton Yartsev648cb712013-04-04 23:46:29 +0000307 void ReportMismatchedDealloc(CheckerContext &C, SourceRange Range,
Anton Yartseva3ae9372013-04-05 11:25:10 +0000308 const Expr *DeallocExpr, const RefState *RS,
309 SymbolRef Sym) const;
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000310 void ReportOffsetFree(CheckerContext &C, SVal ArgVal, SourceRange Range,
311 const Expr *DeallocExpr,
312 const Expr *AllocExpr = 0) const;
Anton Yartsevbb369952013-03-13 14:39:10 +0000313 void ReportUseAfterFree(CheckerContext &C, SourceRange Range,
314 SymbolRef Sym) const;
315 void ReportDoubleFree(CheckerContext &C, SourceRange Range, bool Released,
Anton Yartsev3258d4b2013-03-13 17:07:32 +0000316 SymbolRef Sym, SymbolRef PrevSym) const;
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000317
Anna Zaksca8e36e2012-02-23 21:38:21 +0000318 /// Find the location of the allocation for Sym on the path leading to the
319 /// exploded node N.
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000320 LeakInfo getAllocationSite(const ExplodedNode *N, SymbolRef Sym,
321 CheckerContext &C) const;
Anna Zaksca8e36e2012-02-23 21:38:21 +0000322
Anna Zaksda046772012-02-11 21:02:40 +0000323 void reportLeak(SymbolRef Sym, ExplodedNode *N, CheckerContext &C) const;
324
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000325 /// The bug visitor which allows us to print extra diagnostics along the
326 /// BugReport path. For example, showing the allocation site of the leaked
327 /// region.
Jordy Rose01153492012-03-24 02:45:35 +0000328 class MallocBugVisitor : public BugReporterVisitorImpl<MallocBugVisitor> {
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000329 protected:
Anna Zaksfe571602012-02-16 22:26:07 +0000330 enum NotificationMode {
331 Normal,
Anna Zaksfe571602012-02-16 22:26:07 +0000332 ReallocationFailed
333 };
334
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000335 // The allocated region symbol tracked by the main analysis.
336 SymbolRef Sym;
337
Anna Zaks88feba02012-05-10 01:37:40 +0000338 // The mode we are in, i.e. what kind of diagnostics will be emitted.
339 NotificationMode Mode;
Jordy Roseb000fb52012-03-24 03:15:09 +0000340
Anna Zaks88feba02012-05-10 01:37:40 +0000341 // A symbol from when the primary region should have been reallocated.
342 SymbolRef FailedReallocSymbol;
Jordy Roseb000fb52012-03-24 03:15:09 +0000343
Anna Zaks88feba02012-05-10 01:37:40 +0000344 bool IsLeak;
345
346 public:
347 MallocBugVisitor(SymbolRef S, bool isLeak = false)
348 : Sym(S), Mode(Normal), FailedReallocSymbol(0), IsLeak(isLeak) {}
Jordy Roseb000fb52012-03-24 03:15:09 +0000349
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000350 virtual ~MallocBugVisitor() {}
351
352 void Profile(llvm::FoldingSetNodeID &ID) const {
353 static int X = 0;
354 ID.AddPointer(&X);
355 ID.AddPointer(Sym);
356 }
357
Anna Zaksfe571602012-02-16 22:26:07 +0000358 inline bool isAllocated(const RefState *S, const RefState *SPrev,
359 const Stmt *Stmt) {
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000360 // Did not track -> allocated. Other state (released) -> allocated.
Anton Yartsev2de19ed2013-03-25 01:35:45 +0000361 return (Stmt && (isa<CallExpr>(Stmt) || isa<CXXNewExpr>(Stmt)) &&
Anna Zaksfe571602012-02-16 22:26:07 +0000362 (S && S->isAllocated()) && (!SPrev || !SPrev->isAllocated()));
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000363 }
364
Anna Zaksfe571602012-02-16 22:26:07 +0000365 inline bool isReleased(const RefState *S, const RefState *SPrev,
366 const Stmt *Stmt) {
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000367 // Did not track -> released. Other state (allocated) -> released.
Anton Yartsev2de19ed2013-03-25 01:35:45 +0000368 return (Stmt && (isa<CallExpr>(Stmt) || isa<CXXDeleteExpr>(Stmt)) &&
Anna Zaksfe571602012-02-16 22:26:07 +0000369 (S && S->isReleased()) && (!SPrev || !SPrev->isReleased()));
370 }
371
Anna Zaks5b7aa342012-06-22 02:04:31 +0000372 inline bool isRelinquished(const RefState *S, const RefState *SPrev,
373 const Stmt *Stmt) {
374 // Did not track -> relinquished. Other state (allocated) -> relinquished.
375 return (Stmt && (isa<CallExpr>(Stmt) || isa<ObjCMessageExpr>(Stmt) ||
376 isa<ObjCPropertyRefExpr>(Stmt)) &&
377 (S && S->isRelinquished()) &&
378 (!SPrev || !SPrev->isRelinquished()));
379 }
380
Anna Zaksfe571602012-02-16 22:26:07 +0000381 inline bool isReallocFailedCheck(const RefState *S, const RefState *SPrev,
382 const Stmt *Stmt) {
383 // If the expression is not a call, and the state change is
384 // released -> allocated, it must be the realloc return value
385 // check. If we have to handle more cases here, it might be cleaner just
386 // to track this extra bit in the state itself.
387 return ((!Stmt || !isa<CallExpr>(Stmt)) &&
388 (S && S->isAllocated()) && (SPrev && !SPrev->isAllocated()));
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000389 }
390
391 PathDiagnosticPiece *VisitNode(const ExplodedNode *N,
392 const ExplodedNode *PrevN,
393 BugReporterContext &BRC,
394 BugReport &BR);
Anna Zaks88feba02012-05-10 01:37:40 +0000395
396 PathDiagnosticPiece* getEndPath(BugReporterContext &BRC,
397 const ExplodedNode *EndPathNode,
398 BugReport &BR) {
399 if (!IsLeak)
400 return 0;
401
402 PathDiagnosticLocation L =
403 PathDiagnosticLocation::createEndOfPath(EndPathNode,
404 BRC.getSourceManager());
405 // Do not add the statement itself as a range in case of leak.
406 return new PathDiagnosticEventPiece(L, BR.getDescription(), false);
407 }
408
Anna Zaks56a938f2012-03-16 23:24:20 +0000409 private:
410 class StackHintGeneratorForReallocationFailed
411 : public StackHintGeneratorForSymbol {
412 public:
413 StackHintGeneratorForReallocationFailed(SymbolRef S, StringRef M)
414 : StackHintGeneratorForSymbol(S, M) {}
415
416 virtual std::string getMessageForArg(const Expr *ArgE, unsigned ArgIndex) {
Jordan Rose615a0922012-09-22 01:24:42 +0000417 // Printed parameters start at 1, not 0.
418 ++ArgIndex;
419
Anna Zaks56a938f2012-03-16 23:24:20 +0000420 SmallString<200> buf;
421 llvm::raw_svector_ostream os(buf);
422
Jordan Rose615a0922012-09-22 01:24:42 +0000423 os << "Reallocation of " << ArgIndex << llvm::getOrdinalSuffix(ArgIndex)
424 << " parameter failed";
Anna Zaks56a938f2012-03-16 23:24:20 +0000425
426 return os.str();
427 }
428
429 virtual std::string getMessageForReturn(const CallExpr *CallExpr) {
Anna Zaksfbd58742012-03-16 23:44:28 +0000430 return "Reallocation of returned value failed";
Anna Zaks56a938f2012-03-16 23:24:20 +0000431 }
432 };
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000433 };
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000434};
Kovarththanan Rajaratnamba5fb5a2009-11-28 06:07:30 +0000435} // end anonymous namespace
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000436
Jordan Rose166d5022012-11-02 01:54:06 +0000437REGISTER_MAP_WITH_PROGRAMSTATE(RegionState, SymbolRef, RefState)
438REGISTER_MAP_WITH_PROGRAMSTATE(ReallocPairs, SymbolRef, ReallocPair)
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000439
Anna Zaks4141e4d2012-11-13 03:18:01 +0000440// A map from the freed symbol to the symbol representing the return value of
441// the free function.
442REGISTER_MAP_WITH_PROGRAMSTATE(FreeReturnValue, SymbolRef, SymbolRef)
443
Anna Zaks4fb54872012-02-11 21:02:35 +0000444namespace {
445class StopTrackingCallback : public SymbolVisitor {
446 ProgramStateRef state;
447public:
448 StopTrackingCallback(ProgramStateRef st) : state(st) {}
449 ProgramStateRef getState() const { return state; }
450
451 bool VisitSymbol(SymbolRef sym) {
452 state = state->remove<RegionState>(sym);
453 return true;
454 }
455};
456} // end anonymous namespace
457
Anna Zaks66c40402012-02-14 21:55:24 +0000458void MallocChecker::initIdentifierInfo(ASTContext &Ctx) const {
Anna Zaksa38cb2c2012-05-18 22:47:40 +0000459 if (II_malloc)
460 return;
461 II_malloc = &Ctx.Idents.get("malloc");
462 II_free = &Ctx.Idents.get("free");
463 II_realloc = &Ctx.Idents.get("realloc");
464 II_reallocf = &Ctx.Idents.get("reallocf");
465 II_calloc = &Ctx.Idents.get("calloc");
466 II_valloc = &Ctx.Idents.get("valloc");
467 II_strdup = &Ctx.Idents.get("strdup");
468 II_strndup = &Ctx.Idents.get("strndup");
Anna Zaksb319e022012-02-08 20:13:28 +0000469}
470
Anna Zaks66c40402012-02-14 21:55:24 +0000471bool MallocChecker::isMemFunction(const FunctionDecl *FD, ASTContext &C) const {
Anna Zaks14345182012-05-18 01:16:10 +0000472 if (isFreeFunction(FD, C))
473 return true;
474
475 if (isAllocationFunction(FD, C))
476 return true;
477
Anton Yartsev2de19ed2013-03-25 01:35:45 +0000478 if (isStandardNewDelete(FD, C))
479 return true;
480
Anna Zaks14345182012-05-18 01:16:10 +0000481 return false;
482}
483
484bool MallocChecker::isAllocationFunction(const FunctionDecl *FD,
485 ASTContext &C) const {
Anna Zaks1d6cc6a2012-02-15 02:12:00 +0000486 if (!FD)
487 return false;
Anna Zaks14345182012-05-18 01:16:10 +0000488
Jordan Rose5ef6e942012-07-10 23:13:01 +0000489 if (FD->getKind() == Decl::Function) {
490 IdentifierInfo *FunI = FD->getIdentifier();
491 initIdentifierInfo(C);
Anna Zaks66c40402012-02-14 21:55:24 +0000492
Jordan Rose5ef6e942012-07-10 23:13:01 +0000493 if (FunI == II_malloc || FunI == II_realloc ||
494 FunI == II_reallocf || FunI == II_calloc || FunI == II_valloc ||
495 FunI == II_strdup || FunI == II_strndup)
496 return true;
497 }
Anna Zaks66c40402012-02-14 21:55:24 +0000498
Anna Zaks14345182012-05-18 01:16:10 +0000499 if (Filter.CMallocOptimistic && FD->hasAttrs())
500 for (specific_attr_iterator<OwnershipAttr>
501 i = FD->specific_attr_begin<OwnershipAttr>(),
502 e = FD->specific_attr_end<OwnershipAttr>();
503 i != e; ++i)
504 if ((*i)->getOwnKind() == OwnershipAttr::Returns)
505 return true;
506 return false;
507}
508
509bool MallocChecker::isFreeFunction(const FunctionDecl *FD, ASTContext &C) const {
510 if (!FD)
511 return false;
512
Jordan Rose5ef6e942012-07-10 23:13:01 +0000513 if (FD->getKind() == Decl::Function) {
514 IdentifierInfo *FunI = FD->getIdentifier();
515 initIdentifierInfo(C);
Anna Zaks14345182012-05-18 01:16:10 +0000516
Jordan Rose5ef6e942012-07-10 23:13:01 +0000517 if (FunI == II_free || FunI == II_realloc || FunI == II_reallocf)
518 return true;
519 }
Anna Zaks66c40402012-02-14 21:55:24 +0000520
Anna Zaks14345182012-05-18 01:16:10 +0000521 if (Filter.CMallocOptimistic && FD->hasAttrs())
522 for (specific_attr_iterator<OwnershipAttr>
523 i = FD->specific_attr_begin<OwnershipAttr>(),
524 e = FD->specific_attr_end<OwnershipAttr>();
525 i != e; ++i)
526 if ((*i)->getOwnKind() == OwnershipAttr::Takes ||
527 (*i)->getOwnKind() == OwnershipAttr::Holds)
528 return true;
Anna Zaks66c40402012-02-14 21:55:24 +0000529 return false;
530}
531
Anton Yartsev69746282013-03-28 16:10:38 +0000532// Tells if the callee is one of the following:
533// 1) A global non-placement new/delete operator function.
534// 2) A global placement operator function with the single placement argument
535// of type std::nothrow_t.
Anton Yartsev2de19ed2013-03-25 01:35:45 +0000536bool MallocChecker::isStandardNewDelete(const FunctionDecl *FD,
537 ASTContext &C) const {
538 if (!FD)
539 return false;
540
541 OverloadedOperatorKind Kind = FD->getOverloadedOperator();
542 if (Kind != OO_New && Kind != OO_Array_New &&
543 Kind != OO_Delete && Kind != OO_Array_Delete)
544 return false;
545
Anton Yartsev69746282013-03-28 16:10:38 +0000546 // Skip all operator new/delete methods.
547 if (isa<CXXMethodDecl>(FD))
Anton Yartsev2de19ed2013-03-25 01:35:45 +0000548 return false;
549
550 // Return true if tested operator is a standard placement nothrow operator.
551 if (FD->getNumParams() == 2) {
552 QualType T = FD->getParamDecl(1)->getType();
553 if (const IdentifierInfo *II = T.getBaseTypeIdentifier())
554 return II->getName().equals("nothrow_t");
555 }
556
557 // Skip placement operators.
558 if (FD->getNumParams() != 1 || FD->isVariadic())
559 return false;
560
561 // One of the standard new/new[]/delete/delete[] non-placement operators.
562 return true;
563}
564
Anna Zaksb319e022012-02-08 20:13:28 +0000565void MallocChecker::checkPostStmt(const CallExpr *CE, CheckerContext &C) const {
Jordan Rosec20c7272012-09-20 01:55:32 +0000566 if (C.wasInlined)
567 return;
568
Anna Zaksb319e022012-02-08 20:13:28 +0000569 const FunctionDecl *FD = C.getCalleeDecl(CE);
570 if (!FD)
571 return;
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000572
Anna Zaks87cb5be2012-02-22 19:24:52 +0000573 ProgramStateRef State = C.getState();
Anna Zaks55dd9562012-08-24 02:28:20 +0000574 bool ReleasedAllocatedMemory = false;
Jordan Rose5ef6e942012-07-10 23:13:01 +0000575
576 if (FD->getKind() == Decl::Function) {
577 initIdentifierInfo(C.getASTContext());
578 IdentifierInfo *FunI = FD->getIdentifier();
579
Anton Yartsev648cb712013-04-04 23:46:29 +0000580 if (FunI == II_malloc || FunI == II_valloc) {
581 if (CE->getNumArgs() < 1)
582 return;
583 State = MallocMemAux(C, CE, CE->getArg(0), UndefinedVal(), State);
584 } else if (FunI == II_realloc) {
585 State = ReallocMem(C, CE, false);
586 } else if (FunI == II_reallocf) {
587 State = ReallocMem(C, CE, true);
588 } else if (FunI == II_calloc) {
589 State = CallocMem(C, CE);
590 } else if (FunI == II_free) {
591 State = FreeMemAux(C, CE, State, 0, false, ReleasedAllocatedMemory);
592 } else if (FunI == II_strdup) {
593 State = MallocUpdateRefState(C, CE, State);
594 } else if (FunI == II_strndup) {
595 State = MallocUpdateRefState(C, CE, State);
Anton Yartsev2de19ed2013-03-25 01:35:45 +0000596 }
Anton Yartsev648cb712013-04-04 23:46:29 +0000597 else if (isStandardNewDelete(FD, C.getASTContext())) {
598 // Process direct calls to operator new/new[]/delete/delete[] functions
599 // as distinct from new/new[]/delete/delete[] expressions that are
600 // processed by the checkPostStmt callbacks for CXXNewExpr and
601 // CXXDeleteExpr.
602 OverloadedOperatorKind K = FD->getOverloadedOperator();
603 if (K == OO_New)
604 State = MallocMemAux(C, CE, CE->getArg(0), UndefinedVal(), State,
605 AF_CXXNew);
606 else if (K == OO_Array_New)
607 State = MallocMemAux(C, CE, CE->getArg(0), UndefinedVal(), State,
608 AF_CXXNewArray);
609 else if (K == OO_Delete || K == OO_Array_Delete)
610 State = FreeMemAux(C, CE, State, 0, false, ReleasedAllocatedMemory);
611 else
612 llvm_unreachable("not a new/delete operator");
Jordan Rose5ef6e942012-07-10 23:13:01 +0000613 }
614 }
615
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000616 if (Filter.CMallocOptimistic || Filter.CMismatchedDeallocatorChecker) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000617 // Check all the attributes, if there are any.
618 // There can be multiple of these attributes.
619 if (FD->hasAttrs())
620 for (specific_attr_iterator<OwnershipAttr>
621 i = FD->specific_attr_begin<OwnershipAttr>(),
622 e = FD->specific_attr_end<OwnershipAttr>();
623 i != e; ++i) {
624 switch ((*i)->getOwnKind()) {
625 case OwnershipAttr::Returns:
626 State = MallocMemReturnsAttr(C, CE, *i);
627 break;
628 case OwnershipAttr::Takes:
629 case OwnershipAttr::Holds:
630 State = FreeMemAttr(C, CE, *i);
631 break;
632 }
633 }
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000634 }
Anna Zaks60a1fa42012-02-22 03:14:20 +0000635 C.addTransition(State);
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000636}
637
Anton Yartsev2de19ed2013-03-25 01:35:45 +0000638void MallocChecker::checkPostStmt(const CXXNewExpr *NE,
639 CheckerContext &C) const {
640
641 if (NE->getNumPlacementArgs())
642 for (CXXNewExpr::const_arg_iterator I = NE->placement_arg_begin(),
643 E = NE->placement_arg_end(); I != E; ++I)
644 if (SymbolRef Sym = C.getSVal(*I).getAsSymbol())
645 checkUseAfterFree(Sym, C, *I);
646
Anton Yartsev2de19ed2013-03-25 01:35:45 +0000647 if (!isStandardNewDelete(NE->getOperatorNew(), C.getASTContext()))
648 return;
649
650 ProgramStateRef State = C.getState();
651 // The return value from operator new is bound to a specified initialization
652 // value (if any) and we don't want to loose this value. So we call
653 // MallocUpdateRefState() instead of MallocMemAux() which breakes the
654 // existing binding.
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000655 State = MallocUpdateRefState(C, NE, State, NE->isArray() ? AF_CXXNewArray
656 : AF_CXXNew);
Anton Yartsev2de19ed2013-03-25 01:35:45 +0000657 C.addTransition(State);
658}
659
660void MallocChecker::checkPreStmt(const CXXDeleteExpr *DE,
661 CheckerContext &C) const {
662
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000663 if (!Filter.CNewDeleteChecker)
Anton Yartsev2de19ed2013-03-25 01:35:45 +0000664 if (SymbolRef Sym = C.getSVal(DE->getArgument()).getAsSymbol())
665 checkUseAfterFree(Sym, C, DE->getArgument());
666
Anton Yartsev2de19ed2013-03-25 01:35:45 +0000667 if (!isStandardNewDelete(DE->getOperatorDelete(), C.getASTContext()))
668 return;
669
670 ProgramStateRef State = C.getState();
671 bool ReleasedAllocated;
672 State = FreeMemAux(C, DE->getArgument(), DE, State,
673 /*Hold*/false, ReleasedAllocated);
674
675 C.addTransition(State);
676}
677
Jordan Rose9fe09f32013-03-09 00:59:10 +0000678static bool isKnownDeallocObjCMethodName(const ObjCMethodCall &Call) {
679 // If the first selector piece is one of the names below, assume that the
680 // object takes ownership of the memory, promising to eventually deallocate it
681 // with free().
682 // Ex: [NSData dataWithBytesNoCopy:bytes length:10];
683 // (...unless a 'freeWhenDone' parameter is false, but that's checked later.)
684 StringRef FirstSlot = Call.getSelector().getNameForSlot(0);
685 if (FirstSlot == "dataWithBytesNoCopy" ||
686 FirstSlot == "initWithBytesNoCopy" ||
687 FirstSlot == "initWithCharactersNoCopy")
688 return true;
Anna Zaks5b7aa342012-06-22 02:04:31 +0000689
690 return false;
691}
692
Jordan Rose9fe09f32013-03-09 00:59:10 +0000693static Optional<bool> getFreeWhenDoneArg(const ObjCMethodCall &Call) {
694 Selector S = Call.getSelector();
695
696 // FIXME: We should not rely on fully-constrained symbols being folded.
697 for (unsigned i = 1; i < S.getNumArgs(); ++i)
698 if (S.getNameForSlot(i).equals("freeWhenDone"))
699 return !Call.getArgSVal(i).isZeroConstant();
700
701 return None;
702}
703
Anna Zaks4141e4d2012-11-13 03:18:01 +0000704void MallocChecker::checkPostObjCMessage(const ObjCMethodCall &Call,
705 CheckerContext &C) const {
Anna Zaksc2cca232012-12-11 00:17:53 +0000706 if (C.wasInlined)
707 return;
708
Jordan Rose9fe09f32013-03-09 00:59:10 +0000709 if (!isKnownDeallocObjCMethodName(Call))
710 return;
Anna Zaks4141e4d2012-11-13 03:18:01 +0000711
Jordan Rose9fe09f32013-03-09 00:59:10 +0000712 if (Optional<bool> FreeWhenDone = getFreeWhenDoneArg(Call))
713 if (!*FreeWhenDone)
714 return;
715
716 bool ReleasedAllocatedMemory;
717 ProgramStateRef State = FreeMemAux(C, Call.getArgExpr(0),
718 Call.getOriginExpr(), C.getState(),
719 /*Hold=*/true, ReleasedAllocatedMemory,
720 /*RetNullOnFailure=*/true);
721
722 C.addTransition(State);
Anna Zaks5b7aa342012-06-22 02:04:31 +0000723}
724
Anna Zaks87cb5be2012-02-22 19:24:52 +0000725ProgramStateRef MallocChecker::MallocMemReturnsAttr(CheckerContext &C,
726 const CallExpr *CE,
727 const OwnershipAttr* Att) {
Sean Huntcf807c42010-08-18 23:23:40 +0000728 if (Att->getModule() != "malloc")
Anna Zaks87cb5be2012-02-22 19:24:52 +0000729 return 0;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000730
Sean Huntcf807c42010-08-18 23:23:40 +0000731 OwnershipAttr::args_iterator I = Att->args_begin(), E = Att->args_end();
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000732 if (I != E) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000733 return MallocMemAux(C, CE, CE->getArg(*I), UndefinedVal(), C.getState());
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000734 }
Anna Zaks87cb5be2012-02-22 19:24:52 +0000735 return MallocMemAux(C, CE, UnknownVal(), UndefinedVal(), C.getState());
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000736}
737
Anna Zaksb319e022012-02-08 20:13:28 +0000738ProgramStateRef MallocChecker::MallocMemAux(CheckerContext &C,
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000739 const CallExpr *CE,
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000740 SVal Size, SVal Init,
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000741 ProgramStateRef State,
742 AllocationFamily Family) {
Anna Zakse17fdb22012-06-07 03:57:32 +0000743
744 // Bind the return value to the symbolic value from the heap region.
745 // TODO: We could rewrite post visit to eval call; 'malloc' does not have
746 // side effects other than what we model here.
Ted Kremenek66c486f2012-08-22 06:26:15 +0000747 unsigned Count = C.blockCount();
Anna Zakse17fdb22012-06-07 03:57:32 +0000748 SValBuilder &svalBuilder = C.getSValBuilder();
749 const LocationContext *LCtx = C.getPredecessor()->getLocationContext();
David Blaikie5251abe2013-02-20 05:52:05 +0000750 DefinedSVal RetVal = svalBuilder.getConjuredHeapSymbolVal(CE, LCtx, Count)
751 .castAs<DefinedSVal>();
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000752 State = State->BindExpr(CE, C.getLocationContext(), RetVal);
Zhongxing Xua49c6b72009-12-11 03:09:01 +0000753
Anna Zaksb16ce452012-02-15 00:11:22 +0000754 // We expect the malloc functions to return a pointer.
David Blaikie5251abe2013-02-20 05:52:05 +0000755 if (!RetVal.getAs<Loc>())
Anna Zaksb16ce452012-02-15 00:11:22 +0000756 return 0;
757
Jordy Rose32f26562010-07-04 00:00:41 +0000758 // Fill the region with the initialization value.
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000759 State = State->bindDefault(RetVal, Init);
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000760
Jordy Rose32f26562010-07-04 00:00:41 +0000761 // Set the region's extent equal to the Size parameter.
Anna Zakse9ef5622012-02-10 01:11:00 +0000762 const SymbolicRegion *R =
Anna Zakse17fdb22012-06-07 03:57:32 +0000763 dyn_cast_or_null<SymbolicRegion>(RetVal.getAsRegion());
Anna Zaks60a1fa42012-02-22 03:14:20 +0000764 if (!R)
Anna Zakse9ef5622012-02-10 01:11:00 +0000765 return 0;
David Blaikiedc84cd52013-02-20 22:23:23 +0000766 if (Optional<DefinedOrUnknownSVal> DefinedSize =
David Blaikie5251abe2013-02-20 05:52:05 +0000767 Size.getAs<DefinedOrUnknownSVal>()) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000768 SValBuilder &svalBuilder = C.getSValBuilder();
Anna Zaks60a1fa42012-02-22 03:14:20 +0000769 DefinedOrUnknownSVal Extent = R->getExtent(svalBuilder);
Anna Zaks60a1fa42012-02-22 03:14:20 +0000770 DefinedOrUnknownSVal extentMatchesSize =
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000771 svalBuilder.evalEQ(State, Extent, *DefinedSize);
Anna Zakse9ef5622012-02-10 01:11:00 +0000772
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000773 State = State->assume(extentMatchesSize, true);
774 assert(State);
Anna Zaks60a1fa42012-02-22 03:14:20 +0000775 }
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000776
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000777 return MallocUpdateRefState(C, CE, State, Family);
Anna Zaks87cb5be2012-02-22 19:24:52 +0000778}
779
780ProgramStateRef MallocChecker::MallocUpdateRefState(CheckerContext &C,
Anton Yartsev2de19ed2013-03-25 01:35:45 +0000781 const Expr *E,
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000782 ProgramStateRef State,
783 AllocationFamily Family) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000784 // Get the return value.
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000785 SVal retVal = State->getSVal(E, C.getLocationContext());
Anna Zaks87cb5be2012-02-22 19:24:52 +0000786
787 // We expect the malloc functions to return a pointer.
David Blaikie5251abe2013-02-20 05:52:05 +0000788 if (!retVal.getAs<Loc>())
Anna Zaks87cb5be2012-02-22 19:24:52 +0000789 return 0;
790
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000791 SymbolRef Sym = retVal.getAsLocSymbol();
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000792 assert(Sym);
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000793
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000794 // Set the symbol's state to Allocated.
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000795 return State->set<RegionState>(Sym, RefState::getAllocated(Family, E));
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000796}
797
Anna Zaks87cb5be2012-02-22 19:24:52 +0000798ProgramStateRef MallocChecker::FreeMemAttr(CheckerContext &C,
799 const CallExpr *CE,
800 const OwnershipAttr* Att) const {
Sean Huntcf807c42010-08-18 23:23:40 +0000801 if (Att->getModule() != "malloc")
Anna Zaks87cb5be2012-02-22 19:24:52 +0000802 return 0;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000803
Anna Zaksb3d72752012-03-01 22:06:06 +0000804 ProgramStateRef State = C.getState();
Anna Zaks55dd9562012-08-24 02:28:20 +0000805 bool ReleasedAllocated = false;
Anna Zaksb3d72752012-03-01 22:06:06 +0000806
Sean Huntcf807c42010-08-18 23:23:40 +0000807 for (OwnershipAttr::args_iterator I = Att->args_begin(), E = Att->args_end();
808 I != E; ++I) {
Anna Zaksb3d72752012-03-01 22:06:06 +0000809 ProgramStateRef StateI = FreeMemAux(C, CE, State, *I,
Anna Zaks55dd9562012-08-24 02:28:20 +0000810 Att->getOwnKind() == OwnershipAttr::Holds,
811 ReleasedAllocated);
Anna Zaksb3d72752012-03-01 22:06:06 +0000812 if (StateI)
813 State = StateI;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000814 }
Anna Zaksb3d72752012-03-01 22:06:06 +0000815 return State;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000816}
817
Ted Kremenek8bef8232012-01-26 21:29:00 +0000818ProgramStateRef MallocChecker::FreeMemAux(CheckerContext &C,
Anna Zakse9ef5622012-02-10 01:11:00 +0000819 const CallExpr *CE,
820 ProgramStateRef state,
821 unsigned Num,
Anna Zaks55dd9562012-08-24 02:28:20 +0000822 bool Hold,
Anna Zaks4141e4d2012-11-13 03:18:01 +0000823 bool &ReleasedAllocated,
824 bool ReturnsNullOnFailure) const {
Anna Zaks259052d2012-04-10 23:41:11 +0000825 if (CE->getNumArgs() < (Num + 1))
826 return 0;
827
Anna Zaks4141e4d2012-11-13 03:18:01 +0000828 return FreeMemAux(C, CE->getArg(Num), CE, state, Hold,
829 ReleasedAllocated, ReturnsNullOnFailure);
830}
831
Anna Zaks2ccecfa2012-11-13 19:47:40 +0000832/// Checks if the previous call to free on the given symbol failed - if free
833/// failed, returns true. Also, returns the corresponding return value symbol.
Benjamin Kramer4d9f4e52012-11-22 15:02:44 +0000834static bool didPreviousFreeFail(ProgramStateRef State,
835 SymbolRef Sym, SymbolRef &RetStatusSymbol) {
Anna Zaks2ccecfa2012-11-13 19:47:40 +0000836 const SymbolRef *Ret = State->get<FreeReturnValue>(Sym);
Anna Zaks4141e4d2012-11-13 03:18:01 +0000837 if (Ret) {
838 assert(*Ret && "We should not store the null return symbol");
839 ConstraintManager &CMgr = State->getConstraintManager();
840 ConditionTruthVal FreeFailed = CMgr.isNull(State, *Ret);
Anna Zaks2ccecfa2012-11-13 19:47:40 +0000841 RetStatusSymbol = *Ret;
842 return FreeFailed.isConstrainedTrue();
Anna Zaks4141e4d2012-11-13 03:18:01 +0000843 }
Anna Zaks2ccecfa2012-11-13 19:47:40 +0000844 return false;
Anna Zaks5b7aa342012-06-22 02:04:31 +0000845}
846
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000847AllocationFamily MallocChecker::getAllocationFamily(CheckerContext &C,
Anton Yartsev648cb712013-04-04 23:46:29 +0000848 const Stmt *S) const {
849 if (!S)
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000850 return AF_None;
851
Anton Yartsev648cb712013-04-04 23:46:29 +0000852 if (const CallExpr *CE = dyn_cast<CallExpr>(S)) {
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000853 const FunctionDecl *FD = C.getCalleeDecl(CE);
Anton Yartsev648cb712013-04-04 23:46:29 +0000854
855 if (!FD)
856 FD = dyn_cast<FunctionDecl>(CE->getCalleeDecl());
857
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000858 ASTContext &Ctx = C.getASTContext();
859
Anton Yartsev648cb712013-04-04 23:46:29 +0000860 if (isAllocationFunction(FD, Ctx) || isFreeFunction(FD, Ctx))
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000861 return AF_Malloc;
862
863 if (isStandardNewDelete(FD, Ctx)) {
864 OverloadedOperatorKind Kind = FD->getOverloadedOperator();
Anton Yartsev648cb712013-04-04 23:46:29 +0000865 if (Kind == OO_New || Kind == OO_Delete)
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000866 return AF_CXXNew;
Anton Yartsev648cb712013-04-04 23:46:29 +0000867 else if (Kind == OO_Array_New || Kind == OO_Array_Delete)
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000868 return AF_CXXNewArray;
869 }
870
871 return AF_None;
872 }
873
Anton Yartsev648cb712013-04-04 23:46:29 +0000874 if (const CXXNewExpr *NE = dyn_cast<CXXNewExpr>(S))
875 return NE->isArray() ? AF_CXXNewArray : AF_CXXNew;
876
877 if (const CXXDeleteExpr *DE = dyn_cast<CXXDeleteExpr>(S))
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000878 return DE->isArrayForm() ? AF_CXXNewArray : AF_CXXNew;
879
Anton Yartsev648cb712013-04-04 23:46:29 +0000880 if (isa<ObjCMessageExpr>(S))
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000881 return AF_Malloc;
882
883 return AF_None;
884}
885
886bool MallocChecker::printAllocDeallocName(raw_ostream &os, CheckerContext &C,
887 const Expr *E) const {
888 if (const CallExpr *CE = dyn_cast<CallExpr>(E)) {
889 // FIXME: This doesn't handle indirect calls.
890 const FunctionDecl *FD = CE->getDirectCallee();
891 if (!FD)
892 return false;
893
894 os << *FD;
895 if (!FD->isOverloadedOperator())
896 os << "()";
897 return true;
898 }
899
900 if (const ObjCMessageExpr *Msg = dyn_cast<ObjCMessageExpr>(E)) {
901 if (Msg->isInstanceMessage())
902 os << "-";
903 else
904 os << "+";
905 os << Msg->getSelector().getAsString();
906 return true;
907 }
908
909 if (const CXXNewExpr *NE = dyn_cast<CXXNewExpr>(E)) {
910 os << "'"
911 << getOperatorSpelling(NE->getOperatorNew()->getOverloadedOperator())
912 << "'";
913 return true;
914 }
915
916 if (const CXXDeleteExpr *DE = dyn_cast<CXXDeleteExpr>(E)) {
917 os << "'"
918 << getOperatorSpelling(DE->getOperatorDelete()->getOverloadedOperator())
919 << "'";
920 return true;
921 }
922
923 return false;
924}
925
926void MallocChecker::printExpectedAllocName(raw_ostream &os, CheckerContext &C,
927 const Expr *E) const {
928 AllocationFamily Family = getAllocationFamily(C, E);
929
930 switch(Family) {
931 case AF_Malloc: os << "malloc()"; return;
932 case AF_CXXNew: os << "'new'"; return;
933 case AF_CXXNewArray: os << "'new[]'"; return;
934 case AF_None: llvm_unreachable("not a deallocation expression");
935 }
936}
937
938void MallocChecker::printExpectedDeallocName(raw_ostream &os,
939 AllocationFamily Family) const {
940 switch(Family) {
941 case AF_Malloc: os << "free()"; return;
942 case AF_CXXNew: os << "'delete'"; return;
943 case AF_CXXNewArray: os << "'delete[]'"; return;
944 case AF_None: llvm_unreachable("suspicious AF_None argument");
945 }
946}
947
Anna Zaks5b7aa342012-06-22 02:04:31 +0000948ProgramStateRef MallocChecker::FreeMemAux(CheckerContext &C,
949 const Expr *ArgExpr,
950 const Expr *ParentExpr,
Anna Zaks4141e4d2012-11-13 03:18:01 +0000951 ProgramStateRef State,
Anna Zaks55dd9562012-08-24 02:28:20 +0000952 bool Hold,
Anna Zaks4141e4d2012-11-13 03:18:01 +0000953 bool &ReleasedAllocated,
954 bool ReturnsNullOnFailure) const {
Anna Zaks5b7aa342012-06-22 02:04:31 +0000955
Anna Zaks4141e4d2012-11-13 03:18:01 +0000956 SVal ArgVal = State->getSVal(ArgExpr, C.getLocationContext());
David Blaikie5251abe2013-02-20 05:52:05 +0000957 if (!ArgVal.getAs<DefinedOrUnknownSVal>())
Anna Zakse9ef5622012-02-10 01:11:00 +0000958 return 0;
David Blaikie5251abe2013-02-20 05:52:05 +0000959 DefinedOrUnknownSVal location = ArgVal.castAs<DefinedOrUnknownSVal>();
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000960
961 // Check for null dereferences.
David Blaikie5251abe2013-02-20 05:52:05 +0000962 if (!location.getAs<Loc>())
Anna Zaksb319e022012-02-08 20:13:28 +0000963 return 0;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000964
Anna Zaksb276bd92012-02-14 00:26:13 +0000965 // The explicit NULL case, no operation is performed.
Ted Kremenek8bef8232012-01-26 21:29:00 +0000966 ProgramStateRef notNullState, nullState;
Anna Zaks4141e4d2012-11-13 03:18:01 +0000967 llvm::tie(notNullState, nullState) = State->assume(location);
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000968 if (nullState && !notNullState)
Anna Zaksb319e022012-02-08 20:13:28 +0000969 return 0;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000970
Jordy Rose43859f62010-06-07 19:32:37 +0000971 // Unknown values could easily be okay
972 // Undefined values are handled elsewhere
973 if (ArgVal.isUnknownOrUndef())
Anna Zaksb319e022012-02-08 20:13:28 +0000974 return 0;
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000975
Jordy Rose43859f62010-06-07 19:32:37 +0000976 const MemRegion *R = ArgVal.getAsRegion();
977
978 // Nonlocs can't be freed, of course.
979 // Non-region locations (labels and fixed addresses) also shouldn't be freed.
980 if (!R) {
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000981 ReportBadFree(C, ArgVal, ArgExpr->getSourceRange(), ParentExpr);
Anna Zaksb319e022012-02-08 20:13:28 +0000982 return 0;
Jordy Rose43859f62010-06-07 19:32:37 +0000983 }
984
985 R = R->StripCasts();
986
987 // Blocks might show up as heap data, but should not be free()d
988 if (isa<BlockDataRegion>(R)) {
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000989 ReportBadFree(C, ArgVal, ArgExpr->getSourceRange(), ParentExpr);
Anna Zaksb319e022012-02-08 20:13:28 +0000990 return 0;
Jordy Rose43859f62010-06-07 19:32:37 +0000991 }
992
993 const MemSpaceRegion *MS = R->getMemorySpace();
994
Anton Yartsevbb369952013-03-13 14:39:10 +0000995 // Parameters, locals, statics, globals, and memory returned by alloca()
996 // shouldn't be freed.
Jordy Rose43859f62010-06-07 19:32:37 +0000997 if (!(isa<UnknownSpaceRegion>(MS) || isa<HeapSpaceRegion>(MS))) {
998 // FIXME: at the time this code was written, malloc() regions were
999 // represented by conjured symbols, which are all in UnknownSpaceRegion.
1000 // This means that there isn't actually anything from HeapSpaceRegion
1001 // that should be freed, even though we allow it here.
1002 // Of course, free() can work on memory allocated outside the current
1003 // function, so UnknownSpaceRegion is always a possibility.
1004 // False negatives are better than false positives.
1005
Anton Yartsev849c7bf2013-03-28 17:05:19 +00001006 ReportBadFree(C, ArgVal, ArgExpr->getSourceRange(), ParentExpr);
Anna Zaksb319e022012-02-08 20:13:28 +00001007 return 0;
Jordy Rose43859f62010-06-07 19:32:37 +00001008 }
Anna Zaks118aa752013-02-07 23:05:47 +00001009
1010 const SymbolicRegion *SrBase = dyn_cast<SymbolicRegion>(R->getBaseRegion());
Jordy Rose43859f62010-06-07 19:32:37 +00001011 // Various cases could lead to non-symbol values here.
1012 // For now, ignore them.
Anna Zaks118aa752013-02-07 23:05:47 +00001013 if (!SrBase)
Anna Zaksb319e022012-02-08 20:13:28 +00001014 return 0;
Jordy Rose43859f62010-06-07 19:32:37 +00001015
Anna Zaks118aa752013-02-07 23:05:47 +00001016 SymbolRef SymBase = SrBase->getSymbol();
1017 const RefState *RsBase = State->get<RegionState>(SymBase);
Anna Zaks2ccecfa2012-11-13 19:47:40 +00001018 SymbolRef PreviousRetStatusSymbol = 0;
Zhongxing Xu7e3cda92010-01-18 03:27:34 +00001019
Anton Yartsev648cb712013-04-04 23:46:29 +00001020 if (RsBase) {
Zhongxing Xu589c0f22009-11-12 08:38:56 +00001021
Anna Zaks04130232013-04-09 00:30:28 +00001022 // Check for double free first.
1023 if ((RsBase->isReleased() || RsBase->isRelinquished()) &&
Anton Yartsev648cb712013-04-04 23:46:29 +00001024 !didPreviousFreeFail(State, SymBase, PreviousRetStatusSymbol)) {
1025 ReportDoubleFree(C, ParentExpr->getSourceRange(), RsBase->isReleased(),
1026 SymBase, PreviousRetStatusSymbol);
1027 return 0;
Anton Yartsev648cb712013-04-04 23:46:29 +00001028
Anna Zaks04130232013-04-09 00:30:28 +00001029 // If the pointer is allocated or escaped, but we are now trying to free it,
1030 // check that the call to free is proper.
1031 } else if (RsBase->isAllocated() || RsBase->isEscaped()) {
1032
1033 // Check if an expected deallocation function matches the real one.
1034 bool DeallocMatchesAlloc =
1035 RsBase->getAllocationFamily() == getAllocationFamily(C, ParentExpr);
1036 if (!DeallocMatchesAlloc) {
1037 ReportMismatchedDealloc(C, ArgExpr->getSourceRange(),
1038 ParentExpr, RsBase, SymBase);
1039 return 0;
1040 }
1041
1042 // Check if the memory location being freed is the actual location
1043 // allocated, or an offset.
1044 RegionOffset Offset = R->getAsOffset();
1045 if (Offset.isValid() &&
1046 !Offset.hasSymbolicOffset() &&
1047 Offset.getOffset() != 0) {
1048 const Expr *AllocExpr = cast<Expr>(RsBase->getStmt());
1049 ReportOffsetFree(C, ArgVal, ArgExpr->getSourceRange(), ParentExpr,
1050 AllocExpr);
1051 return 0;
1052 }
Anton Yartsev648cb712013-04-04 23:46:29 +00001053 }
Anna Zaks118aa752013-02-07 23:05:47 +00001054 }
1055
1056 ReleasedAllocated = (RsBase != 0);
Anna Zaks55dd9562012-08-24 02:28:20 +00001057
Anna Zaks2ccecfa2012-11-13 19:47:40 +00001058 // Clean out the info on previous call to free return info.
Anna Zaks118aa752013-02-07 23:05:47 +00001059 State = State->remove<FreeReturnValue>(SymBase);
Anna Zaks2ccecfa2012-11-13 19:47:40 +00001060
Anna Zaks4141e4d2012-11-13 03:18:01 +00001061 // Keep track of the return value. If it is NULL, we will know that free
1062 // failed.
1063 if (ReturnsNullOnFailure) {
1064 SVal RetVal = C.getSVal(ParentExpr);
1065 SymbolRef RetStatusSymbol = RetVal.getAsSymbol();
1066 if (RetStatusSymbol) {
Anna Zaks118aa752013-02-07 23:05:47 +00001067 C.getSymbolManager().addSymbolDependency(SymBase, RetStatusSymbol);
1068 State = State->set<FreeReturnValue>(SymBase, RetStatusSymbol);
Anna Zaks4141e4d2012-11-13 03:18:01 +00001069 }
1070 }
1071
Anton Yartseva3989b82013-04-05 19:08:04 +00001072 AllocationFamily Family = RsBase ? RsBase->getAllocationFamily()
1073 : getAllocationFamily(C, ParentExpr);
Zhongxing Xu589c0f22009-11-12 08:38:56 +00001074 // Normal free.
Anton Yartsev849c7bf2013-03-28 17:05:19 +00001075 if (Hold)
Anna Zaks118aa752013-02-07 23:05:47 +00001076 return State->set<RegionState>(SymBase,
Anton Yartsev849c7bf2013-03-28 17:05:19 +00001077 RefState::getRelinquished(Family,
1078 ParentExpr));
1079
1080 return State->set<RegionState>(SymBase,
1081 RefState::getReleased(Family, ParentExpr));
Zhongxing Xud9c84c82009-12-12 12:29:38 +00001082}
1083
Anton Yartsev648cb712013-04-04 23:46:29 +00001084bool MallocChecker::isTrackedFamily(AllocationFamily Family) const {
Anton Yartsev9c6bbb32013-04-05 00:31:02 +00001085 switch (Family) {
1086 case AF_Malloc: {
1087 if (!Filter.CMallocOptimistic && !Filter.CMallocPessimistic)
1088 return false;
Anton Yartsevc8454312013-04-05 02:12:04 +00001089 return true;
Anton Yartsev9c6bbb32013-04-05 00:31:02 +00001090 }
1091 case AF_CXXNew:
1092 case AF_CXXNewArray: {
1093 if (!Filter.CNewDeleteChecker)
1094 return false;
Anton Yartsevc8454312013-04-05 02:12:04 +00001095 return true;
Anton Yartsev9c6bbb32013-04-05 00:31:02 +00001096 }
1097 case AF_None: {
Anton Yartseva3989b82013-04-05 19:08:04 +00001098 llvm_unreachable("no family");
Anton Yartsev9c6bbb32013-04-05 00:31:02 +00001099 }
Anton Yartsev9c6bbb32013-04-05 00:31:02 +00001100 }
Anton Yartsevc8454312013-04-05 02:12:04 +00001101 llvm_unreachable("unhandled family");
Anton Yartsev648cb712013-04-04 23:46:29 +00001102}
1103
1104bool MallocChecker::isTrackedFamily(CheckerContext &C,
1105 const Stmt *AllocDeallocStmt) const {
1106 return isTrackedFamily(getAllocationFamily(C, AllocDeallocStmt));
1107}
1108
1109bool MallocChecker::isTrackedFamily(CheckerContext &C, SymbolRef Sym) const {
Anton Yartsev648cb712013-04-04 23:46:29 +00001110
Anton Yartseva3989b82013-04-05 19:08:04 +00001111 const RefState *RS = C.getState()->get<RegionState>(Sym);
1112 assert(RS);
1113 return isTrackedFamily(RS->getAllocationFamily());
Anton Yartsev648cb712013-04-04 23:46:29 +00001114}
1115
Ted Kremenek9c378f72011-08-12 23:37:29 +00001116bool MallocChecker::SummarizeValue(raw_ostream &os, SVal V) {
David Blaikiedc84cd52013-02-20 22:23:23 +00001117 if (Optional<nonloc::ConcreteInt> IntVal = V.getAs<nonloc::ConcreteInt>())
Jordy Rose43859f62010-06-07 19:32:37 +00001118 os << "an integer (" << IntVal->getValue() << ")";
David Blaikiedc84cd52013-02-20 22:23:23 +00001119 else if (Optional<loc::ConcreteInt> ConstAddr = V.getAs<loc::ConcreteInt>())
Jordy Rose43859f62010-06-07 19:32:37 +00001120 os << "a constant address (" << ConstAddr->getValue() << ")";
David Blaikiedc84cd52013-02-20 22:23:23 +00001121 else if (Optional<loc::GotoLabel> Label = V.getAs<loc::GotoLabel>())
Chris Lattner68106302011-02-17 05:38:27 +00001122 os << "the address of the label '" << Label->getLabel()->getName() << "'";
Jordy Rose43859f62010-06-07 19:32:37 +00001123 else
1124 return false;
1125
1126 return true;
1127}
1128
Ted Kremenek9c378f72011-08-12 23:37:29 +00001129bool MallocChecker::SummarizeRegion(raw_ostream &os,
Jordy Rose43859f62010-06-07 19:32:37 +00001130 const MemRegion *MR) {
1131 switch (MR->getKind()) {
1132 case MemRegion::FunctionTextRegionKind: {
Anna Zaks5fc1d0c2012-09-17 19:13:56 +00001133 const NamedDecl *FD = cast<FunctionTextRegion>(MR)->getDecl();
Jordy Rose43859f62010-06-07 19:32:37 +00001134 if (FD)
Benjamin Kramerb8989f22011-10-14 18:45:37 +00001135 os << "the address of the function '" << *FD << '\'';
Jordy Rose43859f62010-06-07 19:32:37 +00001136 else
1137 os << "the address of a function";
1138 return true;
1139 }
1140 case MemRegion::BlockTextRegionKind:
1141 os << "block text";
1142 return true;
1143 case MemRegion::BlockDataRegionKind:
1144 // FIXME: where the block came from?
1145 os << "a block";
1146 return true;
1147 default: {
1148 const MemSpaceRegion *MS = MR->getMemorySpace();
1149
Anna Zakseb31a762012-01-04 23:54:01 +00001150 if (isa<StackLocalsSpaceRegion>(MS)) {
Jordy Rose43859f62010-06-07 19:32:37 +00001151 const VarRegion *VR = dyn_cast<VarRegion>(MR);
1152 const VarDecl *VD;
1153 if (VR)
1154 VD = VR->getDecl();
1155 else
1156 VD = NULL;
1157
1158 if (VD)
1159 os << "the address of the local variable '" << VD->getName() << "'";
1160 else
1161 os << "the address of a local stack variable";
1162 return true;
1163 }
Anna Zakseb31a762012-01-04 23:54:01 +00001164
1165 if (isa<StackArgumentsSpaceRegion>(MS)) {
Jordy Rose43859f62010-06-07 19:32:37 +00001166 const VarRegion *VR = dyn_cast<VarRegion>(MR);
1167 const VarDecl *VD;
1168 if (VR)
1169 VD = VR->getDecl();
1170 else
1171 VD = NULL;
1172
1173 if (VD)
1174 os << "the address of the parameter '" << VD->getName() << "'";
1175 else
1176 os << "the address of a parameter";
1177 return true;
1178 }
Anna Zakseb31a762012-01-04 23:54:01 +00001179
1180 if (isa<GlobalsSpaceRegion>(MS)) {
Jordy Rose43859f62010-06-07 19:32:37 +00001181 const VarRegion *VR = dyn_cast<VarRegion>(MR);
1182 const VarDecl *VD;
1183 if (VR)
1184 VD = VR->getDecl();
1185 else
1186 VD = NULL;
1187
1188 if (VD) {
1189 if (VD->isStaticLocal())
1190 os << "the address of the static variable '" << VD->getName() << "'";
1191 else
1192 os << "the address of the global variable '" << VD->getName() << "'";
1193 } else
1194 os << "the address of a global variable";
1195 return true;
1196 }
Anna Zakseb31a762012-01-04 23:54:01 +00001197
1198 return false;
Jordy Rose43859f62010-06-07 19:32:37 +00001199 }
1200 }
1201}
1202
Anton Yartsev849c7bf2013-03-28 17:05:19 +00001203void MallocChecker::ReportBadFree(CheckerContext &C, SVal ArgVal,
1204 SourceRange Range,
1205 const Expr *DeallocExpr) const {
1206
1207 if (!Filter.CMallocOptimistic && !Filter.CMallocPessimistic &&
1208 !Filter.CNewDeleteChecker)
1209 return;
1210
Anton Yartsev648cb712013-04-04 23:46:29 +00001211 if (!isTrackedFamily(C, DeallocExpr))
1212 return;
1213
Ted Kremenekd048c6e2010-12-20 21:19:09 +00001214 if (ExplodedNode *N = C.generateSink()) {
Jordy Rose43859f62010-06-07 19:32:37 +00001215 if (!BT_BadFree)
Anna Zaksfebdc322012-02-16 22:26:12 +00001216 BT_BadFree.reset(new BugType("Bad free", "Memory Error"));
Jordy Rose43859f62010-06-07 19:32:37 +00001217
Dylan Noblesmithf7ccbad2012-02-05 02:13:05 +00001218 SmallString<100> buf;
Jordy Rose43859f62010-06-07 19:32:37 +00001219 llvm::raw_svector_ostream os(buf);
Anton Yartsev849c7bf2013-03-28 17:05:19 +00001220
Jordy Rose43859f62010-06-07 19:32:37 +00001221 const MemRegion *MR = ArgVal.getAsRegion();
Anton Yartsev849c7bf2013-03-28 17:05:19 +00001222 while (const ElementRegion *ER = dyn_cast_or_null<ElementRegion>(MR))
1223 MR = ER->getSuperRegion();
1224
1225 if (MR && isa<AllocaRegion>(MR))
1226 os << "Memory allocated by alloca() should not be deallocated";
1227 else {
1228 os << "Argument to ";
1229 if (!printAllocDeallocName(os, C, DeallocExpr))
1230 os << "deallocator";
1231
1232 os << " is ";
1233 bool Summarized = MR ? SummarizeRegion(os, MR)
1234 : SummarizeValue(os, ArgVal);
1235 if (Summarized)
1236 os << ", which is not memory allocated by ";
Jordy Rose43859f62010-06-07 19:32:37 +00001237 else
Anton Yartsev849c7bf2013-03-28 17:05:19 +00001238 os << "not memory allocated by ";
1239
1240 printExpectedAllocName(os, C, DeallocExpr);
Jordy Rose43859f62010-06-07 19:32:37 +00001241 }
Anton Yartsev849c7bf2013-03-28 17:05:19 +00001242
Anna Zakse172e8b2011-08-17 23:00:25 +00001243 BugReport *R = new BugReport(*BT_BadFree, os.str(), N);
Ted Kremenek76aadc32012-03-09 01:13:14 +00001244 R->markInteresting(MR);
Anton Yartsevbb369952013-03-13 14:39:10 +00001245 R->addRange(Range);
Jordan Rose785950e2012-11-02 01:53:40 +00001246 C.emitReport(R);
Jordy Rose43859f62010-06-07 19:32:37 +00001247 }
1248}
1249
Anton Yartsev648cb712013-04-04 23:46:29 +00001250void MallocChecker::ReportMismatchedDealloc(CheckerContext &C,
1251 SourceRange Range,
1252 const Expr *DeallocExpr,
Anton Yartseva3ae9372013-04-05 11:25:10 +00001253 const RefState *RS,
1254 SymbolRef Sym) const {
Anton Yartsev849c7bf2013-03-28 17:05:19 +00001255
1256 if (!Filter.CMismatchedDeallocatorChecker)
1257 return;
1258
1259 if (ExplodedNode *N = C.generateSink()) {
Anton Yartsev648cb712013-04-04 23:46:29 +00001260 if (!BT_MismatchedDealloc)
1261 BT_MismatchedDealloc.reset(new BugType("Bad deallocator",
1262 "Memory Error"));
Anton Yartsev849c7bf2013-03-28 17:05:19 +00001263
1264 SmallString<100> buf;
1265 llvm::raw_svector_ostream os(buf);
1266
1267 const Expr *AllocExpr = cast<Expr>(RS->getStmt());
1268 SmallString<20> AllocBuf;
1269 llvm::raw_svector_ostream AllocOs(AllocBuf);
1270 SmallString<20> DeallocBuf;
1271 llvm::raw_svector_ostream DeallocOs(DeallocBuf);
1272
1273 os << "Memory";
1274 if (printAllocDeallocName(AllocOs, C, AllocExpr))
1275 os << " allocated by " << AllocOs.str();
1276
1277 os << " should be deallocated by ";
1278 printExpectedDeallocName(os, RS->getAllocationFamily());
1279
1280 if (printAllocDeallocName(DeallocOs, C, DeallocExpr))
1281 os << ", not " << DeallocOs.str();
1282
Anton Yartsev648cb712013-04-04 23:46:29 +00001283 BugReport *R = new BugReport(*BT_MismatchedDealloc, os.str(), N);
Anton Yartseva3ae9372013-04-05 11:25:10 +00001284 R->markInteresting(Sym);
Anton Yartsev849c7bf2013-03-28 17:05:19 +00001285 R->addRange(Range);
Anton Yartseva3ae9372013-04-05 11:25:10 +00001286 R->addVisitor(new MallocBugVisitor(Sym));
Anton Yartsev849c7bf2013-03-28 17:05:19 +00001287 C.emitReport(R);
1288 }
1289}
1290
Anna Zaks118aa752013-02-07 23:05:47 +00001291void MallocChecker::ReportOffsetFree(CheckerContext &C, SVal ArgVal,
Anton Yartsev849c7bf2013-03-28 17:05:19 +00001292 SourceRange Range, const Expr *DeallocExpr,
1293 const Expr *AllocExpr) const {
1294
1295 if (!Filter.CMallocOptimistic && !Filter.CMallocPessimistic &&
1296 !Filter.CNewDeleteChecker)
1297 return;
1298
Anton Yartsev648cb712013-04-04 23:46:29 +00001299 if (!isTrackedFamily(C, AllocExpr))
1300 return;
1301
Anna Zaks118aa752013-02-07 23:05:47 +00001302 ExplodedNode *N = C.generateSink();
1303 if (N == NULL)
1304 return;
1305
1306 if (!BT_OffsetFree)
1307 BT_OffsetFree.reset(new BugType("Offset free", "Memory Error"));
1308
1309 SmallString<100> buf;
1310 llvm::raw_svector_ostream os(buf);
Anton Yartsev849c7bf2013-03-28 17:05:19 +00001311 SmallString<20> AllocNameBuf;
1312 llvm::raw_svector_ostream AllocNameOs(AllocNameBuf);
Anna Zaks118aa752013-02-07 23:05:47 +00001313
1314 const MemRegion *MR = ArgVal.getAsRegion();
1315 assert(MR && "Only MemRegion based symbols can have offset free errors");
1316
1317 RegionOffset Offset = MR->getAsOffset();
1318 assert((Offset.isValid() &&
1319 !Offset.hasSymbolicOffset() &&
1320 Offset.getOffset() != 0) &&
1321 "Only symbols with a valid offset can have offset free errors");
1322
1323 int offsetBytes = Offset.getOffset() / C.getASTContext().getCharWidth();
1324
Anton Yartsev849c7bf2013-03-28 17:05:19 +00001325 os << "Argument to ";
1326 if (!printAllocDeallocName(os, C, DeallocExpr))
1327 os << "deallocator";
1328 os << " is offset by "
Anna Zaks118aa752013-02-07 23:05:47 +00001329 << offsetBytes
1330 << " "
1331 << ((abs(offsetBytes) > 1) ? "bytes" : "byte")
Anton Yartsev849c7bf2013-03-28 17:05:19 +00001332 << " from the start of ";
1333 if (AllocExpr && printAllocDeallocName(AllocNameOs, C, AllocExpr))
1334 os << "memory allocated by " << AllocNameOs.str();
1335 else
1336 os << "allocated memory";
Anna Zaks118aa752013-02-07 23:05:47 +00001337
1338 BugReport *R = new BugReport(*BT_OffsetFree, os.str(), N);
1339 R->markInteresting(MR->getBaseRegion());
1340 R->addRange(Range);
1341 C.emitReport(R);
1342}
1343
Anton Yartsevbb369952013-03-13 14:39:10 +00001344void MallocChecker::ReportUseAfterFree(CheckerContext &C, SourceRange Range,
1345 SymbolRef Sym) const {
1346
Anton Yartsev849c7bf2013-03-28 17:05:19 +00001347 if (!Filter.CMallocOptimistic && !Filter.CMallocPessimistic &&
1348 !Filter.CNewDeleteChecker)
1349 return;
1350
Anton Yartsev648cb712013-04-04 23:46:29 +00001351 if (!isTrackedFamily(C, Sym))
1352 return;
1353
Anton Yartsevbb369952013-03-13 14:39:10 +00001354 if (ExplodedNode *N = C.generateSink()) {
1355 if (!BT_UseFree)
1356 BT_UseFree.reset(new BugType("Use-after-free", "Memory Error"));
1357
1358 BugReport *R = new BugReport(*BT_UseFree,
1359 "Use of memory after it is freed", N);
1360
1361 R->markInteresting(Sym);
1362 R->addRange(Range);
1363 R->addVisitor(new MallocBugVisitor(Sym));
1364 C.emitReport(R);
1365 }
1366}
1367
1368void MallocChecker::ReportDoubleFree(CheckerContext &C, SourceRange Range,
1369 bool Released, SymbolRef Sym,
Anton Yartsev3258d4b2013-03-13 17:07:32 +00001370 SymbolRef PrevSym) const {
Anton Yartsevbb369952013-03-13 14:39:10 +00001371
Anton Yartsev849c7bf2013-03-28 17:05:19 +00001372 if (!Filter.CMallocOptimistic && !Filter.CMallocPessimistic &&
1373 !Filter.CNewDeleteChecker)
1374 return;
1375
Anton Yartsev648cb712013-04-04 23:46:29 +00001376 if (!isTrackedFamily(C, Sym))
1377 return;
1378
Anton Yartsevbb369952013-03-13 14:39:10 +00001379 if (ExplodedNode *N = C.generateSink()) {
1380 if (!BT_DoubleFree)
1381 BT_DoubleFree.reset(new BugType("Double free", "Memory Error"));
1382
1383 BugReport *R = new BugReport(*BT_DoubleFree,
1384 (Released ? "Attempt to free released memory"
1385 : "Attempt to free non-owned memory"),
1386 N);
1387 R->addRange(Range);
Anton Yartsev3258d4b2013-03-13 17:07:32 +00001388 R->markInteresting(Sym);
1389 if (PrevSym)
1390 R->markInteresting(PrevSym);
Anton Yartsevbb369952013-03-13 14:39:10 +00001391 R->addVisitor(new MallocBugVisitor(Sym));
1392 C.emitReport(R);
1393 }
1394}
1395
Anna Zaks87cb5be2012-02-22 19:24:52 +00001396ProgramStateRef MallocChecker::ReallocMem(CheckerContext &C,
1397 const CallExpr *CE,
1398 bool FreesOnFail) const {
Anna Zaks259052d2012-04-10 23:41:11 +00001399 if (CE->getNumArgs() < 2)
1400 return 0;
1401
Ted Kremenek8bef8232012-01-26 21:29:00 +00001402 ProgramStateRef state = C.getState();
Ted Kremenekc8413fd2010-12-02 07:49:45 +00001403 const Expr *arg0Expr = CE->getArg(0);
Ted Kremenek5eca4822012-01-06 22:09:28 +00001404 const LocationContext *LCtx = C.getLocationContext();
Anna Zakse9ef5622012-02-10 01:11:00 +00001405 SVal Arg0Val = state->getSVal(arg0Expr, LCtx);
David Blaikie5251abe2013-02-20 05:52:05 +00001406 if (!Arg0Val.getAs<DefinedOrUnknownSVal>())
Anna Zaks87cb5be2012-02-22 19:24:52 +00001407 return 0;
David Blaikie5251abe2013-02-20 05:52:05 +00001408 DefinedOrUnknownSVal arg0Val = Arg0Val.castAs<DefinedOrUnknownSVal>();
Zhongxing Xud9c84c82009-12-12 12:29:38 +00001409
Ted Kremenek846eabd2010-12-01 21:28:31 +00001410 SValBuilder &svalBuilder = C.getSValBuilder();
Zhongxing Xud9c84c82009-12-12 12:29:38 +00001411
Ted Kremenekc8413fd2010-12-02 07:49:45 +00001412 DefinedOrUnknownSVal PtrEQ =
1413 svalBuilder.evalEQ(state, arg0Val, svalBuilder.makeNull());
Zhongxing Xud9c84c82009-12-12 12:29:38 +00001414
Lenny Maiorani4d8d8032011-04-27 14:49:29 +00001415 // Get the size argument. If there is no size arg then give up.
1416 const Expr *Arg1 = CE->getArg(1);
1417 if (!Arg1)
Anna Zaks87cb5be2012-02-22 19:24:52 +00001418 return 0;
Lenny Maiorani4d8d8032011-04-27 14:49:29 +00001419
1420 // Get the value of the size argument.
Anna Zakse9ef5622012-02-10 01:11:00 +00001421 SVal Arg1ValG = state->getSVal(Arg1, LCtx);
David Blaikie5251abe2013-02-20 05:52:05 +00001422 if (!Arg1ValG.getAs<DefinedOrUnknownSVal>())
Anna Zaks87cb5be2012-02-22 19:24:52 +00001423 return 0;
David Blaikie5251abe2013-02-20 05:52:05 +00001424 DefinedOrUnknownSVal Arg1Val = Arg1ValG.castAs<DefinedOrUnknownSVal>();
Lenny Maiorani4d8d8032011-04-27 14:49:29 +00001425
1426 // Compare the size argument to 0.
1427 DefinedOrUnknownSVal SizeZero =
1428 svalBuilder.evalEQ(state, Arg1Val,
1429 svalBuilder.makeIntValWithPtrWidth(0, false));
1430
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001431 ProgramStateRef StatePtrIsNull, StatePtrNotNull;
1432 llvm::tie(StatePtrIsNull, StatePtrNotNull) = state->assume(PtrEQ);
1433 ProgramStateRef StateSizeIsZero, StateSizeNotZero;
1434 llvm::tie(StateSizeIsZero, StateSizeNotZero) = state->assume(SizeZero);
1435 // We only assume exceptional states if they are definitely true; if the
1436 // state is under-constrained, assume regular realloc behavior.
1437 bool PrtIsNull = StatePtrIsNull && !StatePtrNotNull;
1438 bool SizeIsZero = StateSizeIsZero && !StateSizeNotZero;
1439
Lenny Maiorani4d8d8032011-04-27 14:49:29 +00001440 // If the ptr is NULL and the size is not 0, the call is equivalent to
1441 // malloc(size).
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001442 if ( PrtIsNull && !SizeIsZero) {
Anna Zaks87cb5be2012-02-22 19:24:52 +00001443 ProgramStateRef stateMalloc = MallocMemAux(C, CE, CE->getArg(1),
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001444 UndefinedVal(), StatePtrIsNull);
Anna Zaks87cb5be2012-02-22 19:24:52 +00001445 return stateMalloc;
Zhongxing Xud9c84c82009-12-12 12:29:38 +00001446 }
1447
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001448 if (PrtIsNull && SizeIsZero)
Anna Zaks87cb5be2012-02-22 19:24:52 +00001449 return 0;
Zhongxing Xud9c84c82009-12-12 12:29:38 +00001450
Anna Zaks30838b92012-02-13 20:57:07 +00001451 // Get the from and to pointer symbols as in toPtr = realloc(fromPtr, size).
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001452 assert(!PrtIsNull);
Anna Zaks30838b92012-02-13 20:57:07 +00001453 SymbolRef FromPtr = arg0Val.getAsSymbol();
1454 SVal RetVal = state->getSVal(CE, LCtx);
1455 SymbolRef ToPtr = RetVal.getAsSymbol();
1456 if (!FromPtr || !ToPtr)
Anna Zaks87cb5be2012-02-22 19:24:52 +00001457 return 0;
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001458
Anna Zaks55dd9562012-08-24 02:28:20 +00001459 bool ReleasedAllocated = false;
1460
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001461 // If the size is 0, free the memory.
1462 if (SizeIsZero)
Anna Zaks55dd9562012-08-24 02:28:20 +00001463 if (ProgramStateRef stateFree = FreeMemAux(C, CE, StateSizeIsZero, 0,
1464 false, ReleasedAllocated)){
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001465 // The semantics of the return value are:
1466 // If size was equal to 0, either NULL or a pointer suitable to be passed
Anna Zaksede875b2012-08-03 18:30:18 +00001467 // to free() is returned. We just free the input pointer and do not add
1468 // any constrains on the output pointer.
Anna Zaks87cb5be2012-02-22 19:24:52 +00001469 return stateFree;
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001470 }
1471
1472 // Default behavior.
Anna Zaks55dd9562012-08-24 02:28:20 +00001473 if (ProgramStateRef stateFree =
1474 FreeMemAux(C, CE, state, 0, false, ReleasedAllocated)) {
1475
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001476 ProgramStateRef stateRealloc = MallocMemAux(C, CE, CE->getArg(1),
1477 UnknownVal(), stateFree);
Anna Zaks30838b92012-02-13 20:57:07 +00001478 if (!stateRealloc)
Anna Zaks87cb5be2012-02-22 19:24:52 +00001479 return 0;
Anna Zaks55dd9562012-08-24 02:28:20 +00001480
Anna Zaks9dc298b2012-09-12 22:57:34 +00001481 ReallocPairKind Kind = RPToBeFreedAfterFailure;
1482 if (FreesOnFail)
1483 Kind = RPIsFreeOnFailure;
1484 else if (!ReleasedAllocated)
1485 Kind = RPDoNotTrackAfterFailure;
1486
Anna Zaks55dd9562012-08-24 02:28:20 +00001487 // Record the info about the reallocated symbol so that we could properly
1488 // process failed reallocation.
Anna Zaks40add292012-02-15 00:11:25 +00001489 stateRealloc = stateRealloc->set<ReallocPairs>(ToPtr,
Anna Zaks9dc298b2012-09-12 22:57:34 +00001490 ReallocPair(FromPtr, Kind));
Anna Zaks55dd9562012-08-24 02:28:20 +00001491 // The reallocated symbol should stay alive for as long as the new symbol.
Anna Zaksb276bd92012-02-14 00:26:13 +00001492 C.getSymbolManager().addSymbolDependency(ToPtr, FromPtr);
Anna Zaks87cb5be2012-02-22 19:24:52 +00001493 return stateRealloc;
Zhongxing Xud9c84c82009-12-12 12:29:38 +00001494 }
Anna Zaks87cb5be2012-02-22 19:24:52 +00001495 return 0;
Zhongxing Xu589c0f22009-11-12 08:38:56 +00001496}
Zhongxing Xu7b760962009-11-13 07:25:27 +00001497
Anna Zaks87cb5be2012-02-22 19:24:52 +00001498ProgramStateRef MallocChecker::CallocMem(CheckerContext &C, const CallExpr *CE){
Anna Zaks259052d2012-04-10 23:41:11 +00001499 if (CE->getNumArgs() < 2)
1500 return 0;
1501
Ted Kremenek8bef8232012-01-26 21:29:00 +00001502 ProgramStateRef state = C.getState();
Ted Kremenek846eabd2010-12-01 21:28:31 +00001503 SValBuilder &svalBuilder = C.getSValBuilder();
Ted Kremenek5eca4822012-01-06 22:09:28 +00001504 const LocationContext *LCtx = C.getLocationContext();
1505 SVal count = state->getSVal(CE->getArg(0), LCtx);
1506 SVal elementSize = state->getSVal(CE->getArg(1), LCtx);
Ted Kremenekc8413fd2010-12-02 07:49:45 +00001507 SVal TotalSize = svalBuilder.evalBinOp(state, BO_Mul, count, elementSize,
1508 svalBuilder.getContext().getSizeType());
1509 SVal zeroVal = svalBuilder.makeZeroVal(svalBuilder.getContext().CharTy);
Zhongxing Xua5ce9662010-06-01 03:01:33 +00001510
Anna Zaks87cb5be2012-02-22 19:24:52 +00001511 return MallocMemAux(C, CE, TotalSize, zeroVal, state);
Zhongxing Xua5ce9662010-06-01 03:01:33 +00001512}
1513
Anna Zaks3d7c44e2012-03-21 19:45:08 +00001514LeakInfo
Anna Zaksca8e36e2012-02-23 21:38:21 +00001515MallocChecker::getAllocationSite(const ExplodedNode *N, SymbolRef Sym,
1516 CheckerContext &C) const {
Anna Zaks7752d292012-02-27 23:40:55 +00001517 const LocationContext *LeakContext = N->getLocationContext();
Anna Zaksca8e36e2012-02-23 21:38:21 +00001518 // Walk the ExplodedGraph backwards and find the first node that referred to
1519 // the tracked symbol.
1520 const ExplodedNode *AllocNode = N;
Anna Zaks3d7c44e2012-03-21 19:45:08 +00001521 const MemRegion *ReferenceRegion = 0;
Anna Zaksca8e36e2012-02-23 21:38:21 +00001522
1523 while (N) {
Anna Zaks3d7c44e2012-03-21 19:45:08 +00001524 ProgramStateRef State = N->getState();
1525 if (!State->get<RegionState>(Sym))
Anna Zaksca8e36e2012-02-23 21:38:21 +00001526 break;
Anna Zaks3d7c44e2012-03-21 19:45:08 +00001527
1528 // Find the most recent expression bound to the symbol in the current
1529 // context.
Anna Zaks27d99dd2013-04-10 21:42:02 +00001530 if (!ReferenceRegion) {
1531 if (const MemRegion *MR = C.getLocationRegionIfPostStore(N)) {
1532 SVal Val = State->getSVal(MR);
1533 if (Val.getAsLocSymbol() == Sym) {
Anna Zaks8cf91f72013-04-10 22:56:33 +00001534 const VarRegion* VR = MR->getBaseRegion()->getAs<VarRegion>();
Anna Zaks27d99dd2013-04-10 21:42:02 +00001535 // Do not show local variables belonging to a function other than
1536 // where the error is reported.
1537 if (!VR ||
1538 (VR->getStackFrame() == LeakContext->getCurrentStackFrame()))
1539 ReferenceRegion = MR;
1540 }
1541 }
Benjamin Kramer850f1b12012-03-21 21:03:48 +00001542 }
Anna Zaks3d7c44e2012-03-21 19:45:08 +00001543
Anna Zaks7752d292012-02-27 23:40:55 +00001544 // Allocation node, is the last node in the current context in which the
1545 // symbol was tracked.
1546 if (N->getLocationContext() == LeakContext)
1547 AllocNode = N;
Anna Zaksca8e36e2012-02-23 21:38:21 +00001548 N = N->pred_empty() ? NULL : *(N->pred_begin());
1549 }
1550
Anna Zaks97bfb552013-01-08 00:25:29 +00001551 return LeakInfo(AllocNode, ReferenceRegion);
Anna Zaksca8e36e2012-02-23 21:38:21 +00001552}
1553
Anna Zaksda046772012-02-11 21:02:40 +00001554void MallocChecker::reportLeak(SymbolRef Sym, ExplodedNode *N,
1555 CheckerContext &C) const {
Anton Yartsev849c7bf2013-03-28 17:05:19 +00001556
1557 if (!Filter.CMallocOptimistic && !Filter.CMallocPessimistic &&
Jordan Rosee85deb32013-04-05 17:55:00 +00001558 !Filter.CNewDeleteLeaksChecker)
Anton Yartsev849c7bf2013-03-28 17:05:19 +00001559 return;
1560
Jordan Rosee85deb32013-04-05 17:55:00 +00001561 const RefState *RS = C.getState()->get<RegionState>(Sym);
1562 assert(RS && "cannot leak an untracked symbol");
1563 AllocationFamily Family = RS->getAllocationFamily();
1564 if (!isTrackedFamily(Family))
Anton Yartsev418780f2013-04-05 02:25:02 +00001565 return;
1566
Jordan Rosee85deb32013-04-05 17:55:00 +00001567 // Special case for new and new[]; these are controlled by a separate checker
1568 // flag so that they can be selectively disabled.
1569 if (Family == AF_CXXNew || Family == AF_CXXNewArray)
1570 if (!Filter.CNewDeleteLeaksChecker)
1571 return;
1572
Anna Zaksda046772012-02-11 21:02:40 +00001573 assert(N);
1574 if (!BT_Leak) {
Anna Zaksfebdc322012-02-16 22:26:12 +00001575 BT_Leak.reset(new BugType("Memory leak", "Memory Error"));
Anna Zaksda046772012-02-11 21:02:40 +00001576 // Leaks should not be reported if they are post-dominated by a sink:
1577 // (1) Sinks are higher importance bugs.
1578 // (2) NoReturnFunctionChecker uses sink nodes to represent paths ending
1579 // with __noreturn functions such as assert() or exit(). We choose not
1580 // to report leaks on such paths.
1581 BT_Leak->setSuppressOnSink(true);
1582 }
1583
Anna Zaksca8e36e2012-02-23 21:38:21 +00001584 // Most bug reports are cached at the location where they occurred.
1585 // With leaks, we want to unique them by the location where they were
1586 // allocated, and only report a single path.
Anna Zaks7752d292012-02-27 23:40:55 +00001587 PathDiagnosticLocation LocUsedForUniqueing;
Anna Zaks97bfb552013-01-08 00:25:29 +00001588 const ExplodedNode *AllocNode = 0;
Anna Zaks3d7c44e2012-03-21 19:45:08 +00001589 const MemRegion *Region = 0;
Anna Zaks97bfb552013-01-08 00:25:29 +00001590 llvm::tie(AllocNode, Region) = getAllocationSite(N, Sym, C);
1591
1592 ProgramPoint P = AllocNode->getLocation();
1593 const Stmt *AllocationStmt = 0;
David Blaikie7a95de62013-02-21 22:23:56 +00001594 if (Optional<CallExitEnd> Exit = P.getAs<CallExitEnd>())
Anna Zaks97bfb552013-01-08 00:25:29 +00001595 AllocationStmt = Exit->getCalleeContext()->getCallSite();
David Blaikie7a95de62013-02-21 22:23:56 +00001596 else if (Optional<StmtPoint> SP = P.getAs<StmtPoint>())
Anna Zaks97bfb552013-01-08 00:25:29 +00001597 AllocationStmt = SP->getStmt();
Anton Yartsev418780f2013-04-05 02:25:02 +00001598 if (AllocationStmt)
Anna Zaks97bfb552013-01-08 00:25:29 +00001599 LocUsedForUniqueing = PathDiagnosticLocation::createBegin(AllocationStmt,
1600 C.getSourceManager(),
1601 AllocNode->getLocationContext());
Anna Zaksca8e36e2012-02-23 21:38:21 +00001602
Anna Zaks3d7c44e2012-03-21 19:45:08 +00001603 SmallString<200> buf;
1604 llvm::raw_svector_ostream os(buf);
Jordan Rose919e8a12012-08-08 18:23:36 +00001605 if (Region && Region->canPrintPretty()) {
Anna Zaks68eb4c22013-04-06 00:41:36 +00001606 os << "Potential leak of memory pointed to by '";
Jordan Rose919e8a12012-08-08 18:23:36 +00001607 Region->printPretty(os);
Jordan Rose0d53ab42012-08-08 18:23:31 +00001608 os << '\'';
Anna Zaks68eb4c22013-04-06 00:41:36 +00001609 } else {
1610 os << "Potential memory leak";
Anna Zaks3d7c44e2012-03-21 19:45:08 +00001611 }
1612
Anna Zaks97bfb552013-01-08 00:25:29 +00001613 BugReport *R = new BugReport(*BT_Leak, os.str(), N,
1614 LocUsedForUniqueing,
1615 AllocNode->getLocationContext()->getDecl());
Ted Kremenek76aadc32012-03-09 01:13:14 +00001616 R->markInteresting(Sym);
Anna Zaks88feba02012-05-10 01:37:40 +00001617 R->addVisitor(new MallocBugVisitor(Sym, true));
Jordan Rose785950e2012-11-02 01:53:40 +00001618 C.emitReport(R);
Anna Zaksda046772012-02-11 21:02:40 +00001619}
1620
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +00001621void MallocChecker::checkDeadSymbols(SymbolReaper &SymReaper,
1622 CheckerContext &C) const
Ted Kremenekc8413fd2010-12-02 07:49:45 +00001623{
Zhongxing Xu173ff562010-08-15 08:19:57 +00001624 if (!SymReaper.hasDeadSymbols())
1625 return;
Zhongxing Xufc7ac8f2009-11-13 07:48:11 +00001626
Ted Kremenek8bef8232012-01-26 21:29:00 +00001627 ProgramStateRef state = C.getState();
Zhongxing Xu173ff562010-08-15 08:19:57 +00001628 RegionStateTy RS = state->get<RegionState>();
Jordy Rose90760142010-08-18 04:33:47 +00001629 RegionStateTy::Factory &F = state->get_context<RegionState>();
Zhongxing Xu173ff562010-08-15 08:19:57 +00001630
Dmitri Gribenkocfa88f82013-01-12 19:30:44 +00001631 SmallVector<SymbolRef, 2> Errors;
Zhongxing Xu173ff562010-08-15 08:19:57 +00001632 for (RegionStateTy::iterator I = RS.begin(), E = RS.end(); I != E; ++I) {
1633 if (SymReaper.isDead(I->first)) {
Anna Zaks54458702012-10-29 22:51:54 +00001634 if (I->second.isAllocated())
Anna Zaksf8c17b72012-02-09 06:48:19 +00001635 Errors.push_back(I->first);
Jordy Rose90760142010-08-18 04:33:47 +00001636 // Remove the dead symbol from the map.
Ted Kremenek3baf6722010-11-24 00:54:37 +00001637 RS = F.remove(RS, I->first);
Ted Kremenek217470e2011-07-28 23:07:51 +00001638
Zhongxing Xufc7ac8f2009-11-13 07:48:11 +00001639 }
1640 }
Ted Kremenek217470e2011-07-28 23:07:51 +00001641
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001642 // Cleanup the Realloc Pairs Map.
Jordan Rose166d5022012-11-02 01:54:06 +00001643 ReallocPairsTy RP = state->get<ReallocPairs>();
1644 for (ReallocPairsTy::iterator I = RP.begin(), E = RP.end(); I != E; ++I) {
Anna Zaks40add292012-02-15 00:11:25 +00001645 if (SymReaper.isDead(I->first) ||
1646 SymReaper.isDead(I->second.ReallocatedSym)) {
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001647 state = state->remove<ReallocPairs>(I->first);
1648 }
1649 }
1650
Anna Zaks4141e4d2012-11-13 03:18:01 +00001651 // Cleanup the FreeReturnValue Map.
1652 FreeReturnValueTy FR = state->get<FreeReturnValue>();
1653 for (FreeReturnValueTy::iterator I = FR.begin(), E = FR.end(); I != E; ++I) {
1654 if (SymReaper.isDead(I->first) ||
1655 SymReaper.isDead(I->second)) {
1656 state = state->remove<FreeReturnValue>(I->first);
1657 }
1658 }
1659
Anna Zaksca8e36e2012-02-23 21:38:21 +00001660 // Generate leak node.
Anna Zaks54458702012-10-29 22:51:54 +00001661 ExplodedNode *N = C.getPredecessor();
1662 if (!Errors.empty()) {
1663 static SimpleProgramPointTag Tag("MallocChecker : DeadSymbolsLeak");
1664 N = C.addTransition(C.getState(), C.getPredecessor(), &Tag);
Dmitri Gribenkocfa88f82013-01-12 19:30:44 +00001665 for (SmallVector<SymbolRef, 2>::iterator
Anna Zaks54458702012-10-29 22:51:54 +00001666 I = Errors.begin(), E = Errors.end(); I != E; ++I) {
Anna Zaksda046772012-02-11 21:02:40 +00001667 reportLeak(*I, N, C);
Anna Zaksf8c17b72012-02-09 06:48:19 +00001668 }
Ted Kremenek217470e2011-07-28 23:07:51 +00001669 }
Anna Zaks54458702012-10-29 22:51:54 +00001670
Anna Zaksca8e36e2012-02-23 21:38:21 +00001671 C.addTransition(state->set<RegionState>(RS), N);
Zhongxing Xu7b760962009-11-13 07:25:27 +00001672}
Zhongxing Xu243fde92009-11-17 07:54:15 +00001673
Anton Yartsev55e57a52013-04-10 22:21:41 +00001674void MallocChecker::checkPreCall(const CallEvent &Call,
1675 CheckerContext &C) const {
1676
Anna Zaks14345182012-05-18 01:16:10 +00001677 // We will check for double free in the post visit.
Anton Yartsev55e57a52013-04-10 22:21:41 +00001678 if (const AnyFunctionCall *FC = dyn_cast<AnyFunctionCall>(&Call)) {
1679 const FunctionDecl *FD = FC->getDecl();
1680 if (!FD)
1681 return;
Anton Yartsev2de19ed2013-03-25 01:35:45 +00001682
Anton Yartsev55e57a52013-04-10 22:21:41 +00001683 if ((Filter.CMallocOptimistic || Filter.CMallocPessimistic) &&
1684 isFreeFunction(FD, C.getASTContext()))
1685 return;
Anna Zaks66c40402012-02-14 21:55:24 +00001686
Anton Yartsev55e57a52013-04-10 22:21:41 +00001687 if (Filter.CNewDeleteChecker &&
1688 isStandardNewDelete(FD, C.getASTContext()))
1689 return;
1690 }
1691
1692 // Check if the callee of a method is deleted.
1693 if (const CXXInstanceCall *CC = dyn_cast<CXXInstanceCall>(&Call)) {
1694 SymbolRef Sym = CC->getCXXThisVal().getAsSymbol();
1695 if (!Sym || checkUseAfterFree(Sym, C, CC->getCXXThisExpr()))
1696 return;
1697 }
1698
1699 // Check arguments for being used after free.
1700 for (unsigned I = 0, E = Call.getNumArgs(); I != E; ++I) {
1701 SVal ArgSVal = Call.getArgSVal(I);
1702 if (ArgSVal.getAs<Loc>()) {
1703 SymbolRef Sym = ArgSVal.getAsSymbol();
Anna Zaks66c40402012-02-14 21:55:24 +00001704 if (!Sym)
1705 continue;
Anton Yartsev55e57a52013-04-10 22:21:41 +00001706 if (checkUseAfterFree(Sym, C, Call.getArgExpr(I)))
Anna Zaks66c40402012-02-14 21:55:24 +00001707 return;
1708 }
1709 }
1710}
1711
Anna Zaks91c2a112012-02-08 23:16:56 +00001712void MallocChecker::checkPreStmt(const ReturnStmt *S, CheckerContext &C) const {
1713 const Expr *E = S->getRetValue();
1714 if (!E)
1715 return;
Anna Zaks0860cd02012-02-11 21:44:39 +00001716
1717 // Check if we are returning a symbol.
Jordan Rose0d53ab42012-08-08 18:23:31 +00001718 ProgramStateRef State = C.getState();
1719 SVal RetVal = State->getSVal(E, C.getLocationContext());
Anna Zaksd9ab7bb2012-02-22 02:36:01 +00001720 SymbolRef Sym = RetVal.getAsSymbol();
1721 if (!Sym)
1722 // If we are returning a field of the allocated struct or an array element,
1723 // the callee could still free the memory.
1724 // TODO: This logic should be a part of generic symbol escape callback.
1725 if (const MemRegion *MR = RetVal.getAsRegion())
1726 if (isa<FieldRegion>(MR) || isa<ElementRegion>(MR))
1727 if (const SymbolicRegion *BMR =
1728 dyn_cast<SymbolicRegion>(MR->getBaseRegion()))
1729 Sym = BMR->getSymbol();
Zhongxing Xu4985e3e2009-11-17 08:58:18 +00001730
Anna Zaks0860cd02012-02-11 21:44:39 +00001731 // Check if we are returning freed memory.
Jordan Rose0d53ab42012-08-08 18:23:31 +00001732 if (Sym)
Jordan Rose65d4bd62012-11-15 19:11:33 +00001733 checkUseAfterFree(Sym, C, E);
Zhongxing Xu4985e3e2009-11-17 08:58:18 +00001734}
Zhongxing Xub94b81a2009-12-31 06:13:07 +00001735
Anna Zaksf5aa3f52012-03-22 00:57:20 +00001736// TODO: Blocks should be either inlined or should call invalidate regions
1737// upon invocation. After that's in place, special casing here will not be
1738// needed.
1739void MallocChecker::checkPostStmt(const BlockExpr *BE,
1740 CheckerContext &C) const {
1741
1742 // Scan the BlockDecRefExprs for any object the retain count checker
1743 // may be tracking.
1744 if (!BE->getBlockDecl()->hasCaptures())
1745 return;
1746
1747 ProgramStateRef state = C.getState();
1748 const BlockDataRegion *R =
1749 cast<BlockDataRegion>(state->getSVal(BE,
1750 C.getLocationContext()).getAsRegion());
1751
1752 BlockDataRegion::referenced_vars_iterator I = R->referenced_vars_begin(),
1753 E = R->referenced_vars_end();
1754
1755 if (I == E)
1756 return;
1757
1758 SmallVector<const MemRegion*, 10> Regions;
1759 const LocationContext *LC = C.getLocationContext();
1760 MemRegionManager &MemMgr = C.getSValBuilder().getRegionManager();
1761
1762 for ( ; I != E; ++I) {
Ted Kremeneke3ce2c12012-12-06 07:17:20 +00001763 const VarRegion *VR = I.getCapturedRegion();
Anna Zaksf5aa3f52012-03-22 00:57:20 +00001764 if (VR->getSuperRegion() == R) {
1765 VR = MemMgr.getVarRegion(VR->getDecl(), LC);
1766 }
1767 Regions.push_back(VR);
1768 }
1769
1770 state =
1771 state->scanReachableSymbols<StopTrackingCallback>(Regions.data(),
1772 Regions.data() + Regions.size()).getState();
1773 C.addTransition(state);
1774}
1775
Anna Zaks14345182012-05-18 01:16:10 +00001776bool MallocChecker::isReleased(SymbolRef Sym, CheckerContext &C) const {
Anna Zaks91c2a112012-02-08 23:16:56 +00001777 assert(Sym);
1778 const RefState *RS = C.getState()->get<RegionState>(Sym);
Anna Zaks14345182012-05-18 01:16:10 +00001779 return (RS && RS->isReleased());
1780}
1781
1782bool MallocChecker::checkUseAfterFree(SymbolRef Sym, CheckerContext &C,
1783 const Stmt *S) const {
Anna Zaks91c2a112012-02-08 23:16:56 +00001784
Anton Yartsevbb369952013-03-13 14:39:10 +00001785 if (isReleased(Sym, C)) {
1786 ReportUseAfterFree(C, S->getSourceRange(), Sym);
1787 return true;
Anna Zaks91c2a112012-02-08 23:16:56 +00001788 }
Anton Yartsevbb369952013-03-13 14:39:10 +00001789
Anna Zaks91c2a112012-02-08 23:16:56 +00001790 return false;
1791}
1792
Zhongxing Xuc8023782010-03-10 04:58:55 +00001793// Check if the location is a freed symbolic region.
Anna Zaks390909c2011-10-06 00:43:15 +00001794void MallocChecker::checkLocation(SVal l, bool isLoad, const Stmt *S,
1795 CheckerContext &C) const {
Zhongxing Xuc8023782010-03-10 04:58:55 +00001796 SymbolRef Sym = l.getLocSymbolInBase();
Anna Zaks91c2a112012-02-08 23:16:56 +00001797 if (Sym)
Anna Zaks14345182012-05-18 01:16:10 +00001798 checkUseAfterFree(Sym, C, S);
Zhongxing Xuc8023782010-03-10 04:58:55 +00001799}
Ted Kremenekdd0e4902010-07-31 01:52:11 +00001800
Anna Zaks4fb54872012-02-11 21:02:35 +00001801// If a symbolic region is assumed to NULL (or another constant), stop tracking
1802// it - assuming that allocation failed on this path.
1803ProgramStateRef MallocChecker::evalAssume(ProgramStateRef state,
1804 SVal Cond,
1805 bool Assumption) const {
1806 RegionStateTy RS = state->get<RegionState>();
Anna Zaks4fb54872012-02-11 21:02:35 +00001807 for (RegionStateTy::iterator I = RS.begin(), E = RS.end(); I != E; ++I) {
Ted Kremenek47cbd0f2012-09-07 22:31:01 +00001808 // If the symbol is assumed to be NULL, remove it from consideration.
Jordan Roseec8d4202012-11-01 00:18:27 +00001809 ConstraintManager &CMgr = state->getConstraintManager();
1810 ConditionTruthVal AllocFailed = CMgr.isNull(state, I.getKey());
1811 if (AllocFailed.isConstrainedTrue())
Anna Zaks4fb54872012-02-11 21:02:35 +00001812 state = state->remove<RegionState>(I.getKey());
1813 }
1814
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001815 // Realloc returns 0 when reallocation fails, which means that we should
1816 // restore the state of the pointer being reallocated.
Jordan Rose166d5022012-11-02 01:54:06 +00001817 ReallocPairsTy RP = state->get<ReallocPairs>();
1818 for (ReallocPairsTy::iterator I = RP.begin(), E = RP.end(); I != E; ++I) {
Ted Kremenek47cbd0f2012-09-07 22:31:01 +00001819 // If the symbol is assumed to be NULL, remove it from consideration.
Jordan Roseec8d4202012-11-01 00:18:27 +00001820 ConstraintManager &CMgr = state->getConstraintManager();
1821 ConditionTruthVal AllocFailed = CMgr.isNull(state, I.getKey());
Jordan Rose79a29eb2012-11-01 00:25:15 +00001822 if (!AllocFailed.isConstrainedTrue())
Anna Zaks9dc298b2012-09-12 22:57:34 +00001823 continue;
Jordan Roseec8d4202012-11-01 00:18:27 +00001824
Anna Zaks9dc298b2012-09-12 22:57:34 +00001825 SymbolRef ReallocSym = I.getData().ReallocatedSym;
1826 if (const RefState *RS = state->get<RegionState>(ReallocSym)) {
1827 if (RS->isReleased()) {
1828 if (I.getData().Kind == RPToBeFreedAfterFailure)
Anna Zaks40add292012-02-15 00:11:25 +00001829 state = state->set<RegionState>(ReallocSym,
Anton Yartsev849c7bf2013-03-28 17:05:19 +00001830 RefState::getAllocated(RS->getAllocationFamily(), RS->getStmt()));
Anna Zaks9dc298b2012-09-12 22:57:34 +00001831 else if (I.getData().Kind == RPDoNotTrackAfterFailure)
1832 state = state->remove<RegionState>(ReallocSym);
1833 else
1834 assert(I.getData().Kind == RPIsFreeOnFailure);
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001835 }
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001836 }
Anna Zaks9dc298b2012-09-12 22:57:34 +00001837 state = state->remove<ReallocPairs>(I.getKey());
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001838 }
1839
Anna Zaks4fb54872012-02-11 21:02:35 +00001840 return state;
1841}
1842
Jordan Rose9fe09f32013-03-09 00:59:10 +00001843bool MallocChecker::doesNotFreeMemOrInteresting(const CallEvent *Call,
1844 ProgramStateRef State) const {
Jordan Rose85d7e012012-07-02 19:27:51 +00001845 assert(Call);
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001846
1847 // For now, assume that any C++ call can free memory.
1848 // TODO: If we want to be more optimistic here, we'll need to make sure that
1849 // regions escape to C++ containers. They seem to do that even now, but for
1850 // mysterious reasons.
Jordan Rosecde8cdb2012-07-02 19:27:56 +00001851 if (!(isa<FunctionCall>(Call) || isa<ObjCMethodCall>(Call)))
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001852 return false;
1853
Jordan Rose740d4902012-07-02 19:27:35 +00001854 // Check Objective-C messages by selector name.
Jordan Rosecde8cdb2012-07-02 19:27:56 +00001855 if (const ObjCMethodCall *Msg = dyn_cast<ObjCMethodCall>(Call)) {
Jordan Rose85d7e012012-07-02 19:27:51 +00001856 // If it's not a framework call, or if it takes a callback, assume it
1857 // can free memory.
1858 if (!Call->isInSystemHeader() || Call->hasNonZeroCallbackArg())
Anna Zaks07d39a42012-02-28 01:54:22 +00001859 return false;
1860
Jordan Rose9fe09f32013-03-09 00:59:10 +00001861 // If it's a method we know about, handle it explicitly post-call.
1862 // This should happen before the "freeWhenDone" check below.
1863 if (isKnownDeallocObjCMethodName(*Msg))
1864 return true;
Anna Zaks52a04812012-06-20 23:35:57 +00001865
Jordan Rose9fe09f32013-03-09 00:59:10 +00001866 // If there's a "freeWhenDone" parameter, but the method isn't one we know
1867 // about, we can't be sure that the object will use free() to deallocate the
1868 // memory, so we can't model it explicitly. The best we can do is use it to
1869 // decide whether the pointer escapes.
1870 if (Optional<bool> FreeWhenDone = getFreeWhenDoneArg(*Msg))
1871 return !*FreeWhenDone;
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001872
Jordan Rose9fe09f32013-03-09 00:59:10 +00001873 // If the first selector piece ends with "NoCopy", and there is no
1874 // "freeWhenDone" parameter set to zero, we know ownership is being
1875 // transferred. Again, though, we can't be sure that the object will use
1876 // free() to deallocate the memory, so we can't model it explicitly.
1877 StringRef FirstSlot = Msg->getSelector().getNameForSlot(0);
Jordan Rose740d4902012-07-02 19:27:35 +00001878 if (FirstSlot.endswith("NoCopy"))
Anna Zaksfb7f76f2012-03-05 17:42:10 +00001879 return false;
Anna Zaksfb7f76f2012-03-05 17:42:10 +00001880
Anna Zaks5f757682012-06-19 05:10:32 +00001881 // If the first selector starts with addPointer, insertPointer,
1882 // or replacePointer, assume we are dealing with NSPointerArray or similar.
1883 // This is similar to C++ containers (vector); we still might want to check
Jordan Rose740d4902012-07-02 19:27:35 +00001884 // that the pointers get freed by following the container itself.
1885 if (FirstSlot.startswith("addPointer") ||
1886 FirstSlot.startswith("insertPointer") ||
1887 FirstSlot.startswith("replacePointer")) {
Anna Zaks5f757682012-06-19 05:10:32 +00001888 return false;
1889 }
1890
Jordan Rose740d4902012-07-02 19:27:35 +00001891 // Otherwise, assume that the method does not free memory.
1892 // Most framework methods do not free memory.
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001893 return true;
Anna Zaks66c40402012-02-14 21:55:24 +00001894 }
1895
Jordan Rose740d4902012-07-02 19:27:35 +00001896 // At this point the only thing left to handle is straight function calls.
1897 const FunctionDecl *FD = cast<FunctionCall>(Call)->getDecl();
1898 if (!FD)
1899 return false;
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001900
Jordan Rose740d4902012-07-02 19:27:35 +00001901 ASTContext &ASTC = State->getStateManager().getContext();
1902
1903 // If it's one of the allocation functions we can reason about, we model
1904 // its behavior explicitly.
1905 if (isMemFunction(FD, ASTC))
1906 return true;
1907
1908 // If it's not a system call, assume it frees memory.
1909 if (!Call->isInSystemHeader())
1910 return false;
1911
1912 // White list the system functions whose arguments escape.
1913 const IdentifierInfo *II = FD->getIdentifier();
1914 if (!II)
1915 return false;
1916 StringRef FName = II->getName();
1917
Jordan Rose740d4902012-07-02 19:27:35 +00001918 // White list the 'XXXNoCopy' CoreFoundation functions.
Jordan Rose85d7e012012-07-02 19:27:51 +00001919 // We specifically check these before
Jordan Rose740d4902012-07-02 19:27:35 +00001920 if (FName.endswith("NoCopy")) {
1921 // Look for the deallocator argument. We know that the memory ownership
1922 // is not transferred only if the deallocator argument is
1923 // 'kCFAllocatorNull'.
1924 for (unsigned i = 1; i < Call->getNumArgs(); ++i) {
1925 const Expr *ArgE = Call->getArgExpr(i)->IgnoreParenCasts();
1926 if (const DeclRefExpr *DE = dyn_cast<DeclRefExpr>(ArgE)) {
1927 StringRef DeallocatorName = DE->getFoundDecl()->getName();
1928 if (DeallocatorName == "kCFAllocatorNull")
1929 return true;
1930 }
1931 }
1932 return false;
1933 }
1934
Jordan Rose740d4902012-07-02 19:27:35 +00001935 // Associating streams with malloced buffers. The pointer can escape if
Jordan Rose85d7e012012-07-02 19:27:51 +00001936 // 'closefn' is specified (and if that function does free memory),
1937 // but it will not if closefn is not specified.
Jordan Rose740d4902012-07-02 19:27:35 +00001938 // Currently, we do not inspect the 'closefn' function (PR12101).
1939 if (FName == "funopen")
Jordan Rose85d7e012012-07-02 19:27:51 +00001940 if (Call->getNumArgs() >= 4 && Call->getArgSVal(4).isConstant(0))
1941 return true;
Jordan Rose740d4902012-07-02 19:27:35 +00001942
1943 // Do not warn on pointers passed to 'setbuf' when used with std streams,
1944 // these leaks might be intentional when setting the buffer for stdio.
1945 // http://stackoverflow.com/questions/2671151/who-frees-setvbuf-buffer
1946 if (FName == "setbuf" || FName =="setbuffer" ||
1947 FName == "setlinebuf" || FName == "setvbuf") {
1948 if (Call->getNumArgs() >= 1) {
1949 const Expr *ArgE = Call->getArgExpr(0)->IgnoreParenCasts();
1950 if (const DeclRefExpr *ArgDRE = dyn_cast<DeclRefExpr>(ArgE))
1951 if (const VarDecl *D = dyn_cast<VarDecl>(ArgDRE->getDecl()))
1952 if (D->getCanonicalDecl()->getName().find("std") != StringRef::npos)
1953 return false;
1954 }
1955 }
1956
1957 // A bunch of other functions which either take ownership of a pointer or
1958 // wrap the result up in a struct or object, meaning it can be freed later.
1959 // (See RetainCountChecker.) Not all the parameters here are invalidated,
1960 // but the Malloc checker cannot differentiate between them. The right way
1961 // of doing this would be to implement a pointer escapes callback.
1962 if (FName == "CGBitmapContextCreate" ||
1963 FName == "CGBitmapContextCreateWithData" ||
1964 FName == "CVPixelBufferCreateWithBytes" ||
1965 FName == "CVPixelBufferCreateWithPlanarBytes" ||
1966 FName == "OSAtomicEnqueue") {
1967 return false;
1968 }
1969
Jordan Rose85d7e012012-07-02 19:27:51 +00001970 // Handle cases where we know a buffer's /address/ can escape.
1971 // Note that the above checks handle some special cases where we know that
1972 // even though the address escapes, it's still our responsibility to free the
1973 // buffer.
1974 if (Call->argumentsMayEscape())
Jordan Rose740d4902012-07-02 19:27:35 +00001975 return false;
1976
1977 // Otherwise, assume that the function does not free memory.
1978 // Most system calls do not free the memory.
1979 return true;
Anna Zaks66c40402012-02-14 21:55:24 +00001980}
1981
Anna Zaks41988f32013-03-28 23:15:29 +00001982static bool retTrue(const RefState *RS) {
1983 return true;
1984}
1985
1986static bool checkIfNewOrNewArrayFamily(const RefState *RS) {
1987 return (RS->getAllocationFamily() == AF_CXXNewArray ||
1988 RS->getAllocationFamily() == AF_CXXNew);
1989}
1990
Anna Zaksbf53dfa2012-12-20 00:38:25 +00001991ProgramStateRef MallocChecker::checkPointerEscape(ProgramStateRef State,
1992 const InvalidatedSymbols &Escaped,
Anna Zaks233e26a2013-02-07 23:05:43 +00001993 const CallEvent *Call,
1994 PointerEscapeKind Kind) const {
Anna Zaks41988f32013-03-28 23:15:29 +00001995 return checkPointerEscapeAux(State, Escaped, Call, Kind, &retTrue);
1996}
1997
1998ProgramStateRef MallocChecker::checkConstPointerEscape(ProgramStateRef State,
1999 const InvalidatedSymbols &Escaped,
2000 const CallEvent *Call,
2001 PointerEscapeKind Kind) const {
2002 return checkPointerEscapeAux(State, Escaped, Call, Kind,
2003 &checkIfNewOrNewArrayFamily);
2004}
2005
2006ProgramStateRef MallocChecker::checkPointerEscapeAux(ProgramStateRef State,
2007 const InvalidatedSymbols &Escaped,
2008 const CallEvent *Call,
2009 PointerEscapeKind Kind,
2010 bool(*CheckRefState)(const RefState*)) const {
Jordan Rose9fe09f32013-03-09 00:59:10 +00002011 // If we know that the call does not free memory, or we want to process the
2012 // call later, keep tracking the top level arguments.
Anna Zaks233e26a2013-02-07 23:05:43 +00002013 if ((Kind == PSK_DirectEscapeOnCall ||
2014 Kind == PSK_IndirectEscapeOnCall) &&
Jordan Rose9fe09f32013-03-09 00:59:10 +00002015 doesNotFreeMemOrInteresting(Call, State)) {
Anna Zaks66c40402012-02-14 21:55:24 +00002016 return State;
Anna Zaks233e26a2013-02-07 23:05:43 +00002017 }
Anna Zaks66c40402012-02-14 21:55:24 +00002018
Anna Zaksbf53dfa2012-12-20 00:38:25 +00002019 for (InvalidatedSymbols::const_iterator I = Escaped.begin(),
Anna Zaks41988f32013-03-28 23:15:29 +00002020 E = Escaped.end();
2021 I != E; ++I) {
Anna Zaks4fb54872012-02-11 21:02:35 +00002022 SymbolRef sym = *I;
Anna Zaksbf53dfa2012-12-20 00:38:25 +00002023
Anna Zaks5b7aa342012-06-22 02:04:31 +00002024 if (const RefState *RS = State->get<RegionState>(sym)) {
Anna Zaks04130232013-04-09 00:30:28 +00002025 if (RS->isAllocated() && CheckRefState(RS)) {
Anna Zaks431e35c2012-08-09 00:42:24 +00002026 State = State->remove<RegionState>(sym);
Anna Zaks04130232013-04-09 00:30:28 +00002027 State = State->set<RegionState>(sym, RefState::getEscaped(RS));
2028 }
Anna Zaks5b7aa342012-06-22 02:04:31 +00002029 }
Anna Zaks4fb54872012-02-11 21:02:35 +00002030 }
Anna Zaks66c40402012-02-14 21:55:24 +00002031 return State;
Ted Kremenekdd0e4902010-07-31 01:52:11 +00002032}
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +00002033
Jordy Rose393f98b2012-03-18 07:43:35 +00002034static SymbolRef findFailedReallocSymbol(ProgramStateRef currState,
2035 ProgramStateRef prevState) {
Jordan Rose166d5022012-11-02 01:54:06 +00002036 ReallocPairsTy currMap = currState->get<ReallocPairs>();
2037 ReallocPairsTy prevMap = prevState->get<ReallocPairs>();
Jordy Rose393f98b2012-03-18 07:43:35 +00002038
Jordan Rose166d5022012-11-02 01:54:06 +00002039 for (ReallocPairsTy::iterator I = prevMap.begin(), E = prevMap.end();
Jordy Rose393f98b2012-03-18 07:43:35 +00002040 I != E; ++I) {
2041 SymbolRef sym = I.getKey();
2042 if (!currMap.lookup(sym))
2043 return sym;
2044 }
2045
2046 return NULL;
2047}
2048
Anna Zaksff3b9fd2012-02-09 06:25:51 +00002049PathDiagnosticPiece *
2050MallocChecker::MallocBugVisitor::VisitNode(const ExplodedNode *N,
2051 const ExplodedNode *PrevN,
2052 BugReporterContext &BRC,
2053 BugReport &BR) {
Jordy Rose393f98b2012-03-18 07:43:35 +00002054 ProgramStateRef state = N->getState();
2055 ProgramStateRef statePrev = PrevN->getState();
2056
2057 const RefState *RS = state->get<RegionState>(Sym);
2058 const RefState *RSPrev = statePrev->get<RegionState>(Sym);
Anna Zaksede875b2012-08-03 18:30:18 +00002059 if (!RS)
Anna Zaksff3b9fd2012-02-09 06:25:51 +00002060 return 0;
2061
Anna Zaksfe571602012-02-16 22:26:07 +00002062 const Stmt *S = 0;
2063 const char *Msg = 0;
Anna Zaks56a938f2012-03-16 23:24:20 +00002064 StackHintGeneratorForSymbol *StackHint = 0;
Anna Zaksfe571602012-02-16 22:26:07 +00002065
2066 // Retrieve the associated statement.
2067 ProgramPoint ProgLoc = N->getLocation();
David Blaikie7a95de62013-02-21 22:23:56 +00002068 if (Optional<StmtPoint> SP = ProgLoc.getAs<StmtPoint>()) {
Jordan Rose852aa0d2012-07-10 22:07:52 +00002069 S = SP->getStmt();
David Blaikie7a95de62013-02-21 22:23:56 +00002070 } else if (Optional<CallExitEnd> Exit = ProgLoc.getAs<CallExitEnd>()) {
Jordan Rose852aa0d2012-07-10 22:07:52 +00002071 S = Exit->getCalleeContext()->getCallSite();
David Blaikie7a95de62013-02-21 22:23:56 +00002072 } else if (Optional<BlockEdge> Edge = ProgLoc.getAs<BlockEdge>()) {
Ted Kremeneka4a17592013-01-04 19:04:36 +00002073 // If an assumption was made on a branch, it should be caught
2074 // here by looking at the state transition.
2075 S = Edge->getSrc()->getTerminator();
Anna Zaksfe571602012-02-16 22:26:07 +00002076 }
Ted Kremeneka4a17592013-01-04 19:04:36 +00002077
Anna Zaksfe571602012-02-16 22:26:07 +00002078 if (!S)
Anna Zaksff3b9fd2012-02-09 06:25:51 +00002079 return 0;
Anna Zaksff3b9fd2012-02-09 06:25:51 +00002080
Jordan Rose28038f32012-07-10 22:07:42 +00002081 // FIXME: We will eventually need to handle non-statement-based events
2082 // (__attribute__((cleanup))).
2083
Anna Zaksff3b9fd2012-02-09 06:25:51 +00002084 // Find out if this is an interesting point and what is the kind.
Anna Zaksfe571602012-02-16 22:26:07 +00002085 if (Mode == Normal) {
Anna Zaks368a0d52012-03-15 21:13:02 +00002086 if (isAllocated(RS, RSPrev, S)) {
Anna Zaksfe571602012-02-16 22:26:07 +00002087 Msg = "Memory is allocated";
Anna Zaksfbd58742012-03-16 23:44:28 +00002088 StackHint = new StackHintGeneratorForSymbol(Sym,
2089 "Returned allocated memory");
Anna Zaks368a0d52012-03-15 21:13:02 +00002090 } else if (isReleased(RS, RSPrev, S)) {
Anna Zaksfe571602012-02-16 22:26:07 +00002091 Msg = "Memory is released";
Anna Zaksfbd58742012-03-16 23:44:28 +00002092 StackHint = new StackHintGeneratorForSymbol(Sym,
2093 "Returned released memory");
Anna Zaks5b7aa342012-06-22 02:04:31 +00002094 } else if (isRelinquished(RS, RSPrev, S)) {
2095 Msg = "Memory ownership is transfered";
2096 StackHint = new StackHintGeneratorForSymbol(Sym, "");
Anna Zaks368a0d52012-03-15 21:13:02 +00002097 } else if (isReallocFailedCheck(RS, RSPrev, S)) {
Anna Zaksfe571602012-02-16 22:26:07 +00002098 Mode = ReallocationFailed;
2099 Msg = "Reallocation failed";
Anna Zaks56a938f2012-03-16 23:24:20 +00002100 StackHint = new StackHintGeneratorForReallocationFailed(Sym,
Anna Zaksfbd58742012-03-16 23:44:28 +00002101 "Reallocation failed");
Jordy Rose393f98b2012-03-18 07:43:35 +00002102
Jordy Roseb000fb52012-03-24 03:15:09 +00002103 if (SymbolRef sym = findFailedReallocSymbol(state, statePrev)) {
2104 // Is it possible to fail two reallocs WITHOUT testing in between?
2105 assert((!FailedReallocSymbol || FailedReallocSymbol == sym) &&
2106 "We only support one failed realloc at a time.");
Jordy Rose393f98b2012-03-18 07:43:35 +00002107 BR.markInteresting(sym);
Jordy Roseb000fb52012-03-24 03:15:09 +00002108 FailedReallocSymbol = sym;
2109 }
Anna Zaksfe571602012-02-16 22:26:07 +00002110 }
2111
2112 // We are in a special mode if a reallocation failed later in the path.
2113 } else if (Mode == ReallocationFailed) {
Jordy Roseb000fb52012-03-24 03:15:09 +00002114 assert(FailedReallocSymbol && "No symbol to look for.");
Anna Zaksfe571602012-02-16 22:26:07 +00002115
Jordy Roseb000fb52012-03-24 03:15:09 +00002116 // Is this is the first appearance of the reallocated symbol?
2117 if (!statePrev->get<RegionState>(FailedReallocSymbol)) {
Jordy Roseb000fb52012-03-24 03:15:09 +00002118 // We're at the reallocation point.
2119 Msg = "Attempt to reallocate memory";
2120 StackHint = new StackHintGeneratorForSymbol(Sym,
2121 "Returned reallocated memory");
2122 FailedReallocSymbol = NULL;
2123 Mode = Normal;
2124 }
Anna Zaksfe571602012-02-16 22:26:07 +00002125 }
2126
Anna Zaksff3b9fd2012-02-09 06:25:51 +00002127 if (!Msg)
2128 return 0;
Anna Zaks56a938f2012-03-16 23:24:20 +00002129 assert(StackHint);
Anna Zaksff3b9fd2012-02-09 06:25:51 +00002130
2131 // Generate the extra diagnostic.
Anna Zaksfe571602012-02-16 22:26:07 +00002132 PathDiagnosticLocation Pos(S, BRC.getSourceManager(),
Anna Zaksff3b9fd2012-02-09 06:25:51 +00002133 N->getLocationContext());
Anna Zaks56a938f2012-03-16 23:24:20 +00002134 return new PathDiagnosticEventPiece(Pos, Msg, true, StackHint);
Anna Zaksff3b9fd2012-02-09 06:25:51 +00002135}
2136
Anna Zaks93c5a242012-05-02 00:05:20 +00002137void MallocChecker::printState(raw_ostream &Out, ProgramStateRef State,
2138 const char *NL, const char *Sep) const {
2139
2140 RegionStateTy RS = State->get<RegionState>();
2141
Ted Kremenekc37fad62013-01-03 01:30:12 +00002142 if (!RS.isEmpty()) {
2143 Out << Sep << "MallocChecker:" << NL;
2144 for (RegionStateTy::iterator I = RS.begin(), E = RS.end(); I != E; ++I) {
2145 I.getKey()->dumpToStream(Out);
2146 Out << " : ";
2147 I.getData().dump(Out);
2148 Out << NL;
2149 }
2150 }
Anna Zaks93c5a242012-05-02 00:05:20 +00002151}
Anna Zaksff3b9fd2012-02-09 06:25:51 +00002152
Anna Zaks231361a2012-02-08 23:16:52 +00002153#define REGISTER_CHECKER(name) \
2154void ento::register##name(CheckerManager &mgr) {\
Anna Zaksf0dfc9c2012-02-17 22:35:31 +00002155 registerCStringCheckerBasic(mgr); \
Anna Zaks231361a2012-02-08 23:16:52 +00002156 mgr.registerChecker<MallocChecker>()->Filter.C##name = true;\
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +00002157}
Anna Zaks231361a2012-02-08 23:16:52 +00002158
2159REGISTER_CHECKER(MallocPessimistic)
2160REGISTER_CHECKER(MallocOptimistic)
Anton Yartsev2de19ed2013-03-25 01:35:45 +00002161REGISTER_CHECKER(NewDeleteChecker)
Jordan Rosee85deb32013-04-05 17:55:00 +00002162REGISTER_CHECKER(NewDeleteLeaksChecker)
Anton Yartsev849c7bf2013-03-28 17:05:19 +00002163REGISTER_CHECKER(MismatchedDeallocatorChecker)