blob: f1e501651e2a657ee949786d49641a0bd90bca54 [file] [log] [blame]
Chris Lattner59907c42007-08-10 20:18:51 +00001//===--- SemaChecking.cpp - Extra Semantic Checking -----------------------===//
2//
3// The LLVM Compiler Infrastructure
4//
Chris Lattner0bc735f2007-12-29 19:59:25 +00005// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
Chris Lattner59907c42007-08-10 20:18:51 +00007//
8//===----------------------------------------------------------------------===//
9//
Mike Stump1eb44332009-09-09 15:08:12 +000010// This file implements extra semantic analysis beyond what is enforced
Chris Lattner59907c42007-08-10 20:18:51 +000011// by the C type system.
12//
13//===----------------------------------------------------------------------===//
14
15#include "Sema.h"
Ted Kremenek826a3452010-07-16 02:11:22 +000016#include "clang/Analysis/Analyses/FormatString.h"
Chris Lattner59907c42007-08-10 20:18:51 +000017#include "clang/AST/ASTContext.h"
Ken Dyck199c3d62010-01-11 17:06:35 +000018#include "clang/AST/CharUnits.h"
Daniel Dunbarc4a1dea2008-08-11 05:35:13 +000019#include "clang/AST/DeclObjC.h"
Ted Kremenek23245122007-08-20 16:18:38 +000020#include "clang/AST/ExprCXX.h"
Ted Kremenek7ff22b22008-06-16 18:00:42 +000021#include "clang/AST/ExprObjC.h"
Mike Stumpf8c49212010-01-21 03:59:47 +000022#include "clang/AST/DeclObjC.h"
23#include "clang/AST/StmtCXX.h"
24#include "clang/AST/StmtObjC.h"
Chris Lattner719e6152009-02-18 19:21:10 +000025#include "clang/Lex/LiteralSupport.h"
Chris Lattner59907c42007-08-10 20:18:51 +000026#include "clang/Lex/Preprocessor.h"
Mike Stumpf8c49212010-01-21 03:59:47 +000027#include "llvm/ADT/BitVector.h"
28#include "llvm/ADT/STLExtras.h"
Nate Begeman0d15c532010-06-13 04:47:52 +000029#include "llvm/ADT/StringExtras.h"
Tom Care3bfc5f42010-06-09 04:11:11 +000030#include "llvm/Support/raw_ostream.h"
Eric Christopher691ebc32010-04-17 02:26:23 +000031#include "clang/Basic/TargetBuiltins.h"
Nate Begeman26a31422010-06-08 02:47:44 +000032#include "clang/Basic/TargetInfo.h"
Zhongxing Xua1f3dba2009-05-20 01:55:10 +000033#include <limits>
Chris Lattner59907c42007-08-10 20:18:51 +000034using namespace clang;
35
Chris Lattner60800082009-02-18 17:49:48 +000036/// getLocationOfStringLiteralByte - Return a source location that points to the
37/// specified byte of the specified string literal.
38///
39/// Strings are amazingly complex. They can be formed from multiple tokens and
40/// can have escape sequences in them in addition to the usual trigraph and
41/// escaped newline business. This routine handles this complexity.
42///
43SourceLocation Sema::getLocationOfStringLiteralByte(const StringLiteral *SL,
44 unsigned ByteNo) const {
45 assert(!SL->isWide() && "This doesn't work for wide strings yet");
Mike Stump1eb44332009-09-09 15:08:12 +000046
Chris Lattner60800082009-02-18 17:49:48 +000047 // Loop over all of the tokens in this string until we find the one that
48 // contains the byte we're looking for.
49 unsigned TokNo = 0;
50 while (1) {
51 assert(TokNo < SL->getNumConcatenated() && "Invalid byte number!");
52 SourceLocation StrTokLoc = SL->getStrTokenLoc(TokNo);
Mike Stump1eb44332009-09-09 15:08:12 +000053
Chris Lattner60800082009-02-18 17:49:48 +000054 // Get the spelling of the string so that we can get the data that makes up
55 // the string literal, not the identifier for the macro it is potentially
56 // expanded through.
57 SourceLocation StrTokSpellingLoc = SourceMgr.getSpellingLoc(StrTokLoc);
58
59 // Re-lex the token to get its length and original spelling.
60 std::pair<FileID, unsigned> LocInfo =
61 SourceMgr.getDecomposedLoc(StrTokSpellingLoc);
Douglas Gregorf715ca12010-03-16 00:06:06 +000062 bool Invalid = false;
Benjamin Kramerf6ac97b2010-03-16 14:14:31 +000063 llvm::StringRef Buffer = SourceMgr.getBufferData(LocInfo.first, &Invalid);
Douglas Gregorf715ca12010-03-16 00:06:06 +000064 if (Invalid)
Douglas Gregoraea67db2010-03-15 22:54:52 +000065 return StrTokSpellingLoc;
66
Benjamin Kramerf6ac97b2010-03-16 14:14:31 +000067 const char *StrData = Buffer.data()+LocInfo.second;
Mike Stump1eb44332009-09-09 15:08:12 +000068
Chris Lattner60800082009-02-18 17:49:48 +000069 // Create a langops struct and enable trigraphs. This is sufficient for
70 // relexing tokens.
71 LangOptions LangOpts;
72 LangOpts.Trigraphs = true;
Mike Stump1eb44332009-09-09 15:08:12 +000073
Chris Lattner60800082009-02-18 17:49:48 +000074 // Create a lexer starting at the beginning of this token.
Benjamin Kramerf6ac97b2010-03-16 14:14:31 +000075 Lexer TheLexer(StrTokSpellingLoc, LangOpts, Buffer.begin(), StrData,
76 Buffer.end());
Chris Lattner60800082009-02-18 17:49:48 +000077 Token TheTok;
78 TheLexer.LexFromRawLexer(TheTok);
Mike Stump1eb44332009-09-09 15:08:12 +000079
Chris Lattner443e53c2009-02-18 19:26:42 +000080 // Use the StringLiteralParser to compute the length of the string in bytes.
Douglas Gregorb90f4b32010-05-26 05:35:51 +000081 StringLiteralParser SLP(&TheTok, 1, PP, /*Complain=*/false);
Chris Lattner443e53c2009-02-18 19:26:42 +000082 unsigned TokNumBytes = SLP.GetStringLength();
Mike Stump1eb44332009-09-09 15:08:12 +000083
Chris Lattner2197c962009-02-18 18:52:52 +000084 // If the byte is in this token, return the location of the byte.
Chris Lattner60800082009-02-18 17:49:48 +000085 if (ByteNo < TokNumBytes ||
86 (ByteNo == TokNumBytes && TokNo == SL->getNumConcatenated())) {
Mike Stump1eb44332009-09-09 15:08:12 +000087 unsigned Offset =
Douglas Gregorb90f4b32010-05-26 05:35:51 +000088 StringLiteralParser::getOffsetOfStringByte(TheTok, ByteNo, PP,
89 /*Complain=*/false);
Mike Stump1eb44332009-09-09 15:08:12 +000090
Chris Lattner719e6152009-02-18 19:21:10 +000091 // Now that we know the offset of the token in the spelling, use the
92 // preprocessor to get the offset in the original source.
93 return PP.AdvanceToTokenCharacter(StrTokLoc, Offset);
Chris Lattner60800082009-02-18 17:49:48 +000094 }
Mike Stump1eb44332009-09-09 15:08:12 +000095
Chris Lattner60800082009-02-18 17:49:48 +000096 // Move to the next string token.
97 ++TokNo;
98 ByteNo -= TokNumBytes;
99 }
100}
101
Ryan Flynn4403a5e2009-08-06 03:00:50 +0000102/// CheckablePrintfAttr - does a function call have a "printf" attribute
103/// and arguments that merit checking?
104bool Sema::CheckablePrintfAttr(const FormatAttr *Format, CallExpr *TheCall) {
105 if (Format->getType() == "printf") return true;
106 if (Format->getType() == "printf0") {
107 // printf0 allows null "format" string; if so don't check format/args
108 unsigned format_idx = Format->getFormatIdx() - 1;
Sebastian Redl4a2614e2009-11-17 18:02:24 +0000109 // Does the index refer to the implicit object argument?
110 if (isa<CXXMemberCallExpr>(TheCall)) {
111 if (format_idx == 0)
112 return false;
113 --format_idx;
114 }
Ryan Flynn4403a5e2009-08-06 03:00:50 +0000115 if (format_idx < TheCall->getNumArgs()) {
116 Expr *Format = TheCall->getArg(format_idx)->IgnoreParenCasts();
Ted Kremenekefaff192010-02-27 01:41:03 +0000117 if (!Format->isNullPointerConstant(Context,
118 Expr::NPC_ValueDependentIsNull))
Ryan Flynn4403a5e2009-08-06 03:00:50 +0000119 return true;
120 }
121 }
122 return false;
123}
Chris Lattner60800082009-02-18 17:49:48 +0000124
Sebastian Redl0eb23302009-01-19 00:08:26 +0000125Action::OwningExprResult
Anders Carlssond406bf02009-08-16 01:56:34 +0000126Sema::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
Sebastian Redl0eb23302009-01-19 00:08:26 +0000127 OwningExprResult TheCallResult(Owned(TheCall));
Douglas Gregor2def4832008-11-17 20:34:05 +0000128
Anders Carlssond406bf02009-08-16 01:56:34 +0000129 switch (BuiltinID) {
Chris Lattner30ce3442007-12-19 23:59:04 +0000130 case Builtin::BI__builtin___CFStringMakeConstantString:
Chris Lattner925e60d2007-12-28 05:29:59 +0000131 assert(TheCall->getNumArgs() == 1 &&
Chris Lattner1b9a0792007-12-20 00:26:33 +0000132 "Wrong # arguments to builtin CFStringMakeConstantString");
Chris Lattner69039812009-02-18 06:01:06 +0000133 if (CheckObjCString(TheCall->getArg(0)))
Sebastian Redl0eb23302009-01-19 00:08:26 +0000134 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000135 break;
Ted Kremenek49ff7a12008-07-09 17:58:53 +0000136 case Builtin::BI__builtin_stdarg_start:
Chris Lattner30ce3442007-12-19 23:59:04 +0000137 case Builtin::BI__builtin_va_start:
Sebastian Redl0eb23302009-01-19 00:08:26 +0000138 if (SemaBuiltinVAStart(TheCall))
139 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000140 break;
Chris Lattner1b9a0792007-12-20 00:26:33 +0000141 case Builtin::BI__builtin_isgreater:
142 case Builtin::BI__builtin_isgreaterequal:
143 case Builtin::BI__builtin_isless:
144 case Builtin::BI__builtin_islessequal:
145 case Builtin::BI__builtin_islessgreater:
146 case Builtin::BI__builtin_isunordered:
Sebastian Redl0eb23302009-01-19 00:08:26 +0000147 if (SemaBuiltinUnorderedCompare(TheCall))
148 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000149 break;
Benjamin Kramere771a7a2010-02-15 22:42:31 +0000150 case Builtin::BI__builtin_fpclassify:
151 if (SemaBuiltinFPClassification(TheCall, 6))
152 return ExprError();
153 break;
Eli Friedman9ac6f622009-08-31 20:06:00 +0000154 case Builtin::BI__builtin_isfinite:
155 case Builtin::BI__builtin_isinf:
156 case Builtin::BI__builtin_isinf_sign:
157 case Builtin::BI__builtin_isnan:
158 case Builtin::BI__builtin_isnormal:
Benjamin Kramer3b1e26b2010-02-16 10:07:31 +0000159 if (SemaBuiltinFPClassification(TheCall, 1))
Eli Friedman9ac6f622009-08-31 20:06:00 +0000160 return ExprError();
161 break;
Eli Friedman6cfda232008-05-20 08:23:37 +0000162 case Builtin::BI__builtin_return_address:
Eric Christopher691ebc32010-04-17 02:26:23 +0000163 case Builtin::BI__builtin_frame_address: {
164 llvm::APSInt Result;
165 if (SemaBuiltinConstantArg(TheCall, 0, Result))
Sebastian Redl0eb23302009-01-19 00:08:26 +0000166 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000167 break;
Eric Christopher691ebc32010-04-17 02:26:23 +0000168 }
169 case Builtin::BI__builtin_eh_return_data_regno: {
170 llvm::APSInt Result;
171 if (SemaBuiltinConstantArg(TheCall, 0, Result))
Chris Lattner21fb98e2009-09-23 06:06:36 +0000172 return ExprError();
173 break;
Eric Christopher691ebc32010-04-17 02:26:23 +0000174 }
Eli Friedmand38617c2008-05-14 19:38:39 +0000175 case Builtin::BI__builtin_shufflevector:
Sebastian Redl0eb23302009-01-19 00:08:26 +0000176 return SemaBuiltinShuffleVector(TheCall);
177 // TheCall will be freed by the smart pointer here, but that's fine, since
178 // SemaBuiltinShuffleVector guts it, but then doesn't release it.
Daniel Dunbar4493f792008-07-21 22:59:13 +0000179 case Builtin::BI__builtin_prefetch:
Sebastian Redl0eb23302009-01-19 00:08:26 +0000180 if (SemaBuiltinPrefetch(TheCall))
181 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000182 break;
Daniel Dunbard5f8a4f2008-09-03 21:13:56 +0000183 case Builtin::BI__builtin_object_size:
Sebastian Redl0eb23302009-01-19 00:08:26 +0000184 if (SemaBuiltinObjectSize(TheCall))
185 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000186 break;
Eli Friedmand875fed2009-05-03 04:46:36 +0000187 case Builtin::BI__builtin_longjmp:
188 if (SemaBuiltinLongjmp(TheCall))
189 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000190 break;
Chris Lattner5caa3702009-05-08 06:58:22 +0000191 case Builtin::BI__sync_fetch_and_add:
192 case Builtin::BI__sync_fetch_and_sub:
193 case Builtin::BI__sync_fetch_and_or:
194 case Builtin::BI__sync_fetch_and_and:
195 case Builtin::BI__sync_fetch_and_xor:
196 case Builtin::BI__sync_add_and_fetch:
197 case Builtin::BI__sync_sub_and_fetch:
198 case Builtin::BI__sync_and_and_fetch:
199 case Builtin::BI__sync_or_and_fetch:
200 case Builtin::BI__sync_xor_and_fetch:
201 case Builtin::BI__sync_val_compare_and_swap:
202 case Builtin::BI__sync_bool_compare_and_swap:
203 case Builtin::BI__sync_lock_test_and_set:
204 case Builtin::BI__sync_lock_release:
Chandler Carruthd2014572010-07-09 18:59:35 +0000205 return SemaBuiltinAtomicOverloaded(move(TheCallResult));
Nate Begeman26a31422010-06-08 02:47:44 +0000206 }
207
208 // Since the target specific builtins for each arch overlap, only check those
209 // of the arch we are compiling for.
210 if (BuiltinID >= Builtin::FirstTSBuiltin) {
211 switch (Context.Target.getTriple().getArch()) {
212 case llvm::Triple::arm:
213 case llvm::Triple::thumb:
214 if (CheckARMBuiltinFunctionCall(BuiltinID, TheCall))
215 return ExprError();
216 break;
217 case llvm::Triple::x86:
218 case llvm::Triple::x86_64:
219 if (CheckX86BuiltinFunctionCall(BuiltinID, TheCall))
220 return ExprError();
221 break;
222 default:
223 break;
224 }
225 }
226
227 return move(TheCallResult);
228}
229
230bool Sema::CheckX86BuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
231 switch (BuiltinID) {
Eric Christopher691ebc32010-04-17 02:26:23 +0000232 case X86::BI__builtin_ia32_palignr128:
233 case X86::BI__builtin_ia32_palignr: {
234 llvm::APSInt Result;
235 if (SemaBuiltinConstantArg(TheCall, 2, Result))
Nate Begeman26a31422010-06-08 02:47:44 +0000236 return true;
Eric Christopher691ebc32010-04-17 02:26:23 +0000237 break;
238 }
Anders Carlsson71993dd2007-08-17 05:31:46 +0000239 }
Nate Begeman26a31422010-06-08 02:47:44 +0000240 return false;
241}
Mike Stump1eb44332009-09-09 15:08:12 +0000242
Nate Begeman61eecf52010-06-14 05:21:25 +0000243// Get the valid immediate range for the specified NEON type code.
244static unsigned RFT(unsigned t, bool shift = false) {
245 bool quad = t & 0x10;
246
247 switch (t & 0x7) {
248 case 0: // i8
Nate Begemand69ec162010-06-17 02:26:59 +0000249 return shift ? 7 : (8 << (int)quad) - 1;
Nate Begeman61eecf52010-06-14 05:21:25 +0000250 case 1: // i16
Nate Begemand69ec162010-06-17 02:26:59 +0000251 return shift ? 15 : (4 << (int)quad) - 1;
Nate Begeman61eecf52010-06-14 05:21:25 +0000252 case 2: // i32
Nate Begemand69ec162010-06-17 02:26:59 +0000253 return shift ? 31 : (2 << (int)quad) - 1;
Nate Begeman61eecf52010-06-14 05:21:25 +0000254 case 3: // i64
Nate Begemand69ec162010-06-17 02:26:59 +0000255 return shift ? 63 : (1 << (int)quad) - 1;
Nate Begeman61eecf52010-06-14 05:21:25 +0000256 case 4: // f32
257 assert(!shift && "cannot shift float types!");
Nate Begemand69ec162010-06-17 02:26:59 +0000258 return (2 << (int)quad) - 1;
Nate Begeman61eecf52010-06-14 05:21:25 +0000259 case 5: // poly8
260 assert(!shift && "cannot shift polynomial types!");
Nate Begemand69ec162010-06-17 02:26:59 +0000261 return (8 << (int)quad) - 1;
Nate Begeman61eecf52010-06-14 05:21:25 +0000262 case 6: // poly16
263 assert(!shift && "cannot shift polynomial types!");
Nate Begemand69ec162010-06-17 02:26:59 +0000264 return (4 << (int)quad) - 1;
Nate Begeman61eecf52010-06-14 05:21:25 +0000265 case 7: // float16
266 assert(!shift && "cannot shift float types!");
Nate Begemand69ec162010-06-17 02:26:59 +0000267 return (4 << (int)quad) - 1;
Nate Begeman61eecf52010-06-14 05:21:25 +0000268 }
269 return 0;
270}
271
Nate Begeman26a31422010-06-08 02:47:44 +0000272bool Sema::CheckARMBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
Nate Begeman1c2a88c2010-06-09 01:10:23 +0000273 llvm::APSInt Result;
274
Nate Begeman0d15c532010-06-13 04:47:52 +0000275 unsigned mask = 0;
Nate Begeman61eecf52010-06-14 05:21:25 +0000276 unsigned TV = 0;
Nate Begeman1c2a88c2010-06-09 01:10:23 +0000277 switch (BuiltinID) {
Nate Begemana23326b2010-06-17 04:17:01 +0000278#define GET_NEON_OVERLOAD_CHECK
279#include "clang/Basic/arm_neon.inc"
280#undef GET_NEON_OVERLOAD_CHECK
Nate Begeman1c2a88c2010-06-09 01:10:23 +0000281 }
282
Nate Begeman0d15c532010-06-13 04:47:52 +0000283 // For NEON intrinsics which are overloaded on vector element type, validate
284 // the immediate which specifies which variant to emit.
285 if (mask) {
286 unsigned ArgNo = TheCall->getNumArgs()-1;
287 if (SemaBuiltinConstantArg(TheCall, ArgNo, Result))
288 return true;
289
Nate Begeman61eecf52010-06-14 05:21:25 +0000290 TV = Result.getLimitedValue(32);
291 if ((TV > 31) || (mask & (1 << TV)) == 0)
Nate Begeman0d15c532010-06-13 04:47:52 +0000292 return Diag(TheCall->getLocStart(), diag::err_invalid_neon_type_code)
293 << TheCall->getArg(ArgNo)->getSourceRange();
294 }
Nate Begeman1c2a88c2010-06-09 01:10:23 +0000295
Nate Begeman0d15c532010-06-13 04:47:52 +0000296 // For NEON intrinsics which take an immediate value as part of the
297 // instruction, range check them here.
Nate Begeman61eecf52010-06-14 05:21:25 +0000298 unsigned i = 0, l = 0, u = 0;
Nate Begeman0d15c532010-06-13 04:47:52 +0000299 switch (BuiltinID) {
300 default: return false;
Nate Begemana23326b2010-06-17 04:17:01 +0000301#define GET_NEON_IMMEDIATE_CHECK
302#include "clang/Basic/arm_neon.inc"
303#undef GET_NEON_IMMEDIATE_CHECK
Nate Begeman0d15c532010-06-13 04:47:52 +0000304 };
305
Nate Begeman61eecf52010-06-14 05:21:25 +0000306 // Check that the immediate argument is actually a constant.
Nate Begeman0d15c532010-06-13 04:47:52 +0000307 if (SemaBuiltinConstantArg(TheCall, i, Result))
308 return true;
309
Nate Begeman61eecf52010-06-14 05:21:25 +0000310 // Range check against the upper/lower values for this isntruction.
Nate Begeman0d15c532010-06-13 04:47:52 +0000311 unsigned Val = Result.getZExtValue();
Nate Begeman61eecf52010-06-14 05:21:25 +0000312 if (Val < l || Val > (u + l))
Nate Begeman0d15c532010-06-13 04:47:52 +0000313 return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
Nate Begeman61eecf52010-06-14 05:21:25 +0000314 << llvm::utostr(l) << llvm::utostr(u+l)
315 << TheCall->getArg(i)->getSourceRange();
Nate Begeman0d15c532010-06-13 04:47:52 +0000316
Nate Begeman26a31422010-06-08 02:47:44 +0000317 return false;
Anders Carlssond406bf02009-08-16 01:56:34 +0000318}
Daniel Dunbarde454282008-10-02 18:44:07 +0000319
Anders Carlssond406bf02009-08-16 01:56:34 +0000320/// CheckFunctionCall - Check a direct function call for various correctness
321/// and safety properties not strictly enforced by the C type system.
322bool Sema::CheckFunctionCall(FunctionDecl *FDecl, CallExpr *TheCall) {
323 // Get the IdentifierInfo* for the called function.
324 IdentifierInfo *FnInfo = FDecl->getIdentifier();
325
326 // None of the checks below are needed for functions that don't have
327 // simple names (e.g., C++ conversion functions).
328 if (!FnInfo)
329 return false;
Mike Stump1eb44332009-09-09 15:08:12 +0000330
Daniel Dunbarde454282008-10-02 18:44:07 +0000331 // FIXME: This mechanism should be abstracted to be less fragile and
332 // more efficient. For example, just map function ids to custom
333 // handlers.
334
Chris Lattner59907c42007-08-10 20:18:51 +0000335 // Printf checking.
Argyrios Kyrtzidis40b598e2009-06-30 02:34:44 +0000336 if (const FormatAttr *Format = FDecl->getAttr<FormatAttr>()) {
Ted Kremenek826a3452010-07-16 02:11:22 +0000337 const bool b = Format->getType() == "scanf";
338 if (b || CheckablePrintfAttr(Format, TheCall)) {
Ted Kremenek3d692df2009-02-27 17:58:43 +0000339 bool HasVAListArg = Format->getFirstArg() == 0;
Ted Kremenek826a3452010-07-16 02:11:22 +0000340 CheckPrintfScanfArguments(TheCall, HasVAListArg,
341 Format->getFormatIdx() - 1,
342 HasVAListArg ? 0 : Format->getFirstArg() - 1,
343 !b);
Douglas Gregor3c385e52009-02-14 18:57:46 +0000344 }
Chris Lattner59907c42007-08-10 20:18:51 +0000345 }
Mike Stump1eb44332009-09-09 15:08:12 +0000346
347 for (const NonNullAttr *NonNull = FDecl->getAttr<NonNullAttr>(); NonNull;
Anders Carlssond406bf02009-08-16 01:56:34 +0000348 NonNull = NonNull->getNext<NonNullAttr>())
349 CheckNonNullArguments(NonNull, TheCall);
Sebastian Redl0eb23302009-01-19 00:08:26 +0000350
Anders Carlssond406bf02009-08-16 01:56:34 +0000351 return false;
Anders Carlsson71993dd2007-08-17 05:31:46 +0000352}
353
Anders Carlssond406bf02009-08-16 01:56:34 +0000354bool Sema::CheckBlockCall(NamedDecl *NDecl, CallExpr *TheCall) {
Fariborz Jahanian725165f2009-05-18 21:05:18 +0000355 // Printf checking.
Argyrios Kyrtzidis40b598e2009-06-30 02:34:44 +0000356 const FormatAttr *Format = NDecl->getAttr<FormatAttr>();
Fariborz Jahanian725165f2009-05-18 21:05:18 +0000357 if (!Format)
Anders Carlssond406bf02009-08-16 01:56:34 +0000358 return false;
Mike Stump1eb44332009-09-09 15:08:12 +0000359
Fariborz Jahanian725165f2009-05-18 21:05:18 +0000360 const VarDecl *V = dyn_cast<VarDecl>(NDecl);
361 if (!V)
Anders Carlssond406bf02009-08-16 01:56:34 +0000362 return false;
Mike Stump1eb44332009-09-09 15:08:12 +0000363
Fariborz Jahanian725165f2009-05-18 21:05:18 +0000364 QualType Ty = V->getType();
365 if (!Ty->isBlockPointerType())
Anders Carlssond406bf02009-08-16 01:56:34 +0000366 return false;
Mike Stump1eb44332009-09-09 15:08:12 +0000367
Ted Kremenek826a3452010-07-16 02:11:22 +0000368 const bool b = Format->getType() == "scanf";
369 if (!b && !CheckablePrintfAttr(Format, TheCall))
Anders Carlssond406bf02009-08-16 01:56:34 +0000370 return false;
Mike Stump1eb44332009-09-09 15:08:12 +0000371
Anders Carlssond406bf02009-08-16 01:56:34 +0000372 bool HasVAListArg = Format->getFirstArg() == 0;
Ted Kremenek826a3452010-07-16 02:11:22 +0000373 CheckPrintfScanfArguments(TheCall, HasVAListArg, Format->getFormatIdx() - 1,
374 HasVAListArg ? 0 : Format->getFirstArg() - 1, !b);
Anders Carlssond406bf02009-08-16 01:56:34 +0000375
376 return false;
Fariborz Jahanian725165f2009-05-18 21:05:18 +0000377}
378
Chris Lattner5caa3702009-05-08 06:58:22 +0000379/// SemaBuiltinAtomicOverloaded - We have a call to a function like
380/// __sync_fetch_and_add, which is an overloaded function based on the pointer
381/// type of its first argument. The main ActOnCallExpr routines have already
382/// promoted the types of arguments because all of these calls are prototyped as
383/// void(...).
384///
385/// This function goes through and does final semantic checking for these
386/// builtins,
Chandler Carruthd2014572010-07-09 18:59:35 +0000387Sema::OwningExprResult
388Sema::SemaBuiltinAtomicOverloaded(OwningExprResult TheCallResult) {
389 CallExpr *TheCall = (CallExpr *)TheCallResult.get();
Chris Lattner5caa3702009-05-08 06:58:22 +0000390 DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts());
391 FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl());
392
393 // Ensure that we have at least one argument to do type inference from.
Chandler Carruthd2014572010-07-09 18:59:35 +0000394 if (TheCall->getNumArgs() < 1) {
395 Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least)
396 << 0 << 1 << TheCall->getNumArgs()
397 << TheCall->getCallee()->getSourceRange();
398 return ExprError();
399 }
Mike Stump1eb44332009-09-09 15:08:12 +0000400
Chris Lattner5caa3702009-05-08 06:58:22 +0000401 // Inspect the first argument of the atomic builtin. This should always be
402 // a pointer type, whose element is an integral scalar or pointer type.
403 // Because it is a pointer type, we don't have to worry about any implicit
404 // casts here.
Chandler Carruthd2014572010-07-09 18:59:35 +0000405 // FIXME: We don't allow floating point scalars as input.
Chris Lattner5caa3702009-05-08 06:58:22 +0000406 Expr *FirstArg = TheCall->getArg(0);
Chandler Carruthd2014572010-07-09 18:59:35 +0000407 if (!FirstArg->getType()->isPointerType()) {
408 Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer)
409 << FirstArg->getType() << FirstArg->getSourceRange();
410 return ExprError();
411 }
Mike Stump1eb44332009-09-09 15:08:12 +0000412
Chandler Carruthd2014572010-07-09 18:59:35 +0000413 QualType ValType =
414 FirstArg->getType()->getAs<PointerType>()->getPointeeType();
Mike Stump1eb44332009-09-09 15:08:12 +0000415 if (!ValType->isIntegerType() && !ValType->isPointerType() &&
Chandler Carruthd2014572010-07-09 18:59:35 +0000416 !ValType->isBlockPointerType()) {
417 Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer_intptr)
418 << FirstArg->getType() << FirstArg->getSourceRange();
419 return ExprError();
420 }
Chris Lattner5caa3702009-05-08 06:58:22 +0000421
Chandler Carruth8d13d222010-07-18 20:54:12 +0000422 // The majority of builtins return a value, but a few have special return
423 // types, so allow them to override appropriately below.
424 QualType ResultType = ValType;
425
Chris Lattner5caa3702009-05-08 06:58:22 +0000426 // We need to figure out which concrete builtin this maps onto. For example,
427 // __sync_fetch_and_add with a 2 byte object turns into
428 // __sync_fetch_and_add_2.
429#define BUILTIN_ROW(x) \
430 { Builtin::BI##x##_1, Builtin::BI##x##_2, Builtin::BI##x##_4, \
431 Builtin::BI##x##_8, Builtin::BI##x##_16 }
Mike Stump1eb44332009-09-09 15:08:12 +0000432
Chris Lattner5caa3702009-05-08 06:58:22 +0000433 static const unsigned BuiltinIndices[][5] = {
434 BUILTIN_ROW(__sync_fetch_and_add),
435 BUILTIN_ROW(__sync_fetch_and_sub),
436 BUILTIN_ROW(__sync_fetch_and_or),
437 BUILTIN_ROW(__sync_fetch_and_and),
438 BUILTIN_ROW(__sync_fetch_and_xor),
Mike Stump1eb44332009-09-09 15:08:12 +0000439
Chris Lattner5caa3702009-05-08 06:58:22 +0000440 BUILTIN_ROW(__sync_add_and_fetch),
441 BUILTIN_ROW(__sync_sub_and_fetch),
442 BUILTIN_ROW(__sync_and_and_fetch),
443 BUILTIN_ROW(__sync_or_and_fetch),
444 BUILTIN_ROW(__sync_xor_and_fetch),
Mike Stump1eb44332009-09-09 15:08:12 +0000445
Chris Lattner5caa3702009-05-08 06:58:22 +0000446 BUILTIN_ROW(__sync_val_compare_and_swap),
447 BUILTIN_ROW(__sync_bool_compare_and_swap),
448 BUILTIN_ROW(__sync_lock_test_and_set),
449 BUILTIN_ROW(__sync_lock_release)
450 };
Mike Stump1eb44332009-09-09 15:08:12 +0000451#undef BUILTIN_ROW
452
Chris Lattner5caa3702009-05-08 06:58:22 +0000453 // Determine the index of the size.
454 unsigned SizeIndex;
Ken Dyck199c3d62010-01-11 17:06:35 +0000455 switch (Context.getTypeSizeInChars(ValType).getQuantity()) {
Chris Lattner5caa3702009-05-08 06:58:22 +0000456 case 1: SizeIndex = 0; break;
457 case 2: SizeIndex = 1; break;
458 case 4: SizeIndex = 2; break;
459 case 8: SizeIndex = 3; break;
460 case 16: SizeIndex = 4; break;
461 default:
Chandler Carruthd2014572010-07-09 18:59:35 +0000462 Diag(DRE->getLocStart(), diag::err_atomic_builtin_pointer_size)
463 << FirstArg->getType() << FirstArg->getSourceRange();
464 return ExprError();
Chris Lattner5caa3702009-05-08 06:58:22 +0000465 }
Mike Stump1eb44332009-09-09 15:08:12 +0000466
Chris Lattner5caa3702009-05-08 06:58:22 +0000467 // Each of these builtins has one pointer argument, followed by some number of
468 // values (0, 1 or 2) followed by a potentially empty varags list of stuff
469 // that we ignore. Find out which row of BuiltinIndices to read from as well
470 // as the number of fixed args.
Douglas Gregor7814e6d2009-09-12 00:22:50 +0000471 unsigned BuiltinID = FDecl->getBuiltinID();
Chris Lattner5caa3702009-05-08 06:58:22 +0000472 unsigned BuiltinIndex, NumFixed = 1;
473 switch (BuiltinID) {
474 default: assert(0 && "Unknown overloaded atomic builtin!");
475 case Builtin::BI__sync_fetch_and_add: BuiltinIndex = 0; break;
476 case Builtin::BI__sync_fetch_and_sub: BuiltinIndex = 1; break;
477 case Builtin::BI__sync_fetch_and_or: BuiltinIndex = 2; break;
478 case Builtin::BI__sync_fetch_and_and: BuiltinIndex = 3; break;
479 case Builtin::BI__sync_fetch_and_xor: BuiltinIndex = 4; break;
Mike Stump1eb44332009-09-09 15:08:12 +0000480
Daniel Dunbar7eff7c42010-03-25 17:13:09 +0000481 case Builtin::BI__sync_add_and_fetch: BuiltinIndex = 5; break;
482 case Builtin::BI__sync_sub_and_fetch: BuiltinIndex = 6; break;
483 case Builtin::BI__sync_and_and_fetch: BuiltinIndex = 7; break;
484 case Builtin::BI__sync_or_and_fetch: BuiltinIndex = 8; break;
485 case Builtin::BI__sync_xor_and_fetch: BuiltinIndex = 9; break;
Mike Stump1eb44332009-09-09 15:08:12 +0000486
Chris Lattner5caa3702009-05-08 06:58:22 +0000487 case Builtin::BI__sync_val_compare_and_swap:
Daniel Dunbar7eff7c42010-03-25 17:13:09 +0000488 BuiltinIndex = 10;
Chris Lattner5caa3702009-05-08 06:58:22 +0000489 NumFixed = 2;
490 break;
491 case Builtin::BI__sync_bool_compare_and_swap:
Daniel Dunbar7eff7c42010-03-25 17:13:09 +0000492 BuiltinIndex = 11;
Chris Lattner5caa3702009-05-08 06:58:22 +0000493 NumFixed = 2;
Chandler Carruth8d13d222010-07-18 20:54:12 +0000494 ResultType = Context.BoolTy;
Chris Lattner5caa3702009-05-08 06:58:22 +0000495 break;
Daniel Dunbar7eff7c42010-03-25 17:13:09 +0000496 case Builtin::BI__sync_lock_test_and_set: BuiltinIndex = 12; break;
Chris Lattner5caa3702009-05-08 06:58:22 +0000497 case Builtin::BI__sync_lock_release:
Daniel Dunbar7eff7c42010-03-25 17:13:09 +0000498 BuiltinIndex = 13;
Chris Lattner5caa3702009-05-08 06:58:22 +0000499 NumFixed = 0;
Chandler Carruth8d13d222010-07-18 20:54:12 +0000500 ResultType = Context.VoidTy;
Chris Lattner5caa3702009-05-08 06:58:22 +0000501 break;
502 }
Mike Stump1eb44332009-09-09 15:08:12 +0000503
Chris Lattner5caa3702009-05-08 06:58:22 +0000504 // Now that we know how many fixed arguments we expect, first check that we
505 // have at least that many.
Chandler Carruthd2014572010-07-09 18:59:35 +0000506 if (TheCall->getNumArgs() < 1+NumFixed) {
507 Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least)
508 << 0 << 1+NumFixed << TheCall->getNumArgs()
509 << TheCall->getCallee()->getSourceRange();
510 return ExprError();
511 }
Mike Stump1eb44332009-09-09 15:08:12 +0000512
Chris Lattnere7ac0a92009-05-08 15:36:58 +0000513 // Get the decl for the concrete builtin from this, we can tell what the
514 // concrete integer type we should convert to is.
515 unsigned NewBuiltinID = BuiltinIndices[BuiltinIndex][SizeIndex];
516 const char *NewBuiltinName = Context.BuiltinInfo.GetName(NewBuiltinID);
517 IdentifierInfo *NewBuiltinII = PP.getIdentifierInfo(NewBuiltinName);
Mike Stump1eb44332009-09-09 15:08:12 +0000518 FunctionDecl *NewBuiltinDecl =
Chris Lattnere7ac0a92009-05-08 15:36:58 +0000519 cast<FunctionDecl>(LazilyCreateBuiltin(NewBuiltinII, NewBuiltinID,
520 TUScope, false, DRE->getLocStart()));
Chandler Carruthd2014572010-07-09 18:59:35 +0000521
Chandler Carruthdb4325b2010-07-18 07:23:17 +0000522 // The first argument is by definition correct, we use it's type as the type
523 // of the entire operation. Walk the remaining arguments promoting them to
524 // the deduced value type.
Chris Lattner5caa3702009-05-08 06:58:22 +0000525 for (unsigned i = 0; i != NumFixed; ++i) {
526 Expr *Arg = TheCall->getArg(i+1);
Mike Stump1eb44332009-09-09 15:08:12 +0000527
Chris Lattner5caa3702009-05-08 06:58:22 +0000528 // If the argument is an implicit cast, then there was a promotion due to
529 // "...", just remove it now.
530 if (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Arg)) {
531 Arg = ICE->getSubExpr();
532 ICE->setSubExpr(0);
533 ICE->Destroy(Context);
534 TheCall->setArg(i+1, Arg);
535 }
Mike Stump1eb44332009-09-09 15:08:12 +0000536
Chris Lattner5caa3702009-05-08 06:58:22 +0000537 // GCC does an implicit conversion to the pointer or integer ValType. This
538 // can fail in some cases (1i -> int**), check for this error case now.
Anders Carlssoncdb61972009-08-07 22:21:05 +0000539 CastExpr::CastKind Kind = CastExpr::CK_Unknown;
Anders Carlsson5cf86ba2010-04-24 19:06:50 +0000540 CXXBaseSpecifierArray BasePath;
541 if (CheckCastTypes(Arg->getSourceRange(), ValType, Arg, Kind, BasePath))
Chandler Carruthd2014572010-07-09 18:59:35 +0000542 return ExprError();
Mike Stump1eb44332009-09-09 15:08:12 +0000543
Chris Lattner5caa3702009-05-08 06:58:22 +0000544 // Okay, we have something that *can* be converted to the right type. Check
545 // to see if there is a potentially weird extension going on here. This can
546 // happen when you do an atomic operation on something like an char* and
547 // pass in 42. The 42 gets converted to char. This is even more strange
548 // for things like 45.123 -> char, etc.
Mike Stump1eb44332009-09-09 15:08:12 +0000549 // FIXME: Do this check.
Anders Carlsson80971bd2010-04-24 16:36:20 +0000550 ImpCastExprToType(Arg, ValType, Kind);
Chris Lattner5caa3702009-05-08 06:58:22 +0000551 TheCall->setArg(i+1, Arg);
552 }
Mike Stump1eb44332009-09-09 15:08:12 +0000553
Chris Lattner5caa3702009-05-08 06:58:22 +0000554 // Switch the DeclRefExpr to refer to the new decl.
555 DRE->setDecl(NewBuiltinDecl);
556 DRE->setType(NewBuiltinDecl->getType());
Mike Stump1eb44332009-09-09 15:08:12 +0000557
Chris Lattner5caa3702009-05-08 06:58:22 +0000558 // Set the callee in the CallExpr.
559 // FIXME: This leaks the original parens and implicit casts.
560 Expr *PromotedCall = DRE;
561 UsualUnaryConversions(PromotedCall);
562 TheCall->setCallee(PromotedCall);
Mike Stump1eb44332009-09-09 15:08:12 +0000563
Chandler Carruthdb4325b2010-07-18 07:23:17 +0000564 // Change the result type of the call to match the original value type. This
565 // is arbitrary, but the codegen for these builtins ins design to handle it
566 // gracefully.
Chandler Carruth8d13d222010-07-18 20:54:12 +0000567 TheCall->setType(ResultType);
Chandler Carruthd2014572010-07-09 18:59:35 +0000568
569 return move(TheCallResult);
Chris Lattner5caa3702009-05-08 06:58:22 +0000570}
571
572
Chris Lattner69039812009-02-18 06:01:06 +0000573/// CheckObjCString - Checks that the argument to the builtin
Anders Carlsson71993dd2007-08-17 05:31:46 +0000574/// CFString constructor is correct
Steve Narofffd942622009-04-13 20:26:29 +0000575/// FIXME: GCC currently emits the following warning:
Mike Stump1eb44332009-09-09 15:08:12 +0000576/// "warning: input conversion stopped due to an input byte that does not
Steve Narofffd942622009-04-13 20:26:29 +0000577/// belong to the input codeset UTF-8"
578/// Note: It might also make sense to do the UTF-16 conversion here (would
579/// simplify the backend).
Chris Lattner69039812009-02-18 06:01:06 +0000580bool Sema::CheckObjCString(Expr *Arg) {
Chris Lattner56f34942008-02-13 01:02:39 +0000581 Arg = Arg->IgnoreParenCasts();
Anders Carlsson71993dd2007-08-17 05:31:46 +0000582 StringLiteral *Literal = dyn_cast<StringLiteral>(Arg);
583
584 if (!Literal || Literal->isWide()) {
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000585 Diag(Arg->getLocStart(), diag::err_cfstring_literal_not_string_constant)
586 << Arg->getSourceRange();
Anders Carlsson9cdc4d32007-08-17 15:44:17 +0000587 return true;
Anders Carlsson71993dd2007-08-17 05:31:46 +0000588 }
Mike Stump1eb44332009-09-09 15:08:12 +0000589
Daniel Dunbarf015b032009-09-22 10:03:52 +0000590 const char *Data = Literal->getStrData();
591 unsigned Length = Literal->getByteLength();
Mike Stump1eb44332009-09-09 15:08:12 +0000592
Daniel Dunbarf015b032009-09-22 10:03:52 +0000593 for (unsigned i = 0; i < Length; ++i) {
594 if (!Data[i]) {
595 Diag(getLocationOfStringLiteralByte(Literal, i),
596 diag::warn_cfstring_literal_contains_nul_character)
597 << Arg->getSourceRange();
598 break;
599 }
600 }
Mike Stump1eb44332009-09-09 15:08:12 +0000601
Anders Carlsson9cdc4d32007-08-17 15:44:17 +0000602 return false;
Chris Lattner59907c42007-08-10 20:18:51 +0000603}
604
Chris Lattnerc27c6652007-12-20 00:05:45 +0000605/// SemaBuiltinVAStart - Check the arguments to __builtin_va_start for validity.
606/// Emit an error and return true on failure, return false on success.
Chris Lattner925e60d2007-12-28 05:29:59 +0000607bool Sema::SemaBuiltinVAStart(CallExpr *TheCall) {
608 Expr *Fn = TheCall->getCallee();
609 if (TheCall->getNumArgs() > 2) {
Chris Lattner2c21a072008-11-21 18:44:24 +0000610 Diag(TheCall->getArg(2)->getLocStart(),
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000611 diag::err_typecheck_call_too_many_args)
Eric Christopherccfa9632010-04-16 04:56:46 +0000612 << 0 /*function call*/ << 2 << TheCall->getNumArgs()
613 << Fn->getSourceRange()
Mike Stump1eb44332009-09-09 15:08:12 +0000614 << SourceRange(TheCall->getArg(2)->getLocStart(),
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000615 (*(TheCall->arg_end()-1))->getLocEnd());
Chris Lattner30ce3442007-12-19 23:59:04 +0000616 return true;
617 }
Eli Friedman56f20ae2008-12-15 22:05:35 +0000618
619 if (TheCall->getNumArgs() < 2) {
Eric Christopherd77b9a22010-04-16 04:48:22 +0000620 return Diag(TheCall->getLocEnd(),
621 diag::err_typecheck_call_too_few_args_at_least)
622 << 0 /*function call*/ << 2 << TheCall->getNumArgs();
Eli Friedman56f20ae2008-12-15 22:05:35 +0000623 }
624
Chris Lattnerc27c6652007-12-20 00:05:45 +0000625 // Determine whether the current function is variadic or not.
Douglas Gregor9ea9bdb2010-03-01 23:15:13 +0000626 BlockScopeInfo *CurBlock = getCurBlock();
Chris Lattnerc27c6652007-12-20 00:05:45 +0000627 bool isVariadic;
Steve Naroffcd9c5142009-04-15 19:33:47 +0000628 if (CurBlock)
John McCallc71a4912010-06-04 19:02:56 +0000629 isVariadic = CurBlock->TheDecl->isVariadic();
Ted Kremenek9498d382010-04-29 16:49:01 +0000630 else if (FunctionDecl *FD = getCurFunctionDecl())
631 isVariadic = FD->isVariadic();
632 else
Argyrios Kyrtzidis53d0ea52008-06-28 06:07:14 +0000633 isVariadic = getCurMethodDecl()->isVariadic();
Mike Stump1eb44332009-09-09 15:08:12 +0000634
Chris Lattnerc27c6652007-12-20 00:05:45 +0000635 if (!isVariadic) {
Chris Lattner30ce3442007-12-19 23:59:04 +0000636 Diag(Fn->getLocStart(), diag::err_va_start_used_in_non_variadic_function);
637 return true;
638 }
Mike Stump1eb44332009-09-09 15:08:12 +0000639
Chris Lattner30ce3442007-12-19 23:59:04 +0000640 // Verify that the second argument to the builtin is the last argument of the
641 // current function or method.
642 bool SecondArgIsLastNamedArgument = false;
Anders Carlssone2c14102008-02-13 01:22:59 +0000643 const Expr *Arg = TheCall->getArg(1)->IgnoreParenCasts();
Mike Stump1eb44332009-09-09 15:08:12 +0000644
Anders Carlsson88cf2262008-02-11 04:20:54 +0000645 if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Arg)) {
646 if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(DR->getDecl())) {
Chris Lattner30ce3442007-12-19 23:59:04 +0000647 // FIXME: This isn't correct for methods (results in bogus warning).
648 // Get the last formal in the current function.
Anders Carlsson88cf2262008-02-11 04:20:54 +0000649 const ParmVarDecl *LastArg;
Steve Naroffcd9c5142009-04-15 19:33:47 +0000650 if (CurBlock)
651 LastArg = *(CurBlock->TheDecl->param_end()-1);
652 else if (FunctionDecl *FD = getCurFunctionDecl())
Chris Lattner371f2582008-12-04 23:50:19 +0000653 LastArg = *(FD->param_end()-1);
Chris Lattner30ce3442007-12-19 23:59:04 +0000654 else
Argyrios Kyrtzidis53d0ea52008-06-28 06:07:14 +0000655 LastArg = *(getCurMethodDecl()->param_end()-1);
Chris Lattner30ce3442007-12-19 23:59:04 +0000656 SecondArgIsLastNamedArgument = PV == LastArg;
657 }
658 }
Mike Stump1eb44332009-09-09 15:08:12 +0000659
Chris Lattner30ce3442007-12-19 23:59:04 +0000660 if (!SecondArgIsLastNamedArgument)
Mike Stump1eb44332009-09-09 15:08:12 +0000661 Diag(TheCall->getArg(1)->getLocStart(),
Chris Lattner30ce3442007-12-19 23:59:04 +0000662 diag::warn_second_parameter_of_va_start_not_last_named_argument);
663 return false;
Eli Friedman6cfda232008-05-20 08:23:37 +0000664}
Chris Lattner30ce3442007-12-19 23:59:04 +0000665
Chris Lattner1b9a0792007-12-20 00:26:33 +0000666/// SemaBuiltinUnorderedCompare - Handle functions like __builtin_isgreater and
667/// friends. This is declared to take (...), so we have to check everything.
Chris Lattner925e60d2007-12-28 05:29:59 +0000668bool Sema::SemaBuiltinUnorderedCompare(CallExpr *TheCall) {
669 if (TheCall->getNumArgs() < 2)
Chris Lattner2c21a072008-11-21 18:44:24 +0000670 return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args)
Eric Christopherd77b9a22010-04-16 04:48:22 +0000671 << 0 << 2 << TheCall->getNumArgs()/*function call*/;
Chris Lattner925e60d2007-12-28 05:29:59 +0000672 if (TheCall->getNumArgs() > 2)
Mike Stump1eb44332009-09-09 15:08:12 +0000673 return Diag(TheCall->getArg(2)->getLocStart(),
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000674 diag::err_typecheck_call_too_many_args)
Eric Christopherccfa9632010-04-16 04:56:46 +0000675 << 0 /*function call*/ << 2 << TheCall->getNumArgs()
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000676 << SourceRange(TheCall->getArg(2)->getLocStart(),
677 (*(TheCall->arg_end()-1))->getLocEnd());
Mike Stump1eb44332009-09-09 15:08:12 +0000678
Chris Lattner925e60d2007-12-28 05:29:59 +0000679 Expr *OrigArg0 = TheCall->getArg(0);
680 Expr *OrigArg1 = TheCall->getArg(1);
Douglas Gregorcde01732009-05-19 22:10:17 +0000681
Chris Lattner1b9a0792007-12-20 00:26:33 +0000682 // Do standard promotions between the two arguments, returning their common
683 // type.
Chris Lattner925e60d2007-12-28 05:29:59 +0000684 QualType Res = UsualArithmeticConversions(OrigArg0, OrigArg1, false);
Daniel Dunbar403bc2b2009-02-19 19:28:43 +0000685
686 // Make sure any conversions are pushed back into the call; this is
687 // type safe since unordered compare builtins are declared as "_Bool
688 // foo(...)".
689 TheCall->setArg(0, OrigArg0);
690 TheCall->setArg(1, OrigArg1);
Mike Stump1eb44332009-09-09 15:08:12 +0000691
Douglas Gregorcde01732009-05-19 22:10:17 +0000692 if (OrigArg0->isTypeDependent() || OrigArg1->isTypeDependent())
693 return false;
694
Chris Lattner1b9a0792007-12-20 00:26:33 +0000695 // If the common type isn't a real floating type, then the arguments were
696 // invalid for this operation.
697 if (!Res->isRealFloatingType())
Mike Stump1eb44332009-09-09 15:08:12 +0000698 return Diag(OrigArg0->getLocStart(),
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000699 diag::err_typecheck_call_invalid_ordered_compare)
Chris Lattnerd1625842008-11-24 06:25:27 +0000700 << OrigArg0->getType() << OrigArg1->getType()
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000701 << SourceRange(OrigArg0->getLocStart(), OrigArg1->getLocEnd());
Mike Stump1eb44332009-09-09 15:08:12 +0000702
Chris Lattner1b9a0792007-12-20 00:26:33 +0000703 return false;
704}
705
Benjamin Kramere771a7a2010-02-15 22:42:31 +0000706/// SemaBuiltinSemaBuiltinFPClassification - Handle functions like
707/// __builtin_isnan and friends. This is declared to take (...), so we have
Benjamin Kramer3b1e26b2010-02-16 10:07:31 +0000708/// to check everything. We expect the last argument to be a floating point
709/// value.
710bool Sema::SemaBuiltinFPClassification(CallExpr *TheCall, unsigned NumArgs) {
711 if (TheCall->getNumArgs() < NumArgs)
Eli Friedman9ac6f622009-08-31 20:06:00 +0000712 return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args)
Eric Christopherd77b9a22010-04-16 04:48:22 +0000713 << 0 << NumArgs << TheCall->getNumArgs()/*function call*/;
Benjamin Kramer3b1e26b2010-02-16 10:07:31 +0000714 if (TheCall->getNumArgs() > NumArgs)
715 return Diag(TheCall->getArg(NumArgs)->getLocStart(),
Eli Friedman9ac6f622009-08-31 20:06:00 +0000716 diag::err_typecheck_call_too_many_args)
Eric Christopherccfa9632010-04-16 04:56:46 +0000717 << 0 /*function call*/ << NumArgs << TheCall->getNumArgs()
Benjamin Kramer3b1e26b2010-02-16 10:07:31 +0000718 << SourceRange(TheCall->getArg(NumArgs)->getLocStart(),
Eli Friedman9ac6f622009-08-31 20:06:00 +0000719 (*(TheCall->arg_end()-1))->getLocEnd());
720
Benjamin Kramer3b1e26b2010-02-16 10:07:31 +0000721 Expr *OrigArg = TheCall->getArg(NumArgs-1);
Mike Stump1eb44332009-09-09 15:08:12 +0000722
Eli Friedman9ac6f622009-08-31 20:06:00 +0000723 if (OrigArg->isTypeDependent())
724 return false;
725
Chris Lattner81368fb2010-05-06 05:50:07 +0000726 // This operation requires a non-_Complex floating-point number.
Eli Friedman9ac6f622009-08-31 20:06:00 +0000727 if (!OrigArg->getType()->isRealFloatingType())
Mike Stump1eb44332009-09-09 15:08:12 +0000728 return Diag(OrigArg->getLocStart(),
Eli Friedman9ac6f622009-08-31 20:06:00 +0000729 diag::err_typecheck_call_invalid_unary_fp)
730 << OrigArg->getType() << OrigArg->getSourceRange();
Mike Stump1eb44332009-09-09 15:08:12 +0000731
Chris Lattner81368fb2010-05-06 05:50:07 +0000732 // If this is an implicit conversion from float -> double, remove it.
733 if (ImplicitCastExpr *Cast = dyn_cast<ImplicitCastExpr>(OrigArg)) {
734 Expr *CastArg = Cast->getSubExpr();
735 if (CastArg->getType()->isSpecificBuiltinType(BuiltinType::Float)) {
736 assert(Cast->getType()->isSpecificBuiltinType(BuiltinType::Double) &&
737 "promotion from float to double is the only expected cast here");
738 Cast->setSubExpr(0);
739 Cast->Destroy(Context);
740 TheCall->setArg(NumArgs-1, CastArg);
741 OrigArg = CastArg;
742 }
743 }
744
Eli Friedman9ac6f622009-08-31 20:06:00 +0000745 return false;
746}
747
Eli Friedmand38617c2008-05-14 19:38:39 +0000748/// SemaBuiltinShuffleVector - Handle __builtin_shufflevector.
749// This is declared to take (...), so we have to check everything.
Sebastian Redl0eb23302009-01-19 00:08:26 +0000750Action::OwningExprResult Sema::SemaBuiltinShuffleVector(CallExpr *TheCall) {
Nate Begeman37b6a572010-06-08 00:16:34 +0000751 if (TheCall->getNumArgs() < 2)
Sebastian Redl0eb23302009-01-19 00:08:26 +0000752 return ExprError(Diag(TheCall->getLocEnd(),
Eric Christopherd77b9a22010-04-16 04:48:22 +0000753 diag::err_typecheck_call_too_few_args_at_least)
Nate Begeman37b6a572010-06-08 00:16:34 +0000754 << 0 /*function call*/ << 2 << TheCall->getNumArgs()
Eric Christopherd77b9a22010-04-16 04:48:22 +0000755 << TheCall->getSourceRange());
Eli Friedmand38617c2008-05-14 19:38:39 +0000756
Nate Begeman37b6a572010-06-08 00:16:34 +0000757 // Determine which of the following types of shufflevector we're checking:
758 // 1) unary, vector mask: (lhs, mask)
759 // 2) binary, vector mask: (lhs, rhs, mask)
760 // 3) binary, scalar mask: (lhs, rhs, index, ..., index)
761 QualType resType = TheCall->getArg(0)->getType();
762 unsigned numElements = 0;
763
Douglas Gregorcde01732009-05-19 22:10:17 +0000764 if (!TheCall->getArg(0)->isTypeDependent() &&
765 !TheCall->getArg(1)->isTypeDependent()) {
Nate Begeman37b6a572010-06-08 00:16:34 +0000766 QualType LHSType = TheCall->getArg(0)->getType();
767 QualType RHSType = TheCall->getArg(1)->getType();
768
769 if (!LHSType->isVectorType() || !RHSType->isVectorType()) {
Douglas Gregorcde01732009-05-19 22:10:17 +0000770 Diag(TheCall->getLocStart(), diag::err_shufflevector_non_vector)
Mike Stump1eb44332009-09-09 15:08:12 +0000771 << SourceRange(TheCall->getArg(0)->getLocStart(),
Douglas Gregorcde01732009-05-19 22:10:17 +0000772 TheCall->getArg(1)->getLocEnd());
773 return ExprError();
774 }
Nate Begeman37b6a572010-06-08 00:16:34 +0000775
776 numElements = LHSType->getAs<VectorType>()->getNumElements();
777 unsigned numResElements = TheCall->getNumArgs() - 2;
Mike Stump1eb44332009-09-09 15:08:12 +0000778
Nate Begeman37b6a572010-06-08 00:16:34 +0000779 // Check to see if we have a call with 2 vector arguments, the unary shuffle
780 // with mask. If so, verify that RHS is an integer vector type with the
781 // same number of elts as lhs.
782 if (TheCall->getNumArgs() == 2) {
783 if (!RHSType->isIntegerType() ||
784 RHSType->getAs<VectorType>()->getNumElements() != numElements)
785 Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector)
786 << SourceRange(TheCall->getArg(1)->getLocStart(),
787 TheCall->getArg(1)->getLocEnd());
788 numResElements = numElements;
789 }
790 else if (!Context.hasSameUnqualifiedType(LHSType, RHSType)) {
Douglas Gregorcde01732009-05-19 22:10:17 +0000791 Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector)
Mike Stump1eb44332009-09-09 15:08:12 +0000792 << SourceRange(TheCall->getArg(0)->getLocStart(),
Douglas Gregorcde01732009-05-19 22:10:17 +0000793 TheCall->getArg(1)->getLocEnd());
794 return ExprError();
Nate Begeman37b6a572010-06-08 00:16:34 +0000795 } else if (numElements != numResElements) {
796 QualType eltType = LHSType->getAs<VectorType>()->getElementType();
Chris Lattner788b0fd2010-06-23 06:00:24 +0000797 resType = Context.getVectorType(eltType, numResElements,
798 VectorType::NotAltiVec);
Douglas Gregorcde01732009-05-19 22:10:17 +0000799 }
Eli Friedmand38617c2008-05-14 19:38:39 +0000800 }
801
802 for (unsigned i = 2; i < TheCall->getNumArgs(); i++) {
Douglas Gregorcde01732009-05-19 22:10:17 +0000803 if (TheCall->getArg(i)->isTypeDependent() ||
804 TheCall->getArg(i)->isValueDependent())
805 continue;
806
Nate Begeman37b6a572010-06-08 00:16:34 +0000807 llvm::APSInt Result(32);
808 if (!TheCall->getArg(i)->isIntegerConstantExpr(Result, Context))
809 return ExprError(Diag(TheCall->getLocStart(),
810 diag::err_shufflevector_nonconstant_argument)
811 << TheCall->getArg(i)->getSourceRange());
Sebastian Redl0eb23302009-01-19 00:08:26 +0000812
Chris Lattnerd1a0b6d2008-08-10 02:05:13 +0000813 if (Result.getActiveBits() > 64 || Result.getZExtValue() >= numElements*2)
Sebastian Redl0eb23302009-01-19 00:08:26 +0000814 return ExprError(Diag(TheCall->getLocStart(),
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000815 diag::err_shufflevector_argument_too_large)
Sebastian Redl0eb23302009-01-19 00:08:26 +0000816 << TheCall->getArg(i)->getSourceRange());
Eli Friedmand38617c2008-05-14 19:38:39 +0000817 }
818
819 llvm::SmallVector<Expr*, 32> exprs;
820
Chris Lattnerd1a0b6d2008-08-10 02:05:13 +0000821 for (unsigned i = 0, e = TheCall->getNumArgs(); i != e; i++) {
Eli Friedmand38617c2008-05-14 19:38:39 +0000822 exprs.push_back(TheCall->getArg(i));
823 TheCall->setArg(i, 0);
824 }
825
Nate Begemana88dc302009-08-12 02:10:25 +0000826 return Owned(new (Context) ShuffleVectorExpr(Context, exprs.begin(),
Nate Begeman37b6a572010-06-08 00:16:34 +0000827 exprs.size(), resType,
Ted Kremenek8189cde2009-02-07 01:47:29 +0000828 TheCall->getCallee()->getLocStart(),
829 TheCall->getRParenLoc()));
Eli Friedmand38617c2008-05-14 19:38:39 +0000830}
Chris Lattner30ce3442007-12-19 23:59:04 +0000831
Daniel Dunbar4493f792008-07-21 22:59:13 +0000832/// SemaBuiltinPrefetch - Handle __builtin_prefetch.
833// This is declared to take (const void*, ...) and can take two
834// optional constant int args.
835bool Sema::SemaBuiltinPrefetch(CallExpr *TheCall) {
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000836 unsigned NumArgs = TheCall->getNumArgs();
Daniel Dunbar4493f792008-07-21 22:59:13 +0000837
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000838 if (NumArgs > 3)
Eric Christopherccfa9632010-04-16 04:56:46 +0000839 return Diag(TheCall->getLocEnd(),
840 diag::err_typecheck_call_too_many_args_at_most)
841 << 0 /*function call*/ << 3 << NumArgs
842 << TheCall->getSourceRange();
Daniel Dunbar4493f792008-07-21 22:59:13 +0000843
844 // Argument 0 is checked for us and the remaining arguments must be
845 // constant integers.
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000846 for (unsigned i = 1; i != NumArgs; ++i) {
Daniel Dunbar4493f792008-07-21 22:59:13 +0000847 Expr *Arg = TheCall->getArg(i);
Eric Christopher691ebc32010-04-17 02:26:23 +0000848
Eli Friedman9aef7262009-12-04 00:30:06 +0000849 llvm::APSInt Result;
Eric Christopher691ebc32010-04-17 02:26:23 +0000850 if (SemaBuiltinConstantArg(TheCall, i, Result))
851 return true;
Mike Stump1eb44332009-09-09 15:08:12 +0000852
Daniel Dunbar4493f792008-07-21 22:59:13 +0000853 // FIXME: gcc issues a warning and rewrites these to 0. These
854 // seems especially odd for the third argument since the default
855 // is 3.
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000856 if (i == 1) {
Eli Friedman9aef7262009-12-04 00:30:06 +0000857 if (Result.getLimitedValue() > 1)
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000858 return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
Chris Lattner21fb98e2009-09-23 06:06:36 +0000859 << "0" << "1" << Arg->getSourceRange();
Daniel Dunbar4493f792008-07-21 22:59:13 +0000860 } else {
Eli Friedman9aef7262009-12-04 00:30:06 +0000861 if (Result.getLimitedValue() > 3)
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000862 return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
Chris Lattner21fb98e2009-09-23 06:06:36 +0000863 << "0" << "3" << Arg->getSourceRange();
Daniel Dunbar4493f792008-07-21 22:59:13 +0000864 }
865 }
866
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000867 return false;
Daniel Dunbar4493f792008-07-21 22:59:13 +0000868}
869
Eric Christopher691ebc32010-04-17 02:26:23 +0000870/// SemaBuiltinConstantArg - Handle a check if argument ArgNum of CallExpr
871/// TheCall is a constant expression.
872bool Sema::SemaBuiltinConstantArg(CallExpr *TheCall, int ArgNum,
873 llvm::APSInt &Result) {
874 Expr *Arg = TheCall->getArg(ArgNum);
875 DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts());
876 FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl());
877
878 if (Arg->isTypeDependent() || Arg->isValueDependent()) return false;
879
880 if (!Arg->isIntegerConstantExpr(Result, Context))
881 return Diag(TheCall->getLocStart(), diag::err_constant_integer_arg_type)
Eric Christopher5e896552010-04-19 18:23:02 +0000882 << FDecl->getDeclName() << Arg->getSourceRange();
Eric Christopher691ebc32010-04-17 02:26:23 +0000883
Chris Lattner21fb98e2009-09-23 06:06:36 +0000884 return false;
885}
886
Daniel Dunbard5f8a4f2008-09-03 21:13:56 +0000887/// SemaBuiltinObjectSize - Handle __builtin_object_size(void *ptr,
888/// int type). This simply type checks that type is one of the defined
889/// constants (0-3).
Eric Christopherfee667f2009-12-23 03:49:37 +0000890// For compatability check 0-3, llvm only handles 0 and 2.
Daniel Dunbard5f8a4f2008-09-03 21:13:56 +0000891bool Sema::SemaBuiltinObjectSize(CallExpr *TheCall) {
Eric Christopher691ebc32010-04-17 02:26:23 +0000892 llvm::APSInt Result;
893
894 // Check constant-ness first.
895 if (SemaBuiltinConstantArg(TheCall, 1, Result))
896 return true;
897
Daniel Dunbard5f8a4f2008-09-03 21:13:56 +0000898 Expr *Arg = TheCall->getArg(1);
Daniel Dunbard5f8a4f2008-09-03 21:13:56 +0000899 if (Result.getSExtValue() < 0 || Result.getSExtValue() > 3) {
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000900 return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
901 << "0" << "3" << SourceRange(Arg->getLocStart(), Arg->getLocEnd());
Daniel Dunbard5f8a4f2008-09-03 21:13:56 +0000902 }
903
904 return false;
905}
906
Eli Friedman586d6a82009-05-03 06:04:26 +0000907/// SemaBuiltinLongjmp - Handle __builtin_longjmp(void *env[5], int val).
Eli Friedmand875fed2009-05-03 04:46:36 +0000908/// This checks that val is a constant 1.
909bool Sema::SemaBuiltinLongjmp(CallExpr *TheCall) {
910 Expr *Arg = TheCall->getArg(1);
Eric Christopher691ebc32010-04-17 02:26:23 +0000911 llvm::APSInt Result;
Douglas Gregorcde01732009-05-19 22:10:17 +0000912
Eric Christopher691ebc32010-04-17 02:26:23 +0000913 // TODO: This is less than ideal. Overload this to take a value.
914 if (SemaBuiltinConstantArg(TheCall, 1, Result))
915 return true;
916
917 if (Result != 1)
Eli Friedmand875fed2009-05-03 04:46:36 +0000918 return Diag(TheCall->getLocStart(), diag::err_builtin_longjmp_invalid_val)
919 << SourceRange(Arg->getLocStart(), Arg->getLocEnd());
920
921 return false;
922}
923
Ted Kremenekd30ef872009-01-12 23:09:09 +0000924// Handle i > 1 ? "x" : "y", recursivelly
Ted Kremenek082d9362009-03-20 21:35:28 +0000925bool Sema::SemaCheckStringLiteral(const Expr *E, const CallExpr *TheCall,
926 bool HasVAListArg,
Ted Kremenek826a3452010-07-16 02:11:22 +0000927 unsigned format_idx, unsigned firstDataArg,
928 bool isPrintf) {
929
Douglas Gregorcde01732009-05-19 22:10:17 +0000930 if (E->isTypeDependent() || E->isValueDependent())
931 return false;
Ted Kremenekd30ef872009-01-12 23:09:09 +0000932
933 switch (E->getStmtClass()) {
934 case Stmt::ConditionalOperatorClass: {
Ted Kremenek082d9362009-03-20 21:35:28 +0000935 const ConditionalOperator *C = cast<ConditionalOperator>(E);
Ted Kremenek826a3452010-07-16 02:11:22 +0000936 return SemaCheckStringLiteral(C->getTrueExpr(), TheCall, HasVAListArg,
937 format_idx, firstDataArg, isPrintf)
938 && SemaCheckStringLiteral(C->getRHS(), TheCall, HasVAListArg,
939 format_idx, firstDataArg, isPrintf);
Ted Kremenekd30ef872009-01-12 23:09:09 +0000940 }
941
942 case Stmt::ImplicitCastExprClass: {
Ted Kremenek082d9362009-03-20 21:35:28 +0000943 const ImplicitCastExpr *Expr = cast<ImplicitCastExpr>(E);
Ted Kremenekd30ef872009-01-12 23:09:09 +0000944 return SemaCheckStringLiteral(Expr->getSubExpr(), TheCall, HasVAListArg,
Ted Kremenek826a3452010-07-16 02:11:22 +0000945 format_idx, firstDataArg, isPrintf);
Ted Kremenekd30ef872009-01-12 23:09:09 +0000946 }
947
948 case Stmt::ParenExprClass: {
Ted Kremenek082d9362009-03-20 21:35:28 +0000949 const ParenExpr *Expr = cast<ParenExpr>(E);
Ted Kremenekd30ef872009-01-12 23:09:09 +0000950 return SemaCheckStringLiteral(Expr->getSubExpr(), TheCall, HasVAListArg,
Ted Kremenek826a3452010-07-16 02:11:22 +0000951 format_idx, firstDataArg, isPrintf);
Ted Kremenekd30ef872009-01-12 23:09:09 +0000952 }
Mike Stump1eb44332009-09-09 15:08:12 +0000953
Ted Kremenek082d9362009-03-20 21:35:28 +0000954 case Stmt::DeclRefExprClass: {
955 const DeclRefExpr *DR = cast<DeclRefExpr>(E);
Mike Stump1eb44332009-09-09 15:08:12 +0000956
Ted Kremenek082d9362009-03-20 21:35:28 +0000957 // As an exception, do not flag errors for variables binding to
958 // const string literals.
959 if (const VarDecl *VD = dyn_cast<VarDecl>(DR->getDecl())) {
960 bool isConstant = false;
961 QualType T = DR->getType();
Ted Kremenekd30ef872009-01-12 23:09:09 +0000962
Ted Kremenek082d9362009-03-20 21:35:28 +0000963 if (const ArrayType *AT = Context.getAsArrayType(T)) {
964 isConstant = AT->getElementType().isConstant(Context);
Mike Stumpac5fc7c2009-08-04 21:02:39 +0000965 } else if (const PointerType *PT = T->getAs<PointerType>()) {
Mike Stump1eb44332009-09-09 15:08:12 +0000966 isConstant = T.isConstant(Context) &&
Ted Kremenek082d9362009-03-20 21:35:28 +0000967 PT->getPointeeType().isConstant(Context);
968 }
Mike Stump1eb44332009-09-09 15:08:12 +0000969
Ted Kremenek082d9362009-03-20 21:35:28 +0000970 if (isConstant) {
Sebastian Redl31310a22010-02-01 20:16:42 +0000971 if (const Expr *Init = VD->getAnyInitializer())
Ted Kremenek082d9362009-03-20 21:35:28 +0000972 return SemaCheckStringLiteral(Init, TheCall,
Ted Kremenek826a3452010-07-16 02:11:22 +0000973 HasVAListArg, format_idx, firstDataArg,
974 isPrintf);
Ted Kremenek082d9362009-03-20 21:35:28 +0000975 }
Mike Stump1eb44332009-09-09 15:08:12 +0000976
Anders Carlssond966a552009-06-28 19:55:58 +0000977 // For vprintf* functions (i.e., HasVAListArg==true), we add a
978 // special check to see if the format string is a function parameter
979 // of the function calling the printf function. If the function
980 // has an attribute indicating it is a printf-like function, then we
981 // should suppress warnings concerning non-literals being used in a call
982 // to a vprintf function. For example:
983 //
984 // void
985 // logmessage(char const *fmt __attribute__ (format (printf, 1, 2)), ...){
986 // va_list ap;
987 // va_start(ap, fmt);
988 // vprintf(fmt, ap); // Do NOT emit a warning about "fmt".
989 // ...
990 //
991 //
992 // FIXME: We don't have full attribute support yet, so just check to see
993 // if the argument is a DeclRefExpr that references a parameter. We'll
994 // add proper support for checking the attribute later.
995 if (HasVAListArg)
996 if (isa<ParmVarDecl>(VD))
997 return true;
Ted Kremenek082d9362009-03-20 21:35:28 +0000998 }
Mike Stump1eb44332009-09-09 15:08:12 +0000999
Ted Kremenek082d9362009-03-20 21:35:28 +00001000 return false;
1001 }
Ted Kremenekd30ef872009-01-12 23:09:09 +00001002
Anders Carlsson8f031b32009-06-27 04:05:33 +00001003 case Stmt::CallExprClass: {
1004 const CallExpr *CE = cast<CallExpr>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00001005 if (const ImplicitCastExpr *ICE
Anders Carlsson8f031b32009-06-27 04:05:33 +00001006 = dyn_cast<ImplicitCastExpr>(CE->getCallee())) {
1007 if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(ICE->getSubExpr())) {
1008 if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(DRE->getDecl())) {
Argyrios Kyrtzidis40b598e2009-06-30 02:34:44 +00001009 if (const FormatArgAttr *FA = FD->getAttr<FormatArgAttr>()) {
Anders Carlsson8f031b32009-06-27 04:05:33 +00001010 unsigned ArgIndex = FA->getFormatIdx();
1011 const Expr *Arg = CE->getArg(ArgIndex - 1);
Mike Stump1eb44332009-09-09 15:08:12 +00001012
1013 return SemaCheckStringLiteral(Arg, TheCall, HasVAListArg,
Ted Kremenek826a3452010-07-16 02:11:22 +00001014 format_idx, firstDataArg, isPrintf);
Anders Carlsson8f031b32009-06-27 04:05:33 +00001015 }
1016 }
1017 }
1018 }
Mike Stump1eb44332009-09-09 15:08:12 +00001019
Anders Carlsson8f031b32009-06-27 04:05:33 +00001020 return false;
1021 }
Ted Kremenek082d9362009-03-20 21:35:28 +00001022 case Stmt::ObjCStringLiteralClass:
1023 case Stmt::StringLiteralClass: {
1024 const StringLiteral *StrE = NULL;
Mike Stump1eb44332009-09-09 15:08:12 +00001025
Ted Kremenek082d9362009-03-20 21:35:28 +00001026 if (const ObjCStringLiteral *ObjCFExpr = dyn_cast<ObjCStringLiteral>(E))
Ted Kremenekd30ef872009-01-12 23:09:09 +00001027 StrE = ObjCFExpr->getString();
1028 else
Ted Kremenek082d9362009-03-20 21:35:28 +00001029 StrE = cast<StringLiteral>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00001030
Ted Kremenekd30ef872009-01-12 23:09:09 +00001031 if (StrE) {
Ted Kremenek826a3452010-07-16 02:11:22 +00001032 CheckFormatString(StrE, E, TheCall, HasVAListArg, format_idx,
1033 firstDataArg, isPrintf);
Ted Kremenekd30ef872009-01-12 23:09:09 +00001034 return true;
1035 }
Mike Stump1eb44332009-09-09 15:08:12 +00001036
Ted Kremenekd30ef872009-01-12 23:09:09 +00001037 return false;
1038 }
Mike Stump1eb44332009-09-09 15:08:12 +00001039
Ted Kremenek082d9362009-03-20 21:35:28 +00001040 default:
1041 return false;
Ted Kremenekd30ef872009-01-12 23:09:09 +00001042 }
1043}
1044
Fariborz Jahaniane898f8a2009-05-21 18:48:51 +00001045void
Mike Stump1eb44332009-09-09 15:08:12 +00001046Sema::CheckNonNullArguments(const NonNullAttr *NonNull,
1047 const CallExpr *TheCall) {
Fariborz Jahaniane898f8a2009-05-21 18:48:51 +00001048 for (NonNullAttr::iterator i = NonNull->begin(), e = NonNull->end();
1049 i != e; ++i) {
Chris Lattner12b97ff2009-05-25 18:23:36 +00001050 const Expr *ArgExpr = TheCall->getArg(*i);
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001051 if (ArgExpr->isNullPointerConstant(Context,
Douglas Gregorce940492009-09-25 04:25:58 +00001052 Expr::NPC_ValueDependentIsNotNull))
Chris Lattner12b97ff2009-05-25 18:23:36 +00001053 Diag(TheCall->getCallee()->getLocStart(), diag::warn_null_arg)
1054 << ArgExpr->getSourceRange();
Fariborz Jahaniane898f8a2009-05-21 18:48:51 +00001055 }
1056}
Ted Kremenekd30ef872009-01-12 23:09:09 +00001057
Ted Kremenek826a3452010-07-16 02:11:22 +00001058/// CheckPrintfScanfArguments - Check calls to printf and scanf (and similar
1059/// functions) for correct use of format strings.
Chris Lattner59907c42007-08-10 20:18:51 +00001060void
Ted Kremenek826a3452010-07-16 02:11:22 +00001061Sema::CheckPrintfScanfArguments(const CallExpr *TheCall, bool HasVAListArg,
1062 unsigned format_idx, unsigned firstDataArg,
1063 bool isPrintf) {
1064
Ted Kremenek082d9362009-03-20 21:35:28 +00001065 const Expr *Fn = TheCall->getCallee();
Chris Lattner925e60d2007-12-28 05:29:59 +00001066
Sebastian Redl4a2614e2009-11-17 18:02:24 +00001067 // The way the format attribute works in GCC, the implicit this argument
1068 // of member functions is counted. However, it doesn't appear in our own
1069 // lists, so decrement format_idx in that case.
1070 if (isa<CXXMemberCallExpr>(TheCall)) {
1071 // Catch a format attribute mistakenly referring to the object argument.
1072 if (format_idx == 0)
1073 return;
1074 --format_idx;
1075 if(firstDataArg != 0)
1076 --firstDataArg;
1077 }
1078
Ted Kremenek826a3452010-07-16 02:11:22 +00001079 // CHECK: printf/scanf-like function is called with no format string.
Chris Lattner925e60d2007-12-28 05:29:59 +00001080 if (format_idx >= TheCall->getNumArgs()) {
Ted Kremenek826a3452010-07-16 02:11:22 +00001081 Diag(TheCall->getRParenLoc(), diag::warn_missing_format_string)
Chris Lattnerdcd5ef12008-11-19 05:27:50 +00001082 << Fn->getSourceRange();
Ted Kremenek71895b92007-08-14 17:39:48 +00001083 return;
1084 }
Mike Stump1eb44332009-09-09 15:08:12 +00001085
Ted Kremenek082d9362009-03-20 21:35:28 +00001086 const Expr *OrigFormatExpr = TheCall->getArg(format_idx)->IgnoreParenCasts();
Mike Stump1eb44332009-09-09 15:08:12 +00001087
Chris Lattner59907c42007-08-10 20:18:51 +00001088 // CHECK: format string is not a string literal.
Mike Stump1eb44332009-09-09 15:08:12 +00001089 //
Ted Kremenek71895b92007-08-14 17:39:48 +00001090 // Dynamically generated format strings are difficult to
1091 // automatically vet at compile time. Requiring that format strings
1092 // are string literals: (1) permits the checking of format strings by
1093 // the compiler and thereby (2) can practically remove the source of
1094 // many format string exploits.
Ted Kremenek7ff22b22008-06-16 18:00:42 +00001095
Mike Stump1eb44332009-09-09 15:08:12 +00001096 // Format string can be either ObjC string (e.g. @"%d") or
Ted Kremenek7ff22b22008-06-16 18:00:42 +00001097 // C string (e.g. "%d")
Mike Stump1eb44332009-09-09 15:08:12 +00001098 // ObjC string uses the same format specifiers as C string, so we can use
Ted Kremenek7ff22b22008-06-16 18:00:42 +00001099 // the same format string checking logic for both ObjC and C strings.
Chris Lattner1cd3e1f2009-04-29 04:49:34 +00001100 if (SemaCheckStringLiteral(OrigFormatExpr, TheCall, HasVAListArg, format_idx,
Ted Kremenek826a3452010-07-16 02:11:22 +00001101 firstDataArg, isPrintf))
Chris Lattner1cd3e1f2009-04-29 04:49:34 +00001102 return; // Literal format string found, check done!
Ted Kremenek7ff22b22008-06-16 18:00:42 +00001103
Chris Lattner655f1412009-04-29 04:59:47 +00001104 // If there are no arguments specified, warn with -Wformat-security, otherwise
1105 // warn only with -Wformat-nonliteral.
1106 if (TheCall->getNumArgs() == format_idx+1)
Mike Stump1eb44332009-09-09 15:08:12 +00001107 Diag(TheCall->getArg(format_idx)->getLocStart(),
Ted Kremenek826a3452010-07-16 02:11:22 +00001108 diag::warn_format_nonliteral_noargs)
Chris Lattner655f1412009-04-29 04:59:47 +00001109 << OrigFormatExpr->getSourceRange();
1110 else
Mike Stump1eb44332009-09-09 15:08:12 +00001111 Diag(TheCall->getArg(format_idx)->getLocStart(),
Ted Kremenek826a3452010-07-16 02:11:22 +00001112 diag::warn_format_nonliteral)
Chris Lattner655f1412009-04-29 04:59:47 +00001113 << OrigFormatExpr->getSourceRange();
Ted Kremenekd30ef872009-01-12 23:09:09 +00001114}
Ted Kremenek71895b92007-08-14 17:39:48 +00001115
Ted Kremeneke0e53132010-01-28 23:39:18 +00001116namespace {
Ted Kremenek826a3452010-07-16 02:11:22 +00001117class CheckFormatHandler : public analyze_format_string::FormatStringHandler {
1118protected:
Ted Kremeneke0e53132010-01-28 23:39:18 +00001119 Sema &S;
1120 const StringLiteral *FExpr;
1121 const Expr *OrigFormatExpr;
Ted Kremenek6ee76532010-03-25 03:59:12 +00001122 const unsigned FirstDataArg;
Ted Kremeneke0e53132010-01-28 23:39:18 +00001123 const unsigned NumDataArgs;
1124 const bool IsObjCLiteral;
1125 const char *Beg; // Start of format string.
Ted Kremenek0d277352010-01-29 01:06:55 +00001126 const bool HasVAListArg;
1127 const CallExpr *TheCall;
1128 unsigned FormatIdx;
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001129 llvm::BitVector CoveredArgs;
Ted Kremenekefaff192010-02-27 01:41:03 +00001130 bool usesPositionalArgs;
1131 bool atFirstArg;
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001132public:
Ted Kremenek826a3452010-07-16 02:11:22 +00001133 CheckFormatHandler(Sema &s, const StringLiteral *fexpr,
Ted Kremenek6ee76532010-03-25 03:59:12 +00001134 const Expr *origFormatExpr, unsigned firstDataArg,
Ted Kremeneke0e53132010-01-28 23:39:18 +00001135 unsigned numDataArgs, bool isObjCLiteral,
Ted Kremenek0d277352010-01-29 01:06:55 +00001136 const char *beg, bool hasVAListArg,
1137 const CallExpr *theCall, unsigned formatIdx)
Ted Kremeneke0e53132010-01-28 23:39:18 +00001138 : S(s), FExpr(fexpr), OrigFormatExpr(origFormatExpr),
Ted Kremenek6ee76532010-03-25 03:59:12 +00001139 FirstDataArg(firstDataArg),
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001140 NumDataArgs(numDataArgs),
Ted Kremenek0d277352010-01-29 01:06:55 +00001141 IsObjCLiteral(isObjCLiteral), Beg(beg),
1142 HasVAListArg(hasVAListArg),
Ted Kremenekefaff192010-02-27 01:41:03 +00001143 TheCall(theCall), FormatIdx(formatIdx),
1144 usesPositionalArgs(false), atFirstArg(true) {
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001145 CoveredArgs.resize(numDataArgs);
1146 CoveredArgs.reset();
1147 }
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001148
Ted Kremenek07d161f2010-01-29 01:50:07 +00001149 void DoneProcessing();
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001150
Ted Kremenek826a3452010-07-16 02:11:22 +00001151 void HandleIncompleteSpecifier(const char *startSpecifier,
1152 unsigned specifierLen);
1153
Ted Kremenekefaff192010-02-27 01:41:03 +00001154 virtual void HandleInvalidPosition(const char *startSpecifier,
1155 unsigned specifierLen,
Ted Kremenek826a3452010-07-16 02:11:22 +00001156 analyze_format_string::PositionContext p);
Ted Kremenekefaff192010-02-27 01:41:03 +00001157
1158 virtual void HandleZeroPosition(const char *startPos, unsigned posLen);
1159
Ted Kremeneke0e53132010-01-28 23:39:18 +00001160 void HandleNullChar(const char *nullCharacter);
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001161
Ted Kremenek826a3452010-07-16 02:11:22 +00001162protected:
Ted Kremenekf88c8e02010-01-29 20:55:36 +00001163 SourceRange getFormatStringRange();
Ted Kremenek826a3452010-07-16 02:11:22 +00001164 CharSourceRange getSpecifierRange(const char *startSpecifier,
1165 unsigned specifierLen);
Ted Kremeneke0e53132010-01-28 23:39:18 +00001166 SourceLocation getLocationOfByte(const char *x);
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001167
Ted Kremenek0d277352010-01-29 01:06:55 +00001168 const Expr *getDataArg(unsigned i) const;
Ted Kremeneke0e53132010-01-28 23:39:18 +00001169};
1170}
1171
Ted Kremenek826a3452010-07-16 02:11:22 +00001172SourceRange CheckFormatHandler::getFormatStringRange() {
Ted Kremeneke0e53132010-01-28 23:39:18 +00001173 return OrigFormatExpr->getSourceRange();
1174}
1175
Ted Kremenek826a3452010-07-16 02:11:22 +00001176CharSourceRange CheckFormatHandler::
1177getSpecifierRange(const char *startSpecifier, unsigned specifierLen) {
Tom Care45f9b7e2010-06-21 21:21:01 +00001178 SourceLocation Start = getLocationOfByte(startSpecifier);
1179 SourceLocation End = getLocationOfByte(startSpecifier + specifierLen - 1);
1180
1181 // Advance the end SourceLocation by one due to half-open ranges.
1182 End = End.getFileLocWithOffset(1);
1183
1184 return CharSourceRange::getCharRange(Start, End);
Ted Kremenekf88c8e02010-01-29 20:55:36 +00001185}
1186
Ted Kremenek826a3452010-07-16 02:11:22 +00001187SourceLocation CheckFormatHandler::getLocationOfByte(const char *x) {
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001188 return S.getLocationOfStringLiteralByte(FExpr, x - Beg);
Ted Kremeneke0e53132010-01-28 23:39:18 +00001189}
1190
Ted Kremenek826a3452010-07-16 02:11:22 +00001191void CheckFormatHandler::HandleIncompleteSpecifier(const char *startSpecifier,
1192 unsigned specifierLen){
Ted Kremenek808015a2010-01-29 03:16:21 +00001193 SourceLocation Loc = getLocationOfByte(startSpecifier);
1194 S.Diag(Loc, diag::warn_printf_incomplete_specifier)
Ted Kremenek826a3452010-07-16 02:11:22 +00001195 << getSpecifierRange(startSpecifier, specifierLen);
Ted Kremenek808015a2010-01-29 03:16:21 +00001196}
1197
Ted Kremenekefaff192010-02-27 01:41:03 +00001198void
Ted Kremenek826a3452010-07-16 02:11:22 +00001199CheckFormatHandler::HandleInvalidPosition(const char *startPos, unsigned posLen,
1200 analyze_format_string::PositionContext p) {
Ted Kremenekefaff192010-02-27 01:41:03 +00001201 SourceLocation Loc = getLocationOfByte(startPos);
Ted Kremenek826a3452010-07-16 02:11:22 +00001202 S.Diag(Loc, diag::warn_format_invalid_positional_specifier)
1203 << (unsigned) p << getSpecifierRange(startPos, posLen);
Ted Kremenekefaff192010-02-27 01:41:03 +00001204}
1205
Ted Kremenek826a3452010-07-16 02:11:22 +00001206void CheckFormatHandler::HandleZeroPosition(const char *startPos,
Ted Kremenekefaff192010-02-27 01:41:03 +00001207 unsigned posLen) {
1208 SourceLocation Loc = getLocationOfByte(startPos);
Ted Kremenek826a3452010-07-16 02:11:22 +00001209 S.Diag(Loc, diag::warn_format_zero_positional_specifier)
1210 << getSpecifierRange(startPos, posLen);
Ted Kremenekefaff192010-02-27 01:41:03 +00001211}
1212
Ted Kremenek826a3452010-07-16 02:11:22 +00001213void CheckFormatHandler::HandleNullChar(const char *nullCharacter) {
1214 // The presence of a null character is likely an error.
1215 S.Diag(getLocationOfByte(nullCharacter),
1216 diag::warn_printf_format_string_contains_null_char)
1217 << getFormatStringRange();
1218}
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001219
Ted Kremenek826a3452010-07-16 02:11:22 +00001220const Expr *CheckFormatHandler::getDataArg(unsigned i) const {
1221 return TheCall->getArg(FirstDataArg + i);
1222}
1223
1224void CheckFormatHandler::DoneProcessing() {
1225 // Does the number of data arguments exceed the number of
1226 // format conversions in the format string?
1227 if (!HasVAListArg) {
1228 // Find any arguments that weren't covered.
1229 CoveredArgs.flip();
1230 signed notCoveredArg = CoveredArgs.find_first();
1231 if (notCoveredArg >= 0) {
1232 assert((unsigned)notCoveredArg < NumDataArgs);
1233 S.Diag(getDataArg((unsigned) notCoveredArg)->getLocStart(),
1234 diag::warn_printf_data_arg_not_used)
1235 << getFormatStringRange();
1236 }
1237 }
1238}
1239
1240//===--- CHECK: Printf format string checking ------------------------------===//
1241
1242namespace {
1243class CheckPrintfHandler : public CheckFormatHandler {
1244public:
1245 CheckPrintfHandler(Sema &s, const StringLiteral *fexpr,
1246 const Expr *origFormatExpr, unsigned firstDataArg,
1247 unsigned numDataArgs, bool isObjCLiteral,
1248 const char *beg, bool hasVAListArg,
1249 const CallExpr *theCall, unsigned formatIdx)
1250 : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg,
1251 numDataArgs, isObjCLiteral, beg, hasVAListArg,
1252 theCall, formatIdx) {}
1253
1254
1255 bool HandleInvalidPrintfConversionSpecifier(
1256 const analyze_printf::PrintfSpecifier &FS,
1257 const char *startSpecifier,
1258 unsigned specifierLen);
1259
1260 bool HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier &FS,
1261 const char *startSpecifier,
1262 unsigned specifierLen);
1263
1264 bool HandleAmount(const analyze_format_string::OptionalAmount &Amt, unsigned k,
1265 const char *startSpecifier, unsigned specifierLen);
1266 void HandleInvalidAmount(const analyze_printf::PrintfSpecifier &FS,
1267 const analyze_printf::OptionalAmount &Amt,
1268 unsigned type,
1269 const char *startSpecifier, unsigned specifierLen);
1270 void HandleFlag(const analyze_printf::PrintfSpecifier &FS,
1271 const analyze_printf::OptionalFlag &flag,
1272 const char *startSpecifier, unsigned specifierLen);
1273 void HandleIgnoredFlag(const analyze_printf::PrintfSpecifier &FS,
1274 const analyze_printf::OptionalFlag &ignoredFlag,
1275 const analyze_printf::OptionalFlag &flag,
1276 const char *startSpecifier, unsigned specifierLen);
1277};
1278}
1279
1280bool CheckPrintfHandler::HandleInvalidPrintfConversionSpecifier(
1281 const analyze_printf::PrintfSpecifier &FS,
1282 const char *startSpecifier,
1283 unsigned specifierLen) {
1284
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001285 unsigned argIndex = FS.getArgIndex();
1286 bool keepGoing = true;
1287 if (argIndex < NumDataArgs) {
Ted Kremenek826a3452010-07-16 02:11:22 +00001288 // Consider the argument coverered, even though the specifier doesn't
1289 // make sense.
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001290 CoveredArgs.set(argIndex);
1291 }
1292 else {
1293 // If argIndex exceeds the number of data arguments we
1294 // don't issue a warning because that is just a cascade of warnings (and
1295 // they may have intended '%%' anyway). We don't want to continue processing
1296 // the format string after this point, however, as we will like just get
1297 // gibberish when trying to match arguments.
1298 keepGoing = false;
1299 }
Ted Kremenek826a3452010-07-16 02:11:22 +00001300
Ted Kremenek808015a2010-01-29 03:16:21 +00001301 const analyze_printf::ConversionSpecifier &CS =
Ted Kremenek826a3452010-07-16 02:11:22 +00001302 FS.getConversionSpecifier();
Ted Kremenek808015a2010-01-29 03:16:21 +00001303 SourceLocation Loc = getLocationOfByte(CS.getStart());
Ted Kremenek26ac2e02010-01-29 02:40:24 +00001304 S.Diag(Loc, diag::warn_printf_invalid_conversion)
Ted Kremenek826a3452010-07-16 02:11:22 +00001305 << llvm::StringRef(CS.getStart(), CS.getLength())
1306 << getSpecifierRange(startSpecifier, specifierLen);
1307
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001308 return keepGoing;
Ted Kremenek26ac2e02010-01-29 02:40:24 +00001309}
1310
Ted Kremenek826a3452010-07-16 02:11:22 +00001311bool CheckPrintfHandler::HandleAmount(
1312 const analyze_format_string::OptionalAmount &Amt,
1313 unsigned k, const char *startSpecifier,
1314 unsigned specifierLen) {
Ted Kremenek0d277352010-01-29 01:06:55 +00001315
1316 if (Amt.hasDataArgument()) {
Ted Kremenek0d277352010-01-29 01:06:55 +00001317 if (!HasVAListArg) {
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001318 unsigned argIndex = Amt.getArgIndex();
1319 if (argIndex >= NumDataArgs) {
Ted Kremenekefaff192010-02-27 01:41:03 +00001320 S.Diag(getLocationOfByte(Amt.getStart()),
1321 diag::warn_printf_asterisk_missing_arg)
Ted Kremenek826a3452010-07-16 02:11:22 +00001322 << k << getSpecifierRange(startSpecifier, specifierLen);
Ted Kremenek0d277352010-01-29 01:06:55 +00001323 // Don't do any more checking. We will just emit
1324 // spurious errors.
1325 return false;
1326 }
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001327
Ted Kremenek0d277352010-01-29 01:06:55 +00001328 // Type check the data argument. It should be an 'int'.
Ted Kremenek31f8e322010-01-29 23:32:22 +00001329 // Although not in conformance with C99, we also allow the argument to be
1330 // an 'unsigned int' as that is a reasonably safe case. GCC also
1331 // doesn't emit a warning for that case.
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001332 CoveredArgs.set(argIndex);
1333 const Expr *Arg = getDataArg(argIndex);
Ted Kremenek0d277352010-01-29 01:06:55 +00001334 QualType T = Arg->getType();
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001335
1336 const analyze_printf::ArgTypeResult &ATR = Amt.getArgType(S.Context);
1337 assert(ATR.isValid());
1338
1339 if (!ATR.matchesType(S.Context, T)) {
Ted Kremenekefaff192010-02-27 01:41:03 +00001340 S.Diag(getLocationOfByte(Amt.getStart()),
1341 diag::warn_printf_asterisk_wrong_type)
1342 << k
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001343 << ATR.getRepresentativeType(S.Context) << T
Ted Kremenek826a3452010-07-16 02:11:22 +00001344 << getSpecifierRange(startSpecifier, specifierLen)
Ted Kremenekd635c5f2010-01-30 00:49:51 +00001345 << Arg->getSourceRange();
Ted Kremenek0d277352010-01-29 01:06:55 +00001346 // Don't do any more checking. We will just emit
1347 // spurious errors.
1348 return false;
1349 }
1350 }
1351 }
1352 return true;
1353}
Ted Kremenek0d277352010-01-29 01:06:55 +00001354
Tom Caree4ee9662010-06-17 19:00:27 +00001355void CheckPrintfHandler::HandleInvalidAmount(
Ted Kremenek826a3452010-07-16 02:11:22 +00001356 const analyze_printf::PrintfSpecifier &FS,
Tom Caree4ee9662010-06-17 19:00:27 +00001357 const analyze_printf::OptionalAmount &Amt,
1358 unsigned type,
1359 const char *startSpecifier,
1360 unsigned specifierLen) {
1361 const analyze_printf::ConversionSpecifier &CS = FS.getConversionSpecifier();
1362 switch (Amt.getHowSpecified()) {
1363 case analyze_printf::OptionalAmount::Constant:
1364 S.Diag(getLocationOfByte(Amt.getStart()),
1365 diag::warn_printf_nonsensical_optional_amount)
1366 << type
1367 << CS.toString()
Ted Kremenek826a3452010-07-16 02:11:22 +00001368 << getSpecifierRange(startSpecifier, specifierLen)
1369 << FixItHint::CreateRemoval(getSpecifierRange(Amt.getStart(),
Tom Caree4ee9662010-06-17 19:00:27 +00001370 Amt.getConstantLength()));
1371 break;
1372
1373 default:
1374 S.Diag(getLocationOfByte(Amt.getStart()),
1375 diag::warn_printf_nonsensical_optional_amount)
1376 << type
1377 << CS.toString()
Ted Kremenek826a3452010-07-16 02:11:22 +00001378 << getSpecifierRange(startSpecifier, specifierLen);
Tom Caree4ee9662010-06-17 19:00:27 +00001379 break;
1380 }
1381}
1382
Ted Kremenek826a3452010-07-16 02:11:22 +00001383void CheckPrintfHandler::HandleFlag(const analyze_printf::PrintfSpecifier &FS,
Tom Caree4ee9662010-06-17 19:00:27 +00001384 const analyze_printf::OptionalFlag &flag,
1385 const char *startSpecifier,
1386 unsigned specifierLen) {
1387 // Warn about pointless flag with a fixit removal.
1388 const analyze_printf::ConversionSpecifier &CS = FS.getConversionSpecifier();
1389 S.Diag(getLocationOfByte(flag.getPosition()),
1390 diag::warn_printf_nonsensical_flag)
1391 << flag.toString() << CS.toString()
Ted Kremenek826a3452010-07-16 02:11:22 +00001392 << getSpecifierRange(startSpecifier, specifierLen)
1393 << FixItHint::CreateRemoval(getSpecifierRange(flag.getPosition(), 1));
Tom Caree4ee9662010-06-17 19:00:27 +00001394}
1395
1396void CheckPrintfHandler::HandleIgnoredFlag(
Ted Kremenek826a3452010-07-16 02:11:22 +00001397 const analyze_printf::PrintfSpecifier &FS,
Tom Caree4ee9662010-06-17 19:00:27 +00001398 const analyze_printf::OptionalFlag &ignoredFlag,
1399 const analyze_printf::OptionalFlag &flag,
1400 const char *startSpecifier,
1401 unsigned specifierLen) {
1402 // Warn about ignored flag with a fixit removal.
1403 S.Diag(getLocationOfByte(ignoredFlag.getPosition()),
1404 diag::warn_printf_ignored_flag)
1405 << ignoredFlag.toString() << flag.toString()
Ted Kremenek826a3452010-07-16 02:11:22 +00001406 << getSpecifierRange(startSpecifier, specifierLen)
1407 << FixItHint::CreateRemoval(getSpecifierRange(
Tom Caree4ee9662010-06-17 19:00:27 +00001408 ignoredFlag.getPosition(), 1));
1409}
1410
Ted Kremeneke0e53132010-01-28 23:39:18 +00001411bool
Ted Kremenek826a3452010-07-16 02:11:22 +00001412CheckPrintfHandler::HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier
Ted Kremenek5c41ee82010-02-11 09:27:41 +00001413 &FS,
Ted Kremeneke0e53132010-01-28 23:39:18 +00001414 const char *startSpecifier,
1415 unsigned specifierLen) {
1416
Ted Kremenekefaff192010-02-27 01:41:03 +00001417 using namespace analyze_printf;
Ted Kremeneke0e53132010-01-28 23:39:18 +00001418 const ConversionSpecifier &CS = FS.getConversionSpecifier();
1419
Ted Kremenekefaff192010-02-27 01:41:03 +00001420 if (atFirstArg) {
1421 atFirstArg = false;
1422 usesPositionalArgs = FS.usesPositionalArg();
1423 }
1424 else if (usesPositionalArgs != FS.usesPositionalArg()) {
1425 // Cannot mix-and-match positional and non-positional arguments.
1426 S.Diag(getLocationOfByte(CS.getStart()),
Ted Kremenek826a3452010-07-16 02:11:22 +00001427 diag::warn_format_mix_positional_nonpositional_args)
1428 << getSpecifierRange(startSpecifier, specifierLen);
Ted Kremenek0d277352010-01-29 01:06:55 +00001429 return false;
1430 }
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001431
Ted Kremenekefaff192010-02-27 01:41:03 +00001432 // First check if the field width, precision, and conversion specifier
1433 // have matching data arguments.
1434 if (!HandleAmount(FS.getFieldWidth(), /* field width */ 0,
1435 startSpecifier, specifierLen)) {
1436 return false;
1437 }
1438
1439 if (!HandleAmount(FS.getPrecision(), /* precision */ 1,
1440 startSpecifier, specifierLen)) {
Ted Kremenek0d277352010-01-29 01:06:55 +00001441 return false;
1442 }
1443
Ted Kremenekf88c8e02010-01-29 20:55:36 +00001444 if (!CS.consumesDataArgument()) {
1445 // FIXME: Technically specifying a precision or field width here
1446 // makes no sense. Worth issuing a warning at some point.
Ted Kremenek0e5675d2010-02-10 02:16:30 +00001447 return true;
Ted Kremenekf88c8e02010-01-29 20:55:36 +00001448 }
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001449
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001450 // Consume the argument.
1451 unsigned argIndex = FS.getArgIndex();
Ted Kremeneke3fc5472010-02-27 08:34:51 +00001452 if (argIndex < NumDataArgs) {
1453 // The check to see if the argIndex is valid will come later.
1454 // We set the bit here because we may exit early from this
1455 // function if we encounter some other error.
1456 CoveredArgs.set(argIndex);
1457 }
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001458
1459 // Check for using an Objective-C specific conversion specifier
1460 // in a non-ObjC literal.
1461 if (!IsObjCLiteral && CS.isObjCArg()) {
Ted Kremenek826a3452010-07-16 02:11:22 +00001462 return HandleInvalidPrintfConversionSpecifier(FS, startSpecifier,
1463 specifierLen);
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001464 }
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001465
Tom Caree4ee9662010-06-17 19:00:27 +00001466 // Check for invalid use of field width
1467 if (!FS.hasValidFieldWidth()) {
Tom Care45f9b7e2010-06-21 21:21:01 +00001468 HandleInvalidAmount(FS, FS.getFieldWidth(), /* field width */ 0,
Tom Caree4ee9662010-06-17 19:00:27 +00001469 startSpecifier, specifierLen);
1470 }
1471
1472 // Check for invalid use of precision
1473 if (!FS.hasValidPrecision()) {
1474 HandleInvalidAmount(FS, FS.getPrecision(), /* precision */ 1,
1475 startSpecifier, specifierLen);
1476 }
1477
1478 // Check each flag does not conflict with any other component.
1479 if (!FS.hasValidLeadingZeros())
1480 HandleFlag(FS, FS.hasLeadingZeros(), startSpecifier, specifierLen);
1481 if (!FS.hasValidPlusPrefix())
1482 HandleFlag(FS, FS.hasPlusPrefix(), startSpecifier, specifierLen);
Tom Care45f9b7e2010-06-21 21:21:01 +00001483 if (!FS.hasValidSpacePrefix())
1484 HandleFlag(FS, FS.hasSpacePrefix(), startSpecifier, specifierLen);
Tom Caree4ee9662010-06-17 19:00:27 +00001485 if (!FS.hasValidAlternativeForm())
1486 HandleFlag(FS, FS.hasAlternativeForm(), startSpecifier, specifierLen);
1487 if (!FS.hasValidLeftJustified())
1488 HandleFlag(FS, FS.isLeftJustified(), startSpecifier, specifierLen);
1489
1490 // Check that flags are not ignored by another flag
Tom Care45f9b7e2010-06-21 21:21:01 +00001491 if (FS.hasSpacePrefix() && FS.hasPlusPrefix()) // ' ' ignored by '+'
1492 HandleIgnoredFlag(FS, FS.hasSpacePrefix(), FS.hasPlusPrefix(),
1493 startSpecifier, specifierLen);
Tom Caree4ee9662010-06-17 19:00:27 +00001494 if (FS.hasLeadingZeros() && FS.isLeftJustified()) // '0' ignored by '-'
1495 HandleIgnoredFlag(FS, FS.hasLeadingZeros(), FS.isLeftJustified(),
1496 startSpecifier, specifierLen);
1497
1498 // Check the length modifier is valid with the given conversion specifier.
1499 const LengthModifier &LM = FS.getLengthModifier();
1500 if (!FS.hasValidLengthModifier())
1501 S.Diag(getLocationOfByte(LM.getStart()),
1502 diag::warn_printf_nonsensical_length)
1503 << LM.toString() << CS.toString()
Ted Kremenek826a3452010-07-16 02:11:22 +00001504 << getSpecifierRange(startSpecifier, specifierLen)
1505 << FixItHint::CreateRemoval(getSpecifierRange(LM.getStart(),
Tom Caree4ee9662010-06-17 19:00:27 +00001506 LM.getLength()));
1507
1508 // Are we using '%n'?
Ted Kremeneke82d8042010-01-29 01:35:25 +00001509 if (CS.getKind() == ConversionSpecifier::OutIntPtrArg) {
Tom Caree4ee9662010-06-17 19:00:27 +00001510 // Issue a warning about this being a possible security issue.
Ted Kremeneke82d8042010-01-29 01:35:25 +00001511 S.Diag(getLocationOfByte(CS.getStart()), diag::warn_printf_write_back)
Ted Kremenek826a3452010-07-16 02:11:22 +00001512 << getSpecifierRange(startSpecifier, specifierLen);
Ted Kremeneke82d8042010-01-29 01:35:25 +00001513 // Continue checking the other format specifiers.
1514 return true;
1515 }
Ted Kremenek5c41ee82010-02-11 09:27:41 +00001516
Ted Kremenekda51f0d2010-01-29 01:43:31 +00001517 // The remaining checks depend on the data arguments.
1518 if (HasVAListArg)
1519 return true;
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001520
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001521 if (argIndex >= NumDataArgs) {
Ted Kremenek6ee76532010-03-25 03:59:12 +00001522 if (FS.usesPositionalArg()) {
1523 S.Diag(getLocationOfByte(CS.getStart()),
1524 diag::warn_printf_positional_arg_exceeds_data_args)
1525 << (argIndex+1) << NumDataArgs
Ted Kremenek826a3452010-07-16 02:11:22 +00001526 << getSpecifierRange(startSpecifier, specifierLen);
Ted Kremenek6ee76532010-03-25 03:59:12 +00001527 }
1528 else {
1529 S.Diag(getLocationOfByte(CS.getStart()),
1530 diag::warn_printf_insufficient_data_args)
Ted Kremenek826a3452010-07-16 02:11:22 +00001531 << getSpecifierRange(startSpecifier, specifierLen);
Ted Kremenek6ee76532010-03-25 03:59:12 +00001532 }
1533
Ted Kremenekda51f0d2010-01-29 01:43:31 +00001534 // Don't do any more checking.
1535 return false;
1536 }
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001537
Ted Kremenekd635c5f2010-01-30 00:49:51 +00001538 // Now type check the data expression that matches the
1539 // format specifier.
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001540 const Expr *Ex = getDataArg(argIndex);
Ted Kremenekd635c5f2010-01-30 00:49:51 +00001541 const analyze_printf::ArgTypeResult &ATR = FS.getArgType(S.Context);
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001542 if (ATR.isValid() && !ATR.matchesType(S.Context, Ex->getType())) {
1543 // Check if we didn't match because of an implicit cast from a 'char'
1544 // or 'short' to an 'int'. This is done because printf is a varargs
1545 // function.
1546 if (const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Ex))
1547 if (ICE->getType() == S.Context.IntTy)
1548 if (ATR.matchesType(S.Context, ICE->getSubExpr()->getType()))
1549 return true;
Ted Kremenek105d41c2010-02-01 19:38:10 +00001550
Tom Care3bfc5f42010-06-09 04:11:11 +00001551 // We may be able to offer a FixItHint if it is a supported type.
Ted Kremenek826a3452010-07-16 02:11:22 +00001552 PrintfSpecifier fixedFS = FS;
Tom Care3bfc5f42010-06-09 04:11:11 +00001553 bool success = fixedFS.fixType(Ex->getType());
1554
1555 if (success) {
1556 // Get the fix string from the fixed format specifier
1557 llvm::SmallString<128> buf;
1558 llvm::raw_svector_ostream os(buf);
1559 fixedFS.toString(os);
1560
1561 S.Diag(getLocationOfByte(CS.getStart()),
1562 diag::warn_printf_conversion_argument_type_mismatch)
1563 << ATR.getRepresentativeType(S.Context) << Ex->getType()
Ted Kremenek826a3452010-07-16 02:11:22 +00001564 << getSpecifierRange(startSpecifier, specifierLen)
Tom Care3bfc5f42010-06-09 04:11:11 +00001565 << Ex->getSourceRange()
1566 << FixItHint::CreateReplacement(
Ted Kremenek826a3452010-07-16 02:11:22 +00001567 getSpecifierRange(startSpecifier, specifierLen),
Tom Care3bfc5f42010-06-09 04:11:11 +00001568 os.str());
1569 }
1570 else {
1571 S.Diag(getLocationOfByte(CS.getStart()),
1572 diag::warn_printf_conversion_argument_type_mismatch)
1573 << ATR.getRepresentativeType(S.Context) << Ex->getType()
Ted Kremenek826a3452010-07-16 02:11:22 +00001574 << getSpecifierRange(startSpecifier, specifierLen)
Tom Care3bfc5f42010-06-09 04:11:11 +00001575 << Ex->getSourceRange();
1576 }
Ted Kremenekd635c5f2010-01-30 00:49:51 +00001577 }
Ted Kremeneke0e53132010-01-28 23:39:18 +00001578
1579 return true;
1580}
1581
Ted Kremenek826a3452010-07-16 02:11:22 +00001582//===--- CHECK: Scanf format string checking ------------------------------===//
1583
1584namespace {
1585class CheckScanfHandler : public CheckFormatHandler {
1586public:
1587 CheckScanfHandler(Sema &s, const StringLiteral *fexpr,
1588 const Expr *origFormatExpr, unsigned firstDataArg,
1589 unsigned numDataArgs, bool isObjCLiteral,
1590 const char *beg, bool hasVAListArg,
1591 const CallExpr *theCall, unsigned formatIdx)
1592 : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg,
1593 numDataArgs, isObjCLiteral, beg, hasVAListArg,
1594 theCall, formatIdx) {}
1595
1596 bool HandleScanfSpecifier(const analyze_scanf::ScanfSpecifier &FS,
1597 const char *startSpecifier,
1598 unsigned specifierLen);
Ted Kremenekb7c21012010-07-16 18:28:03 +00001599
1600 void HandleIncompleteScanList(const char *start, const char *end);
Ted Kremenek826a3452010-07-16 02:11:22 +00001601};
Ted Kremenek07d161f2010-01-29 01:50:07 +00001602}
Ted Kremeneke0e53132010-01-28 23:39:18 +00001603
Ted Kremenekb7c21012010-07-16 18:28:03 +00001604void CheckScanfHandler::HandleIncompleteScanList(const char *start,
1605 const char *end) {
1606 S.Diag(getLocationOfByte(end), diag::warn_scanf_scanlist_incomplete)
1607 << getSpecifierRange(start, end - start);
1608}
1609
Ted Kremenek826a3452010-07-16 02:11:22 +00001610bool CheckScanfHandler::HandleScanfSpecifier(
1611 const analyze_scanf::ScanfSpecifier &FS,
1612 const char *startSpecifier,
1613 unsigned specifierLen) {
1614
1615 using namespace analyze_scanf;
1616 using namespace analyze_format_string;
1617
1618 const ConversionSpecifier &CS = FS.getConversionSpecifier();
1619
1620 // FIXME: Handle case where '%' and '*' don't consume an argument.
1621 // This needs to be done for the printf case as well.
1622 if (atFirstArg) {
1623 atFirstArg = false;
1624 usesPositionalArgs = FS.usesPositionalArg();
1625 }
1626 else if (usesPositionalArgs != FS.usesPositionalArg()) {
1627 // Cannot mix-and-match positional and non-positional arguments.
1628 S.Diag(getLocationOfByte(CS.getStart()),
1629 diag::warn_format_mix_positional_nonpositional_args)
1630 << getSpecifierRange(startSpecifier, specifierLen);
1631 return false;
1632 }
1633
1634 // Check if the field with is non-zero.
1635 const OptionalAmount &Amt = FS.getFieldWidth();
1636 if (Amt.getHowSpecified() == OptionalAmount::Constant) {
1637 if (Amt.getConstantAmount() == 0) {
1638 const CharSourceRange &R = getSpecifierRange(Amt.getStart(),
1639 Amt.getConstantLength());
1640 S.Diag(getLocationOfByte(Amt.getStart()),
1641 diag::warn_scanf_nonzero_width)
1642 << R << FixItHint::CreateRemoval(R);
1643 }
1644 }
1645
1646 if (!FS.consumesDataArgument()) {
1647 // FIXME: Technically specifying a precision or field width here
1648 // makes no sense. Worth issuing a warning at some point.
1649 return true;
1650 }
1651
1652 // Consume the argument.
1653 unsigned argIndex = FS.getArgIndex();
1654 if (argIndex < NumDataArgs) {
1655 // The check to see if the argIndex is valid will come later.
1656 // We set the bit here because we may exit early from this
1657 // function if we encounter some other error.
1658 CoveredArgs.set(argIndex);
1659 }
1660
1661 // FIXME: Check that the length modifier is valid with the given
1662 // conversion specifier.
1663
1664 // The remaining checks depend on the data arguments.
1665 if (HasVAListArg)
1666 return true;
1667
1668 if (argIndex >= NumDataArgs) {
1669 if (FS.usesPositionalArg()) {
1670 S.Diag(getLocationOfByte(CS.getStart()),
1671 diag::warn_printf_positional_arg_exceeds_data_args)
1672 << (argIndex+1) << NumDataArgs
1673 << getSpecifierRange(startSpecifier, specifierLen);
1674 }
1675 else {
1676 S.Diag(getLocationOfByte(CS.getStart()),
1677 diag::warn_printf_insufficient_data_args)
1678 << getSpecifierRange(startSpecifier, specifierLen);
1679 }
1680
1681 // Don't do any more checking.
1682 return false;
1683 }
1684
1685 // FIXME: Check that the argument type matches the format specifier.
1686
1687 return true;
1688}
1689
1690void Sema::CheckFormatString(const StringLiteral *FExpr,
Ted Kremenek0e5675d2010-02-10 02:16:30 +00001691 const Expr *OrigFormatExpr,
1692 const CallExpr *TheCall, bool HasVAListArg,
Ted Kremenek826a3452010-07-16 02:11:22 +00001693 unsigned format_idx, unsigned firstDataArg,
1694 bool isPrintf) {
1695
Ted Kremeneke0e53132010-01-28 23:39:18 +00001696 // CHECK: is the format string a wide literal?
1697 if (FExpr->isWide()) {
1698 Diag(FExpr->getLocStart(),
Ted Kremenek826a3452010-07-16 02:11:22 +00001699 diag::warn_format_string_is_wide_literal)
Ted Kremeneke0e53132010-01-28 23:39:18 +00001700 << OrigFormatExpr->getSourceRange();
1701 return;
1702 }
Ted Kremenek826a3452010-07-16 02:11:22 +00001703
Ted Kremeneke0e53132010-01-28 23:39:18 +00001704 // Str - The format string. NOTE: this is NOT null-terminated!
1705 const char *Str = FExpr->getStrData();
Ted Kremenek826a3452010-07-16 02:11:22 +00001706
Ted Kremeneke0e53132010-01-28 23:39:18 +00001707 // CHECK: empty format string?
1708 unsigned StrLen = FExpr->getByteLength();
Ted Kremenek826a3452010-07-16 02:11:22 +00001709
Ted Kremeneke0e53132010-01-28 23:39:18 +00001710 if (StrLen == 0) {
Ted Kremenek826a3452010-07-16 02:11:22 +00001711 Diag(FExpr->getLocStart(), diag::warn_empty_format_string)
Ted Kremeneke0e53132010-01-28 23:39:18 +00001712 << OrigFormatExpr->getSourceRange();
1713 return;
1714 }
Ted Kremenek826a3452010-07-16 02:11:22 +00001715
1716 if (isPrintf) {
1717 CheckPrintfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg,
1718 TheCall->getNumArgs() - firstDataArg,
1719 isa<ObjCStringLiteral>(OrigFormatExpr), Str,
1720 HasVAListArg, TheCall, format_idx);
1721
1722 if (!analyze_format_string::ParsePrintfString(H, Str, Str + StrLen))
1723 H.DoneProcessing();
1724 }
1725 else {
1726 CheckScanfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg,
1727 TheCall->getNumArgs() - firstDataArg,
1728 isa<ObjCStringLiteral>(OrigFormatExpr), Str,
1729 HasVAListArg, TheCall, format_idx);
1730
1731 if (!analyze_format_string::ParseScanfString(H, Str, Str + StrLen))
1732 H.DoneProcessing();
1733 }
Ted Kremenekce7024e2010-01-28 01:18:22 +00001734}
1735
Ted Kremenek06de2762007-08-17 16:46:58 +00001736//===--- CHECK: Return Address of Stack Variable --------------------------===//
1737
1738static DeclRefExpr* EvalVal(Expr *E);
1739static DeclRefExpr* EvalAddr(Expr* E);
1740
1741/// CheckReturnStackAddr - Check if a return statement returns the address
1742/// of a stack variable.
1743void
1744Sema::CheckReturnStackAddr(Expr *RetValExp, QualType lhsType,
1745 SourceLocation ReturnLoc) {
Mike Stump1eb44332009-09-09 15:08:12 +00001746
Ted Kremenek06de2762007-08-17 16:46:58 +00001747 // Perform checking for returned stack addresses.
Steve Naroffdd972f22008-09-05 22:11:13 +00001748 if (lhsType->isPointerType() || lhsType->isBlockPointerType()) {
Ted Kremenek06de2762007-08-17 16:46:58 +00001749 if (DeclRefExpr *DR = EvalAddr(RetValExp))
Chris Lattner3c73c412008-11-19 08:23:25 +00001750 Diag(DR->getLocStart(), diag::warn_ret_stack_addr)
Chris Lattner08631c52008-11-23 21:45:46 +00001751 << DR->getDecl()->getDeclName() << RetValExp->getSourceRange();
Mike Stump1eb44332009-09-09 15:08:12 +00001752
Steve Naroffc50a4a52008-09-16 22:25:10 +00001753 // Skip over implicit cast expressions when checking for block expressions.
Chris Lattner4ca606e2009-09-08 00:36:37 +00001754 RetValExp = RetValExp->IgnoreParenCasts();
Steve Naroffc50a4a52008-09-16 22:25:10 +00001755
Chris Lattner9e6b37a2009-10-30 04:01:58 +00001756 if (BlockExpr *C = dyn_cast<BlockExpr>(RetValExp))
Mike Stump397195b2009-04-17 00:09:41 +00001757 if (C->hasBlockDeclRefExprs())
1758 Diag(C->getLocStart(), diag::err_ret_local_block)
1759 << C->getSourceRange();
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001760
Chris Lattner9e6b37a2009-10-30 04:01:58 +00001761 if (AddrLabelExpr *ALE = dyn_cast<AddrLabelExpr>(RetValExp))
1762 Diag(ALE->getLocStart(), diag::warn_ret_addr_label)
1763 << ALE->getSourceRange();
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001764
Mike Stumpac5fc7c2009-08-04 21:02:39 +00001765 } else if (lhsType->isReferenceType()) {
1766 // Perform checking for stack values returned by reference.
Douglas Gregor49badde2008-10-27 19:41:14 +00001767 // Check for a reference to the stack
1768 if (DeclRefExpr *DR = EvalVal(RetValExp))
Chris Lattnerdcd5ef12008-11-19 05:27:50 +00001769 Diag(DR->getLocStart(), diag::warn_ret_stack_ref)
Chris Lattner08631c52008-11-23 21:45:46 +00001770 << DR->getDecl()->getDeclName() << RetValExp->getSourceRange();
Ted Kremenek06de2762007-08-17 16:46:58 +00001771 }
1772}
1773
1774/// EvalAddr - EvalAddr and EvalVal are mutually recursive functions that
1775/// check if the expression in a return statement evaluates to an address
1776/// to a location on the stack. The recursion is used to traverse the
1777/// AST of the return expression, with recursion backtracking when we
1778/// encounter a subexpression that (1) clearly does not lead to the address
1779/// of a stack variable or (2) is something we cannot determine leads to
1780/// the address of a stack variable based on such local checking.
1781///
Ted Kremeneke8c600f2007-08-28 17:02:55 +00001782/// EvalAddr processes expressions that are pointers that are used as
1783/// references (and not L-values). EvalVal handles all other values.
Mike Stump1eb44332009-09-09 15:08:12 +00001784/// At the base case of the recursion is a check for a DeclRefExpr* in
Ted Kremenek06de2762007-08-17 16:46:58 +00001785/// the refers to a stack variable.
1786///
1787/// This implementation handles:
1788///
1789/// * pointer-to-pointer casts
1790/// * implicit conversions from array references to pointers
1791/// * taking the address of fields
1792/// * arbitrary interplay between "&" and "*" operators
1793/// * pointer arithmetic from an address of a stack variable
1794/// * taking the address of an array element where the array is on the stack
1795static DeclRefExpr* EvalAddr(Expr *E) {
Ted Kremenek06de2762007-08-17 16:46:58 +00001796 // We should only be called for evaluating pointer expressions.
David Chisnall0f436562009-08-17 16:35:33 +00001797 assert((E->getType()->isAnyPointerType() ||
Steve Naroffdd972f22008-09-05 22:11:13 +00001798 E->getType()->isBlockPointerType() ||
Ted Kremeneka526c5c2008-01-07 19:49:32 +00001799 E->getType()->isObjCQualifiedIdType()) &&
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001800 "EvalAddr only works on pointers");
Mike Stump1eb44332009-09-09 15:08:12 +00001801
Ted Kremenek06de2762007-08-17 16:46:58 +00001802 // Our "symbolic interpreter" is just a dispatch off the currently
1803 // viewed AST node. We then recursively traverse the AST by calling
1804 // EvalAddr and EvalVal appropriately.
1805 switch (E->getStmtClass()) {
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001806 case Stmt::ParenExprClass:
1807 // Ignore parentheses.
1808 return EvalAddr(cast<ParenExpr>(E)->getSubExpr());
Ted Kremenek06de2762007-08-17 16:46:58 +00001809
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001810 case Stmt::UnaryOperatorClass: {
1811 // The only unary operator that make sense to handle here
1812 // is AddrOf. All others don't make sense as pointers.
1813 UnaryOperator *U = cast<UnaryOperator>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00001814
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001815 if (U->getOpcode() == UnaryOperator::AddrOf)
1816 return EvalVal(U->getSubExpr());
1817 else
Ted Kremenek06de2762007-08-17 16:46:58 +00001818 return NULL;
1819 }
Mike Stump1eb44332009-09-09 15:08:12 +00001820
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001821 case Stmt::BinaryOperatorClass: {
1822 // Handle pointer arithmetic. All other binary operators are not valid
1823 // in this context.
1824 BinaryOperator *B = cast<BinaryOperator>(E);
1825 BinaryOperator::Opcode op = B->getOpcode();
Mike Stump1eb44332009-09-09 15:08:12 +00001826
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001827 if (op != BinaryOperator::Add && op != BinaryOperator::Sub)
1828 return NULL;
Mike Stump1eb44332009-09-09 15:08:12 +00001829
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001830 Expr *Base = B->getLHS();
1831
1832 // Determine which argument is the real pointer base. It could be
1833 // the RHS argument instead of the LHS.
1834 if (!Base->getType()->isPointerType()) Base = B->getRHS();
Mike Stump1eb44332009-09-09 15:08:12 +00001835
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001836 assert (Base->getType()->isPointerType());
1837 return EvalAddr(Base);
1838 }
Steve Naroff61f40a22008-09-10 19:17:48 +00001839
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001840 // For conditional operators we need to see if either the LHS or RHS are
1841 // valid DeclRefExpr*s. If one of them is valid, we return it.
1842 case Stmt::ConditionalOperatorClass: {
1843 ConditionalOperator *C = cast<ConditionalOperator>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00001844
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001845 // Handle the GNU extension for missing LHS.
1846 if (Expr *lhsExpr = C->getLHS())
1847 if (DeclRefExpr* LHS = EvalAddr(lhsExpr))
1848 return LHS;
1849
1850 return EvalAddr(C->getRHS());
1851 }
Mike Stump1eb44332009-09-09 15:08:12 +00001852
Ted Kremenek54b52742008-08-07 00:49:01 +00001853 // For casts, we need to handle conversions from arrays to
1854 // pointer values, and pointer-to-pointer conversions.
Douglas Gregor49badde2008-10-27 19:41:14 +00001855 case Stmt::ImplicitCastExprClass:
Douglas Gregor6eec8e82008-10-28 15:36:24 +00001856 case Stmt::CStyleCastExprClass:
Douglas Gregor49badde2008-10-27 19:41:14 +00001857 case Stmt::CXXFunctionalCastExprClass: {
Argyrios Kyrtzidis0835a3c2008-08-18 23:01:59 +00001858 Expr* SubExpr = cast<CastExpr>(E)->getSubExpr();
Ted Kremenek54b52742008-08-07 00:49:01 +00001859 QualType T = SubExpr->getType();
Mike Stump1eb44332009-09-09 15:08:12 +00001860
Steve Naroffdd972f22008-09-05 22:11:13 +00001861 if (SubExpr->getType()->isPointerType() ||
1862 SubExpr->getType()->isBlockPointerType() ||
1863 SubExpr->getType()->isObjCQualifiedIdType())
Ted Kremenek54b52742008-08-07 00:49:01 +00001864 return EvalAddr(SubExpr);
1865 else if (T->isArrayType())
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001866 return EvalVal(SubExpr);
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001867 else
Ted Kremenek54b52742008-08-07 00:49:01 +00001868 return 0;
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001869 }
Mike Stump1eb44332009-09-09 15:08:12 +00001870
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001871 // C++ casts. For dynamic casts, static casts, and const casts, we
1872 // are always converting from a pointer-to-pointer, so we just blow
Douglas Gregor49badde2008-10-27 19:41:14 +00001873 // through the cast. In the case the dynamic cast doesn't fail (and
1874 // return NULL), we take the conservative route and report cases
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001875 // where we return the address of a stack variable. For Reinterpre
Douglas Gregor49badde2008-10-27 19:41:14 +00001876 // FIXME: The comment about is wrong; we're not always converting
1877 // from pointer to pointer. I'm guessing that this code should also
Mike Stump1eb44332009-09-09 15:08:12 +00001878 // handle references to objects.
1879 case Stmt::CXXStaticCastExprClass:
1880 case Stmt::CXXDynamicCastExprClass:
Douglas Gregor49badde2008-10-27 19:41:14 +00001881 case Stmt::CXXConstCastExprClass:
1882 case Stmt::CXXReinterpretCastExprClass: {
1883 Expr *S = cast<CXXNamedCastExpr>(E)->getSubExpr();
Steve Naroffdd972f22008-09-05 22:11:13 +00001884 if (S->getType()->isPointerType() || S->getType()->isBlockPointerType())
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001885 return EvalAddr(S);
1886 else
1887 return NULL;
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001888 }
Mike Stump1eb44332009-09-09 15:08:12 +00001889
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001890 // Everything else: we simply don't reason about them.
1891 default:
1892 return NULL;
1893 }
Ted Kremenek06de2762007-08-17 16:46:58 +00001894}
Mike Stump1eb44332009-09-09 15:08:12 +00001895
Ted Kremenek06de2762007-08-17 16:46:58 +00001896
1897/// EvalVal - This function is complements EvalAddr in the mutual recursion.
1898/// See the comments for EvalAddr for more details.
1899static DeclRefExpr* EvalVal(Expr *E) {
Mike Stump1eb44332009-09-09 15:08:12 +00001900
Ted Kremeneke8c600f2007-08-28 17:02:55 +00001901 // We should only be called for evaluating non-pointer expressions, or
1902 // expressions with a pointer type that are not used as references but instead
1903 // are l-values (e.g., DeclRefExpr with a pointer type).
Mike Stump1eb44332009-09-09 15:08:12 +00001904
Ted Kremenek06de2762007-08-17 16:46:58 +00001905 // Our "symbolic interpreter" is just a dispatch off the currently
1906 // viewed AST node. We then recursively traverse the AST by calling
1907 // EvalAddr and EvalVal appropriately.
1908 switch (E->getStmtClass()) {
Douglas Gregora2813ce2009-10-23 18:54:35 +00001909 case Stmt::DeclRefExprClass: {
Ted Kremenek06de2762007-08-17 16:46:58 +00001910 // DeclRefExpr: the base case. When we hit a DeclRefExpr we are looking
1911 // at code that refers to a variable's name. We check if it has local
1912 // storage within the function, and if so, return the expression.
1913 DeclRefExpr *DR = cast<DeclRefExpr>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00001914
Ted Kremenek06de2762007-08-17 16:46:58 +00001915 if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl()))
Mike Stump1eb44332009-09-09 15:08:12 +00001916 if (V->hasLocalStorage() && !V->getType()->isReferenceType()) return DR;
1917
Ted Kremenek06de2762007-08-17 16:46:58 +00001918 return NULL;
1919 }
Mike Stump1eb44332009-09-09 15:08:12 +00001920
Ted Kremenek06de2762007-08-17 16:46:58 +00001921 case Stmt::ParenExprClass:
1922 // Ignore parentheses.
1923 return EvalVal(cast<ParenExpr>(E)->getSubExpr());
Mike Stump1eb44332009-09-09 15:08:12 +00001924
Ted Kremenek06de2762007-08-17 16:46:58 +00001925 case Stmt::UnaryOperatorClass: {
1926 // The only unary operator that make sense to handle here
1927 // is Deref. All others don't resolve to a "name." This includes
1928 // handling all sorts of rvalues passed to a unary operator.
1929 UnaryOperator *U = cast<UnaryOperator>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00001930
Ted Kremenek06de2762007-08-17 16:46:58 +00001931 if (U->getOpcode() == UnaryOperator::Deref)
1932 return EvalAddr(U->getSubExpr());
1933
1934 return NULL;
1935 }
Mike Stump1eb44332009-09-09 15:08:12 +00001936
Ted Kremenek06de2762007-08-17 16:46:58 +00001937 case Stmt::ArraySubscriptExprClass: {
1938 // Array subscripts are potential references to data on the stack. We
1939 // retrieve the DeclRefExpr* for the array variable if it indeed
1940 // has local storage.
Ted Kremenek23245122007-08-20 16:18:38 +00001941 return EvalAddr(cast<ArraySubscriptExpr>(E)->getBase());
Ted Kremenek06de2762007-08-17 16:46:58 +00001942 }
Mike Stump1eb44332009-09-09 15:08:12 +00001943
Ted Kremenek06de2762007-08-17 16:46:58 +00001944 case Stmt::ConditionalOperatorClass: {
1945 // For conditional operators we need to see if either the LHS or RHS are
1946 // non-NULL DeclRefExpr's. If one is non-NULL, we return it.
1947 ConditionalOperator *C = cast<ConditionalOperator>(E);
1948
Anders Carlsson39073232007-11-30 19:04:31 +00001949 // Handle the GNU extension for missing LHS.
1950 if (Expr *lhsExpr = C->getLHS())
1951 if (DeclRefExpr *LHS = EvalVal(lhsExpr))
1952 return LHS;
1953
1954 return EvalVal(C->getRHS());
Ted Kremenek06de2762007-08-17 16:46:58 +00001955 }
Mike Stump1eb44332009-09-09 15:08:12 +00001956
Ted Kremenek06de2762007-08-17 16:46:58 +00001957 // Accesses to members are potential references to data on the stack.
Douglas Gregor83f6faf2009-08-31 23:41:50 +00001958 case Stmt::MemberExprClass: {
Ted Kremenek06de2762007-08-17 16:46:58 +00001959 MemberExpr *M = cast<MemberExpr>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00001960
Ted Kremenek06de2762007-08-17 16:46:58 +00001961 // Check for indirect access. We only want direct field accesses.
1962 if (!M->isArrow())
1963 return EvalVal(M->getBase());
1964 else
1965 return NULL;
1966 }
Mike Stump1eb44332009-09-09 15:08:12 +00001967
Ted Kremenek06de2762007-08-17 16:46:58 +00001968 // Everything else: we simply don't reason about them.
1969 default:
1970 return NULL;
1971 }
1972}
Ted Kremenek588e5eb2007-11-25 00:58:00 +00001973
1974//===--- CHECK: Floating-Point comparisons (-Wfloat-equal) ---------------===//
1975
1976/// Check for comparisons of floating point operands using != and ==.
1977/// Issue a warning if these are no self-comparisons, as they are not likely
1978/// to do what the programmer intended.
1979void Sema::CheckFloatComparison(SourceLocation loc, Expr* lex, Expr *rex) {
1980 bool EmitWarning = true;
Mike Stump1eb44332009-09-09 15:08:12 +00001981
Ted Kremenek4e99a5f2008-01-17 16:57:34 +00001982 Expr* LeftExprSansParen = lex->IgnoreParens();
Ted Kremenek32e97b62008-01-17 17:55:13 +00001983 Expr* RightExprSansParen = rex->IgnoreParens();
Ted Kremenek588e5eb2007-11-25 00:58:00 +00001984
1985 // Special case: check for x == x (which is OK).
1986 // Do not emit warnings for such cases.
1987 if (DeclRefExpr* DRL = dyn_cast<DeclRefExpr>(LeftExprSansParen))
1988 if (DeclRefExpr* DRR = dyn_cast<DeclRefExpr>(RightExprSansParen))
1989 if (DRL->getDecl() == DRR->getDecl())
1990 EmitWarning = false;
Mike Stump1eb44332009-09-09 15:08:12 +00001991
1992
Ted Kremenek1b500bb2007-11-29 00:59:04 +00001993 // Special case: check for comparisons against literals that can be exactly
1994 // represented by APFloat. In such cases, do not emit a warning. This
1995 // is a heuristic: often comparison against such literals are used to
1996 // detect if a value in a variable has not changed. This clearly can
1997 // lead to false negatives.
1998 if (EmitWarning) {
1999 if (FloatingLiteral* FLL = dyn_cast<FloatingLiteral>(LeftExprSansParen)) {
2000 if (FLL->isExact())
2001 EmitWarning = false;
Mike Stumpac5fc7c2009-08-04 21:02:39 +00002002 } else
Ted Kremenek1b500bb2007-11-29 00:59:04 +00002003 if (FloatingLiteral* FLR = dyn_cast<FloatingLiteral>(RightExprSansParen)){
2004 if (FLR->isExact())
2005 EmitWarning = false;
2006 }
2007 }
Mike Stump1eb44332009-09-09 15:08:12 +00002008
Ted Kremenek588e5eb2007-11-25 00:58:00 +00002009 // Check for comparisons with builtin types.
Sebastian Redl0eb23302009-01-19 00:08:26 +00002010 if (EmitWarning)
Ted Kremenek588e5eb2007-11-25 00:58:00 +00002011 if (CallExpr* CL = dyn_cast<CallExpr>(LeftExprSansParen))
Douglas Gregor3c385e52009-02-14 18:57:46 +00002012 if (CL->isBuiltinCall(Context))
Ted Kremenek588e5eb2007-11-25 00:58:00 +00002013 EmitWarning = false;
Mike Stump1eb44332009-09-09 15:08:12 +00002014
Sebastian Redl0eb23302009-01-19 00:08:26 +00002015 if (EmitWarning)
Ted Kremenek588e5eb2007-11-25 00:58:00 +00002016 if (CallExpr* CR = dyn_cast<CallExpr>(RightExprSansParen))
Douglas Gregor3c385e52009-02-14 18:57:46 +00002017 if (CR->isBuiltinCall(Context))
Ted Kremenek588e5eb2007-11-25 00:58:00 +00002018 EmitWarning = false;
Mike Stump1eb44332009-09-09 15:08:12 +00002019
Ted Kremenek588e5eb2007-11-25 00:58:00 +00002020 // Emit the diagnostic.
2021 if (EmitWarning)
Chris Lattnerfa25bbb2008-11-19 05:08:23 +00002022 Diag(loc, diag::warn_floatingpoint_eq)
2023 << lex->getSourceRange() << rex->getSourceRange();
Ted Kremenek588e5eb2007-11-25 00:58:00 +00002024}
John McCallba26e582010-01-04 23:21:16 +00002025
John McCallf2370c92010-01-06 05:24:50 +00002026//===--- CHECK: Integer mixed-sign comparisons (-Wsign-compare) --------===//
2027//===--- CHECK: Lossy implicit conversions (-Wconversion) --------------===//
John McCallba26e582010-01-04 23:21:16 +00002028
John McCallf2370c92010-01-06 05:24:50 +00002029namespace {
John McCallba26e582010-01-04 23:21:16 +00002030
John McCallf2370c92010-01-06 05:24:50 +00002031/// Structure recording the 'active' range of an integer-valued
2032/// expression.
2033struct IntRange {
2034 /// The number of bits active in the int.
2035 unsigned Width;
John McCallba26e582010-01-04 23:21:16 +00002036
John McCallf2370c92010-01-06 05:24:50 +00002037 /// True if the int is known not to have negative values.
2038 bool NonNegative;
John McCallba26e582010-01-04 23:21:16 +00002039
John McCallf2370c92010-01-06 05:24:50 +00002040 IntRange() {}
2041 IntRange(unsigned Width, bool NonNegative)
2042 : Width(Width), NonNegative(NonNegative)
2043 {}
John McCallba26e582010-01-04 23:21:16 +00002044
John McCallf2370c92010-01-06 05:24:50 +00002045 // Returns the range of the bool type.
2046 static IntRange forBoolType() {
2047 return IntRange(1, true);
John McCall51313c32010-01-04 23:31:57 +00002048 }
2049
John McCallf2370c92010-01-06 05:24:50 +00002050 // Returns the range of an integral type.
2051 static IntRange forType(ASTContext &C, QualType T) {
2052 return forCanonicalType(C, T->getCanonicalTypeInternal().getTypePtr());
John McCall51313c32010-01-04 23:31:57 +00002053 }
2054
John McCallf2370c92010-01-06 05:24:50 +00002055 // Returns the range of an integeral type based on its canonical
2056 // representation.
2057 static IntRange forCanonicalType(ASTContext &C, const Type *T) {
2058 assert(T->isCanonicalUnqualified());
2059
2060 if (const VectorType *VT = dyn_cast<VectorType>(T))
2061 T = VT->getElementType().getTypePtr();
2062 if (const ComplexType *CT = dyn_cast<ComplexType>(T))
2063 T = CT->getElementType().getTypePtr();
John McCall323ed742010-05-06 08:58:33 +00002064
2065 if (const EnumType *ET = dyn_cast<EnumType>(T)) {
2066 EnumDecl *Enum = ET->getDecl();
2067 unsigned NumPositive = Enum->getNumPositiveBits();
2068 unsigned NumNegative = Enum->getNumNegativeBits();
2069
2070 return IntRange(std::max(NumPositive, NumNegative), NumNegative == 0);
2071 }
John McCallf2370c92010-01-06 05:24:50 +00002072
2073 const BuiltinType *BT = cast<BuiltinType>(T);
2074 assert(BT->isInteger());
2075
2076 return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger());
2077 }
2078
2079 // Returns the supremum of two ranges: i.e. their conservative merge.
John McCallc0cd21d2010-02-23 19:22:29 +00002080 static IntRange join(IntRange L, IntRange R) {
John McCallf2370c92010-01-06 05:24:50 +00002081 return IntRange(std::max(L.Width, R.Width),
John McCall60fad452010-01-06 22:07:33 +00002082 L.NonNegative && R.NonNegative);
2083 }
2084
2085 // Returns the infinum of two ranges: i.e. their aggressive merge.
John McCallc0cd21d2010-02-23 19:22:29 +00002086 static IntRange meet(IntRange L, IntRange R) {
John McCall60fad452010-01-06 22:07:33 +00002087 return IntRange(std::min(L.Width, R.Width),
2088 L.NonNegative || R.NonNegative);
John McCallf2370c92010-01-06 05:24:50 +00002089 }
2090};
2091
2092IntRange GetValueRange(ASTContext &C, llvm::APSInt &value, unsigned MaxWidth) {
2093 if (value.isSigned() && value.isNegative())
2094 return IntRange(value.getMinSignedBits(), false);
2095
2096 if (value.getBitWidth() > MaxWidth)
2097 value.trunc(MaxWidth);
2098
2099 // isNonNegative() just checks the sign bit without considering
2100 // signedness.
2101 return IntRange(value.getActiveBits(), true);
2102}
2103
John McCall0acc3112010-01-06 22:57:21 +00002104IntRange GetValueRange(ASTContext &C, APValue &result, QualType Ty,
John McCallf2370c92010-01-06 05:24:50 +00002105 unsigned MaxWidth) {
2106 if (result.isInt())
2107 return GetValueRange(C, result.getInt(), MaxWidth);
2108
2109 if (result.isVector()) {
John McCall0acc3112010-01-06 22:57:21 +00002110 IntRange R = GetValueRange(C, result.getVectorElt(0), Ty, MaxWidth);
2111 for (unsigned i = 1, e = result.getVectorLength(); i != e; ++i) {
2112 IntRange El = GetValueRange(C, result.getVectorElt(i), Ty, MaxWidth);
2113 R = IntRange::join(R, El);
2114 }
John McCallf2370c92010-01-06 05:24:50 +00002115 return R;
2116 }
2117
2118 if (result.isComplexInt()) {
2119 IntRange R = GetValueRange(C, result.getComplexIntReal(), MaxWidth);
2120 IntRange I = GetValueRange(C, result.getComplexIntImag(), MaxWidth);
2121 return IntRange::join(R, I);
John McCall51313c32010-01-04 23:31:57 +00002122 }
2123
2124 // This can happen with lossless casts to intptr_t of "based" lvalues.
2125 // Assume it might use arbitrary bits.
John McCall0acc3112010-01-06 22:57:21 +00002126 // FIXME: The only reason we need to pass the type in here is to get
2127 // the sign right on this one case. It would be nice if APValue
2128 // preserved this.
John McCallf2370c92010-01-06 05:24:50 +00002129 assert(result.isLValue());
John McCall0acc3112010-01-06 22:57:21 +00002130 return IntRange(MaxWidth, Ty->isUnsignedIntegerType());
John McCall51313c32010-01-04 23:31:57 +00002131}
John McCallf2370c92010-01-06 05:24:50 +00002132
2133/// Pseudo-evaluate the given integer expression, estimating the
2134/// range of values it might take.
2135///
2136/// \param MaxWidth - the width to which the value will be truncated
2137IntRange GetExprRange(ASTContext &C, Expr *E, unsigned MaxWidth) {
2138 E = E->IgnoreParens();
2139
2140 // Try a full evaluation first.
2141 Expr::EvalResult result;
2142 if (E->Evaluate(result, C))
John McCall0acc3112010-01-06 22:57:21 +00002143 return GetValueRange(C, result.Val, E->getType(), MaxWidth);
John McCallf2370c92010-01-06 05:24:50 +00002144
2145 // I think we only want to look through implicit casts here; if the
2146 // user has an explicit widening cast, we should treat the value as
2147 // being of the new, wider type.
2148 if (ImplicitCastExpr *CE = dyn_cast<ImplicitCastExpr>(E)) {
2149 if (CE->getCastKind() == CastExpr::CK_NoOp)
2150 return GetExprRange(C, CE->getSubExpr(), MaxWidth);
2151
2152 IntRange OutputTypeRange = IntRange::forType(C, CE->getType());
2153
John McCall60fad452010-01-06 22:07:33 +00002154 bool isIntegerCast = (CE->getCastKind() == CastExpr::CK_IntegralCast);
2155 if (!isIntegerCast && CE->getCastKind() == CastExpr::CK_Unknown)
2156 isIntegerCast = CE->getSubExpr()->getType()->isIntegerType();
2157
John McCallf2370c92010-01-06 05:24:50 +00002158 // Assume that non-integer casts can span the full range of the type.
John McCall60fad452010-01-06 22:07:33 +00002159 if (!isIntegerCast)
John McCallf2370c92010-01-06 05:24:50 +00002160 return OutputTypeRange;
2161
2162 IntRange SubRange
2163 = GetExprRange(C, CE->getSubExpr(),
2164 std::min(MaxWidth, OutputTypeRange.Width));
2165
2166 // Bail out if the subexpr's range is as wide as the cast type.
2167 if (SubRange.Width >= OutputTypeRange.Width)
2168 return OutputTypeRange;
2169
2170 // Otherwise, we take the smaller width, and we're non-negative if
2171 // either the output type or the subexpr is.
2172 return IntRange(SubRange.Width,
2173 SubRange.NonNegative || OutputTypeRange.NonNegative);
2174 }
2175
2176 if (ConditionalOperator *CO = dyn_cast<ConditionalOperator>(E)) {
2177 // If we can fold the condition, just take that operand.
2178 bool CondResult;
2179 if (CO->getCond()->EvaluateAsBooleanCondition(CondResult, C))
2180 return GetExprRange(C, CondResult ? CO->getTrueExpr()
2181 : CO->getFalseExpr(),
2182 MaxWidth);
2183
2184 // Otherwise, conservatively merge.
2185 IntRange L = GetExprRange(C, CO->getTrueExpr(), MaxWidth);
2186 IntRange R = GetExprRange(C, CO->getFalseExpr(), MaxWidth);
2187 return IntRange::join(L, R);
2188 }
2189
2190 if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) {
2191 switch (BO->getOpcode()) {
2192
2193 // Boolean-valued operations are single-bit and positive.
2194 case BinaryOperator::LAnd:
2195 case BinaryOperator::LOr:
2196 case BinaryOperator::LT:
2197 case BinaryOperator::GT:
2198 case BinaryOperator::LE:
2199 case BinaryOperator::GE:
2200 case BinaryOperator::EQ:
2201 case BinaryOperator::NE:
2202 return IntRange::forBoolType();
2203
John McCallc0cd21d2010-02-23 19:22:29 +00002204 // The type of these compound assignments is the type of the LHS,
2205 // so the RHS is not necessarily an integer.
2206 case BinaryOperator::MulAssign:
2207 case BinaryOperator::DivAssign:
2208 case BinaryOperator::RemAssign:
2209 case BinaryOperator::AddAssign:
2210 case BinaryOperator::SubAssign:
2211 return IntRange::forType(C, E->getType());
2212
John McCallf2370c92010-01-06 05:24:50 +00002213 // Operations with opaque sources are black-listed.
2214 case BinaryOperator::PtrMemD:
2215 case BinaryOperator::PtrMemI:
2216 return IntRange::forType(C, E->getType());
2217
John McCall60fad452010-01-06 22:07:33 +00002218 // Bitwise-and uses the *infinum* of the two source ranges.
2219 case BinaryOperator::And:
John McCallc0cd21d2010-02-23 19:22:29 +00002220 case BinaryOperator::AndAssign:
John McCall60fad452010-01-06 22:07:33 +00002221 return IntRange::meet(GetExprRange(C, BO->getLHS(), MaxWidth),
2222 GetExprRange(C, BO->getRHS(), MaxWidth));
2223
John McCallf2370c92010-01-06 05:24:50 +00002224 // Left shift gets black-listed based on a judgement call.
2225 case BinaryOperator::Shl:
John McCall3aae6092010-04-07 01:14:35 +00002226 // ...except that we want to treat '1 << (blah)' as logically
2227 // positive. It's an important idiom.
2228 if (IntegerLiteral *I
2229 = dyn_cast<IntegerLiteral>(BO->getLHS()->IgnoreParenCasts())) {
2230 if (I->getValue() == 1) {
2231 IntRange R = IntRange::forType(C, E->getType());
2232 return IntRange(R.Width, /*NonNegative*/ true);
2233 }
2234 }
2235 // fallthrough
2236
John McCallc0cd21d2010-02-23 19:22:29 +00002237 case BinaryOperator::ShlAssign:
John McCallf2370c92010-01-06 05:24:50 +00002238 return IntRange::forType(C, E->getType());
2239
John McCall60fad452010-01-06 22:07:33 +00002240 // Right shift by a constant can narrow its left argument.
John McCallc0cd21d2010-02-23 19:22:29 +00002241 case BinaryOperator::Shr:
2242 case BinaryOperator::ShrAssign: {
John McCall60fad452010-01-06 22:07:33 +00002243 IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth);
2244
2245 // If the shift amount is a positive constant, drop the width by
2246 // that much.
2247 llvm::APSInt shift;
2248 if (BO->getRHS()->isIntegerConstantExpr(shift, C) &&
2249 shift.isNonNegative()) {
2250 unsigned zext = shift.getZExtValue();
2251 if (zext >= L.Width)
2252 L.Width = (L.NonNegative ? 0 : 1);
2253 else
2254 L.Width -= zext;
2255 }
2256
2257 return L;
2258 }
2259
2260 // Comma acts as its right operand.
John McCallf2370c92010-01-06 05:24:50 +00002261 case BinaryOperator::Comma:
2262 return GetExprRange(C, BO->getRHS(), MaxWidth);
2263
John McCall60fad452010-01-06 22:07:33 +00002264 // Black-list pointer subtractions.
John McCallf2370c92010-01-06 05:24:50 +00002265 case BinaryOperator::Sub:
2266 if (BO->getLHS()->getType()->isPointerType())
2267 return IntRange::forType(C, E->getType());
2268 // fallthrough
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00002269
John McCallf2370c92010-01-06 05:24:50 +00002270 default:
2271 break;
2272 }
2273
2274 // Treat every other operator as if it were closed on the
2275 // narrowest type that encompasses both operands.
2276 IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth);
2277 IntRange R = GetExprRange(C, BO->getRHS(), MaxWidth);
2278 return IntRange::join(L, R);
2279 }
2280
2281 if (UnaryOperator *UO = dyn_cast<UnaryOperator>(E)) {
2282 switch (UO->getOpcode()) {
2283 // Boolean-valued operations are white-listed.
2284 case UnaryOperator::LNot:
2285 return IntRange::forBoolType();
2286
2287 // Operations with opaque sources are black-listed.
2288 case UnaryOperator::Deref:
2289 case UnaryOperator::AddrOf: // should be impossible
2290 case UnaryOperator::OffsetOf:
2291 return IntRange::forType(C, E->getType());
2292
2293 default:
2294 return GetExprRange(C, UO->getSubExpr(), MaxWidth);
2295 }
2296 }
Douglas Gregor8ecdb652010-04-28 22:16:22 +00002297
2298 if (dyn_cast<OffsetOfExpr>(E)) {
2299 IntRange::forType(C, E->getType());
2300 }
John McCallf2370c92010-01-06 05:24:50 +00002301
2302 FieldDecl *BitField = E->getBitField();
2303 if (BitField) {
2304 llvm::APSInt BitWidthAP = BitField->getBitWidth()->EvaluateAsInt(C);
2305 unsigned BitWidth = BitWidthAP.getZExtValue();
2306
2307 return IntRange(BitWidth, BitField->getType()->isUnsignedIntegerType());
2308 }
2309
2310 return IntRange::forType(C, E->getType());
2311}
John McCall51313c32010-01-04 23:31:57 +00002312
John McCall323ed742010-05-06 08:58:33 +00002313IntRange GetExprRange(ASTContext &C, Expr *E) {
2314 return GetExprRange(C, E, C.getIntWidth(E->getType()));
2315}
2316
John McCall51313c32010-01-04 23:31:57 +00002317/// Checks whether the given value, which currently has the given
2318/// source semantics, has the same value when coerced through the
2319/// target semantics.
John McCallf2370c92010-01-06 05:24:50 +00002320bool IsSameFloatAfterCast(const llvm::APFloat &value,
2321 const llvm::fltSemantics &Src,
2322 const llvm::fltSemantics &Tgt) {
John McCall51313c32010-01-04 23:31:57 +00002323 llvm::APFloat truncated = value;
2324
2325 bool ignored;
2326 truncated.convert(Src, llvm::APFloat::rmNearestTiesToEven, &ignored);
2327 truncated.convert(Tgt, llvm::APFloat::rmNearestTiesToEven, &ignored);
2328
2329 return truncated.bitwiseIsEqual(value);
2330}
2331
2332/// Checks whether the given value, which currently has the given
2333/// source semantics, has the same value when coerced through the
2334/// target semantics.
2335///
2336/// The value might be a vector of floats (or a complex number).
John McCallf2370c92010-01-06 05:24:50 +00002337bool IsSameFloatAfterCast(const APValue &value,
2338 const llvm::fltSemantics &Src,
2339 const llvm::fltSemantics &Tgt) {
John McCall51313c32010-01-04 23:31:57 +00002340 if (value.isFloat())
2341 return IsSameFloatAfterCast(value.getFloat(), Src, Tgt);
2342
2343 if (value.isVector()) {
2344 for (unsigned i = 0, e = value.getVectorLength(); i != e; ++i)
2345 if (!IsSameFloatAfterCast(value.getVectorElt(i), Src, Tgt))
2346 return false;
2347 return true;
2348 }
2349
2350 assert(value.isComplexFloat());
2351 return (IsSameFloatAfterCast(value.getComplexFloatReal(), Src, Tgt) &&
2352 IsSameFloatAfterCast(value.getComplexFloatImag(), Src, Tgt));
2353}
2354
John McCall323ed742010-05-06 08:58:33 +00002355void AnalyzeImplicitConversions(Sema &S, Expr *E);
2356
2357bool IsZero(Sema &S, Expr *E) {
2358 llvm::APSInt Value;
2359 return E->isIntegerConstantExpr(Value, S.Context) && Value == 0;
2360}
2361
2362void CheckTrivialUnsignedComparison(Sema &S, BinaryOperator *E) {
2363 BinaryOperator::Opcode op = E->getOpcode();
2364 if (op == BinaryOperator::LT && IsZero(S, E->getRHS())) {
2365 S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison)
2366 << "< 0" << "false"
2367 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
2368 } else if (op == BinaryOperator::GE && IsZero(S, E->getRHS())) {
2369 S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison)
2370 << ">= 0" << "true"
2371 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
2372 } else if (op == BinaryOperator::GT && IsZero(S, E->getLHS())) {
2373 S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison)
2374 << "0 >" << "false"
2375 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
2376 } else if (op == BinaryOperator::LE && IsZero(S, E->getLHS())) {
2377 S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison)
2378 << "0 <=" << "true"
2379 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
2380 }
2381}
2382
2383/// Analyze the operands of the given comparison. Implements the
2384/// fallback case from AnalyzeComparison.
2385void AnalyzeImpConvsInComparison(Sema &S, BinaryOperator *E) {
2386 AnalyzeImplicitConversions(S, E->getLHS());
2387 AnalyzeImplicitConversions(S, E->getRHS());
2388}
John McCall51313c32010-01-04 23:31:57 +00002389
John McCallba26e582010-01-04 23:21:16 +00002390/// \brief Implements -Wsign-compare.
2391///
2392/// \param lex the left-hand expression
2393/// \param rex the right-hand expression
2394/// \param OpLoc the location of the joining operator
John McCalld1b47bf2010-03-11 19:43:18 +00002395/// \param BinOpc binary opcode or 0
John McCall323ed742010-05-06 08:58:33 +00002396void AnalyzeComparison(Sema &S, BinaryOperator *E) {
2397 // The type the comparison is being performed in.
2398 QualType T = E->getLHS()->getType();
2399 assert(S.Context.hasSameUnqualifiedType(T, E->getRHS()->getType())
2400 && "comparison with mismatched types");
John McCallba26e582010-01-04 23:21:16 +00002401
John McCall323ed742010-05-06 08:58:33 +00002402 // We don't do anything special if this isn't an unsigned integral
2403 // comparison: we're only interested in integral comparisons, and
2404 // signed comparisons only happen in cases we don't care to warn about.
2405 if (!T->isUnsignedIntegerType())
2406 return AnalyzeImpConvsInComparison(S, E);
John McCallf2370c92010-01-06 05:24:50 +00002407
John McCall323ed742010-05-06 08:58:33 +00002408 Expr *lex = E->getLHS()->IgnoreParenImpCasts();
2409 Expr *rex = E->getRHS()->IgnoreParenImpCasts();
John McCallba26e582010-01-04 23:21:16 +00002410
John McCall323ed742010-05-06 08:58:33 +00002411 // Check to see if one of the (unmodified) operands is of different
2412 // signedness.
2413 Expr *signedOperand, *unsignedOperand;
2414 if (lex->getType()->isSignedIntegerType()) {
2415 assert(!rex->getType()->isSignedIntegerType() &&
2416 "unsigned comparison between two signed integer expressions?");
2417 signedOperand = lex;
2418 unsignedOperand = rex;
2419 } else if (rex->getType()->isSignedIntegerType()) {
2420 signedOperand = rex;
2421 unsignedOperand = lex;
John McCallba26e582010-01-04 23:21:16 +00002422 } else {
John McCall323ed742010-05-06 08:58:33 +00002423 CheckTrivialUnsignedComparison(S, E);
2424 return AnalyzeImpConvsInComparison(S, E);
John McCallba26e582010-01-04 23:21:16 +00002425 }
2426
John McCall323ed742010-05-06 08:58:33 +00002427 // Otherwise, calculate the effective range of the signed operand.
2428 IntRange signedRange = GetExprRange(S.Context, signedOperand);
John McCallf2370c92010-01-06 05:24:50 +00002429
John McCall323ed742010-05-06 08:58:33 +00002430 // Go ahead and analyze implicit conversions in the operands. Note
2431 // that we skip the implicit conversions on both sides.
2432 AnalyzeImplicitConversions(S, lex);
2433 AnalyzeImplicitConversions(S, rex);
John McCallba26e582010-01-04 23:21:16 +00002434
John McCall323ed742010-05-06 08:58:33 +00002435 // If the signed range is non-negative, -Wsign-compare won't fire,
2436 // but we should still check for comparisons which are always true
2437 // or false.
2438 if (signedRange.NonNegative)
2439 return CheckTrivialUnsignedComparison(S, E);
John McCallba26e582010-01-04 23:21:16 +00002440
2441 // For (in)equality comparisons, if the unsigned operand is a
2442 // constant which cannot collide with a overflowed signed operand,
2443 // then reinterpreting the signed operand as unsigned will not
2444 // change the result of the comparison.
John McCall323ed742010-05-06 08:58:33 +00002445 if (E->isEqualityOp()) {
2446 unsigned comparisonWidth = S.Context.getIntWidth(T);
2447 IntRange unsignedRange = GetExprRange(S.Context, unsignedOperand);
John McCallba26e582010-01-04 23:21:16 +00002448
John McCall323ed742010-05-06 08:58:33 +00002449 // We should never be unable to prove that the unsigned operand is
2450 // non-negative.
2451 assert(unsignedRange.NonNegative && "unsigned range includes negative?");
2452
2453 if (unsignedRange.Width < comparisonWidth)
2454 return;
2455 }
2456
2457 S.Diag(E->getOperatorLoc(), diag::warn_mixed_sign_comparison)
2458 << lex->getType() << rex->getType()
2459 << lex->getSourceRange() << rex->getSourceRange();
John McCallba26e582010-01-04 23:21:16 +00002460}
2461
John McCall51313c32010-01-04 23:31:57 +00002462/// Diagnose an implicit cast; purely a helper for CheckImplicitConversion.
John McCall323ed742010-05-06 08:58:33 +00002463void DiagnoseImpCast(Sema &S, Expr *E, QualType T, unsigned diag) {
John McCall51313c32010-01-04 23:31:57 +00002464 S.Diag(E->getExprLoc(), diag) << E->getType() << T << E->getSourceRange();
2465}
2466
John McCall323ed742010-05-06 08:58:33 +00002467void CheckImplicitConversion(Sema &S, Expr *E, QualType T,
2468 bool *ICContext = 0) {
2469 if (E->isTypeDependent() || E->isValueDependent()) return;
John McCall51313c32010-01-04 23:31:57 +00002470
John McCall323ed742010-05-06 08:58:33 +00002471 const Type *Source = S.Context.getCanonicalType(E->getType()).getTypePtr();
2472 const Type *Target = S.Context.getCanonicalType(T).getTypePtr();
2473 if (Source == Target) return;
2474 if (Target->isDependentType()) return;
John McCall51313c32010-01-04 23:31:57 +00002475
2476 // Never diagnose implicit casts to bool.
2477 if (Target->isSpecificBuiltinType(BuiltinType::Bool))
2478 return;
2479
2480 // Strip vector types.
2481 if (isa<VectorType>(Source)) {
2482 if (!isa<VectorType>(Target))
John McCall323ed742010-05-06 08:58:33 +00002483 return DiagnoseImpCast(S, E, T, diag::warn_impcast_vector_scalar);
John McCall51313c32010-01-04 23:31:57 +00002484
2485 Source = cast<VectorType>(Source)->getElementType().getTypePtr();
2486 Target = cast<VectorType>(Target)->getElementType().getTypePtr();
2487 }
2488
2489 // Strip complex types.
2490 if (isa<ComplexType>(Source)) {
2491 if (!isa<ComplexType>(Target))
John McCall323ed742010-05-06 08:58:33 +00002492 return DiagnoseImpCast(S, E, T, diag::warn_impcast_complex_scalar);
John McCall51313c32010-01-04 23:31:57 +00002493
2494 Source = cast<ComplexType>(Source)->getElementType().getTypePtr();
2495 Target = cast<ComplexType>(Target)->getElementType().getTypePtr();
2496 }
2497
2498 const BuiltinType *SourceBT = dyn_cast<BuiltinType>(Source);
2499 const BuiltinType *TargetBT = dyn_cast<BuiltinType>(Target);
2500
2501 // If the source is floating point...
2502 if (SourceBT && SourceBT->isFloatingPoint()) {
2503 // ...and the target is floating point...
2504 if (TargetBT && TargetBT->isFloatingPoint()) {
2505 // ...then warn if we're dropping FP rank.
2506
2507 // Builtin FP kinds are ordered by increasing FP rank.
2508 if (SourceBT->getKind() > TargetBT->getKind()) {
2509 // Don't warn about float constants that are precisely
2510 // representable in the target type.
2511 Expr::EvalResult result;
John McCall323ed742010-05-06 08:58:33 +00002512 if (E->Evaluate(result, S.Context)) {
John McCall51313c32010-01-04 23:31:57 +00002513 // Value might be a float, a float vector, or a float complex.
2514 if (IsSameFloatAfterCast(result.Val,
John McCall323ed742010-05-06 08:58:33 +00002515 S.Context.getFloatTypeSemantics(QualType(TargetBT, 0)),
2516 S.Context.getFloatTypeSemantics(QualType(SourceBT, 0))))
John McCall51313c32010-01-04 23:31:57 +00002517 return;
2518 }
2519
John McCall323ed742010-05-06 08:58:33 +00002520 DiagnoseImpCast(S, E, T, diag::warn_impcast_float_precision);
John McCall51313c32010-01-04 23:31:57 +00002521 }
2522 return;
2523 }
2524
2525 // If the target is integral, always warn.
2526 if ((TargetBT && TargetBT->isInteger()))
2527 // TODO: don't warn for integer values?
John McCall323ed742010-05-06 08:58:33 +00002528 DiagnoseImpCast(S, E, T, diag::warn_impcast_float_integer);
John McCall51313c32010-01-04 23:31:57 +00002529
2530 return;
2531 }
2532
John McCallf2370c92010-01-06 05:24:50 +00002533 if (!Source->isIntegerType() || !Target->isIntegerType())
John McCall51313c32010-01-04 23:31:57 +00002534 return;
2535
John McCall323ed742010-05-06 08:58:33 +00002536 IntRange SourceRange = GetExprRange(S.Context, E);
2537 IntRange TargetRange = IntRange::forCanonicalType(S.Context, Target);
John McCallf2370c92010-01-06 05:24:50 +00002538
2539 if (SourceRange.Width > TargetRange.Width) {
John McCall51313c32010-01-04 23:31:57 +00002540 // People want to build with -Wshorten-64-to-32 and not -Wconversion
2541 // and by god we'll let them.
John McCallf2370c92010-01-06 05:24:50 +00002542 if (SourceRange.Width == 64 && TargetRange.Width == 32)
John McCall323ed742010-05-06 08:58:33 +00002543 return DiagnoseImpCast(S, E, T, diag::warn_impcast_integer_64_32);
2544 return DiagnoseImpCast(S, E, T, diag::warn_impcast_integer_precision);
2545 }
2546
2547 if ((TargetRange.NonNegative && !SourceRange.NonNegative) ||
2548 (!TargetRange.NonNegative && SourceRange.NonNegative &&
2549 SourceRange.Width == TargetRange.Width)) {
2550 unsigned DiagID = diag::warn_impcast_integer_sign;
2551
2552 // Traditionally, gcc has warned about this under -Wsign-compare.
2553 // We also want to warn about it in -Wconversion.
2554 // So if -Wconversion is off, use a completely identical diagnostic
2555 // in the sign-compare group.
2556 // The conditional-checking code will
2557 if (ICContext) {
2558 DiagID = diag::warn_impcast_integer_sign_conditional;
2559 *ICContext = true;
2560 }
2561
2562 return DiagnoseImpCast(S, E, T, DiagID);
John McCall51313c32010-01-04 23:31:57 +00002563 }
2564
2565 return;
2566}
2567
John McCall323ed742010-05-06 08:58:33 +00002568void CheckConditionalOperator(Sema &S, ConditionalOperator *E, QualType T);
2569
2570void CheckConditionalOperand(Sema &S, Expr *E, QualType T,
2571 bool &ICContext) {
2572 E = E->IgnoreParenImpCasts();
2573
2574 if (isa<ConditionalOperator>(E))
2575 return CheckConditionalOperator(S, cast<ConditionalOperator>(E), T);
2576
2577 AnalyzeImplicitConversions(S, E);
2578 if (E->getType() != T)
2579 return CheckImplicitConversion(S, E, T, &ICContext);
2580 return;
2581}
2582
2583void CheckConditionalOperator(Sema &S, ConditionalOperator *E, QualType T) {
2584 AnalyzeImplicitConversions(S, E->getCond());
2585
2586 bool Suspicious = false;
2587 CheckConditionalOperand(S, E->getTrueExpr(), T, Suspicious);
2588 CheckConditionalOperand(S, E->getFalseExpr(), T, Suspicious);
2589
2590 // If -Wconversion would have warned about either of the candidates
2591 // for a signedness conversion to the context type...
2592 if (!Suspicious) return;
2593
2594 // ...but it's currently ignored...
2595 if (S.Diags.getDiagnosticLevel(diag::warn_impcast_integer_sign_conditional))
2596 return;
2597
2598 // ...and -Wsign-compare isn't...
2599 if (!S.Diags.getDiagnosticLevel(diag::warn_mixed_sign_conditional))
2600 return;
2601
2602 // ...then check whether it would have warned about either of the
2603 // candidates for a signedness conversion to the condition type.
2604 if (E->getType() != T) {
2605 Suspicious = false;
2606 CheckImplicitConversion(S, E->getTrueExpr()->IgnoreParenImpCasts(),
2607 E->getType(), &Suspicious);
2608 if (!Suspicious)
2609 CheckImplicitConversion(S, E->getFalseExpr()->IgnoreParenImpCasts(),
2610 E->getType(), &Suspicious);
2611 if (!Suspicious)
2612 return;
2613 }
2614
2615 // If so, emit a diagnostic under -Wsign-compare.
2616 Expr *lex = E->getTrueExpr()->IgnoreParenImpCasts();
2617 Expr *rex = E->getFalseExpr()->IgnoreParenImpCasts();
2618 S.Diag(E->getQuestionLoc(), diag::warn_mixed_sign_conditional)
2619 << lex->getType() << rex->getType()
2620 << lex->getSourceRange() << rex->getSourceRange();
2621}
2622
2623/// AnalyzeImplicitConversions - Find and report any interesting
2624/// implicit conversions in the given expression. There are a couple
2625/// of competing diagnostics here, -Wconversion and -Wsign-compare.
2626void AnalyzeImplicitConversions(Sema &S, Expr *OrigE) {
2627 QualType T = OrigE->getType();
2628 Expr *E = OrigE->IgnoreParenImpCasts();
2629
2630 // For conditional operators, we analyze the arguments as if they
2631 // were being fed directly into the output.
2632 if (isa<ConditionalOperator>(E)) {
2633 ConditionalOperator *CO = cast<ConditionalOperator>(E);
2634 CheckConditionalOperator(S, CO, T);
2635 return;
2636 }
2637
2638 // Go ahead and check any implicit conversions we might have skipped.
2639 // The non-canonical typecheck is just an optimization;
2640 // CheckImplicitConversion will filter out dead implicit conversions.
2641 if (E->getType() != T)
2642 CheckImplicitConversion(S, E, T);
2643
2644 // Now continue drilling into this expression.
2645
2646 // Skip past explicit casts.
2647 if (isa<ExplicitCastExpr>(E)) {
2648 E = cast<ExplicitCastExpr>(E)->getSubExpr()->IgnoreParenImpCasts();
2649 return AnalyzeImplicitConversions(S, E);
2650 }
2651
2652 // Do a somewhat different check with comparison operators.
2653 if (isa<BinaryOperator>(E) && cast<BinaryOperator>(E)->isComparisonOp())
2654 return AnalyzeComparison(S, cast<BinaryOperator>(E));
2655
2656 // These break the otherwise-useful invariant below. Fortunately,
2657 // we don't really need to recurse into them, because any internal
2658 // expressions should have been analyzed already when they were
2659 // built into statements.
2660 if (isa<StmtExpr>(E)) return;
2661
2662 // Don't descend into unevaluated contexts.
2663 if (isa<SizeOfAlignOfExpr>(E)) return;
2664
2665 // Now just recurse over the expression's children.
2666 for (Stmt::child_iterator I = E->child_begin(), IE = E->child_end();
2667 I != IE; ++I)
2668 AnalyzeImplicitConversions(S, cast<Expr>(*I));
2669}
2670
2671} // end anonymous namespace
2672
2673/// Diagnoses "dangerous" implicit conversions within the given
2674/// expression (which is a full expression). Implements -Wconversion
2675/// and -Wsign-compare.
2676void Sema::CheckImplicitConversions(Expr *E) {
2677 // Don't diagnose in unevaluated contexts.
2678 if (ExprEvalContexts.back().Context == Sema::Unevaluated)
2679 return;
2680
2681 // Don't diagnose for value- or type-dependent expressions.
2682 if (E->isTypeDependent() || E->isValueDependent())
2683 return;
2684
2685 AnalyzeImplicitConversions(*this, E);
2686}
2687
Mike Stumpf8c49212010-01-21 03:59:47 +00002688/// CheckParmsForFunctionDef - Check that the parameters of the given
2689/// function are appropriate for the definition of a function. This
2690/// takes care of any checks that cannot be performed on the
2691/// declaration itself, e.g., that the types of each of the function
2692/// parameters are complete.
2693bool Sema::CheckParmsForFunctionDef(FunctionDecl *FD) {
2694 bool HasInvalidParm = false;
2695 for (unsigned p = 0, NumParams = FD->getNumParams(); p < NumParams; ++p) {
2696 ParmVarDecl *Param = FD->getParamDecl(p);
2697
2698 // C99 6.7.5.3p4: the parameters in a parameter type list in a
2699 // function declarator that is part of a function definition of
2700 // that function shall not have incomplete type.
2701 //
2702 // This is also C++ [dcl.fct]p6.
2703 if (!Param->isInvalidDecl() &&
2704 RequireCompleteType(Param->getLocation(), Param->getType(),
2705 diag::err_typecheck_decl_incomplete_type)) {
2706 Param->setInvalidDecl();
2707 HasInvalidParm = true;
2708 }
2709
2710 // C99 6.9.1p5: If the declarator includes a parameter type list, the
2711 // declaration of each parameter shall include an identifier.
2712 if (Param->getIdentifier() == 0 &&
2713 !Param->isImplicit() &&
2714 !getLangOptions().CPlusPlus)
2715 Diag(Param->getLocation(), diag::err_parameter_name_omitted);
Sam Weinigd17e3402010-02-01 05:02:49 +00002716
2717 // C99 6.7.5.3p12:
2718 // If the function declarator is not part of a definition of that
2719 // function, parameters may have incomplete type and may use the [*]
2720 // notation in their sequences of declarator specifiers to specify
2721 // variable length array types.
2722 QualType PType = Param->getOriginalType();
2723 if (const ArrayType *AT = Context.getAsArrayType(PType)) {
2724 if (AT->getSizeModifier() == ArrayType::Star) {
2725 // FIXME: This diagnosic should point the the '[*]' if source-location
2726 // information is added for it.
2727 Diag(Param->getLocation(), diag::err_array_star_in_function_definition);
2728 }
2729 }
Mike Stumpf8c49212010-01-21 03:59:47 +00002730 }
2731
2732 return HasInvalidParm;
2733}