blob: 8ef9c21913cb228f157942dd4238b30b09de837f [file] [log] [blame]
Ted Kremenek61f3e052008-04-03 04:42:52 +00001// BugReporter.cpp - Generate PathDiagnostics for Bugs ------------*- C++ -*--//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// This file defines BugReporter, a utility class for generating
Ted Kremenek6c07bdb2009-06-26 00:05:51 +000011// PathDiagnostics.
Ted Kremenek61f3e052008-04-03 04:42:52 +000012//
13//===----------------------------------------------------------------------===//
14
Ted Kremenek9b663712011-02-10 01:03:03 +000015#include "clang/StaticAnalyzer/Core/BugReporter/BugReporter.h"
16#include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
17#include "clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h"
Ted Kremenek61f3e052008-04-03 04:42:52 +000018#include "clang/AST/ASTContext.h"
Ted Kremeneke41611a2009-07-16 18:13:04 +000019#include "clang/Analysis/CFG.h"
Ted Kremenek61f3e052008-04-03 04:42:52 +000020#include "clang/AST/Expr.h"
Ted Kremenek00605e02009-03-27 20:55:39 +000021#include "clang/AST/ParentMap.h"
Chris Lattner16f00492009-04-26 01:32:48 +000022#include "clang/AST/StmtObjC.h"
23#include "clang/Basic/SourceManager.h"
Ted Kremenek61f3e052008-04-03 04:42:52 +000024#include "clang/Analysis/ProgramPoint.h"
Ted Kremenek9b663712011-02-10 01:03:03 +000025#include "clang/StaticAnalyzer/Core/BugReporter/PathDiagnostic.h"
Chris Lattner405674c2008-08-23 22:23:37 +000026#include "llvm/Support/raw_ostream.h"
Ted Kremenek331b0ac2008-06-18 05:34:07 +000027#include "llvm/ADT/DenseMap.h"
Ted Kremenekcf118d42009-02-04 23:49:09 +000028#include "llvm/ADT/STLExtras.h"
Ted Kremenek00605e02009-03-27 20:55:39 +000029#include "llvm/ADT/OwningPtr.h"
Ted Kremenek10aa5542009-03-12 23:41:59 +000030#include <queue>
Ted Kremenek61f3e052008-04-03 04:42:52 +000031
32using namespace clang;
Ted Kremenek9ef65372010-12-23 07:20:52 +000033using namespace ento;
Ted Kremenek61f3e052008-04-03 04:42:52 +000034
Ted Kremenek8966bc12009-05-06 21:39:49 +000035BugReporterVisitor::~BugReporterVisitor() {}
Ted Kremenek1b431022010-03-20 18:01:57 +000036
David Blaikie99ba9e32011-12-20 02:48:34 +000037void BugReporterContext::anchor() {}
38
Ted Kremenekcf118d42009-02-04 23:49:09 +000039//===----------------------------------------------------------------------===//
Ted Kremenek31061982009-03-31 23:00:32 +000040// Helper routines for walking the ExplodedGraph and fetching statements.
Ted Kremenekcf118d42009-02-04 23:49:09 +000041//===----------------------------------------------------------------------===//
Ted Kremenek61f3e052008-04-03 04:42:52 +000042
Ted Kremenek9c378f72011-08-12 23:37:29 +000043static inline const Stmt *GetStmt(const ProgramPoint &P) {
Ted Kremenek592362b2009-08-18 01:05:30 +000044 if (const StmtPoint* SP = dyn_cast<StmtPoint>(&P))
45 return SP->getStmt();
Ted Kremenek9c378f72011-08-12 23:37:29 +000046 else if (const BlockEdge *BE = dyn_cast<BlockEdge>(&P))
Ted Kremenek61f3e052008-04-03 04:42:52 +000047 return BE->getSrc()->getTerminator();
Mike Stump1eb44332009-09-09 15:08:12 +000048
Ted Kremenekb697b102009-02-23 22:44:26 +000049 return 0;
Ted Kremenek706e3cf2008-04-07 23:35:17 +000050}
51
Zhongxing Xuc5619d92009-08-06 01:32:16 +000052static inline const ExplodedNode*
Ted Kremenek9c378f72011-08-12 23:37:29 +000053GetPredecessorNode(const ExplodedNode *N) {
Ted Kremenekbd7efa82008-04-17 23:44:37 +000054 return N->pred_empty() ? NULL : *(N->pred_begin());
55}
Ted Kremenek2673c9f2008-04-25 19:01:27 +000056
Zhongxing Xuc5619d92009-08-06 01:32:16 +000057static inline const ExplodedNode*
Ted Kremenek9c378f72011-08-12 23:37:29 +000058GetSuccessorNode(const ExplodedNode *N) {
Ted Kremenekb697b102009-02-23 22:44:26 +000059 return N->succ_empty() ? NULL : *(N->succ_begin());
Ted Kremenekbd7efa82008-04-17 23:44:37 +000060}
61
Ted Kremenek9c378f72011-08-12 23:37:29 +000062static const Stmt *GetPreviousStmt(const ExplodedNode *N) {
Ted Kremenekb697b102009-02-23 22:44:26 +000063 for (N = GetPredecessorNode(N); N; N = GetPredecessorNode(N))
Ted Kremenek5f85e172009-07-22 22:35:28 +000064 if (const Stmt *S = GetStmt(N->getLocation()))
Ted Kremenekb697b102009-02-23 22:44:26 +000065 return S;
Mike Stump1eb44332009-09-09 15:08:12 +000066
Ted Kremenekb697b102009-02-23 22:44:26 +000067 return 0;
Ted Kremenek3148eb42009-01-24 00:55:43 +000068}
69
Ted Kremenek9c378f72011-08-12 23:37:29 +000070static const Stmt *GetNextStmt(const ExplodedNode *N) {
Ted Kremenekb697b102009-02-23 22:44:26 +000071 for (N = GetSuccessorNode(N); N; N = GetSuccessorNode(N))
Ted Kremenek5f85e172009-07-22 22:35:28 +000072 if (const Stmt *S = GetStmt(N->getLocation())) {
Ted Kremenekf5ab8e62009-03-28 17:33:57 +000073 // Check if the statement is '?' or '&&'/'||'. These are "merges",
74 // not actual statement points.
75 switch (S->getStmtClass()) {
76 case Stmt::ChooseExprClass:
John McCall56ca35d2011-02-17 10:25:35 +000077 case Stmt::BinaryConditionalOperatorClass: continue;
Ted Kremenekf5ab8e62009-03-28 17:33:57 +000078 case Stmt::ConditionalOperatorClass: continue;
79 case Stmt::BinaryOperatorClass: {
John McCall2de56d12010-08-25 11:45:40 +000080 BinaryOperatorKind Op = cast<BinaryOperator>(S)->getOpcode();
81 if (Op == BO_LAnd || Op == BO_LOr)
Ted Kremenekf5ab8e62009-03-28 17:33:57 +000082 continue;
83 break;
84 }
85 default:
86 break;
87 }
Ted Kremenekb697b102009-02-23 22:44:26 +000088 return S;
Ted Kremenekf5ab8e62009-03-28 17:33:57 +000089 }
Mike Stump1eb44332009-09-09 15:08:12 +000090
Ted Kremenekb697b102009-02-23 22:44:26 +000091 return 0;
92}
93
Ted Kremenek5f85e172009-07-22 22:35:28 +000094static inline const Stmt*
Ted Kremenek9c378f72011-08-12 23:37:29 +000095GetCurrentOrPreviousStmt(const ExplodedNode *N) {
Ted Kremenek5f85e172009-07-22 22:35:28 +000096 if (const Stmt *S = GetStmt(N->getLocation()))
Ted Kremenekb697b102009-02-23 22:44:26 +000097 return S;
Mike Stump1eb44332009-09-09 15:08:12 +000098
Ted Kremenekb697b102009-02-23 22:44:26 +000099 return GetPreviousStmt(N);
100}
Mike Stump1eb44332009-09-09 15:08:12 +0000101
Ted Kremenek5f85e172009-07-22 22:35:28 +0000102static inline const Stmt*
Ted Kremenek9c378f72011-08-12 23:37:29 +0000103GetCurrentOrNextStmt(const ExplodedNode *N) {
Ted Kremenek5f85e172009-07-22 22:35:28 +0000104 if (const Stmt *S = GetStmt(N->getLocation()))
Ted Kremenekb697b102009-02-23 22:44:26 +0000105 return S;
Mike Stump1eb44332009-09-09 15:08:12 +0000106
Ted Kremenekb697b102009-02-23 22:44:26 +0000107 return GetNextStmt(N);
108}
109
110//===----------------------------------------------------------------------===//
Ted Kremenek31061982009-03-31 23:00:32 +0000111// PathDiagnosticBuilder and its associated routines and helper objects.
Ted Kremenekb697b102009-02-23 22:44:26 +0000112//===----------------------------------------------------------------------===//
Ted Kremenekb479dad2009-02-23 23:13:51 +0000113
Zhongxing Xuc5619d92009-08-06 01:32:16 +0000114typedef llvm::DenseMap<const ExplodedNode*,
115const ExplodedNode*> NodeBackMap;
Ted Kremenek7dc86642009-03-31 20:22:36 +0000116
Ted Kremenekbabdd7b2009-03-27 05:06:10 +0000117namespace {
Kovarththanan Rajaratnamba5fb5a2009-11-28 06:07:30 +0000118class NodeMapClosure : public BugReport::NodeResolver {
Ted Kremenek7dc86642009-03-31 20:22:36 +0000119 NodeBackMap& M;
120public:
121 NodeMapClosure(NodeBackMap *m) : M(*m) {}
122 ~NodeMapClosure() {}
Mike Stump1eb44332009-09-09 15:08:12 +0000123
Ted Kremenek9c378f72011-08-12 23:37:29 +0000124 const ExplodedNode *getOriginalNode(const ExplodedNode *N) {
Ted Kremenek7dc86642009-03-31 20:22:36 +0000125 NodeBackMap::iterator I = M.find(N);
126 return I == M.end() ? 0 : I->second;
127 }
128};
Mike Stump1eb44332009-09-09 15:08:12 +0000129
Kovarththanan Rajaratnamba5fb5a2009-11-28 06:07:30 +0000130class PathDiagnosticBuilder : public BugReporterContext {
Ted Kremenek7dc86642009-03-31 20:22:36 +0000131 BugReport *R;
David Blaikieef3643f2011-09-26 00:51:36 +0000132 PathDiagnosticConsumer *PDC;
Ted Kremenek00605e02009-03-27 20:55:39 +0000133 llvm::OwningPtr<ParentMap> PM;
Ted Kremenek7dc86642009-03-31 20:22:36 +0000134 NodeMapClosure NMC;
Mike Stump1eb44332009-09-09 15:08:12 +0000135public:
Ted Kremenek8966bc12009-05-06 21:39:49 +0000136 PathDiagnosticBuilder(GRBugReporter &br,
Mike Stump1eb44332009-09-09 15:08:12 +0000137 BugReport *r, NodeBackMap *Backmap,
David Blaikieef3643f2011-09-26 00:51:36 +0000138 PathDiagnosticConsumer *pdc)
Ted Kremenek8966bc12009-05-06 21:39:49 +0000139 : BugReporterContext(br),
Anna Zaks8e6431a2011-08-18 22:37:56 +0000140 R(r), PDC(pdc), NMC(Backmap) {}
Mike Stump1eb44332009-09-09 15:08:12 +0000141
Ted Kremenek9c378f72011-08-12 23:37:29 +0000142 PathDiagnosticLocation ExecutionContinues(const ExplodedNode *N);
Mike Stump1eb44332009-09-09 15:08:12 +0000143
Ted Kremenek9c378f72011-08-12 23:37:29 +0000144 PathDiagnosticLocation ExecutionContinues(llvm::raw_string_ostream &os,
145 const ExplodedNode *N);
Mike Stump1eb44332009-09-09 15:08:12 +0000146
Anna Zaks8e6431a2011-08-18 22:37:56 +0000147 BugReport *getBugReport() { return R; }
148
Tom Care212f6d32010-09-16 03:50:38 +0000149 Decl const &getCodeDecl() { return R->getErrorNode()->getCodeDecl(); }
Zhongxing Xub317f8f2009-09-10 05:44:00 +0000150
Anna Zaks220ac8c2011-09-15 01:08:34 +0000151 const LocationContext* getLocationContext() {
152 return R->getErrorNode()->getLocationContext();
153 }
154
Tom Care212f6d32010-09-16 03:50:38 +0000155 ParentMap& getParentMap() { return R->getErrorNode()->getParentMap(); }
Mike Stump1eb44332009-09-09 15:08:12 +0000156
Ted Kremenekc3f83ad2009-04-01 17:18:21 +0000157 const Stmt *getParent(const Stmt *S) {
158 return getParentMap().getParent(S);
159 }
Mike Stump1eb44332009-09-09 15:08:12 +0000160
Ted Kremenek8966bc12009-05-06 21:39:49 +0000161 virtual NodeMapClosure& getNodeResolver() { return NMC; }
Douglas Gregor72971342009-04-18 00:02:19 +0000162
Ted Kremenekd8c938b2009-03-27 21:16:25 +0000163 PathDiagnosticLocation getEnclosingStmtLocation(const Stmt *S);
Mike Stump1eb44332009-09-09 15:08:12 +0000164
David Blaikieef3643f2011-09-26 00:51:36 +0000165 PathDiagnosticConsumer::PathGenerationScheme getGenerationScheme() const {
166 return PDC ? PDC->getGenerationScheme() : PathDiagnosticConsumer::Extensive;
Ted Kremenek7dc86642009-03-31 20:22:36 +0000167 }
168
Ted Kremenekbabdd7b2009-03-27 05:06:10 +0000169 bool supportsLogicalOpControlFlow() const {
170 return PDC ? PDC->supportsLogicalOpControlFlow() : true;
Mike Stump1eb44332009-09-09 15:08:12 +0000171 }
Ted Kremenekbabdd7b2009-03-27 05:06:10 +0000172};
173} // end anonymous namespace
174
Ted Kremenek00605e02009-03-27 20:55:39 +0000175PathDiagnosticLocation
Ted Kremenek9c378f72011-08-12 23:37:29 +0000176PathDiagnosticBuilder::ExecutionContinues(const ExplodedNode *N) {
Ted Kremenek5f85e172009-07-22 22:35:28 +0000177 if (const Stmt *S = GetNextStmt(N))
Anna Zaks220ac8c2011-09-15 01:08:34 +0000178 return PathDiagnosticLocation(S, getSourceManager(), getLocationContext());
Ted Kremenek00605e02009-03-27 20:55:39 +0000179
Anna Zaks0cd59482011-09-16 19:18:30 +0000180 return PathDiagnosticLocation::createDeclEnd(N->getLocationContext(),
181 getSourceManager());
Ted Kremenek082cb8d2009-03-12 18:41:53 +0000182}
Mike Stump1eb44332009-09-09 15:08:12 +0000183
Ted Kremenek00605e02009-03-27 20:55:39 +0000184PathDiagnosticLocation
Ted Kremenek9c378f72011-08-12 23:37:29 +0000185PathDiagnosticBuilder::ExecutionContinues(llvm::raw_string_ostream &os,
186 const ExplodedNode *N) {
Ted Kremenekbabdd7b2009-03-27 05:06:10 +0000187
Ted Kremenek143ca222008-05-06 18:11:09 +0000188 // Slow, but probably doesn't matter.
Ted Kremenekb697b102009-02-23 22:44:26 +0000189 if (os.str().empty())
190 os << ' ';
Mike Stump1eb44332009-09-09 15:08:12 +0000191
Ted Kremenek00605e02009-03-27 20:55:39 +0000192 const PathDiagnosticLocation &Loc = ExecutionContinues(N);
Mike Stump1eb44332009-09-09 15:08:12 +0000193
Ted Kremenek00605e02009-03-27 20:55:39 +0000194 if (Loc.asStmt())
Ted Kremenekb697b102009-02-23 22:44:26 +0000195 os << "Execution continues on line "
Chandler Carruth64211622011-07-25 21:09:52 +0000196 << getSourceManager().getExpansionLineNumber(Loc.asLocation())
Ted Kremenek8966bc12009-05-06 21:39:49 +0000197 << '.';
Ted Kremenek4f1db532009-12-04 20:34:31 +0000198 else {
199 os << "Execution jumps to the end of the ";
200 const Decl *D = N->getLocationContext()->getDecl();
201 if (isa<ObjCMethodDecl>(D))
202 os << "method";
203 else if (isa<FunctionDecl>(D))
204 os << "function";
205 else {
206 assert(isa<BlockDecl>(D));
207 os << "anonymous block";
208 }
209 os << '.';
210 }
Mike Stump1eb44332009-09-09 15:08:12 +0000211
Ted Kremenek082cb8d2009-03-12 18:41:53 +0000212 return Loc;
Ted Kremenek143ca222008-05-06 18:11:09 +0000213}
214
Ted Kremenekddb7bab2009-05-15 01:50:15 +0000215static bool IsNested(const Stmt *S, ParentMap &PM) {
216 if (isa<Expr>(S) && PM.isConsumedExpr(cast<Expr>(S)))
217 return true;
Mike Stump1eb44332009-09-09 15:08:12 +0000218
Ted Kremenekddb7bab2009-05-15 01:50:15 +0000219 const Stmt *Parent = PM.getParentIgnoreParens(S);
Mike Stump1eb44332009-09-09 15:08:12 +0000220
Ted Kremenekddb7bab2009-05-15 01:50:15 +0000221 if (Parent)
222 switch (Parent->getStmtClass()) {
223 case Stmt::ForStmtClass:
224 case Stmt::DoStmtClass:
225 case Stmt::WhileStmtClass:
226 return true;
227 default:
228 break;
229 }
Mike Stump1eb44332009-09-09 15:08:12 +0000230
231 return false;
Ted Kremenekddb7bab2009-05-15 01:50:15 +0000232}
233
Ted Kremenekd8c938b2009-03-27 21:16:25 +0000234PathDiagnosticLocation
235PathDiagnosticBuilder::getEnclosingStmtLocation(const Stmt *S) {
Ted Kremenek9c378f72011-08-12 23:37:29 +0000236 assert(S && "Null Stmt *passed to getEnclosingStmtLocation");
Mike Stump1eb44332009-09-09 15:08:12 +0000237 ParentMap &P = getParentMap();
Ted Kremenek8966bc12009-05-06 21:39:49 +0000238 SourceManager &SMgr = getSourceManager();
Anna Zaks220ac8c2011-09-15 01:08:34 +0000239 const LocationContext *LC = getLocationContext();
Ted Kremeneke88a1702009-05-11 22:19:32 +0000240
Ted Kremenekddb7bab2009-05-15 01:50:15 +0000241 while (IsNested(S, P)) {
Ted Kremenek8c8b0ad2009-05-11 19:50:47 +0000242 const Stmt *Parent = P.getParentIgnoreParens(S);
Mike Stump1eb44332009-09-09 15:08:12 +0000243
Ted Kremenekaf3e3d52009-03-28 03:37:59 +0000244 if (!Parent)
245 break;
Mike Stump1eb44332009-09-09 15:08:12 +0000246
Ted Kremenekaf3e3d52009-03-28 03:37:59 +0000247 switch (Parent->getStmtClass()) {
Ted Kremenek5fb5dfb2009-04-01 06:13:56 +0000248 case Stmt::BinaryOperatorClass: {
249 const BinaryOperator *B = cast<BinaryOperator>(Parent);
250 if (B->isLogicalOp())
Anna Zaks220ac8c2011-09-15 01:08:34 +0000251 return PathDiagnosticLocation(S, SMgr, LC);
Ted Kremenek5fb5dfb2009-04-01 06:13:56 +0000252 break;
Mike Stump1eb44332009-09-09 15:08:12 +0000253 }
Ted Kremenekaf3e3d52009-03-28 03:37:59 +0000254 case Stmt::CompoundStmtClass:
255 case Stmt::StmtExprClass:
Anna Zaks220ac8c2011-09-15 01:08:34 +0000256 return PathDiagnosticLocation(S, SMgr, LC);
Ted Kremenek1d9a23a2009-03-28 04:08:14 +0000257 case Stmt::ChooseExprClass:
258 // Similar to '?' if we are referring to condition, just have the edge
259 // point to the entire choose expression.
260 if (cast<ChooseExpr>(Parent)->getCond() == S)
Anna Zaks220ac8c2011-09-15 01:08:34 +0000261 return PathDiagnosticLocation(Parent, SMgr, LC);
Ted Kremenek1d9a23a2009-03-28 04:08:14 +0000262 else
Anna Zaks220ac8c2011-09-15 01:08:34 +0000263 return PathDiagnosticLocation(S, SMgr, LC);
John McCall56ca35d2011-02-17 10:25:35 +0000264 case Stmt::BinaryConditionalOperatorClass:
Ted Kremenek1d9a23a2009-03-28 04:08:14 +0000265 case Stmt::ConditionalOperatorClass:
266 // For '?', if we are referring to condition, just have the edge point
267 // to the entire '?' expression.
John McCall56ca35d2011-02-17 10:25:35 +0000268 if (cast<AbstractConditionalOperator>(Parent)->getCond() == S)
Anna Zaks220ac8c2011-09-15 01:08:34 +0000269 return PathDiagnosticLocation(Parent, SMgr, LC);
Ted Kremenek1d9a23a2009-03-28 04:08:14 +0000270 else
Anna Zaks220ac8c2011-09-15 01:08:34 +0000271 return PathDiagnosticLocation(S, SMgr, LC);
Ted Kremenekaf3e3d52009-03-28 03:37:59 +0000272 case Stmt::DoStmtClass:
Anna Zaks220ac8c2011-09-15 01:08:34 +0000273 return PathDiagnosticLocation(S, SMgr, LC);
Ted Kremenekaf3e3d52009-03-28 03:37:59 +0000274 case Stmt::ForStmtClass:
275 if (cast<ForStmt>(Parent)->getBody() == S)
Anna Zaks220ac8c2011-09-15 01:08:34 +0000276 return PathDiagnosticLocation(S, SMgr, LC);
Mike Stump1eb44332009-09-09 15:08:12 +0000277 break;
Ted Kremenekaf3e3d52009-03-28 03:37:59 +0000278 case Stmt::IfStmtClass:
279 if (cast<IfStmt>(Parent)->getCond() != S)
Anna Zaks220ac8c2011-09-15 01:08:34 +0000280 return PathDiagnosticLocation(S, SMgr, LC);
Ted Kremenek8bd4d032009-04-28 04:23:15 +0000281 break;
Ted Kremenekaf3e3d52009-03-28 03:37:59 +0000282 case Stmt::ObjCForCollectionStmtClass:
283 if (cast<ObjCForCollectionStmt>(Parent)->getBody() == S)
Anna Zaks220ac8c2011-09-15 01:08:34 +0000284 return PathDiagnosticLocation(S, SMgr, LC);
Ted Kremenekaf3e3d52009-03-28 03:37:59 +0000285 break;
286 case Stmt::WhileStmtClass:
287 if (cast<WhileStmt>(Parent)->getCond() != S)
Anna Zaks220ac8c2011-09-15 01:08:34 +0000288 return PathDiagnosticLocation(S, SMgr, LC);
Ted Kremenekaf3e3d52009-03-28 03:37:59 +0000289 break;
290 default:
291 break;
292 }
293
Ted Kremenekd8c938b2009-03-27 21:16:25 +0000294 S = Parent;
295 }
Mike Stump1eb44332009-09-09 15:08:12 +0000296
Ted Kremenekd8c938b2009-03-27 21:16:25 +0000297 assert(S && "Cannot have null Stmt for PathDiagnosticLocation");
Ted Kremeneke88a1702009-05-11 22:19:32 +0000298
299 // Special case: DeclStmts can appear in for statement declarations, in which
300 // case the ForStmt is the context.
301 if (isa<DeclStmt>(S)) {
302 if (const Stmt *Parent = P.getParent(S)) {
303 switch (Parent->getStmtClass()) {
304 case Stmt::ForStmtClass:
305 case Stmt::ObjCForCollectionStmtClass:
Anna Zaks220ac8c2011-09-15 01:08:34 +0000306 return PathDiagnosticLocation(Parent, SMgr, LC);
Ted Kremeneke88a1702009-05-11 22:19:32 +0000307 default:
308 break;
Mike Stump1eb44332009-09-09 15:08:12 +0000309 }
310 }
Ted Kremeneke88a1702009-05-11 22:19:32 +0000311 }
312 else if (isa<BinaryOperator>(S)) {
313 // Special case: the binary operator represents the initialization
314 // code in a for statement (this can happen when the variable being
315 // initialized is an old variable.
316 if (const ForStmt *FS =
317 dyn_cast_or_null<ForStmt>(P.getParentIgnoreParens(S))) {
318 if (FS->getInit() == S)
Anna Zaks220ac8c2011-09-15 01:08:34 +0000319 return PathDiagnosticLocation(FS, SMgr, LC);
Ted Kremeneke88a1702009-05-11 22:19:32 +0000320 }
321 }
322
Anna Zaks220ac8c2011-09-15 01:08:34 +0000323 return PathDiagnosticLocation(S, SMgr, LC);
Ted Kremenekd8c938b2009-03-27 21:16:25 +0000324}
325
Ted Kremenekcf118d42009-02-04 23:49:09 +0000326//===----------------------------------------------------------------------===//
Ted Kremenek31061982009-03-31 23:00:32 +0000327// ScanNotableSymbols: closure-like callback for scanning Store bindings.
328//===----------------------------------------------------------------------===//
329
Ted Kremenek18c66fd2011-08-15 22:09:50 +0000330static const VarDecl* GetMostRecentVarDeclBinding(const ExplodedNode *N,
331 ProgramStateManager& VMgr,
332 SVal X) {
Mike Stump1eb44332009-09-09 15:08:12 +0000333
Ted Kremenek31061982009-03-31 23:00:32 +0000334 for ( ; N ; N = N->pred_empty() ? 0 : *N->pred_begin()) {
Mike Stump1eb44332009-09-09 15:08:12 +0000335
Ted Kremenek31061982009-03-31 23:00:32 +0000336 ProgramPoint P = N->getLocation();
Mike Stump1eb44332009-09-09 15:08:12 +0000337
Ted Kremenek31061982009-03-31 23:00:32 +0000338 if (!isa<PostStmt>(P))
339 continue;
Mike Stump1eb44332009-09-09 15:08:12 +0000340
Ted Kremenek9c378f72011-08-12 23:37:29 +0000341 const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(cast<PostStmt>(P).getStmt());
Mike Stump1eb44332009-09-09 15:08:12 +0000342
Ted Kremenek31061982009-03-31 23:00:32 +0000343 if (!DR)
344 continue;
Mike Stump1eb44332009-09-09 15:08:12 +0000345
Ted Kremenek13976632010-02-08 16:18:51 +0000346 SVal Y = N->getState()->getSVal(DR);
Mike Stump1eb44332009-09-09 15:08:12 +0000347
Ted Kremenek31061982009-03-31 23:00:32 +0000348 if (X != Y)
349 continue;
Mike Stump1eb44332009-09-09 15:08:12 +0000350
Ted Kremenek9c378f72011-08-12 23:37:29 +0000351 const VarDecl *VD = dyn_cast<VarDecl>(DR->getDecl());
Mike Stump1eb44332009-09-09 15:08:12 +0000352
Ted Kremenek31061982009-03-31 23:00:32 +0000353 if (!VD)
354 continue;
Mike Stump1eb44332009-09-09 15:08:12 +0000355
Ted Kremenek31061982009-03-31 23:00:32 +0000356 return VD;
357 }
Mike Stump1eb44332009-09-09 15:08:12 +0000358
Ted Kremenek31061982009-03-31 23:00:32 +0000359 return 0;
360}
361
362namespace {
Kovarththanan Rajaratnamba5fb5a2009-11-28 06:07:30 +0000363class NotableSymbolHandler
Ted Kremenek31061982009-03-31 23:00:32 +0000364: public StoreManager::BindingsHandler {
Mike Stump1eb44332009-09-09 15:08:12 +0000365
Ted Kremenek31061982009-03-31 23:00:32 +0000366 SymbolRef Sym;
Ted Kremenek18c66fd2011-08-15 22:09:50 +0000367 const ProgramState *PrevSt;
Ted Kremenek9c378f72011-08-12 23:37:29 +0000368 const Stmt *S;
Ted Kremenek18c66fd2011-08-15 22:09:50 +0000369 ProgramStateManager& VMgr;
Ted Kremenek9c378f72011-08-12 23:37:29 +0000370 const ExplodedNode *Pred;
Mike Stump1eb44332009-09-09 15:08:12 +0000371 PathDiagnostic& PD;
Ted Kremenek31061982009-03-31 23:00:32 +0000372 BugReporter& BR;
Mike Stump1eb44332009-09-09 15:08:12 +0000373
Ted Kremenek31061982009-03-31 23:00:32 +0000374public:
Mike Stump1eb44332009-09-09 15:08:12 +0000375
Ted Kremenek18c66fd2011-08-15 22:09:50 +0000376 NotableSymbolHandler(SymbolRef sym,
377 const ProgramState *prevst,
378 const Stmt *s,
379 ProgramStateManager& vmgr,
380 const ExplodedNode *pred,
381 PathDiagnostic& pd,
382 BugReporter& br)
383 : Sym(sym),
384 PrevSt(prevst),
385 S(s),
386 VMgr(vmgr),
387 Pred(pred),
388 PD(pd),
389 BR(br) {}
Mike Stump1eb44332009-09-09 15:08:12 +0000390
Ted Kremenek31061982009-03-31 23:00:32 +0000391 bool HandleBinding(StoreManager& SMgr, Store store, const MemRegion* R,
392 SVal V) {
Mike Stump1eb44332009-09-09 15:08:12 +0000393
Ted Kremenek31061982009-03-31 23:00:32 +0000394 SymbolRef ScanSym = V.getAsSymbol();
Mike Stump1eb44332009-09-09 15:08:12 +0000395
Ted Kremenek31061982009-03-31 23:00:32 +0000396 if (ScanSym != Sym)
397 return true;
Mike Stump1eb44332009-09-09 15:08:12 +0000398
399 // Check if the previous state has this binding.
Ted Kremenek13976632010-02-08 16:18:51 +0000400 SVal X = PrevSt->getSVal(loc::MemRegionVal(R));
Mike Stump1eb44332009-09-09 15:08:12 +0000401
Ted Kremenek31061982009-03-31 23:00:32 +0000402 if (X == V) // Same binding?
403 return true;
Mike Stump1eb44332009-09-09 15:08:12 +0000404
Ted Kremenek31061982009-03-31 23:00:32 +0000405 // Different binding. Only handle assignments for now. We don't pull
Mike Stump1eb44332009-09-09 15:08:12 +0000406 // this check out of the loop because we will eventually handle other
Ted Kremenek31061982009-03-31 23:00:32 +0000407 // cases.
Mike Stump1eb44332009-09-09 15:08:12 +0000408
Ted Kremenek31061982009-03-31 23:00:32 +0000409 VarDecl *VD = 0;
Mike Stump1eb44332009-09-09 15:08:12 +0000410
Ted Kremenek31061982009-03-31 23:00:32 +0000411 if (const BinaryOperator* B = dyn_cast<BinaryOperator>(S)) {
412 if (!B->isAssignmentOp())
413 return true;
Mike Stump1eb44332009-09-09 15:08:12 +0000414
Ted Kremenek31061982009-03-31 23:00:32 +0000415 // What variable did we assign to?
Ted Kremenek9c378f72011-08-12 23:37:29 +0000416 DeclRefExpr *DR = dyn_cast<DeclRefExpr>(B->getLHS()->IgnoreParenCasts());
Mike Stump1eb44332009-09-09 15:08:12 +0000417
Ted Kremenek31061982009-03-31 23:00:32 +0000418 if (!DR)
419 return true;
Mike Stump1eb44332009-09-09 15:08:12 +0000420
Ted Kremenek31061982009-03-31 23:00:32 +0000421 VD = dyn_cast<VarDecl>(DR->getDecl());
422 }
Ted Kremenek9c378f72011-08-12 23:37:29 +0000423 else if (const DeclStmt *DS = dyn_cast<DeclStmt>(S)) {
Ted Kremenek31061982009-03-31 23:00:32 +0000424 // FIXME: Eventually CFGs won't have DeclStmts. Right now we
425 // assume that each DeclStmt has a single Decl. This invariant
Chris Lattnerfc8f0e12011-04-15 05:22:18 +0000426 // holds by construction in the CFG.
Ted Kremenek31061982009-03-31 23:00:32 +0000427 VD = dyn_cast<VarDecl>(*DS->decl_begin());
428 }
Mike Stump1eb44332009-09-09 15:08:12 +0000429
Ted Kremenek31061982009-03-31 23:00:32 +0000430 if (!VD)
431 return true;
Mike Stump1eb44332009-09-09 15:08:12 +0000432
Ted Kremenek31061982009-03-31 23:00:32 +0000433 // What is the most recently referenced variable with this binding?
Ted Kremenek9c378f72011-08-12 23:37:29 +0000434 const VarDecl *MostRecent = GetMostRecentVarDeclBinding(Pred, VMgr, V);
Mike Stump1eb44332009-09-09 15:08:12 +0000435
Ted Kremenek31061982009-03-31 23:00:32 +0000436 if (!MostRecent)
437 return true;
Mike Stump1eb44332009-09-09 15:08:12 +0000438
Ted Kremenek31061982009-03-31 23:00:32 +0000439 // Create the diagnostic.
Zhanyong Wan7dfc9422011-02-16 21:13:32 +0000440 if (Loc::isLocType(VD->getType())) {
Jordy Rose7df12342011-08-21 05:25:15 +0000441 llvm::SmallString<64> buf;
442 llvm::raw_svector_ostream os(buf);
Benjamin Kramerb8989f22011-10-14 18:45:37 +0000443 os << '\'' << *VD << "' now aliases '" << *MostRecent << '\'';
Anna Zaks590dd8e2011-09-20 21:38:35 +0000444 PathDiagnosticLocation L =
445 PathDiagnosticLocation::createBegin(S, BR.getSourceManager(),
446 Pred->getLocationContext());
Jordy Rose7df12342011-08-21 05:25:15 +0000447 PD.push_front(new PathDiagnosticEventPiece(L, os.str()));
Ted Kremenek31061982009-03-31 23:00:32 +0000448 }
Mike Stump1eb44332009-09-09 15:08:12 +0000449
Ted Kremenek31061982009-03-31 23:00:32 +0000450 return true;
Mike Stump1eb44332009-09-09 15:08:12 +0000451 }
Ted Kremenek31061982009-03-31 23:00:32 +0000452};
453}
454
Ted Kremenek9c378f72011-08-12 23:37:29 +0000455static void HandleNotableSymbol(const ExplodedNode *N,
456 const Stmt *S,
Ted Kremenek31061982009-03-31 23:00:32 +0000457 SymbolRef Sym, BugReporter& BR,
458 PathDiagnostic& PD) {
Mike Stump1eb44332009-09-09 15:08:12 +0000459
Ted Kremenek9c378f72011-08-12 23:37:29 +0000460 const ExplodedNode *Pred = N->pred_empty() ? 0 : *N->pred_begin();
Ted Kremenek18c66fd2011-08-15 22:09:50 +0000461 const ProgramState *PrevSt = Pred ? Pred->getState() : 0;
Mike Stump1eb44332009-09-09 15:08:12 +0000462
Ted Kremenek31061982009-03-31 23:00:32 +0000463 if (!PrevSt)
464 return;
Mike Stump1eb44332009-09-09 15:08:12 +0000465
Ted Kremenek31061982009-03-31 23:00:32 +0000466 // Look at the region bindings of the current state that map to the
467 // specified symbol. Are any of them not in the previous state?
Ted Kremenek18c66fd2011-08-15 22:09:50 +0000468 ProgramStateManager& VMgr = cast<GRBugReporter>(BR).getStateManager();
Ted Kremenek31061982009-03-31 23:00:32 +0000469 NotableSymbolHandler H(Sym, PrevSt, S, VMgr, Pred, PD, BR);
470 cast<GRBugReporter>(BR).getStateManager().iterBindings(N->getState(), H);
471}
472
473namespace {
Kovarththanan Rajaratnamba5fb5a2009-11-28 06:07:30 +0000474class ScanNotableSymbols
Ted Kremenek31061982009-03-31 23:00:32 +0000475: public StoreManager::BindingsHandler {
Mike Stump1eb44332009-09-09 15:08:12 +0000476
Ted Kremenek31061982009-03-31 23:00:32 +0000477 llvm::SmallSet<SymbolRef, 10> AlreadyProcessed;
Ted Kremenek9c378f72011-08-12 23:37:29 +0000478 const ExplodedNode *N;
479 const Stmt *S;
Ted Kremenek31061982009-03-31 23:00:32 +0000480 GRBugReporter& BR;
481 PathDiagnostic& PD;
Mike Stump1eb44332009-09-09 15:08:12 +0000482
Ted Kremenek31061982009-03-31 23:00:32 +0000483public:
Ted Kremenek9c378f72011-08-12 23:37:29 +0000484 ScanNotableSymbols(const ExplodedNode *n, const Stmt *s,
Ted Kremenek5f85e172009-07-22 22:35:28 +0000485 GRBugReporter& br, PathDiagnostic& pd)
Ted Kremenek31061982009-03-31 23:00:32 +0000486 : N(n), S(s), BR(br), PD(pd) {}
Mike Stump1eb44332009-09-09 15:08:12 +0000487
Ted Kremenek31061982009-03-31 23:00:32 +0000488 bool HandleBinding(StoreManager& SMgr, Store store,
489 const MemRegion* R, SVal V) {
Mike Stump1eb44332009-09-09 15:08:12 +0000490
Ted Kremenek31061982009-03-31 23:00:32 +0000491 SymbolRef ScanSym = V.getAsSymbol();
Mike Stump1eb44332009-09-09 15:08:12 +0000492
Ted Kremenek31061982009-03-31 23:00:32 +0000493 if (!ScanSym)
494 return true;
Mike Stump1eb44332009-09-09 15:08:12 +0000495
Ted Kremenek31061982009-03-31 23:00:32 +0000496 if (!BR.isNotable(ScanSym))
497 return true;
Mike Stump1eb44332009-09-09 15:08:12 +0000498
Ted Kremenek31061982009-03-31 23:00:32 +0000499 if (AlreadyProcessed.count(ScanSym))
500 return true;
Mike Stump1eb44332009-09-09 15:08:12 +0000501
Ted Kremenek31061982009-03-31 23:00:32 +0000502 AlreadyProcessed.insert(ScanSym);
Mike Stump1eb44332009-09-09 15:08:12 +0000503
Ted Kremenek31061982009-03-31 23:00:32 +0000504 HandleNotableSymbol(N, S, ScanSym, BR, PD);
505 return true;
506 }
507};
508} // end anonymous namespace
509
510//===----------------------------------------------------------------------===//
511// "Minimal" path diagnostic generation algorithm.
512//===----------------------------------------------------------------------===//
513
Ted Kremenek14856d72009-04-06 23:06:54 +0000514static void CompactPathDiagnostic(PathDiagnostic &PD, const SourceManager& SM);
515
Ted Kremenek31061982009-03-31 23:00:32 +0000516static void GenerateMinimalPathDiagnostic(PathDiagnostic& PD,
517 PathDiagnosticBuilder &PDB,
Zhongxing Xuc5619d92009-08-06 01:32:16 +0000518 const ExplodedNode *N) {
Ted Kremenek8966bc12009-05-06 21:39:49 +0000519
Ted Kremenek31061982009-03-31 23:00:32 +0000520 SourceManager& SMgr = PDB.getSourceManager();
Anna Zaks220ac8c2011-09-15 01:08:34 +0000521 const LocationContext *LC = PDB.getLocationContext();
Ted Kremenek9c378f72011-08-12 23:37:29 +0000522 const ExplodedNode *NextNode = N->pred_empty()
Ted Kremenek31061982009-03-31 23:00:32 +0000523 ? NULL : *(N->pred_begin());
524 while (NextNode) {
Mike Stump1eb44332009-09-09 15:08:12 +0000525 N = NextNode;
Ted Kremenek31061982009-03-31 23:00:32 +0000526 NextNode = GetPredecessorNode(N);
Mike Stump1eb44332009-09-09 15:08:12 +0000527
Ted Kremenek31061982009-03-31 23:00:32 +0000528 ProgramPoint P = N->getLocation();
Mike Stump1eb44332009-09-09 15:08:12 +0000529
Ted Kremenek9c378f72011-08-12 23:37:29 +0000530 if (const BlockEdge *BE = dyn_cast<BlockEdge>(&P)) {
531 const CFGBlock *Src = BE->getSrc();
532 const CFGBlock *Dst = BE->getDst();
533 const Stmt *T = Src->getTerminator();
Mike Stump1eb44332009-09-09 15:08:12 +0000534
Ted Kremenek31061982009-03-31 23:00:32 +0000535 if (!T)
536 continue;
Mike Stump1eb44332009-09-09 15:08:12 +0000537
Anna Zaks590dd8e2011-09-20 21:38:35 +0000538 PathDiagnosticLocation Start =
539 PathDiagnosticLocation::createBegin(T, SMgr,
540 N->getLocationContext());
Mike Stump1eb44332009-09-09 15:08:12 +0000541
Ted Kremenek31061982009-03-31 23:00:32 +0000542 switch (T->getStmtClass()) {
543 default:
544 break;
Mike Stump1eb44332009-09-09 15:08:12 +0000545
Ted Kremenek31061982009-03-31 23:00:32 +0000546 case Stmt::GotoStmtClass:
Mike Stump1eb44332009-09-09 15:08:12 +0000547 case Stmt::IndirectGotoStmtClass: {
Ted Kremenek9c378f72011-08-12 23:37:29 +0000548 const Stmt *S = GetNextStmt(N);
Mike Stump1eb44332009-09-09 15:08:12 +0000549
Ted Kremenek31061982009-03-31 23:00:32 +0000550 if (!S)
551 continue;
Mike Stump1eb44332009-09-09 15:08:12 +0000552
Ted Kremenek31061982009-03-31 23:00:32 +0000553 std::string sbuf;
Mike Stump1eb44332009-09-09 15:08:12 +0000554 llvm::raw_string_ostream os(sbuf);
Ted Kremenek31061982009-03-31 23:00:32 +0000555 const PathDiagnosticLocation &End = PDB.getEnclosingStmtLocation(S);
Mike Stump1eb44332009-09-09 15:08:12 +0000556
Ted Kremenek31061982009-03-31 23:00:32 +0000557 os << "Control jumps to line "
Chandler Carruth64211622011-07-25 21:09:52 +0000558 << End.asLocation().getExpansionLineNumber();
Ted Kremenek31061982009-03-31 23:00:32 +0000559 PD.push_front(new PathDiagnosticControlFlowPiece(Start, End,
560 os.str()));
561 break;
562 }
Mike Stump1eb44332009-09-09 15:08:12 +0000563
564 case Stmt::SwitchStmtClass: {
Ted Kremenek31061982009-03-31 23:00:32 +0000565 // Figure out what case arm we took.
566 std::string sbuf;
567 llvm::raw_string_ostream os(sbuf);
Mike Stump1eb44332009-09-09 15:08:12 +0000568
Ted Kremenek9c378f72011-08-12 23:37:29 +0000569 if (const Stmt *S = Dst->getLabel()) {
Anna Zaks220ac8c2011-09-15 01:08:34 +0000570 PathDiagnosticLocation End(S, SMgr, LC);
Mike Stump1eb44332009-09-09 15:08:12 +0000571
Ted Kremenek31061982009-03-31 23:00:32 +0000572 switch (S->getStmtClass()) {
573 default:
574 os << "No cases match in the switch statement. "
575 "Control jumps to line "
Chandler Carruth64211622011-07-25 21:09:52 +0000576 << End.asLocation().getExpansionLineNumber();
Ted Kremenek31061982009-03-31 23:00:32 +0000577 break;
578 case Stmt::DefaultStmtClass:
579 os << "Control jumps to the 'default' case at line "
Chandler Carruth64211622011-07-25 21:09:52 +0000580 << End.asLocation().getExpansionLineNumber();
Ted Kremenek31061982009-03-31 23:00:32 +0000581 break;
Mike Stump1eb44332009-09-09 15:08:12 +0000582
Ted Kremenek31061982009-03-31 23:00:32 +0000583 case Stmt::CaseStmtClass: {
Mike Stump1eb44332009-09-09 15:08:12 +0000584 os << "Control jumps to 'case ";
Ted Kremenek9c378f72011-08-12 23:37:29 +0000585 const CaseStmt *Case = cast<CaseStmt>(S);
586 const Expr *LHS = Case->getLHS()->IgnoreParenCasts();
Mike Stump1eb44332009-09-09 15:08:12 +0000587
588 // Determine if it is an enum.
Ted Kremenek31061982009-03-31 23:00:32 +0000589 bool GetRawInt = true;
Mike Stump1eb44332009-09-09 15:08:12 +0000590
Ted Kremenek9c378f72011-08-12 23:37:29 +0000591 if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(LHS)) {
Ted Kremenek31061982009-03-31 23:00:32 +0000592 // FIXME: Maybe this should be an assertion. Are there cases
593 // were it is not an EnumConstantDecl?
Ted Kremenek9c378f72011-08-12 23:37:29 +0000594 const EnumConstantDecl *D =
Zhongxing Xu03509ae2010-07-20 06:22:24 +0000595 dyn_cast<EnumConstantDecl>(DR->getDecl());
Mike Stump1eb44332009-09-09 15:08:12 +0000596
Ted Kremenek31061982009-03-31 23:00:32 +0000597 if (D) {
598 GetRawInt = false;
Benjamin Kramerb8989f22011-10-14 18:45:37 +0000599 os << *D;
Ted Kremenek31061982009-03-31 23:00:32 +0000600 }
601 }
Eli Friedman9ec64d62009-04-26 19:04:51 +0000602
603 if (GetRawInt)
Richard Smitha6b8b2c2011-10-10 18:28:20 +0000604 os << LHS->EvaluateKnownConstInt(PDB.getASTContext());
Eli Friedman9ec64d62009-04-26 19:04:51 +0000605
Ted Kremenek31061982009-03-31 23:00:32 +0000606 os << ":' at line "
Chandler Carruth64211622011-07-25 21:09:52 +0000607 << End.asLocation().getExpansionLineNumber();
Ted Kremenek31061982009-03-31 23:00:32 +0000608 break;
609 }
610 }
611 PD.push_front(new PathDiagnosticControlFlowPiece(Start, End,
612 os.str()));
613 }
614 else {
615 os << "'Default' branch taken. ";
Mike Stump1eb44332009-09-09 15:08:12 +0000616 const PathDiagnosticLocation &End = PDB.ExecutionContinues(os, N);
Ted Kremenek31061982009-03-31 23:00:32 +0000617 PD.push_front(new PathDiagnosticControlFlowPiece(Start, End,
618 os.str()));
619 }
Mike Stump1eb44332009-09-09 15:08:12 +0000620
Ted Kremenek31061982009-03-31 23:00:32 +0000621 break;
622 }
Mike Stump1eb44332009-09-09 15:08:12 +0000623
Ted Kremenek31061982009-03-31 23:00:32 +0000624 case Stmt::BreakStmtClass:
625 case Stmt::ContinueStmtClass: {
626 std::string sbuf;
627 llvm::raw_string_ostream os(sbuf);
628 PathDiagnosticLocation End = PDB.ExecutionContinues(os, N);
629 PD.push_front(new PathDiagnosticControlFlowPiece(Start, End,
630 os.str()));
631 break;
632 }
Mike Stump1eb44332009-09-09 15:08:12 +0000633
Ted Kremenek31061982009-03-31 23:00:32 +0000634 // Determine control-flow for ternary '?'.
John McCall56ca35d2011-02-17 10:25:35 +0000635 case Stmt::BinaryConditionalOperatorClass:
Ted Kremenek31061982009-03-31 23:00:32 +0000636 case Stmt::ConditionalOperatorClass: {
637 std::string sbuf;
638 llvm::raw_string_ostream os(sbuf);
639 os << "'?' condition is ";
Mike Stump1eb44332009-09-09 15:08:12 +0000640
Ted Kremenek31061982009-03-31 23:00:32 +0000641 if (*(Src->succ_begin()+1) == Dst)
642 os << "false";
643 else
644 os << "true";
Mike Stump1eb44332009-09-09 15:08:12 +0000645
Ted Kremenek31061982009-03-31 23:00:32 +0000646 PathDiagnosticLocation End = PDB.ExecutionContinues(N);
Mike Stump1eb44332009-09-09 15:08:12 +0000647
Ted Kremenek31061982009-03-31 23:00:32 +0000648 if (const Stmt *S = End.asStmt())
649 End = PDB.getEnclosingStmtLocation(S);
Mike Stump1eb44332009-09-09 15:08:12 +0000650
Ted Kremenek31061982009-03-31 23:00:32 +0000651 PD.push_front(new PathDiagnosticControlFlowPiece(Start, End,
652 os.str()));
653 break;
654 }
Mike Stump1eb44332009-09-09 15:08:12 +0000655
Ted Kremenek31061982009-03-31 23:00:32 +0000656 // Determine control-flow for short-circuited '&&' and '||'.
657 case Stmt::BinaryOperatorClass: {
658 if (!PDB.supportsLogicalOpControlFlow())
659 break;
Mike Stump1eb44332009-09-09 15:08:12 +0000660
Zhongxing Xu03509ae2010-07-20 06:22:24 +0000661 const BinaryOperator *B = cast<BinaryOperator>(T);
Ted Kremenek31061982009-03-31 23:00:32 +0000662 std::string sbuf;
663 llvm::raw_string_ostream os(sbuf);
664 os << "Left side of '";
Mike Stump1eb44332009-09-09 15:08:12 +0000665
John McCall2de56d12010-08-25 11:45:40 +0000666 if (B->getOpcode() == BO_LAnd) {
Ted Kremenek31061982009-03-31 23:00:32 +0000667 os << "&&" << "' is ";
Mike Stump1eb44332009-09-09 15:08:12 +0000668
Ted Kremenek31061982009-03-31 23:00:32 +0000669 if (*(Src->succ_begin()+1) == Dst) {
670 os << "false";
Anna Zaks220ac8c2011-09-15 01:08:34 +0000671 PathDiagnosticLocation End(B->getLHS(), SMgr, LC);
Anna Zaks0cd59482011-09-16 19:18:30 +0000672 PathDiagnosticLocation Start =
673 PathDiagnosticLocation::createOperatorLoc(B, SMgr);
Ted Kremenek31061982009-03-31 23:00:32 +0000674 PD.push_front(new PathDiagnosticControlFlowPiece(Start, End,
675 os.str()));
Mike Stump1eb44332009-09-09 15:08:12 +0000676 }
Ted Kremenek31061982009-03-31 23:00:32 +0000677 else {
678 os << "true";
Anna Zaks220ac8c2011-09-15 01:08:34 +0000679 PathDiagnosticLocation Start(B->getLHS(), SMgr, LC);
Ted Kremenek31061982009-03-31 23:00:32 +0000680 PathDiagnosticLocation End = PDB.ExecutionContinues(N);
681 PD.push_front(new PathDiagnosticControlFlowPiece(Start, End,
682 os.str()));
Mike Stump1eb44332009-09-09 15:08:12 +0000683 }
Ted Kremenek31061982009-03-31 23:00:32 +0000684 }
685 else {
John McCall2de56d12010-08-25 11:45:40 +0000686 assert(B->getOpcode() == BO_LOr);
Ted Kremenek31061982009-03-31 23:00:32 +0000687 os << "||" << "' is ";
Mike Stump1eb44332009-09-09 15:08:12 +0000688
Ted Kremenek31061982009-03-31 23:00:32 +0000689 if (*(Src->succ_begin()+1) == Dst) {
690 os << "false";
Anna Zaks220ac8c2011-09-15 01:08:34 +0000691 PathDiagnosticLocation Start(B->getLHS(), SMgr, LC);
Ted Kremenek31061982009-03-31 23:00:32 +0000692 PathDiagnosticLocation End = PDB.ExecutionContinues(N);
693 PD.push_front(new PathDiagnosticControlFlowPiece(Start, End,
Mike Stump1eb44332009-09-09 15:08:12 +0000694 os.str()));
Ted Kremenek31061982009-03-31 23:00:32 +0000695 }
696 else {
697 os << "true";
Anna Zaks220ac8c2011-09-15 01:08:34 +0000698 PathDiagnosticLocation End(B->getLHS(), SMgr, LC);
Anna Zaks0cd59482011-09-16 19:18:30 +0000699 PathDiagnosticLocation Start =
700 PathDiagnosticLocation::createOperatorLoc(B, SMgr);
Ted Kremenek31061982009-03-31 23:00:32 +0000701 PD.push_front(new PathDiagnosticControlFlowPiece(Start, End,
Mike Stump1eb44332009-09-09 15:08:12 +0000702 os.str()));
Ted Kremenek31061982009-03-31 23:00:32 +0000703 }
704 }
Mike Stump1eb44332009-09-09 15:08:12 +0000705
Ted Kremenek31061982009-03-31 23:00:32 +0000706 break;
707 }
Mike Stump1eb44332009-09-09 15:08:12 +0000708
709 case Stmt::DoStmtClass: {
Ted Kremenek31061982009-03-31 23:00:32 +0000710 if (*(Src->succ_begin()) == Dst) {
711 std::string sbuf;
712 llvm::raw_string_ostream os(sbuf);
Mike Stump1eb44332009-09-09 15:08:12 +0000713
Ted Kremenek31061982009-03-31 23:00:32 +0000714 os << "Loop condition is true. ";
715 PathDiagnosticLocation End = PDB.ExecutionContinues(os, N);
Mike Stump1eb44332009-09-09 15:08:12 +0000716
Ted Kremenek31061982009-03-31 23:00:32 +0000717 if (const Stmt *S = End.asStmt())
718 End = PDB.getEnclosingStmtLocation(S);
Mike Stump1eb44332009-09-09 15:08:12 +0000719
Ted Kremenek31061982009-03-31 23:00:32 +0000720 PD.push_front(new PathDiagnosticControlFlowPiece(Start, End,
721 os.str()));
722 }
723 else {
724 PathDiagnosticLocation End = PDB.ExecutionContinues(N);
Mike Stump1eb44332009-09-09 15:08:12 +0000725
Ted Kremenek31061982009-03-31 23:00:32 +0000726 if (const Stmt *S = End.asStmt())
727 End = PDB.getEnclosingStmtLocation(S);
Mike Stump1eb44332009-09-09 15:08:12 +0000728
Ted Kremenek31061982009-03-31 23:00:32 +0000729 PD.push_front(new PathDiagnosticControlFlowPiece(Start, End,
730 "Loop condition is false. Exiting loop"));
731 }
Mike Stump1eb44332009-09-09 15:08:12 +0000732
Ted Kremenek31061982009-03-31 23:00:32 +0000733 break;
734 }
Mike Stump1eb44332009-09-09 15:08:12 +0000735
Ted Kremenek31061982009-03-31 23:00:32 +0000736 case Stmt::WhileStmtClass:
Mike Stump1eb44332009-09-09 15:08:12 +0000737 case Stmt::ForStmtClass: {
Ted Kremenek31061982009-03-31 23:00:32 +0000738 if (*(Src->succ_begin()+1) == Dst) {
739 std::string sbuf;
740 llvm::raw_string_ostream os(sbuf);
Mike Stump1eb44332009-09-09 15:08:12 +0000741
Ted Kremenek31061982009-03-31 23:00:32 +0000742 os << "Loop condition is false. ";
743 PathDiagnosticLocation End = PDB.ExecutionContinues(os, N);
744 if (const Stmt *S = End.asStmt())
745 End = PDB.getEnclosingStmtLocation(S);
Mike Stump1eb44332009-09-09 15:08:12 +0000746
Ted Kremenek31061982009-03-31 23:00:32 +0000747 PD.push_front(new PathDiagnosticControlFlowPiece(Start, End,
748 os.str()));
749 }
750 else {
751 PathDiagnosticLocation End = PDB.ExecutionContinues(N);
752 if (const Stmt *S = End.asStmt())
753 End = PDB.getEnclosingStmtLocation(S);
Mike Stump1eb44332009-09-09 15:08:12 +0000754
Ted Kremenek31061982009-03-31 23:00:32 +0000755 PD.push_front(new PathDiagnosticControlFlowPiece(Start, End,
Ted Kremenek5fb5dfb2009-04-01 06:13:56 +0000756 "Loop condition is true. Entering loop body"));
Ted Kremenek31061982009-03-31 23:00:32 +0000757 }
Mike Stump1eb44332009-09-09 15:08:12 +0000758
Ted Kremenek31061982009-03-31 23:00:32 +0000759 break;
760 }
Mike Stump1eb44332009-09-09 15:08:12 +0000761
Ted Kremenek31061982009-03-31 23:00:32 +0000762 case Stmt::IfStmtClass: {
763 PathDiagnosticLocation End = PDB.ExecutionContinues(N);
Mike Stump1eb44332009-09-09 15:08:12 +0000764
Ted Kremenek31061982009-03-31 23:00:32 +0000765 if (const Stmt *S = End.asStmt())
766 End = PDB.getEnclosingStmtLocation(S);
Mike Stump1eb44332009-09-09 15:08:12 +0000767
Ted Kremenek31061982009-03-31 23:00:32 +0000768 if (*(Src->succ_begin()+1) == Dst)
769 PD.push_front(new PathDiagnosticControlFlowPiece(Start, End,
Ted Kremenek5fb5dfb2009-04-01 06:13:56 +0000770 "Taking false branch"));
Mike Stump1eb44332009-09-09 15:08:12 +0000771 else
Ted Kremenek31061982009-03-31 23:00:32 +0000772 PD.push_front(new PathDiagnosticControlFlowPiece(Start, End,
Ted Kremenek5fb5dfb2009-04-01 06:13:56 +0000773 "Taking true branch"));
Mike Stump1eb44332009-09-09 15:08:12 +0000774
Ted Kremenek31061982009-03-31 23:00:32 +0000775 break;
776 }
777 }
778 }
Mike Stump1eb44332009-09-09 15:08:12 +0000779
Ted Kremenekdd986cc2009-05-07 00:45:33 +0000780 if (NextNode) {
Anna Zaks8e6431a2011-08-18 22:37:56 +0000781 // Add diagnostic pieces from custom visitors.
782 BugReport *R = PDB.getBugReport();
783 for (BugReport::visitor_iterator I = R->visitor_begin(),
784 E = R->visitor_end(); I!=E; ++I) {
785 if (PathDiagnosticPiece *p = (*I)->VisitNode(N, NextNode, PDB, *R))
Ted Kremenekdd986cc2009-05-07 00:45:33 +0000786 PD.push_front(p);
787 }
Ted Kremenek8966bc12009-05-06 21:39:49 +0000788 }
Mike Stump1eb44332009-09-09 15:08:12 +0000789
Ted Kremenek9c378f72011-08-12 23:37:29 +0000790 if (const PostStmt *PS = dyn_cast<PostStmt>(&P)) {
Ted Kremenek31061982009-03-31 23:00:32 +0000791 // Scan the region bindings, and see if a "notable" symbol has a new
792 // lval binding.
793 ScanNotableSymbols SNS(N, PS->getStmt(), PDB.getBugReporter(), PD);
794 PDB.getStateManager().iterBindings(N->getState(), SNS);
795 }
796 }
Mike Stump1eb44332009-09-09 15:08:12 +0000797
Ted Kremenek14856d72009-04-06 23:06:54 +0000798 // After constructing the full PathDiagnostic, do a pass over it to compact
799 // PathDiagnosticPieces that occur within a macro.
800 CompactPathDiagnostic(PD, PDB.getSourceManager());
Ted Kremenek31061982009-03-31 23:00:32 +0000801}
802
803//===----------------------------------------------------------------------===//
Ted Kremenek5fb5dfb2009-04-01 06:13:56 +0000804// "Extensive" PathDiagnostic generation.
805//===----------------------------------------------------------------------===//
806
807static bool IsControlFlowExpr(const Stmt *S) {
808 const Expr *E = dyn_cast<Expr>(S);
Mike Stump1eb44332009-09-09 15:08:12 +0000809
Ted Kremenek5fb5dfb2009-04-01 06:13:56 +0000810 if (!E)
811 return false;
Mike Stump1eb44332009-09-09 15:08:12 +0000812
813 E = E->IgnoreParenCasts();
814
John McCall56ca35d2011-02-17 10:25:35 +0000815 if (isa<AbstractConditionalOperator>(E))
Ted Kremenek5fb5dfb2009-04-01 06:13:56 +0000816 return true;
Mike Stump1eb44332009-09-09 15:08:12 +0000817
Ted Kremenek5fb5dfb2009-04-01 06:13:56 +0000818 if (const BinaryOperator *B = dyn_cast<BinaryOperator>(E))
819 if (B->isLogicalOp())
820 return true;
Mike Stump1eb44332009-09-09 15:08:12 +0000821
822 return false;
Ted Kremenek5fb5dfb2009-04-01 06:13:56 +0000823}
824
Ted Kremenek14856d72009-04-06 23:06:54 +0000825namespace {
Kovarththanan Rajaratnamba5fb5a2009-11-28 06:07:30 +0000826class ContextLocation : public PathDiagnosticLocation {
Ted Kremenek8f9b1b32009-05-01 16:08:09 +0000827 bool IsDead;
828public:
829 ContextLocation(const PathDiagnosticLocation &L, bool isdead = false)
830 : PathDiagnosticLocation(L), IsDead(isdead) {}
Mike Stump1eb44332009-09-09 15:08:12 +0000831
832 void markDead() { IsDead = true; }
Ted Kremenek8f9b1b32009-05-01 16:08:09 +0000833 bool isDead() const { return IsDead; }
834};
Mike Stump1eb44332009-09-09 15:08:12 +0000835
Kovarththanan Rajaratnamba5fb5a2009-11-28 06:07:30 +0000836class EdgeBuilder {
Ted Kremenek8f9b1b32009-05-01 16:08:09 +0000837 std::vector<ContextLocation> CLocs;
838 typedef std::vector<ContextLocation>::iterator iterator;
Ted Kremenek14856d72009-04-06 23:06:54 +0000839 PathDiagnostic &PD;
840 PathDiagnosticBuilder &PDB;
841 PathDiagnosticLocation PrevLoc;
Mike Stump1eb44332009-09-09 15:08:12 +0000842
Ted Kremenek8f9b1b32009-05-01 16:08:09 +0000843 bool IsConsumedExpr(const PathDiagnosticLocation &L);
Mike Stump1eb44332009-09-09 15:08:12 +0000844
Ted Kremenek14856d72009-04-06 23:06:54 +0000845 bool containsLocation(const PathDiagnosticLocation &Container,
846 const PathDiagnosticLocation &Containee);
Mike Stump1eb44332009-09-09 15:08:12 +0000847
Ted Kremenek14856d72009-04-06 23:06:54 +0000848 PathDiagnosticLocation getContextLocation(const PathDiagnosticLocation &L);
Mike Stump1eb44332009-09-09 15:08:12 +0000849
Ted Kremenek9650cf32009-05-11 21:42:34 +0000850 PathDiagnosticLocation cleanUpLocation(PathDiagnosticLocation L,
851 bool firstCharOnly = false) {
Ted Kremenek8c8b0ad2009-05-11 19:50:47 +0000852 if (const Stmt *S = L.asStmt()) {
Ted Kremenek9650cf32009-05-11 21:42:34 +0000853 const Stmt *Original = S;
Ted Kremenek8c8b0ad2009-05-11 19:50:47 +0000854 while (1) {
855 // Adjust the location for some expressions that are best referenced
856 // by one of their subexpressions.
Ted Kremenek9650cf32009-05-11 21:42:34 +0000857 switch (S->getStmtClass()) {
858 default:
859 break;
860 case Stmt::ParenExprClass:
Peter Collingbournef111d932011-04-15 00:35:48 +0000861 case Stmt::GenericSelectionExprClass:
862 S = cast<Expr>(S)->IgnoreParens();
Ted Kremenek9650cf32009-05-11 21:42:34 +0000863 firstCharOnly = true;
864 continue;
John McCall56ca35d2011-02-17 10:25:35 +0000865 case Stmt::BinaryConditionalOperatorClass:
Ted Kremenek9650cf32009-05-11 21:42:34 +0000866 case Stmt::ConditionalOperatorClass:
John McCall56ca35d2011-02-17 10:25:35 +0000867 S = cast<AbstractConditionalOperator>(S)->getCond();
Ted Kremenek9650cf32009-05-11 21:42:34 +0000868 firstCharOnly = true;
869 continue;
870 case Stmt::ChooseExprClass:
871 S = cast<ChooseExpr>(S)->getCond();
872 firstCharOnly = true;
873 continue;
874 case Stmt::BinaryOperatorClass:
875 S = cast<BinaryOperator>(S)->getLHS();
876 firstCharOnly = true;
877 continue;
878 }
Mike Stump1eb44332009-09-09 15:08:12 +0000879
Ted Kremenek9650cf32009-05-11 21:42:34 +0000880 break;
Ted Kremenek8c8b0ad2009-05-11 19:50:47 +0000881 }
Mike Stump1eb44332009-09-09 15:08:12 +0000882
Ted Kremenek9650cf32009-05-11 21:42:34 +0000883 if (S != Original)
Anna Zaks23803372011-09-20 16:23:37 +0000884 L = PathDiagnosticLocation(S, L.getManager(), PDB.getLocationContext());
Ted Kremenek8c8b0ad2009-05-11 19:50:47 +0000885 }
Mike Stump1eb44332009-09-09 15:08:12 +0000886
Ted Kremenek9650cf32009-05-11 21:42:34 +0000887 if (firstCharOnly)
Anna Zaks1531bb02011-09-20 01:38:47 +0000888 L = PathDiagnosticLocation::createSingleLocation(L);
Ted Kremenek9650cf32009-05-11 21:42:34 +0000889
Ted Kremenek8c8b0ad2009-05-11 19:50:47 +0000890 return L;
891 }
Mike Stump1eb44332009-09-09 15:08:12 +0000892
Ted Kremenek14856d72009-04-06 23:06:54 +0000893 void popLocation() {
Ted Kremenek8f9b1b32009-05-01 16:08:09 +0000894 if (!CLocs.back().isDead() && CLocs.back().asLocation().isFileID()) {
Ted Kremenek5c7168c2009-04-22 20:36:26 +0000895 // For contexts, we only one the first character as the range.
Ted Kremenek07c015c2009-05-15 02:46:13 +0000896 rawAddEdge(cleanUpLocation(CLocs.back(), true));
Ted Kremenek5c7168c2009-04-22 20:36:26 +0000897 }
Ted Kremenek14856d72009-04-06 23:06:54 +0000898 CLocs.pop_back();
899 }
Mike Stump1eb44332009-09-09 15:08:12 +0000900
Ted Kremenek14856d72009-04-06 23:06:54 +0000901public:
902 EdgeBuilder(PathDiagnostic &pd, PathDiagnosticBuilder &pdb)
903 : PD(pd), PDB(pdb) {
Mike Stump1eb44332009-09-09 15:08:12 +0000904
Ted Kremeneka301a672009-04-22 18:16:20 +0000905 // If the PathDiagnostic already has pieces, add the enclosing statement
906 // of the first piece as a context as well.
Ted Kremenek14856d72009-04-06 23:06:54 +0000907 if (!PD.empty()) {
908 PrevLoc = PD.begin()->getLocation();
Mike Stump1eb44332009-09-09 15:08:12 +0000909
Ted Kremenek14856d72009-04-06 23:06:54 +0000910 if (const Stmt *S = PrevLoc.asStmt())
Ted Kremeneke1baed32009-05-05 23:13:38 +0000911 addExtendedContext(PDB.getEnclosingStmtLocation(S).asStmt());
Ted Kremenek14856d72009-04-06 23:06:54 +0000912 }
913 }
914
915 ~EdgeBuilder() {
916 while (!CLocs.empty()) popLocation();
Anna Zaks0cd59482011-09-16 19:18:30 +0000917
Ted Kremeneka301a672009-04-22 18:16:20 +0000918 // Finally, add an initial edge from the start location of the first
919 // statement (if it doesn't already exist).
Anna Zaks0cd59482011-09-16 19:18:30 +0000920 PathDiagnosticLocation L = PathDiagnosticLocation::createDeclBegin(
921 PDB.getLocationContext(),
922 PDB.getSourceManager());
923 if (L.isValid())
924 rawAddEdge(L);
Ted Kremenek14856d72009-04-06 23:06:54 +0000925 }
926
927 void addEdge(PathDiagnosticLocation NewLoc, bool alwaysAdd = false);
Mike Stump1eb44332009-09-09 15:08:12 +0000928
Ted Kremenek8bd4d032009-04-28 04:23:15 +0000929 void rawAddEdge(PathDiagnosticLocation NewLoc);
Mike Stump1eb44332009-09-09 15:08:12 +0000930
Ted Kremenek14856d72009-04-06 23:06:54 +0000931 void addContext(const Stmt *S);
Ted Kremeneke1baed32009-05-05 23:13:38 +0000932 void addExtendedContext(const Stmt *S);
Mike Stump1eb44332009-09-09 15:08:12 +0000933};
Ted Kremenek14856d72009-04-06 23:06:54 +0000934} // end anonymous namespace
935
936
937PathDiagnosticLocation
938EdgeBuilder::getContextLocation(const PathDiagnosticLocation &L) {
939 if (const Stmt *S = L.asStmt()) {
940 if (IsControlFlowExpr(S))
941 return L;
Mike Stump1eb44332009-09-09 15:08:12 +0000942
943 return PDB.getEnclosingStmtLocation(S);
Ted Kremenek14856d72009-04-06 23:06:54 +0000944 }
Mike Stump1eb44332009-09-09 15:08:12 +0000945
Ted Kremenek14856d72009-04-06 23:06:54 +0000946 return L;
947}
948
949bool EdgeBuilder::containsLocation(const PathDiagnosticLocation &Container,
950 const PathDiagnosticLocation &Containee) {
951
952 if (Container == Containee)
953 return true;
Mike Stump1eb44332009-09-09 15:08:12 +0000954
Ted Kremenek14856d72009-04-06 23:06:54 +0000955 if (Container.asDecl())
956 return true;
Mike Stump1eb44332009-09-09 15:08:12 +0000957
Ted Kremenek14856d72009-04-06 23:06:54 +0000958 if (const Stmt *S = Containee.asStmt())
959 if (const Stmt *ContainerS = Container.asStmt()) {
960 while (S) {
961 if (S == ContainerS)
962 return true;
963 S = PDB.getParent(S);
964 }
965 return false;
966 }
967
968 // Less accurate: compare using source ranges.
969 SourceRange ContainerR = Container.asRange();
970 SourceRange ContaineeR = Containee.asRange();
Mike Stump1eb44332009-09-09 15:08:12 +0000971
Ted Kremenek14856d72009-04-06 23:06:54 +0000972 SourceManager &SM = PDB.getSourceManager();
Chandler Carruth40278532011-07-25 16:49:02 +0000973 SourceLocation ContainerRBeg = SM.getExpansionLoc(ContainerR.getBegin());
974 SourceLocation ContainerREnd = SM.getExpansionLoc(ContainerR.getEnd());
975 SourceLocation ContaineeRBeg = SM.getExpansionLoc(ContaineeR.getBegin());
976 SourceLocation ContaineeREnd = SM.getExpansionLoc(ContaineeR.getEnd());
Mike Stump1eb44332009-09-09 15:08:12 +0000977
Chandler Carruth64211622011-07-25 21:09:52 +0000978 unsigned ContainerBegLine = SM.getExpansionLineNumber(ContainerRBeg);
979 unsigned ContainerEndLine = SM.getExpansionLineNumber(ContainerREnd);
980 unsigned ContaineeBegLine = SM.getExpansionLineNumber(ContaineeRBeg);
981 unsigned ContaineeEndLine = SM.getExpansionLineNumber(ContaineeREnd);
Mike Stump1eb44332009-09-09 15:08:12 +0000982
Ted Kremenek14856d72009-04-06 23:06:54 +0000983 assert(ContainerBegLine <= ContainerEndLine);
Mike Stump1eb44332009-09-09 15:08:12 +0000984 assert(ContaineeBegLine <= ContaineeEndLine);
985
Ted Kremenek14856d72009-04-06 23:06:54 +0000986 return (ContainerBegLine <= ContaineeBegLine &&
987 ContainerEndLine >= ContaineeEndLine &&
988 (ContainerBegLine != ContaineeBegLine ||
Chandler Carrutha77c0312011-07-25 20:57:57 +0000989 SM.getExpansionColumnNumber(ContainerRBeg) <=
990 SM.getExpansionColumnNumber(ContaineeRBeg)) &&
Ted Kremenek14856d72009-04-06 23:06:54 +0000991 (ContainerEndLine != ContaineeEndLine ||
Chandler Carrutha77c0312011-07-25 20:57:57 +0000992 SM.getExpansionColumnNumber(ContainerREnd) >=
993 SM.getExpansionColumnNumber(ContainerREnd)));
Ted Kremenek14856d72009-04-06 23:06:54 +0000994}
995
Ted Kremenek14856d72009-04-06 23:06:54 +0000996void EdgeBuilder::rawAddEdge(PathDiagnosticLocation NewLoc) {
997 if (!PrevLoc.isValid()) {
998 PrevLoc = NewLoc;
999 return;
1000 }
Mike Stump1eb44332009-09-09 15:08:12 +00001001
Ted Kremenek8c8b0ad2009-05-11 19:50:47 +00001002 const PathDiagnosticLocation &NewLocClean = cleanUpLocation(NewLoc);
1003 const PathDiagnosticLocation &PrevLocClean = cleanUpLocation(PrevLoc);
Mike Stump1eb44332009-09-09 15:08:12 +00001004
Ted Kremenek8c8b0ad2009-05-11 19:50:47 +00001005 if (NewLocClean.asLocation() == PrevLocClean.asLocation())
Ted Kremenek14856d72009-04-06 23:06:54 +00001006 return;
Mike Stump1eb44332009-09-09 15:08:12 +00001007
Ted Kremenek14856d72009-04-06 23:06:54 +00001008 // FIXME: Ignore intra-macro edges for now.
Chandler Carruth40278532011-07-25 16:49:02 +00001009 if (NewLocClean.asLocation().getExpansionLoc() ==
1010 PrevLocClean.asLocation().getExpansionLoc())
Ted Kremenek14856d72009-04-06 23:06:54 +00001011 return;
1012
Ted Kremenek8c8b0ad2009-05-11 19:50:47 +00001013 PD.push_front(new PathDiagnosticControlFlowPiece(NewLocClean, PrevLocClean));
1014 PrevLoc = NewLoc;
Ted Kremenek14856d72009-04-06 23:06:54 +00001015}
1016
1017void EdgeBuilder::addEdge(PathDiagnosticLocation NewLoc, bool alwaysAdd) {
Mike Stump1eb44332009-09-09 15:08:12 +00001018
Ted Kremeneka301a672009-04-22 18:16:20 +00001019 if (!alwaysAdd && NewLoc.asLocation().isMacroID())
1020 return;
Mike Stump1eb44332009-09-09 15:08:12 +00001021
Ted Kremenek14856d72009-04-06 23:06:54 +00001022 const PathDiagnosticLocation &CLoc = getContextLocation(NewLoc);
1023
1024 while (!CLocs.empty()) {
Ted Kremenek8f9b1b32009-05-01 16:08:09 +00001025 ContextLocation &TopContextLoc = CLocs.back();
Mike Stump1eb44332009-09-09 15:08:12 +00001026
Ted Kremenek14856d72009-04-06 23:06:54 +00001027 // Is the top location context the same as the one for the new location?
1028 if (TopContextLoc == CLoc) {
Ted Kremenek8f9b1b32009-05-01 16:08:09 +00001029 if (alwaysAdd) {
Ted Kremenek4c6f8d32009-05-04 18:15:17 +00001030 if (IsConsumedExpr(TopContextLoc) &&
1031 !IsControlFlowExpr(TopContextLoc.asStmt()))
Ted Kremenek8f9b1b32009-05-01 16:08:09 +00001032 TopContextLoc.markDead();
1033
Ted Kremenek14856d72009-04-06 23:06:54 +00001034 rawAddEdge(NewLoc);
Ted Kremenek8f9b1b32009-05-01 16:08:09 +00001035 }
Ted Kremenek14856d72009-04-06 23:06:54 +00001036
1037 return;
1038 }
1039
1040 if (containsLocation(TopContextLoc, CLoc)) {
Ted Kremenek8f9b1b32009-05-01 16:08:09 +00001041 if (alwaysAdd) {
Ted Kremenek14856d72009-04-06 23:06:54 +00001042 rawAddEdge(NewLoc);
Mike Stump1eb44332009-09-09 15:08:12 +00001043
Ted Kremenek4c6f8d32009-05-04 18:15:17 +00001044 if (IsConsumedExpr(CLoc) && !IsControlFlowExpr(CLoc.asStmt())) {
Ted Kremenek8f9b1b32009-05-01 16:08:09 +00001045 CLocs.push_back(ContextLocation(CLoc, true));
1046 return;
1047 }
1048 }
Mike Stump1eb44332009-09-09 15:08:12 +00001049
Ted Kremenek14856d72009-04-06 23:06:54 +00001050 CLocs.push_back(CLoc);
Mike Stump1eb44332009-09-09 15:08:12 +00001051 return;
Ted Kremenek14856d72009-04-06 23:06:54 +00001052 }
1053
1054 // Context does not contain the location. Flush it.
1055 popLocation();
1056 }
Mike Stump1eb44332009-09-09 15:08:12 +00001057
Ted Kremenek5c7168c2009-04-22 20:36:26 +00001058 // If we reach here, there is no enclosing context. Just add the edge.
1059 rawAddEdge(NewLoc);
Ted Kremenek14856d72009-04-06 23:06:54 +00001060}
1061
Ted Kremenek8f9b1b32009-05-01 16:08:09 +00001062bool EdgeBuilder::IsConsumedExpr(const PathDiagnosticLocation &L) {
1063 if (const Expr *X = dyn_cast_or_null<Expr>(L.asStmt()))
1064 return PDB.getParentMap().isConsumedExpr(X) && !IsControlFlowExpr(X);
Mike Stump1eb44332009-09-09 15:08:12 +00001065
Ted Kremenek8f9b1b32009-05-01 16:08:09 +00001066 return false;
1067}
Mike Stump1eb44332009-09-09 15:08:12 +00001068
Ted Kremeneke1baed32009-05-05 23:13:38 +00001069void EdgeBuilder::addExtendedContext(const Stmt *S) {
1070 if (!S)
1071 return;
Mike Stump1eb44332009-09-09 15:08:12 +00001072
1073 const Stmt *Parent = PDB.getParent(S);
Ted Kremeneke1baed32009-05-05 23:13:38 +00001074 while (Parent) {
1075 if (isa<CompoundStmt>(Parent))
1076 Parent = PDB.getParent(Parent);
1077 else
1078 break;
1079 }
1080
1081 if (Parent) {
1082 switch (Parent->getStmtClass()) {
1083 case Stmt::DoStmtClass:
1084 case Stmt::ObjCAtSynchronizedStmtClass:
1085 addContext(Parent);
1086 default:
1087 break;
1088 }
1089 }
Mike Stump1eb44332009-09-09 15:08:12 +00001090
Ted Kremeneke1baed32009-05-05 23:13:38 +00001091 addContext(S);
1092}
Mike Stump1eb44332009-09-09 15:08:12 +00001093
Ted Kremenek14856d72009-04-06 23:06:54 +00001094void EdgeBuilder::addContext(const Stmt *S) {
1095 if (!S)
1096 return;
1097
Anna Zaks220ac8c2011-09-15 01:08:34 +00001098 PathDiagnosticLocation L(S, PDB.getSourceManager(), PDB.getLocationContext());
Mike Stump1eb44332009-09-09 15:08:12 +00001099
Ted Kremenek14856d72009-04-06 23:06:54 +00001100 while (!CLocs.empty()) {
1101 const PathDiagnosticLocation &TopContextLoc = CLocs.back();
1102
1103 // Is the top location context the same as the one for the new location?
1104 if (TopContextLoc == L)
1105 return;
1106
1107 if (containsLocation(TopContextLoc, L)) {
Ted Kremenek14856d72009-04-06 23:06:54 +00001108 CLocs.push_back(L);
Mike Stump1eb44332009-09-09 15:08:12 +00001109 return;
Ted Kremenek14856d72009-04-06 23:06:54 +00001110 }
1111
1112 // Context does not contain the location. Flush it.
1113 popLocation();
1114 }
1115
1116 CLocs.push_back(L);
1117}
1118
1119static void GenerateExtensivePathDiagnostic(PathDiagnostic& PD,
1120 PathDiagnosticBuilder &PDB,
Zhongxing Xuc5619d92009-08-06 01:32:16 +00001121 const ExplodedNode *N) {
Ted Kremenek14856d72009-04-06 23:06:54 +00001122 EdgeBuilder EB(PD, PDB);
Anna Zaks0cd59482011-09-16 19:18:30 +00001123 const SourceManager& SM = PDB.getSourceManager();
Ted Kremenek14856d72009-04-06 23:06:54 +00001124
Ted Kremenek9c378f72011-08-12 23:37:29 +00001125 const ExplodedNode *NextNode = N->pred_empty() ? NULL : *(N->pred_begin());
Ted Kremenek14856d72009-04-06 23:06:54 +00001126 while (NextNode) {
1127 N = NextNode;
1128 NextNode = GetPredecessorNode(N);
1129 ProgramPoint P = N->getLocation();
1130
Ted Kremenekdd986cc2009-05-07 00:45:33 +00001131 do {
1132 // Block edges.
1133 if (const BlockEdge *BE = dyn_cast<BlockEdge>(&P)) {
1134 const CFGBlock &Blk = *BE->getSrc();
1135 const Stmt *Term = Blk.getTerminator();
Mike Stump1eb44332009-09-09 15:08:12 +00001136
Ted Kremenekdd986cc2009-05-07 00:45:33 +00001137 // Are we jumping to the head of a loop? Add a special diagnostic.
Ted Kremenekddb7bab2009-05-15 01:50:15 +00001138 if (const Stmt *Loop = BE->getDst()->getLoopTarget()) {
Anna Zaks0cd59482011-09-16 19:18:30 +00001139 PathDiagnosticLocation L(Loop, SM, PDB.getLocationContext());
Ted Kremenekddb7bab2009-05-15 01:50:15 +00001140 const CompoundStmt *CS = NULL;
Mike Stump1eb44332009-09-09 15:08:12 +00001141
Ted Kremenekddb7bab2009-05-15 01:50:15 +00001142 if (!Term) {
1143 if (const ForStmt *FS = dyn_cast<ForStmt>(Loop))
1144 CS = dyn_cast<CompoundStmt>(FS->getBody());
1145 else if (const WhileStmt *WS = dyn_cast<WhileStmt>(Loop))
Mike Stump1eb44332009-09-09 15:08:12 +00001146 CS = dyn_cast<CompoundStmt>(WS->getBody());
Ted Kremenekddb7bab2009-05-15 01:50:15 +00001147 }
Mike Stump1eb44332009-09-09 15:08:12 +00001148
Ted Kremenekdd986cc2009-05-07 00:45:33 +00001149 PathDiagnosticEventPiece *p =
1150 new PathDiagnosticEventPiece(L,
Ted Kremenek07c015c2009-05-15 02:46:13 +00001151 "Looping back to the head of the loop");
Mike Stump1eb44332009-09-09 15:08:12 +00001152
Ted Kremenekdd986cc2009-05-07 00:45:33 +00001153 EB.addEdge(p->getLocation(), true);
1154 PD.push_front(p);
Mike Stump1eb44332009-09-09 15:08:12 +00001155
Ted Kremenekddb7bab2009-05-15 01:50:15 +00001156 if (CS) {
Anna Zaks0cd59482011-09-16 19:18:30 +00001157 PathDiagnosticLocation BL =
1158 PathDiagnosticLocation::createEndBrace(CS, SM);
Ted Kremenek07c015c2009-05-15 02:46:13 +00001159 EB.addEdge(BL);
Ted Kremenekdd986cc2009-05-07 00:45:33 +00001160 }
Ted Kremenek8bd4d032009-04-28 04:23:15 +00001161 }
Mike Stump1eb44332009-09-09 15:08:12 +00001162
Ted Kremenekddb7bab2009-05-15 01:50:15 +00001163 if (Term)
1164 EB.addContext(Term);
Mike Stump1eb44332009-09-09 15:08:12 +00001165
Ted Kremenekdd986cc2009-05-07 00:45:33 +00001166 break;
Ted Kremenek14856d72009-04-06 23:06:54 +00001167 }
1168
Mike Stump1eb44332009-09-09 15:08:12 +00001169 if (const BlockEntrance *BE = dyn_cast<BlockEntrance>(&P)) {
Ted Kremenek3c0349e2011-03-01 03:15:10 +00001170 if (const CFGStmt *S = BE->getFirstElement().getAs<CFGStmt>()) {
1171 const Stmt *stmt = S->getStmt();
1172 if (IsControlFlowExpr(stmt)) {
Zhongxing Xub36cd3e2010-09-16 01:25:47 +00001173 // Add the proper context for '&&', '||', and '?'.
Ted Kremenek3c0349e2011-03-01 03:15:10 +00001174 EB.addContext(stmt);
Zhongxing Xub36cd3e2010-09-16 01:25:47 +00001175 }
1176 else
Ted Kremenek3c0349e2011-03-01 03:15:10 +00001177 EB.addExtendedContext(PDB.getEnclosingStmtLocation(stmt).asStmt());
Ted Kremenekdd986cc2009-05-07 00:45:33 +00001178 }
Zhongxing Xub36cd3e2010-09-16 01:25:47 +00001179
Ted Kremenekdd986cc2009-05-07 00:45:33 +00001180 break;
1181 }
1182 } while (0);
Mike Stump1eb44332009-09-09 15:08:12 +00001183
Ted Kremenekdd986cc2009-05-07 00:45:33 +00001184 if (!NextNode)
Ted Kremenek14856d72009-04-06 23:06:54 +00001185 continue;
Mike Stump1eb44332009-09-09 15:08:12 +00001186
Anna Zaks8e6431a2011-08-18 22:37:56 +00001187 // Add pieces from custom visitors.
1188 BugReport *R = PDB.getBugReport();
1189 for (BugReport::visitor_iterator I = R->visitor_begin(),
1190 E = R->visitor_end(); I!=E; ++I) {
1191 if (PathDiagnosticPiece *p = (*I)->VisitNode(N, NextNode, PDB, *R)) {
Ted Kremenek8966bc12009-05-06 21:39:49 +00001192 const PathDiagnosticLocation &Loc = p->getLocation();
1193 EB.addEdge(Loc, true);
1194 PD.push_front(p);
1195 if (const Stmt *S = Loc.asStmt())
Mike Stump1eb44332009-09-09 15:08:12 +00001196 EB.addExtendedContext(PDB.getEnclosingStmtLocation(S).asStmt());
Ted Kremenek8966bc12009-05-06 21:39:49 +00001197 }
Mike Stump1eb44332009-09-09 15:08:12 +00001198 }
Ted Kremenek14856d72009-04-06 23:06:54 +00001199 }
1200}
1201
Ted Kremenek5fb5dfb2009-04-01 06:13:56 +00001202//===----------------------------------------------------------------------===//
Ted Kremenekcf118d42009-02-04 23:49:09 +00001203// Methods for BugType and subclasses.
1204//===----------------------------------------------------------------------===//
Argyrios Kyrtzidis404fc3a2011-02-23 00:16:01 +00001205BugType::~BugType() { }
1206
Ted Kremenekcf118d42009-02-04 23:49:09 +00001207void BugType::FlushReports(BugReporter &BR) {}
Ted Kremenekbb77e9b2008-05-01 22:50:36 +00001208
David Blaikie99ba9e32011-12-20 02:48:34 +00001209void BuiltinBug::anchor() {}
1210
Ted Kremenekcf118d42009-02-04 23:49:09 +00001211//===----------------------------------------------------------------------===//
1212// Methods for BugReport and subclasses.
1213//===----------------------------------------------------------------------===//
Anna Zakse172e8b2011-08-17 23:00:25 +00001214
David Blaikie99ba9e32011-12-20 02:48:34 +00001215void BugReport::NodeResolver::anchor() {}
1216
Anna Zaks8e6431a2011-08-18 22:37:56 +00001217void BugReport::addVisitor(BugReporterVisitor* visitor) {
1218 if (!visitor)
1219 return;
1220
1221 llvm::FoldingSetNodeID ID;
1222 visitor->Profile(ID);
1223 void *InsertPos;
1224
1225 if (CallbacksSet.FindNodeOrInsertPos(ID, InsertPos)) {
1226 delete visitor;
1227 return;
1228 }
1229
1230 CallbacksSet.InsertNode(visitor, InsertPos);
1231 Callbacks = F.add(visitor, Callbacks);
1232}
1233
1234BugReport::~BugReport() {
1235 for (visitor_iterator I = visitor_begin(), E = visitor_end(); I != E; ++I) {
Anna Zaksdc757b02011-08-19 23:21:56 +00001236 delete *I;
Anna Zaks8e6431a2011-08-18 22:37:56 +00001237 }
1238}
Anna Zakse172e8b2011-08-17 23:00:25 +00001239
1240void BugReport::Profile(llvm::FoldingSetNodeID& hash) const {
1241 hash.AddPointer(&BT);
Anna Zakse172e8b2011-08-17 23:00:25 +00001242 hash.AddString(Description);
Anna Zaks590dd8e2011-09-20 21:38:35 +00001243 if (Location.isValid()) {
1244 Location.Profile(hash);
1245 } else {
1246 assert(ErrorNode);
1247 hash.AddPointer(GetCurrentOrPreviousStmt(ErrorNode));
1248 }
Anna Zakse172e8b2011-08-17 23:00:25 +00001249
1250 for (SmallVectorImpl<SourceRange>::const_iterator I =
1251 Ranges.begin(), E = Ranges.end(); I != E; ++I) {
1252 const SourceRange range = *I;
1253 if (!range.isValid())
1254 continue;
1255 hash.AddInteger(range.getBegin().getRawEncoding());
1256 hash.AddInteger(range.getEnd().getRawEncoding());
1257 }
1258}
Ted Kremenekcf118d42009-02-04 23:49:09 +00001259
Ted Kremenek9c378f72011-08-12 23:37:29 +00001260const Stmt *BugReport::getStmt() const {
Anna Zakse172e8b2011-08-17 23:00:25 +00001261 if (!ErrorNode)
1262 return 0;
1263
Tom Care212f6d32010-09-16 03:50:38 +00001264 ProgramPoint ProgP = ErrorNode->getLocation();
Ted Kremenek5f85e172009-07-22 22:35:28 +00001265 const Stmt *S = NULL;
Mike Stump1eb44332009-09-09 15:08:12 +00001266
Ted Kremenek9c378f72011-08-12 23:37:29 +00001267 if (BlockEntrance *BE = dyn_cast<BlockEntrance>(&ProgP)) {
Zhongxing Xufafd3832009-08-20 01:23:34 +00001268 CFGBlock &Exit = ProgP.getLocationContext()->getCFG()->getExit();
Zhongxing Xu50d5bc42009-08-18 08:46:04 +00001269 if (BE->getBlock() == &Exit)
Tom Care212f6d32010-09-16 03:50:38 +00001270 S = GetPreviousStmt(ErrorNode);
Ted Kremenekcf118d42009-02-04 23:49:09 +00001271 }
Ted Kremenek5f85e172009-07-22 22:35:28 +00001272 if (!S)
Mike Stump1eb44332009-09-09 15:08:12 +00001273 S = GetStmt(ProgP);
1274
1275 return S;
Ted Kremenekbb77e9b2008-05-01 22:50:36 +00001276}
1277
Argyrios Kyrtzidis640ccf02010-12-04 01:12:15 +00001278std::pair<BugReport::ranges_iterator, BugReport::ranges_iterator>
Anna Zakse172e8b2011-08-17 23:00:25 +00001279BugReport::getRanges() {
1280 // If no custom ranges, add the range of the statement corresponding to
1281 // the error node.
1282 if (Ranges.empty()) {
1283 if (const Expr *E = dyn_cast_or_null<Expr>(getStmt()))
1284 addRange(E->getSourceRange());
1285 else
1286 return std::make_pair(ranges_iterator(), ranges_iterator());
1287 }
1288
Anna Zaks14924262011-08-24 20:31:06 +00001289 // User-specified absence of range info.
1290 if (Ranges.size() == 1 && !Ranges.begin()->isValid())
1291 return std::make_pair(ranges_iterator(), ranges_iterator());
1292
Anna Zakse172e8b2011-08-17 23:00:25 +00001293 return std::make_pair(Ranges.begin(), Ranges.end());
Ted Kremenekf1ae7052008-04-03 17:57:38 +00001294}
1295
Anna Zaks590dd8e2011-09-20 21:38:35 +00001296PathDiagnosticLocation BugReport::getLocation(const SourceManager &SM) const {
Anna Zaksb7530a42011-08-17 23:21:23 +00001297 if (ErrorNode) {
Anna Zaks590dd8e2011-09-20 21:38:35 +00001298 assert(!Location.isValid() &&
Anna Zaksb7530a42011-08-17 23:21:23 +00001299 "Either Location or ErrorNode should be specified but not both.");
1300
Ted Kremenek9c378f72011-08-12 23:37:29 +00001301 if (const Stmt *S = GetCurrentOrPreviousStmt(ErrorNode)) {
Anna Zaks590dd8e2011-09-20 21:38:35 +00001302 const LocationContext *LC = ErrorNode->getLocationContext();
1303
Ted Kremenek9b5e5052009-02-27 20:05:10 +00001304 // For member expressions, return the location of the '.' or '->'.
Ted Kremenek5b9bd212009-09-11 22:07:28 +00001305 if (const MemberExpr *ME = dyn_cast<MemberExpr>(S))
Anna Zaks590dd8e2011-09-20 21:38:35 +00001306 return PathDiagnosticLocation::createMemberLoc(ME, SM);
Ted Kremenek5b9bd212009-09-11 22:07:28 +00001307 // For binary operators, return the location of the operator.
1308 if (const BinaryOperator *B = dyn_cast<BinaryOperator>(S))
Anna Zaks590dd8e2011-09-20 21:38:35 +00001309 return PathDiagnosticLocation::createOperatorLoc(B, SM);
Ted Kremenek9b5e5052009-02-27 20:05:10 +00001310
Anna Zaks590dd8e2011-09-20 21:38:35 +00001311 return PathDiagnosticLocation::createBegin(S, SM, LC);
Ted Kremenek9b5e5052009-02-27 20:05:10 +00001312 }
Anna Zaksb7530a42011-08-17 23:21:23 +00001313 } else {
1314 assert(Location.isValid());
1315 return Location;
1316 }
1317
Anna Zaks590dd8e2011-09-20 21:38:35 +00001318 return PathDiagnosticLocation();
Ted Kremenekd2f642b2008-04-14 17:39:48 +00001319}
1320
Ted Kremenekcf118d42009-02-04 23:49:09 +00001321//===----------------------------------------------------------------------===//
1322// Methods for BugReporter and subclasses.
1323//===----------------------------------------------------------------------===//
1324
1325BugReportEquivClass::~BugReportEquivClass() {
Ted Kremenek8966bc12009-05-06 21:39:49 +00001326 for (iterator I=begin(), E=end(); I!=E; ++I) delete *I;
Ted Kremenekcf118d42009-02-04 23:49:09 +00001327}
1328
Zhongxing Xua2f4ec02009-09-05 06:06:49 +00001329GRBugReporter::~GRBugReporter() { }
Ted Kremenekcf118d42009-02-04 23:49:09 +00001330BugReporterData::~BugReporterData() {}
1331
Zhongxing Xu38b02b92009-08-06 06:28:40 +00001332ExplodedGraph &GRBugReporter::getGraph() { return Eng.getGraph(); }
Ted Kremenekcf118d42009-02-04 23:49:09 +00001333
Ted Kremenek18c66fd2011-08-15 22:09:50 +00001334ProgramStateManager&
Ted Kremenekcf118d42009-02-04 23:49:09 +00001335GRBugReporter::getStateManager() { return Eng.getStateManager(); }
1336
Anna Zaks3b030a22011-08-19 01:57:09 +00001337BugReporter::~BugReporter() {
1338 FlushReports();
1339
1340 // Free the bug reports we are tracking.
1341 typedef std::vector<BugReportEquivClass *> ContTy;
1342 for (ContTy::iterator I = EQClassesVector.begin(), E = EQClassesVector.end();
1343 I != E; ++I) {
1344 delete *I;
1345 }
1346}
Ted Kremenekcf118d42009-02-04 23:49:09 +00001347
1348void BugReporter::FlushReports() {
1349 if (BugTypes.isEmpty())
1350 return;
1351
1352 // First flush the warnings for each BugType. This may end up creating new
Argyrios Kyrtzidis404fc3a2011-02-23 00:16:01 +00001353 // warnings and new BugTypes.
1354 // FIXME: Only NSErrorChecker needs BugType's FlushReports.
1355 // Turn NSErrorChecker into a proper checker and remove this.
Chris Lattner5f9e2722011-07-23 10:55:15 +00001356 SmallVector<const BugType*, 16> bugTypes;
Ted Kremenekcf118d42009-02-04 23:49:09 +00001357 for (BugTypesTy::iterator I=BugTypes.begin(), E=BugTypes.end(); I!=E; ++I)
Argyrios Kyrtzidis404fc3a2011-02-23 00:16:01 +00001358 bugTypes.push_back(*I);
Chris Lattner5f9e2722011-07-23 10:55:15 +00001359 for (SmallVector<const BugType*, 16>::iterator
Argyrios Kyrtzidis404fc3a2011-02-23 00:16:01 +00001360 I = bugTypes.begin(), E = bugTypes.end(); I != E; ++I)
Ted Kremenekcf118d42009-02-04 23:49:09 +00001361 const_cast<BugType*>(*I)->FlushReports(*this);
1362
Argyrios Kyrtzidis404fc3a2011-02-23 00:16:01 +00001363 typedef llvm::FoldingSet<BugReportEquivClass> SetTy;
1364 for (SetTy::iterator EI=EQClasses.begin(), EE=EQClasses.end(); EI!=EE;++EI){
1365 BugReportEquivClass& EQ = *EI;
1366 FlushReport(EQ);
Ted Kremenek94826a72008-04-03 04:59:14 +00001367 }
Ted Kremenekcf118d42009-02-04 23:49:09 +00001368
Argyrios Kyrtzidis404fc3a2011-02-23 00:16:01 +00001369 // BugReporter owns and deletes only BugTypes created implicitly through
1370 // EmitBasicReport.
1371 // FIXME: There are leaks from checkers that assume that the BugTypes they
1372 // create will be destroyed by the BugReporter.
1373 for (llvm::StringMap<BugType*>::iterator
1374 I = StrBugTypes.begin(), E = StrBugTypes.end(); I != E; ++I)
1375 delete I->second;
1376
Ted Kremenekcf118d42009-02-04 23:49:09 +00001377 // Remove all references to the BugType objects.
Ted Kremenek3baf6722010-11-24 00:54:37 +00001378 BugTypes = F.getEmptySet();
Ted Kremenekcf118d42009-02-04 23:49:09 +00001379}
1380
1381//===----------------------------------------------------------------------===//
1382// PathDiagnostics generation.
1383//===----------------------------------------------------------------------===//
1384
Zhongxing Xu38b02b92009-08-06 06:28:40 +00001385static std::pair<std::pair<ExplodedGraph*, NodeBackMap*>,
Zhongxing Xuc5619d92009-08-06 01:32:16 +00001386 std::pair<ExplodedNode*, unsigned> >
Zhongxing Xu38b02b92009-08-06 06:28:40 +00001387MakeReportGraph(const ExplodedGraph* G,
Chris Lattner5f9e2722011-07-23 10:55:15 +00001388 SmallVectorImpl<const ExplodedNode*> &nodes) {
Mike Stump1eb44332009-09-09 15:08:12 +00001389
Ted Kremenekcf118d42009-02-04 23:49:09 +00001390 // Create the trimmed graph. It will contain the shortest paths from the
Mike Stump1eb44332009-09-09 15:08:12 +00001391 // error nodes to the root. In the new graph we should only have one
Ted Kremenekcf118d42009-02-04 23:49:09 +00001392 // error node unless there are two or more error nodes with the same minimum
1393 // path length.
Zhongxing Xu38b02b92009-08-06 06:28:40 +00001394 ExplodedGraph* GTrim;
Zhongxing Xuc5619d92009-08-06 01:32:16 +00001395 InterExplodedGraphMap* NMap;
Ted Kremenekfe9e5432009-02-18 03:48:14 +00001396
1397 llvm::DenseMap<const void*, const void*> InverseMap;
Ted Kremenek40406fe2010-12-03 06:52:30 +00001398 llvm::tie(GTrim, NMap) = G->Trim(nodes.data(), nodes.data() + nodes.size(),
1399 &InverseMap);
Mike Stump1eb44332009-09-09 15:08:12 +00001400
Ted Kremenekcf118d42009-02-04 23:49:09 +00001401 // Create owning pointers for GTrim and NMap just to ensure that they are
1402 // released when this function exists.
Zhongxing Xu38b02b92009-08-06 06:28:40 +00001403 llvm::OwningPtr<ExplodedGraph> AutoReleaseGTrim(GTrim);
Zhongxing Xuc5619d92009-08-06 01:32:16 +00001404 llvm::OwningPtr<InterExplodedGraphMap> AutoReleaseNMap(NMap);
Mike Stump1eb44332009-09-09 15:08:12 +00001405
Ted Kremenekcf118d42009-02-04 23:49:09 +00001406 // Find the (first) error node in the trimmed graph. We just need to consult
1407 // the node map (NMap) which maps from nodes in the original graph to nodes
1408 // in the new graph.
Ted Kremenek938332c2009-05-16 01:11:58 +00001409
Zhongxing Xuc5619d92009-08-06 01:32:16 +00001410 std::queue<const ExplodedNode*> WS;
Zhongxing Xu38b02b92009-08-06 06:28:40 +00001411 typedef llvm::DenseMap<const ExplodedNode*, unsigned> IndexMapTy;
Ted Kremenek938332c2009-05-16 01:11:58 +00001412 IndexMapTy IndexMap;
Ted Kremenekcf118d42009-02-04 23:49:09 +00001413
Ted Kremenek40406fe2010-12-03 06:52:30 +00001414 for (unsigned nodeIndex = 0 ; nodeIndex < nodes.size(); ++nodeIndex) {
1415 const ExplodedNode *originalNode = nodes[nodeIndex];
1416 if (const ExplodedNode *N = NMap->getMappedNode(originalNode)) {
Ted Kremenek938332c2009-05-16 01:11:58 +00001417 WS.push(N);
Ted Kremenek40406fe2010-12-03 06:52:30 +00001418 IndexMap[originalNode] = nodeIndex;
Ted Kremenekcf118d42009-02-04 23:49:09 +00001419 }
Ted Kremenek40406fe2010-12-03 06:52:30 +00001420 }
Mike Stump1eb44332009-09-09 15:08:12 +00001421
Ted Kremenek938332c2009-05-16 01:11:58 +00001422 assert(!WS.empty() && "No error node found in the trimmed graph.");
Ted Kremenekcf118d42009-02-04 23:49:09 +00001423
1424 // Create a new (third!) graph with a single path. This is the graph
1425 // that will be returned to the caller.
Zhongxing Xuc77a5512010-07-01 07:10:59 +00001426 ExplodedGraph *GNew = new ExplodedGraph();
Mike Stump1eb44332009-09-09 15:08:12 +00001427
Ted Kremenek10aa5542009-03-12 23:41:59 +00001428 // Sometimes the trimmed graph can contain a cycle. Perform a reverse BFS
Ted Kremenek331b0ac2008-06-18 05:34:07 +00001429 // to the root node, and then construct a new graph that contains only
1430 // a single path.
Ted Kremenek3148eb42009-01-24 00:55:43 +00001431 llvm::DenseMap<const void*,unsigned> Visited;
Mike Stump1eb44332009-09-09 15:08:12 +00001432
Ted Kremenek331b0ac2008-06-18 05:34:07 +00001433 unsigned cnt = 0;
Ted Kremenek9c378f72011-08-12 23:37:29 +00001434 const ExplodedNode *Root = 0;
Mike Stump1eb44332009-09-09 15:08:12 +00001435
Ted Kremenek331b0ac2008-06-18 05:34:07 +00001436 while (!WS.empty()) {
Ted Kremenek9c378f72011-08-12 23:37:29 +00001437 const ExplodedNode *Node = WS.front();
Ted Kremenek10aa5542009-03-12 23:41:59 +00001438 WS.pop();
Mike Stump1eb44332009-09-09 15:08:12 +00001439
Ted Kremenek331b0ac2008-06-18 05:34:07 +00001440 if (Visited.find(Node) != Visited.end())
1441 continue;
Mike Stump1eb44332009-09-09 15:08:12 +00001442
Ted Kremenek331b0ac2008-06-18 05:34:07 +00001443 Visited[Node] = cnt++;
Mike Stump1eb44332009-09-09 15:08:12 +00001444
Ted Kremenek331b0ac2008-06-18 05:34:07 +00001445 if (Node->pred_empty()) {
1446 Root = Node;
1447 break;
1448 }
Mike Stump1eb44332009-09-09 15:08:12 +00001449
Zhongxing Xuc5619d92009-08-06 01:32:16 +00001450 for (ExplodedNode::const_pred_iterator I=Node->pred_begin(),
Ted Kremenek331b0ac2008-06-18 05:34:07 +00001451 E=Node->pred_end(); I!=E; ++I)
Ted Kremenek10aa5542009-03-12 23:41:59 +00001452 WS.push(*I);
Ted Kremenek331b0ac2008-06-18 05:34:07 +00001453 }
Mike Stump1eb44332009-09-09 15:08:12 +00001454
Ted Kremenek938332c2009-05-16 01:11:58 +00001455 assert(Root);
Mike Stump1eb44332009-09-09 15:08:12 +00001456
Ted Kremenek10aa5542009-03-12 23:41:59 +00001457 // Now walk from the root down the BFS path, always taking the successor
Ted Kremenek331b0ac2008-06-18 05:34:07 +00001458 // with the lowest number.
Mike Stump1eb44332009-09-09 15:08:12 +00001459 ExplodedNode *Last = 0, *First = 0;
Ted Kremenekfe9e5432009-02-18 03:48:14 +00001460 NodeBackMap *BM = new NodeBackMap();
Ted Kremenek938332c2009-05-16 01:11:58 +00001461 unsigned NodeIndex = 0;
Mike Stump1eb44332009-09-09 15:08:12 +00001462
Zhongxing Xuc5619d92009-08-06 01:32:16 +00001463 for ( const ExplodedNode *N = Root ;;) {
Ted Kremenek331b0ac2008-06-18 05:34:07 +00001464 // Lookup the number associated with the current node.
Ted Kremenek3148eb42009-01-24 00:55:43 +00001465 llvm::DenseMap<const void*,unsigned>::iterator I = Visited.find(N);
Ted Kremenek938332c2009-05-16 01:11:58 +00001466 assert(I != Visited.end());
Mike Stump1eb44332009-09-09 15:08:12 +00001467
Ted Kremenek331b0ac2008-06-18 05:34:07 +00001468 // Create the equivalent node in the new graph with the same state
1469 // and location.
Ted Kremenek9c378f72011-08-12 23:37:29 +00001470 ExplodedNode *NewN = GNew->getNode(N->getLocation(), N->getState());
Mike Stump1eb44332009-09-09 15:08:12 +00001471
Ted Kremenekfe9e5432009-02-18 03:48:14 +00001472 // Store the mapping to the original node.
1473 llvm::DenseMap<const void*, const void*>::iterator IMitr=InverseMap.find(N);
1474 assert(IMitr != InverseMap.end() && "No mapping to original node.");
Zhongxing Xuc5619d92009-08-06 01:32:16 +00001475 (*BM)[NewN] = (const ExplodedNode*) IMitr->second;
Mike Stump1eb44332009-09-09 15:08:12 +00001476
Ted Kremenek331b0ac2008-06-18 05:34:07 +00001477 // Link up the new node with the previous node.
1478 if (Last)
Ted Kremenek5fe4d9d2009-10-07 00:42:52 +00001479 NewN->addPredecessor(Last, *GNew);
Mike Stump1eb44332009-09-09 15:08:12 +00001480
Ted Kremeneka43a1eb2008-04-23 23:02:12 +00001481 Last = NewN;
Mike Stump1eb44332009-09-09 15:08:12 +00001482
Ted Kremenek331b0ac2008-06-18 05:34:07 +00001483 // Are we at the final node?
Ted Kremenek938332c2009-05-16 01:11:58 +00001484 IndexMapTy::iterator IMI =
Zhongxing Xuc5619d92009-08-06 01:32:16 +00001485 IndexMap.find((const ExplodedNode*)(IMitr->second));
Ted Kremenek938332c2009-05-16 01:11:58 +00001486 if (IMI != IndexMap.end()) {
Ted Kremenek331b0ac2008-06-18 05:34:07 +00001487 First = NewN;
Ted Kremenek938332c2009-05-16 01:11:58 +00001488 NodeIndex = IMI->second;
Ted Kremenekc1da4412008-06-17 19:14:06 +00001489 break;
Ted Kremenek331b0ac2008-06-18 05:34:07 +00001490 }
Mike Stump1eb44332009-09-09 15:08:12 +00001491
Ted Kremenek331b0ac2008-06-18 05:34:07 +00001492 // Find the next successor node. We choose the node that is marked
1493 // with the lowest DFS number.
Zhongxing Xuc5619d92009-08-06 01:32:16 +00001494 ExplodedNode::const_succ_iterator SI = N->succ_begin();
1495 ExplodedNode::const_succ_iterator SE = N->succ_end();
Ted Kremenekc1da4412008-06-17 19:14:06 +00001496 N = 0;
Mike Stump1eb44332009-09-09 15:08:12 +00001497
Ted Kremenek331b0ac2008-06-18 05:34:07 +00001498 for (unsigned MinVal = 0; SI != SE; ++SI) {
Mike Stump1eb44332009-09-09 15:08:12 +00001499
Ted Kremenek331b0ac2008-06-18 05:34:07 +00001500 I = Visited.find(*SI);
Mike Stump1eb44332009-09-09 15:08:12 +00001501
Ted Kremenek331b0ac2008-06-18 05:34:07 +00001502 if (I == Visited.end())
1503 continue;
Mike Stump1eb44332009-09-09 15:08:12 +00001504
Ted Kremenek331b0ac2008-06-18 05:34:07 +00001505 if (!N || I->second < MinVal) {
1506 N = *SI;
1507 MinVal = I->second;
Ted Kremenekc1da4412008-06-17 19:14:06 +00001508 }
Ted Kremenek331b0ac2008-06-18 05:34:07 +00001509 }
Mike Stump1eb44332009-09-09 15:08:12 +00001510
Ted Kremenek938332c2009-05-16 01:11:58 +00001511 assert(N);
Ted Kremeneka43a1eb2008-04-23 23:02:12 +00001512 }
Mike Stump1eb44332009-09-09 15:08:12 +00001513
Ted Kremenek938332c2009-05-16 01:11:58 +00001514 assert(First);
1515
Ted Kremenekfe9e5432009-02-18 03:48:14 +00001516 return std::make_pair(std::make_pair(GNew, BM),
1517 std::make_pair(First, NodeIndex));
Ted Kremeneka43a1eb2008-04-23 23:02:12 +00001518}
1519
Ted Kremenek0e5c8d42009-03-10 05:16:17 +00001520/// CompactPathDiagnostic - This function postprocesses a PathDiagnostic object
1521/// and collapses PathDiagosticPieces that are expanded by macros.
1522static void CompactPathDiagnostic(PathDiagnostic &PD, const SourceManager& SM) {
1523 typedef std::vector<std::pair<PathDiagnosticMacroPiece*, SourceLocation> >
1524 MacroStackTy;
Mike Stump1eb44332009-09-09 15:08:12 +00001525
Ted Kremenek0e5c8d42009-03-10 05:16:17 +00001526 typedef std::vector<PathDiagnosticPiece*>
1527 PiecesTy;
Mike Stump1eb44332009-09-09 15:08:12 +00001528
Ted Kremenek0e5c8d42009-03-10 05:16:17 +00001529 MacroStackTy MacroStack;
1530 PiecesTy Pieces;
Mike Stump1eb44332009-09-09 15:08:12 +00001531
Ted Kremenek0e5c8d42009-03-10 05:16:17 +00001532 for (PathDiagnostic::iterator I = PD.begin(), E = PD.end(); I!=E; ++I) {
1533 // Get the location of the PathDiagnosticPiece.
Mike Stump1eb44332009-09-09 15:08:12 +00001534 const FullSourceLoc Loc = I->getLocation().asLocation();
1535
Ted Kremenek0e5c8d42009-03-10 05:16:17 +00001536 // Determine the instantiation location, which is the location we group
1537 // related PathDiagnosticPieces.
Mike Stump1eb44332009-09-09 15:08:12 +00001538 SourceLocation InstantiationLoc = Loc.isMacroID() ?
Chandler Carruth40278532011-07-25 16:49:02 +00001539 SM.getExpansionLoc(Loc) :
Ted Kremenek0e5c8d42009-03-10 05:16:17 +00001540 SourceLocation();
Mike Stump1eb44332009-09-09 15:08:12 +00001541
Ted Kremenek0e5c8d42009-03-10 05:16:17 +00001542 if (Loc.isFileID()) {
1543 MacroStack.clear();
1544 Pieces.push_back(&*I);
1545 continue;
1546 }
1547
1548 assert(Loc.isMacroID());
Mike Stump1eb44332009-09-09 15:08:12 +00001549
Ted Kremenek0e5c8d42009-03-10 05:16:17 +00001550 // Is the PathDiagnosticPiece within the same macro group?
1551 if (!MacroStack.empty() && InstantiationLoc == MacroStack.back().second) {
1552 MacroStack.back().first->push_back(&*I);
1553 continue;
1554 }
1555
1556 // We aren't in the same group. Are we descending into a new macro
1557 // or are part of an old one?
1558 PathDiagnosticMacroPiece *MacroGroup = 0;
1559
1560 SourceLocation ParentInstantiationLoc = InstantiationLoc.isMacroID() ?
Chandler Carruth40278532011-07-25 16:49:02 +00001561 SM.getExpansionLoc(Loc) :
Ted Kremenek0e5c8d42009-03-10 05:16:17 +00001562 SourceLocation();
Mike Stump1eb44332009-09-09 15:08:12 +00001563
Ted Kremenek0e5c8d42009-03-10 05:16:17 +00001564 // Walk the entire macro stack.
1565 while (!MacroStack.empty()) {
1566 if (InstantiationLoc == MacroStack.back().second) {
1567 MacroGroup = MacroStack.back().first;
1568 break;
1569 }
Mike Stump1eb44332009-09-09 15:08:12 +00001570
Ted Kremenek0e5c8d42009-03-10 05:16:17 +00001571 if (ParentInstantiationLoc == MacroStack.back().second) {
1572 MacroGroup = MacroStack.back().first;
1573 break;
1574 }
Mike Stump1eb44332009-09-09 15:08:12 +00001575
Ted Kremenek0e5c8d42009-03-10 05:16:17 +00001576 MacroStack.pop_back();
1577 }
Mike Stump1eb44332009-09-09 15:08:12 +00001578
Ted Kremenek0e5c8d42009-03-10 05:16:17 +00001579 if (!MacroGroup || ParentInstantiationLoc == MacroStack.back().second) {
1580 // Create a new macro group and add it to the stack.
Anna Zaks590dd8e2011-09-20 21:38:35 +00001581 PathDiagnosticMacroPiece *NewGroup =
1582 new PathDiagnosticMacroPiece(
1583 PathDiagnosticLocation::createSingleLocation(I->getLocation()));
Ted Kremenek0e5c8d42009-03-10 05:16:17 +00001584
1585 if (MacroGroup)
1586 MacroGroup->push_back(NewGroup);
1587 else {
1588 assert(InstantiationLoc.isFileID());
1589 Pieces.push_back(NewGroup);
1590 }
Mike Stump1eb44332009-09-09 15:08:12 +00001591
Ted Kremenek0e5c8d42009-03-10 05:16:17 +00001592 MacroGroup = NewGroup;
1593 MacroStack.push_back(std::make_pair(MacroGroup, InstantiationLoc));
1594 }
1595
1596 // Finally, add the PathDiagnosticPiece to the group.
1597 MacroGroup->push_back(&*I);
1598 }
Mike Stump1eb44332009-09-09 15:08:12 +00001599
Ted Kremenek0e5c8d42009-03-10 05:16:17 +00001600 // Now take the pieces and construct a new PathDiagnostic.
1601 PD.resetPath(false);
Mike Stump1eb44332009-09-09 15:08:12 +00001602
Ted Kremenek0e5c8d42009-03-10 05:16:17 +00001603 for (PiecesTy::iterator I=Pieces.begin(), E=Pieces.end(); I!=E; ++I) {
1604 if (PathDiagnosticMacroPiece *MP=dyn_cast<PathDiagnosticMacroPiece>(*I))
1605 if (!MP->containsEvent()) {
1606 delete MP;
1607 continue;
1608 }
Mike Stump1eb44332009-09-09 15:08:12 +00001609
Ted Kremenek0e5c8d42009-03-10 05:16:17 +00001610 PD.push_back(*I);
1611 }
1612}
1613
Ted Kremenek7dc86642009-03-31 20:22:36 +00001614void GRBugReporter::GeneratePathDiagnostic(PathDiagnostic& PD,
Chris Lattner5f9e2722011-07-23 10:55:15 +00001615 SmallVectorImpl<BugReport *> &bugReports) {
Mike Stump1eb44332009-09-09 15:08:12 +00001616
Ted Kremenek40406fe2010-12-03 06:52:30 +00001617 assert(!bugReports.empty());
Chris Lattner5f9e2722011-07-23 10:55:15 +00001618 SmallVector<const ExplodedNode *, 10> errorNodes;
1619 for (SmallVectorImpl<BugReport*>::iterator I = bugReports.begin(),
Ted Kremenek40406fe2010-12-03 06:52:30 +00001620 E = bugReports.end(); I != E; ++I) {
1621 errorNodes.push_back((*I)->getErrorNode());
1622 }
Mike Stump1eb44332009-09-09 15:08:12 +00001623
Ted Kremeneka43a1eb2008-04-23 23:02:12 +00001624 // Construct a new graph that contains only a single path from the error
Mike Stump1eb44332009-09-09 15:08:12 +00001625 // node to a root.
Zhongxing Xu38b02b92009-08-06 06:28:40 +00001626 const std::pair<std::pair<ExplodedGraph*, NodeBackMap*>,
Zhongxing Xuc5619d92009-08-06 01:32:16 +00001627 std::pair<ExplodedNode*, unsigned> >&
Ted Kremenek40406fe2010-12-03 06:52:30 +00001628 GPair = MakeReportGraph(&getGraph(), errorNodes);
Mike Stump1eb44332009-09-09 15:08:12 +00001629
Ted Kremenekcf118d42009-02-04 23:49:09 +00001630 // Find the BugReport with the original location.
Ted Kremenek40406fe2010-12-03 06:52:30 +00001631 assert(GPair.second.second < bugReports.size());
1632 BugReport *R = bugReports[GPair.second.second];
Ted Kremenekcf118d42009-02-04 23:49:09 +00001633 assert(R && "No original report found for sliced graph.");
Mike Stump1eb44332009-09-09 15:08:12 +00001634
Zhongxing Xu38b02b92009-08-06 06:28:40 +00001635 llvm::OwningPtr<ExplodedGraph> ReportGraph(GPair.first.first);
Ted Kremenekfe9e5432009-02-18 03:48:14 +00001636 llvm::OwningPtr<NodeBackMap> BackMap(GPair.first.second);
Zhongxing Xuc5619d92009-08-06 01:32:16 +00001637 const ExplodedNode *N = GPair.second.first;
Mike Stump1eb44332009-09-09 15:08:12 +00001638
1639 // Start building the path diagnostic...
David Blaikieef3643f2011-09-26 00:51:36 +00001640 PathDiagnosticBuilder PDB(*this, R, BackMap.get(),
1641 getPathDiagnosticConsumer());
Mike Stump1eb44332009-09-09 15:08:12 +00001642
Anna Zaks8e6431a2011-08-18 22:37:56 +00001643 // Register additional node visitors.
Anna Zaks50bbc162011-08-19 22:33:38 +00001644 R->addVisitor(new NilReceiverBRVisitor());
1645 R->addVisitor(new ConditionBRVisitor());
Mike Stump1eb44332009-09-09 15:08:12 +00001646
Anna Zaks23f395e2011-08-20 01:27:22 +00001647 // Generate the very last diagnostic piece - the piece is visible before
1648 // the trace is expanded.
1649 PathDiagnosticPiece *LastPiece = 0;
1650 for (BugReport::visitor_iterator I = R->visitor_begin(),
1651 E = R->visitor_end(); I!=E; ++I) {
1652 if (PathDiagnosticPiece *Piece = (*I)->getEndPath(PDB, N, *R)) {
1653 assert (!LastPiece &&
1654 "There can only be one final piece in a diagnostic.");
1655 LastPiece = Piece;
1656 }
1657 }
1658 if (!LastPiece)
1659 LastPiece = BugReporterVisitor::getDefaultEndPath(PDB, N, *R);
1660 if (LastPiece)
1661 PD.push_back(LastPiece);
1662 else
1663 return;
1664
Ted Kremenek7dc86642009-03-31 20:22:36 +00001665 switch (PDB.getGenerationScheme()) {
David Blaikieef3643f2011-09-26 00:51:36 +00001666 case PathDiagnosticConsumer::Extensive:
Ted Kremenek8966bc12009-05-06 21:39:49 +00001667 GenerateExtensivePathDiagnostic(PD, PDB, N);
Ted Kremenek5fb5dfb2009-04-01 06:13:56 +00001668 break;
David Blaikieef3643f2011-09-26 00:51:36 +00001669 case PathDiagnosticConsumer::Minimal:
Ted Kremenek7dc86642009-03-31 20:22:36 +00001670 GenerateMinimalPathDiagnostic(PD, PDB, N);
1671 break;
1672 }
Ted Kremenek7dc86642009-03-31 20:22:36 +00001673}
1674
Ted Kremenekcf118d42009-02-04 23:49:09 +00001675void BugReporter::Register(BugType *BT) {
Ted Kremenek3baf6722010-11-24 00:54:37 +00001676 BugTypes = F.add(BugTypes, BT);
Ted Kremenek76d90c82008-05-16 18:33:14 +00001677}
1678
Mike Stump1eb44332009-09-09 15:08:12 +00001679void BugReporter::EmitReport(BugReport* R) {
Ted Kremenekcf118d42009-02-04 23:49:09 +00001680 // Compute the bug report's hash to determine its equivalence class.
1681 llvm::FoldingSetNodeID ID;
1682 R->Profile(ID);
Mike Stump1eb44332009-09-09 15:08:12 +00001683
1684 // Lookup the equivance class. If there isn't one, create it.
Ted Kremenekcf118d42009-02-04 23:49:09 +00001685 BugType& BT = R->getBugType();
1686 Register(&BT);
1687 void *InsertPos;
Argyrios Kyrtzidis404fc3a2011-02-23 00:16:01 +00001688 BugReportEquivClass* EQ = EQClasses.FindNodeOrInsertPos(ID, InsertPos);
Mike Stump1eb44332009-09-09 15:08:12 +00001689
Ted Kremenekcf118d42009-02-04 23:49:09 +00001690 if (!EQ) {
1691 EQ = new BugReportEquivClass(R);
Argyrios Kyrtzidis404fc3a2011-02-23 00:16:01 +00001692 EQClasses.InsertNode(EQ, InsertPos);
Anna Zaks3b030a22011-08-19 01:57:09 +00001693 EQClassesVector.push_back(EQ);
Ted Kremenekcf118d42009-02-04 23:49:09 +00001694 }
1695 else
1696 EQ->AddReport(R);
Ted Kremenek61f3e052008-04-03 04:42:52 +00001697}
1698
Ted Kremenek06c9cb42009-09-14 22:01:32 +00001699
1700//===----------------------------------------------------------------------===//
1701// Emitting reports in equivalence classes.
1702//===----------------------------------------------------------------------===//
1703
1704namespace {
Kovarththanan Rajaratnamba5fb5a2009-11-28 06:07:30 +00001705struct FRIEC_WLItem {
Ted Kremenek06c9cb42009-09-14 22:01:32 +00001706 const ExplodedNode *N;
1707 ExplodedNode::const_succ_iterator I, E;
1708
1709 FRIEC_WLItem(const ExplodedNode *n)
1710 : N(n), I(N->succ_begin()), E(N->succ_end()) {}
1711};
1712}
1713
Ted Kremenek61f52bd2010-09-09 19:05:34 +00001714static BugReport *
1715FindReportInEquivalenceClass(BugReportEquivClass& EQ,
Chris Lattner5f9e2722011-07-23 10:55:15 +00001716 SmallVectorImpl<BugReport*> &bugReports) {
Ted Kremenek61f52bd2010-09-09 19:05:34 +00001717
Ted Kremenek06c9cb42009-09-14 22:01:32 +00001718 BugReportEquivClass::iterator I = EQ.begin(), E = EQ.end();
1719 assert(I != E);
1720 BugReport *R = *I;
1721 BugType& BT = R->getBugType();
Ted Kremenek61f52bd2010-09-09 19:05:34 +00001722
Ted Kremenek40406fe2010-12-03 06:52:30 +00001723 // If we don't need to suppress any of the nodes because they are
1724 // post-dominated by a sink, simply add all the nodes in the equivalence class
1725 // to 'Nodes'. Any of the reports will serve as a "representative" report.
Ted Kremenek61f52bd2010-09-09 19:05:34 +00001726 if (!BT.isSuppressOnSink()) {
1727 for (BugReportEquivClass::iterator I=EQ.begin(), E=EQ.end(); I!=E; ++I) {
Ted Kremenek9c378f72011-08-12 23:37:29 +00001728 const ExplodedNode *N = I->getErrorNode();
Ted Kremenek61f52bd2010-09-09 19:05:34 +00001729 if (N) {
1730 R = *I;
Ted Kremenek40406fe2010-12-03 06:52:30 +00001731 bugReports.push_back(R);
Ted Kremenek61f52bd2010-09-09 19:05:34 +00001732 }
1733 }
Ted Kremenek06c9cb42009-09-14 22:01:32 +00001734 return R;
Ted Kremenek61f52bd2010-09-09 19:05:34 +00001735 }
1736
Ted Kremenek06c9cb42009-09-14 22:01:32 +00001737 // For bug reports that should be suppressed when all paths are post-dominated
1738 // by a sink node, iterate through the reports in the equivalence class
1739 // until we find one that isn't post-dominated (if one exists). We use a
1740 // DFS traversal of the ExplodedGraph to find a non-sink node. We could write
1741 // this as a recursive function, but we don't want to risk blowing out the
1742 // stack for very long paths.
Ted Kremenek40406fe2010-12-03 06:52:30 +00001743 BugReport *exampleReport = 0;
Ted Kremenek61f52bd2010-09-09 19:05:34 +00001744
Ted Kremenek06c9cb42009-09-14 22:01:32 +00001745 for (; I != E; ++I) {
1746 R = *I;
Ted Kremenek40406fe2010-12-03 06:52:30 +00001747 const ExplodedNode *errorNode = R->getErrorNode();
Ted Kremenek06c9cb42009-09-14 22:01:32 +00001748
Ted Kremenek40406fe2010-12-03 06:52:30 +00001749 if (!errorNode)
Ted Kremenek06c9cb42009-09-14 22:01:32 +00001750 continue;
Ted Kremenek40406fe2010-12-03 06:52:30 +00001751 if (errorNode->isSink()) {
David Blaikieb219cfc2011-09-23 05:06:16 +00001752 llvm_unreachable(
Ted Kremenek06c9cb42009-09-14 22:01:32 +00001753 "BugType::isSuppressSink() should not be 'true' for sink end nodes");
Ted Kremenek06c9cb42009-09-14 22:01:32 +00001754 }
Ted Kremenek61f52bd2010-09-09 19:05:34 +00001755 // No successors? By definition this nodes isn't post-dominated by a sink.
Ted Kremenek40406fe2010-12-03 06:52:30 +00001756 if (errorNode->succ_empty()) {
1757 bugReports.push_back(R);
1758 if (!exampleReport)
1759 exampleReport = R;
Ted Kremenek61f52bd2010-09-09 19:05:34 +00001760 continue;
1761 }
1762
Ted Kremenek06c9cb42009-09-14 22:01:32 +00001763 // At this point we know that 'N' is not a sink and it has at least one
1764 // successor. Use a DFS worklist to find a non-sink end-of-path node.
1765 typedef FRIEC_WLItem WLItem;
Chris Lattner5f9e2722011-07-23 10:55:15 +00001766 typedef SmallVector<WLItem, 10> DFSWorkList;
Ted Kremenek06c9cb42009-09-14 22:01:32 +00001767 llvm::DenseMap<const ExplodedNode *, unsigned> Visited;
1768
1769 DFSWorkList WL;
Ted Kremenek40406fe2010-12-03 06:52:30 +00001770 WL.push_back(errorNode);
1771 Visited[errorNode] = 1;
Ted Kremenek06c9cb42009-09-14 22:01:32 +00001772
1773 while (!WL.empty()) {
1774 WLItem &WI = WL.back();
1775 assert(!WI.N->succ_empty());
1776
1777 for (; WI.I != WI.E; ++WI.I) {
1778 const ExplodedNode *Succ = *WI.I;
1779 // End-of-path node?
1780 if (Succ->succ_empty()) {
Ted Kremenek61f52bd2010-09-09 19:05:34 +00001781 // If we found an end-of-path node that is not a sink.
1782 if (!Succ->isSink()) {
Ted Kremenek40406fe2010-12-03 06:52:30 +00001783 bugReports.push_back(R);
1784 if (!exampleReport)
1785 exampleReport = R;
Ted Kremenek61f52bd2010-09-09 19:05:34 +00001786 WL.clear();
1787 break;
1788 }
Ted Kremenek06c9cb42009-09-14 22:01:32 +00001789 // Found a sink? Continue on to the next successor.
1790 continue;
1791 }
Ted Kremenek06c9cb42009-09-14 22:01:32 +00001792 // Mark the successor as visited. If it hasn't been explored,
1793 // enqueue it to the DFS worklist.
1794 unsigned &mark = Visited[Succ];
1795 if (!mark) {
1796 mark = 1;
1797 WL.push_back(Succ);
1798 break;
1799 }
1800 }
Ted Kremenek61f52bd2010-09-09 19:05:34 +00001801
1802 // The worklist may have been cleared at this point. First
1803 // check if it is empty before checking the last item.
1804 if (!WL.empty() && &WL.back() == &WI)
Ted Kremenek06c9cb42009-09-14 22:01:32 +00001805 WL.pop_back();
1806 }
1807 }
Ted Kremenek06c9cb42009-09-14 22:01:32 +00001808
Ted Kremenek61f52bd2010-09-09 19:05:34 +00001809 // ExampleReport will be NULL if all the nodes in the equivalence class
1810 // were post-dominated by sinks.
Ted Kremenek40406fe2010-12-03 06:52:30 +00001811 return exampleReport;
Ted Kremenek61f52bd2010-09-09 19:05:34 +00001812}
Ted Kremeneke0a58072009-09-18 22:37:37 +00001813
1814//===----------------------------------------------------------------------===//
1815// DiagnosticCache. This is a hack to cache analyzer diagnostics. It
1816// uses global state, which eventually should go elsewhere.
1817//===----------------------------------------------------------------------===//
1818namespace {
Kovarththanan Rajaratnamba5fb5a2009-11-28 06:07:30 +00001819class DiagCacheItem : public llvm::FoldingSetNode {
Ted Kremeneke0a58072009-09-18 22:37:37 +00001820 llvm::FoldingSetNodeID ID;
1821public:
1822 DiagCacheItem(BugReport *R, PathDiagnostic *PD) {
Anna Zaks4522e2a2011-09-19 23:44:31 +00001823 R->Profile(ID);
1824 PD->Profile(ID);
Ted Kremeneke0a58072009-09-18 22:37:37 +00001825 }
1826
1827 void Profile(llvm::FoldingSetNodeID &id) {
1828 id = ID;
1829 }
1830
1831 llvm::FoldingSetNodeID &getID() { return ID; }
1832};
1833}
1834
1835static bool IsCachedDiagnostic(BugReport *R, PathDiagnostic *PD) {
1836 // FIXME: Eventually this diagnostic cache should reside in something
1837 // like AnalysisManager instead of being a static variable. This is
1838 // really unsafe in the long term.
1839 typedef llvm::FoldingSet<DiagCacheItem> DiagnosticCache;
1840 static DiagnosticCache DC;
1841
1842 void *InsertPos;
1843 DiagCacheItem *Item = new DiagCacheItem(R, PD);
1844
1845 if (DC.FindNodeOrInsertPos(Item->getID(), InsertPos)) {
1846 delete Item;
1847 return true;
1848 }
1849
1850 DC.InsertNode(Item, InsertPos);
1851 return false;
1852}
1853
Ted Kremenekcf118d42009-02-04 23:49:09 +00001854void BugReporter::FlushReport(BugReportEquivClass& EQ) {
Chris Lattner5f9e2722011-07-23 10:55:15 +00001855 SmallVector<BugReport*, 10> bugReports;
Ted Kremenek40406fe2010-12-03 06:52:30 +00001856 BugReport *exampleReport = FindReportInEquivalenceClass(EQ, bugReports);
1857 if (!exampleReport)
Ted Kremenek06c9cb42009-09-14 22:01:32 +00001858 return;
1859
David Blaikieef3643f2011-09-26 00:51:36 +00001860 PathDiagnosticConsumer* PD = getPathDiagnosticConsumer();
Mike Stump1eb44332009-09-09 15:08:12 +00001861
Ted Kremenekcf118d42009-02-04 23:49:09 +00001862 // FIXME: Make sure we use the 'R' for the path that was actually used.
Mike Stump1eb44332009-09-09 15:08:12 +00001863 // Probably doesn't make a difference in practice.
Ted Kremenek40406fe2010-12-03 06:52:30 +00001864 BugType& BT = exampleReport->getBugType();
Mike Stump1eb44332009-09-09 15:08:12 +00001865
Ted Kremenekd49967f2009-04-29 21:58:13 +00001866 llvm::OwningPtr<PathDiagnostic>
Ted Kremenek40406fe2010-12-03 06:52:30 +00001867 D(new PathDiagnostic(exampleReport->getBugType().getName(),
Ted Kremenekda0e8422009-04-29 22:05:03 +00001868 !PD || PD->useVerboseDescription()
Ted Kremenek40406fe2010-12-03 06:52:30 +00001869 ? exampleReport->getDescription()
1870 : exampleReport->getShortDescription(),
Ted Kremenekd49967f2009-04-29 21:58:13 +00001871 BT.getCategory()));
1872
Ted Kremenek40406fe2010-12-03 06:52:30 +00001873 if (!bugReports.empty())
1874 GeneratePathDiagnostic(*D.get(), bugReports);
Mike Stump1eb44332009-09-09 15:08:12 +00001875
Ted Kremenek40406fe2010-12-03 06:52:30 +00001876 if (IsCachedDiagnostic(exampleReport, D.get()))
Ted Kremeneke0a58072009-09-18 22:37:37 +00001877 return;
1878
Ted Kremenek072192b2008-04-30 23:47:44 +00001879 // Get the meta data.
Anna Zaks7f2531c2011-08-22 20:31:28 +00001880 const BugReport::ExtraTextList &Meta =
1881 exampleReport->getExtraText();
1882 for (BugReport::ExtraTextList::const_iterator i = Meta.begin(),
1883 e = Meta.end(); i != e; ++i) {
1884 D->addMeta(*i);
1885 }
Ted Kremenek75840e12008-04-18 01:56:37 +00001886
Ted Kremenek3148eb42009-01-24 00:55:43 +00001887 // Emit a summary diagnostic to the regular Diagnostics engine.
Argyrios Kyrtzidis640ccf02010-12-04 01:12:15 +00001888 BugReport::ranges_iterator Beg, End;
1889 llvm::tie(Beg, End) = exampleReport->getRanges();
David Blaikied6471f72011-09-25 23:23:43 +00001890 DiagnosticsEngine &Diag = getDiagnostic();
Ted Kremenekc213b482010-01-15 07:56:51 +00001891
1892 // Search the description for '%', as that will be interpretted as a
1893 // format character by FormatDiagnostics.
Chris Lattner5f9e2722011-07-23 10:55:15 +00001894 StringRef desc = exampleReport->getShortDescription();
Ted Kremenekc213b482010-01-15 07:56:51 +00001895 unsigned ErrorDiag;
1896 {
1897 llvm::SmallString<512> TmpStr;
1898 llvm::raw_svector_ostream Out(TmpStr);
Chris Lattner5f9e2722011-07-23 10:55:15 +00001899 for (StringRef::iterator I=desc.begin(), E=desc.end(); I!=E; ++I)
Ted Kremenekc213b482010-01-15 07:56:51 +00001900 if (*I == '%')
1901 Out << "%%";
1902 else
1903 Out << *I;
1904
1905 Out.flush();
David Blaikied6471f72011-09-25 23:23:43 +00001906 ErrorDiag = Diag.getCustomDiagID(DiagnosticsEngine::Warning, TmpStr);
Ted Kremenekc213b482010-01-15 07:56:51 +00001907 }
Ted Kremenek57202072008-07-14 17:40:50 +00001908
Argyrios Kyrtzidisb6b7e7b2010-12-03 00:58:10 +00001909 {
Anna Zaks590dd8e2011-09-20 21:38:35 +00001910 DiagnosticBuilder diagBuilder = Diag.Report(
1911 exampleReport->getLocation(getSourceManager()).asLocation(), ErrorDiag);
Argyrios Kyrtzidis640ccf02010-12-04 01:12:15 +00001912 for (BugReport::ranges_iterator I = Beg; I != End; ++I)
Argyrios Kyrtzidisb6b7e7b2010-12-03 00:58:10 +00001913 diagBuilder << *I;
Ted Kremenek2f0e89e2008-04-18 22:56:53 +00001914 }
Ted Kremenek3148eb42009-01-24 00:55:43 +00001915
David Blaikieef3643f2011-09-26 00:51:36 +00001916 // Emit a full diagnostic for the path if we have a PathDiagnosticConsumer.
Ted Kremenek3148eb42009-01-24 00:55:43 +00001917 if (!PD)
1918 return;
Mike Stump1eb44332009-09-09 15:08:12 +00001919
1920 if (D->empty()) {
Anna Zaks590dd8e2011-09-20 21:38:35 +00001921 PathDiagnosticPiece *piece = new PathDiagnosticEventPiece(
1922 exampleReport->getLocation(getSourceManager()),
1923 exampleReport->getDescription());
Ted Kremenek1fbfd5b2009-03-06 23:58:11 +00001924
Ted Kremenek3148eb42009-01-24 00:55:43 +00001925 for ( ; Beg != End; ++Beg) piece->addRange(*Beg);
1926 D->push_back(piece);
1927 }
Mike Stump1eb44332009-09-09 15:08:12 +00001928
Ted Kremenek3148eb42009-01-24 00:55:43 +00001929 PD->HandlePathDiagnostic(D.take());
Ted Kremenek61f3e052008-04-03 04:42:52 +00001930}
Ted Kremenek57202072008-07-14 17:40:50 +00001931
Chris Lattner5f9e2722011-07-23 10:55:15 +00001932void BugReporter::EmitBasicReport(StringRef name, StringRef str,
Anna Zaks590dd8e2011-09-20 21:38:35 +00001933 PathDiagnosticLocation Loc,
Ted Kremenek8c036c72008-09-20 04:23:38 +00001934 SourceRange* RBeg, unsigned NumRanges) {
1935 EmitBasicReport(name, "", str, Loc, RBeg, NumRanges);
1936}
Ted Kremenekcf118d42009-02-04 23:49:09 +00001937
Chris Lattner5f9e2722011-07-23 10:55:15 +00001938void BugReporter::EmitBasicReport(StringRef name,
1939 StringRef category,
Anna Zaks590dd8e2011-09-20 21:38:35 +00001940 StringRef str, PathDiagnosticLocation Loc,
Ted Kremenek8c036c72008-09-20 04:23:38 +00001941 SourceRange* RBeg, unsigned NumRanges) {
Mike Stump1eb44332009-09-09 15:08:12 +00001942
Argyrios Kyrtzidis404fc3a2011-02-23 00:16:01 +00001943 // 'BT' is owned by BugReporter.
1944 BugType *BT = getBugTypeForName(name, category);
Anna Zaks590dd8e2011-09-20 21:38:35 +00001945 BugReport *R = new BugReport(*BT, str, Loc);
Ted Kremenekcf118d42009-02-04 23:49:09 +00001946 for ( ; NumRanges > 0 ; --NumRanges, ++RBeg) R->addRange(*RBeg);
1947 EmitReport(R);
Ted Kremenek57202072008-07-14 17:40:50 +00001948}
Argyrios Kyrtzidis404fc3a2011-02-23 00:16:01 +00001949
Chris Lattner5f9e2722011-07-23 10:55:15 +00001950BugType *BugReporter::getBugTypeForName(StringRef name,
1951 StringRef category) {
Argyrios Kyrtzidis404fc3a2011-02-23 00:16:01 +00001952 llvm::SmallString<136> fullDesc;
1953 llvm::raw_svector_ostream(fullDesc) << name << ":" << category;
1954 llvm::StringMapEntry<BugType *> &
1955 entry = StrBugTypes.GetOrCreateValue(fullDesc);
1956 BugType *BT = entry.getValue();
1957 if (!BT) {
1958 BT = new BugType(name, category);
1959 entry.setValue(BT);
1960 }
1961 return BT;
1962}